#instantbird log on 08 04 2014

All times are UTC.

00:25:37 <-- mali has quit (Ping timeout)
00:54:45 <-- Armada has quit (Connection reset by peer)
01:32:30 <clokep> flo: I still don't get the InstantbirdDebug folder
01:57:44 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
02:12:00 <instant-buildbot> build #2293 of macosx-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2293
03:14:51 <instant-buildbot> build #1117 of linux-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1117
04:02:41 <instant-buildbot> build #12 of linux64-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/12
04:07:08 <instant-buildbot> build #1470 of win32-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1470
04:07:19 --> gerard-majax__ has joined #instantbird
04:21:40 <-- Rym has quit (Ping timeout)
04:50:33 --> Rym has joined #instantbird
04:52:39 <-- Rym has quit (Ping timeout)
04:59:37 <-- gerard-majax__ has quit (Ping timeout)
05:00:10 --> Rym has joined #instantbird
05:26:30 --> nhnt11 has joined #instantbird
05:29:05 <-- EionRobb has quit (Quit: Leaving.)
05:46:19 * Fallen|away is now known as Fallen
05:46:37 --> sonny has joined #instantbird
05:53:31 <-- sonny has quit (Ping timeout)
06:07:55 --> gerard-majax__ has joined #instantbird
06:16:59 <-- Rym has quit (Ping timeout)
06:25:50 <-- gerard-majax__ has quit (Ping timeout)
06:52:41 --> Rym has joined #instantbird
06:54:45 <-- Rym has quit (Ping timeout)
07:04:37 --> jb has joined #instantbird
07:04:44 <-- jb has quit (Input/output error)
07:05:42 --> jb has joined #instantbird
07:18:08 --> ens0 has joined #instantbird
07:19:42 <-- nhnt11 has quit (Ping timeout)
07:20:50 <-- jb has quit (Quit: jb)
07:25:23 --> mpmc has joined #instantbird
07:32:34 --> jb has joined #instantbird
07:35:55 --> sonny has joined #instantbird
07:40:36 <-- ens0 has quit (Quit: Quitte)
07:46:33 --> gerard-majax__ has joined #instantbird
07:46:50 --> Rym has joined #instantbird
07:48:53 <-- Rym has quit (Ping timeout)
07:50:58 --> Rym has joined #instantbird
07:52:58 <-- Rym has quit (Ping timeout)
08:04:11 --> nhnt11 has joined #instantbird
08:08:41 <-- sonny has quit (Ping timeout)
08:08:44 --> flo-retina has joined #instantbird
08:08:44 * ChanServ sets mode +qo flo-retina flo-retina 
08:09:00 --> sonny has joined #instantbird
08:09:15 <flo-retina> clokep: have you applied the patch from bug 1047702 ?
08:09:19 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1047702 cri, --, ---, iann_bugzilla, ASSI, recursivemake's scan for Makefiles with XPI_PKGNAME or INSTALL_EXTENSION_ID should take account of c
08:13:20 <-- sonny has quit (Ping timeout)
08:17:16 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
08:17:50 --> chrisccoulson has joined #instantbird
08:22:39 <nhnt11> flo-retina: Services.prefs.clearUserPref would work for a pref set from code too right?
08:22:50 <nhnt11> A pref set from code, that isn't in all-instantbird.js (the pending files pref)
08:23:09 <flo-retina> yes
08:23:14 <nhnt11> Thanks
08:23:28 <flo-retina> I'm not completely sure of the meaning of the question
08:23:38 <flo-retina> because I don't see a way to set a user pref without using code to set it
08:24:09 <nhnt11> flo-retina: I thought a "user pref" might mean something the user added manually, using the context menu in about:config
08:24:30 <flo-retina> ok
08:24:30 <nhnt11> Anyway, that's cleared up now
08:24:37 <flo-retina> it means a non default vlaue
08:24:38 <flo-retina> *value
08:24:43 <nhnt11> ah, okay
08:24:54 <flo-retina> clearUserPref will revert to the value in all-instantbird.js, or remove the pref if it had no default value
08:27:34 --> sonny has joined #instantbird
08:29:42 --> aleth has joined #instantbird
08:29:42 * ChanServ sets mode +o aleth 
08:36:16 <nhnt11> aleth: "What exactly happens if the assumption is wrong? Should it throw if it's not true?" (context: the assumption is that indexAllLogs is called at startup) How do we check if the assumption is wrong?
08:36:36 <aleth> I think I made a suggestion in my comments
08:37:02 <nhnt11> aleth: You suggested we throw if the assumption is wrong, but I don't know how to check if it was called at startup or not.
08:37:02 <aleth> i.e. make that method private and call it from an init method
08:37:11 <nhnt11> Maybe I haven't read that part yet
08:37:14 <nhnt11> Oh, I see it now
08:37:29 <nhnt11> Never mind
08:40:13 --> Bollebib has joined #instantbird
08:45:05 --> Rym has joined #instantbird
08:47:17 <-- Rym has quit (Ping timeout)
08:54:04 <nhnt11> aleth: Thanks for catching the case where a particular day has mixed txt/json logs. I think this should take care of it: http://pastebin.instantbird.com/796855
08:54:12 <nhnt11> Wrong link, sorry. http://pastebin.instantbird.com/796866
08:55:09 --> Rym has joined #instantbird
08:55:47 <aleth> Yes, that looks like it will work at first glance
08:56:41 <nhnt11> aleth: Did you have a name better than "getLogArray" in mind?
08:57:00 <nhnt11> getLogFolderEntries?
08:57:09 <-- Rym has quit (Ping timeout)
08:59:28 <aleth> OK
09:02:01 <nhnt11> aleth: So I don't have a strong opinion on the question of passing around imILog instances when forEach is called in the all-logs case.
09:02:48 <flo-retina> we may have a nightly on all OSes next night
09:03:14 <nhnt11> Indeed we would save some overhead by not wrapping it in an imILog instance.
09:03:21 <flo-retina> before it breaks again. FYI incoming bustage is bug 1035599, but should give us more build stability long term :)
09:03:23 <nhnt11> Btw, do you agree that "processLogsCallback" could use a better name?
09:03:24 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1035599 nor, --, ---, Pidgeot18, ASSI, Pseudo-merge m-c and c-c's objdir
09:03:36 <aleth> The point is a path is a string and doesn't need as much wrapping iirc.
09:03:45 <aleth> And less memory ;)
09:04:03 <aleth> So if the only use case for the all-logs case only needs a path, I'd say go with that.
09:04:38 <aleth> flo-retina: That's interesting :)
09:04:40 <-- nhnt11 has quit (Input/output error)
09:05:42 <flo-retina> ah, Joshua fixed the SDK version https://hg.mozilla.org/comm-central/rev/e78232714abc :)
09:08:46 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:08:59 --> nhnt11 has joined #instantbird
09:09:39 * nhnt11 wants to be able to delete his accounts again
09:10:01 <aleth> Why can't you delete accounts?
09:10:21 <nhnt11> aleth: bug 1044172
09:10:23 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1044172 nor, --, ---, clokep, ASSI, [Regression] Error "aJID.trim is not a function" when deleting XMPP account
09:11:01 <aleth> Ah, it's just waiting for the tree to reopen.
09:11:13 <nhnt11> yeah
09:11:23 <aleth> The current multi-bustage has really been painful all round for c-c work. At least it should be over soon :)
09:11:38 <nhnt11> If we're having nightlies tonight, any chance we can get permission to land that beforehand?
09:12:47 <aleth> It touches chat/ so probably not. But keep an eye on tbpl, if TB goes green you could ask Standard8 if you really want it
09:13:19 <-- nhnt11 has quit (Ping timeout)
09:13:27 <aleth> We're still waiting on the next m-i to m-c merge currently.
09:20:33 --> nhnt11 has joined #instantbird
09:26:03 --> Rym has joined #instantbird
09:28:09 <-- Rym has quit (Ping timeout)
09:36:04 <-- nhnt11 has quit (Ping timeout)
09:37:21 --> nhnt11 has joined #instantbird
09:39:08 <-- nhnt11 has quit (Ping timeout)
09:40:43 --> nhnt11 has joined #instantbird
09:42:28 <-- nhnt11 has quit (Ping timeout)
09:42:52 --> nhnt11 has joined #instantbird
09:45:54 <-- nhnt11 has quit (Ping timeout)
09:59:46 <-- sonny has quit (Ping timeout)
10:05:10 --> flo-retina has joined #instantbird
10:05:10 * ChanServ sets mode +qo flo-retina flo-retina 
10:06:49 --> sonny has joined #instantbird
10:08:09 <aleth> flo-retina: Am I actually correct in my assumption that strings aren't wrapped when passed across XPCOM as they are passed by value?
10:11:11 <flo-retina> aleth: I don't know
10:20:14 --> Rym has joined #instantbird
10:21:59 <-- aleth has quit (Ping timeout)
10:22:14 <-- Rym has quit (Ping timeout)
10:22:26 --> Hadi has joined #instantbird
10:31:20 --> BWMerlin has joined #instantbird
10:31:28 <-- sonny has quit (Ping timeout)
10:34:19 --> Armada has joined #instantbird
10:45:53 <-- Bollebib has quit (Client exited)
10:47:17 --> sonny has joined #instantbird
10:48:26 --> Hadi1 has joined #instantbird
10:48:39 <-- Hadi has quit (Ping timeout)
10:54:11 --> aleth has joined #instantbird
10:54:11 * ChanServ sets mode +o aleth 
10:54:51 --> Hadi has joined #instantbird
10:55:07 <-- Hadi1 has quit (Client exited)
11:06:49 --> Rym has joined #instantbird
11:09:30 <-- Rym has quit (Ping timeout)
11:14:18 <-- sonny has quit (Ping timeout)
11:20:15 --> sonny has joined #instantbird
11:26:58 * Fallen is now known as Fallen|away
11:33:05 --> clokep_work has joined #instantbird
11:33:05 * ChanServ sets mode +o clokep_work 
11:43:23 <-- jb has quit (Ping timeout)
11:45:34 <-- sonny has quit (Ping timeout)
11:53:47 <clokep_work> flo-retina: Bah, no. I didn't.
11:59:10 --> jb has joined #instantbird
12:01:05 --> Rym has joined #instantbird
12:03:10 <-- Rym has quit (Ping timeout)
12:12:16 <flo-retina> clokep_work: once that patch reaches m-c and I have installed the 10.7 sdk on our slave, we should have Mac nightlies again
12:16:18 <clokep_work> flo-retina: Awesome! :) WHere'd you end up getting the 10.7 SDK from?
12:17:00 <flo-retina> once [...] I have installed ...
12:17:02 <flo-retina> I haven't done it yet
12:17:08 <flo-retina> sorry for the ambiguity
12:17:30 <flo-retina> I was too tired yesterday evening to poke at that, and it didn't seem urgent given that the other fix hadn't landed yet
12:25:20 --> sonny has joined #instantbird
12:27:19 * Fallen|away is now known as Fallen
12:27:58 <-- BWMerlin has quit (Quit: BWMerlin)
12:36:03 <clokep_work> Understandable! :)
12:42:00 <-- jb has quit (Quit: jb)
12:42:13 --> jb has joined #instantbird
12:42:36 <-- sonny has quit (Ping timeout)
12:45:51 <-- jb has quit (Ping timeout)
12:48:36 --> jb has joined #instantbird
12:50:08 --> sonny has joined #instantbird
12:55:23 --> Rym has joined #instantbird
12:57:30 <-- Rym has quit (Ping timeout)
13:14:10 --> BillBinkley has joined #instantbird
13:24:15 <-- Hadi has quit (Ping timeout)
13:24:20 --> Hadi has joined #instantbird
13:32:21 --> Rym has joined #instantbird
13:34:25 <-- Rym has quit (Ping timeout)
13:37:21 <-- aleth has quit (Ping timeout)
13:50:51 * Fallen is now known as Fallen|away
14:01:43 --> aleth has joined #instantbird
14:01:43 * ChanServ sets mode +o aleth 
14:02:08 <-- jb has quit (Connection reset by peer)
14:02:12 --> jb1 has joined #instantbird
14:03:21 --> jb has joined #instantbird
14:03:52 <-- jb1 has quit (Ping timeout)
14:03:57 <-- jb has quit (Connection reset by peer)
14:04:03 --> jb has joined #instantbird
14:04:23 <-- jb has quit (Connection reset by peer)
14:04:33 --> jb has joined #instantbird
14:05:47 --> Rym has joined #instantbird
14:18:56 <-- aleth has quit (Ping timeout)
14:20:00 --> aleth has joined #instantbird
14:20:01 * ChanServ sets mode +o aleth 
14:55:33 <-- aleth has quit (Ping timeout)
15:03:33 --> aleth has joined #instantbird
15:03:34 * ChanServ sets mode +o aleth 
15:23:49 <-- Rym has quit (Ping timeout)
15:24:46 --> mayanktg has joined #instantbird
15:29:04 <mayanktg> aleth: I need some help. I moved the UI inside XBL binding. I'm able to establish the callbut the elements I have added are not visible in the conversation box :-./ http://pastebin.instantbird.com/797767 I have tried changing the z-index, display properties etc with no help. The CSS for the components is in conversation.css (its shown in DOMi too) but the localVideo, remoteVideo etc aren't visible.
15:29:29 <mayanktg> Should I share screenshot of the DOMi too?
15:30:10 <aleth> mayanktg: You're puttin the new elements as child nodes of the browser element. That's not what you want here I think.
15:30:45 <aleth> Put them above the current browser element, as children of the vbox
15:31:08 <mayanktg> aleth: Ok.
15:31:21 <aleth> Or actually even better is probably to put them above the vbox
15:34:31 <aleth> You also shouldn't use this.browser.querySelector then. Give the new elements anonymous ids and use the getAnonymousElement... methods
15:34:41 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:34:49 <mayanktg> Ok. I will change that too.
15:35:16 <aleth> And it's better to use the hidden attribute than "display".
15:36:43 <aleth> https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Property/hidden
15:40:46 <aleth> conversation.xml is full of code doing similar stuff, so you can find examples there.
15:41:18 <aleth> It also has helper functions already like http://mxr.mozilla.org/comm-central/source/im/content/conversation.xml#1670
15:41:58 <mayanktg> Yes, I found out how to use it. The elements are being displayed now. Thanks! :)
15:42:03 <aleth> Look at the default value for hidden here http://mxr.mozilla.org/comm-central/source/im/content/conversation.xml#29
15:42:10 <aleth> OK
15:43:03 <mayanktg> Yup
15:47:00 --> iamjayakumars has joined #instantbird
15:49:28 <-- mayanktg has quit (Ping timeout)
15:49:51 --> mayanktg has joined #instantbird
15:50:36 <aleth> mayanktg: Have you considered putting all the video UI in a box and then putting a splitter between that and the browser vbox? like http://mxr.mozilla.org/comm-central/source/im/content/conversation.xml#51
15:51:18 <aleth> Then the user could resize the video area
15:51:34 <mayanktg> aleth: No. Not until now. Let me try that.
15:51:51 <aleth> I'm not convinced it's a great idea, but it could be worth experimenting with to see what it looks/feels like
15:52:20 <-- sonny has quit (Ping timeout)
15:53:17 <-- mayanktg has quit (Client exited)
15:53:17 --> Bollebib has joined #instantbird
15:53:20 --> mayanktg has joined #instantbird
15:55:50 <aleth> Find out if you like it or not!
15:57:50 --> sonny has joined #instantbird
15:59:30 --> Rym has joined #instantbird
15:59:39 --> flo-retina has joined #instantbird
15:59:39 * ChanServ sets mode +qo flo-retina flo-retina 
16:01:49 <-- mayanktg has quit (Ping timeout)
16:02:13 --> mayanktg has joined #instantbird
16:02:25 <-- gerard-majax__ has quit (Ping timeout)
16:08:13 <-- mayanktg has quit (Ping timeout)
16:08:35 --> mayanktg has joined #instantbird
16:18:52 <-- mayanktg has quit (Ping timeout)
16:19:09 --> mayanktg has joined #instantbird
16:24:32 <-- sonny has quit (Ping timeout)
16:28:42 <-- mayanktg has quit (Ping timeout)
16:28:59 --> mayanktg has joined #instantbird
16:29:52 --> gerard-majax__ has joined #instantbird
16:31:38 --> qheaden has joined #instantbird
16:35:41 <-- jb has quit (Ping timeout)
16:41:28 <-- gerard-majax__ has quit (Ping timeout)
16:56:49 <-- Rym has quit (Ping timeout)
16:57:43 --> gerard-majax__ has joined #instantbird
16:58:58 <-- aleth has quit (Quit: exit stage left)
16:59:16 <-- mayanktg has quit (Ping timeout)
16:59:23 --> Rym has joined #instantbird
16:59:34 --> mayanktg has joined #instantbird
17:02:32 <-- mayanktg has quit (Client exited)
17:02:40 --> mayanktg has joined #instantbird
17:07:58 <-- gerard-majax__ has quit (Ping timeout)
17:16:24 <-- Even has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:16:30 --> Even has joined #instantbird
17:16:30 * ChanServ sets mode +o Even 
17:17:54 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
17:18:04 --> Bollebib has joined #instantbird
17:19:42 --> nhnt11 has joined #instantbird
17:22:41 <-- mayanktg has quit (Ping timeout)
17:22:57 --> mayanktg has joined #instantbird
17:23:08 --> gerard-majax__ has joined #instantbird
17:29:03 <-- mayanktg has quit (Ping timeout)
17:29:19 --> mayanktg has joined #instantbird
17:29:34 <-- iamjayakumars has quit (Quit: )
17:39:38 <-- mayanktg has quit (Ping timeout)
17:39:40 --> aleth has joined #instantbird
17:39:40 * ChanServ sets mode +o aleth 
17:39:57 --> mayanktg has joined #instantbird
17:42:04 <-- gerard-majax__ has quit (Ping timeout)
17:42:34 <-- aleth has quit (Ping timeout)
17:53:09 --> aleth has joined #instantbird
17:53:09 * ChanServ sets mode +o aleth 
17:57:08 <-- mayanktg has quit (Ping timeout)
17:57:30 --> mayanktg has joined #instantbird
18:02:31 <nhnt11> instantbot: uuid
18:02:32 <instantbot> 5f172f21-cd94-4403-808c-0a76b549f12a (/msg instantbot cid for CID form)
18:02:37 <-- mayanktg has quit (Ping timeout)
18:03:20 --> mayanktg has joined #instantbird
18:05:15 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:06:49 <-- mayanktg has quit (Ping timeout)
18:07:19 --> mayanktg has joined #instantbird
18:09:59 <-- mayanktg has quit (Ping timeout)
18:10:13 --> mayanktg has joined #instantbird
18:11:58 <-- mayanktg has quit (Ping timeout)
18:12:22 --> mayanktg has joined #instantbird
18:14:07 <-- mayanktg has quit (Ping timeout)
18:14:30 --> mayanktg has joined #instantbird
18:17:56 <-- mayanktg has quit (Ping timeout)
18:18:16 --> mayanktg has joined #instantbird
18:18:27 <nhnt11> Bah, I can't figure out why the test for number of session messages is broken :-/
18:20:35 <nhnt11> Oh, duh
18:20:51 <-- mayanktg has quit (Ping timeout)
18:21:09 --> mayanktg has joined #instantbird
18:27:35 <nhnt11> aleth: Btw, just to keep you up to speed with what I'm doing: I'm writing an indexing test at the moment.
18:27:58 <aleth> sounds good!
18:28:34 * aleth was hoping it would just need a couple of lines added to the existing test
18:28:49 <nhnt11> Yeah, shouldn't be too difficult.
18:28:57 <nhnt11> (Just getting started on it)
18:32:36 --> Hadi1 has joined #instantbird
18:32:58 <-- Hadi has quit (Ping timeout)
18:35:20 <-- Hadi1 has quit (Client exited)
18:37:05 <nhnt11> Uh, does Services.prefs.getCharPref throw NS_ERROR_UNEXPECTED if the pref doesn't exist?
18:37:07 * nhnt11 treis
18:37:09 <nhnt11> tries*
18:37:36 <flo-retina> that "Are we signing Thunderbird with codesign v2 ?" tb-planning thread sounds like it will be painful :(
18:37:37 <nhnt11> indeed...
18:37:39 <aleth> It did say it was UNEXPECTED ;)
18:37:44 <flo-retina> we don't sign OS X builds currently anyway though :)
18:38:11 * aleth wonders why m-i hasn't been merged yet
18:38:28 <nhnt11> Hmm, so I should be adding this filesToBeIndexed pref to all-instantbird.js
18:38:33 <aleth> I thought that was a daily thing...
18:38:37 <nhnt11> I don't see a good way to check if it exists or not
18:38:40 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:38:52 --> nhnt11 has joined #instantbird
18:38:57 <-- qheaden has quit (Input/output error)
18:39:12 <aleth> nhnt11: It's a good idea to add it there, yes
18:39:38 <nhnt11> I'll add it in the chat presf
18:39:39 <nhnt11> prefs*
18:40:23 <aleth> Or you could use prefHasUserValue maybe
18:40:41 <aleth> But generally it's nice to have them in the prefs file, for documentation if nothing else
18:40:46 <nhnt11> Yeah, I'll add it
18:41:07 <aleth> i.e. you might want to do both
18:41:33 <nhnt11> Why both?
18:41:38 <nhnt11> I only need to check if it's empty
18:41:50 <nhnt11> (which was throwing because it didn't exist at all)
18:41:56 <aleth> ok
18:41:57 <clokep_work> flo-retina: How difficult would it be to start signing on Windows builds?
18:42:07 --> jb has joined #instantbird
18:42:17 <flo-retina> I have absolutely no idea
18:43:05 <nhnt11> Yay, tests pas
18:43:06 <nhnt11> pass*
18:43:10 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
18:43:22 --> gerard-majax__ has joined #instantbird
18:43:22 <clokep_work> The install experience is pretty bad right now. :(
18:43:37 <-- jb has quit (Connection reset by peer)
18:43:38 --> jb1 has joined #instantbird
18:54:22 <nhnt11> aleth: I don't understand "Under what circumstances is this ever not empty?" in your review comments (regarding the filesToBeIndexed pref, checked in indexLogFile)
18:54:40 <nhnt11> Do you want me to add a comment there or is it a real question?
18:54:53 <aleth> It was a real question
18:55:24 <nhnt11> It's non-empty when we have queued files at shutdown, and in case of a crash during an indexing job, and so on.
18:56:17 <nhnt11> or do you mean, at the time we call indexLogFile, you'd expect it to be empty?
18:57:10 <aleth> I was a bit worried that we could end up with all the log files piled up into that pref if something goes wrong (which would almost certainly break)
18:57:29 <nhnt11> I don't think so.
18:57:48 <aleth> Or that we'd have a crash during the initial index and then have that pref set plus the need to reindex everything
18:57:49 <nhnt11> indexLogFile adds the file to that pref before it starts, and removes it when indexing is finished.
18:58:12 <nhnt11> aleth: filesToBeIndexed is ignored as long as reindex-required is true
18:58:30 <nhnt11> Also during a full reindex only one file is added at a time
18:59:05 <aleth> ok
18:59:06 <aleth> How about increasing performance by storing the contents of the pref in a variable, and only copying it to the pref when modifying it? To avoid the constant pref reads
18:59:23 <aleth> (not sure how expensive those are, when they add up)
19:00:19 <nhnt11> aleth: How about not setting the pref if reindex-required is true? (in that case we'll be reading reindex-required every time though)
19:00:44 <nhnt11> I can't see a good way to avoid writing the pref every time without defeating its purpose
19:01:09 <aleth> Yeah, that doesn't seem to improve anything much.
19:01:33 <aleth> Maybe you can/should clear the pref when a reindex starts?
19:02:13 <nhnt11> I've done that in the latest patch already
19:02:20 <nhnt11> It doesn't prevent reading the empty pref though
19:02:21 <aleth> OK, great.
19:02:51 <aleth> It would just save the reads (apart from the first one) and the associated JSON.parse calls
19:04:29 <nhnt11> aleth: The only okay-ish solution I can think of is passing another parameter to indexLogFile which would prevent reading the pref
19:05:38 <aleth> I'm not proposing that, I'm proposing a variable that contains the contents of the pref at all times, so you don't have to read/parse the pref all the time
19:06:15 <nhnt11> What if we crash before we have a chance to write the pref?
19:06:18 <aleth> You just mirror that variable to the pref so it survives crashes. e.g. give it a setter that also sets the pref
19:06:20 <nhnt11> That would defeat the purpose of the pref
19:06:31 <nhnt11> Uh
19:06:54 <nhnt11> So we would avoid the read?
19:06:57 <aleth> Yup.
19:06:58 <nhnt11> hmm
19:07:45 * nhnt11 doesn't feel like that would really be too useful
19:07:55 <aleth> Maybe not a "JS setter", but you get the idea
19:08:04 <nhnt11> We have two set's, getting rid of a get wouldn't make too much of a difference :-/
19:08:34 <nhnt11> But okay, no big deal
19:08:44 <aleth> It's a get plus a parse, but I'll go with what you think makes the code simplest.
19:09:56 <aleth> Not going to insist on it for performance reasons as it's async anyway.
19:10:09 * nhnt11 would like to leave it as it is, then.
19:10:54 <-- mayanktg has quit (Ping timeout)
19:11:13 --> mayanktg has joined #instantbird
19:14:16 <aleth> mayanktg: how's it going?
19:14:43 <-- mayanktg has quit (Ping timeout)
19:15:35 --> mayanktg has joined #instantbird
19:16:21 --> mpmc has joined #instantbird
19:21:49 <-- mayanktg has quit (Ping timeout)
19:22:07 --> mayanktg has joined #instantbird
19:24:56 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:25:49 --> qheaden has joined #instantbird
19:26:18 <-- aleth has quit (Quit: exit stage left)
19:28:00 --> nhnt11 has joined #instantbird
19:29:12 <flo-retina> Is bug 1047702 still not in m-c? :-S
19:29:15 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1047702 cri, --, ---, iann_bugzilla, ASSI, recursivemake's scan for Makefiles with XPI_PKGNAME or INSTALL_EXTENSION_ID should take account of c
19:30:13 <-- mayanktg has quit (Ping timeout)
19:31:16 --> mayanktg has joined #instantbird
19:33:52 <-- Bollebib has quit (Client exited)
19:34:07 --> Bollebib has joined #instantbird
19:39:05 <-- mayanktg has quit (Ping timeout)
19:39:22 --> mayanktg has joined #instantbird
19:42:45 <-- mayanktg has quit (Ping timeout)
19:43:07 --> mayanktg has joined #instantbird
19:43:30 <-- jb1 has quit (Ping timeout)
19:44:31 <clokep_work> nhnt11: What issue are you trying to solve?
19:45:46 <-- mayanktg has quit (Ping timeout)
19:57:53 --> chrisccoulson has joined #instantbird
20:02:09 --> aleth has joined #instantbird
20:02:09 * ChanServ sets mode +o aleth 
20:08:24 <-- aleth has quit (Ping timeout)
20:08:25 --> aleth has joined #instantbird
20:08:25 * ChanServ sets mode +o aleth 
20:09:26 --> mali has joined #instantbird
20:11:25 --> EionRobb has joined #instantbird
20:16:14 <aleth> flo-retina: m-i just merged to m-c
20:16:45 <flo-retina> :)
20:17:19 <clokep_work> Woot!
20:19:35 <aleth> Looks like jcranmer's objdir rework will land tomorrow, so we'll need port some of that I guess
20:20:09 <flo-retina> aleth: I looked at his patch this morning
20:20:19 <flo-retina> it seems he already did the changes to im/ and suite/
20:20:33 <flo-retina> aleth: I think it's the buildbot config that will need tweaks
20:20:48 <nhnt11> clokep_work: Regarding the prefs stuff?
20:21:47 <nhnt11> The function that indexes a single log file first saves the log file path in a pref, then indexes the file, then removes it from the pref. the function that indexes all log files calls this function repeatedly for each log file, so we were worried that getting/setting the pref would cause overhead
20:22:12 --> Tonnes has joined #instantbird
20:22:59 <clokep_work> nhnt11: (o_O)
20:23:04 <clokep_work> That sounds...inefficient.
20:24:23 <aleth> nhnt11: Just a thought, have you checked when prefs are written to disk? i.e. does this actually do what you think?
20:24:56 <flo-retina> nhnt11: what is this expected to do?
20:35:40 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:35:51 <-- clokep_work has quit (Ping timeout)
20:36:52 * aleth tries a clobber build
20:37:27 <aleth> Who knows, there might be some new bustage to go with the fixes ;)
20:44:19 <flo-retina> ahah
20:48:42 <aleth> flo-retina: have you seen bug 1048042
20:48:45 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1048042 nor, --, ---, iann_bugzilla, ASSI, Port |Bug 780159 - Remove obsolete REGCHROME| and |Bug 935387 - Remove non recursed install targets|
20:49:04 <flo-retina> aleth: how did you know I was looking at https://bugzilla.mozilla.org/attachment.cgi?id=8466809&action=diff right now? :-D
20:49:21 <aleth> It built OK btw :)
20:50:10 <flo-retina> that's fine with me (I mean the im/ changes in there). I don't I've ever seen that stuff actually work.
20:50:26 <flo-retina> I copied it from the TB makefiles back in 2008, but never tested it, so it probably never worked
20:51:13 <aleth> The error console is much busier on the fresh build btw. But most of the new warnings are not from our code.
20:52:57 <flo-retina> I wonder if I should put there the 10.8 SDK too while I'm at it
20:53:33 <flo-retina> aleth: I noticed lots of warnings on my local build last time I tested
20:56:04 <instantbot> New Instantbird - Contacts window bug 1048518 filed by aleth@instantbird.org.
20:56:06 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1048518 nor, --, ---, nobody, NEW, "this._observers is undefined" on merging buddies
20:58:28 <instantbot> New Instantbird - Other bug 1048521 filed by aleth@instantbird.org.
20:58:32 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1048521 min, --, ---, nobody, NEW, Strict mode function declaration warnings
21:02:42 <instantbot> New Instantbird - Other bug 1048524 filed by aleth@instantbird.org.
21:02:45 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1048524 min, --, ---, aleth, ASSI, "Function does not always return a value" warning in TagMenu
21:02:48 --> Hadi has joined #instantbird
21:02:54 <flo-retina> aleth: time to start a Mac nightly? :)
21:02:58 <flo-retina> (the SDK is installed)
21:03:03 <aleth> great! :)
21:03:13 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:03:27 * aleth is filing bugs :-/
21:03:31 <flo-retina> wait, has anybody looked at the Linux bustge on http://buildbot.instantbird.org/waterfall ?
21:06:25 <instantbot> New Chat Core - IRC bug 1048528 filed by aleth@instantbird.org.
21:06:27 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1048528 nor, --, ---, nobody, NEW, "Reference to undefined property" in ircISUPPORT
21:06:43 <aleth> flo-retina: Linux is busted? :-(
21:06:48 <flo-retina> aleth: yes
21:06:59 <flo-retina> aleth: looks like it could be as a result of one of my hacks :(
21:07:09 <aleth> Ah, it's in purple.
21:07:36 <aleth> Maybe an incorrect ifdef
21:08:42 <flo-retina> aleth: the problem is https://hg.mozilla.org/users/florian_queze.net/purple/rev/9962cc44aded#l2.16
21:08:51 <flo-retina> when we are doing it twice in parallel
21:08:58 <flo-retina> and on linux we have apparently 2 dynamic prpls
21:09:08 <flo-retina> (although I'm not fully convinced either of them actually works right now)
21:09:37 <flo-retina> wait, we had working linux builds with that changeset included, didn't we?
21:10:12 <aleth> Wasn't it only your Windows fix that landed after that?
21:11:26 <flo-retina> well, https://hg.mozilla.org/users/florian_queze.net/purple/rev/9f93b3f31412 is fully irrelevant on linux
21:12:04 <flo-retina> so that's probably a new bustage coming from m-c
21:12:07 <-- Hadi has quit (Ping timeout)
21:19:40 <aleth> I don't understand what's going on there.
21:20:29 <flo-retina> it fails ;)
21:22:20 <-- aleth has quit (Ping timeout)
21:28:47 <flo-retina> hmm, that mac mini is actually quite noisy when compilin
21:29:06 <flo-retina> significantly noisier than my macbook pro also compiling on all its cores
21:29:23 <-- Rym has quit (Ping timeout)
21:29:23 --> Hadi has joined #instantbird
21:31:10 <-- Hadi has quit (Ping timeout)
21:33:18 * Fallen|away is now known as Fallen
21:40:53 --> Hadi has joined #instantbird
21:57:41 <-- Tonnes has quit (Quit: ChatZilla [Firefox 31.0/20140716183446])
22:02:17 --> aleth has joined #instantbird
22:02:17 * ChanServ sets mode +o aleth 
22:12:24 <-- EionRobb has quit (Ping timeout)
22:13:33 --> EionRobb has joined #instantbird
22:18:23 <aleth> Sounds like progress in #maildev while I'm fixing papercuts :)
22:25:48 <instant-buildbot> build #2294 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2294
22:27:25 <flo-retina> ah!
22:39:28 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
22:44:38 <flo-retina> aleth: bug 1047841 is one of these rare patches where my immediate reaction is "r-" but the more I look the less I find actual issues.
22:44:40 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1047841 nor, --, ---, aleth, ASSI, Removing a contact with merged buddies doesn't work as expected
22:46:04 <aleth> It does look odd at first glance, but I think it's actually the right thing to do here.
22:46:28 <flo-retina> "the" right thing to do :-D
22:46:47 <aleth> well, given the constraints of the API ;)
22:47:42 <flo-retina> that _updatePositions thing irks me
22:48:07 <flo-retina> aleth: I think the right thing to do is to get rid of all this code, store the contact list in JSON, and async write it every once in a while
22:48:20 <aleth> Heh :D
22:48:45 <aleth> That's not wrong.
22:49:14 <instantbot> aleth@instantbird.org changed the Resolution on bug 1048524 from --- to FIXED.
22:49:16 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1048524 min, --, 1.6, aleth, RESO FIXED, "Function does not always return a value" warning in TagMenu
22:49:26 <flo-retina> we would probably want tests before making such a rewrite
22:49:38 <flo-retina> although we may have a hard time making the tests pass before :-D
23:16:37 <-- aleth has quit (Quit: exit stage left)
23:29:50 <-- mali has quit (Ping timeout)
23:31:39 --> clokep has joined #instantbird
23:31:39 * ChanServ sets mode +o clokep 
23:37:40 * clokep sees that aleth went on a rampage. :)
23:52:24 * Fallen is now known as Fallen|away