#instantbird log on 07 31 2014

All times are UTC.

00:00:53 <-- Mook_as has quit (Quit: Mook_as)
00:02:36 <-- rosonline has quit (Ping timeout)
00:03:06 <-- Rym has quit (Ping timeout)
00:04:55 --> rosonline has joined #instantbird
00:27:48 --> Rym has joined #instantbird
00:44:25 <-- Armada has quit (Connection reset by peer)
01:11:48 <-- rosonline has quit (Client exited)
01:14:11 <-- clokep has quit (Ping timeout)
01:16:50 --> mconley has joined #instantbird
01:17:55 --> clokep has joined #instantbird
01:17:55 * ChanServ sets mode +o clokep 
01:30:21 <-- Rym has quit (Ping timeout)
01:58:54 --> Rym has joined #instantbird
02:00:56 <-- Rym has quit (Ping timeout)
02:14:10 <instant-buildbot> build #2289 of macosx-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2289
02:14:52 <instant-buildbot> build #1466 of win32-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1466
02:46:49 --> Rym has joined #instantbird
02:47:59 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
02:48:51 <-- Rym has quit (Ping timeout)
03:20:00 <-- chrisccoulson has quit (Ping timeout)
03:34:38 <-- mconley has quit (Input/output error)
03:34:45 --> chrisccoulson has joined #instantbird
03:35:07 --> mconley has joined #instantbird
03:36:59 <-- mconley has quit (Ping timeout)
03:45:10 <-- sonny has quit (Ping timeout)
03:52:22 <-- Mook has quit (Quit: Mook)
04:18:32 --> mconley has joined #instantbird
04:26:44 <-- mconley has quit (Input/output error)
04:27:13 --> mconley has joined #instantbird
04:29:04 <-- mconley has quit (Ping timeout)
05:02:22 --> Bollebib has joined #instantbird
05:17:16 --> mayanktg-ph has joined #instantbird
05:37:29 <-- Bollebib has quit (Client exited)
05:46:54 <-- EionRobb has quit (Quit: Leaving.)
06:09:47 --> jb has joined #instantbird
06:17:57 * Fallen|away is now known as Fallen
07:14:28 <-- Suiseiseki has quit (Ping timeout)
07:52:26 --> mpmc has joined #instantbird
07:53:32 --> sonny has joined #instantbird
07:53:34 <-- sonny has quit (Client exited)
08:03:03 --> Rym has joined #instantbird
08:12:16 --> gerard-majax_ has joined #instantbird
08:21:54 <-- gerard-majax_ has quit (Ping timeout)
08:23:02 --> aleth has joined #instantbird
08:23:03 * ChanServ sets mode +o aleth 
08:28:07 <flo-retina> "12:27.40 make[5]: *** No rule to make target `../../xpcom/glue/standalone/libxpcomglue.a.desc', needed by `instantbird'.  Stop." :-S
08:30:03 <flo-retina> I wonder where that dependency is coming from: ../im/branding/nightly/libs: media/mtransport/test/libs
08:31:17 <aleth>  /test/ ?
08:31:19 --> gerard-majax_ has joined #instantbird
08:31:27 <flo-retina> of course my error is 1045969
08:31:30 <flo-retina> bug 1045969
08:31:32 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1045969 nor, --, ---, mh+mozilla, ASSI, export_dirs and libs_dir need to take into account comm-central
08:31:48 <flo-retina> aleth: it makes no sense that copying a bunch of branding image files would depend on something in media/
08:32:02 <aleth> and especially a test in media
08:32:19 <aleth> That's just weird, those never get packaged.
08:33:48 <aleth> flo-retina: Does your error still happen if you apply the patch in that bug?
08:34:00 <flo-retina> rebuilding now with that patch ;)
08:34:26 <flo-retina>  0:49.37 clang: error: no such file or directory: '../../../purplexpcom/src/libpurplexpcom.dylib'
08:34:59 <aleth> heh, well at least that's in purple now.
08:37:33 <flo-retina> "mozbuild.frontend.data.LinkageWrongKindError: Linkable.link_library() does not take components." :(
08:37:41 <mayanktg-ph> aleth: there's a bug filed for implementing navigator.mediaDevices :) . https://bugzilla.mozilla.org/show_bug.cgi?id=1046245
08:37:43 <instantbot> Bug 1046245 nor, --, ---, nobody, NEW, implement navigator.mediaDevices for enumeration local gUM audio & video sources
08:37:43 <flo-retina> (that's if I add purplexpcom to USE_LIBS in prpl.py)
08:37:52 <flo-retina> mayanktg-ph: I saw that :)
08:38:01 <aleth> mayanktg-ph: That's good news :)
08:38:46 <mayanktg-ph> flo-retina, aleth : yes! :-)
08:38:48 <aleth> flo-retina: "does not take components" uh?
08:39:34 <flo-retina> aleth: well, it's still the same problem, purplexpcom is both an xpcom component, and a shared library (because we link libpurple and glib into it)
08:39:42 <flo-retina> and the build system isn't a fan of that special arrangement
08:40:02 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
08:40:38 --> chrisccoulson has joined #instantbird
08:41:24 <aleth> flo-retina: indeed, that's exactly what it checks for http://mxr.mozilla.org/comm-central/source/mozilla/python/mozbuild/mozbuild/frontend/data.py#339
08:42:27 <flo-retina> yeah, it's just hating me
08:44:12 <flo-retina> I don't understand how we are linking static prpls :-S
08:44:21 <flo-retina> ah, it's declared the other way with FINAL_LIBRARY
08:44:32 <-- jb has quit (Ping timeout)
08:44:41 <aleth> What if we link libpurple one level higher? Would that work? (outside of the addon)
08:45:50 * Fallen is now known as Fallen|away
08:46:25 <flo-retina> what does that mean?
08:46:31 <flo-retina> "one level higher"
08:50:57 <aleth> I meant moving the dynamic prpl stuff from prpl.py to moz.build somehow, but I'm not sure the idea makes sense as looking at the files I don't see how
08:51:40 <flo-retina> prpl.py is included by moz.build files
08:52:21 <aleth> Yes, but from the prpl moz.build
08:52:52 <aleth> Anyway, I don't think it helps.
08:54:18 <aleth> Might be worth asking glandium what he would suggest for this case.
08:55:53 <-- gerard-majax_ has quit (Ping timeout)
08:56:05 <flo-retina> my build finished successfully!
08:56:24 <aleth> \o/
08:56:27 <aleth> What did you do?
08:56:38 <flo-retina> something ugly
08:56:53 --> gerard-majax_ has joined #instantbird
08:56:54 <flo-retina> I'm re-linking purplexpcom for each dynamic prpl :-]
08:57:03 <aleth> :D
08:57:57 <flo-retina> hmm, for some reason I don't have the InstantbirdDebug.app folder in dist/ :(
08:59:32 <flo-retina> could be that it's just because I needed to clobber after applying the patch from bug 1045969
08:59:34 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1045969 nor, --, ---, mh+mozilla, ASSI, export_dirs and libs_dir need to take into account comm-central
08:59:44 <-- gerard-majax_ has quit (Ping timeout)
09:00:48 --> gerard-majax_ has joined #instantbird
09:01:46 <flo-retina> hmm, maybe I could avoid re-linking if I was calling make for libpurplexpcom.dylib rather than for "target"
09:02:28 <aleth> I was just wondering if maybe it shouldn't be a target
09:02:58 <aleth> Not sure what else there is in the current build system though.
09:03:09 <aleth> What's "host"?
09:03:22 <-- gerard-majax_ has quit (Ping timeout)
09:03:44 <flo-retina> aleth: not completely sure
09:04:25 <flo-retina> usually stuff with the HOST_ prefix are things that should be able to run during the build process (eg the tools for generating mar files) and that we aren't packaging. These should be built for the current machine's architecture, even if we are cross compiling
09:05:08 <aleth> There's also something called recursive_make_targets, used for android
09:05:49 <-- Rym has quit (Ping timeout)
09:11:39 <instantbot> aleth@instantbird.org changed the Resolution on bug 1046414 from --- to FIXED.
09:11:40 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1046414 nor, --, 1.6, aleth, RESO FIXED, Add tooltips to the about panel
09:19:21 <flo-retina> clobber build failed :(
09:23:34 <aleth> So it's building everything but not im/app ?
09:23:40 <flo-retina> failing in purple
09:23:47 <flo-retina> my previous hack wasn't strong enough
09:24:09 --> jb has joined #instantbird
09:24:40 <aleth> glandium seems to be around atm, maybe ping him?
09:25:49 <-- jb has quit (Ping timeout)
09:26:59 <flo-retina> "make[4]: *** [extensions/purple/libpurple/protocols/null/target] Error 2" lovely error message
09:33:57 --> gerard-majax_ has joined #instantbird
09:34:53 --> Rym has joined #instantbird
09:36:22 <flo-retina> looks like I have a hack that actually works this time
09:36:55 <-- Rym has quit (Ping timeout)
09:37:39 <flo-retina> still no Instantbird.app though
09:38:16 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:46:14 --> Rym has joined #instantbird
10:01:41 --> flo-retina has joined #instantbird
10:01:41 * ChanServ sets mode +qo flo-retina flo-retina 
10:03:05 --> BWMerlin has joined #instantbird
10:04:55 --> clokep has joined #instantbird
10:04:55 * ChanServ sets mode +o clokep 
10:05:03 --> Armada has joined #instantbird
10:44:18 <clokep> flo-retina: Congrats.
10:47:56 <flo-retina> for the build that compiles but doesn't start? :)
10:50:22 --> jb has joined #instantbird
10:50:34 <-- jb has quit (Input/output error)
10:51:20 --> jb has joined #instantbird
10:52:13 <clokep> flo-retina: Baby steps.
10:59:57 --> mayanktg has joined #instantbird
11:03:59 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
11:06:44 * Fallen|away is now known as Fallen
11:09:55 <-- Rym has quit (Ping timeout)
11:10:03 <mayanktg> select-file-active.png is unavailable
11:11:44 <mayanktg> Sorry that was for sawrubh
11:13:13 * Fallen is now known as Fallen|away
11:14:29 <-- BillBinkley has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
11:16:40 --> Suiseiseki has joined #instantbird
11:18:25 <aleth> mayanktg: Don't forget to ask your reviewers if you are unsure about the reason for a requested change
11:19:29 --> rosonline has joined #instantbird
11:23:08 --> Rym has joined #instantbird
11:27:11 --> BillBinkley has joined #instantbird
11:33:03 <-- mayanktg has quit (Ping timeout)
11:33:23 --> mayanktg has joined #instantbird
11:42:23 <-- rosonline has quit (Ping timeout)
11:42:36 --> rosonline has joined #instantbird
11:44:29 <-- aleth has quit (Ping timeout)
11:51:01 --> clokep_work has joined #instantbird
11:51:01 * ChanServ sets mode +o clokep_work 
11:55:28 --> aleth has joined #instantbird
11:55:28 * ChanServ sets mode +o aleth 
11:59:04 <-- mayanktg has quit (Ping timeout)
12:10:10 <-- BWMerlin has quit (Quit: BWMerlin)
12:14:35 <-- aleth has quit (Ping timeout)
12:15:10 --> aleth has joined #instantbird
12:15:10 * ChanServ sets mode +o aleth 
12:17:33 <-- jb has quit (Ping timeout)
12:18:30 --> jb has joined #instantbird
12:20:36 <-- aleth has quit (Ping timeout)
12:21:31 --> nhnt11 has joined #instantbird
12:22:38 --> aleth has joined #instantbird
12:22:38 * ChanServ sets mode +o aleth 
12:24:42 --> mayanktg has joined #instantbird
12:30:40 <nhnt11> Ah, tooltips in about pages :)
12:30:46 <nhnt11> That was an easy patch! :)
12:33:16 <nhnt11> flo-retina: So I've got a new patch for indexed logs, but I had a few questions about your review comments, so I'll reply on the bug and wait before uploading a new patch. That okay?
12:33:50 <flo-retina> I'll try and have a look soon
12:37:13 <nhnt11> Can you JSON.stringify an array directly?
12:37:15 * nhnt11 tries
12:37:33 <nhnt11> Ah, it works
12:37:33 <nhnt11> nice
12:37:47 <aleth> Arrays are objects ;)
12:38:21 <aleth> Having said that, JSON.stringifying Maps and Sets doesn't work (at least it didn't use to), which is a bug iirc
12:38:23 <nhnt11> Sure, I just wasn't sure how JSON handled them. Anyways, that's clear now.
12:38:30 <nhnt11> hmm
12:42:03 <nhnt11> Hmm, so turns out I only really have one question. Guess I was tired on the train ;)
12:43:00 <nhnt11> There was an addon to auto-hide the participant list or something right?
12:43:46 * nhnt11 found Toggle Participant List
12:45:19 <flo-retina> uh, looks like our wiki is full of spam :(
12:46:03 <nhnt11> What?
12:46:12 <nhnt11> wiki.i.o seems fine
12:46:35 <flo-retina> nhnt11: https://wiki.instantbird.org/Special:RecentChanges
12:46:49 <nhnt11> Ah..
12:47:22 * nhnt11 read "full of spam" as "defaced" for some reason :S
12:52:48 <clokep_work> That's annoying. :-\
12:52:53 <clokep_work> I hate admining wikis.
13:00:37 <flo-retina> clokep_work: I think Mic was taking care of it without even talking about it
13:02:57 <-- mayanktg-ph has quit (Quit: Connection closed for inactivity)
13:04:15 --> mayanktg-ph has joined #instantbird
13:05:23 <flo-retina> nhnt11: only one question?
13:09:07 <-- aleth has quit (Ping timeout)
13:12:10 <flo-retina> my nightly is now at 850MB of ram
13:14:37 <-- BillBinkley has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
13:15:49 --> BillBinkley has joined #instantbird
13:19:54 <nhnt11> flo-retina: I had a few questions on the train but the answers seem to be obvious now.
13:21:18 <nhnt11> flo-retina: We don't expect the queue to be empty at that point (in which case it wouldn't really be a queue, would it?) but we do expect that a full re-index does not happen except at startup (when the queue is empty anyway)
13:21:57 <nhnt11> If we ever add code to do a reindex at a time other than startup, we will need to handle the case you're worried about, yes.
13:22:51 <flo-retina> that may be worth a code comment too :)
13:22:56 <nhnt11> Alright.
13:27:26 <flo-retina> I think I've just found a way to save some of the memory used by the twitter prpl
13:27:50 <flo-retina> instead of keeping the JSON data about the user that comes with each tweet, we should put that in a weakmap
13:28:59 --> mconley has joined #instantbird
13:29:15 <flo-retina> I currently have 170 copies of Usul's twitter profile description in the notable strings.
13:30:15 <clokep_work> flo-retina: Yes. That sounds likely. I'm not positive what WeakMaps do though.
13:30:22 <flo-retina> it may also be interesting to figure out a way to avoid duplicating IRC nicks all the time in memory. I have 727 copies of the string "aleth"
13:31:06 <flo-retina> clokep_work: I think they don't add a reference to objects, so that they can still be gc'ed (if not tweet from that person is in memory any more, we shouldn't keep the user data in memory forever)
13:31:18 <flo-retina> s/not/no/
13:38:12 <clokep_work> I see.
13:38:27 <clokep_work> flo-retina: We do fill in the participants list though.
13:38:35 <clokep_work> SO don't we still need that data?
13:41:35 <-- jb has quit (Quit: jb)
13:43:27 <-- mconley has quit (Input/output error)
13:43:55 --> mconley has joined #instantbird
13:45:45 <-- mconley has quit (Ping timeout)
13:51:59 <flo-retina> clokep_work: if there's a participant object, a reference would be kept
13:56:27 --> jb has joined #instantbird
14:12:16 <-- BillBinkley has quit (Ping timeout)
14:15:22 --> BillBinkley has joined #instantbird
14:17:50 <clokep_work> Right! :)
14:28:06 --> mconley has joined #instantbird
15:00:40 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:01:23 <-- jb has quit (Quit: jb)
15:03:09 --> Bollebib has joined #instantbird
15:03:46 --> jb has joined #instantbird
15:07:26 <-- jb has quit (Ping timeout)
15:17:02 <-- mayanktg has quit (Ping timeout)
15:17:05 --> jb has joined #instantbird
15:17:23 --> mayanktg has joined #instantbird
15:20:50 <-- jb has quit (Ping timeout)
15:22:58 <-- mayanktg-ph has quit (Quit: Connection closed for inactivity)
15:25:06 --> flo-retina has joined #instantbird
15:25:06 * ChanServ sets mode +qo flo-retina flo-retina 
15:32:35 <-- gerard-majax_ has quit (Ping timeout)
15:46:27 --> qheaden has joined #instantbird
15:47:11 <qheaden> Hello.
15:47:25 <clokep_work> Hello qheaden.
15:49:17 <-- mayanktg has quit (Ping timeout)
15:49:41 --> mayanktg has joined #instantbird
15:51:49 * qheaden wonders what effect this has on the Ib Facebook chat prpl: http://techcrunch.com/2014/04/09/facebook-messenger-or-the-highway/
15:53:25 --> jb has joined #instantbird
15:54:59 <clokep_work> qheaden: The bigger issue is they're killing the XMPP gateway at some point.
15:57:22 <-- mayanktg has quit (Ping timeout)
15:57:41 --> mayanktg has joined #instantbird
16:06:50 <clokep_work> Do we know if we'll be unbusted enough with the stuff that just landed to build?
16:12:14 <flo-retina> hasn't yahoo japan been removed from JS-Yahoo? I still see prpl-yahoojp in the forcePurple pref
16:12:18 <flo-retina> qheaden: ?
16:13:05 --> gerard-majax_ has joined #instantbird
16:17:07 <qheaden> flo-retina: yes, it has been removed.
16:17:13 <clokep_work> flo-retina: We killed the JS code, but not the libpurple code.
16:17:22 <qheaden> ^
16:17:46 <qheaden> We should probably kill the purple code too.
16:20:38 <clokep_work> qheaden: I'd rather just let upstream kill it personally.
16:20:50 <clokep_work> qheaden: Did you have any chance to look at enabling stuff in TB?
16:21:18 <qheaden> clokep_work: Unfortunately I wasn't able to.
16:28:13 <-- gerard-majax_ has quit (Ping timeout)
16:31:08 <clokep_work> qheaden: Not a problem! :)
16:33:30 --> gerard-majax_ has joined #instantbird
16:38:25 --> iamjayakumars has joined #instantbird
16:38:35 <-- rosonline has quit (Client exited)
16:40:25 <-- Armada has quit (Connection reset by peer)
16:43:34 --> Armada has joined #instantbird
16:45:23 <-- Armada has quit (Ping timeout)
16:46:55 --> Mook_as has joined #instantbird
16:53:14 <-- gerard-majax_ has quit (Ping timeout)
16:58:51 --> mayanktg-ph has joined #instantbird
16:59:06 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:00:14 --> gerard-majax_ has joined #instantbird
17:02:04 * Fallen|away is now known as Fallen
17:04:01 <-- gerard-majax_ has quit (Client exited)
17:04:05 --> gerard-majax__ has joined #instantbird
17:07:59 <flo-retina> new bustage! https://bugzilla.mozilla.org/show_bug.cgi?id=941296#c70
17:08:02 <instantbot> Bug 941296 nor, --, mozilla34, giles, RESO FIXED, PlatformDecoderModule for OSX
17:08:35 <-- jb has quit (Ping timeout)
17:11:24 <clokep_work> :(
17:12:45 <-- gerard-majax__ has quit (Ping timeout)
17:12:58 <flo-retina> I'm actually asking for someone to post a notification of that on dev-platform
17:24:58 <flo-retina> nhnt11: haven't you said not so long ago that you had an updated patch for indexing?
17:25:02 * flo-retina hasn't seen it
17:29:16 <flo-retina> do we know what's responsible for making that second "nick.toLowerCase() is not online" message? http://i.imgur.com/VBLfUAi.png
17:31:18 <clokep_work> I've never seen that before.
17:32:28 <flo-retina> I seen it several times (like 5-6 times) before
17:32:59 <flo-retina> I vaguely suspect it could be related to something doing a whois, and us printing part of the whowas reply in the conversation
17:33:55 <flo-retina> the string is error.noSuchNick=%S is not online.
17:34:56 <flo-retina> http://mxr.mozilla.org/comm-central/source/chat/protocols/irc/irc.js#119
17:35:12 <flo-retina> so it could be that we also need to have sent the last message in the private conversation
17:36:18 <nhnt11> flo-retina: The advantage of having aGroupByDay is that we don't do all the processing that DailyLogSet does if it's false
17:37:03 <nhnt11> Whereas if we include a forEachDay in the imILogSet interface we can just get rid of DailyLogSet
17:40:10 <flo-retina> why would we do the processing before forEachDay is called?
17:41:18 <nhnt11> Hmm, right.
17:41:58 * nhnt11 moves stuff around
17:43:48 --> Hadi has joined #instantbird
17:45:41 <-- Hadi has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:53:14 <nhnt11> flo-retina: Where do you think is the best place for the comment about how a full reindex happens only at startup? (at the place where indexAllLogs is called, in the indexAllLogs function, or in queueIndexingJob?)
17:53:38 <flo-retina> at the place where I had a comment on the previous patch?
17:54:06 <flo-retina> or more clearly phrased: at the place where something would have to be changed if that assumption was no longer true
17:54:15 <nhnt11> In queueIndexingJob then. That seemed like a slightly odd place to me to talk about a full reindex, so I asked.
17:54:17 <nhnt11> Hmm.
17:54:24 <nhnt11> Okay.
17:54:34 <flo-retina> maybe it will seem odd when looking at the updated patch :)
17:54:45 <nhnt11> In that case, I'd say indexAllLogs is the best place
18:00:04 <nhnt11> Ah, I seem to have misunderstood one of your comments
18:01:16 <nhnt11> flo-retina: "Why do you need to save both the paths and the relative paths in the constructor?" I'm not storing both. I'm storing all the full paths, and the relative paths of the /directories/ (not the files)
18:01:31 <nhnt11> Quite possibly the set of relatives may have just one element
18:01:43 <flo-retina> ah
18:01:45 <nhnt11> The reason is because when querying the database we need the relative path of the folder
18:02:01 <nhnt11> s/relatives/relative directories/
18:02:30 <nhnt11> flo-retina: Storing the relative paths of the files seems like overkill to me tbh
18:02:34 <nhnt11> As long as we aren't leaking them...
18:02:39 <flo-retina> it's possible it was late when I reviewed :)
18:02:59 <flo-retina> nhnt11: why are we even storing these paths?
18:03:05 <flo-retina> (I haven't looked at the code since I reviewed)
18:03:22 <nhnt11> flo-retina: It's a LogSet, so it needs to know which paths it represents?
18:05:17 <flo-retina> nhnt11: if it represents all the log files from a directory, you don't need to store the path of each file, right?
18:05:44 <flo-retina> if it's a result of a search and you have only some files from the folder (or even from several different folders), then you do need to store the (relative?) paths
18:06:02 <nhnt11> flo-retina: It's very possible it represents the files from multiple directories, for example if it's from a contact with several buddie
18:06:04 <nhnt11> s
18:06:31 --> jb has joined #instantbird
18:07:28 <nhnt11> In my mind, you're suggesting doing something similar to the database and storing relative directories, and mapping filenames to their relative directories using an id or something
18:07:53 <nhnt11> If that's correct^, I still think it's overkill for something that's not going to be written to disk
18:08:18 <nhnt11> Or else we'd need separate implementations of the imILogSet interface for each case
18:08:42 <nhnt11> (one for when there are multiple directories like from a search, one for when it's from a single dir, maybe there are other cases?)
18:08:46 <nhnt11> I think that's overkill too thoug
18:10:28 <flo-retina> maybe
18:10:45 <flo-retina> nhnt11: how do you search across ALL logs at once?
18:11:00 <nhnt11> flo-retina: Services.logs.getAllLogs().search()
18:11:11 <flo-retina> you aren't going to store the path of each log file in memory for that, are you?
18:11:11 <nhnt11> Btw, I'll upload the patch once the answers to these log set questions are decided upon
18:11:44 <flo-retina> you wouldn't even want to iterate over the log directories to build that list of paths, you just want to query the db
18:11:54 <nhnt11> Hmm... right.
18:12:51 <flo-retina> so my question is, why do you need to have a list of log file paths before someone has called forEach?
18:13:00 <flo-retina> it seems to me you only need a list of relative directory paths
18:13:05 * nhnt11 wonders what the best thing to do is.
18:13:26 <nhnt11> flo-retina: Right, that makes sense, but there'll need to be a separate LogSet implementation for the search case
18:13:38 <nhnt11> Where there are only some files to include.
18:13:57 <clokep_work> nhnt11: Did we ever figure out that cross platform thing?
18:14:05 <flo-retina> nhnt11: you may need to have a separate implementation.
18:14:36 <nhnt11> clokep_work: I think we decided that triggering a full re-index is enough?
18:14:44 <flo-retina> nhnt11: or you may need to keep that array of file paths null until you have search results, and have some of the implementation behave differently based on whether that array is null or not
18:15:01 * flo-retina doesn't know what the "cross platform thing" refers to
18:15:24 <clokep_work> nhnt11: I don't remember having that conversation.
18:15:31 <nhnt11> flo-retina: clokep_work was wondering a while ago what would happen if someone migrated their profile directory to a different OS
18:15:43 <clokep_work> nhnt11: Not migrated, synced.
18:16:02 <flo-retina> clokep_work: are you worried about the .sqlite file getting corrupted by the sync?
18:16:14 <flo-retina> if so, how is that different from the existing blist.sqlite file?
18:16:17 <nhnt11> flo-retina: clokep_work is worried that the stored paths will not be compatible
18:16:27 <nhnt11> across different OSes
18:16:48 <flo-retina> nhnt11: I think if you store only relative paths, and always use the / separator (which is non-default but does work on Windows, you should be fine)
18:17:16 * nhnt11 didn't know "/" works on Windows.
18:18:01 <clokep_work> I agree, that should work OK
18:23:38 --> mayanktg has joined #instantbird
18:25:04 <-- iamjayakumars has quit (Client exited)
18:25:47 <flo-retina> nhnt11: I think gloda's chat index always uses "/"
18:26:49 <-- mayanktg-ph has quit (Quit: )
18:27:50 <nhnt11> So for the next patch I need to a) "Merge" Daily and non-daily log sets, b) make sure paths in the db always use "/", and create a separate implementation of LogSet to solve the problem of unnecessarily keeping paths in memory
18:28:16 * nhnt11 wonders if he'll have to replace all the OS.Path stuff because of "/"
18:28:31 <nhnt11> Anyway...
18:28:36 <nhnt11> Back in a bit to do all that.
18:28:39 * nhnt11 is now known as nhnt11_away
18:31:15 <flo-retina> nhnt11: ifdef XP_WIN .replace(/\\/g, "/")
18:46:58 <-- Tonnes has quit (Quit: ChatZilla [Firefox 31.0/20140716183446])
19:14:33 <-- flo-retina has quit (Ping timeout)
19:25:16 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
19:25:47 <clokep_work> mayanktg: Any luck on updating those patches?
19:27:39 --> chrisccoulson has joined #instantbird
19:28:32 --> flo-retina has joined #instantbird
19:28:32 * ChanServ sets mode +qo flo-retina flo-retina 
19:28:52 <mayanktg> clokep_work: I'm making progress and will update the patch before sleeping.
19:29:16 <clokep_work> mayanktg: Great! Any questions in the comments people have left?
19:29:49 <clokep_work> mayanktg: I'd highly suggest re-reading all the code and looking for SIMILAR issues to the things we said. :)
19:31:18 <mayanktg> Hmm yes. Regarding directly putting the UI inside the XBL markup instead of HTML document. I haven't tried it yet, but I'm not sure what part of code I'll need to change here. I'll try to figure it out though.
19:32:13 <flo-retina> mayanktg: probably a lot, but it should be a simplification :)
19:33:37 <mayanktg> flo-retina: Hmm ok. I'm trying it then.  :)
19:36:50 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:40:46 <clokep_work> https://bugzilla.mozilla.org/show_bug.cgi?id=1030059#c7 is promising. :)
19:40:49 <instantbot> Bug 1030059 maj, --, ---, nobody, NEW, Passwords gone in newest nightly
19:41:57 <-- mayanktg has quit (Ping timeout)
19:44:39 --> mayanktg has joined #instantbird
19:46:26 <-- mayanktg has quit (Ping timeout)
19:48:08 --> mayanktg has joined #instantbird
19:52:04 <-- mayanktg has quit (Ping timeout)
19:52:49 --> Tonnes has joined #instantbird
19:52:56 --> mayanktg has joined #instantbird
19:54:36 * Fallen is now known as Fallen|away
19:55:35 <-- mayanktg has quit (Ping timeout)
19:56:20 --> mayanktg has joined #instantbird
19:57:05 --> Armada has joined #instantbird
20:00:35 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:01:35 <-- mayanktg has quit (Ping timeout)
20:15:37 <-- jb has quit (Ping timeout)
20:17:15 * Fallen|away is now known as Fallen
20:26:26 * Fallen is now known as Fallen|away
20:29:31 --> jb has joined #instantbird
20:31:40 <clokep_work> flo-retina: FWIW I'd like to land bug 964828 sometime "soon". ;)
20:31:42 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=964828 maj, --, ---, clokep, ASSI, Update libpurple up to 2.10.9
20:32:59 * nhnt11_away is now known as nhnt11
20:36:09 <-- flo-retina has quit (Ping timeout)
20:36:51 --> flo-retina has joined #instantbird
20:36:51 * ChanServ sets mode +qo flo-retina flo-retina 
20:42:23 --> EionRobb has joined #instantbird
20:44:33 <-- clokep_work has quit (Ping timeout)
20:44:48 <-- jb has quit (Ping timeout)
20:48:52 --> jb has joined #instantbird
21:18:49 <-- BillBinkley has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
21:19:17 --> BillBinkley has joined #instantbird
21:35:14 --> clokep has joined #instantbird
21:35:15 * ChanServ sets mode +o clokep 
21:40:15 --> clokep_work has joined #instantbird
21:40:15 * ChanServ sets mode +o clokep_work 
21:40:46 <-- jb has quit (Ping timeout)
21:47:32 <clokep_work> flo-retina: 
21:47:40 <clokep_work> Do you have your purple patches anywhere?
21:48:09 <flo-retina> in my purple folder
21:52:44 <clokep_work> Care to share? :)
21:58:20 --> jb has joined #instantbird
22:02:44 <flo-retina> do you have a favorite bug where I can attach it?
22:08:45 * Fallen|away is now known as Fallen
22:16:52 <-- Bollebib has quit (Client exited)
22:18:11 <flo-retina> clokep_work: I'm cleaning it up
22:18:12 * Fallen is now known as Fallen|away
22:20:28 <clokep_work> flo-retina: Nope. :)
22:21:42 <flo-retina> I don't even know how I can describe what that patch does :-S
22:22:32 <flo-retina> clokep_work: http://pastebin.instantbird.com/783759
22:22:38 <flo-retina> I haven't tested this specific version of the patch
22:23:41 <flo-retina> I wanted to test it, but mach has decided to clobber my build, and I don't think I'll wait for it to finisih before going to bed
22:23:56 <clokep_work> Intersting.
22:24:51 * clokep_work starts a build
22:25:01 <flo-retina> the version I tested didn't have the PURPLEXPCOM_PATH and PURPLEXPCOM_LIB variables, and had more dead code
22:25:11 <flo-retina> clokep_work: have you applied the other required patches?
22:26:36 <clokep_work> flo-retina: I applied qheaden's patch to change PARALLEL_DIRS to DIRS.
22:26:53 <flo-retina> my patch includes/replaces that
22:27:35 <clokep_work> OK.
22:27:46 <clokep_work> Than the answer is probably "no"?
22:27:58 <flo-retina> I meant bug 1045969
22:28:01 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1045969 nor, --, ---, mh+mozilla, ASSI, export_dirs and libs_dir need to take into account comm-central
22:28:11 <flo-retina> if you don't apply that to mozilla-central, you've got no chance of building something
22:28:28 <flo-retina> also, update c-c, the main c-c patch landed today
22:28:47 <flo-retina> with all of that applied, a mac build should finish successfully, but not work.
22:28:51 <flo-retina> a linux build should work.
22:28:57 <flo-retina> Windows will have different issues
22:29:10 <clokep_work> flo-retina: Ah, yes. I have applied.
22:43:26 <flo-retina> clokep_work: the pastebined patch works
22:44:11 <clokep_work> flo-retina: Cool, thanks! :)
22:44:14 <clokep_work> Do you want me to push it?
22:44:46 <flo-retina> you would probably review it first ;)
22:46:18 <-- BillBinkley has quit (Ping timeout)
22:46:45 <flo-retina> but sure, if you like it, you can push it :)
22:47:31 * Fallen|away is now known as Fallen
23:03:39 --> mayanktg has joined #instantbird
23:06:28 <-- mayanktg has quit (Ping timeout)
23:10:27 * Fallen is now known as Fallen|away
23:32:18 --> mayanktg has joined #instantbird
23:32:41 <-- mconley has quit (Connection reset by peer)
23:33:14 --> mconley has joined #instantbird
23:52:00 <-- Armada has quit (Connection reset by peer)
23:52:03 <-- mayanktg has quit (Ping timeout)
23:52:07 --> mayanktg has joined #instantbird