#instantbird log on 07 28 2014

All times are UTC.

00:07:32 <-- freaktechnik has quit (Ping timeout)
00:10:07 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
00:11:20 --> Rym has joined #instantbird
01:22:58 <-- Hadi has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
02:25:53 <instant-buildbot> build #2286 of macosx-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2286
03:04:01 <-- rosonline has quit (Client exited)
03:04:26 <instant-buildbot> build #1112 of linux-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1112
03:29:18 <-- mconley has quit (Input/output error)
03:29:46 --> mconley has joined #instantbird
03:31:34 <-- mconley has quit (Ping timeout)
03:35:22 <instant-buildbot> build #1463 of win32-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1463
04:18:14 <instant-buildbot> build #7 of linux64-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/7
04:51:20 --> mpmc has joined #instantbird
05:58:45 <-- Rym has quit (Ping timeout)
06:07:21 --> Bollebib has joined #instantbird
06:12:52 <-- EionRobb has quit (Quit: Leaving.)
06:13:21 --> flo-retina has joined #instantbird
06:13:21 * ChanServ sets mode +qo flo-retina flo-retina 
06:16:33 --> jb has joined #instantbird
06:42:36 * Fallen|away is now known as Fallen
06:50:48 --> mconley has joined #instantbird
06:56:24 --> fjaeio has joined #instantbird
06:59:09 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
07:33:04 <-- jb has quit (Ping timeout)
08:00:27 --> aleth has joined #instantbird
08:00:27 * ChanServ sets mode +o aleth 
08:33:30 --> jb has joined #instantbird
08:34:52 --> chrisccoulson has joined #instantbird
08:35:05 <-- ivan` has quit (Ping timeout)
08:39:33 --> ivan` has joined #instantbird
08:42:55 <-- fjaeio has quit (Ping timeout)
08:46:51 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
08:58:59 <-- mconley has quit (Quit: NO CARRIER)
08:59:43 --> fjaeio has joined #instantbird
09:08:56 <-- ivan` has quit (Quit: ERC Version 5.3 (IRC client for Emacs))
09:13:14 <-- jb has quit (Connection reset by peer)
09:13:26 --> jb has joined #instantbird
09:17:35 --> ivan` has joined #instantbird
09:26:40 <-- aleth has quit (Ping timeout)
09:32:13 --> freaktechnik has joined #instantbird
09:34:30 --> aleth has joined #instantbird
09:34:30 * ChanServ sets mode +o aleth 
09:35:44 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:47:03 --> Armada has joined #instantbird
10:00:31 <-- aleth has quit (Ping timeout)
10:06:11 --> aleth has joined #instantbird
10:06:12 * ChanServ sets mode +o aleth 
10:16:34 <-- aleth has quit (Ping timeout)
10:18:28 --> aleth has joined #instantbird
10:18:28 * ChanServ sets mode +o aleth 
10:19:58 --> clokep has joined #instantbird
10:19:58 * ChanServ sets mode +o clokep 
10:28:28 <-- freaktechnik has quit (Ping timeout)
10:30:17 --> BWMerlin has joined #instantbird
10:33:05 <-- aleth has quit (Ping timeout)
10:35:23 --> flo-retina has joined #instantbird
10:35:23 * ChanServ sets mode +qo flo-retina flo-retina 
10:36:33 --> aleth has joined #instantbird
10:36:33 * ChanServ sets mode +o aleth 
10:50:43 <-- aleth has quit (Ping timeout)
10:51:18 <-- fjaeio has quit (Ping timeout)
10:52:02 --> fjaeio has joined #instantbird
10:59:06 --> freaktechnik has joined #instantbird
11:04:06 --> mayanktg has joined #instantbird
11:12:23 --> aleth has joined #instantbird
11:12:23 * ChanServ sets mode +o aleth 
11:14:14 <mayanktg> aleth: HI. It is required to add a border: none for the buttons in panel 2 and 3 else they appear to have 3D like buttons in Linux. Here is the pastebin which gives correct result. http://pastebin.instantbird.com/770044
11:15:29 <aleth> mayanktg: OK, thanks! Can you also put that in a bug comment so we have it there for the future?
11:22:40 <mayanktg> aleth: Regarding the bug comment https://bugzilla.mozilla.org/show_bug.cgi?id=1018060#c43 The ID in the o=... SDP line changes for each generated SDP session-description. i.e. They use the o= (...) details to generate a unique global identifier. IMO it is not important to send these lines over the Jingle Stanza. We can use Mozilla-SIPUA too, it doesn't break anything.
11:22:43 <instantbot> Bug 1018060 enh, --, ---, mayanktg, NEW, Video calls via XMPP/Jingle and WebRTC
11:23:37 <aleth> mayanktg: But does the recipient have to reply with the same id to answer the call? Or doesn't that matter?
11:25:27 <aleth> For the username part, Mozilla-SIPUA seems better than including a version number (we don't know which version the sender is using, we don't even know it's a Mozilla app really). All this certainly needs a good comment in the code.
11:26:13 <mayanktg> No, the recipient doesn't need to answer the call with the same id (id here refers to one in line o=...). This line just provides a globally unique name to the call being made.  It doesn't matter until and unless the WebRTC recognizes it to be valid o= line.
11:26:35 <aleth> OK
11:26:35 <mayanktg> OK I'll use the Mozilla-SIPUA name then.
11:35:46 <mayanktg> Grr... XMPP account is giving problems. I'm sharing the exact error for |itemPayload.forEach(itemDesc.addChild);| in a min. It failed to add the array elements as child of the <description/> , though on adding dumps it identified the child elements to be XML nodes. :-o
11:37:27 <mayanktg> The error is http://pastebin.instantbird.com/770113. (this.children is undefined)
11:37:54 <-- Tonnes has quit (Quit: ChatZilla [Firefox 31.0/20140716183446])
11:39:11 --> Tonnes has joined #instantbird
11:40:20 <aleth> Ah, you're getting the problem because 'this' in line 203 isn't set correctly when using |itemPayload.forEach(itemDesc.addChild);|. That's annoying, in that case you'd better use the longer version you had in the bug.
11:41:37 <mayanktg> Ok.
11:42:01 --> Bollebib has joined #instantbird
11:42:24 <aleth> The alternative (just so you know about it for the future) is to use the second parameter in forEach https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/forEach
11:46:15 <mayanktg> Ahh...Thanks. I did read this page but couldn't get I would be needing to pass _this_ parameter too. :-/
11:46:29 <-- freaktechnik has quit (Ping timeout)
11:48:47 <-- mayanktg has quit (Ping timeout)
11:50:54 --> mpmc has joined #instantbird
11:55:55 --> clokep_work has joined #instantbird
11:55:56 * ChanServ sets mode +o clokep_work 
12:02:58 --> mayanktg has joined #instantbird
12:07:44 <-- aleth has quit (Ping timeout)
12:08:37 <clokep_work> mayanktg: I'll read over your reply sometime soon. I hope most of the comments made sense.
12:08:56 --> aleth has joined #instantbird
12:08:56 * ChanServ sets mode +o aleth 
12:09:55 <-- mayanktg has quit (Client exited)
12:09:57 --> mayanktg has joined #instantbird
12:10:52 <-- BWMerlin has quit (Quit: BWMerlin)
12:18:31 <-- mayanktg has quit (Ping timeout)
12:21:52 --> BillBinkley has joined #instantbird
12:22:53 <-- aleth has quit (Ping timeout)
12:24:08 <-- fjaeio has quit (Ping timeout)
12:24:25 --> fjaeio has joined #instantbird
12:25:45 --> aleth has joined #instantbird
12:25:45 * ChanServ sets mode +o aleth 
12:31:57 <-- jb has quit (Quit: jb)
12:33:51 --> jb has joined #instantbird
12:33:55 --> Rym has joined #instantbird
12:41:48 --> mayanktg has joined #instantbird
12:42:50 <clokep_work> Apaprently in tab prefs landed in Fx.
12:43:26 <clokep_work> That'd be...touhg for us though. :-\
12:44:07 <aleth> Not necessarily... nhnt11 knows how to put things in tabs ;)
12:44:17 <aleth> Does it even touch the pane XUL?
12:44:28 * clokep_work doesn't know.
12:44:34 <clokep_work> aleth: The issue (in my mind) is the window size.
12:45:33 <aleth> FX shouldn't really make any assumptions about window size either, but I see what you mean.
12:51:52 <-- mayanktg has quit (Ping timeout)
12:52:41 --> mayanktg has joined #instantbird
12:58:39 <instantbot> aleth@instantbird.org changed the Resolution on bug 1044031 from --- to FIXED.
12:58:41 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1044031 nor, --, 1.6, mayanktg, RESO FIXED, Top and middle border doesn't match in user icon webcam panel
13:00:42 <-- mayanktg has quit (Ping timeout)
13:01:00 --> mayanktg has joined #instantbird
13:16:59 <flo-retina> clokep_work: what's the problem for us with in-content preferences landing in Firefox?
13:19:21 <-- clokep has quit (Ping timeout)
13:19:23 --> clokep has joined #instantbird
13:19:23 * ChanServ sets mode +o clokep 
13:20:52 <clokep_work> flo-retina: There's no problem.
13:27:39 <-- Rym has quit (Ping timeout)
13:30:50 <-- mayanktg has quit (Ping timeout)
13:31:19 --> mayanktg has joined #instantbird
13:33:55 <-- mayanktg has quit (Ping timeout)
13:34:16 --> mayanktg has joined #instantbird
13:39:36 <-- mayanktg has quit (Ping timeout)
13:39:55 --> mayanktg has joined #instantbird
13:49:43 <-- jb has quit (Quit: jb)
13:55:51 --> jb has joined #instantbird
13:56:08 --> Rym has joined #instantbird
13:57:53 <clokep_work> flo-retina: The conversation in #maildev with Joshua and Mark might be interesting?
13:58:15 <-- Rym has quit (Ping timeout)
14:03:52 <-- fjaeio has quit (Quit: fjaeio)
14:13:27 --> mconley has joined #instantbird
14:27:43 <-- aleth has quit (Ping timeout)
14:30:14 --> aleth has joined #instantbird
14:30:14 * ChanServ sets mode +o aleth 
14:36:39 <-- mayanktg has quit (Ping timeout)
14:38:11 --> mayanktg-ph has joined #instantbird
14:41:11 <flo-retina> clokep_work: indeed, thanks. Bug 1043795 is definitely relevant to our interests.
14:41:14 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1043795 nor, --, ---, nobody, NEW, Add IS_BUNDLE
14:41:17 <-- jb has quit (Quit: jb)
14:41:28 <flo-retina> mayanktg: so where are you with the generic button patch?
14:45:03 --> Rym has joined #instantbird
14:53:44 --> jb has joined #instantbird
15:06:16 <-- aleth has quit (Ping timeout)
15:15:12 --> mayanktg has joined #instantbird
15:21:51 <mayanktg> flo-retina: Yes I observed after your review that the gray line shifts about 2px from the current version. I will but the buttons inside the given space only. I'm working on the patch and will update it shortly.
15:34:44 <mayanktg> flo-retina: You said to add a right margin for displayNameAndToolbar class. This leaves a white space at the rightmost area of this box. Is the space left intentionally? (because I thought it to be bug and therefore i removed that white space in the patch :-( ) Sorry :-/
15:35:13 <flo-retina> it should match the current appearance
15:35:41 <mayanktg> Ok. Got it,
15:35:47 <flo-retina> that line should stop at the end of the target switcher icon
15:35:59 <flo-retina> (think of it as an underline of the icon+display name)
15:37:53 <mayanktg> Yes. I have understood it now what you're saying. :)
15:38:36 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:40:39 <-- mayanktg has quit (Ping timeout)
15:41:29 --> mayanktg has joined #instantbird
15:47:21 --> aleth has joined #instantbird
15:47:21 * ChanServ sets mode +o aleth 
15:47:43 <aleth> mayanktg: You can always post screenshots here if you need quick feedback ;)
15:55:05 <aleth> flo-retina: I don't think the current appearance can be retained entirely - there is too little room on the right hand side of the target switcher.
15:57:48 <aleth> I think what you're really after is "don't make the current total size of the conv-top bigger"
15:58:08 --> flo-retina has joined #instantbird
15:58:08 * ChanServ sets mode +qo flo-retina flo-retina 
15:58:40 <-- clokep_work has quit (Ping timeout)
15:59:08 <mayanktg> Exactly When there are multiple targets present the button looks like this http://i.imgur.com/guKWFNtl.jpg . i.e. gray line ends just below the button end. 
15:59:08 <mayanktg> But when there is no multiple targets the gray line should end below the icon. Wouldn't it cause icon to shift between two conversations?
16:00:08 <aleth> With "multiple targets" you mean "with my patch applied"? Because I can see only one icon
16:01:42 <mayanktg> Yes.
16:02:32 <aleth> mayanktg: The extra space on the right is needed because the button now looks like a button on hover. So yes, compared to the current state it will shift to the left. But the horizontal line should not change at all compared to the current state.
16:04:37 <aleth> What you don't want is the icon moving around when you hover over it ;)
16:05:55 <aleth> On your screenshot above it looks like there is 1px difference between the right button border and the horizontal line end. You could make those match.
16:06:47 --> clokep_work has joined #instantbird
16:06:47 * ChanServ sets mode +o clokep_work 
16:07:33 <mayanktg> Ok. Just to be clear when there are no "multiple targets" present the target icon should look like this http://i.imgur.com/12Nru51l.jpg ...And when we have multiple targets the button should be like this http://i.imgur.com/guKWFNtl.jpg ?
16:08:19 <mayanktg> I'll take care of the borders
16:10:04 <mayanktg> Please tell if you mean something else?
16:12:35 <-- jb has quit (Ping timeout)
16:12:52 <-- BillBinkley has quit (Ping timeout)
16:21:25 <clokep_work> mayanktg: You probably want to ping someone ther.
16:23:44 <mayanktg> Oh sorry... aleth: Please tell if you were meaning something else. I guess the best would be not to change the box size and keep the borders as they are in our present builds (i.e. they end just below the target icons).
16:26:05 <-- aleth has quit (Ping timeout)
16:29:23 --> aleth has joined #instantbird
16:29:23 * ChanServ sets mode +o aleth 
16:30:24 <aleth> mayanktg: I don't understand what you mean by multiple targets. I don't think the number of icons should make any difference
16:30:34 <-- mayanktg has quit (Ping timeout)
16:31:26 --> mayanktg has joined #instantbird
16:36:42 <mayanktg> aleth: See, this is the icon when target icon behaves like a button http://i.imgur.com/vOab1eCl.jpg. I want to know where should the gray line end when the target icon is not a button? i.e. in this case http://i.imgur.com/P91GjRDl.jpg .
16:38:49 <mayanktg> ...when it is just an icon.
16:42:21 <-- aleth has quit (Ping timeout)
16:42:29 --> BillBinkley has joined #instantbird
16:50:16 --> Mook_as has joined #instantbird
16:50:31 --> aleth has joined #instantbird
16:50:31 * ChanServ sets mode +o aleth 
16:51:34 <aleth> mayanktg: I don't think the icon should be any different when it's disabled. The gray line should always end at the same place.
16:53:10 <aleth> The target icon is just another button now with your new patch. You don't want it to move around when it's enabled or when a second button appears.
16:53:21 <aleth> Maybe I'm misunderstanding what you're asking...
16:53:47 <mayanktg> aleth: Ok. I got it. Done :)
16:54:59 <mayanktg> That's what I was asking. Maybe I tried too hard to explain it.
16:55:04 <aleth> No problem
16:55:17 <mayanktg> Looking for keeping the button active when clicked but not focused.  I will update the patch then.
16:57:28 * CAKCy is now known as CAKCy_AFK
16:59:55 <aleth> mayanktg: I think flo-retina's main concern was when the window is very small (with the smaller conv-top), that the conv-top has the same height as it does now.
17:00:06 --> jb has joined #instantbird
17:00:47 <aleth> The CSS for this case might have to be different than the CSS for the large conv-top, I don't know.
17:01:13 <mayanktg> aleth: Yes. It was caused I was keeping the height of buttons fixed to 24px. Now I'm decreasing them to fit the height of the smaller conv-top.
17:01:24 <mayanktg> *because
17:03:19 <-- aleth has quit (Ping timeout)
17:08:14 <-- mayanktg has quit (Ping timeout)
17:09:09 --> mayanktg has joined #instantbird
17:09:14 --> aleth has joined #instantbird
17:09:14 * ChanServ sets mode +o aleth 
17:17:51 <-- mayanktg has quit (Ping timeout)
17:18:12 --> mayanktg has joined #instantbird
17:21:36 <-- mayanktg has quit (Ping timeout)
17:21:59 --> mayanktg has joined #instantbird
17:27:09 <-- mayanktg has quit (Ping timeout)
17:27:32 --> mayanktg has joined #instantbird
17:31:52 <-- mayanktg has quit (Ping timeout)
17:32:21 --> mayanktg has joined #instantbird
17:43:33 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:48:02 * CAKCy_AFK is now known as CAKCy
17:52:56 <-- mayanktg has quit (Ping timeout)
17:53:37 --> mayanktg has joined #instantbird
17:56:11 <-- jb has quit (Ping timeout)
17:56:58 --> nhnt11 has joined #instantbird
18:03:21 <-- aleth has quit (Ping timeout)
18:05:57 --> aleth has joined #instantbird
18:05:57 * ChanServ sets mode +o aleth 
18:07:27 <-- Tonnes has quit (Connection reset by peer)
18:17:29 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:17:49 --> mayanktg has joined #instantbird
18:20:12 <-- aleth has quit (Ping timeout)
18:25:03 --> aleth has joined #instantbird
18:25:03 * ChanServ sets mode +o aleth 
18:28:52 <-- aleth has quit (Ping timeout)
18:29:07 --> aleth has joined #instantbird
18:29:07 * ChanServ sets mode +o aleth 
18:32:01 <-- aleth has quit (Ping timeout)
18:36:53 --> aleth has joined #instantbird
18:36:54 * ChanServ sets mode +o aleth 
18:39:27 <mayanktg> aleth: The open="true" trick worked :)
18:39:58 <aleth> Good! The way to find it was simply to look at the list of attributes on the toolbarbutton page btw.
18:43:20 <-- Armada has quit (Ping timeout)
18:50:21 <-- aleth has quit (Quit: exit stage left)
19:22:57 <-- mayanktg-ph has quit (Quit: Connection closed for inactivity)
19:25:16 --> jb has joined #instantbird
19:28:03 <-- clokep_work has quit (Ping timeout)
19:35:38 --> arlolra has joined #instantbird
19:43:29 --> clokep_work has joined #instantbird
19:43:29 * ChanServ sets mode +o clokep_work 
19:50:14 <-- mayanktg has quit (Ping timeout)
19:50:34 --> mayanktg has joined #instantbird
19:51:06 <-- Rym has quit (Ping timeout)
19:51:29 --> Rym has joined #instantbird
19:54:52 <mayanktg> flo-retina: Updating the generic buttons patch with added comment.
20:07:05 <-- arlolra has quit (Ping timeout)
20:07:13 --> arlolra has joined #instantbird
20:09:16 <-- mayanktg has quit (Ping timeout)
20:10:02 --> mayanktg has joined #instantbird
20:17:44 --> Armada has joined #instantbird
20:19:39 <-- mayanktg has quit (Ping timeout)
20:19:57 --> mayanktg has joined #instantbird
20:26:33 <-- clokep_work has quit (Ping timeout)
20:33:56 --> EionRobb has joined #instantbird
20:43:49 <-- gerard-majax_ has quit (Ping timeout)
20:50:33 <-- CAKCy has quit (Quit: Have a great day everyone!)
20:52:12 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:58:16 --> sonny has joined #instantbird
21:03:06 <-- mayanktg has quit (Ping timeout)
21:03:30 --> mayanktg has joined #instantbird
21:09:39 <-- arlolra has quit (Quit: arlolra)
21:20:08 <-- sonny has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:32:04 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:36:02 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
22:04:29 --> aleth has joined #instantbird
22:04:29 * ChanServ sets mode +o aleth 
22:31:47 <-- Bollebib has quit (Client exited)
22:37:28 <-- aleth has quit (Quit: exit stage left)
22:46:52 <-- jb has quit (Connection reset by peer)
23:25:40 <-- stux has quit (Ping timeout)
23:25:52 --> stux has joined #instantbird
23:35:41 <-- stux has quit (Ping timeout)
23:40:49 * Fallen is now known as Fallen|away
23:43:24 --> stux has joined #instantbird
23:49:51 <-- stux has quit (Ping timeout)
23:49:57 --> stux has joined #instantbird
23:53:05 <-- Armada has quit (Connection reset by peer)