#instantbird log on 07 23 2014

All times are UTC.

00:32:55 <clokep> flo-retina: I keep hitting a brick wall when looking at bug 1030059, I'd like to brainstorm tomorrow.
00:32:58 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1030059 maj, --, ---, nobody, NEW, Passwords gone in newest nightly
00:43:25 <-- mpmc has quit (Connection reset by peer)
00:54:18 <-- Mook_as has quit (Quit: Mook_as)
01:06:36 <-- Armada has quit (Connection reset by peer)
01:11:39 <-- Rym has quit (Ping timeout)
01:16:38 <-- clokep_work has quit (Ping timeout)
01:17:47 --> clokep_work has joined #instantbird
01:17:47 * ChanServ sets mode +o clokep_work 
01:18:56 --> Rym has joined #instantbird
01:24:43 <-- clokep_work has quit (Ping timeout)
01:49:57 <-- freaktechnik has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
01:57:02 <-- sawrubh has quit (Ping timeout)
02:01:34 --> sawrubh has joined #instantbird
02:33:32 --> AlexanderSalas has joined #instantbird
02:45:29 --> mconley has joined #instantbird
02:56:36 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
03:28:22 --> CAKCy has joined #instantbird
03:32:18 <instant-buildbot> build #2280 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2280
04:02:02 <-- micahg has quit (Ping timeout)
04:11:56 <instant-buildbot> build #1456 of win32-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1456
04:30:22 <-- mconley has quit (Input/output error)
04:30:51 --> mconley has joined #instantbird
04:32:43 <-- mconley has quit (Ping timeout)
04:34:00 <-- Rym has quit (Ping timeout)
05:02:50 --> Rym has joined #instantbird
05:04:54 <-- Rym has quit (Ping timeout)
05:15:57 --> Mook has joined #instantbird
05:34:15 <-- AlexanderSalas has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
05:34:23 --> AlexanderSalas has joined #instantbird
05:42:37 --> jb has joined #instantbird
05:43:13 <-- jb has quit (Input/output error)
05:44:34 --> jb has joined #instantbird
06:22:21 <-- EionRobb has quit (Quit: Leaving.)
06:28:25 --> Bollebib has joined #instantbird
06:44:25 * Fallen|away is now known as Fallen
06:54:33 <-- Mook has quit (Quit: Mook)
07:15:58 --> gerard-majax_ has joined #instantbird
07:16:40 <-- Bollebib has quit (Ping timeout)
07:20:09 <-- gerard-majax_ has quit (Ping timeout)
08:19:09 * Fallen is now known as Fallen|away
08:28:03 --> Tonnes has joined #instantbird
08:33:35 --> chrisccoulson has joined #instantbird
08:48:10 <-- Tonnes has quit (Input/output error)
08:59:34 --> Armada has joined #instantbird
09:04:36 --> Tonnes has joined #instantbird
09:21:29 --> Bollebib has joined #instantbird
09:34:28 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:35:42 --> gerard-majax_ has joined #instantbird
09:36:40 * Fallen|away is now known as Fallen
09:36:56 <-- jb has quit (Ping timeout)
10:07:26 --> flo-retina has joined #instantbird
10:07:26 * ChanServ sets mode +qo flo-retina flo-retina 
10:18:47 --> rosonline has joined #instantbird
10:19:37 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
10:20:13 --> rosonline has joined #instantbird
10:23:07 --> BWMerlin has joined #instantbird
10:26:01 --> clokep_work has joined #instantbird
10:26:01 * ChanServ sets mode +o clokep_work 
10:27:28 --> clokep has joined #instantbird
10:27:28 * ChanServ sets mode +o clokep 
10:38:04 --> aleth has joined #instantbird
10:38:04 * ChanServ sets mode +o aleth 
10:39:52 <aleth> clokep: So the password thing wasn't a simple race condition? :-(
10:43:21 <clokep> aleth: It might be...but if I try to yield for it other things in IB try to initialize and stuff explodes.
10:46:56 * clokep is hoping flo-retina has some ideas.
10:49:00 <aleth> clokep: I meant trying something like this http://pastebin.instantbird.com/754910
10:49:20 <aleth> Before figuring out what the fix would be ;)
10:51:06 --> jb has joined #instantbird
10:53:13 <clokep> aleth: So I can't figure out what's even supposed to happen.
10:53:32 <clokep> It sounds like (by reading the bugs I linked to) that it's supposed to just initialize syncrhonously if you call an API before the async init is done.
10:53:54 <aleth> Uh, then my pastebin is pointless.
10:56:02 <aleth> But if that's true, why was this needed? https://bugzilla.mozilla.org/attachment.cgi?id=8435440&action=diff :-/
10:56:47 <aleth> I guess I have no idea what asyncprompter does, so...
10:59:07 --> ogi has joined #instantbird
10:59:15 <aleth> clokep: what exactly goes wrong? What's the error returned by Services.logins.findLogins?
11:00:10 <clokep> aleth: There is NO error.
11:00:13 <clokep> I just have no passwords.
11:00:20 <aleth> Friendly.
11:00:25 <clokep> All my accounts say "A password is required to log in"
11:00:33 <clokep> Or whatever the message is that we put in the account manager.
11:01:55 <aleth> I thought you might end up in _handleMasterPasswordException
11:03:23 <clokep> There's no exception.
11:03:29 <clokep> It just reads no password, apparently.
11:03:43 <clokep> I wonder if the switch to the new format isn't working on Windows for some reason?
11:04:41 --> BillBinkley has joined #instantbird
11:05:33 <aleth> clokep: Do you have a logins.json in your profile dir?
11:05:41 <aleth> Does it look broken?
11:06:00 <aleth> It does sound like it might be a migration problem
11:06:07 <clokep> aleth: No.
11:06:40 <aleth> If you make a new profile, does everything work when you add a new account?
11:06:51 <-- rosonline has quit (Ping timeout)
11:07:15 --> rosonline has joined #instantbird
11:08:27 <clokep> I didn't try that.
11:08:58 * clokep wonders if there's a pref or something that gets set after the transition.
11:09:02 <clokep> And if it's set so it's not trying to do it again?
11:09:09 <aleth> If you look at logins.json in your mac profile you can see what it's supposed to look like
11:11:26 <aleth> clokep: not a bad suspicion http://dxr.mozilla.org/mozilla-central/source/toolkit/components/passwordmgr/storage-json.js#88
11:14:41 <-- jb has quit (Ping timeout)
11:16:48 <aleth> I wonder if the problem is that because the import is async, there is indeed a problem if we try to get a password before initialization is complete in that case.
11:17:07 <aleth> i.e. does ensureDataReady actually notice if an import is ongoing.
11:18:08 <aleth> I sort of doubt it http://dxr.mozilla.org/mozilla-central/source/toolkit/components/passwordmgr/LoginStore.jsm#232
11:18:22 <-- AlexanderSalas has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:19:53 <-- aleth has quit (Ping timeout)
11:22:17 --> aleth has joined #instantbird
11:22:17 * ChanServ sets mode +o aleth 
11:23:47 <-- rosonline has quit (Ping timeout)
11:23:53 <clokep> Bah, "signon", really?
11:23:57 --> rosonline has joined #instantbird
11:23:57 <clokep> I expected it to have "login" in it.
11:24:01 <clokep> You know, for the login manager.
11:24:16 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
11:26:54 --> Rym has joined #instantbird
11:29:28 --> clokep has joined #instantbird
11:29:33 * Fallen is now known as Fallen|away
11:29:42 <-- clokep has quit (Input/output error)
11:32:00 --> clokep has joined #instantbird
11:32:00 * ChanServ sets mode +o clokep 
11:32:36 <-- Rym has quit (Ping timeout)
11:33:20 <-- rosonline has quit (Ping timeout)
11:33:29 --> rosonline has joined #instantbird
11:34:28 <clokep> aleth: Right now I'm trying http://pastebin.instantbird.com/754914, but I get http://pastebin.instantbird.com/754913
11:35:01 <-- aleth has quit (Ping timeout)
11:36:22 --> aleth has joined #instantbird
11:36:22 * ChanServ sets mode +o aleth 
11:36:23 <clokep> And he's gone.
11:37:23 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
11:40:22 --> rosonline has joined #instantbird
11:40:38 <aleth> clokep: That's not really surprising, is it?
11:41:13 <aleth> blist.js is trying to use Services.core before it's finished initializing
11:41:23 <clokep> aleth: Yes. I feel like we have a race condition in the core of IB, honestly.
11:41:34 <clokep> But I'm still not sure IF we even need to wait for that to be initialized!
11:41:37 <aleth> I'd confirm the diagnosis before trying to fix it, personally.
11:42:44 <aleth> Just stick a bunch of dumps in storage-json.js and loginstore.jsm and you'll see what's going on.
11:44:32 <aleth> My guess is that the new login manager starts up, sets up the async migration, but before that finishes, we already access the passwords, and ensureDataReady simply creates a new logins database because the import hasn't happened yet so there isn't a logins.json there.
11:47:05 <-- rosonline has quit (Ping timeout)
11:47:07 --> rosonline has joined #instantbird
11:47:37 --> Rym has joined #instantbird
11:48:56 <-- aleth has quit (Ping timeout)
11:49:56 <-- Suiseiseki has quit (Ping timeout)
11:50:21 <clokep> aleth: I do have a logins.json now that seems t ohave gotten my passwords right.
11:50:26 --> aleth has joined #instantbird
11:50:26 * ChanServ sets mode +o aleth 
11:50:54 <clokep> aleth: And restarting again seems to have given me all my passwords back, so that sounds reasonable.
11:51:38 <-- rosonline has quit (Ping timeout)
11:52:00 --> rosonline has joined #instantbird
11:55:36 <-- rosonline has quit (Ping timeout)
11:57:36 --> rosonline has joined #instantbird
12:00:16 <nhnt11> Hello
12:00:31 <nhnt11> aleth: Actually this._woot makes sure the message group is only prepended once :]
12:01:24 <-- rosonline has quit (Ping timeout)
12:01:59 --> rosonline has joined #instantbird
12:03:17 --> mpmc has joined #instantbird
12:03:43 <-- rosonline has quit (Ping timeout)
12:05:07 --> rosonline has joined #instantbird
12:05:52 <-- BWMerlin has quit (Quit: BWMerlin)
12:06:19 <-- Rym has quit (Ping timeout)
12:07:41 <-- rosonline has quit (Ping timeout)
12:07:51 --> rosonline has joined #instantbird
12:08:03 --> Suiseiseki has joined #instantbird
12:09:32 <-- rosonline has quit (Ping timeout)
12:09:42 --> rosonline has joined #instantbird
12:11:24 <-- rosonline has quit (Ping timeout)
12:11:30 --> rosonline has joined #instantbird
12:13:59 --> freaktechnik has joined #instantbird
12:14:09 <-- rosonline has quit (Ping timeout)
12:14:12 --> rosonline has joined #instantbird
12:17:56 <-- rosonline has quit (Ping timeout)
12:18:06 --> rosonline has joined #instantbird
12:19:47 <-- rosonline has quit (Ping timeout)
12:20:15 --> rosonline has joined #instantbird
12:21:57 <-- rosonline has quit (Ping timeout)
12:23:23 --> rosonline has joined #instantbird
12:25:40 <nhnt11> So I'm starting off today with the log indexing stuff that's left (closing the db connection when inactive)
12:25:53 <clokep> good.
12:26:24 <nhnt11> flo-retina: Should I hurry up with the log indexing stuff (i.e. will you have time for a review soonish?) or should I continue with the prepending?
12:27:14 <-- rosonline has quit (Ping timeout)
12:29:19 <flo-retina> nhnt11: tonight my priority will be to get the two new Linux slave to work with buildbot and restore Linux nightlies
12:29:38 <flo-retina> I can probably review your patch tomorrow evening
12:29:44 <nhnt11> Okay, I expected that.
12:29:45 <nhnt11> Great.
12:29:52 <nhnt11> So I'll get a patch up before bed for indexing..
12:30:22 --> rosonline has joined #instantbird
12:32:07 <-- rosonline has quit (Ping timeout)
12:32:43 --> rosonline has joined #instantbird
12:34:26 <-- rosonline has quit (Ping timeout)
12:34:37 --> rosonline has joined #instantbird
12:35:41 --> Rym has joined #instantbird
12:36:12 <-- nhnt11 has quit (Ping timeout)
12:36:15 --> nhnt11 has joined #instantbird
12:37:42 <-- Rym has quit (Ping timeout)
12:38:19 <-- rosonline has quit (Ping timeout)
12:38:34 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:42:09 <-- flo-retina has quit (Ping timeout)
12:43:51 --> flo-retina has joined #instantbird
12:43:51 * ChanServ sets mode +qo flo-retina flo-retina 
12:44:19 <flo-retina> clokep: so, are you still seeking help/ideas for that password manager issue?
12:44:39 <clokep> flo-retina: I think so, I was in the middle of writing a summary of what I've found first though.
12:48:00 <flo-retina> ok
12:50:26 <-- nhnt11 has quit (Ping timeout)
12:50:30 --> nhnt11 has joined #instantbird
12:52:49 --> jb has joined #instantbird
12:53:51 <clokep> flo-retina: https://bugzilla.mozilla.org/show_bug.cgi?id=1030059#c4
12:53:54 <instantbot> Bug 1030059 maj, --, ---, nobody, NEW, Passwords gone in newest nightly
13:00:38 <flo-retina> clokep: oh, so the issue is only on the first startup after an upgrade?
13:01:14 <clokep> flo-retina: It seems to be, yep!
13:01:27 <clokep> I think I had messed up my profile by deleting logins.json while testing things but never resetting the pref.
13:02:17 <flo-retina> hmm, do you mean the bug only occurs if the user has messed with the profile by hand?
13:02:23 <clokep> No.
13:02:28 <clokep> I'm saying that's why it was occurring EVERY time.
13:02:33 <clokep> Initially.
13:03:06 <flo-retina> ah!
13:03:32 <flo-retina> clokep: one thing I was thinking, is that we use passwords very early in the startup, when Firefox probably doesn't until a webpage has loaded
13:04:01 <clokep> flo-retina: Yes! We do. Thunderbird does too though, which is why I initially looked into the patch Joshua had created.
13:04:28 <flo-retina> are we sure Thunderbird doesn't have the bug too?
13:04:30 <-- nhnt11 has quit (Ping timeout)
13:04:54 <clokep> No.
13:05:27 <aleth> I think this bug could in principle happen on all OS, it being a race condition essentially.
13:06:03 --> nhnt11 has joined #instantbird
13:06:38 --> sonny has joined #instantbird
13:06:55 --> sonny1 has joined #instantbird
13:07:44 --> mayanktg has joined #instantbird
13:08:26 <-- sonny has quit (Ping timeout)
13:08:34 <-- sonny1 has quit (Client exited)
13:13:20 <instantbot> ryanvm@gmail.com changed the Resolution on bug 1042040 from --- to FIXED.
13:13:21 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1042040 nor, --, ---, mayanktg, RESO FIXED, Define a function to generate unique ID for the XML Stanza which MUST have uniquely generated id/sid
13:15:43 <clokep> mayanktg, sawrubh: So you guys should rebase any patches you have to use that function.
13:15:44 <clokep> Thanks!
13:18:16 <mayanktg> Yes. I'll update the video call patch today by answering your queries and also by using the new generateId() .
13:22:33 <clokep> mayanktg: Excellent!
13:22:55 <flo-retina> oh, Ryan is doing c-c checkins again? :)
13:23:10 <clokep> Apparently.
13:23:18 <clokep> It's approval needed so...
13:23:26 <flo-retina> yeah, "a=me" seems convenient ;)
13:31:51 <-- flo-retina has quit (Ping timeout)
13:31:55 <aleth> clokep: How about queueing just the connection of the accounts on the login initialization promise? Then nothing should break in blist etc. as all the services can be up and running synchronously
13:33:57 <clokep> aleth: That might work, I assume you mean essentially yielding at https://mxr.mozilla.org/comm-central/source/chat/components/src/imCore.js#265
13:34:40 <aleth> No, I think you want all those services to init.
13:35:00 <aleth> Yielding here might be enough https://mxr.mozilla.org/comm-central/source/chat/components/src/imCore.js#271
13:35:20 --> flo-retina has joined #instantbird
13:35:20 * ChanServ sets mode +qo flo-retina flo-retina 
13:35:56 <aleth> Better than yielding, just stick the contents of the if clause in a then() on the initialization promise.
13:36:31 <aleth> Or maybe even cleaner, do that here https://mxr.mozilla.org/comm-central/source/chat/components/src/imAccounts.js#964
13:37:38 <clokep> aleth: Let's not discuss using then or yielding, it's the same thing.
13:38:13 <aleth> clokep: Not quite - if you make the whole thing a task, the event loop will spin at least once before it starts to run afaik.
13:38:20 <clokep> aleth: What happens if someone doesn't have auto-logins and hits connect really fast? :-D
13:38:21 --> qheaden has joined #instantbird
13:38:30 <qheaden> Hello. :)
13:38:32 <clokep> aleth: OK, but they're essentially the same.
13:38:36 <clokep> Implementation details
13:38:52 <aleth> clokep: This kind of thing matters if the next thing of the event loop is the blist ;)
13:39:11 <aleth> i.e. if you call init() and nothing is done apart from scheduling the task.
13:39:44 <aleth> clokep: You're right, maybe the yield/then should be somewhere in connect() or whereever getpassword is called ;)
13:44:27 <clokep> aleth: I don't see how it matters /at all/ whether the event loop spins at all.
13:44:34 <qheaden> clokep: You mentioned me reviewing code. Is there any current code that needs review?
13:45:25 <aleth> clokep: Before, you got an error in blist because Services.core.init() hadn't finished running. So if all init() does is schedule a task, you'll probably get that same error again.
13:46:38 <aleth> But never mind.
13:51:03 <aleth> (To put it another way, I may be wrong but I think your mental model is that when you use Task.async to write an async function, everything up to the first yield runs synchronously. It doesn't.)
13:55:54 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:56:00 --> nhnt11 has joined #instantbird
13:57:02 <clokep> aleth: It was, but you corrected me. But my point is that in this case it /doesn't matter/.
14:03:14 --> mconley has joined #instantbird
14:10:41 <flo-retina> ah, there are new reporters in about:memory
14:10:57 <flo-retina> blist.xul has 865 event-listeners but only 2 event-targets
14:10:59 <flo-retina> that's strange
14:11:25 <flo-retina> hmm, I'm not sure I actually trust that event-targets count
14:13:42 <-- jb has quit (Ping timeout)
14:14:37 <clokep> aleth: So putting it just at the autologin point had no errors, but the account manager still said I had to enter passwords.
14:14:49 <clokep> But clsoing that reopening it "worked" and the password was actually in the properties if I clicked on it.
14:15:01 --> jb has joined #instantbird
14:15:59 <clokep> So that's uhhh...some progress.
14:16:21 <flo-retina> │  │  │  │       ├──0.04 MB (00.01%) ++ string(length=143, copies=259, "<span left="true" class="ib-nick">reyre</span> [<span left="true" class="ib-nick">reyre</span>@6A6344CE.2BBBD1AD.5670445F.IP] entered the room.")
14:16:21 <flo-retina> │  │  │  │       ├──0.04 MB (00.01%) ++ string(length=89, copies=318, "<span left="true" class="ib-nick">mayanktg</span> has left the room (Quit: Ping timeout).")
14:16:21 <flo-retina> │  │  │  │       ├──0.03 MB (00.01%) ++ string(length=61, copies=402, "reyre [reyre@6A6344CE.2BBBD1AD.5670445F.IP] entered the room.")
14:16:21 <flo-retina> │  │  │  │       ├──0.03 MB (00.01%) ++ string(length=51, copies=396, "reyre has left the room (Quit: Max SendQ exceeded).")
14:16:21 <flo-retina> Surprising notable strings.
14:16:49 <clokep> Copies of things up in the 400s?! :-S
14:17:34 <flo-retina> mayanktg is in 3 channels where I am. 318 copies means he has left with "Quit: Ping timeout" 106 times since I started Instantbird.
14:18:09 <flo-retina> we are probably coping the string around a few times while adding emoticons and filtering unwanted HTML markup
14:18:18 <flo-retina> but still... there's something that seems wrong
14:18:46 <flo-retina> as that should be garbage collected
14:19:28 <clokep> Probably.
14:21:18 <flo-retina> bah... checking the log, that's correct, he actually left with that quit message 106 time since Monday.
14:21:20 <-- jb has quit (Ping timeout)
14:21:29 <flo-retina> :-S
14:21:39 <flo-retina> nhnt11: we need infinite scroll to get rid of these messages from memory ;)
14:22:11 --> jb has joined #instantbird
14:22:29 <nhnt11> Yeah
14:22:34 <mayanktg> Sorry guys. My poor internet. :(
14:23:48 --> jb1 has joined #instantbird
14:23:51 <-- jb has quit (Ping timeout)
14:27:43 <nhnt11> aleth: Does this look correct? https://pastebin.mozilla.org/5595951
14:27:56 <nhnt11> Just wanted another pair of eyes to look at it to be sure.
14:28:51 <nhnt11> The code assumes that all database transactions are queued using gDatabase.queueOperation
14:30:47 <nhnt11> Hmm, I think the clearTimeout call eliminates the need for the check in line 14
14:34:11 <-- aleth has quit (Ping timeout)
14:38:26 <clokep_work> flo-retina: Do we think bug 1036894 (which just landed on m-c) will bust us at all...I'm checking now, but it doesn't seem so..
14:38:29 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1036894 nor, --, mozilla34, mh+mozilla, RESO FIXED, Move in-tree library linkage information to moz.build
14:39:41 <clokep_work> Hm...looks like we use EXTRA_DSO_LDOPTS
14:42:52 * clokep_work suspects we'll be OK until bug 882908 lands.
14:42:56 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=882908 nor, --, ---, nobody, NEW, move OS_LIBS, EXTRA_LIS and OS_LDFLAGS to moz.build
14:44:21 * nhnt11 racks his brain to figure out if it's possible for the close timer to fire when something is yielding on getConn()
14:45:40 <flo-retina> clokep_work: I wouldn't be surprised if we had to look at our libpurple prpl linking strategy again due to these bugs
14:46:10 * clokep_work hopes we can get linux builds before that happens. :)
14:48:26 <flo-retina> if it's planned to happen today, it will be a race ;)
14:54:40 <clokep_work> :( https://hg.mozilla.org/mozilla-central/rev/9565dc1c02c6#l22.156 is busting us
15:02:06 <flo-retina> what's the problem?
15:06:08 --> Rym has joined #instantbird
15:09:41 <clokep_work> flo-retina: You can't define IS_COMPONENT and FORCE_SHARED_LIB at the same time.
15:10:23 <flo-retina> then just remove FORCE_SHARED_LIB
15:10:28 <flo-retina> see line 22.168
15:10:33 <clokep_work> I know. :P
15:10:35 <clokep_work> I'm working on it.
15:10:36 <flo-retina> IS_COMPONENT now _implies_ SHARED_LIB
15:11:14 <clokep_work> I know what the fix is! I'm just saying we have to do it.
15:11:16 <clokep_work> My build is going now.
15:11:24 <clokep_work> I was just complaining about it. ;)
15:12:01 <flo-retina> clokep_work: I was afraid of a more serious bustage than "we need to clean up some of our cruft" ;)
15:16:19 <clokep_work> flo-retina: Bah: " 0:15.94 /Users/pcloke/mozilla/comm-central/mozilla/config/recurse.mk:11: *** Variable EXTRA_DSO_LDOPTS is defined in /Users/pcloke/mozilla/comm-central/obj-x86_64-apple-darwin13.2.0/mozilla/extensions/purple/purplexpcom/src/Makefile. It should only be defined in moz.build files.  Stop." It seems like there's a commit https://hg.mozilla.org/integration/mozilla-inbound/rev/a0988e587a90 that c
15:16:30 <clokep_work> But I could just try moving it to moz.build; any thoughts?
15:18:02 <flo-retina> moving to moz.build seems reasonable
15:19:10 <clokep_work> Are things like XPCOM_GLUE_LDOPTS defined for moz.build files?
15:19:15 <clokep_work> Doesn't seem to be in config.status.
15:19:28 <flo-retina> probably not
15:19:52 <flo-retina> I think glandium's email to dev-platform had something about it
15:20:29 <-- mayanktg has quit (Ping timeout)
15:20:30 <flo-retina> clokep_work: btw, it should be pretty obvious that a component requires linking to the xpcom glue, so it's possible moz.build stuff will just do the right thing automagically
15:20:49 --> mayanktg has joined #instantbird
15:23:21 <flo-retina> clokep_work: $(XPCOM_GLUE_LDOPTS) doesn't seem to exist anymore in m-c, all I find is in c-c: http://mxr.mozilla.org/comm-central/search?string=xpcom_glue_ldopts
15:23:27 <flo-retina> I suspect that line was already deadcode
15:24:13 <clokep_work> Ah, interesting.
15:25:53 <clokep_work> flo-retina: There's also http://hg.mozilla.org/users/florian_queze.net/purple/file/956f01125ef6/purplexpcom/src/Makefile.in#l51
15:26:07 <flo-retina> this one I think we need to keep
15:26:17 <flo-retina> I looked at it a few minutes ago, and looked puzzled ;)
15:26:35 <flo-retina> but I think it's so that other libraries can link to our library
15:26:41 <flo-retina> ie. that's the dynamic-prpls case
15:28:14 <clokep_work> Luckily debug builds do both dynamic and static prpls. :)
15:29:37 <-- mayanktg has quit (Ping timeout)
15:29:56 --> mayanktg has joined #instantbird
15:33:57 <-- gerard-majax_ has quit (Ping timeout)
15:35:09 --> aleth has joined #instantbird
15:35:10 * ChanServ sets mode +o aleth 
15:36:43 <flo-retina> :)
15:37:12 <flo-retina> unfortunately we are not going to have enough minis to do debug builds on commit
15:37:21 <flo-retina> hmm, or maybe we should use the "release" minis for that?
15:37:35 <aleth> clokep: I guess this also needs to be changed http://mxr.mozilla.org/comm-central/source/im/content/account.js#25
15:38:57 <clokep_work> aleth: Or maybe we should add it to getting the password like you suggested?
15:39:33 <clokep_work> qheaden: So my review queue is empty, I'm sure flo-retina has things to review. Not sure if any of them are reasonable or not, of course. :)
15:39:33 <aleth> clokep_work: That would be cleaner, but then you'd have to change all the consumers because getPassword would return a promise
15:39:39 <clokep_work> Plus anything from our GSoC students.
15:39:40 <-- Bollebib has quit (Ping timeout)
15:39:47 <clokep_work> aleth: Yes.
15:39:53 <aleth> clokep_work: Probably the right thing to do, but more work ;)
15:44:13 <nhnt11> aleth: http://log.bezut.info/instantbird/today/#m291
15:48:29 <-- clokep_work has quit (Ping timeout)
15:48:39 <-- clokep has quit (Ping timeout)
15:54:14 --> clokep_work has joined #instantbird
15:54:14 * ChanServ sets mode +o clokep_work 
15:54:18 --> clokep has joined #instantbird
15:54:18 * ChanServ sets mode +o clokep 
16:02:11 <clokep_work> flo-retina: http://pastebin.instantbird.com/755031 What's -bundle directive?
16:02:26 <aleth> nhnt11: isn't this enough? http://pastebin.instantbird.com/755030
16:02:35 <clokep_work> And why were we not getting it before. :P
16:05:10 <-- mayanktg has quit (Ping timeout)
16:05:59 <-- clokep_work has quit (Ping timeout)
16:06:17 <-- clokep has quit (Ping timeout)
16:06:21 --> clokep_work has joined #instantbird
16:06:21 * ChanServ sets mode +o clokep_work 
16:06:21 --> mayanktg has joined #instantbird
16:06:31 --> clokep has joined #instantbird
16:06:31 * ChanServ sets mode +o clokep 
16:07:14 --> iamjayakumars__ has joined #instantbird
16:08:30 --> mpmc has joined #instantbird
16:08:46 <nhnt11> aleth: What if the close timer fires before the promise resolves?
16:09:16 <-- aleth has quit (Ping timeout)
16:09:34 <nhnt11> It's possible the promise is a Task containing multiple yields. One of those yields may be enough for the timer to fire, causing the connection to close in the middle of the Task
16:13:48 * iamjayakumars__ is now known as iamjayakumars_
16:14:59 <-- iamjayakumars_ has quit (Quit: )
16:15:05 --> iamjayakumars__ has joined #instantbird
16:16:12 <-- iamjayakumars__ has quit (Client exited)
16:16:23 --> iamjayakumars_ has joined #instantbird
16:17:22 <-- mayanktg has quit (Ping timeout)
16:17:39 --> mayanktg has joined #instantbird
16:18:29 --> aleth has joined #instantbird
16:18:30 * ChanServ sets mode +o aleth 
16:19:58 <-- iamjayakumars_ has quit (Quit: )
16:20:10 --> iamjayakumars_ has joined #instantbird
16:20:43 * clokep_work just tried to use in-line markdown.
16:20:45 <clokep_work> Fail.
16:21:17 <aleth> nhnt11: I don't understand what you mean.
16:22:24 <flo-retina> clokep_work: I think http://docstore.mik.ua/orelly/unix3/mac/ch05_03.htm explains it... but I don't understand the meaning of that explanation :-S
16:22:33 <aleth> nhnt11: There's a bug in that pastebin by the way, this._dbqueue is never set.
16:22:53 <aleth> clokep_work: are you using USE_LIBS now?
16:23:42 <clokep_work> flo-retina: I found it a bit confusing too. :-\ is it trying to build a static component instead of a dynamic one or something?
16:24:57 <clokep_work> aleth: http://pastebin.instantbird.com/755033 is my current diff.
16:25:03 <clokep_work> Both purple and c-c are in there
16:25:08 <clokep_work> So...sme of the paths are funky. :-D
16:27:51 <flo-retina> clokep_work: so is http://mxr.mozilla.org/comm-central/source/mozilla/config/rules.mk#406 the problem?
16:29:01 <clokep_work> flo-retina: Looks like it, also looks like we shouldn't even be providing EXTRA_DSO_LDOPTS at all since it's all done magically?
16:29:17 <flo-retina> clokep_work: not directly related to your error, I see on your linker command line in the first pastebin: -install_name @executable_path/components/purplexpcom
16:29:22 <flo-retina> shouldn't that be libpurplexpcom.dylib?
16:29:35 <clokep_work> Yes, it should. Youre right.
16:29:45 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:30:30 <-- mayanktg has quit (Ping timeout)
16:31:16 <aleth> clokep_work: https://groups.google.com/forum/#!topic/mozilla.dev.platform/AIMU8KoS0Os seems to suggest USE_LIBS in moz.build would be enough for the dynamic linked ones?
16:31:21 --> mayanktg has joined #instantbird
16:39:21 * flo-retina isn't sure what you all are trying to do
16:39:50 <flo-retina> but libpurplexpcom.dylib is "special" in that it is loaded as an xpcom component AND is used as a shared library by dynamic prpls.
16:42:18 <clokep_work> flo-retina: I'm pretty sure it's obvious what we're trying to do: get it to build.
16:42:49 <flo-retina> ok, do it then :-D
16:42:56 <clokep_work> I'm stuck at this point...
16:42:58 <clokep_work> But doing real work.
16:44:33 <-- freaktechnik has quit (Ping timeout)
16:45:22 --> freaktechnik has joined #instantbird
16:52:49 <-- iamjayakumars_ has quit (Client exited)
16:53:17 --> Mook_as has joined #instantbird
16:57:41 --> mpmc has joined #instantbird
16:58:09 <-- aleth has quit (Quit: exit stage left)
16:58:21 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:00:32 <sawrubh> bah, I just updated my repo (silly move I know but I normally do it whenever a related patch lands, in this case mayanktg's generateId one) and bam I get this error: http://pastebin.instantbird.com/755054
17:00:57 <nhnt11> aleth: Operation1 gets queued. Before it completes, Op2 gets queued. When Op1 completes, the timer is set. Op2 is still doing whatever it's doing, and takes longer than 5 minutes. By this time, the timer fires and closes the db connection. Whatever's left in Op2 fails.
17:01:06 <sawrubh> I should have instead just continued qpushing his mq (I dislike it and hence decided to update)
17:01:31 <sawrubh> hmm, seems people have had that problem already
17:01:34 * nhnt11 is confusing himself
17:01:39 * sawrubh reads scrollback
17:01:41 <-- qheaden has quit (Quit: http://www.mibbit.com ajax IRC Client)
17:01:55 <clokep_work> sawrubh: You could have just pulled c-c and not m-c.
17:02:13 <clokep_work> sawrubh: And yse, we're busted. I'd prefer you roll back m-c and continue working on your project.
17:02:15 <sawrubh> I do a client.py checkout
17:02:17 <clokep_work> I ahve a partial fix for the issues though.
17:02:23 <sawrubh> and yes I know that's a sily move
17:02:26 <sawrubh> *silly
17:03:00 <-- Rym has quit (Ping timeout)
17:03:16 * sawrubh goes to look how to roll back m-c
17:03:25 <sawrubh> just hg revert commit id should work right?
17:03:47 <nhnt11> sawrubh: I think it's hg backout.
17:04:00 <nhnt11> And you'll need to know the exact commit that broke things (could be more than one? idk)
17:05:23 <clokep_work> sawrubh: |hg update -R <rev>|
17:05:42 <clokep_work> Don't bother with the exact revision, just use an older revision.
17:05:52 <clokep_work> It'll make it easier when you do finally update too.
17:07:29 <nhnt11> clokep_work: That's awesome, thanks.
17:07:37 * nhnt11 wonders why he didn't think of that
17:08:15 <clokep_work> nhnt11: That's what you pay me for..
17:08:37 --> Rym has joined #instantbird
17:08:43 <clokep_work> Wait...I'm not being paid for this. :-S
17:08:51 * nhnt11 sends clokep_work a cheque
17:10:27 <-- mayanktg has quit (Ping timeout)
17:11:33 --> mayanktg has joined #instantbird
17:22:30 <-- jb1 has quit (Ping timeout)
17:22:51 <clokep_work> nhnt11: Thanks. :P
17:29:10 <-- mayanktg has quit (Ping timeout)
17:29:38 --> mayanktg has joined #instantbird
17:32:12 <-- mayanktg has quit (Ping timeout)
17:32:33 --> mayanktg has joined #instantbird
17:45:22 <-- Mook_as has quit (Quit: Mook_as)
17:47:22 --> Mook_as has joined #instantbird
17:57:33 --> Bollebib has joined #instantbird
18:08:24 <mayanktg> Bah, why I'm unable to use this.LOG in xmpp-jingle.jsm file. even upon adding the jsProtoHelper.jsm module. :-/
18:08:24 <mayanktg> http://pastebin.instantbird.com/755076 (L12 and L50)
18:31:19 * Fallen|away is now known as Fallen
18:45:00 <-- freaktechnik has quit (Ping timeout)
18:46:44 <-- nhnt11 has quit (Ping timeout)
18:46:47 --> nhnt11 has joined #instantbird
18:52:40 <-- mayanktg has quit (Ping timeout)
18:52:56 --> mayanktg has joined #instantbird
18:54:28 <nhnt11> brb
18:59:07 <-- mayanktg has quit (Ping timeout)
18:59:29 --> mayanktg has joined #instantbird
19:09:22 <-- Rym has quit (Ping timeout)
19:09:55 <clokep_work> mayanktg: That makes no sense.
19:10:06 <clokep_work> Including jsProtoHelper has nothing to do w/ defining LOG AFAIK.
19:10:51 <-- mayanktg has quit (Ping timeout)
19:11:02 <clokep_work> mayanktg: https://mxr.mozilla.org/comm-central/source/chat/modules/jsProtoHelper.jsm#32 is where it gets initialized, but it's for the account object, not every object.
19:11:55 --> mayanktg has joined #instantbird
19:14:33 <-- mayanktg has quit (Ping timeout)
19:15:18 --> mayanktg has joined #instantbird
19:15:34 <flo-retina> is there an easy way for hg diff to ignore only _trailing_ whitespace?
19:16:29 <clokep_work> Not that I know of.
19:16:41 <clokep_work> -w ignores whitespace only changes, I think.
19:16:52 <flo-retina> yeah, but I re-indented a few lines
19:18:22 <clokep> :-\ I don't know then, sorry.
19:20:17 <clokep_work> flo-retina: There's also "-b" which is "Ignore changes in the amount of white space" that might work
19:20:26 <clokep_work> ALthough I'm unsure if \r|\n count as whitespace for that.
19:20:29 <flo-retina> that skips my reindented lines
19:20:32 <clokep_work> :(
19:20:42 <flo-retina> I had already tried these two
19:21:13 <-- mayanktg has quit (Ping timeout)
19:21:38 --> mayanktg has joined #instantbird
19:21:44 <clokep_work> sed w/ some magic? ;)
19:21:51 <clokep_work> I don't think there's something in this case. Sorry.
19:22:26 <flo-retina> I think I'll just hand edit the diff
19:22:36 <clokep_work> That thing you always yell at us for? :-D
19:22:38 <flo-retina> and try harder to make my editor not kill trailing whitespace next time
19:22:48 <flo-retina> clokep_work: but I do it correctly ;-)
19:22:54 <clokep_work> Komodo lets you strip whitespaces from /only/ edited lines.
19:22:55 <clokep_work> Which is nice. :)
19:23:07 <flo-retina> yeah, that's the behavior I want
19:23:31 <flo-retina> I found an emacs module doing that, but I've yet to install it (ie. find a good time to restart my editor; which I restart as rarely as my browser ;))
19:24:06 <flo-retina> clokep_work: another solution would be to purposefully clear the whitespace on these files in a different copy of the tree, and then do an interdiff :-D
19:25:21 <clokep_work> flo-retina: That could do it, yes.
19:26:08 --> jb has joined #instantbird
19:32:05 <-- mayanktg has quit (Ping timeout)
19:32:52 --> mayanktg has joined #instantbird
19:33:39 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:38:56 <-- mayanktg has quit (Ping timeout)
19:40:10 --> mayanktg has joined #instantbird
19:54:06 <-- mayanktg has quit (Ping timeout)
19:55:13 --> mayanktg has joined #instantbird
19:57:55 --> flo-retina has joined #instantbird
19:57:55 * ChanServ sets mode +qo flo-retina flo-retina 
20:10:56 <-- Armada has quit (Ping timeout)
20:12:52 <-- ogi has quit (Client exited)
20:15:40 <-- mayanktg has quit (Ping timeout)
20:16:01 --> mayanktg has joined #instantbird
20:16:56 --> EionRobb has joined #instantbird
20:27:17 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:27:28 --> nhnt11 has joined #instantbird
20:39:05 --> Armada has joined #instantbird
20:40:28 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
20:41:05 * Fallen is now known as Fallen|away
20:41:15 --> chrisccoulson has joined #instantbird
20:58:33 <-- mayanktg has quit (Ping timeout)
20:59:25 --> mayanktg has joined #instantbird
21:04:18 <-- mayanktg has quit (Ping timeout)
21:18:52 <alexis> haha, I just got a message "prpl-irc: Unused mode parameters: fckidiots!*@"
21:32:35 --> Rym has joined #instantbird
21:33:27 <-- CAKCy has quit (Quit: Have a great day everyone!)
21:38:34 --> rosonline has joined #instantbird
21:38:45 <EionRobb> lol
21:46:17 <flo-retina> alexis: that's a good one! :)
21:55:09 <-- Armada has quit (Ping timeout)
22:00:07 <-- mconley has quit (Input/output error)
22:01:43 --> Armada has joined #instantbird
22:20:03 <-- Rym has quit (Ping timeout)
22:25:07 <flo-retina> hmm
22:25:19 <flo-retina> almost too easy to be true. The slave started a nightly before I even wanted it
22:25:31 <flo-retina> it will obviously fail due to the unappropriate mozconfig though
22:32:21 <-- Mook_as has quit (Quit: Mook_as)
22:35:32 --> Mook_as has joined #instantbird
22:35:43 <instant-buildbot> build #1097 of linux-nightly-default is complete: Failure [4failed shell_1 shell_2]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1097
22:45:09 <-- rosonline has quit (Ping timeout)
22:46:58 <instant-buildbot> build #1098 of linux-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1098
22:47:37 --> rosonline has joined #instantbird
22:48:37 --> Rym has joined #instantbird
22:50:38 <-- Rym has quit (Ping timeout)
22:57:07 --> Rym has joined #instantbird
23:05:00 <flo-retina> clokep, clokep_work: http://pastebin.instantbird.com/755222 rs?
23:09:47 <alexis> clokep cool to see you're using pelican :-)
23:10:26 * flo-retina is probably not going to wait much before checking that in without review :-]
23:13:53 <flo-retina> If someone disliked that change, it's too late: https://hg.mozilla.org/comm-central/rev/b533b6092f82
23:15:00 <instant-buildbot> build #1099 of linux-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1099
23:21:57 <-- Armada has quit (Connection reset by peer)
23:22:26 <instant-buildbot> build #1100 of linux-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1100
23:24:42 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
23:28:06 <-- instant-buildbot has quit (Input/output error)
23:28:11 --> instant-buildbot has joined #instantbird
23:28:11 * ChanServ sets mode +v instant-buildbot 
23:28:41 <instant-buildbot> build #1101 of linux-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1101
23:29:42 <clokep> flo-retina: "which: no python2.7 in (/usr/bin:/bin)"
23:29:45 <clokep> Sounds like a fun error.
23:30:35 <-- instant-buildbot has quit (Input/output error)
23:30:40 --> instant-buildbot has joined #instantbird
23:30:40 * ChanServ sets mode +v instant-buildbot 
23:31:03 <clokep> alexis: Did you just find my blog or...?
23:31:11 <flo-retina> clokep: have you figured out the build issues?
23:31:47 <clokep> flo-retina: No, do you want what I have so far?
23:31:52 <alexis> clokep: ah, I'm not actively developing pelican but I'm still receiving emails about it
23:32:09 <alexis> clokep: and I just found out your name in an email about a theme (or a plugin I don't remember) today
23:32:14 <flo-retina> clokep: not really; I would just like to have a linux nightly tomorrow ;)
23:32:35 <clokep> flo-retina: I was going to work on it soon and rs=bustage-fix it if I can get something to work.
23:32:41 <clokep> But I'm stuck on that -bundle thing.
23:32:48 <clokep> alexis: Yes, a plug-in.
23:32:52 <clokep> Were you a developer of pelican?
23:33:24 <alexis> clokep: I'm the original author.
23:33:41 <flo-retina> :)
23:33:41 <clokep> alexis: Ah, cool. :)
23:33:43 <clokep> Well it's neat.
23:33:55 <-- Rym has quit (Ping timeout)
23:34:17 <alexis> clokep: fun to see a lot of people using it. It just started like that: http://blog.notmyidea.org/pelican-a-simple-static-blog-generator-in-python.html
23:34:48 <clokep> :)
23:35:04 <alexis> it feels a bit bloated nowadays :p
23:35:29 <instant-buildbot> build #1102 of linux-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1102
23:35:55 <clokep> Haha, less bloated than....WordPress. ;)
23:36:29 * flo-retina shrugs
23:36:31 <alexis> heh
23:36:40 <flo-retina> configure: error: Library requirements (avahi-client avahi-glib) not met
23:36:54 <alexis> I love to see the project maintained without needing to do anything, I won :)
23:36:58 <alexis> open source won :)
23:37:02 <flo-retina> btw, I'm probably not going to try making Linux64 nightlies this night
23:37:23 <flo-retina> if I get linux32 builds running, that will already be good
23:38:03 <alexis> flo-retina: neat :)
23:38:14 <alexis> remembers me it's been a while since I updated instantbird
23:38:37 <flo-retina> alexis: have you seen our new build hardware? http://queze.net/goinfre/minis/
23:39:27 <alexis> wow neat!
23:39:38 <alexis> 10 machines?!
23:39:42 <alexis> celebrity!
23:40:05 <flo-retina> I think I requested 20
23:40:16 <flo-retina> but we got 10, and that's already going to be very useful :)
23:42:00 <instant-buildbot> build #1103 of linux-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1103
23:42:16 <flo-retina> "configure: error: Could not find krb5. To build without Kerberos, reconfigure with --disable-kerberos."
23:42:18 <flo-retina> clokep: is that your stuff?
23:42:19 <clokep> Avahi! :-D
23:42:33 <clokep> flo-retina: That's Lync, yes.
23:42:54 <flo-retina> I guess yum install krb5-devel won't hurt ^^
23:43:33 <flo-retina> that's installing plenty of dependencies
23:43:55 <flo-retina> 23 packages, 29MB to download
23:43:59 <clokep> =-o
23:46:59 <instant-buildbot> build #1104 of linux-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1104
23:48:46 <flo-retina> ahah!
23:48:52 <flo-retina>     IS_COMPONENT implies FORCE_SHARED_LIB. Please remove the latter.
23:49:00 <flo-retina> looks like it's not my builder's fault this time!
23:49:43 <clokep> :)
23:50:14 <clokep_work> flo-retina: So I think I've hit SOME of those.
23:50:22 <clokep_work> But I can't get Mac to finish building, it's possible Linux will w/ my patch.
23:50:37 <flo-retina> pastebin?
23:50:42 <clokep_work> k one second
23:50:51 <flo-retina> or file a bug :)
23:51:35 <clokep_work> flo-retina: http://pastebin.instantbird.com/755244 and http://pastebin.instantbird.com/755243
23:51:41 <clokep_work> Yes, I actually have the new bug page open!
23:51:53 <clokep> alexis: Well thanks, it's neat software. :)
23:52:21 <alexis> clokep: cool to see it used!
23:53:50 <instantbot> New Instantbird - Other bug 1043045 filed by clokep@gmail.com.
23:53:51 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1043045 nor, --, ---, nobody, NEW, Port |Bug 1036894 - Move in-tree library linkage information to moz.build| to im
23:54:15 --> AlexanderSalas has joined #instantbird
23:54:18 <clokep> flo-retina: ^
23:55:04 * clokep needs to eat.