#instantbird log on 07 14 2014

All times are UTC.

00:08:07 --> zen_monkey has joined #instantbird
00:20:26 <-- Rym has quit (Ping timeout)
00:20:41 --> Rym has joined #instantbird
00:25:18 <-- Rym has quit (Ping timeout)
00:25:41 --> Rym has joined #instantbird
00:37:24 <-- wnayes has quit (Ping timeout)
00:37:46 --> wnayes has joined #instantbird
01:01:28 <-- zen_monkey has left #instantbird (Saliendo)
02:15:13 <instant-buildbot> build #1442 of win32-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1442
02:37:17 <-- wnayes has quit (Ping timeout)
02:37:38 --> wnayes has joined #instantbird
02:40:21 <-- Rym has quit (Ping timeout)
03:10:32 <-- wnayes has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
03:14:48 <-- mconley has quit (Input/output error)
03:24:39 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
03:34:15 <instant-buildbot> build #2259 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2259
04:18:04 --> CAKCy has joined #instantbird
04:20:37 --> mconley has joined #instantbird
04:53:29 <-- Tonnes has quit (Quit: ChatZilla [Firefox 30.0/20140605174243])
05:01:02 <-- mconley has quit (Input/output error)
05:08:22 * Fallen|away is now known as Fallen
05:28:26 <-- EionRobb has quit (Quit: Leaving.)
05:34:03 --> Rym has joined #instantbird
05:49:19 * Fallen is now known as Fallen|away
05:50:42 * Fallen|away is now known as Fallen
06:29:18 <-- nhnt11 has quit (Ping timeout)
06:29:41 --> nhnt11 has joined #instantbird
06:31:19 --> jb has joined #instantbird
06:48:54 --> EionRobb has joined #instantbird
06:59:13 --> ogi has joined #instantbird
07:10:48 <-- jb has quit (Ping timeout)
07:30:43 <-- Rym has quit (Ping timeout)
07:31:17 --> sawrubh|ib has joined #instantbird
07:32:39 <sawrubh|ib> I get http://i.imgur.com/rHAVIQt.png when I try using the browserRequest.xul in chat/content
07:34:48 --> aleth has joined #instantbird
07:34:48 * ChanServ sets mode +o aleth 
07:35:23 <-- aleth has quit (Quit: exit stage left)
07:35:25 --> aleth has joined #instantbird
07:35:25 * ChanServ sets mode +o aleth 
07:35:37 * sawrubh|ib goes back to copying and using the browserRequest.xul from mail/base/content
07:56:55 --> jb has joined #instantbird
07:57:23 <-- jb has quit (Input/output error)
08:01:09 --> jb has joined #instantbird
08:09:40 <-- sawrubh|ib has quit (Ping timeout)
08:13:13 --> gerard-majax__ has joined #instantbird
08:14:11 --> sawrubh|ib has joined #instantbird
08:17:28 <-- sawrubh|ib has quit (Quit: sawrubh|ib)
08:28:31 --> Armada has joined #instantbird
08:45:05 --> mayanktg has joined #instantbird
08:47:05 <-- aleth has quit (Quit: exit stage left)
08:47:35 <sawrubh> so I'm still getting https://pastebin.mozilla.org/5553226 http://i.imgur.com/8MVwQZh.png is how it looks
08:47:40 <-- mayanktg has quit (Ping timeout)
08:47:41 <-- jb has quit (Ping timeout)
08:48:30 --> mayanktg has joined #instantbird
08:51:31 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
08:51:39 --> nhnt11 has joined #instantbird
08:54:21 <-- mayanktg has quit (Ping timeout)
08:54:44 --> mayanktg has joined #instantbird
08:55:18 --> chrisccoulson has joined #instantbird
08:57:18 <-- mayanktg has quit (Ping timeout)
08:59:15 --> mayanktg has joined #instantbird
09:01:47 <-- mayanktg has quit (Ping timeout)
09:03:38 --> mpmc has joined #instantbird
09:07:04 <sawrubh> flo-retina: happy quatorze!
09:09:41 --> mayanktg has joined #instantbird
09:12:13 <-- mayanktg has quit (Ping timeout)
09:12:35 --> mayanktg has joined #instantbird
09:19:05 --> aleth has joined #instantbird
09:19:05 * ChanServ sets mode +o aleth 
09:20:07 <aleth> mayanktg: Can you finish up the webcam patch with clokep's feedback so it can land?
09:25:26 <mayanktg> aleth: Ok. I'll try to edit the panel-2,3 buttons so that no bottom margins appear when viewing in the windows in the windows.
09:25:38 <aleth> Maybe a min-height is enough.
09:25:57 <aleth> But I don't know.
09:26:01 <mayanktg> Ok.
09:29:20 <-- mayanktg has quit (Ping timeout)
09:30:48 --> mayanktg has joined #instantbird
09:32:28 <mayanktg> aleth: I have a problem with the detectEntityCapabilities method I have created in the conversation binding. It evaluates mGUMD (L65) after I set the entities object (L74) :( 
09:34:37 <mayanktg> Why is this happening? I mean the execution should have been sequential. and |video = true| should have been executed before the Line 74.
09:35:14 <aleth> Where is the code?
09:36:13 <aleth> Is there a pastebin?
09:36:17 <-- mayanktg has quit (Ping timeout)
09:37:03 --> mayanktg has joined #instantbird
09:37:33 <mayanktg> aleth: http://pastebin.instantbird.com/750004
09:37:51 <mayanktg> Sorry i forgot to paste the link.
09:38:49 <aleth> That code isn't "sequential" (you mean synchronous) because video=true gets set in a callback.
09:39:02 <aleth> You don't know how quickly the callback function is called.
09:39:50 <mayanktg> Yes. That's the problem. I have to return the values only after the mGUMD has been called.
09:40:15 <aleth> You have to make detectCapabilities asynchronous as well.
09:40:36 <aleth> There is no way it can immediately return a value.
09:41:30 <mayanktg> Ok. So I need to implement promise here?
09:41:56 <aleth> You could pass a callback to detectCapabilities and call it when the value is ready.
09:43:10 <aleth> If you like, you can use a promise, but only if you don't think that will cost too much time for you to learn how to do ;)
09:43:38 <aleth> Callbacks are easier here as gUMD doesn't use promises anyway.
09:44:54 <-- mayanktg has quit (Ping timeout)
09:46:12 --> mayanktg has joined #instantbird
09:48:50 <-- mayanktg has quit (Ping timeout)
09:49:37 --> mayanktg has joined #instantbird
09:52:59 <-- mayanktg has quit (Ping timeout)
09:54:00 --> mayanktg has joined #instantbird
09:55:40 <-- mayanktg has quit (Ping timeout)
09:57:13 --> mayanktg has joined #instantbird
10:00:12 <mayanktg> Mic also mentioned about buttons overlapping the rounded corners in Windows 7 http://log.bezut.info/instantbird/140704/#m77 . So I have added |border-bottom-left/right-radius: 3px;| for the lower icons.
10:04:45 <aleth> mayanktg: ping clokep with a patch when you are done so he can test it,
10:05:13 <-- mayanktg has quit (Ping timeout)
10:06:10 --> mayanktg has joined #instantbird
10:13:44 <-- mayanktg has quit (Ping timeout)
10:14:37 --> mayanktg has joined #instantbird
10:15:03 <mayanktg> aleth: The rounded corner for the panel appears only in Windows 7 and not in Ubuntu/Mac. Right? So do I need to add an ifdef for Windows 7?
10:15:14 <aleth> mayanktg: Sounds like it
10:15:21 <mayanktg> aleth: Ok.
10:17:46 <-- Armada has quit (Connection reset by peer)
10:20:31 --> clokep has joined #instantbird
10:20:31 * ChanServ sets mode +o clokep 
10:35:27 <-- mayanktg has quit (Ping timeout)
10:36:20 --> mayanktg has joined #instantbird
10:40:14 <-- EionRobb has quit (Quit: Leaving.)
10:40:27 --> BWMerlin has joined #instantbird
10:41:05 <mayanktg> clokep: Hello. :) I have uploaded the changes for the user icon patch. Could you try that patch once more and see if still the bottom margins persist?
10:43:49 <clokep> mayanktg: Does it apply on top or is it a full patch?
10:44:06 <mayanktg> clokep: Its a full patch.
10:44:51 <mayanktg> Should I upload one which works on top of it?
10:45:09 <clokep> That's fine, just wanted to know.
10:45:24 <mayanktg> Ok :)
10:46:06 <clokep> mayanktg: The bottom margin is still there.
10:46:36 <mayanktg> :(
10:47:39 <clokep> mayanktg: You really need to add version numbers to your patch titles when you upload them.
10:48:13 <aleth> That means editing the "description" field on bugzilla ;)
10:48:40 <clokep> Although interdiff doesn't seem to be working nayway. :-S
10:49:11 <clokep> mayanktg: I'm trying t ofigure out what you changed to ensure the right code is applied, can you point me to a block of new code you added?
10:49:21 <mayanktg> I did change the version number this time. from v5 to v6. :-o
10:49:33 <mayanktg> yes.
10:49:36 <clokep> Where does it say "v5"?
10:52:13 <clokep> Any,way, please point to a block of code that's different. :)
10:53:08 <aleth> From the screenshot it looks like the height needs to be bigger on Windows
10:53:30 <mayanktg> https://bugzilla.mozilla.org/attachment.cgi?id=8455222&action=diff Line 598 has been changed from |height: 52px| to |min-height: 52px|
10:53:44 <mayanktg> aleth: Yes.
10:54:11 <clokep> mayanktg: So min-height means that the object has to be at least 52px, but CAN be larger.
10:54:14 <clokep> Maybe you want max-height?
10:54:19 * clokep tries it.
10:54:24 <aleth> clokep: How big does it need to be?
10:54:31 * clokep has no idea.
10:54:42 * aleth wonders if the font is taller on Windows.
10:55:05 <mayanktg> I guess around 60px
10:55:24 --> Rym has joined #instantbird
10:55:26 <mayanktg> http://log.bezut.info/instantbird/140704/#m61
10:57:31 <-- ogi has quit (Ping timeout)
10:59:24 * clokep doesn't have time right now to play w/ this.
11:00:51 <mayanktg> I guess setting the height to 60px for Windows should fix this up. As the icons in panel 2,3 are shorter than that in panel-1.
11:02:04 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
11:09:57 <-- aleth has quit (Ping timeout)
11:26:26 --> jb has joined #instantbird
11:29:06 --> aleth has joined #instantbird
11:29:06 * ChanServ sets mode +o aleth 
11:33:39 <-- Rym has quit (Ping timeout)
11:34:18 <-- aleth has quit (Ping timeout)
11:35:15 <-- jb has quit (Ping timeout)
11:38:35 --> Rym has joined #instantbird
11:39:55 --> aleth has joined #instantbird
11:39:55 * ChanServ sets mode +o aleth 
11:44:52 <-- mayanktg has quit (Ping timeout)
11:45:10 --> mayanktg has joined #instantbird
11:49:40 <-- BWMerlin has quit (Quit: BWMerlin)
11:51:15 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:58:45 --> clokep_work has joined #instantbird
11:58:45 * ChanServ sets mode +o clokep_work 
11:59:56 <-- mayanktg has quit (Ping timeout)
12:00:52 --> mayanktg has joined #instantbird
12:13:08 <mayanktg> aleth: Ok. And we need to add %ifdef XP_WIN for Windows 7 right?
12:13:09 <mayanktg> I'm getting this warning in the error Console when I add a ifdef to the css http://pastebin.instantbird.com/750071
12:13:44 <aleth> That's because you have to mark the file for preprocessing if it doesn't contain any ifdefs yet.
12:14:02 <aleth> Obviously %ifdef isn't valid CSS...
12:14:49 <mayanktg> But im/themes/blist.css already contains ifdefs before.
12:15:03 * Fallen is now known as Fallen|away
12:15:16 <aleth> mayanktg: In that case try removing the leading spaces.
12:15:28 <aleth> They probably confuse the preprocessor.
12:17:27 <mayanktg> aleth: Yep. No errors now :)
12:22:41 --> BillBinkley has joined #instantbird
12:25:38 <clokep_work> That's a shame, but I guess if it's preprocessed already..
12:26:08 <aleth> I just think landing this >> spending another few days waiting for someone to come up with magic css
12:26:56 <clokep_work> Yes. :)
12:27:03 <clokep_work> We need to figure out what needs to be tweaked though.
12:35:32 <clokep_work> mayanktg: I can try something when I get home if you'd like. But not on my Windows machine anymore.
12:37:01 <mayanktg> I would be needing a Windows machine. No problem, I guess it should be working now. I have updated the patch with changed height for windows. 
12:37:49 <aleth> mayanktg: Did you get the callback working?
12:38:33 <mayanktg> aleth: No. Not until now.
12:41:19 <-- Rym has quit (Ping timeout)
12:43:49 <sawrubh> clokep_work: btw I would like to figure out that Invalid Client error I get while signing into Box from IB, right now I'm changing the flow of the current implementation to allow me to pass the error to the UI (which in turn will allow me successfully handle multiple  transfers at the same time)
12:44:07 --> Rym has joined #instantbird
12:44:21 <sawrubh> I would however like to figure out that signing error in some time (since I don't want to switch from what I'm working on currently)
12:45:37 <clokep_work> sawrubh: I gave you a bunch of steps yesterday to start debugging it.
12:46:01 <sawrubh> you said turn on debugging, which I'm not sure what you meant
12:46:10 <sawrubh> and it doesn't output any line numbers, let me show you the screenshot
12:46:29 <sawrubh> http://i.imgur.com/8MVwQZh.png
12:46:54 <sawrubh> https://pastebin.mozilla.org/5553226 is all I get in the error console
12:47:49 <aleth> Are you using OAuth2?
12:47:57 <sawrubh> yes
12:48:06 <sawrubh> the new Box signing experience uses that :)
12:48:57 <sawrubh> also http://i.imgur.com/rHAVIQt.png is what I see when I use the browserRequest.xul in chat/content (I don't know why that little bubble on top left comes)
12:49:24 <sawrubh> so I have started using the browserRequest.xul I copied from mail/base/content (which TB uses) and it works fine now
12:55:21 <-- aleth has quit (Ping timeout)
12:56:35 --> aleth has joined #instantbird
12:56:35 * ChanServ sets mode +o aleth 
13:06:01 <-- Rym has quit (Ping timeout)
13:06:53 <-- mayanktg has quit (Ping timeout)
13:07:16 --> mayanktg has joined #instantbird
13:07:45 --> Rym has joined #instantbird
13:11:16 <clokep_work> sawrubh: Ah, I didn't know ythe webpage was giving you that.
13:11:42 <clokep_work> sawrubh: It uses log4moz, you can turn on debugging easily. I don't remember how to though.
13:12:15 <clokep_work> sawrubh: http://dxr.mozilla.org/comm-central/source/mailnews/db/gloda/modules/log4moz.js#88 looks like create a pref called <loggername>.logging.console and set it to 'Debug'
13:18:21 --> Armada has joined #instantbird
13:23:15 --> rosonline has joined #instantbird
13:23:51 <-- Rym has quit (Ping timeout)
13:30:46 <sawrubh> bored of coding in the Summer, https://blog.mozilla.org/security/2014/05/15/introducing-mozilla-winter-of-security-2014/ :P
13:30:52 --> Rym has joined #instantbird
13:31:00 <sawrubh> ^ that
13:31:14 <sawrubh> sorry ignore that message, it was meant for some other place
13:32:02 <clokep_work> sawrubh: Are you saying you need more to do?!
13:32:10 <clokep_work> My laundry could use getting done. ;)
13:32:24 <sawrubh> :)
13:35:05 <-- Rym has quit (Connection reset by peer)
13:35:21 <flo-retina> clokep_work: you probably want it done before the winter :)
13:35:46 --> Rym has joined #instantbird
13:41:18 <-- Rym has quit (Ping timeout)
13:42:17 <-- mayanktg has quit (Ping timeout)
13:42:20 --> mayanktg has joined #instantbird
13:43:24 --> Rym has joined #instantbird
13:45:52 <-- mayanktg has quit (Ping timeout)
13:47:00 --> mayanktg has joined #instantbird
13:48:41 <-- mayanktg has quit (Ping timeout)
13:48:43 --> mayanktg has joined #instantbird
13:49:06 <-- Rym has quit (Ping timeout)
13:50:24 <-- mayanktg has quit (Ping timeout)
13:50:46 --> Rym has joined #instantbird
13:53:40 --> mayanktg has joined #instantbird
13:55:20 <-- mayanktg has quit (Ping timeout)
13:58:03 --> mconley has joined #instantbird
13:58:43 <-- aleth has quit (Ping timeout)
13:58:51 --> mayanktg has joined #instantbird
13:59:15 --> aleth has joined #instantbird
13:59:15 * ChanServ sets mode +o aleth 
13:59:28 <-- Rym has quit (Ping timeout)
13:59:52 --> Rym has joined #instantbird
14:00:31 <-- mayanktg has quit (Ping timeout)
14:02:26 <-- Rym has quit (Ping timeout)
14:02:39 --> mayanktg has joined #instantbird
14:07:01 <-- mayanktg has quit (Ping timeout)
14:09:11 --> mayanktg has joined #instantbird
14:10:29 <-- aleth has quit (Ping timeout)
14:12:05 <-- mayanktg has quit (Ping timeout)
14:13:20 --> mayanktg has joined #instantbird
14:16:33 <-- mayanktg has quit (Ping timeout)
14:32:05 --> Rym has joined #instantbird
14:37:48 --> mayanktg-ph has joined #instantbird
14:42:00 <-- Rym has quit (Ping timeout)
14:48:43 --> Rym has joined #instantbird
14:53:07 --> mpmc has joined #instantbird
14:57:24 <-- Rym has quit (Ping timeout)
15:02:07 --> Rym has joined #instantbird
15:04:36 <-- Rym has quit (Ping timeout)
15:05:30 --> mayanktg has joined #instantbird
15:06:23 <-- mayanktg-ph has quit (Quit: )
15:06:27 --> Rym has joined #instantbird
15:07:30 --> aleth has joined #instantbird
15:07:30 * ChanServ sets mode +o aleth 
15:08:10 <-- Rym has quit (Ping timeout)
15:10:09 <-- aleth has quit (Ping timeout)
15:10:59 --> aleth has joined #instantbird
15:10:59 * ChanServ sets mode +o aleth 
15:17:20 --> iamjayakumars has joined #instantbird
15:18:03 <-- aleth has quit (Quit: exit stage left)
15:33:20 <mayanktg> aleth: Added the detect video capability functionality using callback.
15:57:54 <-- nhnt11 has quit (Ping timeout)
15:58:58 --> nhnt11 has joined #instantbird
16:04:39 --> arlolra has joined #instantbird
16:35:10 <-- gerard-majax__ has quit (Ping timeout)
16:47:03 --> Mook_as has joined #instantbird
16:57:04 <-- mayanktg has quit (Ping timeout)
16:58:21 --> mayanktg has joined #instantbird
17:16:40 <-- mayanktg has quit (Ping timeout)
17:17:00 --> mayanktg has joined #instantbird
17:22:48 --> Rym has joined #instantbird
17:31:37 <-- Rym has quit (Ping timeout)
17:50:17 * sawrubh feels really irritated
17:50:35 <sawrubh> I've been trying to debug this error in my code and can't seem to find the cause
17:54:41 <sawrubh> I'm trying to create the XMPPFileTransfer object once during the offer phase, now I need to pass the current conv object, when I'm doing this._conv[from], it seems to be undefined :/
17:57:08 <clokep_work> "it"?
17:58:00 <nhnt11> sawrubh: I'd check if your "this" is actually what you expecte
17:58:02 <nhnt11> expect*
17:58:03 <nhnt11> pastebin?
18:00:17 <sawrubh> https://pastebin.mozilla.org/5554842 is the pastebin (it's the smallest pastebin which gives you enough context)
18:00:41 <sawrubh> one more sec
18:01:42 <sawrubh> earlier the code was https://pastebin.mozilla.org/5554845
18:02:04 <-- mconley has quit (Connection reset by peer)
18:02:30 --> mconley has joined #instantbird
18:02:43 <clokep_work> Can you point us to lines somewhere?
18:02:52 <sawrubh> what I changed is earlier I used to create an object fileOffer (on L11 of 2nd pastebin) and the callback there (which is defined on L112) used to call XMPPFileTransfer
18:03:05 <sawrubh> clokep_work: I'm explaining (slow typing)
18:03:35 <nhnt11> sawrubh: So what's this._conv? where's it defined?
18:03:45 <nhnt11> You seem to treat it like a map on line 31
18:04:19 <nhnt11> Is the value of |from| what you'd expect? Are you setting this._conv[from] correctly wherever you're setting it?
18:04:36 <sawrubh> nhnt11: it's defined inside XMPPAccountPrototype as a NormalizedMap
18:05:01 <nhnt11> sawrubh: If it's a Map, you should certainly be using this._conv.get(from) and not this._conv[from]
18:05:40 <sawrubh> nhnt11: http://mxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm#618
18:06:16 <sawrubh> nhnt11: I used to access it as `this._conv[from]` earlier and it used to work
18:07:03 <sawrubh> btw continuing, so what I changed now is I call XMPPFileTransfer inside the place where I used to create the fileOffer object
18:07:12 <clokep_work> sawrubh: It used to not be a map.
18:07:20 <clokep_work> It used to be an object.
18:07:22 <sawrubh> ah
18:07:53 * sawrubh tries using get
18:09:27 <nhnt11> clokep_work: I just saw the __noSuchMethod__ thing in NormalizedMap, magic indeed.
18:09:42 <clokep_work> nhnt11: I wrote a blog post on that, if you didn't read it.
18:09:43 <nhnt11> How did you discover that? :) (You wrote that code, right?)
18:10:03 <sawrubh> nhnt11: what's magical about it?
18:10:05 <nhnt11> I think I saw it but didn't read it properly maybe
18:10:15 <sawrubh> what can it be used for?
18:10:29 <nhnt11> sawrubh: See chat/modules/NormalizedMap.jsm
18:10:35 <nhnt11> or read this: http://patrick.cloke.us/posts/2014/04/27/extending-javascript-maps-or-other/
18:10:45 <-- mayanktg has quit (Ping timeout)
18:11:38 --> mayanktg has joined #instantbird
18:13:10 <clokep_work> nhnt11: MDN.
18:13:33 <clokep_work> It was on the sidebar that all objects have.
18:13:43 <clokep_work> It was in the sidebar as an inherited properly that all objects have.
18:13:44 <clokep_work> Rather.
18:13:56 <nhnt11> Ah..
18:14:15 <-- mayanktg has quit (Ping timeout)
18:14:26 <nhnt11> I'm surprised your "First Approach" didn't work
18:14:54 --> arlolra1 has joined #instantbird
18:15:05 --> mayanktg has joined #instantbird
18:15:09 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:16:06 <-- arlolra has quit (Ping timeout)
18:16:11 <-- arlolra1 has quit (Quit: arlolra1)
18:16:14 <sawrubh> clokep_work: nhnt11 thanks
18:20:01 <nhnt11> Interesting: https://bugzilla.mozilla.org/show_bug.cgi?id=882301#c1
18:20:04 <instantbot> Bug 882301 nor, --, ---, general, RESO INVALID, Native methods on types inherited from builtins: method called on incompatible Object
18:20:20 <-- mayanktg has quit (Ping timeout)
18:20:58 --> arlolra has joined #instantbird
18:21:11 --> mayanktg has joined #instantbird
18:28:52 <clokep_work> nhnt11: There's a bug about allowing this though, it's linked to in the post.
18:28:57 <nhnt11> I saw it.
18:34:42 <nhnt11> clokep_work: Btw, why not just use a factory function like this: http://pastebin.instantbird.com/750214?
18:55:40 <clokep_work> nhnt11: That creates a new prototype chain for every instance.
18:57:42 <sawrubh> how do I define a function using fat arrows functions? I mean my object has accept and reject methods and I do https://pastebin.mozilla.org/5555043
18:58:36 <sawrubh> in my UI I do https://pastebin.mozilla.org/5555046
18:59:02 <clokep_work> Is pastebin.ib really slow or is it my connection?
18:59:12 <nhnt11> clokep_work: Is that really that big a deal?
18:59:22 <nhnt11> clokep_work: Yeah, I've been using pb.mozilla.org these days
18:59:28 <nhnt11> (I thought it was my connectino)
18:59:52 <clokep_work> nhnt11: It essentially means the JIT won't work.
18:59:53 <clokep_work> sawrubh: Is the "this" not working as you expect?
19:00:06 <sawrubh> no I get some error, wait pastebinning
19:03:09 <sawrubh> https://pastebin.mozilla.org/5555052
19:03:32 <clokep_work> :-S
19:03:45 <sawrubh> this probably means that my usage isn't right (I have L21 in https://pastebin.mozilla.org/5555046 )
19:03:49 <nhnt11> sawrubh: What's like 439?
19:03:50 <sawrubh> note the lack of braces
19:03:54 <nhnt11> line*
19:04:07 <-- arlolra has quit (Quit: arlolra)
19:05:09 <sawrubh> http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/widgets/notification.xml#439
19:06:25 * nhnt11 doesn't know
19:09:13 * sawrubh wonders if this is some QueryInterface magic
19:10:03 <sawrubh> the function definition seems right, right?
19:10:16 <sawrubh> I mean using the fat arrow function
19:10:22 <clokep_work> sawrubh: Yes, it does.
19:10:45 <clokep_work> Can you show more context?
19:11:25 <sawrubh> I had this weird notification.xml bug earlier also, that time it turned out I was defining the accept and reject in conversation.xml using braces like `aSubject.accept()` instead of `aSubject.accept`
19:12:11 <clokep_work> Ah, you mean parenthesis.
19:12:31 <sawrubh> yeah but that doesn't seem to be the case here, does it?
19:14:23 <sawrubh> https://pastebin.mozilla.org/5555113 is the interface definition, L41 and 43
19:14:58 <-- mayanktg has quit (Ping timeout)
19:15:26 <sawrubh> https://pastebin.mozilla.org/5555114 is where I populate the XMPPFileTransfer object which is basically ClassInfo'ing prplIFileTransfer
19:15:47 <sawrubh> this XMPPFileTransfer object is then passed to the UI using notifyObserver
19:16:28 <sawrubh> got it!
19:16:29 <sawrubh> nvm
19:16:47 <clokep_work> sawrubh: What was the issue?
19:16:56 <sawrubh> https://pastebin.mozilla.org/5555115 is what I was doing in the UI
19:17:23 <sawrubh> since earlier I used to create an object manually, I had to QI it before passing it to the method which then did aSubject.accept or whatever
19:18:03 <sawrubh> since now I'm directly passing the XMPPFileTransfer object, I think I don;t need to do that QI  on L68 of the above pastebin
19:18:07 * sawrubh tries what he just proposed
19:18:20 <clokep_work> QIing to something that it already is shouldn't really give an issue.
19:18:27 <sawrubh> :/
19:18:49 <sawrubh> so should I remove that QI or not?
19:22:56 <clokep_work> Try it.
19:22:59 <sawrubh> clokep_work: you're right it doesn't fix it :/
19:23:01 <clokep_work> There's no harm in trying something.
19:23:01 <sawrubh> I just tried
19:23:09 <clokep_work> It shouldn't really be necessary though.
19:23:33 <clokep_work> sawrubh: Try printing out the accept method in the UI patch?
19:23:39 <sawrubh> I mean I've removed it, since it neither worsens the situation but it certainly doesn't fix it
19:23:45 <sawrubh> okie dokie
19:23:54 <clokep_work> Let's see what it actually is!
19:23:57 <clokep_work> That way we can start to debug it.
19:24:11 <sawrubh> reveal your secrets, dirty object!
19:25:31 --> mayanktg has joined #instantbird
19:28:57 <-- mayanktg has quit (Ping timeout)
19:29:45 --> mayanktg has joined #instantbird
19:29:57 <sawrubh> the dirty object has spoken! https://pastebin.mozilla.org/5555147
19:30:04 <sawrubh> it's native code, wat
19:30:31 * sawrubh remembers having seen some native code error like this when it shouldn't have been
19:33:09 <Mook_as> .bind() methods are native code, IIRC (you're seeing the wrapper .bind() returns)
19:33:17 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:34:47 <sawrubh> Mook_as: so you're saying it's normal or there some bind issue in what I pass as accept and reject from my backend code
19:34:56 * sawrubh suspects something has to do with using fat arrows
19:35:02 <clokep_work> sawrubh: Trying calling it?
19:35:04 <Mook_as> I'm saying that's one possible reason you're seeing [native code]
19:35:11 <clokep_work> And add a print statement inside of it.
19:45:19 <sawrubh> it's getting called, the print inside accept's body gets printed
19:45:34 <clokep_work> Alright.
19:46:17 <clokep_work> Where's the error again? I Seem to have lost that pastebin.
19:46:56 <sawrubh> https://pastebin.mozilla.org/5555147
19:47:36 <clokep_work> OK
19:49:19 <clokep_work> sawrubh: Btw it would help me to help you debug these things if you showed diffs from your last working version.
19:49:23 <clokep_work> Instead of diffs from the tip of master.
19:49:48 <sawrubh> ok, sharing the working pastebin in a sec
19:49:54 <sawrubh> (only the relevant parts)
19:50:04 <clokep_work> sawrubh: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Method/appendNotification
19:50:09 <clokep_work> Re-read the "buttons" section.
19:50:15 <clokep_work> The callback accepts two input arguments.
19:50:22 <clokep_work> My guess is that you need to accept those.
19:54:17 <sawrubh> https://pastebin.mozilla.org/5554845 is how the backend code used to be, (L11-28 are useful which actually create the object passed to the UI)
19:55:24 <sawrubh> and https://pastebin.mozilla.org/5555046 is how the UI code used to be, notice I don't have two input arguments
19:58:11 <clokep_work> sawrubh: Did you see my suggestion?
19:58:15 <clokep_work> That's still not what I asked for. :-\
19:58:22 <clokep_work> I asked for the diff between that version and what you have now!
19:58:28 <clokep_work> So I can easily see the lines that changed.
19:58:40 <-- BillBinkley has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
20:05:10 <clokep_work> sawrubh: E.g. if you're using mq, don't qref and then show the diff, just do |hg diff|
20:06:58 <sawrubh> clokep_work: https://pastebin.mozilla.org/5555309 is the backend interdiff
20:08:27 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
20:10:06 --> chrisccoulson has joined #instantbird
20:12:58 --> aleth has joined #instantbird
20:12:58 * ChanServ sets mode +o aleth 
20:13:16 <clokep_work> sawrubh: So, did you try what I asked yet though? :-S
20:15:07 <sawrubh> no, let me try. Basically I need to change my backend where I define accept and reject to take 2 args which I'm not gonna use anyhow
20:16:11 <clokep_work> Yes.
20:16:22 <clokep_work> JS just ignores arguments, but maybe since it's now "native code" it won't do it.
20:16:42 <aleth> mayanktg: Looks like good progress!
20:17:45 <aleth> mayanktg: Does e.g. Jitsi recognise an IB contact has video capability now?
20:17:48 <mayanktg> aleth: yay! Next -> Bug 1027779 ?
20:17:51 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1027779 nor, --, ---, mayanktg, NEW, Inability to send call request if no messages have been exchanged before.
20:18:08 <mayanktg> aleth: I forgot to check. Just a min.
20:23:26 <mayanktg> It didn't recognize :'(
20:23:44 <aleth> mayanktg: If you look at the debug log, where does it go wrong?
20:24:31 <sawrubh> clokep_work: https://pastebin.mozilla.org/5555337 is my backend code now (I've made no changes to the frontend code) and I still get the same error https://pastebin.mozilla.org/5555339
20:24:47 <aleth> mayanktg: I'm not expecting an actual video call to "just work" immediately, that would be too much to hope for ;) I'm just interested in whether the 0115 capability mechanism is working as it should.
20:25:00 <sawrubh> one thing to note though is that L2 of https://pastebin.mozilla.org/5555339 still doesn't show those two arguments
20:25:40 <clokep_work> aleth: You have any ideas?
20:25:58 <aleth> clokep_work: what's the context>
20:26:06 <sawrubh> mayanktg: yes! I'm having the same problem in my patch too (not being able to start a file transfer unless there has been some conversation between the two parties
20:26:09 <sawrubh> aleth: one second
20:29:31 <clokep_work> aleth: https://pastebin.mozilla.org/5555309 gives sawrubh an error https://pastebin.mozilla.org/5555147
20:29:36 <sawrubh> aleth: https://pastebin.mozilla.org/5555043 is how I've populated the XMPPFileTransfer object which I pass to the UI, XMPPFileTransfer ClassInfo's prplIFileTransfer which is defined like https://pastebin.mozilla.org/5555113, now the UI code is https://pastebin.mozilla.org/5555115 and the error I get is https://pastebin.mozilla.org/5555339
20:29:56 <clokep_work> sawrubh: So that's not the error.
20:30:00 <clokep_work> I think you keep pasting the wrong link.
20:30:06 <clokep_work> That's you just printing out what accept is.
20:30:13 <sawrubh> ah sorry
20:30:51 <sawrubh> aleth: https://pastebin.mozilla.org/5555052 is the error
20:31:13 <sawrubh> http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/widgets/notification.xml#439 is where the error comes
20:32:23 <mayanktg> aleth: That should have worked. After receiving the Service discovery stanza the client knows what are the capabilities of the machine at the other end. I'm receiving this stanza from the Jitsi. But maybe the <feature/> nodes I'm sending aren't enough to enable the video call in Jitsi?
20:32:55 <mayanktg> I should try sending the same Service stanza to Jitsi what it sends to us :P
20:33:06 <aleth> clokep_work: http://mxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm#577 did this get overlooked?
20:33:27 <sawrubh> ok, I'm just going 10-15 minutes staring-at-code-mode to find out what's wrong actually
20:33:44 <aleth> mayanktg: Looks like that needs some more investigating then, maybe reread the XEP...
20:33:55 <-- nhnt11 has quit (Input/output error)
20:34:19 <clokep_work> aleth: Looks like it, yes.
20:34:26 <mayanktg> aleth: Ok. re-reading the Entity Capability XEP.
20:34:27 <clokep_work> aleth: It causing an issue?
20:34:39 <clokep_work> It should just be "has"
20:35:04 <aleth> mayanktg: Before you do that though: You're piling up a lot of patches that should go through their review cycles and land. Can you (1) make sure you've addressed all the existing feedback on older patches and then (2) send out friendly review pings, if needed by email?
20:35:05 --> nhnt11 has joined #instantbird
20:35:37 <aleth> clokep_work: It's almost certainly causing *some* issue, but I just stumbled over it in the code.
20:36:58 <mayanktg> aleth: Yes. I'm trying to answer you reviews on the video call patch. Its a bit complicated to change some of the codes in the sdp2xml() . I'll try to answer them asap.
20:37:27 <aleth> mayanktg: If you get stuck with that or don't quite know what I meant, then ask.
20:37:42 <mayanktg> I'll try to land the generic icons patch too.
20:37:50 <aleth> Great.
20:38:52 <mayanktg> Flo said that generic icons patch was on his early review queue. Just waiting for him to review it.
20:39:02 <aleth> sawrubh: What's the prplIFileTransfer interface look like?
20:39:27 <clokep_work> aleth: Any chance of patching it or should I "soon"?
20:39:51 <aleth> clokep_work: "soon" will do, I can't get to it right now.
20:39:51 <sawrubh> aleth: https://pastebin.mozilla.org/5555113
20:40:11 <aleth> sawrubh: Thanks
20:40:25 <aleth> sawrubh: I'm a bit confused - why do you need all this to land Filelink? Isn't that priority number one?
20:41:06 <nhnt11> sawrubh: onSIInitiateRequest should get called right? Have you confirmed that's not causing the problem?
20:41:25 <nhnt11> oh, it's reject
20:41:36 <clokep_work> aleth: No. That's blocked on reviews right now.
20:41:43 <sawrubh> aleth: this is unrelated to the FileLink patch, this is my xmpp implementation patch
20:41:43 <aleth> clokep_work: OK, cool.
20:42:00 <sawrubh> the FileLink patch also needs some debugging though :/
20:42:02 <aleth> Just trying to get up to speed with the context ;)
20:44:33 <nhnt11> sawrubh: Have you tried changing |callback: foo| to |callback: () => foo()| btw? (wild guess)
20:44:58 <mayanktg> aleth: Heh..Video call gets enabled in Jitsi if I send the features I receive from it ;)
20:45:00 <sawrubh> no I haven't
20:45:13 <aleth> mayanktg: OK, so you need to understand what those features are ;)
20:45:22 <sawrubh> btw Mook_as pointed (and I suspect too) that this is to do somewhere with me using the fat arrows
20:45:45 <mayanktg> aleth: Trying to minimize the feature list and identifying the features. :)
20:45:48 <aleth> mayanktg: Of course you can only send those feature capabilities if IB is actually capable of them...
20:46:31 <Mook_as> sawrubh: fat arrow != bind. bind gives you [native code], from a quick test fat arrow doesn't seem to.
20:46:35 <mayanktg> Yes. Just curious right now. I will see if I can add them.
20:46:46 <aleth> sawrubh: I doubt it has anything to do with fat arrows...
20:46:51 <nhnt11> sawrubh: That would be pretty weird
20:47:06 <sawrubh> but fat arrows allow you to not have to bind `this` innit?
20:47:07 <clokep_work> aleth: https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1018771&attachment=8455614
20:47:44 <nhnt11> sawrubh: yes.
20:47:49 <-- CAKCy has quit (Quit: Have a great day everyone!)
20:48:44 <aleth> sawrubh: nhnt11: The implementation is a bit different under the hood though iirc.
20:49:02 <nhnt11> aleth: yeah. you can't change the `this` value using call or bind right?
20:49:07 <nhnt11> sawrubh: This may be worth a read: http://robcee.net/2013/fat-arrow-functions-in-javascript/
20:49:23 <aleth> nhnt11: I think so ("lexical scope").
20:49:33 <sawrubh> nhnt11: your suggestion worked :)
20:49:52 <aleth> nhnt11++ :)
20:49:56 <sawrubh> 2/2
20:50:07 <sawrubh> f yeah
20:50:10 * aleth hasn't even found that callback line in the patch yet in his reading...
20:50:22 <nhnt11> sawrubh: My suspicion was that while in the scope of the binding, aSubject.accept was a function, it may not behave similarly when stored in the object and called from a different scope
20:50:24 <nhnt11> if that makes sense
20:51:02 <sawrubh> aleth: L16 and L21 of https://pastebin.mozilla.org/5555115
20:51:35 <aleth> ah, I hadn't seen that one!
20:51:39 <clokep_work> aleth: Thanks.
20:51:47 <nhnt11> sawrubh: If you're feeling adventurous, modify notification.xml in toolkit and print typeof button.callback
20:51:47 <aleth> clokep_work: Thanks for the rapid fix!
20:51:52 <sawrubh> aleth: L4 and 7 of https://pastebin.mozilla.org/5555043 for the backend code
20:52:37 <aleth> OK, so that problem is solved then.
20:53:09 <sawrubh> so what life lessons have I learned today?
20:54:37 --> EionRobb has joined #instantbird
20:54:46 <aleth> nhnt11: Do you think this is behaving the way it should, or should we file a bug?
20:55:03 <nhnt11> aleth: I'm not entirely sure, writing a small snippet to test my theory
20:56:50 <aleth> nhnt11: Good idea, a test case would be needed to file a bug anyway,
20:57:42 <aleth> sawrubh: Large patches bitrot quickly in painful ways, so land them whenever you can? ;)
20:58:39 <aleth> nhnt11: Could be a bug around how XPConnect wraps arrow functions
20:58:42 <nhnt11> sawrubh: Could you please print `typeof aSubject.accept` in the fileTransferOffer method?
20:58:46 <nhnt11> aleth: My thoughts exactly
20:59:16 <nhnt11> sawrubh: Btw, this is happening only if fileTransfer.accept is an arrow function?
20:59:24 <nhnt11> i.e on line 4 and 7 here: https://pastebin.mozilla.org/5555043
21:00:09 <nhnt11> aleth: I was thinking, something is going wrong while storing the method in the button object
21:00:57 <nhnt11> sawrubh: It would also be useful to see what happens if you did `acceptButton.callback() `right after the acceptButton definition in the fileTransferOffer method
21:01:18 <mayanktg> aleth: I identified what feature node enables video call in Jitsi. I'll try to implement it tonight. btw I tried making a call to Jitsi and I received this JIngle stanza http://pastebin.instantbird.com/750268 from it. The only reason I'm unable to make a call is due to the converted sdp http://pastebin.instantbird.com/750267 (everything correct except L24 and 48).
21:01:24 <sawrubh> nhnt11: the type is `function` inside notification.xml
21:01:33 <nhnt11> Sounds right
21:01:54 <nhnt11> Maybe something is happening when passing it around (i.e. in box.appendNotification)
21:01:58 <sawrubh> this is with the change you suggested btw
21:02:18 <nhnt11> sawrubh: Reverse the change I suggested for all of these tests please :)
21:02:34 <nhnt11> I'm curious what's going on here btw, if it's too time consuming feel free to carry on :)
21:02:43 <sawrubh> nhnt11: (re earlier question) yes this only happened when the fileTransfer.accept is an arrow function
21:02:49 <nhnt11> Interesting..
21:02:51 <aleth> nhnt11: There's a whole bunch of wrapping and unwrapping going on behind the scenes here as the reference to the function is passed to notification.xml
21:03:04 <nhnt11> Yeah..
21:03:34 <aleth> mayanktg: So the problem is actually in sdp2xml/xml2sdp?
21:03:39 <nhnt11> If this happens only when it's an arrow function, it's likely a bug...
21:04:50 <aleth> nhnt11: Certainly sounds like it, unless there's some complicated explanation for why this is expected behaviour for lexical scope. At any rate, worth filing.
21:05:17 <sawrubh> cc me on whatever you file :)
21:05:21 <mayanktg> aleth: Yes. Its in xml2sdp. Will fix it.
21:05:33 <nhnt11> sawrubh: Maybe you should file it, you have the example code ;)
21:05:37 <aleth> mayanktg: So you have a new sample for your xml2sdp test? :D
21:05:50 <aleth> mayanktg: Anyway, this is good progress.
21:06:09 <aleth> sawrubh, nhnt11: You need to abstract it down to a minimal test case before filing though.
21:06:19 <mayanktg> yes. Mighty big samples.
21:06:45 <sawrubh> nhnt11: even without the change you suggested, it's still a function inside notification.xml
21:06:54 <nhnt11> Interesting: http://stackoverflow.com/questions/5140156/illegal-operation-on-wrappednative-prototype-object
21:06:57 <sawrubh> aleth: yeah, no one's gonna want to look at my code and figure things out ;)
21:06:57 <-- clokep_work has quit (Ping timeout)
21:07:04 <nhnt11> I know that's about jquery but the first answer is intriguing
21:07:26 <nhnt11> particularly |var x = document.createElement; calling x('div') will make firefox whine|
21:07:41 <nhnt11> That's similar to what was going on in your code..
21:08:54 <aleth> Hmm, it's kind of related, but probably desired behaviour for security reasons in that case
21:09:00 <nhnt11> Yeah
21:10:16 <aleth> mayanktg: haha yes, those stanzas are huge.
21:12:43 <sawrubh> nhnt11: https://pastebin.mozilla.org/5555517 is what I get when I do accepButton.callback() after defining acceptButton
21:13:08 <nhnt11> So the same error!
21:13:18 <sawrubh> L566 in conversation.xml is the line where I'm calling acceptButton.callback()
21:13:47 <nhnt11> So it appears that if you have a wrapped arrow function, storing it as a property of an object and then calling it from the object fails
21:14:09 <sawrubh> yes
21:14:11 <nhnt11> Maybe it's something to do with the function now being a property of a different object?
21:14:30 * sawrubh wonders who would know how to answer that
21:14:34 <sawrubh> someone definitive
21:14:45 <sawrubh> a spec or Brendan ;)
21:14:46 <aleth> Bholley?
21:15:05 <sawrubh> let's summon bholley
21:15:16 <sawrubh> err, get ourselves summoned before him
21:15:29 <aleth> Well, a stripped down testcase would avoid wasting his time ;)
21:16:25 <nhnt11> aleth: How do I wrap an arrow function? :-/
21:16:34 <nhnt11> I'd have to define an interface et al right?
21:16:48 <aleth> You mean, what's needed for a minimal test case?
21:16:54 <nhnt11> Yeah
21:16:58 <-- iamjayakumars has quit (Ping timeout)
21:17:09 <aleth> Try an interface with a single function in it, an implementation, and an object using this.
21:17:14 <nhnt11> I confirmed that this isn't happening with non-wrapped arrow functions
21:17:16 <nhnt11> okay
21:17:27 --> iamjayakumars has joined #instantbird
21:17:34 <sawrubh> I'll just be selfish and get back to my patch
21:17:36 <aleth> There's other ways to wrap things but this is closest to sawrubh's case.
21:17:43 <nhnt11> sawrubh: Wait, is this happening iwth the reject button too?
21:17:47 <nhnt11> (both right?)
21:17:56 <sawrubh> yeah
21:18:25 <nhnt11> ah wait, both of them use this
21:23:10 * nhnt11 doesn't have time to write an interface at the moment
21:23:58 <aleth> Save it for when you're bored/frustrated with something else ;)
21:24:14 <nhnt11> I'll make a note ;)
21:26:58 <aleth> |let isFatArrow = (func) => { try { new func(); } catch(e) { return true;} return false; };| is neat
21:29:02 --> qheaden has joined #instantbird
21:33:43 * sawrubh rests for a whike
21:37:23 <nhnt11> Good night
21:38:25 <mayanktg> I can get the video call notification too in Instantbird when I place a call from Jitsi. But the stream isn't established. :-| 
21:38:34 * mayanktg tries
21:39:41 <-- mconley has quit (Input/output error)
21:42:42 <mayanktg> aleth: https://developers.google.com/talk/call_signaling#Detecting_Support_and_Call_Routing I guess we can include these three <feature/> http://pastebin.instantbird.com/750279 with our Service Discovery Stanza too. 
21:43:30 <aleth> mayanktg: You want to video call gtalk contacts too? :D
21:44:01 <aleth> mayanktg: If you add this, make sure to include that link in the comments.
21:44:10 <mayanktg> aleth: Jitsi enables the video call button only when these three features are included :-/
21:45:24 <aleth> mayanktg: That's odd...
21:45:36 <EionRobb> that's pretty normal.  most xmpp clients just advertise all 3
21:45:44 <aleth> EionRobb: Thanks for the info!
21:46:18 <mayanktg> Thanks! :)
21:46:33 <EionRobb> I mean, technically, it shouldn't matter if its only one of the three (eg, pidgin doesn't care), but all clients just seem to squirt out all 3 anyway, and only negiotate actual capabilities when they try to make a call
21:47:21 <aleth> It sounds like a bug to depend on the presence of these google-specific capabilities when determining whether to offer video though.
21:47:57 <aleth> I'm not sure if it's Jitsi's bug or IB's (ie if something is wrong with the other capabilities we're sending) ;)
21:48:39 <EionRobb> everyone just tries to make it work with google talk though
21:48:47 <EionRobb> *tried
21:49:32 <aleth> mayanktg: EionRobb: We don't actually know yet if Jitsi (or Pidgin, or gtalk) can handle gecko's webrtc video. But it would be interesting to know if and why it fails.
21:49:45 <EionRobb> what codec?
21:49:48 <mayanktg> Exactly. We aren't dependent on those three features. But including them with a comment mentioning about it.
21:50:28 <mayanktg> *But we can include them mentioning a comment about it.
21:51:20 <aleth> mayanktg: What's the codec in the offer we send?
21:52:17 <mayanktg> Just a sec. RTP/SAVPF
21:53:40 <EionRobb> does webrtc support relays?
21:55:35 <aleth> mayanktg: Is SAVPF really the video codec?
21:55:47 <aleth> EionRobb: I don't know.
21:55:51 <EionRobb> you could also test your integration with the libpurple xmpp too through instantbird, right?
21:56:27 <mayanktg> aleth: Sorry it might be VP8 . Let me give it a read.
21:57:00 <mayanktg> aleth: Yup VP8 it is.
21:57:18 <EionRobb> lol, searching for SAVPF brings up http://code.google.com/p/webrtc2sip/ :)
21:57:24 <EionRobb> SAVPF is just the transport, right?
21:57:49 <mayanktg> EionRobb: Yes. SAVPF is just the transport.
21:57:50 <aleth> Yes, afaik
21:58:05 <EionRobb> so, pretty much not compatible with jingle? :)
21:58:28 <mayanktg> We are using VP* codec. But Jitsi uses H262 video codec.
21:58:44 <mayanktg> *VP8
21:58:47 <EionRobb> there's some webrtc src/sink plugins for gstreamer
21:58:58 <mayanktg> *H264
21:59:09 <EionRobb> because the google talk client uses h264 :)
21:59:26 <EionRobb> getting gstreamer-ffmpeg working on windows for that to work with pidgin was a bitch
21:59:47 <aleth> That sounds tricky, indeed.
22:00:23 <EionRobb> http://caniuse.com/#feat=mpeg4 says there should be support as of version 26?
22:00:31 <aleth> Given mayanktg's gsoc project, we're going to be happy if webrtc calls work nicely, and go from there :)
22:01:06 <aleth> EionRobb: There's support for the codec, but I'm not sure if the webrtc implementation also supports it.
22:01:59 <aleth> mayanktg: If an incoming call offers H264, what happens?
22:03:16 <mayanktg> aleth: I get a notification to accept/reject call --> On accepting the call --> The stream isn't initialized.
22:03:44 <aleth> mayanktg: But is there an error message? Do you translate the H264 offer correctly to sdp? Where does it fail?
22:04:46 <aleth> flo-retina would probably know what webrtc supports here.
22:04:57 <EionRobb> looking at how webrtc tries to find connection candidates, looks very very similar to how jingle does it
22:06:04 <aleth> EionRobb: mayanktg has been writing sdp <-> jingle translation code.
22:06:53 <aleth> mayanktg, EionRobb: bug 948160
22:06:55 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=948160 nor, P1, mozilla33, ekr, ASSI, Adding OpenH264 support to WebRTC (Desktop)
22:07:31 <-- Even has quit (Ping timeout)
22:07:40 <mayanktg> aleth: Just a min. I'm checking for errors and will let you know the exact details.
22:08:33 <aleth> mayanktg: I'm not too surprised if it doesn't work, given the bug I just linked hasn't been fixed, but we just want to be sure the problem isn't in your code.
22:10:01 <aleth> mayanktg: You might want to cc yourself to that bug too...
22:10:32 <mayanktg> aleth: Done.
22:47:21 <-- aleth has quit (Quit: exit stage left)
22:52:02 <-- iamjayakumars has quit (Client exited)
22:52:11 <-- mayanktg has quit (Client exited)
23:09:41 --> wnayes has joined #instantbird
23:15:20 --> iamjayakumars has joined #instantbird
23:17:19 <-- qheaden has quit (Ping timeout)
23:17:32 <-- iamjayakumars has quit (Ping timeout)
23:29:27 --> clokep has joined #instantbird
23:29:27 * ChanServ sets mode +o clokep 
23:31:16 --> iamjayakumars has joined #instantbird
23:31:57 --> iamjayakumars__ has joined #instantbird
23:32:05 <-- iamjayakumars has quit (Connection reset by peer)
23:32:32 <-- iamjayakumars__ has quit (Client exited)
23:39:53 <-- clokep has quit (Ping timeout)
23:40:12 --> clokep has joined #instantbird
23:40:12 * ChanServ sets mode +o clokep 
23:57:11 <clokep> Hello.