All times are UTC.
00:12:40 --> Rym has joined #instantbird 00:22:16 <-- wnayes has quit (Ping timeout) 00:22:31 --> wnayes has joined #instantbird 00:28:58 <-- nhnt11 has quit (Ping timeout) 00:29:21 --> nhnt11 has joined #instantbird 00:30:16 <-- Armada has quit (Connection reset by peer) 00:32:10 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 00:36:19 <-- gerard-majax has quit (Quit: Ex-Chat) 00:36:31 --> gerard-majax has joined #instantbird 01:06:18 <-- Tonnes has quit (Ping timeout) 01:43:28 --> Tonnes has joined #instantbird 02:22:35 <-- wnayes has quit (Ping timeout) 02:22:56 --> wnayes has joined #instantbird 02:24:36 --> iamjayakumars has joined #instantbird 02:26:39 <-- iamjayakumars has quit (Ping timeout) 03:03:23 <-- Rym has quit (Ping timeout) 03:21:01 <instant-buildbot> build #2258 of macosx-nightly-default is complete: Failure [4failed shell_5] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2258 03:28:33 --> Rym has joined #instantbird 03:34:15 --> CAKCy has joined #instantbird 03:35:33 <-- wnayes has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 03:49:24 --> iamjayakumars has joined #instantbird 03:59:51 <-- iamjayakumars has quit (Client exited) 04:04:13 <instant-buildbot> build #1441 of win32-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1441 04:15:25 <-- Rym has quit (Ping timeout) 04:47:21 --> iamjayakumars has joined #instantbird 05:14:38 <-- iamjayakumars has quit (Client exited) 05:21:15 <-- gerard-majax has quit (Ping timeout) 05:55:41 <-- mconley has quit (Input/output error) 06:07:56 <nhnt11> Hi 06:08:16 <nhnt11> I'm going out for lunch, I'll look at the awesometab regression when I get back 06:08:29 <nhnt11> clokep; Please ping me again if I forget later. 06:08:36 <nhnt11> See you later 06:15:35 --> EionRobb has joined #instantbird 07:19:36 --> jb has joined #instantbird 07:57:49 --> iamjayakumars has joined #instantbird 08:01:19 * flo-retina is annoyed by these repeated Mac upload failures 08:01:29 --> arlolra has joined #instantbird 08:01:45 <flo-retina> I guess I should look for a network cable and plug that mac mini directly to the router again 08:11:03 <-- arlolra has quit (Quit: arlolra) 08:13:39 <-- jb has quit (Quit: jb) 08:13:50 --> Armada has joined #instantbird 08:15:23 --> jb has joined #instantbird 08:26:12 <-- jb has quit (Ping timeout) 08:37:13 <-- iamjayakumars has quit (Client exited) 08:52:15 --> mpmc has joined #instantbird 09:00:22 --> iamjayakumars has joined #instantbird 09:02:07 * Fallen|away is now known as Fallen 09:04:04 <-- iamjayakumars has quit (Ping timeout) 09:13:04 --> Rym has joined #instantbird 09:20:32 <-- Rym has quit (Ping timeout) 09:21:09 --> Rym has joined #instantbird 09:24:47 <-- Rym has quit (Connection reset by peer) 09:25:21 --> Rym has joined #instantbird 09:36:46 <-- Rym has quit (Ping timeout) 09:37:01 * Fallen is now known as Fallen|away 09:37:56 --> Rym has joined #instantbird 10:03:23 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 10:06:05 <-- Rym has quit (Ping timeout) 10:07:54 --> Rym has joined #instantbird 10:46:33 --> ogi has joined #instantbird 11:03:28 --> mikk_s has joined #instantbird 11:03:47 --> iamjayakumars has joined #instantbird 11:04:34 <-- EionRobb has quit (Quit: Leaving.) 11:05:43 <-- iamjayakumars has quit (Ping timeout) 11:06:58 <-- Rym has quit (Ping timeout) 11:12:51 --> Hadi has joined #instantbird 11:23:14 <-- mikk_s has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 11:27:35 <-- ogi has quit (Quit: rcirc on GNU Emacs 24.3.1) 11:52:44 <-- Even has quit (Ping timeout) 11:53:12 <sawrubh> bah weird errors 11:58:02 <-- BWMerlin has quit (Quit: BWMerlin) 12:26:26 --> clokep has joined #instantbird 12:26:27 * ChanServ sets mode +o clokep 12:32:24 <-- Hadi has quit (Ping timeout) 12:32:41 <sawrubh> with my rebased patch (and having copied OAuth2.jsm inside im/modules/) I get this error when I try to add a Box account: https://pastebin.mozilla.org/5550694 12:37:05 <sawrubh> gah 12:37:43 * sawrubh builds TB to see what happens in it while adding Box 12:52:01 --> Even has joined #instantbird 12:52:01 * ChanServ sets mode +o Even 12:54:40 <clokep> Do you also have the browserRequest.xul file and stuff? 12:59:56 <sawrubh> no 13:10:38 <sawrubh> sorry was afk 13:28:53 --> mpmc has joined #instantbird 13:29:51 <-- mpmc has left #instantbird () 14:05:43 --> jb has joined #instantbird 14:28:44 --> aleth has joined #instantbird 14:28:44 * ChanServ sets mode +o aleth 14:43:53 --> mikk_s has joined #instantbird 14:45:27 <-- mikk_s has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 14:46:14 <-- aleth has quit (Quit: exit stage left) 14:50:08 <-- jb has quit (Ping timeout) 15:01:36 --> Rym has joined #instantbird 15:01:59 <nhnt11> Hello 15:02:04 * nhnt11 looks at the awesometab regression 15:03:45 <-- nhnt11 has quit (Ping timeout) 15:03:48 --> nhnt11 has joined #instantbird 15:04:03 --> iamjayakumars has joined #instantbird 15:06:16 <-- iamjayakumars has quit (Ping timeout) 15:06:38 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:07:02 --> nhnt11 has joined #instantbird 15:07:07 <-- nhnt11 has quit (Input/output error) 15:07:42 --> nhnt11 has joined #instantbird 15:08:11 <nhnt11> Indeed it appears to be caused by https://hg.mozilla.org/comm-central/rev/c94223070d13 15:09:02 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:09:08 --> nhnt11 has joined #instantbird 15:14:24 --> mconley has joined #instantbird 15:18:40 <instantbot> New Instantbird - Other bug 1037974 filed by nhnt11@gmail.com. 15:18:42 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1037974 nor, --, ---, nobody, NEW, [Regression] Awesometab doesn't rank MUCs properly 15:20:37 <nhnt11> flo-retina: Maybe you'd like to steal the review on that bug if you've got a minute^ ? 15:20:58 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:21:21 --> nhnt11 has joined #instantbird 15:21:41 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:21:49 --> nhnt11 has joined #instantbird 15:23:42 <flo-retina> nhnt11: I don't understand what the patch does at first glance, so if you think it will be trivial for aleth, I'm happy to wait for him 15:23:51 <flo-retina> otherwise if you want to explain so that it looks trivial to me, go ahead 15:26:04 * clokep thinks he vaguely follows it. 15:27:34 <flo-retina> oh, the previous code was assigning the new instance to a local variables that was overwritten at the next iteration of the loop? 15:29:07 <nhnt11> flo-retina: Yes, I'm not sure why it only affected MUCs 15:29:43 <flo-retina> nhnt11: a comment in the bug explaining what the problem was would have been helpful; and would still be helpful for future reference :) 15:30:14 <nhnt11> Right, I'll make sure I do that next time 15:30:30 <flo-retina> nhnt11: is there any risk gStatsByConvId may not be initialized when we run that code? 15:31:01 <nhnt11> flo-retina: No, https://mxr.mozilla.org/comm-central/source/im/components/ibConvStatsService.js#32 15:31:25 --> iamjayakumars has joined #instantbird 15:31:30 <flo-retina> nhnt11: ok. Is there any risk it may contain previous obsolete data we want to get rid of? 15:31:55 <nhnt11> flo-retina: Any obsolete data will be overwritten 15:32:09 <nhnt11> Any data that wasnt in the cache should be kept anyway 15:32:49 <flo-retina> the previous code (before the patch that caused the regression) replaced the whole object; that's why I'm asking 15:33:28 <nhnt11> I realize that, I think the new code is better 15:34:30 <clokep> nhnt11: "Right, I'll make sure I do that next time" it'll be nice to include a summary in this bug too. 15:34:37 <nhnt11> ok 15:34:59 * nhnt11 is eating, give me some time :) 15:36:50 <flo-retina> alright, if you are confident, r+ 15:37:01 <flo-retina> it's clearly better than what's currently in the tree anyway :) 15:37:15 <-- Rym has quit (Ping timeout) 15:38:23 <flo-retina> nhnt11: in the future, please also mark regression bugs as blocking the bug that caused the regression 15:38:54 --> Rym has joined #instantbird 15:42:32 <-- Rym has quit (Ping timeout) 15:43:02 --> Rym has joined #instantbird 15:45:40 <-- Rym has quit (Ping timeout) 15:46:09 --> Rym has joined #instantbird 15:51:44 --> Hadi has joined #instantbird 15:56:42 <-- Rym has quit (Ping timeout) 15:56:54 <-- iamjayakumars has quit (Client exited) 15:57:22 --> iamjayakumars has joined #instantbird 15:58:14 <-- nhnt11 has quit (Ping timeout) 15:58:36 --> iamjayakumars__ has joined #instantbird 15:58:50 <-- iamjayakumars has quit (Connection reset by peer) 15:59:06 --> Rym has joined #instantbird 15:59:15 --> nhnt11 has joined #instantbird 16:16:08 <-- Rym has quit (Ping timeout) 16:20:42 --> mpmc has joined #instantbird 16:22:24 --> Rym has joined #instantbird 16:27:04 <-- Rym has quit (Connection reset by peer) 16:27:20 --> Rym has joined #instantbird 16:29:13 <-- Rym has quit (Ping timeout) 16:29:36 --> mayanktg has joined #instantbird 16:32:54 <-- mconley has quit (Input/output error) 16:34:15 --> Rym has joined #instantbird 16:42:37 <-- mayanktg has quit (Ping timeout) 16:42:59 --> mayanktg has joined #instantbird 16:53:49 <nhnt11> fOkay 16:53:52 <nhnt11> okay* 17:14:44 <-- iamjayakumars__ has quit (Client exited) 17:15:08 --> iamjayakumars has joined #instantbird 17:17:03 <-- iamjayakumars has quit (Ping timeout) 17:17:37 * Fallen|away is now known as Fallen 17:22:55 --> wnayes has joined #instantbird 17:27:25 <-- Rym has quit (Quit: WeeChat 0.4.3) 17:40:33 --> Rym has joined #instantbird 17:55:13 <-- Rym has quit (Ping timeout) 17:57:47 --> mconley has joined #instantbird 18:18:29 <-- mayanktg has quit (Ping timeout) 18:18:44 --> mayanktg has joined #instantbird 18:20:28 <-- mayanktg has quit (Ping timeout) 18:20:51 --> mayanktg has joined #instantbird 18:24:28 <-- mayanktg has quit (Ping timeout) 18:24:44 --> mayanktg has joined #instantbird 18:24:46 --> Rym has joined #instantbird 18:30:04 <-- Rym has quit (Ping timeout) 18:30:07 * sawrubh wonders whether to move or copy browserRequest.cs 18:30:13 <sawrubh> *browserRequest.css 18:30:31 --> zen_monkey has joined #instantbird 18:30:34 --> Rym has joined #instantbird 18:31:13 <clokep> sawrubh: I think we have a copy of it, essentially, in im/ already. 18:31:22 <sawrubh> also I get this error while signing: https://pastebin.mozilla.org/5551320 18:31:24 <clokep> It might not be called the identical thing. 18:31:40 <sawrubh> seems something elated to the key 18:31:52 <sawrubh> did you get a key issued for TB or any application? 18:32:07 <clokep> That question doesn't make sense. 18:32:36 <clokep> sawrubh: Did you check that it works in TB btw? 18:32:38 <sawrubh> so I get the error I pastebinned, which says invalid client 18:32:50 <sawrubh> yes it works perfectly in TB 18:37:46 <-- wnayes has quit (Ping timeout) 18:37:58 --> wnayes has joined #instantbird 18:38:07 <clokep> Hmm.... 18:38:28 <clokep> One second. 18:39:58 <sawrubh> btw we have a browserRequest.xul in chat/content, here's the diff with the one in mail/base/content (which OAuth2.jsm originally uses) http://www.diffchecker.com/z2rxptwy (left is the one in chat, right is the one in mail) 18:40:10 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 18:40:16 <sawrubh> I had tried using the one in chat but had some issues, I'll try again 18:40:56 <clokep> sawrubh: More likely the diff of the JS is more important. 18:41:21 <clokep> sawrubh: What's the actual error you see? With line numbers and such. 18:41:27 <clokep> Is there a description? 18:41:29 <clokep> Did you turno n debugging? 18:41:51 <sawrubh> clokep: are you asking about the error while signing into Box? 18:46:26 <-- Rym has quit (Ping timeout) 18:47:23 <sawrubh> btw the js seem pretty much similar http://www.diffchecker.com/ifw7jvlr except for the difference with regards to <statusbar> (L34-41 of http://www.diffchecker.com/z2rxptwy) 18:50:36 * sawrubh goes to watch the World Cup 18:51:17 <clokep> sawrubh: Yes, to signing in. 18:51:21 <clokep> And yes, they look pretty similar. :) 18:51:32 <sawrubh> catch you after the World Cup :) 18:51:45 <clokep> Yes, I'm gonna do that too 18:57:58 <-- mayanktg has quit (Ping timeout) 18:58:17 --> mayanktg has joined #instantbird 19:07:04 <-- mayanktg has quit (Ping timeout) 19:07:39 --> mayanktg has joined #instantbird 19:14:51 <-- mayanktg has quit (Ping timeout) 19:15:13 --> mayanktg has joined #instantbird 19:20:33 <-- mayanktg has quit (Ping timeout) 19:20:54 --> mayanktg has joined #instantbird 19:27:55 <-- mayanktg has quit (Ping timeout) 19:28:17 --> mayanktg has joined #instantbird 19:30:04 <-- mayanktg has quit (Ping timeout) 19:30:26 --> mayanktg has joined #instantbird 19:32:42 <-- Hadi has quit (Ping timeout) 19:42:24 --> Rym has joined #instantbird 19:45:40 --> gerard-majax__ has joined #instantbird 19:53:18 <-- mayanktg has quit (Ping timeout) 19:53:36 --> mayanktg has joined #instantbird 19:59:12 <-- Rym has quit (Ping timeout) 20:00:34 <-- mayanktg has quit (Ping timeout) 20:01:15 --> mayanktg has joined #instantbird 20:03:53 <-- mayanktg has quit (Ping timeout) 20:04:33 --> mayanktg has joined #instantbird 20:10:58 <-- mayanktg has quit (Ping timeout) 20:11:17 --> mayanktg has joined #instantbird 20:15:38 <-- mayanktg has quit (Ping timeout) 20:15:57 --> mayanktg has joined #instantbird 20:16:28 --> EionRobb has joined #instantbird 20:19:32 <-- mayanktg has quit (Ping timeout) 20:19:53 --> mayanktg has joined #instantbird 20:21:39 <-- mayanktg has quit (Ping timeout) 20:21:57 --> mayanktg has joined #instantbird 20:22:13 <-- gerard-majax__ has quit (Ping timeout) 20:25:34 <-- mayanktg has quit (Ping timeout) 20:25:46 --> mayanktg has joined #instantbird 20:28:51 --> Rym has joined #instantbird 20:29:16 <-- mayanktg has quit (Ping timeout) 20:30:06 --> mayanktg has joined #instantbird 20:39:43 <-- Rym has quit (Ping timeout) 20:40:22 --> Rym has joined #instantbird 20:45:44 <-- mayanktg has quit (Ping timeout) 20:46:02 --> mayanktg has joined #instantbird 21:00:16 <-- mayanktg has quit (Ping timeout) 21:00:29 --> mayanktg has joined #instantbird 21:02:11 <-- mayanktg has quit (Ping timeout) 21:02:37 --> mayanktg has joined #instantbird 21:04:41 --> gerard-majax__ has joined #instantbird 21:06:48 <-- gerard-majax__ has quit (Ping timeout) 21:25:35 <-- mayanktg has quit (Ping timeout) 21:26:24 --> mayanktg has joined #instantbird 21:44:23 <-- EionRobb has quit (Ping timeout) 21:44:42 --> EionRobb has joined #instantbird 21:49:35 <-- mayanktg has quit (Ping timeout) 21:55:18 <-- zen_monkey has quit (Quit: Saliendo) 22:08:07 <-- CAKCy has quit (Quit: Have a great day everyone!) 22:09:58 --> zen_monkey has joined #instantbird 22:16:59 <-- Rym has quit (Ping timeout) 22:31:01 <nhnt11> flo-retina, clokep: Pushing bug 1037974, any objections? 22:31:03 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1037974 nor, --, ---, nhnt11, ASSI, [Regression] Awesometab doesn't rank MUCs properly 22:31:07 * nhnt11 would like that fixed in tomorrow's nightly 22:31:30 <flo-retina> go ahead 22:31:31 <clokep> nhnt11: Star the tree first? 22:31:35 <flo-retina> it's r+'ed, right? 22:31:45 <flo-retina> clokep: isn't it im/ only? 22:31:49 <nhnt11> clokep: It's IM only, is it important I star the tree? (I don't mind doing it but am in a hurry to go to bed) 22:31:52 <nhnt11> flo-retina: yes. 22:31:54 <clokep> Oh, yeah. Never mind. :) 22:31:57 <clokep> nhnt11: Nah, just push. 22:33:49 <instantbot> nhnt11@gmail.com changed the Resolution on bug 1037974 from --- to FIXED. 22:33:50 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1037974 nor, --, 1.6, nhnt11, RESO FIXED, [Regression] Awesometab doesn't rank MUCs properly 22:33:59 <nhnt11> Good night 22:34:19 <clokep> Thanks1 22:37:44 <-- wnayes has quit (Ping timeout) 22:38:02 --> wnayes has joined #instantbird 22:39:10 --> Rym has joined #instantbird 22:51:37 <-- zen_monkey has quit (Ping timeout) 23:14:31 <-- Rym has quit (Connection reset by peer) 23:14:50 --> Rym has joined #instantbird 23:34:55 <-- Rym has quit (Ping timeout) 23:35:09 * Fallen is now known as Fallen|away 23:36:01 --> Rym has joined #instantbird 23:38:10 --> zen_monkey has joined #instantbird 23:52:23 <-- zen_monkey has quit (Connection reset by peer) 23:56:04 <-- Armada has quit (Connection reset by peer)