All times are UTC.
00:00:46 --> nhnt11-testing has joined #instantbird 00:02:18 <nhnt11-testing> \o/ 00:02:20 <nhnt11-testing> Log sets! 00:02:25 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 00:02:45 <-- Rym has quit (Ping timeout) 00:03:51 --> nhnt11-testing has joined #instantbird 00:04:46 <-- nhnt11-testing has quit (Client exited) 00:04:57 --> nhnt11-testing has joined #instantbird 00:05:19 <-- EionRobb has quit (Ping timeout) 00:05:39 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 00:06:38 --> EionRobb has joined #instantbird 00:06:41 <nhnt11> Bah, search is a bit broken 00:06:47 <nhnt11> I need to sleep though 00:06:49 <nhnt11> Good night 00:11:37 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 00:36:01 <-- Hadi has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 00:44:36 <-- wnayes has quit (Ping timeout) 00:44:58 --> wnayes has joined #instantbird 00:58:51 --> Rym has joined #instantbird 01:03:50 <-- Rym has quit (Ping timeout) 01:07:48 <-- Mook_as has quit (Quit: Mook_as) 01:33:31 --> Rym has joined #instantbird 01:42:31 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 02:10:41 <-- Rym has quit (Ping timeout) 02:18:36 --> Rym has joined #instantbird 02:32:20 --> mconley has joined #instantbird 02:44:11 <-- wnayes has quit (Ping timeout) 02:44:26 --> wnayes has joined #instantbird 03:02:04 --> Mook has joined #instantbird 03:08:48 <-- Rym has quit (Ping timeout) 03:26:29 <-- Mook has quit (Quit: Mook) 03:39:43 <-- wnayes has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 03:47:02 <-- mconley has quit (Input/output error) 04:03:44 <instant-buildbot> build #1439 of win32-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1439 05:23:52 --> jb has joined #instantbird 05:33:40 <-- jb has quit (Ping timeout) 05:41:32 <-- EionRobb has quit (Quit: Leaving.) 05:42:39 --> jb has joined #instantbird 06:07:15 --> gerard-majax has joined #instantbird 06:09:38 <-- jb has quit (Ping timeout) 06:09:56 --> jb has joined #instantbird 06:22:01 <instant-buildbot> build #2254 of macosx-nightly-default is complete: Failure [4failed hg_1] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2254 06:22:04 <-- gerard-majax has quit (Ping timeout) 06:36:52 --> gerard-majax has joined #instantbird 07:00:57 <-- gerard-majax has quit (Ping timeout) 07:03:25 <-- GeekShadow has quit (Ping timeout) 07:36:50 --> CAKCy has joined #instantbird 07:48:44 --> mconley has joined #instantbird 07:50:10 --> gerard-majax has joined #instantbird 07:50:36 <-- mconley has quit (Ping timeout) 07:52:09 --> Hadi has joined #instantbird 08:06:26 --> chrisccoulson has joined #instantbird 08:12:03 --> mayanktg-ph has joined #instantbird 09:15:20 --> jb1 has joined #instantbird 09:15:23 <-- jb has quit (Connection reset by peer) 09:34:02 --> aleth has joined #instantbird 09:34:02 * ChanServ sets mode +o aleth 09:34:21 <aleth> The tree is green :) Land all the things! 09:38:30 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 09:40:11 <-- aleth has quit (Ping timeout) 09:43:26 --> aleth has joined #instantbird 09:43:26 * ChanServ sets mode +o aleth 09:44:00 <aleth> nhnt11: sounds like progress :) 09:44:10 <-- jb1 has quit (Ping timeout) 09:46:27 <CAKCy> aleth: FYI. Had a crash earlier. Computer waking up from sleep wi Instantbird running already. There was a disagreement between it and Avast. Didn't have a chance to send crash report. 09:46:47 <aleth> What disagreement? 09:47:55 <aleth> Does Avast not recognise IB? 09:48:06 <CAKCy> Avast sandboxed the exe (though I installed and went through Avast analysis yesterday). Avast insisted on analyzing twice (and I presume that was the reason of the crash) 09:48:30 <aleth> Sounds like an Avast bug. Maybe they need to whitelist IB... 09:48:52 <CAKCy> Probably... I get that a lot with .Net ClickOnce 09:49:13 <aleth> You could tell their support about it? 09:50:08 <CAKCy> Will have a couple more test gos and if it keeps analyzing will let them know. 09:51:08 --> jb has joined #instantbird 09:52:56 <nhnt11> aleth: :) 09:53:31 * nhnt11 will be back in a couple of hours 09:54:00 <aleth> If you have time, push all your checkin-needed patches now while the tree is open ;) 09:55:06 <sawrubh> aleth: can you push bug 1021684 so that we can then land my FileLink patch 09:55:09 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1021684 nor, --, ---, clokep, ASSI, Update box.com Filelink implementation to new APIs 09:55:58 <aleth> sawrubh: Does your Filelink patch have r+? It would be great to land it. 09:56:27 <sawrubh> it has r+ from mconley but flo still has to review it 09:56:48 <sawrubh> I think it has something from clokep as well 09:56:48 * sawrubh checks 09:57:00 * Fallen|away is now known as Fallen 09:57:32 <aleth> I'm pretty sure that box patch also needs to be uplifted so I'll leave it to clokep. 10:02:11 <-- aleth has quit (Ping timeout) 10:05:53 --> flo-retina has joined #instantbird 10:05:53 * ChanServ sets mode +qo flo-retina flo-retina 10:07:34 <flo-retina> aleth: any idea why the hg pull of mozilla-central could be failing on our mac slave? :( 10:22:05 <flo-retina> I have an IRC nick in my buddy list who's shown as "status unknown" in the conversation tab since I reconnected 10:22:14 <flo-retina> but when hovering the tab, whois shows he's available 10:25:51 <flo-retina> the only vaguely interesting thing I can see in the debug log is that we sent an automatic WHOIS to a lowercase version of that nick 10:26:17 <flo-retina> (I thought we had something more efficient than whois to get presence info on moznet) 10:27:11 --> clokep has joined #instantbird 10:27:11 * ChanServ sets mode +o clokep 10:27:19 --> aleth has joined #instantbird 10:27:19 * ChanServ sets mode +o aleth 10:28:25 <aleth> flo-retina: The conversation tab will still show unknown because there's no buddy associated with the conversation. 10:28:35 <flo-retina> why? 10:28:48 <flo-retina> the tab was green before I disconnected. 10:29:06 <aleth> Is the conversation with a contact? 10:29:16 <flo-retina> yes 10:29:16 <aleth> Otherwise I don't see how it could be. 10:29:17 <flo-retina> I said "I have an IRC nick in my buddy list who's shown as "status unknown" in the conversation tab since I reconnected" 10:29:40 <aleth> :( 10:29:46 <aleth> Sounds like a new bug then. 10:30:01 <flo-retina> note: the contact is also not shown as online in the contacts window 10:30:34 <aleth> That's not surprising. We don't get the presence for contacts via whois btw. 10:30:46 <flo-retina> so what's causing the automatic WHOIS? 10:30:49 <aleth> So there's probably something going wrong with the watch/monitor/ison 10:30:57 <flo-retina> I vaguely assumed it was only for people I had active conversations with 10:31:09 <flo-retina> except we WHOIS'ed automatically 4-5 people, only 2 of which I had active conversations with 10:31:11 <aleth> Your whois was probably when you hovered over the contact or tab 10:31:12 <aleth> ? 10:31:36 <aleth> Or when you opened the conversation? (we do a whois then) 10:31:57 <flo-retina> aleth: there's no way I could have hovered "felipe" and "Sylvestre" within the same second. They are at the opposite end of the contacts list 10:32:04 <flo-retina> (and I don't have active conversations with them) 10:32:32 <clokep> I don't think we auto-whois anyone. 10:32:32 <aleth> Then I don't understand what's going on. 10:32:59 <clokep> I'll check in all of our chat patches once I get to work. 10:33:07 <clokep> I'd prefer to check in the box one myself btw. 10:33:10 <aleth> We don't (outside of the two cases I mentioned) 10:33:30 <flo-retina> this is strange :-/ 10:34:17 <clokep> (BUt if someone could star the tree that would be helpful!) 10:34:33 <flo-retina> note: we sent a ISON command 10:34:41 <aleth> clokep: It's surprisingly green ;) 10:34:43 <flo-retina> the nick of the person who's shown as "unknown" is NOT in the list of nicks we sent. 10:35:00 <clokep> :-S 10:35:06 <clokep> Do you have a lot of people on your list? 10:35:13 <clokep> We trim that list down and rotate the names sent each time. 10:35:20 <flo-retina> clokep: we sent 22 nicks 10:35:23 <aleth> We don't send ISON for people we MONITOR 10:35:28 <aleth> What network is he on? 10:35:33 <flo-retina> only one ISON was sent 10:35:39 <flo-retina> aleth: moznet 10:35:51 <flo-retina> the nick is Gijs (if that's relevant) 10:36:23 <flo-retina> another thing that may or may not be relevant. I added this nick to my list of contacts yesterday. 10:36:41 <flo-retina> and given that this night's nightly has failed, I haven't restarted Instantbird since that. 10:36:55 <sawrubh> clokep: can you answer that 'move sendErrorMessage' query I sent in the email, btw that classInfo thing is done, I had just forgotten to push the right change :P 10:37:05 <clokep> sawrubh: Not right now. 10:37:12 <sawrubh> ok np 10:37:13 <clokep> I will when I get to work. 10:38:14 <aleth> moznet uses WATCH iirc 10:38:15 <flo-retina> this is the only IRC nick in my buddy list that's showing as "unknown" if I display offline contacts 10:38:31 <aleth> If you reconnect the IRC account, does he show up? 10:38:33 <-- jb has quit (Ping timeout) 10:38:41 <flo-retina> aleth: we sent a WATCH command too 10:38:55 <aleth> Did the WATCH command include him? 10:38:56 <clokep> OK, so it sounds like something isn't working properly when you add someone to your list. 10:39:05 <flo-retina> no 10:39:10 <aleth> clokep: That sounds plausible 10:39:12 <flo-retina> clokep: yes, that seems the most likely 10:39:38 <flo-retina> the likely steps to reproduce are "1. add someone to your list. 2. Disconnect. 3 Reconnect" 10:39:39 <aleth> flo-retina: So try reconnecting, if we are right that should make him appear available 10:39:44 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 10:39:48 --> flo-retina has joined #instantbird 10:39:49 * ChanServ sets mode +qo flo-retina flo-retina 10:39:50 <aleth> s/reconnecting/restarting 10:40:16 --> jb has joined #instantbird 10:40:32 <flo-retina> aleth: you sure there's nothing else I should extract from this process before restarting? 10:40:46 <aleth> flo-retina: I think we're OK. 10:41:11 <flo-retina> my error console has several "Error: uncaught exception: 2147500033" 10:41:18 <aleth> If we can't reproduce we won't know what to do anyway 10:41:23 <aleth> flo-retina: I filed that bug already 10:41:27 <-- Hadi has quit (Ping timeout) 10:41:29 <flo-retina> they are from yesterday afternoon though 10:41:41 <flo-retina> ok 10:41:42 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 10:41:49 --> flo-retina has joined #instantbird 10:41:49 * ChanServ sets mode +qo flo-retina flo-retina 10:42:18 <aleth> bug 1019132 10:42:20 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1019132 nor, --, ---, nobody, NEW, "uncaught exception: 2147500033" on opening an awesometab 10:42:21 <flo-retina> aleth: he is (unsurprisingly) showing as online after a restart 10:43:03 <aleth> We'll have to look at what (doesn't) happen when you add a contact then 10:44:14 <aleth> Smells like a regression somehow. 10:44:57 <clokep> I really wish that code had more tests. :-\ 10:45:03 <instantbot> New Chat Core - IRC bug 1037379 filed by florian@queze.net. 10:45:04 <flo-retina> +1! 10:45:05 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1037379 nor, --, ---, nobody, NEW, Newly added contact shown as status unknown after reconnecting 10:45:05 <clokep> aleth: Btw I think I know how to fix that topic issue you're seeing. 10:45:39 <clokep> aleth: I think if http://dxr.mozilla.org/comm-central/source/chat/protocols/irc/irc.js#542 returns undefined then it will work. 10:45:40 --> Hadi has joined #instantbird 10:48:08 <aleth> clokep: I'm not sure - won't there still be an undefiined != undefined here? http://dxr.mozilla.org/comm-central/source/chat/protocols/irc/irc.js#511 10:48:57 <clokep> aleth: Yes, but that's fine. 10:49:19 <clokep> We don't have to send that notification a billion times, just once. 10:49:26 <aleth> But when will we send it? 10:49:38 <clokep> I have to think about it more. 10:49:59 <clokep> It was just an idea. 10:50:05 <aleth> Maybe a check when the participant is added? 10:52:06 <aleth> Since the problem occurs when that happens after the mode set. 10:54:19 <clokep> Are you sure? 10:54:26 <clokep> Why is that not in the bug? 10:54:36 <aleth> It is in the bug. 10:55:45 <aleth> https://bugzilla.mozilla.org/show_bug.cgi?id=1034971#c4 10:55:47 <instantbot> Bug 1034971 nor, --, ---, nobody, NEW, Regression: IRC topic not always settable on freshly-joined channels 10:56:04 * clokep wonders if that's the unread bugmail he has in that thread. ;) 10:56:08 <clokep> Ah yes, it must be. 10:56:27 <clokep> Bah, yeah I never saw that ocmment. 10:56:43 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 10:58:40 --> mayanktg has joined #instantbird 10:59:34 <flo-retina> any idea of the mac slave? :-S 10:59:48 <flo-retina> oh, it finally worked 11:00:20 <flo-retina> it took 1582s to clone m-c :-S 11:01:00 <aleth> Bad cable connection? 11:09:09 --> Armada has joined #instantbird 11:15:53 <-- aleth has quit (Quit: exit stage left) 11:15:57 --> aleth has joined #instantbird 11:15:58 * ChanServ sets mode +o aleth 11:17:28 --> ig0rk0 has joined #instantbird 11:17:34 <ig0rk0> hi 11:18:00 <ig0rk0> addons.instantbird not working :( 11:22:01 <aleth> ig0rk0: Looks like it :( 11:22:05 <aleth> flo-retina ^^ 11:24:26 <-- aleth has quit (Quit: exit stage left) 11:24:31 --> aleth has joined #instantbird 11:24:31 * ChanServ sets mode +o aleth 11:31:41 <-- aleth has quit (Ping timeout) 11:43:42 <-- mayanktg-ph has quit (Quit: ) 11:45:18 <-- mayanktg has quit (Ping timeout) 11:50:05 --> mayanktg has joined #instantbird 11:52:35 --> clokep_work has joined #instantbird 11:52:35 * ChanServ sets mode +o clokep_work 11:53:08 <clokep_work> So what bugs need pushing I'm gonna do chat stuff now. 11:57:06 <sawrubh> clokep_work: bug 1021684 11:57:08 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1021684 nor, --, ---, clokep, ASSI, Update box.com Filelink implementation to new APIs 11:58:28 <-- mayanktg has quit (Ping timeout) 12:03:33 <-- jb has quit (Quit: jb) 12:04:51 --> jb has joined #instantbird 12:05:01 <clokep_work> sawrubh: Mark just pushed that. 12:05:09 <-- jb has quit (Input/output error) 12:05:34 <sawrubh> yeah, pulling and then rebasing and then re-requesting review on it 12:06:47 <clokep_work> Cool. 12:06:50 <clokep_work> Good luck. :-\ 12:10:53 --> jb has joined #instantbird 12:13:26 --> Rym has joined #instantbird 12:20:05 <-- Rym has quit (Connection reset by peer) 12:20:48 --> Rym has joined #instantbird 12:23:05 <instant-buildbot> build #2256 of macosx-nightly-default is complete: Failure [4failed shell_5] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2256 12:27:32 <flo-retina> should we retrigger? Or do we not care as there's been no ib commit yesterday? 12:28:18 <sawrubh> clokep_work: I have an issue, if I have to replace L717 of http://pastebin.instantbird.com/748996 with using ClassInfo instead, it's a problem, because ClassInfo is with the XMPPFileTransfer object but that object isn't available until the receiver has accepted the offer :/ 12:29:00 <sawrubh> I could create a ClassInfo object just for this as a workaround 12:39:02 <clokep_work> Bah the tree is closed again. 12:39:22 <nhnt11> Hello 12:48:44 <flo-retina> clokep_work: that was quick! 12:49:16 <nhnt11> Ah, bug 1034981 is r+ 12:49:18 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1034981 nor, --, 1.6, nobody, NEW, Ugly 'typing' tab color 12:49:24 <nhnt11> Can I push it? It's im only and really annoying 12:49:29 <flo-retina> sure 12:50:04 <flo-retina> if it complains, you'll have to add "a=im/-only patch on CLOSED TREE" at the end of your commit message 12:50:19 <nhnt11> It shouldn't, right? After aleth's patch? 12:51:01 <flo-retina> I don't remember if aleth patched that or just mentioned how to do it 12:51:09 <flo-retina> nhnt11: anyway, go ahead! :-D 12:51:14 <clokep_work> nhnt11: Just wait one second please. 12:51:39 <nhnt11> clokep_work: I'm waiting. 12:52:09 <clokep_work> nhnt11: OK. 12:52:15 <clokep_work> I had an unread message in #maildev. 12:52:23 <clokep_work> I had just asked to push some chat/ patches of Mark, was hoping he ahd replied. 12:52:25 <clokep_work> But he didn't. 12:52:27 <clokep_work> So go ahead. ;) 12:52:47 <nhnt11> clokep_work: OK as in "Go ahead"? 12:52:55 <nhnt11> Yeah, just saw that, cool 12:53:30 <clokep_work> Yes. 12:53:38 <nhnt11> flo-retina: It worked fine without modifying the commit message :) 12:53:39 <nhnt11> aleth++ 12:53:42 <flo-retina> :) 12:54:09 <nhnt11> flo-retina: Should I wipe the [1.6-blocking] tag from the whiteboard? 12:54:12 <flo-retina> maybe it's time to retrigger a nightly then? :-D 12:54:14 <flo-retina> nhnt11: no 12:54:20 <flo-retina> nhnt11: it doesn't matter on resolved bugs 12:54:39 <clokep_work> sawrubh: I know I still owe you some answers. 12:54:39 <flo-retina> and it's good to still have it if we ever need to reopen the bug 12:54:40 <nhnt11> clokep_work: Yes for the whiteboard thing? 12:54:42 <clokep_work> My boss came in... 12:54:49 <clokep_work> nhnt11: No. 12:56:25 <-- nhnt11 has quit (Ping timeout) 12:56:28 --> nhnt11 has joined #instantbird 12:56:38 <nhnt11> Wow, my internet just lagged massively 12:56:56 <nhnt11> (I got a ton of pending messages at once, then ping'd out) 12:57:36 <nhnt11> Heh, they arrived totally out of order too 12:58:03 <instantbot> nhnt11@gmail.com changed the Resolution on bug 1034981 from --- to FIXED. 12:58:04 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1034981 nor, --, 1.6, nobody, RESO FIXED, Ugly 'typing' tab color 12:58:56 <nhnt11> clokep_work: Um, did you mark it as regression before or after I posted the changeset link? 12:58:59 * nhnt11 is confused 12:59:30 <nhnt11> Never mind 13:10:27 <clokep_work> sawrubh: ping 13:10:35 <clokep_work> nhnt11: It's all shown in the bug... 13:11:35 <nhnt11> yeah sorry, internet problems 13:12:04 <clokep_work> sawrubh: Your question makes no sense (the classinfo one you asked me in IRC) 13:12:08 <clokep_work> And where did you go? 13:12:12 <clokep_work> Please ping me when you're back. 13:15:25 <-- jb has quit (Ping timeout) 13:17:41 <-- nhnt11 has quit (Ping timeout) 13:17:45 --> nhnt11 has joined #instantbird 13:19:14 <sawrubh> Pong (I had just gone for a shower while I had left my computer to compile after the pull) 13:19:43 <sawrubh> Why doesn't it make sense 13:20:34 <sawrubh> Give me 1 minute 13:22:23 * sawrubh -> back 13:23:32 <flo-retina> sawrubh: it makes no sense, please rephrase it instead of asking us to try to figure it out _again_. 13:23:40 <sawrubh> ok, so in order to do something like <XMPPFileTransfer object>.__proto__.QueryInterface(Ci.prplIFileTransfer) instead of XPCOMUtils.generateQI([Ci.prplIFileTransfer]) don't you think I would need access to XMPPFIleTransfer object 13:26:11 <sawrubh> do I make sense or should I ask in a clearer way? 13:26:40 <sawrubh> clokep_work: ^ 13:27:11 <flo-retina> sawrubh: the <XMPPFileTransfer object>.__proto__.QueryInterface(Ci.prplIFileTransfer) part doesn't make sense. Why would you do that? (or what do you expect it to do?) 13:30:43 <flo-retina> so what are you actually trying to do? 13:30:49 <sawrubh> so I (think I) was asked to use ClassInfo (https://mxr.mozilla.org/comm-central/source/chat/modules/imXPCOMUtils.jsm#164) instead of generateQI in bug 1024023, so I planned to use ClassInfo's QueryInterface method to get the QI 13:30:52 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1024023 nor, --, ---, saurabhanandiit, ASSI, Add File Transfer Support for JS-XMPP 13:30:59 <clokep_work> flo-retina: I asked him to use ClassInfo instead of generateQI. 13:31:13 <clokep_work> sawrubh: That's not really what I meant. 13:31:25 <clokep_work> The last part: "so I planned to use ClassInfo's QueryInterface method to get the QI" is wrong. 13:31:48 <flo-retina> alright, I'll let clokep_work clarify then :) 13:32:17 <clokep_work> sawrubh: All you need to do is something like https://mxr.mozilla.org/comm-central/source/chat/modules/jsProtoHelper.jsm#234 13:32:54 <clokep_work> Once that is figured out, we can discuss the other things in your email. 13:33:07 <sawrubh> I had already done that in L287 of http://pastebin.instantbird.com/748996 13:33:27 <clokep_work> sawrubh: Can you please stop sending huge diffs. 13:33:31 <clokep_work> Send us just the change you made. 13:33:57 <sawrubh> ok 13:34:04 <clokep_work> OK, so you did that and...it didn't work? 13:34:23 <sawrubh> this was part of my first patch itself on which you commented use ClassInfo 13:34:51 <sawrubh> I was wondering what else to do besides doing what https://mxr.mozilla.org/comm-central/source/chat/modules/jsProtoHelper.jsm#234 does 13:35:13 <nhnt11> brb 13:35:47 <nhnt11> Hmm, more like bbl 13:36:27 <clokep_work> sawrubh: So this goes back to my question of why are you not using that object in othe rplaces you generate a filetransfer. 13:36:31 <clokep_work> Which you never answered. 13:36:49 <clokep_work> Lines 702 - 718 and 640 - 643. 13:38:24 <sawrubh> I think I saw in the usage of notifyObserver somewhere that they included a QI while populating the object they sent as an argument to notifyObserver and I did that same :) 13:38:40 <sawrubh> I never realized having a ClassInfo in your object allowed you to not have this 13:38:55 <clokep_work> IT's provided by the ClassInfo prototype. 13:39:00 <clokep_work> That still doesn't really answer my question though. 13:40:38 <sawrubh> I told you, I didn't realize it could be done that way 13:43:40 <-- BWMerlin has quit (Quit: BWMerlin) 13:43:42 --> mconley has joined #instantbird 13:43:44 <sawrubh> should we discuss the other thing in my email? 13:44:00 * Fallen is now known as Fallen|away 13:44:35 <-- ig0rk0 has quit (Quit: http://www.mibbit.com ajax IRC Client) 13:44:35 <clokep_work> sawrubh: Clearly I don't consider that a real answer, but OK. 13:45:30 <clokep_work> sawrubh: Adding an nsIArray of prplIFileTransfer to have optional arguments is NOT ok. 13:45:34 <clokep_work> What are those arguments going to be? 13:45:36 <clokep_work> Something like a filename? 13:45:43 <clokep_work> That's already PART of the prplIFileTransfer object. 13:45:49 <clokep_work> There's no reason to send it again. 13:46:58 --> aleth has joined #instantbird 13:46:59 * ChanServ sets mode +o aleth 13:48:27 --> jb has joined #instantbird 13:50:24 * Fallen|away is now known as Fallen 13:50:51 --> mpmc has joined #instantbird 13:53:30 <sawrubh> right now yes, it's mostly just the name of the sender or the receiver (since this interface is used by both of them it's the name of the other guy) but I wanted to have the space for further changes, say we want to have an error message with the amount of bytes written till now then we'll have to make it a part of the prplIFileTransfer object when we want 13:53:30 <sawrubh> to do that 13:53:44 <sawrubh> now this is speculative but I just wanted to keep this in mind 13:54:05 <clokep_work> I'd prefer we not over-engineer something with possibilities until we need them. :) 13:54:15 <clokep_work> So don't worry about adding something like that until we need it. 13:54:29 <sawrubh> ok done :) 13:54:50 <clokep_work> Is it clear now how that can be moved into the UI? 13:56:10 <sawrubh> yes, first off stop creating a new object for notifyObserver's, instead populate the existing object which is created once (either during fileOffer or otherwise) 13:56:38 <sawrubh> secondly use the exisiting attribute in the interface to create the error string dynamically if it's needed 13:57:16 <sawrubh> (like the sender attribute inside prplIFileTransfer) 13:57:44 <sawrubh> and I should probably rename it to something more generic since 'sender' could be technically either the receiver or the sender 13:57:53 <-- Rym has quit (Ping timeout) 13:59:39 * Fallen is now known as Fallen|away 14:00:13 <clokep_work> Yes. 14:02:04 <sawrubh> I'll get back in sometime (turns out I forgot to clobber before building and showering and it failed it between) so I'm gonna clobber and let it build again and then do the rebasing 14:02:17 <sawrubh> should take around 35 minutes 14:03:10 <instantbot> clokep@gmail.com changed the Resolution on bug 1018771 from --- to FIXED. 14:03:11 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1018771 min, --, 1.6, clokep, RESO FIXED, Use Maps and Sets in XMPP code 14:03:40 <instantbot> clokep@gmail.com changed the Resolution on bug 963519 from --- to FIXED. 14:03:41 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=963519 min, --, 1.6, clokep, RESO FIXED, Stop using Object.prototype.__proto__ because of bug 948227 14:03:49 <sawrubh> or wait, does the tree being closed means that the changes I've pulled already are *not* supposed to successfully build? 14:03:53 <aleth> \o/ Thanks for doing those checkins clokep_work :) 14:04:00 <sawrubh> s/means/mean 14:04:28 <clokep_work> sawrubh: It should build OK. It's back open. 14:04:29 <aleth> I just saw the tree was closed so I wasn't expecting them... 14:04:36 <clokep_work> aleth: Standard8 reopened it for me. 14:07:30 <aleth> nhnt11: What's with the log splitting patch? 14:08:21 <aleth> Ah, you wanted flo to take another look I guess. 14:09:09 <-- sawrubh has quit (Ping timeout) 14:09:33 <clokep_work> sawrubh: And I'd suggest you talk to aleth about Tasks, I've never used them. 14:11:12 --> sawrubh has joined #instantbird 14:18:41 <sawrubh> yay, that MUC bug should be doable now or probably work already with the patch I have :) 14:20:19 * flo-retina wonders what the "this.buddy is null" error in his console is. 14:20:31 <flo-retina> I always suspect the "Other Contacts" magic tag when that kind of stuff appears :-S 14:21:09 <flo-retina> it's exciting that we'll no longer be seeing these __proto__ assignment warnings :) 14:21:12 <flo-retina> clokep_work++ 14:23:16 <clokep_work> flo-retina: I only wrote one patch there. :P 14:23:23 <clokep_work> Everyone deserves a ++, I think. ;) 14:23:27 <flo-retina> but you pushed that forward 14:23:29 <clokep_work> sawrubh: And I'd suggest you talk to aleth about Tasks, I've never used them. 14:23:39 <flo-retina> or nhnt11 :) 14:24:08 <sawrubh> it would be great if aleth could oversee the Tasks part of the next version of my patch 14:24:16 <flo-retina> clokep_work: now if some day I could convince you of cleaning up that "Error: Registration completed before SASL authentication completed." error, my console would be almost clean ;) 14:24:28 <sawrubh> I'm still not sure about Tasks but I don't wanna spend too much time on it also 14:24:40 <clokep_work> flo-retina: I want to take another look at the SASL code soon, yes. :) 14:24:49 <aleth> sawrubh: If you're confident about Promises now, then do it with promises, that's enough to get r+ 14:26:36 <sawrubh> actually I found the Task example (on the MDN page) more understandable (relatively) so have done it that way and it works and I think it's correct, I don't wanna think how to complex-ly do it the Promises way now 14:26:42 <aleth> OK 14:27:57 --> iamjayakumars has joined #instantbird 14:46:02 --> rosonline has joined #instantbird 14:47:55 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 14:52:10 <sawrubh> I get https://pastebin.mozilla.org/5544699 while building :/ 14:52:26 <nhnt11> re 14:52:29 <nhnt11> I can help with Tasks, yeah. 14:52:45 <sawrubh> also pasting something on http://pastebin.instantbird.com/ isn't working properly 14:52:57 <sawrubh> it doesn't give me the correct link, it just redirects back to http://pastebin.instantbird.com/ 14:53:01 <nhnt11> Working fo rme 14:53:40 <clokep_work> sawrubh: That looks like fallout from a bustage that was fixed recently, I guess not in the TrayToolkit code for Linux though. 14:53:51 <clokep_work> sawrubh: Checkout the last two commits on https://hg.mozilla.org/users/florian_queze.net/purple 14:54:24 <sawrubh> I had pulled libpurple too from ^ this repo 14:54:46 * sawrubh checking the committs 14:54:53 --> BillBinkley has joined #instantbird 14:55:20 <aleth> sawrubh: You'll have to create a similar patch for the file causing the error. 14:56:35 <sawrubh> ok, should I submit a patch for Linux after I get it working locally? 14:56:37 <sawrubh> or does someone else have it planned? 14:57:11 <aleth> No, please do that. 15:09:10 <-- jb has quit (Ping timeout) 15:13:54 --> jb has joined #instantbird 15:14:31 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 15:18:40 --> rosonline has joined #instantbird 15:21:28 <-- nhnt11 has quit (Ping timeout) 15:21:51 --> nhnt11 has joined #instantbird 15:23:00 <sawrubh> btw the changes are live on bugsahoy and whatcanidoformozilla :) 15:23:08 <flo-retina> :) 15:23:15 <sawrubh> so start mentoring bugs and expecting new contributors 15:27:20 <aleth> thanks! 15:28:05 --> Rym has joined #instantbird 15:35:31 <sawrubh> aleth: do we have on file about the Linux build issue otherwise I'll file one 15:35:38 <sawrubh> +a bug 15:36:00 <aleth> Attach it to the existing bug 1036367 15:36:02 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1036367 nor, --, 1.6, aleth, RESO FIXED, Fix dangerous public destructors in purple/ 15:36:30 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:41:33 <-- jb has quit (Quit: jb) 15:44:59 --> jb has joined #instantbird 15:47:15 <clokep_work> sawrubh: Any of us can review it, most likely. ;) 15:50:22 --> mayanktg has joined #instantbird 15:51:00 <-- aleth has quit (Ping timeout) 15:51:12 <-- jb has quit (Ping timeout) 15:52:16 <-- gerard-majax has quit (Ping timeout) 15:53:49 <-- mayanktg has quit (Ping timeout) 15:54:51 --> mayanktg has joined #instantbird 15:57:53 <-- nhnt11 has quit (Ping timeout) 15:58:47 --> nhnt11 has joined #instantbird 15:59:01 <-- Rym has quit (Ping timeout) 15:59:24 --> Rym has joined #instantbird 16:23:52 <clokep_work> Looks like they're adding some more stuff to moz.build again, but jcranmer made patches that include chat/im. 16:24:55 * sawrubh can't figure out why https://pastebin.mozilla.org/5544928 isn't working 16:26:13 <clokep_work> You probably should have asked us this sooner. :) What was teh error again? 16:26:46 <sawrubh> https://pastebin.mozilla.org/5544931 16:27:42 <clokep_work> sawrubh: I /think/ you have to make http://dxr.mozilla.org/comm-central/source/im/components/mintrayr/trayPlatform.h#52 private 16:28:04 <sawrubh> how did trayPlatorm.h come into context o.O 16:39:55 <sawrubh> even with https://pastebin.mozilla.org/5544944 as patch I get https://pastebin.mozilla.org/5544943 16:40:06 <sawrubh> I tried different things but it didn't work 16:40:43 <sawrubh> different = making it non-virtual, removing the empty body of virtual implementation 16:45:17 <-- BillBinkley has quit (Ping timeout) 16:45:33 --> aleth has joined #instantbird 16:45:33 * ChanServ sets mode +o aleth 16:45:41 <sawrubh> aleth: ^ 16:47:29 <aleth> sawrubh: You can't make it private if there is a delete call calling the destructor from the outside ;) 16:48:09 <sawrubh> I clearly haven't eaten my C++ breakfast 16:48:09 <sawrubh> today 16:48:10 * instantbot mumbles something about c++ being evil 16:48:47 <sawrubh> aleth: so what should I do because the initial error did want me to make it private 16:49:21 <aleth> sawrubh: You either find a way to get rid of the delete call, or you do what the linked bug suggests for marking it an exception. 16:51:49 --> nhnt11-testing has joined #instantbird 16:53:43 <-- aleth has quit (Ping timeout) 16:53:52 <nhnt11> :-/ 16:54:06 <nhnt11> I've added the "function" thingy to my callback interface 16:54:14 <nhnt11> But I'm still forced to create an object wrapper for the callback 16:54:25 <nhnt11> I wonder if I have to query interface somewhere :-/ 16:54:29 <clokep_work> aleth: Thanks. Any reason for Object.getProtoOf instead of hard coding it like normal? 16:54:32 <nhnt11> Hmm, possibly... 16:55:02 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:55:26 --> nhnt11-testing has joined #instantbird 16:56:24 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:56:59 --> Mook_as has joined #instantbird 16:57:04 --> nhnt11-testing has joined #instantbird 16:57:13 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:57:37 --> nhnt11-testing has joined #instantbird 16:57:57 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:58:55 --> nhnt11-testing has joined #instantbird 16:59:55 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:00:05 --> nhnt11-testing has joined #instantbird 17:00:35 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:01:53 --> nhnt11-testing has joined #instantbird 17:03:19 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:03:31 --> nhnt11-testing has joined #instantbird 17:04:49 <-- Rym has quit (Ping timeout) 17:05:07 --> Rym has joined #instantbird 17:06:31 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:07:19 --> nhnt11-testing has joined #instantbird 17:07:27 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:13:29 <nhnt11> Indexing seems noticeably slower, not sure if it's because of the extra imILog instances... 17:13:42 --> nhnt11-testing has joined #instantbird 17:14:14 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:16:18 --> nhnt11-testing has joined #instantbird 17:18:52 <-- Rym has quit (Ping timeout) 17:25:25 <-- nhnt11-testing has quit (Client exited) 17:25:41 <nhnt11> Bah, storing paths relative to the logs dir in the db makes stuff complicated :-/ 17:28:11 --> nhnt11-testing has joined #instantbird 17:28:18 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:28:59 --> nhnt11-testing has joined #instantbird 17:29:06 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:29:22 --> nhnt11-testing has joined #instantbird 17:29:30 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:31:13 --> nhnt11-testing has joined #instantbird 17:31:32 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:33:11 <sawrubh> aleth: https://pastebin.mozilla.org/5545153 still doesn't fix it 17:33:37 --> nhnt11-testing has joined #instantbird 17:34:14 <sawrubh> it says https://pastebin.mozilla.org/5545157 17:34:18 <-- nhnt11 has quit (Ping timeout) 17:34:28 <sawrubh> while I see that's how it's being used in http://dxr.mozilla.org/comm-central/search?q=HasDangerousPublicDestructor&redirect=true 17:34:40 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:35:43 --> nhnt11-testing has joined #instantbird 17:36:01 <sawrubh> also there is no nsTArray which I could replace with some ref counted nsCOMArray if bug 1036367 is what you meant by 'what the linked bug suggests' 17:36:02 --> nhnt11 has joined #instantbird 17:36:03 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1036367 nor, --, 1.6, aleth, RESO FIXED, Fix dangerous public destructors in purple/ 17:36:20 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:36:50 --> nhnt11-testing has joined #instantbird 17:37:01 <clokep_work> sawrubh: That is not what he meant. 17:37:04 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:37:31 --> nhnt11-testing has joined #instantbird 17:37:55 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:38:04 <clokep_work> sawrubh: https://hg.mozilla.org/comm-central/rev/bbefe71a3aea#l1.13 is an example of using that. 17:38:14 <clokep_work> But if you really can't get it to work, just stop building it in the moz.build file and move on. 17:38:14 --> nhnt11-testing has joined #instantbird 17:38:17 --> flo-retina has joined #instantbird 17:38:17 * ChanServ sets mode +qo flo-retina flo-retina 17:39:10 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:39:19 --> nhnt11-testing has joined #instantbird 17:40:15 --> BillBinkley has joined #instantbird 17:40:25 <-- nhnt11-testing has quit (Client exited) 17:40:33 --> nhnt11-testing has joined #instantbird 17:40:56 --> aleth has joined #instantbird 17:40:56 * ChanServ sets mode +o aleth 17:41:04 <sawrubh> clokep_work: I'll give it one more try otherwise I'll move on, just hope not building this wouldn't affect me rebasing and testing the FileLink patch after the rebase 17:41:17 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:42:08 * nhnt11 grinds his teeth 17:42:10 --> nhnt11-testing has joined #instantbird 17:42:14 <clokep_work> sawrubh: It might be a bit annoying, but just keep it in a separate patch in your queue and you should be OK. :) 17:42:23 <clokep_work> This is why we need Linux nightlies back. :( 17:42:26 <nhnt11> Log tree rebuilding, y u no work!? 17:42:35 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:42:35 <aleth> nhnt11: http://log.bezut.info/instantbird/140711/#m485 sounds disappointing after all this work... 17:43:02 <nhnt11> aleth: May not be too difficult to mitigate. 17:43:17 <nhnt11> And I'm not sure what exact change is causing it to slow down, I should diagnose that first 17:43:29 <nhnt11> And before all of that, I need to get the log tree to rebuild 17:43:32 <aleth> First get it working of course ;) 17:43:39 <nhnt11> I've got a new log set with the results, no idea why it's not rebuilding it 17:44:18 --> nhnt11-testing has joined #instantbird 17:44:46 <nhnt11> Sorry for the join/part spam btw 17:45:04 <nhnt11> #instantbird is really teh only channel where I have a lot of logs on my testing profile.. 17:45:18 <aleth> How are you "rebuilding" it? 17:45:53 <nhnt11> aleth: http://pastebin.instantbird.com/749131 17:46:03 <nhnt11> I was doing something similar before and it was working.. 17:46:10 --> Rym has joined #instantbird 17:46:31 <aleth> The promise isn't resolving? 17:46:36 <nhnt11> It's resolving 17:46:44 <nhnt11> The reportError says "false" 17:46:45 <aleth> Just checking... 17:46:47 <nhnt11> As expected 17:47:05 <nhnt11> And the chatLogTreeView is going through the logs (forEach is being called) 17:47:25 <aleth> Sounds like it's being constructed then 17:47:32 <-- nhnt11-testing has quit (Client exited) 17:47:35 <nhnt11> Yeah. 17:47:40 --> nhnt11-testing has joined #instantbird 17:47:47 <nhnt11> Aha! 17:47:55 <nhnt11> The problem isn't in rebuilding! 17:48:05 <nhnt11> It appears that the log set returned is the original one 17:48:08 <-- mconley has quit (Input/output error) 17:48:15 <nhnt11> Even though I'm constructing a new one with the entries from the search results 17:48:20 <nhnt11> (6 entries) 17:48:22 <nhnt11> Weird :-/ 17:48:24 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:48:34 <-- Hadi has quit (Ping timeout) 17:49:42 --> nhnt11-testing has joined #instantbird 17:49:51 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:50:34 --> nhnt11-testing has joined #instantbird 17:51:03 <aleth> sawrubh: Did you get it fixed? 17:51:15 <aleth> Ah, I see clokep_work linked you to an example. 17:52:21 <nhnt11> WTF 17:52:44 <nhnt11> Every time I fetch the logs for #instantbird, the number of files increases by 972 17:52:50 <nhnt11> (which is hte actual number of log files) 17:53:03 <aleth> So you keep adding to the "log set"? 17:53:07 <nhnt11> Is this some memory leak? 17:53:24 <nhnt11> aleth: Should I be defining an array as null in the prototype and setting it in the constructor? 17:53:38 <aleth> I have no idea what your current code looks like. 17:53:57 <nhnt11> I'm pastebinning context 17:53:59 <aleth> It doesn't sound like a leak, more like a bug. 17:54:06 <aleth> Not that leaks aren't bugs... 17:54:43 <nhnt11> aleth: http://pastebin.instantbird.com/749132 17:55:00 <-- BillBinkley has quit (Ping timeout) 17:55:08 <nhnt11> The problem is that after a DailyLogSet is constructed, the next one inherits all the paths of the first one 17:55:14 <-- nhnt11-testing has quit (Client exited) 17:55:23 --> nhnt11-testing has joined #instantbird 17:56:14 <aleth> If you're really creating a new object, that won't "just happen". 17:56:23 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:56:30 <nhnt11> Yeah, that's what's puzzling me 17:56:39 <aleth> You're probably adding to aEntries somewhere. 17:57:23 <aleth> Remember objects get passed as references. 17:57:34 <nhnt11> I know that.. 17:57:37 <nhnt11> Hmm 17:57:54 <aleth> Yeah, but it's still a likely source of mistakes like that one ;) 17:58:11 <nhnt11> I'm certainly creating new objects where I should be 17:58:24 --> nhnt11-testing has joined #instantbird 17:58:47 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:59:36 <aleth> Btw I would have left the relative path stuff out of the initial patch, to avoid complications. 17:59:45 --> nhnt11-testing has joined #instantbird 18:00:32 <nhnt11> aleth: I got everything by working by resetting all of the properties in the prototype in the constructor 18:01:08 <nhnt11> Well, at least it's working now :) 18:01:09 <aleth> Are you sure there isn't a "new" missing somewhere? 18:01:35 <aleth> so that's the only bug :-) 18:01:39 <nhnt11> Yeah. I'm sure. 18:02:24 <aleth> Oh, I know what you might have been doing. 18:02:35 <aleth> You've been pushing to a property *of the prototype* 18:02:50 <aleth> So any new objects created inherit the modified prototype. 18:03:12 <aleth> So your workaround is actually the correct fix, probably. 18:03:15 <nhnt11> aleth: Yeah, but not intentionally 18:03:22 <nhnt11> aleth: I just looked it up, DailyLogEnumerator is already doing that 18:03:26 <nhnt11> https://mxr.mozilla.org/comm-central/source/chat/components/src/logger.js#555 18:03:44 <aleth> Yes, you have to. 18:03:50 <nhnt11> Hmm, cool 18:03:52 <nhnt11> (I think) 18:04:02 <aleth> Do you understand why? 18:04:11 <nhnt11> I do 18:04:15 <aleth> Cool :) 18:04:23 <nhnt11> But I don't understand why the designer of the language would think that this is good behavior 18:04:29 <aleth> Haha. 18:04:47 <clokep_work> nhnt11: FWIW Python is identical. 18:04:50 <nhnt11> aleth: I just remembered I had a similar problem in the stats service 18:04:54 <aleth> You mean, "why aren't prototypes protected somehow"? 18:05:03 <aleth> Ask Brendan ;) 18:05:16 <nhnt11> Why does doing something to this.foo in the constructor modify the prototype? 18:05:54 <aleth> Because the property foo is defined on the prototype. 18:06:07 <nhnt11> Ah, references/ 18:06:16 <aleth> If you do a this.foo = {} first then you create a new object overriding the prototype. 18:06:34 <aleth> The reason we have the foo: {} in the prototype is so you can delete this.foo ;) 18:06:43 <aleth> Also, for documentation. 18:07:02 * nhnt11 wishes the language would do some magic 18:07:03 <nhnt11> anyway 18:07:06 <nhnt11> nice that this is out of hte wya 18:07:08 <nhnt11> the way* 18:07:12 <nhnt11> Everything seems to be working 18:07:18 <nhnt11> ..... time to look at gloda :( 18:07:26 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 18:07:35 <aleth> Why gloda? 18:07:40 <nhnt11> I think I'll clean stuff up first.. 18:07:40 <nhnt11> aleth: LogSets 18:07:44 <clokep_work> nhnt11: But in some use cases you WANT that to be shared amongst all prototypes 18:07:46 <clokep_work> So it can't do magic. 18:07:50 <aleth> Oh, have you rewritten logger.js again? :D 18:07:57 <nhnt11> yeah 18:08:25 <aleth> nhnt11: You may have a whole prototype chain, in which case it might make sense not to have all but the top level immutable. 18:08:42 <aleth> It's basically just the absence of "private" in JS. 18:08:50 <nhnt11> clokep_work: Fair enough... I guess 18:08:53 <-- mayanktg has quit (Ping timeout) 18:09:11 <nhnt11> aleth: I think it's just my brain treating prototypes like abstract classes or something :] 18:09:58 <aleth> I don't know what the JS inheritance model is called in CS-speak 18:10:10 <aleth> maybe "a strangely functional mess" :P 18:10:15 --> mayanktg has joined #instantbird 18:10:20 <nhnt11> Haha 18:17:04 <sawrubh> woot fixed 18:24:26 <sawrubh> or not :/ the build proceeded, now it fails like https://pastebin.mozilla.org/5545213 with patch as https://pastebin.mozilla.org/5545212 18:24:31 <sawrubh> aleth: ^ 18:25:04 <clokep_work> sawrubh: That's odd. :-\ 18:25:17 <sawrubh> indeed, should I clobber? 18:25:41 <aleth> Weird. 18:25:45 <sawrubh> because the build proceeded and then this error is weird 18:27:36 * sawrubh just clobbered 18:27:38 <sawrubh> let's see what happens after tha 18:27:52 <aleth> You're sure there was no error further up? 18:28:35 <sawrubh> yes I'm quite sure 18:29:38 <aleth> Let's hope a clobber works then 18:30:48 <-- iamjayakumars has quit (Client exited) 18:36:29 <sawrubh> and it fails again :/ 18:36:56 <sawrubh> and this time I've piped the output so I know for sure there's no error in it any place else besides this last 18:37:28 * sawrubh wonders if there's anything wrong with the patch https://pastebin.mozilla.org/5545212 18:38:36 <clokep_work> aleth: So...where does that even get called as an array? :-S 18:38:49 <aleth> What where? 18:39:02 <clokep_work> trackBuddy 18:39:20 <aleth> Look at the 251 message for example 18:40:04 <aleth> sawrubh: (long shot) try a space after "template" and removing the "mintrayr::" 18:40:30 * sawrubh tries all shots 18:41:19 <clokep_work> aleth: https://mxr.mozilla.org/comm-central/source/chat/protocols/irc/ircBase.jsm#541 ? 18:41:38 <aleth> sawrubh: Actually you've got the wrong class name :( 18:41:51 <aleth> http://lxr.instantbird.org/instantbird/source/instantbird/components/mintrayr/trayToolkit.h#91 18:42:19 <aleth> Hmm, maybe not. 18:42:50 <aleth> Yeah, ignore that. 18:42:56 --> BillBinkley has joined #instantbird 18:43:29 <sawrubh> maybe I should use http://dxr.mozilla.org/comm-central/source/im/components/mintrayr/trayPlatform.h#52 I mean have Icon inside rather than TrayIconImpl 18:43:55 <aleth> No 18:44:18 <aleth> At least, I don't think that's the problem. 18:46:08 <aleth> clokep_work: http://mxr.mozilla.org/comm-central/source/chat/protocols/irc/ircWatchMonitor.jsm#150 18:46:30 <sawrubh> strike 1: space after template doesn't work 18:47:03 <aleth> space after template should definitely work 18:47:13 <-- BillBinkley has quit (Ping timeout) 18:47:16 <aleth> Leaving out the mintrayr::, I'm not so sure about. 18:48:16 <aleth> sawrubh: While you're trying these long shots, you could ask bjacob for advice. 18:48:40 * sawrubh finds him at #gfx 18:48:49 <clokep_work> aleth: Ah, right! It's cause it's weird that sometimes we want to make efficient messages and other times we just send the individual nick. 18:49:27 <aleth> clokep_work: I think the reason for passing the array is that we want to send a single WATCH message for all of them on connection, not one for each 18:49:38 <clokep_work> aleth: That's what I just said. ;) 18:49:39 <aleth> ah yeah, that's what you meant by efficient I guess 18:49:43 <aleth> :D 18:49:51 <clokep_work> aleth: And it's confusing that the method changes while the protocol is running. 18:49:54 <Mook_as> sawrubh: does http://logs.glob.uno/?c=mozilla%23developers&s=9+Jul+2014&e=9+Jul+2014#c1006368 sound relevant? 18:49:59 <clokep_work> So all the stuff is inited using the one on the prototype. 18:50:18 <aleth> Yes. 18:50:46 <aleth> It could do with some streamlining, if that's possible, but that would take more though. 18:50:48 <aleth> thought 18:52:53 <sawrubh> Mook_as: thanks for the pointer however it looks like sfink never reached a solution 18:53:52 <Mook_as> Err, bug 1036525? 18:53:54 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1036525 nor, --, mozilla33, sphink, RESO FIXED, elfhack failing to build with missing DSO_SONAME 18:55:22 <sawrubh> Mook_as: ...and someone else got it too later http://logs.glob.uno/?c=mozilla%23developers&s=9+Jul+2014&e=9+Jul+2014#c1006701 18:59:10 <-- Rym has quit (Ping timeout) 19:00:12 --> Rym has joined #instantbird 19:00:29 <aleth> clokep_work: Thanks for the reviews! 19:01:25 <instantbot> aleth@instantbird.org changed the Resolution on bug 1037379 from --- to FIXED. 19:01:27 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1037379 nor, --, 1.6, aleth, RESO FIXED, Newly added contact shown as status unknown after reconnecting 19:02:16 <instantbot> aleth@instantbird.org changed the Resolution on bug 1034971 from --- to FIXED. 19:02:17 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1034971 nor, --, 1.6, aleth, RESO FIXED, Regression: IRC topic not always settable on freshly-joined channels 19:02:19 <aleth> Nice to be able to push stuff immediately :) 19:04:46 <mayanktg> Done with the sending the entity discovery part...Now I have to add check device support in the conversation binding...and look for bugs. 19:04:49 --> Even has joined #instantbird 19:04:49 * ChanServ sets mode +o Even 19:05:02 <aleth> mayanktg: Sounds good :) 19:07:03 <sawrubh> and just like that my problems are solved! 19:07:13 <sawrubh> jcranmer is ma hero! 19:07:23 <mayanktg> There is a problem that two accounts cannot detect their capabilities if they are on the same Instantbird instance...because they simultaneously send similar "id" ..6..7..8..9.. to each other and it causes conflict. :P . I'll fix it though. 19:07:47 <aleth> sawrubh: What was the fix? 19:08:07 <sawrubh> dunno, he says he has the *fix*, is planning to push 19:08:21 * sawrubh eyes c-c or whichever tree that's gonna be pushed greedily 19:08:22 <aleth> mayanktg: That means the id's aren't unique enough. 19:08:37 <clokep_work> Someone tell me "no" next time I file a "fix up crappy code" :P 19:09:32 <aleth> clokep_work: Why? Which bug is this? 19:12:20 <clokep_work> aleth: A few of my recent bugs have had bad regressions. :( 19:12:51 <aleth> clokep_work: You could rephrase that as "the existing code was lacking comments around nontrivial stuff" if you want to feel better ;) 19:15:39 * aleth is impressed there have been no regressions from nhnt11's async logs so far 19:15:44 <aleth> test coverage ftw I guess! 19:16:03 <nhnt11> aleth: Yeah, I did a lot of testing (automated and manual..) 19:16:59 * nhnt11 expects a regression to show up sooner or later though 19:17:10 <aleth> sawrubh: So what are you going to do until jcranmer fixes your problem? ;) 19:18:17 <sawrubh> I don't know what to code, I can probably start rebasing already 19:18:29 <aleth> clokep_work ^^ 19:18:32 <sawrubh> or read up something (but there's no code to read as such) 19:18:41 <sawrubh> I can take a look at purplexpcom 19:18:43 <clokep_work> sawrubh: Didn't I already mention above that you can just not build that code? 19:18:51 <clokep_work> So that you're not blocked on this. 19:19:24 <sawrubh> and have that in a separate mq, got it 19:20:30 <-- mayanktg has quit (Ping timeout) 19:20:45 <-- aleth has quit (Ping timeout) 19:21:57 --> mayanktg has joined #instantbird 19:24:07 --> mconley has joined #instantbird 19:26:03 <clokep_work> Lots of chat checkins today! 19:27:26 <sawrubh> and he's pushed it 19:28:51 <clokep_work> Hah. 19:29:00 <clokep_work> Just as you were about to move to something else. ;) 19:29:42 <sawrubh> this kinda thing has been happening to me quite a lot so at sometimes I just ignore the overhead and get blocked #trolling 19:30:30 <sawrubh> btw sharing my patch on #developers got me some feedback on how to do that public destructor thingy better 19:30:36 <sawrubh> :) 19:32:35 <clokep_work> sawrubh: Yeah, generally I'd suggest you guys don't update your trees THAT often, especially with how broken c-c has been recently...but in this case you had to. :( 19:36:49 <nhnt11> writing comments takes almost as much time as writing code :-/ 19:43:47 <-- mconley has quit (Input/output error) 19:53:50 <clokep_work> nhnt11: :-D But it'll help so much next time you look! 20:01:11 --> mconley has joined #instantbird 20:02:52 <-- Rym has quit (Ping timeout) 20:03:03 <-- mconley has quit (Ping timeout) 20:04:43 --> mpmc has joined #instantbird 20:05:59 <-- mayanktg has quit (Ping timeout) 20:06:46 --> mayanktg has joined #instantbird 20:13:54 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died) 20:16:07 * clokep_work goes home. 20:20:11 <-- clokep_work has quit (Ping timeout) 20:30:35 --> nhnt11-testing has joined #instantbird 20:30:48 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:31:12 --> nhnt11-testing has joined #instantbird 20:31:54 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:33:00 --> nhnt11-testing has joined #instantbird 20:33:50 <nhnt11> flo-retina: Ping 20:35:45 <-- nhnt11-testing has quit (Client exited) 20:35:56 --> nhnt11-testing has joined #instantbird 20:36:09 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:37:26 --> mconley has joined #instantbird 20:37:50 --> nhnt11-testing has joined #instantbird 20:38:11 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:39:12 --> nhnt11-testing has joined #instantbird 20:41:02 <-- nhnt11-testing has quit (Client exited) 20:41:36 * nhnt11 tries to figure out why Ib is triggering a full indexAllLogs job at startup every time 20:44:57 --> nhnt11-testing has joined #instantbird 20:45:39 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:49:05 --> chrisccoulson has joined #instantbird 20:49:58 --> arlolra has joined #instantbird 20:54:45 --> mayanktg1 has joined #instantbird 20:54:54 <-- mayanktg1 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:55:31 <flo-retina> nhnt11: pong ? 20:55:51 <-- mayanktg has quit (Ping timeout) 20:56:35 <nhnt11> flo-retina: So as discussed, imILogSet instances have a forEach method that accepts an imIProcessLogsCallback, which is one of those "function" interfaces. Problem is, it doesn't seem to work, and I'm not sure if I should be QueryInterface'ing somewhere or something. 20:56:48 <nhnt11> I'm forced to pass it a full object with a processLogs method 20:57:08 --> mayanktg has joined #instantbird 20:58:37 <nhnt11> I think I tried calling QueryInterface(Ci.imILogSet) on the log set instance to no effect, but I don't remember properly what exactly I tried.. 21:00:22 --> Hadi has joined #instantbird 21:02:30 <sawrubh> I had a similar experience with QueryInterfaces 21:03:59 <nhnt11> sawrubh: Did you arrive at a solution? 21:04:44 <sawrubh> in my case it was mostly a QueryInterface vs ClassInfo and it worked although I'm not sure how 21:05:06 <nhnt11> Hmm 21:08:25 <-- mayanktg has quit (Ping timeout) 21:09:17 --> mayanktg has joined #instantbird 21:14:41 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 21:20:25 <-- Hadi has quit (Ping timeout) 21:25:18 --> aleth has joined #instantbird 21:25:18 * ChanServ sets mode +o aleth 21:25:23 <-- arlolra has quit (Quit: arlolra) 21:26:07 * nhnt11 thinks he has satisfactorily handled shutdown 21:27:51 <nhnt11> Only thing left in the backend is (I think) closing the database connection after a period of inactivity... 21:28:47 <aleth> Maybe sqlite.jsm does this automatically? 21:28:47 <nhnt11> (For which I'll likely need yet another queue of some sort.. 21:29:10 <nhnt11> I doubt that.. but I'll research 21:29:18 <aleth> I doubt it too, but you never know. 21:29:30 <-- mconley has quit (Input/output error) 21:31:48 <aleth> Oh, some useful feedback from dholbert. Nice. 21:32:11 <nhnt11> I think I'll do a self review and upload a patch before worrying about closing the connection 21:32:23 <aleth> Good idea :) 21:32:43 <aleth> What are you doing for the searchbar -- basically lifting code from the newtab? 21:34:07 <nhnt11> aleth: Yeah, have I posted a screenshot? 21:34:34 <aleth> I've seen the screenshot, I'm more wondering if it filters while you type. 21:34:41 <nhnt11> Yes, it does. 21:34:48 <nhnt11> It does not use code from the awesometab though 21:35:02 <nhnt11> It uses the type="search" attribute on the textbox 21:35:17 <nhnt11> Which causes the command to be fired if the user pauses typing 21:35:26 <aleth> Ah, great :) 21:35:30 <nhnt11> So it's not instant, but we don't want that anyway 21:35:34 <nhnt11> Yeah, it works well. 21:36:40 <aleth> Definitely upload a patch soon. 21:36:58 <sawrubh> aleth: ask you for review with dholbert's comment? 21:37:02 <sawrubh> +addressed 21:37:23 <aleth> There'll likely be some followups anyway (color the searchbar background red if there are no hits, make it possible to step through the hits) 21:37:43 <nhnt11> aleth: What I'm doing at shutdown now is storing all pending files in a JSON file, and queuing these at the next startup. That sound fine? 21:38:02 <aleth> Pending log files you mean? 21:38:06 <flo-retina> nhnt11: have you fixed that problem you had? 21:38:09 <nhnt11> flo-retina: No. 21:38:19 <nhnt11> aleth: Yeah, pending indexing jobs 21:38:28 <flo-retina> the typical trick with the "function" interfaces is that you can pass a function only from a different compartment (ie. when you'll cross xpconnect) 21:38:39 <flo-retina> if you are calling it from within the same file, you'll need to pass a real object 21:38:47 <nhnt11> Alright, cool. 21:38:56 <nhnt11> flo-retina: What do you think of the shutdown thing I just mentioned^? 21:39:01 <aleth> nhnt11: That sounds OK, though you could persist the list, that might be easier 21:39:10 <flo-retina> nhnt11: haven't seen it 21:39:13 <aleth> And avoid the need for a temporary file. 21:39:32 <nhnt11> aleth: What does "persist the list" mean? 21:40:09 <-- Tonnes has quit (Quit: ChatZilla 0.9.90.1 [Firefox 30.0/20140605174243]) 21:40:32 <aleth> nhnt11: The equivalent of this https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Attribute/persist, or maybe in a pref. 21:41:00 <aleth> Ah, sorry I meant to link to document.persist, not the attribute 21:41:25 <nhnt11> Ah, that sounds nice 21:41:31 <nhnt11> Hmm, I didn't think of using a pref... 21:43:18 <-- rosonline has quit (Client exited) 21:45:12 --> Hadi has joined #instantbird 21:47:05 <aleth> sawrubh: I'll do that tomorrow. 21:47:33 <sawrubh> sure, it's not blocking me so doesn't really matter 21:48:33 <aleth> Yup, and I need to change my previous patch there it seems ;) 21:50:11 <-- mayanktg has quit (Ping timeout) 21:51:06 --> mayanktg has joined #instantbird 21:53:28 <nhnt11> Looks like the shutdown stuff is working nicely. 21:54:27 --> mali has joined #instantbird 21:57:06 --> clokep has joined #instantbird 21:57:06 * ChanServ sets mode +o clokep 21:58:31 <nhnt11> Another large patch.. 21:59:34 --> Hadi1 has joined #instantbird 22:00:04 <-- Hadi has quit (Ping timeout) 22:01:44 <-- Hadi1 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 22:03:10 <aleth> clokep: Did you have any luck getting your Windows to build? 22:03:16 <-- mayanktg has quit (Ping timeout) 22:03:43 <clokep> aleth: Nope. 22:03:48 --> mayanktg has joined #instantbird 22:03:49 <nhnt11> aleth: What do you think we should do for the case that there are no search results? 22:03:56 <clokep> I was going to try again briefly after putting my groceries away 22:04:08 <aleth> nhnt11: Color the search bar background red? 22:04:11 <nhnt11> Just leave the browser empty for now? 22:04:12 <nhnt11> Hm 22:04:18 <aleth> Have some sort of neutral background color 22:04:26 <nhnt11> That could be tricky/os-dependant 22:04:41 <aleth> I'm just thinking of what the FX findbar does. 22:04:43 <nhnt11> (the red background) 22:04:44 <nhnt11> yeah 22:05:02 <nhnt11> aleth: Btw, I'm leaving the findbar in there for now 22:05:09 <nhnt11> Till we have good UI to iterate through the results 22:05:22 <aleth> Right, I suggested earlier to leave that for a followup. 22:05:25 <nhnt11> yeah 22:05:36 <aleth> The patch will be big enough ;) 22:05:45 <nhnt11> I think we should discuss the to-do for the remainder of the summer btw. 22:06:02 <aleth> Definitely! 22:06:20 <nhnt11> My proposal is: get this indexing patch landed, and meanwhile start working on infinite scroll. 22:06:33 <aleth> Have you looked further at the message code flow yet? 22:06:43 <nhnt11> My priority is to get infinite scroll to fetch logs and add them 22:06:44 <aleth> That sounds like a good plan. 22:07:16 <aleth> I would suggest starting with design work on infinite scroll in parallel to review cycles on indexing + indexing followups. 22:07:35 <nhnt11> After that, I can work on starting on eliminating the log viewer (but I really don't know how much is possible with the time I have left) 22:07:36 <nhnt11> Yeah 22:07:49 <nhnt11> I haven't looked into the convbrowser code in a while 22:08:04 <aleth> And conversation.xml 22:08:28 <-- Mook_as has quit (Ping timeout) 22:08:38 <aleth> Eliminating the log viewer is way down the road. 22:08:53 <nhnt11> First step as before is to get messages to add properly in reverse order, then selectively load them when restoring a conv on hold 22:09:01 <nhnt11> I mean load the first few, and then the rest on scrolling 22:09:01 <nhnt11> yeah 22:09:26 <aleth> Before you decide on a first step, I'd like to see the big picture API plan. 22:09:54 <aleth> I mean sure, it'll be somethign like that, but the devil is in the details here. 22:10:12 <nhnt11> aleth: I suggested that first step because it's independent of log APIs 22:10:22 <nhnt11> Anyway you have a point 22:10:54 <mali> Hi people. I could find the source tracker. Where is Instantbird source hosted now? http://hg.instantbird.org/instantbird/shortlog doesn't seem fresh. 22:11:10 --> Mook_as has joined #instantbird 22:11:20 <nhnt11> Considering we're going to have split log files, I want to modify the convbrowser to "prepend" entire convs 22:11:25 <aleth> mali: https://hg.mozilla.org/comm-central/shortlog/ 22:11:40 <nhnt11> Like what it does with init(), but without discarding whatever it's already got. 22:11:55 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 22:12:49 <aleth> Adding a thousand messages isn't that quick though. 22:13:58 <nhnt11> Hmm yeah. on second thought maybe that's not as rare a case as I thought 22:14:04 <aleth> mali: Did you want to build Instantbird? 22:14:17 <nhnt11> So we'd prepend a fixed number of messages, fine. 22:14:23 <aleth> nhnt11: It's not hard to get the progress bar to appear currently. 22:14:40 <nhnt11> aleth: Right, but what about jank? 22:14:49 <-- Mook_as has quit (Ping timeout) 22:14:50 <nhnt11> And I don't think the user really wants to laod the last 1k messages 22:15:00 <nhnt11> 50 is probably more than enough. 22:15:00 <aleth> That's my point. 22:15:24 <aleth> I'm saying it's not difficult to run into noticeable delays... 22:15:33 <mali> no, I can't do it. I just wanted to see commit logs. 22:15:34 <nhnt11> Oh, that way 22:15:34 <aleth> And we should avoid them in the new API 22:15:48 <nhnt11> I thought you meant that it's easy code-wise to show the progress bar :D 22:15:55 <aleth> Heh, no :D 22:16:12 <aleth> Though we could play some music too. 22:16:23 <aleth> "Your conversation is on hold and will be displayed shortly." 22:16:27 <nhnt11> Haha 22:16:56 <clokep> mali: In particular you'll only car eabout commits to the chat/ and im/ directories. 22:17:06 * clokep has a couple of RSS feeds to follow just those two. 22:17:41 <nhnt11> I'm going to upload a patch now and go to bed, I'm pretty tired 22:17:49 <mali> clokep: I'd like to know them if possible 22:18:23 <mali> So the project is now part of thunderbird and a standalone program at the same time? 22:18:31 <clokep> mali: http://hgchanges.fractalbrew.com/comm-central/feed/chat http://hgchanges.fractalbrew.com/comm-central/feed/im 22:18:48 <clokep> mali: The chat backend is used within Thunderbird and Instantbird, but Instantbird is still a separate program. 22:19:32 <mali> clokep: hmm. thanks 22:19:42 <clokep> If that isn't clear, ask further questions. 22:20:33 <mali> in fact ı used to hang in this room 7-8 months ago. 22:20:44 <mali> i am familiar with some stuff already 22:20:45 <mali> thanks 22:21:31 <mali> as I see, the number of developers seem to be increased. 22:21:36 <mali> very good to see that. 22:22:26 <clokep> aleth: http://pastebin.instantbird.com/749203 22:22:39 <clokep> mali: Well we have three Google Summer of Code students working with us. 22:22:45 <clokep> Hopefully they'll stick around afterward. :) 22:22:53 <clokep> flo-retina: Any ideas? http://pastebin.instantbird.com/749203 22:23:42 <mali> gsoc has always been fun :) 22:24:14 <aleth> clokep: huh. 22:24:38 <clokep> aleth: Huh....my m-c seems to be from Jul 2013, wtf. 22:24:38 --> Hadi has joined #instantbird 22:25:03 <aleth> Oh well, that might be the problem then ;) 22:25:17 <clokep> But...I ran client.py checkout! 22:25:32 <aleth> And that's a *long* time ago. 22:25:39 <flo-retina> clokep: strange that you have both an error about the JAR MANIFEST and about some .lib files 22:25:41 <aleth> Any errors during client.py checkout maybe? 22:25:59 * clokep is manually updating it. 22:26:10 <clokep> flo-retina: Yeah there's something odd going on. :( 22:28:30 <aleth> clokep: Maybe you had some uncommitted changes floating around and that blocked the checkout 22:29:05 <clokep> aleth: So I had something in my mq. 22:29:11 <clokep> Then I tried to get rid of it and it wouldn't let me pop. 22:29:13 <clokep> So I recloned. 22:29:17 <clokep> And now it doesn't seem to be updating. 22:29:23 <clokep> But I just changed the hgrc to onit to the right location... 22:29:31 <clokep> But I didn't think client.py even used that 22:29:41 <aleth> Maybe just grab a fresh bundle. 22:29:58 <aleth> Probably as fast as updating the changes. 22:34:02 <aleth> Or did you reclone from hg.mozilla, not locally? 22:34:14 <clokep> I'm just pulling it from the web now. 22:34:17 <clokep> Starting at what I had. 22:34:26 <clokep> It's updating my files now. 22:34:29 <clokep> I have a pretty good connection. ;) 22:34:41 <-- Armada has quit (Connection reset by peer) 22:36:09 <nhnt11> Ahaha, I tried showing about:blank in case of no search results and got this: http://puu.sh/a7ghD/46aa83fcba.png 22:36:21 <aleth> hehe 22:36:28 <aleth> That's one of the decks. 22:36:30 <nhnt11> That's cool, I'm going to clone that for a "No results" page. 22:37:01 <aleth> Good idea! 22:37:23 <aleth> I forgot I'd added that as with daily logs, you almost never see it. 22:38:00 <nhnt11> this is great, I can just copy all the CSS :D 22:38:01 <nhnt11> aleth++ 22:42:05 --> wnayes has joined #instantbird 22:42:24 --> mpmc has joined #instantbird 22:43:17 <-- mali has quit (Quit: Instantbird http://www.instantbird.com) 22:44:28 <nhnt11> Good enough, I think? http://puu.sh/a7gWx/8520e7fd5b.png 22:44:55 <aleth> Yup. 22:45:07 <aleth> It's off-center a bit? 22:45:18 <aleth> I mean the text in the white bubble 22:45:19 <nhnt11> The text? 22:45:21 <nhnt11> Yeah 22:45:29 <aleth> Probably the lack of an icon 22:45:42 <nhnt11> Yeah, I'll fix it 22:45:51 <nhnt11> I think it's because of -moz-padding-start 22:46:21 <aleth> Or add an info icon if that's quicker. 22:46:35 <aleth> But it's not really needed. 22:46:59 <nhnt11> Now it looks off center on the other side, probably thanks to the full stop: http://puu.sh/a7h8Y/41e8a86198.png 22:47:12 <nhnt11> I think it's fine though, the period isn't my fault ;) 22:47:31 <aleth> Just drop the period :P 22:47:38 <nhnt11> Sure 22:48:12 <nhnt11> Looks good to me: http://puu.sh/a7heA/e1eca704c6.png 22:48:23 <clokep> \o/ it's using mozmake now. 22:48:25 <clokep> That's a good sign. 22:48:32 <aleth> nhnt11: WFM 22:49:10 <aleth> clokep: Sounds like it's doing what it should now :) 22:49:23 <clokep> Hopefully. 22:49:26 * clokep is clobbering. 22:49:49 <aleth> How long do Windows builds take these days? 22:49:56 <aleth> I guess you're about to find out... 22:50:53 --> Mook_as has joined #instantbird 22:51:33 --> Tonnes has joined #instantbird 22:54:17 <clokep> On my computer, about an hour. 22:54:21 <-- aleth has quit (Ping timeout) 22:55:53 --> nhnt11-testing has joined #instantbird 22:55:55 <clokep> Unfortunately if this works I still need to do a full build to test mayanktg's stuff. :( 22:56:19 <clokep> Hmm...that's odd. It wouldn't tab complete mayanktg, but it's highlighting the nick as have left. 22:56:31 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 22:58:08 <-- Hadi has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 22:58:27 <nhnt11> I need a better name for "pointFindbarToEmptyFile" 23:01:43 --> Hadi has joined #instantbird 23:03:11 <-- Hadi has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 23:05:28 --> nhnt11-testing has joined #instantbird 23:06:03 --> Hadi has joined #instantbird 23:07:04 <nhnt11> test 23:07:09 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 23:07:17 <nhnt11> Excellent, all is working methinks 23:20:43 --> Hadi1 has joined #instantbird 23:20:54 <nhnt11> Good night! 23:21:14 <-- Hadi1 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 23:21:20 --> Hadi1 has joined #instantbird 23:21:55 <-- Hadi1 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 23:22:15 <-- Hadi has quit (Ping timeout) 23:23:25 --> Hadi has joined #instantbird