#instantbird log on 07 06 2014

All times are UTC.

00:23:21 <-- Rym has quit (Ping timeout)
00:26:38 --> Rym has joined #instantbird
00:44:31 --> Armada has joined #instantbird
00:50:02 --> mconley has joined #instantbird
01:02:55 <-- Rym has quit (Ping timeout)
01:17:29 <-- Tonnes has quit (Quit: ChatZilla [Firefox 30.0/20140605174243])
01:25:26 <-- Armada has quit (Connection reset by peer)
13:50:27 <instantbot> New Instantbird - Contacts window bug 1034967 filed by aleth@instantbird.org.
13:50:29 --> instantbot has joined #instantbird
13:50:29 topic changed by concrete.mozilla.org to "Ask about Instantbird (http://instantbird.com) here!|Current version is Instantbird 1.5! :) |News: http://blog.instantbird.org/ |Nightlies: http://nightly.instantbird.im/ (for testing only) |IRC logs: http://log.bezut.info/ |Pastebin: http://pastebin.instantbird.org/ | Bugs: https://bugzilla.mozilla.org"
13:50:29 * ChanServ sets mode +v instantbot 
13:50:38 <flo-retina> instantbot: welcome back :)
13:50:39 <instantbot> salut flo-retina
13:52:38 <aleth> Using the API would mean writing an entirely new prpl?
13:52:54 <flo-retina> yes, but that's not even my concern
13:53:09 <flo-retina> my concern is that I don't find _any_ documentation any any API end point letting you chat :-/
13:53:20 <flo-retina> s/any/about/2
13:53:28 <aleth> They really don't want third party clients it seems...
13:53:56 <flo-retina> forcing people to look at the website while chatting seems a good way to have more ads-display-time per user
13:54:11 <flo-retina> now that there are enough facebook users that using facebook is unavoidable
13:54:57 <flo-retina> aleth: their current stuff used for the website looks easy to reverse engineer (it's just JSON being XHR'ed around)
13:55:26 <flo-retina> aleth: but basing a prpl on a reverse engineered protocol rather than an API exposes us to random breakage everyday whenever they change something
13:59:57 <aleth> Yes, that really doesn't sound worth the effort.
14:00:07 <flo-retina> aleth: I'm looking at https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=963519&attachment=8451349
14:00:39 <aleth> ah, the "this turned out to be a lot easier than I thought" patch?
14:00:58 <flo-retina> I have the unusual feeling that "the patch is r+, but I don't understand why" (usually when I'm unsure about a patch, it's because I feel it's r- but can't figure out something specific that is wrong about it) :-D
14:01:29 <aleth> heh, that's got to be a first :D
14:01:43 <flo-retina> aleth: nah, the patch isn't simpler than I expected.
14:01:58 <flo-retina> I think it's the case where I had said "Object.create" should be the solution in this specific case
14:03:03 <flo-retina> aleth: hmm, if we call that method several times, aren't we building a prototype chain that gets longer and longer?prototype
14:03:10 <flo-retina> (discard that last "prototype" word ^^')
14:04:44 <aleth> why?
14:07:11 <aleth> Object.create only copies the own properties from the existing object
14:08:12 <flo-retina> ah yeah
14:08:27 <flo-retina> the English version of the MDN page is somehow easier to understand :)
14:09:06 <aleth> "own properties" is terrible grammar so probably hard to translate ;)
14:09:10 <flo-retina> yeah, that patch seems correct :)
14:09:39 <flo-retina> aleth: well, the French version is plain wrong
14:10:00 <aleth> translated by someone who didn't understand what they were translating?
14:10:18 --> iamjayakumars has joined #instantbird
14:10:22 <flo-retina> it says "Si cet argument facultatif est spécifié, il représente un objet dont les propriétés seront propres au nouvel objet crée (et non partagés avec son prototype)."
14:10:34 <flo-retina> it says it will be the own properties of the new object
14:10:55 <aleth> ah, true but misleading...
14:11:16 --> iamjayakumars__ has joined #instantbird
14:11:21 <-- iamjayakumars has quit (Connection reset by peer)
14:11:39 <aleth> Missing the key detail.
14:11:49 * flo-retina isn't sure what a reasonable translation would be, and doesn't really feel like trying to make up one, but is wondering if a bug should be filed
14:12:34 <aleth> "dont les propres propriétés"? ;)
14:13:18 <aleth> makes it sound like a tongue-twister...
14:13:28 <flo-retina> "(note du traducteur) Normalement un objet n'a pas de prototype ( mais il est relié au prototype de la fonction qui a servi à le construire )." WTF...
14:15:12 <flo-retina> these pages should really be translated by someone who understands JS, or point to the english version :(
14:21:34 <aleth> How do I set an approval-comm-aurora flag? Does the bug have to be in the TB component for that to work?
14:22:20 <flo-retina> probably :-/
14:22:44 <flo-retina> we should probably file a bug to get these 2 flags added to the Chat product
14:25:28 <aleth> Bah, and I can only request the flag from you (as the reviewer) when I need standard8 for this (afaik)
14:28:20 <flo-retina> you don't request approval aurora/beta from someone specific
14:28:24 <flo-retina> you just set the flag to '?'
14:28:34 <aleth> OK then
14:28:49 <aleth> Misleading UI ;)
14:29:04 <flo-retina> bugzilla ;)
14:33:59 <flo-retina> aleth: so I think that patch is ok, but I'm wondering if it wasn't better to have an explicit list of properties we care about
14:34:27 <aleth> I wondered about that, but the explicit list is already explicit in the base constants in the same file.
14:36:29 <flo-retina> aleth: do you mean here? http://mxr.mozilla.org/comm-central/source/chat/modules/imContentSink.jsm#201
14:36:44 <aleth> Or are we worried about someone abusing this function?
14:37:02 <aleth> Yes (and at the top of the file of course)
14:37:58 <aleth> Hmm, we could actually drop that line you linked to now.
14:38:23 <aleth> Well, simplify to let result = {}.
14:39:33 <aleth> ah, no, forget I said that ;)
14:39:42 * aleth was confusing himself
14:40:15 <flo-retina> btw, I think that code has unit tests, so check they still work (although I see no reason why they should be broken by your change)
14:41:13 <aleth> I've done that
14:47:12 <-- aleth has quit (Quit: exit stage left)
14:47:50 --> aleth has joined #instantbird
14:47:50 * ChanServ sets mode +o aleth 
14:51:56 <instantbot> New Chat Core - IRC bug 1034971 filed by aleth@instantbird.org.
14:51:57 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1034971 nor, --, ---, nobody, NEW, Regression: IRC topic not always settable on freshly-joined channels
14:52:08 <flo-retina> thanks :)
14:53:44 <-- aleth has quit (Quit: exit stage left)
15:26:23 <nhnt11> Do we have a new nightly?
15:27:13 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:27:48 --> nhnt11 has joined #instantbird
15:29:42 <flo-retina> nhnt11: apparently no, but aleth has a fix for the mac failure
15:55:28 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:56:39 <-- nhnt11 has quit (Ping timeout)
15:58:13 --> nhnt11 has joined #instantbird
16:04:36 <instantbot> New Instantbird - Conversation bug 1034981 filed by florian@queze.net.
16:04:37 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1034981 nor, --, ---, nobody, NEW, Ugly 'typing' tab color
16:05:21 <nhnt11> flo-retina: Is that the typing tab or the "has finished typing" tab color?
16:05:30 <nhnt11> ah, typing.
16:05:35 <nhnt11> never mind...
16:06:07 * nhnt11 clobbers
16:06:49 <flo-retina> nhnt11: have you seen it too?
16:06:57 <nhnt11> flo-retina: Yes, but thought it was expected
16:07:07 <nhnt11> I'd already expressed my dislike for the "dimmed" colours so I kept quiet...
16:07:10 <flo-retina> the expectation is https://bug1003705.bugzilla.mozilla.org/attachment.cgi?id=8415052
16:07:12 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1003705 nor, --, 1.6, philipp, RESO FIXED, Unread/Typing/Attention colors are too bright
16:07:16 <nhnt11> Right, saw that now.
16:09:00 <-- iamjayakumars__ has quit (Client exited)
16:10:20 <flo-retina> nhnt11: does https://bug1034981.bugzilla.mozilla.org/attachment.cgi?id=8451360 match what you've observed?
16:10:23 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1034981 nor, --, ---, nobody, NEW, Ugly 'typing' tab color
16:10:28 <nhnt11> flo-retina: Yes.
16:12:10 <flo-retina> that really looks like a typo in the patch
16:12:17 <flo-retina> that color isn't even readable
16:15:44 --> iamjayakumars has joined #instantbird
16:41:54 --> mpmc has joined #instantbird
16:49:18 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:57:57 * Fallen is now known as Fallen|away
17:08:24 <-- nhnt11 has quit (Ping timeout)
17:08:27 --> nhnt11 has joined #instantbird
17:21:14 <-- iamjayakumars has quit (Quit: )
18:18:38 * Fallen|away is now known as Fallen
18:55:04 --> Rym has joined #instantbird
19:07:40 * Fallen is now known as Fallen|away
19:45:30 * Fallen|away is now known as Fallen
19:49:47 <-- Rym has quit (Ping timeout)
19:51:59 --> mpmc has joined #instantbird
19:53:36 --> Rym has joined #instantbird
20:15:35 --> aleth has joined #instantbird
20:15:35 * ChanServ sets mode +o aleth 
20:17:29 <-- aleth has quit (Quit: exit stage left)
20:23:52 --> EionRobb has joined #instantbird
20:31:44 --> mconley has joined #instantbird
20:31:47 --> Mnyromyr has joined #instantbird
20:32:48 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
20:43:38 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:50:59 <-- Rym has quit (Ping timeout)
20:51:17 --> Rym has joined #instantbird
21:03:25 * Fallen is now known as Fallen|away
21:15:19 --> clokep_work has joined #instantbird
21:15:19 * ChanServ sets mode +o clokep_work 
21:21:10 <clokep_work> flo-retina: FWIW we sohuldn't bother reverse engineering any Facebook stuff, EionRobb already plans to do it.
21:21:45 <-- gerard-majax_ has quit (Ping timeout)
21:32:33 * Fallen|away is now known as Fallen
21:43:27 <-- mconley has quit (Input/output error)
21:46:30 * Fallen is now known as Fallen|away
21:51:19 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:51:28 --> nhnt11 has joined #instantbird
22:24:58 --> aleth has joined #instantbird
22:24:59 * ChanServ sets mode +o aleth 
22:32:00 <-- aleth has quit (Quit: exit stage left)
22:32:28 --> aleth has joined #instantbird
22:32:28 * ChanServ sets mode +o aleth 
22:40:41 <-- clokep_work has quit (Ping timeout)
22:53:03 <-- aleth has quit (Quit: exit stage left)
23:40:25 --> Hadi has joined #instantbird
23:54:27 <-- mpmc has quit (Client exited)