#instantbird log on 07 02 2014

All times are UTC.

00:09:53 --> rosonline has joined #instantbird
00:14:49 <-- Rym has quit (Ping timeout)
00:15:07 --> Rym has joined #instantbird
00:18:47 <-- Rym has quit (Ping timeout)
00:33:37 --> clokep_work has joined #instantbird
00:33:37 * ChanServ sets mode +o clokep_work 
00:34:00 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
00:41:23 <-- wnayes has quit (Ping timeout)
00:44:36 --> wnayes has joined #instantbird
01:07:45 --> Rym has joined #instantbird
01:21:53 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
01:26:30 <clokep> Woot! Clean review queue. :)
01:38:05 --> mconley has joined #instantbird
01:38:39 <-- Rym has quit (Ping timeout)
02:08:18 --> Rym has joined #instantbird
02:10:31 <-- nhnt11 has quit (Ping timeout)
02:11:55 --> nhnt11 has joined #instantbird
02:34:07 <-- nhnt11 has quit (Ping timeout)
02:34:29 --> nhnt11 has joined #instantbird
02:41:02 <-- wnayes has quit (Ping timeout)
02:44:25 --> wnayes has joined #instantbird
02:47:04 <-- Rym has quit (Ping timeout)
03:08:43 <-- wnayes has quit (Quit: wnayes)
03:16:29 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
04:10:27 <-- mconley has quit (Input/output error)
04:27:21 --> mconley has joined #instantbird
04:35:47 <-- Mook has quit (Quit: Mook)
04:49:17 <-- mconley has quit (Input/output error)
04:53:26 <-- Suiseiseki has quit (Ping timeout)
05:01:51 --> gerard-majax_ has joined #instantbird
05:08:34 <-- gerard-majax_ has quit (Ping timeout)
05:22:29 <-- EionRobb has quit (Quit: Leaving.)
06:54:30 * Fallen|away is now known as Fallen
07:37:49 --> mpmc has joined #instantbird
07:46:27 <-- nhnt11 has quit (Ping timeout)
07:46:49 --> nhnt11 has joined #instantbird
07:52:28 --> gerard-majax_ has joined #instantbird
07:53:04 --> jb has joined #instantbird
08:11:18 --> Mic|web has joined #instantbird
08:49:45 <-- Tonnes has quit (Ping timeout)
08:50:26 --> Tonnes has joined #instantbird
09:16:44 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
09:17:25 --> chrisccoulson has joined #instantbird
09:23:39 --> Suiseiseki has joined #instantbird
09:26:45 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
09:28:17 --> EionRobb has joined #instantbird
10:03:15 --> BWMerlin has joined #instantbird
10:14:23 --> clokep has joined #instantbird
10:14:23 * ChanServ sets mode +o clokep 
10:16:53 <clokep> sawrubh: Did you have a chance to read over those comments yet?
10:17:44 <-- flo-retina has quit (Ping timeout)
10:29:54 <-- clokep has quit (Ping timeout)
10:33:30 * Fallen is now known as Fallen|away
10:36:20 --> flo-retina has joined #instantbird
10:36:20 * ChanServ sets mode +qo flo-retina flo-retina 
10:59:07 --> Armada has joined #instantbird
11:06:07 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:19:05 <-- EionRobb has quit (Quit: Leaving.)
11:21:08 <-- nhnt11 has quit (Ping timeout)
11:21:48 --> nhnt11 has joined #instantbird
11:21:50 * Fallen|away is now known as Fallen
11:31:53 --> mayanktg has joined #instantbird
11:35:31 --> clokep_work has joined #instantbird
11:35:32 * ChanServ sets mode +o clokep_work 
11:37:21 <-- nhnt11 has quit (Ping timeout)
11:37:43 <clokep_work> Good morning!
11:38:06 --> nhnt11 has joined #instantbird
11:39:10 <-- BWMerlin has quit (Quit: BWMerlin)
11:40:05 * Fallen is now known as Fallen|away
11:56:59 <-- nhnt11 has quit (Ping timeout)
12:07:59 <-- Armada has quit (Connection reset by peer)
12:08:10 --> Armada has joined #instantbird
12:11:28 * Fallen|away is now known as Fallen
12:26:10 * Fallen is now known as Fallen|away
12:26:52 * Fallen|away is now known as Fallen
12:31:09 <sawrubh> clokep_work: I took a look, I have a few questions which I'll post in a moment
12:31:17 <sawrubh> (sorry for being away)
12:31:49 <clokep_work> No problem. :)
12:31:54 <clokep_work> I Just can't keep track of when you kids sleep and such. :P
12:57:43 <-- mayanktg has quit (Ping timeout)
12:58:22 --> mpmc has joined #instantbird
13:01:07 * Fallen is now known as Fallen|away
13:01:17 --> mayanktg has joined #instantbird
13:44:00 <-- Even has quit (Ping timeout)
13:48:43 --> Even has joined #instantbird
13:48:43 * ChanServ sets mode +o Even 
14:00:12 --> mconley has joined #instantbird
14:00:23 --> aleth has joined #instantbird
14:00:23 * ChanServ sets mode +o aleth 
14:05:27 <mayanktg> aleth: Hey. How can I process a received IQ Stanza when account is connected. i.e. When I ask for a service discovery info request I receive an IQ stanza containing the <identity/> and <feature/> nodes which I have to use to create a Hex String for "ver" attribute..... 
14:06:17 <flo-retina> mayanktg: what's the question exactly?
14:06:24 <aleth> When do you send a service discovery request?
14:07:48 <mayanktg> I send a service discovery request when I receive a <presence/> containing <c/> . If the ver attribute is not present in cache already, I ask for service discovery request.
14:08:25 <flo-retina> so what's the question?
14:08:28 <aleth> So you receive an IQ stanza in return. How is this different to the IQ stanzas you are already receiving for Jingle?
14:08:38 <aleth> Don't you already know where to handle them?
14:09:04 <mayanktg> I'm receiving an IQ stanza but I'm unable to fetch it.
14:09:07 <mayanktg> ...
14:09:30 <aleth> fetch it?
14:10:16 <mayanktg> I have used it inside the onIQStanza() where I receive the Jingle IQ stanzas. Wait let me pastebin the diff to make it clear.
14:10:33 <aleth> onIQStanza seems the right place, yes ;)
14:11:32 <mayanktg> http://pastebin.instantbird.com/745557
14:13:35 <mayanktg> I'm unable to get the IQ result.
14:13:40 --> rosonline has joined #instantbird
14:13:48 <mayanktg> Though its displayed in the account's debug log.
14:16:05 <aleth> Proceed in stages: is onIQStanza getting called? which parts of your if clause are called?
14:16:43 <aleth> You could even use the debugger and step through what happens if that helps.
14:16:47 <mayanktg> No. onIQStanza isn't called. I did a Cu.reportError on it and it wasn't called.
14:17:16 <mayanktg> Though its getting called when I start a "video call".
14:17:41 <aleth> Then you have to look at the code around where onIQStanza is called... where new incoming messages are handled.
14:19:16 <clokep_work> sawrubh: So...about those questions? :P
14:19:22 <mayanktg> aleth: Ok.
14:19:25 * clokep_work thinks that was a few hours ago. :-\
14:21:58 <mayanktg> aleth: the onIQStanza() is called at http://mxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp-session.jsm#498 function accountListening().
14:24:07 <mayanktg> I'm taking to look and will try to solve it :)
14:30:10 --> mayanktg-ph has joined #instantbird
14:43:56 <-- mayanktg has quit (Ping timeout)
14:44:16 --> mayanktg has joined #instantbird
14:46:04 --> iamjayakumars has joined #instantbird
14:50:25 <-- mayanktg-ph has quit (Quit: )
14:50:42 <flo-retina> btw, I have a brief look at the Windows VM yesterday, but I don't have any idea of another hack I could use instead of the pymake hack we removed
14:55:30 --> Mic|web has joined #instantbird
14:55:49 <flo-retina> bah, when using google to look for ideas for that path problem, I ended up on http://trac.buildbot.net/ticket/456 (see who fixed it and who was cc'ed) ;)
14:58:23 <aleth> well, at least you know how to get in touch with them! ;)
15:00:11 --> nhnt11 has joined #instantbird
15:02:10 <flo-retina> aleth: I don't think our problem is buildbot's fault though
15:02:21 <flo-retina> aleth: actually, I'm fully sure it's not buildbot'sfault
15:02:31 <flo-retina> if I run "make distribution" in a terminal, I have the same failure
15:02:45 <-- nhnt11 has quit (Ping timeout)
15:03:07 <aleth> hmm, but make package works?
15:03:55 <flo-retina> aleth: sure
15:04:02 <flo-retina> aleth: it's make buildsymbols that fails
15:10:16 <aleth> mayanktg: have you found the problem?
15:13:53 <mayanktg> aleth: As far as I have understood onIQStanza is only called when the conversation starts and not when the account is connected. So I'll need to call onIQStanza() when the account is connected.
15:14:43 <clokep_work> Isn't onIQStanza called whenever an IQ stanza is received?
15:15:15 <aleth> Does execHandler get called and if so, what happens there?
15:15:35 <aleth> I think you're missing something.
15:16:44 <mayanktg> aleth, clokep_work: I also think so. onIQStanza() should be called whenever an IQ stanza is received.
15:18:03 <flo-retina> mayanktg: it should only be called after an account is connected
15:18:19 <flo-retina> but there's no reason for you to exchange service discovery stanza on an account that isn't connected yet
15:18:24 <flo-retina> so I don't understand what you are trying to do
15:18:53 <aleth> mayanktg: Explain to us exactly what happens to the incoming data and where it flows *at the moment*
15:19:10 <flo-retina> or pastebin a diff :)
15:20:00 <mayanktg> flo-retina: Yes. I'm pastebining a diff and explaining the flow.
15:24:55 <-- Even has quit (Input/output error)
15:26:02 <mayanktg> http://pastebin.instantbird.com/745557 When an account is connected it receives <presence/> from different buddies. If the presence stanza contains a <c/> I compare the "ver" attribute with already stored "ver" caches. Else I request for Service Discovery info (Line 33)... Now I get a service discovery IQ stanza of type result containing <identity> and <feature> elements when I check the debug log. _But_ the problem is
15:26:02 <mayanktg> that onIQStanza() is not called  (L126).
15:26:35 --> Even has joined #instantbird
15:26:35 * ChanServ sets mode +o Even 
15:27:28 <aleth> mayanktg: The IQ stanza is received *somewhere* by the XMPP prpl. Where is that and where does it go?
15:28:22 <aleth> I've already asked you about execHandler.
15:31:36 <mayanktg> Sorry idk about it. Wait let me see. execHandler is defined in xml-session.jsm and is called at accountListening().
15:32:11 <aleth> So does accountListening get called? What happens then?
15:32:35 <aleth> That's what "figure out the code flow" means.
15:40:21 <mayanktg> aleth: Yes you're right execHandler is getting called and since aHandled is present the later part of the onIqStanza() is not called.
15:40:36 <flo-retina> so what's already handling it? :)
15:42:38 <mayanktg> flo-retina: I'm looking at it. Give me a min., I think I can fix this up. :-o
15:46:40 <-- rosonline has quit (Ping timeout)
15:47:27 <mayanktg> It was the predefined ID "info1" I was using which was causing the problem. I'm able to get the result IQ Stanza now :) 
15:47:50 <mayanktg> Thanks a lot! :) :)
16:04:20 <-- gerard-majax_ has quit (Ping timeout)
16:07:16 --> nhnt11 has joined #instantbird
16:09:30 <aleth> nhnt11: How's the indexing going? ;)
16:12:31 <nhnt11> aleth: I've (mostly) addressed your comments on the log splitting bug, and been working on the indexing patch as well, but I've been a bit caught up on some other things the last couple days so it's been slow.
16:12:50 <aleth> OK
16:12:54 <aleth> As long as you're not blocked...
16:12:59 <nhnt11> I want to upload patches tonight though
16:13:02 <nhnt11> nope
16:16:59 <-- mayanktg has quit (Ping timeout)
16:21:27 --> aleth-mac has joined #instantbird
16:22:02 <-- aleth-mac has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:22:19 <-- iamjayakumars has quit (Quit: )
16:22:41 <-- aleth has quit (Quit: exit stage left)
16:24:27 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
16:25:06 --> arlolra has joined #instantbird
16:26:10 --> aleth has joined #instantbird
16:26:10 * ChanServ sets mode +o aleth 
16:26:16 <-- aleth has quit (Input/output error)
16:30:50 --> mayanktg has joined #instantbird
16:39:49 <-- mayanktg has quit (Ping timeout)
16:44:00 --> iamjayakumars has joined #instantbird
16:45:20 * nhnt11 is back (was eating)
16:45:55 <nhnt11> aleth: "I would rather actually write 1000 messages here." Why? I don't see the point, but I don't really mind either way
16:46:09 <nhnt11> I originally made it write 1k messages but it took a while so I figured it was unnecessary I/O
16:47:02 <-- arlolra has quit (Quit: arlolra)
16:48:02 --> gerard-majax_ has joined #instantbird
16:48:18 --> arlolra has joined #instantbird
16:51:04 <-- gerard-majax_ has quit (Ping timeout)
16:53:47 --> Mook_as has joined #instantbird
17:12:09 <clokep_work> sawrubh: Ping
17:13:54 --> Rym has joined #instantbird
17:18:02 --> mayanktg-ph has joined #instantbird
17:18:21 <-- jb has quit (Ping timeout)
17:19:14 --> gerard-majax_ has joined #instantbird
17:37:29 <-- gerard-majax_ has quit (Ping timeout)
17:37:44 <-- nhnt11 has quit (Ping timeout)
17:37:54 --> nhnt11 has joined #instantbird
17:42:46 <-- flo-retina has quit (Ping timeout)
17:45:36 --> mayanktg has joined #instantbird
17:53:00 <-- iamjayakumars has quit (Client exited)
17:56:03 <-- Tonnes has quit (Quit: ChatZilla [Firefox 30.0/20140605174243])
17:57:33 <-- mayanktg-ph has quit (Quit: )
18:14:50 <-- Rym has quit (Ping timeout)
18:23:51 --> Tonnes has joined #instantbird
18:40:30 --> gerard-majax_ has joined #instantbird
18:53:56 <-- mayanktg has quit (Ping timeout)
18:54:17 --> mayanktg has joined #instantbird
18:57:03 <-- chrisccoulson has quit (Ping timeout)
18:57:37 --> chrisccoulson has joined #instantbird
18:58:24 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
18:59:17 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:59:22 --> clokep_work has joined #instantbird
18:59:22 * ChanServ sets mode +o clokep_work 
19:01:55 <-- Mook_as has quit (Input/output error)
19:02:26 --> Mook_as has joined #instantbird
19:03:31 --> unghost has joined #instantbird
19:28:12 --> jb has joined #instantbird
19:52:52 <-- arlolra has quit (Quit: arlolra)
20:07:39 <-- jb has quit (Ping timeout)
20:20:48 <-- mayanktg has quit (Ping timeout)
20:21:33 --> mayanktg has joined #instantbird
20:23:20 <-- clokep_work has quit (Ping timeout)
20:24:10 <-- mayanktg has quit (Ping timeout)
20:25:15 --> mayanktg has joined #instantbird
20:33:09 --> EionRobb has joined #instantbird
20:59:50 --> flo-retina has joined #instantbird
20:59:50 * ChanServ sets mode +qo flo-retina flo-retina 
21:21:42 <-- EionRobb has quit (Connection reset by peer)
21:21:51 --> EionRobb has joined #instantbird
21:33:06 <mayanktg> I'm able to generate a ver attribute as per the given procedure, but the generated sha-1 encoded string is not similar (even pattern wise dissimilar) to what I have received. Looking at http://xmpp.org/extensions/xep-0115.html#howitworks ver attr of the example I guess some alteration has been done to the encoded string.
21:34:23 * mayanktg reads RFC 3174 (SHA1) and RFC 4648 (data encoding) to find out what's missing...
21:37:10 --> Rym has joined #instantbird
21:39:29 <-- mayanktg has quit (Ping timeout)
21:40:35 --> mayanktg has joined #instantbird
21:43:23 <mayanktg> Aah...I have to encode it to Base64 too.
21:43:45 <mayanktg> *using
21:45:15 <nhnt11> mayanktg: Just fyi, section 5.1 on the page you linked mentiones that you need to encode using Base64 ;)
21:45:29 <nhnt11> mentions*
21:45:45 <mayanktg> nhnt11: Yeah..I missed that line earlier :(
21:46:12 <mayanktg> Do you know how can I encode it using Base 64?
21:46:16 <nhnt11> I usually don't like reading RFCs :(
21:46:47 <mayanktg> np :)
21:46:52 <nhnt11> No idea if there's a module or something that makes it easy
21:46:54 <nhnt11> Search MDN?
21:47:21 <nhnt11> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Base64_encoding_and_decoding
21:47:44 <nhnt11> mayanktg: Looks like you can use ArrayBuffers
21:47:57 <mayanktg> Yes, I'm doing that. I remember sawrubh implementing it at some point.
21:48:54 <flo-retina> isn't btoa doing it?
21:49:17 <flo-retina> ah, yeah, the MDN page said that
21:49:43 <nhnt11> Oh wow, I think I'm blind
21:50:03 <flo-retina> nhnt11: so how is the indexing progressing? :)
21:50:41 <-- mconley has quit (Input/output error)
21:51:17 <nhnt11> flo-retina: I'd been a bit caught up in some other things the last two days, so a bit slow, but I'm about to work on your log set idea
21:51:55 * Fallen|away is now known as Fallen
21:52:23 * flo-retina wonders how come all the Ib GSoC students seem "caught up in some other things for the last few days" every few days this year. :(
21:54:09 <-- flo-retina has quit (Ping timeout)
21:58:44 <-- gerard-majax_ has quit (Ping timeout)
22:05:04 <-- unghost has quit (Input/output error)
22:05:55 <-- Even has quit (Input/output error)
22:05:58 --> Even has joined #instantbird
22:05:58 * ChanServ sets mode +o Even 
22:10:36 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:16:35 <-- Armada has quit (Connection reset by peer)
22:22:02 --> nhnt11-testing has joined #instantbird
22:22:08 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:26:51 --> mconley has joined #instantbird
22:28:41 <-- mconley has quit (Input/output error)
22:29:34 --> flo-retina has joined #instantbird
22:29:34 * ChanServ sets mode +qo flo-retina flo-retina 
22:30:13 <flo-retina> nhnt11: is this new log splitting patch something I should look at in the train tomorrow?
22:30:43 <nhnt11> flo-retina: Could you? It shouldn't take too long. Have you seen it once already?
22:31:04 <flo-retina> I don't think I looked at it before, no
22:31:19 <flo-retina> but I do want to look at it at least once
22:31:27 <nhnt11> flo-retina: ok. aleth has already done a review, maybe wait till he r+'s it?
22:31:50 <nhnt11> (if you've got other things to do, feel free to give them priority, I'd say)
22:32:12 <flo-retina> because 1. I'm curious to see how it works, 2. I need to know how this is works overall to be able to follow the discussions about what will happen next in your project :)
22:33:56 <nhnt11> Alright, please take a look then. :)
22:34:40 <nhnt11> It's not a huge patch, the gist is that it creates a new log file in 3 different scenarios, and adds a "noNewSession" flag to the headers of the split files.
22:35:47 * flo-retina agreed with aleth's comment that a wording without negative would be better
22:35:50 <nhnt11> flo-retina: I'm confused about what to do for the race conditions you mentioned :(
22:36:14 <flo-retina> I'm not sure why you assume I know what I mentioned a while ago :-D
22:36:30 <nhnt11> Erm :-
22:36:31 <nhnt11> (
22:37:25 <flo-retina> clokep: I would like your input on the CTCP part of my comment here: https://bugzilla.mozilla.org/show_bug.cgi?id=983347#c35
22:37:29 <instantbot> Bug 983347 nor, --, ---, arlolra, ASSI, Need different paths for displaying to the screen and sending over the wire
22:40:03 <nhnt11> flo-retina: You were worried about a race condition if two INSERTs were queued on the same connection. I just realized the answer is yet another promise queue though.
22:40:09 <nhnt11> queueDBOperation :]
22:40:23 <nhnt11> (or queueDbInsert maybe)
22:40:59 <flo-retina> wasn't that for the indexing patch?
22:41:05 <flo-retina> I thought you were talking about the log splitting :-S
22:41:09 <nhnt11> Yes. I should've mentioned that, sorry.
22:41:39 <flo-retina> ahah, assuming I knew what I had mentioned was even less a good idea then :-D
22:52:09 * Fallen is now known as Fallen|away
23:01:09 <-- BillBinkley has quit (Connection reset by peer)
23:11:32 --> clokep has joined #instantbird
23:11:32 * ChanServ sets mode +o clokep 
23:12:09 <nhnt11> Hi clokep
23:12:21 <nhnt11> I wanted to push bug 955714, that okay?
23:12:23 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955714 nor, --, ---, nhnt11, NEW, Tabbrowser conversations property assumes all tabs have linkedConversations
23:12:57 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
23:13:09 <clokep> One second, everything just crashed
23:13:22 <nhnt11> sure
23:13:39 <clokep> nhnt11: That's fine.
23:13:53 <nhnt11> clokep: Thanks. Are you going to look at checkin-needed any time soon btw?
23:14:02 <nhnt11> We likely want windows nightlies before async logs, correct?
23:14:44 <clokep> nhnt11: The tree is closed.
23:14:51 <clokep> Those touch chat/.
23:15:02 <nhnt11> Right, thought you said you could get approval
23:15:08 <nhnt11> No matter, just wanted to know what the status was
23:15:34 <clokep> There's a separate status for approval check-ins.
23:15:37 <clokep> We can ask soon though, yes.
23:15:42 <clokep> jcranmer said it should be green "soon"
23:15:48 <nhnt11> Great.
23:16:16 <instantbot> nhnt11@gmail.com changed the Resolution on bug 955714 from --- to FIXED.
23:16:17 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955714 nor, --, ---, nhnt11, RESO FIXED, Tabbrowser conversations property assumes all tabs have linkedConversations
23:16:36 <nhnt11> I keep forgetting target milestone :(
23:16:47 <clokep> One day. :-D
23:17:59 <nhnt11> clokep: One day I'll stop forgetting? (or one day till the tree opens?)
23:18:08 <clokep> One day you'll stop forgetting!
23:18:14 * nhnt11 was hopeful there for a second :P
23:21:43 <-- Rym has quit (Ping timeout)