#instantbird log on 06 30 2014

All times are UTC.

00:30:00 <-- wnayes has quit (Ping timeout)
00:31:49 --> wnayes has joined #instantbird
00:55:47 <-- EionRobb has quit (Ping timeout)
00:56:10 --> EionRobb has joined #instantbird
01:05:40 <-- Armada has quit (Connection reset by peer)
01:12:02 <-- clokep_work has quit (Ping timeout)
01:12:02 --> mconley has joined #instantbird
01:12:15 --> clokep_work has joined #instantbird
01:12:15 * ChanServ sets mode +o clokep_work 
01:40:19 <-- clokep_work has quit (Ping timeout)
02:01:46 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
02:29:34 <-- wnayes has quit (Ping timeout)
02:32:58 --> wnayes has joined #instantbird
03:15:51 <-- mconley has quit (Input/output error)
03:16:24 <-- wnayes has quit (Quit: wnayes)
04:19:28 --> nhnt11 has joined #instantbird
05:23:54 --> mconley has joined #instantbird
06:07:56 <-- EionRobb has quit (Quit: Leaving.)
06:33:23 --> Even has joined #instantbird
06:33:23 * ChanServ sets mode +o Even 
06:43:12 <-- Even has quit (Ping timeout)
06:43:51 <-- mconley has quit (Ping timeout)
06:43:57 --> Even has joined #instantbird
06:43:57 * ChanServ sets mode +o Even 
06:44:19 --> mconley has joined #instantbird
06:57:42 --> mpmc has joined #instantbird
07:03:10 <-- mconley has quit (Input/output error)
07:52:58 --> flo-retina has joined #instantbird
07:52:58 * ChanServ sets mode +qo flo-retina flo-retina 
07:53:26 <flo-retina> If anybody feels like fixing the bustages, http://hg.mozilla.org/comm-central/rev/497ee03dc80b is what needs porting to fix Mac. http://hg.mozilla.org/comm-central/rev/f8112386067e is what needs attention for the Windows bustage.
07:54:29 <sawrubh> flo-retina: that seems urgent otherwise we could marked that as good first bug :)
08:00:21 <flo-retina> good first bustage bug maybe? ;)
08:00:48 <sawrubh> let me tweet that bug
08:01:10 <sawrubh> flo-retina: so the review on bug 1014644, is it blocked on some discussion on some mailing list or something?
08:01:14 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1014644 nor, --, ---, saurabhanandiit, ASSI, Make FileLink work in Instantbird
08:02:31 <flo-retina> no
08:03:11 --> gerard-majax_ has joined #instantbird
08:04:46 <sawrubh> flo-retina: is there a bug on file about this bustage and the links you just gave about fixing it? otherwise I'll file one and tweet that
08:13:46 * Fallen|away is now known as Fallen
08:17:16 <sawrubh> gah, the same prpl-jabber error, now what have I done...
08:31:16 <flo-retina> sawrubh: we usually just check-in the fixes with rs=bustage-fix or r=<name> over IRC, and don't file bugs
08:31:32 <flo-retina> at least for the package-manifest trivial change
08:31:42 <flo-retina> for the other one, we may need some discussion (but then it's no longer a trivial bug)
08:32:49 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
08:57:19 <-- Fallen has quit (Ping timeout)
08:58:22 --> Fallen has joined #instantbird
09:14:04 --> flo-retina has joined #instantbird
09:14:05 * ChanServ sets mode +qo flo-retina flo-retina 
09:17:08 --> Mic|web has joined #instantbird
09:21:10 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:35:44 --> chrisccoulson has joined #instantbird
09:41:04 <flo-retina> sawrubh: "I'm getting that prpl-jabber error which normally comes because of some syntax error." have you found the syntax error?
09:42:49 <sawrubh> flo-retina: no, I've poured over it with my eyes (my editor doesn't support finding the syntax errors in js automatically) and can't find it
09:42:51 <sawrubh> I've checked all the commas and everything
09:43:05 * sawrubh tries some online linter
09:43:12 <flo-retina> from the application directory, run ./xpcshell components/xmpp.js
09:43:21 <flo-retina> that won't "work", but should print the error
09:43:36 <sawrubh> now that's a helpful trick
09:43:40 * sawrubh tries it
09:43:46 <flo-retina> (and obviously, fix the path if I got it wrong ;))
09:44:56 --> BWMerlin has joined #instantbird
09:48:47 <flo-retina> clokep: "I can show someone the code I used to generate it, but I won't be attaching it here since that kind of defeats the purpose." would be nice to still have it accessible in the bug for future reference. I wonder if it would 'work' to attach it and mark it as security-sensitive.
09:49:10 <flo-retina> sawrubh: did that work?
09:49:27 <sawrubh> I tried writing this first : https://etherpad.mozilla.org/ib-tips :P
09:49:30 <sawrubh> let me first check
09:49:36 <sawrubh> s/tried/started
09:52:52 <sawrubh> I tried './mozilla/mach xpcshell chat/protocols/xmpp/xmpp.js' since that's how it's said we run xpcshell (https://developer.mozilla.org/en-US/docs/Mozilla/QA/Writing_xpcshell-based_unit_tests) but it says unknown command xpcshell
09:53:10 <sawrubh> also in order to run it like ./xpcshell components/xmpp.js I would need the xpcshell executable
09:53:22 * sawrubh searches for the executable inside the objdir
09:54:06 <Mic|web> sawrubh: isn't the objdir the dir that you'd need to run it from?
09:54:15 <Mic|web> Afaik there's an xpcshell executable in there...
09:54:37 <sawrubh> yes there is on dist/bin
09:54:40 <sawrubh> *one
09:54:41 <flo-retina> sawrubh: I said in the app folder
09:54:51 <sawrubh> ah, sorry I missed it
09:54:51 * flo-retina wonders why you are making stuff up instead of following exactly the instructions :(
09:55:29 <flo-retina> "chat/protocols/xmpp" is also quite obviously not the correct path
09:55:43 <sawrubh> yes wrt to the applications directory it isn't
09:58:19 <sawrubh> so this is what I tried './obj-x86_64-unknown-linux-gnu/mozilla/dist/bin/xpcshell chat/protocols/xmpp/xmpp.js
09:58:19 <sawrubh> ./obj-x86_64-unknown-linux-gnu/mozilla/dist/bin/xpcshell: error while loading shared libraries: libxul.so: cannot open shared object file: No such file or directory'
09:58:35 <sawrubh> btw I'm on Linux so I guess the app folder means the objdir in my case
09:59:29 <sawrubh> ah, got it I need to run the xmpp.js that's inside the objdir too instead of the one in chat
10:00:20 <flo-retina> could you please stop guessing random things?
10:00:29 <flo-retina> just cd /obj-x86_64-unknown-linux-gnu/mozilla/dist/bin
10:00:31 <flo-retina> and then run what I said
10:02:59 <sawrubh> http://pastebin.instantbird.com/744505
10:03:16 <flo-retina> ok
10:03:32 <flo-retina> LD_LIBRARY_PATH=. ./xpcshell components/xmpp.js
10:04:06 <sawrubh> now it runs but nothing happens
10:04:19 <flo-retina> if nothing is printed, you don't have a syntax error
10:04:48 <sawrubh> ok
10:08:15 <flo-retina> so what was the issue in the first place?
10:08:25 <sawrubh> flo-retina: when you said http://log.bezut.info/instantbird/140627/#m523 I din't really understand what you meant by it
10:08:46 <flo-retina> what change have you tried after reading that? (pastebin the diff :))
10:08:47 <sawrubh> I mean the broken part
10:09:02 <flo-retina> I mostly meant "missing" when I said "broken"
10:09:11 <flo-retina> but it could also have been an empty one
10:12:27 <sawrubh> so on L256 of http://pastebin.instantbird.com/744508 I added that __proto__ , earlier (https://bugzilla.mozilla.org/attachment.cgi?id=8445793&action=edit) I used to do this inside an object called GenericFileTransferPrototype (Ctrl+F this on that patch) but no one used to inherit from GenericFileTransferPrototype
10:13:29 <sawrubh> so that's why in the current patch (http://pastebin.instantbird.com/744508) I removed GenericFileTransferPrototype from jsProtoHelper.jsm, added this __proto__ to XMPPFileTransfer instead
10:13:30 <flo-retina> ok
10:14:06 <sawrubh> even earlier it didn't used to work (but atleast I wasn't getting this prpl-jabber error)
10:14:08 <flo-retina> is prplIFileTransfer correctly defined?
10:14:19 <flo-retina> if you type Components.interfaces.prplIFileTransfer in the error console, what do you get?
10:14:30 * sawrubh does that
10:15:05 <sawrubh> aha
10:15:57 <sawrubh> so the error console says (even before I've done anything) : http://pastebin.instantbird.com/744509
10:16:05 <sawrubh> I hadn't noticed that
10:17:08 <flo-retina> heh, see what I meant by "broken" ClassInfo implementation? ;)
10:17:46 --> Armada has joined #instantbird
10:18:27 * sawrubh goes to include XPCOMUtils
10:18:37 <flo-retina> imXPCOMUtils
10:18:41 <sawrubh> yeah
10:19:15 <sawrubh> apparently dxr is not too helpful to tell me where ClassInfo is defined if I simply search that keywork
10:19:30 <sawrubh> I need to add other options, which I'll read about later
10:19:37 <flo-retina> http://lxr.instantbird.org/instantbird/source/chat/modules/imXPCOMUtils.jsm#13
10:19:56 <sawrubh> :)
10:20:14 <Mic|web> meh, the CSS changes for mayanktg aren't as easy as I thought :S
10:20:31 <flo-retina> sawrubh: so remember for next time: before asking why stuff doesn't work, always check the error console ;)
10:20:48 <flo-retina> Mic|web: CSS is never as easy as it seems ;)
10:20:50 --> clokep has joined #instantbird
10:21:02 <sawrubh> yeah! I should never get dettered by just seeing an error in say the Add Account Window
10:21:19 <sawrubh> error console has some useful info most of the time
10:22:10 <flo-retina> "seeing an error in say the Add Account Window" that's not supposed to happen, and worth filing a bug
10:28:43 <flo-retina> nhnt11: have you seen bug 956713?
10:28:45 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=956713 nor, --, ---, nobody, NEW, Investigate a "json + journal" API
10:31:54 <sawrubh> flo-retina: http://i.imgur.com/nIH5ltL.png is what I see, I don't know if that deserves a bug filing
10:32:23 <flo-retina> weren't we talking about the error console? :-S
10:33:07 <flo-retina> sawrubh: that error in your screenshot probably means that you are trying to use libpurple's xmpp (rather than the JS one), and haven't built libpurple
10:33:35 <sawrubh> "seeing an error in say the Add Account Window" I said the error appeared in the Add Account Window like it does in the screenshot
10:33:52 <sawrubh> I have js-xmpp instead of prpl-jabber in the about:config pref flag
10:34:07 <sawrubh> so I think I should be using js-xmpp only
10:34:21 <flo-retina> sawrubh: I guess I didn't see how that was related to my previous sentence "always check the error console" then
10:35:00 <flo-retina> errr yeah, that error is because JS-XMPP is broken due to the JS error in it
10:35:05 <flo-retina> you've fixed it now, right?
10:35:11 <sawrubh> yes
10:38:04 <clokep> sawrubh: Btw putting js-xmpp in that pref doesn't do anything, removing things tells it not to use libpurple for that protocol.
10:38:50 <clokep> flo-retina: That second patch is in Windows already? Does that mean we don't know what change needs to be fixed to build Windows symbols?
10:39:16 <flo-retina> clokep: it's pretty clear that we need to revert that patch (as pymake no longer exists)
10:39:27 <flo-retina> then we should see if buildsymbols is broken on Windows
10:39:39 <flo-retina> if not great; if it is we will need to look for another workaround
10:39:44 <sawrubh> clokep: so replacing prpl-jabber with js-xmpp in that pref is what I've done and isn't that what should be done?
10:40:00 <clokep> Ah! Yes, that's what it's doing. :-[ Sorry.
10:40:00 <flo-retina> sawrubh: re-read what clokep told you.
10:40:24 * clokep sighs.
10:40:33 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
10:40:33 <clokep> flo-retina: Maybe I'll have time to look at it today.
10:40:44 <clokep> But not now, I'm already running late.
10:41:26 <flo-retina> clokep: I think we should just revert the change (but still provide the purple folder), fix package-manifest, and start new nightlies to see what happens
10:41:32 <flo-retina> we can't guess before seeing if it fails :)
10:43:00 <clokep> Alright.
10:45:07 <nhnt11> Hello
10:55:46 <nhnt11> flo-retina: That's an interesting bug
10:55:53 <nhnt11> (http://log.bezut.info/instantbird/today/#m123)
11:02:59 --> BillBinkley has joined #instantbird
11:03:14 <nhnt11> flo-retina: That looks pretty cool, are you suggesting we should use it somewhere?
11:03:20 <flo-retina> no
11:03:29 <nhnt11> Didn't think so
11:03:40 <flo-retina> I don't know when it's supposed to be ready, what approach they are taking exactly, or if they have even settled on one yet
11:03:52 <nhnt11> Looks interesting for sure.
11:03:59 <flo-retina> I just thought you might be interested in being aware of what's going on there, and that some of their thoughts could be useful to you
11:04:09 <nhnt11> Yes, I read most of the comments
11:04:23 <flo-retina> :)
11:04:39 <flo-retina> nhnt11: so what are you planning to get done this week?
11:04:45 <flo-retina> which patches are landing? :)
11:04:52 <nhnt11> flo-retina: I
11:04:54 <sawrubh> flo-retina: so I'm back on http://pastebin.instantbird.com/744524 for the patch (http://pastebin.instantbird.com/744508) I was getting the same error when you had suggested: http://log.bezut.info/instantbird/140627/#m523 what's changed since then is that I'veremoved GenericFileTransferPrototype from jsProtoHelper.jsm, added this __proto__ to XMPPFileTransfer
11:04:54 <flo-retina> where will you need help?
11:04:54 <nhnt11> sorry
11:04:55 <sawrubh> instead
11:05:00 <nhnt11> I'm evaluating that myself right now
11:05:30 <flo-retina> I'll be pretty busy this week, but I'll have 2 round trips to Paris, so 4 reviewing hours ;)
11:05:54 <flo-retina> (bug 983347 will be my top priority during these train rides though)
11:05:56 <nhnt11> I want to get bug 1025522 ready first, then finish up the indexed logs patch.
11:05:57 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=983347 nor, --, ---, arlolra, ASSI, Need different paths for displaying to the screen and sending over the wire
11:05:59 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1025522 nor, --, ---, nhnt11, ASSI, Split log files to prevent them from growing too large
11:06:05 <nhnt11> Okay.
11:08:07 <sawrubh> flo-retina: Components.utils.reportError("aSubject: " + aSubject + ", " + JSON.stringify(aSubject)) is what prints L2 of http://pastebin.instantbird.com/744524
11:09:33 <flo-retina> sawrubh: have you checked what I asked you to check before in the error console?
11:09:34 <-- clokep has quit (Ping timeout)
11:10:57 <sawrubh> I simply type `Components.interfaces.prplIFileTransfer` in the error console and nothing happens
11:11:21 <nhnt11> sawrubh: try alert(foo) instead of foo
11:11:34 <sawrubh> I mean besides prplIFileTransfer getting printed with that green icon
11:11:46 * nhnt11 shuts up
11:12:14 <sawrubh> I get a popup saying prplIFileTransfer
11:13:05 <flo-retina> hm
11:13:25 <flo-retina> if you do aSubject.QueryInterface(Components.interfaces.prplIFileTransfer) what's the result?
11:18:27 <sawrubh> Error: Yo: [xpconnect wrapped prplIFileTransfer]  Source File: chrome://instantbird/content/conversation.xml Line: 1947
11:19:04 <sawrubh> (don't mind the error and the yo)
11:21:14 <flo-retina> no exception?
11:21:34 --> aleth_web has joined #instantbird
11:22:43 <sawrubh> flo-retina: http://pastebin.instantbird.com/744537
11:32:04 * Fallen is now known as Fallen|away
11:33:26 --> mpmc has joined #instantbird
11:33:57 <flo-retina> sounds like something is still wrong with ClassInfo :-/
11:36:42 <sawrubh> \:
11:47:34 <sawrubh> I'm not sure why I need a ClassInfo btw? Things were working fine even before I had ClassInfo and all I was doing was send these file transfer offers to the UI from onIQStanza
11:48:18 <sawrubh> these errors came when I'm trying to pass the error to the UI too, for which all I did different is add this new string attribute error to prplIFileTransfer
11:50:07 <nhnt11> aleth_web: So for bug 1025522, I'm going to add a "noNewSession" flag to the log headers, and maintain the current behavior with sessions.
11:50:10 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1025522 nor, --, ---, nhnt11, ASSI, Split log files to prevent them from growing too large
11:50:40 <nhnt11> If we want to properly define a session and implement that definition, we can do it in a separate bug, methinks,
11:51:44 <aleth_web> nhnt11: OK (but note that by implementing anything you're defining it in some way ;) )
11:52:26 <aleth_web> I agree about not doing anything in that bug outside the logging code though, that would be scope creep...
11:55:35 --> clokep_work has joined #instantbird
11:55:35 * ChanServ sets mode +o clokep_work 
11:56:56 <sawrubh> clokep_work: hey
12:00:01 <-- BWMerlin has quit (Quit: BWMerlin)
12:00:25 --> Rym has joined #instantbird
12:09:22 <clokep_work> sawrubh: Hello
12:12:19 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:12:21 --> clokep_work has joined #instantbird
12:12:21 * ChanServ sets mode +o clokep_work 
12:15:46 <sawrubh> clokep_work: I just wanted to let you know I'm still stuck on that aNotification is null'
12:15:50 <sawrubh> issue
12:16:05 <clokep_work> sawrubh: OK. I haven't really read all your pastebins this morning btw.
12:17:22 <clokep_work> sawrubh: Can you point me to where in the log I need to look to get the "newest" pastebins?
12:17:43 <sawrubh> also when you said : http://log.bezut.info/instantbird/140625/#m226 I wanted to let you know that my current function which generates the request(L262 of http://pastebin.instantbird.com/744508) also calls sendStanza and I haven't figured out how to intercept the argument to sendStanza inside that function
12:18:24 <sawrubh> https://mxr.mozilla.org/comm-central/source/chat/protocols/irc/test/test_ctcpQuote.js I think uses the feature that the function which generates the request and the function which sends it are different
12:19:37 <sawrubh> clokep_work: just see http://log.bezut.info/instantbird/today#m165 (it contains everything)
12:21:11 <clokep_work> sawrubh: OK, so what I need to know to help you debug this is WHAT is calling that function in notification.xml. :)
12:21:53 --> jb has joined #instantbird
12:22:24 <sawrubh> one second
12:22:43 <clokep_work> flo-retina: https://hg.mozilla.org/comm-central/rev/f8112386067e so just revert line 1.19/1.20 should that be a @$(MAKE) or just $(MAKE)?
12:22:46 <clokep_work> And what's the difference? :)
12:24:04 <aleth_web> sawrubh: If you're getting an error in notification.xml (in toolkit) you're almost certainly using the notification bar wrong.
12:24:20 <clokep_work> (I see I need to use "imsymbols" not "buildsymbols", but my question is really what's the deal with @$ vs. $?)
12:28:04 <sawrubh> clokep_work: http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/widgets/notification.xml#152 is getting called when I call appendNotification from my frontend code (L156 of http://pastebin.instantbird.com/744550 which is my UI patch) and http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/widgets/notification.xml#247 is the
12:28:04 <sawrubh> line where aNotification is null
12:28:45 <flo-retina> clokep_work: I think @ is just telling gmake to not print the command line before executing it
12:28:55 <sawrubh> aleth_web: I call appendNotification similarly on L136 of http://pastebin.instantbird.com/744550 and that works fine
12:29:15 <flo-retina> and I assume there's typically a @ when calling make recursively, because gmake will print an "entering <folder>" line anyway
12:29:39 <flo-retina> clokep_work: you can get rid of the imsymbols rule, and just inline it
12:30:48 <clokep_work> flo-retina: http://pastebin.instantbird.com/744551
12:31:07 <clokep_work> sawrubh: OK, so... I've probably asked you to do this already, but did you cehck that all the inputs at L156 are not-null?
12:31:12 <aleth_web> sawrubh: You might call it similarly, but clearly in this case some of the parameters you are passing are wrong.
12:31:25 <aleth_web> Find out which one isn't what you think it is.
12:31:35 <flo-retina> clokep_work: r=me over IRC ;)
12:31:56 <flo-retina> I would be surprised if this didn't fail... but it's worth trying :)
12:32:20 <flo-retina> clokep_work: are you also taking care of the other bustage while you are at it? :)
12:33:19 <clokep_work> flo-retina: I'm about to push both.
12:33:26 <flo-retina> cool, thanks! :)
12:33:41 <aleth_web> clokep_work, bustage buster! :)
12:33:48 <clokep_work> https://hg.mozilla.org/comm-central/rev/f428a25c56c9 and https://hg.mozilla.org/comm-central/rev/2d0bf51fc537
12:33:59 <clokep_work> aleth_web: Your patch works btw, I didn't have to put CLOSED TREE
12:34:02 <clokep_work> So thanks. :)
12:34:16 <flo-retina> aleth_web++ and clokep_work++ then! :)
12:37:10 <clokep_work> flo-retina: Want me to restart nightlies too?
12:37:16 <flo-retina> sure :)
12:43:28 --> rosonline has joined #instantbird
12:43:43 <clokep_work> flo-retina: Done.
12:43:52 <flo-retina> thx
12:48:37 --> jb1 has joined #instantbird
12:48:37 --> qheaden has joined #instantbird
12:49:08 <-- jb1 has quit (Input/output error)
12:49:47 --> jb1 has joined #instantbird
12:49:52 <-- jb has quit (Ping timeout)
12:55:02 <sawrubh> clokep_work: aleth_web it works now
12:55:31 <nhnt11> aleth_web: What do you think we should do for the case of corrupt/invalid log files?
12:55:40 <nhnt11> I think we can keep the "error" session message there
12:55:58 <flo-retina> sawrubh: what fixed it? :)
12:56:47 <clokep_work> aleth_web: You were able to reproduce that XMPP bug?
12:57:05 <sawrubh> flo-retina: clokep_work aleth_web http://pastebin.instantbird.com/744566 :)
12:57:31 <sawrubh> basically changed the callback function of the close button
12:58:38 <clokep_work> sawrubh: So your "earlier" one might work if you didn't put () at the end of the callback line.
12:58:38 <flo-retina> wow, that line 6 looked so wrong :-/
12:58:47 <sawrubh> yes
12:58:50 <flo-retina> exactly what I was about to say
12:59:03 <flo-retina> although that may need a .bind
12:59:12 <aleth_web> clokep_work: yes
12:59:31 <clokep_work> sawrubh: But awesome! :) I hate getting stuck on stupid things like that. :(
12:59:53 * sawrubh feels stupid and happy at the same time
13:00:17 <aleth_web> sawrubh: it's all debugging experience ;)
13:00:22 <sawrubh> flo-retina: it works without the bind
13:00:39 <sawrubh> I don't think it should require a bind
13:01:13 <flo-retina> sawrubh: the code is http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/notification.xml#195
13:02:20 * aleth_web wonders why that callback needs to involve the tabbrowser
13:02:54 <aleth_web> seems wrong to me
13:02:56 <flo-retina> sawrubh: how is |this._showNotification(this.currentNotification, false, aSkipAnimation);| getting the correct |this| value?
13:02:58 <-- Rym has quit (Ping timeout)
13:03:13 <sawrubh> which is exactly what's intriguing me
13:03:36 <sawrubh> does js pass the current context by default or something like a hidden param ;)
13:04:11 <aleth_web> nhnt11: Yes, that seems reasonable.
13:05:58 * nhnt11 is going to fix the behavior of these message formatting things (||, **, //) one day
13:06:02 <nhnt11> if someone doesn't do it first...
13:06:16 <flo-retina> sawrubh: nope
13:06:28 <flo-retina> sawrubh: but if something is a event handler, "this" points to the node receiving the event
13:06:40 <flo-retina> but I don't see that in your code
13:07:10 <aleth_web> why not add some dump()s and actually find out what is going on? ;)
13:07:26 * aleth_web suspects too much staring at code is going on here
13:07:35 <aleth_web> Or use the debugger or whatever
13:07:42 * sawrubh adds the dumps
13:07:51 --> Rym has joined #instantbird
13:07:51 <sawrubh> let's find out what sorcery is going on here :P
13:08:40 <aleth_web> nhnt11: that would be 1) nice 2) probably involve a lot of bikeshedding edge cases ;)
13:08:52 <flo-retina> sawrubh: could it be that your code is never called, and closing the notification is the default action? :-P
13:08:57 <nhnt11> aleth_web: 3) need tests
13:08:59 <nhnt11> :P
13:09:23 <aleth_web> nhnt11: hey, if it gets that far, it's fine.... ;)
13:09:30 <flo-retina> aleth_web: 4) fun with BenB :)
13:09:42 <aleth_web> flo-retina: indeed ;D
13:10:05 <aleth_web> That's kind of an extra large portion of 2) ;)
13:11:43 <nhnt11> As usual, I feel like it can't be as complicated as you guys make it sound :-/
13:11:57 <nhnt11> And as usual, I haven't looked at the code yet, so my opinion is invalid
13:12:39 <aleth_web> We should also fix the smiley recognition code
13:12:45 <aleth_web> That could be a nice warmup.
13:13:12 <aleth_web> At least that only touches IM...
13:14:07 --> Armada651 has joined #instantbird
13:14:11 <clokep_work> aleth_web: Btw I can take that XMPP review if you want, I think flo-retina has enough already.
13:14:24 <aleth_web> Great, thanks.
13:14:25 <-- Armada has quit (Connection reset by peer)
13:14:28 <flo-retina> which one is that?
13:14:41 <aleth_web> It's only changed comments though.
13:15:08 <flo-retina> aleth_web: oh, please, don't involve the smiley code in that conversation :-D
13:16:26 <flo-retina> aleth_web: the other thing that would be nice to cleanup is HTML/XML escaping without using the piece of code also used for formatting/link detection
13:17:34 <aleth_web> hmm yes
13:18:04 <-- jb1 has quit (Ping timeout)
13:20:39 --> jb has joined #instantbird
13:23:08 <sawrubh> hrm, now it doesn't work. I'm pretty sure I saw it working once
13:26:09 --> mconley has joined #instantbird
13:28:07 <sawrubh> even doing |callback: box.removeCurrentNotification.bind(this)| doesn't work btw
13:32:24 <flo-retina> sawrubh: if you use bind, you would do .bind(box), not .bind(this)
13:32:57 <sawrubh> because yep that's the context here
13:39:27 <-- mconley has quit (Input/output error)
13:50:47 <-- gerard-majax_ has quit (Ping timeout)
13:52:21 <-- jb has quit (Ping timeout)
13:55:03 --> jb has joined #instantbird
13:55:24 * Fallen|away is now known as Fallen
13:59:41 <aleth_web> sawrubh: http://bonsaiden.github.io/JavaScript-Garden/#function.this
13:59:55 <sawrubh> flo-retina: I'm using what originally worked, because even doing |box.removeCurrentNotification.bind(box)| I get this.close(http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/notification.xml#441) is not defined
14:00:09 <sawrubh> aleth_web: ta I'll take a look
14:00:29 <sawrubh> aleth_web: I had found http://www.quirksmode.org/js/this.html
14:13:26 <aleth_web> clokep_work: looks like that fixed the build, at least on mac
14:13:38 <flo-retina> sawrubh: ahah, that code just closes the notification by default
14:15:04 --> iamjayakumars has joined #instantbird
14:15:44 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:17:05 <clokep_work> aleth_web: Woot!
14:17:12 <aleth_web> :)
14:17:17 <clokep_work> Who wants to be fist to see if it runs? :P
14:17:26 <flo-retina> I can :-P
14:17:33 <flo-retina> but I wasn't concerned about Mac
14:17:53 <flo-retina> the uncertainty is about building the symbols on Windows
14:18:47 --> nhnt11-testing has joined #instantbird
14:19:03 * nhnt11-testing is going to lurk here for a while and see if log files are behaving correctly
14:20:16 <flo-retina> cool :)
14:20:27 <sawrubh> nhnt11: you should probably join #firefox or #developers for that
14:20:33 <nhnt11-testing> sawrubh: Actually no
14:20:38 <nhnt11-testing> Or maybe
14:20:41 <flo-retina> not if he wants 20 minute breaks
14:20:46 <nhnt11-testing> sawrubh: I want a channel that is active but not too much
14:20:47 <sawrubh> :P
14:20:47 <aleth_web> Join a whole lot of different channels ;)
14:20:50 <nhnt11-testing> Yeah, what flo-retina said
14:21:04 * sawrubh shuts up for the next 1 hour ;)
14:21:06 <aleth_web> Including a completely empty one maybe...
14:21:07 --> qheaden has joined #instantbird
14:21:09 <nhnt11-testing> #perf maybe.
14:21:12 <nhnt11-testing> aleth_web: I'm already in one :)
14:21:15 <aleth_web> :)
14:21:38 <aleth_web> #ubuntu is a good one for the 1000 message thingy
14:21:52 <nhnt11-testing> Ah, yeah. Not too concerned about that though
14:21:58 <nhnt11-testing> (the test I wrote takes care of it I think)
14:22:05 <aleth_web> Looks like it.
14:22:07 <nhnt11-testing> I'm looking for correct handling of session messages
14:23:49 --> mconley has joined #instantbird
14:24:40 <-- rosonline has quit (Ping timeout)
14:24:58 <clokep_work> flo-retina: It failed.
14:25:59 <flo-retina> :'(
14:26:13 <flo-retina> and here goes my evening I guess :(
14:28:37 <sawrubh> a meeting free evening ;)\
14:28:49 <flo-retina> sawrubh: wanna fix windows for us? :-P
14:29:41 <sawrubh> do I need to have access to Windows?
14:29:54 <flo-retina> yes
14:30:12 <sawrubh> I don't unfortunately :/
14:33:11 <nhnt11> aleth_web: Do you think we need to test for the noNewSession flag in the log splitting test?
14:33:29 <nhnt11> Hmm, "why not" I guess.
14:33:58 <aleth_web> Or add a split log to the clustered logs test.
14:34:14 <nhnt11> Yeah.
14:37:20 * Fallen is now known as Fallen|away
14:40:38 --> gerard-majax_ has joined #instantbird
14:54:10 <sawrubh> how do I initialize the logger as said here: http://log.bezut.info/instantbird/140625/#m219
14:54:50 <-- gerard-majax_ has quit (Ping timeout)
14:54:55 <-- iamjayakumars has quit (Client exited)
14:55:05 <sawrubh> I don't see the code doing this in xmpp.js
14:55:28 <flo-retina> sawrubh: it's done at http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#32
14:57:22 <sawrubh> flo-retina: what does aModule do in http://dxr.mozilla.org/comm-central/source/chat/modules/imXPCOMUtils.jsm#91
14:57:41 <sawrubh> flo-retina: this should do it, thanks
14:57:44 <flo-retina> it annoys Mook
14:58:13 <flo-retina> sawrubh: it's the object holding the logger
14:58:51 <flo-retina> sawrubh: for code within a JS-prpl, you most likely want to re-use an existing logger attached to an account
15:00:38 <sawrubh> ah, so something like this._conv.account.LOG should do it probably given http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#32 has with it a log
15:00:52 <sawrubh> I mean an initialized log
15:01:08 <flo-retina> right
15:01:23 <sawrubh> coolio
15:03:39 <nhnt11> Ah, bugs
15:07:52 <-- Rym has quit (Ping timeout)
15:08:13 --> Rym has joined #instantbird
15:09:25 --> gerard-majax_ has joined #instantbird
15:16:26 <-- gerard-majax_ has quit (Ping timeout)
15:16:33 <nhnt11> Looks like it works :)
15:16:43 --> iamjayakumars has joined #instantbird
15:20:49 <nhnt11> brb
15:23:04 <clokep_work> sawrubh: Does that mean you're adding logging to all your code? :P
15:23:59 <sawrubh> instead of throwing it to the error console, where it makes sense to log it, yes (like when the file transfer is complete)
15:24:40 <sawrubh> eventually we would want to move these LOG'ed things to the UI (probably notification bar) or downloads panel
15:24:44 <aleth_web> Debug logging is meant to make it easy to debug problems when they occur...
15:26:35 <sawrubh> aleth_web: but the event of file transfer completing isn't a problem, it's just an alert so that's why throwing to the error console didn't make much sense to me
15:27:21 <aleth_web> It's a good idea to add to the debug logging as you write a feature as that helps you debug it while you are finishing the patch, /and/ later on.
15:28:05 * sawrubh has a feeling his understanding of debug logging isn't matching with that of aleth_web
15:28:12 <aleth_web> For the whole "informing the UI a transfer has completed" business, I hope you have looked at the download panel objects by now.
15:28:23 <aleth_web> You might be reinventing the wheel.
15:28:33 * aleth_web shouldn't have to keep saying this.
15:28:52 <aleth_web> sawrubh: A debug log is what you get when you right-click on the account in the account manager.
15:29:20 <clokep_work> aleth_web: Honestly I find that unrelated and possibly a distraction at the moment.
15:29:34 <-- Rym has quit (Ping timeout)
15:29:34 <sawrubh> ok, so that happens automatically when stanzas are exchanged, what do I need to do about debug logging?
15:29:55 <aleth_web> Maybe there's enough debug logging enough already as the stanzas will be logged, maybe you want more human-readable commentary
15:30:05 <aleth_web> I can't tell you.
15:30:10 <sawrubh> clokep_work: do we want that ^ ?
15:30:21 --> Rym has joined #instantbird
15:30:40 <aleth_web> clokep_work: I basically agree up to the point where  there's talk of adding notification bars for completed transfers and stuff like that.
15:30:58 <sawrubh> aleth_web: this human readable version, where is it visible? I mean where can the user see this
15:31:07 <aleth_web> The debug log should be human readable ;)
15:31:29 <aleth_web> Devs are humans too.
15:31:54 <clokep_work> aleth_web: I don't think we're at that point yet.
15:31:54 <aleth_web> clokep_work: Honestly I don't think the initial patch needs a lot of UI.
15:32:02 <clokep_work> It shouldn't have much.
15:32:17 <sawrubh> it's just accept/deny and showing the errors
15:32:25 <sawrubh> all using notification bars
15:32:29 <aleth_web> OK then
15:33:17 --> unghost has joined #instantbird
15:34:34 <-- jb has quit (Ping timeout)
15:34:57 <clokep_work> Yeah, it shouldn't be showing progress or anythign like that. When it's complete it should probably show a system message, but that's a single line of code.
15:35:06 <aleth_web> Right.
15:35:20 <aleth_web> So we're all on the same page :)
15:35:50 * sawrubh adds that single line of code
15:36:07 <sawrubh> on the same page is where we wanna be :)
15:36:55 --> rosonline has joined #instantbird
15:48:32 <-- rosonline has quit (Client exited)
15:54:50 <-- nhnt11-testing has quit (No route to host)
15:54:50 <-- nhnt11 has quit (No route to host)
15:56:45 --> nhnt11 has joined #instantbird
15:56:57 --> nhnt11-testing has joined #instantbird
16:14:43 <-- douglaswth has quit (Ping timeout)
16:16:04 --> douglaswth has joined #instantbird
16:19:52 <-- douglaswth has quit (Ping timeout)
16:21:13 --> douglaswth has joined #instantbird
16:22:54 <-- douglaswth has quit (Ping timeout)
16:23:41 --> douglaswth has joined #instantbird
16:28:19 <-- douglaswth has quit (Ping timeout)
16:30:13 --> douglaswth has joined #instantbird
16:32:10 <-- douglaswth has quit (Ping timeout)
16:35:33 <-- qheaden has quit (Ping timeout)
16:36:31 --> qheaden has joined #instantbird
16:42:04 --> douglaswth has joined #instantbird
16:45:34 <-- douglaswth has quit (Ping timeout)
16:46:26 --> douglaswth has joined #instantbird
16:50:49 <-- douglaswth has quit (Ping timeout)
16:50:58 --> douglaswth has joined #instantbird
16:55:16 --> Mook_as has joined #instantbird
16:57:20 <-- swills has left #instantbird ()
17:00:29 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:08:45 <clokep_work> sawrubh: You able to get that stuff working yet?
17:10:46 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:32:32 --> unghost_ has joined #instantbird
17:32:38 <-- unghost_ has quit (Input/output error)
17:45:46 --> flo-retina has joined #instantbird
17:45:46 * ChanServ sets mode +qo flo-retina flo-retina 
17:46:18 <-- iamjayakumars has quit (Client exited)
18:08:48 <sawrubh> clokep_work: I've sent a review your way, everything works
18:09:02 <sawrubh> err...feedback
18:21:06 <nhnt11> aleth_web: So creating new log files screws up my test quite a bit :(
18:21:29 <aleth_web> That's annoying... why?
18:21:30 <nhnt11> I'll have to yield on the _initialized promise and the queueFileOperation promise after every logMessage call
18:21:39 <nhnt11> Because I can't know when a new file is started
18:21:50 <nhnt11> (well I guess I can)
18:21:57 <aleth_web> Ah, because the logger code now uses date.now?
18:22:20 <nhnt11> But then if we change the way we split files the logging test will need to be rewritten as well instead of just the splitting test
18:22:22 <nhnt11> uh, no.
18:22:30 <nhnt11> It doesn't use Date.now() (anymore at least)
18:22:38 <aleth_web> ok
18:22:57 <aleth_web> So if it's all based on the message timestamps, what's the problem?
18:23:10 <nhnt11> the problem is that if I make test_logging log a message that creates a new file, I need to yield on the initialation of that file as well as the I/O promise for that file, in additino to the first one
18:23:14 <nhnt11> (excuse my typos)
18:23:23 <nhnt11> It makes for ugly code is all
18:23:45 <aleth_web> Doesn't that only happen when you know in your code you're testing for splitting a file?
18:24:06 <nhnt11> Well yeah, I could hard code it I guess
18:24:18 <nhnt11> Bah, it took ages to discover hwat was happening here
18:24:39 <aleth_web> I'm thinking more along the lines of "it's good if it fails if it splits when you don't expect it"
18:24:41 <nhnt11> I'm now leaning on ensuring the logging test doesn't have split files, and just including the test for noNewSession in the splitting test
18:24:45 <aleth_web> But I'll leave it to you
18:24:55 <aleth_web> Yeah, it might be easier to keep the test separate
18:25:09 <aleth_web> That's really about readability...
18:25:54 <nhnt11> Not necessarily
18:26:07 <nhnt11> The logging test could yield false positives in the future
18:26:15 <nhnt11> (yield in the english sense)
18:26:25 <aleth_web> Yes
18:27:16 <aleth_web> I was just agreeing with keeping the split files test separare if the alternative is uglifying the existing tests
18:27:37 <nhnt11> right
18:28:15 <nhnt11> Don't think I can avoid uglifying though
18:28:20 <aleth_web> Especially as yielding all over the place also makes the test less robust.
18:28:51 <aleth_web> There's a risk it ends up syncifying things.
18:29:20 <nhnt11> The problem is that we kind of want synchronous behavior in the test
18:29:39 <nhnt11> One solution is to provide some way to know when a log writer has finished /all/ of its pending mesages
18:29:43 <nhnt11> finished writing*
18:29:45 <aleth_web> Only in the sense that you don't want to read before everything's been written
18:29:48 <nhnt11> yeah
18:30:03 <nhnt11> hmm..
18:45:08 --> Mic|web has joined #instantbird
18:55:30 <-- Rym has quit (Ping timeout)
19:00:08 --> Rym has joined #instantbird
19:14:59 <clokep_work> sawrubh: OK, sorry I disappeared.
19:15:07 <clokep_work> Had a meeting. :-D
19:15:12 <sawrubh> np
19:17:01 <clokep_work> aleth_web: That's gross. :-\
19:26:41 <nhnt11> clokep_work: What's gross? :S
19:29:45 <clokep_work> nhnt11: The patch he just f?ed me on.
19:29:54 <nhnt11> ok nvm then
19:37:00 <clokep_work> nhnt11: Why?
19:37:04 <clokep_work> nhnt11: bug 788137
19:37:09 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=788137 nor, --, ---, aleth, NEW, Nick for XMPP chatrooms becomes 'null'
19:37:24 <nhnt11> clokep_work: I thought you were referring to something in the conversation on #instantbird while you were away
19:37:59 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
19:38:29 <clokep_work> The world exists outside of IRC! ;)
19:38:44 <nhnt11> I didn't have context ;)
19:40:08 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:46:26 <flo-retina> clokep_work: fwiw, if you are not confident r+'ing that hack, I'm totally willing to do it
19:46:45 <flo-retina> clokep_work: there's just no excuse for having kept this broken for so long, and we should 'fix' the issue and if possible uplift to TB31.
19:47:12 <clokep_work> flo-retina: Oh, I meant to ask if this was an issue with both JS-XMPP or just libpurple or not.
19:47:25 <flo-retina> clokep_work: what you are describing is the "nice way to handle auto-join" which we have thought about a few times, and never decided to actually implement, because we really want session restore and get rid of the auto-join feature
19:48:05 <clokep_work> flo-retina: Sure, I know that. :) I think it's worth thinking if this is worth the development time (e.g. will it take an hour? 7? 49?)
19:48:29 <flo-retina> clokep_work: if I understood aleth's comment and the patch correctly, the issue is that purple-xmpp names that field "nick" and JS-XMPP names that field "handle".
19:48:54 <flo-retina> is fixing the auto-join feature worth the development time?
19:49:08 <flo-retina> IMHO implementing a correct UI for that feature would take more time than implementing the equivalent part of session restore.
19:49:39 <flo-retina> you would need to replace the textbox with the list of channels by a listbox, and provide a way to delete a room from that list, or a way to add a room
19:49:59 <flo-retina> possibly also a way to show what the values of the various fields are
19:50:10 <flo-retina> you would need migration code to keep backward compatibility with existing profiles
19:52:36 <clokep_work> Yes.
19:53:04 * clokep_work feels like flo-retina is trying to convince him of something but is sure they agree.
19:53:39 <-- mconley has quit (Input/output error)
19:54:32 <flo-retina> clokep_work: yeah, I'm saying that if you want to fix auto-join (or mentor someone through fixing it), that should be a separate bug, and fixing the hack is fine for now
19:55:18 <flo-retina> bah, talking about hacks reminds me that Windows is broken :(
20:01:17 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
20:04:07 <clokep_work> flo-retina: Sounds like you should r+ it then. ;)
20:08:36 --> jb has joined #instantbird
20:14:28 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:16:35 <-- jb has quit (Ping timeout)
20:17:06 --> gerard-majax_ has joined #instantbird
20:29:04 --> chrisccoulson has joined #instantbird
20:37:14 --> EionRobb has joined #instantbird
20:42:24 --> mconley has joined #instantbird
21:04:07 <-- mconley has quit (Ping timeout)
21:04:56 --> mconley has joined #instantbird
21:08:36 <-- mconley has quit (Ping timeout)
21:47:16 <-- unghost has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
21:58:38 <-- clokep_work has quit (Ping timeout)
22:06:39 <-- gerard-majax_ has quit (Ping timeout)
22:15:50 --> mconley has joined #instantbird
22:19:16 --> nhnt11-testing has joined #instantbird
22:19:41 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:29:12 --> nhnt11-testing has joined #instantbird
22:29:15 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:30:35 --> nhnt11-testing has joined #instantbird
22:30:47 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:33:49 --> nhnt11-testing has joined #instantbird
22:34:04 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:48:30 * mconley is now known as mconley|food
22:49:03 <-- mconley|food has quit (Input/output error)
22:58:02 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:58:09 --> nhnt11 has joined #instantbird
23:21:45 * Fallen|away is now known as Fallen