#instantbird log on 06 27 2014

All times are UTC.

00:05:34 <-- Rym has quit (Ping timeout)
00:07:11 --> Rym has joined #instantbird
00:17:47 <-- Rym has quit (Ping timeout)
00:18:03 --> Rym has joined #instantbird
00:23:25 --> mconley has joined #instantbird
01:18:43 <-- Mook_as has quit (Quit: Mook_as)
01:34:28 --> nhnt11-testing has joined #instantbird
01:34:41 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
01:56:37 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
02:02:15 --> mpmc has joined #instantbird
03:18:11 --> Mook has joined #instantbird
04:19:37 <-- Rym has quit (Ping timeout)
04:29:33 <-- mconley has quit (Input/output error)
04:30:54 <-- gerv has quit (Ping timeout)
04:40:40 --> gerv has joined #instantbird
05:15:19 <-- EionRobb has quit (Quit: Leaving.)
05:23:24 <-- Mook has quit (Quit: Mook)
05:58:59 <-- Gizmokid2005 has quit (Ping timeout)
05:59:25 --> Gizmokid2005 has joined #instantbird
06:06:26 --> jb has joined #instantbird
06:08:07 <-- jb has quit (Ping timeout)
06:12:52 * Fallen|away is now known as Fallen
06:13:39 --> gerard-majax__ has joined #instantbird
06:22:06 * Fallen is now known as Fallen|away
06:23:57 --> gerard-majax_ has joined #instantbird
06:24:53 <-- gerard-majax__ has quit (Ping timeout)
06:26:03 <-- gerard-majax_ has quit (Ping timeout)
06:47:35 --> jb has joined #instantbird
07:14:40 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
07:48:01 --> gerard-majax_ has joined #instantbird
08:04:01 --> Mic|web has joined #instantbird
08:26:15 --> Armada has joined #instantbird
08:29:24 * Fallen|away is now known as Fallen
08:44:33 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
08:44:39 --> nhnt11 has joined #instantbird
08:44:51 <nhnt11> Hi
08:45:52 --> Armada651 has joined #instantbird
08:46:03 <-- Armada has quit (Ping timeout)
08:48:43 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
08:48:55 --> chrisccoulson has joined #instantbird
09:06:49 <-- jb has quit (Ping timeout)
09:14:57 --> aleth_web has joined #instantbird
09:48:06 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
09:58:13 --> flo-retina has joined #instantbird
09:58:13 * ChanServ sets mode +qo flo-retina flo-retina 
10:05:48 --> clokep_work has joined #instantbird
10:05:48 * ChanServ sets mode +o clokep_work 
10:06:59 <-- Armada651 has quit (Quit: Leaving)
10:07:04 --> Armada has joined #instantbird
10:20:20 <-- clokep_work has quit (Ping timeout)
10:21:15 --> nhnt11-testing has joined #instantbird
10:21:33 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:24:12 --> nhnt11-testing has joined #instantbird
10:24:23 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:34:27 --> nhnt11-testing has joined #instantbird
10:34:53 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:35:27 --> nhnt11-testing has joined #instantbird
10:36:07 --> mayanktg has joined #instantbird
10:39:01 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:40:02 --> nhnt11-testing has joined #instantbird
10:41:15 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:45:10 --> nhnt11-testing has joined #instantbird
10:45:30 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:48:02 --> nhnt11-testing has joined #instantbird
10:48:31 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:49:22 --> nhnt11-testing has joined #instantbird
10:50:37 <-- nhnt11-testing has quit (Client exited)
10:51:35 --> nhnt11-testing has joined #instantbird
10:51:48 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:52:33 --> nhnt11-testing has joined #instantbird
10:53:12 <nhnt11> flo-retina: I've fixed your awesomebug, want to steal the review? :)
10:53:23 <flo-retina> maybe (if it's trivial)
10:53:46 <-- nhnt11-testing has quit (Client exited)
10:54:31 <nhnt11> It's not too complicated
10:54:39 <nhnt11> I'll upload it in a minute
10:54:46 --> nhnt11-testing has joined #instantbird
10:54:50 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:56:26 <-- mayanktg has quit (Ping timeout)
10:56:53 --> mayanktg has joined #instantbird
10:57:44 <nhnt11> flo-retina: https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1029501&attachment=8447103
10:57:47 <nhnt11> Pretty trivial I think :)
10:57:53 <aleth_web> nhnt11: The log indexing WIP looks good :)
10:57:58 <nhnt11> (the end result anyways)
10:57:58 <nhnt11> aleth_web: :)
10:58:25 <nhnt11> aleth_web: I wrote a test for the log file splitting ;)
10:58:42 <nhnt11> I think I now automatically think "this needs a test" when I write a new feature
10:59:21 <aleth_web> Great :) It's also somehow a lot easier to think that once a file already has some tests for it ;)
11:00:18 <nhnt11> Another thing about writing a test is that I can safely get an idea of whether it works without risking screwing up my profile.
11:00:25 <aleth_web> (probably because most of the work is setting up the fake accounts/convs and stuff)
11:03:22 <flo-retina> nhnt11: how is it "stealing" a review if the flag was set on me? ;)
11:03:29 <flo-retina> nhnt11: anyway, looks good, thanks! :)
11:03:40 <flo-retina> hmm, wait
11:04:51 <flo-retina> nhnt11: could _lastSelectedTab from http://lxr.instantbird.org/instantbird/source/instantbird/content/macgestures.js be used or replaced?
11:06:49 --> nhnt11-phone has joined #instantbird
11:07:07 <nhnt11-phone> flo-retina: Ah yeah, didnt think of that...
11:07:18 <flo-retina> I think your new implementation is cleaner
11:07:22 <nhnt11-phone> I'd probably replace it.
11:07:26 <nhnt11-phone> Yeah
11:07:39 <nhnt11-phone> (I'll be back in a few minutes btw)
11:09:54 <-- nhnt11-phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
11:12:25 <mayanktg> aleth_web: Hello. What should be done next for the Video call patch? Should I try to implement Entity capability (Bug 1025150) or add other features for which I added followup bugs (for eg. inability to send video call if no message is exchanged, audio call...)?
11:12:27 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1025150 nor, --, ---, nobody, NEW, Implement Entity Capabilities in XMPP (XEP-0115)
11:13:23 <aleth_web> If your first patch is now finished and going through its review cycles, I think entity capabilities is the best next step.
11:14:39 <mayanktg> Ok. I've uploaded the patch and until its reviewed I should move ahead with it then. :) 
11:15:59 <aleth_web> ok :)
11:17:03 <aleth_web> mayanktg: Also request f? from flo on your XMPP patch.
11:24:36 --> clokep_work has joined #instantbird
11:24:36 * ChanServ sets mode +o clokep_work 
11:25:52 <nhnt11> mayanktg: ping
11:26:02 <nhnt11> What are the UI changes in the latest patch?
11:26:07 <nhnt11> I see you've requested f? from me again
11:28:10 <mayanktg> nhnt11: No. It was an earlier patch. I didn't marked it obsolete. Sorry. I'm removing it. 
11:28:28 <nhnt11> ok
11:37:25 <nhnt11> flo-retina: I'm a bit uncomfortable about accessing mPreviousTab from the gestures code
11:37:39 <nhnt11> Is that ok or should I create a getter for it?
11:37:56 <nhnt11> (or just rename it or something)
11:49:44 <flo-retina> maybe rename it, or something
11:49:51 <flo-retina> how is that named on Firefox's tabbrowser?
11:50:14 <flo-retina> that gesture code is hackish enough already that I wouldn't r- using mPreviousTab though :)
11:54:41 <sawrubh> aleth_web: ping
11:55:48 <aleth_web> sawrubh: hi
11:57:36 <sawrubh> aleth_web: so I'm stuck with this thing, I call this method called sendErrorMessage(http://pastebin.instantbird.com/742790)  which defined (http://pastebin.instantbird.com/742789) and it then passes it to conversation.xml (L40 of http://pastebin.instantbird.com/742804) but I'm getting the error : http://pastebin.instantbird.com/742793
11:58:15 <clokep_work> sawrubh: That seems like the same thing you were stuck on yesterday, I had given you some feedback / asked you a few questions; did you look into any of that?
11:58:33 <sawrubh> aleth_web: I'm simply using enumerators to pass strings to UI like has been done in https://mxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm#113 and http://mxr.mozilla.org/comm-central/source/im/content/conversation.xml#1857
11:58:46 <sawrubh> clokep_work: yes, I'm using enumerators now and not using any interfaces
11:58:54 <clokep_work> Thats' not an enumerator.
11:58:59 <clokep_work> Well, not the way I meant it.
11:59:04 <sawrubh> I'm using nsSimpleEnumerator
11:59:25 <clokep_work> sawrubh: I meant https://mxr.mozilla.org/comm-central/source/chat/components/public/imIAccount.idl#151
12:00:12 <sawrubh> but still this error shouldn't be coming because chat-remove-buddy does it similarly
12:02:27 <sawrubh> clokep_work: also if I use enumerators like in that code you linked, there won't be much different efficiency or cleanliness wise
12:02:34 --> BWMerlin has joined #instantbird
12:03:04 <sawrubh> it still would send these short's and that would have to case switched to get the string for the property file
12:03:35 <sawrubh> something similar to which I'm doing, I'm just not using these macro-like strings/enumerators
12:05:23 <clokep_work> sawrubh: It has nothing to do with efficiency, it has to do with providing a similar experience across multiple protocols.
12:20:03 --> nhnt11-testing has joined #instantbird
12:20:13 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:24:52 <-- mayanktg has quit (Ping timeout)
12:27:55 --> jb has joined #instantbird
12:30:05 <sawrubh> ok, so now interface: http://pastebin.instantbird.com/742833, calling code: http://pastebin.instantbird.com/742834, called code: http://pastebin.instantbird.com/742835, same error
12:30:53 <sawrubh> clokep_work: ^ is this how you meant to use it?
12:31:41 <clokep_work> No.
12:31:58 <clokep_work> The UI should be handling the strings.
12:32:31 <sawrubh> ok
12:32:55 <sawrubh> give me 5 minutes to do this
12:32:57 <clokep_work> sawrubh: You won't have to mess with nsISupportsStrings, etc.
12:33:35 <sawrubh> one issue with this htough
12:33:56 <sawrubh> so suppose the string in the UI needs an argument also to create the string
12:34:39 <clokep_work> What sort of argument?
12:35:34 --> mayanktg has joined #instantbird
12:36:26 <sawrubh> like `"something failed from" + from` and another string which is just normal string "this is an error message without appending a string to it", in order to handle this, I'll have to pass that `from` to formatStringFromName
12:36:59 <sawrubh> I mean sometimes, I use formatStringFromName, otherwise GetStringFromName depending on whether the function which wants to show the error
12:37:22 <sawrubh> wants to create a dynamic string
12:37:57 <sawrubh> am I making sense? or should I explain more clearly?
12:38:05 <nhnt11> clokep_work: You're on tab 3. You switch to tab 5. You close tab 5. It's confusing and unintuitive to go back to tab 3?
12:38:23 <clokep_work> nhnt11: Yes.
12:38:25 <nhnt11> Do you want to go back to tab 3 only if you close tab5 within a few seconds?
12:38:27 <clokep_work> I HATE that behavior with a passion.
12:38:35 <clokep_work> I /never/ want to go back to that tab.
12:38:59 <clokep_work> sawrubh: Can you give a specific example?
12:39:00 <nhnt11> So you /want/ to go to the tab next to the one you closed?
12:39:05 <clokep_work> Yes.
12:39:09 <nhnt11> That's weird.
12:39:12 <clokep_work> That's how both Firefox and Instantbird work right now.
12:39:24 <nhnt11> Hmm right that's how firefox works
12:39:26 <clokep_work> I don't think so.
12:39:35 <clokep_work> I think you're not really fixing what Florian filed that bug about.
12:39:35 <nhnt11> Maybe only for newtab then..
12:39:51 <clokep_work> I also don't really think we should have Escape close that tab, personally.
12:40:07 * clokep_work isn't sure why flo-retina thinks that fits into the other behavior.
12:40:15 <nhnt11> Yes. I purposely extended it, because /I/ thought it was intuitive
12:40:33 <nhnt11> (I can make it newtab only, no problem)
12:42:31 <flo-retina> clokep_work: are you saying my review wasn't careful enough? :)
12:42:56 <clokep_work> flo-retina: I'm saying I want to ensure we understand what we're landing.
12:43:53 <sawrubh> clokep_work: ok, so suppose I have a function which wants to show the error ("File transfer offer for file" + fileName + "declined"), in order to show this error it would call my function with the proper enum and fileName as argument, fileName would be used to contruct the error string to be shown in conversation.xml. If (as I understand it) we pass only the
12:43:53 <sawrubh> enum name right now (because only then we'll be able to not have to mess with nsISupportsString) how will that happen?
12:44:30 <clokep_work> sawrubh: This is why I was suggesting we might need a prplIFileTransfer object. :)
12:45:17 <sawrubh> and that's why I have imIFileTransferError object, for this error handling and I'm getting this error :)
12:45:36 <clokep_work> Those aren't the same things.
12:45:44 <sawrubh> I have two objects, prplIFileTransfer object for file transfer needs, imIFileTransferError for error handling
12:45:52 <clokep_work> They should be one object.
12:45:54 <flo-retina> clokep_work: indeed, I didn't pay enough attention
12:45:58 <clokep_work> Like the way prplIAccount does it.
12:46:12 <flo-retina> nhnt11: I think we probably want to do it only for the new tab. And possibly only for the escape key.
12:46:15 <aleth_web> sawrubh: There's a difference between the receiver not accepting an upload (so it never starts) and an upload/download failing. The latter is almost certainly already covered in some way by the download panel interfaces
12:46:18 <clokep_work> sawrubh: I don't understand why you're getting that error though, I was hoping aleth_web or flo-retina would have an idea.
12:46:55 <flo-retina> clokep_work: which error?
12:47:01 <sawrubh> clokep_work: exactly what you're suggesting is I understand elegance and beauty of code which I'll do once I figure out why the current system doesn't work
12:47:16 <sawrubh> flo-retina: one sec while I link the pastebins
12:47:57 <nhnt11> flo-retina, clokep_work: ok
12:48:07 * nhnt11 starts over
12:48:08 <sawrubh> flo-retina:  I call this method called sendErrorMessage(http://pastebin.instantbird.com/742790) which defined (http://pastebin.instantbird.com/742789) and it then passes it to conversation.xml (L40 of http://pastebin.instantbird.com/742804) but I'm getting the error : http://pastebin.instantbird.com/742793
12:48:40 <flo-retina> nhnt11: could be for the escape key in general maybe
12:49:01 <flo-retina> nhnt11: or maybe only for tabs that haven't been selected explicitly by the user
12:49:26 <flo-retina> I mean, when you Command+T to open the awesometab, the fact that the that tab gets selected isn't the result of a click on a tab.
12:49:52 <flo-retina> hmm, I guess in the other cases the tab that opens automatically doesn't get selected by default
12:55:01 --> Rym has joined #instantbird
12:55:14 <flo-retina> sawrubh: no idea. You'll need to either add a few dumps in notification.xml, or us the debugger
12:55:26 <flo-retina> (do we have instructions anywhere about how to get the debugger to work?)
12:55:38 <sawrubh> which debugger are we talking about?
12:55:57 <flo-retina> the chrome debugger, or whatever it's called
12:56:02 <flo-retina> maybe Browser Debugger
12:58:01 <aleth_web> I think there's instructions in the (IB) bug
12:59:03 <sawrubh> aleth_web: bug #?
12:59:25 * nhnt11 really wants to get a patch up for this before he has to leave
13:01:42 --> qheaden has joined #instantbird
13:01:50 <qheaden> Hello everyone.
13:05:36 --> nhnt11-testing has joined #instantbird
13:05:56 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:06:16 <clokep_work> Hello qheaden.
13:08:31 * qheaden wonders why he is getting an HTTP connection error with JS-Yahoo.
13:08:42 <-- Rym has quit (Ping timeout)
13:09:50 <nhnt11> flo-retina: Do we want the restore previous tab behavior only for escape or when it's closed in general? (give me an ultimatum please, I gtg soon)
13:10:01 <nhnt11> clokep_work: ^
13:10:13 <flo-retina> nhnt11: what do you think is the best behavior?
13:10:18 <nhnt11> I think mimicking firefox is best
13:10:22 <nhnt11> (closed by any means)
13:10:38 <flo-retina> agreed
13:11:21 --> nhnt11-testing has joined #instantbird
13:11:39 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:12:36 <nhnt11> I've uploaded a patch (fairly trivial again) :)
13:15:46 <qheaden> Is anyone able to connect to their account with JS-Yahoo?
13:18:02 * clokep_work hasn't tried today.
13:18:07 <-- nhnt11 has quit (Input/output error)
13:21:56 --> Rym has joined #instantbird
13:25:22 <qheaden> Turns out that libpurple Yahoo can connect, but not JS-Yahoo. :(
13:25:26 * qheaden sighs
13:25:57 <clokep_work> qheaden: Figure out the difference? :P
13:26:09 <qheaden> Yeah, I'm about to do that now.
13:29:52 <-- jb has quit (Ping timeout)
13:31:38 <qheaden> Hmm. Looks like the web server we get our Yahoo pager IP address from isn't responding.
13:31:49 <qheaden> Let me see which one libpurple uses.
13:32:36 <clokep_work> :-S
13:34:07 <qheaden> So, it looks like we should be using scsa.msg.yahoo.com/capacity as our URL. It is a round-robin DNS for their MSG information servers.
13:34:19 <qheaden> Last comment here: https://developer.pidgin.im/ticket/12357
13:36:34 <clokep_work> qheaden: What do we currently use?
13:36:49 <clokep_work> (Link me is good enough.)
13:37:33 <qheaden> vcs1.msg.yahoo.com/capacity
13:37:39 <qheaden> http://lxr.mozilla.org/comm-central/source/chat/protocols/yahoo/yahoo.js#530
13:37:50 <qheaden> I changed the URL just now, rebuilt, and I was able to connect.
13:38:01 <qheaden> Perhaps they are shifting some servers around since Yahoo Japan is supposed to be going out soon.
13:40:47 <clokep_work> That has a bad cert on it now? :-S
13:41:24 <qheaden> Bad cert?
13:41:28 * clokep_work used http://dxr.mozilla.org/comm-central/source/chat/protocols/yahoo/yahoo.js#530 instead
13:41:36 <clokep_work> qheaden: That page caused a certificate error for me.
13:41:47 <clokep_work> Apparently something I have upgraded that to an HTTPS link.
13:42:04 <clokep_work> qheaden: Put up a patch.
13:42:17 <clokep_work> If it's just a round-robin than NBD. :)
13:42:34 <qheaden> clokep_work: You get an SSL error? I can't even connect. :P
13:42:53 <qheaden> Hmm, looks like the URL we use for Yahoo JAPAN is dead too. :-/
13:43:13 <qheaden> I'm not sure how we should treat Yahoo JAPAN at this point, if it is going out soon.
13:43:37 <-- Rym has quit (Ping timeout)
13:43:49 <clokep_work> qheaden: I think you totally misunderstood what I just said. That LXR link gave an SSL error to me.
13:44:03 <qheaden> Oh. :P
13:44:49 --> Rym has joined #instantbird
13:51:51 <instantbot> New Chat Core - Yahoo! Messenger bug 1031305 filed by qheaden@phaseshiftsoftware.com.
13:51:52 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1031305 nor, --, ---, qheaden, ASSI, Capacity server URLs are dead and prevent connection
13:53:41 <-- Rym has quit (Ping timeout)
13:53:59 --> Rym has joined #instantbird
13:58:03 <qheaden> When I nslookup cs1.yahoo.co.jp, I get that cs.yahoo.co.jp is a canonical name for it. When I look that up, I get no DNS answer. I guess they removed the DNS entries for the Yahoo Japan capacity server?
14:00:29 <qheaden> Okay, so it looks like even libpurple cannot connect to Yahoo JAPAN's servers anymore. I get the error "The server returned an empty response."
14:01:01 <clokep_work> qheaden: When did that bug we found say it was to be disabled?
14:01:18 * qheaden looks for the url
14:02:39 <qheaden> According to the bug: It shut down March 26th https://developer.pidgin.im/ticket/15906
14:03:07 <clokep_work> Oh, of this year?
14:03:26 <qheaden> Yep. Just translated the site notice, and they said it will no longer be in servers on March 26th 2014
14:03:28 <clokep_work> qheaden: http://www.microsofttranslator.com/bv.aspx
14:03:30 <clokep_work> Hah, yes.
14:03:38 <clokep_work> qheaden: OK, in a separate bug, let's nuke it?
14:03:43 <qheaden> Okay.
14:04:50 <-- mayanktg has quit (Ping timeout)
14:05:39 --> mayanktg has joined #instantbird
14:06:25 <instantbot> New Chat Core - Yahoo! Messenger bug 1031314 filed by qheaden@phaseshiftsoftware.com.
14:06:26 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1031314 nor, --, ---, qheaden, ASSI, Remove Yahoo! JAPAN support from JS-Yahoo
14:07:10 <-- BWMerlin has quit (Quit: BWMerlin)
14:13:00 --> iamjayakumars has joined #instantbird
14:15:39 <qheaden> flo-retina: Thanks for posting the translated notice.
14:16:42 <flo-retina> qheaden: np;
14:16:48 <flo-retina> qheaden: actually, I couldn't resist.
14:17:02 <flo-retina> qheaden: it's the first time I actually translate a page to read it (rather than to work on the translation feature)
14:18:41 <qheaden> lol
14:20:25 <clokep_work> Patches nuking lots of code are easy to review. ;)
14:23:50 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:24:21 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:25:12 <qheaden> :)
14:25:36 <qheaden> A feel a little better not having to debug Yahoo JAPAN and figure out that something doesn't work on that side.
14:26:29 <qheaden> We need to get that URL patch in the tree as soon as possible. Without it, no one can log in.
14:28:17 <clokep_work> Yeah. Unfortunately the tree is busted right now.
14:29:26 <aleth_web> it's been closed all week :(
14:29:44 <qheaden> I noticed that. :(
14:34:03 --> mconley has joined #instantbird
14:35:05 <qheaden> aleth_web: I just tested bug 955571, and I am able to see the status message in the tooltip of buddies.
14:35:07 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955571 nor, --, ---, nobody, NEW, Status messages of contacts not shown in buddy tooltip
14:35:53 <aleth_web> qheaden: Great, then maybe it got fixed by wnayes or me in recent tooltip patches :) Just resolve it then WFM
14:36:05 <qheaden> Okay.
14:38:35 <qheaden> aleth_web: Is this the way it should be? http://imgur.com/3V7UTUc
14:39:19 <aleth_web> qheaden: yes
14:39:31 <qheaden> Okay, good.
14:40:30 <instantbot> qheaden@phaseshiftsoftware.com changed the Resolution on bug 955571 from --- to WORKSFORME.
14:40:31 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955571 nor, --, ---, nobody, RESO WORKSFORME, Status messages of contacts not shown in buddy tooltip
14:42:39 <aleth_web> Not that many js-yahoo bugs to go :)
14:43:26 * Fallen is now known as Fallen|away
14:47:46 --> jb has joined #instantbird
15:01:41 <aleth_web> qheaden is on a roll today...
15:01:54 <qheaden> \o/
15:02:14 * qheaden actually has a cold, and is at home today instead of at work
15:14:16 --> flo-retina has joined #instantbird
15:14:17 * ChanServ sets mode +qo flo-retina flo-retina 
15:14:21 <-- qheaden has quit (Ping timeout)
15:14:54 --> qheaden has joined #instantbird
15:15:42 * qheaden is giving clokep_work a workout!
15:17:19 <clokep_work> qheaden: You probably want to mark those all as checkin-needed btw.
15:20:41 <qheaden> Okay.
15:26:43 <-- iamjayakumars has quit (Client exited)
15:26:47 --> iamjayakumars has joined #instantbird
15:50:45 <clokep_work> qheaden: So what is left then?
15:51:28 <-- gerard-majax_ has quit (Ping timeout)
15:57:50 <-- jb has quit (Ping timeout)
15:58:45 --> mayanktg-ph has joined #instantbird
15:59:01 <-- mayanktg-ph has quit (Quit: )
16:09:27 <-- Rym has quit (Ping timeout)
16:14:20 --> Rym has joined #instantbird
16:23:18 <-- Rym has quit (Ping timeout)
16:30:04 --> Rym has joined #instantbird
16:31:17 --> mayanktg has joined #instantbird
16:32:57 <-- Tonnes has quit (Connection reset by peer)
16:33:27 * Fallen|away is now known as Fallen
16:37:24 --> Tonnes has joined #instantbird
16:44:01 <mayanktg> aleth_web: Thanks for taking a look into the patch. I'll do the necessary changes.
16:45:05 <aleth_web> Ask here if you don't understand something...
16:46:39 <mayanktg> aleth_web: Regarding Entity Discovery I read the Entity Discovery (0115) and Service Discovery (0030) XEPs again. Do you know what my first step would/should be?
16:47:59 --> Mook_as has joined #instantbird
16:48:28 <mayanktg> How will I determine that video/audio device exists in _my_ device and then send this info when queried by other user?
16:48:31 <aleth_web> Talk to sawrubh to discover if/what work he has already done on this?
16:48:56 <aleth_web> Looks like there's two parts to this bug, sending the info and receiving it.
16:48:56 <mayanktg> Ok
16:49:38 <aleth_web> Don't you already determine what video/audio is available in the webcam bug somewhere?
16:49:55 <mayanktg> Yes. getUserMediaDevices()
16:50:02 <aleth_web> OK, so you know how to do it ;)
16:50:19 <mayanktg> Yess! For this I'll be needing a DOMWindow.
16:51:06 <aleth_web> Yes, so you have to figure out when you need this information (on account connect? later?) and then request the UI to give it to you.
16:53:04 <mayanktg> Ok. I guess we should get this information on account connect only. This would be easier in the future if we want to specify the video/voice call support on the buddy list.
16:53:07 <aleth_web> It may help to first do the "get info from contacts" part and then see what e.g. Jitsi sends you in response to that.
16:53:42 <aleth_web> That should give you an idea for the kind of thing you have to send yourself.
16:53:56 <mayanktg> great.
16:55:09 <aleth_web> Of course there should also be examples in the XEPs ;)
16:55:35 <-- clokep_work has quit (Ping timeout)
16:55:53 <mayanktg> Yes I've read them. But seeing the exact samples would definitely help me understand what needs to be done. 
16:56:43 <aleth_web> Also useful for tests ;)
16:57:50 <mayanktg> Hehe. I'm trying to implement the "get info from contacts" part then...
16:58:32 <aleth_web> Right, implement that part of 0115 and see what kind of info you get...
17:00:05 <aleth_web> Look at the existing code that deals with the roster before you start, to see whether it is related.
17:04:03 <mayanktg> Yes. I was seeing the roster part only a while before. Ok. I'm trying to implement it now. 
17:06:26 <aleth_web> It might not be related of course... idk how XEP 0115 works ;)
17:14:19 <-- iamjayakumars has quit (Quit: )
17:19:23 <qheaden> I can't seem to reproduce bug 955588.
17:19:25 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955588 nor, --, ---, nobody, NEW, Attempting to store duplicate buddy error after failed auth request
17:19:34 <qheaden> It's one of those aleth_web specials. ;)
17:21:48 <aleth_web> It might be due to a different JS-Yahoo bug (hopefully now fixed) affecting the contact data for the profile I was using at the time?
17:22:01 <qheaden> Perhaps.
17:22:14 <aleth_web> Maybe the ymail issues were fixed elsewhere?
17:28:00 <mayanktg> aleth_web: Jitsi sends the entity information with the presence stanza only on account connect. I didn't implementing anything, just connected my XMPP-A with Ib and XMPP-B with Jitsi. I received a presence stanza http://pastebin.instantbird.com/742952 with <c/> element just like its given in http://xmpp.org/extensions/xep-0115.html#howitworks. :)  
17:28:30 <sawrubh> mayanktg: yes I've seen that in my explorations
17:28:47 <sawrubh> even right now I receive the <c/> element in my debug log
17:29:25 <aleth_web> That's good isn't it, then you just need to parse it?
17:30:08 <aleth_web> And look at the XEPs to find out what you do if you're talking to a client that doesn't automatically send it to you.
17:33:01 <mayanktg> Yes it is. Ok. So now I should first figure out how to parse the <c/> element and get device capability info, then look for how to _ask_ for this info from the client that doesn't automatically send this as presence stanza?
17:33:08 <flo-retina> can we just do nothing in that case and assume WebRTC isn't supported? ;)
17:33:23 <aleth_web> Yes
17:33:47 <flo-retina> I don't think we should spam the network with service discovery stanzas :)
17:34:19 <aleth_web> flo-retina: yes (though sawrubh may not be able to make that assumption ;) )
17:34:42 <aleth_web> flo-retina: iirc avoiding spamming is what 0115 is all about.
17:35:10 <sawrubh> it would be spamming if you consider presence stanzas spamming
17:35:51 <sawrubh> I mean from my readings it seemed all we do is just add this extra element to the already being-sent-out presence stanza
17:35:57 * sawrubh reads again
17:36:49 <aleth_web> mayanktg: So for your purposes, I think flo is right and you can just assume someone without a <c/> element can't do voice or video, as in that case the client is ancient ;)
17:36:49 <sawrubh> nvm I misunderstood what you guys were talking about -> shutting up
17:37:02 <aleth_web> (just to avoid misunderstandings)
17:37:07 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:39:40 <flo-retina> aleth_web: I think we can also decide that file transfer isn't supported, and use filelink :)
17:39:49 <sawrubh> we could do that
17:39:55 <aleth_web> heh :D
17:40:05 * sawrubh loves filelink more for some reason
17:40:22 <flo-retina> sawrubh: could be that you are working on it? :-P
17:40:23 <mayanktg> aleth_web: What I'll do is --> If I receive a presence stanza with <c/> I'll send this element to a function which parses it for "video" and/or "voice" support and if it supports notify about it. right?
17:40:24 <sawrubh> I like the persistence it provides
17:41:24 <aleth_web> mayanktg: I don't think you notify anyone, you just store the capability data with the buddy.
17:42:59 <mayanktg> aleth_web: Ok. How/Where to store the capability data with the particular buddies. :-o
17:43:55 <aleth_web> mayanktg: take a look at XMPP account buddies
17:44:23 <aleth_web> Already there in the code ;)
17:44:40 <mayanktg> Okays! :)
17:46:09 <flo-retina> aleth_web: isn't that stored already?
17:46:26 <aleth_web> If it's stored already, then mayanktg should discover that fact very soon ;)
17:47:07 <aleth_web> I'm just asking him to read the related code around presence and accountbuddies.
17:47:12 <flo-retina> http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp.jsm#534 it looks like we currently store the whole presence stanza
17:47:32 <flo-retina> (even though that seems wasteful, and should probably be changed someday)
17:47:45 <flo-retina> I suspect the capabilities is the only useful thing that isn't already stored in other fields of that object
17:48:13 <aleth_web> It would be better to parse that part of the stanza on receipt.
17:49:03 <flo-retina> hmm, we may have to do it, if we want to update the disabled attribute of some icons in the UI
17:49:17 <aleth_web> Right.
17:59:05 <aleth_web> flo-retina: "the "your account has been reconnected" message should be displayed only _after_ we have called joinChat, right?" I don't understand this comment, what is your concern?
18:05:04 --> clokep has joined #instantbird
18:06:04 * clokep is now known as IRCMonkey30332
18:08:01 * IRCMonkey30332 is now known as clokep_
18:15:26 <clokep_> sawrubh: So did you figure out that issue then?
18:19:17 <flo-retina> aleth_web: we don't want to display that message if we are not auto-rejoining, right?
18:19:42 <aleth_web> We do, to let you know that you can /join again ;)
18:20:08 <aleth_web> At least that's what I thought.
18:20:11 <flo-retina> aleth_web: if you had /part'ed, I think we no longer "account disconnected" messages
18:20:30 <flo-retina> so you would display plenty of "account reconnected" messages without every saying that it's been disconnected beforehand
18:20:42 <aleth_web> Hmm, I'll check that.
18:20:45 <aleth_web> Makes sense.
18:24:13 * clokep_ tries to reproduce the password thing.
18:24:31 <-- clokep_ has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
18:25:16 --> clokep has joined #instantbird
18:25:16 * ChanServ sets mode +o clokep 
18:25:56 <clokep> flo-retina: So oddly the protocols which I retyped in my passwords DID connect.
18:25:59 <clokep> But the other ones did not.
18:27:15 <clokep> But I can't reproduce w/ my local build.
18:27:26 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:28:34 --> clokep has joined #instantbird
18:29:06 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
18:29:08 --> gerard-majax_ has joined #instantbird
18:30:04 <-- Rym has quit (Ping timeout)
18:30:59 --> Rym has joined #instantbird
18:32:12 --> clokep has joined #instantbird
18:33:38 <clokep> sawrubh: What does "DOS issue" mean?
18:34:38 <aleth_web> clokep: Is this a migration issue?
18:34:49 <clokep> aleth_web: I don't know.
18:34:59 <clokep> I'm going to build again and see.
18:43:44 <flo-retina> clokep: likely deny-of-service ?
18:44:45 <clokep> flo-retina: Llikely, but I don't understand what he said in context.
18:45:05 <flo-retina> I don't know what you are talking about :)
18:45:10 <clokep> His blog post.
18:45:14 * flo-retina feels like he's playing Mook's role ;)
18:50:15 <sawrubh> clokep no I haven't been able to figure this out, I seem to have a feeling this is to do with a) I've added function called sendErrorMessage in XMPPConversationPrototype object, now should I add that in the prplIConversation IDL definition or something or b) I might need to add this function sendErrorMessage somewhere else
18:50:44 <sawrubh> clokep: by DOS issue I meant what I was earlier doing is getting the permission of the user while sending the initiate offer of IBB stream
18:51:22 <sawrubh> I accepted the Stream Initiation offer directly, created a local file and then sent the IBB initiation request which could then be declined and accepted
18:51:52 <sawrubh> someone could have easily sent many such SI offers and caused me to create many local files, that is what I meant
18:52:35 <clokep> sawrubh: So DOS /does/ mean "Denial of Service"
18:52:55 <clokep> sawrubh: Why are you calling sendErrorMessage from?
18:53:08 <clokep> I thought it was getting called though? :-S
18:53:11 <sawrubh> I didn't get your last question
18:53:57 <sawrubh> for your first question: yeah so if you send enough such requests you could potentially cause the receiver to create a lot of these local files and hence bring it down or something so I called it DOS
18:54:05 <sawrubh> probably I need to find a better term for it
18:54:54 <-- clokep has quit (Ping timeout)
18:55:13 --> clokep has joined #instantbird
18:55:43 <clokep> sawrubh: To be clear my question was literally just "DOS == Denial of Service", I know what a denial of service attack is. :P
18:55:48 <clokep> sawrubh: Which question did you not understand?
18:56:00 <sawrubh> "Why are you calling sendErrorMessage from?"
18:56:06 <clokep> Where, not why
18:56:48 <sawrubh> I call sendErrorMessage from wherever I was doing a Cu.reportError earlier, like for example in the callback which handles the reply to the stream initiation offer sent by the sender
18:58:16 <clokep> sawrubh: Remember that I can't keep the same context of these problems in my head that you can -- I work on many different things.
18:58:28 <clokep> I don't know where you used to be calling from Cu.reportError from.
18:58:33 <sawrubh> ok sorry should I explain again?
18:58:49 <sawrubh> here it goes
18:59:08 <sawrubh> (and this probably might uncover the bug)
18:59:13 <clokep> Yep. :)
19:02:52 <-- gerard-majax_ has quit (Ping timeout)
19:04:03 <sawrubh> so I had these reportError's which I was using to show the errors, I had to somehow trickle them to the UI so what I did was, add sendErrorMessage() to XMPPConversationPrototype (just where I added sendFile() method), I have simply added this field called 'error' to the prplIFileTransfer IDL
19:05:18 <sawrubh> now I populate this inside sendErrorMessage using something like http://pastebin.instantbird.com/742999
19:07:05 <clokep> OK
19:07:25 <sawrubh> now consumers () call this like L122 of http://pastebin.instantbird.com/743000
19:07:37 --> gerard-majax_ has joined #instantbird
19:08:38 <-- Rym has quit (Ping timeout)
19:09:14 <sawrubh> the error is http://pastebin.instantbird.com/743002
19:09:35 <sawrubh> now a)I'm confused why it says prpl-jabber at all in the error event though I'm using js-xmpp
19:11:36 --> Rym has joined #instantbird
19:11:49 <-- Rym has quit (Quit: WeeChat 0.4.3)
19:12:01 --> Rym has joined #instantbird
19:12:53 <aleth_web> prpl-jabber is the protocol id string, js-xmpp is an implementation of prpl-jabber so to speak
19:16:35 <-- gerard-majax_ has quit (Ping timeout)
19:19:15 <clokep> sawrubh: So, did you try printing things out? What is the notifiction trying to be fired?
19:28:45 <-- Rym has quit (Ping timeout)
19:31:29 --> Rym has joined #instantbird
19:39:22 --> The0x539 has joined #instantbird
19:58:24 <clokep> sawrubh: Any luck?
20:04:44 <sawrubh> no, so I see everything correctly in the notifyObserver function, I don't know what gets called after observer.observe(http://mxr.mozilla.org/comm-central/source/chat/modules/jsProtoHelper.jsm#468) but exploring http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/widgets/notification.xml#152 (which must be getting called by my code:
20:04:44 <sawrubh> http://pastebin.instantbird.com/743023) I see http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/widgets/notification.xml#247 is the line where aNotification is null
20:06:21 * clokep goes to look at the patches again on the bug.
20:06:27 <clokep> sawrubh: Or are those too out of date to be useful?
20:06:30 <clokep> I'm curious about the UI one
20:06:45 <sawrubh> I'll update my WIP there, or I could pastebin them here
20:06:50 <sawrubh> which one is convenient for you?
20:07:36 <clokep> pastebin at the moment is OK
20:08:07 <sawrubh> 2 minutes
20:08:18 <clokep> Rgr
20:08:30 <sawrubh> what's rgr?
20:08:34 <clokep> Roger.
20:08:38 <clokep> "I understand"
20:08:54 <sawrubh> yeah I've seen enough Hollywood movies to know what roger means
20:08:56 <clokep> (As opposed to wilco = "will comply" == "I will do")
20:09:07 <sawrubh> :P
20:09:12 <clokep> sawrubh: Most movies use "Roger" when they should use "wilco". :)
20:09:46 * aleth_web wonders where "roger" came from...
20:10:33 <aleth_web> ah, 'r' for 'received'
20:10:37 <aleth_web> duh.
20:11:09 <clokep> :-D
20:22:42 <mayanktg> aleth_web: What does a receipt means? http://log.bezut.info/instantbird/today#m397 . How can I add button to the UI after adding it to the receipt ? (Like add video call button if <c/> element's attribute "ext" has "voice-v1").
20:26:21 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
20:27:25 <mayanktg> flo-retina: Could you tell what a receipt is?
20:27:36 <flo-retina> if you can give me the context
20:27:39 <flo-retina> maybe :)
20:28:14 <mayanktg> I have to put the <c/> element I have received from the presence stanza into the receipt.
20:29:42 <mayanktg> It was as per the conversation http://log.bezut.info/instantbird/today#m397 which mentioned that I have to put the element on a receipt so that it can be used to enable/add buttons for use.
20:29:50 <flo-retina> "on receipt" means "when receiving"
20:31:02 <mayanktg> aah .. Ok :)
20:36:30 <sawrubh> clokep: backend patch: http://pastebin.instantbird.com/743024, UI patch: http://pastebin.instantbird.com/743025 (sorry for the delay)
20:36:58 <-- The0x539 has left #instantbird ()
20:37:13 <clokep> sawrubh: OK, so do lines 183 get called?
20:37:20 <clokep> What is "aSubject" there if you print it out?
20:38:53 <sawrubh> clokep: yes, line 183 is being called (that's how appendNotification is called which then shows the error of aNotification being null)
20:39:09 <sawrubh> lemme see what aSubject is there
20:39:31 <sawrubh> a toSource() on aSubject......let's see whatya got
20:39:56 <clokep> I usually like to print out the variable, toSource and sometimes JSON.stringify, depending on what I'm expecting.
20:46:03 <sawrubh> clokep: http://pastebin.instantbird.com/743036
20:46:32 <clokep> Interesting.
20:50:18 <clokep> flo-retina: ^
20:50:28 <clokep> sawrubh: Any reason you're making a GenericFileTransferPrototype and not using it? Just testing?
20:51:36 <sawrubh> ah, it slipped my mind to remove it
20:52:37 <sawrubh> when I started doing this patch I thought I would need such an object for implementing addObserver, removeObserver which were required if you wanted to call notifyObserver with a prplIFileTransfer object as argument
20:52:43 <sawrubh> but that myth has been busted
20:53:02 <sawrubh> I'll remove the addObserver and removeObserver from prplIFileTransfer IDL definition too
20:53:26 <flo-retina> clokep: there's either a QueryInterface call missing, or a broken ClassInfo implementation
20:53:46 <clokep> sawrubh: ^
20:54:30 <sawrubh> ah so GenericFileTransferPrototype might be needed afterall
20:57:01 <flo-retina> sawrubh: not if you only need ClassInfo
20:58:43 <clokep> sawrubh: You could do something like http://lxr.instantbird.org/instantbird/source/chat/protocols/twitter/twitter.js#102
20:58:45 * sawrubh goes to look up the importance of ClassInfo and what is a non-broken implementatin of it
20:59:01 <sawrubh> I understood as some sort of description
21:01:42 <flo-retina> sawrubh: it lists the interfaces that are available on your object
21:01:51 <flo-retina> s/available on/implemented by/
21:03:31 * sawrubh writes this in his to-be-blogged-about list
21:04:08 <-- mayanktg has quit (Ping timeout)
21:07:12 --> mayanktg has joined #instantbird
21:11:47 <flo-retina> sawrubh: if you want to understand more about it, "interface flattening" will be nice search keywords ;)
21:12:27 <-- Rym has quit (Ping timeout)
21:13:21 --> Rym has joined #instantbird
21:13:25 <sawrubh> ta
21:41:44 <clokep> Bah, the buddy added prompt thing really sucks (when someone "wants to chat with you" :-\
21:50:26 <flo-retina> yes, it's our worst piece of UI
21:51:24 <clokep> Free donuts for anyone who fixes it after GSoC.
21:51:59 <sawrubh> will you ship the donuts or will we have to come to Boston for that?
21:52:11 <flo-retina> sawrubh: implementation details
21:52:50 <clokep> sawrubh: If you want Boston cream doughnuts you'll probably have to come to Boston.
21:53:15 <sawrubh> flo-retina: with that recent Google offer to pay to go attend the reunion, I'm just wary of everything :P ;)
21:55:33 <flo-retina> have you applied for that lottery?
21:56:35 <sawrubh> nah, I knew I wouldn't be able/want to pay for it :)
21:56:57 <sawrubh> my entire stipend might be spent on it
21:57:03 <sawrubh> or quite some of it I guess
22:07:24 <-- Rym has quit (Ping timeout)
22:07:41 --> Rym has joined #instantbird
22:10:43 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:16:51 <-- mconley has quit (Input/output error)
22:25:34 <-- Rym has quit (Ping timeout)
22:31:09 --> Rym has joined #instantbird
22:36:02 <-- Rym has quit (Connection reset by peer)
22:36:24 --> Rym has joined #instantbird
22:36:37 --> wnayes has joined #instantbird
22:47:26 <-- wnayes has quit (Connection reset by peer)
22:48:59 <-- aleth_web has quit (Quit: Connection closed for inactivity)
22:51:38 --> wnayes has joined #instantbird
22:59:22 * Fallen is now known as Fallen|away
23:02:16 <-- wnayes has quit (Connection reset by peer)
23:06:26 --> wnayes has joined #instantbird
23:09:19 <-- wnayes has quit (Connection reset by peer)
23:09:55 --> wnayes has joined #instantbird
23:12:49 <-- wnayes has quit (Connection reset by peer)
23:16:25 <-- clokep has quit (Ping timeout)
23:17:18 <-- Rym has quit (Ping timeout)
23:17:31 --> wnayes has joined #instantbird
23:18:21 <-- wnayes has quit (Connection reset by peer)
23:18:56 --> Rym has joined #instantbird
23:19:32 --> wnayes has joined #instantbird
23:23:00 <-- flo-retina has quit (Ping timeout)
23:27:31 --> mconley has joined #instantbird
23:32:42 --> BWMerlin has joined #instantbird
23:47:34 <-- wnayes has quit (Connection reset by peer)
23:48:45 <-- Rym has quit (Ping timeout)
23:49:02 --> Rym has joined #instantbird
23:51:45 --> wnayes has joined #instantbird
23:51:58 <-- wnayes has quit (Quit: wnayes)