#instantbird log on 06 25 2014

All times are UTC.

00:22:47 <-- mayanktg has quit (Ping timeout)
00:26:20 <-- Rym has quit (Ping timeout)
00:26:37 --> mayanktg has joined #instantbird
00:32:06 --> Rym has joined #instantbird
00:55:44 <-- wnayes has quit (Ping timeout)
00:58:54 --> wnayes has joined #instantbird
01:05:19 <-- Mook_as has quit (Quit: Mook_as)
01:41:54 <-- mconley has quit (Input/output error)
01:46:45 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
02:25:19 <-- wnayes has quit (Quit: wnayes)
02:33:10 <-- Rym has quit (Ping timeout)
02:33:29 --> Rym has joined #instantbird
02:38:08 <-- Rym has quit (Ping timeout)
02:58:18 --> Mook has joined #instantbird
03:08:55 <-- mpmc1 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
03:31:53 <-- flo-retina has quit (Ping timeout)
05:30:06 <-- EionRobb has quit (Quit: Leaving.)
06:38:52 --> flo-retina has joined #instantbird
06:38:52 * ChanServ sets mode +qo flo-retina flo-retina 
06:39:37 <flo-retina> hello :)
06:40:18 <flo-retina> clokep: I don't remember seeing that question before no.
06:40:27 <flo-retina> my nightly hasn't lost my passwords
06:40:38 <flo-retina> are you thinking about a possible windows-specific issue?
06:41:33 <nhnt11> flo-retina: Thanks for the feedback! Quite some stuff to think about :)
06:41:52 <nhnt11> btw, I got a friend to try Instantbird and he said the account manager froze on the first run
06:41:54 <flo-retina> indeed, that may keep you busy for a few hours ;)
06:42:03 <nhnt11> He has some sort of proxy setup, is this a known issue?
06:42:05 <nhnt11> He's on windows
06:42:10 <flo-retina> is that really the account manager?
06:42:17 <flo-retina> or was this after connecting an account?
06:42:21 <nhnt11> I think he meant "account wizard"
06:42:29 <flo-retina> If the later, it could be the sync I/O of the contacts list storage
06:42:44 <flo-retina> that used to freeze for 2 minutes or so on Windows with a largish set of facebook friends
06:42:48 <nhnt11> I'll try to get more details out of him, unfortunately he told me about this on WhatsApp on which I was a bit too lazy to type right after I woke up
06:42:53 <nhnt11> Hmm I see.
06:42:53 <flo-retina> I think with some hacks I've reduced it to at most a few seconds
06:43:04 <nhnt11> I don't /think/ that's the case
06:43:12 <nhnt11> From what I gathered he couldn't add any accounts
06:43:18 <flo-retina> but the real solution would be to get rid of the .sqlite file, and just OS.File async write a json file
06:43:20 <nhnt11> Anyway I'll ask him for more details
06:43:44 <flo-retina> ok :)
06:44:10 <flo-retina> nhnt11: your patch took my whole train hour, so I haven't looked at all at the other stuff in the queue
06:45:04 <nhnt11> flo-retina: Er.. sorry? :]
06:45:27 <flo-retina> nhnt11: there's a forEach method in logger.js that's used by the indexing patch.
06:45:39 <nhnt11> flo-retina: That's r+ already by aleth
06:45:47 <flo-retina> I almost commented that I don't remember seeing/reviewing it, but thought it was in the async log patch
06:45:49 <flo-retina> except it isn't
06:45:53 <flo-retina> nhnt11: which patch?
06:45:55 <nhnt11> bug 1025464
06:45:57 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1025464 nor, --, ---, nhnt11, NEW, Refactor log sweeping code to use Task.jsm and move it to logger.js
06:45:59 <nhnt11> flo-retina: ^
06:46:22 <flo-retina> ah, I should have a look there
06:46:33 <flo-retina> is that applying after the async I/O patch?
06:46:36 <nhnt11> That bug blocks the indexing bug btw
06:46:37 <nhnt11> Yes.
06:46:47 <nhnt11> Async I/O, then refactor/move, then indexing.
06:47:46 <nhnt11> flo-retina: Btw, I thought |function* ()| was the convention. I've used that /everywhere/, in the async logs patch
06:48:07 <flo-retina> it's possible I haven't paid attention to that at the time :-/
06:48:28 <nhnt11> flo-retina: function* () is the convention used in m-c
06:48:59 <nhnt11> In /most/ places at least, from this dxr search... hmm
06:48:59 <flo-retina> nhnt11: btw, re bug 1025464, in general patches changing idl files in chat/ need my review or at least rs ;).
06:49:02 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1025464 nor, --, ---, nhnt11, NEW, Refactor log sweeping code to use Task.jsm and move it to logger.js
06:49:19 <nhnt11> flo-retina: okay, should have told you to take a look, sorry.
06:49:30 * nhnt11 got caught up in other stuff
06:49:38 <flo-retina> no worries
06:49:45 <flo-retina> our review policies aren't very explicit ;)
06:50:35 <nhnt11> flo-retina: So I'm going to just follow whatever you want for function* (fwiw I like it with the space better). If you want me to do a find/replace in the async logs patch, I'll do that in a few minutes.
06:52:39 <flo-retina> do we have other uses in existing chat/ code?
06:53:36 <nhnt11> flo-retina: only one anonymous from what I see from searching mxr
06:53:44 <nhnt11> https://mxr.mozilla.org/comm-central/source/mozilla/browser/base/content/test/chat/head.js#70
06:53:47 <nhnt11> It has the space
06:54:01 <nhnt11> Task.jsm includes teh space as well
06:55:06 <flo-retina> fair enough; discard that comment then :)
06:55:19 <flo-retina> I've got to go. I'm likely unavailable until 5pm.
06:55:26 <nhnt11> flo-retina: Have a nice day!
06:55:32 <flo-retina> thanks
06:55:51 <nhnt11> Thanks for the reviews
07:13:18 --> jb has joined #instantbird
07:48:02 --> gerard-majax__ has joined #instantbird
07:48:10 <-- jb has quit (Ping timeout)
07:54:27 <-- gerard-majax__ has quit (Ping timeout)
07:58:28 <-- nhnt11 has quit (Ping timeout)
07:59:16 --> nhnt11 has joined #instantbird
08:09:08 <-- nhnt11 has quit (Connection reset by peer)
08:10:51 --> nhnt11 has joined #instantbird
08:15:02 <-- nhnt11 has quit (Ping timeout)
08:15:11 * Fallen|away is now known as Fallen
08:15:17 --> nhnt11 has joined #instantbird
08:19:08 --> gerard-majax__ has joined #instantbird
08:22:17 <-- gerard-majax__ has quit (Ping timeout)
08:23:49 --> jb has joined #instantbird
08:35:30 <-- nhnt11 has quit (Ping timeout)
08:35:40 --> nhnt11 has joined #instantbird
08:37:47 <-- Mook has quit (Quit: Mook)
09:11:42 --> EionRobb has joined #instantbird
09:33:41 --> mpmc has joined #instantbird
09:43:34 --> gerard-majax__ has joined #instantbird
09:51:00 --> BWMerlin has joined #instantbird
10:01:18 <-- EionRobb has quit (Ping timeout)
10:26:53 <instantbot> New Instantbird - Other bug 1030059 filed by clokep@gmail.com.
10:26:55 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1030059 nor, --, ---, nobody, NEW, Passwords gone in newest nightly
10:29:26 --> clokep_work has joined #instantbird
10:30:29 * clokep_work is now known as IRCMonkey63314
10:31:58 <-- jb has quit (Ping timeout)
11:01:11 <-- IRCMonkey63314 has quit (Ping timeout)
11:04:37 --> jb has joined #instantbird
11:04:49 <sawrubh> mayanktg: ping
11:05:58 <sawrubh> mayanktg: you seem to have created a new directory for storing your xpcshell test (https://bug1018060.bugzilla.mozilla.org/attachment.cgi?id=8442898) is that the method that was agreed to?
11:06:04 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1018060 enh, --, ---, mayanktg, NEW, Video calls via XMPP/Jingle and WebRTC
11:11:12 <mayanktg> sawrubh: Yes.
11:11:30 <sawrubh> ok, then I'll place mine inside that too
11:11:34 <mayanktg> the test is created in the directory xmpp/test/
11:11:53 --> Rym has joined #instantbird
11:12:06 <sawrubh> yeah, I see that
11:18:48 <-- mayanktg has quit (Ping timeout)
11:34:07 --> Hadi has joined #instantbird
11:42:37 <-- flo-retina has quit (Ping timeout)
11:44:05 <-- BWMerlin has quit (Quit: BWMerlin)
11:45:34 --> clokep_work has joined #instantbird
11:45:34 * ChanServ sets mode +o clokep_work 
11:47:01 --> chrisccoulson has joined #instantbird
11:47:25 <sawrubh> seems like emulating a drag and drop using xpcshell might not be so straightforward
11:48:15 <nhnt11> sawrubh: You're writing UI tests? :S
11:48:21 <sawrubh> nhnt11: yes
11:48:30 <clokep_work> sawrubh: xpcshell isn't designed for UI tests IIRC.
11:48:38 <sawrubh> mochitest?
11:48:57 <clokep_work> sawrubh: I think we were more interested in tests for the XMPP code.
11:49:00 <clokep_work> Aloso, please answer my email.
11:49:03 <clokep_work> I'll beback soon.
11:49:05 * nhnt11 is surprised that you're writing UI tests
11:49:22 <nhnt11> (It's not something I've seen people asking for often on #instantbird)
11:50:20 <sawrubh> clokep_work: so in order to test the xmpp part of my patch, I need to initiate a transfer right?
11:50:51 <sawrubh> or I could simply test for the stanza sending I guess
11:51:23 <sawrubh> just ensure the right stanzas with the right properties come back when we send some specific stanzas
11:53:08 <clokep_work> Yes.
11:53:26 * clokep_work thinks nhnt11 isn't following the whole conversation. ;)
11:57:16 <nhnt11> :S
11:57:32 * nhnt11 shrugs
11:58:42 --> mayanktg-ph has joined #instantbird
12:05:31 <-- Hadi has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:11:42 --> mayanktg has joined #instantbird
12:28:26 --> Hadi has joined #instantbird
12:29:51 <-- jb has quit (Input/output error)
12:30:03 <sawrubh> so since the sender isn't fixed, I can't actually send the stanzas, I just need to fake sending a stanza....
12:30:10 --> jb has joined #instantbird
12:30:17 <sawrubh> which sounds weird to me
12:34:43 <-- mayanktg-ph has quit (Quit: )
12:37:17 <-- Hadi has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:39:24 <sawrubh> clokep_work: any ideas?
12:40:15 <sawrubh> hard coding the sender and receiver's address doesn't make sense to me
12:41:43 <-- Rym has quit (Ping timeout)
12:49:37 --> Rym has joined #instantbird
12:50:12 <nhnt11> sawrubh: Why not?
12:50:27 <nhnt11> Maybe I'm out of line but hard coding things is usually okay for tests
12:50:53 <nhnt11> (I hard coded conversation instances for the logging tests for example)
12:52:07 <sawrubh> so new profiles are created for each run, so I will have to sign into these jabber accounts and launch two instances of instantbird for sending the stanzas between them
12:59:25 <-- Rym has quit (Connection reset by peer)
12:59:57 --> Rym has joined #instantbird
13:22:49 <-- Rym has quit (Ping timeout)
13:31:57 --> Rym has joined #instantbird
13:32:18 --> iamjayakumars has joined #instantbird
13:37:55 --> rosonline has joined #instantbird
13:38:03 <-- Rym has quit (Ping timeout)
13:41:25 <-- iamjayakumars has quit (Client exited)
13:59:31 --> mconley has joined #instantbird
14:02:26 --> Rym has joined #instantbird
14:05:40 <clokep_work> sawrubh: I have no idea what oyu're asking about, I need context.
14:06:00 <-- Rym has quit (Ping timeout)
14:06:39 --> Rym has joined #instantbird
14:11:28 <-- Rym has quit (Ping timeout)
14:12:57 --> Rym has joined #instantbird
14:16:28 <-- Rym has quit (Ping timeout)
14:16:29 --> iamjayakumars has joined #instantbird
14:20:33 --> Rym has joined #instantbird
14:29:29 <-- Rym has quit (Ping timeout)
14:34:30 <clokep_work> sawrubh: You still here?
14:35:23 <-- rosonline has quit (Client exited)
14:48:39 --> Armada has joined #instantbird
14:54:01 <-- Armada has quit (Quit: Leaving)
14:54:18 * Fallen is now known as Fallen|away
14:54:41 --> Armada has joined #instantbird
14:59:08 --> Rym has joined #instantbird
15:24:07 <sawrubh> clokep_work: I was having dinner
15:24:24 <sawrubh> so I'm planning to write the test we had thought of writing
15:26:15 <sawrubh> now if I actually send the xmpp stanzas in the xpcshell test to check the responses then I'll need to hard code the jabber ID of the sender and the receiver, and their passwords and then open two instances of IB right?
15:26:45 <clokep_work> sawrubh: I'm confused at what you're suggesting. What do you mean by "actually"?
15:26:56 <clokep_work> And can you reword the goal of the xpcshell test to ensure we're on the same page.
15:27:51 --> flo-retina has joined #instantbird
15:27:51 * ChanServ sets mode +qo flo-retina flo-retina 
15:28:18 <sawrubh> ok, so I planned (before things became unclear) to write an xpcshell test, which would create a Stream Initiate stanza and send it to another instance running with a differnt jabber id
15:28:32 <sawrubh> and then see the response that I get on the sender is what I expect
15:29:09 <sawrubh> when I say "actually" I mean that we actually call sendStanza function
15:29:14 <clokep_work> sawrubh: You cannot depend on an external process running.
15:29:30 <clokep_work> sawrubh: You either need to "fake" it by hard coding strings and passing them into the proper functions or.
15:29:33 <sawrubh> otherwise the other approach could be like what mayanktg did, not call sendStanza and just
15:29:43 <clokep_work> Or set up a server (in the test) and pass between two instances.
15:29:54 <clokep_work> I'd suggest faking it, that's how most of our tests are done.
15:31:28 <sawrubh> if I am to fake it, the test seems pretty pointless, because it won't be a stanza then (I'll only keep the si element and remove the IQ stanza it's wrapped in)
15:31:31 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:31:56 <sawrubh> also my functions take a stanza so giving them a si element would do nothing
15:32:30 <clokep_work> sawrubh: If you think it's pointless you're most likely misunderstanding what we're trying to test.
15:32:37 <clokep_work> Which is an important aspect of writing a test. :-D
15:32:39 <-- Rym has quit (Ping timeout)
15:32:55 <sawrubh> or I could break my function to logic to take a stanza and then extract the si element out of it and do the processing on it, and then I could test the working of this second function (which processes the si element))
15:32:57 --> Rym has joined #instantbird
15:33:33 <clokep_work> sawrubh: So what are we trying to test?
15:33:38 <clokep_work> Specifically.
15:34:52 <sawrubh> (I think) we wanted to test whether when we send an IQ stanza with the stream initiation offer, we get a reply which looks correct
15:35:12 <sawrubh> as in having the right elements nested in the right manner, having the correct namespaces etc set on them?
15:35:41 <clokep_work> OK.
15:35:46 <clokep_work> So how would we do that?
15:37:37 <sawrubh> since my functions take a stanza, I would need to break my logic into two functions, one would take a stanza and then extract the si element out of it and call the second function to do the processing on the si element (http://xmpp.org/extensions/xep-0095.html#example-4)
15:37:46 <sawrubh> I could test this second function only in that case
15:39:19 <sawrubh> am I thinking in the wrong way?
15:40:37 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:42:39 <clokep_work> Why can't you send the whole stanza in?
15:46:20 <sawrubh> because sending a stanza will require me to set the from and to fields and someone needs to be listening to that, what happens right now is that I send a initiation request and add a callback to that particular ID in the stanza, then the receiver replies to this initiation request and then replies which the callback then responds to
15:47:11 <sawrubh> if I'm faking it, then I would be able to test this callback function only
15:51:08 <sawrubh> unrelated: where is LOG defined, I've tried using this.LOG but it isn't able to find it, I've tried including imXPCOMUtils.jsm but it doesn't seem to defined there
15:54:16 <clokep_work> sawrubh: You have to initialize a logger, xmpp.jsm should do it.
15:54:27 <clokep_work> sawrubh: OK, so you won't be sending anything over a network for this test, is that clear?
15:54:43 <sawrubh> yes, I won't send anything over the network, that much is clear to me
15:54:44 <clokep_work> You should be hard coding the to/from fields.
15:54:58 <clokep_work> I don't understand "someone needs to be listening to that"
15:55:19 <-- nhnt11 has quit (Ping timeout)
15:55:30 <sawrubh> I meant to say, the receiver (the to field should be online) only then will it reply to my iq stanza
15:55:31 <clokep_work> So one test is this: You all the function that generates a request and test that it matches what is expected.
15:55:52 <clokep_work> A separate test is that when you receive a request you respond appropriate.
15:55:55 <clokep_work> YOu won't be testing it all at once.
15:55:58 <clokep_work> It's two separate tests.
15:56:24 --> nhnt11 has joined #instantbird
15:58:20 <-- gerard-majax__ has quit (Ping timeout)
15:58:46 <clokep_work> sawrubh: To be more specific, call sendInitiatorRequest and then check that sendStanza receives the expected string.
16:01:13 * sawrubh checks how to intercept the argument of sendStanza
16:03:12 <clokep_work> I do it in one of the IRC tests
16:05:02 * sawrubh checks that
16:17:00 <-- Rym has quit (Ping timeout)
16:19:00 <-- jb has quit (Ping timeout)
16:20:27 --> Rym has joined #instantbird
16:48:02 --> Mook_as has joined #instantbird
16:53:47 <clokep_work> sawrubh: https://mxr.mozilla.org/comm-central/source/chat/protocols/irc/test/test_ctcpQuote.js seems to do it
16:54:42 <sawrubh> I searched all the files but couldn't find it, moved on to something else, thanks
16:55:04 <-- iamjayakumars has quit (Ping timeout)
16:55:22 <-- Rym has quit (Ping timeout)
16:55:22 --> iamjayakumars has joined #instantbird
16:57:18 --> Rym has joined #instantbird
16:59:23 <-- Rym has quit (Ping timeout)
17:02:27 --> Rym has joined #instantbird
17:08:08 <sawrubh> I wonder where does Services object become available in conversation.xml, I don't see it included anywhere
17:08:18 <sawrubh> its there in the global scope
17:10:09 <nhnt11> sawrubh: Cu.import("resources:///modules/imServices.jsm")
17:10:16 <nhnt11> oh
17:10:19 <nhnt11> sorry
17:10:40 <nhnt11> sawrubh: Check instantbird.xul/instantbird.js
17:11:10 <nhnt11> sawrubh: If Services is in the window, conversation.xml can access it
17:11:12 <sawrubh> but instantbird.js isn't included anywhere in conversation.xml
17:11:29 <nhnt11> sawrubh: conversation.xml goes in the window, which is instantbird.xul
17:11:37 <nhnt11> /That/ includes instantbird.js
17:11:39 <sawrubh> ok
17:11:55 <nhnt11> makes sense?
17:12:15 <nhnt11> it appears instantbird.js doesn't include it either though
17:12:40 <nhnt11> Ah, it's in utilities.js
17:12:42 <nhnt11> which is included
17:24:23 <clokep_work> Hahah.
17:24:25 <clokep_work> Confusing!
17:33:15 <-- Rym has quit (Ping timeout)
17:33:23 <-- Tonnes has quit (Quit: ChatZilla [Firefox 30.0/20140605174243])
17:34:41 --> Rym has joined #instantbird
17:41:21 * Fallen|away is now known as Fallen
18:12:09 <-- iamjayakumars has quit (Quit: )
18:44:37 <-- Rym has quit (Ping timeout)
18:54:24 --> gerard-majax__ has joined #instantbird
19:18:21 <-- mayanktg has quit (Client exited)
19:22:03 --> mayanktg has joined #instantbird
20:03:06 <-- mayanktg has quit (Ping timeout)
20:03:12 --> EionRobb has joined #instantbird
20:04:56 --> mayanktg-ph has joined #instantbird
20:05:28 --> mayanktg has joined #instantbird
20:27:53 --> Rym has joined #instantbird
20:33:11 --> mpmc has joined #instantbird
20:39:41 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:40:10 <-- clokep_work has quit (Ping timeout)
21:04:56 <-- mayanktg has quit (Client exited)
21:23:11 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
21:24:03 --> chrisccoulson has joined #instantbird
21:30:41 <-- mconley has quit (Input/output error)
21:35:42 --> EionRobb1 has joined #instantbird
21:36:48 <-- EionRobb has quit (Ping timeout)
21:59:00 --> mconley has joined #instantbird
21:59:01 <-- mconley has quit (Input/output error)
22:07:53 <-- Even has quit (Ping timeout)
22:18:38 <-- Rym has quit (Ping timeout)
22:24:17 --> Rym has joined #instantbird
22:40:01 * Fallen is now known as Fallen|away
22:44:03 <-- mayanktg-ph has quit (Ping timeout)
22:44:03 <-- sawrubh has quit (Ping timeout)
22:49:44 <-- Armada has quit (Connection reset by peer)
22:50:17 --> sawrubh has joined #instantbird
22:51:36 --> wnayes has joined #instantbird
22:53:07 <-- sawrubh has quit (Ping timeout)
22:53:50 --> sawrubh has joined #instantbird
22:57:50 <-- sawrubh has quit (Ping timeout)
23:05:27 <-- Rym has quit (Ping timeout)
23:11:09 --> Rym has joined #instantbird
23:14:35 --> sawrubh has joined #instantbird
23:21:24 --> clokep_work has joined #instantbird
23:21:24 * ChanServ sets mode +o clokep_work 
23:22:22 --> clokep has joined #instantbird
23:36:43 <-- clokep_work has quit (Ping timeout)
23:47:51 <-- Rym has quit (Ping timeout)
23:49:34 --> Rym has joined #instantbird
23:49:48 <-- Rym has quit (Connection reset by peer)
23:50:05 --> Rym has joined #instantbird