#instantbird log on 06 24 2014

All times are UTC.

00:01:02 <-- arlolra has quit (Quit: arlolra)
00:16:19 --> clokep_work has joined #instantbird
00:16:19 * ChanServ sets mode +o clokep_work 
00:16:48 <-- mconley has quit (Input/output error)
00:21:29 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
00:32:56 <-- Rym has quit (Ping timeout)
00:35:03 --> Rym has joined #instantbird
00:39:14 <-- xangua has quit (Quit: Connection closed for inactivity)
00:42:53 <-- wnayes has quit (Ping timeout)
00:43:46 <-- Rym has quit (Ping timeout)
00:46:05 --> wnayes has joined #instantbird
00:56:20 --> mconley has joined #instantbird
01:05:25 <-- Mook_as has quit (Quit: Mook_as)
01:13:10 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
01:13:23 <-- mconley has quit (Ping timeout)
01:13:26 --> Rym has joined #instantbird
01:16:10 --> mconley has joined #instantbird
01:20:00 <-- mconley has quit (Input/output error)
01:22:09 <-- wnayes has quit (Ping timeout)
01:23:52 --> nhnt11-phone has joined #instantbird
01:24:22 <nhnt11-phone> The tests passed :)
01:24:36 <nhnt11-phone> Looks like that's all set then..
01:24:41 <-- nhnt11-phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
01:45:54 <-- clokep has quit (Ping timeout)
02:31:04 <-- Rym has quit (Ping timeout)
03:29:42 --> gerard-majax__ has joined #instantbird
03:35:01 --> mconley has joined #instantbird
03:42:58 <-- gerard-majax__ has quit (Ping timeout)
03:58:41 --> gerard-majax__ has joined #instantbird
04:09:01 <-- gerard-majax__ has quit (Ping timeout)
04:09:19 <-- mconley has quit (Input/output error)
04:21:05 <instantbot> New Instantbird - Other bug 1029330 filed by kantsuris@gmail.com.
04:21:06 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1029330 nor, --, ---, nobody, UNCO, no start on windows 7 x64 - not icuin52.dll
04:48:21 --> gerard-majax__ has joined #instantbird
04:56:24 <-- gerard-majax__ has quit (Ping timeout)
05:02:55 --> jb has joined #instantbird
05:04:56 --> gerard-majax__ has joined #instantbird
05:09:37 <-- gerard-majax__ has quit (Ping timeout)
05:10:34 --> gerard-majax__ has joined #instantbird
05:22:35 <-- gerard-majax__ has quit (Ping timeout)
05:34:07 <-- jb has quit (Ping timeout)
05:38:57 --> gerard-majax__ has joined #instantbird
05:50:52 <-- gerard-majax__ has quit (Ping timeout)
06:21:25 --> iLobster has joined #instantbird
06:23:28 <iLobster> Greetings.
06:23:46 <iLobster> Confirm bug 1029330 - after today nightly update Instanbird do not start with error about icuin52.dll missing.
06:23:48 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1029330 nor, --, ---, nobody, UNCO, no start on windows 7 x64 - not icuin52.dll
06:25:09 <-- iLobster has quit (Quit: ChatZilla [Firefox 30.0/20140605174243])
06:26:20 --> gerard-majax__ has joined #instantbird
06:30:50 --> iLobster has joined #instantbird
06:31:43 <iLobster> and there are also icuin52.dll and icudt52.dll missing errors too
06:38:54 <iLobster> hmm... and after i copied those files from Firefox installation to Instantbird installation - my Accounts window say that i need to enter passwords to my accounts
06:39:50 <iLobster> so me moving back to version 1.6a1pre (20140503041623)
06:44:12 * Fallen|away is now known as Fallen
06:52:30 --> mpmc has joined #instantbird
07:20:43 --> nhnt11-tb has joined #instantbird
07:21:22 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
07:21:39 <nhnt11> flo-retina: I've uploaded new patches on bug 955292. Straightforward changes I think.
07:21:42 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955292 enh, --, ---, nhnt11, ASSI, Read/write chat logs asynchronously
07:21:59 <nhnt11> flo-retina: What do you think about using the status indicator dots from Thunderbird? They have retina sized ones ;)
07:24:05 --> nhnt11-tb has joined #instantbird
07:24:55 <-- flo-retina has quit (Ping timeout)
07:24:59 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
07:25:02 --> nhnt11-tb has joined #instantbird
07:29:41 <nhnt11> Hmm, can't find that icon anywhere
07:30:36 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
07:33:11 <nhnt11> bbl, lunch
08:43:26 <-- iLobster has quit (Quit: ChatZilla [Firefox 30.0/20140605174243])
08:56:16 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
08:56:39 --> chrisccoulson has joined #instantbird
08:57:38 --> flo-retina has joined #instantbird
08:57:38 * ChanServ sets mode +qo flo-retina flo-retina 
08:58:06 <flo-retina> nhnt11: To put them where?
09:03:37 --> mayanktg has joined #instantbird
09:03:42 <flo-retina> clokep, iLobster: I've stopped the update to the 2 newest Windows nightly
09:08:24 --> aleth has joined #instantbird
09:08:24 * ChanServ sets mode +o aleth 
09:09:52 <-- aleth has quit (Quit: exit stage left)
09:09:54 --> aleth has joined #instantbird
09:09:54 * ChanServ sets mode +o aleth 
09:16:32 * aleth wonders if all those new Windows bugs mean we have Windows nighties again
09:16:57 <nhnt11> flo-retina: On conversation headers for example
09:17:06 <nhnt11> Wherever we have status indicator dots now... :S
09:17:21 <nhnt11> aleth: There was a new nightly yesterday :)
09:17:28 <aleth> :)
09:18:56 <aleth> nhnt11: Before I look at the logs, so the state of play with async logs is that you think you found the problem, but the tree is still busted so you can't try it?
09:19:18 <flo-retina> aleth: there was one today too
09:19:24 <nhnt11> aleth: Pushed to try again yesterday with debug dumps, found the issue, fixed it, uploaded new patches :)
09:19:25 <flo-retina> the problem is... apparently it doesn't start :-D
09:19:32 <aleth> nhnt11: great :)
09:19:51 <flo-retina> any help with that windows issue would be appreciated
09:19:58 <aleth> I guess it would have been too much to hope for no regressions after all this time :-S
09:21:26 <flo-retina> indeed
09:21:40 <flo-retina> but a "we updated everybody to a build that doesn't start" regression is kinda bad :(
09:22:01 <aleth> yes :-/
09:23:57 <-- mayanktg has quit (Ping timeout)
09:24:22 --> mayanktg has joined #instantbird
09:47:36 --> BWMerlin has joined #instantbird
09:57:57 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:03:29 <-- aleth has quit (Ping timeout)
10:21:46 --> clokep has joined #instantbird
10:21:46 * ChanServ sets mode +o clokep 
10:22:44 <-- EionRobb has quit (Quit: Leaving.)
10:24:18 <clokep> flo-retina: Thanks.
10:26:27 --> flo-retina has joined #instantbird
10:26:27 * ChanServ sets mode +qo flo-retina flo-retina 
10:26:41 <clokep> sawrubh: Ping
10:27:01 <clokep> flo-retina: Any thoughts on how to fix the Windows stuff? DO a diff of package-manifest.in?
10:27:15 <flo-retina> clokep: you can try that, yes :)
10:27:19 <flo-retina> diff it with the Tb one
10:29:38 --> aleth has joined #instantbird
10:29:38 * ChanServ sets mode +o aleth 
10:29:43 <clokep> http://pastebin.instantbird.com/741079
10:29:47 <clokep> For whoever has time to look
10:30:03 <clokep> IB is -, TB is +
10:30:20 <aleth> ooh, does that fix the Windows issues? :)
10:30:25 <clokep> Looks like the MOZ_NATIVE_ICU and MOZ_SHARED_ICU changes.
10:30:26 <flo-retina> clokep: excellent, thanks! :)
10:30:31 <clokep> aleth: It's just a diff.
10:30:43 <clokep> Lines 93 - 109
10:30:59 <flo-retina> I think we could also take the #ifndef MOZ_FOLD_LIBS change
10:31:04 <flo-retina> sounds like it would be useful in the future :)
10:31:10 <flo-retina> or maybe port that separately
10:31:54 <flo-retina> I wonder why the #ifndef MOZ_DEBUG is removed
10:33:13 <flo-retina> there are plenty of other changes we should take :-/
10:33:34 * flo-retina would really like to get rid of most of that file
10:34:01 <flo-retina> I think we should have a separate toolkit file that would be included by both Firefox and Tb, so that we could just include it too
10:37:36 <flo-retina> bah, the fix was made for mail/ and suite/ but not im/ :( http://hg.mozilla.org/comm-central/rev/fd35deed885d
10:37:37 <clokep> flo-retina: I don't have time to do any right now. I need to get to work to do a demo.
10:37:42 <clokep> But I'm willing to r+ anything. ;)
10:37:53 <flo-retina> clokep: I assume r=bustage fix could also do ;)
10:38:01 <clokep> flo-retina: Sure. :)
10:38:16 <clokep> I'd probably have time to push an untested patch late morning too.
10:38:45 <nhnt11> aleth: Btw I marked the new patch as r? florian, but feel free to steal it if you've got a minute, simple changes :)
10:39:05 <flo-retina> nhnt11: can we just look at the interdiff?
10:39:09 <nhnt11> flo-retina: Yes
10:39:26 <nhnt11> A couple of lines.
10:40:03 <aleth> nhnt11: I can take a look in a couple of minutes
10:40:11 <nhnt11> No big hurry, tree is still closed :]
10:40:49 <nhnt11> Are we getting that exception for pushing changes that only affect im/ btw?
10:41:39 <flo-retina> nhnt11: your changes affect chat, don't they?
10:41:41 <aleth> nhnt11: Looks like it
10:41:49 <nhnt11> flo-retina: Yes, it was a general question
10:41:51 <aleth> It wouldn't help you here though.
10:42:03 <nhnt11> Right, I was just curious
10:42:08 <aleth> Huh, laggy today.
10:42:48 * nhnt11 wants to get these try patches out of his queue
10:43:03 <flo-retina> nhnt11: we could still ask for approval for that change
10:43:07 <nhnt11> (I currently have one that adds the debug dumps, and one that undoes them, and it irks my ocd :])
10:44:43 <mayanktg> flo-retina: You mentioned that |#changeUserIconPanel > .panel-arrowcontainer > .panel-arrowcontent| in the CSS is duplicated. But when I remove it again margin appears in the panel. How to fix that.? :-o
10:45:03 <clokep> flo-retina: Standard8 kind of seemed to apply we can push IM only changes w/o approval, but that's a little sketchy. :)
10:45:24 <flo-retina> clokep: yeah, and?
10:45:41 <flo-retina> clokep: I'm saying we should request approval from Standard8 for nhnt11's patch. Are you saying something different?
10:45:43 <aleth> clokep: I just need to update my patch and get r+ and it will be possible.
10:46:01 * aleth thinks we are talking about different things at once
10:46:16 <flo-retina> mayanktg: The "duplicated" comment is because you have 2 rules that set padding and margin to 0 next to each other
10:46:18 <clokep> flo-retina: Sorry, I thought we were talking about package-manifest stuff.
10:47:30 <flo-retina> clokep: I'm about to land http://pastebin.instantbird.com/741080
10:48:20 <mayanktg> flo-retina: Oh ok. :)
10:49:35 <clokep> Looks reasonable.
10:53:52 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
10:54:13 <flo-retina> mayanktg: I think we should get https://bugzilla.mozilla.org/show_bug.cgi?id=1004930#c12 moving too. Could you answer my comments there, and (if needed) update the patch. I could potentially steal that review from Mic tomorrow.
10:54:16 <instantbot> Bug 1004930 enh, --, ---, nobody, NEW, Generic way to add buttons for actions to a conversation
10:56:10 <mayanktg> flo-retina: yeah sure. I was going to just say that. I'll answer your comments and update the patch too. Also mention what changes I need to do make the target swticher function properly.
10:59:33 <mayanktg> flo-retina: Here's the interdiff of the changes I've made in the user icon bug http://pastebin.instantbird.com/741093 .
11:04:49 <nhnt11> Status update: I've nearly got the two-table design working. After that I'm going to add proper error handling, clean up the UI modifications, and hopefully upload a patch by bedtime.
11:05:35 <-- aleth has quit (Ping timeout)
11:09:40 --> aleth has joined #instantbird
11:09:40 * ChanServ sets mode +o aleth 
11:28:56 <aleth> nhnt11: So re the logger.js change, the issue was that DailyEnumerators sorted the entries, but LogEnumerators didn't?
11:29:22 <nhnt11> aleth: Sort of, yeah.
11:29:42 <nhnt11> The reason I didn't detect it is because the entries returned by DirectoryIterator were already in order
11:29:47 <nhnt11> (on OS X)
11:29:48 <aleth> Yes, makes sense.
11:29:52 <nhnt11> rather, on my machine*
11:30:05 <aleth> I guess the tests paid off already then ;)
11:30:13 <nhnt11> I just asked Yoric on #perf whether the order is predictable at all.
11:30:16 <nhnt11> yeah, quite
11:30:32 <nhnt11> aleth: I found another issue in the test itself, while searching for the reason for failure :)
11:30:40 <nhnt11> (the yield logWriter._initialized thing)
11:33:34 <flo-retina> mayanktg: line 37 in that pastebin isn't correct
11:34:59 <nhnt11> Can you use a constructor to specify the default value of an argument? Anyone know off the top of their head?
11:35:00 --> clokep_work has joined #instantbird
11:35:00 * ChanServ sets mode +o clokep_work 
11:35:13 <flo-retina> mayanktg: do you no longer need the "margin: 0" at line 124?
11:35:18 <clokep_work> nhnt11: Yes
11:35:21 <clokep_work> It's just a function.
11:35:21 <nhnt11> (something like function foo (aBar = new FooBar()) { ...})
11:35:26 <nhnt11> clokep_work: Thanks.
11:35:34 <clokep_work> nhnt11: Wait, what... (o_O)
11:35:44 <nhnt11> Uh.
11:35:52 <clokep_work> Generating a new object in there is something I think we try to avoid, but talk to your reviewer.
11:36:06 <mayanktg> flo-retina: You said that |webcamStream = null| was as ineffective as using |delete webcamStream| . What should I use then instead? 
11:36:08 <nhnt11> Alright. It's just an idea for now.
11:36:21 <flo-retina> mayanktg: what did I say in my previous comment?
11:38:57 <mayanktg> flo-retina: uhh...ok ... I need to use |video.mozSrcObject = null| instead of |webcamStream = null| :S
11:39:09 <flo-retina> exactly!
11:39:26 <flo-retina> :)
11:40:19 <aleth> nhnt11: I don't understand the yield on _initialized. Why isn't yielding on the last file operation on that path enough?
11:40:42 <mayanktg> I was deleting the local variable only, and was happy about it :-/
11:41:25 <nhnt11> aleth: give me a second
11:42:11 <nhnt11> aleth: https://bugzilla.mozilla.org/attachment.cgi?id=8445003&action=diff#a/chat/components/src/logger.js_sec4
11:42:16 <nhnt11> Look at line 230
11:42:24 <nhnt11> We do the queuing in _initialized.then()
11:42:29 <aleth> Yes
11:42:36 <nhnt11> So before yielding on _initialized, the appends haven't been queued at all
11:42:48 <aleth> Oh, I see.
11:43:02 <aleth> Thanks.
11:43:11 <nhnt11> This behavior is fine from the POV of logger.js, I didn't want to change it for the sake of the test
11:43:18 <aleth> Right.
11:43:34 <mayanktg> flo-retina: After removing the |margin: 0| part from line 124 there is no margins left in case of Linux. So I think we won't need margin: 0 here.
11:43:43 <nhnt11> aleth: Hmm, do you think the comment needs improvement?
11:44:06 <nhnt11> "The file I/O is queued only after initialization completes, so we need to yield on that first" maybe?
11:46:08 <aleth> Maybe s/the file IO/writing the message logs ?
11:47:17 <nhnt11> Hmm ok. Your call, I'm ok with anything.
11:47:36 <aleth> I got confused because writing the header is also file i/o ;)
11:47:52 <nhnt11> Ah!
11:48:00 <nhnt11> alright
11:48:01 <aleth> So if you improve the comment to reflect that, I'm happy with it.
11:48:17 <nhnt11> Sure. Thanks for the reviews!
11:48:26 <aleth> Let's hope the tree opens soon.
11:53:06 <aleth> flo-retina: Ping reminder to push bug 976083 when you get a chance.
11:53:09 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=976083 nor, --, ---, aleth, ASSI, Update FAQ to include required libraries for newer 64b Ubuntus
11:54:18 --> mikk_s has joined #instantbird
12:00:20 <nhnt11> :O
12:00:34 * nhnt11 found a high resolution version of the IRC prpl icon
12:00:50 <nhnt11> (http://www.instantbird.com/about.html)
12:07:34 <-- mikk_s has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
12:07:36 <clokep_work> nhnt11: Is that useful in some way?
12:07:42 --> Rym has joined #instantbird
12:08:06 <nhnt11> clokep_work: For retina displays maybe? I suppose there exists an svg somewhere though
12:12:39 <clokep_work> nhnt11: Oh, OK. I thought you wanted a larger version somewhere.
12:16:57 <flo-retina> nhnt11: I have the SVG files for most of the PNGs we use
12:17:00 <flo-retina> "somewhere"
12:17:17 <-- BWMerlin has quit (Quit: BWMerlin)
12:17:31 <flo-retina> aleth: I think you can just push changes to the website repo yourself
12:17:52 <flo-retina> how that propagates to the online website isn't clear (even to me)
12:20:24 <clokep_work> I think we didn't usually do that because of translators?
12:20:32 <clokep_work> We somehow had it grouped w/ releases
12:20:39 <aleth> flo-retina: When I push I get "HTTP Error 405: push requires POST request"
12:20:50 <flo-retina> what's the URL you are pushing to?
12:21:07 <aleth> http://hg.instantbird.org/websites/www.instantbird.com/
12:21:15 <flo-retina> aleth: change that to https
12:22:03 <aleth> Ah OK, now it's more reasonable, saying "authorization required"
12:22:46 <aleth> Which I don't have, for instantbird.org
12:25:57 <aleth> So maybe you can push it for me ;)
12:26:18 <-- mayanktg has quit (Ping timeout)
12:27:23 --> mayanktg has joined #instantbird
12:27:52 <flo-retina> aleth: have you tried reproducing bug 788137 recently?
12:27:54 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=788137 nor, --, ---, nobody, UNCO, Nick for XMPP chatrooms becomes 'null'
12:28:04 <aleth> flo-retina: No.
12:28:16 <flo-retina> aleth: if you were authorized for the addons/experiment/whatever we called that repo, you are authorized for the website
12:28:30 <aleth> I wasn't though, I never used that repo.
12:29:22 <nhnt11> flo-retina: The sqlite3 shell lists views as well when I ask for a list of tables. Just confirming, this is standard behavior right? Doing tableExists() on a view should work?
12:30:11 <nhnt11> (if you don't know off the top of your head, I'll write a scratchpad snippet)
12:31:26 <flo-retina> I don't know :)
12:32:33 <nhnt11> Uh
12:32:36 <nhnt11> looks like it doesn't work
12:32:56 <nhnt11> (tableExists() on a view returns false)
12:36:12 <instantbot> florian@queze.net changed the Resolution on bug 1029330 from --- to FIXED.
12:36:13 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1029330 blo, --, 1.6, florian, RESO FIXED, no start on windows 7 x64 - not icuin52.dll
12:36:27 <flo-retina> nhnt11: what are you actually trying to do?
12:36:51 <nhnt11> flo-retina: At this point, I guess just an exercise to figure out how stuff works 
12:36:56 <nhnt11> I was checking at one point if a table exists
12:37:05 <nhnt11> As a way to determine if I need to index everything again
12:37:14 <nhnt11> Now I'm just removing the db and re-indexing everything
12:37:22 <nhnt11> (when I need to -which will be decided by a pref)
12:37:39 <flo-retina> would using the schema version help?
12:38:06 <nhnt11> Yeah, I thought of that. Wanted to check it out later once this is working
12:38:15 <nhnt11> (as a substitute for a pref)
12:38:24 <clokep_work> flo-retina: Thanks. :)
12:38:26 <nhnt11> I guess it would then be similar to the stats cache version stuff
12:39:52 <nhnt11> flo-retina: That can be added in a follow-up though right? for now, I can just index everything if the db doesn't exist.
12:39:59 <instantbot> New Instantbird - Conversation bug 1029501 filed by florian@queze.net.
12:40:01 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1029501 min, --, ---, nobody, NEW, Opening the awesometab and then pressing Escape should return to the previous conversation
12:40:14 <flo-retina> nhnt11: I guess.
12:40:21 <-- Rym has quit (Client exited)
12:40:21 <nhnt11> That's an interesting bug ^
12:40:27 <flo-retina> nhnt11: I'm not fully focused on what you are saying; so do what makes sense
12:40:28 --> Rym has joined #instantbird
12:40:33 <nhnt11> ok
12:40:48 <flo-retina> nhnt11: I'm frequently annoyed by that bug
12:40:54 <aleth> It sounds reasonable (if I understand correctly)
12:40:57 <flo-retina> I guess it's the first time I file it instead of complaining
12:41:02 <nhnt11> flo-retina: Thanks for filing it, I'll try to fix it soon
12:41:18 <flo-retina> or if it's not Mic will dupe it soon :-D
12:41:51 <flo-retina> clokep_work: I retriggered a Windows nightly
12:42:06 <flo-retina> would be nice if someone could verify that it starts as soon as it's finished building
12:47:29 <clokep_work> flo-retina: Thanks.
12:47:36 <clokep_work> I can download it and ensure it starts, but not that it connects. :P
12:47:52 <flo-retina> clokep_work: that's enough to verify the bug is fixed, right? :)
12:48:20 <clokep_work> Yes
12:48:46 <clokep_work> There's no way to like email me when it's done automatically, right?
12:50:09 <flo-retina> I get an email for all finished buildbot jobs
12:50:12 <flo-retina> but that's spammy
12:51:55 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:53:24 <clokep_work> I didn't say all! :P
12:53:38 * clokep_work wonders where instant-buildbot went?
12:53:51 <flo-retina> that's a good question to ask Even I guess ;)
12:53:53 * nhnt11 totally forgot that instant-buildbot existed
12:54:23 <flo-retina> maybe a buildbot restart would be enough to revive it
12:54:34 <flo-retina> (but a restart cancels all in-progress builds; so not an awesome idea right now)
13:02:10 <clokep_work> Definitely not. :)
13:18:58 <-- aleth_web has quit (Quit: Connection closed for inactivity)
13:29:24 <-- aleth has quit (Ping timeout)
13:29:47 --> aleth has joined #instantbird
13:29:47 * ChanServ sets mode +o aleth 
13:30:27 --> rosonline has joined #instantbird
13:35:14 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:50:36 <rosonline> Hi everbody
13:50:54 <rosonline> Any news about the translation things?
13:51:07 <clokep_work> What about them? :-S
13:51:15 <clokep_work> I.e. is there something wrong I should be tracking?
13:53:01 <-- Rym has quit (Ping timeout)
13:53:26 --> Rym has joined #instantbird
13:55:38 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:59:45 --> flo-retina has joined #instantbird
13:59:45 * ChanServ sets mode +qo flo-retina flo-retina 
14:03:17 <-- aleth has quit (Ping timeout)
14:04:34 <-- gerard-majax__ has quit (Ping timeout)
14:15:33 <mayanktg> flo-retina: How to get that different color for the elements on the DOMi you once showed me for the user icon panel? :-o
14:27:14 --> mconley has joined #instantbird
14:36:13 --> Armada has joined #instantbird
14:39:05 --> gerard-majax__ has joined #instantbird
14:45:27 <-- gerard-majax__ has quit (Ping timeout)
14:47:43 --> gerard-majax__ has joined #instantbird
14:52:23 <-- gerard-majax__ has quit (Ping timeout)
15:05:25 --> clokep_work has joined #instantbird
15:05:25 * ChanServ sets mode +o clokep_work 
15:08:03 --> gerard-majax__ has joined #instantbird
15:20:30 <-- gerard-majax__ has quit (Ping timeout)
15:49:32 --> arlolra has joined #instantbird
15:55:12 <-- nhnt11 has quit (Ping timeout)
15:56:03 --> nhnt11 has joined #instantbird
16:04:42 <flo-retina> mayanktg: using the "DOM Node" view, right click, "insert" and then type "style" "background: red"
16:04:51 <flo-retina> and change the color for each element you want to look at
16:06:32 <mayanktg> Nice :)
16:12:00 --> jb has joined #instantbird
16:14:03 <-- flo-retina has quit (Ping timeout)
16:16:14 <mayanktg> http://i.imgur.com/d7f4uWJl.jpg :)
16:24:37 --> iamjayakumars has joined #instantbird
16:27:03 --> flo-retina has joined #instantbird
16:27:03 * ChanServ sets mode +qo flo-retina flo-retina 
16:31:09 <-- mayanktg has quit (Ping timeout)
16:32:25 --> mayanktg has joined #instantbird
16:41:40 <-- Rym has quit (Ping timeout)
16:42:45 <-- jb has quit (Quit: jb)
16:46:23 <-- rosonline has quit (Client exited)
16:46:57 --> Mook_as has joined #instantbird
16:51:00 --> jb has joined #instantbird
17:04:09 <-- jb has quit (Ping timeout)
17:05:29 --> jb has joined #instantbird
17:12:55 <-- jb has quit (Ping timeout)
17:27:49 <-- flo-retina has quit (Ping timeout)
17:28:37 --> qheaden has joined #instantbird
17:28:48 --> jb has joined #instantbird
17:29:31 <-- iamjayakumars has quit (Client exited)
17:30:42 <-- mayanktg has quit (Ping timeout)
17:31:19 <-- jb has quit (Ping timeout)
17:31:37 --> jb has joined #instantbird
17:31:53 --> mayanktg has joined #instantbird
17:33:12 --> flo-retina has joined #instantbird
17:33:13 * ChanServ sets mode +qo flo-retina flo-retina 
17:34:39 <-- mayanktg has quit (Ping timeout)
17:35:54 <-- mconley has quit (Ping timeout)
17:36:16 --> mayanktg has joined #instantbird
17:36:22 --> mconley has joined #instantbird
17:37:36 * nhnt11 feels like some of the stuff mayanktg is working with needs promises :(
17:37:55 <nhnt11> Like that code snippet on the latest blog post... 3 nested callbacks :-/
17:39:32 <-- jb has quit (Ping timeout)
17:39:58 <flo-retina> nhnt11: what is that code doing?
17:39:59 <mayanktg> nhnt11: Could you detail a bit because I'm using alike nested callbacks for creating "answer" too. I can improve upon it.
17:40:30 <nhnt11> flo-retina: I didn't look closely, but it seems like async stuff with callbacks. I'm not saying mayanktg can do anything about it
17:40:52 <mayanktg> flo-retina: http://mayanktg.github.io/and-first-xmpp-video-call-was-made/ That method is creating an SDP offer. 
17:45:00 --> jb has joined #instantbird
18:11:37 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
18:21:27 <-- jb has quit (Ping timeout)
18:21:44 --> jb has joined #instantbird
18:23:07 --> Rym has joined #instantbird
18:46:52 <mayanktg> flo-retina: I'll update the generic buttons patch in about 15min. You can take a look at it then.
18:58:30 <-- clokep_work has quit (Ping timeout)
19:09:21 --> clokep_work has joined #instantbird
19:09:21 * ChanServ sets mode +o clokep_work 
19:10:18 <nhnt11> Alright, so I've been doing quite a bit of refactoring and the patch isn't ready for review yet, but I'll request f? before bed.
19:18:56 <nhnt11> flo-retina, clokep_work: If I set a pref in both chat-prefs.js and all-instantbird.js, which one overrides the other?
19:19:38 <clokep_work> nhnt11: Don't.
19:19:47 <nhnt11> clokep_work: So set the prefs separately in mail/ and im/ ?
19:19:58 <nhnt11> ok
19:20:15 <clokep_work> nhnt11: Yes.
19:20:29 <clokep_work> It doesn't make sense otherwise. :)
19:23:01 * nhnt11 is doing a self review
19:23:56 <nhnt11> flo-retina: By the way, I think we should wait on all the file I/O promises during async shutdown
19:24:27 <-- jb has quit (Ping timeout)
19:24:28 <nhnt11> Maybe I should add that before we land async logging
19:24:47 <nhnt11> s/Maybe//
19:32:27 <-- Rym has quit (Ping timeout)
19:34:22 <flo-retina> nhnt11: Isn't OS.File already waiting for all pending file I/O during shutdown?
19:34:43 <nhnt11> flo-retina: The promise queue in logger.js hasn't actually queued OS.File operations yet
19:34:47 <nhnt11> Um.
19:34:51 <nhnt11> That was a bad sentence
19:34:59 <flo-retina> nhnt11: all-instantbird.js overrides chat-prefs.js
19:35:17 <flo-retina> nhnt11: default pref files are read in reverse-alphabetical order
19:35:21 --> Rym has joined #instantbird
19:35:58 <flo-retina> nhnt11: ah, in that case yes, you need to deal with asyncShutdown
19:35:58 <nhnt11> flo-retina: What I meant was, the promise queue in logger.js stores something like |() => OS.File.foo(bar)|
19:36:04 <nhnt11> yeah
19:36:15 <nhnt11> Should be straight forward, I've been reading up on it
19:36:26 <flo-retina> yep
19:36:36 <nhnt11> flo-retina: Thanks, so I think I should pref it off by default in chat-prefs.js, and enable it in all-instantbird.js
19:36:50 <nhnt11> (indexing I mean)
19:37:07 <nhnt11> It doesn't feel right to not have it at all in chat-prefs.js
19:37:50 <flo-retina> you could also handle in the code that the pref not existing means it's preff'ed off
19:37:58 <flo-retina> I don't mind either way
19:38:33 <flo-retina> nhnt11: btw, the reverse alphabetical sort is the reason for the "all-" prefix ;)
19:39:37 <nhnt11> Ah, now it makes sense :D
19:39:51 <nhnt11> Thanks
19:44:03 <-- clokep_work has quit (Ping timeout)
19:49:46 --> clokep_work has joined #instantbird
19:49:46 * ChanServ sets mode +o clokep_work 
19:54:05 --> EionRobb has joined #instantbird
20:02:04 <nhnt11> flo-retina: Feel free to steal the review on bug 955292 if you've got a minute
20:02:07 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955292 enh, --, ---, nhnt11, ASSI, Read/write chat logs asynchronously
20:02:38 <nhnt11> (Interdiff: https://bugzilla.mozilla.org/attachment.cgi?oldid=8445003&action=interdiff&newid=8445380&headers=1)
20:02:54 <flo-retina> I was already looking at the interdiff ;)
20:02:59 <flo-retina> are you sure profileBeforeChange is the correct value?
20:03:16 <nhnt11> The documentation I read said that stuff that does changes in the profile dir should use that.
20:03:39 <flo-retina> I mean, have you checked that OS.File is still usable 
20:03:44 <nhnt11> "at the end of phase profileBeforeChange, no service is permitted to write to the profile directory"
20:03:51 <nhnt11> It should be?
20:03:56 <nhnt11> let me check
20:05:35 <flo-retina> http://mxr.mozilla.org/mozilla-central/source/toolkit/components/osfile/modules/osfile_async_front.jsm#1612 explains
20:05:47 <nhnt11> I was just looking at this: https://bugzilla.mozilla.org/attachment.cgi?id=804673&action=diff
20:06:21 <nhnt11> flo-retina: So profileBeforeChange looks good
20:06:48 <flo-retina> isn't there a 'magical' way to wait for all the promises of an array or something?
20:07:00 <nhnt11> Promise.all()
20:07:08 <nhnt11> But Map.values() is an iterable, not an array
20:07:39 <nhnt11> Erm, an |Iterator| object I mean
20:07:59 <flo-retina> I assume you are sure there's no possible deadlock between the various promises in gFilePromises ?
20:08:12 <nhnt11> Yes, I'm sure
20:08:43 <flo-retina> "will care of it." did you mean "will take care of it."?
20:08:53 <nhnt11> Uh, damn.
20:09:05 <nhnt11> (I did)
20:09:09 <flo-retina> "Logs service: shutting down" isn't descriptive enough
20:09:38 <nhnt11> "Logs service: waiting for pending file operations"?
20:10:04 <flo-retina> "Chat logger: writing all pending messages"?
20:10:28 <nhnt11> Those aren't necessarily only pending message writes..
20:11:06 <nhnt11> But if that technicality can be overlooked, okay.
20:11:16 <flo-retina> what are the other cases?
20:11:29 <nhnt11> Reading a log file, writing a header
20:11:40 <flo-retina> we shouldn't read during shutdown
20:11:57 <flo-retina> shouldn't we reject these promises instead?
20:12:05 <nhnt11> Reject the reads?
20:12:06 <flo-retina> or is it so unlikely to happen that we don't care?
20:12:09 <nhnt11> i.e. don't do them?
20:12:13 <nhnt11> It is very very unlikely to happen
20:12:38 <nhnt11> The way the queue is written at the moment, I can't wait on all reads
20:12:45 <nhnt11> Because some writes may have been queued /after/ a read
20:12:55 <nhnt11> I can't *not* wait I mean
20:13:19 <flo-retina> that seems slightly incorrect, but oh well :)
20:13:42 <nhnt11> :S
20:14:12 <flo-retina> (not being able to ignore reads)
20:14:14 <nhnt11> I can't possibly store every I/O promise on a path, and the point of the queue is to ensure reads and writes don't happen simultaneously
20:14:26 <nhnt11> The promise stored is for the /last/ queued operation
20:14:40 <nhnt11> (which happens only after the one queued before it, and so on)
20:15:06 <flo-retina> yeah, I still remember a bit what the patch does ;)
20:15:15 <nhnt11> okay
20:16:23 <flo-retina> mayanktg: I can't parse that sentence "Context attribute is set empty and when there exists multiple targets id is assigned to it."
20:16:38 <nhnt11> flo-retina: I'm making the AsyncShutdown import non-lazy in the next patch
20:16:38 <flo-retina> and there's no point in saying that it's set to empty. That's _very_ visible.
20:16:50 <flo-retina> The important part to comment about is WHY we are setting it to empty
20:16:56 <nhnt11> (it gets called every time anyway)
20:17:35 <nhnt11> Same for Task.jsm
20:17:36 <flo-retina> mayanktg: why the changes from hbox to box?
20:19:15 <mayanktg> flo-retina: I changed it because it was already inside a hbox.
20:20:04 <mayanktg> flo-retina: I'll change the comment then, I wasn't able to figure out why context attribute was set to empty.
20:20:26 <flo-retina> why haven't you asked then?
20:21:02 <flo-retina> mayanktg: box seems to be the same thing as an hbox; just slightly less explicit. Please revert to hbox.
20:21:05 <nhnt11> flo-retina: Does this look ok? https://pastebin.mozilla.org/5465869
20:21:44 <mayanktg> flo-retina: Ok. I'll revert it back then. Why are we using context="" there?
20:22:20 <flo-retina> nhnt11: yes :)
20:24:00 --> unghost has joined #instantbird
20:24:26 <flo-retina> mayanktg: have you tried opening context menus on that area? and around it?
20:25:00 <mayanktg> flo-retina: Yes. I have tried that. 
20:25:02 <mayanktg> ...
20:25:47 <flo-retina> so what have you noticed?
20:26:29 <mayanktg> I noticed that if multiple targets were present there appeared a menu list.
20:26:44 <mayanktg> which consisted of the targets.
20:26:58 <flo-retina> what if you right click outside the area of the target switcher?
20:28:02 <mayanktg> A menu containing new tab, open a new window.. etc. appears
20:28:28 <flo-retina> so can you guess why we have context="" ?
20:29:08 <mayanktg> Oh! if the context is not set then those menu won't appear. 
20:30:43 <flo-retina> if the context attribute is not set, the context attribute from parent nodes will be used
20:32:07 <mayanktg> yep I've understood it now. Thanks a lot :). I'm updating the patch and posting it again then.
20:32:50 <flo-retina> mayanktg: so you likely want context="" on the convToolbarbuttonBox box rather than on the target switcher, right?
20:34:05 <mayanktg> Yes. because we _might_ have menu for other toolbarbuttons too.
20:34:14 <flo-retina> I wonder if that mousethrough="always" attribute you removed should also be kept on the convToolbarbuttonBox
20:34:56 <nhnt11> I've attached my indexing WIP on bug 955014. Quite sleepy now, good night. :)
20:34:58 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955014 enh, --, ---, nhnt11, ASSI, Indexed logs & efficient search
20:35:24 <flo-retina> nhnt11: good night!
20:36:13 <mayanktg> Ok. I'm adding it to convToolbarbuttonbox then.
20:36:36 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:36:44 --> nhnt11 has joined #instantbird
20:46:22 <mayanktg> flo-retina: Should I add a comment on both the places where convToolbarbottonBox is used?
20:51:18 <mayanktg> I'm adding the comment only at the "conv-info-large" binding.
20:53:05 --> Hadi has joined #instantbird
21:04:08 <-- Hadi has quit (Connection reset by peer)
21:12:26 <-- EionRobb has quit (Quit: Leaving.)
21:23:11 * arlolra eagerly awaits https://bugzilla.mozilla.org/show_bug.cgi?id=1004930
21:23:13 <instantbot> Bug 1004930 enh, --, ---, mayanktg, ASSI, Generic way to add buttons for actions to a conversation
21:23:29 --> EionRobb has joined #instantbird
21:23:56 <mayanktg> arlolra: Hope it lands soon :)
21:25:04 * flo-retina isn't sure what https://bug1004930.bugzilla.mozilla.org/attachment.cgi?id=8445456 is expected to show
21:25:15 <-- EionRobb has quit (Ping timeout)
21:25:33 <flo-retina> arlolra: yeah, it's expected to land soon. At least I'll get impatient if it doesn't ;).
21:25:59 <arlolra> does it support labels instead of icons?
21:26:02 --> EionRobb has joined #instantbird
21:26:51 <flo-retina> arlolra: what's the use case?
21:27:24 <flo-retina> arlolra: it seems to currently support any XUL element
21:27:32 <flo-retina> which is actually kinda strange.
21:27:44 <flo-retina> mayanktg: shouldn't we restrict this to toolbarbutton items?
21:28:08 <mayanktg> flo-retina: Yes, we should do this!
21:28:39 <arlolra> i was planning on using toolbarbutton with a label for otr's various states. not private, private but not verified, verified
21:29:12 <arlolra> I stated doing https://github.com/arlolra/ctypes-otr/blob/master/bootstrap.js#L69-L148
21:29:20 <arlolra> s/stated/started/
21:29:45 <-- clokep_work has quit (Ping timeout)
21:29:56 <flo-retina> arlolra: what about a different icon for each of these states, and a descriptive tooltip when hovering the icon?
21:30:32 <arlolra> that works, red, yellow, green with tooltips
21:31:18 <flo-retina> if you use these colors, ensure they are colorblind-friendly
21:32:44 <-- unghost has quit (Input/output error)
21:33:21 <arlolra> right
21:33:30 <flo-retina> arlolra: looking at your link... what are you trying to do with the noTopic and editing attributes there?
21:38:01 <arlolra> flo-retina: that's a fair question. it's from https://addons.instantbird.org/en-US/instantbird/addon/309
21:39:04 <arlolra> the comment says
21:39:05 <arlolra> / Flags which work by presence/absence must be removed and "reinitialized" via broadcast.
21:39:09 <flo-retina> ok, so it seems quite unrelated
21:39:37 <flo-retina> these attributes only make sense in multi user chats, and I think you are intending to touch/touching only 1:1 conversations
21:40:10 <-- Armada has quit (Connection reset by peer)
21:40:38 <arlolra> flo-retina: ah, ok, thanks
21:40:41 <arlolra> will remove
21:47:19 <flo-retina> people expecting stuff from me: I'll be in Paris and mostly offline during the next 2 days. I'll likely look at some review requests in the train tomorrow morning.
21:48:57 <flo-retina> Good night
21:49:06 <mayanktg> Night!
21:55:24 <-- Rym has quit (Connection reset by peer)
21:58:22 --> Rym has joined #instantbird
21:59:29 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:05:16 <-- Rym has quit (Ping timeout)
22:08:21 --> Rym has joined #instantbird
22:18:58 * Fallen is now known as Fallen|away
22:25:27 <-- Rym has quit (Ping timeout)
22:25:51 --> Rym has joined #instantbird
22:29:21 --> mpmc has joined #instantbird
22:30:07 <mpmc> Hey folks, booted my PC tried loading up instantbird and got this.. http://imgur.com/QChazL8 Any ideas?
22:32:25 --> mpmc1 has joined #instantbird
22:33:27 <mpmc> o.o, installed the latest nightly and its working again O.o!
22:34:46 <-- mpmc has quit (Quit: http://www.mibbit.com ajax IRC Client)
22:40:14 --> wnayes has joined #instantbird
22:41:02 <-- arlolra has quit (Quit: arlolra)
22:51:25 --> clokep has joined #instantbird
22:51:25 * ChanServ sets mode +o clokep 
22:52:36 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
22:53:47 --> clokep has joined #instantbird
22:54:28 <clokep> mpmc1: https://hg.mozilla.org/comm-central/rev/e646a3628e82
22:54:32 * clokep is now known as h87tz4
22:54:52 * h87tz4 is now known as clokep
22:55:17 <-- wnayes has quit (Ping timeout)
22:56:11 <clokep> flo-retina: So none of my passwords were loaded on Windows. :-S
22:56:36 <mpmc1> h87tz4 clokep: I see, thanks for pointing that bug out :)
22:56:43 <clokep> I think I recently asked you about some password changes that were ported by Suite (maybe mail?) but I don't know if you ever responded.
22:58:57 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:59:03 --> wnayes has joined #instantbird
22:59:29 --> clokep has joined #instantbird
23:02:38 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
23:03:13 <-- Rym has quit (Ping timeout)
23:04:03 --> Rym has joined #instantbird
23:11:32 --> clokep_work has joined #instantbird