#instantbird log on 06 23 2014

All times are UTC.

00:17:58 <-- wnayes has quit (Ping timeout)
00:20:19 --> wnayes has joined #instantbird
00:24:59 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
00:32:19 <-- rosonline has quit (Ping timeout)
01:23:31 <-- clokep has quit (Ping timeout)
02:17:32 <-- wnayes has quit (Ping timeout)
02:47:47 <-- Rym has quit (Ping timeout)
03:56:41 --> Rym has joined #instantbird
03:58:22 <-- Rym has quit (Ping timeout)
04:33:29 --> jb has joined #instantbird
04:41:55 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
04:42:02 --> nhnt11 has joined #instantbird
04:46:06 --> mayanktg has joined #instantbird
05:02:52 <-- mayanktg has quit (Client exited)
05:03:02 --> mayanktg has joined #instantbird
05:23:26 --> gerard-majax__ has joined #instantbird
05:31:37 <-- jb has quit (Ping timeout)
06:48:17 --> jb has joined #instantbird
06:58:12 <-- gerard-majax__ has quit (Ping timeout)
07:23:57 --> mpmc has joined #instantbird
07:24:16 <nhnt11> mayanktg: ping
07:24:25 <mayanktg> nhnt11: pong
07:26:07 <nhnt11> mayanktg: Do you need anymore feedback on bug 975542?
07:26:16 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=975542 enh, --, ---, mayanktg, NEW, Set user icon from image taken with the webcam.
07:26:28 <nhnt11> (I'm adding a comment documenting the fix for the close button)
07:27:29 <mayanktg> Ok. I'll make the changes and upload the patch then. After then I guess Mic would test it on Windows.
07:28:04 <-- jb has quit (Quit: jb)
07:30:34 <nhnt11> let me test it again to make sure I didn't miss anything..  This time I'll enable the webcam and do a full uild
07:30:35 <nhnt11> build
07:32:10 <mayanktg> You will need to do clobber --> build? :-o
07:32:12 --> jb has joined #instantbird
07:32:36 <mayanktg> Thanks :) 
07:59:39 <nhnt11> Hmm, I'm seeing |Error: aFunction.apply is not a function| in the error console at startup with mayanktg's patch applied
07:59:49 <nhnt11> (imXPCOMUtils.jsm, L148)
08:04:04 <nhnt11> mayanktg: Turns out setting max-width alone isn't enough, hold on..
08:11:04 <mayanktg> nhnt11: What's the cause of this error?
08:11:10 <nhnt11> mayanktg: No idea
08:11:41 <nhnt11> Let me unapply your patch and see if it still appears
08:11:55 <nhnt11> (It's not on the latest nightly, and I had only your patch applied, so I assumed)
08:14:29 <mayanktg> Ok. I am also seeing that error message. But when I cleared the error log and reopened the panel again, no error message was displayed.
08:14:50 <nhnt11> Could be a startup-only thing
08:14:57 <nhnt11> Bah! :(
08:15:21 <nhnt11> (I'll explain why I'm saying "bah!" in a sec)
08:16:14 <nhnt11> I had somehow fixed this bug: http://puu.sh/9DJVv/f80dde478f.png with some CSS changes...
08:16:25 <nhnt11> But I tried to backtrack to see what fixed it and now it's broken again :-/
08:16:34 <nhnt11> And I can't figure out what I ndid that was doing the trick :(
08:17:51 <mayanktg> Wasn't it one of the flip things that aleth said might help?
08:18:45 <nhnt11> That's supposed to be enabled by default.
08:19:58 --> Mic has joined #instantbird
08:19:58 * ChanServ sets mode +o Mic 
08:21:10 <mayanktg> nhnt11: This is how it looked on my system. http://i.imgur.com/RfcVu8y.png 
08:21:28 <nhnt11> mayanktg: On my system it's varying based on where it is on the screen
08:22:08 <nhnt11> Aha!
08:22:22 <nhnt11> I'd set width and height to 16px on #userIconPanelImageRemove
08:22:25 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
08:22:34 <nhnt11> Leaving it without the width and height set seems to fix it
08:23:29 --> mayanktg has joined #instantbird
08:24:07 <mayanktg> nhnt11:  :)
08:29:28 <mayanktg> thanks nhnt11. I'm trying the diff. Just to see if the changes are working well on Linux too.
08:29:29 <mayanktg> :)
08:29:39 <nhnt11> np
08:39:20 <mayanktg> Seems to work well :) I'll recheck things and update the patch. Thanks a lot! :)
08:40:44 <-- jb has quit (Ping timeout)
08:42:09 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
08:46:59 --> jb has joined #instantbird
08:49:07 <-- jb has quit (Connection reset by peer)
08:49:09 --> jb1 has joined #instantbird
08:53:21 <mayanktg> nhnt11: There? Removing the |max-width: 16px; min-width: 16px;| line from userIconPanelImageRemove is changing the proportion of the stack in which the user icon and X button is present :-/
08:53:45 <mayanktg> Line 495 of the diff you've shared.
08:53:59 <mayanktg> Sry 491
08:56:51 <mayanktg> http://i.imgur.com/MUq4QZk.png
08:59:15 <mayanktg> Just keeping the min-width: 16px keeps it into shape though.
09:05:13 <mayanktg> please just try once if keeping |min-width: 16px;| inside userIconPanelImageRemove  doesn't change the behavior of how panel is opened.
09:14:31 <nhnt11> mayanktg: setting padding: 0; fixed that issue
09:15:00 <nhnt11> Is that not working for you?
09:17:20 <mayanktg> No :-/
09:17:55 <mayanktg> Shall I post a complete diff of the changes?
09:18:05 <-- jb1 has quit (Ping timeout)
09:18:11 <nhnt11> Is it different from the one I posted?
09:18:11 <mayanktg> nhnt11: ^
09:18:32 <mayanktg> No. I did exactly what you've mentioned in the diff.
09:19:47 --> jb has joined #instantbird
09:20:37 <mayanktg> nhnt11: Just in case you need it. http://pastebin.instantbird.com/740629
09:21:37 <mayanktg> Is setting only |min-width: 16px;| causing the problem?
09:33:51 <nhnt11> mayanktg: What I'm surprised about is the fact that setting min-width is fixing it
09:34:11 <nhnt11> If it was max-width, that would have been understandable
09:35:04 <mayanktg> Yeah. Even I cannot relate why it was fixed after including the min-width line :-o
09:35:46 <nhnt11> mayanktg: Setting min-width causes problems with the positioning of the panel again
09:36:14 <nhnt11> mayanktg: Can you open the DomI and check if anything else is there on which you can set padding or something?
09:36:27 <mayanktg> yeah. sure.
09:38:48 <nhnt11> mayanktg: Btw, make sure you disable the capture button until the webcam loads
09:39:02 <nhnt11> It takes a couple of seconds to load for me and if I press capture before it does, it leads to errors
09:40:14 <mayanktg> I know. I have set the disabled attribute to true, until getuserMedia's successCallback is called, but even after then it takes time to start the webcam.
09:40:44 <mayanktg> Idk how to activate the button when the webcam is fully started.
09:41:33 --> chrisccoulson has joined #instantbird
09:41:43 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:43:03 <nhnt11> mayanktg: I think you want to enable it in onloadedmetadata
09:44:05 <mayanktg> nhnt11: Yeah got it :)
09:47:43 <nhnt11> mayanktg: or perhaps in the media stream's onstarted event?
09:47:55 * nhnt11 shrugs..
09:48:08 <nhnt11> I don't know how to fix your video width problem :(
09:48:22 <nhnt11> Without using ifdefs for OS X...
09:48:37 * nhnt11 needs to get back to work on his logs stuff
09:49:39 --> Fallen has joined #instantbird
09:50:24 <mayanktg> nhnt11: http://pastebin.instantbird.com/740632 I changed it to onloadedmetadata. Still its the same. The button is enabled before the stream is actually completely loaded.
09:51:38 <mayanktg> nhnt11: Then put an ifdef if it isn't solving the problem. :-|
09:51:44 <nhnt11> mayanktg: Try |aStream.addEventListener("started", () => d.gEBI("captureButton").removeAttr("disabled"));|
09:53:22 <nhnt11> mayanktg: Also you need to remove the hover/active states for the button while it's disabled
09:58:08 <nhnt11> mayanktg: Ah. Try video.onplaying :)
09:58:22 <nhnt11> check media events here: http://www.w3schools.com/tags/ref_eventattributes.asp
09:58:44 <mayanktg> nhnt11: Ok Thanks :). The above line didn't work out.
10:00:19 <mayanktg> nhnt11: Yep. onplaying worked :)
10:00:21 <nhnt11> mayanktg: Also, you need to disable the capture button again when the video has been stopped
10:00:32 <nhnt11> (like when the user presses back)
10:01:46 <mayanktg> Ok. Done :)
10:02:44 --> Armada has joined #instantbird
10:03:40 <-- EionRobb has quit (Quit: Leaving.)
10:15:26 --> BWMerlin has joined #instantbird
10:18:24 <mayanktg> I tried setting minW/maxW/width on both stack and the image so that it could be fixed. It didn't help either. Should we try using the ifdefs then? :-o
10:18:29 <mayanktg> nhnt11: ^
10:19:02 --> gerard-majax__ has joined #instantbird
10:20:49 <nhnt11> mayanktg: Maybe. Ask aleth or flo for their opinion first.
10:20:53 <nhnt11> There's probably a better way
10:21:03 <mayanktg> Ok. 
10:23:42 <mayanktg> aleth_web: Hi. The panel looks like http://i.imgur.com/MUq4QZk.png if I remove the |min-width: 16px| from userIconPanelImageRemove, but on setting min-width the panel behavior changes in Mac. I can't find any other way to fix this issue. Shall we go for using ifdefs to fix this issue?
10:23:55 <mayanktg> http://pastebin.instantbird.com/740629
10:24:06 <mayanktg> The complete pastebin of the bug.
10:24:38 <mayanktg> L421.
10:28:40 <nhnt11> mayanktg: You haven't changed the button to toolbarbutton
10:28:42 <nhnt11> Do that.
10:29:00 <nhnt11> I changed userIconPanelImageRemove to be a toolbarbutton
10:29:39 <nhnt11> Remember that toolbarbuttons try to keep their sizes constrained, which we actually want here.
10:29:46 <nhnt11> (unlike on the other buttons)
10:30:37 <nhnt11> mayanktg: You need to change those :focus selectors to :active
10:30:39 <mayanktg> nhnt11: Thanks. It works now. This was causing the problem:-/
10:31:09 <mayanktg> ok change it to :hover:active right?
10:31:11 <nhnt11> also the :hover and :active ones need to be only if the disabled attribute is not present
10:31:22 <nhnt11> No, just :active
10:31:23 <nhnt11> :S
10:31:28 <mayanktg> Ok.
10:41:08 <mayanktg> aleth_web: its fixed now.
10:43:02 <-- mayanktg has quit (Ping timeout)
10:45:58 --> mayanktg has joined #instantbird
11:05:25 --> flo-retina has joined #instantbird
11:05:25 * ChanServ sets mode +qo flo-retina flo-retina 
11:13:10 <mayanktg> I'm getting a |Error: aFunction.apply is not a function| error upon startup if I include |Cu.import("resource:///modules/imXPCOMUtils.jsm");| line in the blist.js file. :-/
11:14:14 <flo-retina> mayanktg: don't include that file from blist.js
11:14:30 <mayanktg> flo-retina: Then?
11:15:21 <flo-retina> ?
11:15:41 <flo-retina> what are you trying to do with it?
11:16:01 <nhnt11> mayanktg: Include XPCOMUtils instead of imXPCOMUtils maybe
11:16:50 <mayanktg> I have to use OS.File for the userIcon bug, so I'm using |XPCOMUtils.defineLazyModuleGetter(this, "OS", "resource://gre/modules/osfile.jsm");| to import that file. 
11:16:55 <-- jb has quit (Ping timeout)
11:16:56 <mayanktg> nhnt11: Ok.
11:17:36 <mayanktg> nhnt11: ++
11:17:39 <mayanktg> :)
11:23:24 --> Rym has joined #instantbird
11:33:27 --> jb has joined #instantbird
11:37:52 * Fallen is now known as Fallen|away
11:46:12 --> clokep_work has joined #instantbird
11:46:12 * ChanServ sets mode +o clokep_work 
11:55:36 <-- Rym has quit (Ping timeout)
11:57:04 --> Rym has joined #instantbird
12:03:37 <-- BWMerlin has quit (Quit: BWMerlin)
12:06:29 * Fallen|away is now known as Fallen
12:09:43 <mayanktg> nhnt11: I'm uploading the patch, could you final check it once if the style appears correctly?
12:25:08 <-- Rym has quit (Ping timeout)
12:27:04 --> Rym has joined #instantbird
12:40:39 --> mpmc has joined #instantbird
12:43:55 --> qheaden has joined #instantbird
13:02:12 * Fallen is now known as Fallen|away
13:02:46 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:06:31 <clokep_work> sawrubh: So what're you working on now? We haven't really talked a ton in the past four or five days.
13:08:17 <flo-retina> nhnt11: what's the status with fixing that test failure on Linux?
13:12:39 <nhnt11> I put it on hold on saturday because of the bustage, and got indexing/search working. Today I've been cleaning up the search stuff (things like localizing the placeholder string) and intend to look at the linux failure again soon (in a few minutes)
13:12:42 <nhnt11> flo-retina: ^
13:14:23 <nhnt11> Btw, looks like the tree is closed/busted still...
13:14:43 <flo-retina> how hard have you tried fixing that tree?
13:14:58 <nhnt11> I haven't tried fixing it.
13:15:15 --> rosonline has joined #instantbird
13:15:44 <flo-retina> can the code that failed to compile be ifdef'ed out for your try pushes?
13:17:03 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:17:18 --> qheaden has joined #instantbird
13:18:00 <nhnt11> honestly I don't understand the error and don't really know /what/ to ifdef out - the whole file?
13:18:11 <nhnt11> "cannot allocate an object of abstract type 'blabla'"
13:18:23 --> iamjayakumars has joined #instantbird
13:18:28 <flo-retina> nhnt11: the error is |/builds/slave/tb-c-cen-lx-ntly-0000000000000/build/mailnews/extensions/smime/src/nsMsgComposeSecure.h:12:27: fatal error: nsICMSEncoder.h: No such file or directory|
13:19:14 <nhnt11> uh, I was looking at an older bustage, oops
13:21:10 <sawrubh> clokep_work: first up address the feedback you gave, then very quickly add that drag and drop which should be done very quickly 
13:21:22 <flo-retina> there are patches for the current bustage in bug 1027241
13:21:24 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1027241 blo, --, ---, nobody, NEW, Import nsICMS* from Gecko to Thunderbird to fix bustage caused by their removal from Gecko.
13:21:29 <sawrubh> And then writing the tests today
13:21:31 <flo-retina> not sure if they are good enough to compile
13:22:13 <sawrubh> The next patch with notification bar and comments addressed should be up in some hours and then test hopefully by EOD (not sure on the tests parts though to be available by EOD)
13:23:31 <-- Rym has quit (Ping timeout)
13:24:41 <nhnt11> I'm trying the fix locally
13:30:34 <sawrubh> clokep_work: I copied those two functions from http://dxr.mozilla.org/comm-central/source/mozilla/dom/settings/SettingsDB.jsm#130
13:31:08 <sawrubh> (those = b64ToUint6 and base64DecToArr)
13:34:39 <-- iamjayakumars has quit (Client exited)
13:37:55 --> nhnt11-testing has joined #instantbird
13:39:09 --> Rym has joined #instantbird
13:40:49 <clokep_work> sawrubh: Which are from https://developer.mozilla.org/en-US/docs/Web/JavaScript/Base64_encoding_and_decoding, which that code you copied has a comment about. :P
13:40:56 <clokep_work> I'd still like them to be cleaned up to not look as gross.
13:41:01 <sawrubh> ok
13:51:05 <nhnt11> Hmm, applying the patch didn't do anything
13:51:11 <nhnt11> I wonder if I need to clobber :-/
13:51:24 <nhnt11> (Already tried configuring)
13:52:06 <-- nhnt11-testing has quit (Client exited)
13:56:46 * Fallen|away is now known as Fallen
13:57:37 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:57:45 --> nhnt11 has joined #instantbird
13:58:56 <clokep_work> nhnt11: Let me know if you figure out a way to build c0c.
13:59:19 <nhnt11> Sure.
13:59:36 <nhnt11> (running a build atm, it'll take maybe 10 more minutes)
14:02:11 --> nhnt11-testing has joined #instantbird
14:02:33 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:02:53 --> nhnt11-testing has joined #instantbird
14:03:33 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:05:27 --> mconley has joined #instantbird
14:05:43 --> iamjayakumars has joined #instantbird
14:05:47 <nhnt11> uh
14:05:53 <nhnt11> there's a last_insert_rowid function in SQL
14:05:54 <nhnt11> duh
14:06:00 <nhnt11> *facepalm(
14:06:01 <nhnt11> *
14:09:49 <nhnt11> Hmm, build failed again :(
14:10:11 <nhnt11> Same error, interestingly :S
14:32:16 --> mcollins has joined #instantbird
14:33:02 <mcollins> is there a way to make Instantbird do an auto-NickServ identify?
14:33:23 * mcollins is tired of talking to that guy
14:33:23 <clokep_work> mcollins: Just type your password in.
14:34:29 <mcollins> ah ok
14:34:58 <clokep_work> That should work fine for most cases at least. :)
14:35:07 <clokep_work> If it doesn't, please let me know.
14:36:14 <mcollins> well, let's see
14:36:18 <-- mcollins has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
14:38:06 --> mcollins has joined #instantbird
14:38:12 <mcollins> perfect :)
14:39:28 <-- mcollins has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
14:42:43 <flo-retina> :)
14:57:53 <nhnt11> Gah, you can do |SELECT last_insert_rowid()|
14:58:51 <nhnt11> I saw so many answers on stackoverflow and such saying stuff like using OUTPUT to put the id in a temporary table variable and crap like that :S
14:59:45 <nhnt11> I'm probably doing premature optimization :(
14:59:47 * nhnt11 moves on
15:00:09 <flo-retina> is that test fixed?
15:00:23 <nhnt11> flo-retina: No, my build failed and I was working on this while it was building
15:00:28 <flo-retina> mayanktg: what's the current status of the user icon patch?
15:00:37 <nhnt11> Got a little caught up with this though
15:01:26 <flo-retina> clokep_work: one problem with giving you access to the windows vm to kick the buildbot service everyday is that Windows is installed in French :(
15:04:35 <-- iamjayakumars has quit (Client exited)
15:04:59 <-- Rym has quit (Ping timeout)
15:05:46 <nhnt11> Ah, damn, I needed to make a modification in m-c as well to build...
15:06:05 <nhnt11> flo-retina: Is it possible to push to try with m-c changes as well as c-c ones?
15:06:25 <flo-retina> yes, I don't remember how one does that, but I remember that's documented on the wiki
15:06:30 <nhnt11> looking.
15:06:32 --> Rym has joined #instantbird
15:07:17 <nhnt11> got it, thanks.
15:08:18 <mayanktg> flo-retina: I made the changes nhnt11 mentioned in the bug and have uploaded the patch for feedback from Mic regarding Windows styling.
15:08:47 <flo-retina> have you had an opportunity to talk with Mic recently?
15:08:58 <flo-retina> clokep may be able to help you to see how it looks on Windows
15:09:26 <mayanktg> No :-/ He came online for a moment today, but I couldn't talk to him.
15:09:53 <-- jb has quit (Quit: jb)
15:10:42 <mayanktg> clokep_work: Could you test the user icon patch for styling on Windows?
15:10:54 --> jb has joined #instantbird
15:11:58 <-- qheaden has quit (Ping timeout)
15:13:16 <-- Rym has quit (Connection reset by peer)
15:14:19 --> Rym has joined #instantbird
15:17:35 --> Rym_ has joined #instantbird
15:17:57 <-- Rym has quit (Ping timeout)
15:18:32 --> qheaden has joined #instantbird
15:18:50 <nhnt11> alright, doing another build...
15:18:56 * nhnt11 hopes it works so that he can push to try
15:21:09 <-- qheaden has quit (Ping timeout)
15:23:21 --> iamjayakumars has joined #instantbird
15:24:23 --> arlolra has joined #instantbird
15:25:27 <-- iamjayakumars has quit (Ping timeout)
15:26:43 <clokep_work> flo-retina: You don't think I know Windows well enough to ignore the language? ;)
15:28:27 <-- Rym_ has quit (Connection reset by peer)
15:28:59 <flo-retina> clokep_work: I think even when knowing the language it's difficult enough to interact with it
15:29:00 --> Rym_ has joined #instantbird
15:29:22 <clokep_work> mayanktg: Yes, but not now.
15:29:29 <clokep_work> flo-retina: I was mostly joking. :)
15:29:33 <clokep_work> But yeah, it oculd be painful
15:29:53 <nhnt11> flo-retina: Okay, so for the path ids table, I've set a UNIQUE constraint on the "path" column. Do you think it's better to try and insert a path, and select it if it fails, or try to select it, and insert if select didn't return anything?
15:30:04 * nhnt11 doesn't know if there are "good practice" rules and such for this
15:30:27 <flo-retina> is UNIQUE honored by SQLite, or just there "for syntax compatibility"? :)
15:30:35 <nhnt11> It's honoured.
15:30:37 <nhnt11> I tested ;)
15:43:39 --> iamjayakumars has joined #instantbird
15:50:38 <-- iamjayakumars has quit (Client exited)
15:53:20 <-- gerard-majax__ has quit (Ping timeout)
15:53:21 --> iamjayakumars has joined #instantbird
15:54:50 <-- nhnt11 has quit (Ping timeout)
15:56:07 --> nhnt11 has joined #instantbird
15:56:54 <nhnt11> Build failed again :(
16:02:50 <nhnt11> Ah, but the error isdifferent... nsMsgAttachmentHandler.cpp
16:03:21 <nhnt11> nsMsgAttachmentHandler.h:66:3: error: static_assert failed
16:03:38 <-- Rym_ has quit (Ping timeout)
16:06:28 --> Rym_ has joined #instantbird
16:08:03 <-- jb has quit (Ping timeout)
16:09:12 <flo-retina> nhnt11: so what's the failed assert?
16:09:42 <nhnt11> "Reference-counted classes should not have a public destructor. Try to make this class's destructor non-public. If that is really not possible, you can whitelist this class by providing a HasDangerousPublicDestructor specialization for it."
16:11:38 <-- Rym_ has quit (Ping timeout)
16:11:51 --> Rym_ has joined #instantbird
16:15:06 <-- iamjayakumars has quit (Client exited)
16:21:12 <-- Rym_ has quit (Connection reset by peer)
16:21:35 --> Rym_ has joined #instantbird
16:24:52 --> jb has joined #instantbird
16:26:53 --> iamjayakumars has joined #instantbird
16:27:40 <-- mayanktg has quit (Ping timeout)
16:30:13 --> mayanktg has joined #instantbird
16:53:53 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:54:37 * nhnt11 pushes to try
17:18:25 --> Mook_as has joined #instantbird
17:19:46 --> flo-retina has joined #instantbird
17:19:47 * ChanServ sets mode +qo flo-retina flo-retina 
17:21:45 <-- iamjayakumars has quit (Quit: )
17:24:39 <mayanktg> aleth_web: The call now gets disconnected automatically if unanswered for the given time. :)
17:27:35 <-- Rym_ has quit (Ping timeout)
17:29:06 --> Rym_ has joined #instantbird
17:35:07 <-- jb has quit (Ping timeout)
18:15:17 <nhnt11> bah, some other tests failing again....
18:16:35 --> gerard-majax__ has joined #instantbird
18:16:53 --> Tonnes has joined #instantbird
18:17:32 <flo-retina> mayanktg: "The call now gets disconnected automatically if unanswered for the given time." why would an unanswered call be connected?
18:17:42 <flo-retina> believe it or not, we have a new Windows nightly! \o/
18:20:04 <mayanktg> flo-retina: We send a notification whether to accept/reject the call to the sender --> until the callee accepts/rejects the call the caller is in wait mode. If the call remains unanswered for 30 sec it automatically gets disconnected and the chat box is restored again. 
18:20:12 <mayanktg> yay :)
18:20:44 <flo-retina> or, so it was just confusing wording
18:21:14 <flo-retina> *ok
18:21:22 --> xangua has joined #instantbird
18:21:23 <mayanktg> Yeah :-| I wrote it for aleth because it was his idea.
18:22:01 <flo-retina> nhnt11: thanks on getting that bustage fixed! :)
18:22:46 <flo-retina> looks like you got quick help to get it landed timely :)
18:24:10 <-- Rym_ has quit (Ping timeout)
18:24:59 --> Rym_ has joined #instantbird
18:27:37 <-- Rym_ has quit (Ping timeout)
18:29:40 --> Rym_ has joined #instantbird
18:31:00 <-- Rym_ has quit (Connection reset by peer)
18:31:54 --> Rym_ has joined #instantbird
18:49:57 <nhnt11> flo-retina: Np, thank /you/ for giving me the fix
18:51:23 <nhnt11> I'm cancelling the try build, doesn't look like it's of any use..
18:51:39 <nhnt11> any use letting it run further just for OS X I mean
18:51:49 <clokep_work> nhnt11: Which bustage is this?
18:51:53 <clokep_work> flo-retina: Excellent! :) THanks.
18:52:33 <nhnt11> clokep_work: The one for which I submitted a patch? bug 1028997
18:52:36 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1028997 nor, --, Thunderbird 33.0, nhnt11, RESO FIXED, Assertion failure in nsMsgAttachmentHandler.h
18:53:14 <clokep_work> nhnt11: Well done. :)
18:53:28 <clokep_work> Does that mean building works now? :P
18:53:30 <nhnt11> Uh, I really didn't do anything other than follow directions :S
18:53:33 <nhnt11> clokep_work: No
18:53:52 <nhnt11> This fix was necessary but not sufficient..
18:54:19 <nhnt11> clokep_work: You need the patch from bug 1027241 to build
18:54:22 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1027241 blo, --, ---, nobody, NEW, Import nsICMS* from Gecko to Thunderbird to fix bustage caused by their removal from Gecko.
18:57:26 <flo-retina> nhnt11: so do you have something else you want to try to fix that logger test?
19:00:12 <nhnt11> flo-retina: I want to run all tests locally once first to ensure that my tests will even run when I push
19:00:49 <nhnt11> flo-retina: Never mind
19:00:50 <nhnt11> My tests pass
19:01:02 <nhnt11> uh
19:01:04 <nhnt11> on linux 32 at least
19:01:34 <flo-retina> they used to fail only on linux 64
19:01:41 <flo-retina> so you seem to still be at the same point
19:01:52 <nhnt11> right, not thinking clearly at the moment
19:02:02 <nhnt11> let me check if my debug dumps helped at all...
19:07:01 <nhnt11> Okay, the "problem" is that the files are not being read in the right order
19:09:22 <nhnt11> I wonder if I am assuming something wrong about the order of entries returned by DrectoryIterator
19:10:12 * nhnt11 looks some stuff up..
19:15:50 <nhnt11> flo-retina: Okay, the problem is definitely that the directory contents are not returned in an expected order (seemingly only on linux 64, maybe it's just a bad assumption to make). The simple fix is to simply sort all entries in the Log constructor
19:16:15 <nhnt11> I'm curious how nsIFile.directoryEntries behaves
19:16:42 <flo-retina> assuming anything about the order of entries seems wrong :)
19:17:19 <-- Rym_ has quit (Ping timeout)
19:24:05 <nhnt11> pl. O
19:24:09 <nhnt11> ^typo
19:24:15 <nhnt11> ok, I've added a localeCompare
19:25:01 <nhnt11> This should fix the issues...
19:27:03 <nhnt11> I'm pushing only linux64 this time
19:31:11 <flo-retina> why localeCompare?
19:31:30 <flo-retina> is there anything localized in there? Do we rely on the order of the files anywhere?
19:31:54 <nhnt11> flo-retina: Since the filenames are timestamps, I figured I could just compare the filenames with localecompare and be done with it
19:31:59 <nhnt11> Um, yes we do
19:32:13 <nhnt11> For files not grouped by day, we still want the files to be enumerated in order
19:32:19 <flo-retina> why not just "sort"?
19:32:31 <flo-retina> I don't see how the localization of the sort is needed here?
19:32:36 <nhnt11> flo-retina: Because the array is an array of DirectoryIterator.Entry
19:32:40 <flo-retina> (a localeCompare is slower than a normal compare)
19:32:47 <nhnt11> Is there an easy way to sort based on a particular field?
19:32:50 <nhnt11> (entry.path)
19:33:26 <nhnt11> Give me a minute...
19:34:48 <nhnt11> So if it's okay to do a direct compare of filenames, I can do that.
19:35:29 <nhnt11> (I was sorting based on full path, but I can do it on the filename instead, that should eliminate the need for localeCompare)
19:35:39 --> jb has joined #instantbird
19:35:44 <flo-retina> I don't remember the context (and I'm having dinner), do what makes sense :)
19:35:57 <nhnt11> Alright.
19:36:12 <nhnt11> I've already pushed to try, the idea of the fix is the same so the try results will tell us what we need
19:36:29 <nhnt11> I can change the way I'm sorting them if needed - as long as they get sorted it's fine :)
19:38:03 <nhnt11> Uh, I think I just requested a cancellation by mistake (I saw an x button and I thought that would close the popup... :])
20:00:26 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
20:21:43 <-- jb has quit (Ping timeout)
20:35:57 <mayanktg> I'm unable to set the accesskey for the notificationbox's button :-/ Eventhough on using dump I'm getting the value of the accesskey. The key isn't set. http://pastebin.instantbird.com/740836 is the method for showing the notificationbox.
20:35:58 --> Rym_ has joined #instantbird
20:41:49 <clokep_work> nhnt11: Sort takes a sorting function.
20:42:36 <-- Rym_ has quit (Ping timeout)
20:43:22 --> Rym_ has joined #instantbird
20:43:35 <-- gerard-majax__ has quit (Ping timeout)
20:44:53 <flo-retina> mayanktg: The field is named accessKey, not accesskey
20:45:16 <flo-retina> mayanktg: the code using it is http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/notification.xml#121
20:47:31 <mayanktg> flo-retina: Ahh... Its fixed. 
20:47:36 --> mpmc has joined #instantbird
20:48:04 <mayanktg> My brain couldn't differentiate the K and k even in the https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Method/appendNotification :-|
20:49:00 <flo-retina> that happens...
20:49:12 <flo-retina> it's confusing that there's a mix of accesskey and accessKey in the code :(
20:53:01 <mayanktg> also do you have any good "Close" icon for the vdeo call (top-right) http://i.imgur.com/MamNhiml.jpg ?
20:53:07 <mayanktg> flo-retina: ^
20:55:24 <mayanktg> It should be not less than 20px. The current one is a 16px one and its pretty small :-|
20:56:54 <flo-retina> I see the t-shirt contest continues!
20:57:08 <mayanktg> :D
21:13:36 <flo-retina> no, I don't have ideas of where we could steal a larger close/stop icon.
21:14:46 <flo-retina> the only idea I have is the stop icon that was in the browser navigation toolbar before Australis
21:15:41 --> EionRobb has joined #instantbird
21:17:58 <mayanktg> np :) . I think its 16px too. I'll try to find some in the browser/ and mobile/android../resources.
21:18:10 <flo-retina> I think the current one is 16px
21:18:19 <flo-retina> I suspect the toolbar icon version was larger
21:18:46 <mayanktg> The current one is 16px..Hmm..Let me use that icon then.
21:18:49 <flo-retina> errr; it's actually quite possible that it's 16px too
21:18:59 <flo-retina> but the current one is 16px including some transparent padding
21:19:21 <flo-retina> mayanktg: what you have in the screenshot doesn't look bad for a first UI
21:19:29 <flo-retina> we can polish later
21:20:41 <mayanktg> flo-retina: Ok. Wait...let me share a screenshot of the notificationbox too..Suggest about the "answer button" too.
21:21:31 <mayanktg> http://i.imgur.com/HkSTzcPl.jpg
21:22:10 <mayanktg> I have a hover and active state for the button too.. and a hover state for notificationbox.
21:32:24 <flo-retina> have you intentionally centered that text, and made that button look flat?
21:32:47 <mayanktg> Yes. I've centered the text and made the buttons flat.
21:33:04 <flo-retina> what was wrong with the default appearance?
21:34:20 <mayanktg> Nothing. I thought having a green answer call button will be good. If it isn't appearing good, I'll surely revert back
21:35:21 <flo-retina> keep the default appearance initially while we focus on the technical aspects of the code
21:35:45 <flo-retina> if things need to be improved in the theming, we can deal with it later.
21:36:04 <mayanktg> http://i.imgur.com/MckrmFKl.jpg Ok. I have switched back to the original one. :)
21:36:23 <mayanktg> ignore the account name :-|
21:36:47 <flo-retina> isn't the button on the right side by default?
21:37:53 <mayanktg> I guess no. I removed all the CSS I've applied on the notificationbox. I'll see to it.
21:38:49 <flo-retina> maybe I'm just tired then :)
21:39:07 * flo-retina has seen too much tinkering with these poor notification bars lately
21:42:52 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:03:14 * Fallen is now known as Fallen|away
22:14:12 <-- clokep_work has quit (Ping timeout)
22:15:28 <-- Rym_ has quit (Connection reset by peer)
22:16:00 --> Rym_ has joined #instantbird
22:27:36 <-- Rym_ has quit (Ping timeout)
22:28:31 --> Rym_ has joined #instantbird
22:45:45 --> wnayes has joined #instantbird
23:27:25 <-- Rym_ has quit (Ping timeout)
23:29:31 --> Rym_ has joined #instantbird
23:34:45 --> clokep has joined #instantbird
23:34:45 * ChanServ sets mode +o clokep 
23:35:16 <-- clokep has quit (Input/output error)
23:35:43 --> chrisccoulson has joined #instantbird
23:38:10 <-- Rym_ has quit (Connection reset by peer)
23:38:53 --> Rym_ has joined #instantbird
23:41:58 <-- Armada has quit (Connection reset by peer)
23:43:08 --> Rym has joined #instantbird
23:43:39 <-- Rym_ has quit (Ping timeout)
23:47:18 --> clokep has joined #instantbird
23:47:18 * ChanServ sets mode +o clokep 
23:47:42 <clokep> :(
23:47:59 <clokep> flo-retina: "The program can't start because icuin52.dll is missing from your computer. Try reinstalling the program to fix this problem."
23:50:26 <-- rosonline has quit (Ping timeout)
23:53:15 <-- Rym has quit (Connection reset by peer)
23:54:37 --> Rym has joined #instantbird