#instantbird log on 06 18 2014

All times are UTC.

00:31:37 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
00:39:26 <-- wnayes has quit (Ping timeout)
00:42:48 --> wnayes has joined #instantbird
00:50:15 * mconley is now known as mconley|food
00:50:56 <-- Rym has quit (Ping timeout)
00:57:41 <nhnt11> flo-retina: Thanks for the r+! I'll push to try and try and churn out a patch for indexing asap!
00:59:06 --> Rym has joined #instantbird
01:01:47 <-- Rym has quit (Ping timeout)
01:02:36 --> Rym has joined #instantbird
01:04:50 --> Rym_ has joined #instantbird
01:05:16 <-- Rym has quit (Ping timeout)
01:06:01 <-- Mook_as has quit (Quit: Mook_as)
02:07:20 <-- Rym_ has quit (Ping timeout)
02:09:26 <clokep> nhnt11: Do you know what i need to do to enable chrome stuff in scratchpad?
02:10:39 --> Rym_ has joined #instantbird
02:11:36 <nhnt11> clokep: I could have sworn there was a menubar item for it
02:11:38 <nhnt11> Can't find it atm
02:11:42 <nhnt11> ah
02:11:44 <clokep> Ah, nvm. Figured it out
02:11:50 <nhnt11> Weird
02:11:54 <nhnt11> The menubar changes for the scratchpad
02:12:01 <nhnt11> this time, didn't change till I switched to a different app and back
02:13:24 <clokep> :-S
02:13:35 <clokep> It says I'm running with browser context, but Components is undefined.
02:13:49 <nhnt11> WFM
02:14:21 <clokep> I also find the scratchpad to be pretty much garbage.
02:14:40 <clokep> It's very difficult to use.
02:14:56 <nhnt11> clokep: Easier than Ib's Error Console
02:16:24 <clokep> nhnt11: I strongly disagree.
02:16:38 <clokep> What does "Run" vs "Inspect" vs "Display" do?
02:16:45 <clokep> Sometimes they print weird comments out, but what do they represent?
02:16:52 <nhnt11> I've only ever used Run
02:25:48 <clokep> \o/
02:34:40 * nhnt11 wonders what clokep accomplished
02:36:49 <clokep> nhnt11: Uploading in a minute, I'll show you.
02:39:30 <-- wnayes has quit (Ping timeout)
02:42:50 --> wnayes has joined #instantbird
02:58:00 <-- Rym_ has quit (Ping timeout)
03:03:39 * mconley|food is now known as mconley
03:09:35 <-- wnayes has quit (Quit: wnayes)
03:18:59 <-- mconley has quit (Ping timeout)
03:19:27 --> mconley has joined #instantbird
03:45:33 --> Mook has joined #instantbird
03:57:54 <-- clokep has quit (Ping timeout)
04:08:00 <-- mconley has quit (Input/output error)
05:46:19 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
05:46:26 --> nhnt11 has joined #instantbird
05:54:07 --> mpmc has joined #instantbird
06:11:25 <-- EionRobb has quit (Quit: Leaving.)
06:19:31 * Fallen|away is now known as Fallen
06:23:29 --> gerard-majax__ has joined #instantbird
06:31:29 <-- gerard-majax__ has quit (Ping timeout)
06:46:21 --> gerard-majax__ has joined #instantbird
06:59:03 <-- gerard-majax__ has quit (Ping timeout)
07:00:20 --> gerard-majax__ has joined #instantbird
07:20:07 <-- gerard-majax__ has quit (Ping timeout)
07:21:11 --> gerard-majax__ has joined #instantbird
07:24:23 <-- gerard-majax__ has quit (Ping timeout)
07:50:58 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
07:59:47 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
08:01:07 --> chrisccoulson has joined #instantbird
08:02:11 --> gerard-majax__ has joined #instantbird
08:09:25 --> mpmc has joined #instantbird
08:31:28 --> sonny has joined #instantbird
08:31:40 <-- sonny has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
08:54:43 * Fallen is now known as Fallen|away
09:28:25 --> aleth has joined #instantbird
09:28:26 * ChanServ sets mode +o aleth 
09:29:07 <-- aleth has quit (Quit: exit stage left)
09:29:10 --> aleth has joined #instantbird
09:29:10 * ChanServ sets mode +o aleth 
09:31:20 * Fallen|away is now known as Fallen
09:35:13 --> BWMerlin has joined #instantbird
09:40:48 <aleth> sawrubh: A lot of the download panel code is in toolkit, so you can use it from IB directly.
09:41:30 <aleth> Don't put off looking at the interfaces used there too long, so you don't reinvent the wheel (e.g. for telling the UI about the progress of a download, cancelling downloads etc)
09:47:40 <aleth> clokep: There's a pref you need to set before you can enable chrome in scratchpad
09:50:45 <Fallen> aha, bitten by the autocomplete-for-parted-nicks feature or just typed his name out of habit? :-)
09:51:19 <aleth> Neither, I typed it by hand ;)
09:51:36 <Fallen> ah rats, I thought I could prove my point :-)
09:51:43 <aleth> The parted-nicks thing only works for a couple of minutes after someone leaves.
09:52:01 <aleth> Unless you're bouncering, of course ;)
09:52:08 <Fallen> I'm feeling pretty bouncy :-)
09:52:26 <aleth> We really need to add that bouncy pref for you then.
09:52:34 <Fallen> I've disabled the feature in an extension actually, so I am good
09:52:43 <Fallen> I still need to pref it though
09:52:52 <Fallen> "when there is time" :-)
09:53:05 <aleth> yeah...
09:53:25 * aleth is spending all his mozilla time on gsoc mentoring atm
09:54:25 <-- Fallen has quit (Quit: ZNC - http://znc.sourceforge.net)
09:58:56 <sawrubh> aleth: yo, also what was that comment you had made "pretty soon you must figure out what objects..." on that etherpad we were discussing xmpp file transfer
10:00:13 <aleth> I don't remember but I guess the comment meant "make sure you understand how the UI and the backend talk to each other" ;)
10:00:28 --> Fallen|away has joined #instantbird
10:01:09 <aleth> nhnt11: So are you going to land the async patches today? :)
10:01:41 <aleth> Do it soon before the tree breaks again ;)
10:03:25 * Fallen|away is now known as Fallen
10:03:57 --> clokep has joined #instantbird
10:03:57 * ChanServ sets mode +o clokep 
10:04:19 <-- aleth has quit (Ping timeout)
10:07:22 <nhnt11> sawrubh: Ping
10:07:36 <nhnt11> aleth: Hopefully
10:07:37 <nhnt11> :D
10:07:52 * nhnt11 is going to push to try in a bit
10:08:14 <-- flo-retina has quit (Ping timeout)
10:17:06 <nhnt11> clokep: ping
10:18:05 <nhnt11> I want to push to try, I have 3 patches applied. I'm going to do a |hg qnew -m "try: <options>" try| and then push. I'm confused by all the options ;S
10:18:41 <nhnt11> Should I just use default options?
10:18:53 <nhnt11> I don't know if  I should be running only some specific unit tests..
10:19:17 <nhnt11> Nor if I need to do both debug and optimized builds. (I think one of them would suffice)
10:20:08 <clokep> nhnt11: What's your goal?
10:20:13 <clokep> Do you know of try-chooser?
10:20:34 <nhnt11> Yeah.. Hence the "try: <options>" commit message
10:20:44 <nhnt11> or do you mean the hg extension?
10:20:55 <nhnt11> clokep: The goal is to ensure unit tests pass
10:21:05 <nhnt11> Gloda ones, I'm guessing
10:21:15 <nhnt11> Since logger.js didn't have any tests before
10:21:16 <clokep> nhnt11: http://trychooser.pub.build.mozilla.org/
10:21:29 <nhnt11> "This connection is untrusted" :S
10:21:44 <nhnt11> "You don't have permission to access /error/noindex.html on this server."
10:22:00 <clokep> nhnt11: Did it redirect to https for you?
10:22:04 <clokep> For it to not be.
10:22:19 <nhnt11> Yes it did.
10:23:05 <nhnt11> Disabling http-everywhere didn't help
10:23:13 <nhnt11> oh, that needed a restart
10:23:21 <nhnt11> Nvm, I see it now.
10:23:23 <nhnt11> Thanks!
10:23:37 * clokep just opened it in IE. ;)
10:24:10 <clokep> You have actually tested it in TB, right?
10:24:13 <nhnt11> Yes.
10:24:32 <clokep> You can probably restrict to just xpcshell tests, but I'm not sure what tests exist for gloda.
10:24:57 <nhnt11> Maybe I should ask on #maildev
10:25:12 <clokep> You should easily be able to look at what tests exist.
10:25:29 --> aleth has joined #instantbird
10:25:29 * ChanServ sets mode +o aleth 
10:26:32 <nhnt11> okay
10:31:29 --> flo-retina has joined #instantbird
10:31:29 * ChanServ sets mode +qo flo-retina flo-retina 
10:31:55 <clokep> nhnt11: Not thta asking is bad, but you should try to look it up yourself first. :)
10:32:54 <nhnt11> fair enough
10:33:06 <nhnt11> fwiw I'm looking and I don't really see any gloda specific tests, which can't be right
10:36:41 <clokep> aleth: ping
10:37:19 <clokep> nhnt11: http://dxr.mozilla.org/comm-central/search?q=path%3Agloda+path%3Atest&case=true&redirect=true
10:37:30 <clokep> Not saying any of those cover the IM code tohugh.
10:37:42 <nhnt11> oh, it's all in mailnews, duh
10:38:13 <nhnt11> clokep: Thanks :] Looks like there's no test_index_im.js..
10:38:52 * nhnt11 was trying to find gloda code, and was being super slow because he's talking to someone
10:39:24 <sawrubh> nhnt11: pong (I'm in a bank though)
10:39:45 <nhnt11> sawrubh: never mind, carry on.
10:40:38 <sawrubh> Anything urgent though?
10:41:47 <clokep> No
10:42:02 <clokep> Ah, that wasn't to me. :-D
10:42:16 <aleth> clokep: hi
10:42:23 <sawrubh> clokep: you also wanted to talk?
10:42:30 <clokep> sawrubh: Yes.
10:42:56 <sawrubh> Sorry I had slept in the morning by the time you came back
10:45:33 --> Rym_ has joined #instantbird
10:45:47 <clokep> sawrubh: OK, but I had expected a patch to be uploaded yesterday, as we discussed. This wasn't done and no explanation was provided. What's up?
10:46:13 <clokep> aleth: I asked in the bug.
10:53:15 * aleth hopes that can land before it bitrots again.
10:53:24 * aleth looks vaguely in the direction of flo-retina ;)
10:56:39 <nhnt11> Okay if there are no tests for IM indexing I'm not sure I should even be doing a try build :S
10:56:48 <-- douglaswth has quit (Ping timeout)
10:57:04 <aleth> nhnt11: You can run the TB tests locally before pushing to try anyway.
10:57:05 --> douglaswth has joined #instantbird
10:57:42 <aleth> My guess is flo asked for a try build purely to avoid any unpleasant TB surprises.
10:57:49 <nhnt11> aleth: So why push to try at all? So that people can test the builds?
10:57:50 <nhnt11> hmm
10:58:04 <nhnt11> Like building on a different platform or something?
10:58:15 <nhnt11> If it's to avoid unpleasant tb surprises, I'll go ahead and run xpcshell tests
10:58:18 <aleth> nhnt11: It can build and test on all OS, and some tests are hard to run locally(mozmill).
10:58:38 <nhnt11> alright
10:59:07 <aleth> I'd be very surprised if you encountered any issues in your try build.
11:01:18 <-- clokep has quit (Ping timeout)
11:01:32 <nhnt11> So I'm thinking |try: -b do -p linux,linux64,macosx64,win32 -u xpcshell -t none|
11:05:35 <aleth> seems ok
11:06:21 * nhnt11 is a bit distracted atm, sorry for the slowness
11:08:43 <nhnt11> bah, preoutgoing.mq-no-push :-/
11:08:52 * nhnt11 wonders how to disable that for try pushes
11:12:38 <aleth> qnew before trying.
11:12:52 <nhnt11> I did.
11:13:23 <nhnt11> hg is preventing me from pushing because I have patches applied :S
11:13:27 <nhnt11> Even with push -f ...
11:13:53 <aleth> hmm, maybe ask on #maildev?
11:15:03 <aleth> push -f should really do the trick :-/
11:17:32 <nhnt11> I just commented out the hook and pushed
11:18:43 <aleth> Where did that hook come from? Did you add it?
11:19:13 <nhnt11> I think it's a mach thing
11:19:49 <aleth> I don't think mach modifies your hgrc
11:20:14 <nhnt11> I think |mach mercurial-setup| does some stuff there
11:20:22 <aleth> Ah, I never used that.
11:20:24 <nhnt11> I'm sure I didn't add that myself :)
11:20:35 * aleth wrote his own hooks ;)
11:22:17 <aleth> Is that the only hook it added, or are there other ones?
11:29:48 --> mayanktg has joined #instantbird
11:32:36 <nhnt11> aleth: There's one for pull and one for push
11:33:44 <aleth> Thanks. Makes sense. I have one for pulling which does a qpop -a automatically
11:34:32 <nhnt11> aleth: Does your hook also have a clever way of restoring your queue to original state after the pull?
11:35:03 <aleth> No... though I guess it would be possible to store the current state somewhere.
11:35:29 <aleth> It may fail to reapply though, so I prefer to do that by hand.
11:37:04 * Fallen is now known as Fallen|away
11:41:20 --> clokep_work has joined #instantbird
11:41:20 * ChanServ sets mode +o clokep_work 
11:42:20 <mayanktg> aleth: How do I add the notificationbox? The callee should get the notification to accept/reject the call when I send the "offer" to the conversation binding through notifyObservers() .
11:42:46 <aleth> mayanktg: There's already a notificationbox in conversation.xml, use that.
11:44:32 <flo-retina> aleth: what are you looking for in my direction?
11:44:55 <aleth> flo-retina: bug 1014472
11:45:08 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1014472 nor, --, ---, aleth, ASSI, Support automatic MUC reconnection for all protocols
11:46:15 <flo-retina> nhnt11: I asked for a try push because you are adding new tests.
11:46:30 <flo-retina> gloda may also have some mozmill tests, but I'm not sure
11:47:18 <nhnt11> flo-retina: to ensure the new tests pass on all platforms?
11:48:23 <flo-retina> yes
11:55:09 --> Armada has joined #instantbird
11:57:02 --> nhnt11-phone has joined #instantbird
11:57:25 <nhnt11-phone> Had to run out for a bit, be back soon.
11:57:31 <-- nhnt11-phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
12:05:11 <-- aleth has quit (Ping timeout)
12:10:21 --> aleth has joined #instantbird
12:10:21 * ChanServ sets mode +o aleth 
12:10:34 <clokep_work> sawrubh: So ping me when you're back onlien.
12:11:33 <flo-retina> sawrubh: and please upload ASAP that patch you promised yesterday ;)
12:12:04 <flo-retina> clokep_work will starve if he doesn't have a patch to eat for lunch ;).
12:12:15 * clokep_work is eating breakfast.
12:17:47 <-- Rym_ has quit (Ping timeout)
12:37:27 --> Mic|web has joined #instantbird
12:45:04 <mayanktg> Added the notificationbox :) . adding accept and reject call buttons to it. 
12:45:58 <Mic|web> mayanktg: do you mean a notification *bar*?
12:46:41 <Mic|web> There's a notification box already where you can add your notification bars to be shown above the conversation content...
12:46:42 <aleth> Pretty sure he means one of these https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/notificationbox ;)
12:47:16 <aleth> It's a bit unfortunate it's not called a bar... probably inherited from hbox/vbox
12:47:20 <mayanktg> Mic|web: Yes. I'm using one of the defined in the conversation.xml :)
12:49:14 <Mic|web> i.e. you're calling "appendNotification" on the already defined notificationbox most likely?
12:49:42 <mayanktg> Mic|web: Yes. I'm doing that. Is there some other way around?
12:49:57 <Mic|web> No, no. That's just what I thought you'd do :)
12:51:48 * aleth wonders what should happen if the conv/IB doesn't have focus.
12:52:17 <mayanktg> http://i.imgur.com/72B56mkl.jpg . Also The "label" should contain the name of the caller in the notification. "You are receiving a Call from A" .I'm figuring out how to add it. 
12:53:47 <aleth> mayanktg: Isn't the name obvious from the tab?
12:53:50 <Mic|web> mayanktg: what's the problem with the label?
12:54:13 --> Rym_ has joined #instantbird
12:54:36 <aleth> this.conv.name if you want to use it.
12:54:39 <mayanktg> aleth: Oh yeah! I almost forgot that ;)
12:55:01 <mayanktg> aleth: It should behave like when someone mentions you in a conversation? The tab title changes to blue color?
12:55:02 <Mic|web> mayanktg: make sure that it's localized.
12:55:20 <Mic|web> mayanktg: What about a toaster popup notification?
12:55:48 <mayanktg> Mic|web: Currently it isn't. I'll localize it.
12:56:09 <aleth> The ping idea is a good one though. We could have a toaster iff the user has toasters enabled for pings.
12:56:12 <Mic|web> You can click the notification to accept the call and click its [x] button to reject it.
12:56:20 <mayanktg> Mic|web: idk about taster popup notification :-/
12:56:46 --> qheaden has joined #instantbird
12:57:29 <Mic|web> mayanktg: that's a name for the notifications shown in a corner of the screen, outside of any window.
12:57:32 <aleth> mayanktg: Preferences->General->Notify of messages...
12:57:48 <Mic|web> Like the one that you might see when receiving a directed message in an inactive window.
12:58:02 <-- BWMerlin has quit (Quit: BWMerlin)
12:58:08 <mayanktg> Mic|web: Yepp. Understood. I didn't know what its called :)
12:58:30 <Mic|web> I don't like the name. I usually call them just "popup notification".
12:58:55 <clokep_work> aleth: Yes, I think it should be treated just likea  new message!
12:59:10 <qheaden> Hello everyone.
13:00:36 <clokep_work> Hello qheaden.
13:00:52 <qheaden> clokep_work: FYI, I've been testing out Yahoo messenger. I've basically been testing the single chat, not so much group chat, since I don't have a group of friends on Yahoo.
13:01:02 <qheaden> Things are working pretty smoothly.
13:01:34 <qheaden> I still need to look into the bugs blocking turning on JS-Yahoo by default.
13:03:06 <aleth> Mic|web: Did you see mayanktg had a question about the in-call UI
13:03:24 <clokep_work> qheaden: Awesome. :) I think we're close.
13:03:39 <aleth> yay :)
13:03:39 <qheaden> I think so too. :)
13:06:28 <mayanktg> Mic|web: Yes. We should have a final prototype about the in-call UI. For eg Idk yet where to put the call disconnect button. It would be great if we decide it soon. :-o
13:18:51 <Mic|web> Do you have some ideas how to end a call? What's the pros and cons for each?
13:23:02 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:23:37 <Mic|web> What does the button look like when you think about it?
13:23:49 <mayanktg> I had this prototype where after call has been established there would be menu to end call, hold, mute etc.
13:23:53 <mayanktg> http://i.imgur.com/UcxFIju.png
13:24:27 <mayanktg> Pros: It would be neat and clear. Cons: Difficult to identify.
13:25:38 <mayanktg> imo the "end call" button should be inside the video stream. Maybe top-right.
13:25:48 <Mic|web> OK, that's an idea.
13:26:01 <aleth> What does "hold" do?
13:26:42 <Mic|web> Is it an [x] or a struck through / crossed out "video call" icon?
13:27:51 <mayanktg> aleth: The stream would be paused (not disconnected). It was an idea to implement it.
13:27:58 * aleth likes [x]
13:28:19 <Mic|web> Shouldn't we position the icon using start/end instead of left(right?
13:28:34 <mayanktg> me too.. [x] would be better.
13:28:57 <Mic|web> Same for the "Remove user icon" button on the new panel.
13:28:58 <aleth> It also needs a fullscreen button imho
13:29:19 <flo-retina> [X] is a nice way to display "end call"
13:29:31 <Mic|web> aleth: eventually yes.
13:29:38 <aleth> Eventually, sure.
13:29:40 <mayanktg> aleth: yes. its a fullscreen button. We ca change its position.
13:29:44 <flo-retina> I was wondering if we couldn't have only one icon visible all the time, and when hovering it, it would expand to a larger set of icons
13:29:53 <flo-retina> including mute sound, mute camera, fullscreen, etc...
13:30:25 <Mic|web> mayanktg: ah, is "Hold" something like "Mute" but extending to the camera as well?
13:31:10 <sawrubh> clokep_work: I'm back online and working on that UI patch
13:31:24 <mayanktg> Mic|web: yes. That's what I though of. A person doesn't want to show the video stream for a momen, so he put the video on hold.
13:31:39 <mayanktg> *moment
13:32:04 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:32:16 <Mic|web> Like ... when he needs to change his pants in mid-conversation? :P
13:32:17 <Mic|web> scnr
13:32:57 <mayanktg> flo-retina: Maybe only remoteVideo and localVideo are visible --> when person hovers over the videoBox --> other buttons appear in their desired place.
13:34:00 <mayanktg> Mic|web: eventually, exactly! :D
13:34:37 <aleth> mayanktg: For the first patch to land, I think you can get away with just the [X] on hover.
13:35:06 <Mic|web> aleth, mayanktg: I think so too.
13:35:08 <aleth> Mute, hold, fullscreen all sound like followups. Just so something can land soon...
13:37:38 <mayanktg> aleth: Ok. Also I had one problem. I'm bitroting my own patches. When I change a thing from one of the patches some part of the latter one gets bitrotten and I have to fix it up :-/
13:38:21 <Mic|web> mayanktg: yes, I know I need to do the reviews :(
13:38:34 <mayanktg> Mic: Yeah. It would be in the follow ups. :)
13:40:01 <sawrubh> clokep_work: do you a minute to talk about whether I should use a prplIFileTransfer object to notify the UI about the file transfer offer, you had raised this point during yesterday's discussion
13:40:16 <mayanktg> Mic|web: Please review the generic icon bug first whenever you get time. :) 
13:40:58 <sawrubh> aleth: ^ so we were discussing how to signal the UI of the receiver about the file transfer offer by the sender
13:41:34 <clokep_work> sawrubh: It depends on how you plan to notify the UI and interact with an ongoing file transfer.
13:42:02 * Fallen|away is now known as Fallen
13:44:51 <-- aleth has quit (Ping timeout)
13:49:16 <-- Mic|web has quit (Ping timeout)
13:58:19 --> flo-retina has joined #instantbird
13:58:19 * ChanServ sets mode +qo flo-retina flo-retina 
13:58:20 --> mconley has joined #instantbird
13:58:52 --> Mic|web has joined #instantbird
14:14:44 <nhnt11> re
14:14:47 <-- Rym_ has quit (Ping timeout)
14:15:37 <nhnt11> clokep_work: What does it mean if a try build is "Burning"?
14:16:30 <clokep_work> nhnt11: Probably that all your tests are failing? :P
14:17:16 * nhnt11 is checking the build log
14:18:50 <sawrubh> nhnt11: ^5
14:19:02 <nhnt11> 5?
14:19:27 <sawrubh> high five, it sees you're burning the tree for the first time, it's always a good feeling ;)
14:19:33 <sawrubh> *seems
14:19:55 <nhnt11> What does "burning the tree" mean :S
14:19:59 <nhnt11> doesn't sound good :P
14:21:08 <sawrubh> either it's not compiling or some of your test is failing, if it's red, then it's burning
14:21:27 <nhnt11> Some packaging fault
14:25:42 <sawrubh> nhnt11: I removed the link from remove-files.in in my case,
14:25:52 <sawrubh> in you case it should be something similar
14:26:16 <nhnt11> I'm not comfortable touching random files like that :S
14:26:16 <sawrubh> *lne
14:26:23 <sawrubh> *line
14:26:24 <nhnt11> I mean for a push
14:27:47 * sawrubh is checking TB-Try and Trunk if this error is htere too
14:28:30 <sawrubh> nhnt11: cool so https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=7a876ebc3a69 is busted too
14:28:38 <sawrubh> seems like it's not your fault
14:28:50 <nhnt11> yeah
14:28:51 <nhnt11> cool
14:29:24 <sawrubh> ask flo or cloke otherwise notify people in #maildev
14:31:52 <clokep_work> nhnt11: It's probably starred on Thunderbird-Trunk then.
14:31:55 <clokep_work> You can follow the bug there.
14:32:09 <clokep_work> Looks like we're busted right now: http://buildbot.instantbird.org/tgrid
14:36:53 * nhnt11 sighs
14:37:05 <nhnt11> guess I won't be pushing async logs any time soon...
14:37:11 <nhnt11> (well.. maybe. idk)
14:44:03 <clokep_work> nhnt11: Mark it as checkin-needed and leave it.
14:44:17 <clokep_work> ALthough Joshua said the fix is easy.
14:44:23 <nhnt11> clokep_work: What about the try build?
14:44:30 <nhnt11> I meant I need to wait till a try build works...
14:45:21 <clokep_work> nhnt11: Wait until someone fixes it, then re-push?
14:45:25 <nhnt11> yeah
14:50:46 <sawrubh> Just curious, I've seen people saying 'js prpls' (http://log.bezut.info/instantbird/140617/#m574) when referring to js implementations of protocols, but isn't purple the name of the library, why do we use 'prpl' with js?
14:55:17 <nhnt11> sawrubh: prpl= protocol plugin
14:55:24 <nhnt11> doesn't refer to libpurple
14:55:56 <sawrubh> ah
14:58:36 <Mic|web> sawrubh: I think I've heard that (lib)p(u)rpl(e) got it's name from that, not the other way round...
15:36:43 <clokep_work> sawrubh: protocol plugin = prpl = purple, the library of which is libpurple, as nhnt11 and Mic|web said.
15:36:53 <clokep_work> So we adopted it for our protocol plugins also, but we use prpl everywhere.
15:45:20 <-- gerard-majax__ has quit (Ping timeout)
15:50:33 --> rosonline has joined #instantbird
15:54:28 <-- nhnt11 has quit (Ping timeout)
15:55:22 --> nhnt11 has joined #instantbird
15:59:20 <-- flo-retina has quit (Ping timeout)
16:00:27 --> flo-retina has joined #instantbird
16:00:27 * ChanServ sets mode +qo flo-retina flo-retina 
16:00:55 <flo-retina> sawrubh: we use "prpl" when it's related to a protocol plugin, and "purple" when it's related to libpurple
16:06:18 <clokep_work> Can someone please port https://hg.mozilla.org/comm-central/rev/852267c1a357 for im/?
16:06:45 <flo-retina> clokep_work: nhnt11 can ;)
16:12:03 <clokep_work> I was going to suggest him or maybe qheaden.
16:12:15 * clokep_work doesn't like assigning work. :)
16:13:36 <flo-retina> clokep_work: I'm saying nhnt11 because he's the one blocked by that bustage ;)
16:14:17 <nhnt11> afk, really sorry
16:14:54 <qheaden> You wanted something like this? http://pastebin.mozilla.org/5430613
16:15:12 <qheaden> Better: http://pastebin.mozilla.org/5430615
16:16:48 --> gerard-majax__ has joined #instantbird
16:20:04 --> yash_ has joined #instantbird
16:23:34 <clokep_work> qheaden: Sure, and make sure it works. :P
16:31:43 <-- gerard-majax__ has quit (Ping timeout)
16:34:13 <nhnt11> re
16:36:05 --> gerard-majax__ has joined #instantbird
16:36:29 <nhnt11> flo-retina: I'm not totally blocked on the bustage, I'm learning how to use sqlite.jsm at the moment
16:36:48 <-- rosonline has quit (Client exited)
16:37:23 <flo-retina> nhnt11: I thought you wanted to land and can't?
16:39:13 <nhnt11> flo-retina: Erm yeah, but I still have other stuff to do...
16:39:20 <nhnt11> Just saying. Not that I mind porting that to im/
16:41:15 <-- qheaden has quit (Ping timeout)
16:46:04 --> iamjayakumars has joined #instantbird
16:46:07 --> Hadi has joined #instantbird
16:53:04 <flo-retina> nhnt11: I think everybody has other stuff to do ;)
16:53:20 <nhnt11> "Just saying. Not that I mind porting that to im/" :)
16:53:34 <nhnt11> Uh, is qheaden on it?
16:53:52 <nhnt11> seemed like he was.. but he's offline and I have no idea if he posted a patch somewhere
16:54:58 --> qheaden has joined #instantbird
16:55:12 <-- gerard-majax__ has quit (Ping timeout)
16:57:05 --> Mook_as has joined #instantbird
16:57:19 --> gerard-majax__ has joined #instantbird
16:59:15 <-- qheaden has quit (Ping timeout)
16:59:42 <-- gerard-majax__ has quit (Ping timeout)
17:03:12 --> qheaden has joined #instantbird
17:10:36 <clokep_work> nhnt11: He posted a pastebin, but he's back. qheaden
17:11:08 <qheaden> nhnt11: http://pastebin.mozilla.org/5430615
17:11:18 <qheaden> I'm running a compile now to see if that fixes the build.
17:11:55 <qheaden> clokep_work: A successful build would mean the patch works, correct? Or is there more involved to test?
17:12:33 <clokep_work> qheaden: You need to package.
17:12:38 <qheaden> Okay.
17:12:42 <clokep_work> qheaden: Thanks. :)
17:12:50 <qheaden> Sure. :)
17:15:03 <-- iamjayakumars has quit (Quit: )
17:15:21 --> gerard-majax__ has joined #instantbird
17:18:39 <-- gerard-majax__ has quit (Ping timeout)
17:25:54 <nhnt11> flo-retina: Any thoughts on the data type I should use to store the contents of a log file?
17:26:05 <nhnt11> From stuff I'm reading, looks like MEDIUMTEXT would be a good bet
17:26:58 <flo-retina> http://mxr.mozilla.org/comm-central/search?string=mediumtext gives no result :-S
17:27:23 <nhnt11> Hmm..
17:28:15 <flo-retina> http://libdbi-drivers.sourceforge.net/docs/dbd_sqlite/x121.html (random google result) says "One noticeable difference between SQLite and other SQL database engines is that the former is typeless. All data are stored as strings, and you can insert any type of data into any column."
17:28:39 <nhnt11> uh
17:28:40 <nhnt11> oops
17:28:48 * nhnt11 should have found that out himself..
17:29:38 <flo-retina> nhnt11: heh, it's confusing that the tables are declared with types for each column when they aren't very relevant ;)
17:30:01 <flo-retina> IIRC they do that only to help compatibility with SQL code initially written for other SQL databases
17:30:13 <nhnt11> yeah, makes sense
17:30:21 <nhnt11> I guess I'll just use TEXT then
17:30:26 <nhnt11> seems the most sensible..
17:30:43 <nhnt11> And VARCHAR for stuff like paths and filenames
17:32:03 --> mpmc has joined #instantbird
17:32:47 --> Even has joined #instantbird
17:32:47 * ChanServ sets mode +o Even 
17:36:10 <-- douglaswth has quit (Input/output error)
17:36:20 <sawrubh> flo-retina: just curious, who does the rate limiting or throttling in xmpp or is that done on a lower level in the OSI stack?
17:41:20 <flo-retina> the server
17:49:37 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
17:53:40 <-- mayanktg has quit (Ping timeout)
17:57:35 --> mayanktg has joined #instantbird
18:02:49 <-- Hadi has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:08:16 --> douglaswth has joined #instantbird
18:19:46 <-- mconley has quit (Ping timeout)
18:20:15 --> mconley has joined #instantbird
18:52:28 --> Hadi has joined #instantbird
19:12:53 <nhnt11> flo-retina: Does an insert statement have any results? I'm trying to get the id (primary key) of the newly inserted row without executing another statement
19:13:25 <nhnt11> When I google I keep getting references to PHP's mysql_insert_id() which gives the id of the last insert
19:13:33 <nhnt11> Can't find anything similar in sqlite.jsm
19:14:24 <flo-retina> nhnt11: in imContacts.js that was DBConn.lastInsertRowID
19:14:29 <flo-retina> not sure how sqlite.jsm deals with that
19:14:58 <nhnt11> I'm looking at the file and haven't found anything I could use so far.
19:21:42 <nhnt11> Hmm.. https://bugzilla.mozilla.org/show_bug.cgi?id=930408 :(
19:21:45 <instantbot> Bug 930408 nor, --, ---, nobody, NEW, Remove affectedRows and lastInsertRowID from Sqlite.jsm documentation
19:25:55 <-- mayanktg has quit (Ping timeout)
19:26:49 --> mayanktg has joined #instantbird
19:33:18 <nhnt11> flo-retina: Any ideas? The only thing I can think of atm is to manually set the id's and store them in a JSON file or something...
19:36:33 <nhnt11> I ran a script in scratchpad btw to test the result of an insert statement. Object.keys(result) was blank...
19:37:12 <flo-retina> nhnt11: you could run a SELECT query to find the latest id
19:37:15 <flo-retina> but that seems expensive
19:37:22 <nhnt11> Yeah, I wanted to avoid that
19:39:27 <nhnt11> Hmm, how about manual ids, but we only store the last one?
19:39:54 <nhnt11> After log sweeping, we dump the last file id somewhere (maybe in the database itself) and every time we want to update it, we increment and store again
19:40:06 <nhnt11> it=the index
19:44:17 <flo-retina> why do you need the ids then?
19:44:51 <nhnt11> What?
19:45:24 <nhnt11> not sure what you're asking sorry. The answer that comes to mind is "we want to avoid storing paths over and over" but you know that
19:47:31 <flo-retina> you need the id only when you are inserting, and never later?
19:48:22 <nhnt11> Yes.
19:48:40 <nhnt11> In the sense that later, I will be looking it up in one table, and using it to look up the path in another table
19:48:56 <nhnt11> erm I'm still confused what you're asking
19:50:38 <flo-retina> what about creating a view for your two tables, and having a trigger doing the inserts for you?
19:51:12 * nhnt11 looks up views
19:51:20 <flo-retina> nhnt11: http://www.sqlite.org/lang_createview.html
19:51:27 <nhnt11> i'm there already :)
19:55:25 <-- qheaden has quit (Input/output error)
20:00:14 --> qheaden has joined #instantbird
20:00:35 <-- qheaden has left #instantbird ()
20:00:42 --> qheaden has joined #instantbird
20:02:03 <qheaden> I just got home and checked my Instantbird compile. It compiled fine, but make package isn't working. I'm getting "Missing file" errors for bin/chrome/purple, bin/chrome/purple.manifest, bin/components/libpurplexpcom.so, etc.
20:02:14 <qheaden> I enabled the purple extension in my .mozconfig
20:03:19 <flo-retina> do you have the mozilla/extensions/purple folder checked out?
20:04:36 <qheaden> Yep.
20:04:45 <qheaden> Let me make sure my .mozconfig changes were picked up.
20:04:50 <qheaden> I initial built without purple.
20:04:54 <qheaden> *initially
20:07:10 <qheaden> Okay, I think the mach configure fixed it. Building now..
20:27:05 --> EionRobb has joined #instantbird
20:32:15 <qheaden> flo-retina: Unfortunately, I still get the errors. They are here: http://pastebin.mozilla.org/5431664
20:32:31 <qheaden> FYI I am using Linux to compile.
20:32:53 <flo-retina> has libpurple been built?
20:33:36 * qheaden sighs
20:33:58 <qheaden> I typed --enable-extension instead of --enable-extensions
20:34:02 <qheaden> Let me try again.
20:34:33 * Fallen is now known as Fallen|away
20:35:15 <-- Hadi has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:37:45 <clokep_work> Arg. :(
20:44:39 * qheaden wishes he could try building completely in a ramdisk for fun.
20:46:46 <clokep_work> All you kids seem obsessed w/ ramdisk. :P
20:47:46 <qheaden> The day they actually come out with ram that can keep data after a shutdown, people will probably say that hard disks are going to die. :P
20:48:17 <qheaden> They will die, just like PC gaming is "dying" :P
21:01:00 <clokep_work> Sure, but that's just a hard disk then, isn't it? ;)
21:02:23 <flo-retina> isn't that what we call SSD?
21:07:57 <-- clokep_work has quit (Ping timeout)
21:16:59 <sawrubh> flo-retina: so I need to pass an object containing the fileName, fileSize and what to do when accept or reject is done from xmpp.jsm to UI (conversation,xml)
21:17:43 <sawrubh> using notifyObservers, I think I'll be able to retrieve the name and size but when I tell in the UI that upon clicking the accept button call the accept function
21:18:03 <sawrubh> which I defined in xmpp.jsm, I don't think it'll work, because the body of accept is defined in xmpp.jsm, right?
21:18:30 <sawrubh> so what's the workaround? btw I want to send an object like http://pastebin.instantbird.com/737976 to the UI
21:18:31 <flo-retina> sawrubh: I think that's the reason why clokep mentioned a prplIFileTransfer interface that you may need to create
21:19:02 <flo-retina> where is imFileTransferOffer defined?
21:19:32 <sawrubh> currently nowhere, I wanted to remove L26 and just pass that obkect without and QueryInterface defined
21:20:13 <sawrubh> if I decide to create a prplIFileTransfer, then I;ll keep L26 and define an imFileTransferOffer in prplIFileTransfer.idl that I create
21:20:15 <flo-retina> it seems what you actually want is defining that interface in an idl file
21:20:48 <flo-retina> sawrubh: the "im" prefix means it's implemented by the chat core. The "prpl" prefix means it's implemented by the protocol plugins.
21:20:54 <sawrubh> but I wanted to know if the former is possibel (that is without definig any interfaces do this back and forth business between the UI and backend)
21:21:26 <sawrubh> I mean define the logic of the accept button in xmpp.jsm but call it from conversation.xml
21:21:50 <flo-retina> it's probably technically possible, but not without receiving an r- from me ;)
21:22:49 <sawrubh> :P
21:25:04 <flo-retina> sawrubh: the reason why we have interfaces is to have a single place that defines clearly what can be passed between the UI and the back-end
21:25:23 <flo-retina> so you can expect reviewers to defend that pretty strongly ;)
21:26:19 <sawrubh> ok
21:26:40 <flo-retina> writing an interface isn't difficult btw
21:26:48 <sawrubh> yeah, I know
21:26:53 <sawrubh> one question
21:27:26 <sawrubh> so we implement Conversation, ConvIM and other things in js, then why don't we name the idl as 'im'
21:28:03 <sawrubh> they are named as prplIConversation.idl, what does protocol plugin mean? is js-xmpp a plugin over xmpp, like libpurple might be another plugin over xmpp?
21:28:41 <flo-retina> sawrubh: protocol plugins is anything in chat/protocols/
21:29:12 <flo-retina> 'im' is what's implemented in chat/components/src/
21:29:37 <sawrubh> is this documented somewhere?
21:29:53 <sawrubh> (just curious, if I should have read it before)
21:30:07 <sawrubh> otherwise I'll blog about this
21:30:22 <sawrubh> and other things about the IB codebase I've learnt
21:30:31 <flo-retina> I was just going to suggest that you may want to document that on some wiki page :)
21:31:19 <flo-retina> "protocol plugins is anything in chat/protocols/" actually, that's what we call js-prpls.
21:31:34 <flo-retina> there are also protocol plugins implemented in C in mozilla/extensions/purple/libpurple/protocols/
21:39:46 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
21:41:17 <-- mconley has quit (Input/output error)
21:46:01 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:50:00 <-- EionRobb has quit (Ping timeout)
21:51:05 --> EionRobb has joined #instantbird
21:51:13 <sawrubh> flo-retina: it all makes sense now!
22:11:00 --> mconley has joined #instantbird
22:19:37 <-- mconley has quit (Input/output error)
22:22:11 --> wnayes has joined #instantbird
22:24:08 <-- nhnt11 has quit (Ping timeout)
22:25:03 --> nhnt11 has joined #instantbird
22:25:57 <-- Mook_as has quit (Quit: Mook_as)
22:29:33 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:36:04 --> Mook_as has joined #instantbird
22:36:29 --> Rym_ has joined #instantbird
22:41:32 <-- nhnt11 has quit (Ping timeout)
22:42:33 --> nhnt11 has joined #instantbird
22:45:12 <-- nhnt11 has quit (Ping timeout)
22:45:58 --> nhnt11 has joined #instantbird
22:57:34 <-- Rym_ has quit (Ping timeout)
22:59:03 --> Rym_ has joined #instantbird
23:02:44 <-- Rym_ has quit (Ping timeout)
23:04:23 --> Rym_ has joined #instantbird
23:04:29 <-- nhnt11 has quit (Ping timeout)
23:05:27 --> nhnt11 has joined #instantbird
23:06:16 --> clokep has joined #instantbird
23:06:16 * ChanServ sets mode +o clokep 
23:14:31 <-- nhnt11 has quit (Ping timeout)
23:15:30 --> nhnt11 has joined #instantbird
23:24:23 --> chrisccoulson has joined #instantbird
23:32:08 <-- nhnt11 has quit (Ping timeout)
23:32:44 --> nhnt11 has joined #instantbird
23:35:30 <-- Rym_ has quit (Ping timeout)
23:41:26 <-- Mook_as has quit (Input/output error)
23:46:01 <-- nhnt11 has quit (Ping timeout)
23:46:45 --> nhnt11 has joined #instantbird
23:51:51 --> Rym_ has joined #instantbird
23:52:36 --> Mook_as has joined #instantbird
23:55:03 <-- Armada has quit (Connection reset by peer)
23:57:52 <-- nhnt11 has quit (Ping timeout)
23:58:36 --> nhnt11 has joined #instantbird