#instantbird log on 06 17 2014

All times are UTC.

00:00:39 <-- clokep has quit (Ping timeout)
00:02:18 --> iamjayakumars has joined #instantbird
00:03:16 --> clokep has joined #instantbird
00:03:16 * ChanServ sets mode +o clokep 
00:04:04 <-- iamjayakumars has quit (Ping timeout)
00:23:55 --> iamjayakumars has joined #instantbird
00:25:53 --> mconley has joined #instantbird
00:26:49 <-- wnayes has quit (Ping timeout)
00:29:52 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
00:30:04 --> wnayes has joined #instantbird
00:33:34 <-- iamjayakumars has quit (Quit: )
01:05:40 <-- Mook_as has quit (Quit: Mook_as)
01:06:36 <-- clokep has quit (Ping timeout)
01:09:25 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
01:09:37 --> chrisccoulson has joined #instantbird
01:10:24 --> clokep has joined #instantbird
01:10:24 * ChanServ sets mode +o clokep 
01:16:17 <-- mpmc has quit (Ping timeout)
01:16:35 --> mpmc has joined #instantbird
01:33:25 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
02:02:36 <-- clokep has quit (Ping timeout)
02:07:51 <-- mconley has quit (Ping timeout)
02:08:19 --> mconley has joined #instantbird
02:13:43 <-- wnayes has quit (Quit: wnayes)
03:14:55 <-- mconley has quit (Input/output error)
03:16:49 <-- Rym has quit (Ping timeout)
04:29:20 --> micahg has joined #instantbird
04:46:15 --> gerard-majax_ has joined #instantbird
04:57:21 <-- gerard-majax_ has quit (Ping timeout)
05:03:44 --> gerard-majax_ has joined #instantbird
05:14:09 <-- gerard-majax_ has quit (Ping timeout)
05:16:09 --> mconley has joined #instantbird
05:17:57 <-- mconley has quit (Ping timeout)
06:05:50 --> gerard-majax_ has joined #instantbird
06:11:32 <-- EionRobb has quit (Quit: Leaving.)
06:21:52 <-- gerard-majax_ has quit (Ping timeout)
06:37:30 --> gerard-majax_ has joined #instantbird
06:42:15 <-- gerard-majax_ has quit (Ping timeout)
06:45:46 --> gerard-majax_ has joined #instantbird
06:51:38 * Fallen|away is now known as Fallen
06:51:48 <-- gerard-majax_ has quit (Ping timeout)
06:53:22 --> gerard-majax_ has joined #instantbird
06:56:16 <-- gerard-majax_ has quit (Connection reset by peer)
07:03:00 --> gerard-majax_ has joined #instantbird
07:12:46 <-- gerard-majax_ has quit (Ping timeout)
07:58:41 --> Rym has joined #instantbird
08:11:07 --> Armada has joined #instantbird
08:31:44 --> petunia has joined #instantbird
08:37:07 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
08:37:16 <-- petunia has quit (Ping timeout)
08:37:25 --> chrisccoulson has joined #instantbird
08:38:34 --> gerard-majax_ has joined #instantbird
08:38:58 --> gerard-majax__ has joined #instantbird
08:40:23 <-- gerard-majax_ has quit (Ping timeout)
08:46:39 --> mpmc has joined #instantbird
08:57:04 --> EionRobb has joined #instantbird
09:04:55 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:28:23 <-- flo-retina has quit (Ping timeout)
09:29:47 --> mayanktg has joined #instantbird
09:37:27 <-- Rym has quit (Ping timeout)
09:42:19 <nhnt11> mayanktg: I'm currently running a build with your patch. Is it enough for you if I edit stuff to make it look nice in the domI, post a screenshot, and note the changes I made in the bug?
09:42:48 <mayanktg> nhnt11: Yeah. absolutely. :)
09:43:17 <nhnt11> okay :) Is there anything in specific that you want me to test?
09:44:24 --> rosonline has joined #instantbird
09:44:41 <mayanktg> Could you check why the panel changes to weird shape when moving from retina to non-retina screen? I remember you showed me a snapshot of it earlier. :-o
09:44:56 <-- rosonline has quit (Connection reset by peer)
09:45:27 <nhnt11> mayanktg: seems to be an upstream bug, don't worry about it
09:46:00 <nhnt11> maybe there's a workaround though, i'm not sure
09:47:10 <mayanktg> nhnt11: Ok. Then just post the changes it would be needed for the fix. :)
09:49:59 --> rosonline has joined #instantbird
09:52:49 --> flo-retina has joined #instantbird
09:52:49 * ChanServ sets mode +qo flo-retina flo-retina 
10:03:02 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:03:06 --> flo-retina has joined #instantbird
10:03:06 * ChanServ sets mode +qo flo-retina flo-retina 
10:05:23 <sawrubh> nhnt11: any idea? code: http://pastebin.instantbird.com/737124 problem: in sendStanza (inside xmpp-session.jsm) aCallback is coming as undefined, even though when I'm printing what I'm passing as callback (on L568), it's printing allright
10:06:33 <nhnt11> sawrubh: Line 568 says that it's a function? where does it say that it's undefined?
10:06:46 <nhnt11> sendStanza sees it as undefined?
10:07:02 <sawrubh> nhnt11: L118
10:07:22 <sawrubh> *inside* sendStanza, aCallback (which I passed on L569) is coming as undefined
10:07:28 <nhnt11> hmm
10:07:29 <sawrubh> sendStanza is reaching fine
10:07:46 <-- Suiseiseki has quit (Ping timeout)
10:08:25 <sawrubh> btw in L1317 of xmpp.jsm, this technique has been used like I'm doing and it must be wokring
10:08:50 <flo-retina> fwiw, our friend from yesterday evening ended up asking stuff in #pidgin too ;).
10:08:55 <nhnt11> sawrubh: Are you sure that the sendStanza call that is showing the callback as undefined is coming from your code?
10:09:51 <sawrubh> yes, I can sandwitch that printing on L118 with another print and confirm
10:10:02 <sawrubh> but I'm very sure it's coming from mine
10:10:02 <nhnt11> or dump a stack trace ;)
10:10:05 <nhnt11> okay
10:10:28 <sawrubh> for a stack trace, it's Error.stack() right?
10:10:40 <nhnt11> sawrubh: Cu.reportError(new Error().stack)
10:10:47 <sawrubh> yeah
10:13:16 <nhnt11> Weird problem :S
10:15:35 <sawrubh> http://pastebin.instantbird.com/737155 yes it's me
10:16:37 <sawrubh> the weird thing is the dump on L568 says it's all fine and sendStanza finds it undefined :/
10:17:34 <nhnt11> sawrubh: Uh
10:17:40 <nhnt11> Look at line 3 in your pastebin
10:17:56 <nhnt11> There's a sendStanza call from xmpp.jsm
10:18:04 <nhnt11> That does this._connection.sendStanza(aStanz)
10:18:16 <sawrubh> ugh
10:18:18 <nhnt11> So what you actually need is this.conv._account._connection.sendStanza(
10:18:50 <nhnt11> need/want/whatever, I assume you know what  you're doing ;)
10:19:03 <sawrubh> got it, thanks
10:19:43 --> clokep has joined #instantbird
10:19:43 * ChanServ sets mode +o clokep 
10:19:48 <nhnt11> np
10:21:25 --> BWMerlin has joined #instantbird
10:24:01 <nhnt11> mayanktg: The image from the webcam needs to be mirrored
10:24:30 <nhnt11> In the current patch if I move my head to the right, my head in the image moves lef
10:24:32 <nhnt11> left*
10:25:36 <nhnt11> flo-retina: What do you think about this?^
10:25:45 --> Suiseiseki has joined #instantbird
10:25:46 <nhnt11> The final image will appear to be different from the preview
10:26:08 <nhnt11> That's expected for most "front facing" cameras these days though..
10:28:35 <nhnt11> mayanktg: By highlighting the "x" on mousing over the image, it appears that clicking on the image will remove it - whereas you need to actually click on top of the "x" itself for that. imho.
10:29:04 <flo-retina> nhnt11: no mirroring :-P
10:29:16 <flo-retina> we are displaying a preview of what would be set as the icon
10:29:47 <nhnt11> Mirror the icon too?
10:29:48 <flo-retina> if it looks unusual to you because you are used to seeing yourself in a mirror, that's not a problem we can really fix... (without making it more misleading)
10:30:03 <flo-retina> nhnt11: so that your face looks unusual to _all_ your friends?
10:30:34 <flo-retina> nhnt11: wait, are we talking about video calls, or the buddy icon patch?
10:30:41 <nhnt11> flo-retina: Buddy icon patch
10:30:45 <flo-retina> nhnt11: for video calls, I'm not against mirroring the local video.
10:30:50 <flo-retina> for buddy icons, we should not do it.
10:30:53 <nhnt11> Okay
10:31:05 <nhnt11> Almost every app I've ever used behaves how I said, so I suggested it
10:31:24 <nhnt11> It's true that mirroring the icon itself isn't a good solution
10:31:27 <nhnt11> (OS X does that btw)
10:31:32 <flo-retina> nhnt11: out of curiosity, how does your macbook behaves when it asks you to take a picture of yourself when creating your user account?
10:31:36 <nhnt11> But that's not for IM
10:31:49 <flo-retina> ah, it mirrors the account icon?
10:31:50 <nhnt11> flo-retina: Just checked that. It mirrors both the preview and the set icon.
10:31:55 <flo-retina> ok
10:32:05 <flo-retina> makes sense if you are the intended viewer of the icon I guess :)
10:32:09 <nhnt11> Yeah.
10:32:17 <mayanktg> nhnt11: In my system the remove "x" icon is working fine. I mean, the image is removed when i click on the "x" button.
10:32:46 <nhnt11> Interestingly both my phone and my dad's phone (both android) mirror the preview of the front facing camera, but do not mirror the picture that is taken
10:33:40 <nhnt11> mayanktg: I meant, the "x" button gets a different icon when the mouse hovers over the /image/ (not the "x" icon itself)
10:33:50 <nhnt11> This is misleading to me since clicking the /image/ doesn't do anything
10:36:54 <mayanktg> nhnt11: Oh :-/ So you're saying it should not change the "x" image when someone hovers over the image. Okay.
10:37:16 <nhnt11> mayanktg: that's my opinion, you should ask flo-retina ;)
10:38:36 <flo-retina> mayanktg: you've got the icon states confused there
10:38:57 <mayanktg> btw i thought it would be directional if we use grey-->(light red) hover--> (bright red) onfocus. 
10:39:24 <mayanktg> Ok. Then we'll use only two icon states?
10:39:30 <flo-retina> there should be one icon when the user is not hovering the [X], a different icon when the [X] is hovered, and a third 'active' icon when the [X] is being clicked but the mouse hasn't been released yet
10:40:04 <nhnt11> mayanktg: The problem with changing the icon when hovering on the /image/ rather than the /x/, is that I don't know yet that a third state exists
10:40:10 <flo-retina> mayanktg: look at what happens when clicking the [X] on conversation tabs
10:40:12 <mayanktg> flo-retina: got that.
10:41:33 <nhnt11> mayanktg: Maybe what you wanted is to have no "x" at all on an unhovered image, and an "x" when the image is hovered, and a highlighted "x" when the "x" itself is hovered
10:41:45 * nhnt11 shrugs.
10:41:59 <nhnt11> These are just my opinions/random ideas, like I said
10:42:15 <nhnt11> mayanktg: The size of these icons looks okay right?
10:42:16 <nhnt11> http://puu.sh/9xm5E/d3091c49ee.png
10:42:29 <nhnt11> (Can I go with these sizes for the retina ones when making changes?
10:42:52 <flo-retina> are they both coming from the same toolbar file this time?
10:43:10 <mayanktg> flo-retina: yes. they are from the toolbar.png you mentioned
10:43:37 <flo-retina> that camera icon looks blurry :-S
10:44:04 <flo-retina> but ok...
10:44:17 <mayanktg> I didn't alter its proportion in any way :(
10:44:38 <flo-retina> nhnt11: not sure what you are asking. The retina icons should have the same size; it just should have a PNG file with many more pixels
10:44:42 <flo-retina> mayanktg: did you resize it?
10:44:58 <mayanktg> flo-retina: No. 
10:45:01 <nhnt11> flo-retina: Currently they are bigger physical dimension-wise
10:45:12 <nhnt11> So I wanted to know if the size looked wrong on non-retina first
10:45:13 <flo-retina> oh, you are CSS-resizing them?
10:45:38 <mayanktg> I took 16X16 from the toolbar.png and 32x32 from the toolbar@2x.png. 
10:45:42 <nhnt11> retina display screenshot: http://puu.sh/9xmeT/f8d5414c7e.png
10:46:00 <mayanktg> And used as it .
10:46:53 <flo-retina> ok
10:48:33 <nhnt11> mayanktg: Okay so I notice you are using min-height everywhere. Can I ask why?
10:48:35 <clokep> It looks like they're actually the same size, just the size of each icon is so different (one is much taller) that it makes it look like the camera icon is the wrong size.
10:48:48 <nhnt11> Shouldn't you be setting width and height to 16px? Why are you using 15px?
10:49:32 <flo-retina> mayanktg, nhnt11: when looking at a zoomed screenshot, do you agree that camera icon doesn't look right? http://i.imgur.com/8dgu1Sw.png
10:49:42 <flo-retina> the toolbar.png file on the left side; your screenshot on the right side
10:50:54 <nhnt11> flo-retina: I never disagreed with you :)
10:51:00 <nhnt11> fwiw, the retina icon looks correct
10:51:08 <flo-retina> ok, so please fix that icon :)
10:51:15 <nhnt11> (just enlarged and therefore a little pixellated)
10:51:19 * nhnt11 is trying
10:51:30 <mayanktg> flo-retina: ok. I'll fix it now.
10:53:55 <nhnt11> flo-retina, mayanktg: http://puu.sh/9xmCP/6b8a50c538.png (retina
10:53:56 <nhnt11> )
10:54:27 <nhnt11> (the webcam icon doesn't seem blurred, but the margin seems off)
10:54:33 <nhnt11> bottom margin I mean
10:57:04 <flo-retina> nhnt11: you may need vertical centering or somethign
10:57:11 <nhnt11> yeah
10:57:13 <flo-retina> (if both icon files don't have the same size)
10:57:23 <flo-retina> can't you get 2 icon files at the same size though?
10:57:25 <nhnt11> I'm pretty sure they do
10:57:31 <nhnt11> Have the same size I mean
10:57:37 <nhnt11> I set the widths and heights to 16px
10:57:43 <flo-retina> is the camera icon centered in its file?
10:57:50 <nhnt11> Not sure
10:57:52 <nhnt11> Checking
10:58:28 <nhnt11> flo-retina: The non-retina icon file is blurry btw
10:58:44 <flo-retina> ok, get rid of it and ask for a new icon file then :)
10:58:46 <nhnt11> icons seem to be centered in the files
10:58:53 * flo-retina afk lunch
10:58:59 <mayanktg> the height of the two icons are different. if I recall correctly the webcam icon was 20px in height and select-file icon was 28px .
10:59:07 <mayanktg> Ok. I'm sending a new file then.
10:59:22 <nhnt11> mayanktg: Both the icons are 16x16 in the patch I downloaded
10:59:27 <nhnt11> And the retina ones are 32x32
10:59:32 <mayanktg> yes.
11:00:15 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:00:23 <nhnt11> mayanktg: The retina new-file icon is cropped incorrectly
11:00:43 <nhnt11> The space at the top is half the space at the bottom
11:01:14 <-- mayanktg has quit (Ping timeout)
11:01:26 --> mayanktg has joined #instantbird
11:01:35 <nhnt11> webcam image also seems to be cropped incorrectly (non-retina)
11:01:38 <mayanktg> Should I send you 4 new icon files?
11:02:04 <nhnt11> mayanktg: Upload a new patch on the bug instead if you're making changes :) 
11:02:13 <nhnt11> Easier to download and apply it that way...
11:02:16 <mayanktg> yeah..
11:02:28 <mayanktg> I meant it that way only.
11:02:41 <nhnt11> mayanktg: Btw to fix retina icon sizes I added "width 16px; height: 16px;" under #selectFileButton > .toolbarbutton-icon
11:03:21 <nhnt11> I'll document this on the bug too..
11:05:45 <nhnt11> mayanktg: How about I post an interdiff of my changes on the bug? :)
11:06:29 <mayanktg> nhnt11: It would be fine :)
11:07:42 <nhnt11> mayanktg: Wasn't there a way to do this stuff without negative margins everywhere? :(
11:09:38 <mayanktg> nhnt11: I tried very hard not to use negative margins, but I couldn't find another way. I mentioned about using negative margins here, before using them :(
11:09:55 <nhnt11> bah, UI...
11:10:09 <nhnt11> Maybe I should say *GUI* ;)
11:17:06 --> mconley has joined #instantbird
11:18:10 <-- mayanktg has quit (Ping timeout)
11:18:53 <-- mconley has quit (Ping timeout)
11:22:26 <sawrubh> the first XMPP protocol based file transfer just took place :)
11:22:38 --> mayanktg has joined #instantbird
11:23:02 <EionRobb> using which method?
11:23:20 <mayanktg> sawrubh: congrats! :)
11:23:58 <sawrubh> EionRobb: using http://xmpp.org/extensions/xep-0096.html
11:24:13 <nhnt11> sawrubh: :)
11:24:39 <sawrubh> EionRobb: did you mean Stream Initiation vs Jingle?
11:25:05 <EionRobb> vs In Band Byte Transfer
11:25:15 <sawrubh> it's using In Band right now
11:25:28 <sawrubh> I'll implement SOCKS Bytestream later on
11:25:32 <EionRobb> the slowest yet most reliable of them all :)
11:25:52 <EionRobb> good choice
11:26:10 <sawrubh> well it was more of clokep's choice :P
11:26:43 * sawrubh goes to polish the code
11:27:39 <nhnt11> mayanktg: The panel resizing issue seems to have gone away! :)
11:27:46 <nhnt11> I don't know which one of my changes fixed it
11:27:53 <mayanktg> :)
11:28:57 <nhnt11> I can't seem to get the text align thing to work
11:29:02 <nhnt11> I'll upload what I have so far
11:30:25 <-- mayanktg has quit (Ping timeout)
11:30:52 --> mayanktg-ph has joined #instantbird
11:31:36 <mayanktg-ph> nhnt11: sorry..no electricity. I'll send you the new icons soon.
11:44:07 <sawrubh> hmm, the size of file I sent was 1,10,442 while the size of file received shows it's size as 1,10,592
11:44:19 * sawrubh wonders whats the reason for the increase
11:45:22 <nhnt11> sawrubh: diff them? :)
11:45:37 <sawrubh> diff images?
11:45:37 * nhnt11 wonders if diff would work
11:45:43 * sawrubh looks up how to do that
11:45:50 <nhnt11> If png's have newlines...
11:45:57 <sawrubh> they look absolutely similar though visibly
11:47:11 --> mayanktg has joined #instantbird
11:48:30 <sawrubh> I could add them in qref, then diff the ascii content of their images
11:51:43 --> aleth_web has joined #instantbird
11:55:08 --> clokep_work has joined #instantbird
11:55:09 * ChanServ sets mode +o clokep_work 
11:56:25 <nhnt11> mayanktg-ph: Before I try further to get these margins to work, here's a suggestion - why not set the padding of userIconPanelMenu (and the other vboxes in that deck) to zero, and get the spacing around the image by applying padding on the userIconPanelStack (and webcamOverflow/webcamPhoto)?
11:56:48 <nhnt11> The buttons and the image/preview should be in separate boxes imo
11:57:43 * nhnt11 can't get the margins for the back/take picture and reshoot/set icon buttons to work
11:58:11 <sawrubh> hmm, so my block size is 4096, it seems to be doing something fancy when the last one is padded or something
11:58:24 <sawrubh> adding zeros to the file end
11:59:30 <sawrubh> I sent a 96byte text file and received a 4096 byte file, with 4000 bytes as zero
11:59:50 <mayanktg-ph> nhnt11: okay...let me try that.
12:00:02 <clokep_work> sawrubh: hexdump them and compare the output.
12:00:30 <clokep_work> If you're on Linux you should have a utility called hexdump, you might have to install hexutils or something.
12:00:34 <clokep_work> But I think it's standard. :)
12:00:36 <sawrubh> clokep_work: I don't need to, I just need to fix this weird padding thingy
12:00:42 <sawrubh> clokep_work: but it works which is good :)
12:00:52 <clokep_work> sawrubh: OK! I wasn't sure you confirmed itw as padding
12:01:52 <sawrubh> bbiab
12:03:53 <-- EionRobb has quit (Quit: Leaving.)
12:10:00 <nhnt11> aleth_web: "Does this throw prevent the iterator.close from happening?" nope
12:10:11 <nhnt11> Stuff in finally happens even if something in the catch block throws
12:10:37 * nhnt11 had a discussion about this with EionRobb the other day, and tested it in scratchpad :)
12:10:39 <aleth_web> Good :)
12:10:58 * aleth_web didn't remember what happened in that edge case.
12:11:01 <nhnt11> I don't like the idea of returning true arbitrarily :(
12:11:09 <aleth_web> return a resolved promise?
12:11:17 <nhnt11> Isn't that a bit of a waste?
12:11:23 <nhnt11> I'd rather return true than that :]
12:11:27 <nhnt11> Idk
12:11:35 <aleth_web> The promise will resolve to something anyway...
12:11:50 <aleth_web> If it doesn't cause the warnings, I don't mind.
12:12:15 <aleth_web> But there's definitely a warning if inside a JS function you return; at one place and return value; in another.
12:12:28 <mayanktg-ph> nhnt11: thanks :) I will look into the changes you've mentioned and will put them in separate boxes.
12:13:12 <clokep_work> aleth_web, nhnt11: If you have a "useless" return value, I'd prefer you return null, I think.
12:13:30 * nhnt11 was just about to ask about returning null
12:13:33 <nhnt11> If that's okay, great! :)
12:13:37 <aleth_web> null is better, right :)
12:14:43 <nhnt11> Hmm, bitrot
12:21:46 <-- BWMerlin has quit (Quit: BWMerlin)
12:33:46 <nhnt11> aleth_web: The IB UI patch in bug 955292 got bitrotted, but I just had to add a few lines from the diff manually so can I carry forward the r+?
12:33:49 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955292 enh, --, ---, nhnt11, ASSI, Read/write chat logs asynchronously
12:34:21 <aleth_web> nhnt11: Yes
12:40:50 <-- flo-retina has quit (Ping timeout)
12:43:00 --> flo-retina has joined #instantbird
12:43:00 * ChanServ sets mode +qo flo-retina flo-retina 
12:46:41 --> Rym has joined #instantbird
12:54:00 <clokep_work> You don't generally need to upload new patches for bitrot I thought.
12:55:44 <aleth_web> I thought the patch in the bug should match what will be checked in?
12:56:09 <aleth_web> I guess I should have carried forward the r+ though, sorry.
12:56:43 * aleth_web and nhnt11 have been bitrotting each other.
12:58:34 <sawrubh> seems this is soon going to be a trend with me and clokep_work ;)
12:59:03 * sawrubh wonders when Mic and mayanktg will do that :)
12:59:07 <clokep_work> sawrubh: No. I only intend to have that one change.
12:59:45 <sawrubh> I was kidding :)
13:01:20 <flo-retina> sawrubh: I could also do it for Mic ;)
13:01:52 <flo-retina> What's the state of the patch about adding generic icons to conversations?
13:03:33 <mayanktg> flo-retina: It still needs to be reviewed. I was told that once it has been reviewed, I can carry forward with the changes suggested in the review.
13:04:26 <flo-retina> how many times have you pinged for the review?
13:07:04 <mayanktg> I told Mic about it. But then he was busy and couldn't review it. I should have pinged others too. It was my fault :-/
13:10:19 <mayanktg> flo-retina: http://imgur.com/I4D9RHF.png , http://i.imgur.com/ZK6f8l1l.jpg is the changed icons. I checked their sizes and they are centralized. I didn't alter their proportions or size in any way.
13:11:12 <mayanktg> Do they look alright?
13:13:30 --> mpmc has joined #instantbird
13:17:09 <flo-retina> http://i.imgur.com/ZK6f8l1l.jpg looks better, yes
13:18:18 <flo-retina> is the icon of a blank sheet really the one we should use for "select file" btw?
13:19:00 <flo-retina> when looking at http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/Toolbar.png, I wonder if it wouldn't be better to use the 'folder' icon (the one just before the one you used; and just after the add-on icon)
13:19:27 <flo-retina> I mean, the icon used for "Open File"
13:20:19 <mayanktg> flo-retina: yeah I understood. I guess we should use the one we are using currently. It specifies "file". and not "open folder". Its my opinion though.
13:22:31 <flo-retina> here's a screenshot of the Firefox customization: http://i.imgur.com/DFMOuwB.png
13:22:43 <flo-retina> I think we should use the "Open File" icon
13:23:03 <mayanktg> Ok! :)
13:23:19 <flo-retina> mayanktg: when clicking that button you are actually opening a file picker which shows folders.
13:23:46 <mayanktg> Wait..I'm posting a new screenshot with the icons.
13:24:21 <mayanktg> Hmm..and the icon we are using specifies "page" :) Much better.
13:24:37 <mayanktg> ..to use the folder icon.
13:32:52 <-- mayanktg has quit (Ping timeout)
13:34:53 --> mayanktg has joined #instantbird
13:37:06 <mayanktg> flo-retina: http://i.imgur.com/ZKCIqYil.jpg  The right and left edges appear to be a little blurry for the 16x16 icons. It is clear in case of 32x32 icon.
13:40:37 <flo-retina> seems fine :)
13:41:58 <mayanktg> ok :) I will then use these icons and will try to do the changes nhnt11 suggested for the bug and will post the updated patch.
13:42:18 <flo-retina> mayanktg: these icons have 2 states in the toolbar.png file; do you also use the two?
13:43:54 <mayanktg> You mean, when the icon is clicked their state should be changed. Right? I didn't use the second state..I will do that.
13:46:03 <flo-retina> not sure if it should change when clicked or when hovered
13:46:09 <flo-retina> but if there are 2 states in that file, there's likely a reason
13:48:04 <mayanktg> flo-retina: We should change it when hovered. It would be appropriate and the change would be visible. Yes you're right.
13:50:06 --> mconley has joined #instantbird
13:51:37 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:58:55 --> iamjayakumars has joined #instantbird
14:05:59 <aleth_web> mayanktg: You can check in the FX CSS whether it's on hover or on click. (I suspect it's the latter)
14:06:49 <flo-retina> aleth_web: Firefox seems to have 3 states
14:07:07 <flo-retina> aleth_web: but I suspect the hover state is obtained only by changing the background color on a semi-transparent icon
14:07:12 <aleth_web> Something happens on hover, but I'm not sure it changes the icon itself
14:07:22 <aleth_web> RIght.
14:07:35 <aleth_web> I've suggested before mayanktg simply reuse that CSS.
14:10:31 <aleth_web> But that was for the conversation icons, so maybe it doesn't apply here.
14:11:17 <aleth_web> The hamburger menu bottom icons do darken on hover.
14:11:57 <aleth_web> Some of them at least (doesn't seem to be consistent, surprisingly)
14:12:08 <mayanktg> aleth_web: I guess we should here use the other state for hover. Sorry I missed the ping. I was modifying those icons on other laptop.
14:37:29 <mayanktg> aleth_web, flo-retina: http://imgur.com/6Dg5T1H This is how the icons look when hovered. Te icons in the hamburger menu in Ff has 3 states but since we don't have 3 state icons for "select file" and "take picture" imo we should go with the 2 state icons (i.e. normal and darker onewhen hovered).
14:41:13 * flo-retina doesn't care very strongly
14:42:06 <aleth_web> That looks good enough to me.
14:42:57 <-- Rym has quit (Ping timeout)
14:52:14 --> Rym has joined #instantbird
15:03:00 <clokep_work> sawrubh: ping
15:15:47 <-- mayanktg has quit (Ping timeout)
15:19:24 --> mayanktg has joined #instantbird
15:20:40 <-- gerard-majax__ has quit (Ping timeout)
15:23:29 <-- iamjayakumars has quit (Client exited)
15:27:20 <sawrubh> clokep_work: pong
15:28:25 <clokep_work> sawrubh: lunch.
15:28:30 <clokep_work> Congrats on your transfer though. :)
15:28:37 <clokep_work> Does that mean you'll get a patch up at some point soon? :P
15:28:57 <sawrubh> I actually started reading Promised, OS.File uses it extensively
15:29:11 <sawrubh> but yeah, the patch should be up in 2-3 hours
15:29:12 --> iamjayakumars has joined #instantbird
15:39:25 <-- iamjayakumars has quit (Client exited)
15:46:13 --> Mic|web has joined #instantbird
15:53:39 <-- nhnt11 has quit (Ping timeout)
15:55:02 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
15:55:12 --> nhnt11 has joined #instantbird
16:09:20 --> gerard-majax__ has joined #instantbird
16:11:37 <mayanktg> nhnt11: Hi. I applied the changes you mentioned in the diff (https://bugzilla.mozilla.org/attachment.cgi?id=8441326&action=diff). The L533 and L534 caused the Linux styling to break, rest was correct. You're right I'll have to change separate the preview/image and buttons into separate boxes.
16:13:50 --> iamjayakumars has joined #instantbird
16:26:54 <-- gerard-majax__ has quit (Ping timeout)
16:40:44 --> Mic|web has joined #instantbird
16:41:25 --> mpmc has joined #instantbird
16:42:28 --> gerard-majax__ has joined #instantbird
16:48:14 <-- gerard-majax__ has quit (Ping timeout)
16:48:57 <clokep_work> sawrubh: Ah, yes. definitely needa use those.
16:53:34 <clokep_work> sawrubh: What does it use now? :-S
16:54:33 <aleth_web> clokep_work: He means there are Promises in the existing code but he didn't write that part of it so he needs to understand them before he can change it ;)
16:54:43 <aleth_web> Just a guess.
16:54:47 <sawrubh> gah, you type faster than me
16:55:07 <sawrubh> yes, that's why, I need to understand the 'then' and stuff Promises entails
16:55:09 <aleth_web> sawrubh: fyi nhnt11 can also answer Promise questions now :)
16:56:52 <clokep_work> sawrubh: OK, cool. Go over all that code again, make sure it's formatted right, add comments to confusing parts.
16:56:59 <clokep_work> (As if you're reviewing it, ya know? :P)
16:57:07 <sawrubh> yes :)
17:00:06 --> Mook_as has joined #instantbird
17:03:24 --> gerard-majax__ has joined #instantbird
17:06:31 <-- rosonline has quit (Ping timeout)
17:14:00 <-- gerard-majax__ has quit (Ping timeout)
17:23:26 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:34:49 <-- iamjayakumars has quit (Quit: )
17:43:52 <mayanktg> I'm now using a common box for the button sets in the panel. The only place I'm using negative margin is where a default margin of 10px is set for the left, right and bottom areas of the panel. This is different for retina-screens which is causing the margins to change in retina screens :-/ I'll add a fix for it in the patch.
17:45:19 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:50:20 <mayanktg> aleth_web, Mic|web: : I added the call disconnect feature in the video call yesterday. It would be nice if we decide the final prototype and work on it. idk where to put the buttons, so I implemented it using /end command.
17:52:47 <-- mayanktg-ph has quit (Quit: Connection closed for inactivity)
18:13:23 <-- mayanktg has quit (Ping timeout)
18:14:08 --> mayanktg has joined #instantbird
18:25:20 --> iamjayakumars has joined #instantbird
18:26:09 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
18:29:13 <aleth_web> aleth_web: Sounds good. You probably should have that discussion with Mic.
18:29:24 <aleth_web> Do you have other things to do while you wait?
18:29:35 <sawrubh> aleth_web: talking to yourself, eh?
18:29:54 <aleth_web> mayanktg: ^^
18:30:13 --> chrisccoulson has joined #instantbird
18:30:21 * aleth_web blames irccloud ;)
18:31:42 --> flo-retina has joined #instantbird
18:31:43 * ChanServ sets mode +qo flo-retina flo-retina 
18:32:27 <mayanktg> aleth_web: Yeah. I'm working with the theme part of the "video call". flo-retina mentioned about mirroring the video streams so I'll implement it too.
18:32:45 <flo-retina> nhnt11: r+, clear to land; but please push to try once to ensure the tests work there :)
18:34:27 <flo-retina> mayanktg: don't worry too much about the video mirroring
18:34:41 <flo-retina> mayanktg: nhnt11 seemed to care about it, so I suspect he'll add it if you don't ;)
18:34:44 <aleth_web> mayanktg: You could also use the notificationbar in conversation.xml instead of automatically accepting calls. I'd leave the mirroring for (much) later
18:34:52 <flo-retina> it's one line of CSS though
18:34:58 <aleth_web> ah ;)
18:35:59 <mayanktg> aleth_web: Okays! Then I'm going to remove the auto accepting calls and add notifications :)
18:36:00 * aleth_web expected it to need some canvas magic
18:36:28 * mayanktg I though the same as aleth_web did.
18:36:36 <mayanktg> *thought
18:39:57 <Mic|web> mayanktg: if you have a separate canvas or video element for it then it's really only a css-transformation.
18:40:11 <-- iamjayakumars has quit (Quit: )
18:40:18 <Mic|web> "transform: scaleX(-1)" or something like that.
18:42:16 <mayanktg> Mic|web: Ok. Got it :)
18:42:42 <flo-retina> Mic|web++
18:53:21 <-- Rym has quit (Ping timeout)
18:54:59 --> Rym has joined #instantbird
18:59:44 <-- mayanktg has quit (Ping timeout)
19:03:15 --> mayanktg has joined #instantbird
19:13:49 --> mikk_s has joined #instantbird
19:15:12 <-- mikk_s has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
19:22:30 <-- aleth_web has left #instantbird ()
19:32:04 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
19:38:58 <sawrubh> gah, I'm confused
19:39:30 <sawrubh> guess I'll start explaining what I understand
19:41:45 <sawrubh> so base64 is used for encoding binary data, it'll get padded if it's not a factor of 6 (the size that is)
19:43:19 <sawrubh> now when I read the file, it's read as ArrayBufferView, which needs to be converted to a string of binary data for btoa to be applied to it (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Base64_encoding_and_decoding)
19:45:31 <sawrubh> ah I think I know...
19:45:34 * sawrubh tries something
19:46:00 * clokep_work doesn't see a question in there.
19:46:45 <sawrubh> wait let me pastebin
19:54:05 <sawrubh> code: http://pastebin.instantbird.com/737353
19:59:58 <clokep_work> OK, but what's the QUESTION. :P
20:02:13 <sawrubh> the bigger question is why is writeChunk (which basically uses OS.File.write) writing the entire 4096 bytes (size of chunk)
20:03:32 <clokep_work> That sounds exactly like what you'd expect. :-S
20:03:36 <-- mconley has quit (Connection reset by peer)
20:03:50 --> mconley has joined #instantbird
20:04:54 <-- Tonnes has quit (Connection reset by peer)
20:09:38 <sawrubh> so I need to have the information about how much in the chunk is actual data and how much is padding
20:11:10 <-- Rym has quit (Ping timeout)
20:11:52 <sawrubh> so what I'm confused about is that sendChunk basically reads 96bytes and it reaches the other end and that writes the size of the chunk, instead of directly the amount received (after converting it to the binary)
20:12:34 <sawrubh> padding the binary just ensures it's 6-bit aligned but 96 is also 6-bit aligned so it shouldn't have any padding
20:12:46 <sawrubh> s/also/already
20:16:16 * sawrubh is looking at it
20:19:33 <clokep_work> Sorry I can't concentrate on this right now.
20:21:46 --> EionRobb has joined #instantbird
20:22:29 <sawrubh> I think I know what I should do, on L650 of http://pastebin.instantbird.com/737353 I simply pass this.blockSize as the amount to be read, I need to find out how much to read
20:28:13 <clokep_work> Probably.
20:28:21 <clokep_work> So if it's the last chunk don't read the whole blcoksize.
20:29:17 <sawrubh> yeah
20:30:54 --> Rym has joined #instantbird
20:40:41 --> rosonline has joined #instantbird
20:54:31 <sawrubh> fixed
20:55:40 <-- Rym has quit (Ping timeout)
20:57:31 --> Rym has joined #instantbird
21:08:19 --> sonny has joined #instantbird
21:11:15 <-- Rym has quit (Ping timeout)
21:13:12 --> Rym has joined #instantbird
21:14:44 <clokep_work> sawrubh: Cool, so what's left?
21:15:43 <sawrubh> for v1 nothing, for v2 adding a UI, we haven't worked on an interface yet so probably that
21:16:02 <sawrubh> do we want to work on SOCKS Bytestream right now or later?
21:17:52 <sawrubh> or what I could do is work on that purplexpcom interface simulateneously, I dunno, file transfer as such works, now we just need to improve it with features like feedback (option to accept/deny, pause, stop downloads, see progress using Downloads Panel)
21:19:40 <clokep_work> sawrubh: I think I've said a few times that you shouldn't worry about the SOCKS Bytestream yet.
21:19:51 <sawrubh> ok
21:20:17 <clokep_work> The reason for implementing the basic XMPP support was to ensure we have some sort of file transfer that worked and we can get the interfaces working.
21:21:12 <sawrubh> if the some sort of file transfer already works, what do we need the interfaces for? so that other consumers could hook into this?
21:21:45 <clokep_work> sawrubh: I don't understand your question. :-S
21:21:59 --> sukhe has joined #instantbird
21:22:06 <sawrubh> I mean this file transfer is working even without the interfaces right?
21:22:07 <clokep_work> The interface is so that the UI can call the backend code.
21:22:14 <sawrubh> ah
21:22:14 <clokep_work> It's using the interface, didn't you modify the IDL?
21:22:18 <-- sukhe has left #instantbird ()
21:22:27 <sawrubh> yes, but just needed to add the sendFile method
21:22:40 <clokep_work> Yes. . .
21:22:43 <sawrubh> that's the only thng called from conversation.xml (UI-ish part)
21:22:53 <clokep_work> conversation.xml is UI, it's not UI-ish. ;)
21:22:57 <-- sonny has quit (Client exited)
21:23:08 <clokep_work> So now the question is: "does that interface make sense or does it actually need more to it?"
21:23:24 <sawrubh> ah, that sounds like an open ended question though
21:23:43 <clokep_work> Go on.
21:23:49 <sawrubh> we could always keep modifying the interface, adding more features to it
21:24:01 <sawrubh> so we should first come up with something we want immediately
21:24:13 <clokep_work> Yes.
21:24:22 * sawrubh goes back to that etherpad
21:24:32 <clokep_work> So a question might be "Is what we have useful right now that we should get it working and land it?"
21:24:32 <sawrubh> should we jot down there what we want right now?
21:24:42 <clokep_work> I don't understand your question.
21:25:25 <sawrubh> I meant should we discuss that 'OK, we want a way in the interface to pause the transfer, let's add a method called pauseTransfer'
21:25:58 <sawrubh> and things like that, I mean brainstorming about what we need in the first version we land
21:26:00 <clokep_work> That's something that needs to be discussed at some point, yes.
21:26:04 <clokep_work> Yes.
21:26:47 <clokep_work> This is also only sending a transfer, not accepting one.
21:27:18 <sawrubh> the other client is accepting the transfer, only then will the transfer happen right?
21:27:34 <sawrubh> I send from one instance of IB to another and that accepts it and saves it
21:27:36 <clokep_work> Well actually, you might be testing IB to IB which means you've already done both parts of that.
21:27:38 <clokep_work> Oh, OK.
21:27:46 <clokep_work> So just none of the UI work is done on either side, got it. :)
21:27:52 <sawrubh> yeah
21:28:00 <clokep_work> OK.
21:28:03 <sawrubh> we just assume everyone in the world wants files
21:28:12 <clokep_work> OK.
21:28:45 <clokep_work> So, what might make sense to do is to add the UI bits to this in a separate patch (similar to what was done for the FileLink stuff).
21:29:04 <clokep_work> So we can iterate on the two separately.
21:29:38 <sawrubh> that shall be done :) By UI, you mean a notificationbox to tell you, someone offered you a file transfer and then you can accept/decline it
21:29:48 <sawrubh> anything else besides that in the UI?
21:30:08 <clokep_work> Yep! Well you ahve drag n drop to start a transfer right?
21:30:17 <sawrubh> I'm assuming the Downloads Panel is gonna a whole new beast like FileLink
21:30:19 <clokep_work> I think those two things are the bare minimum we would need to support to land this.
21:30:20 <sawrubh> +be
21:30:24 <clokep_work> Yeah, that'll be a separate bug.
21:30:50 <sawrubh> hopefully, people won't be so pissed when I copy stuff there ;)
21:30:57 <sawrubh> ..or wait I won't have to copy :P
21:31:10 <clokep_work> The download stuff? You might need to, yes.
21:31:25 --> sonny has joined #instantbird
21:31:26 <sawrubh> I thought we could access everything in mozilla?
21:31:54 <clokep_work> I do not believe we can access things in browser.
21:31:58 <sawrubh> :(
21:32:10 <sawrubh> will this be a copy or move btw?
21:32:46 <sawrubh> if a move, then people are surely gonna be angry
21:34:40 <clokep_work> sawrubh: Do I need to answer that?
21:34:45 <clokep_work> How could we possibly move it?
21:34:56 <clokep_work> Firefox certainly doesn't have access to any of our code.
21:35:12 <clokep_work> (I don't mean that to be mean, the question just doesn't make much sense.)
21:35:20 <clokep_work> UI code is generally forked between applications.
21:35:20 <sawrubh> yeah, sorry
21:35:34 <sawrubh> I realized once I said it :/
21:35:35 <clokep_work> Some of the stuff (DownloadUtils) we probably have access to.
21:36:00 <sawrubh> we have access to DownloadUtils (that's what I used in management.js)
21:38:15 <clokep_work> sawrubh: We'll also want to think about tests.
21:38:18 <sawrubh> wait, in order to land this, we need to also add something to decide between FileLink and this method
21:38:23 <clokep_work> And whether passing an nsIFile to purplexpcom makes sense.
21:38:34 <sawrubh> because both will get trigger when you drag and drop
21:38:35 <clokep_work> sawrubh: Well not if FileLink hasn't landed yet. ;)
21:38:41 <clokep_work> Right now your patches will conflict.
21:40:49 <sawrubh> what are the reasons for thinking whether to pass nsIFile to purplexpcom?
21:41:03 <clokep_work> Is that enough information to start a file transfer in libpurple?
21:41:32 <clokep_work> (I know doing the implementation for purplexpcom is a separate bug, but these are things to think about so we don't have to constantly change the interface.)
21:41:32 <sawrubh> ok, so looking at libpurple interface side by side, I'll add that to my TODO
21:42:03 <clokep_work> OK, so is it clear what should be done next?
21:42:23 <clokep_work> (Also, what happens if I try to start a file transfer with a different protocol, e.g. IRC.)
21:42:26 <clokep_work> Does it just throw?
21:43:06 <clokep_work> mconley: Hey, where's the download manager code live at?
21:43:16 <sawrubh> hmm, I haven't thought about that
21:43:18 <clokep_work> "download" apparently brings up many many hits on dxr. :-D
21:43:39 <sawrubh> I think I linked to it in my proposal
21:43:42 * sawrubh looks
21:44:06 <sawrubh> http://mxr.mozilla.org/mozilla-central/source/browser/components/downloads/
21:44:12 <clokep_work> Yeah, just found it.
21:46:56 <sawrubh> ok, so next thing, add that notification bar thingy and then land this?
21:47:18 <sawrubh> in the meantime, keep thinking about interfaces and libpurple
21:47:47 <sawrubh> also downloads panel (#fx-team might be able to help with that later)
21:48:46 <clokep_work> So, yes. I think adding the notification bar to have some basic UI should be first, yes.
21:48:51 <clokep_work> And get the backend patch up for review.
21:49:46 <flo-retina> sawrubh: "to land this, we need to also add something to decide between FileLink and this method" for now, you could just make the IBB code fail when the file is larger than a certain size (eg. 64kB)
21:50:04 <flo-retina> clokep_work: what's the reason for that nsIFile in the interface?
21:50:23 <flo-retina> do we already have an nsIFile on the UI side, or are we creating it to go through xpconnect?
21:51:09 <flo-retina> if the later; shouldn't we just pass the path as a string, so that it could be opened with OS.File for js prpls and with fopen by purplexpcom?
21:53:09 <clokep_work> flo-retina: The drag and drop stuff gives you an nsIFile.
21:53:16 <flo-retina> ok
21:53:38 <clokep_work> flo-retina: My understand is that the JS code makes an OS.File...but I haven't really looked at the code yet (I'd really like it in the patch....I think I've asked a few times sawrubh)
21:54:58 <sawrubh> clokep_work: "I've asked a few times" you mean about OS.File? Yes, the code uses OS.File
21:55:16 <mconley> clokep_work: hey - sorry, was AFK
21:55:24 <mconley> clokep_work: the front-end of the back-end? I think you've just found the browser front-end
21:55:30 <sawrubh> clokep_work: "I'd really like it in the patch" you mean comments?
21:56:26 <sawrubh> mconley: I actually plan to use the downloads panel to show the status of the download and upload of file transfers
21:57:52 <clokep_work> sawrubh: I've asked a few times for the code to be uploaded in the bug. ;)
21:58:02 --> sonny1 has joined #instantbird
21:58:04 <sawrubh> ah, I will do that surely :)
21:58:07 <clokep_work> It's hard to give feedback and I'm afraid there's a LOT Of code that hasn't been looked at yet.
21:58:25 <clokep_work> mconley: Yeah. Thanks. Is the backend somewhere else?
21:58:36 <-- sonny1 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:58:37 <-- sonny has quit (Client exited)
22:04:30 <mconley> clokep_work: yep, hang on...
22:04:42 <clokep_work> No rush. :-D
22:04:43 <mconley> clokep_work: http://dxr.mozilla.org/mozilla-central/source/toolkit/components/jsdownloads/src/Downloads.jsm
22:04:58 <flo-retina> mayanktg: ping
22:05:07 <clokep_work> Hmm....interesting.
22:05:10 <clokep_work> Thanks.
22:05:10 <mayanktg> flo-retina: yepp.
22:05:42 <flo-retina> I just looked briefly at the latest patch where you requested review from me
22:05:50 <sawrubh> clokep_work: do you want me to add the pref and then pref this off in the UI (I have already done that in the filelink bug btw)
22:05:57 <flo-retina> the part of the css related to retina icons seems broken
22:06:30 <flo-retina> don't you need a rule for the :hover state there too, and to specify different -moz-image-region values?
22:06:48 <clokep_work> sawrubh: Yes.
22:07:19 <sawrubh> well conflict for sure then with that filelink bug :)
22:07:37 <clokep_work> Yeah I know. :-\ Sorry.
22:07:44 <-- mayanktg has quit (Ping timeout)
22:07:54 --> mayanktg has joined #instantbird
22:09:07 <sawrubh> clokep_work: also I think I'll need a way to send something (some sort of signal) from onIQStanza (inside xmpp.jsm) to the UI (conversation.xml)
22:09:09 <mayanktg> flo-retina: nhnt11 set the height and width of the icon to 16px. err...My bad. I'm adding the hover state in for the retina screens too
22:09:48 <clokep_work> sawrubh: For what?
22:09:52 <sawrubh> when the file transfer offer is received, I've always done UI->backend, not backend->UI
22:09:58 <clokep_work> Yep!
22:10:10 <flo-retina> mayanktg: you also seem to be missing an ifdef around the retina rules
22:10:11 <sawrubh> guess it should be similar though
22:10:16 <flo-retina> the retina files aren't packaged on windows
22:10:31 <clokep_work> sawrubh: Not really. It's done using observers, pretty much.
22:10:33 <flo-retina> and from what I've been told, some Windows screens are hidpi now
22:11:30 <-- mconley has quit (Input/output error)
22:11:31 <mayanktg> flo-retina: I didn't know about it. I'm making the changes and will show you the diff.
22:12:12 <sawrubh> clokep_work: yeah, I see these observers, let me see how they do it :)
22:12:57 <clokep_work> There's also the whole "how do you notify of progress" thing, but that doesn't necessarily need to be dealt with yet.
22:13:02 <mayanktg> flo-retina: Are the "x" remove icon buttons functioning correctly? I have added a @2x icon for it too. So I'll need to add -moz-image-region for it too?
22:13:12 <clokep_work> sawrubh: Is there a prplIFileTransfer object or something btw?
22:13:36 <flo-retina> mayanktg: the -moz-image-region is because you have several states in the same file
22:13:50 <clokep_work> sawrubh: So tests + accepting a file transfer in the UI I think need to be done next.
22:14:33 <sawrubh> and sending for review, whatever's been done
22:14:52 <sawrubh> clokep_work: any particular tests I can look at for guidance?
22:16:32 <clokep_work> There might be an XMPP...
22:16:50 <clokep_work> sawrubh: https://mxr.mozilla.org/comm-central/source/chat/protocols/irc/test/
22:17:06 <clokep_work> sawrubh: Did someone else start writing tests for XMPP? Maybe mayanktg? Or nhnt11?
22:17:08 * clokep_work goes away.
22:17:23 <sawrubh> clokep_work: no, I haven't created that prplIFileTransfer object? should I?
22:17:51 <mayanktg> clokep_work: Yes I have written a test for XMPP to test xml2sdp and sdp2xml.
22:18:28 <flo-retina> mayanktg: but it's not landed yet, right?
22:18:31 * Fallen is now known as Fallen|away
22:18:38 <mayanktg> flo-retina: yes.
22:18:46 <flo-retina> so sawrubh would have to go look at the patch in the bug :)
22:18:50 <-- clokep_work has quit (Ping timeout)
22:18:53 <sawrubh> but I could always use that for guidance :)
22:19:43 <sawrubh> mayanktg: bug number :P (sorry I don't have it in my awesomebar)
22:19:45 <mayanktg> sawrubh: https://bug1018060.bugzilla.mozilla.org/attachment.cgi?id=8439135 Here's the test.
22:19:48 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1018060 nor, --, ---, mayanktg, NEW, Voice and video call support in XMPP using WebRTC
22:20:01 <sawrubh> ta
22:22:26 <mayanktg> flo-retina: The @2x icons were used specially for Mac (they have -mac as their suffix). I should rename those files to |webRTC-shareDevice-16@2x.png| and |select-file@2x.png| right?
22:23:03 <flo-retina> not necessarily
22:23:08 <flo-retina> why do you want to rename them?
22:23:57 <mayanktg> Because Windows will be also using the @2x icons.
22:24:29 <flo-retina> mayanktg: here is how things look with the patch currently in the bug: http://i.imgur.com/NX9BOKY.png http://i.imgur.com/1ogofQB.png
22:24:52 <flo-retina> nhnt11: ^
22:25:45 <sawrubh> flo-retina: what name would you like for all the file transfer related xmpp code? xmpp-ft.jsm?
22:26:01 <flo-retina> works for me
22:26:09 <flo-retina> does it really have to be a separate file?
22:27:12 <sawrubh> flo-retina: http://log.bezut.info/instantbird/140616/#m127
22:28:20 <mayanktg> flo-retina: imo changing the margin in "#userIconButtonBox" for hidpi screens will fix the margins. And I'll add the -moz-image-region for it too which would fix the icon shape.
22:28:46 <-- Armada has quit (Connection reset by peer)
22:33:18 <flo-retina> https://bugzilla.mozilla.org/show_bug.cgi?id=985947 seems related to the popup sizing issues we discussed a few days ago
22:33:20 <instantbot> Bug 985947 nor, --, ---, nobody, NEW, [10.9] Popups can shrink when switching to hidpi mode
22:35:08 <mayanktg> flo-retina: http://pastebin.instantbird.com/737444 Please take a look over the interdiff and check if I have done it right?
22:35:51 <flo-retina> there's no reason for #userIconButtonBox to have different margins on retina screens
22:36:45 <flo-retina> doesn't the close button icon also have 2 states?
22:37:03 <mayanktg> Ok. Then how will the margins be fixed for retina screens? Sorry I don't have an idea how to fix  that.
22:37:22 <flo-retina> the sizes aren't different on retina screens
22:37:42 <flo-retina> only the resolution of the icons is different
22:39:46 --> wnayes has joined #instantbird
22:44:16 --> mconley has joined #instantbird
22:48:58 <mayanktg>  flo-retina: http://pastebin.instantbird.com/737445 Is it ok now? I have added the states for close button for hidpi screen.
22:52:37 <instantbot> New Instantbird - Contacts window bug 1026784 filed by florian@queze.net.
22:52:38 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1026784 tri, --, ---, nobody, NEW, Remove the <popupset id="mainpopupset"> element from the blist.xul DOM
22:52:49 <flo-retina> if anybody's looking for a really trivial bug to fix ;)
22:53:58 <flo-retina> mayanktg: you have one UserIconPanelImageRemove and the next two with "user" instead of "User". What's the correct one?
22:54:33 <flo-retina> and I see no reason for that -mac in the filenames
22:54:35 <mayanktg> ohh ...userIconPanelImageRemove one is the correct one.
22:55:11 <mayanktg> flo-retina: I was asking you about removing -mac from name only a while ago.
22:56:07 <flo-retina> and I asked you why you wanted to rename them, because I wasn't seeing the reason
22:57:51 <mayanktg> Ok. I'm then changing the names of the files, fixing the typo and uploading the patch.
22:58:29 <-- Rym has quit (Ping timeout)
23:03:05 --> Tonnes has joined #instantbird
23:03:30 <flo-retina> mayanktg: try #changeUserIconPanel > .panel-arrowcontainer > .panel-arrowcontent { padding: 0 0; } in the CSS, and remove your (or nhnt11's) crazy negative margins please.
23:04:16 <flo-retina> mayanktg: here's what the DOM looks like: http://i.imgur.com/bYtKbIo.png
23:10:04 <mayanktg> flo-retina: I used the negative margins :-( It's fixed now. The buttons don't leave any margins now :) 
23:14:14 <flo-retina> ok :)
23:14:27 <flo-retina> I'll try and have another look tomorrow
23:18:13 <mayanktg> Done with the changes you've mentioned. :) I'm updating the patch then.
23:34:19 <-- mayanktg has quit (Ping timeout)
23:35:31 --> clokep has joined #instantbird
23:35:31 * ChanServ sets mode +o clokep 
23:39:06 --> mayanktg has joined #instantbird
23:45:36 <clokep> sawrubh: I'm home now, but I'll be busy fora few minutes
23:48:07 --> Rym has joined #instantbird
23:49:07 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
23:50:43 <-- Rym has quit (Ping timeout)
23:54:00 --> Rym has joined #instantbird