#instantbird log on 06 16 2014

All times are UTC.

00:17:44 <-- mconley has quit (Input/output error)
00:17:49 <-- wnayes has quit (Ping timeout)
00:21:07 --> wnayes has joined #instantbird
00:58:07 --> ConnorBehan has joined #instantbird
00:59:20 <ConnorBehan> now that instantbird is developed in comm-central, will it move to the same release schedule as thunderbird?
01:12:46 <clokep> ConnorBehan: We're not tied to their release schedule, no.
01:12:50 <clokep> We do our own release engineering.
01:12:57 <clokep> It's not handled by Mozilla staff at all.
01:13:12 <ConnorBehan> ok, so 1.6 will appear on the main site just like the others?
01:15:59 <clokep> Yes.
01:16:11 <clokep> We're not sure when 1.6 will be released, but hopefully soon.
01:16:23 <clokep> We just got some new build machines that need to be setup first though.
01:19:35 <ConnorBehan> the last several version have built successfully against the libxul.so that ships with firefox
01:20:25 <ConnorBehan> I suppose that's an accident by this point, and it's really designed to be against the libxul.so from thunderbird?
01:23:47 <clokep> Shouldn't those be the same?
01:23:58 <clokep> An dno, we don't use TB code.
01:25:35 <ConnorBehan> well thunderbird can't be built against xulrunner because the libxul.so's are different
01:25:53 <ConnorBehan> but I guess instantbird uses a small enough subset of the API that it can work with both
01:30:44 <clokep> OK. I'm really not entirely sure, sorry. :-\
01:32:19 <ConnorBehan> if there's a change in what 1.6 builds against, I'll let you know :)
01:42:53 <clokep> Thanks. :)
01:43:01 <clokep> We play to release 1.6 for 64-bit Linux too btw.
01:46:29 <-- clokep has quit (Ping timeout)
01:51:21 <-- Rym has quit (Ping timeout)
01:57:02 --> Rym has joined #instantbird
02:09:51 --> mconley has joined #instantbird
02:17:38 <-- wnayes has quit (Ping timeout)
02:20:59 --> wnayes has joined #instantbird
02:28:47 <-- wnayes has quit (Quit: wnayes)
03:20:29 <-- mpmc has quit (Ping timeout)
03:21:38 --> mpmc has joined #instantbird
03:52:26 --> stux has joined #instantbird
03:57:55 <-- Rym has quit (Ping timeout)
04:28:42 --> jb has joined #instantbird
04:44:24 <-- ConnorBehan has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
04:47:19 <-- jb has quit (Connection reset by peer)
04:47:21 --> jb1 has joined #instantbird
04:47:36 <-- gerard-majax_ has quit (Ping timeout)
05:05:44 <-- mconley has quit (Input/output error)
05:08:30 <-- jb1 has quit (Ping timeout)
05:57:28 <-- EionRobb has quit (Quit: Leaving.)
06:00:02 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
06:03:58 --> gerard-majax_ has joined #instantbird
06:21:21 <-- gerard-majax_ has quit (Ping timeout)
06:37:25 --> gerard-majax_ has joined #instantbird
06:45:48 <-- gerard-majax_ has quit (Ping timeout)
06:46:41 --> gerard-majax_ has joined #instantbird
06:52:11 <-- gerard-majax_ has quit (Ping timeout)
07:18:14 --> Armada has joined #instantbird
07:37:06 --> sawrubh|ib has joined #instantbird
07:41:17 --> Hadi has joined #instantbird
07:56:01 --> gerard-majax__ has joined #instantbird
08:05:20 --> EionRobb has joined #instantbird
08:12:58 <-- Armada has quit (Connection reset by peer)
08:29:18 --> Mic|web has joined #instantbird
08:35:38 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
08:35:54 --> chrisccoulson has joined #instantbird
08:38:12 --> sonny has joined #instantbird
09:10:21 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
09:14:08 <-- sonny has quit (Ping timeout)
09:32:16 --> sonny has joined #instantbird
09:33:04 --> sonny1 has joined #instantbird
09:33:26 <-- sonny1 has quit (Client exited)
09:33:58 <-- sonny has quit (Ping timeout)
09:35:29 <-- sawrubh|ib has quit (Ping timeout)
09:36:35 --> sawrubh|ib has joined #instantbird
09:43:49 <-- EionRobb has quit (Quit: Leaving.)
09:46:27 --> EionRobb has joined #instantbird
09:47:45 * Fallen|away is now known as Fallen
09:49:14 --> BWMerlin has joined #instantbird
09:54:41 --> flo-retina has joined #instantbird
09:54:41 * ChanServ sets mode +qo flo-retina flo-retina 
09:55:24 <flo-retina> hmm, I can resize my buddy list today :-S
09:58:09 <Hadi> flo-retina:  Hello
09:58:37 <Hadi> There seems to be a bug in the website, in the developer's page, the nightly releases points to the wrong  ftp server
09:59:19 <Hadi> The link in the irc welcome msg also shows nothing
09:59:29 <Hadi> only the link in the news section has a nightly build in it
10:00:06 <flo-retina> http://ftp.instantbird.com/instantbird/nightly/latest-1.6a1pre/ works
10:01:59 <Hadi> flo-retina:  in the website this page:
10:02:01 <Hadi> https://wiki.instantbird.org/Main_Page
10:02:10 <Hadi> the latest nightly build section points to the wrong link
10:02:32 <Hadi> it points to trunk/ which is empty just wanted to point that
10:03:32 <flo-retina> trunk/ is no longer empty ;)
10:05:51 <instantbot> florian@queze.net changed the Resolution on bug 978755 from --- to FIXED.
10:05:53 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=978755 nor, --, ---, florian, RESO FIXED, latest-trunk link on the FTP points to an empty folder
10:09:37 <Hadi> yeaa
10:10:06 <flo-retina> happy? :)
10:10:22 <flo-retina> unless you are on Mac, the latest nightly is old though :(.
10:14:19 <Hadi> no, it's da windows
10:19:06 --> clokep has joined #instantbird
10:19:06 * ChanServ sets mode +o clokep 
10:34:13 <clokep> sawrubh|ib: nsIFile sounds correct, this needs to be used from both C++ and JS.
10:34:15 * instantbot frowns at clokep
10:52:38 <clokep> But the JS implementation should probably use OS.File.
10:52:53 * clokep hopes that makes sense.
11:02:22 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:09:04 <-- EionRobb has quit (Quit: Leaving.)
11:13:48 --> aleth has joined #instantbird
11:13:48 * ChanServ sets mode +o aleth 
11:23:36 <aleth> flo-retina: Is your blist-resize problem also a retina issue? I.e. does it maybe happen after moving the blist to an external screen?
11:23:50 <flo-retina> maybe
11:24:00 <flo-retina> but my resizable blist is currently on the external monitor
11:24:28 <flo-retina> I read in another retina-related bug that the behavior may be different depending on the position of the external monitor relative to the primary one
11:24:36 <aleth> Just wondering since you&nhnt11 seem to be the only ones so far who have seen this
11:27:36 --> mayanktg has joined #instantbird
11:28:35 --> Rym has joined #instantbird
11:33:46 --> Mic|web has joined #instantbird
11:35:39 <instantbot> aleth@instantbird.org changed the Resolution on bug 955000 from --- to FIXED.
11:35:40 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955000 enh, --, ---, aleth, RESO FIXED, Add someone as a buddy directly from an open conversation
11:51:55 <-- Hadi has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:58:33 * aleth has done so many reviews on nhnt11's async logs patch that the bug webpage is now showing up among the top hits in FX's new tab :P
12:00:08 --> clokep_work has joined #instantbird
12:00:08 * ChanServ sets mode +o clokep_work 
12:08:04 <-- mayanktg has quit (Ping timeout)
12:08:44 --> mayanktg has joined #instantbird
12:11:48 <-- aleth has quit (Ping timeout)
12:11:51 --> aleth has joined #instantbird
12:11:51 * ChanServ sets mode +o aleth 
12:14:02 <sawrubh> alexis: lol
12:16:23 <sawrubh> so http://pastebin.instantbird.com/736636 is my WIP, I've added sendFile to imConversations.js, jsProtoHelper.jsm, purpleConv{Chat.h, ConvIM.h, Conversation.cpp}, every place I see sendMsg and it makes sense
12:18:08 <sawrubh> but now it gets compiled, it seems to be called but I get 'NS_ERROR_NOT_IMPLEMENTED: Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [prplIConversation.sendFile]' error
12:18:25 <-- aleth has quit (Ping timeout)
12:18:28 --> aleth has joined #instantbird
12:18:28 * ChanServ sets mode +o aleth 
12:18:30 <sawrubh> I've done everything (I think) as is being done for sendMsg
12:19:05 <clokep_work> sawrubh: BytesToARrayBuffer looks like a copy of https://mxr.mozilla.org/comm-central/source/chat/modules/ArrayBufferUtils.jsm#29
12:19:05 <sawrubh|ib> aleth, clokep_work: ^
12:19:33 <aleth> Can you put that filetransfer object in its own file (assuming clokep_work agrees)?
12:20:43 <clokep_work> objects
12:20:50 <aleth> Right
12:20:55 <clokep_work> I don't see anything obvious, but I can't concentrate ont his right now. :-\
12:21:12 <sawrubh|ib> ok
12:22:25 <sawrubh|ib> aleth: can you help?
12:22:36 <aleth> Put a dump() in jsprotohelper to check your not implemented error is coming from there.
12:23:23 <sawrubh|ib> I
12:23:35 <sawrubh|ib> (ignore that)
12:23:36 <clokep_work> Ah, good idea.
12:25:18 <-- aleth has quit (Ping timeout)
12:25:48 <-- BWMerlin has quit (Quit: BWMerlin)
12:27:21 <sawrubh|ib> aleth: guess you're gonna be my saviour this week :)
12:27:35 --> aleth has joined #instantbird
12:27:35 * ChanServ sets mode +o aleth 
12:29:20 <-- aleth has quit (Ping timeout)
12:29:23 --> aleth has joined #instantbird
12:29:23 * ChanServ sets mode +o aleth 
12:30:54 <sawrubh|ib> aleth: no, it seems to be thrown somewhere before, because the dump in jsProtoHelper isn't dumpong
12:31:12 <aleth> So, work backwards and find out where it is throwing ;)
12:38:39 <nhnt11> aleth, flo-retina: My blist is currently unresizable
12:38:55 * nhnt11 wonders what's triggering this
12:40:37 <-- aleth has quit (Ping timeout)
12:40:43 --> aleth has joined #instantbird
12:40:43 * ChanServ sets mode +o aleth 
12:42:15 <sawrubh|ib> clokep_work: did you base that bug 1021684 patch over my patch
12:42:17 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1021684 nor, --, ---, clokep, ASSI, Update box.com Filelink implementation to new APIs
12:42:26 <sawrubh|ib> otherwise it might be bitrotten once my patch lands
12:46:51 <clokep_work> sawrubh|ib: I did not.
12:46:58 <clokep_work> I'm hoping to bitrot your patch actually. :-[
12:47:15 <flo-retina> that's what I was going to say; it will land first as it's an emergency fix
12:47:24 <clokep_work> Otherwise the patch as it stands now will be what would get applied to c-beta.
12:48:16 <clokep_work> Well, once it works. ;)
12:48:28 * clokep_work guesses he's setting the header wrong for the httpRequest call.
12:50:47 --> qheaden has joined #instantbird
12:51:03 <sawrubh|ib> :(
12:58:30 <sawrubh|ib> ok, so what comes in between imConversation.js and jsProtoHelper.jsm, let's see....
13:00:06 <sawrubh|ib> this._prplConv[this._currentTargetId] aha!
13:00:11 <-- Rym has quit (Ping timeout)
13:00:28 --> Rym has joined #instantbird
13:01:59 <clokep_work> Whatever that is. :P
13:05:21 <qheaden> Hello everyone.
13:06:09 <aleth> Probably not the source of the problem...
13:07:38 <aleth> Hi qheaden :)
13:13:11 <sawrubh|ib> aleth: so sendFile in this.target is called where target is basically a prplIConversation object, now that comes from jsProtoHelper's GenericConversationPrototype and that is where I've added sendFile
13:13:37 <aleth> So if you put a dump() before the throw in jsprotohelper, do you get there?
13:13:49 <sawrubh|ib> no! which is surprising
13:14:00 <aleth> Did you do a full build?
13:14:05 <sawrubh|ib> no
13:14:27 <sawrubh|ib> these are all in chat which get built when I do mach build im/
13:14:35 <sawrubh|ib> but I'll probably just do a full build
13:14:42 <aleth> I've said many times incremental builds don't work if you change interfaces :-S
13:15:23 <sawrubh|ib> :s
13:15:35 <aleth> Sometimes it helps to listen to conversations going on with others here too...
13:15:45 <aleth> You're all likely to face similar problems.
13:18:14 <sawrubh|ib> btw jsProtoHelper and imConversation aren't interfaces afaik (interfaces are IDL's right) and I did a full build after I changed the interface which was once
13:18:28 <aleth> True.
13:18:30 <sawrubh|ib> so that's not the issue and I've just done a full build and the result is the same
13:18:41 <sawrubh|ib> it's still not reaching jsProtoHelper's sendFile
13:18:59 * sawrubh|ib quickly pastebins
13:19:37 <aleth> Really it shouldn't reach it anyway, it should reach the xmpp sendFile since that overrides the jsprotohelper one ;)
13:20:28 <sawrubh|ib> http://pastebin.instantbird.com/736659
13:20:51 <sawrubh|ib> it's not reaching xmpp.jsm's too (I've added a reportError there too)
13:24:14 <clokep_work> sawrubh|ib: Where's the actual entry point?
13:24:26 <sawrubh|ib> in conversation.xml
13:24:42 <sawrubh|ib> when I drop the file, handleDroppedFile is called, there
13:25:21 <clokep_work> sawrubh|ib: Print out what this._conv is and what this._conv.sendFile is.
13:26:14 <aleth> heh, some of that file transfer code looks familiar somehow
13:27:46 <sawrubh|ib> I've taken whatever was useful from Atul's code
13:27:56 <aleth> sure.
13:29:10 <aleth> Have you checked there isn't some syntax error in xmpp.jsm that is breaking the file?
13:29:53 <aleth> Comment out all your changes apart from the sendFile and see if that changes anything
13:30:15 <sawrubh|ib> clokep_work: http://pastebin.instantbird.com/736660
13:30:40 <sawrubh|ib> what's inetresting is that sendFile printed shows as having no arguments while all my sendFile's have aFile as argument
13:31:41 <aleth> Oh nice, the build system patch worked.
13:31:54 <aleth> My checkin didn't trigger a TB build.
13:32:25 <clokep_work> aleth: Now to get it to trigger IB ones. :P
13:32:34 <clokep_work> sawrubh|ib: [native code] means it's definitely not jsProtoHelper.
13:32:49 <aleth> clokep_work: no problem, give me a minute :P
13:33:04 <aleth> sawrubh|ib: are you *sure* you are using JS-XMPP ?!
13:33:14 * sawrubh|ib checks the prefs
13:33:22 <sawrubh|ib> I'm sure though, just doublechecking
13:33:59 <sawrubh|ib> prpl-jabber,prpl-yahoo,prpl-yahoojp :o
13:34:02 <sawrubh|ib> sorry, my bad
13:34:17 <sawrubh|ib> how did this happen, I'm pretty sure I had js-xmpp turned on, meh
13:34:40 <sawrubh|ib> sorry guys, stupid mistake
13:34:50 * aleth wonders if this explains the topic patch problems ;)
13:36:00 <clokep_work> Ah, good catch. :)
13:39:46 <-- sawrubh|ib has quit (Ping timeout)
13:41:46 <-- aleth has quit (Ping timeout)
13:41:49 --> aleth has joined #instantbird
13:41:49 * ChanServ sets mode +o aleth 
13:41:53 --> Hadi has joined #instantbird
13:42:02 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
13:47:03 <-- aleth has quit (Ping timeout)
13:47:06 --> aleth has joined #instantbird
13:47:06 * ChanServ sets mode +o aleth 
13:47:23 --> mpmc has joined #instantbird
13:48:24 <nhnt11> Hello
13:48:35 * nhnt11 writes a blog post
13:48:44 --> iamjayakumars has joined #instantbird
13:49:04 <nhnt11> My blist is still not resizable btw
13:49:51 <nhnt11> aleth: I have a bunch of |TypeError: this._updateAutoScrollEnabled is not a function| in my error console, is this a known regression?
13:50:09 * nhnt11 assumed that scrolling stuff is best pointed at aleth :)
13:50:09 <aleth> No
13:50:17 <aleth> Sounds new :-/
13:50:23 <nhnt11> Well, there are quite a few of them
13:50:26 <iamjayakumars> nhnt11: stable or nightly?
13:50:40 <nhnt11> iamjayakumars: nightly
13:51:10 <nhnt11> Also the text on the buttons at the top of the error console seem misaligned
13:51:29 <nhnt11> Though I can't tell if they were always like that
13:51:30 <nhnt11> http://puu.sh/9w2BS/c40b276364.png
13:51:38 --> sawrubh|ib has joined #instantbird
13:52:26 <nhnt11> I wonder if these errors only popup if autoscrolling is enabled?
13:55:12 <aleth> nhnt11: they're not misaligned for me
13:55:24 <aleth> bugfilin' time?
13:55:25 <nhnt11> Interesting..
13:55:30 <nhnt11> Yeah, looks like it
13:55:45 <nhnt11> I'm going to file a blist-resizability bug too
13:55:54 <nhnt11> (or did flo already do that?)
14:00:11 <nhnt11> aleth: Do you not see the auto scroll errors? (and if not, do you have autoscroll disabled?)
14:00:23 <nhnt11> (and if you do, do you have autoscroll enabled?)
14:00:38 <-- aleth has quit (Ping timeout)
14:00:49 <nhnt11> Does anyone with autoscroll disabled see these errors?
14:00:54 --> aleth has joined #instantbird
14:00:54 * ChanServ sets mode +o aleth 
14:01:10 <aleth> I haven't changed any autoscroll settings
14:01:24 <nhnt11> brb, gotta open the prefs window and Ib will likely crash
14:01:30 <-- nhnt11 has quit (Input/output error)
14:01:33 --> nhnt11 has joined #instantbird
14:03:16 <-- aleth has quit (Quit: exit stage left)
14:03:20 --> aleth has joined #instantbird
14:03:20 * ChanServ sets mode +o aleth 
14:05:38 <flo-retina> aleth: was |entries.forEach((aEntry, i) => entries[i] = aEntry.path);| meant to just be a .map ?
14:05:41 <-- aleth has quit (Ping timeout)
14:06:36 <nhnt11> flo-retina: That looks like something from my log sweeping patch
14:06:39 <nhnt11> Did you mean to ask me that?
14:06:49 <nhnt11> Oh, aleth replied there. Why didn't I get an email :S
14:06:52 --> aleth has joined #instantbird
14:06:52 * ChanServ sets mode +o aleth 
14:06:58 <nhnt11> Ah, I did get it, nvm
14:07:02 <flo-retina> nhnt11: you can answer too :)
14:07:13 <nhnt11> Yeah, that just needs to be .map
14:08:00 <nhnt11> Those are pretty trivial review comments, yay :)
14:09:12 <nhnt11> aleth: "Shouldn't this callback return a promise?" What are you referring to here?
14:10:26 <aleth> Does it matter that the callbacks in a forEach are all called at once or should they wait on each other?
14:10:35 <nhnt11> My blist suddenly became resizable :S
14:10:41 <nhnt11> I moved it to the edge of the window
14:11:34 <nhnt11> aleth: I still don't understand, sorry. Why would they be called at once?
14:11:50 <aleth> Why wouldn't they?
14:12:17 <nhnt11> aleth: https://developer.mozilla.org/en-US/docs/JavaScript_OS.File/OS.File.DirectoryIterator_for_the_main_thread#forEach%28%29
14:12:25 <nhnt11> "Iteration takes place sequentially"
14:12:29 <aleth> Right. Scroll down to "Promise-based loop"
14:13:12 <nhnt11> My callback doesn't return a Promise :S
14:13:28 <aleth> ah, I think you get it now :)
14:13:52 <nhnt11> aleth: No, I don't. Are you saying it /should/ return a promise?
14:15:01 <aleth> Doesn't it depend on what the callback does?
14:15:24 <nhnt11> Yeah. My callback doesn't seem to need to return a promise?
14:15:42 <nhnt11> Hmm, are you saying the callback from the consumer may be async?
14:15:58 <nhnt11> i.e. if aCallback.parseLog returns a promise, we should wait on it?
14:16:16 <nhnt11> (even if that's not what you're saying, I should probably accommodate for that :))
14:16:47 <-- aleth has quit (Ping timeout)
14:16:51 --> aleth has joined #instantbird
14:16:51 * ChanServ sets mode +o aleth 
14:18:48 <-- aleth has quit (Ping timeout)
14:22:05 --> aleth has joined #instantbird
14:22:06 * ChanServ sets mode +o aleth 
14:23:45 <-- aleth has quit (Ping timeout)
14:23:48 --> aleth has joined #instantbird
14:23:48 * ChanServ sets mode +o aleth 
14:24:03 <aleth> No, that's exactly what I meant.
14:24:07 <aleth> That's how the forEach callback is supposed to work ;)
14:25:06 <nhnt11> aleth: I can't directly supply the parseLog callback to forEach though
14:25:14 <nhnt11> "If any of the callbacks throws an error or rejects a promise, the loop is stopped and rejects with the same error."
14:25:24 <nhnt11> I don't want the loop to stop because parsing one log file failed
14:25:36 <nhnt11> On second thought, the callback should handle that
14:26:00 <nhnt11> (i.e. if the promise rejects, it's a big flaw with the callback, and the loop /should/ be stopped)
14:26:20 <-- iamjayakumars has quit (Ping timeout)
14:27:16 <-- sawrubh|ib has quit (Ping timeout)
14:29:00 --> mconley has joined #instantbird
14:31:08 --> sawrubh|ib has joined #instantbird
14:40:15 <-- mayanktg has quit (Ping timeout)
14:43:31 --> mayanktg has joined #instantbird
14:49:21 --> iamjayakumars has joined #instantbird
14:49:28 <-- iamjayakumars has quit (Client exited)
14:59:59 <nhnt11> aleth: Hmm, also, I need to include the isDir and endsWith("json") checks in tehre
15:00:30 --> iamjayakumars has joined #instantbird
15:00:32 <nhnt11> So I think it's fine how it is, except maybe I want to do yield aCallback.parseLog(...) 
15:00:47 <nhnt11> (and maybe I can remove the try/catch block
15:00:50 <nhnt11> )
15:02:21 <nhnt11> Erm, can't yield there without making the callback a Task.async()
15:05:51 <-- aleth has quit (Ping timeout)
15:05:54 --> aleth has joined #instantbird
15:05:54 * ChanServ sets mode +o aleth 
15:08:33 <-- iamjayakumars has quit (Ping timeout)
15:18:32 <-- nhnt11 has quit (Ping timeout)
15:24:10 --> iamjayakumars has joined #instantbird
15:28:19 <clokep_work> aleth: So bug 955000 wasn't like blcoking any of the other stuff we had going on, right?
15:28:21 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955000 enh, --, 1.6, aleth, RESO FIXED, Add someone as a buddy directly from an open conversation
15:28:52 <aleth> clokep_work: No, the blocking on is the reconnection bug which imho could land.
15:29:03 <aleth> s/on/one
15:29:21 --> nhnt11 has joined #instantbird
15:30:41 <flo-retina> aleth: ah, did I remember wrong which one of the reviews you were pinging me about last week? :-/
15:31:01 <clokep_work> aleth: Rgr.
15:31:02 <-- aleth has quit (Ping timeout)
15:31:05 --> aleth has joined #instantbird
15:31:05 * ChanServ sets mode +o aleth 
15:31:19 <aleth> flo-retina: No, they both needed to land to avoid even more bitrot
15:31:25 * aleth suspects the reconnection one was bitrotted by nhnt11 by now
15:33:09 <aleth> yup, it was.
15:33:16 <aleth> Not badly though.
15:33:25 <clokep_work> :)
15:33:46 <-- nhnt11 has quit (Ping timeout)
15:36:38 --> nhnt11 has joined #instantbird
15:39:19 <clokep_work> flo-retina: So I assume we're not releasing until we have the new minis set up?
15:39:50 <flo-retina> I don't know
15:39:59 <flo-retina> I don't see how these 2 things relate tbh
15:40:33 <flo-retina> I don't know how long it will take to setup the minis
15:40:42 <flo-retina> could be 2-3 months
15:40:50 <-- nhnt11 has quit (Ping timeout)
15:41:03 --> nhnt11 has joined #instantbird
15:42:01 <-- stux has quit (Quit: Aloha!)
15:42:43 <-- nhnt11 has quit (Ping timeout)
15:43:20 --> nhnt11 has joined #instantbird
15:44:22 <-- gerard-majax__ has quit (Ping timeout)
15:45:06 --> arlolra has joined #instantbird
15:45:59 <clokep_work> flo-retina: Well either that or we have to fix our current build infrastructure.
15:46:02 <clokep_work> That's how they relate. ;)
15:49:49 <-- nhnt11 has quit (Ping timeout)
15:53:03 --> stux has joined #instantbird
15:56:08 --> nhnt11 has joined #instantbird
16:01:03 <-- nhnt11 has quit (Ping timeout)
16:01:39 --> nhnt11 has joined #instantbird
16:07:38 <flo-retina> clokep_work: I think we have to fix our current infra
16:08:20 <aleth> Get it to work on known hardware first...
16:09:37 <-- Rym has quit (Ping timeout)
16:10:04 <flo-retina> aleth: last time I touched the windows VM, the situation was: we build fine if the machine starts, and then I start buildbot by hand from an open session.
16:10:17 <flo-retina> aleth: if buildbot is started automatically at startup, the wrong version of the SDK gets selected.
16:10:25 <flo-retina> I have no clue of why, and would like Even to look into it
16:10:33 <aleth> bah, some strange config issue.
16:10:43 <aleth> Hopefully simpler than the Linux situation at least.
16:11:07 <flo-retina> you are talking about windows. How can it be simpler than Linux? :-P
16:11:11 * flo-retina isn't Mic.
16:11:18 <aleth> lol
16:11:39 <nhnt11> aleth: I think parseAllLogs is a clearer name than "forEach" but I kinda like forEach in that it's a "standard" name
16:11:41 <aleth> Simpler than puppet, then.
16:11:54 <aleth> nhnt11: yeah, and it doesn't do any parsing ;)
16:12:03 <nhnt11> Yeah fair enough
16:12:05 * nhnt11 changes it
16:13:05 <clokep_work> flo-retina: Alright. :-\ 
16:13:10 * clokep_work feels useless with this build stuff.
16:14:11 <aleth> ^^ that's the problem :-S
16:14:14 <aleth> i.e. me too.
16:14:44 <aleth> nhnt11: maybe "forEachLog" if you want it to be clearer?
16:14:52 <nhnt11> Nah, forEach is better imo
16:15:03 <aleth> ah yeah, it'll be Services.logs.forEach. 
16:15:08 <nhnt11> It sounds perfectly clear when you consider |Services.logs.forEach|
16:15:12 <nhnt11> Aha :D
16:16:17 --> Rym has joined #instantbird
16:18:59 <-- iamjayakumars has quit (Client exited)
16:22:08 --> iamjayakumars has joined #instantbird
16:22:10 <-- aleth has quit (Ping timeout)
16:24:44 --> aleth has joined #instantbird
16:24:44 * ChanServ sets mode +o aleth 
16:35:08 <-- nhnt11 has quit (Ping timeout)
16:41:51 --> gerard-majax__ has joined #instantbird
16:44:02 <-- sawrubh|ib has quit (Ping timeout)
16:44:19 <-- gerard-majax__ has quit (Ping timeout)
16:45:16 --> sawrubh|ib has joined #instantbird
16:47:04 <-- sawrubh|ib has quit (Ping timeout)
16:47:04 <-- Rym has quit (Ping timeout)
16:49:03 --> sawrubh|ib has joined #instantbird
16:49:21 --> Rym has joined #instantbird
16:50:10 --> Mook_as has joined #instantbird
16:50:32 --> gerard-majax_ has joined #instantbird
16:51:25 <-- Rym has quit (Ping timeout)
16:53:10 <-- gerard-majax_ has quit (Ping timeout)
16:55:45 --> nhnt11 has joined #instantbird
16:57:25 <-- nhnt11 has quit (Ping timeout)
16:58:03 <-- iamjayakumars has quit (Client exited)
16:59:35 --> Rym has joined #instantbird
17:03:47 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:03:49 --> nhnt11 has joined #instantbird
17:04:16 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:06:12 <-- Rym has quit (Ping timeout)
17:08:15 --> Rym has joined #instantbird
17:15:31 --> gerard-majax_ has joined #instantbird
17:16:54 <-- gerard-majax_ has quit (Max SendQ exceeded)
17:21:54 <-- aleth has quit (Ping timeout)
17:25:05 <-- clokep_work has quit (Ping timeout)
17:25:37 --> clokep_work has joined #instantbird
17:25:38 * ChanServ sets mode +o clokep_work 
17:30:47 <clokep_work> sawrubh|ib: Just checking in...you making progress?
17:35:52 --> aleth has joined #instantbird
17:35:52 * ChanServ sets mode +o aleth 
17:37:11 --> gerard-majax_ has joined #instantbird
17:40:27 <-- gerard-majax_ has quit (Ping timeout)
17:46:56 <clokep_work> arlolra: I took a look at your code briefly, but haven't been able to write up a full review yet. :-\
17:49:55 <arlolra> clokep_work: no problem. thanks for looking
17:51:44 <clokep_work> There is a pretty big issue that I saw though...you have the IRC code interacting directly with the UI conv, that's a big no-no.
18:00:25 <nhnt11> Is interdiff broken on bmo? :S
18:00:42 <arlolra> clokep_work: hmm. yeah, I was a little unsure about that. suggestions on how to better achieve the same result would be helpful. though I'm sure that'll come in review
18:01:00 <clokep_work> nhnt11: I don't think so, why?
18:01:15 <clokep_work> arlolra: That's why I haven't given comments yet, I haven't been able to delve deep enough into it to think about it.
18:01:23 <clokep_work> (I was also working on a quick turn around patch the other day.)
18:01:39 <nhnt11> clokep_work: I can't interdiff between my latest patch (v2) on bug 1025464 and the previous one
18:01:43 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1025464 nor, --, ---, nhnt11, NEW, Refactor log sweeping code to use Task.jsm and move it to logger.js
18:02:02 <nhnt11> I just get "Warning: interdiff encountered errors while comparing these patches." "No valid patch files were found in the attachment."
18:03:07 <aleth> Seems to be happening on other bugs too.
18:03:38 <clokep_work> Ask in #it?
18:04:11 <nhnt11> Hmm. fwiw it's working on the async logs bug
18:04:18 <nhnt11> Hmm okay
18:05:11 <clokep_work> Maybe a small hiccup?
18:07:58 <nhnt11> It's a problem with the patch(es)
18:08:02 <nhnt11> I can't interdiff locally either
18:08:06 <nhnt11> :S
18:08:19 * nhnt11 hasn't tampered with any diffs...
18:09:05 <nhnt11> Oh
18:09:21 <nhnt11> It's failing because the patch is based on top of the async logs patched, which changed...
18:09:26 <nhnt11> s/patched/patch
18:09:38 <nhnt11> (So there are changes in the context part of the diff)
18:10:17 * nhnt11 wonders about the "other bugs" aleth was talking about
18:11:00 <aleth> https://bugzilla.mozilla.org/attachment.cgi?oldid=8427167&action=interdiff&newid=8440750&headers=1
18:11:08 <sawrubh|ib> clokep_work: sorry, was having dinner. Yes, it's working halfway. Pretty close to getting it done.
18:11:08 --> flo-retina has joined #instantbird
18:11:08 * ChanServ sets mode +qo flo-retina flo-retina 
18:11:18 <aleth> nhnt11: Probably fails for the same reason.
18:11:20 <nhnt11> aleth: That's likely bitrot as well
18:11:23 <nhnt11> yeah
18:12:15 --> jb has joined #instantbird
18:12:49 <flo-retina> just noticed ConnorBehan's questions about libxul.so in the log.
18:13:03 <flo-retina> clokep_work: Thunderbird statically links mailnews' C++ code into libxul.
18:13:25 <flo-retina> so no, we don't need a custom libxul, the libxul from a Firefox with the same gecko version number should work for Instantbird
18:13:58 <nhnt11> aleth: I'm sure I changed that to forEach :S
18:14:02 <nhnt11> I wonder if I cmd+z'd something
18:14:12 <nhnt11> (I was undoing some stuff at some point)
18:14:22 <nhnt11> bah
18:14:32 <clokep_work> flo-retina: That's what I thought. Thanks for the correct explanation though.
18:14:53 <-- aleth has quit (Ping timeout)
18:16:05 <flo-retina> np
18:16:22 --> aleth has joined #instantbird
18:16:22 * ChanServ sets mode +o aleth 
18:17:39 <-- sawrubh|ib has quit (Connection reset by peer)
18:17:44 --> Armada has joined #instantbird
18:18:59 --> sawrubh|ib has joined #instantbird
18:24:52 <-- Tonnes has quit (Connection reset by peer)
18:25:19 <-- jb has quit (Ping timeout)
18:29:40 <nhnt11> Heh, here's a nice way to test forEach: use it to delete the log files at the end of the logging test.
18:35:04 <nhnt11> aleth: Do you think the test should obtain a list of all log files using OS.File, then ensure they are all parsed? :S
18:35:13 <nhnt11> This seems like duplicating most of the forEach code...
18:35:36 <nhnt11> Maybe we want to just test the isDir and endsWith(".json") parts of it?
18:35:45 <nhnt11> That isn't /that/ useful to test though..
18:36:05 <aleth> No, just run forEach in an existing test, and check all the files get passed.
18:36:18 <aleth> I didn't mean anything complicated.
18:36:25 <nhnt11> check them all for what?
18:36:35 <nhnt11> isDir and ".json"?
18:36:57 <aleth> No, that doesn't make sense. Just that parseLog gets called where it should.
18:37:18 <aleth> Don't you already have a bunch of log files set up in your daily logs test?
18:37:30 <nhnt11> Yeah
18:37:38 <nhnt11> So just ensure those two files are getting parsed?
18:37:39 <nhnt11> fine..
18:37:55 <aleth> Nothing complicated.
18:38:05 <nhnt11> I'll remove them in forEach, and then ensure that no files remaining in the log folder.
18:38:07 <nhnt11> That fine?
18:38:12 <aleth> Sure.
18:39:13 <nhnt11> Ah, there's an OS.File.removeEmptyDir! :)
18:39:35 <nhnt11> I assume that throws if the dir isn't empty (which is what we want)
18:39:42 <aleth> I should have just agreed with http://log.bezut.info/instantbird/140616/#m474, that would have shortened this confusing conversation ;)
18:40:46 <nhnt11> :]
18:41:07 <aleth> But the ping was on the next line, so I missed it ;)
18:44:08 <-- nhnt11 has quit (Input/output error)
18:44:09 --> nhnt12 has joined #instantbird
18:44:36 --> Tonnes has joined #instantbird
18:47:02 <-- Rym has quit (Ping timeout)
18:48:33 <-- aleth has quit (Ping timeout)
18:48:41 --> Rym has joined #instantbird
18:49:40 <nhnt12> Interesting
18:49:53 --> rosonline has joined #instantbird
18:49:56 <nhnt12> removeEmptyDir is supposed to throw if the directory doesn't exist
18:50:03 <nhnt12> But from my scratchpad testing, it doesn't
18:50:12 <nhnt12> It /does/ throw if the dir is empty (which works for me)
18:50:21 <nhnt12> isn't empty*
18:51:11 <nhnt12> The ignoreAbsent works though
18:51:18 <nhnt12> (setting it to false I mean)
18:55:20 --> gerard-majax_ has joined #instantbird
19:02:21 <-- Rym has quit (Ping timeout)
19:04:40 --> Rym has joined #instantbird
19:07:01 --> jb has joined #instantbird
19:10:23 <-- Suiseiseki has quit (Ping timeout)
19:11:21 --> jb1 has joined #instantbird
19:11:34 <-- jb has quit (Ping timeout)
19:11:44 --> Suiseiseki has joined #instantbird
19:17:40 <nhnt12> flo-retina: If I have a callback declared as [scriptable, function, blabla] in the idl, will it not work to pass directly a function from an xpchshell test?
19:17:51 <nhnt12> xpcshell*
19:21:07 <nhnt12> Do I need to do a QueryInterface first?
19:21:18 <-- jb1 has quit (Ping timeout)
19:23:42 <nhnt12> I tried using Services.logs, that doesn't seem to be working either..
19:25:08 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:25:31 --> Armada651 has joined #instantbird
19:25:32 <-- Armada has quit (Connection reset by peer)
19:26:05 <nhnt12> Bah, I needed to do a mach build...
19:31:45 <nhnt12> That didn't fix it.
19:31:53 * nhnt12 doesn't know anymore
19:32:12 <nhnt12> Using Services.logs won't work because I've imported logger.js, and the Logger instance needs to be in the same scope
19:32:26 <nhnt12> (otherwise gLogWritersById won't work)
19:33:01 <nhnt12> I tried |let logger = new gLogger.Logger(); logger.QueryInterface(Ci.imILogger);|, no luck
19:33:51 <nhnt12> (the callback still needs to be an object implementing a "parseLog" function to work)
19:34:03 --> jb has joined #instantbird
19:34:34 * nhnt12 gives up for now
19:35:59 --> mpmc has joined #instantbird
19:37:53 <-- sawrubh|ib has quit (Quit: sawrubh|ib)
19:42:29 <-- jb has quit (Ping timeout)
19:46:59 --> jb has joined #instantbird
19:47:30 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
19:49:17 * nhnt12 is now known as nhnt11
19:49:18 --> chrisccoulson has joined #instantbird
19:49:38 <-- jb has quit (Ping timeout)
19:49:51 <nhnt11> bbl
20:07:17 --> jb has joined #instantbird
20:09:18 --> wsmwk has joined #instantbird
20:09:44 <-- jb has quit (Ping timeout)
20:11:26 --> jackarg has joined #instantbird
20:12:26 <jackarg> Hi there, I've come to a dead end and i'm really hoping somebody can help: is it possible to forward an incoming email to IM (a chatbot) and vice versa?
20:14:26 --> Mic|web has joined #instantbird
20:14:49 <clokep_work> jackarg: Using Instantbird, I assume? You could probably come up with some way to do that, but it's not a built in feature. Instantbird has no support for IMAP or POP3 built in by default.
20:15:38 --> EionRobb has joined #instantbird
20:16:36 <clokep_work> jackarg: If you're using Thunderbird...that could be easier and interesting. I don't believe anyone has explored that.
20:17:03 <jackarg> hi clokep_work: a few things first: I have no idea what instabird does, what is IMAP and what is POP3, unfortunately. I just want to be able to forward emails to the duckduckgo chatbot http://www.gabrielweinberg.com/blog/2011/03/imddggg-duckduckgo-chat-bot.html       ,get the results, and send them back by email. Because I guess chatbots only work with IM
20:17:29 <jackarg> So I was first thinking I could do this with gmail and google talk, but I think if I need to script something I should use something local like thunderbird
20:17:33 <jackarg> but i'm really lost
20:17:44 <jackarg> and i'm not sure how to procceed
20:18:38 <clokep_work> jackarg: Well first you need a way to receive emails, IMAP and POP3 are the protocols to do that; then you need a way to talk to a chat bot (it looks like that bot uses XMPP); you then need a way to send an email, which is via SMTP.
20:18:47 <clokep_work> This could probably all be done locally in Thunderbird, with an extension.
20:19:09 <clokep_work> You'd have to hook into the Thunderbird events for a new email, forward the stuff to the bot, record the results and write an email.
20:19:53 <jackarg> gmail is IMAP right? Ok so.. what extensions are already there to do that? what part do I need to write myself, and how would I do so?
20:21:42 <EionRobb> why would you do that using xmpp though?
20:22:33 <jackarg> EionRobb: sorry I don't know enough about the field to answer that..
20:22:49 <clokep_work> jackarg: There are no extensions that do any of this AFAIK.
20:23:02 <EionRobb> why not just do the same http calls for the search results lookup that the chatbot does?
20:23:10 <clokep_work> Yeah, that'd be easier.
20:23:20 <clokep_work> My guess of what you actually want to do is search duckduckgo from yourp hone?
20:25:38 <jackarg> Ok so I'll explain: I want to access internet (so search ddg) from my phone, but this one can only text, it has no email or chat function. I made it possible, with the use of an old android phone I don't use, to redirect messages I send to it to my email. But the chatbot doesn't respond to an email, so somehow I have to transfer that email to an IM. That's what i'm trying to figure out so far
20:25:38 <-- Armada651 has quit (Connection reset by peer)
20:25:39 --> Armada651 has joined #instantbird
20:25:49 <jackarg> what is this about http calls?
20:26:33 <flo-retina> jackarg: are you using Instantbird?
20:26:34 <EionRobb> why not use the android phone instead? :)
20:27:01 <jackarg> lol ok let's just say it's not mine :)
20:27:23 <jackarg> it's my wifes
20:27:39 <jackarg> it's her work phone, so it's either at home or at work, always connected to wifi
20:28:00 <jackarg> And I have a basic nokia 100
20:28:02 <flo-retina> jackarg: this discussion is very offtopic here, so please continue it elsewhere.
20:28:16 <jackarg> flo-retina: nope I don't even use thunderbird. But i probably will have to
20:28:48 <jackarg> EionRobb: and clokep_work if you're up to helping me, should we do a private talk?
20:29:19 <clokep_work> jackarg: I'm busy, sorry.
20:29:25 * EionRobb is also at work
20:29:35 --> BWMerlin has joined #instantbird
20:30:53 <jackarg> Darn it! Ok EionRobb can you just explain what you mean by the http calls? and clokep_work just where can I start writing a script to do this thing?
20:31:41 <-- flo-retina has kicked jackarg from #instantbird
20:37:03 <wsmwk> flo-retina: that was rather abrupt
20:37:24 <-- mayanktg has quit (Ping timeout)
20:38:04 <wsmwk> I sent him here because I didn't see anyone related to chat in #thunderbird
20:38:53 --> mayanktg has joined #instantbird
20:40:10 <flo-retina> wsmwk: we have no reason to help someone spy his wife's phone. And he doesn't even seem to be using any of the products we develop.
20:41:12 <flo-retina> wsmwk: but sending here people who have Thunderbird chat questions is generally OK (and we certainly don't kick them out :))
20:42:39 <EionRobb> doesn't sound like he's "spying his wife's phone", just using it as a relay, and he might have ended up writing you guys an smtp/imap prpl
20:42:52 * clokep_work doubts that.
20:42:53 <wsmwk> I didn't read the whole conversation.   not clear he was talking about spying
20:43:15 * Mook_as isn't convinced a smtp/imap prpl is a reasonable thing to have
20:43:17 <flo-retina> wsmwk: purposefully not clear; but very possible.
20:44:11 <flo-retina> wsmwk: he talked about forwarding texts to email, and email to IM.
20:44:57 <Mook_as> it sounds like he's already got the text->mail part, though, so any help we give wouldn't be conductive to the spying.
20:45:56 <flo-retina> wsmwk: have you directed him to #maildev, or did he find it by himself? :)
20:46:27 <wsmwk> flo-retina: i sent him there b4 you posted your resopnse to me
20:47:03 <flo-retina> ok; hopefully he won't waste too many people's time :)
20:51:36 <flo-retina> EionRobb: he seems connected to IRC with a libpurple-based client, maybe we should send him to #pidgin?
20:51:51 <clokep_work> Wait, let me join #pidgin first. . .
20:52:47 <wsmwk> says he's a teen
20:53:02 --> jb has joined #instantbird
20:53:15 <flo-retina> with a wife?
20:53:16 <wsmwk> he has no programming experience, so he'll likely hit a dead end.
20:53:39 <-- stux has quit (Quit: Aloha!)
20:54:45 <-- jb has quit (Ping timeout)
20:59:26 <-- BWMerlin has quit (Quit: BWMerlin)
20:59:27 --> stux has joined #instantbird
21:00:24 --> jb has joined #instantbird
21:05:07 <-- Rym has quit (Ping timeout)
21:10:46 --> The0x539 has joined #instantbird
21:11:05 <-- The0x539 has left #instantbird ()
21:14:27 --> Rym has joined #instantbird
21:20:41 * Fallen is now known as Fallen|away
21:23:08 <-- Rym has quit (Ping timeout)
21:24:00 --> Rym has joined #instantbird
21:24:23 <-- Hadi has quit (Ping timeout)
21:24:41 <-- arlolra has quit (Quit: arlolra)
21:31:54 <-- gerard-majax_ has quit (Ping timeout)
21:42:31 <-- jb has quit (Ping timeout)
21:52:07 <-- mconley has quit (Input/output error)
22:05:09 <-- clokep_work has quit (Ping timeout)
22:22:52 --> gerard-majax_ has joined #instantbird
22:24:56 <-- gerard-majax_ has quit (Ping timeout)
22:25:43 <-- mayanktg has quit (Ping timeout)
22:25:58 --> mayanktg has joined #instantbird
22:28:30 --> wnayes has joined #instantbird
22:29:15 <-- rosonline has quit (Ping timeout)
22:30:00 --> rosonline has joined #instantbird
22:41:16 --> jb has joined #instantbird
22:50:03 <-- jb has quit (Ping timeout)
22:52:41 --> jb has joined #instantbird
22:56:21 <-- jb has quit (Ping timeout)
23:02:28 --> sukhe has joined #instantbird
23:03:06 <-- sukhe has left #instantbird ()
23:09:33 --> mconley has joined #instantbird
23:14:44 <-- Rym has quit (Ping timeout)
23:15:06 --> Rym has joined #instantbird
23:20:46 <-- Armada651 has quit (Connection reset by peer)
23:28:30 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
23:35:30 <-- mconley has quit (Input/output error)
23:36:05 <-- rosonline has quit (Ping timeout)
23:39:10 --> clokep has joined #instantbird
23:39:10 * ChanServ sets mode +o clokep 
23:44:57 --> rosonline has joined #instantbird
23:59:46 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)