#instantbird log on 06 15 2014

All times are UTC.

00:02:26 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
00:03:25 <sawrubh|ib> anyone awake?
00:06:55 <sawrubh|ib> so I added a function at http://dxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm#240 called sendFile, now I want to call this function from conversation.xml when I drop a file, so I did something like this._conv.sendFile but it wasn't called, so I realized I had to add it some IDL (like sendMsg has been added), so I added 'void sendFile(in nsIFile aFile);' to prplIConversation.xml but it didn't compile
00:07:19 <sawrubh|ib> giving some error in puplexpcom, I guess I'll also have to implement this in purplexpcom
00:07:30 <sawrubh|ib> so how can I fix this?
00:08:25 <mayanktg> prplConversation.idl right? Did you change the uuid of the interface?
00:08:32 <sawrubh|ib> no
00:08:37 * sawrubh|ib tries
00:08:48 <sawrubh|ib> instantbot: uuid
00:08:49 <instantbot> ac1855b6-92d3-4103-9aa4-3ede192212f9 (/msg instantbot cid for CID form)
00:11:53 <mayanktg> I guess you've to add it the same way I was supposed to add the startCall(). 
00:11:58 <sawrubh|ib> mayanktg: doesn't work, http://pastebin.instantbird.com/735838 is the error I get
00:12:45 <sawrubh|ib> I changed the uuid on http://dxr.mozilla.org/comm-central/source/chat/components/public/prplIConversation.idl#19 only
00:15:45 <mayanktg> Hmm.. I added it this way https://bug1018060.bugzilla.mozilla.org/attachment.cgi?id=8439455 . Though its in the same manner you have done :| 
00:15:47 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1018060 nor, --, ---, mayanktg, NEW, Voice and video call support in XMPP using WebRTC
00:17:51 <-- sawrubh|ib has quit (Connection reset by peer)
00:18:35 <-- mconley has quit (Ping timeout)
00:18:49 <mayanktg> Though you'll have to add the sendFile() at chat/modules/jsProtohelper.jsm but the build should have been successful.
00:19:38 --> sawrubh|ib has joined #instantbird
00:20:14 <sawrubh|ib> http://pastebin.instantbird.com/735839 is my WIP btw
00:22:20 <mayanktg> sawrubh|ib: I guess you have to add |#include "nsIFile.idl"| in the header instead of |interface nsIFile;|
00:22:27 <mayanktg> http://mxr.mozilla.org/comm-central/source/chat/components/public/imILogger.idl#53
00:22:52 <mayanktg> the nsIFile is included at Line 7
00:25:34 <mayanktg> I'm trying it too. Hope it works ;)
00:25:45 <sawrubh|ib> you're trying my patch :o
00:26:48 <mayanktg> Not your patch ...Just adding the sendFile() to the interface
00:27:42 <sawrubh|ib> still doesn't work :/
00:28:14 <sawrubh|ib> clokep: are you back?
00:31:27 <mayanktg> My build was successful :-/
00:31:54 <sawrubh|ib> huh
00:32:44 <mayanktg> http://pastebin.instantbird.com/735840 the diff
00:32:54 <mayanktg> ohh wait
00:33:14 <sawrubh|ib> you didn't add sendFile() :P
00:33:15 <mayanktg> I forgot to add the function part in the diff :P
00:34:02 <mayanktg> oops http://pastebin.instantbird.com/735841
00:49:33 <-- mayanktg has quit (Ping timeout)
00:49:35 --> mayanktg has joined #instantbird
00:49:51 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
00:49:53 --> mayanktg has joined #instantbird
00:50:03 <-- wnayes has quit (Ping timeout)
00:53:13 <-- Rym has quit (Ping timeout)
00:53:23 --> wnayes has joined #instantbird
00:53:32 --> Rym has joined #instantbird
00:55:16 <-- sawrubh|ib has quit (Quit: sawrubh|ib)
01:05:00 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
01:53:41 <-- Tonnes has quit (Connection reset by peer)
02:02:07 <nhnt11> Hi
02:02:45 <nhnt11> "it makes it much harder to search logs by date" - why?
02:02:46 <nhnt11> :S
02:02:54 <nhnt11> flo-retina: ^
02:04:43 <-- nhnt11 has quit (Ping timeout)
02:10:53 --> nhnt11 has joined #instantbird
02:19:45 <-- Rym has quit (Ping timeout)
02:20:04 <-- nhnt11 has quit (Ping timeout)
02:23:04 --> Rym has joined #instantbird
02:28:38 --> nhnt11 has joined #instantbird
02:30:49 --> mconley has joined #instantbird
02:37:51 <-- nhnt11 has quit (Ping timeout)
02:42:16 <-- mconley has quit (Input/output error)
02:46:07 --> nhnt11 has joined #instantbird
02:49:45 <-- wnayes has quit (Ping timeout)
02:53:04 --> wnayes has joined #instantbird
03:40:16 <-- Rym has quit (Ping timeout)
03:41:53 <-- wnayes has quit (Quit: wnayes)
03:56:11 --> mayanktg-ph has joined #instantbird
04:30:31 --> mconley has joined #instantbird
05:14:40 --> jb has joined #instantbird
05:28:27 --> iamjayakumars has joined #instantbird
06:05:06 <-- mconley has quit (Input/output error)
06:07:18 <-- jb has quit (Ping timeout)
06:09:24 <-- iamjayakumars has quit (Client exited)
06:20:55 --> Tonnes has joined #instantbird
06:23:36 --> iamjayakumars has joined #instantbird
06:59:58 <-- iamjayakumars has quit (Client exited)
07:04:09 --> jb has joined #instantbird
07:16:34 <-- jb has quit (Ping timeout)
07:23:26 --> jb has joined #instantbird
07:26:04 <-- jb has quit (Ping timeout)
07:35:15 <sawrubh> nhnt11: hey
07:35:31 <sawrubh> Any idea about my issue?
07:48:49 <-- Tonnes has quit (Quit: ChatZilla [Firefox 29.0.1/20140506152807])
07:56:42 --> Tonnes has joined #instantbird
08:00:08 <flo-retina> nhnt11: because logs can't be on more than one day
08:00:26 <flo-retina> sawrubh: what about just implementing in the SendFile method in the C++ files?
08:00:27 <instantbot> c++ sucks
08:00:34 <flo-retina> (like the error message tells you you need to ;))
08:04:55 <sawrubh> flo-retina: but I thought it's up to me to specify something in interface and then implement it selectively in places I want, like I simply want to implement in xmpp and not purplexpcom
08:05:32 <flo-retina> what made you think that?
08:05:55 <sawrubh> Or is this requirement to implement SendFile in C++ added because I've added this function definition in prplIConversation.idl
08:06:16 <flo-retina> sawrubh|ib: strange thing is, the first time you talked about this error message, you knew what the problem was ("giving some error in puplexpcom, I guess I'll also have to implement this in purplexpcom") :-P
08:06:42 <flo-retina> sawrubh: sure. If you add something to an interface, you need to implement it in all places that implement the interface.
08:09:29 <sawrubh> OK, so creating an interface, implementing it in xmpp and creating that pruplexpcom wrapper will have to hand in hand then
08:31:01 <-- clokep has quit (Ping timeout)
08:31:37 --> clokep has joined #instantbird
08:31:37 * ChanServ sets mode +o clokep 
08:43:49 --> Armada has joined #instantbird
09:49:21 --> iamjayakumars has joined #instantbird
09:50:59 <-- iamjayakumars has quit (Client exited)
10:08:08 --> iamjayakumars has joined #instantbird
10:09:31 --> rosonline has joined #instantbird
10:10:34 <-- rosonline has quit (Connection reset by peer)
10:14:12 --> rosonline has joined #instantbird
10:16:36 <-- iamjayakumars has quit (Client exited)
10:31:33 <-- EionRobb has quit (Quit: Leaving.)
10:51:30 --> iamjayakumars has joined #instantbird
11:05:20 <-- iamjayakumars has quit (Client exited)
11:19:19 --> iamjayakumars has joined #instantbird
11:21:40 --> aleth has joined #instantbird
11:21:40 * ChanServ sets mode +o aleth 
11:27:58 --> mpmc has joined #instantbird
11:34:21 --> mayanktg has joined #instantbird
11:42:21 <-- nhnt11 has quit (Ping timeout)
11:47:03 <-- mayanktg has quit (Client exited)
11:52:20 <-- iamjayakumars has quit (Client exited)
11:58:32 --> iamjayakumars has joined #instantbird
11:58:42 --> mayanktg has joined #instantbird
12:02:47 <-- iamjayakumars has quit (Client exited)
12:07:04 --> iamjayakumars has joined #instantbird
12:12:48 <-- mayanktg has quit (Ping timeout)
12:16:32 <-- iamjayakumars has quit (Client exited)
12:18:16 --> mayanktg has joined #instantbird
12:20:46 --> sawrubh|ib has joined #instantbird
12:28:01 <-- BWMerlin has quit (Quit: BWMerlin)
12:28:34 <-- aleth has quit (Ping timeout)
12:30:24 --> aleth has joined #instantbird
12:30:24 * ChanServ sets mode +o aleth 
12:35:15 <sawrubh|ib> aleth: so I'm not exactly sure why it was happening but when I hadn't used a separate jar(classic.jar in this case) I was getting this issue: http://log.bezut.info/instantbird/140611/#m398
12:35:57 <aleth> sawrubh|ib: Then you should say so in the bug when responding to mconley's question ;)
12:36:50 <sawrubh|ib> aleth: I'll do that :)
12:38:44 <sawrubh|ib> aleth: two more things, out of curiosity a) can we use some method that I've defined inside xmpp.jsm without having added as part of the interface b)is there another way to make changes in purplexpcom without creating two mq's (I don't wanna constantly keep switching between two mq's for making changes, in one I'll be making the changes related to creating the interface and implementation in xmpp, in the other changes in
12:38:44 <sawrubh|ib> purplexpcom)
12:39:50 <aleth> a) no, unless it's called from inside the prpl b) it's a separate repo, so probably no
12:40:11 <sawrubh|ib> :(
12:40:26 <aleth> I'm sure you expected those answers.
12:40:57 <sawrubh|ib> yes, but I was optimistic
12:41:06 <aleth> Having an interface to expose things to the outside would be pretty pointless if you could call things not in the interface.
12:41:25 <sawrubh|ib> makes sense
12:48:00 <sawrubh|ib> aleth: also in https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=7b0fd820e09d they are orange for some reason but it builds fine on my system for example, checking the logs the errors don't *seem* to be my fault, can you see and tell if that's right?
12:49:12 <aleth> You can compare with the latest trunk build https://tbpl.mozilla.org/?tree=Thunderbird-Trunk
12:51:39 <aleth> Looks like some problems with the build config.
13:01:15 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:02:40 --> nhnt11 has joined #instantbird
13:04:29 <-- nhnt11 has quit (Ping timeout)
13:13:53 --> Mic has joined #instantbird
13:13:54 * ChanServ sets mode +o Mic 
13:34:52 --> iamjayakumars has joined #instantbird
14:00:31 <-- aleth has quit (Ping timeout)
14:04:03 <-- Tonnes has quit (Connection reset by peer)
14:07:23 --> nhnt11 has joined #instantbird
14:12:45 --> aleth has joined #instantbird
14:12:45 * ChanServ sets mode +o aleth 
14:16:28 --> Tonnes has joined #instantbird
14:26:42 <-- sawrubh|ib has quit (Ping timeout)
14:28:40 <-- clokep has quit (Ping timeout)
14:28:55 --> clokep has joined #instantbird
14:28:55 * ChanServ sets mode +o clokep 
14:32:01 <-- iamjayakumars has quit (Client exited)
14:45:27 --> sawrubh|ib has joined #instantbird
14:59:00 <flo-retina> aleth: my build failed with an error in the QQ prpl yesterday, is this something any of you have seen?
14:59:53 <aleth> Yes (I've had a patch applied locally to not build qq since forever)
15:00:26 <flo-retina> alright
15:00:32 * flo-retina just commented out the line that causes the error
15:02:05 <-- aleth has quit (Input/output error)
15:02:07 --> aleth has joined #instantbird
15:02:07 * ChanServ sets mode +o aleth 
15:02:24 <aleth> We'll have to decide whether to include it in the next version anyway, since it apparently is broken
15:02:46 <-- mayanktg-ph has quit (Quit: Connection closed for inactivity)
15:02:49 <flo-retina> hasn't it been broken like... forever? :-S
15:03:06 <aleth> yes... that doesn't change the fact that it's broken ;)
15:03:28 <aleth> I think we were hoping upstream would fix the issues eventually
15:03:29 <flo-retina> when do you see the next release happening?
15:03:34 --> jb has joined #instantbird
15:03:43 <flo-retina> aleth: upstream rm'ed the folder a long while ago
15:03:53 <aleth> after we're able to build all nightlies, plus time for the trains?
15:03:53 <flo-retina> or have we switched to a different libqq already?
15:03:57 <flo-retina> I don't remember :-S
15:04:20 <flo-retina> we still haven't figured out a strategy for releasing out of comm-* :-/
15:04:29 --> Rym has joined #instantbird
15:04:31 <flo-retina> but yeah, building nightlies is the first step
15:05:40 <-- aleth has quit (Ping timeout)
15:05:43 --> aleth has joined #instantbird
15:05:43 * ChanServ sets mode +o aleth 
15:08:07 <-- jb has quit (Ping timeout)
15:08:53 <aleth> A minimalist strategy for releasing out of comm* would be to declare a release "ready" on a merge day, giving the localisers a very generous 12 weeks.
15:11:25 <-- aleth has quit (Ping timeout)
15:11:27 --> aleth has joined #instantbird
15:11:28 * ChanServ sets mode +o aleth 
15:13:19 <-- aleth has quit (Ping timeout)
15:13:22 --> aleth has joined #instantbird
15:13:22 * ChanServ sets mode +o aleth 
15:14:30 <aleth> bah, it's really unfortunate we can't tell with IRC whether a message was actually sent or not
15:19:04 * aleth speaks to the void
15:19:32 <sawrubh|ib> aleth: The WIP are http://pastebin.instantbird.com/736157 (non-purple) and http://pastebin.instantbird.com/736158 (purple)
15:19:58 <sawrubh|ib> I still am not able to call sendFile, everything compiles (so that's something right)
15:20:30 <aleth> I don't think you want to use nsIFile somehow, try OS.File ;)
15:21:02 <-- Rym has quit (Ping timeout)
15:21:34 <sawrubh|ib> why? I used nsIFile in the previous drag and drop + filelink patch and it worked
15:22:14 <aleth> If you want your file I/O to be async, the way to do it is with OS.File, and I don't think OS.File takes nsIFiles as arguments
15:23:37 <aleth> As for why you can't call it, it's probably just this again http://log.bezut.info/instantbird/140609/#m153
15:24:34 <aleth> sawrubh|ib: Note I haven't looked at your code, maybe you have good reasons for the nsIFile.
15:25:06 <-- rosonline has quit (Client exited)
15:26:02 <aleth> sawrubh|ib: https://developer.mozilla.org/en-US/docs/JavaScript_OS.File
15:27:00 <sawrubh|ib> I was using nsIFile, because I had used it previously
15:27:06 * sawrubh|ib looks at what https://developer.mozilla.org/en-US/docs/Web/API/DataTransfer#mozGetDataAt.28.29 returns
15:27:39 <aleth> Older APIs will use nsIFile, yes
15:28:56 <aleth> Web APIs may use File
15:29:16 <aleth> It's a bit confusing at first, as mayanktg can tell you ;)
15:29:17 <sawrubh|ib> so I won't be able to use OS.File?
15:29:23 <aleth> Sure you can!
15:29:44 <sawrubh|ib> mayanktg: there?
15:30:45 <mayanktg> sawrubh|ib: yepp
15:31:18 --> Rym has joined #instantbird
15:37:38 <aleth> flo-retina: re qq, https://bugzilla.mozilla.org/show_bug.cgi?id=955231#c11
15:37:40 <instantbot> Bug 955231 nor, --, ---, clokep, NEW, Update libqq-pidgin to 0.72
15:38:59 <-- Rym has quit (Ping timeout)
15:44:17 <-- sawrubh|ib has quit (Ping timeout)
15:46:00 --> Rym has joined #instantbird
15:46:42 --> sawrubh|ib has joined #instantbird
15:50:14 --> iamjayakumars has joined #instantbird
15:50:17 <-- aleth has quit (Ping timeout)
15:50:19 --> aleth has joined #instantbird
15:50:20 * ChanServ sets mode +o aleth 
15:52:46 <-- nhnt11 has quit (Ping timeout)
15:52:47 --> nhnt11 has joined #instantbird
15:55:25 <-- clokep has quit (Ping timeout)
15:55:47 --> clokep has joined #instantbird
15:55:47 * ChanServ sets mode +o clokep 
16:03:33 <flo-retina> hmm, I wonder if with the minis we will have enough machines to have a try server :)
16:10:27 <-- sawrubh|ib has quit (Ping timeout)
16:10:36 <flo-retina> aleth: no longer having the error at the end doesn't make the |./mozilla/mach run| command work :(
16:10:50 <aleth> lol, I tried exactly the same thing.
16:10:52 --> sawrubh|ib has joined #instantbird
16:11:23 <aleth> The m-c merge would have taken care of that one :-/
16:11:23 * flo-retina is trying the buddy icon patch
16:13:43 <flo-retina> aleth: have you tried that patch?
16:13:50 <flo-retina> actually: who has tried that patch? :)
16:14:11 <aleth> The webcam one? iirc mayanktg and Mic have tried it
16:14:52 <mayanktg> Yes. Mic shared screenshots of how the patch looked in Windows.
16:15:16 <mayanktg> http://i.imgur.com/ptDZfBV.png
16:15:22 <flo-retina> bah, it looks like moving a window around between a retina and non-retina screen is completely screwing up popup/panel/tooltip sizing :(
16:15:35 <-- iamjayakumars has quit (Client exited)
16:15:39 <flo-retina> mayanktg: was the appearance there fixed?
16:16:23 <mayanktg> Yes :( nhnt11 mentioned about the error while moving from retina to non-retina screen. No it wasn't fixed.
16:16:24 <aleth> Especially the wonky borders
16:16:53 <flo-retina> aleth: is the blist window no longer resizeable? :-S
16:17:05 <aleth> Since when?
16:17:17 <flo-retina> mayanktg: so is it useful for me to review the patch, if the previous feedback hasn't been addressed?
16:17:29 <flo-retina> aleth: I don't know; I just see I can't resize it :-S
16:17:54 * aleth tries his build
16:18:03 <nhnt11> flo-retina: I can't resize mine either :S
16:18:15 <nhnt11> (Just brought it up and tried)
16:18:23 --> iamjayakumars has joined #instantbird
16:18:35 <aleth> regressions :(
16:18:49 <mayanktg> flo-retina: I addressed the previous feedback and made the changes Mic requested. (adding aero icons, compressing svg etc.) 
16:18:57 <nhnt11> What on earth
16:19:02 <nhnt11> I ran a build a while ago
16:19:06 <nhnt11> It's been 80 minutes and it's still running
16:19:38 <aleth> Did you clobber? It got trapped in a loop for me too.
16:19:48 <nhnt11> Just clobbered
16:19:53 <nhnt11> Restarting the build in a sec
16:20:05 <flo-retina> mine reticulated splines for 35 minutes yesterday before I clobbered
16:21:12 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:21:50 --> nhnt11 has joined #instantbird
16:22:06 <nhnt11> flo-retina: I can resize the blist again after restarting Ib
16:23:39 <flo-retina> mayanktg: http://imgur.com/goWUXMB,M62waFi,Z7pcUaS
16:25:11 <flo-retina> mayanktg: do you have a LED on your webcam that turns itself on when the webcam is enabled?
16:25:21 <mayanktg> flo-retina: yes.
16:25:49 <nhnt11> flo-retina: Moving the window between displays screws up tooltips?
16:25:51 <flo-retina> mayanktg: does it turn itself off when you have finished taking an user icon shoot?
16:25:55 <flo-retina> nhnt11: yes :(
16:26:07 <nhnt11> Ah, before the whois is loaded..
16:26:16 <flo-retina> nhnt11: all popups :(
16:26:50 <nhnt11> :(
16:27:05 <nhnt11> It looks especially bad with mayanktg's panel..
16:27:11 <nhnt11> tooltips fix themselves in a second
16:27:11 <flo-retina> yeah
16:27:19 <flo-retina> no, they don't (always)
16:27:32 <flo-retina> nhnt11: have you tried mayanktg's user icon patch?
16:27:36 <nhnt11> Ah yeah, for gtalk..
16:27:41 <nhnt11> flo-retina: very briefly
16:27:52 <flo-retina> did the camera turn itself off correctly after you were done taking a picture?
16:27:53 <mayanktg> flo-retina: No. The webcam still remains opened. I'll close it then. 
16:28:08 <nhnt11> I saw the panel, noticed a couple of margins were "off", noticed the popup thing when moving between displays, and didn't test anything else
16:28:15 <nhnt11> flo-retina: It didn't detect my camera
16:28:38 <-- aleth has quit (Ping timeout)
16:28:40 --> aleth has joined #instantbird
16:28:41 * ChanServ sets mode +o aleth 
16:28:44 <nhnt11> I needed to set some flag or something? Idk, I was working on something else and didn't want to disrupt my build environment
16:29:00 <mayanktg> nhnt11: It was because you didn't do a build after applying the patch.
16:29:17 <nhnt11> I think I did, but I don't think I clobbered (if that's required?)
16:29:21 <nhnt11> But whatever, I don't remember
16:29:25 <nhnt11> It was quite a long time ago...
16:29:41 <mayanktg> yeah MOZ_MEDIA_NAVIGATOR=1 in im/confvars.h . But it was included in the patch.
16:29:48 <nhnt11> right..
16:30:23 <aleth> mayanktg: "The webcam still remains opened." Don't you think that's a pretty big flaw? I thought that patch was almost ready :-/
16:31:15 <aleth> flo-retina: Doesn't that retina panel thing sound like a gecko bug? :-S
16:31:21 <flo-retina> aleth: yes!
16:31:24 <nhnt11> Yeah
16:31:42 <flo-retina> aleth: especially as I've been seeing these crazy-sized panels for a while on Firefox, and couldn't figure out why
16:32:03 <nhnt11> I just tried on fx, a couple of tooltips are badly sized after moving
16:32:25 <mayanktg> aleth: I didn't close the webcam because we would need to start the webcam again if a person clicks "reshoot". I'll change it now. 
16:33:02 <aleth> mayanktg: I don't see any problem with starting the webcam again when the user requests it ;)
16:34:36 <flo-retina> mayanktg: that sounds like a reason to _maybe_ not turn off the webcam after clicking "capture". It's certainly not a reason to keep the webcam running after the "set icon" button has been clicked.
16:34:52 <mayanktg> aleth: I'm changing it. Flo once said that some webcams take a while to get started, so making the user wait for "reshoot" as most of us would be using it more than once. 
16:35:09 <mayanktg> flo-retina: It is running even after "Set Icon" is clicked ? :-o
16:35:13 <mayanktg> wait...
16:35:20 <flo-retina> mayanktg: it is running until the blist is closed.
16:35:42 <aleth> mayanktg: It's OK to keep it on after clicking capture, but when the icon is set, it has to be off.
16:36:11 <flo-retina> and when clicking "back" and returning to the initial state of the panel, it should be off too.
16:36:29 <mayanktg> It was fine a while ago. Must have been changed during the last patch I updates
16:36:32 <aleth> I seem to be able to resize the blist at all times
16:37:33 <mayanktg> flo-retina: Yes. They were working. Wait I'm fixing it up.
16:45:02 <-- qheaden has quit (Ping timeout)
16:45:31 <-- Armada has quit (Ping timeout)
16:46:42 <-- Tonnes has quit (Connection reset by peer)
16:50:09 <-- gerard-majax_ has quit (No route to host)
16:50:14 --> gerard-majax_ has joined #instantbird
16:51:14 <-- gerard-majax_ has quit (Connection reset by peer)
16:51:20 --> gerard-majax_ has joined #instantbird
16:53:36 <-- iamjayakumars has quit (Client exited)
16:54:25 --> Armada has joined #instantbird
16:56:37 --> iamjayakumars has joined #instantbird
16:57:26 --> Tonnes has joined #instantbird
16:58:17 --> wnayes has joined #instantbird
17:05:43 <-- Rym has quit (Ping timeout)
17:06:22 --> Rym has joined #instantbird
17:07:25 <-- aleth has quit (Ping timeout)
17:07:28 --> aleth has joined #instantbird
17:07:28 * ChanServ sets mode +o aleth 
17:12:37 --> jb has joined #instantbird
17:19:01 <-- iamjayakumars has quit (Quit: )
17:24:33 <-- Tonnes has quit (Quit: ChatZilla [Firefox 29.0.1/20140506152807])
17:26:58 <-- sawrubh|ib has quit (Ping timeout)
17:27:53 --> sawrubh|ib has joined #instantbird
17:32:33 --> Tonnes has joined #instantbird
17:36:58 <mayanktg> flo-retina: I fixed the issue. Webcam is getting closed now. What do I need to change more in the patch?
17:39:18 <aleth> mayanktg: Did you see the bug comment?
17:39:55 <mayanktg> No. wait...
17:40:16 <flo-retina> bah, that logging patch isn't ready either :(
17:43:34 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
17:44:03 <-- Rym has quit (Ping timeout)
17:48:44 --> Rym has joined #instantbird
17:51:53 <-- aleth has quit (Ping timeout)
17:51:57 --> aleth has joined #instantbird
17:51:57 * ChanServ sets mode +o aleth 
17:57:01 <-- aleth has quit (Ping timeout)
17:58:06 --> aleth has joined #instantbird
17:58:07 * ChanServ sets mode +o aleth 
18:16:16 <-- sawrubh|ib has quit (Ping timeout)
18:18:19 <-- wnayes has quit (Ping timeout)
18:21:34 --> wnayes has joined #instantbird
18:24:10 --> unghost has joined #instantbird
18:28:07 <-- aleth has quit (Ping timeout)
18:32:57 <-- jb has quit (Ping timeout)
18:37:44 --> aleth has joined #instantbird
18:37:44 * ChanServ sets mode +o aleth 
18:45:07 <-- flo-retina has quit (Ping timeout)
18:51:23 <mayanktg> Do these icons match http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/menuPanel-small@2x.png (3rd one for Select File...) and http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/webRTC-shareDevice-16@2x.png ? can we use it as replacement for current Select File... and Take Picture.. button icons?
18:52:10 <nhnt11> aleth: For a one liner function that doesn't return anything, which syntax should I use? https://pastebin.mozilla.org/5414167
18:52:27 <nhnt11> First one, I think?
18:52:39 <nhnt11> clokep: ^
18:59:42 <nhnt11> flo-retina: "avoid changing the coding style in files that were consistent. Note: already requested[...]" I forgot to respond to this, sorry. FYI though, the coding style wasn't consistent (https://mxr.mozilla.org/comm-central/source/chat/components/src/logger.js#473, 488, #509, #576) so I figured I'd go with the convention that we follow now.
19:01:14 <nhnt11> Please let me know if you still want me to make it consistently "brace on new line" everywhere.
19:12:49 --> Mic|web has joined #instantbird
19:15:08 <aleth> flo-retina: btw I asked nhnt11 to make the coding style consistent with what we do now -- since most lines of the file are touched anyway in this patch I figured the usual rule didn't really apply.
19:16:01 <aleth> mayanktg: What's wrong with the current icons?
19:16:49 <aleth> nhnt11: In your pastebin, the first version *does* return something (possibly undefined if delete returns nothing)
19:17:14 <mayanktg> aleth: flo-retina said that they don't seem to have same color so we should find another from Ff toolbar.
19:17:29 <nhnt11> aleth: Yeah, but it doesn't matter what it returns (it's not expected to return anything)
19:17:53 <nhnt11> (That was my real question I guess, is it okay that that returns something?)
19:18:02 <aleth> I don't think it matters here.
19:18:20 <nhnt11> ok. I'll go with the one liner then
19:19:05 <aleth> mayanktg: I thought you edited them so they did have the same colour?
19:19:50 <mayanktg> aleth: Yes. I photoshopped them and put the same color for both of them.
19:20:27 * nhnt11 thinks flo intened to r- the Tb/gloda patch..
19:20:49 <mayanktg> aleth: I changed the other points he mentioned (close webcam, enable capture when webcam is ready, pointer). I won't be able to touch the theme for Window/Mac :-|
19:21:13 <aleth> mayanktg: I'd say make sure the webcam icon is unchanged (the same as the m-c version), and then check again the select file icon retina version to make sure you changed the colour there to match as well.
19:21:31 <aleth> Then just tell flo you did this.
19:21:50 <aleth> For the Windows theme, you needinfo? Mic, and for Mac, maybe nhnt11 can help?
19:22:03 <mayanktg> yeah. I'm redoing it again.
19:22:19 * nhnt11 can help, sure
19:22:33 <aleth> mayanktg: well, don't redo it if it's already correct. Just check it.
19:23:11 <mayanktg> aleth: Ok.
19:23:22 <aleth> mayanktg: Btw if I recall correctly, those icons were taken from the browser already.
19:23:24 <Mic|web> aleth, mayanktg: I'll have a look at the styles.
19:23:54 <aleth> Mic|web: :) didn't see you were here!
19:23:57 <Mic|web> styles/icons/... on Windows.
19:24:20 <mayanktg> aleth: Yes. They were from the browser. Select File was cropped from a set of icons.
19:24:31 <nhnt11> mayanktg, aleth: Weren't they originally android resources? or did you drop those?
19:24:55 <nhnt11> (Or were those for something else entirely?)
19:25:10 <aleth> I remember we dropped the android ones. (At least that's what we decided here at the time)
19:25:15 <nhnt11> okay
19:26:27 <Mic|web> mayanktg: when choosing an icon, we should make sure that we also have matching icons for file transfers for example, lest we have to start over once sawrubh is looking for icons.
19:27:48 <mayanktg> Mic|web: Ok. I'll search one for File Transfer too :)
19:28:31 <aleth> Mic|web, mayanktg: iirc the icons came from these OS-specific folders https://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/
19:28:37 <Mic|web> Thinking about it the Download-icon that's used for the panel might be the one that we'd like to match.
19:29:08 <Mic|web> sawrubh: you're going to use the download icon and panel of Firefox for file transfer?
19:29:09 <aleth> I don't think we have to worry about a file transfer icon if sawrubh reuses the Download panel. At least not for now.
19:29:36 <aleth> Mic|web had a neat idea where you change the arrow direction for "upload" iirc
19:29:53 <Mic|web> Yes, I also did mockups for that once.
19:29:54 <mayanktg> aleth: Yes. I borrowed those icons from that source only /browser/themes/osx
19:30:55 <sawrubh> I was planning to use that Download panel icon, yeah
19:31:34 <sawrubh> Mic|web: what about when we have a download and an upload going simultaneously?
19:32:29 <Mic|web> sawrubh: I used two smaller arrows in opposite directions for this case.
19:32:30 <aleth> mayanktg: ah, here's the other one https://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/menuPanel.png
19:32:51 <aleth> Notice they have a subtle gradient to them, I hope that didn't get lost.
19:32:57 <Mic|web> I suspect that flo wants to have a say in this as well ;)
19:32:59 <sawrubh> Mic|web: is it online?
19:33:05 <Mic|web> umm...
19:33:27 <Mic|web> Let me see. Too bad that I haven't synced my Fx profile yet, so no awesomebar results for me yet :(
19:35:45 <mayanktg> aleth: So I'll pickup the Select File icon from there, match it up with the color of webrtc-icon and also ensure that the gradient is similar for both the icons. Right?
19:36:16 <-- unghost has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
19:36:23 <aleth> mayanktg: Yes... but if that's what you've already done, you don't need to do anything ;)
19:37:12 <aleth> One thing you might have missed is that the different sizes have slightly different colours.
19:37:51 <mayanktg> The gradient was lost. Yeah probably. I'm just confirming and uploading it with a new one if it has got variations 
19:38:08 <aleth> So double-check you used https://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/menuPanel@2x.png and the @2x retina version of the webcam icon, not just double the size of the normal one.
19:58:21 <-- aleth has quit (Ping timeout)
19:58:56 --> Armada651 has joined #instantbird
19:59:55 <-- Armada has quit (Ping timeout)
20:07:47 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
20:09:24 --> flo-retina has joined #instantbird
20:09:25 * ChanServ sets mode +qo flo-retina flo-retina 
20:14:13 --> EionRobb has joined #instantbird
20:15:06 * Armada651 is now known as Armada
20:17:32 <-- wnayes has quit (Ping timeout)
20:18:05 --> mpmc has joined #instantbird
20:20:51 --> wnayes has joined #instantbird
20:29:54 --> mconley has joined #instantbird
20:37:13 <mayanktg> Does the icons have same color now and they look good enough to be used? http://i.imgur.com/6JdjLb1.png 
20:38:22 <flo-retina> mayanktg: are they both coming from the Firefox toolbar?
20:38:31 <flo-retina> (my guess is 'no')
20:39:37 <mayanktg> flo-retina: The Select File... icon is from https://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/menuPanel@2x.png and the Take Picture... icon is from http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/webRTC-shareDevice-16@2x.png
20:40:16 <mayanktg> I couldn't find a suitable icon in there :(
20:40:23 <flo-retina> ok... let me find for you the camera icon of the toolbar
20:44:24 <flo-retina> mayanktg: you have both icons on http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/Toolbar@2x.png
20:44:59 <flo-retina> and http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/Toolbar.png for the non-retina version
20:47:37 <nhnt11> flo-retina: I've changed everything back to "brace on a new line", please let me know if you want to change your mind considering http://log.bezut.info/instantbird/today/#m361. I'll upload a new patch before going to bed.
20:48:04 <mayanktg> ok..thanks. I'm changing the icons with these ones.
20:48:09 <flo-retina> bah I had missed that part of the log
20:49:35 <flo-retina> nhnt11: do whatever you prefer with these {, sorry for the confusion.
20:50:14 <nhnt11> Alright. I prefer "brace on the same line". Thanks
20:50:35 <flo-retina> nhnt11: don't use "function() foo" without {} if you don't intend to return something
20:50:44 <nhnt11> Okay, thanks
20:51:52 <nhnt11> I've replied to a couple of your queries on the bug btw
20:58:37 <flo-retina> nhnt11: ok, so the last thing we haven't agreed on yet is getLogPathForConversation
20:59:23 <nhnt11> flo-retina: Would you rather I just returned a path synchronously?
20:59:31 <nhnt11> or, not wait on initialized?
21:01:08 <flo-retina> nhnt11: I don't really understand what that code is trying to do :(
21:01:11 <flo-retina> both before and after the patch
21:01:21 <flo-retina> I guess I need to look at more context / the existing file
21:01:33 <nhnt11> flo-retina: Before the patch, it creates a log writer if one doesn't already exist, and returns its path
21:01:46 <nhnt11> at this point the file at that path is guaranteed to exist because everything is synchronous
21:01:47 <flo-retina> no, I mean the caller code
21:01:50 <nhnt11> Oh
21:01:54 <flo-retina> there's no good reason for the indexing code to create a log file
21:02:06 <-- gerard-majax_ has quit (Ping timeout)
21:03:34 --> gerard-majax_ has joined #instantbird
21:06:03 <flo-retina> nhnt11: can you make this wait for all pending write operations to finish?
21:06:27 <nhnt11> Yes
21:07:18 <flo-retina> _beginIndexingJob is called either when receiving the "conversation-closed" notification, or 5s after the "new-text" notification
21:08:05 <nhnt11> In that case... It's unlikely that a new log writer has to be created in the existing code
21:08:07 <flo-retina> ok, great. So please don't make that function create the file; ever. Just wait for all pending write operations before resolving the promise. And if the file really doesn't exist, resolve to null 
21:08:18 <nhnt11> Okay.
21:11:03 <flo-retina> Ensure the code doesn't fail too spectacularly if null is returned (looks like |this._knownConversations[convId].scheduledIndex = null;| needs to be executed; could be done with a try/finally).
21:11:04 <flo-retina> This code still feels vaguely broken; but I don't want to make you rewrite more of the gloda indexing code. That would just be painful for both of us, without any obvious benefit ;).
21:18:42 <nhnt11> flo-retina: How about making the promise reject instead of resolving to null?
21:18:49 <nhnt11> It'll be easier to handle in the calling code as well
21:21:13 <flo-retina> that's fine
21:21:27 <flo-retina> would we be in this case if logging is disabled?
21:22:40 <nhnt11> Yes.
21:22:44 <flo-retina> ok
21:22:59 <flo-retina> so we certainly don't want to create log files with the headers if logging is disabled ;)
21:23:42 <nhnt11> Well the current patch doesn't create log files in that case
21:24:04 <nhnt11> It fails with ReferenceError: writer._initialized is undefined ;)
21:25:11 <flo-retina> ahah
21:26:06 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:30:23 <mayanktg> flo-retina: http://i.imgur.com/rIcEvjI.png :)
22:00:17 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:07:32 <-- Even has quit (Ping timeout)
22:12:57 --> chrisccoulson has joined #instantbird
22:17:32 <-- wnayes has quit (Ping timeout)
22:20:53 --> wnayes has joined #instantbird
22:21:00 <-- Armada has quit (Connection reset by peer)
22:24:23 <-- Rym has quit (Ping timeout)
22:26:07 <-- mpmc has quit (Connection reset by peer)
22:27:18 --> mpmc has joined #instantbird
22:41:05 <-- mconley has quit (Input/output error)
22:53:59 --> Rym has joined #instantbird
23:50:00 <-- Rym has quit (Ping timeout)
23:50:16 --> Rym has joined #instantbird
23:55:29 --> mconley has joined #instantbird