#instantbird log on 06 11 2014

All times are UTC.

00:04:26 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
00:13:54 <mayanktg> Finally done with the offer :D
00:14:05 <clokep> Woot!
00:14:15 <mayanktg> :)
00:14:29 * mayanktg going to write tests for xml2sdp now 
00:23:10 <-- Rym has quit (Ping timeout)
00:24:01 --> Rym has joined #instantbird
00:47:09 <-- Fallen|away has quit (Ping timeout)
00:50:52 --> Fallen|away has joined #instantbird
01:01:18 <-- Mook_as has quit (Quit: Mook_as)
01:27:48 --> clokep_work has joined #instantbird
01:27:48 * ChanServ sets mode +o clokep_work 
01:51:29 <-- clokep_work has quit (Ping timeout)
02:15:19 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
02:29:38 --> mconley has joined #instantbird
02:30:59 <-- clokep has quit (Ping timeout)
03:02:46 <sawrubh> clokep sorry I had slept
03:02:55 <sawrubh> Morning people!
04:07:31 <-- nhnt11 has quit (Ping timeout)
04:08:30 --> nhnt11 has joined #instantbird
04:42:04 --> sawrubh|ib has joined #instantbird
04:46:02 <-- Rym has quit (Ping timeout)
05:17:33 <sawrubh|ib> bah, http://pastebin.instantbird.com/733673 is the WIP
05:18:13 <sawrubh|ib> file is coming out as null on L198 :(
05:18:29 * sawrubh|ib wonders if anyone is even awake at this point
05:18:57 * sawrubh|ib goes to fix the TB CSS that he has broken
05:44:13 --> Armada has joined #instantbird
05:47:23 <-- sawrubh|ib has quit (Quit: sawrubh|ib)
05:48:59 <-- Armada has quit (Connection reset by peer)
05:51:32 <-- EionRobb has quit (Quit: Leaving.)
05:55:42 --> jb has joined #instantbird
05:57:15 --> Armada has joined #instantbird
05:58:45 <sawrubh> Current status: TB building on laptop making it useless, browsing on mobile
06:34:25 <-- jb has quit (Ping timeout)
07:46:22 --> jb has joined #instantbird
07:54:50 <-- mayanktg has quit (Ping timeout)
08:03:28 --> sonny has joined #instantbird
08:17:46 --> sawrubh|ib has joined #instantbird
08:23:43 --> EionRobb has joined #instantbird
08:23:44 --> Mic has joined #instantbird
08:23:44 * ChanServ sets mode +o Mic 
08:27:00 <sawrubh|ib> I can't understand. So what's happening is that the icons for the various providers like Box, Hightail are not showing up in TB, while they work all right in IB
08:27:37 <sawrubh|ib> I was wondering if the files in chat/ are not package when we build TB or not?
08:28:05 <sawrubh|ib> https://bugzilla.mozilla.org/attachment.cgi?id=8436940 is the patch btw
08:34:09 <sawrubh|ib> so I've moved box-log.png from TB to chat/ and addAccountDialog.xul accesses it  via http://dxr.mozilla.org/comm-central/source/mail/components/cloudfile/nsBox.js#42
08:34:26 <sawrubh|ib> now that path remains unchanges, so if it works in IB, it should technically work in TB
08:39:56 <-- sonny has quit (Ping timeout)
08:40:31 --> sonny has joined #instantbird
08:42:11 <-- sonny has quit (Ping timeout)
08:44:00 <Mic> Does any other of the files that you moved in a similar way work for you?
08:45:30 <Mic> sawrubh|ib: ^
08:50:36 <sawrubh> Yes
08:50:57 <sawrubh> I mean the files I moved to chat/clousfile works
08:51:11 <sawrubh> That's where addAccountDialog.xul is located
08:51:51 <Mic> I rather mean something like the logo of the other service.
08:52:56 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
08:53:03 --> nhnt11 has joined #instantbird
08:54:10 <sawrubh|ib> so I moved the logo's of both (Box and Hightail) and they both don't work
08:54:18 <sawrubh|ib> let me show you a screenshot
08:55:10 <sawrubh|ib> btw does openDialog(<path to png file>); work in the error console, I'm trying to see if I'm able to access the files
08:56:09 <Mic> It should work, yes.
08:56:28 <Mic> You can also paste the path in DOM Inspector's adress bar.
08:56:58 <Mic> It will show the file in the main area (below the adress bar) if it's registered under that path.
08:57:47 <sawrubh|ib> http://imgur.com/nfHiaAq,7APK7Pc,4n2m8im,QLqsVzI is what I see
08:57:50 <Mic> Could you pastebin the generated chrome manifest files? I wanna have a look at the chrome registration lines.
08:58:53 <sawrubh|ib> so you can see in the screenshots, that dropbox's (which I installed as an addon) icon is working
09:00:07 <sawrubh|ib> also the CSS which styles http://dxr.mozilla.org/comm-central/source/mail/components/cloudfile/content/Box/management.xhtml seems to be not working
09:00:21 <Mic> I don't see any DropBox icon on the screenshot?
09:00:23 <sawrubh|ib> Mic: where do I get the generated chrome manifest files?
09:00:47 <sawrubh|ib> Mic: the last one (among the four) you can see the dropbox icon besides the entry in the menu (on the add account dialog)
09:02:13 --> sonny has joined #instantbird
09:02:52 <Mic> Can you check if I am looking at the right image?
09:02:59 <-- sonny has quit (Client exited)
09:03:55 <Mic> Wait, that's a gallery? Sorry, I thought you linked to a single image.
09:04:32 <Mic> Yes, there's the icon. I see.
09:04:48 <Mic> Search for chrome.manifest in your obj-dir.
09:05:34 <sawrubh|ib> there are quite a few, guess I'll find the one for chat/themes
09:06:30 <Mic> I think I'm interested in the one for chat (should be at <objdir>/mozilla/dist/bin/chrome/chat.manifest) and the one for Thunderbird that contained the registration before.
09:07:35 <Mic> Did you see the images using openDialog(<...>); by the way?
09:07:57 <sawrubh|ib> no, it doesn't work, I tried opening the xhtml and that opened
09:07:58 <Mic> (I guess no?)
09:08:40 <sawrubh|ib> I t
09:09:05 --> sonny has joined #instantbird
09:09:13 <Mic> ?
09:09:26 <-- sonny has quit (Client exited)
09:10:45 --> sonny has joined #instantbird
09:10:52 <sawrubh|ib> ignore previous message
09:11:02 <sawrubh|ib> this is what I try : openDialog("chrome://messenger/skin/icons/insecure.png");
09:11:50 <sawrubh|ib> and it doesn't open (insecure.png is a file inside /home/sawrubh/Mozilla/comm-central/mail/themes/linux/mail/icons
09:11:55 <sawrubh|ib> so it should have worked
09:18:14 <Mic> That's in Instantbird or Thunderbird?
09:19:30 <sawrubh|ib> I'm running TB's error console and doing all this in that, this insecure.png is a file inside mail's icon directory
09:21:53 <sawrubh|ib> btw the chrome url for box-logo.png is 'chrome://messenger/skin/icons/box-logo.png', do you still want chat.manifest or messenger.manifest, both of these are in mozilla/dist/bin/chrome
09:22:27 <sawrubh|ib> http://pastebin.instantbird.com/733772 is messenger.manifest
09:22:40 <sawrubh|ib> http://pastebin.instantbird.com/733771 is chat.manifest
09:24:59 <Mic> Thanks
09:25:31 <sawrubh|ib> Thank YOU for helping me :)
09:27:42 <sawrubh|ib> ah, interesting. So inside '/home/sawrubh/build/mozilla/dist/bin/chrome/chat/skin/classic/messenger' I see the icons directory (where I moved the box-logo.png) so it's not like the icon isn't getting packaged
09:28:42 <Mic> At the moment I want to find out if you have two different skin-registrations that are pointing to two different directories.
09:28:52 <Mic> That wouldn't work afaik.
09:29:13 <sawrubh|ib> ah, so you also want the manifest file for...where TB would have put it
09:29:26 <Mic> *two different skin-registrations for "messenger"
09:29:28 * sawrubh|ib finds out which manifest file to give you
09:32:19 <sawrubh|ib> which manifest file should I check to find this out?
09:34:32 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:35:11 <Mic> I don't know anything about TB, sorry.
09:36:36 <Mic> I'll be back in a few minutes.
09:37:04 <Mic> I think it would be worth checking if you have clashing skin-chrome registrations...
09:38:46 <-- Mic has quit (Ping timeout)
09:48:07 --> Mic has joined #instantbird
09:48:07 * ChanServ sets mode +o Mic 
09:48:48 <sawrubh|ib> ok, so here's my understanding (which might not be correct). I removed the entry corresponding to box-logo.png from the jar.mn in mail where the icon was located, moved the icon to chat, added the entry in jar.mn of chat/themes, the overall chrome url has remained the same (because that's why the icons work in IB)
09:49:08 <sawrubh|ib> how would I check clashing skin-chrome registrations....lets see
09:53:33 --> BWMerlin has joined #instantbird
10:03:24 --> clokep has joined #instantbird
10:03:24 * ChanServ sets mode +o clokep 
10:09:58 --> flo-retina has joined #instantbird
10:09:58 * ChanServ sets mode +qo flo-retina flo-retina 
10:13:54 --> mayanktg has joined #instantbird
10:19:27 --> mpmc has joined #instantbird
10:22:29 <Mic> bye
10:22:31 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
10:24:20 <-- EionRobb has quit (Quit: Leaving.)
10:43:38 <-- sonny has quit (Ping timeout)
10:55:05 --> sonny has joined #instantbird
10:56:35 <clokep> sawrubh|ib: I'm on my way out, but are there any errors about missing icon files or anything of that sort? Did you check to see if the files are actually packaged anywhere?
11:05:26 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:33:35 --> aleth has joined #instantbird
11:33:35 * ChanServ sets mode +o aleth 
11:48:59 <-- aleth has quit (Ping timeout)
11:49:11 --> aleth has joined #instantbird
11:49:11 * ChanServ sets mode +o aleth 
11:52:01 --> clokep_work has joined #instantbird
11:52:01 * ChanServ sets mode +o clokep_work 
11:58:00 <clokep_work> sawrubh|ib: Ping
12:03:45 <-- BWMerlin has quit (Quit: BWMerlin)
12:04:50 <mayanktg> aleth: Hey. I've created the whole SDP now. I'm passing the  received <content> stanzas as argument. But while writing test I'm unable to get how to convert the sample input string into XML stanza. :(
12:05:07 <mayanktg> Wait I'm sharing pastebin of the function and the test
12:10:27 <mayanktg> aleth: http://pastebin.instantbird.com/733843 (Line 156) I'm getting the <content> nodes here.
12:11:58 <aleth> Is your problem in this pastebin or in the test (not in the pastebin)?
12:12:08 <mayanktg> aleth: http://pastebin.instantbird.com/733844 (Line 145) the |jingle.xml2sdp(input)| is unable to perform for the given input
12:12:18 <mayanktg> Its in the test. 
12:12:49 <aleth> Line 156 is almost certainly wrong though.
12:13:35 <aleth> mayanktg: In the test, isn't the output of the new test the same as the input of the sdp2xml test?
12:14:36 <flo-retina> mayanktg: for the test, I guess creating an xmpp parser would help: http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp-xml.jsm#288
12:14:50 <mayanktg> aleth: Upon receiving the stanzas "xmlns" is added to every node. So it is different in a way. But I guess that would work too 
12:15:31 <aleth> Who adds the xmlns?
12:16:33 <mayanktg> idk. But when I checked the sending and received stanzas on different clients they where different (due to the addition of xmlns)
12:16:43 <aleth> mayanktg: Ah no, sorry, I think line 156 in your first pastebin should work actually (I missed the 's' in getElements ;) )
12:17:02 <aleth> mayanktg: So the stanza you send doesn't have them, and the server adds them?
12:17:15 <mayanktg> yeah.
12:18:04 <aleth> Does your xml2sdp require the xmlns to be there or doesn't it matter?
12:18:09 <mayanktg> aleth: The problem is that. I'm taking the input as array of strings, but it should have been rather an array of XML stanzas. That's why I'm unable to perform any getElement() on the given input.
12:18:28 <aleth> I understand that part.
12:19:16 <mayanktg> aleth: No. it doesn't. It should work with the given output of sdp2xml.
12:20:36 <aleth> OK. In that case I think it's enough if you use the same test constants for both. i.e. have a sdpstring and an xml string and then use the output of sdp2xml (the array) to test xml2sdp.
12:20:54 <mayanktg> Yes. Ok i'll do that :)
12:21:09 <mayanktg> great!
12:21:11 <aleth> Since you already test the sdp2xml output is correct.
12:21:18 <-- sawrubh|ib has quit (Ping timeout)
12:21:24 <mayanktg> yepp...Got it :)
12:22:18 <-- gerard-majax_ has quit (Ping timeout)
12:22:33 --> sawrubh|ib has joined #instantbird
12:23:25 <aleth> Alternatively, like flo said, you have to create an XMLParser and parse your xml string with it to obtain node objects.
12:25:24 <aleth> Before this lands, we'll probably want/have more than one test input anyway.
12:30:57 <mayanktg> Yes. I was going to ask for the same. I only have offer for my machine.
12:33:56 <aleth> Once people start testing your patches (when we can establish a connection via XMPP), I'm sure it'll be easy to get a few more ;)
12:40:01 --> qheaden has joined #instantbird
12:53:29 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:53:56 --> qheaden has joined #instantbird
12:56:09 <-- qheaden has quit (Input/output error)
12:58:07 --> qheaden has joined #instantbird
13:01:50 --> gerard-majax_ has joined #instantbird
13:01:53 <clokep_work> sawrubh|ib: So...did you figure out that styling issue or no?
13:02:04 <mayanktg> aleth: the test passed :)
13:02:38 <aleth> mayanktg: Good :)
13:02:41 <aleth> What's next?
13:02:42 <mayanktg> aleth: NEXT is --> giving this answer to conversation binding to form an answer
13:02:44 <mayanktg> :P
13:02:52 <aleth> :D
13:02:57 <flo-retina> I don't think ":P" is appropriate here.
13:03:37 <aleth> mayanktg: Do you know how to do that?
13:03:38 <mayanktg> flo-retina: Sorry. It was because I knew aleth would be asking me this question
13:03:40 <-- gerard-majax_ has quit (Ping timeout)
13:04:00 <aleth> mayanktg: I understood.
13:05:17 <mayanktg> I'll have to pass the string from xmpp.jsm to conversation binding.. 
13:05:27 --> gerard-majax_ has joined #instantbird
13:08:15 <mayanktg> idk how to to that :-/ ..Its just the opposite of how we were sending the offer generated at conversation binding to the prpl. 
13:11:53 <aleth> You use this.notifyObservers() from the prpl to send a notification. The conversation binding will receive it here http://mxr.mozilla.org/comm-central/source/im/content/conversation.xml#1773. You can pass the offer in the aData parameter.
13:17:00 <sawrubh|ib> clokep_work: pong, yes I can see the files packaged in 'dist/bin/chrome/chat/skin/classic/messenger/icons' and I couldn't find any other skin-chrome registrations besides the one in messenger.manifest and no I couldn't get it working yet
13:18:00 <sawrubh|ib> I'm starting to write the WIP for the interface creation part
13:21:08 <clokep_work> Alright.
13:21:40 <clokep_work> flo-retina: Did you see those issues? Do you have any ideas?
13:22:14 <flo-retina> I don't understand the question. What's the issue?
13:24:01 <sawrubh|ib> let me post htem again in a concise format
13:25:16 <sawrubh|ib> http://imgur.com/nfHiaAq,7APK7Pc,4n2m8im,QLqsVzI is how TB's preference pane looks after my changes(it's a gallery with multiple images) , you can notice that the provider icons are missing in them
13:26:17 <sawrubh|ib> functionality wise they're working fine, that's why they passed the mozmill tests, I think, you'll also notice in the 4th image the dropbox addon has it's provider icon alright (so it shows I've only broken the existing providers, which makes sense too)
13:27:51 <sawrubh|ib> so then I checked if the provider icons (which I moved from mail's icons directory to chat's icons directory (I created one as you can see in the patch)) are getting packaged and they seem to be present in 'dist/bin/chrome/chat/skin/classic/messenger/icons' which makes me think they are packaged
13:29:07 <flo-retina> so find the URL currently used to attempt to display these images
13:29:15 <flo-retina> and then try to open it
13:29:24 <flo-retina> (in the error console, openDialog(url))
13:29:27 <flo-retina> that should show the image
13:29:30 <sawrubh|ib> I tried that and it doesn't open (I did it using openDialog)
13:29:31 <flo-retina> or may show an error
13:29:43 <flo-retina> do you get any error in the terminal or the console?
13:30:09 <sawrubh|ib> it doesn't show any error, it just doesn't open, I tried opening other icons in the mail's theme directory and those don't open too, I tried opening a xhtml and that opens
13:31:06 <flo-retina> if you do openDialog("about:logo")
13:31:08 <flo-retina> does it open?
13:31:43 * sawrubh|ib tries
13:32:06 <sawrubh|ib> fwiw I have 'ac_add_options --disable-debug-symbols' in my mozconfig, do you think that could be doing this?
13:32:24 <flo-retina> no
13:33:18 <sawrubh|ib> openDialog("about:logo") doesn't open anything, nor do I get any errors either on the terminal or the error console
13:33:23 <flo-retina> openDialog("chrome://messenger/skin/icons/box-logo.png") also opens a dialog for me
13:33:49 * sawrubh|ib tries on some non-image-y resource
13:33:51 <flo-retina> is there anything displayed in the console?
13:34:07 <flo-retina> for me it displays "[object ChromeWindow]"
13:34:30 <sawrubh|ib> for me it does that too
13:34:42 <sawrubh|ib> but I don't see any dialogs with an object or anything
13:34:54 <sawrubh|ib> hrm
13:35:02 <flo-retina> if you select the main TB window, are they listed in the "Window" menu?
13:35:17 <flo-retina> hrm?
13:35:42 <sawrubh|ib> hrm (just an expression I use when things don't work)
13:37:48 <sawrubh|ib> http://i.imgur.com/VDlGXsL.png is what I see and I see no Windows menu, I've pressed Alt to show the menu but nothings comes
13:37:57 <sawrubh|ib> where do I find the "Windows" menu?
13:39:02 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:39:56 <flo-retina> is there a way to re-enable the standard menu bar instead of the hamburger menu?
13:40:11 * sawrubh|ib checks the prefs
13:40:53 <clokep_work> Alt brings it up on Windows.
13:41:44 --> rosonline has joined #instantbird
13:43:15 <sawrubh|ib> It's not bringing it up on Linux for some reason, it does in Firefox
13:44:44 <aleth> Might be worth filing a TB bug for that if it's really broken.
13:50:01 <sawrubh|ib> aha
13:51:21 <sawrubh|ib> so I'm able to open JS, XUL files (like chrome://messenger/skin/cloudfile/addAccountDialog.{xul, js}) however when I try to open chrome://messenger/skin/cloudfile/addAccountDialog.css it says file not found
13:52:26 <flo-retina> what's the exact path in dist/bin ?
13:52:56 <sawrubh|ib> so http://pastebin.instantbird.com/733883 is my changes to chat/themes/jar.mn
13:53:53 <flo-retina> are these files really different for each OS?
13:54:10 <sawrubh|ib> the path to addAccountDialog.css is '/mozilla/dist/bin/chrome/chat/skin/classic/messenger/cloudfile'
13:54:23 <flo-retina> so you are positive that file exists?
13:54:53 <sawrubh|ib> I can see a symlink to addAccountDialog.css in the path I mentioned above
13:55:11 <flo-retina> and the symlink isn't broken?
13:55:45 <sawrubh|ib> no, clicking on it opens the correct file for me
13:57:32 <flo-retina> do you have a debug build around?
13:58:41 --> clokep_w1 has joined #instantbird
13:58:45 <sawrubh|ib> no, I can build though
13:59:01 <-- clokep_work has quit (Input/output error)
13:59:10 <sawrubh|ib> I had requested Opt builds on Try so that doesn't help
13:59:43 * sawrubh|ib starts the build then
14:00:08 <sawrubh|ib> flo-retina: just wondering how would a debug build help btw?
14:00:50 * clokep_w1 is now known as clokep_work
14:01:03 <flo-retina> sawrubh|ib: when attempting to access a chrome file that doesn't exist, debug builds print a warning to the terminal
14:01:27 <flo-retina> sawrubh|ib: so if the file isn't packaged/accessed correctly, a debug build will at least tell you what file it attempted to load
14:01:29 * sawrubh|ib makes a mental note to request debug builds on try as well
14:03:57 --> sukhe has joined #instantbird
14:06:57 <-- mconley has quit (Input/output error)
14:08:39 <sawrubh|ib> also curious, is there a way to find out inside TB itself it it's a debug build?
14:09:37 <-- sukhe has left #instantbird ()
14:15:48 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:15:49 --> clokep_work has joined #instantbird
14:15:49 * ChanServ sets mode +o clokep_work 
14:16:17 <sawrubh|ib> should I clobber btw (right now I've started without clobbering) although I've run ./mozilla/mach configure
14:16:51 <sawrubh|ib> http://pastebin.instantbird.com/733886 is my mozconfig btw
14:17:16 <sawrubh|ib> clokep_work: any thoughts on http://log.bezut.info/instantbird/today#m22 ?
14:18:10 <clokep_work> sawrubh|ib: In what context?
14:18:21 <clokep_work> thoughts on what? Can you be more specific?
14:19:40 <-- sawrubh|ib has quit (Quit: sawrubh|ib)
14:21:04 <sawrubh> Laptop is too hot
14:22:37 --> Rym has joined #instantbird
14:25:12 <nhnt11> sawrubh: When that happened on my old machine, I would rest my laptop on the keyboard on a stool (upside down) with the intake vent facing up, and put it directly under a fan at full speed for the duration of the build
14:25:19 <sawrubh> clokep_work: do you have any idea why that error would be coming, why file would be coming out as null? Is it because a a event.dataTransfer doesn't exist (even though it should as I'm passing it as an argument)
14:26:16 --> iamjayakumars has joined #instantbird
14:30:56 <sawrubh> flo-retina: "are these files really different for each OS" I'll have to check, I just copied from TB and they seem to have separate copies for each OS
14:31:18 <flo-retina> ok
14:32:07 <-- iamjayakumars has quit (Connection reset by peer)
14:32:33 --> iamjayakumars has joined #instantbird
14:33:50 <clokep_work> sawrubh: You need to give me a lot more context!
14:34:01 <clokep_work> I don't know what error your'e talking about.
14:34:13 <sawrubh> OK, I'll do that once I come back to my laptop
14:34:50 <iamjayakumars> Hi, I don't know Why Instanbird Stable and Nightly Crash always, when i use CMD + Q to quit in MAC
14:34:58 <iamjayakumars> anyone facing this issue 
14:36:05 --> mconley has joined #instantbird
14:36:45 <aleth> iamjayakumars: Nobody has reported that before. Does it crash if you quit from the menu?
14:37:15 <iamjayakumars> aleth: i already reported a long back
14:37:26 <aleth> iamjayakumars: Did you file a bug?
14:37:32 <iamjayakumars> Nope, Only when i use the Shortcut key
14:37:34 <aleth> Otherwise things get lost.
14:37:36 <iamjayakumars> nope aleth
14:38:01 <aleth> What IB windows are open when you press the shortcut key?
14:38:45 <aleth> Did you send a crash report?
14:38:59 <iamjayakumars> Only main windows, not chat windows
14:39:17 <iamjayakumars> if i use the shortcut key to close, it crash and no crash report
14:39:54 <aleth> How do you know it crashes if there is no crash report?
14:40:40 <aleth> i.e. what exactly happens?
14:40:41 <iamjayakumars> OMG, when i click the preferences also it crash
14:41:10 <aleth> And which version of OSX is this?
14:41:25 * aleth is on OSX and has never seen this
14:42:09 <iamjayakumars> 10.9.3
14:42:24 <clokep_work> THis sounds like that bug that flo-retina complains has existed forever?
14:43:05 <iamjayakumars> i'm not using non-retina display
14:43:07 <flo-retina> iamjayakumars: have you closed the contacts window?
14:43:22 <flo-retina> aleth: it smells a lot like our top crasher
14:43:41 <aleth> But we have crash reports for our top crasher...
14:43:41 <flo-retina> aleth: start a nightly, close the contacts window, press Command+, to open the pref window. That crashes most of the time.
14:44:09 <iamjayakumars> ya same crash i closed chat and main contact window also
14:44:20 <iamjayakumars> No error and no warnings :(
14:44:31 <aleth> flo-retina: Doesn't crash for me ...
14:44:38 <iamjayakumars> some messages only
14:44:46 <aleth> Intermittent crashes are hard to pin down :-/
14:44:58 <flo-retina> aleth: it's hard, and it's in ObjectiveC code, I don't know that language :(
14:45:08 <flo-retina> aleth: it has been RESOLVED FIXED, but we still get stacks...
14:45:46 <iamjayakumars> i faced this same issue in 10.8, 10.9, 10.9.1,10.9.2,10.9.3
14:46:45 <nhnt11> aleth: you've never seen this? :S
14:46:49 <aleth> No
14:46:56 <nhnt11> This happens pretty much /every/ time for me
14:47:08 <nhnt11> (close the blist and cmd+,)
14:47:35 --> nhnt12 has joined #instantbird
14:47:47 <-- nhnt12 has quit (Input/output error)
14:47:47 <-- nhnt11 has quit (Input/output error)
14:47:56 --> nhnt11 has joined #instantbird
14:48:06 <sawrubh> Is this the one I was cc'ed on?
14:48:26 --> nhnt12 has joined #instantbird
14:48:41 <nhnt12> I just reproduced it 3 times in a row :(
14:48:51 <-- nhnt11 has quit (NickServ (GHOST command used by nhnt12))
14:48:54 * nhnt12 is now known as nhnt11
14:49:27 <flo-retina> nhnt11: feel free to debug it ;)
14:49:35 * nhnt11 goes back to his dinner ;)
14:49:41 <flo-retina> aleth: haven't we fixed that completion bug about having the same nick offered twice in the completions?
14:49:56 <aleth> flo-retina: no
14:50:03 <flo-retina> (because nhnt11 has left, and nhnt11 is nhnt12's new nick)
14:50:40 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:50:41 <clokep_work> :-S That's a fun bug! :)
14:50:45 <flo-retina> nhnt11: if you don't have the habit of closing the blist, or don't use the menu, it never crashes
14:51:09 <nhnt11> flo-retina: Right, but aleth just said he couldn't reproduce it
14:51:18 <aleth> I tried a couple of times to reproduce it.
14:51:36 * nhnt11 just leaves the blist open when his screen is connected
14:52:31 * flo-retina would like to reproduce it on a machine with a working valgrind
14:52:40 <flo-retina> that requires OS X 10.6 or 10.7 IIRC
14:55:56 --> sawrubh|ib has joined #instantbird
14:57:42 <aleth> nhnt11: On the other hand, I see a nsIWindowWatcher.openWindow shutdown error every single time and it's intermittent for everyone else ;)
14:58:26 * aleth has been meaning to fix it
14:59:16 <flo-retina> maybe that's saving you from the crash? :-D
14:59:47 <aleth> So if I fix it I'll get crashes? That's demotivating ;)
15:02:54 <sawrubh|ib> I get this error during building TB : http://pastebin.instantbird.com/733909
15:03:25 <flo-retina> aleth: you just get to fix the crash and be our hero! :)
15:04:51 * sawrubh|ib tries clobbering :(
15:05:43 <sawrubh|ib> this is frustrating, goodbye for another 30 minutes
15:05:50 <-- sawrubh|ib has quit (Quit: sawrubh|ib)
15:06:41 <clokep_work> sawrubh: Didn't you have a question for me? Now might be a good time to talk about it.
15:08:43 <aleth> sawrubh: Can't you work on some other part of the code while waiting for the build?
15:09:34 <-- iamjayakumars has quit (Client exited)
15:10:24 <sawrubh> The laptop hangs while TB builds. I'm reading the spec on mobile in the meanwhile
15:11:11 <sawrubh> clokep_work: so that WIP patch link I gave was to enable notification box, so I iterate over all logged in FileLink providers and add buttons for it
15:12:08 <aleth> sawrubh: Sounds like being able to use the try server is very useful to you then?
15:12:47 <sawrubh> I add the callback in that for loop, now in that callback function (which is that uploadFile function) I get the error that file is null (on L198)
15:13:11 <clokep_work> sawrubh: OK, OK it looks pretty reasonable.
15:13:12 <clokep_work> One second.
15:13:36 <clokep_work> sawrubh: Did you print out what aDataTransfer is?
15:14:03 <sawrubh> aleth: yes, from next time I plan to request both debug and opt so I can download and try them
15:14:47 <sawrubh> clokep_work: no, I didn't. I'll do that once I'm back on my laptop and will get back to you
15:20:45 <clokep_work> sawrubh: Overall it looks like it should work...btw aren't you missinga  return on line 193?
15:20:47 <clokep_work> After line 193.
15:27:59 <-- aleth has quit (Ping timeout)
15:28:14 --> iamjayakumars has joined #instantbird
15:31:43 <clokep_work> sawrubh: Yeah nothing pops out at me. :(
15:32:03 --> aleth has joined #instantbird
15:32:03 * ChanServ sets mode +o aleth 
15:32:26 <sawrubh> Cool, don't waste any of your time
15:32:57 <sawrubh> I'll look at it soon
15:33:23 <nhnt11> sawrubh: I'm really surprised your laptop completely freezes when you're building. :(
15:33:41 <-- iamjayakumars has quit (Ping timeout)
15:34:20 <-- Rym has quit (Ping timeout)
15:37:09 <clokep_work> My old laptop was pretty unresponsive when I was building and took > 2 hours to build.
15:38:11 --> iamjayakumars has joined #instantbird
15:39:53 <sawrubh> Well, it's beyond the point where the failure came last time so this work (hopefully)
15:44:12 <sawrubh> Done! 37 minutes, sweet
15:44:36 <clokep_work> Yya.
15:45:36 --> sawrubh|ib has joined #instantbird
15:48:28 <sawrubh|ib> btw someone on #maildev told me that Right click on toolbar and selecting Menubar would work, and it does
15:51:28 <sawrubh|ib> flo-retina: I still don't see the Windows menu item in TB (I have a debug build)
15:51:48 <flo-retina> for me it's between Tools and Help
15:52:02 <flo-retina> hmm, maybe it's mac only :-S
15:52:25 <flo-retina> anyway, with a debug build, you should have warnings in the termianl when trying to access a non-existant chrome file
15:58:24 <sawrubh|ib> http://i.imgur.com/UznwAeP.png is what I see in TB
15:58:31 <sawrubh|ib> and yeah I see http://pastebin.instantbird.com/733927 now in the terminal
15:59:14 --> mayanktg has joined #instantbird
16:01:47 --> Rym has joined #instantbird
16:02:52 <sawrubh|ib> got it!
16:03:04 <-- rosonline has quit (Ping timeout)
16:03:16 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:03:46 <sawrubh|ib> http://pastebin.instantbird.com/733948
16:05:57 <sawrubh|ib> given that the changes to jars are like http://pastebin.instantbird.com/733883 ...to fix this (and ensure IB's CSS doesn't break too), I should...
16:06:51 <aleth> Did you remove the old jar.mn for that file in TB?
16:07:07 <aleth> jar.mn entry I mean
16:07:23 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:07:29 --> qheaden has joined #instantbird
16:08:56 <sawrubh|ib> yes, I have (otherwise it wouldn't have compiled itself and failed during jar building saying file isn't there)
16:10:01 <instantbot> aleth@instantbird.org changed the Resolution on bug 1007239 from --- to WORKSFORME.
16:10:04 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1007239 nor, --, ---, nobody, RESO WORKSFORME, libpurple XPCOM protocol commands leak into JS protocols
16:10:34 <-- gerard-majax_ has quit (Ping timeout)
16:12:10 <sawrubh|ib> why is the file getting package in 'chrome/chat/skin/classic/messenger/icons/' instead of 'chrome/classic/skin/classic/messenger/icons/' event though I've added '% skin messenger classic/1.0 %skin/classic/messenger/' above the jar.mn entry
16:12:54 <clokep_work> aleth: I don't understand how that bug would have been magically fixed.
16:12:58 <clokep_work> How did you test it?
16:13:09 <aleth> clokep_work: I believe I fixed it
16:13:26 <aleth> clokep_work: To test, open a JS-Yahoo conversation and look at the commands listed.
16:13:44 <clokep_work> sawrubh|ib: The first one in there looks correct....I don't think the extra classic is suposed to be there?
16:16:05 <sawrubh|ib> clokep_work: you mean 'classic/1.0' (I still don't feel comfortable with jar.mn paths), can you be more clear what's wrong?
16:17:59 <clokep_work> sawrubh|ib: I don't know what's wrong, that's why I'm not being clear.
16:18:17 --> arlolra has joined #instantbird
16:18:38 <aleth> Doesn't the fact that it works for IB mean that the problem must be in a mail/ file?
16:18:44 <-- sonny has quit (Ping timeout)
16:19:28 <sawrubh|ib> aleth: you mean someone in mail/ is overridding this formatting line I've added on L17 of http://pastebin.instantbird.com/733883 
16:19:49 <sawrubh|ib> yeah, it works perfectly in IB and that is what's intriguing me
16:20:24 <aleth> What's happened to this line? http://mxr.mozilla.org/comm-central/source/mail/themes/linux/jar.mn#92
16:20:55 <clokep_work> It's probably just gone, as it's in chat now.
16:21:15 <aleth> Oh wait, wrong file. http://mxr.mozilla.org/comm-central/source/mail/themes/linux/jar.mn#270
16:21:22 <aleth> clokep_work: It /should/ be gone, but is it? ;)
16:21:57 <sawrubh|ib> http://pastebin.instantbird.com/733949
16:22:18 <aleth> OK, so that guess doesn't help ;)
16:22:38 <sawrubh|ib> and it /will/ have to go, otherwise build will fail, so that ruled it out for me
16:22:40 <sawrubh|ib> :)
16:24:03 <aleth> mayanktg: Did you see my comment in the logs?
16:26:13 <sawrubh|ib> I think I know!
16:27:26 <sawrubh|ib> http://dxr.mozilla.org/comm-central/source/chat/themes/jar.mn#5 might be why it's going to 'chrome/chat/skin/classic/messenger/icons/' instead of 'chrome/classic/skin/classic/messenger/icons/'
16:27:55 <sawrubh|ib> ...or I dunno
16:29:03 <sawrubh|ib> ok, so we need to remove the 'chat' word from the path and add 'classic' in it's place....
16:29:12 <aleth> You'll have to check the docs for jar.manifests
16:29:13 <mayanktg> aleth: Yes. I went away for dinner. I'm implementing it. I will add |notifyObservers(sdp, "session-initiate-receive");| to the prpl and then use this case at the observe method in conversation binding. 
16:30:24 --> rosonline has joined #instantbird
16:31:55 <aleth> OK (though I'd use a name that reflects the meaning of the notification less technically, maybe something like "webrtc-call-request")
16:32:14 <clokep_work> aleth: Ah, yeah that's the commit I was thinking of.
16:32:35 <clokep_work> aleth: Do we have thoughts on whether to support NON-webrtc stuff?
16:32:51 <mayanktg> aleth: Ok. I'll use that name 
16:33:41 <aleth> clokep_work: If you have a better name, please mention it! (I'm sure there is one) But as far as the UI goes, I doubt we'll use anything other than webrtc to respond to sdp offers
16:35:08 <aleth> clokep_work: Hmm, maybe we should call the notification "sdp-offer-received"? Is that clearer?
16:35:52 <aleth> Anyway, that can always be changed easily during reviews.
16:36:07 <-- iamjayakumars has quit (Client exited)
16:37:38 --> iamjayakumars has joined #instantbird
16:47:13 <-- jb has quit (Ping timeout)
16:48:48 <-- Rym has quit (Ping timeout)
16:55:36 <-- sawrubh|ib has quit (Ping timeout)
16:57:43 <-- aleth has quit (Ping timeout)
16:59:31 --> Rym has joined #instantbird
17:01:12 <nhnt11> Hey, I just realized Instantbird works with emoji (duh!)
17:01:24 <nhnt11> This calls for an addon that automatically converts emoticons to emoji :P
17:03:45 <clokep_work> What? (o_O)
17:04:45 <clokep_work> You can disable the images, if that's what you mean.
17:05:16 <nhnt11> What?
17:05:17 <nhnt11> No.
17:06:49 <nhnt11> https://en.wikipedia.org/wiki/Emoji
17:06:49 <clokep_work> I asked you what first! :P
17:06:56 <nhnt11> clokep_work: ^
17:07:28 <clokep_work> So it's just unicode?
17:07:31 <clokep_work> I don't understand. . .
17:07:32 <nhnt11> Yup
17:07:41 <clokep_work> I guess I don'tunderstand where the "add-on" comes in.
17:07:59 <nhnt11> clokep_work: The addon comes in by converting stuff like ":P" to the unicode value
17:08:24 <nhnt11> That would be "😜" in this case I guess
17:08:47 <nhnt11> It being unicode, it works across all apps if the OS supports it
17:09:21 <clokep_work> I see.
17:09:58 <nhnt11> clokep_work: In OS X, you can insert emoji by pressing Cmd+Ctrl+Space
17:10:05 <nhnt11> It doesn't work in Instantbird, but it probably should!
17:10:11 <nhnt11> (Try it in TextEdit or something)
17:11:05 <nhnt11> Here's the halo one that you say you use a lot: 😇
17:13:03 <nhnt11> Using these would also prevent emoticons from popping up when you don't want them to, like when there's a colon after a closing parenthesis
17:13:42 * nhnt11 is curious if this is something that other Ib devs/users would be interested in
17:16:44 <clokep_work> Interesting, it works in Firefox.
17:19:17 <clokep_work> Ah, but only in content, not in chrome.
17:20:33 <nhnt11> clokep_work: It works in my URL bar
17:20:37 <nhnt11> That's chrome, isn't it?
17:21:07 <nhnt11> Hmm, if it works in firefox, should be easy to get in Ib right?
17:21:14 <nhnt11> I'll look at it later :)
17:21:22 * nhnt11 is very interested in this.
17:23:28 <clokep_work> nhnt11: It didn't work in the search bar.
17:23:39 <clokep_work> The web search bar thing, IDK what it's called.
17:23:55 <clokep_work> Oh wait.
17:23:59 <clokep_work> It did, I must have done something wrong. :-D
17:24:12 <nhnt11> :)
17:25:53 --> sawrubh|ib has joined #instantbird
17:30:02 <sawrubh|ib> I'm still not able to figure out what's wrong with that chrome registration
17:34:35 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:34:57 --> nhnt11 has joined #instantbird
17:38:02 --> aleth has joined #instantbird
17:38:02 * ChanServ sets mode +o aleth 
17:38:03 <mayanktg> aleth: I was getting a |this.notifyObeservers is not a function| error. So I added the nsIObserverService implementation  http://pastebin.instantbird.com/733982 . I'm not getting any errors now, but the notification isn't received at the observe method :-/
17:38:22 <aleth> mayanktg: Pastebin?
17:38:31 <aleth> Oh, I see.
17:38:44 <clokep_work> I'm pretty sure the accoutn does that already.
17:38:51 <aleth> Yeah.
17:39:02 <clokep_work> maybe this._account.notifyObservers? Not sure the scope you're in.
17:39:14 <aleth> No, what's needed is the conversation I think.
17:39:16 <clokep_work> sawrubh|ib: I don't know, sorry. :-\
17:39:20 <clokep_work> AH, yeah.
17:40:11 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:40:14 <mayanktg> Let me try this._account.notifyObservers.
17:40:29 --> nhnt11 has joined #instantbird
17:40:34 <-- nhnt11 has quit (Input/output error)
17:40:45 <clokep_work> mayanktg: Did you see what aleth just asid?
17:40:45 --> nhnt11 has joined #instantbird
17:40:56 <aleth> mayanktg: So what you want isn't this.notifyObservers but conversation.notifyObservers (and you have to get the right conversation)
17:41:22 <mayanktg> clokep_work: Oh..sorry :-/
17:41:40 <aleth> ie. when I said "this.notifyObservers" I assumed you would find the right "this" to send it to ;)
17:42:27 <-- nhnt11 has quit (Ping timeout)
17:42:45 <mayanktg> aleth: I should have figured it out. :-(
17:42:45 <aleth> mayanktg: To make it clear, the function you are supposed to be calling is this one: http://mxr.mozilla.org/comm-central/source/chat/modules/jsProtoHelper.jsm#465
17:42:56 <aleth> mayanktg: easy mistake to make!
17:43:01 --> nhnt11 has joined #instantbird
17:43:18 <-- clokep_work has quit (Ping timeout)
17:44:23 <mayanktg> aleth: Thanks. :) I read about notifyObservers and nsIObserverService at the MDN https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIObserverService#notifyObservers()
17:45:04 <aleth> mayanktg: Yes, that's the right thing to read about :) But luckily it's already implemented for you.
17:46:11 <aleth> nhnt11: I'm pretty sure any emoji addon will be quite popular ;)
17:46:25 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:46:39 --> nhnt11 has joined #instantbird
17:46:59 <nhnt11> aleth: :)
17:49:09 <aleth> mayanktg: Look at onMessageStanza to see how to get the conversation.
17:51:08 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:51:42 --> nhnt11 has joined #instantbird
17:53:23 <-- Rym has quit (Ping timeout)
17:53:58 <mayanktg> OK. I'm going through it. 
17:56:31 --> clokep_work has joined #instantbird
17:56:31 * ChanServ sets mode +o clokep_work 
17:57:07 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:00:05 <-- arlolra has quit (Quit: arlolra)
18:00:18 <clokep_work> sawrubh|ib: I'd suggest moving onto something else and leaving it for now.
18:03:34 <sawrubh|ib> yes, I've moved to re-reading XEP96 and seeing how to write it's interface
18:03:43 <sawrubh|ib> will send some WIP in sometime
18:03:55 <clokep_work> "seeing how to write it's interface? What's that mean? :)
18:04:40 <aleth> mayanktg: have you found it?
18:04:53 <sawrubh|ib> how does MAYBE and MUST translate to IDL terminology
18:05:21 <mayanktg> aleth: Yes. |this..createConversation(..buddy name..)| . 
18:05:21 <aleth> The IDL has to work for *all* protocols.
18:05:49 <clokep_work> sawrubh|ib: I don't understand what you're suggesting. There is an optional keyword though.
18:06:40 <aleth> mayanktg: Yes, that will work. Though you should use an attribute of the received Stanza (from)
18:07:32 <sawrubh|ib> aleth: ok, so I need to write an interface (something along the lines of those prpl*.idl's in chat/components/public) right? and that interface is what I'll implement in xmpp.jsm?
18:07:43 <mayanktg> aleth: Ok. I will do that :) |aStanza.attributes(["from"])|
18:08:01 <aleth> mayanktg: http://mxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm#869
18:08:12 <aleth> Don't forget the normalize.
18:08:54 <aleth> sawrubh|ib: Yes
18:08:58 <mayanktg> That's why I was getting a buddy Not found error in the console :-/
18:09:27 <sawrubh|ib> aleth: and that interface is what's been already implemented in libpurple and I'll write a purplexpcom interface/wrapper which will bridge between the libpurple implementation and this IDL file I define?
18:09:28 <aleth> I did say look at onMessageStanza ;)
18:09:53 --> qheaden has joined #instantbird
18:09:55 <aleth> sawrubh|ib: No such interface exists yet. The second half of the sentence is correct though ;)
18:10:29 <sawrubh|ib> clokep_work, aleth:  any other pointers/tips before I proceed ?
18:10:50 <clokep_work> sawrubh|ib: purplexpcom IS that wrapper between the IB interface and the libpurple interface.
18:11:13 <mayanktg> aleth: Done :)
18:11:31 <aleth> sawrubh|ib: Also look at the download panel interfaces to see if there is something you can/should usefully inherit
18:11:41 <aleth> And discuss it early and often with clokep_work! ;)
18:11:47 <clokep_work> "I need to write an interface (something along the lines of those prpl*.idl's in chat/components/public) right?" is mostly right, you're going to have to also modify the prplIAccount or prplIConversation interface too in there.
18:12:20 <sawrubh|ib> Ok, so a) I create an IDL file, implement that in xmpp.jsm b) I use the IDL file I created in 'a' and write another IDL file (or whatever it is in) in purplexpcom and that'll act as a bridge between teh IDL in 'a' and libpurple
18:12:31 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:12:37 --> nhnt11 has joined #instantbird
18:12:44 <sawrubh|ib> and in the latter case libpurple will provide the implementation, instead of me writing it (like I'll do in xmpp.jsm) right?
18:12:46 <aleth> purplexpcom is C++ code that implements the IDL.
18:12:47 * instantbot mumbles something about c++ being evil
18:12:58 <aleth> It calls into libpurple.
18:13:25 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:13:32 --> nhnt11 has joined #instantbird
18:13:32 <aleth> Just take a look at some of the existing IDLs and their implementations for examples!
18:14:19 <aleth> mayanktg: it's working then? :)
18:15:09 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:15:16 --> nhnt11 has joined #instantbird
18:16:54 <mayanktg> aleth: Yeah. :) But I'm receiving a |body is null| after I append a video element to the body. I'll figure it out 
18:17:58 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:17:58 <clokep_work> sawrubh|ib: I think you're getting a bit confused between interfaces and implementations, are you familiar with those concepts previously?
18:18:10 --> nhnt11 has joined #instantbird
18:18:19 <clokep_work> An interface says HOW you're allowed to call some set of code, but it doesn't actually have any of the code to do it.
18:18:48 <clokep_work> XMPP will /implement/ that interface to add the code to do it, we could also implement it in IRC, and purplexpcom.
18:18:48 <sawrubh|ib> yeah and an implementation defined the logic/body for that property/function
18:18:54 <clokep_work> Yep.
18:21:13 <sawrubh|ib> Ok, so Problem: find out what to include in that interface, Solution: Look at Download panel interfaces/implementations and decide which property makes sense
18:21:43 * aleth wonders if IRC DCC would be an easier "my first file transfer implementation" than XMPP ?
18:22:15 * sawrubh|ib wonders why it would be, does IRC DCC offer something special?
18:22:25 <aleth> I have no idea how they compare.
18:22:37 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:22:48 <aleth> But clokep_work knows all of the IRC RFCs so he knows at least one side of the comparison ;)
18:22:52 --> nhnt11 has joined #instantbird
18:22:52 <sawrubh|ib> I think I understand enough to file a bug
18:23:14 --> arlolra has joined #instantbird
18:23:21 <sawrubh|ib> clokep_work's also written js-xmpp so he know both sides of the comparison
18:23:30 <sawrubh|ib> s/know/knows
18:23:44 <aleth> Actually js-xmpp started as a gsoc project
18:24:52 <clokep_work> aleth: No.
18:25:04 <clokep_work> sawrubh|ib: I didn't write JS-XMPP, don't you attribute that code to me!
18:25:13 * clokep_work finds that code difficult to work in. ;)
18:25:30 <clokep_work> I wrote the majority of the IRC code (aleth wrote a good amount too), and some of the Twitter code.
18:26:24 <aleth> mayanktg: What body is this?
18:27:18 <sawrubh|ib> clokep_work: do you want me to break this into 3 bugs (create interface, xmpp implementation, purplexpcom interface)
18:27:33 <mayanktg> aleth: I have fixed it. It was the "ibcontent". But there's a bigger problem now :'( |Error: Argument 1 of mozRTCSessionDescription.constructor can't be converted to a dictionary.|
18:27:33 <clokep_work> sawrubh|ib: It needs to all be done at once.
18:28:16 <aleth> mayanktg: So you're injecting that into the conversation browser? I guess that's OK for a WIP.
18:28:18 --> sonny has joined #instantbird
18:28:42 * sawrubh|ib mumbles something about his bugs being gigantic (like the make filelink work)
18:28:51 <aleth> mayanktg: I don't understand that error message either, you'll have to do some googling on it.
18:29:03 <mayanktg> aleth: I'll probably have to go back and send the complete offer instead of just sending just offer.type
18:29:19 <aleth> sending what where?
18:29:30 <clokep_work> sawrubh|ib: Initially the purplexpcom stuff can be a no-op. That can be a separate bug.
18:29:39 <clokep_work> But you need ONE of the implementations are else adding an interface is useless. :)
18:30:07 <sawrubh|ib> so 2 bugs then...
18:30:28 <aleth> mayanktg: maybe a pastebin would help here.
18:30:53 <mayanktg> The offer conteins two properties. {type: "offer", offer: "..."} . We are only sending sdp.offer part here.
18:30:54 <mayanktg> Ok
18:31:35 <-- iamjayakumars has quit (Quit: )
18:31:38 <sawrubh|ib> 'Support for file transfer in XMPP'
18:32:07 <clokep_work> sawrubh|ib: Yes, two bugs sounds reasonable. :)
18:32:45 <mayanktg> aleth: http://pastebin.instantbird.com/733989 (Line 445) 
18:33:50 <mayanktg> aleth: and I'm receiving the error at http://pastebin.instantbird.com/733990 (Line 198)
18:34:14 <mayanktg>  |Error: Argument 1 of mozRTCSessionDescription.constructor can't be converted to a dictionary.|
18:35:34 <mayanktg> http://lists.w3.org/Archives/Public/public-webrtc/2012Jul/0076.html
18:36:03 <instantbot> New Chat Core - XMPP bug 1024023 filed by saurabhanandiit@gmail.com.
18:36:04 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1024023 nor, --, ---, nobody, NEW, Add File Transfer Support for JS-XMPP
18:36:30 <mayanktg> aleth: The Session Description object should always have two components a type and SDP string
18:37:10 <mayanktg> Wait I guess I can fix it :)
18:38:10 <aleth> Yes, you just have to recreate the object.
18:38:40 <-- sonny has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:42:51 <mayanktg> yay! Answer created too :)
18:42:59 <instantbot> clokep@gmail.com changed the Resolution on bug 955474 from --- to DUPLICATE.
18:43:01 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955474 nor, --, ---, nobody, RESO DUPLICATE, Support for File transfer for XMPP
18:44:13 <aleth> mayanktg: Sounds like progress :)
18:44:55 <mayanktg> NEXT--> send the answer to the caller? 
18:45:14 <aleth> mayanktg: Yes, I think so.
18:46:42 <aleth> Hopefully that's not too hard as you already have your sdp2xml helper functions and so on.
18:46:50 <mayanktg> aleth: Ok. :)
18:47:06 <-- chrisccoulson has quit (Connection reset by peer)
18:47:58 <sawrubh|ib> I guess I'll base this mq off trunk, rather than on top of the changes I've done to make filelink work, since this seems to be independent
18:48:28 <mayanktg> aleth: Yes. I was figuring out how I'll do that. Just checked again the XEP: 0320 if I'm not missing anything for sending the answer. 
18:49:16 <-- aleth has quit (Ping timeout)
18:53:56 <clokep_work> sawrubh|ib: Good idea.
18:57:46 <mayanktg> aleth: I'm going through the SDP answer too to figure out the differences the "offer" and "answer" has.
19:01:59 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:02:57 --> chrisccoulson has joined #instantbird
19:03:25 --> Mic has joined #instantbird
19:03:25 * ChanServ sets mode +o Mic 
19:09:17 <sawrubh|ib> ..I guess I'll have to keep it on top of the drag and drop patch to reuse the code for conversation.xml, bah (here I wanted to have nothing to do from my previous patch)
19:09:48 <sawrubh|ib> Mic: hey, so I needed some help with regards to that chrome stuff I having an issue with
19:11:01 <sawrubh|ib> Mic: The problem I have is I have this jar.mn (https://pastebin.mozilla.org/5391895) L39-L77 are what interest me, now for a file called box-log.png (on Linux) it's placed in 'chrome/chat/skin/classic/messenger/icons/', while I want it in 'chrome/classic/skin/classic/messenger/icons/', do you think with the voodoo magic I've written on L49, 'chrome/chat/skin/classic/messenger/icons/' is where it would be placed?
19:20:51 --> Mook_as has joined #instantbird
19:23:00 --> flo-retina has joined #instantbird
19:23:00 * ChanServ sets mode +qo flo-retina flo-retina 
19:29:15 <Mic> sawrubh|ib: could you try what the result is if you replace line 49 with the following:
19:29:19 <Mic> % skin messenger classic/1.0 chrome/classic/
19:34:30 <sawrubh|ib> just a minute, I had just now popped 'em off
19:34:35 <sawrubh|ib> pushing the patches back on
19:38:41 <nhnt11> flo-retina: Can you please help me figure out this error? error: https://pastebin.mozilla.org/5392418, code: https://pastebin.mozilla.org/5392473
19:39:09 <nhnt11> The error is on line 203 of the code pastebin btw
19:39:32 <nhnt11> The DBConn stuff is reused from imContacts.js
19:39:56 <nhnt11> I don't see anything I missed :-/ the SQL line works when I type it in an sqlite3 shell
19:40:51 <nhnt11> The executeSimpleSQL on line 229 works fine
19:41:08 <nhnt11> Oh great
19:41:15 <nhnt11> I have gDBConnWithPendingTransaction defined twice
19:41:37 <nhnt11> Doesn't get rid of the error ;)
19:42:59 * flo-retina wonders if it's too late to make nhnt11 start from scratch :-P
19:43:12 <nhnt11> flo-retina: Start from scratch = ?
19:43:19 <flo-retina> I mean, the code using SQLite in imContacts.js is all old and synchronous
19:43:20 <nhnt11> What do you want me to re-do?
19:43:23 <nhnt11> Lol
19:43:30 <nhnt11> That doesn't mean this shouldn't work :-/
19:43:32 <flo-retina> there's a shinny new http://mxr.mozilla.org/mozilla-central/source/toolkit/modules/Sqlite.jsm returning promises and all the new cool stuff ;)
19:43:50 <nhnt11> Damn it, why didn't I find that
19:43:57 * nhnt11 still wonders why this doesn't work
19:44:04 <flo-retina> note: I've never used Sqlite.jsm
19:44:20 <nhnt11> flo-retina: If it uses Promises, I likely will use it :D
19:45:10 <nhnt11> AAAAH
19:45:19 <nhnt11> I've defined the first column as "text"
19:45:21 <nhnt11> Not "msg"
19:45:25 * nhnt11 hits himself
19:45:53 <nhnt11> Yeah, it works now.
19:45:54 <nhnt11> BAH
19:46:15 <flo-retina> :)
19:47:32 <flo-retina> btw, if someone wanted to refactor imContacts.js to stop using SQLite, and use a JSON file written atomically and asynchronously, that would be great ;)
19:47:45 <flo-retina> as after the logging code, it should be our last large piece doing sync I/O
19:48:08 <flo-retina> we are also doing sync I/O for the buddy icons, but that code is used less often
19:49:48 <sawrubh|ib> Mic: nothing changes, same result :(
19:50:00 <Mic> Exactly the same?
19:50:18 --> mpmc has joined #instantbird
19:50:53 <flo-retina> clokep_work, qheaden: do you think bug 1007239 is actually WFM?
19:50:55 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1007239 nor, --, ---, nobody, RESO WORKSFORME, libpurple XPCOM protocol commands leak into JS protocols
19:51:01 <flo-retina> and aleth too of course
19:51:25 <clokep_work> flo-retina: Or we could juse the Sqlite.jsm? ;)
19:51:40 <clokep_work> flo-retina: aleth and I had a conversation about that eralier today, did you see it?
19:51:42 <flo-retina> clokep_work: SQLite is making our live complicated there.
19:51:46 <flo-retina> no
19:52:35 <sawrubh|ib> Mic: btw I just made the change and ran ./mozilla/mach build, that should've picked up the change in the jar.mn right? and yes exactly the same
19:53:14 <flo-retina> clokep_work: I still don't see how that could have fixed it
19:53:25 <flo-retina> (I just read the log)
19:53:45 <clokep_work> flo-retina: I'm not convinced either.
19:53:55 <clokep_work> I've no way to test it here.
19:57:18 <nhnt11> Is there a bug for Promise errors while log sweeping?
19:57:31 <clokep_work> What?
19:57:35 <clokep_work> I don't think so.
19:57:45 <sawrubh|ib> Mic: let me know if you have other ideas because I'm out of them :)
19:57:57 <nhnt11> It's taking forever for me to do a BMO search
19:58:19 <nhnt11> But I'm seeing errors for my log indexing sweeping, and it's essentially the same code.
19:58:44 * flo-retina didn't know we had code using promises already
19:58:59 <nhnt11> flo-retina: OS.File is essentially Promise code
19:59:12 <flo-retina> ah so you mean errors inside OS.File?
19:59:41 <nhnt11> Well kinda. They're not OS.File errors though. They're caused because there are a couple of missing return statements in the sweeping code.
19:59:59 * nhnt11 just got a list of all the messages he has ever sent or receieved that contain the word "test" :)
20:00:10 <nhnt11> That's a /long/ list.
20:01:13 <clokep_work> Hahah.
20:01:34 <nhnt11> The query took 8ms, and gave me 675 results :)
20:01:43 <nhnt11> um, no tha'ts wrong
20:02:03 <nhnt11> The database is 32MB
20:02:16 <nhnt11> I'll have the actual time taken for the query in a sec
20:02:50 <nhnt11> Aaand... 7ms. That seems wrong :-/
20:02:58 <clokep_work> Too fast? ;)
20:03:11 <nhnt11> The time between "Sweeping complete" and the display of that message was way more than that
20:05:10 <nhnt11> Okay, this time there was no lag between "Sweeping complete!" and the results. I forgot to delete the database, so all the messages were added again, => this time I got 1350 results in 14ms
20:05:20 <nhnt11> That seems to suggest O(n)
20:06:04 <nhnt11> Which is quite good for a search I suppose :)
20:07:43 <nhnt11> flo-retina: So I think it takes a /lot/ of space to store all the messages in the logs.
20:07:50 <nhnt11> Because this was on my Testing profile, and it was 32MB
20:08:09 <nhnt11> I haven't enabled any compression and I don't know if anything is enabled by default though
20:08:40 <Mic> sawrubh|ib: can you try with this? http://pastebin.instantbird.com/734026
20:09:10 <nhnt11> In comparison, my logs folder is ~45MB
20:09:59 <nhnt11> Also, I stored in this db only the text, sender, and time of a message, no other metadata
20:12:05 * nhnt11 wonders if anyone else has an opinion on the sizes as well
20:12:49 <nhnt11> Hmm, the logs folder of my main profile is 250MB-ish
20:12:52 <nhnt11> I'm going to run this on that.
20:13:02 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:13:41 --> nhnt11 has joined #instantbird
20:13:42 <-- nhnt11 has quit (Input/output error)
20:14:11 --> nhnt11 has joined #instantbird
20:15:35 <nhnt11> Interesting, 10ms, 973 results. The database is 59.2MB
20:15:57 <nhnt11> I don't think that's an outrageous file size considering my logs folder is 250MB
20:17:35 * nhnt11 now waits for opinions :)
20:22:23 <-- clokep_work has quit (Ping timeout)
20:24:04 <nhnt11> Hmm, I wonder what gloda does
20:25:14 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:25:45 --> nhnt11 has joined #instantbird
20:27:08 --> EionRobb has joined #instantbird
20:28:09 <flo-retina> nhnt11: what's the question?
20:28:12 <Mic> sawrubh|ib: what was the result when using the jar.mn file that I pasted?
20:28:37 <nhnt11> flo-retina: Are these file sizes large enough that we want to consider /not/ storing all the logs in the database?
20:29:11 <flo-retina> the size is 20% of your log folder?
20:29:27 <nhnt11> flo-retina: For a 45MB log folder, it was 32MB
20:29:33 <nhnt11> For a 250MB one, it was 50something
20:29:42 <flo-retina> that doesn't seem realistic
20:29:57 <nhnt11> It could, considering that words get repeated often
20:30:21 <nhnt11> (i.e. the index would grow rapidly initially, but for logs spanning a large amount of time, it won't)
20:31:08 <nhnt11> Hmm, but the /messages/ are certainly getting stored...
20:31:21 * nhnt11 wonders if something is going wrong
20:31:37 <-- sawrubh|ib has quit (Quit: sawrubh|ib)
20:32:23 --> jb has joined #instantbird
20:35:39 <flo-retina> nhnt11: could also be that you have a large default size for the database
20:35:50 <flo-retina> you could check by indexing a log folder containing a single hello world message
20:36:00 <nhnt11> Interesting, I'll try that.
20:36:16 <nhnt11> flo-retina: I can see the database growing btw, while log sweeping runs
20:37:42 <nhnt11> flo-retina: Also I ran log sweeping multiple times on my Testing profile without deleting the database, it's growing proportionally (so far, three times and 104MB)
20:38:13 * flo-retina wonders how nhnt11 would feel about gzipping the logs at the same time as they are indexed
20:38:38 <nhnt11> flo-retina: gzipping the log folder?
20:38:44 <flo-retina> yeah
20:38:50 <nhnt11> Hmm.
20:38:55 <nhnt11> Makes sense.
20:39:08 <nhnt11> brb
20:39:09 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:40:55 --> nhnt11 has joined #instantbird
20:42:59 <nhnt11> flo-retina: Are you assuming that the log indexing service will obtain all of its data from log files?
20:43:22 <nhnt11> What I'm thinking is, the indexing service listens for new-text and so on, and adds them to the db on the fly
20:43:35 <nhnt11> Which could mean the stats service and this should really be the same thing
20:45:24 <nhnt11> In this case "gzipping the logs at the same time as they are indexed" would be more like "gzipping the logs at the same time as they are written"
20:46:45 <nhnt11> Meh, I initially wrote this as an addon so that people on this channel could try it out and we could get more db sizes.
20:47:19 <nhnt11> Ran into problems with XPCOMUtils and TextEncoder/Decoder not being available (I remember this from the stats addon I wrote last year) and just made it a service directly
20:47:31 <nhnt11> Maybe I should try again to make it an addon
20:48:47 * nhnt11 is really tempted to create an inverted index himself, if only because it's a cool algorithm :]
20:49:01 <nhnt11> algorithm/data structure
20:49:52 * mayanktg The answer SDP have a slight different structure from offer SDP. I'm making changes to the function so that proper stanza could be created.
20:51:52 <Mic> hmm, that was stupid :(
20:52:07 * Mic has "ac_add_options --disable-accessibility" in his mozconfig :(
20:52:26 <-- jb has quit (Ping timeout)
20:52:59 <Mic> I wanted to check with DOMi what the accessible properties of the items on mayanktg's user icon panel are. :(
20:54:41 <nhnt11> flo-retina: What do you think I should do next?
20:57:04 <mayanktg> Mic: So you'll have to build the whole thing again? You can tell how to check for accessibility and I'll perform the check. 
20:57:46 <Mic> mayanktg: I'm already building, so nevermind :)
20:58:22 <-- nhnt11 has quit (Ping timeout)
20:59:19 <mayanktg> Mic: Thanks :) That patch has already made you build several times :-/
21:00:30 --> Rym has joined #instantbird
21:00:39 --> nhnt11 has joined #instantbird
21:00:40 <flo-retina> the gzipping cound be done later in the summer of course
21:00:46 <flo-retina> nhnt11: the gzipping cound be done later in the summer of course
21:02:20 <flo-retina> "22:48:48 * nhnt11 is really tempted to create an inverted index himself […]" sounds like a cool school project; not a GSoC project ;)
21:04:10 <-- flo-retina has quit (Ping timeout)
21:08:24 --> flo-retina has joined #instantbird
21:08:25 * ChanServ sets mode +qo flo-retina flo-retina 
21:16:58 <Mic> Here's a first attempt of a new MUC icon: http://i.imgur.com/KNrg2H1.png I think moving the silhouettes where they are on this image looks nicer. The white border between them helps to see that they are three distinct shapes.
21:17:04 --> sawrubh|ib has joined #instantbird
21:18:56 <sawrubh|ib> Mic: Thanks!
21:19:00 <sawrubh|ib> it worked :)
21:22:42 <Mic> And it didn't break anything?
21:22:58 <Mic> What does the resulting classic.manifest file look like?
21:23:01 <Mic> sawrubh|ib: ^
21:24:14 <-- arlolra has quit (Quit: arlolra)
21:27:09 <sawrubh|ib> not sure actually, so now all the provider's favicons are there in the addAccountDialog and the preference pane works for Box and Hightail, although Dropbox's is broken
21:27:19 <flo-retina> Mic: is that meant as a large icon for the awesometab?
21:27:39 <flo-retina> I'm asking because when I read "MUC icon" I think first about the icon displayed in tabs.
21:28:16 <Mic> That's meant as a replacement for the icon of MUCs / channels on the awesome tab, yes.
21:28:33 <sawrubh|ib> Mic: now I'm not sure if that's this change or my patch in general (http://imgur.com/2Ct6uVi,SitwVPg,K87M0UF are the screenshots)
21:28:38 <flo-retina> Mic: ok :)
21:28:55 <flo-retina> Mic: I think I would need to see it in the awesometab context to decide if I like it or not :)
21:29:04 <flo-retina> but I'm not a fan of the current one, so I shouldn't be difficult to convince
21:29:32 <sawrubh|ib> Mic: http://pastebin.instantbird.com/734065 is classic.manifest btw
21:29:51 <sawrubh|ib> from one problem to the next, now I need to figure out why the Dropbox addon is broken
21:29:56 * sawrubh|ib whips out DOMi
21:30:31 <sawrubh|ib> flo-retina: are you talking about that MUC icon bug where it looks aliased
21:30:38 <flo-retina> no
21:30:49 <flo-retina> different muc icon issue :)
21:31:21 <Mic> sawrubh|ib: great, I was afraid that might overwrite something but it looks like it was just included into this file.
21:32:04 <sawrubh|ib> ok, so it seems my patch is the one breaking the addon then
21:39:21 <-- mconley has quit (Input/output error)
21:46:48 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:48:49 <flo-retina> Mic: good point about applying the translate to all coordinates!
21:49:05 <flo-retina> we may also reduce the number of digits after the decimal separator
21:49:39 <flo-retina> I doubt anybody can see what 10^-5 pixel looks like
21:51:26 <nhnt11> flo-retina: If this new service will be used for log reading, what will become of logger.js?
21:51:34 <nhnt11> Or will this only be used for search?
21:52:10 <flo-retina> err
21:52:19 <nhnt11> I'm not entirely sure where we want to go with this.
21:52:25 <flo-retina> I meant this new service needs to get data from logs to build the index
21:52:26 <nhnt11> (I was afk for a bit, sorry)
21:52:36 <flo-retina> I didn't mean that the UI would use it to read logs
21:52:54 <nhnt11> So logger.js will be adapted to use this index?
21:54:36 <nhnt11> flo-retina: Okay, I think my real question is, what does the API for this database provide? Ways to search it? Ways to obtain logs for it by time? What does it return from a search? If it returns messages, I don't see why we need the old api at all. If it returns a log file to be read, I don't see the point of keeping all of those messages indexed in the database for that sole purpose
21:55:06 <nhnt11> I can come up with answers for these questions myself, but I'm curious what you envision at this time
21:55:24 <flo-retina> "logger.js will be adapted to use this index?" that seems likely, yes
21:55:33 <flo-retina> the logger service will have ways to search
21:56:07 <nhnt11> flo-retina: So the columns of this database would likely be one for message text, and one for log file name?
21:56:48 <flo-retina> nhnt11: I was thinking that a database query returns the list of log files that contained the queried term, and maybe an indication of the position inside the log files (if we don't split log files to files small enough that reading it all to search the word in it isn't a problem)
21:57:27 <Mic> nhnt11: wouldn't you want a table with the log files names mapping them to an id that you'd use in the table with the messages? Duplicating the file name for every message seems wasteful...
21:57:38 <nhnt11> flo-retina: In that case, I'm very skeptical of keeping every message in the database. What we want is an inverted index for the log files, and what we're doing is putting all of the contents of those files and getting sqlite to build such an index for us
21:57:42 <flo-retina> nhnt11: I was thinking that eg. system messages wouldn't be indexed
21:57:55 <mayanktg> Mic: Yes I'm trying to replace the transform using Inkspace. Will do that. :) 
21:57:57 <flo-retina> Mic: right
21:58:32 <nhnt11> Mic: Yeah, right.
21:58:55 <flo-retina> nhnt11: are you saying that you want to have the whole content of a log file on each row of the table?
21:59:02 <nhnt11> flo-retina: No.
21:59:12 <flo-retina> (that's what I had for Tb/gloda)
21:59:22 <nhnt11> We have log files with some contents. We are duplicating those contents into the database, and then sqlite builds an index for the database
21:59:34 <nhnt11> I'm saying we build the index for the log files directly, without duplication
21:59:47 <flo-retina> how do you do that with sqlite?
22:00:17 <nhnt11> flo-retina: We'd have to do it manually, which is the sucky part.
22:00:25 <flo-retina> that means 'no' then :-P
22:00:40 <nhnt11> Fine...
22:00:58 <flo-retina> you don't want to spend a month building an indexer, and then discover that it performs at 5% of the speed of the one we already had.
22:01:22 <flo-retina> (hint: it's likely highly optimized C/C++ inside SQLite, and it likely has hundreads of tests)
22:01:31 <nhnt11> Yeah, okay
22:01:55 <nhnt11> flo-retina: My real point isn't that we should do it manually, but rather that once we have a database of all our logs, we should harness it further
22:02:20 <flo-retina> note: if you finish your project early and want to use the remaining time to prove that I was wrong here, feel free ;)
22:02:47 <flo-retina> nhnt11: do you have examples of "harness it further"?
22:02:50 <nhnt11> Alright. I guess that we can always extend the database further later.
22:02:56 <flo-retina> I have examples in mind, but yours are possibly very different :)
22:03:19 <nhnt11> flo-retina: Request it for all logs from a certain time range. All logs for some specified contacts.
22:03:25 <nhnt11> off the top of my head
22:03:32 <flo-retina> (the ideas I have are universal completion (I think I had a WIP attached somewhere), or even attempting to detect the way someone writes to imitate it :))
22:03:35 <nhnt11> There are loads of possibilities..
22:05:12 <-- flo-retina has quit (Ping timeout)
22:05:15 <nhnt11> (the two examples I suggested can be done already, but using the database would avoid file system traversal)
22:05:56 <sawrubh|ib> hmm, DOMi doesn't seem to work :/
22:06:07 --> flo-retina has joined #instantbird
22:06:07 * ChanServ sets mode +qo flo-retina flo-retina 
22:07:40 <mayanktg> Mic: removed the transforms. Also reducing the decimal places :)
22:08:31 <Mic> Cool, so Inkscape has a feature to do that for you?
22:09:06 <nhnt11> Btw, changes to logger.js imply that this service should exist for Thunderbird as well
22:10:01 <nhnt11> Hmm, maybe not. If the database is empty, the function would just return empty results, and Thunderbird would never call it in the first place...
22:10:18 <nhnt11> s/is empty/didn't exist/
22:11:26 <flo-retina> nhnt11: as long as there's a pref to disable indexing, shipping dead code in Tb shouldn't be a problem
22:11:46 <flo-retina> it already ships plenty of useless stuff (eg. jQuery) anyway
22:12:01 <mayanktg> MIc: yeah. It was that simple. Go to Path --> Simplify and it changed the transforms. 
22:13:02 <Mic> I never understood why you'd want to use jQuery and the like in a product like Tb or Fx...
22:13:26 <flo-retina> Mic: you wouldn't ;)
22:16:03 <Mook_as> it's mostly familiarity (if you're already using it elsewhere, you'd want to use it there too).
22:16:09 <Mook_as> of course, that's... useless for everybody else.
22:16:40 <nhnt11> flo-retina: Cool. Or imServices.jsm would simply fail to get the service, and logger.js would simply return empty results in that case.
22:16:41 <flo-retina> Mook_as: s/useless/painful/
22:17:00 <nhnt11> (I'd rather the service live in im/ if Thunderbird isn't going to use it)
22:17:10 <flo-retina> nhnt11: yeah, whatever. Not a difficult problem, we can fix it whenever we are close to landing :)
22:17:14 <nhnt11> cool
22:17:43 <nhnt11> flo-retina: One more thing I wanted to discuss. How do you feel about making initialization synchronous for the LogWriters (it would solve some problems)
22:17:44 <flo-retina> now if we could deprecate gloda and use it for search within TB, that could be cool too :-P
22:17:59 <flo-retina> define "synchronous"?
22:18:16 <nhnt11> Never mind, you won't approve. I myself am skeptical.
22:18:30 <flo-retina> if you mean sync disk I/O, clearly r- :)
22:18:39 <nhnt11> Yes. Never mind.
22:18:51 <flo-retina> but I don't see what it would solve
22:18:55 <nhnt11> I'm having trouble writing tests for it because I need to wait for stuff to be written. I'll figure it out
22:19:05 <nhnt11> Idea flash: spawn a Task
22:19:07 <flo-retina> how difficult is it to just keep the header line in the object somewhere, and write it at the same time as the first message?
22:19:36 <nhnt11> flo-retina: Initialization also asynchronously creates the log folder if it doesn't exist, and sets the path for the log writer.
22:19:37 <flo-retina> (ignore that suggestion if it isn't helpful/related to your actual problem; I haven't looked at your code recently)
22:19:55 <nhnt11> Right, forget about it. I'll figure it out (Tasks are probably the answer)
22:20:01 <flo-retina> wait, are you saying the problem is about a _test_?
22:20:32 <nhnt11> Erm.
22:20:37 <nhnt11> Not /exactly/
22:21:11 <nhnt11> But yeah.
22:21:25 <nhnt11> Yes, I realize my tests should work and I shouldn't be modifying the actual code to make the test work
22:21:32 <nhnt11> And I won't, never mind :]
22:27:04 <-- Rym has quit (Ping timeout)
22:32:32 <flo-retina> :)
22:34:46 --> Rym has joined #instantbird
22:39:06 <mayanktg> Mic: I was talking about these grey close icons available http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/osx/global/icons/close@2x.png /close.png . Will it look nice above the "user icon"?
22:39:41 <mayanktg> I compressed the image upto 2 decimal places and also did the changes you mentioned in the comment.
22:40:44 <Mic> I don't know. You can add them and let someone on Mac OS have a look...
22:41:25 <mayanktg> Ok. I'm adding it then.
22:43:22 <-- Rym has quit (Ping timeout)
22:44:13 --> Rym has joined #instantbird
22:46:11 <-- Armada has quit (Connection reset by peer)
22:49:50 <sawrubh|ib> clokep So Mic has helped me fix the issue, now favicons are working for existing providers as well as Dropbox addon, however the Dropbox management interface is broken (http://i.imgur.com/BdULpr8.png), management interface for the existing providers is working however their CSS seems to be differing by size and the font applied (http://imgur.com/LxsEx5h&A6CpUgt)
22:51:06 <sawrubh|ib> I tried debugging using DOMi but DOMi doesn't seem to be working in the TB build I have
22:53:24 <Mic> Maybe try the remote debugger?
22:53:33 <Mic> *dev tools
22:55:04 <sawrubh|ib> do you think that allows inspecting XUL's (probably should) ?
22:55:10 <sawrubh|ib> Mic: how do I do that btw?
22:56:16 <Mic> You definitely need to have Tb running for that, then choose in Firefox' menu bar Tools->Web Development->Connect...
22:56:31 <Mic> Try the default values there.
22:57:13 <Mic> mayanktg: we need to make the panel and it's buttons keyboard accessible.
22:57:49 <mayanktg> How can I do that?
22:58:06 <Mic> The buttons have shortcuts already but the remove button isn't usable with keyboard only.
22:58:35 <Mic> Would be nice if they were focusable as well, i.e. you could tab through the elements in the panel.
22:59:08 <mayanktg> Ok. So I will have to accesskey to the remove button too.
22:59:12 <Mic> I don't know. Firefox' doorhanger panels at the start of the adress bar allow that. Have a look there?
22:59:44 <Mic> mayanktg: no, as you can't display the key anywhere. The button is just an image!
23:00:48 <Mic> The panel can't be opened using the keyboard either.
23:01:32 <Mic> I tried Enter, Space, Alt+Down. These are the common keys on Windows, at least.
23:01:59 <mayanktg> Mic: Yes. The buttons present in the door are keyboard accessible.
23:07:59 <sawrubh|ib> Mic: where do you see remote debugger?
23:08:06 <sawrubh|ib> I don't see it in Fx Nightly
23:08:41 <mayanktg> I'm searching for ways to make that focusable. Maybe its because we have used -moz-appearance: none which is causing the problem. I''m not sure.
23:15:56 <Mic> mayanktg: yes, there's a -moz CSS extension (property) that allows you to change the focus behaviour of elements.
23:16:21 <Mic> MDN has a list with all CSS properties, including Mozilla only extensions.
23:18:18 --> clokep has joined #instantbird
23:18:19 * ChanServ sets mode +o clokep 
23:19:32 <sawrubh|ib> Mic: nvm, I found https://developer.mozilla.org/en-US/docs/Tools/Remote_Debugging/Thunderbird
23:19:41 <mayanktg> Yes. I have found it https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Mozilla_Extensions
23:20:09 <Mic> sawrubh|ib: this should be helpful!
23:20:45 <Mic> Once you've connected to it, you can choose the right window and have a look using the "Inspector" tool.
23:21:05 <mayanktg> Mic: -moz-user-focus: normal should make it accessible.
23:21:12 <Mic> Yep
23:23:26 <sawrubh|ib> hrm, I get an 'Error Connection timeout' with port as 6000 and localhost
23:23:40 <sawrubh|ib> do I need to enable remote debugging on TB as well?
23:24:04 <Mic> The guide will most likely answer questions like this.
23:24:21 <sawrubh|ib> it doesn't..but I'll check again
23:24:24 <sawrubh|ib> clokep: http://log.bezut.info/instantbird/today#m903
23:26:35 <sawrubh|ib> gah, my Firefox and TB version's don't match, probably that's the issue
23:28:32 <Mic> How did you set up Tb for this?
23:30:09 <sawrubh|ib> The article says you don't need to setup TB, btw I'm compiling TB and the Nightly I'm running is downloaded from the website
23:31:23 <Mic> There's a section called "Setting up Thunderbird" and it definitely contains something ;)
23:31:51 --> wnayes has joined #instantbird
23:31:59 <sawrubh|ib> eek, yeah
23:34:34 <sawrubh|ib> it's working now
23:34:41 <mayanktg> Mic: The -moz-user-focus doesn't bring any change :-/ (The buttons become accessible if I remove -moz-appearance: none; ). I'll figure out what should be done here 
23:35:05 <Mic> mayanktg: can you pastebin a WIP, please?
23:35:58 <Mic> I've tried myself by adding -moz-user-focus:normal;  with DOMi and the buttons were focusable thereafter...
23:36:18 <mayanktg> http://pastebin.instantbird.com/734124
23:38:25 <mayanktg> Mic: ^
23:38:38 <Mic> OK, and how did you try it?
23:39:02 <Mic> You might have to click the panel to make it work at the moment.
23:39:20 <Mic> That is: click the panel and then try to tab through the UI elements.
23:39:34 <mayanktg> I clicked on the icon --> and then tried to press TAB 
23:40:18 <Mic> The icon on the panel or the icon on the contact list?
23:40:34 <mayanktg> Icon on the contact list
23:40:38 <sawrubh|ib> I don't see the preference window under the remote processes
23:40:56 <Mic> OK, try clicking somewhere on the panel when it's opened.
23:41:18 <Mic> sawrubh|ib: I was afraid that this might happen :(
23:41:53 <mayanktg> Mic: Nothing happens. I mean the Tabs cannot access the buttons
23:42:15 <Mic> Wait a minute (or two). I'll check...
23:43:52 <-- rosonline has quit (Client exited)
23:45:22 <Mic> mayanktg: the change works for me.
23:45:49 <Mic> It's even enough to open the panel by a click on the user icon on the contact list.
23:46:23 <mayanktg> I have added it to the correct place? i.e. #userIconPanelButton 
23:46:50 --> Tonnes has joined #instantbird
23:47:17 <Mic> Yes
23:47:18 <sawrubh|ib> clokep: do you know why aleth thought that the Dropbox addon would probably be broken, because that might give me some hints as to what's causing the breakage
23:47:37 <clokep> sawrubh|ib: He didn't think it would PROBABLY be, he wanted to ensure it wasn't.
23:48:03 <mayanktg> Mic: Ok. I'm making the change then!
23:48:20 <Mic> Let's find out why it's not working for you.
23:48:21 <sawrubh|ib> hmm, so Remote Debugging doesn't work for Preference Panel and DOMi doesn't seem to be working
23:48:35 <sawrubh|ib> Mic: are you talking to me?
23:48:42 <Mic> No
23:49:16 <mayanktg> Mic: Ok.
23:50:46 <mayanktg> Mic: I'm doing a ./mozilla/mach build im/ after making the changes and seeing if it worked.
23:51:11 <mayanktg> Other changes to the css are reflected though :-/
23:51:23 <Mic> That's what I did, too.
23:51:52 * nhnt11 refactors a load of things in logger.js... again
23:52:31 <clokep> sawrubh|ib: I'll be back in a few minutes, I need to catch up on logs and such though. :-\
23:53:10 <Mic> Good night
23:53:59 <sawrubh|ib> Mic: bye
23:54:11 <nhnt11> Good night Mic!
23:54:13 <sawrubh|ib> and thanks for figuring out that chrome issue
23:54:44 <mayanktg> Mic: GoodNight :) There might be some other property I need to add. Maybe the problem would come for all linux platform :-/
23:58:46 <clokep> Ah you figured out the issue w/ the icons?!
23:58:47 <clokep> Nice. :)