#instantbird log on 06 09 2014

All times are UTC.

00:01:08 <Mic> hmm...
00:02:50 <mayanktg> When I add a Cu.reportError(conv) below the line II'm again getting a [xpconnect wrapped (nsISupports, nsIClassInfo, imIConversation, prplIConversation, nsIObserver, prplIConvIM)]
00:03:00 <clokep> qheaden: Can't wait to see it!
00:04:15 <mayanktg> It should have rather been [xpconnect wrapped (prplIConvIM)] ?
00:04:56 --> Rym has joined #instantbird
00:09:40 <-- Rym has quit (Ping timeout)
00:09:51 <Mic> Ah, maybe I got it wrong.
00:09:57 --> Rym has joined #instantbird
00:10:11 <Mic> Assign it to conv and the use QueryInterface on your new variable?
00:10:31 <Mic> let conv = this._conv;
00:10:31 <Mic> conv.QueryInterface(...); 
00:10:35 <Mic> I'm not sure.
00:10:48 <Mic> It's late here, too and I need to go to bed.
00:11:44 <mayanktg> I'm trying it. And I'll probably sleep too after a few tries..
00:11:48 <mayanktg> Ok Goodnight. :)
00:12:34 <-- Rym has quit (Ping timeout)
00:13:37 --> Rym has joined #instantbird
00:19:01 <Mic> Please post what else you tried... that might help to narrow down what the problem is.
00:25:05 <mayanktg> Mic: |conv.QueryInterface(Components.interfaces.prplIConvIM).startCall(offer.sdp)|
00:26:51 <mayanktg> Ok. I'm trying the patch on a different build just to be sure. The error identifies calling the method [prplIConvIM::startCall]  http://pastebin.instantbird.com/732416
00:29:23 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
00:33:11 <-- Suiseiseki has quit (Ping timeout)
00:34:24 <-- Rym has quit (Ping timeout)
00:36:36 --> Suiseiseki has joined #instantbird
00:36:46 --> Rym has joined #instantbird
00:38:42 <-- Rym has quit (Ping timeout)
00:38:58 --> Rym has joined #instantbird
00:46:40 <-- Rym has quit (Ping timeout)
00:46:56 --> Rym has joined #instantbird
00:50:37 <mayanktg> bah :-/ It gives the same error again. I need to use QueryInterface correctly.  
00:53:50 <clokep> Can you show a complete diff?
00:53:55 <clokep> I want to see how you modified the interface.
00:55:29 <mayanktg> Yes.
00:56:45 <mayanktg> clokep: http://pastebin.instantbird.com/732455
01:01:25 <clokep> mayanktg: So what do you see? Does the print on line 568 occur?
01:02:36 <mayanktg> Yes. It occurs. as far aas I rem it outputs "conversation". wait let me check back
01:03:24 <-- Rym has quit (Ping timeout)
01:03:35 <mayanktg> Yeah . the localname is "conversation"
01:04:02 --> mconley has joined #instantbird
01:04:33 <mayanktg> I'm getting this error http://pastebin.instantbird.com/732416 at line 541 
01:04:35 --> Rym has joined #instantbird
01:05:26 * qheaden goes to bed
01:05:28 <qheaden> Goodnight
01:05:55 <clokep> Try mach configure before building.
01:06:10 <mayanktg> Ok
01:06:15 <-- qheaden has quit (Input/output error)
01:08:20 <mayanktg> I did a mach configure, now I'm building it again...
01:14:20 <-- mconley has quit (Ping timeout)
01:15:44 <-- Armada has quit (Connection reset by peer)
01:16:57 --> mayanktg-ph has joined #instantbird
01:17:07 <-- mayanktg has quit (Ping timeout)
01:21:24 <mayanktg-ph> I'll check after my build is complete whether it solves the problem..
01:27:59 --> mconley has joined #instantbird
01:37:50 <-- Rym has quit (Ping timeout)
01:43:08 <-- mconley has quit (Ping timeout)
01:55:49 --> mconley has joined #instantbird
02:02:07 <-- clokep has quit (Ping timeout)
02:11:47 --> Rym has joined #instantbird
02:29:11 <-- mconley has quit (Ping timeout)
02:30:24 <instantbot> ryanvm@gmail.com changed the Resolution on bug 1013034 from --- to FIXED.
02:30:25 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1013034 nor, --, ---, qheaden, RESO FIXED, Conference messages aren't broadcast
02:41:55 --> mconley has joined #instantbird
02:53:19 <-- mconley has quit (Input/output error)
03:51:32 <-- Mook has quit (Quit: Mook)
03:53:12 --> mconley has joined #instantbird
04:02:35 <-- mconley has quit (Ping timeout)
04:22:44 <-- mayanktg-ph has quit (Quit: Connection closed for inactivity)
04:29:03 <-- Rym has quit (Ping timeout)
04:29:21 --> Rym has joined #instantbird
05:01:57 <-- Rym has quit (Ping timeout)
05:02:13 --> Rym has joined #instantbird
05:06:53 --> mayanktg-ph has joined #instantbird
05:08:04 --> gerard-majax_ has joined #instantbird
05:10:47 <-- Rym has quit (Ping timeout)
05:11:03 --> Rym has joined #instantbird
05:12:22 <-- gerard-majax_ has quit (Ping timeout)
05:19:42 <-- Rym has quit (Ping timeout)
05:21:22 --> Rym has joined #instantbird
05:42:01 <-- Rym has quit (Ping timeout)
05:58:05 <-- EionRobb has quit (Quit: Leaving.)
06:01:34 --> jb has joined #instantbird
06:08:14 --> sawrubh|ib has joined #instantbird
06:18:16 --> gerard-majax_ has joined #instantbird
06:27:20 <-- gerard-majax_ has quit (Ping timeout)
06:44:06 --> EionRobb has joined #instantbird
07:13:23 --> gerard-majax_ has joined #instantbird
07:17:35 <-- gerard-majax_ has quit (Ping timeout)
07:30:07 --> Mic has joined #instantbird
07:30:07 * ChanServ sets mode +o Mic 
07:34:04 --> gerard-majax_ has joined #instantbird
07:40:00 <-- gerard-majax_ has quit (Ping timeout)
08:17:15 --> gerard-majax_ has joined #instantbird
08:22:33 <sawrubh|ib> Mic: awake?
08:22:53 <Mic> sawrubh|ib: hmm, let me check...
08:22:58 <Mic> Yeah, I think so ;)
08:23:11 <sawrubh|ib> :)
08:23:14 <sawrubh|ib> Mic: is http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/DownloadUtils.jsm#47 how one defined a lazy getter?
08:23:20 <sawrubh|ib> s/defined/defines
08:24:45 <sawrubh|ib> or I think like this https://developer.mozilla.org/en-US/docs/Mozilla/JavaScript_code_modules/XPCOMUtils.jsm#defineLazyGetter%28%29
08:24:46 <Mic> Yes, that's a way to do it. The getter is removed and replaced with a constant value (that also has to be returned on the first call).
08:25:38 <Mic> What do you want to do?
08:26:07 <sawrubh|ib> https://bugzilla.mozilla.org/show_bug.cgi?id=1014644#c24 need to address the lazy getter feedback
08:26:09 <instantbot> Bug 1014644 nor, --, ---, saurabhanandiit, ASSI, Make FileLink work in Instantbird
08:27:20 <Mic> defineLazyGetter is the way, then.
08:27:52 <sawrubh|ib> thanks
08:28:15 <Mic> Here's an example how it is used somewhere else for localisation.
08:28:16 <Mic> https://mxr.mozilla.org/comm-central/source/im/modules/ibTagMenu.jsm#11
08:52:09 <Mic> Test 123 ;) 
08:52:25 <Mic> Cool :)
08:52:37 <Mic> This was sent from a Fx debug console :)
08:53:50 <EionRobb> lol
08:55:11 <Mic> Attach the Firefox dev tools to Instantbird (thanks, Fallen!) and call this.getTabBrowser().selectedConversation._conv.QueryInterface(Components.interfaces.prplIConvChat).sendMsg("<your message>") on the console.
08:55:26 <Mic> I mean that's obvious, isn't it? ;)
08:55:30 <EionRobb> totally
08:55:48 --> mayanktg has joined #instantbird
08:59:17 <-- Mic has quit (Input/output error)
08:59:39 <mayanktg> clokep: Hi. I had to do a |mach clobber && mach configure && mach build| to make the build pass. Even after successful build I'm getting the same error :|
09:09:35 <-- jb has quit (Ping timeout)
09:16:03 --> Mic has joined #instantbird
09:16:03 * ChanServ sets mode +o Mic 
09:17:32 --> jb has joined #instantbird
09:30:55 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
09:36:11 <-- jb has quit (Ping timeout)
09:49:23 --> Armada has joined #instantbird
10:08:19 --> flo-retina has joined #instantbird
10:08:19 * ChanServ sets mode +qo flo-retina flo-retina 
10:15:39 --> mpmc has joined #instantbird
10:20:50 --> clokep has joined #instantbird
10:20:50 * ChanServ sets mode +o clokep 
10:24:00 <flo-retina> has http://log.bezut.info/instantbird/today#m1 been answered?
10:24:32 <clokep> flo-retina: He's still having trouble.
10:24:54 <sawrubh|ib> clokep: Morning!
10:24:55 <clokep> sawrubh|ib: Hmm....so I just meant define it when it gets called, but now looking at it again, I'm not so sure...
10:25:49 * sawrubh|ib is currently stuck with building the entire tree (which takes a painful 30 minutes) :(
10:26:03 <flo-retina> The reason why it's "[xpconnect wrapped (nsISupports, nsIClassInfo, imIConversation, prplIConversation, nsIObserver, prplIConvIM)]" rather than just "[xpconnect wrapped (prplIConvIM)]" is the interface flattening that happens for objects implementing nsIClassInfo
10:27:21 <clokep> sawrubh|ib: Why are you building the entire tree?
10:27:41 <flo-retina> this.getTabBrowser().selectedConversation._conv.QueryInterface(Components.interfaces.prplIConvChat).sendMsg("<your message>") seems too long
10:28:22 <sawrubh|ib> clokep: sure about what? so should I a) use the defineLazyGetter b) simply move the definition below to when it gets called c) do nothing
10:28:38 <mayanktg> flo-retina: Ok. Mic said to use it this way.... |let conv = this._conv.QueryInterface(Components.interfaces.prplIConvIM);|
10:28:54 <flo-retina> wouldn't this.getTabBrowser().selectedConversation.sendMsg("hello") work?
10:29:05 <flo-retina> mayanktg: what's the context?
10:29:05 <sawrubh|ib> clokep: nothing, I did ./mozilla/mach build im/ and it said you tree isn't configured so I thought I would have to do a full build. Turns out not, so I'm good :)
10:30:12 <mayanktg> flo-retina: I've defined a new function startCall() in the interface prplIConvIM which sends the SDP offer generated in the conversation binding..
10:30:29 --> aleth1 has joined #instantbird
10:30:47 <-- aleth1 has quit (Input/output error)
10:31:26 <flo-retina> and?
10:31:27 <mayanktg> flo-retina: I'm able to generate the message but the Line 541 of http://pastebin.instantbird.com/732455 generates that error message
10:31:30 --> aleth has joined #instantbird
10:31:30 * ChanServ sets mode +o aleth 
10:32:11 <flo-retina> "that error message"?
10:32:28 <mayanktg> flo-retina: http://pastebin.instantbird.com/732416
10:33:04 <clokep> sawrubh|ib: So I didn't mean use defineLazyGetter, just leave it how it is for now.
10:33:14 <mayanktg> Cu.reportError(this._conv); dumps |[xpconnect wrapped (nsISupports, nsIClassInfo, imIConversation, prplIConversation, nsIObserver, prplIConvIM)]|
10:33:16 <aleth> It's probably just that this.conv is a UIConv and doesn't forward the method.
10:33:35 <flo-retina> have you rebuilt after changing the .idl file?
10:34:08 <mayanktg> Yes. After adding the function I changed its uuid and rebuilt IB
10:34:33 <aleth> mayanktg: You need to add startCall here http://dxr.mozilla.org/comm-central/source/chat/components/src/imConversations.js#338
10:34:57 <aleth> Because this.conv is a UIConv object, not the prpl conversation object.
10:35:06 <flo-retina> aleth++
10:35:09 <flo-retina> that's the problem :)
10:35:15 <mayanktg> aleth: Ok!!
10:35:16 <aleth> The UIConv has to forward startCall to the prpl
10:36:36 <sawrubh|ib> clokep: also you asked me to move the IB specific strings away from cloudfile.properties, I have created a new file in im/locales called fileUpload.properties and am having to call createBundle on that too
10:37:02 <sawrubh|ib> just wanted to let you know
10:37:16 <aleth> mayanktg: (looking at the logs) you don't need any QueryInterface calls.
10:37:17 <clokep> Too many conversations. :(
10:37:39 <mayanktg> aleth: So I'll add the startCall in imConversations.js and rebuild it again? Ok I'll remove that :)
10:37:41 <clokep> sawrubh|ib: Why not fileTransfers like everything else? :-S
10:37:54 <aleth> mayanktg: Right.
10:39:55 <sawrubh|ib> clokep: because we already have fileTransfers.properties inside the preferences directory inside http://dxr.mozilla.org/comm-central/source/im/locales/en-US/chrome/instantbird/preferences. I thought a similarly named in http://dxr.mozilla.org/comm-central/source/im/locales/en-US/chrome/instantbird/ would be confusing
10:40:33 <sawrubh|ib> clokep: you won't see the file in the link above, I'm creating it in this patch btw
10:41:10 <clokep> Hmm...where tare the rest of the strings for a conversation stored?
10:41:15 <clokep> These shuld probably go there.
10:43:31 <sawrubh|ib> I guess http://dxr.mozilla.org/comm-central/source/im/locales/en-US/chrome/instantbird/conversation.properties then :)
10:46:24 <clokep> Yep.
10:56:16 <sawrubh|ib> clokep: I find the body of uploadListener to be pretty obvious, I'll try to add some comments however still
10:56:49 <-- EionRobb has quit (Quit: Leaving.)
10:57:51 <clokep> sawrubh|ib: You wrote it. :P
10:58:24 <clokep> I mostly find it obvious too, but I've read it a half dozen times at this point and looked at the TB implementation.
10:59:23 <clokep> Just pastebin something to me and I'll tell you if it's OK
10:59:35 <sawrubh|ib> one minute
11:06:32 <aleth> mayanktg: Is it working now?
11:07:53 <-- clokep has quit (Ping timeout)
11:07:57 <sawrubh|ib> clokep: http://pastebin.instantbird.com/732686
11:10:37 --> Rym has joined #instantbird
11:12:12 <mayanktg> aleth:  I added |startCall: function(aOffer)  this.target.startCall(aString),| in imConversations.js and removed startCall() from prplConversation.idl . I shouldn't have removed it from there :-/ I'm getting |startCall is not a function| . I'll fix this up..
11:12:39 <-- Rym has quit (Ping timeout)
11:12:42 <aleth> Yeah, you shouldn't have removed it. If it's not in the interface, it's not callable ;)
11:12:57 --> Rym has joined #instantbird
11:13:00 <aleth> |startCall: function(aOffer)  this.target.startCall(aString),| looks wrong to me. what's aString?!
11:13:55 <mayanktg> aleth: It should be the way its in jsProtoHelper? |startCall: function(aOffer) { throw Cr.NS_ERROR_NOT_IMPLEMENTED; },|
11:14:28 <aleth> no
11:15:44 <flo-retina> the question was "what's aString?" ;)
11:16:05 <aleth> hint: it's a very simple mistake ;)
11:16:20 <mayanktg> Yeah
11:16:25 <mayanktg> understood
11:16:27 <mayanktg> :-/
11:16:50 * sawrubh|ib will soon send flo-retina a review request
11:16:50 <mayanktg> |startCall: function(aOffer) this.target.startCall|
11:17:05 <-- nhnt11 has quit (Ping timeout)
11:17:12 <aleth> Take a deep breath and look at it again ;)
11:17:12 <flo-retina> no...
11:17:25 <flo-retina> well, yes to taking a deep breath :)
11:17:34 --> nhnt11 has joined #instantbird
11:18:33 <mayanktg> aleth, flo-retina: I'm stupid :( |function(aOffer) this.target.startCall(aOffer),|
11:18:41 <aleth> :)
11:18:41 <flo-retina> seems more likely to work
11:18:52 * flo-retina likes the deep-breath-debugging pattern :)
11:19:47 <mayanktg> I have struggled with this all night..and I'm desperate to receive the "offer" 
11:20:06 <mayanktg> I should go for lunch..feeling hungry :-|
11:20:08 <aleth> It's easy to get confused at first with all these conversation objects. What's going on is that this.conv is a UIConv (defined in imConversations.js). From the UIConv, this.target gives you the prp conversation.
11:20:27 <aleth> Lots of layers...
11:21:13 <mayanktg> Yes. Is there a doc or some reading content available for prpl?
11:22:12 <aleth> Not really. We haven't written any mdn pages for them ;)
11:22:22 <aleth> The "docs" are the comments in the interfaces.
11:22:28 <aleth> Just ask here! :D
11:22:34 <aleth> Anyway, it should work now.
11:22:47 <mayanktg> Ok..thanks a lot btw :)
11:27:13 <mayanktg> aleth: It worked! I can send the offer :D and the callee is receiving it too :D ..let me crosscheck it
11:27:43 <-- aleth has quit (Ping timeout)
11:30:03 <mayanktg> yepp
11:31:11 --> aleth has joined #instantbird
11:31:11 * ChanServ sets mode +o aleth 
11:31:26 <aleth> mayanktg: congrats :)
11:32:00 <mayanktg> Now I'll have to it for the video call button..
11:32:19 <aleth> I think there's a word missing there?
11:33:10 <mayanktg> aleth: Yes. "implement"
11:33:29 <aleth> I thought this already used the video button?
11:34:22 <mayanktg> No.. |videoCallButton.setAttribute("oncommand", "this.startCall();");| gives error |startCall is not a function|
11:35:12 <aleth> Oh, if you're using oncommand, you have to read about XUL commands.
11:35:26 <aleth> https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Tutorial/Commands
11:35:49 * sawrubh|ib looks up examples to add a dropdown select menu in a notificationbx
11:35:59 <mayanktg> ok. Even on using it like videoCallButton.onclick = funtion() {...}; I was getting the same error
11:36:29 <aleth> That's because you want to add an event handler, not an attribute.
11:37:09 <aleth> You were just setting a JS property on the videoCallButton object.
11:38:35 <aleth> But if you're using commands, you're not dealing directly with events at all.
11:38:48 <aleth> Just read the page I linked to to find out what they are.
11:38:56 <mayanktg> Ok. Yeah I'm getting your point. The page says that
11:38:57 <mayanktg> :)
11:40:19 <aleth> Why are you using a command by the way?
11:41:30 <aleth> Here's where the existing conversation commands http://mxr.mozilla.org/comm-central/source/im/content/instantbird.xul#54
11:43:29 <mayanktg> aleth: I've implemented a video call button. So when I click on that button I should be able to send "offer" by initiating the startcall method in conversation binding.
11:43:57 <aleth> Right.
11:44:06 <aleth> Oh, I see Mic suggested it.
11:44:34 <mayanktg> Yeah.. ;)
11:44:35 <aleth> I was just surprised you had discovered them on your own ;)
11:45:16 <mayanktg> Mic suggested to use oncommand..you only told about command 
11:45:22 <mayanktg> :)
11:46:01 <aleth> Using a command is a bit more involved. But if you read that page you can figure it out, just add it to the existing ones.
11:49:18 <-- sawrubh|ib has quit (Connection reset by peer)
11:51:45 --> sawrubh|ib has joined #instantbird
11:52:48 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:01:42 <-- sawrubh|ib has quit (Ping timeout)
12:01:49 --> clokep_work has joined #instantbird
12:01:49 * ChanServ sets mode +o clokep_work 
12:02:24 --> sawrubh|ib has joined #instantbird
12:05:00 <clokep_work> aleth: Isn't using command just setting "oncommand" instead of "onclick"? :-S
12:05:19 <aleth> No, you have to add a command element, and that's what you then refer to.
12:05:45 <aleth> iirc.
12:05:50 <-- BWMerlin has quit (Quit: BWMerlin)
12:05:58 <clokep_work> sawrubh|ib: Do you have something against blank lines? :-S You keep squishing all your code together!
12:07:29 * sawrubh|ib was a mobile phone in past life, used to small screens
12:07:56 <clokep_work> sawrubh|ib: "convBundle" should exist already somewhere, I don't think you have to recreate it.
12:08:32 <sawrubh|ib> clokep_work: I'll add more blank lines, I'm just confused most of the times, when someone might just say 'You're using too much space'
12:08:42 <clokep_work> sawrubh|ib: http://pastebin.instantbird.com/732711
12:08:52 <clokep_work> sawrubh|ib: Have we ever said that to you?
12:08:58 <clokep_work> Make it as readable as possible.
12:09:17 <sawrubh|ib> ok :)
12:09:35 <nhnt11> hello
12:10:07 <sawrubh|ib> olleh
12:11:45 <clokep_work> sawrubh|ib: So those comments are OK. The first one I'd say more of "Only handle dropped files."
12:11:55 <clokep_work> I think the cancelEvent line should have a comment.
12:12:20 <clokep_work> All comments should be full sentences (end in a period).
12:12:58 <clokep_work> I don't like the property name "uploadStartedNotif" btw.
12:13:31 <clokep_work> "Send a message with the filename and the filelink" what's "the filelink"? I htink you mean "with the filename and a link to the uploaded file."
12:13:42 <aleth> clokep_work: maybe we should add that to https://wiki.instantbird.org/Instantbird:Coding_Guidelines ;)
12:13:53 <aleth> ie. the commenting stuff
12:14:41 <clokep_work> It's in the Mozilla guide somewhere, I think.
12:16:42 <-- aleth has quit (Ping timeout)
12:17:17 --> aleth has joined #instantbird
12:17:17 * ChanServ sets mode +o aleth 
12:18:42 <sawrubh|ib> I see other non-full sentences in the code, just saying
12:19:13 <clokep_work> sawrubh|ib: That doesn't mean you should do it.
12:19:28 <sawrubh|ib> yes, I was just saying :P
12:26:27 <sawrubh|ib> clokep_work: which one do you prefer : 'Cancel the given event.' or 'This is used to cancel the given event.' ?
12:27:40 <clokep_work> sawrubh|ib: Neither, I want to know *WHY* you're doing it.
12:27:48 <clokep_work> I can tell it's cancelling the event from the function name.
12:28:09 <sawrubh|ib> ah, ok
12:28:48 <sawrubh|ib> but structure wise, the fist one will be a considered a full sentence right (because of the period) or not (because of the lack of 'This')
12:31:03 <clokep_work> "Cancel the given event." is a full sentence.
12:31:41 <sawrubh|ib> btw I add '// For an element to be a valid drop target, we must cancel the last ondragenter and ondragover events' comment to where I add the cancelEvent handler to ondragover and ondragenter, so that should explain the 'why' part
12:35:10 <-- Rym has quit (Ping timeout)
12:35:26 --> Rym has joined #instantbird
12:35:37 <-- ivan has quit (Quit: ERC Version 5.3 (IRC client for Emacs))
12:37:30 <clokep_work> :-(
12:37:52 <clokep_work> I thought you and aleth had a conversation saying that you don't even need to cancel that event there?
12:38:51 <-- Rym has quit (Ping timeout)
12:39:08 --> Rym has joined #instantbird
12:42:18 <-- mayanktg-ph has quit (Quit: )
12:42:30 --> mayanktg has joined #instantbird
12:43:23 --> ivan has joined #instantbird
12:45:18 <aleth> mayanktg: done?
12:46:45 <mayanktg> aleth: Just returned from lunch. I have added the <command> to the XUL. How should I initiate the startCall method from the command? I mean what should be |oncommand="__.startCall()"| so that startCall is called from the binding?
12:47:54 <mayanktg> this.startCall() doesn't recognize it as a function.
12:48:00 <aleth> mayanktg: Something like this should work http://mxr.mozilla.org/comm-central/source/im/content/instantbird.xul#63
12:48:42 <flo-retina> is it a recent regression that the findbar doesn't indicate the "not found" case?
12:48:42 <mayanktg> ok
12:49:03 <aleth> flo-retina: Sounds like it
12:49:31 <flo-retina> aleth: can you reproduce it too?
12:49:40 <aleth> Yes
12:49:45 <aleth> (i.e. the red colour is missing)
12:49:52 <mayanktg> aleth: Done :)
12:50:03 <sawrubh|ib> clokep_work: we discussed that the eventListener we're adding for the "select" event (in addAccountDialog.js), doesn't require adding cancelEvent since we don't want to cancel the default handler however in the case of 'drop' event, we need to cancel because the default handler would prevent the dropping of the file
12:50:07 <aleth> mayanktg: So it works now? :)
12:50:20 <mayanktg> aleth: Yes it does :)
12:50:26 <aleth> Good! :)
12:50:30 <flo-retina> aleth: wasn't there also a message in the empty space after the "Match case" button?
12:50:35 <-- Tonnes has quit (Connection reset by peer)
12:50:39 <aleth> mayanktg: What's next?
12:50:47 <aleth> flo-retina: I don't remember
12:51:07 <aleth> There is in FX though, so we should have it too.
12:51:16 --> qheaden has joined #instantbird
12:51:29 <mayanktg> aleth: What about the /call command at the xml-commands.jsm :-o . Next is to convert the xml stanza back to original offer?
12:51:43 <clokep_work> sawrubh|ib: I thought that was only for the dragging stuff, not for the dropping?
12:51:52 <clokep_work> What would block you from receiving it on the dropping?
12:52:20 <aleth> mayanktg: The call command was for the WIP so you could test things. You can't make it work easily as you need the DOMWindow to generate the offer.
12:52:39 <aleth> mayanktg: Yes, moving on to the receiving end sounds like the next step.
12:53:11 <instantbot> New Instantbird - Conversation bug 1022619 filed by florian@queze.net.
12:53:12 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1022619 nor, --, ---, nobody, NEW, The findbar doesn't show anything for the "not found" case
12:53:15 <mayanktg> aleth: Yes. I'm removing it then. We will only have the call initiation from the toolbarbutton then.
12:53:16 <qheaden> Hello everyone.
12:53:30 <mayanktg> aleth: Ok
12:54:27 <aleth> mayanktg: I guess you'll need an xml2sdp which does the whole thing backwards ;)
12:55:10 <aleth> mayanktg: This would be a good point at which to attach a WIP to your bug and get some feedback from Mic.
12:55:45 <mayanktg> aleth: yepp. In which i'll have to fetch the <content/> from the xml stanza and then reconstruct the offer. 
12:56:10 <mayanktg> Ok. I'm attaching a WIP after reomving the xml-commands.jsm from the patch.
12:57:00 <sawrubh|ib> clokep_work: I can't understand what that last statement means, can you explain it?
12:58:07 <clokep_work> sawrubh|ib: I don't understand why you ahve to cancel the drop event? I thought you only have to do that for the drag events.
12:58:16 <clokep_work> In other words, explain YOUR last statement.
12:58:56 <aleth> mayanktg: Well, xml2sdp should be the reverse of sdp2xml, so in the end you can do xml2sdp(sdp2xml(sdpstring)) and get the sdpstring back ;)
13:00:04 <mayanktg> Hmm.. cool :) going for it!
13:00:53 <aleth> Something like that at least. You can start with looking at where you need to handle the received stanza. Probably you'll have to add some function that handles Jingle nodes.
13:01:25 <aleth> And that will then call helper functions like xml2sdp...
13:01:41 <sawrubh|ib> clokep_work: afk for 5 minutes
13:01:47 <-- Rym has quit (Ping timeout)
13:01:49 <mayanktg> aleth: I', first adding icons for aero in the userIcon bug as Mic said yesterday. 
13:01:56 <mayanktg> *I'm
13:02:01 <aleth> Good idea, get that patch landed :)
13:02:39 <mayanktg> Yeah. I have to fix the design issue on Mac and Windows without having one :-|
13:03:18 <aleth> I doubt you can really do that. Other people will have to tell you what to change, possibly after landing.
13:04:48 <mayanktg> Hmm...me too. Anyways I'm first adding the icons for aero and sending my WIP for Mic.
13:05:00 <aleth> Yes, that should fix it for Windows ;)
13:05:04 --> Rym has joined #instantbird
13:10:18 <-- aleth has quit (Ping timeout)
13:10:45 --> aleth has joined #instantbird
13:10:45 * ChanServ sets mode +o aleth 
13:13:35 <-- Rym has quit (Ping timeout)
13:13:40 <sawrubh|ib> clokep_work: so https://developer.mozilla.org/en-US/docs/DragDrop/Drag_Operations#drop says drag event needs to be cancelled to make it a valid target, and I need to cancel the drop event otherwise the default handler will also handle it (which could be anything like in this showing the name of the file I guess)
13:13:50 --> Rym has joined #instantbird
13:14:49 <-- mayanktg has quit (Ping timeout)
13:15:22 --> mayanktg has joined #instantbird
13:20:26 <sawrubh|ib> clokep_work: also 'uploadStartedMsg' sounds good?
13:28:20 <clokep_work> sawrubh|ib: Better, yes.
13:28:42 <clokep_work> sawrubh|ib: I guess...what IS the default handler for dropping something? Is there actually one? Otherwise, I find it confusing that we would be cancelling it.
13:28:49 <clokep_work> Do we normally stop events from bubbling?
13:29:00 <flo-retina> I think there are enough people here with Macs that it shouldn't be too difficult to find someone who could help for the mac theming (mayanktg)
13:29:03 <clokep_work> (That's a question for aleth and flo-retina.)
13:29:41 <flo-retina> clokep_work: I think default handling is "nope, this is not a drop target, go away", and that's what we are canceling
13:29:47 <aleth> clokep_work: No, we don't, as I mentioned yesterday. See https://developer.mozilla.org/en-US/docs/XUL_Event_Propagation
13:29:48 <sawrubh|ib> clokep_work: so 'Varies' is your answer : https://developer.mozilla.org/en-US/docs/Web/Reference/Events/drop ;)
13:30:04 <mayanktg> flo-retina: I will ask someone to fix it up then :)
13:30:11 <clokep_work> sawrubh|ib: That's not a helpful response.
13:30:16 <flo-retina> :
13:30:29 <flo-retina> mayanktg: I'll do before r+'ing if that patch reaches my review queue again
13:30:32 <clokep_work> sawrubh|ib: So is it clear what the comment above that needs to say then?
13:31:37 <sawrubh|ib> yes, '// Need to prevent the default handlers for drop.' is what I have in mind for the call to cancelEvent in handleDroppedFiles
13:31:53 <mayanktg> flo-retina: Ok. I'll make some changes which Mic has suggested and then I'll send it for review. 
13:32:55 <clokep_work> sawrubh|ib: "Prevent the default drop handler." is more concise.
13:33:18 <clokep_work> I generally don't like things that start with "Need to" or "Check that", I like comments that say what we are doing. :)
13:33:27 <clokep_work> But that's really my own style, not anything we enforce, most likely.
13:36:16 <-- aleth has quit (Ping timeout)
13:36:52 --> aleth has joined #instantbird
13:36:52 * ChanServ sets mode +o aleth 
13:37:18 <clokep_work> sawrubh|ib: That make sense?
13:37:37 <sawrubh|ib> yes
13:41:16 <clokep_work> So what else is there to do? :)
13:41:33 <clokep_work> Btw I'd highly suggest getting the mv cloudfile patch up again before adding the notificationbox.
13:41:40 <clokep_work> So if I think it's OK I can toss the review to flo.
13:41:59 <flo-retina> nhnt11, sawrubh|ib: reminder re blogging weekly updates ;)
13:42:23 <nhnt11> flo-retina: I was going to write another post when async logs lands
13:42:30 <nhnt11> But I should write one about my Tb debugging troubles :S
13:42:43 <sawrubh|ib> I was planning one for when this patch lands :s
13:43:08 <sawrubh|ib> But I should write one about my work on getting this patch there :s
13:44:15 <flo-retina> I don't see how "when this patch lands" relates with the weekly update requirement.
13:44:29 <flo-retina> until a patch has landed, there's no accurate way to predict when it will
13:45:03 <flo-retina> of course if you are super excited when it does land, there's no reason to not blog about your excitement at that time; but that's not a weekly progress report :)
13:47:03 <nhnt11> flo-retina: Well fwiw my progress report would be "Addressed review comments" and a rant about debugging Thunderbird. But okay! :)
13:47:25 <flo-retina> you spent a week addressing review comments?
13:47:35 <flo-retina> did you learn anything interesting thanks to these review comments?
13:47:39 <flo-retina> what are you expecting to do next?
13:47:40 <nhnt11> Hmm, I also played around with the convbrowser
13:47:47 <nhnt11> Alright. Fair enough.
13:48:29 <nhnt11> Yeah I learned about async xpcshell tests and other things, I should keep track of my week
13:48:37 <nhnt11> Which is why I should blog I guess
13:48:38 <nhnt11> :]
13:52:32 <-- Even has quit (Ping timeout)
13:53:03 <clokep_work> FWIW I'd suggest nhnt11, sawrubh|ib and mayanktg blog ~ 2 a week.
13:53:08 <clokep_work> It's easy to forget what you've done after a week.
13:53:18 <flo-retina> weekly is a minimum
13:57:16 <sawrubh|ib> clokep_work: so I just did a self review and everything looks good, should I send it for review or get someone on Windows and Mac to test the styling I have done for those platforms
13:57:24 --> Even has joined #instantbird
13:57:25 * ChanServ sets mode +o Even 
13:57:30 <sawrubh|ib> otherwise I'm good for a review (and then a Try push I guess)
13:57:57 <clokep_work> sawrubh|ib: I don't have a windows machine w/ me at the moment.
13:58:02 <clokep_work> Upload it and I'll tryo n Mac though.
13:58:10 <clokep_work> After my meeting.
13:59:22 * sawrubh|ib wears his Windows-machine-detection-glasses and scans for nearby volunteers for testing
14:00:52 <sawrubh|ib> ...none found :(
14:01:05 * mayanktg bbl
14:01:17 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:04:30 --> iamjayakumars has joined #instantbird
14:07:35 --> mayanktg-ph has joined #instantbird
14:07:36 <-- sawrubh|ib has quit (Ping timeout)
14:09:02 --> sawrubh|ib has joined #instantbird
14:12:33 <flo-retina> sawrubh|ib: I thought nhnt11 just explained how much space he kept for Windows :_P
14:12:59 <sawrubh|ib> *evil smile*
14:13:14 * nhnt11 cant build on windows fyi
14:13:30 <nhnt11> So if you have a try build..
14:13:47 <nhnt11> (I'm eating right now btw, brb)
14:14:00 <aleth> so the "try" in "try build" is short for "try to get someone to run this"? :P
14:15:23 * sawrubh|ib uploads first
14:16:45 <-- Rym has quit (Ping timeout)
14:17:01 --> Rym has joined #instantbird
14:17:29 <sawrubh|ib> aleth: can you take a look, just to make sure I don't do anything stupid with regard to the css and then I'll push to try
14:17:41 <sawrubh|ib> I've uploaded the patch btw
14:18:15 * sawrubh|ib goes to work on notificationbox
14:18:38 <aleth> What css? I don't have time for a full review
14:19:33 <sawrubh|ib> ok, I'll pastebin a diff between the version I just uploaded and the previous one
14:19:49 <sawrubh|ib> and I was talking about Windows and Mac CSS I wrote in this patch for the pref pane
14:21:01 <aleth> If you are just copying CSS from TB, there should be no problem.
14:21:39 <sawrubh|ib> ooh, BZ gives the option of finding interdiff cool
14:21:42 <aleth> I don't have time to look at this in detail right now, sorry.
14:22:05 <sawrubh|ib> np, I'll go work on something else anyway
14:23:56 <-- aleth has quit (Ping timeout)
14:24:30 --> aleth has joined #instantbird
14:24:30 * ChanServ sets mode +o aleth 
14:25:42 <-- Rym has quit (Ping timeout)
14:25:58 <sawrubh|ib> I also need to work on bug 954497 and setting the topic bug :/
14:25:59 --> Rym has joined #instantbird
14:26:00 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=954497 nor, --, ---, nobody, NEW, Unsharp MUC icon in infobar on conversation top (height is 1px too large)
14:26:13 <flo-retina> that bug should be very low priority
14:26:25 <flo-retina> poke at it if you are stuck because all your other patches are waiting for reviews :)
14:26:46 <flo-retina> weren't you almost done with the topic bug?
14:26:56 <sawrubh|ib> no, notifbox is more priority right now
14:28:04 <sawrubh|ib> yes, I was nearly done but then writing the xpcshell seemed like a new things so I didn't delve into it anytime
14:29:01 <nhnt11> aleth: I meant if you have a build ready to test (since I can't build myself)
14:30:47 <flo-retina> if the patch in bug 1011226 works, I think we could land it without xpcshell test to avoid bitrot
14:30:50 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1011226 nor, --, ---, saurabhanandiit, NEW, Support setting the topic in XMPP MUCs
14:31:29 * sawrubh|ib goes to first spend 1 hour on that topic bug
14:31:44 <sawrubh|ib> and if it get's fixed cool, otherwise notifbox it is
14:34:43 <-- nhnt11 has quit (Ping timeout)
14:34:57 --> Tonnes has joined #instantbird
14:35:06 --> nhnt11 has joined #instantbird
14:36:57 <-- aleth has quit (Ping timeout)
14:37:40 <-- Rym has quit (Ping timeout)
14:39:12 <clokep_work> Yeah, I don't remember asking for an xpcshell test on that bug.
14:40:56 <clokep_work> bug 1021684 is unfortunate. :-\
14:40:58 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1021684 nor, --, ---, nobody, NEW, Update box.com Filelink implementation to new APIs
14:42:50 <sawrubh|ib> hrm, so we need to land our patch before it gets bitrotten
14:43:19 <clokep_work> That was not exactly what I was saying, but sure.
14:43:34 --> mconley has joined #instantbird
14:43:45 * sawrubh|ib was just being selfish, sorry
14:44:12 <flo-retina> you may also volunteer to fix that bug :-P
14:44:40 * sawrubh|ib finds a rock to hide under ;)
14:48:44 --> mayanktg has joined #instantbird
14:50:05 <-- nhnt11 has quit (Ping timeout)
14:50:50 --> nhnt11 has joined #instantbird
14:54:19 <-- iamjayakumars has quit (Client exited)
14:54:31 --> iamjayakumars has joined #instantbird
15:02:18 <clokep_work> sawrubh|ib: Your patch still doesn't work for me.
15:03:48 <-- mayanktg-ph has quit (Quit: )
15:04:13 <clokep_work> flo-retina, aleth: Any chance you guys can test this? :-S
15:04:20 <flo-retina> this = ?
15:05:23 <sawrubh|ib> clokep_work: 'doesn't work' = you aren't able to drop the file on the conversation area or the textbox?
15:06:00 <sawrubh|ib> flo-retina: this = the two patches in bug 1014644
15:06:02 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1014644 nor, --, ---, saurabhanandiit, ASSI, Make FileLink work in Instantbird
15:07:04 <clokep_work> sawrubh|ib: Nothing happens when I do, yes.
15:07:29 <sawrubh|ib> clokep_work: do you see any errors in the error console?
15:08:12 <sawrubh|ib> have you turned on the preference btw?
15:09:24 <sawrubh|ib> unlike last time (which was a long time ago) I'm (or atleast was) very confident it should work this time :(
15:09:50 <sawrubh|ib> do you see the preference pane?
15:10:55 <clokep_work> sawrubh|ib: No.
15:11:01 <clokep_work> (No errors.)
15:11:10 <sawrubh|ib> are you sure you
15:11:15 <clokep_work> sawrubh|ib: Hm...I think I flipped the pref, but it's possible I modified the wrong profile.
15:11:17 <sawrubh|ib> you've preffed on the flags
15:11:19 <clokep_work> sawrubh|ib: Yes. I'm positive.
15:11:58 <sawrubh|ib> can you check if it's the right profile, please?
15:12:16 <-- iamjayakumars has quit (Client exited)
15:12:43 <clokep_work> You need to calm down. :P
15:12:48 <clokep_work> It takes me a few minutes to do tehse things.
15:12:55 <clokep_work> And yes, it was the wrong profile.
15:13:07 <clokep_work> I don't think I have a Box.com or YouSendIt account though. :-S
15:14:16 <sawrubh|ib> Mr. User, well you'll have to wait for the protocol file transfer support </kidding>
15:14:41 <clokep_work> Or get the Dropbox addon to work in Instantbird. ;)
15:15:23 * nhnt11 will probably write a puush addon once this lands if it doesn't already exist
15:15:54 <sawrubh|ib> nhnt11: how is a puush addon related to my patch?
15:16:05 <clokep_work> Bah, Box.com requires a phone number? That's annoying...
15:16:06 <nhnt11> sawrubh|ib: For filelink?
15:16:25 <nhnt11> Drop a file, it get's sent to puush, link gets sent to the other person..
15:17:39 <nhnt11> s/get's/gets
15:17:43 <sawrubh|ib> why not land it here : http://mxr.mozilla.org/comm-central/source/mail/components/cloudfile/content/ like the others
15:18:23 <sawrubh|ib> ..because a lot of people might not want it
15:18:36 <nhnt11> That only has Box and Hightail from what I see, so I have no idea of the criteria for landing it there
15:19:02 <nhnt11> Also if it's an addon I can just spend the minimal amount of effort to make it work
15:19:15 * nhnt11 shrugs. This is a premature discussion
15:19:50 * sawrubh|ib goes back to working on the topic bug since things seem to be working for clokep_work
15:20:14 <clokep_work> Bah I can't use the dropbox add-on...firewalled at work.
15:20:28 <clokep_work> sawrubh|ib: OK so initially it seems reasonable at least. :) None of the UI was totally janked either.
15:20:30 <sawrubh|ib> use mobile data connection?
15:20:44 <clokep_work> sawrubh|ib: Tethering in the US costs INSANE amounts of money.
15:21:03 <flo-retina> is it different from just using 3G on the phone?
15:21:06 <clokep_work> The topic bug + the notificationbar stuff should get done.
15:21:07 * sawrubh|ib will keep that in mind in case he ever lands in the US
15:21:18 <clokep_work> flo-retina: Should it be? No. Is it? Yes.
15:21:42 <flo-retina> change country? :-P
15:21:53 <sawrubh|ib> hee hee hee
15:27:59 --> xangua has joined #instantbird
15:29:12 --> aleth has joined #instantbird
15:29:12 * ChanServ sets mode +o aleth 
15:33:19 <clokep_work> sawrubh|ib: Sure, ask florian for f/r.
15:37:40 <nhnt11> Oh, aleth is back
15:38:02 <nhnt11> aleth: "Would it be useful to also test this with dummy operations that resolve/reject after a timeout?" I don't think so
15:38:31 <nhnt11> But I'm investigating
15:39:15 <nhnt11> Also "shouldn't you be asserting ok at the end only if promiseB resolves/rejects correctly?" I think "yield p2.then(() => ok(false), () => ok(true));" would eliminate the need for this
15:39:19 <nhnt11> But again, investigating
15:40:23 <sawrubh|ib> clokep_work: so http://pastebin.instantbird.com/732794 is my WIP, now devel@conference.pidgin.im sends a message in the format I mention in https://bugzilla.mozilla.org/show_bug.cgi?id=1011226#c4 and in order to call setTopic and get it to the show the messages in the format I like '%s has set the topic to %s', I need to pass a setter and in order to extract that setter from the format in which pidgin is sending
15:40:26 <instantbot> Bug 1011226 nor, --, ---, saurabhanandiit, NEW, Support setting the topic in XMPP MUCs
15:40:42 <sawrubh|ib> it to me, I need to pull it from the body
15:41:51 <-- nhnt11 has quit (Ping timeout)
15:42:02 <-- gerard-majax_ has quit (Ping timeout)
15:42:23 --> nhnt11 has joined #instantbird
15:42:57 <-- Tonnes has quit (Quit: ChatZilla [Firefox 29.0.1/20140506152807])
15:43:16 <clokep_work> sawrubh|ib: Is there a question?
15:43:39 <mayanktg> aleth: I'll make the changes as you've suggested in the bug and upload the patch soon.
15:48:52 <sawrubh|ib> clokep_work: so the alternatives are a) not pulling it from the body (since that sounds hack-ish and other channels might not do it this way) b) just showing it in the format 'The topic for <channel name> is %s'
15:49:00 <sawrubh|ib> which one do you think makes sense?
15:50:23 --> iamjayakumars has joined #instantbird
15:50:31 <mayanktg> Mic: I've added the button icons for the aero. Here's the inter diff for the same http://pastebin.instantbird.com/732800 .
15:50:49 <-- iamjayakumars has quit (Client exited)
15:52:47 --> arlolra has joined #instantbird
15:59:24 <-- nhnt11 has quit (Ping timeout)
15:59:37 --> nhnt11 has joined #instantbird
15:59:57 <-- sawrubh|ib has quit (Ping timeout)
16:00:03 --> sawrubh|ib has joined #instantbird
16:00:41 <clokep_work> sawrubh|ib: When you say "pull it from the body" do you mean the CONTENTS of the body or an attribute of the body?
16:01:55 <sawrubh|ib> contents of the body
16:02:30 <clokep_work> We probably shouldn't do that.
16:02:37 <clokep_work> What does the XEPs say?
16:04:30 <sawrubh|ib> well the XEP (http://xmpp.org/extensions/xep-0045.html#subject-mod) says that the subject modifying message shouldn't contain a body, which the pidgin server doesn;t comply to
16:07:31 * sawrubh|ib pushes to try
16:07:45 <clokep_work> Didn't one of the older RFCs or somethign say something about the topic being in the body?
16:08:30 <sawrubh|ib> I've been complying with this XEP
16:08:38 * sawrubh|ib checks the older RFS
16:09:18 <clokep_work> I understand that, but if they're using an older server that doesn't...
16:10:20 <-- nhnt11 has quit (Ping timeout)
16:11:22 --> clokep_w1 has joined #instantbird
16:11:23 --> nhnt11 has joined #instantbird
16:11:47 * clokep_w1 is now known as clokep_work1
16:12:35 <-- clokep_work has quit (NickServ (GHOST command used by clokep_work1))
16:12:40 * clokep_work1 is now known as clokep_work
16:12:52 * ChanServ sets mode +o clokep_work 
16:14:29 <-- aleth has quit (Ping timeout)
16:17:02 --> aleth has joined #instantbird
16:17:02 * ChanServ sets mode +o aleth 
16:18:30 <sawrubh|ib> clokep_work: yeah, http://xmpp.org/rfcs/rfc6121.html#message-syntax-subject says that body can be there
16:20:24 <sawrubh|ib> hrm, but it says the subject will still be in the subject element and not the body...
16:22:25 * sawrubh|ib afk for a bit
16:24:19 <clokep_work> sawrubh|ib: OK, so...it sounds to me like we shouldn't be taking it from the body.
16:25:22 <clokep_work> flo-retina: I don't think you saw my previous question of this, but do we need to also do something similar to bug 1017696?
16:25:24 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1017696 nor, --, seamonkey2.30, philip.chee, RESO FIXED, Use a JSON storage back-end in the Login Manager - SeaMonkey part
16:25:54 <-- aleth has quit (Ping timeout)
16:26:55 --> aleth has joined #instantbird
16:26:55 * ChanServ sets mode +o aleth 
16:30:35 --> gerard-majax_ has joined #instantbird
16:33:25 <-- gerard-majax_ has quit (Ping timeout)
16:34:15 <-- nhnt11 has quit (Input/output error)
16:34:19 --> nhnt11 has joined #instantbird
16:36:37 * sawrubh|ib -> back
16:55:15 <flo-retina> clokep_work: so it looks like they did the packaging change in im/ for us (thanks!)
16:55:32 <clokep_work> flo-retina: WOOT! :) I didn't even think to check the patch.
16:56:02 <flo-retina> clokep_work: for the async loading stuff... I think the chat/ core will need passwords near startup so the hack there copied from Firefox to suite/ wouldn't really save us much (unless the user doesn't connect accounts automatically at startup)
16:56:14 <flo-retina> summary: I think we've got nothing to do.
16:56:29 <clokep_work> OK. :)
17:06:27 <nhnt11> aleth: How would you suggest adding a zero-length log file to the test?
17:06:42 <aleth> nhnt11: You probably have to make one, then read it.
17:06:43 <nhnt11> Would just writing "" to a file work?
17:06:44 * nhnt11 doesn't think so
17:06:57 * nhnt11 does some testing
17:11:07 --> rosonline has joined #instantbird
17:12:06 <nhnt11> Cool, open {truncate: true} and then close creates a zero-length file.
17:12:29 <aleth> I guess that's the equivalent of "touch"
17:12:32 * nhnt11 was worried about a newline automatically being added or something
17:12:33 <nhnt11> yeah
17:13:31 <nhnt11> aleth: Touch doesn't truncate though :)
17:14:08 <aleth> It's more harmless I guess
17:16:02 <clokep_work> Mostly Harmless? :P
17:17:52 <aleth> As long as you bring a towel.
17:18:23 * clokep_work is glad someone got it. :)
17:18:37 * nhnt11 googles that now
17:19:53 <-- rosonline has quit (Ping timeout)
17:19:55 <clokep_work> nhnt11: Hitchhikers Guide to the Galaxy.
17:20:04 <nhnt11> got it
17:20:46 <mayanktg> aleth: I'm now using the generated id and sid, changed the variable name iqStanza to iqContent. But, 1. using |for (let contentNode of iqContent) item.addChild(contentNode)| gives the error |iqContent['@@iterator'] is not a function|
17:20:46 <mayanktg> 2. Cu.reportError(this._targetResource) returns an empty string) which is I guess because we are _sending_ the stanza and IncomingMessage() http://mxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm#260 isn't called yet so the value remains set to |_targetResource = ""| .
17:21:11 --> rosonline has joined #instantbird
17:21:37 <aleth> mayanktg: 1. isn't the return value of sdp2xml an array?
17:22:19 <mayanktg> It is. 
17:22:23 <aleth> 2. So the problem goes away as long as you have received a message from the target before video calling?
17:24:05 <mayanktg> Yes. We will set the _targetResource once we have received a message from the callee before we make an offer.
17:25:08 <aleth> Hmm.
17:25:25 <aleth> You have to change your current code because it will completely break if you have already received a message
17:25:51 <nhnt11> bbiab
17:26:20 <mayanktg> aleth: Yeah you are right.
17:26:42 <mayanktg> it will be barID/Instantbird/Instantbird...
17:26:50 <mayanktg> No only twice.
17:28:52 <-- aleth has quit (Ping timeout)
17:29:25 <mayanktg> Yep..I'm getting repetitive resources.  
17:30:44 <mayanktg> I'll change it up.. :)
17:31:07 * sawrubh|ib grumbles something about weird errors
17:33:02 <sawrubh|ib> btw I'm not too clear after reading https://wiki.mozilla.org/ReleaseEngineering/ThunderbirdTryServer, it says 'The Thunderbird try server is primarily for building Thunderbird. Whilst building other comm-central apps may work, this is not supported - builds and tests may fail etc. '
17:33:12 <mayanktg> aleth: fixed.
17:33:55 <sawrubh|ib> ah, wait. I don't want to build im anyways, I just want to build TB and run the tests. Cool.
17:36:07 <sawrubh|ib> clokep_work: 'try: -b o -e -p linux,linux64,macosx64,win32,win64 -u mozmill -t none' sounds like the right config with which I should push to try?
17:36:32 <clokep_work> sawrubh|ib: I don't know, use try chooser.
17:36:36 --> Rym has joined #instantbird
17:36:42 <clokep_work> sawrubh|ib: Don't build win64.
17:37:00 <sawrubh|ib> I'm using try choose, I wanted to ask which tests to run besides mozmill
17:37:12 <clokep_work> Does this even have mozmill tests?
17:37:17 <clokep_work> "this" being filelink?
17:37:23 <clokep_work> I don't thikn it does, so you should probably NOT run mozmill.
17:37:35 <sawrubh|ib> so which tests to run then?
17:37:41 <clokep_work> Whatever sort of tests it has.
17:37:51 * clokep_work isn't going to look for you.
17:42:35 <sawrubh|ib> seems like FileLink has only mozmill tests (http://dxr.mozilla.org/comm-central/source/mail/test/mozmill/cloudfile)
17:43:21 <clokep_work> Alright, then run just mozmill.
17:44:51 <-- nhnt11 has quit (Ping timeout)
17:46:09 --> nhnt11 has joined #instantbird
17:49:55 --> Mic has joined #instantbird
17:49:56 * ChanServ sets mode +o Mic 
17:51:47 <sawrubh|ib> Interesting, I didn't get a try push url on the terminal (unlike pushing to Fx)
17:51:53 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:52:51 <sawrubh|ib> https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=20636a880c24
17:53:00 <clokep_work> Thanks.
17:53:30 <clokep_work> Let mek now when it finishes? :)
17:54:30 * sawrubh|ib goes back to dealing with that weird 'muc.incomingMessage is not a function' error
17:57:33 <-- mconley has quit (Connection reset by peer)
17:57:51 --> mconley has joined #instantbird
17:58:02 <clokep_work> :-\
17:58:08 <clokep_work> sawrubh|ib: Are you sure that's something you need to solve?
17:58:15 <clokep_work> I'm not convinced the surrounding code is right.
17:58:22 <clokep_work> And I don't want you to waste time debugging something that's useless.
17:59:12 <-- xangua has quit (Quit: Connection closed for inactivity)
17:59:52 <sawrubh|ib> everything seems to work (the topic's getting set in both the cases, pidgin and normal ones complying with XEP), guess it can be called fixed
18:00:34 <sawrubh|ib> I just get this weird error, which doesn't seem to be affecting the output (or probably is but I'm not able to figure out the impact)
18:01:12 <clokep_work> "getting an error" means "not fixed" ;;)
18:01:31 <sawrubh|ib> hrm, I'll have to leave it for now then
18:01:37 * sawrubh|ib moves to notifbox
18:02:17 <sawrubh|ib> probably aleth might have some idea when he coems back
18:02:21 <sawrubh|ib> he usually does
18:02:50 <sawrubh|ib> he helped me fix those weird bindings issue when I was helpless :)
18:03:16 <clokep_work> sawrubh|ib: I'm pretty sure I already told you how to "solve" that issue, but I don't know if you ever tried it.
18:03:54 <sawrubh|ib> I've tried everythign you've suggested, I've tried early return, I've tried calling setTopic with a setter
18:05:48 <clokep_work> What was wrong w/ early returning?
18:05:53 <clokep_work> That it doesn't set the person?
18:06:00 <clokep_work> I thought we just discussed earlier that that isn't really possible.
18:09:46 --> Tonnes has joined #instantbird
18:12:44 <sawrubh|ib> so this is what's happening (http://pastebin.instantbird.com/732849 is the WIP for reference and http://pastebin.instantbird.com/732850 is the output with it), onMessageStanza is getting called for all message stanzas, when I join the channel muc is coming out to be 'sawrubh' which is my nick for that channel, it should instead be an Object with the methods
18:13:21 <sawrubh|ib> that's why I get that error, after that first time, muc is always an Object and has that method and hence no errors and everything works smoothly
18:14:12 <sawrubh|ib> sorry wrong pastebins
18:14:34 <clokep_work> sawrubh|ib: It's because the XMPP code doesn't crazy things where it saves your username in this._mucs and then creates the actual MUC later on.
18:14:48 <sawrubh|ib> http://pastebin.instantbird.com/732851 is the WIP
18:15:09 <sawrubh|ib> you can see I'm early returning on L66 of this
18:15:24 <clokep_work> This happens at https://mxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm#850
18:15:46 <clokep_work> I changed this in one of the patches I have up for review right now.
18:15:52 <clokep_work> So the MUC will always exist after you try to join it.
18:16:47 <sawrubh|ib> yeah, that's what happening. 'muc' doesn't exist the first time and hence I get that error
18:17:20 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
18:18:11 <Mic> mayanktg: the changes for Windows/Aero won't work. That's because the files from the aero folder are going to be used for the theme (see https://mxr.mozilla.org/comm-central/source/im/themes/jar.mn#11 ) and the added lines do not add them to the aero folder. You'll need to adapt the path where the files should be stored accordingly.
18:18:24 <Mic> You can read about the structure of jar manifests here: http://dxr.mozilla.org/mozilla-central/source/build/docs/jar-manifests.rst
18:18:46 <clokep_work> sawrubh|ib: OK, so leave it for now. HOpefully it'll be easier to fix once my patch is committed.
18:18:55 <Mic> You'll also need to add the vector user image for Aero too.
18:19:05 <-- mconley has quit (User has been banned from Mozilla (no spamming here))
18:19:12 <sawrubh|ib> clokep_work: can you give me the bug so that I can add that as dependency?
18:19:17 <-- clokep_work has quit (User has been banned from Mozilla (no spamming here))
18:22:24 <mayanktg> Mic: I'll change the path accordingly. So I need to  convert the two icons into vector images and then put them into the Aero folder. Right?
18:22:58 <Mic> That's not what I wrote ;)
18:24:39 <instantbot> New Chat Core - IRC bug 1022815 filed by dtate@mozilla.com.
18:24:42 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1022815 cri, --, ---, nobody, NEW, Banned for messaging @mardi
18:26:06 <mayanktg> Mic: Oh.. I mixed up the two sentences. :-/ Ok I'll add the userIcon.svg image for the aero too. 
18:27:48 <sawrubh|ib> I wonder if that bug is what caused clokep_work to get disconnected 'User has been banned from Mozilla (no spamming here)'
18:28:20 <sawrubh|ib> flo-retina: ^^
18:30:00 --> mconley has joined #instantbird
18:30:40 --> sonny has joined #instantbird
18:31:09 <Mic> mconley: you left with a strange message about being banned for spamming: http://log.bezut.info/instantbird/today#m692
18:31:20 <-- Rym has quit (Ping timeout)
18:31:37 --> Rym has joined #instantbird
18:31:38 <sawrubh|ib> Mic: yeah clokep left with that message too and he has emailed me just now saying it was something weird
18:31:51 <sawrubh|ib> and that critical bug file above ^^ is also related to this
18:32:06 <Mic> Yep, I've read it.
18:32:58 <mconley> yeah, something screwy happened
18:33:01 * nhnt11 is back
18:33:02 <mconley> not my fault, I swear. :)
18:33:05 <nhnt11> Weird
18:33:31 <Mic> mconley: at least you weren't banned permanently :)
18:33:43 --> clokep_work has joined #instantbird
18:33:44 * ChanServ sets mode +o clokep_work 
18:33:56 * mconley nods
18:33:57 <clokep_work> Ah, here we go. :)
18:35:25 <clokep_work> 14:19:30 - clokep_work: (sawrubh|ib Sorry if you had told me all that before, but I didn't realize you were getting a string of your username when trying to access MUC.)
18:35:37 <clokep_work> And bug 1018771 was what was asked for.
18:35:40 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1018771 min, --, ---, clokep, ASSI, Use Maps and Sets in XMPP code
18:37:01 <-- Rym has quit (Ping timeout)
18:42:33 <-- sonny has quit (Ping timeout)
18:50:13 * mayanktg JAR manifests doc was a good read... :)
18:54:22 <mayanktg> Mic: Should work now http://pastebin.instantbird.com/732864 :-o
18:57:47 <-- mayanktg has quit (Ping timeout)
18:58:20 --> Rym has joined #instantbird
18:58:25 <Mic> mayanktg: other OS dependent files don't have their own folders but contain the OS name in their files names and are renamed while being packaged.
18:58:57 <Mic> Check how it's done for "tag-<OS>.png", I think we want the same here.
19:00:10 --> mayanktg has joined #instantbird
19:01:50 <nhnt11> Meh
19:01:56 <Mic> mayanktg: I left a message in the log
19:02:01 <sawrubh|ib> clokep_work: seems like notificationbox can only have a button (to select whether to upload or not) or some label. I was actually planning to have a dropdown to select the FileLink provider to upload to but that doesn't seem possible now
19:02:05 <-- Rym has quit (Connection reset by peer)
19:02:08 <mayanktg> Mic: yes I was reading it.
19:03:42 * nhnt11 's tests tell him we will need to handle asyncshutdown
19:03:45 --> Rym has joined #instantbird
19:04:11 <nhnt11> Er, we need to clear promises before shutdown is what I mean
19:05:00 <nhnt11> If I have pending logMessage promises, and the test exits (do_throw), all of these pending promises throw stuff like "JSON is undefined" and so on
19:05:32 <-- Rym has quit (Ping timeout)
19:05:42 <nhnt11> I just realized that if this happens in a test, it's possible for it to happen in a real scenario too
19:06:04 <nhnt11> flo-retina: What do you think of this? ^
19:06:15 <nhnt11> I wonder if just yielding on every promise in the map would be enough
19:06:29 <nhnt11> But that could take a while, which isn't cool during shutdown
19:06:34 <mayanktg> Mic: |skin/classic/aero/instantbird/select-file.png       (windows/select-file-aero.png)| I should rename the file in the folder since Windows file have win and aero to their file names.
19:07:04 --> Rym has joined #instantbird
19:07:17 <nhnt11> mayanktg: Are the images for aero/non-aero different?
19:07:28 <mayanktg> nhnt11: No.
19:07:41 <nhnt11> Then you don't need to rename afaik.
19:07:52 <nhnt11> (If I correctly understand what you're talking about)
19:08:20 <nhnt11> the -aero suffixes are there for image where the aero version is different from the non-aero one
19:08:20 <mayanktg> The images are same for linux, aero and non-aero. I only have a 32X32 version for retina displays.
19:08:46 <mayanktg> ok
19:09:00 <nhnt11> For example.png that is common to aero and non-aero, |skin/classic/aero/instantbird/example.png  (windows/example.png)| should do
19:09:48 <mayanktg> I understood what you said. 
19:09:58 <nhnt11> cool
19:10:00 <mayanktg> :)
19:11:11 <Mic> nhnt11: I asked mayanktg to remove the directories and store the files named similar to "tag-*.png" in the theme folder itself.
19:11:47 <nhnt11> Oh! Sorry!
19:11:55 <Mic> So it's rather |skin/classic/aero/instantbird/example.png  (example-win.png)| and so on...
19:11:58 <nhnt11> I think I just added to the confusion :(
19:12:24 <nhnt11> mayanktg: Disregard everything I said, I thought you were talking about aero/non-aero :(
19:12:25 <nhnt11> BUT
19:12:35 <nhnt11> If the linux and windows images are the same, what I said still applies possibly :)
19:13:08 <mayanktg> Sorry :( 
19:13:26 <Mic> The Windows icons look decent. I doubt that they are used for Linux too. scnr ;)
19:13:31 <nhnt11> Uh, that was my fault for responding without any context.
19:13:32 <nhnt11> Mic: lol
19:14:19 <mayanktg> The images are same for linux and windows btw. 
19:15:12 <mayanktg> Mic: So should I move use them to in the theme/ only and then use them as you said above ?
19:15:23 * nhnt11 sighs
19:15:48 <nhnt11> It looks like returning the promise from logMessage may be inevitable for tests
19:16:14 <nhnt11> Because getLogsForConversation does not do any file operations (only directory ones) and therefore is not queued
19:16:32 <nhnt11> (i.e. the getLogsForConv call will finish/yield before logMessage ever happens)
19:16:48 <nhnt11> So I either need to return a promise from logMessage and wait on that or get the path from the map and wait on /that/
19:17:00 <nhnt11> Hmm, I should possibly just use the map
19:18:13 <Mic> mayanktg: yes, you can e.g. only special case the Mac file by appending a "-mac" to it's filename and keep the Linux and Windows filename as it is?
19:18:24 <Mic> That's just an idea...
19:20:07 <mayanktg> Mic: I remember from a conversation that aleth once said we should move them to different folders because in the future we might have icons for each OS's and it will clear things. I'm not sure if it was him or someone else.
19:21:04 <mayanktg> That's why I created separate folders for linux, mac and windows. 
19:21:58 <mayanktg> Ok. I'll keep the filenames for linux and win as it it and add suffix -mac to the mac icons.
19:22:13 <mayanktg> *as it is
19:24:54 <Mic> mayanktg: that makes sense but I think it's not in the scope of this bug. Would you file a bug for what you discussed with aleth?
19:25:37 <mayanktg> Mic: I'll do that. I was just searching the logs to be sure..
19:29:35 <mayanktg> Mic: http://pastebin.instantbird.com/732892 
19:30:36 <mayanktg> ignore the rror at line 33.
19:30:54 * nhnt11 scratches his head
19:35:09 <sawrubh|ib> hrm, I need access to gBrowser to get the notificationbox thingy, this.browser doesn't seem to work
19:35:24 * sawrubh|ib looks up for some examples inside IB for notifbox
19:35:44 <nhnt11> sawrubh|ib: Do you mean the one in conversations?
19:37:28 <sawrubh|ib> yes
19:37:49 <sawrubh|ib> should I do some getParent or some such traversal on browser to get it
19:38:01 <sawrubh|ib> getElemByID prolly
19:39:27 <nhnt11> sawrubh|ib: There's a method called getBrowser() (instantbird.js, in the window's scope), may help you (or did you already have the browser)?
19:40:53 <nhnt11> (https://mxr.mozilla.org/comm-central/source/im/content/instantbird.js#66)
19:42:11 <sawrubh|ib> I'll take a look, no I didn't have the browser
19:42:48 <-- Rym has quit (Ping timeout)
19:43:04 --> Rym has joined #instantbird
19:43:10 <nhnt11> sawrubh|ib: Make sure you do a null check on the browser, not all tabs have one
19:43:16 <nhnt11> (only conversations)
19:43:42 <nhnt11> Well, others could have a browser too, but for example the awesometab doesn't.
19:44:02 <nhnt11> sawrubh|ib: To ensure the current tab is a conversation use getTabBrowser().selectedConversation
19:44:21 <nhnt11> Which will be null if the selected tab panel is not a conv
19:48:44 * nhnt11 gets rid of _queuedLogMessage and makes everything a Task
19:53:09 * mayanktg goes to write xml2sdp()
19:54:50 <-- mayanktg has quit (Ping timeout)
19:54:52 --> mayanktg has joined #instantbird
19:56:05 * nhnt11 should stop using do_throw in async tasks
20:00:52 <clokep_work> sawrubh|ib: We don't have a notification box in the conversation.
20:03:24 <sawrubh|ib> clokep_work: http://mxr.mozilla.org/comm-central/source/im/content/conversation.xml#25
20:03:50 <clokep_work> sawrubh|ib: Interesting, do we actually use that anywhere?
20:04:15 <sawrubh|ib> no where I can see
20:05:05 <clokep_work> Did nhnt11 answer your question of how to get that element?
20:05:33 <flo-retina> clokep_work: we used that for the topic bar before 1.0 (or was that before 0.2?), and didn't remove it because we thought it could be useful for stuff like eg. receiving a file
20:06:10 <sawrubh|ib> I'll take a look, I started checking #servo pfff
20:06:24 <sawrubh|ib> btw the builds are complete at https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=20636a880c24, the tests pass
20:08:14 <-- Rym has quit (Ping timeout)
20:08:32 --> Rym has joined #instantbird
20:09:32 <nhnt11> brb
20:12:15 <clokep_work> sawrubh|ib: Congrats. :)
20:12:57 <sawrubh|ib> :)
20:13:05 <clokep_work> sawrubh|ib: ftp://ftp.mozilla.org/pub/thunderbird/try-builds/saurabhanandiit@gmail.com-20636a880c24/
20:13:20 <clokep_work> I'll play w/ that on Windows tonight unless someone beats me to it.
20:13:29 * sawrubh|ib goes to paste that link in the bug
20:14:11 * sawrubh|ib eyes nhnt11's Windows partition ;)
20:15:25 <sawrubh|ib> arghh, I didn't send my custom mozbuild to try, so it's only built TB :(
20:16:14 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:16:22 <sawrubh|ib> clokep_work: guess you'll have to build on Windows yourself :/
20:16:24 <-- mpmc has quit (Ping timeout)
20:17:14 <clokep_work> sawrubh|ib: I mean TB. I want to make sure it actually works.
20:17:19 <clokep_work> Tests don't necessarily mean something works.
20:17:25 <clokep_work> They should never be relied upon like that.
20:17:41 <clokep_work> qheaden: ping
20:17:42 --> mpmc has joined #instantbird
20:19:40 <-- Rym has quit (Ping timeout)
20:19:58 --> Rym has joined #instantbird
20:25:12 --> EionRobb has joined #instantbird
20:28:27 * nhnt11 falls more and more in love with Tasks
20:28:50 <EionRobb> would you have Tasks babies?
20:29:11 <nhnt11> EionRobb: ok that's a bit weird/creepy.
20:29:25 <EionRobb> that's totally a "yes"
20:38:10 <sawrubh|ib> nhnt11: how will I import instantbird.js, it's not a module and I tried adding js files in the resources section sometime back and it didn't work
20:38:34 <nhnt11> sawrubh|ib: instantbird.js is included in instantbird.xul (the conversation window)
20:38:52 <sawrubh|ib> I want to do this in conversations.xul
20:38:52 <nhnt11> just call getBrowser or getTabBrowser from the window's scope
20:39:05 <nhnt11> window.getBrowser() or just getBrowser() would probably do
20:39:15 <sawrubh|ib> err conversation.xml
20:39:18 * sawrubh|ib tries
20:39:53 <nhnt11> sawrubh|ib: https://mxr.mozilla.org/comm-central/search?string=getTabBrowser&find=im/
20:40:06 <nhnt11> Looks like you need window.getTabBrowser
20:40:20 <nhnt11> Uh, actually just getTabBrowser is used
20:40:35 <nhnt11> But there's a check |if (window.getTabBrowser)|
20:40:46 <nhnt11> Usually that's |if (getTabBrowser in window)| but whatever
20:40:59 <sawrubh|ib> ok
20:44:50 * nhnt11 needs an arbitrary date and tries to think of something clever
20:45:18 <mayanktg> sawrubh|ib: Maybe you can see how getTabBrowser is implemented here http://mxr.mozilla.org/comm-central/source/im/content/instantbird.xul#74 .
20:45:21 <nhnt11> Maybe the date of Instantbird's 1.0 release?
20:46:13 <mayanktg> sorry if it is out of context.
20:46:33 <Mook_as> nhnt11: 1998-03-27, free the lizard?
20:48:23 <nhnt11> Mook_as: What happened on that day? :S
20:48:29 <nhnt11> I couldn't find anything on Google/wikipedia
20:49:04 <nhnt11> I did find http://www.freethelizard.org/
20:49:08 <nhnt11> which is of no help :P
20:49:08 <Mook_as> nhnt11: it should be the first github result for "free the lizard" - Mozilla code was open sourced from Netscape
20:49:26 <nhnt11> Ah! I expected something like that, thanks
20:49:34 <Mook_as> (github, because they imported cvs history at some point)
20:51:16 <nhnt11> Mook_as: The book of mozilla suggests that the date is actually 1998-03-31
20:51:36 <nhnt11> https://en.wikipedia.org/wiki/The_Book_of_Mozilla#The_Book_of_Mozilla.2C_3:31
20:52:03 <Mook_as> Could be; maybe they did a commit first, and then actually opened the repo up later?
20:52:10 * nhnt11 shrugs
20:52:27 * Mook_as can't care enough to shrug
20:52:55 * nhnt11 can't care enough to say that he can't care enough to shrug.. oh wait.
20:53:02 <nhnt11> :P
20:54:13 <-- Rym has quit (Ping timeout)
20:55:15 <clokep_work> sawrubh|ib: You figure it out?
20:56:48 * nhnt11 decides to use the instantbird 1.0 release date
20:57:19 <sawrubh|ib> getNotificationBox doesn't seem to be in window.getTabBrowser(), however window.getTabBrowser exists
20:57:41 <nhnt11> getNotificationBox? Are you sure that's /supposed/ to exist?
20:58:24 <Mic> nhnt11: psst...
20:58:29 <Mic> new Date(Math.random()*1000000000000)
20:58:33 --> arlolra_ has joined #instantbird
20:58:36 <-- arlolra has quit (Connection reset by peer)
20:58:36 <-- arlolra_ has quit (Quit: arlolra_)
20:58:40 <sawrubh|ib> https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/notificationbox#Finding_the_current_notification_box
20:58:54 <nhnt11> Yeah that's not for Instantbird :P
20:58:59 * nhnt11 doesn't think Ib has such a method
20:59:06 <nhnt11> Mic: I need something that /isn't/ random :(
20:59:13 <nhnt11> Otherwise I'd have used new Date()
20:59:23 <Mic> Put it into a lazy getter.
20:59:27 <sawrubh|ib> or wait I can do it like this http://dxr.mozilla.org/comm-central/source/im/content/newtab.xml#330
20:59:29 <nhnt11> Mic: I need to ensure that I have a date that is not the last millisecond of a day or something
20:59:32 <nhnt11> For daily logs
20:59:46 <nhnt11> sawrubh|ib: Look at the line /above/ the line you linked
21:00:04 <clokep_work> sawrubh|ib: Did you dxr for getNotificationBox? That doesn't exist most likely. ;)
21:01:11 <nhnt11> sawrubh|ib: I think you want something like this: https://pastebin.mozilla.org/5381711
21:01:28 <sawrubh|ib> clokep_work: heh, I didn't
21:01:55 <nhnt11> Mic: It's the property of a dummy conv object I'm using in my tests :)
21:02:05 <nhnt11> (Yes it's a lazy getter)
21:08:22 <sawrubh|ib> nhnt11, clokep_work: it works
21:08:40 <nhnt11> cool :)
21:08:53 * nhnt11 just typed that message^ in his code editor -_-
21:09:10 * sawrubh|ib quickly finishes this and gets on with life
21:09:17 <sawrubh|ib> I mean the next thing
21:09:47 <sawrubh|ib> ..which will probably come from https://etherpad.mozilla.org/ib-filelink
21:10:30 <clokep_work> It will.
21:10:41 <clokep_work> I think there's some good stuff on there. :)
21:10:45 <clokep_work> The juicy parts of the project.
21:10:50 <sawrubh|ib> XMPP File Transfer seems to be the way forward!
21:10:58 <clokep_work> Unfortunately a lot of this has been not so exciting sof ar. :(
21:11:18 <sawrubh|ib> From my side? or the moving part?
21:11:26 <clokep_work> The movnig and fixing of stuff.
21:13:44 <sawrubh|ib> hrm, I kinda wonder if I should do point 3 over point 2 (on that etherpad)
21:14:22 <clokep_work> sawrubh|ib: 2 is kind of required for 3, although you could get around it by initially implementing it via a command or something.
21:14:53 <clokep_work> So you might need to do 2 + 3 at once.
21:14:59 <sawrubh|ib> so we have two big parts now, (one supposedly big part of FileLink is done I suppose) one implementing XMPP support and then a purplexpcom interface using libpurple
21:15:14 <sawrubh|ib> (and obviously the UI to accept and reject and stuff)
21:15:25 * clokep_work counts like 5 big parts in there. ;)
21:15:34 <sawrubh|ib> (and the Downloads Panel)
21:15:57 <clokep_work> So 1 is implementing the XMPP support + the interface, another is implementing that interface for purplexpcom.
21:16:10 <clokep_work> A third is all the UI stuff + figuring out the "automatic" switching from file transfer to file link.
21:16:15 <clokep_work> That mostly sums it up?
21:16:45 <sawrubh|ib> yeah, if UI is Downloads Panel + UI for deciding which method to use
21:16:45 * clokep_work is leaving in a minute.
21:17:05 <sawrubh|ib> yay, you'll reach home and have more time :)
21:17:05 <clokep_work> + adding a button to upload things.
21:17:08 <clokep_work> And probably other stuff.
21:17:14 <clokep_work> I'm going for a run first, most likely.
21:17:22 <sawrubh|ib> wow, miles to go before I sleep
21:17:35 <clokep_work> Hopefully be back before 7.
21:17:45 <sawrubh|ib> which is 4am here...
21:18:10 <sawrubh|ib> I should be awake probably...
21:18:28 * sawrubh|ib finds out the readings for 'implementing the XMPP support + the interface'
21:18:41 <sawrubh|ib> I guess I'll start with those previous bugs?
21:18:50 <sawrubh|ib> also need to file new ones
21:19:22 <-- clokep_work has quit (Ping timeout)
21:33:25 --> sonny has joined #instantbird
21:36:26 <sawrubh|ib> Mic: there?
21:37:41 <sawrubh|ib> although I've checked myself but wanted to make sure that it's not possible to add dropdowns to notificationboxes right?
21:39:09 --> jb has joined #instantbird
21:43:24 --> Rym has joined #instantbird
21:43:52 <mayanktg> Mic: Should I send the user icon bug patch for review? I have made the changes to the jar.mn, and flo said he would fix the Mac issues.
21:44:40 --> flo-retina has joined #instantbird
21:44:40 * ChanServ sets mode +qo flo-retina flo-retina 
21:45:52 <Mic> mayanktg: if you've got a newer version of the patch, then yes, please :)
21:46:47 <Mic> sawrubh|ib: you can create notification bars with any content if you like.
21:47:13 <mayanktg> Ok. I'm updating it then. The pastebin I shared for the jar.mn diff was correct http://pastebin.instantbird.com/732892 ?
21:47:16 <Mic> You'd have to write an own binding that extends normal notification bars for that.
21:47:48 <Mic> We used to have one that showed the topic on top of the conversation and allowed editing it too. So it's definitely possible.
21:48:07 <Mic> If that's what you want to do...
21:48:21 <sawrubh|ib> Mic: got any examples? btw I'm using http://mxr.mozilla.org/comm-central/source/im/content/conversation.xml#25 right now to show my notifs
21:48:46 <sawrubh|ib> hrm, sounds like a bit of work
21:48:53 <-- jb has quit (Ping timeout)
21:48:58 <sawrubh|ib> not worth the effort for a UI that's in flux
21:50:25 <-- sonny has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:52:38 <-- sawrubh|ib has quit (Connection reset by peer)
21:53:12 <Mic> sawrubh|ib, in case that you're curious: https://hg.mozilla.org/comm-central/rev/8541b2932cfb
21:54:00 <flo-retina> Mic: r=morian !
21:54:32 * flo-retina didn't remember that
21:55:00 --> sawrubh|ib has joined #instantbird
22:14:40 <sawrubh|ib> clokep I'm very sleepy, will carry on when I get back
22:14:43 * sawrubh|ib -> sleep
22:14:56 <-- sawrubh|ib has quit (Quit: sawrubh|ib)
22:24:11 <-- Rym has quit (Ping timeout)
22:25:18 --> Rym has joined #instantbird
22:29:48 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:29:54 <-- Rym has quit (Ping timeout)
22:31:02 --> Rym has joined #instantbird
22:31:15 <nhnt11> flo-retina: By the way, after I finish these tests (which is soon but I think you might go to bed by then) I thought I'd either experiment with the convbrowser more, or start experimenting with a database. Any thoughts?
22:31:33 <nhnt11> (I'm a bit keen on trying out the database stuff at the moment)
22:31:57 <flo-retina> can you be more specific about what "trying out the database stuff" means?
22:32:00 <nhnt11> I remember we discussed that it's a good idea to test out the performance of a database if we store all messages inside it etc
22:32:32 <nhnt11> I wanted to check out how big it might get, and maybe run some benchmarks on storage/retreival with full text search enabled
22:33:04 <-- Rym has quit (Ping timeout)
22:33:46 --> Rym has joined #instantbird
22:42:19 --> clokep has joined #instantbird
22:42:19 * ChanServ sets mode +o clokep 
22:48:52 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
22:49:00 <-- mconley has quit (Input/output error)
22:49:06 <clokep> Mic: Nice. :) That was before my time. ;)
22:49:29 --> mconley has joined #instantbird
22:51:15 <-- mconley has quit (Ping timeout)
22:54:11 <-- Rym has quit (Ping timeout)
22:54:21 --> Rym has joined #instantbird
22:54:48 * clokep tries sawrubh's build.
22:55:05 <flo-retina> clokep: you really never saw that topic bar?
22:55:31 <clokep> flo-retina: I just meant that commit.
22:55:37 <clokep> I was around before we had the topic header.
22:57:36 * nhnt11 tries to figure out why getNewLogFileName divides the input date by 1000
22:58:18 <nhnt11> Turns out my problems were being caused by that - any date I gave divided by 1000 was before epoch, so it returned the same name for all of my files
22:58:46 <nhnt11> I thought I'd figured this out already but apparently I haven't.
22:59:56 <flo-retina> nhnt11: timestamps in ms vs timestamps in seconds?
23:00:09 <clokep> How do you get a date before the epoch if it's a positive number? :P
23:01:17 <nhnt11> clokep: That's a good point, my reasoning for all the files being named 1970-01-16.090959+0530.json is bad then :S
23:01:48 <nhnt11> Ah, 090959...
23:01:53 * nhnt11 feels stupid
23:02:14 <nhnt11> Now I'm more confused why they all got the same name.
23:02:35 <nhnt11> 090959 = 09:09:59 right? Hours:minutes:seconds
23:03:06 <nhnt11> flo-retina: What I'm trying to understand is why it divides the input date /inside/ the date constructor
23:03:12 <nhnt11> new Date(aDate / 1000)
23:03:33 <clokep> Yes
23:03:35 <nhnt11> That means the aDate input is pre-multiplied somewhere? :S
23:03:48 <clokep> nhnt11: aDate is milliseconds
23:04:26 <nhnt11> clokep: The date constructor accepts a value in milliseconds
23:04:32 <flo-retina> isn't aDate a PRTime in micro seconds, and new Date taking a value in ms?
23:04:43 <clokep> Yes, that's it, see https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIFile
23:04:47 --> wnayes has joined #instantbird
23:04:53 <clokep> lastModifiedTime
23:05:20 <clokep> oh wait, that's milliseconds too.
23:05:24 <clokep> Somewhere we use PRTime, yes. :)
23:05:29 <nhnt11> flo-retina: Wow, thanks, just saw imILogger.idl
23:05:52 * clokep remembers figuring this out when dealing w/ wnayes' patch.
23:05:55 <nhnt11> Log conversations have a PRTime startDate attribute
23:06:44 <nhnt11> Interesting, so a conversation's startDate is in microseconds
23:07:43 <-- Rym has quit (Ping timeout)
23:07:46 <nhnt11> flo-retina: Do we use PRTime to accommodate libpurple? Because JS dates are accurate to milliseconds only
23:08:04 <nhnt11> JS Date objects anyway
23:08:11 <flo-retina> nhnt11: I think that was because it's what is easy to use in xpconnect
23:08:23 <nhnt11> Hmm, unless Date objects accept fractional values
23:08:27 <nhnt11> flo-retina: Oh okay, thanks.
23:08:27 <flo-retina> I would be surprised if libpurple had more details than second
23:09:18 <clokep> nhnt11: JS doesn't even support 64-bit ints. :(
23:09:30 * nhnt11 didn't know that
23:11:22 <EionRobb> it goes up to 48-bit right?
23:11:22 <clokep> Numbers in JS are doubles IIRC.
23:11:32 <clokep> So you can only get to like yeah, 48 or 54 or something bits of precision.
23:14:36 <EionRobb> I didn't realise that bitshifting operations only worked on ints up to 32bit
23:15:15 <nhnt11> Bah, now I'm getting NaN's ...
23:15:20 <clokep> :-D
23:15:23 <clokep> nhnt11: Show some code.
23:15:27 --> Rym has joined #instantbird
23:15:43 <nhnt11> One second
23:17:19 <nhnt11> clokep: I'm about to paste, but some background: I have a dummyConv with a startDate getter that returns a date in microseconds. I pass this value while writing the logs. Reading also works fine, but the date of the conversation read from the log file is "NaN"
23:18:36 <nhnt11> https://pastebin.mozilla.org/5382194
23:20:37 <clokep> nhnt11: Where are you getting NaNs?
23:20:43 <nhnt11> I realize that the start date of the logConversation that is read from the file may not be exactly equal to the one in the dummyConv due to conversion as well as since the startDate of the logConversation is obtained by the first message in the file
23:20:54 --> mconley has joined #instantbird
23:20:57 <nhnt11> clokep: Line 62
23:21:42 <clokep> Hmm....what's the result of line 13?
23:21:54 <nhnt11> clokep: A time in millis
23:22:24 <clokep> I'm not sure. :-\
23:22:30 <clokep> Print everything otu? :P
23:22:55 <nhnt11> I just did
23:23:05 <nhnt11> It's identical to new Date(2011, 5, 28).valueOf()
23:23:07 <nhnt11> 1309199400000 vs 1309199400000
23:23:26 <nhnt11> Hmm
23:23:34 <nhnt11> It may be that MESSAGES aren't using PRTime
23:23:45 <nhnt11> And line 62 is checking properties for the messages..
23:24:09 <clokep> nhnt11: Which is the NaN?
23:24:11 <nhnt11> gah, let me check some stuff
23:24:14 <clokep> OK
23:24:37 <nhnt11> clokep: TEST-UNEXPECTED-FAIL | [...]/test_logger.js | 1309199401000 == "NaN" - See following stack: [...]
23:24:40 <nhnt11> So the first message
23:25:05 <clokep> OK, and yeah it's after you retrieve it.
23:25:17 <nhnt11> Yes
23:25:18 <nhnt11> Ah!
23:25:30 <nhnt11> logMessage does new Date(aMessage.time * 1000)
23:25:35 <nhnt11> Which makes me think aMessage.time is in seconds
23:25:48 <nhnt11> (Which coincides nicely with what flo said about libpurple ;))
23:25:49 * nhnt11 checks
23:26:41 <nhnt11> No, prplIMessage stores it as PRTime
23:26:55 <-- mconley has quit (Input/output error)
23:27:05 <clokep> nhnt11: Are you reading it wrong or something?
23:28:18 <nhnt11> No. The other properties seem to be correct
23:28:23 <nhnt11> I'll double check
23:30:48 <clokep> :-\ I'm not sure Im' helpful, sorry.
23:33:05 <nhnt11> Looks like according to this: https://mxr.mozilla.org/comm-central/source/chat/modules/jsProtoHelper.jsm#371
23:33:06 <nhnt11> time is in seconds and not millis
23:33:36 <nhnt11> flo-retina: Can you confirm this^
23:34:34 <flo-retina> prplIMessage.time seems in seconds, yes
23:35:09 <flo-retina> hmm, it's a PRTime :-S http://lxr.instantbird.org/instantbird/source/chat/components/public/prplIMessage.idl#32
23:35:11 * flo-retina is confused
23:35:14 <nhnt11> flo-retina: Exactly
23:35:23 <flo-retina> it's possible that's just mixed up
23:35:25 <nhnt11> And there's no getter for the time in the GenericMessagePrototype
23:38:00 <nhnt11> flo-retina: Should I be investigating/fixing this possible mixup or can I proceed with how it's all working currently?
23:38:44 <flo-retina> either. But I would do the latter if I were you ;)
23:39:21 <nhnt11> flo-retina: It doesn't seem to be a mix-up judging by the fact that logMessage multiplies it by 1000 before logging it
23:39:42 <nhnt11> And yeah I'm going to do the latter, I've been blocked on this for a while :]
23:40:02 <flo-retina> that .idl file should really have a comment about the unit thought
23:40:10 <nhnt11> Sure, I can add that.
23:40:29 <nhnt11> Though I have no idea of a reason for it
23:42:34 <clokep> Bah I have quesetions for sawrubh. :-S
23:44:17 <nhnt11> pfft, timezones
23:44:48 * clokep still doesn't understand these selected changes.
23:45:26 <nhnt11> clokep: selectedConversation stuff? I can answer questions related to that
23:45:36 * clokep has no idea what nhnt11 is talking about.
23:45:43 <nhnt11> When you said "selected changes"...
23:45:44 <nhnt11> nvm
23:45:57 <clokep> nhnt11: The changes to the handlers for when an account is selected in filelink.
23:46:05 <nhnt11> oh okay. not related, nvm
23:46:06 <nhnt11> sorry
23:46:56 <clokep> No problem.
23:47:56 <nhnt11> Cool, changing message time to seconds fixed everything :)
23:56:51 <-- wnayes has quit (Quit: wnayes)