#instantbird log on 06 08 2014

All times are UTC.

00:01:00 --> xangua has joined #instantbird
00:12:50 --> BWMerlin has joined #instantbird
00:17:04 <-- Rym has quit (Ping timeout)
00:18:19 --> Rym has joined #instantbird
00:20:37 <-- Rym has quit (Ping timeout)
00:21:03 --> Rym has joined #instantbird
00:36:39 <-- Rym has quit (Ping timeout)
00:49:07 <-- Armada has quit (Connection reset by peer)
00:51:18 --> Rym has joined #instantbird
01:13:51 --> clokep has joined #instantbird
01:13:51 * ChanServ sets mode +o clokep 
01:26:16 <-- Rym has quit (Ping timeout)
01:26:34 --> Rym has joined #instantbird
01:35:06 --> mconley has joined #instantbird
01:39:03 <-- Rym has quit (Ping timeout)
01:39:23 --> Rym has joined #instantbird
01:50:21 <-- rosonline has quit (Ping timeout)
01:52:09 --> rosonline has joined #instantbird
01:52:31 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
01:52:45 --> rosonline has joined #instantbird
01:58:19 <-- mconley has quit (Ping timeout)
01:58:47 --> mconley has joined #instantbird
02:13:27 <-- rosonline has quit (Ping timeout)
02:14:39 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
02:22:23 <-- Rym has quit (Ping timeout)
02:22:43 --> Rym has joined #instantbird
02:22:44 <-- mayanktg has quit (Quit: Connection closed for inactivity)
02:31:48 <-- Rym has quit (Ping timeout)
02:32:48 --> Rym has joined #instantbird
02:34:48 <nhnt11> Hi
02:34:54 * nhnt11 is up bright and early this morning
02:36:50 <-- mconley has quit (Ping timeout)
02:38:11 --> mconley has joined #instantbird
02:43:46 <-- Rym has quit (Ping timeout)
02:45:00 --> Rym has joined #instantbird
03:25:04 <-- Rym has quit (Ping timeout)
03:25:32 --> Rym has joined #instantbird
03:43:30 <-- Rym has quit (Ping timeout)
03:44:44 --> Rym has joined #instantbird
03:49:14 <-- mconley has quit (Ping timeout)
03:49:33 <-- Rym has quit (Ping timeout)
03:49:43 --> mconley has joined #instantbird
03:49:51 --> Rym has joined #instantbird
03:57:30 <-- Rym has quit (Ping timeout)
03:59:34 --> Rym has joined #instantbird
04:07:08 <-- mconley has quit (Input/output error)
04:16:28 <-- Rym has quit (Ping timeout)
04:16:48 --> Rym has joined #instantbird
04:45:29 <-- Rym has quit (Ping timeout)
05:39:12 <-- xangua has quit (Quit: Connection closed for inactivity)
06:04:38 <sawrubh> nhnt11: o/
06:55:06 --> EionRobb has joined #instantbird
07:02:26 --> jb has joined #instantbird
07:10:34 --> mayanktg has joined #instantbird
07:20:59 <-- mayanktg has left #instantbird ()
07:24:41 --> mayanktg1 has joined #instantbird
07:25:14 <-- mayanktg1 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
07:25:16 --> mayanktg has joined #instantbird
07:38:43 --> Mic has joined #instantbird
07:38:43 * ChanServ sets mode +o Mic 
07:48:29 <-- Mic has quit (Ping timeout)
07:54:39 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
08:02:15 <-- jb has quit (Ping timeout)
08:07:08 --> sawrubh|ib has joined #instantbird
08:07:55 --> iamjayakumars has joined #instantbird
08:10:45 <-- sawrubh|ib has quit (Quit: sawrubh|ib)
08:18:56 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
08:19:03 --> nhnt11 has joined #instantbird
08:28:40 --> jb has joined #instantbird
08:29:20 <-- iamjayakumars has quit (Client exited)
08:36:42 --> iamjayakumars has joined #instantbird
08:38:44 <-- iamjayakumars has quit (Client exited)
09:01:40 --> iamjayakumars has joined #instantbird
09:03:57 --> Armada has joined #instantbird
09:05:53 <-- iamjayakumars has quit (Client exited)
09:19:53 --> mayanktg-ph has joined #instantbird
09:21:56 --> iamjayakumars has joined #instantbird
09:35:53 <-- EionRobb has quit (Quit: Leaving.)
09:37:15 --> sawrubh|ib has joined #instantbird
09:39:51 <-- sawrubh|ib has quit (Ping timeout)
09:40:54 --> sawrubh|ib has joined #instantbird
09:41:45 --> Mic has joined #instantbird
09:41:45 * ChanServ sets mode +o Mic 
09:43:13 <-- iamjayakumars has quit (Client exited)
09:43:25 <Mic> mayanktg-ph: do I need to do something special to compile with your user icon patch applied? The build failed after applying your patch. Building IB without anything applied worked fine though.
09:43:30 <-- sawrubh|ib has quit (Ping timeout)
09:44:24 --> sawrubh|ib has joined #instantbird
09:45:51 <mayanktg-ph> Mic: No. You only need to add the MOZ_Media_navigator=1 in the im/confvars.h file ..which is included with the patch.
09:46:08 <mayanktg-ph> And the do a complete build
09:47:56 <mayanktg-ph> Wait I'll try applying it to a new ib instance and see if its failing :-o
09:49:06 <Mic> Is there a difference between "mach build clobber" and running "mach clobber"  and then "mach build" manually?
09:50:29 <-- stux has quit (Ping timeout)
09:50:39 <mayanktg-ph> Sorry Idk the difference..I always did a "mach clobber" and then "mach build" personally. 
09:50:39 <Mic> Let's see (and hope that my computer doesn't overheat again :( )
09:52:01 <mayanktg-ph> Ok..I'm also setting up a new ib instance in the mean time. :)
09:52:45 <mayanktg-ph> nhnt11 said there is glitches in padding when seen in Mac and Windows
09:53:28 <mayanktg-ph> I don't have a working mac and win environment for ib to test and fix it :(
09:55:29 --> iamjayakumars has joined #instantbird
09:56:03 <Mic> mayanktg-ph: which paddings do you mean?
09:56:36 <nhnt11> Mic: The button margins were a bit off
09:56:43 <nhnt11> I don't have a screenshot unfortunately
09:56:51 <nhnt11> Not really "glitches" ;)
09:56:51 <mayanktg-ph> The paddings for the buttons ..they appear to misaligned
09:57:09 <mayanktg-ph> Okk
10:07:27 <-- jb has quit (Ping timeout)
10:07:28 <-- iamjayakumars has quit (Connection reset by peer)
10:09:13 <-- sawrubh|ib has quit (Ping timeout)
10:10:50 --> sawrubh|ib has joined #instantbird
10:11:35 <sawrubh|ib> Mic: hey
10:12:09 <sawrubh|ib> do you know if someone is planning on bug 954497?
10:12:12 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=954497 nor, --, ---, nobody, NEW, Unsharp MUC icon in infobar on conversation top (height is 1px too large)
10:13:48 <Mic> It doesn't look like someone's planning to work on that. Just take it if you like.
10:14:34 <Mic> I'm not seeing this problem on Win 7 by the way.
10:15:19 <mayanktg-ph> Mic: ok :) 
10:15:31 <sawrubh|ib> yeah, so it doesn't come on Win7 and aleth said he doesn't see it on Mac
10:15:40 <sawrubh|ib> for some reason it was fixed only for Mac and Win
10:16:18 <mayanktg-ph> Mic: Ohh..sorry ..I though it was related to my conv.
10:19:20 <Mic> My build failed.
10:19:28 <Mic> After almost 30 minutes. That sucks :(
10:20:27 <sawrubh|ib> Mic: have you tried clobbering
10:20:39 <Mic> Yes, I did.
10:20:56 <sawrubh|ib> what's the error you get?
10:23:36 <-- sawrubh|ib has quit (Ping timeout)
10:25:06 <Mic> http://pastebin.instantbird.com/732108
10:25:21 <Mic> The first error is on line 830...
10:26:14 <Mic> It translates to "Conversion of parameter 1 from 'mozilla::dom::NavigatorUserMediaSuccessCallback *' to 'mozilla::dom::CallbackObject *' is not possible."
10:28:08 <Mic> I'll be back after lunch, see you.
10:28:08 --> sawrubh|ib has joined #instantbird
10:29:00 <mayanktg-ph> Until then I'm trying building it up on my Ubuntu 
10:29:40 <sawrubh|ib> Mic: http://pastebin.instantbird.com/731746 is the error I was getting yesterday night
10:29:48 <sawrubh|ib> looks pretty similar to yours
10:29:56 <nhnt11> Build output is localized?
10:29:58 <nhnt11> That's nice! :)
10:30:15 <sawrubh|ib> I pulled the latest changes, clobbered and it build fine after that
10:30:27 <sawrubh|ib> s/build/built
10:40:46 <-- sawrubh|ib has quit (Connection reset by peer)
10:42:14 --> mpmc has joined #instantbird
10:42:30 --> sawrubh|ib has joined #instantbird
10:43:57 --> clokep has joined #instantbird
10:43:58 * ChanServ sets mode +o clokep 
10:57:08 <sawrubh|ib> clokep: Morning
11:03:14 <sawrubh|ib> Mic: so http://dxr.mozilla.org/comm-central/source/im/themes/conversation.css#71 is what styles the icon on all the platforms (it's not OS specific)
11:03:35 <sawrubh|ib> so I'm not sure how the bug seems to be fixed on Mac and Windows but not on Linux
11:04:10 <sawrubh|ib> and http://dxr.mozilla.org/comm-central/source/im/themes/tabbrowser-gnomestripe/tabbrowser.css#92 is what styles the icon in the tabstrip (it's OS specific)
11:08:55 <clokep> sawrubh|ib: Did you read https://wiki.mozilla.org/ReleaseEngineering/ThunderbirdTryServer ?
11:09:04 <clokep> Pushing to try for TB is slightly different than Firefox.
11:09:16 <clokep> Also, please build Windows and/or Mac too. I don't have Linux to test on.
11:10:16 <nhnt11> clokep: Cmd+Plus/minus is supposed to increase/decrease font size in conversations, right?
11:10:41 <clokep> nhnt11: Maybe.
11:10:52 <nhnt11> I think it is
11:10:53 * nhnt11 will check
11:10:58 <nhnt11> It's not working at the moment fo rme though
11:11:59 <clokep> sawrubh|ib: What's the difference between v4 and v5?
11:12:16 <sawrubh|ib> nhnt11, clokep: any idea why bug 954497 would be happening given what I said above
11:12:18 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=954497 nor, --, ---, nobody, NEW, Unsharp MUC icon in infobar on conversation top (height is 1px too large)
11:12:40 <nhnt11> sawrubh|ib: I'll take a look in a minute
11:12:50 <clokep> sawrubh|ib: No, styling is different on different OSes though...
11:13:35 <sawrubh|ib> clokep: I've only updated v5 of Moving the cloudfile to chat/ part because I had forgotten to remove entries for the file I had moved from mail from the jar.mn's in mail/
11:13:45 <sawrubh|ib> so v5 ensures TB compiles
11:13:55 <sawrubh|ib> with v4 of Patch1, TB won't compile
11:14:07 <sawrubh|ib> there is no change in the second (smaller) patch which makes drag and drop work
11:14:14 <sawrubh|ib> (it's still at v4)
11:14:28 <clokep> OK.
11:19:00 <nhnt11> sawrubh|ib: That bug must be really annoying
11:19:08 <nhnt11> Try using the domI to tweak stuff until it works?
11:19:39 <-- Mic has quit (Ping timeout)
11:19:39 <nhnt11> Btw, are you sure you want to be looking at status type icon?
11:20:05 <nhnt11> I think you want prplIcon
11:20:06 <sawrubh|ib> I used DOMi and that's class applied to that icon
11:20:17 <nhnt11> Aaah
11:20:22 <nhnt11> okay that's the MUC icon
11:20:23 <nhnt11> hmm
11:20:24 <sawrubh|ib> hrm, DOMi tells me something else
11:20:29 <sawrubh|ib> yeah :)
11:20:29 <nhnt11> yeah statusTypeIcon should be the one.
11:22:23 <sawrubh|ib> I still don't get it why the styling is different on different OS'es. I don't see any ifdefs or anything OS specific around that class in the CSS :/
11:22:38 * sawrubh|ib checks more closely
11:26:35 <-- sawrubh|ib has quit (Ping timeout)
11:28:17 --> sawrubh|ib has joined #instantbird
11:32:46 <sawrubh|ib> gah, I pushed it to the wrong try server :(
11:35:28 <sawrubh|ib> clokep: are you reviewing right now or waiting for something from my side?
11:36:31 <clokep> sawrubh|ib: I'm doing neither.
11:36:48 <sawrubh|ib> ah
11:39:19 <sawrubh|ib> clokep: I hadn't done the CSS for the preference pane for Windows and Mac, I'll do that (which should take like 10 minutes) and then probably get someone to test it (like nhnt11 ;) ) and if it works well, send to try for building it for Mac and Windows and then you can test. Sounds good?
11:39:50 <sawrubh|ib> if it works, are we good to land :P ?
11:41:19 <clokep> I need to review the code first.
11:41:25 <clokep> And then Florian needs to look over it.
11:41:32 <clokep> And then we have to get a TB person to review it.
11:44:35 <nhnt11> sawrubh|ib: Filelink doesn't have any new interfaces? :S
11:44:38 <nhnt11> That's surprising
11:44:56 <sawrubh|ib> you mean IDL's when you say interfaces right?
11:45:03 <nhnt11> yes
11:45:43 <sawrubh|ib> hmm, I've just moved it so whatever was there should be there...but that's not a good answer
11:46:07 <sawrubh|ib> ah, it has IDL's wait
11:46:21 <nhnt11> Ah
11:46:30 <sawrubh|ib> I just moved them too (to chat/) so I guess you'll have to clobber
11:46:42 <nhnt11> I'll clobber then (I'd rather not take any chances)
11:46:45 <nhnt11> yeah
11:47:08 <sawrubh|ib> clokep: sounds like a lengthy process
11:47:42 <clokep> You do NOT have to clobber for new interfaces!
11:47:51 <clokep> You DO have to do a full build .
11:48:02 <clokep> nhnt11: ^
11:48:07 <clokep> sawrubh|ib: What?
11:48:31 <sawrubh|ib> you reviewing, and then flo and a TB guy
11:48:37 <-- Fallen|away has quit (Ping timeout)
11:54:37 <clokep> sawrubh|ib: Hopefully the second two will go pretty fast.
12:00:07 <sawrubh|ib> so in http://pastebin.instantbird.com/732147 will I have to repeat every file I mentioned between 28 to 34 under the aero section or only the icons and one aero specific CSS (that I've already done)
12:01:28 <sawrubh|ib> also see the indentation in that pastebin and what I see on my Sublime : http://i.imgur.com/l9q1u2T.png
12:01:57 <sawrubh|ib> weird
12:02:11 --> Fallen|away has joined #instantbird
12:02:40 <sawrubh|ib> I guess I'll go back to vim, there the indentation of the file matches what I see in the pastebin
12:02:49 <nhnt11> clokep: Okay.
12:03:12 * nhnt11 just figured a clobber would be very safe... and I haven't clobbered in a while
12:03:35 <clokep> sawrubh|ib: That file uses tabs.
12:03:43 <clokep> nhnt11: Clobbers take a long time.
12:04:12 <nhnt11> I suppose.
12:04:27 * nhnt11 's non-clobber full build has taken 14 minutes already after a fresh pull
12:05:02 <sawrubh|ib> clokep: and what about my actual question about aero chrome urls
12:05:45 <clokep> sawrubh|ib: I don't really understand your question, but I think the answer is no.
12:06:04 <clokep> If you don't give a specific aero version, I think it just uses the non-aero one.
12:06:19 <-- Fallen|away has quit (Ping timeout)
12:07:38 <sawrubh|ib> so in http://dxr.mozilla.org/comm-central/source/mail/themes/windows/jar.mn#564 an entry is being added in the aero section event though the box-logo.png file is the same
12:08:01 <sawrubh|ib> technically they shouldn't have repeated it again right?
12:08:26 <clokep> I don't know, that's why I said "I think" above.
12:08:32 <clokep> I'm really not the person to ask about that. :-\
12:09:12 <nhnt11> sawrubh|ib: I think I can answer this, not a 100% sure (give me a minute)
12:12:38 --> jb has joined #instantbird
12:13:38 --> Fallen|away has joined #instantbird
12:14:53 <nhnt11> sawrubh|ib: Look at the top of the jar.mn
12:15:56 <nhnt11> It maps chrome://instantbird to skin/classic/(aero/)instantbird depending on the os version
12:16:23 <nhnt11> So defining a resource for just one isn't enough, because then it won't get packaged for the others
12:16:28 <nhnt11> (even if it's the same file)
12:16:31 <nhnt11> That's my explanation
12:16:45 * nhnt11 remembers he came across this last year)
12:20:10 --> iamjayakumars has joined #instantbird
12:22:22 <-- jb has quit (Ping timeout)
12:28:43 <clokep> sawrubh|ib: So what did you think of what aleth was saying about the Applications tab?
12:34:31 --> mayanktg has joined #instantbird
12:35:37 --> jb has joined #instantbird
12:36:17 <mayanktg> Mic: I applied my patch on a new c-c repo and did a complete build. The build was successful
12:39:03 <mayanktg> Mic: I guess as sawrubh said you need to pull the latest changes, clobber and build again. 
12:47:58 <-- sawrubh|ib has quit (Ping timeout)
12:49:21 --> sawrubh|ib has joined #instantbird
12:50:08 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:50:53 <sawrubh|ib> clokep: sorry I was away
12:52:37 <sawrubh|ib> so I'm not too much in favor of combining the FileLink panel in the Applications tab
12:52:48 * sawrubh|ib re reads what aleth said
12:55:57 <-- jb has quit (Ping timeout)
12:59:04 <sawrubh|ib> clokep: I'll first answer your comments on the patches
12:59:48 <-- mayanktg-ph has quit (Quit: )
13:01:03 <sawrubh|ib> or rather I'll just answer on the bug
13:08:23 <clokep> sawrubh|ib: I'm going out for a few hours.
13:16:01 --> Mic has joined #instantbird
13:16:01 * ChanServ sets mode +o Mic 
13:18:14 <-- iamjayakumars has quit (Client exited)
13:24:45 <mayanktg> Mic: are you reviewing the patch? I'm moving ahead with adding an interface to create an offer. I had a brief conversation with aleth regarding how to add it. http://log.bezut.info/instantbird/140607/#m441
13:25:55 <Mic> Currently I'm trying to solve my build problem.
13:28:28 --> iamjayakumars has joined #instantbird
13:28:58 <mayanktg> Ok. :)
13:29:39 --> gerard-majax_ has joined #instantbird
13:39:05 --> jb has joined #instantbird
13:41:53 <-- iamjayakumars has quit (Client exited)
13:45:34 --> iamjayakumars has joined #instantbird
13:55:04 <-- jb has quit (Ping timeout)
14:01:08 <-- iamjayakumars has quit (Client exited)
14:10:33 --> iamjayakumars has joined #instantbird
14:17:05 <Mic> My build is way past the point where it failed last time :)
14:17:09 * Mic is keeping his fingers crossed.
14:17:18 <sawrubh|ib> did you do anything special?
14:18:04 <mayanktg> yay..  :)
14:18:57 * mayanktg 's bug depends on Mic's build :P
14:19:07 <-- iamjayakumars has quit (Client exited)
14:19:54 <-- Tonnes has quit (Connection reset by peer)
14:21:14 --> Rym has joined #instantbird
14:22:31 --> Tonnes has joined #instantbird
14:25:51 <-- Rym has quit (Ping timeout)
14:27:04 --> Rym has joined #instantbird
14:40:54 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
14:43:33 --> Mic has joined #instantbird
14:43:34 * ChanServ sets mode +o Mic 
14:43:51 <Mic> :)
14:43:55 <Mic> The build finished and I took a user icon with the cam :)
14:44:31 <Mic> I still wonder what these problems were.
14:44:45 <nhnt11> :)
14:50:50 <mayanktg> :)
14:51:25 <mayanktg> Did it work properly?
14:52:09 <Mic> There are styling issues on Windows but that was to be expected (imo)
14:52:49 <mayanktg> Ok. How will I fix that? :-o
14:54:40 <Mic> I've taken a number of screenshots, that will help to identify the problems.
14:56:03 <mayanktg> great..thanks :) . I will need to write separate css for the two OS. right? 
14:57:49 <Mic> Yes, it looks like you'll need to change at least some of the rules.
14:58:23 <Mic> We don't have separate files for the different OS' but use IFDEFs inside the CSS files to include OS dependent changes.
14:58:40 <Mic> The tabbrowser styles are an exception afaik.
14:59:40 <Mic> Coffee with family now, bbl
15:00:09 <mayanktg> yes. I know how the IFDEF works. aleth taught me as I recall. ;)
15:00:17 <mayanktg> Yep..me too. bbl
15:00:37 <nhnt11> mmm, coffee
15:01:23 <-- Mic has quit (Ping timeout)
15:04:27 --> Mic has joined #instantbird
15:04:28 * ChanServ sets mode +o Mic 
15:08:25 <-- BWMerlin has quit (Quit: BWMerlin)
15:11:20 <-- Rym has quit (Ping timeout)
15:11:26 --> aleth has joined #instantbird
15:11:26 * ChanServ sets mode +o aleth 
15:12:29 --> Rym has joined #instantbird
15:21:10 <-- Fallen|away has quit (Ping timeout)
15:26:44 <-- aleth has quit (Ping timeout)
15:27:03 --> aleth has joined #instantbird
15:27:03 * ChanServ sets mode +o aleth 
15:29:02 <-- aleth has quit (Ping timeout)
15:29:31 --> aleth has joined #instantbird
15:29:31 * ChanServ sets mode +o aleth 
15:30:44 --> mpmc has joined #instantbird
15:31:09 <-- sawrubh|ib has quit (Ping timeout)
15:32:22 --> sawrubh|ib has joined #instantbird
15:37:58 --> Fallen|away has joined #instantbird
15:52:59 <-- Rym has quit (Ping timeout)
15:54:05 --> Rym has joined #instantbird
15:54:37 --> iamjayakumars has joined #instantbird
15:58:00 <-- Mic has quit (Ping timeout)
16:05:06 <aleth> mayanktg: Got your offer working yet?
16:05:11 <mayanktg> aleth: There? I've added the video call button. To create an offer I need a DOMWindow so I'll have to define the function inside the conversation.xml binding only. 
16:05:39 <aleth> Sure, that'll be in the onclick event handler of the button
16:05:45 <aleth> At least for now.
16:06:07 <mayanktg> ok
16:06:46 <mayanktg> Should I create a separate patch for this or include it with the current work?
16:06:55 <aleth> Keep it separate.
16:07:50 <aleth> It'll make it easier to work on, and in the end when you polish this up from a WIP to something that can land you can then still rearrange the parts as seems best.
16:09:31 <mayanktg> Hmm..Ok. I'll post a pastebin after separating then. Until now what I've done is.... 
16:09:47 <mayanktg> 1. defined three methods: initPeerConnection, getVideo and startCall .
16:09:51 <aleth> Oh, if you've kept it together, keep it that way. Don't rearrange now.
16:10:01 <aleth> Right now your goal is to get a working WIP ;)
16:10:26 <mayanktg> 2. created a video call button near the target switcher
16:10:40 <mayanktg> 3. defined an interface at prplConversation.idl 
16:10:46 <mayanktg> What should be my next step?
16:10:53 <aleth> Can you show me the interface diff?
16:10:59 <mayanktg> yes..
16:14:19 <mayanktg> aleth: http://pastebin.instantbird.com/732247 I used some of flo's prev work for the methods.
16:15:07 <aleth> The offer you are passing, what's that going to be? The SDP?
16:15:22 <mayanktg> Yes.
16:16:40 <aleth> Move the method to the interface for prplIConvIM (in the same file) because you don't want it to be available for MUCs ;)
16:17:28 <aleth> (as you can see in http://mxr.mozilla.org/comm-central/source/chat/components/public/prplIConversation.idl#70, that inherits from prplIConversation, but is more specific)
16:18:37 <aleth> Then you have to give a new uuid of the interface (you have to do this whenever you change an interface). You can get a fresh uuid by running "mach uuid"
16:18:43 <mayanktg> ok.
16:19:31 <aleth> Then show me the diff again ;)
16:19:36 --> Mic has joined #instantbird
16:19:36 * ChanServ sets mode +o Mic 
16:19:45 <mayanktg> Everytime I change an iterface content a new uuid should be generated. ok!
16:20:51 <Mic> mayanktg: yes, instantbot has a command that will generate one for you.
16:21:36 <mayanktg> Mic: I remember seeing that... uuid
16:21:47 <mayanktg> How to use that?
16:21:48 <mayanktg> :P
16:22:19 <mayanktg> Though I've already generated one using mach
16:25:20 <mayanktg> aleth: moved to prplConvIM http://pastebin.instantbird.com/732248
16:25:48 <aleth> OK, now you have to do a mach build to pick up the changes.
16:26:01 <mayanktg> Ok.
16:26:21 <mayanktg> and after that?
16:27:02 <aleth> For every prplConvIM in the codebase, you have to add this new method you've added to the interface ;)
16:27:25 <aleth> That means adding it to jsProtoHelper (which is the default implementation for all the JS prpls)
16:29:58 <aleth> All the JS prpls inherit from there.
16:30:02 <sawrubh|ib> aleth: o/
16:30:04 <aleth> http://dxr.mozilla.org/comm-central/source/chat/modules/jsProtoHelper.jsm#502
16:30:34 <mayanktg> Ok. Thanks I was searching for that. 
16:31:37 <aleth> Your default implementation should |throw Cr.NS_ERROR_NOT_IMPLEMENTED; | ... because you're only going to implement it for XMPP at the moment, but your new method will exist for all protocols.
16:32:35 <aleth> When you have done that and you can build without errors, you can move on to actually writing the implementation for XMPP (in xmpp.jsm)
16:35:21 <mayanktg> aleth: Ok. I'm going for it. By the way is the argument type for the startCall() correct? because we are returning an array ?
16:35:38 <mayanktg> I'm not sure about it :-/
16:35:41 <aleth> Well right now you are returning nothing at all (void)
16:35:53 <aleth> That seems OK to me, you can always change it if you need to return something.
16:36:02 <aleth> What would you want to return?
16:37:30 <mayanktg> ahh..its ok. The offer packet created is a string 
16:37:53 <aleth> Yeah, you pass the string to the protocol code. Which then makes a stanza out of it and sends it and so on
16:39:35 <sawrubh|ib> aleth: I don't think it makes too much sense right now to combine the Applications and File transfers pane because we still don't handle the download of files internally yet
16:40:12 <aleth> sawrubh|ib: That's OK, I just wondered whether you had discussed it with clokep.
16:40:14 <mayanktg> Yepp.. I'm adding it to jsProtoHelper then. 
16:40:46 <aleth> mayanktg: Do you understand what you're doing with all this interface stuff? Make sure to ask early if not.
16:42:48 <mayanktg> aleth: We are providing a way/interface so that the protocols and the UI could interact? 
16:43:41 <aleth> Right, the interface defines what properties and methods consumers like the UI can access.
16:46:00 <aleth> So after your change, all IM conversation objects have to have a new startCall method...
16:47:21 <sawrubh|ib> aleth: also in theming, Mac and Windows use sprites (and also effects on hover), for the time being can I just use the attachments icon and have no hover effects
16:48:00 <-- aleth has quit (Quit: exit stage left)
16:48:06 --> aleth has joined #instantbird
16:48:07 * ChanServ sets mode +o aleth 
16:48:55 <aleth> sawrubh: I don't know exactly what you're talking about
16:49:02 <mayanktg> aleth: Ok. I should define the method inside the jsProtoHelper as |startCall: funtion(aOffer) {....}| ?
16:49:28 <aleth> mayanktg: right, and make it throw as I said ;)
16:52:08 <aleth> sawrubh: Do you mean that paperclip icon?
16:52:16 <sawrubh> Yes
16:52:25 <aleth> I don't see any hover effect on OSX
16:54:20 <aleth> Anyway, I wouldn't worry about it too much for now, as long as it looks like the other pref icons. We'll eventually want a different icon there anyway I guess
16:54:34 <sawrubh> I see two rows of icons in the sprite
16:54:40 <-- iamjayakumars has quit (Quit: )
16:54:47 <mayanktg> aleth: Ok. I have added a throw inside the function. Now I can go for the build. right?
16:55:04 <mayanktg> |startCall: function(aOffer) { throw Cr.NS_ERROR_NOT_IMPLEMENTED; }|
16:55:25 <aleth> Yes
16:55:43 <Mic> mayanktg: here's how it looks on Win 7 at the moment: http://i.imgur.com/ptDZfBV.png
16:56:11 <Mic> I think my build hasn't picked up the new icons, so it's missing the webcam, open file and default user icon at the moment.
16:56:20 <mayanktg> Mic: I icons didn't show
16:56:25 <mayanktg> :'(
16:57:01 <aleth> But the build and the webcam is working :)
16:57:19 <clokep> aleth, sawrubh|ib: I don't really see how it's related that we don't handle the download of files right now.
16:58:24 <aleth> clokep: So has the desired preference pane UI for this been discussed or not? I sort of assumed it had happened ages ago :-/
16:58:36 <clokep> aleth: It had not been discussed at all.
16:59:09 <sawrubh> I was just replicating what made sense from the TB's pane
16:59:22 <mayanktg> * the bottom margin for the panel-2,3 should be corrected. * The remove icon button should have more spacing from the border.
16:59:33 <clokep> sawrubh: Replicating it would be combining them, wouldn't it?
16:59:51 <aleth> So currently the Applications pane in IB, if I understand correctly, determines what happens when we click on links in conversations.
17:00:32 <Mic> mayanktg: the borders of the buttons need tweaking too.
17:01:05 <clokep> Yes, it does.
17:01:08 <sawrubh> clokep: so the incoming tab (the one I haven't replicated) handles where you save the attachments which is equivalent to where we save the file that's sent
17:01:29 <aleth> Mic: Would linux/win/osx specific theme files make sense here?
17:01:40 <aleth> i.e. how much of the CSS differs?
17:01:45 <sawrubh> Since we're not handling file download internally inside IB (the user saves the FileLink) in a browser O thought it didn't make much sense right nkwy
17:01:45 <clokep> sawrubh: Hm...I thought it matched the applications tab?
17:02:10 <aleth> clokep: Have a look at TB, I only realized yesterday it doesn't have an Applications tab ;)
17:02:12 <mayanktg> Mic: yes..I'll do that :)
17:02:28 <clokep> sawrubh, aleth: Yeah OK. I think someone confused me at some point.
17:02:38 <clokep> sawrubh: It being separate certainly makes sense.
17:03:23 <mayanktg> aleth: The build was successful. :)
17:03:54 <aleth> clokep: The confusion we've both had comes from the fact that TB has an Attachments pane... for which the code is in applications.xul... because the Incoming panel in the Attachments pane is basically Applications in IB
17:04:46 <aleth> mayanktg: good :) Then you can write a more interesting startCall in xmpp.jsm now (it will override the default from jsProtoHelper)
17:06:05 <mayanktg> aleth: Ok. I have understood it. :)
17:06:43 <aleth> If you're not sure where to put it in xmpp.jsm, look for the object which inherits from the object you added the default to in jsProtoHelper.
17:11:31 <-- nhnt11 has quit (Ping timeout)
17:12:22 --> nhnt11 has joined #instantbird
17:13:54 <-- aleth has quit (Ping timeout)
17:14:57 --> aleth has joined #instantbird
17:14:57 * ChanServ sets mode +o aleth 
17:18:26 --> mconley has joined #instantbird
17:21:45 <-- nhnt11 has quit (Ping timeout)
17:22:58 <-- sawrubh|ib has quit (Ping timeout)
17:23:49 --> sawrubh|ib has joined #instantbird
17:28:39 <sawrubh|ib> aleth: btw even without calling addAcountDialog.accountTypeSelected it seems to be working, also suppose a 'select' event is fired before onInit has been called, will that event be ignored?
17:29:34 <aleth> "seems to be working" doesn't fill me with confidence because after all, that event handler is probably there for a reason ;)
17:30:03 <aleth> Yes, if a select event fires (and it does) before onInit is called, the default select handler of the menulist will handle it.
17:30:37 <aleth> So it's not ignored.
17:32:12 <sawrubh|ib> I still don't get why I need to call addAcountDialog.accountTypeSelected explicitly at the end of onInit 
17:32:25 <aleth> Do you understand the change you are making here?
17:32:30 <aleth> What's it trying to accomplish?
17:32:40 <sawrubh|ib> before onInit gets called once, the default handler keeps on handling select events
17:32:58 <sawrubh|ib> once onInit gets called, we make sure future select events are handler by accountTypeSelected
17:33:00 <aleth> The default select handler of the menulist will also handle it even after your new handler is added, unless your new handler calls event.preventDefault
17:33:37 <sawrubh|ib> yeah, I need to add that and also event.stopPropagation() I guess
17:33:45 <sawrubh|ib> to stop the event from going any further
17:33:46 <aleth> No you don't want to add that.
17:34:03 <aleth> Why would you not want the default menulist select handler to run?
17:34:26 <aleth> You just want *additional* things to happen.
17:34:45 <sawrubh|ib> hmm
17:35:35 <aleth> The problem was the additional handler was being called before onInit and that was a bug.
17:39:08 <aleth> (Of course it's possible there isn't a default handler at all, but my point is you don't need to worry about it)
17:39:34 <sawrubh|ib> ok, so in the case of the conversation.xml's browser and textbox, I'm calling cancelEvent (which calls preventDefault and stopPropagation) in the drop event, should I not do that. I mean canceling the ondragenter and ondragover events is required to make something a valid drop target
17:39:56 <sawrubh|ib> but I guess cancelling the 'drop' event isn't necessary
17:40:15 <aleth> It's different for the drag events because in that case the default handler disallows dropping
17:41:33 <aleth> yeah, you don't need it for drop.
17:42:26 <sawrubh|ib> so I'll stop calling cancelEvent inside my drop handler then
17:42:41 <-- mconley has quit (Input/output error)
17:42:44 <aleth> Yes, shouldn't make any difference.
17:43:14 <sawrubh|ib> and how did you find out the behavior of the default handler in case of select and drop events, https://developer.mozilla.org/en-US/docs/Web/Reference/Events/drop doesn't seem to say anything about it
17:43:40 <sawrubh|ib> it just says 'Varies'
17:44:00 <aleth> https://developer.mozilla.org/en-US/docs/DragDrop/Drag_and_Drop
17:44:21 <aleth> Heh, "varies" isn't that informative :P
17:44:25 --> nhnt11 has joined #instantbird
17:45:51 <sawrubh|ib> also default handler of select is none (https://developer.mozilla.org/en-US/docs/Web/Reference/Events/select) so calling preventDefault wouldn't have done anything
17:46:06 <sawrubh|ib> although I won't call it still :)
17:46:23 <aleth> What I'm trying to explain is that you should only call it if you have reason to ;)
17:47:06 <aleth> The reason events are generally not cancelled is that the whole point of the bubbling system is that multiple things can happen in response to the same event, as it bubbles up the DOM tree.
17:48:13 <aleth> This should clarify things: https://developer.mozilla.org/en-US/docs/XUL_Event_Propagation
17:54:40 <-- Rym has quit (Ping timeout)
17:55:44 <-- mayanktg has quit (Ping timeout)
17:55:45 --> Rym has joined #instantbird
18:04:25 --> mayanktg has joined #instantbird
18:05:03 <sawrubh|ib> aleth: what should I call it if not messenger.* ?
18:05:14 <sawrubh|ib> re the name of the preference
18:05:54 <aleth> sawrubh|ib: Ignore that comment, I didn't notice all-instantbird.js is full of messenger.* prefs.
18:05:59 <aleth> Sorry.
18:06:25 <Mic> mayanktg: the problem with the missing icons is that they aren't packaged for "aero" in the themes jar.mn.
18:07:05 <sawrubh|ib> Mic: that seems to be answeing my question :)
18:07:22 <Mic> sawrubh|ib: hmm, sorry? Which question?
18:07:31 <mayanktg> Mic: Oh ok. I'll add it now. 
18:08:16 <Mic> Or take atleast a note that you remember how to fix that if you're busy with something else..
18:09:23 <sawrubh|ib> Mic: that one needs to add the name of all the normal Windows resource under the aero section too in the jar.mn's for it to be packaged
18:09:33 <mayanktg> OK. I'm doing that. I'll work on the user icon bug later today after I've written the function for create offer.
18:14:31 <instantbot> ryanvm@gmail.com changed the Resolution on bug 1021362 from --- to FIXED.
18:14:33 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1021362 nor, --, ---, nhnt11, RESO FIXED, /msg  foo tries to send the message "foo" to a blank nick
18:18:16 <nhnt11> aleth: I'm taking a look at your comments here: https://bugzilla.mozilla.org/show_bug.cgi?id=955292#c44
18:18:18 <instantbot> Bug 955292 enh, --, ---, nhnt11, ASSI, Read/write chat logs asynchronously
18:18:40 <nhnt11> "Looks like we're just testing edge cases" Those are really the only cases where encodeName does anything
18:18:53 <nhnt11> (Or am I supposed to make sure of that)
18:19:00 <aleth> Yes, but it's also good to have one or two standard examples just to make sure they are not broken.
18:19:08 <aleth> Right.
18:19:51 <-- Rym has quit (Ping timeout)
18:21:02 --> Rym has joined #instantbird
18:22:07 <nhnt11> aleth: yield p2.then(() => ok(false), () => ok(true)); Interesting :)
18:23:21 <-- Rym has quit (Ping timeout)
18:23:30 <mayanktg> aleth: I've added the startCall() in |XMPPAccountPrototype| . I'm confused over what should I write inside the funtion. :-/ I have already defined the startCall method inside conversation.xml binding.
18:23:48 --> Rym has joined #instantbird
18:23:49 <aleth> mayanktg: Why are you adding it to the account prototype? 
18:23:55 <sawrubh|ib> aleth: why should cancelEvent return true or false?
18:24:03 <aleth> You didn't add it to the account interface, after all.
18:24:41 --> mconley has joined #instantbird
18:25:36 <aleth> sawrubh|ib: It's a standard thing for event handlers. Not needed here according to https://developer.mozilla.org/en-US/docs/DragDrop/Drag_Operations#droptargets (but note it is mentioned as an option)
18:26:18 <aleth> mayanktg: Your startCall method in conversation.xml can't do anything XMPP-related.
18:26:19 <Mic> mayanktg: what interface change did you make?
18:26:28 <mayanktg> aleth: Ok. I found that the |typingState| has been called there. That's why I added it to |XMPPAccountPrototype|.
18:26:41 <aleth> mayanktg: That's not the way you find out where to add it ;)
18:26:58 <Mic> And how translates this interface change to the the actual implementation in a protocol plugin?
18:28:02 <aleth> You changed the prplIConvIM interface. That's implemented by GenericConvIMPrototype here. http://dxr.mozilla.org/comm-central/source/chat/modules/jsProtoHelper.jsm#502
18:28:03 <mayanktg> Mic: I have added a startCall() to the interface which is called when the user requests for a call. i.e. mekes an SDP offer.
18:28:23 <aleth> Now you have to find out what in xmpp.jsm extends GenericConvIMPrototype. That's where you need to add it.
18:28:35 <Mic> The question is which interface is "the interface"...
18:30:35 <mayanktg> Mic: purplConversation
18:31:15 <mayanktg> sry prplIConvIM
18:32:52 <Mic> aleth pointed you to the implementation in jsProtoHelper. You now need to find where that is used in XMPP code and extend it there...
18:33:42 <mayanktg> aleth: Ok. I have to add it to  |XMPPConversationPrototype|. 
18:33:51 <aleth> That sounds more like it ;)
18:35:38 <mayanktg> Done.
18:45:34 <-- Rym has quit (Ping timeout)
18:45:52 --> Rym has joined #instantbird
18:51:24 <-- Rym has quit (Ping timeout)
18:51:42 --> Rym has joined #instantbird
18:51:53 <sawrubh|ib> clokep: I had gone through http://dxr.mozilla.org/comm-central/search?q=passwordPrompt&case=true before removing and from what it seemed, passwordPrompt wasn't required by any other file
18:52:05 <clokep> Alright.
18:53:07 <sawrubh|ib> also is it clear now why that menulist and addEventListener change was required ?
18:53:31 <sawrubh|ib> (it was to fix that onInit and addAccountTypeSelected issue)
18:56:24 <aleth> sawrubh|ib: Generally if you're asked questions in the bug,  you should also put answers there, for future reference.
18:58:59 <aleth> mayanktg: Are you clear on what to do next?
19:01:02 <mayanktg> aleth: No. I'm trying to figure that out.
19:01:15 <mayanktg> The function can now be accessed from the conversation binding.
19:02:13 <aleth> Right, you can call it from there with the offer sdp string.
19:06:27 <nhnt11> For the record: We were discussing in #chatdev about implementing CTCP TIME for IRC to view people's local time
19:07:14 <Mic> I fear it will be totally undefined what clients are allowed to return as time (string).
19:07:50 <nhnt11> Ah, there's a bug filed for this already, by Mic ;)
19:07:57 <nhnt11> bug 955448
19:07:59 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955448 min, --, ---, nobody, NEW, Change behavior of /time command
19:08:05 <Mic> lol
19:08:10 <Mic> I should have known :P
19:08:20 <nhnt11> Seems like we just need to alias |/time nick| to |/ctcp nick TIME|
19:08:21 <nhnt11> :)
19:08:41 <Mic> If in doubt then assume that I have already filed a bug for it long ago ;)
19:08:59 <nhnt11> Almost a year ago..
19:09:23 <nhnt11> By the way, /ctcp <nick> TIME works fine right now
19:09:26 <aleth> It's unfortunate the BMO move broke Mic's perfect recall of BIO bug numbers ;)
19:09:59 <sawrubh|ib> nhnt11: we can literally call it 'For the record' when we talk here
19:10:15 <nhnt11> sawrubh|ib: That kind-of-a-pun was intended, yeah :)
19:10:28 <clokep> We already handle time, the command for it is just broken / not implemented https://mxr.mozilla.org/comm-central/source/chat/protocols/irc/ircCTCP.jsm#166
19:12:12 <Mic> aleth, clokep: should we attempt to parse the returned value and discard nonsensical values?
19:12:32 <clokep> Mic: We have no idea what the return format is.
19:12:49 <Mic> "21:07:13 - Mic: I fear it will be totally undefined what clients are allowed to return as time (string)."
19:12:52 <Mic> ;)
19:13:20 <clokep> Mic: https://hg.mozilla.org/comm-central/rev/54e04eabf28d
19:13:27 <nhnt11> Looks like IRCCloud sends the time in GMT
19:13:40 <nhnt11> Which is useless..
19:13:43 <nhnt11> Doesn't send the timezone
19:14:06 <nhnt11> Well that's not too surprising i guess
19:15:00 <nhnt11> Good night
19:15:10 <clokep> Yeah.
19:17:05 <Mic> bbl
19:17:09 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
19:21:56 <sawrubh|ib> clokep: re the removal of strings from composeMsgs.properties, you wanted to discuss if we want to have the same strings in IB or not
19:24:55 <-- mconley has quit (Ping timeout)
19:24:55 <-- sawrubh|ib has quit (Connection reset by peer)
19:27:03 --> sawrubh|ib has joined #instantbird
19:27:07 <clokep> sawrubh|ib: I was asking how they're used, yes.
19:28:35 <sawrubh|ib> they are used by the listener which handles the various failure events in uploading to FileLink and then shows a prompt
19:28:48 <clokep> Shows a prompt?
19:28:52 <clokep> It looked to me like it just does Cu.reportError
19:28:55 <sawrubh|ib> I was using those strings to show the same error cases but I instead throw it to the error console
19:29:05 <sawrubh|ib> I was talking about what TB does :)
19:29:10 <aleth> mayanktg: How's it going?
19:29:25 <clokep> Alright.
19:30:27 <sawrubh|ib> so what we could do is add a notificationbox for showing the errors as well when you drop the file in the window and it'll let you allow you to choose whether to upload and your provider
19:31:20 <sawrubh|ib> but I didn't implement it yet because I thought we might shift to showing a prompt or something else besides notificationbox once protocol support for file transfer lands
19:32:57 <mayanktg> aleth: I've added an onclick handler to the video call button. Which calls the startCall(). But I'm unable to understand how it will pass the offer to the sdp2xml(). Wait I'll figure this out :-|
19:33:07 --> mconley has joined #instantbird
19:33:24 <aleth> Your conversation.xml startCall has to call the XMPP startcall with the offer
19:33:48 <mayanktg> aleth: Does it make sense?
19:33:50 <mayanktg> Ok
19:34:38 <aleth> The basic principle is to do in conversarion.xml the stuff that requires a DOMWindow, and in the prpl everything else.
19:34:57 <clokep> So it's odd to me cause you seem to have done half the work for something -- moving the strings, but not adding the UI.
19:35:02 <clokep> I think we should add the notification box for now.
19:39:02 <mayanktg> aleth: Yes. I call the startCall() with a call offer and then do the rest in the xmpp.jsm. 
19:40:57 <aleth> mayanktg: Do you know how to do that?
19:41:33 <mayanktg> clokep: We wanted to have discussion with Mic regarding how he would like the notifications to appear. Ok. The next step will be to add notification box. 
19:41:58 <aleth> mayanktg: I think clokep is talking to sawrubh|ib not you ;)
19:42:32 <mayanktg> aleth: ohh..we both have to implement notificationbox :-/
19:42:41 <sawrubh|ib> too many people using notificationboxes
19:42:42 <mayanktg> clokep: sorry 
19:43:56 <mayanktg> aleth: I have to send the offer using |this._conv.startCall(offer.sdp)| to the prpl. and from there I'll call the sdp2xml() which converts this offer to xml.
19:43:58 <aleth> mayanktg: Yes, but you have to send your stanza first before you get to respond to it ;)
19:45:15 <mayanktg> Yeah 
19:46:24 <aleth> mayanktg: That sounds like a good plan.
19:47:54 <mayanktg> ok. :)
19:50:04 --> sonny has joined #instantbird
19:55:18 <-- Rym has quit (Ping timeout)
19:56:30 <-- aleth has quit (Quit: exit stage left)
20:03:11 <sawrubh|ib> is http://i.imgur.com/Nh6AWQY.png a bug? I mean I expect it to say 'Armada aleth alexis left' or something, instead it just states their names
20:03:53 <-- sonny has quit (Ping timeout)
20:04:18 <sawrubh|ib> ..or I guess I'm supposed to figure out their state from the color, instead of it actually writing
20:04:39 <sawrubh|ib> it conveyed that two of them either joined/reconnected and aleth left based on their colors
20:04:49 --> Rym has joined #instantbird
20:05:57 <nhnt11> sawrubh|ib: That's most likely a tab complete thing
20:06:02 <nhnt11> Type "a" and press tab
20:06:35 <nhnt11> (Those aren't "left" messages)
20:06:41 <-- Rym has quit (Ping timeout)
20:09:15 --> Rym has joined #instantbird
20:18:52 --> EionRobb has joined #instantbird
20:19:54 <-- Rym has quit (Ping timeout)
20:24:37 <-- sawrubh|ib has quit (Ping timeout)
20:27:06 <-- clokep has quit (Ping timeout)
20:31:12 --> jb has joined #instantbird
20:33:47 <-- jb has quit (Ping timeout)
20:36:09 --> Rym has joined #instantbird
20:37:55 <-- Rym has quit (Ping timeout)
20:38:59 --> sawrubh|ib has joined #instantbird
20:40:32 <-- sawrubh|ib has quit (Connection reset by peer)
20:40:37 --> Rym has joined #instantbird
20:47:06 --> clokep has joined #instantbird
20:47:06 * ChanServ sets mode +o clokep 
20:50:44 --> sawrubh|ib has joined #instantbird
21:08:17 --> chrisccoulson has joined #instantbird
21:10:08 <-- Rym has quit (Ping timeout)
21:10:33 --> Rym has joined #instantbird
21:16:29 <-- Rym has quit (Ping timeout)
21:16:47 --> Rym has joined #instantbird
21:28:33 <-- Rym has quit (Ping timeout)
21:29:58 --> Rym has joined #instantbird
21:31:53 <-- Rym has quit (Quit: WeeChat 0.4.3)
21:31:59 --> Rym has joined #instantbird
21:36:35 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:42:43 <-- mconley has quit (Ping timeout)
21:49:26 <-- gerard-majax_ has quit (Ping timeout)
22:01:19 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:02:45 <clokep> sawrubh|ib: http://dxr.mozilla.org/comm-central/search?q=regexp%3ApasswordPrompt\b&case=true&redirect=true
22:06:55 <-- sawrubh|ib has quit (Quit: sawrubh|ib)
22:07:46 <sawrubh> clokep: yeah, what about it?
22:07:57 <clokep> Just a better search. ;)
22:08:21 <sawrubh> Ah, I thought you were saying you found a file :)
22:08:47 <clokep> I just like regular expressions.
22:09:01 <sawrubh> I'm gonna sleep, I'll do the notificationbox thingy tomorrow
22:09:22 <sawrubh> I just hope this patch doesn't get delayed after that :)
22:09:43 <clokep> Well these changes should all be in the Instantbird patch now, which we haven't put much work into yet. ;)
22:09:46 <-- Rym has quit (Ping timeout)
22:09:49 <clokep> I'll try to test your current patches tomorrow.
22:10:04 --> Rym has joined #instantbird
22:10:23 <sawrubh> You mean the second smaller patch?
22:10:57 <sawrubh> Yeah, I'm keeping all the changes related to drag and drop and it's interaction there
22:11:26 * sawrubh wonders what you mean by much work
22:11:33 <clokep> Yep. :)
22:13:00 <sawrubh> Is there things left besides this notification box which you feel should be part of this bug fix?
22:14:09 <sawrubh> I could probably improve the feedback when you're dragging the file onto the window to indicate which areas are drop targets
22:14:47 <sawrubh> Right now one doesn't get any signs about which are the drop targets
22:17:34 <clokep> sawrubh: Initially I think as long as we have a way to tell the user something failed and when it completed that's OK.
22:17:40 <clokep> Other stuff can be done in a follow up.
22:19:22 <-- Rym has quit (Ping timeout)
22:21:48 --> Mic has joined #instantbird
22:21:48 * ChanServ sets mode +o Mic 
22:23:45 <clokep> sawrubh: btw we can start the TB review (i.e. the moving of the cloudfile stuff) before the UI / notificationbar stuff for IB is finished.
22:25:05 --> Rym has joined #instantbird
22:27:55 <Mic> mayanktg: no "onclick"s please. You most likely want "oncommand" in most cases...
22:29:15 <EionRobb> my mouse makes a "clonk" noise when I press the button. can you change it to onclonk
22:30:19 <clokep> EionRobb: HTML5 added "clonk" to the set of things that count as "command", so you're all set.
22:30:28 <clokep> (It also added "whir" and "whosh")
22:30:28 <EionRobb> perfect
22:33:19 <Mic> Cool, "swish" and "flick" too?
22:33:40 <EionRobb> "thump" would also be nice
22:34:08 <clokep> Mic: I don't think wands are input devices yet.
22:34:20 <Mic> Haha, you understood ;)
22:43:31 <-- Rym has quit (Ping timeout)
22:43:49 --> Rym has joined #instantbird
22:50:48 --> qheaden has joined #instantbird
22:50:52 <qheaden> Hello
22:51:10 <qheaden> clokep: ping
22:51:32 --> gerard-majax_ has joined #instantbird
22:52:07 <clokep> qheaden: pong-ish
22:52:17 <qheaden> :P
22:52:25 <clokep> Tacos....
22:52:38 <qheaden> clokep: I was wondering if you mind me inviting you to a Yahoo conference?
22:52:47 <clokep> k
22:52:59 <clokep> im on js yahoo
22:53:29 <qheaden> Hmm. Come to think of it, you would need my new patch for this to work.
22:53:51 <clokep> I can use libpurple
22:53:56 <qheaden> Okay.
22:54:25 <qheaden> EionRobb: ping
22:54:50 <-- gerard-majax_ has quit (Ping timeout)
22:54:52 <clokep> qheaden: Is that a "no" then?
22:55:06 <qheaden> clokep: No. libpurple is fine.
22:55:15 <-- Rym has quit (Ping timeout)
22:55:19 <qheaden> I was just trying to get EionRobb's attention for a multi-person chat.
22:55:19 <clokep> Let me restart.
22:55:26 <clokep> Mic: is here too
22:55:27 <qheaden> I will just sign into multiple accounts.
22:55:41 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:55:45 --> clokep has joined #instantbird
22:55:46 * ChanServ sets mode +o clokep 
22:55:50 <EionRobb> qheaden: hi
22:56:08 <qheaden> EionRobb: Hey there! Would you mind helping me and clokep test my fixes to the Yahoo group chat?
22:56:08 <clokep> qheaden: OK.
22:56:24 --> Rym has joined #instantbird
22:56:26 <EionRobb> qheaden: only if I can do it while I complain about it
22:56:29 <qheaden> EionRobb: You probably want to use the libpurple version of Yahoo instead of the JS version, since you would need my patch for things to work.
22:56:35 <qheaden> :P
22:56:40 <EionRobb> qheaden: I would find it difficult to use the js version on Pidgin
22:56:48 <qheaden> Ahh okay. :P
22:56:51 <Mic> OK, I can join the conference too.
22:56:59 <qheaden> Mic: Cool.
22:57:00 <EionRobb> although, with the new seedjs plugin loader for libpurple 3......
22:57:25 <Mic> qheaden: brb
22:57:27 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
22:57:27 <qheaden> Give me a sec, I forgot I need to patch my home build of Ib. I patched the version on my work machine.
22:57:33 --> Mic has joined #instantbird
22:57:34 * ChanServ sets mode +o Mic 
22:58:36 <Mic> qheaden: OK, I connected my Yahoo! account.
22:58:40 <Mic> What do I have to do?
22:58:42 <qheaden> Okay
22:58:52 <qheaden> I will invite you to a conference. Give me a sec.
22:59:35 * EionRobb hands qheaden his only Sec
22:59:42 <qheaden> :P
23:00:26 <qheaden> Mic: What is your handle on Yahoo again? Is it just Mic?
23:00:39 * qheaden is trying to figure out which profile I added you guys as buddies under
23:01:59 <EionRobb> I might not be able to join the conf sorry, heading into a meeting
23:02:17 <qheaden> OKay. No problem.
23:07:14 --> mayanktg has joined #instantbird
23:10:28 <qheaden> clokep, Mic: I'm going to close the conversation on my end. Let me know if you see me sign off.
23:10:36 <Mic> OK
23:10:39 <qheaden> Well, log out of the conference.
23:10:45 <Mic> "01:10:30 - ibprpltest left the room."
23:10:50 <qheaden> Awesome.
23:11:15 <Mic> Wanna try again with us leaving first?
23:11:59 <qheaden> Mic: We don't have to. I've tested the leaving and joining stuff a couple of days ago. ;P
23:12:06 <Mic> OK, great.
23:12:15 <qheaden> I was just plagued by that issue where only the host could see everyone.
23:13:11 <mayanktg> Mic: http://pastebin.instantbird.com/732405 I'm able to create the offer inside the conversation binding. But I'm getting http://pastebin.instantbird.com/732416 this error. It means that I haven't implemented startCall() properly :-/ Could you please see where I'm making mistake?
23:13:51 <mayanktg> I have changed the uuid and performed |mach build| 3 times :-/
23:14:49 <mayanktg> And yes I'll use oncommand only :)
23:18:25 <-- Rym has quit (Ping timeout)
23:20:08 <Mic> mayanktg: was there a line number for this error?
23:21:40 <mayanktg> Yes. Line 350 ....means line 193 of the pastebin
23:22:06 <mayanktg> it is the |conv.startCall(offer.sdp)| 
23:22:37 <Mic> I think I'd put a dump/logging call into jsProtoHelper's startCall method and see if it's being run. I'd comment out the XMPP stuff for now.
23:23:04 <mayanktg> Ok. I'm trying that.
23:24:26 <Mic> Can you Cu.reportError(this._conv) on line 185 of you pastebin?
23:24:48 <Mic> Maybe that's rather what I'd start with instead...
23:26:25 <mayanktg> Ok. Using Cu.reportError at jsProtoHelper's startCall didn't give any error console message. I'm putting the Cu... at line 185 too
23:28:15 <Mic> Maybe you need to QueryInterface this object to a prplIConvIM (that's why I'm curious what the output on line 185 is going to be).
23:28:53 <mayanktg> Mic: it returns |[xpconnect wrapped (nsISupports, nsIClassInfo, imIConversation, prplIConversation, nsIObserver, prplIConvIM)]|
23:29:54 <Mic> QueryInterface that to prplIConvIM before using it for anything...
23:30:19 <mayanktg> Ok. 
23:30:43 <mayanktg> But why do I have to do that?
23:31:58 <Mic> To tell it to behave like a prplIConvIM does.
23:32:35 <Mic> The list is saying that it can do it. With QueryInterface you request an object that actually does...
23:33:43 <mayanktg> Okays. I'm searching for how to implement a QueryInterface
23:34:20 <Mic> No, you just need to call the method "QueryInterface" in the right way.
23:34:46 <Mic> Mxr "QueryInterface" and look if that makes clear what you need to do.
23:38:22 <Mic> Maybe read about QueryInterface on MDN too...
23:40:02 <mayanktg> Yes. I did a |QueryInterface(conv.startCall(offer.sdp))| . Didn't help. I'm giving a read on MDN
23:42:15 <Mic> Have you searched for QueryInterface with MXR?
23:42:29 <Mic> That's not the pattern that should have appeared in the results...
23:43:53 <mayanktg> I guess I have found how to do that
23:44:08 <mayanktg> http://mxr.mozilla.org/comm-central/source/chat/content/convbrowser.xml#158 ?
23:45:10 <Mic> Yes, like this.
23:46:00 --> BWMerlin has joined #instantbird
23:47:23 <mayanktg> Mic: |conv.startCall(offer.sdp).QueryInterface(Components.interfaces.prplIConvIM);| and I'm still getting the same error :-/
23:48:28 <Mic> let conv = this._conv.QueryInterface(...);
23:48:43 <Mic> Then use this object like you do (i.e. don't change anything).
23:50:26 <Mic> And make sure to read about QueryInterface again...
23:51:36 * qheaden is actually a bit disappointed at how small the Yahoo group chat patch was. :P
23:54:09 <mayanktg> Mic: I changed it to |let conv = this._conv.QueryInterface(Components.interfaces.prplIConvIM);| .I'm getting the same error. 
23:55:06 <mayanktg> Yes. I was giving it a read here https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsISupports#QueryInterface()