All times are UTC.
00:04:33 --> Rym has joined #instantbird 00:05:15 --> iamjayakumars has joined #instantbird 00:09:45 <-- Armada has quit (Connection reset by peer) 00:14:17 <-- iamjayakumars has quit (Quit: ) 00:29:39 --> mconley has joined #instantbird 00:39:50 <-- sonny has quit (Ping timeout) 00:51:34 <-- Rym has quit (Ping timeout) 00:52:39 --> Rym has joined #instantbird 00:55:00 <-- Rym has quit (Ping timeout) 00:56:15 --> Rym has joined #instantbird 00:58:39 <-- Rym has quit (Ping timeout) 00:59:00 --> Rym has joined #instantbird 01:04:22 <-- Rym has quit (Connection reset by peer) 01:05:17 --> Rym has joined #instantbird 01:07:52 <-- Rym has quit (Ping timeout) 01:09:14 --> Rym has joined #instantbird 01:11:17 <-- Rym has quit (Ping timeout) 01:16:29 --> Rym has joined #instantbird 01:23:43 <-- Rym has quit (Connection reset by peer) 01:24:50 --> Rym has joined #instantbird 01:44:51 --> arlolra has joined #instantbird 01:56:57 <-- Rym has quit (Ping timeout) 02:00:50 --> Rym has joined #instantbird 02:07:14 <-- Rym has quit (Connection reset by peer) 02:08:26 --> Rym has joined #instantbird 02:24:48 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 02:26:27 --> nhnt11-tb has joined #instantbird 02:26:34 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 02:26:39 --> nhnt11-tb has joined #instantbird 02:26:47 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 02:27:18 --> nhnt11-tb has joined #instantbird 02:27:38 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 02:31:03 --> nhnt11-tb has joined #instantbird 02:35:06 <-- nhnt11-tb has quit (Client exited) 02:35:11 --> nhnt11-tb has joined #instantbird 02:35:46 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 02:35:58 --> nhnt11-tb has joined #instantbird 02:36:10 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 02:36:30 <nhnt11> I'm very confused :( 02:36:50 <nhnt11> All this time I thought a block of code was never getting reached because I had a Components.utils.reportError() right above it 02:37:03 <nhnt11> Turns out it /is/ being reached but that reportError isn't working for some reason 02:37:10 <nhnt11> An alert right below it works fine :-/ 02:47:25 --> nhnt11-tb has joined #instantbird 02:47:43 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 02:47:49 --> nhnt11-tb has joined #instantbird 02:48:00 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 02:48:18 --> nhnt11-tb has joined #instantbird 02:48:25 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 02:49:15 --> nhnt11-tb has joined #instantbird 02:49:31 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 02:49:37 --> nhnt11-tb has joined #instantbird 02:50:12 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 02:50:22 --> nhnt11-tb has joined #instantbird 02:50:30 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 02:50:49 --> nhnt11-tb has joined #instantbird 02:51:00 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 02:51:22 --> nhnt11-tb has joined #instantbird 02:52:03 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 02:52:09 --> nhnt11-tb has joined #instantbird 02:52:45 <nhnt11> alert(Components) gives me |[object nsXPCComponents]|. alert(Object.keys(Components)) gives me an empty string 02:53:10 * nhnt11 guesses Components isn't available for some reason from an event handler callback :-/ 02:56:14 <-- nhnt11-tb has quit (Client exited) 02:57:37 * nhnt11 is probably never going to use Cu.reportError again 02:58:36 --> nhnt11-tb has joined #instantbird 02:58:48 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 03:02:15 --> nhnt11-tb has joined #instantbird 03:02:25 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 03:02:48 --> nhnt11-tb has joined #instantbird 03:03:03 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 03:03:20 --> nhnt11-tb has joined #instantbird 03:10:22 <-- nhnt11-tb has quit (Client exited) 03:10:27 --> nhnt11-tb has joined #instantbird 03:11:17 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 03:11:35 --> nhnt11-tb has joined #instantbird 03:12:06 <nhnt11> BAH 03:12:21 <nhnt11> javascript.options.showInConsole is false by default in Thunderbird 03:12:33 * nhnt11 bangs his head on his desk 03:14:45 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 03:15:15 <-- arlolra has quit (Quit: arlolra) 03:16:13 --> nhnt11-tb has joined #instantbird 03:16:23 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 03:19:41 --> nhnt11-tb has joined #instantbird 03:19:51 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 03:20:14 --> nhnt11-tb has joined #instantbird 03:20:28 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 03:20:39 --> nhnt11-tb has joined #instantbird 03:20:54 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 03:22:10 --> nhnt11-tb has joined #instantbird 03:22:43 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 03:23:20 --> nhnt11-tb has joined #instantbird 03:23:30 <nhnt11> \o/ 03:23:31 <nhnt11> FINALLHY 03:23:34 <nhnt11> finally* 03:23:35 <nhnt11> it works 03:24:23 <nhnt11> Turns out the problem was that since the interface was changed from returning an nsISimpleEnumerator to a promise, the return logs could no longer be iterated using fixIterator 03:24:52 <nhnt11> Changing the loop to a |while (this._logs.hasMoreElements()) let log = this._logs.getNext()| fixed everything 03:24:56 <-- nhnt11-tb has left #instantbird () 03:25:08 * nhnt11 can finally sleep now 03:25:22 --> nhnt11-tb has joined #instantbird 03:26:15 <-- nhnt11-tb has quit (Client exited) 03:28:01 --> nhnt11-tb has joined #instantbird 03:30:09 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 03:32:28 <nhnt11> flo-retina: I've attached a patch on the bug. Sorry this took so long :( 03:33:19 * nhnt11 goes to sleep 04:05:27 <-- mconley has quit (Input/output error) 04:31:30 --> mconley has joined #instantbird 04:48:30 --> EionRobb has joined #instantbird 04:54:05 --> mayanktg has joined #instantbird 04:56:14 --> jb has joined #instantbird 05:02:24 --> Mook has joined #instantbird 05:03:21 * Mook is now known as IRCMonkey16455 05:03:41 <-- IRCMonkey16455 has quit (Quit: IRCMonkey16455) 05:03:50 --> Mook1 has joined #instantbird 05:04:48 * Mook1 is now known as Mook 05:13:22 <-- mconley has quit (Input/output error) 05:25:25 <mayanktg> flo-retina: Hello :) .I'm trying to generate an SDP offer instead of a hardcoded one. How can I create one inside the xmpp-commands.jsm file? I'm getting |mozRTCPeerConnection is not defined| error. 05:56:27 <-- mayanktg has quit (Ping timeout) 06:08:42 --> sawrubh|ib has joined #instantbird 06:38:51 <flo-retina> mayanktg: you can't. 06:38:56 <flo-retina> you need a DOMWindow 06:39:03 <flo-retina> the SDP needs to be generated in the conversation.xml binding 06:39:10 <flo-retina> and you need to pass the SDP string to the prpl 07:06:49 <-- sawrubh|ib has quit (Ping timeout) 07:09:03 <-- jb has quit (Connection reset by peer) 07:09:06 --> jb1 has joined #instantbird 07:12:01 --> sawrubh|ib has joined #instantbird 07:18:39 <-- Rym has quit (Ping timeout) 07:20:45 <-- sawrubh|ib has quit (Connection reset by peer) 07:22:16 --> sawrubh|ib has joined #instantbird 07:24:49 <-- jb1 has quit (Ping timeout) 07:37:07 --> jb has joined #instantbird 07:50:14 <-- jb has quit (Ping timeout) 08:40:38 --> mayanktg has joined #instantbird 08:45:37 <-- sawrubh|ib has quit (Ping timeout) 08:46:28 --> sawrubh|ib has joined #instantbird 09:35:15 --> kramolnik has joined #instantbird 10:15:04 <-- kramolnik has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 10:22:05 <-- sawrubh|ib has quit (Ping timeout) 10:42:26 --> jb has joined #instantbird 10:44:41 --> kramolnik has joined #instantbird 10:59:06 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 10:59:11 --> nhnt11 has joined #instantbird 11:10:18 <mayanktg> nhnt11: Hi 11:12:21 <nhnt11> mayanktg: I'm just leaving to go watch xmen, sorry. Catch you later! 11:12:41 <mayanktg> nhnt11: Ahh :D have fun!! :) 11:19:15 <mayanktg> Can we call a method defined in a binding from another location outside the scope? 11:21:52 --> clokep has joined #instantbird 11:21:52 * ChanServ sets mode +o clokep 11:22:16 --> sawrubh|ib has joined #instantbird 11:22:17 <mayanktg> I have a method to create offer inside the conversation binding and I need to call this when /call command is executed..which is at xmpp-conversation.jsm. Here is the pastebin of the patch http://pastebin.instantbird.com/731461 (Line 66 - call command, Line 361- sendOffer method). 11:26:48 <clokep> mayanktg: Did you ever get your test working? 11:29:04 <mayanktg> clokep: No. Its failing. I'm unable to create the output,for which the test would pass. 11:29:21 <clokep> mayanktg: Then you shouldn't be moving on to trying to create the SDP yet. 11:29:54 <clokep> How is it failing? What's different? 11:31:20 <mayanktg> clokep: idk..I copy the whole iq stanza which is generated in the debug log of the caller's account and I paste it in the output string of the test. 11:31:58 <mayanktg> Then when I run the test, I get a test failed response. Wait I'll show you the diff in a min. 11:32:48 <clokep> mayanktg: Did you try to add some dump calls or something like that? 11:32:55 <clokep> It doesn't sound like you put any effort into debugging it. :-\ 11:34:35 <mayanktg> clokep: I tried hard. Yes I did put dump calls both in the sdp2xml file and in the tests.. 11:36:40 --> sonny has joined #instantbird 11:42:28 <-- EionRobb has quit (Quit: Leaving.) 11:42:42 <-- kramolnik has quit (Ping timeout) 11:45:15 <mayanktg> clokep: http://pastebin.instantbird.com/731484 it is the test patch. I'll try to figure out. 11:47:37 <mayanktg> Line 88 should have been |let offer = xmppJingle.jingle.sdp2xml(toJID, fromJID, inputString);| 11:48:01 --> rosonline has joined #instantbird 11:49:58 --> aleth_web has joined #instantbird 11:52:10 <-- sonny has quit (Ping timeout) 11:55:12 <aleth_web> nhnt11: http://log.bezut.info/instantbird/140607/#m75 I remember having the same heureka moment the first time I tried debugging something in TB... you get so used to having these prefs set ;) 11:57:44 <aleth_web> more like s/heureka/facepalm actually. 11:59:39 <mayanktg> clokep: The test is failing because |do_check_eq(offer, output)| is comparing between [object object] and "<iq......" 12:04:04 <flo-retina> mayanktg: and so? 12:06:04 <flo-retina> I'm also interested in details about "I tried hard.". I agree with clokep when he says "It doesn't sound like you put any effort into debugging it." 12:07:19 <mayanktg> flo-retina: I'll have to convert the offer obtained from sdp2xml into a string so that the offer and output can be compared. 12:07:43 <flo-retina> yes 12:08:12 <flo-retina> was that not included in "trying hard to debug it"? 12:09:07 <aleth_web> Note the debug logging code needs to do that too, so there is already a way to do that somewhere. 12:09:45 <mayanktg> no..I couldn't figure that out then. :-( 12:09:47 <flo-retina> aleth_web: the debug logging code may do some pretty printing 12:10:15 <flo-retina> aleth_web: but there's definitely the code that sends the data to the socket that converts the whole thing to a string ;) 12:10:38 <mayanktg> When I run the test I found that the input string I used is different from the string that's being generated in the offer 12:10:41 <aleth_web> heh, true :) 12:10:57 <aleth_web> How is it different? 12:12:41 <aleth_web> I think the offer will be an object too. JSON.stringify() is the generic way to turn objects into JSON strings... 12:12:46 <mayanktg> The offer generates an xml stanza, when we stringify it, it changes into the form of nodes and attributes. 12:13:03 <mayanktg> yes. The offer is an object. 12:14:05 <aleth_web> Yes, so you probably don't want to use JSON.stringify on the xml output 12:14:10 <aleth_web> Though you could. 12:14:20 <mayanktg> How else can I print the offer in the screen? 12:15:23 <aleth_web> Have you tried looking at the methods in xmpp-xml to see if there is already what you need? 12:15:40 <mayanktg> The test passes when I use input as the JSON strring 12:16:56 <mayanktg> But I shouldn't use JSON String for it I suppose. is it getElement? 12:17:18 <aleth_web> You seem to be confusing a lot of things. 12:17:38 <aleth_web> Take a step back and a deep breath and think about what you need for this. 12:19:01 <aleth_web> How is sdp2xml going to be used later? Where is its argument coming from? 12:20:35 <aleth_web> In what form does webrtc provide the offer? 12:20:51 <aleth_web> That's your input for sdp2xml. 12:25:18 <aleth_web> mayanktg: If you're confused about basic things like "how do I make an object" or "what's json" please take time to ask about those or look them up on mdn. There's no point proceeding completely by trial and error. 12:28:25 <mayanktg> clokep: Ok. 12:28:49 <mayanktg> aleth_web, clokep: I had to use getXML() to get the offer. 12:29:17 <aleth_web> I'm confused now. Can you show me a pastebin? 12:29:35 <mayanktg> The test passed with my earlier output and the given offer.getXML(). 12:29:38 <mayanktg> Ok 12:31:29 <-- jb has quit (Ping timeout) 12:32:27 <mayanktg> aleth_web: http://pastebin.instantbird.com/731518 (Line 90) 12:36:00 <aleth_web> Do you know how JSON works? 12:36:26 <mayanktg> No 12:36:38 <aleth_web> Then you should ask ;) 12:37:25 <aleth_web> Try experimenting a bit in the FX Scratchpad. Make an object like so: |let testobject = { name: "hello", value: 23 };| 12:37:34 <clokep> aleth_web: Do you know what the bug is about the username field for IRC. 12:37:48 <aleth_web> Then try JSON.stringify(testobject) and see what it looks like and how it relates to the object. 12:37:57 <aleth_web> Play around with changing the testobject and see what happens. 12:38:22 <mayanktg> aleth_web: Ok. I'm trying that. 12:38:43 <aleth_web> That way you should get a feel for how different types look when converted to JSON. 12:39:29 <aleth_web> clokep: Maybe one of the bouncer bugs? I'm nto sure 12:39:46 <clokep> Most of those seem to be about the password though. 12:40:38 <clokep> aleth_web: Context: https://twitter.com/clokep/status/475253150220562432 12:44:36 <aleth_web> mayanktg: How's that working for you? 12:47:21 <clokep> Btw Twitter is one of the most useless medias ever to have a conversation across. 12:47:23 <mayanktg> I understood how JSON stringify the object. It converts object as { "property1":"value1", "property2: "value2",....} 12:48:50 <aleth_web> So now when you look at your input on line 42, you see it's basically JSON output. 12:49:09 <mayanktg> Yes. 12:50:45 <sawrubh|ib> anyone got any elegant method to make hg understand that I'm just renaming the hg cp'ed file 12:50:58 <aleth_web> hg mv 12:51:34 <aleth_web> mayanktg: So which object does that JSON output come from? 12:52:16 <sawrubh|ib> aleth_web: thanks 12:53:24 <mayanktg> aleth_web: It is the offer which was generated by the createOffer() method. 12:54:19 <aleth_web> OK. So what you have when you want to use sdp2xml later is an object. And which properties of it actually contains the sdp? 12:55:55 <mayanktg> Yes. the property "sdp" of the JSON contains the sdp offer. 12:56:31 <clokep> The property of the object, not the JSON. 12:57:41 <mayanktg> clokep: oh yes.. 12:58:09 <aleth_web> My point is that your code will look something like |let offer = createoffer(...); let xml = sdp2xml(offer.sdp);| right? 13:00:36 <mayanktg> yep.. I'll create an offer using cerateOffer() --> convert it to iq stanza --> send it via Jingle channel... 13:01:03 <aleth_web> So you see that JSON is used nowhere in this? 13:01:20 <mayanktg> Yes! 13:01:31 <aleth_web> So why is your current test input JSON? ;) 13:04:31 <mayanktg> :'( Yeah ... This is not JSON now http://pastebin.instantbird.com/731523 ? 13:04:56 <aleth_web> That's an array of strings ;) 13:05:04 <mayanktg> I've joined the string using input.join("\r\n") 13:05:12 <aleth_web> OK, that sounds right. 13:05:14 <mayanktg> Yep.. 13:05:20 <aleth_web> JSON is generally used as a convenient way to turn objects into human-readable strings that one can write somewhere, but you don't need that here as object.sdp is already a string... 13:05:43 <mayanktg> and I run the test taking the new input --> passed 13:06:12 <aleth_web> Now let's look at the output. 13:06:59 <mayanktg> ok 13:07:02 <aleth_web> I don't think you want sdp2xml to generate the complete iq stanza, just the parts of it that correspond to the sdp 13:07:37 <mayanktg> i.e from the <content/> 13:08:11 <aleth_web> So that the caller can then build a complete stanza using that, adding the recipient jids and so on. 13:08:30 <mayanktg> so I'll have to move the <iq> and <jingle> element back to the main funciton 13:08:32 <mayanktg> yep 13:09:06 <aleth_web> That way sdp2xml doesn't need to know that it's an offer or whatever. It really just handles the sdp. 13:09:27 <aleth_web> After all, later you'll want to also use it to reply to offers and so on... 13:09:43 <mayanktg> Yes, then we can use it both for creating an "offer" and an "answer" 13:10:04 <aleth_web> Yes, you want to make these helper functions as general as possible. 13:10:18 <aleth_web> So you don't have to duplicate your work later... 13:11:39 <mayanktg> Yes you're right. and after creating that I'll have to create a real offer? 13:12:15 <aleth_web> When your test passes, I guess that's the next step. 13:12:23 <aleth_web> By the way, have you seen http://mxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp-xml.jsm#247 ? 13:12:49 <mayanktg> Ok.. No i didn't 13:12:51 <aleth_web> Might be useful for the test if the output is more readable than what getXML gives you. 13:13:00 <mayanktg> Yes.. 13:13:13 <mayanktg> I'll do that too.. 13:13:14 <aleth_web> Because your output constant is completely unreadable ;) 13:13:43 <mayanktg> yeah I had to use a beautifier to make it readable myself 13:13:44 <aleth_web> I mean, it looks like valid XML, but unreadable for humans... 13:13:44 <mayanktg> :-/ 13:16:40 <mayanktg> ok. So I'm making changes the code. 13:17:01 <mayanktg> ...and will get back if I fall into trouble :P 13:17:03 <aleth_web> I hope things are a bit clearer now ;) 13:17:39 <mayanktg> yes. Thanks a lot :-] 13:19:29 --> kramolnik has joined #instantbird 13:23:21 --> sonny has joined #instantbird 13:24:32 --> mpmc has joined #instantbird 13:30:37 <sawrubh|ib> clokep: does this indentation look good : http://pastebin.instantbird.com/731546 ? 13:31:42 <sawrubh|ib> sorry, http://pastebin.instantbird.com/731547 might give more context to comment 13:33:38 <clokep> sawrubh|ib: No. 13:33:43 <clokep> The periods should all line up. 13:34:31 <clokep> sawrubh|ib: The stuff around formatStringFromname looks OK, yes. 13:34:33 <sawrubh|ib> that part wasn't written by me (but I'll fix it) 13:34:46 <sawrubh|ib> I was asking about the formatStringFromName thing 13:35:08 --> gerard-majax_ has joined #instantbird 13:35:23 <sawrubh|ib> coolio 13:39:11 <clokep> sawrubh|ib: Yeah, but let's just fix it. ;) 13:40:00 --> jb has joined #instantbird 13:53:13 <-- sonny has quit (Ping timeout) 13:53:47 <sawrubh|ib> aleth_web: is there a difference when localized string is with a # instead of a %? 13:54:10 <flo-retina> sawrubh|ib: give an example 13:54:38 <sawrubh|ib> I'm using http://pastebin.instantbird.com/731547 but it doesn't seem to work, it simply prints #1 and #2 (the format is here : https://mxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/mozapps/downloads/downloads.properties#101) 13:55:02 <sawrubh|ib> err it prints '#1 #2' instead of '11.0 MB' or something 13:57:31 <sawrubh|ib> http://pastebin.instantbird.com/731560 is the diff fwiw 13:57:42 <sawrubh|ib> none of the formatStringFromName seem to work 14:03:17 <aleth_web> why not mxr how those particular strings are used elsewhere? 14:03:36 <sawrubh|ib> good idea 14:04:22 <aleth_web> My guess is it's intentionally nonstandard 14:05:04 <-- jb has quit (Ping timeout) 14:08:51 <sawrubh|ib> ooh, slick http://dxr.mozilla.org/comm-central/source/mozilla/toolkit/mozapps/downloads/content/downloads.js#980 14:09:11 <sawrubh|ib> I'm not sure why they do this sorcery instead of just plain using % and formatStringFromName which is much easier 14:09:44 <sawrubh|ib> (assuming using %'s allows using formatStringFromName and # doesn't) 14:10:54 <aleth_web> If it's not needed, you can add strings with % to your own properties file I guess. Or ask mconley if there was some deep reason... 14:10:58 <sawrubh|ib> and http://dxr.mozilla.org/comm-central/source/mozilla/toolkit/mozapps/extensions/content/extensions.js#2866 14:11:35 <aleth_web> I don't see why they didn't use % either. 14:13:12 <sawrubh|ib> I'll just go add to me own properties file :) 14:30:46 --> sonny has joined #instantbird 14:31:19 <-- mayanktg has quit (Ping timeout) 14:33:41 --> mayanktg has joined #instantbird 14:40:51 <-- BWMerlin has quit (Quit: BWMerlin) 14:53:22 --> jb has joined #instantbird 15:03:20 <aleth_web> mayanktg: How's your test doing? 15:03:43 <mayanktg> aleth_web: covertToString() is also converting "<" and ">" :-/ 15:04:09 <mayanktg> I mean its treating htem as special character and replacing it with < and > 15:04:16 <flo-retina> aleth_web, sawrubh|ib: the one reason I know for using # instead if %S is in localized plural strings 15:04:34 <flo-retina> but none of these examples seem to be plural strings... 15:05:11 <mayanktg> aleth_web: *convertToString() 15:07:02 <mayanktg> I'm seeing how indentation is implemented in other iq stanzas.. 15:08:07 <aleth_web> That sounds strange to me. 15:08:10 <aleth_web> How are you calling it? 15:10:12 <sawrubh|ib> is there an option on BMO to attach multiple screenshots right when you're filing a bug? (currently I can only attach one) 15:10:13 <mayanktg> item is the <jingle> stanza and I'm calling it |item.convertToString()| 15:10:25 <sawrubh|ib> s/screenshots/attachments 15:10:58 <mayanktg> aleth_web: http://mxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm#855 is an example to use it... 15:11:29 <aleth_web> yes. I don't see why that would convert entities. 15:12:42 <-- sonny has quit (Ping timeout) 15:12:58 <aleth_web> How are you making the item? 15:14:05 <clokep> sawrubh|ib: No 15:14:28 <mayanktg> subItem = Stanza.node(... , ... , ...); 15:14:28 <mayanktg> item.addChild(subItem) 15:14:46 <sawrubh|ib> is someone (interested and) able to reproduce bug 1022166? 15:14:50 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1022166 nor, --, ---, nobody, NEW, Rendering artifacts on DXR 15:16:14 <mayanktg> aleth_web: It must be something wrong with my code, since i see nowhere in the ConvertToString() definition conversion is carried out :-/ 15:16:37 <aleth_web> How about sharing a pastebin? 15:16:50 <mayanktg> yes.. 15:25:46 <aleth_web> Does the stuff in line 139 have anything to do with sdp? 15:26:23 <aleth_web> I'm wondering why sdp2xml needs to know fromJID 15:27:17 <-- rosonline has quit (Ping timeout) 15:27:36 <mayanktg> I'm creating passing a single <jingle> else I'll have to pass as many number of <content> as the number of media identified. 15:28:10 <aleth_web> Sounds like the correct return value would be an array of content nodes? 15:28:16 <mayanktg> Ok. I'll pass each <content> and then construct an iq in the main function. 15:28:18 <mayanktg> Yes. 15:28:50 --> rosonline has joined #instantbird 15:30:19 <aleth_web> The convertToString should only be used in your test. 15:31:04 <mayanktg> Ok. 15:31:11 <aleth_web> To find out where your < entities are coming from, you'll just have to put some dump() statements in your function and discover where it happens. 15:31:44 <mayanktg> aleth_web: Ok. I'll do that and find that out. 15:40:13 --> mconley has joined #instantbird 15:52:32 <-- kramolnik has quit (Ping timeout) 16:02:28 <-- gerard-majax_ has quit (Ping timeout) 16:02:34 <-- mconley has quit (Input/output error) 16:07:29 --> mconley has joined #instantbird 16:09:48 <-- mconley has quit (Input/output error) 16:10:16 --> mconley has joined #instantbird 16:12:04 <-- mconley has quit (Ping timeout) 16:12:53 --> jb1 has joined #instantbird 16:12:57 <-- jb has quit (Connection reset by peer) 16:14:28 --> Armada has joined #instantbird 16:21:02 --> sonny has joined #instantbird 16:22:23 --> jb has joined #instantbird 16:22:44 <-- jb1 has quit (Ping timeout) 16:27:32 <-- sawrubh|ib has quit (Ping timeout) 16:28:24 --> sawrubh|ib has joined #instantbird 16:37:07 <mayanktg> sdp2xml now returns array of <content/>. :) 16:39:06 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:40:24 <-- Even has quit (Ping timeout) 16:44:35 <aleth_web> mayanktg: What does .contentString() on the returned nodes look like? Still seeing <? 16:45:41 <mayanktg> Yes, it was returning the same. I then started working on returning the content nodes as array. Wait let me try that again 16:49:51 --> Even has joined #instantbird 16:49:52 * ChanServ sets mode +o Even 16:55:31 <mayanktg> aleth_web: on |Cu.reportError(s.convertToString())| I'm getting the correct indented stanza but when I try to send the stanza using |aConv.wrappedJSObject._account.sendStanza(s.convertToString())| I get this error |Error: aStanza.attributes is undefined| 16:56:23 <mayanktg> I'm able to send the stanza as ...sendStanza(s) 16:56:47 <aleth_web> That's as it should be, isn't it? You don't want to send the pretty-printed indented string, after all! 16:57:37 <mayanktg> Oh yes! 16:57:54 <aleth_web> The only thing you need convertToString for is for your tests, so you can compare the output of sdp2xml with the expected results in a more readable way 16:57:58 <mayanktg> I should be then using it for the test. 16:58:08 <mayanktg> Yes. 16:58:23 <aleth_web> Get the test working then show me a pastebin 16:58:38 <mayanktg> Ok. 17:05:26 <-- clokep has quit (Ping timeout) 17:06:24 <-- sonny has quit (Ping timeout) 17:10:59 --> mconley has joined #instantbird 17:11:23 <-- nhnt11 has quit (Ping timeout) 17:12:28 --> nhnt11 has joined #instantbird 17:14:35 <sawrubh|ib> mconley: hey 17:14:54 <sawrubh|ib> mconley: any ideas about http://log.bezut.info/instantbird/140607/#m294 ? 17:16:22 <-- mconley has quit (Ping timeout) 17:21:11 <-- sawrubh|ib has quit (Connection reset by peer) 17:23:10 --> sawrubh|ib has joined #instantbird 17:25:51 --> Rym has joined #instantbird 17:26:18 <nhnt11> hi 17:29:42 <nhnt11> aleth_web: Do you think instead of changing the |for (log of fixIterator(aLogs))| to |http://log.bezut.info/instantbird/140607/#m95|, I should just add a query interface? 17:30:48 <aleth_web> What's the context? 17:30:48 <-- Rym has quit (Ping timeout) 17:31:08 <aleth_web> ah, gloda 17:31:22 <nhnt11> aleth_web: https://mxr.mozilla.org/comm-central/source/mail/components/im/content/chat-messenger-overlay.js#1136 17:31:28 <nhnt11> Not gloda, Tb UI 17:31:45 <nhnt11> The problem is that the interface no longer defines the return type as an nsISimpleEnumerator 17:31:51 <nhnt11> so fixIterator returns null 17:31:55 <aleth_web> Ah. This code is unfortunately forked :-/ 17:32:00 <aleth_web> Just do what the same line in IB does. 17:32:19 <nhnt11> Alright. The while loop way then 17:32:20 <aleth_web> (viewlog.js) 17:33:49 --> Rym has joined #instantbird 17:35:59 <nhnt11> Hmm wait 17:36:04 <nhnt11> viewlog.js uses getIter 17:36:06 <nhnt11> my bad 17:38:38 <nhnt11> brb 17:45:21 --> sonny has joined #instantbird 17:50:35 <-- Rym has quit (Ping timeout) 17:50:54 --> Rym has joined #instantbird 17:52:19 <-- sonny has quit (Ping timeout) 17:53:33 <-- Rym has quit (Ping timeout) 17:55:45 --> Rym has joined #instantbird 17:58:05 --> sonny has joined #instantbird 18:00:03 <sawrubh|ib> how do I change the setting to show the times in 12 hour format instead of 24 hour? 18:01:14 <sawrubh|ib> also does someone else get a blank 'Applications' pane when running the Nightly build of IB? Mind you, this is without any of my changes, just the trunk 18:01:25 <aleth_web> There shouldn't be a setting - it probably uses your system settings 18:01:55 <sawrubh|ib> on another test profile I created from scratch, I see handlers for http and ftp etc but not on the build I'm using for my daily use 18:02:17 <aleth_web> Is that a build you've built yourself? 18:02:33 <sawrubh|ib> yes, the one I made by doing |make package| 18:03:07 <aleth_web> Should work fine. 18:03:09 <-- rosonline has quit (Ping timeout) 18:03:54 <sawrubh|ib> hrm, I'll just build it another time and check later 18:04:10 <-- sonny has quit (Ping timeout) 18:06:23 <sawrubh|ib> also where is the setting to save the log and other settings related to saving irc logs 18:07:13 <sawrubh|ib> got it nvm 18:26:21 <sawrubh|ib> aleth_web: how does one fetch strings from dtd files, I've seen GetStringFromName being used everywhere to fetch it from properties files but not seen any dtd examples 18:26:47 <aleth_web> You can't really fetch them, that's what properties files are for. 18:26:50 <sawrubh|ib> the strings from dtd's are directly put in XUL elements using something like '&paneFileTransfers.title' 18:26:56 <aleth_web> Right. 18:27:08 <sawrubh|ib> ah, so I'll just move that string to the properties file then :) 18:27:14 <aleth_web> Yup! 18:27:15 <sawrubh|ib> thanks 18:28:32 <mayanktg> aleth_web: I'm almost done. I have converted the sample output in a readable form, converted the offer array elements using convertToString, but I'm unable to join the two offers. It's throwing |offer.join is not a function()| . I'll figure it out and pastebin the report asap. 18:28:42 <-- Rym has quit (Ping timeout) 18:29:05 <aleth_web> Do you have to join them? 18:29:43 <aleth_web> Anyway, I'm sure you'll figure it out. 18:30:37 <mayanktg> If I'm not joining them, I'll have to take sample output as an array too and compare them. 18:30:51 <-- jb has quit (Ping timeout) 18:31:29 <aleth_web> Whatever seems best. 18:49:31 --> rosonline has joined #instantbird 19:05:56 <mayanktg> aleth_web: Here's is the diff of the test http://pastebin.instantbird.com/731723 . The test is passing for the given input and output. 19:08:51 <aleth_web> mayanktg: :) 19:11:18 <mayanktg> is it ok (except for few newlines at top of the patch)? What else can be done to improve it? :-o 19:13:07 <aleth_web> I'm sure there will be style issues when you put it up for review in a bug, but for now it looks like you have got it into a useful state :) 19:13:11 <aleth_web> What's next? 19:13:47 <mayanktg> Create a _real_ offer? 19:14:11 <aleth_web> OK! 19:14:16 <mayanktg> Yes. I'll fix the style issue before uploading it as a patch.. 19:14:20 <aleth_web> So you have to do this in conversation.xml, right? 19:14:26 <mayanktg> yes. 19:14:45 <mayanktg> But how will I call it when I run the /call command? 19:14:45 <aleth_web> Maybe use the button you added instead of the call command to start the call then. 19:15:58 <aleth_web> You want the UI (conversation.xml) to pass the offer to the protocol plugin. 19:16:02 <mayanktg> ok .. clicking on the button --> generates the offer... How will I send it via prpl-jabber? 19:17:02 <aleth_web> You'll have to add a new method for prplIConversations to the interface I think. 19:17:19 <aleth_web> Discuss it with flo when he is next online. 19:17:49 <mayanktg> Ok... 19:18:07 <aleth_web> You can already start working on it though. 19:18:11 <mayanktg> Until then I'm trying it myslef. 19:18:12 <aleth_web> The interface is here http://mxr.mozilla.org/comm-central/source/chat/components/public/prplIConversation.idl 19:18:17 <mayanktg> *myself 19:18:29 <mayanktg> ok. :) 19:18:48 <aleth_web> It needs a new function for conversations, startCall or something 19:19:01 <aleth_web> As parameters you would pass the offer. 19:20:11 <aleth_web> When you have added it to the interface (nhnt11 can help you with that) you can implement it in xmpp.jsm. And then you can use it :) 19:21:15 <aleth_web> From conversation.xml, you will then be able to do something like |this.conv.startCall(offer);| 19:22:08 <mayanktg> Hmm..Ok. I'll try to implement it. I will have to study about prplConversation.idl first :) . 19:22:17 <sawrubh|ib> aleth_web: I'm done! 19:25:38 --> mconley has joined #instantbird 19:27:25 <mconley> sawrubh: I would wager it's because this code is soooooooo old 19:28:30 <sawrubh|ib> hmm 19:29:15 * sawrubh|ib now just hopes clokep comes quickly and reviews his patches :) 19:30:47 <sawrubh|ib> I'll just go ahead and check if I've managed to break TB ;) 19:41:22 <-- mconley has quit (Ping timeout) 19:54:07 --> mconley has joined #instantbird 19:57:32 <-- mpmc has quit (Connection reset by peer) 19:58:43 --> mpmc has joined #instantbird 20:14:47 <sawrubh|ib> I get this error while building TB : http://pastebin.instantbird.com/731746 20:23:39 <-- mpmc has quit (Connection reset by peer) 20:24:48 --> mpmc has joined #instantbird 20:29:04 <-- mayanktg has quit (Ping timeout) 20:31:29 --> mayanktg has joined #instantbird 20:39:35 --> Rym has joined #instantbird 20:50:48 <-- mayanktg has quit (Ping timeout) 20:50:50 --> mayanktg has joined #instantbird 20:52:22 <-- mconley has quit (Input/output error) 20:52:33 <-- Rym has quit (Ping timeout) 20:52:52 --> Rym has joined #instantbird 20:55:01 <-- Rym has quit (Ping timeout) 20:55:26 --> Rym has joined #instantbird 20:57:37 <-- Rym has quit (Ping timeout) 20:58:49 --> Rym has joined #instantbird 21:16:38 <-- Rym has quit (Ping timeout) 21:17:14 --> Rym has joined #instantbird 21:48:56 <-- aleth_web has quit (Quit: Connection closed for inactivity) 21:56:12 --> Mic has joined #instantbird 21:56:12 * ChanServ sets mode +o Mic 21:57:27 <Mic> Hi 22:02:29 <Mic> Sorry, for not showing up during the last few days... I'd been both sick and buys :S 22:02:36 <Mic> *busy 22:08:26 <sawrubh|ib> I should only run mozmill to ensure my changes haven't broken TB right? 22:13:57 <-- rosonline has quit (Ping timeout) 22:15:00 <mayanktg> Mic: Hello . Here is the WIP for the /call command patch. http://pastebin.instantbird.com/731816 22:15:40 --> rosonline has joined #instantbird 22:15:56 <Mic> Thanks, I'll try to catch up on your work as much as possible tonight... 22:16:52 <mayanktg> Mic: and the xpcshell test for sdp2xml() http://pastebin.instantbird.com/731819 22:18:58 <mayanktg> ok :) 22:21:43 <sawrubh|ib> Mic: do I need to use some special mozconfig for testing on try? 22:23:16 <Mic> sawrubh|ib: I've no experience with try, sorry. 22:33:49 <-- Rym has quit (Ping timeout) 22:37:06 --> Rym has joined #instantbird 22:44:58 <-- Rym has quit (Ping timeout) 22:46:07 --> Rym has joined #instantbird 22:48:17 <-- Rym has quit (Ping timeout) 22:49:55 --> Rym has joined #instantbird 22:56:38 <-- Rym has quit (Ping timeout) 22:56:56 --> Rym has joined #instantbird 22:57:20 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 22:59:34 <-- Rym has quit (Ping timeout) 22:59:56 --> Rym has joined #instantbird 23:02:26 <-- sawrubh|ib has quit (Ping timeout) 23:02:49 --> sawrubh|ib has joined #instantbird 23:20:19 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 23:21:22 --> mayanktg has joined #instantbird 23:24:41 --> EionRobb has joined #instantbird 23:27:19 <-- Rym has quit (Ping timeout) 23:27:41 --> Rym has joined #instantbird 23:30:20 <-- chrisccoulson has quit (Client exited) 23:35:38 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 23:44:43 <-- sawrubh|ib has quit (Quit: sawrubh|ib) 23:56:47 <-- Rym has quit (Ping timeout) 23:58:00 --> Rym has joined #instantbird 23:58:15 <-- EionRobb has quit (Quit: Leaving.)