#instantbird log on 06 06 2014

All times are UTC.

00:02:51 <-- nhnt11 has quit (Ping timeout)
00:03:37 <instantbot> New Chat Core - IRC bug 1021362 filed by nhnt11@gmail.com.
00:03:39 --> nhnt11 has joined #instantbird
00:03:39 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1021362 nor, --, ---, nobody, NEW, /msg  foo tries to send the message "foo" to a blank nick
00:08:05 <-- nhnt11 has quit (Ping timeout)
00:10:13 --> nhnt11 has joined #instantbird
00:10:52 <-- Suiseiseki has quit (Ping timeout)
00:13:42 --> Suiseiseki has joined #instantbird
00:20:04 <-- nhnt11 has quit (Ping timeout)
00:21:33 --> nhnt11 has joined #instantbird
00:29:03 <-- nhnt11 has quit (Ping timeout)
00:30:29 --> nhnt11 has joined #instantbird
00:44:58 <-- nhnt11 has quit (Ping timeout)
00:46:24 --> nhnt11 has joined #instantbird
00:47:31 --> nhnt11-tb has joined #instantbird
00:49:45 <-- nhnt11-tb has left #instantbird ()
00:49:51 <-- nhnt11 has left #instantbird ()
00:50:04 --> nhnt11 has joined #instantbird
00:51:48 <-- nhnt11 has quit (Ping timeout)
00:52:44 --> nhnt11 has joined #instantbird
00:54:03 --> nhnt11-tb has joined #instantbird
00:54:57 <-- nhnt11-tb has left #instantbird ()
01:04:48 <-- nhnt11 has quit (Ping timeout)
01:05:59 --> nhnt11 has joined #instantbird
01:13:35 <-- nhnt11 has quit (Ping timeout)
01:14:58 --> nhnt11 has joined #instantbird
01:21:59 <-- nhnt11 has quit (Ping timeout)
01:23:48 --> nhnt11 has joined #instantbird
01:26:32 <-- Mook_as has quit (Quit: Mook_as)
01:35:23 <-- nhnt11 has quit (Ping timeout)
01:37:05 --> nhnt11 has joined #instantbird
01:40:38 --> nhnt11-tb has joined #instantbird
01:40:46 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
01:42:20 <-- nhnt11 has quit (Ping timeout)
01:43:46 --> nhnt11 has joined #instantbird
01:46:25 <-- Rym has quit (Ping timeout)
01:46:44 --> Rym has joined #instantbird
01:48:11 <-- nhnt11 has quit (Ping timeout)
01:49:37 --> nhnt11 has joined #instantbird
02:11:42 --> mconley has joined #instantbird
02:26:16 <-- nhnt11 has quit (Connection reset by peer)
02:28:12 --> nhnt11 has joined #instantbird
03:06:44 <-- mconley has quit (Input/output error)
03:18:14 <-- nhnt11 has quit (Ping timeout)
03:19:22 --> nhnt11 has joined #instantbird
03:21:55 --> mconley has joined #instantbird
03:29:07 <-- nhnt11 has quit (Ping timeout)
03:29:58 --> nhnt11 has joined #instantbird
03:34:39 <-- mconley has quit (Input/output error)
03:36:42 <-- nhnt11 has quit (Ping timeout)
03:37:26 --> nhnt11 has joined #instantbird
03:48:17 <-- Rym has quit (Ping timeout)
03:48:44 --> Rym has joined #instantbird
03:49:46 <-- nhnt11 has quit (Ping timeout)
03:50:50 --> nhnt11 has joined #instantbird
04:10:09 <-- nhnt11 has quit (Ping timeout)
04:11:16 --> nhnt11 has joined #instantbird
04:35:21 <-- nhnt11 has quit (Ping timeout)
04:37:16 --> nhnt11 has joined #instantbird
04:41:42 <-- nhnt11 has quit (Ping timeout)
04:44:56 --> nhnt11 has joined #instantbird
04:48:35 <-- nhnt11 has quit (Ping timeout)
04:50:16 --> nhnt11 has joined #instantbird
04:53:14 --> mconley has joined #instantbird
04:58:15 <-- nhnt11 has quit (Ping timeout)
04:59:16 --> nhnt11 has joined #instantbird
05:11:58 <-- mconley has quit (Input/output error)
05:31:10 <-- EionRobb has quit (Quit: Leaving.)
05:44:39 <-- nhnt11 has quit (Ping timeout)
05:47:45 --> nhnt11 has joined #instantbird
05:55:43 <-- nhnt11 has quit (Ping timeout)
05:55:49 --> jb has joined #instantbird
05:57:09 --> nhnt11 has joined #instantbird
05:58:31 <-- jb has quit (Ping timeout)
05:59:35 --> jb has joined #instantbird
06:23:54 <-- jb has quit (Ping timeout)
06:56:46 <sawrubh> Morning!
07:10:27 --> jb has joined #instantbird
07:19:38 --> EionRobb has joined #instantbird
07:44:31 --> mayanktg has joined #instantbird
07:49:43 <-- Rym has quit (Ping timeout)
07:53:13 --> Armada has joined #instantbird
08:27:00 <mayanktg> Hello.
08:49:21 --> sonny has joined #instantbird
09:19:32 --> BWMerlin has joined #instantbird
09:41:45 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:57:57 <mayanktg> I have written the xpcshell test for sdp2xml() but its failing because I have to stringify the sample output and offer received from sdp2xml() :-/
09:58:40 <mayanktg> The test passes when I use | do_check_neq() |
10:09:00 --> flo-retina has joined #instantbird
10:09:00 * ChanServ sets mode +qo flo-retina flo-retina 
10:12:08 <mayanktg> http://pastebin.instantbird.com/730496
10:12:22 <-- sonny has quit (Ping timeout)
10:13:54 <flo-retina> mayanktg: shouldn't |const output| be an XML string?
10:14:18 <flo-retina> (rather than a JSON representation of an XML tree)
10:15:02 <mayanktg> flo-retina: Yes. I tried using output as an XML string too. 
10:15:30 <flo-retina> try again then :)
10:16:25 <mayanktg> Yeah. I was doing the same. :)
10:16:54 --> sonny has joined #instantbird
10:18:05 --> clokep has joined #instantbird
10:18:06 * ChanServ sets mode +o clokep 
10:37:35 <mayanktg> flo-retina: I have the iq stanza as http://pastebin.instantbird.com/730529 and I converted it to string by replacing / " by \" / and / return & newline by \r\n /. http://pastebin.instantbird.com/730528 . I must be misplacing some characters :-/  
10:39:16 <clokep> mayanktg: You can always use ' ' as the string quotes and then you don't have to escape "
10:39:28 * clokep finds that code extremely hard to read.
10:39:51 <flo-retina> I thought aleth told you to not use that draft XEP?
10:43:37 <mayanktg> flo-retina: but I was unable to send some of the variables using it (for eg c=IN IP4 ). I didn't know where to put that in the XML stanza :-/ That's why I'm used the draft XEP.
10:44:14 <flo-retina> we told you to not do something. The next day we notice that you did anyway.
10:44:25 <flo-retina> how do you want us to help you if you do the opposite of what we ask?
10:46:16 <mayanktg> sorry. :'( I'll change that to XEP 0320. 
10:47:30 <flo-retina> mayanktg: looks like you have a problem near:
10:47:30 <flo-retina> type="host
10:47:30 <flo-retina> " reladdr="undefined" relport="undefined"/>
10:49:32 <mayanktg> flo-retina: Ok. The relport and reladdr shouldn't be the attributes if they are undefined. I'll fix it.
10:58:49 <-- EionRobb has quit (Quit: Leaving.)
11:06:24 <-- clokep has quit (Ping timeout)
11:26:30 <-- nhnt11 has quit (Ping timeout)
11:27:32 --> nhnt11 has joined #instantbird
11:33:53 --> rosonline has joined #instantbird
11:49:26 --> clokep_work has joined #instantbird
11:49:26 * ChanServ sets mode +o clokep_work 
11:51:20 --> aleth has joined #instantbird
11:51:20 * ChanServ sets mode +o aleth 
11:54:06 <clokep_work> sawrubh: Can you use more descriptive titles for your patches besides Patch1 and Patch2?
11:54:15 <clokep_work> (in the future)
11:54:25 <sawrubh> I thought the commit message did that, but sure
11:55:12 <clokep_work> sawrubh: I don't see the commit messages when looking at the bug on bugzilla. ;)
11:55:25 <clokep_work> Not until I open each patch.
12:00:07 * aleth wonders what the outcome of the close-on-each-write-or-not conversation was and what data went into the decision
12:01:14 <aleth> Too much in the logs these days to read all of them...
12:01:48 <BWMerlin> if pidgin has support for video chat will that come to thunderbird/instantbird?
12:02:44 <-- nhnt11 has quit (Ping timeout)
12:03:00 <clokep_work> BWMerlin: We have a GSoC student working on adding support for WebRTC over XMPP.
12:04:23 <aleth> nhnt11: The news on Promise.finally sounds... promising :D
12:05:31 <clokep_work> aleth: Really? Come on. :P
12:05:51 <BWMerlin> https://blog.wasilczyk.pl/en/2013/pidgin-with-video-finally-for-windows/
12:06:04 --> nhnt11 has joined #instantbird
12:07:28 <aleth> BWMerlin: "support for webrtc" means voice/video chat.
12:07:53 <aleth> But we're not going to "inherit" it from Pidgin automatically.
12:08:09 <BWMerlin> ah okay
12:10:02 <clokep_work> BWMerlin: At least the UI, etc. needs to be updated. the WebRTC work should help w/ that, then someone could integrated the libpurple stuff, maybe. I'm unsure how difficult that is. :)
12:10:12 <clokep_work> sawrubh: Filetransfer.css . . . where is that used?
12:10:52 <sawrubh> it's used in the xhtml's which show the provider details
12:11:03 <BWMerlin> is WebRTC the only way voice/video is done over XMPP?
12:11:03 <sawrubh> management.xhtml in Box and Hightail
12:11:16 <-- nhnt11 has quit (Ping timeout)
12:11:23 --> nhnt11 has joined #instantbird
12:12:04 <clokep_work> BWMerlin: No.
12:12:12 <clokep_work> sawrubh: So it is part of both TB & IB?
12:12:25 <clokep_work> Did that used to be a different name?
12:12:28 <clokep_work> Why is it a new file?
12:14:54 <mayanktg> The XML stanza until now. I'm adding the left out offer values and tying to remove the '\n\r'. http://pastebin.instantbird.com/730598 
12:15:13 <sawrubh> clokep_work: So the styling of these xhtml's came from the preferences.css is the file it comes from, I didn't copy the entire file
12:15:34 <sawrubh> it would have been the same, since I would have to delete most of that radioPane styling part
12:16:31 <clokep_work> sawrubh: I'm having trouble parsing "08:15:13 - sawrubh: […] So the styling of these xhtml's came from the preferences.css is the file it comes from, I didn't copy the entire file"
12:16:33 <nhnt11> aleth: tl;dr: http://log.bezut.info/instantbird/yesterday/#m705
12:16:45 <clokep_work> And I don't understand what the next sentence means either.
12:17:50 <sawrubh> ok, so http://dxr.mozilla.org/comm-central/source/mail/themes/linux/mail/preferences/preferences.css is the file which styles the management.xhtml's
12:18:55 <sawrubh> I would have had to delete quite a significant part of it (the radio[pane=] part) so I thought creating a new file vs copying the existing file and then deleting those sections would be equivalent work
12:20:33 <aleth> sawrubh: Maybe move what you need into that new file, then include that new file in filetransferl.xul too so the rules aren't duplicated.
12:20:55 <aleth> i.e. so you can remove them from preferences.css
12:21:34 <sawrubh> I've moved what I need to a new file(filetransfers.css) and included that in the xhtml's and I don't think there is any duplication of rules
12:21:36 <clokep_work> That's kind of what I was getting at.
12:21:49 <sawrubh> ah
12:21:55 <clokep_work> I don't see mail/preferences/preferences.css touched at all. :-S
12:21:57 <sawrubh> you mean to say remove it from TB's preferences?
12:21:58 <aleth> If the same rules are in preferences.css, that's duplication
12:22:10 <sawrubh> gotcha
12:22:15 <clokep_work> aleth: Any opinion on filetransfers.(js|xul|properties) vs. filetransfer?
12:22:21 <clokep_work> (And it should be camelcase)
12:23:10 <sawrubh> while we're at it, so the titles for the pane in the preference panel are all single words (Themes, Applications etc) while this is 'File Transfers' are we fine with that?
12:23:11 <aleth> clokep_work: Not really. Whatever the string in the pref window is I guess
12:25:26 * sawrubh will make it camel case and remove the rules from TB's preferences.css
12:26:08 <clokep_work> sawrubh: Yes, that's fine (until flo-retina overrules me. :P)
12:26:47 --> mpmc has joined #instantbird
12:26:51 * clokep_work likes these diffs that are hg cp to start w/. :)
12:26:56 <clokep_work> It makes it obvious what we're changing.
12:27:09 <sawrubh> yes! It made it so much more readable for me
12:27:14 <sawrubh> thanks for suggesting that
12:29:36 <-- nhnt11 has quit (Ping timeout)
12:29:49 --> nhnt11 has joined #instantbird
12:31:25 <clokep_work> :)
12:31:35 <clokep_work> I thought we decided on "File transfers" not "File Transfers"?
12:31:40 <clokep_work> For the title of the pref pane.
12:34:20 <-- nhnt11 has quit (Ping timeout)
12:36:12 --> nhnt11 has joined #instantbird
12:36:39 <sawrubh> clokep_work: http://log.bezut.info/instantbird/140531/#m248
12:37:34 <aleth> sawrubh: Go with clokep_work on this, I'm never too sure about capitalization rules ;)
12:37:56 <sawrubh> ok
12:40:29 <-- nhnt11 has quit (Ping timeout)
12:42:54 <-- sonny has quit (Ping timeout)
12:43:37 --> nhnt11 has joined #instantbird
12:44:45 <clokep_work> aleth: Thanks for the drive by, I'd appreciate if you could look over the XUL again at some point. :)
12:44:48 <clokep_work> My XUL is rusty. :-[
12:45:25 <-- aleth has quit (Ping timeout)
12:46:22 <-- gerard-majax_ has quit (Ping timeout)
12:48:07 <-- nhnt11 has quit (Ping timeout)
12:49:41 --> nhnt11 has joined #instantbird
12:49:51 --> aleth has joined #instantbird
12:49:52 * ChanServ sets mode +o aleth 
12:53:25 <aleth> sawrubh: setAttribute("class",...) is not how you do CSS from JS. There's JS properties on the elements that you should use.
12:54:06 <aleth> For example, https://developer.mozilla.org/en-US/docs/Web/API/Element.className (but look at the properties in the sidebar!)
12:58:55 * flo-retina isn't sure what he should overrule
13:03:53 <mayanktg> aleth: How should I send these parametershttp://pastebin.instantbird.com/730632 through the xml stanza? we do not have attributes for these 
13:04:06 <mayanktg> http://pastebin.instantbird.com/730633
13:04:50 --> qheaden has joined #instantbird
13:07:18 <aleth> mayanktg: Isn't that described here? http://xmpp.org/extensions/xep-0167.html#sdp
13:08:05 <-- nhnt11 has quit (Ping timeout)
13:09:03 <mayanktg> oh sorry, I forgot that :-/ Tanks :)
13:09:07 <mayanktg> *thanks :)
13:11:02 <aleth> Like flo said, you probably don't have to encode the v=, o= and s= lines as they are constants, and then your xml2spd() will have to put them back into the sdp by hand.
13:13:39 --> nhnt11 has joined #instantbird
13:17:09 --> sonny has joined #instantbird
13:17:35 <aleth> mayanktg: also this might be relevant (I'm not sure) http://xmpp.org/extensions/xep-0293.html
13:18:02 <clokep_work> Can I just close bug 806079? :-\
13:18:06 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=806079 nor, --, ---, nobody, NEW, Google Chat should accept e-mail addresses @googlemail.com
13:18:11 <aleth> mayanktg: and this section 5 http://xmpp.org/extensions/xep-0294.html
13:19:18 <mayanktg> aleth: Yes. it is . It tell how to use |rtcp-fb| 
13:20:06 <aleth> Make sure you put comments in your code referring to the XEPs you are using, so you and other future coders will find them again
13:21:19 <mayanktg> aleth: Yes. I'll make sure I put proper comments
13:21:53 <-- jb has quit (Quit: jb)
13:21:55 <aleth> thanks. It's a maze of XEPs already, let's make your code not be another maze :)
13:24:12 --> jb has joined #instantbird
13:25:33 --> gerard-majax_ has joined #instantbird
13:32:22 <sawrubh> aleth: http://pastebin.instantbird.com/730654 is the error I get when doing |make package| in my objdir
13:32:32 <sawrubh> should this go in Chat Core or some build system component?
13:32:59 <flo-retina> that's an ib error
13:33:39 * sawrubh files that in Chat Core then
13:33:43 <flo-retina> no
13:33:50 <flo-retina> chat core is for the chat/ folder
13:34:00 <sawrubh> eek
13:34:07 <sawrubh> then which component?
13:34:07 <flo-retina> if you want ot make it work locally, you can just comment out http://mxr.mozilla.org/comm-central/source/im/installer/removed-files.in#204
13:34:28 <flo-retina> sawrubh: https://bugzilla.mozilla.org/enter_bug.cgi?product=Instantbird&component=Other
13:34:40 <sawrubh> thanks
13:35:20 <aleth> Would be nice if you made it work by doing what flo suggested and then added a patch to the bug you filed.
13:36:00 <flo-retina> aleth: the real patch actually needs an ifdef
13:36:11 <flo-retina> the problem is that on linux buildbot mozconfigs we have --disable-dbus
13:36:26 <flo-retina> because our old VM doesn't have dbus...
13:36:31 <sawrubh> aleth: on it
13:36:34 <instantbot> New Instantbird - Other bug 1021704 filed by saurabhanandiit@gmail.com.
13:36:35 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1021704 nor, --, ---, nobody, NEW, Error encountered when doing |make package| in Instantbird
13:36:43 <aleth> flo-retina: So by the time nightlies come back, we won't need that anymore?
13:36:48 <flo-retina> aleth: yeah
13:36:58 <flo-retina> (assuming we also update our linux mozconfigs)
13:37:17 <aleth> Sounds like the real fix is to update the mozconfig then
13:38:04 <sawrubh> ok, but mozconfigs are machine specific, how do I patch that?
13:38:17 <sawrubh> add an ifdef to that removed-files.in file?
13:40:26 <clokep_work> sawrubh: The ones for the buildbots are in the tree.
13:42:08 <aleth> sawrubh: Remove the line flo pointed at, and remove the --disable-dbus from the linux mozconfig.
13:42:45 <aleth> That will ensure that the first change doesn't break builds on the linux buildbot (when they come back)
13:44:00 <flo-retina> aleth: I'm not sure I would r+ any changes to the buildbot linux mozconfigs until we have a slave that actually builds with the new changed mozconfig
13:44:31 <aleth> flo-retina: I wasn't expecting the patch would land until then
13:44:51 <flo-retina> there will be plenty of other changes to the mozconfig for the centos5 -> 6 update
13:45:32 --> jb1 has joined #instantbird
13:45:35 <-- jb has quit (Connection reset by peer)
13:49:19 <sawrubh> flo-retina: sent the patch
13:50:06 <flo-retina> sawrubh: that bug should at least contain the error you are talking about. The pastebin will expire
13:50:16 <flo-retina> and the bug summary should mention which file is causing the problem
13:51:04 <sawrubh> ok
13:51:12 <flo-retina> but thanks :)
13:54:53 <sawrubh> mid-air collision ftw
13:57:30 <aleth> So does package work now for you?
13:59:41 <sawrubh> yes it does
13:59:48 <aleth> :)
14:00:06 <sawrubh> flo-retina: so "It's probably OK to take this change now." do I need to do something?
14:06:32 <-- jb1 has quit (Ping timeout)
14:07:05 --> jb has joined #instantbird
14:08:02 --> sawrubh|ib has joined #instantbird
14:08:20 <-- aleth has quit (Ping timeout)
14:08:39 <-- sawrubh|ib has quit (Quit: Gotham needs me)
14:08:43 <-- jb has quit (Ping timeout)
14:08:44 --> sawrubh|ib has joined #instantbird
14:08:56 <-- BWMerlin has quit (Quit: BWMerlin)
14:09:00 --> aleth has joined #instantbird
14:09:01 * ChanServ sets mode +o aleth 
14:09:54 <flo-retina> sawrubh: attach a patch with only that change?
14:10:05 <flo-retina> (if you want us to check it in soonish)
14:10:39 <clokep_work> :) Someone beat me to telling you not to use pastebins in bugs. ;)
14:11:02 <flo-retina> ;)
14:11:12 <qheaden> Hello. :)
14:11:21 <qheaden> I've finally got some progress on the group chat issue.
14:12:09 <sawrubh|ib> flo-retina: ok, I'll do that
14:14:52 <clokep_work> qheaden: Excellent! I have a feeling this will be a huge patch to read. :-D
14:15:06 <qheaden> clokep_work: So far, it is a two line change. :P
14:15:21 <clokep_work> :)
14:15:24 <qheaden> I messed up some packet keys.
14:15:48 <qheaden> My last packet capture made it much easier to trace.
14:16:28 <qheaden> I was just staring at the code for about an hour a few days ago just to see what issues I could spot.
14:19:39 <aleth> sawrubh: I'm fairly sure Mic already filed a bug for that, try and find it.
14:19:42 <aleth> It doesn't happen on OSX
14:20:48 <aleth> Maybe it was only fixed for Windows and OSX for some reason
14:21:38 <sawrubh|ib> :(
14:21:42 * sawrubh|ib searches for it
14:27:17 --> iamjayakumars has joined #instantbird
14:27:46 <sawrubh|ib> also any elegant way to switch my IB's nick to sawrubh and the irccloud one to something else when I connect using IB and when I disconnect IB, the irccloud one to automatically rename the nick to sawrubh
14:30:44 <sawrubh|ib> so the bug is that in http://i.imgur.com/s4VEfLd.png the irc icon besides the topic seems to be vertically elongated/aliased while the favicon on the tab isn't
14:31:22 <aleth> I can find bug 9544497 by searching for "icon" ;)
14:31:24 <clokep_work> sawrubh|ib: Not that I know of, no.
14:31:39 <aleth> bug 954497
14:31:41 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=954497 nor, --, ---, nobody, NEW, Unsharp MUC icon in infobar on conversation top (height is 1px too large)
14:47:20 --> mconley has joined #instantbird
15:13:04 --> jb has joined #instantbird
15:16:30 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:19:38 <-- aleth has quit (Ping timeout)
15:20:59 <clokep_work> sawrubh|ib: Btw did all that feedback make sense.
15:22:14 <sawrubh|ib> clokep_work: sorry I've just been a little distracted with all this switching between clients and trying to optimize my experience (automatic nick switching)
15:22:41 <sawrubh|ib> getting back to work and seriously taking a look at your feedback in a bit
15:23:31 <clokep_work> OK.
15:33:35 <-- qheaden has quit (Ping timeout)
15:34:28 --> qheaden has joined #instantbird
15:53:54 * qheaden has a conference where all users can see one another!
15:55:19 <qheaden> clokep_work: I think we have a complete fix!
15:55:22 <qheaden> I have to still do more testing.
15:57:22 <nhnt11> clokep_work: Do you use Tb?
15:57:48 --> nhnt11-tb has joined #instantbird
15:57:55 <-- nhnt11-tb has left #instantbird ()
15:58:14 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:58:39 <-- sonny has quit (Ping timeout)
15:58:52 <-- jb has quit (Connection reset by peer)
15:58:55 --> jb has joined #instantbird
16:08:32 --> aleth has joined #instantbird
16:08:32 * ChanServ sets mode +o aleth 
16:08:43 --> nhnt11-tb has joined #instantbird
16:08:49 <-- nhnt11-tb has left #instantbird ()
16:09:15 --> nhnt11-tb has joined #instantbird
16:09:29 <nhnt11-tb> Hmm
16:09:51 <nhnt11-tb> One of my changes causes a "aTimer.cancel is not a function" error :S
16:10:24 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
16:10:38 --> nhnt11-tb has joined #instantbird
16:22:47 <-- iamjayakumars has quit (Client exited)
16:32:41 <mayanktg> http://pastebin.instantbird.com/730794 the stanza looks now. Creating <rtp-hdrext/> (http://xmpp.org/extensions/xep-0294.html#sdp-mapping) and <rtcp-fb/> (http://xmpp.org/extensions/xep-0293.html#sdp-mapping) elements is confusing :-/ 
16:34:02 <aleth> All these acronyms are confusing. Looks like you managed though? :)
16:34:58 <-- gerard-majax_ has quit (Ping timeout)
16:35:08 <mayanktg> I still have to work on it :-|
16:38:48 <mayanktg> Also I'm getting \r\n in the last attribute of the line. :-/  for eg. in |a=candidate:0 1 UDP .... 52180 typ host| I get type="host\r\n"
16:43:10 <aleth> I don't understand. You mean you have trouble parsing the string?
16:43:25 --> iamjayakumars has joined #instantbird
16:43:56 <mayanktg> yes. The newline character is added. I'll figure this out :)
16:43:58 <aleth> Isn't the first thing you do sdp.split("\r\n")?
16:44:47 <aleth> After that there will be no more newlines ;)
16:44:58 <-- iamjayakumars has quit (Client exited)
16:45:25 --> iamjayakumars has joined #instantbird
16:47:04 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
16:47:24 <-- iamjayakumars has quit (Ping timeout)
16:47:30 <mayanktg> If I would have done that, I couldn't have separated two media elements, each line would have been split and i couldn't. I guess so. :-| ....anyways let me try that too :P
16:48:06 <aleth> Well maybe it shouldn't be the first thing you do then, but the third, or something like that ;)
16:49:51 <mayanktg> aleth: Yeppss, that's what I'm doing now..Thanks :)
16:51:57 <clokep_work> nhnt11: Yes.
16:52:01 <clokep_work> qheaden: Woot! :)
16:52:36 * aleth likes the sound of "complete fix" :)
16:52:49 <aleth> Ship it!
16:53:22 <-- sawrubh|ib has quit (Quit: sawrubh|ib)
16:53:24 <clokep_work> flo: Do we need to port anything for https://bugzilla.mozilla.org/show_bug.cgi?id=1017696?
16:53:27 <instantbot> Bug 1017696 nor, --, ---, philip.chee, ASSI, Use a JSON storage back-end in the Login Manager - SeaMonkey part
16:53:56 --> sawrubh|ib has joined #instantbird
16:56:12 <clokep_work> sawrubh|ib: Had a chance to look things over yet?
16:58:43 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:01:31 <sawrubh|ib> clokep_work: done! starting my replies to your comments below (except the one you explicitly wanted on the bug, although I think I can explain it to you here)
17:02:55 <sawrubh|ib> so re that adding the event listener to menulist for the onselect, I added the function but it didn't work (the function you see commented in addAccountDialog.js), do you see anything stupid there
17:04:09 <aleth> Yeah.
17:04:10 --> sonny has joined #instantbird
17:04:29 <sawrubh|ib> what was being done before is 'return addAccountDialog.accountTypeSelected();' which is exactly what I'm doing in that function yet, it doesn't work. What I mean by doesn't work is the addAccountDialog opens up but when I click on one of the providers the 'Setup Account' doesn't get activated
17:04:36 <sawrubh|ib> I assume the onselect handler isn't called
17:04:50 <aleth> For starters, the event isn't called "onselect".
17:05:05 * sawrubh|ib checks
17:05:07 <aleth> Then, there are no changes to addAccountDialog.xul, and there should be.
17:05:09 <-- nhnt11 has quit (Connection reset by peer)
17:05:25 <sawrubh|ib> no, I think I've made the changes
17:05:44 <aleth> They don't show up in the patch?
17:06:01 --> gerard-majax_ has joined #instantbird
17:06:13 * sawrubh|ib checks
17:07:43 --> Mook_as has joined #instantbird
17:08:20 --> nhnt11 has joined #instantbird
17:08:24 <-- gerard-majax_ has quit (Ping timeout)
17:09:16 <sawrubh|ib> aleth: ok, so I must've done something stupid. Yes the change to the xul isn't there, which I must've missed
17:09:27 <sawrubh|ib> but I didn't know the event wasn't called onselect
17:09:49 * sawrubh|ib checks what's the name of the event
17:10:13 <-- nhnt11 has quit (Ping timeout)
17:10:38 --> nhnt11 has joined #instantbird
17:12:45 <aleth> A useful page: https://developer.mozilla.org/en-US/docs/Web/Reference/Events
17:14:13 <nhnt11> clokep_work: Thanks for the trimleft link!
17:14:23 <nhnt11> I'm pretty sure it's an alias for regex, but good to know
17:14:40 * nhnt11 googled "javascript trim leading whitespace" but that wouldn't help since it's not in the standard
17:16:15 <sawrubh|ib> aleth: DOMMenuItemActive event?
17:16:17 <aleth> nhnt11: unlikely http://dxr.mozilla.org/mozilla-central/source/js/src/jsstr.cpp#1837
17:16:33 <aleth> sawrubh|ib: no, "select" ;)
17:16:58 * aleth would have said it before but thought it was obvious :-/
17:17:11 <nhnt11> aleth: Thanks! I read on some stackoverflow answer that String.prototype.trim is just an alias for regex, so...
17:17:22 <nhnt11> Looks like the mozilla implementation is more performant :)
17:19:50 <aleth> sawrubh|ib: Btw for the future, when you mark something r?, it means "I think this is ready to land". In particular, it means that as far as you know, all bugs in it are fixed. Otherwise, use f? ;)
17:26:23 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:26:30 --> nhnt11 has joined #instantbird
17:26:50 <sawrubh|ib> ok, it works
17:26:56 * sawrubh|ib moves to the next comment
17:28:12 <sawrubh|ib> aleth: I'll rename the class to bindHandler?
17:29:15 <clokep_work> nhnt11: I got there from an almost identical search. ;)
17:29:23 <clokep_work> sawrubh|ib: I'd like replies to things in the bug, unless you have questions.
17:29:55 <nhnt11> clokep_work: Did you add "mdn" in your query? :)
17:30:05 * nhnt11 shrugs
17:30:51 <clokep_work> No.
17:30:53 <aleth> sawrubh|ib: Name the class something which tells the reader what it refers to. I don't think "bindHandler" tells me much
17:32:06 <aleth> Why don't you simply put a class or an ID on the richlistbox and then use child selectors?
17:34:02 <aleth> Not that it matters really, whatever is easier.
17:36:02 <mayanktg> removed the "\r\n" -- successfully added the <rtp-hdrext/> -- I have to add the mysterious <rtcp-fb/> now!
17:36:45 <aleth> Just out of interest, what does rtp-hdrext mean?
17:37:27 <clokep_work> mayanktg: What do you mean you have to add it? Didn't you have all this mapped out already?
17:38:11 <-- sonny has quit (Ping timeout)
17:39:57 <mayanktg> aleth: It indicates which RTCP FB (RTCP Feedback) messages may be used in the given media session for the indicated payload type.
17:40:49 <aleth> ok
17:43:14 --> sonny has joined #instantbird
17:43:30 <mayanktg> clokep_work: I have mapped it out, but this one has a complication that it has multiple occurrences. If one is has a subtype it should be <rtcp-fb/> but if it has "trr-int" then it should be <rtcp-fb-trr-int/> :'(
17:46:02 --> flo-retina has joined #instantbird
17:46:02 * ChanServ sets mode +qo flo-retina flo-retina 
17:49:08 <clokep_work> Alright.
17:49:12 <clokep_work> So this is why we write tests? :)
17:53:55 <clokep_work> flo-retina: FYI I'm hoping to get sawrubh|ib's stuff in shape over the next few days for you to take a look at! :)
17:58:13 <sawrubh|ib> clokep_work: so setting the argument of 'paneFT.setAttribute("label", "File Transfers");' to the entity name, didn't work
17:58:13 <nhnt11> Bah
17:58:54 * nhnt11 is intrigued that a file needs to be cloned to get an accurate last modified time
17:59:00 <clokep_work> sawrubh|ib: I expected, but it was worth a try, right?!
18:00:55 * sawrubh|ib had tried using bundle.GetStringFromName but had issues
18:00:59 * sawrubh|ib will try again
18:01:40 <clokep_work> "had issues" is not super specific. :)
18:01:44 <sawrubh|ib> hehe
18:02:35 * nhnt11 tries to trace the order in which these gloda functions are called and what these arguments actually are
18:04:07 <sawrubh|ib> clokep_work: replied on the bug
18:05:17 <flo-retina> nhnt11: good luck! Or sorry :-|.
18:08:30 <-- sonny has quit (Ping timeout)
18:09:03 <sawrubh|ib> clokep_work: so right now the 'File transfers' gets added at the last (I'm doing it via addPane) are you super conscious about it's placement before 'Advanced'?
18:09:13 * sawrubh|ib expects yes but is just confirming ;)
18:09:27 --> sonny has joined #instantbird
18:09:46 <sawrubh|ib> I meant 'File transfers' pane in the preference panel
18:10:01 <clokep_work> sawrubh|ib: That's OK for now IMO.
18:10:29 <clokep_work> flo-retina: The results of the downloadUtils.convertByteUnits thing, does that have to go through a formatting string or just joined with a space?
18:11:16 <nhnt11> flo-retina: In the beginning of http://dxr.mozilla.org/comm-central/source/mail/components/im/modules/index_im.js#402, it compares the last modified time and returns Gloda.kWorkSync if nothing needs to be done. Is it okay to just not schedule the job in this case?
18:11:29 * clokep_work sighs.
18:11:35 <nhnt11> (i.e. why load the logs at all?)
18:11:46 <nhnt11> I don't know if kWorkSync is important somehwere though :-/
18:12:19 --> mpmc has joined #instantbird
18:13:36 <nhnt11> "The goal here is that code that is doing stuff synchronously yields with kWorkSync periodically to make  sure that it doesn't dominate the event-loop."
18:13:42 <aleth> clokep_work: https://mxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/mozapps/downloads/downloads.properties#101
18:13:45 <nhnt11> hmm
18:13:47 <-- jb has quit (Ping timeout)
18:13:50 <nhnt11> Looks like it's not important
18:14:02 <clokep_work> aleth: My thoughts too, OK. Thanks.
18:15:12 <aleth> clokep_work, sawrubh|ib: Can even use that properties file.
18:15:31 <aleth> And note the sizeUnknown case.
18:16:52 <clokep_work> aleth: Do you undesrtand the issues with handlers.xml?
18:17:01 <clokep_work> I don't really understand what's happening there. :-\
18:17:01 <aleth> clokep_work: Yes
18:17:44 <aleth> Handlers.xml is used by the Applications pane. The bindings get applied via CSS.
18:18:35 <aleth> In TB, the cloudfile pane code is in the same file as the applications pane (probably the stuff we have in that pane is in "Incoming", idk)
18:19:27 <aleth> So stuff goes wrong when that CSS is applied to the cloudfile pane, as handlers.xml expects those bindings to live in the applications pane.
18:19:50 <-- aleth has quit (Quit: exit stage left)
18:20:00 --> aleth has joined #instantbird
18:20:01 * ChanServ sets mode +o aleth 
18:20:40 <clokep_work> Hm. OK
18:21:15 <aleth> Basically crappy CSS from TB that has rules that apply to all richlistitems rather than being a bit more selective.
18:21:59 <clokep_work> So are we updating the TB code? Our code? I guess I'm confsued.
18:23:15 <aleth> What I'm a bit confused about is why we decided to have an Applications pane *and* a file transfer pane for IB, while in TB both together are the Attachments pane
18:24:08 <clokep_work> What I'm confused about is how those are related in TB. ;)
18:24:10 <aleth> clokep_work: I think the idea was to change the code for IB only here
18:24:25 <clokep_work> aleth: If you think they should be combined. I'm quite OK with that change.
18:24:35 <aleth> clokep_work: I don't know, I thought you decided that ;)
18:24:57 <clokep_work> aleth: I thought about it for < 5 s.
18:24:59 <aleth> I don't know TB well enough to understand the logic there. I guess it determines what happens to downloaded files
18:25:17 <clokep_work> Which I guess we theoretically will want to do too?
18:25:26 <aleth> I guess so.
18:25:56 <aleth> The pane is "Applications" in FX
18:26:57 <nhnt11> flo-retina: Btw, don't bother reviewing the gloda patch that's currently attached to the bug. There are quite a few changes...
18:27:03 * nhnt11 will cancel the review request
18:27:04 <-- clokep_work has quit (Ping timeout)
18:30:00 <flo-retina> nhnt11: ok
18:32:37 <nhnt11> Bah, this is ridiculously ugly imo: https://pastebin.mozilla.org/5364300
18:33:19 <nhnt11> I'm not considering changing the return on line 7 to a throw, and doing the stuff from line 9-29 in then()
18:34:15 <nhnt11> I should Task-ify this
18:34:34 <nhnt11> I should have Task-ified this long ago.
18:41:41 <nhnt11> Incredible improvement: https://pastebin.mozilla.org/5364373 :)
18:42:14 <aleth> Tasks to the rescue :)
18:43:30 <nhnt11> aleth: Btw, what's the scene with hasOwnProperty?
18:43:41 <aleth> What scene where?
18:43:45 <nhnt11> I've seen there are bugs to get rid of it, but I'm not sure what exactly we're replacing it or whatever
18:44:04 <nhnt11> replacing it with*
18:44:25 <aleth> Oh, it's when using objects as maps, then if property names by coincidence override methods in the prototype, things can break.
18:44:39 <nhnt11> I guess my question is,  is line 5 okay in that pastebin
18:44:40 <aleth> So now we have Map we don't need to worry about that.
18:45:05 <nhnt11> Oh no
18:45:16 * nhnt11 thinks converting gloda stuff to Maps is beyond the scope of this bug
18:45:27 <aleth> Looks OK to me.
18:45:32 <nhnt11> Alright
18:45:57 <aleth> Yeah, converting stuff to Maps is definitely not in your scope here.
18:49:22 <-- aleth has quit (Ping timeout)
18:54:00 * sawrubh|ib never imagined spaces would need to be localized too :P
18:57:04 <-- sonny has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:02:24 <mayanktg> aleth: http://pastebin.instantbird.com/730912 This is how the iq stanza looks now. I think its done, but I'll crosscheck it :)
19:08:01 --> arlolra has joined #instantbird
19:14:21 <-- mayanktg has quit (Ping timeout)
19:16:41 --> mayanktg has joined #instantbird
19:23:07 --> nhnt11-tb has joined #instantbird
19:23:59 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
19:25:48 --> nhnt11-tb has joined #instantbird
19:25:57 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
19:26:46 --> nhnt11-tb has joined #instantbird
19:26:56 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
19:27:15 --> nhnt11-tb has joined #instantbird
19:27:25 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
19:27:31 --> nhnt11-tb has joined #instantbird
19:28:07 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
19:28:34 --> nhnt11-tb has joined #instantbird
19:28:41 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
19:28:57 --> nhnt11-tb has joined #instantbird
19:29:04 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
19:29:25 <nhnt11> flo-retina: Is there a shortcut like |$./mach build im| for thunderbird?
19:29:45 <nhnt11> I tried ./mach build chat && ./mach build mail
19:30:18 --> nhnt11-tb has joined #instantbird
19:30:37 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
19:31:44 <flo-retina> I don't think there is
19:31:50 <nhnt11> :(
19:31:58 <nhnt11> ./mach build takes over a minute every time :-/
19:32:18 <flo-retina> you don't have to use mach
19:32:34 <nhnt11> $make from the objdir?
19:32:58 --> nhnt11-tb has joined #instantbird
19:33:44 <nhnt11> bah...
19:34:22 * nhnt11 adds a load of dumps
19:34:28 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
19:35:06 <flo-retina> make in the objdir will be as long as mac
19:35:07 <flo-retina> h
19:35:51 <flo-retina> but you can make -C objdir/mail/ for example
19:36:05 <flo-retina> don't forget to replace objdir/mail/app/ if you are on mac though ;)
19:36:22 <nhnt11> Hmm
19:36:33 <nhnt11> I think $./mach build mail works for -C objdir/mail
19:36:34 * nhnt11 will try
19:36:40 --> nhnt11-tb has joined #instantbird
19:37:30 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
19:46:20 --> nhnt11-tb has joined #instantbird
19:46:34 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
19:46:48 <nhnt11> flo-retina: https://pastebin.mozilla.org/5364650
19:46:53 <nhnt11> The code doesn't get past line 37 :-/
19:47:17 <nhnt11> Hmm, rather, it doesn't reach line 40. it does reach line 35
19:48:44 --> nhnt11-tb has joined #instantbird
19:49:06 <nhnt11> Aha...
19:49:19 <nhnt11> It never gets past aCache[fileName] = lastModifiedTime
19:49:20 <nhnt11> Duh
19:49:37 <nhnt11> I removed lastModifiedTime from that function :'(
19:49:38 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
19:51:05 * nhnt11 now needs to pass lastModifiedTime to that function
20:00:02 <-- mayanktg has quit (Client exited)
20:01:40 <nhnt11> Okay, I'm going to just set it in the Task that schedules the job. I was worried we may want to wait for the function to finish before setting it but I don't think so. If it's called again, it should certainly return if the old one hasn't completed yet.
20:03:49 --> mayanktg has joined #instantbird
20:05:33 --> nhnt11-tb has joined #instantbird
20:05:47 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
20:06:48 --> nhnt11-tb has joined #instantbird
20:07:32 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
20:08:10 --> nhnt11-tb has joined #instantbird
20:08:23 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
20:08:32 --> nhnt11-tb has joined #instantbird
20:09:02 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
20:09:32 --> nhnt11-tb has joined #instantbird
20:09:48 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
20:11:22 --> nhnt11-tb has joined #instantbird
20:11:36 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
20:15:41 --> sonny has joined #instantbird
20:20:22 <-- sawrubh|ib has quit (Ping timeout)
20:25:52 --> clokep has joined #instantbird
20:25:52 * ChanServ sets mode +o clokep 
20:26:38 <clokep> mayanktg: Your test sshould tell you if it's working or not. :-S
20:28:41 <mayanktg> clokep: Yes. First of all I'm checking the function with different types of offer. (Like one without media=audio etc.)
20:28:42 --> nhnt11-tb has joined #instantbird
20:29:00 <clokep> mayanktg: I don't see how that's related to my comment.
20:29:11 <clokep> Can you show me a diff of what you're doing? I want ot make sure you're not going down the wrong road.
20:29:43 <nhnt11-tb> Bah :(
20:29:54 <nhnt11-tb> "aTimer.cancel" is not a function
20:30:18 * nhnt11-tb searches for timers
20:32:05 <mayanktg> clokep: http://pastebin.instantbird.com/730973 Here's the diff of the patch
20:32:39 <nhnt11> bah
20:32:43 * nhnt11 finds the problem
20:33:10 <clokep> mayanktg: Why do you have a hard coded offer inside of your call function? :-\
20:33:24 <nhnt11> Or maybe not :S
20:33:57 <clokep> mayanktg: Where is the test?
20:34:05 <-- nhnt11-tb has quit (Client exited)
20:34:22 --> nhnt11-tb has joined #instantbird
20:34:27 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
20:34:33 <mayanktg> clokep: Because I was told to first create a function to convert the offer and then only proceed further
20:34:45 <mayanktg> clokep: Wait. its in another patch ..
20:35:27 --> nhnt11-tb has joined #instantbird
20:36:31 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
20:37:54 <mayanktg> clokep: Diff of test http://pastebin.instantbird.com/730974
20:38:35 <clokep> mayanktg: First, a trivial thing: you don't need to use a subscript loader for a module.
20:38:43 * nhnt11 dares to hand-edit a diff
20:38:50 --> nhnt11-tb has joined #instantbird
20:38:52 <clokep> Second, I find this test close to impossible to verify with all the \r\ns in there.
20:39:00 <clokep> You should try to find a better way to format it.
20:39:11 <clokep> (I'd suggest an array of strings that you join with \r\n.)
20:39:24 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
20:39:51 <mayanktg> clokep: Ok. I'll convert that into a readable string.
20:43:10 <clokep> mayanktg: I'm also confused at whether your code works or not. :-S
20:43:44 <mayanktg> :(
20:44:05 <clokep> Why :(? I don't understand.
20:44:34 <mayanktg> I'm receiving the stanza in the format I shared. http://pastebin.instantbird.com/730901 . I'll change then..
20:45:13 <mayanktg> I've only added intents to it.
20:45:30 <nhnt11> mayanktg: That input string looks like json, is it?
20:45:44 <nhnt11> If so you can create a proper object and stringify it (much more readable)
20:46:44 <mayanktg> Ok. I'm creating a proper offer for the input then. 
20:47:20 * nhnt11 can't figure out why aTimer.cancel isn't a function... it's definitely a timer :-/
20:50:36 --> nhnt11-tb has joined #instantbird
20:50:47 <-- nhnt11-tb has left #instantbird ()
20:52:56 --> nhnt11-tb has joined #instantbird
20:53:03 <-- nhnt11-tb has left #instantbird ()
20:53:13 <clokep> mayanktg: So, sometimes we ask you questions that you seem to immediately start working on, I think it'd be beneficial if you first answer our questions before assuming we're going to ask you to change something.
20:53:23 <clokep> Sometimes we just are trying to understand what the code does.
20:53:39 <clokep> Does the SDP request give you back an object or is it a string? 
20:54:06 <clokep> mayanktg: Also, where is that etherpad that has an exampple SDP and example XML?
20:55:41 <mayanktg> clokep: https://etherpad.mozilla.org/ib-sdp The example offer is at the end of the pad
20:56:36 <clokep> mayanktg: So you're const input variable doesn't look anything like that, that great concerns me.
20:58:17 <mayanktg> clokep: You mean the code won't work when I'll have a real offer not a hardcoded one?
20:58:59 --> nhnt11-tb has joined #instantbird
20:59:05 <-- nhnt11-tb has left #instantbird ()
20:59:19 <clokep> mayanktg: I have no idea. I'm saying your test doesn't make sense if your input doesn't match what a /real/ offer looks like.
20:59:32 * nhnt11 desperately starts adding dumps in imXPCOMUtils.jsm
20:59:46 <clokep> nhnt11: What's your problem?
20:59:48 <nhnt11> (in the hope of getting a stack trace)
21:00:05 <clokep> I have a feeling you need to take a step back. Take a deep breath and carefully look back over your changes.
21:00:34 <nhnt11> clokep: There's a clearTimeout that's getting called somewhere, but the only one I can find seems to act on what is definitely a Timer. Also, a dump that I added right above it never fires.
21:00:39 <nhnt11> So I need to find that clearTimeout call.
21:00:49 <clokep> OK.
21:00:53 <nhnt11> (it's throwing because the Timer apparently doesn't have a cancel function)
21:01:22 <mayanktg> clokep: Ok. How can I get the value of a real offer? Should I create an offer by myself?
21:01:40 <clokep> mayanktg: Didn't you just paste one into that etherpad? :-S
21:02:00 <clokep> If so, you can use that.
21:02:06 <clokep> If not...I'm confused at what you put in the etherpad.
21:02:08 --> nhnt11-tb has joined #instantbird
21:02:15 <-- nhnt11-tb has left #instantbird ()
21:03:06 --> nhnt11-tb has joined #instantbird
21:03:14 <-- nhnt11-tb has left #instantbird ()
21:03:32 <nhnt11> :)
21:03:34 <nhnt11> Stacks help
21:03:57 <nhnt11> I now know that the clearTimeout call is coming from findbar.xml
21:04:12 <nhnt11> What I don't know, however, is why any of my code is affecting things over there.
21:05:13 --> nhnt11-tb has joined #instantbird
21:05:20 <-- nhnt11-tb has left #instantbird ()
21:05:30 <clokep> mayanktg: Does my question make sense?
21:05:36 <mayanktg> clokep: I just added newlines to the offer to divide the contents and media. I'll analyze what I'm doing..
21:06:01 --> nhnt11-tb has joined #instantbird
21:06:08 <-- nhnt11-tb has left #instantbird ()
21:06:10 <clokep> I don't know what "I just added new lines to the offer to divide the contents and media" means or why it is necessary.
21:06:34 <nhnt11> Interesting!
21:06:41 <nhnt11> clokep: Do you have Tb open right now?
21:06:47 <clokep> nhnt11: Yes.
21:06:48 <nhnt11> (or can you help me test something?)
21:06:51 <nhnt11> 1 sec
21:07:01 <clokep> ...
21:07:03 <clokep> :P
21:07:09 --> nhnt11-tb has joined #instantbird
21:07:14 <-- nhnt11-tb has left #instantbird ()
21:07:42 <clokep> We don't merge logs from all contacts? :-S
21:07:44 <clokep> That's awkward.
21:07:50 <clokep> From all buddies of the same contact, rather.
21:07:52 <nhnt11> clokep: What?
21:07:53 <nhnt11> We do
21:07:58 <nhnt11> If you view logs from the blist
21:08:07 <clokep> But not from a conversation?
21:08:10 <clokep> Why is that any different?
21:08:17 <nhnt11> If you view logs from a conversation, it shows the logs for the account buddy you're talking with
21:08:24 <nhnt11> (i.e. for that imConversation)
21:08:26 <clokep> That makes no sense.
21:08:38 <nhnt11> I encountered this recently and I agree with you
21:08:49 <nhnt11> Should be a simple fix :)
21:09:01 <clokep> I hope so.
21:09:04 <-- sonny has quit (Ping timeout)
21:09:19 <nhnt11> |if (this.contact) showLogsForContact(...); else showLogsForConversation(...);|
21:09:58 <nhnt11> clokep: Never mind about helping me test something, sorry
21:10:41 --> igorko has joined #instantbird
21:11:48 --> nhnt11-tb has joined #instantbird
21:11:52 <-- nhnt11-tb has left #instantbird ()
21:11:59 --> nhnt11-tb has joined #instantbird
21:12:14 <nhnt11-tb> Thunderbird needs my reopen-last-conv addon ;)
21:12:35 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
21:13:26 <clokep> That needs to not be an add-on. :P
21:17:02 <arlolra> clokep: do you have sec?
21:17:16 <clokep> arlolra: Yes. I have to get me laundry in like 5 minute sthough.
21:17:46 <arlolra> ok
21:17:49 <arlolra> take a peek at https://gist.github.com/arlolra/c6ee91363f22e354498b
21:18:33 <arlolra> does it make sense to add a cancel bool to prplIMessage? or, is using the error field sufficient?
21:20:16 <flo-retina> arlolra: the error boolean indicates that the message itself is an error message (eg. "Failed to send a file to <contact name>")
21:20:45 <arlolra> flo-retina: I guess that answers it. thanks
21:21:23 <arlolra> flo-retina: the above gist is what we're looking like now
21:22:53 <flo-retina> making originalMessage settable doesn't seem exciting
21:23:35 <arlolra> the ui displays originalMessage though
21:24:11 <flo-retina> is this because in your case originalMessage is the encrypted message, and you need to replace it with the clear text version?
21:24:26 <arlolra> yes
21:24:47 <flo-retina> is this for outgoing or incoming messages (or both?)
21:25:02 <arlolra> incoming
21:26:14 <flo-retina> in your gist it seems to be for outgoing
21:26:42 <arlolra> oh, right, so both then
21:26:51 <arlolra> the addon is doing the incoming
21:27:08 <flo-retina> it's not clear to me what pushMsg/popMsg do
21:27:22 <flo-retina> these names tend to indicate a stack
21:27:23 <arlolra> I need to add comments
21:27:32 <flo-retina> but in popMsg you seem to be looking through the whole array
21:27:43 <arlolra> yes, bad naming
21:28:19 <arlolra> it's a buffer to store messages to display after sending. remember that purplexpcom doesn't write messages with context
21:29:32 <arlolra> flo-retina: remember this https://bugzilla.mozilla.org/show_bug.cgi?id=983347#c18
21:29:34 <instantbot> Bug 983347 nor, --, ---, arlolra, ASSI, Need different paths for displaying to the screen and sending over the wire
21:29:38 <flo-retina> I'm starting to wonder if we shouldn't have separate prplImessage and imIMessage interfaces
21:29:47 <flo-retina> the message/originalMessage stuff was already an awful hack
21:31:01 <arlolra> does storeMsg and findMsg sound better?
21:31:17 <flo-retina> and yes, I remember the libpurple API sucks there
21:31:46 <arlolra> :)
21:32:19 <flo-retina> that's better yes. You could also call it bufferMsg instead of storeMsg, as you are putting it in something named msgBuffer anyway
21:33:01 <arlolra> true true
21:33:58 <flo-retina> I still don't really understand how that code works
21:34:16 <flo-retina> isn't aMsg.message the encrypted text in one of the messages and the clear text in the other?
21:36:32 <arlolra> here's gist of the rot13 example using it https://gist.github.com/arlolra/ba1a0efe329952d09461
21:38:32 <arlolra> aMsg.message will be encrypted after "sending-message" observer
21:38:44 <arlolra> aMsg.originalMessage will be plaintext
21:38:56 --> nhnt11-tb has joined #instantbird
21:39:04 <-- nhnt11-tb has left #instantbird ()
21:40:09 <arlolra> the confusing bit is the only a string is sent to this.target.sendMsg(), so the returning aMsg is a new prplIMessage, not the same as the one stored in the buffer
21:40:39 <arlolra> that's to be compatible with the libpurple api
21:42:15 <arlolra> is any of this making sense? I'll be adding some comments so it's clearer
21:42:31 <flo-retina> nhnt11: it's possible what I said the other day about === vs == was wrong
21:43:01 <nhnt11> flo-retina: Why?
21:43:06 <nhnt11> Both work identically for reference types
21:43:19 <nhnt11> === doesn't do type conversion (which we don't want anyway)
21:43:54 <flo-retina> yeah, === works
21:44:05 <flo-retina> I just mean the case where I said == wouldn't have worked... it probably was ok.
21:44:19 <nhnt11> Yeah, == would work as well.
21:45:13 <flo-retina> nhnt11: I think the stuff I debugged that worked in debug builds was probably with an object used as a map, and |if ... in <object>| checks
21:45:20 <flo-retina> and that likely uses .toString
21:45:49 <nhnt11> Ah..
21:47:12 <nhnt11> flo-retina: Do you see anything in this diff that could cause a Timer to not have a cancel function? https://pastebin.mozilla.org/5365294
21:47:30 <nhnt11> Note that the timer is not null or undefined, because imXPCOMUtils checks for that.
21:47:46 <nhnt11> sorry let me change that to diff syntax
21:48:01 <nhnt11> https://pastebin.mozilla.org/5365308
21:48:34 <nhnt11> The timers that I am eying are this._knownConversations[...].scheduledIndex
21:48:52 --> nhnt11-tb has joined #instantbird
21:48:59 <-- nhnt11-tb has left #instantbird ()
21:49:32 <flo-retina> I don't see any timer in that pastebin
21:49:47 <nhnt11> flo-retina: There's one on line 126
21:49:51 <nhnt11> (it's set to null)
21:49:54 <nhnt11> But yeah nor do I really
21:49:58 <nhnt11> (no changes()
21:49:59 <nhnt11> ) *
21:50:07 <nhnt11> Lines 150 and 151 are never called :-/
21:50:33 <nhnt11> I put a try/catch around the cancel in imXPCOMUtils.jsm and got a stack
21:50:39 <nhnt11> It's being called from some findbar code
21:51:18 <nhnt11> Initially I had lines 125 and 126 in the Task, that caused the UI to break completely (the conversation panel and tab never got removed)
21:51:38 <nhnt11> I took them out of the task, which got the UI working correctly but didn't eliminate the error
21:52:02 --> Rym has joined #instantbird
21:52:04 <nhnt11> I need a break, brb.
21:52:10 --> nhnt11-tb has joined #instantbird
21:52:21 <-- nhnt11-tb has left #instantbird ()
21:53:05 --> nhnt11-tb has joined #instantbird
21:53:12 <-- nhnt11-tb has left #instantbird ()
21:54:42 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
21:54:52 --> nhnt11-tb has joined #instantbird
21:55:00 <-- nhnt11-tb has left #instantbird ()
21:55:11 <nhnt11> Ahhhh
21:55:29 <nhnt11> flo-retina: Removing the import for imXPCOMUtils.jsm from chat-messenger-overlay.js fixes it
21:55:50 <nhnt11> (I was importing it to use defineLazyModuleGetter for osfile.jsm)
21:55:54 <nhnt11> Interesting...
21:56:07 <flo-retina> isn't it already imported?
21:56:39 <nhnt11> Already = before my changes?
21:56:41 <nhnt11> If so, no.
21:56:58 <-- igorko has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
21:57:05 * nhnt11 randomly had the idea that this may be interfering with some other xpcomutils module imported by something else
21:57:06 <flo-retina> maybe I'm confusing with imServices
21:57:22 <flo-retina> why are you importing imXPCOMUtils to define lazy getters anyway?
21:57:23 <nhnt11> https://mxr.mozilla.org/comm-central/source/mail/components/im/content/chat-messenger-overlay.js#5
21:57:31 <flo-retina> XPCOMUtils.jsm from toolkit should be enough
21:57:35 <nhnt11> Should I be using XPCOMUtils?
21:57:37 <nhnt11> ok
21:58:03 --> nhnt11-tb has joined #instantbird
21:58:08 <flo-retina> imXPCOMUtils is totally know to break setTimeout. It should only be imported in JS modules and xpcom components that don't have a native setTimeout
21:58:14 <flo-retina> *known
21:58:17 <-- nhnt11-tb has left #instantbird ()
21:58:28 <nhnt11> Alright. Thanks!
21:58:43 <nhnt11> At least I learned something from the last >1 hour of debugging :(
22:03:20 --> nhnt11-tb has joined #instantbird
22:04:16 <nhnt11-tb> flo-retina: How do I view logs from Thunderbird?
22:04:20 <nhnt11-tb> I can't find UI for it :-S
22:04:54 <flo-retina> look in the sidebar
22:04:57 <flo-retina> the right sidebar
22:05:01 <flo-retina> there's a list of previous conversations
22:05:09 <nhnt11-tb> It's empty
22:05:30 * nhnt11-tb guesses that's a bug in his code
22:05:44 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:05:49 --> clokep has joined #instantbird
22:05:49 * ChanServ sets mode +o clokep 
22:06:27 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
22:08:21 --> nhnt11-tb has joined #instantbird
22:08:33 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:08:42 <arlolra> flo-retina: I added some comments https://gist.github.com/arlolra/c6ee91363f22e354498b
22:08:53 <nhnt11-tb> Hmm, definitely a problem with my code. works when I pop my patches
22:08:56 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
22:12:33 <nhnt11> brb
22:13:57 <arlolra> flo-retina: I'll add a cancel bool to prplIMessage. do you have a suggestion for originalMessage?
22:28:32 <flo-retina> not really. I'm just annoyed that we are about to make even more confusing an API that was already quite broken :-/.
22:33:11 <arlolra> sounds fun
22:33:43 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
23:16:10 --> nhnt11-tb has joined #instantbird
23:16:21 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
23:16:55 --> nhnt11-tb has joined #instantbird
23:17:08 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
23:17:58 --> nhnt11-tb has joined #instantbird
23:18:17 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
23:20:31 --> nhnt11-tb has joined #instantbird
23:21:01 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
23:21:21 --> nhnt11-tb has joined #instantbird
23:21:37 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
23:23:23 --> nhnt11-tb has joined #instantbird
23:23:39 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
23:25:19 --> nhnt11-tb has joined #instantbird
23:25:40 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
23:25:45 * nhnt11 sighs
23:27:32 --> nhnt11-tb has joined #instantbird
23:27:42 <-- clokep has quit (Ping timeout)
23:28:08 <-- nhnt11-tb has quit (Quit: nhnt11-tb)
23:28:15 --> nhnt11-tb has joined #instantbird
23:29:05 --> sonny has joined #instantbird
23:30:02 <-- arlolra has quit (Quit: arlolra)
23:50:10 --> BWMerlin has joined #instantbird
23:50:25 <-- mconley has quit (Input/output error)
23:53:30 <-- Rym has quit (Ping timeout)