#instantbird log on 06 04 2014

All times are UTC.

00:19:06 --> Tonnes has joined #instantbird
00:27:40 <-- Mook_as has quit (Quit: Mook_as)
00:31:56 <-- rosonline has quit (Client exited)
00:51:39 --> mconley has joined #instantbird
01:24:12 <-- sonny has quit (Ping timeout)
01:25:57 <-- nhnt11 has quit (Ping timeout)
01:27:07 --> nhnt11 has joined #instantbird
01:58:03 <-- mconley has quit (Input/output error)
02:00:38 <-- nhnt11 has quit (Ping timeout)
02:05:29 --> nhnt11 has joined #instantbird
02:08:06 <-- nhnt11 has quit (Ping timeout)
02:09:56 --> nhnt11 has joined #instantbird
02:16:02 <-- nhnt11 has quit (Ping timeout)
02:18:43 <-- clokep has quit (Ping timeout)
02:19:49 --> mconley has joined #instantbird
02:21:10 <-- mconley has quit (Input/output error)
02:21:38 --> mconley has joined #instantbird
02:22:46 --> nhnt11 has joined #instantbird
02:23:24 <-- mconley has quit (Ping timeout)
02:48:30 <-- nhnt11 has quit (Ping timeout)
02:49:45 --> nhnt11 has joined #instantbird
02:52:27 <-- nhnt11 has quit (Ping timeout)
02:53:20 --> nhnt11 has joined #instantbird
02:55:01 <-- nhnt11 has quit (Ping timeout)
02:56:18 --> nhnt11 has joined #instantbird
02:58:57 <-- nhnt11 has quit (Ping timeout)
03:00:13 --> nhnt11 has joined #instantbird
03:02:37 --> mconley has joined #instantbird
03:10:54 <-- nhnt11 has quit (Ping timeout)
03:12:03 --> nhnt11 has joined #instantbird
03:16:33 <-- nhnt11 has quit (Ping timeout)
03:17:08 --> nhnt11 has joined #instantbird
03:19:43 <-- nhnt11 has quit (Ping timeout)
03:21:10 --> nhnt11 has joined #instantbird
03:30:46 <-- mconley has quit (Input/output error)
03:31:14 --> mconley has joined #instantbird
03:33:00 <-- mconley has quit (Ping timeout)
03:35:58 <-- nhnt11 has quit (Ping timeout)
03:37:05 --> nhnt11 has joined #instantbird
03:50:35 <mayanktg> Hello
04:03:18 <sawrubh> Good morning!
04:03:36 * sawrubh is finally back to work
04:08:02 <nhnt11> Hi
04:09:12 <sawrubh> it was some good experience, met with a lot of people, did some User Research :)
04:09:40 <EionRobb> how many users did you research
04:09:46 <sawrubh> 28
04:09:48 <EionRobb> and did they give you their number when you were done with them
04:10:26 <sawrubh> I think the guys who had invited the people have their numbers, it was pretty well documented
04:11:10 <EionRobb> sounds like a wild party
04:11:30 <sawrubh> a lot of talking for sure, my throat still hurts a bit ;)
04:28:56 <nhnt11> Ah, the tree is open
04:45:39 --> Mook has joined #instantbird
04:55:01 --> gerard-majax__ has joined #instantbird
05:02:35 <-- gerard-majax__ has quit (Ping timeout)
05:31:44 <-- nhnt11 has quit (Ping timeout)
05:33:26 --> nhnt11 has joined #instantbird
05:34:53 <mayanktg> flo-retina, Mic, aleth, clokep: Ping. I need help in deciding the approach. Please tell when anyone of you are free.
05:35:48 <-- nhnt11 has quit (Connection reset by peer)
05:37:39 --> nhnt11 has joined #instantbird
05:39:05 --> gerard-majax__ has joined #instantbird
05:41:59 <-- nhnt11 has quit (Ping timeout)
05:42:24 * Mook looks for descriptions in the logs
05:43:18 --> nhnt11 has joined #instantbird
05:44:45 <-- Rym has quit (Ping timeout)
06:00:10 <mayanktg> here's the etherpad link https://etherpad.mozilla.org/Ib-Webrtc-XMPP for the same. I've added points about mapping SDP to Jingle. But I cannot decide how would I proceed from after mapping is done. :-|
06:01:45 <-- nhnt11 has quit (Ping timeout)
06:03:12 --> nhnt11 has joined #instantbird
06:12:46 <-- nhnt11 has quit (Ping timeout)
06:12:55 <-- EionRobb has quit (Quit: Leaving.)
06:13:51 --> nhnt11 has joined #instantbird
06:35:06 --> kramolnik has joined #instantbird
06:49:29 --> jb has joined #instantbird
07:03:04 <-- mayanktg has quit (Ping timeout)
07:04:45 --> mayanktg has joined #instantbird
07:12:49 --> Armada has joined #instantbird
07:12:55 <-- gerard-majax__ has quit (Ping timeout)
07:14:08 <-- jb has quit (Ping timeout)
07:15:22 <-- Armada has quit (Quit: Leaving)
07:15:29 --> jb has joined #instantbird
07:15:34 --> Armada has joined #instantbird
07:34:57 <-- mayanktg has quit (Ping timeout)
07:41:58 --> EionRobb has joined #instantbird
07:43:49 --> mayanktg has joined #instantbird
07:46:13 <-- mayanktg has quit (Client exited)
07:50:20 <-- jb has quit (Ping timeout)
07:52:42 --> mpmc has joined #instantbird
07:53:27 <-- Mook has quit (Quit: Mook)
08:00:53 --> flo-retina has joined #instantbird
08:00:54 * ChanServ sets mode +qo flo-retina flo-retina 
08:01:05 <-- flo-retina has quit (Input/output error)
08:01:08 --> flo-retina has joined #instantbird
08:01:09 * ChanServ sets mode +qo flo-retina flo-retina 
08:23:01 --> gerard-majax__ has joined #instantbird
08:27:05 --> sonny has joined #instantbird
08:29:56 <-- gerard-majax__ has quit (Ping timeout)
08:45:27 --> gerard-majax__ has joined #instantbird
08:47:36 <-- gerard-majax__ has quit (Ping timeout)
09:04:45 --> gerard-majax__ has joined #instantbird
09:08:44 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
09:12:01 <-- gerard-majax__ has quit (Ping timeout)
09:18:25 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:21:24 --> jb has joined #instantbird
09:21:28 <-- sonny has quit (Ping timeout)
09:21:51 --> sonny has joined #instantbird
09:25:15 <-- sonny has quit (Ping timeout)
09:39:12 --> flo-retina has joined #instantbird
09:39:12 * ChanServ sets mode +qo flo-retina flo-retina 
09:49:07 <sawrubh> http://dxr.mozilla.org/comm-central/source/mailnews/base/util/nsMsgUtils.cpp#533 what is this trying to do, we already can get the localized string by calling formatStringFromName
09:49:25 <sawrubh> what I think it's doing is trying to localize the decimanl point but I can't understand the point of it
09:52:09 <flo-retina> sawrubh: what's the context? (why are you looking at this specific C++ file that isn't used at all by Instantbird?)
09:52:10 <instantbot> c++ is evil
09:52:32 <flo-retina> are you asking why they localize the decimal point? (eg. it's "." in en-US, but "," in French)
09:52:40 <sawrubh> flo-retina: I need to port this function to JS in order to use in the panel for File Transfer I've added in the Preference Pane
09:52:55 --> gerard-majax_ has joined #instantbird
09:52:57 <flo-retina> which function?
09:53:02 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:53:07 <sawrubh> formatFileSize()
09:53:12 <flo-retina> isn't the panel coming from Firefox?
09:53:37 <flo-retina> or  maybe I'm just confused :-S
09:53:53 <sawrubh> no, I'm getting the Panel from Thunderbird since that's what has implemented FileLink
09:54:04 <flo-retina> which panel is this?
09:54:10 <flo-retina> do you have a screenshot?
09:54:20 <sawrubh> yeah, just a sec
09:55:17 <flo-retina> I would be surprised if the download manager didn't have a similar function somewhere
09:56:10 --> sonny has joined #instantbird
09:56:33 <-- sonny has quit (Client exited)
09:58:15 <sawrubh> flo-retina: http://i.imgur.com/LnwYOSm.png and http://i.imgur.com/Wl5cLHM.png
09:59:30 <sawrubh> flo-retina: http://pastebin.instantbird.com/728242 is the ported function until now
10:00:16 <flo-retina> ah, it's a preference pane!
10:00:27 <sawrubh> I need to add the localizing decimal part (I already can localize KB, GB etc using formatStringFromName so that's not a problem)
10:00:37 <flo-retina> I thought you were talking about a panel like the download manager panel in the Firefox toolbar
10:00:48 <sawrubh> sorry for the wrong terms
10:00:57 --> sonny has joined #instantbird
10:01:13 <flo-retina> your operating system likely has a way to screenshot only a window
10:01:27 <flo-retina> on windows (and often on Linux too) that's alt+print scr.
10:02:04 <sawrubh> I'm on Gnome and I do PrtSc button and it prints the whole visible space (I'll try alt+PrtSc)
10:02:49 <flo-retina> sawrubh: is https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Number/toLocaleString doing what you want?
10:04:22 <sawrubh> hmm, it says giving option as 'decimal' should do it, lemme try that
10:05:00 <flo-retina> I'm wondering if http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/DownloadUtils.jsm#443 isn't (most of) the function you are trying to reimplement
10:05:45 --> mayanktg has joined #instantbird
10:07:40 <sawrubh> it's also using toLocaleString internall http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/DownloadUtils.jsm#47
10:08:25 <sawrubh> hmm, I could use it :)
10:08:38 <sawrubh> I mean convertByteUnits
10:11:14 <mayanktg> flo-retina: http://xmpp.org/extensions/inbox/jingle-sdp.html defines a way to transport SDP over Jingle. it sends the sdp offer along with the initiation request. 
10:13:27 --> BWMerlin has joined #instantbird
10:13:39 <mayanktg> Could you tell what should be my approach towards the bug 1018060 ?
10:13:45 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1018060 nor, --, ---, mayanktg, NEW, Voice and video call support in XMPP using WebRTC
10:17:05 <flo-retina> mayanktg: can you ask more specific questions please?
10:21:12 <mayanktg> flo-retina: I don't know how to send the sdp offer over Jingle. The link here http://hancke.name/jabber/webrtc-xmpp-summit-13ph.pdf says that WebRTC uses SDP as an API, Jingle doesn't use SDP. So we would have to map SDP to Jingle. 
10:21:43 <flo-retina> have you read the XEPs we discussed the other day?
10:22:30 --> clokep has joined #instantbird
10:22:30 * ChanServ sets mode +o clokep 
10:22:40 <flo-retina> clokep: good morning :)
10:23:03 <clokep> flo-retina: Hello.
10:23:18 <mayanktg> flo-retina: Yes. I read them. It also had a map to SDP section, but it didn't specify how should we use them :-/ 
10:23:37 <flo-retina> ok, can you summarize what they said?
10:23:57 <mayanktg> Specifically we would need XEP: 0167 - Jingle RTP Session.
10:24:01 <mayanktg> flo-retina: Yes.
10:25:30 <mayanktg> Jingle 0167:  Send initiation and with description send the payload-type (media encoding) to the responder. 
10:25:37 <mayanktg> ...
10:26:33 <mayanktg> Then the responder upon receiving the request, sends session-accept and with the payload-type it supports.
10:27:38 <mayanktg> Now mapping needs to be done. I searched for what SDP description is and found the specification here http://tools.ietf.org/html/rfc4566.html#section-5
10:28:24 <flo-retina> what about http://xmpp.org/extensions/xep-0320.html ?
10:28:27 <-- kramolnik has quit (Ping timeout)
10:29:04 <mayanktg> The payload-type should be mapped to a media field defined in the RFC 4566: SDP
10:29:27 --> kramolnik has joined #instantbird
10:31:03 <sawrubh> clokep: morning
10:31:40 <flo-retina> mayanktg: so I really don't understand where you are stuck / what you are asking.
10:32:44 <clokep> nhnt11: Looks pretty closed to me. ;) https://tbpl.mozilla.org/?tree=Thunderbird-Trunk
10:33:53 <mayanktg> flo-retina: I'm unable to understand how and what should I send the offer to whom I want to make a call.
10:34:20 <flo-retina> mayanktg: here is what I would suggest: get an SDP from PeerConnection, and try to write the XML stanza by hand.
10:34:24 <flo-retina> do that in pastebin or etherpad
10:35:15 <mayanktg> Ok.
10:35:17 <clokep> sawrubh: Hello.
10:37:04 <sawrubh> flo-retina: so convertByteUnits makes 12.0 MB to 12.0,MB for some weird reason, I guess I'll just use toLocaleString
10:37:25 <flo-retina> sawrubh: the reason is that you haven't read the API description
10:37:46 <flo-retina> it returns an array of numeric values and units, you need to join them to build a string.
10:37:55 <flo-retina> the "," comes from the .toString method of Array.
10:42:21 --> chrisccoulson has joined #instantbird
10:43:27 <-- sonny has quit (Ping timeout)
10:46:41 <-- nhnt11 has quit (Ping timeout)
10:48:51 --> nhnt11 has joined #instantbird
10:50:03 --> rosonline has joined #instantbird
10:50:38 <-- nhnt11 has quit (Ping timeout)
10:51:49 <-- EionRobb has quit (Quit: Leaving.)
10:52:36 --> sonny has joined #instantbird
10:53:26 --> nhnt11 has joined #instantbird
10:54:44 <-- kramolnik has quit (Connection reset by peer)
10:55:29 --> kramolnik has joined #instantbird
10:57:00 <clokep> flo-retina: Any chance you'll be able to look at the nightly situation soon? :)
10:57:26 <flo-retina> I'm sleeping during the nights :-P
10:58:34 <-- nhnt11 has quit (Ping timeout)
10:59:12 <flo-retina> clokep: I have no idea of what's going on with the Windows VM
10:59:21 <flo-retina> I want Even to have a look there
10:59:29 <flo-retina> for the Linux situation, I'm not sure what we want to do
10:59:44 --> nhnt11 has joined #instantbird
11:01:26 <clokep> Alright. . .
11:03:14 <-- nhnt11 has quit (Ping timeout)
11:04:29 <-- mayanktg has quit (Ping timeout)
11:04:41 --> nhnt11 has joined #instantbird
11:05:37 <-- nhnt11 has quit (Connection reset by peer)
11:07:01 --> mayanktg has joined #instantbird
11:09:05 --> nhnt11 has joined #instantbird
11:10:45 <sawrubh> clokep: should we go with the text 'You've been sent a file : '<filename> at <link>'' for now then?
11:10:49 <-- nhnt11 has quit (Ping timeout)
11:12:00 <clokep> sawrubh: That's awkwardly worded, but it's OK for now, I suppose.
11:12:06 <clokep> No space before the :
11:12:11 <sawrubh> ok
11:13:15 --> nhnt11 has joined #instantbird
11:13:27 <clokep> And put quotes around the filename.
11:13:34 <clokep> Unless someone else has a better string. :)
11:13:40 * clokep is too tired to come up w/ strings right now. :-[
11:15:20 <-- clokep has quit (Ping timeout)
11:23:54 --> mpmc has joined #instantbird
11:39:25 <-- mayanktg has quit (Ping timeout)
11:39:33 --> mayanktg has joined #instantbird
11:54:24 <-- mayanktg has quit (Ping timeout)
11:54:35 --> aleth_web has joined #instantbird
11:56:44 --> mayanktg has joined #instantbird
12:10:37 <nhnt11> Hello
12:12:03 --> clokep_work has joined #instantbird
12:12:03 * ChanServ sets mode +o clokep_work 
12:13:08 <-- BWMerlin has quit (Quit: BWMerlin)
12:13:17 <nhnt11> flo-retina, aleth_web: I'm thinking of taking a break from the async stuff for a day and looking at the convbrowser (or maybe something else entirely), any thoughts?
12:13:57 <aleth_web> Sure, go ahead. It seems like you're waiting for a bunch of reviews anyway ;)
12:14:33 <nhnt11> aleth_web: I hope those reviews aren't too bad for you. Thanks for the time you've invested on that patch already.. :(
12:14:35 <aleth_web> Did you find out what was making your JSON undefined?
12:14:59 <nhnt11> aleth_web: yes, http://log.bezut.info/instantbird/yesterday/#m432
12:15:27 <aleth_web> heh
12:15:33 <aleth_web> unexpected consequences...
12:15:47 <nhnt11> I'd specifically added that return for tests, but then forgot about it and removed it when you asked why it was there. So yielding on that method started the operation but didn't actually wait for it...
12:16:06 <nhnt11> So then the rest of the task finished, and AsyncShutdown started doing its thing, and JSON was no longer available to the still-running promise.
12:16:27 * nhnt11 should have added a comment from the beginning like clokep said
12:16:35 <aleth_web> Makes sense, though it doesn't look like it was fun to debug ;)
12:16:59 <nhnt11> Not at all :( I'm glad I figured it out though, could've taken much longer tbh :-/
12:17:35 <clokep_work> :)
12:17:40 <nhnt11> Btw, when is it okay to push to a closed tree?
12:17:49 <nhnt11> (i.e. can I push bug 1018602?)
12:17:50 <clokep_work> nhnt11: Almost never.
12:17:51 <clokep_work> No.
12:17:51 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1018602 nor, --, ---, nhnt11, ASSI, "Your account has been reconnected" message not displayed in private conversations if the other part
12:17:53 <nhnt11> Alright then
12:18:30 <clokep_work> They're going to do metered check-ins today, I believe.
12:18:37 <aleth_web> Tree looks less bad than it did the other day
12:21:19 <instantbot> clokep@gmail.com changed the Resolution on bug 1012666 from FIXED to ---.
12:21:21 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1012666 nor, --, 1.6, nhnt11, REOP, Fix up checking if IRC topics are settable
12:21:30 <clokep_work> Yea...
12:23:10 <nhnt11> Why is that bug assigned to me? :S
12:23:38 * nhnt11 wonders if he set that by habit when he attached that bustage fix patch
12:25:03 <clokep_work> Most likely...why didn't you assign it back to me? :(
12:25:22 <nhnt11> clokep_work: yeah should've done that, sorry
12:32:08 <clokep_work> sawrubh: Btw if you don't agree or didn't just directly follow one of my comments, please note that when uploading your next patch.
12:34:35 <sawrubh> Ok
12:39:25 <nhnt11> Ah, I found a bug to work on (bug 1009284)
12:39:29 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1009284 min, --, ---, nobody, NEW, Joining throbber sometimes only shows top left corner
12:44:02 <aleth_web> You can always fix up some awesomebugs ;) Bunch of probably straighforward shutdown errors there iirc
12:46:20 <flo-retina> nhnt11: "when is it okay to push to a closed tree?" when you have approval from the people who were responsible for closing the tree; or when the patch you are pushing is fixing the reason for which the tree is closed.
12:46:34 <nhnt11> Cool.
12:51:17 <nhnt11> flo-retina: On that throbber bug, -moz-image-region auto; also fixes it and seems much cleaner
12:51:25 <nhnt11> I found it here: https://hg.mozilla.org/releases/comm-esr24/rev/4982d1f1e205#l12.52
12:51:50 <flo-retina> ok
12:52:09 * flo-retina added a -moz-image-region: auto; somewhere recently too
12:57:51 <flo-retina> nhnt11: do you really need the !important? Your previous patch didn't have it
12:59:05 <nhnt11> Hmm, no I don't.
12:59:26 * nhnt11 recklessly hand-edits the diff
13:01:42 <clokep_work> Uh oh.
13:03:35 <nhnt11> Uh
13:03:42 * nhnt11 accidentally removed the wrong patch from his queue
13:03:53 <nhnt11> Hooray for uploading stuff to Bugzilla
13:05:47 <aleth_web> Also, version your mq! ;)
13:05:47 <clokep_work> :)
13:05:51 <clokep_work> I've done that once or twice.
13:05:59 <aleth_web> mqexport is your friend.
13:06:02 * sawrubh recently started doing that
13:06:22 <sawrubh> however I don't know how to access those different versions of my mq's -_-
13:06:43 <aleth_web> Same commands as usual, just with a --mq
13:07:15 * nhnt11 will figure that out later
13:08:37 <-- mayanktg has quit (Ping timeout)
13:08:58 <sawrubh> do we place localized strings with no params in dtd files with ENTITY tags?
13:09:40 <aleth_web> dtd files are for XUL markup, properties files for JS
13:09:44 --> mayanktg has joined #instantbird
13:11:43 <sawrubh> https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Method/getString ah cool
13:14:22 <-- clokep_work has quit (Ping timeout)
13:15:42 --> clokep_work has joined #instantbird
13:15:42 * ChanServ sets mode +o clokep_work 
13:21:36 <flo-retina> mayanktg: so where is the pastebin or etherpad with the SDP <-> Jingle XML mapping that I asked you to do almost 3 hours ago?
13:22:31 <mayanktg> flo-retina: http://pastebin.instantbird.com/728373 I was trying o figure out how to convert the offer to  XML stanza 
13:22:46 <flo-retina> that pastebin is fully unrelated
13:22:55 <flo-retina> I see JS code in there
13:25:02 <mayanktg> :-| How will I create peerConnection then? 
13:25:46 <flo-retina> I don't care now. Please do what I asked you to do first.
13:26:28 <flo-retina> mayanktg: take an example of SDP. Paste that in an etherpad.
13:26:42 <flo-retina> then try to write _by hand_ the equivalent Jingle XML
13:26:53 <flo-retina> don't try to code it until you have a good understanding of what you are trying to code.
13:27:02 <mayanktg> Ok.
13:27:26 <flo-retina> and give me the pad URL as soon as you have the SDP
13:27:40 --> qheaden has joined #instantbird
13:34:14 --> iamjayakumars has joined #instantbird
13:35:03 <qheaden> Hello everyone!
13:35:12 <qheaden> clokep_work: So I'm getting closer to solving this Yahoo conference mess.
13:35:22 <flo-retina> :)
13:35:29 <qheaden> Debugging is a pain since it requires user interaction on multiple machines.
13:35:54 <qheaden> Last night I was tracing the code for inviting users and accepting invites, and I think I got a couple of packet key numbers wrong.
13:35:55 <clokep_work> qheaden: :) Nice.
13:36:45 <qheaden> What's stranger, the symptoms seem a little different when using all Instantbird clients vs. using an Instantbird client to host the conference and official Yahoo clients to join as invitees.
13:37:06 <qheaden> So I will continue my trace today and figure out what's going on.
13:37:38 <clokep_work> Or also an official Yahoo client as host and Instantbird as clients? ;)
13:37:59 <qheaden> :(
13:38:31 <qheaden> I performed my packet capture using all official clients. So after I fix my implementation to follow that exactly, things should work.
13:38:54 <mayanktg> flo-retina: https://etherpad.mozilla.org/ib-sdp
13:39:17 --> mconley has joined #instantbird
13:40:56 <flo-retina> mayanktg: I see JS code in there
13:41:24 <clokep_work> qheaden: Excellent. :)
13:41:55 <qheaden> If Yahoo ever announces in the near future that Yahoo messenger will be done away with, I will be forced to sue.
13:42:05 <clokep_work> Hahaha.
13:42:15 <clokep_work> We'll just have you start work on another protocol. :P
13:42:26 <qheaden> YMBird
13:42:41 <flo-retina> mayanktg: show me the local description that you get from PeerConnection
13:43:09 * nhnt11 wonders if qheaden is interested in wiresharking WhatsApp (er, for educational purposes)
13:43:43 <qheaden> lol
13:44:22 <qheaden> nhnt11: No, you aren't allowed to view pictures not meant for you to see.
13:44:27 <flo-retina> doesn't creating a whatsapp account require getting a new phone and sim?
13:49:58 <clokep_work> mayanktg: Do you understand what Florian is asking for? If not, please ask so we can be clearer in what we're saying.
13:50:25 <mayanktg> sorry I missed the ping.
13:50:49 <mayanktg> clokep_work: : How will I get that the local description?
13:51:04 <nhnt11> qheaden: Why wouldn't it be meant for you to see?
13:51:12 <nhnt11> I guess reverse engineering whatsapp has already been done though
13:51:22 <flo-retina> mayanktg: your previous experiment using the patch I gave you sends the SDP in plain text
13:51:30 <flo-retina> you can just use that if you have it around
13:51:44 <nhnt11> flo-retina: It does, but why do we need a new whatsapp account?
13:52:00 <flo-retina> to wireshark it you need to have at least one account, right?
13:52:27 <nhnt11> Oh, you're saying if the wiresharker doesn't already have whatsapp?
13:52:34 <flo-retina> yeah
13:52:44 <mayanktg> Ok. I'll have to apply the patch and see. Wait a min. I'lll figure out how the local descritption looks like
13:52:49 <flo-retina> there's no way I would install a new app and give it access to my whole list of contacts ;)
13:53:29 * nhnt11 shrugs.
13:54:50 <clokep_work> nhnt11: What bugs do you want to check in? I got approval to do a push.
13:54:59 <clokep_work> (I.e. I'll check them in for you with a few of mine!
13:55:00 <clokep_work> )
13:55:20 <nhnt11> clokep_work: bug 1009284, bug 1018602
13:55:23 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1009284 min, --, ---, nobody, NEW, Joining throbber sometimes only shows top left corner
13:55:24 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1018602 nor, --, ---, nhnt11, ASSI, "Your account has been reconnected" message not displayed in private conversations if the other part
13:55:28 <clokep_work> Thanks.
13:55:42 <nhnt11> Thanks to you as well :)
13:58:13 <mayanktg> flo-retina: Here's the offer http://pastebin.instantbird.com/728430
13:59:02 <flo-retina> ok
13:59:07 <flo-retina> so now, show us how you would parse it
14:01:16 <instantbot> clokep@gmail.com changed the Resolution on bug 1012666 from --- to FIXED.
14:01:18 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1012666 nor, --, 1.6, clokep, RESO FIXED, Fix up checking if IRC topics are settable
14:01:47 <instantbot> clokep@gmail.com changed the Resolution on bug 1009284 from --- to FIXED.
14:01:49 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1009284 min, --, 1.6, nhnt11, RESO FIXED, Joining throbber sometimes only shows top left corner
14:02:18 <instantbot> clokep@gmail.com changed the Resolution on bug 1017946 from --- to FIXED.
14:02:20 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1017946 min, --, 1.6, clokep, RESO FIXED, Kill usage of hasOwnProperty global
14:02:49 <instantbot> clokep@gmail.com changed the Resolution on bug 1018602 from --- to FIXED.
14:02:51 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1018602 nor, --, 1.6, nhnt11, RESO FIXED, "Your account has been reconnected" message not displayed in private conversations if the other part
14:03:06 <clokep_work> nhnt11: Thanks. :)
14:03:22 <nhnt11> clokep_work: Thanks. :)
14:05:03 <flo-retina> mayanktg: so, how do you start to parse it?
14:08:17 <mayanktg> flo-retina: Ok I understood what should my xml stanza look like. http://pastebin.instantbird.com/728451 
14:08:30 <mayanktg> ..
14:08:58 <clokep_work> mayanktg: Does that really look like an XMPP stanza to you? :-\
14:09:19 <mayanktg> No. 
14:09:35 <mayanktg> sorry but I'll have to modify it 
14:10:20 <mayanktg> in the form of <iq><jingle><content>...</jingle></iq>
14:10:56 <flo-retina> ok, so if we ignore the first two lines and the last line, you have split the sdp when you had \r\n
14:11:00 <flo-retina> that's a good start
14:11:25 <flo-retina> now you need to understand what all this data means, and find the equivalent in Jingle/XML of each of these lines
14:11:55 <mayanktg> Ok. 
14:30:26 <-- gerard-majax_ has quit (Ping timeout)
14:34:24 <aleth_web> mayanktg: You can stick that SDP pastebin in an etherpad and annotate each line with an explanation of what it is as a first step. (Etherpad conveniently allows multiple colours ;) )
14:35:09 <mayanktg> aleth_web: : I can figure out what most of the line means except for a few. I have already started marking about each of them.
14:35:30 <aleth_web> Sounds promising.
14:46:25 <nhnt11> FYI, I'm trying to get the convbrowser to display messages newest to oldest instead of oldest first.
14:47:47 <mayanktg> aleth_web: Ok. I cannot find equivalents for some of the values https://etherpad.mozilla.org/ib-sdp
14:47:48 <nhnt11> I think a) reversing the order, b) actually display only the first few, c) add the rest when scrolling is a logical to-do order
14:49:12 <mayanktg> aleth_web: I'm trying to figure about them too.
14:49:14 <clokep_work> nhnt11: I assume by "reversing" the order you mean the order they're added to the DOM, not the order they're displayed in the DOM?
14:49:15 <aleth_web> mayanktg: Don't write code yet.
14:49:23 <nhnt11> clokep_work: Yes.
14:49:45 <aleth_web> mayanktg: Do what flo asked you and write the XML directly into the etherpad.
14:49:45 <mayanktg> aleth_web: No. I'm not going to start until I've figured out
14:50:00 <aleth_web> Well, that etherpad contains a mix of code and pasted stuff.
14:50:24 --> Rym has joined #instantbird
14:50:25 <mayanktg> aleth_web: I removed the code 
14:50:53 <aleth_web> And as I mentioned in your other etherpad, I don't think you can use http://xmpp.org/extensions/inbox/jingle-sdp.html, it's a draft. Unless you can show to us why it's OK to use already.
14:51:52 <-- jb has quit (Ping timeout)
14:51:55 <aleth_web> mayanktg: So, keep going with figuring out the missing bits ;)
14:52:51 <nhnt11> aleth_web: Would it be okay to add the action with a variable that's initially false, and set the variable in then()?
14:53:09 <nhnt11> (talking about the nsContextMenu thing in the UI patch)
14:53:47 <mayanktg> aleth_web: Ok. Also when writing the XML stanza should I write the attribute values as it is? I mean for eg write the value of <fingerprint/> that has been given. right?
14:54:03 <nhnt11> Hmm, I don't think that question makes too much sense. Never mind.
14:54:27 <clokep_work> mayanktg: Yes.
14:54:43 <aleth_web> mayanktg: The goal is to produce valid XML.
14:55:13 <mayanktg> aleth_web, clokep_work: Ok :)
14:55:40 <aleth_web> nhnt11: Reversing the order they are added seems a useful experiment, at the very least you'll discover what the issues are
14:56:44 <nhnt11> :)
14:57:07 * nhnt11 will look at this nsContextMenu thing later, async makes his head hurt a bit at the moment.
14:57:07 --> jb has joined #instantbird
14:58:07 <aleth_web> mayanktg: The other goal is that you can explain to us what all those lines in the SDP are for ;)
15:03:14 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:39:53 --> gerard-majax_ has joined #instantbird
15:43:56 <-- gerard-majax_ has quit (Ping timeout)
15:52:50 <nhnt11> clokep_work, aleth_web: How do I push my mq to a different repo? can't find what to add in hgrc for it.
15:53:16 <nhnt11> Do I just add an hgrc in .hg/patches?
15:54:37 --> gerard-majax_ has joined #instantbird
15:57:35 <nhnt11> Ah, yes. that works.
16:03:46 <clokep_work> nhnt11: Yes.
16:03:51 <clokep_work> And then hg push --mq
16:04:34 <nhnt11> Already done :)
16:04:58 * nhnt11 sees a seemingly random "asynclogs.patch2" in his queue repo
16:15:02 <-- jb has quit (Ping timeout)
16:15:06 <flo-retina> mayanktg: so https://etherpad.mozilla.org/ib-sdp looks promising. What's still missing?
16:16:08 <-- gerard-majax_ has quit (Ping timeout)
16:16:12 <mayanktg> There are two sets of <candidate/> . I have created for one. 
16:16:12 <mayanktg> Where to put the Version, origin.... details
16:16:40 <mayanktg> In short all the parameters which are non striked off :-|
16:17:41 --> jb has joined #instantbird
16:17:50 <sawrubh> can I use 'chrome://' urls in import?
16:17:52 <sawrubh> I mean Cu.import()
16:18:47 <mayanktg> flo-retina: I had to find what they meant from XEP: 0166, 1067, 0180, 0320 and jingle-sdp. 
16:19:40 <clokep_work> sawrubh: You shuoldn't even /want/ to do that.
16:21:00 <sawrubh> ok, so I'll make it (the file I'm trying to include) a module then
16:21:32 <flo-retina> clokep_work: https://wiki.mozilla.org/ReleaseEngineering/PuppetAgain/Base_Images#CentOS_6.2_with_Kickstart I think that gives us the correct version of the OS ;)
16:21:43 <sawrubh> I was actually trying to move most of the content of the onDrop method content to an outside file
16:21:46 --> gerard-majax_ has joined #instantbird
16:21:52 <flo-retina> IIRC our failed attempt was with CentOS 6.3 (ie. the latest at the time)
16:22:12 <flo-retina> mayanktg: I don't think merging the 2 sets of candidates will work :-/
16:22:25 <clokep_work> sawrubh: Make it a js file and include it with a script tag.
16:22:35 <clokep_work> flo-retina: Nice! :)
16:22:52 <flo-retina> clokep_work: I'm a bit confused by all the puppet stuff though
16:23:02 <sawrubh> clokep_work: also do you have a better name for that method, I think handleDroppedFile sounds good
16:23:05 <mayanktg> flo-retina: Yes. They are different. I'm not merging them. They for eacg <content/>
16:23:48 <clokep_work> flo-retina: I don't know Puppet, we're using Salt from work, but the guys I work with have used Puppet and/or Chef before. I can ask questions of them if need be.
16:23:57 <clokep_work> sawrubh: I think that's better, yes. :)
16:24:21 <sawrubh> those are some interesting names btw :)
16:25:23 <flo-retina> mayanktg: if the stuff in VERSION, ORIGIN, SESSION NAME and SESSION TIMING is always the same, you can probably just skip it
16:25:30 <mayanktg> flo-retina: Updated with two <contents/> . Each one has their own candidate
16:25:46 <flo-retina> mayanktg: the important thing about the transformation from SDP to Jingle XML is that you need to be able to do the opposite transformation
16:25:55 <mayanktg> Ok.
16:26:17 <flo-retina> so if something is a constant, you can just re-add it as a constant when doing the XML -> SDP transformation
16:26:23 <-- gerard-majax_ has quit (Ping timeout)
16:26:57 <mayanktg> Okays. I understood it :)
16:27:45 <mayanktg> And how will I derive the variables? for eg. generate the fingerprint, pwd etc?
16:28:15 <flo-retina> isn't that the pwd="1ef8fe1ef670d3dd89098b03dac4b4ed" attribute that you already have transformed?
16:28:30 <flo-retina> err, <fingerprint xmlns="urn:xmpp:jingle:apps:dtls:0" hash="sha-256">
16:32:08 <mayanktg> sorry. How can we fetch these values from the offer we get? for eg.. get pwd="1ef8fe1ef670d3dd89098b03dac4b4ed" from the offer and put it in the xml-stanza? Am I clear?
16:34:57 <clokep_work> Aren't they right there in the SDP offer?
16:36:06 <aleth_web> You just have to parse the string.
16:36:41 <mayanktg> Ok..got it :)
16:38:50 <aleth_web> mayanktg: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String lots of useful methods ;)
16:43:04 <mayanktg> aleth_web: Thanks...I've understood it now :D
16:46:36 <-- sonny has quit (Ping timeout)
16:47:17 --> Mook_as has joined #instantbird
17:00:32 <-- kramolnik has quit (Ping timeout)
17:04:46 <clokep_work> Uh oh.
17:04:51 <clokep_work> I just pushed the wrong version of a patch. :( Crap.
17:05:48 <nhnt11> clokep_work: what happens now?
17:06:16 <sawrubh> Apocalypse ?
17:08:39 <clokep_work> nhnt11: I make another patch and have it mark it checkin-needed?
17:09:37 <nhnt11> clokep_work: I meant, will the bad patch be backed out and a new patch uploaded, or a diff between the correct one and the bad one, or what?
17:09:42 * nhnt11 is curious about procedures
17:10:14 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:12:42 --> sonny has joined #instantbird
17:12:45 * clokep_work is curious why you think there are procedures. ;)
17:13:19 <clokep_work> I'm going to ask the sheriff though.
17:15:49 <nhnt11> I figured since this kind of mistake is bound to happen often there's a standard way to deal with it
17:17:37 <clokep_work> There might be on m-c, and the correct way is almost definitely to back it out and then commit the proper version.
17:17:41 <clokep_work> I just did an interdiff though.
17:17:56 <clokep_work> I need to not mess up pushing my next bug. :-\
17:27:09 <mayanktg> aleth_web: Where should I put the constant values in the xml-stanza? for eg v=0, s=SIP Call, t= 0 0 :-o
17:30:20 <-- iamjayakumars has quit (Client exited)
17:39:17 <aleth_web> mayanktg: Like flo said: figure out what they mean, if the value really never changes regardless of what device you use and audio/video settings etc, then you don't have to send them at all via xml.
17:40:19 <mayanktg> aleth_web: Ok. I fetched the "answer" description and I'm comparing the values that didn't change at all.
17:41:10 <aleth_web> What does v and t stand for anyway
17:42:11 <-- jb has quit (Ping timeout)
17:42:16 --> nhnt11-testing has joined #instantbird
17:42:24 <nhnt11-testing> meh
17:42:39 * nhnt11-testing isn't having too much success with this insert in reverse thing.
17:43:04 <clokep_work> That wasn't really how I took what Florian said. . .
17:43:05 <nhnt11-testing> It works great when restoring a conversation from hold
17:43:13 <clokep_work> :)
17:43:15 <nhnt11-testing> Completely breaks while the conversation is going on
17:43:19 <mayanktg> aleth_web: v = version of the offer (its 0), and t = session start and endtiming. 
17:44:02 <aleth_web> mayanktg: I'd say for now just add a comment to those lines in the etherpad explaining that and see if you need them later.
17:44:37 <mayanktg> aleth_web: Ok.
17:45:23 <aleth_web> clokep_work: "so if something is a constant, you can just re-add it as a constant when doing the XML -> SDP transformation" seems to me to imply exactly the same as what I said?
17:46:01 <clokep_work> aleth_web: It's not saying "don't send it in the XML" to me. ;)
17:46:18 <clokep_work> But I haevn't really been paying attention so you're probably more in tune.
17:46:20 <aleth_web> If you send it, you don't need to re-add it, right?
17:46:45 <clokep_work> aleth_web: ... we need to ensure we're compatible with other clients too.
17:46:58 <clokep_work> nhnt11-testing: I'm impressed you got to that point so quickly, Do bubbles work?
17:47:12 <aleth_web> clokep_work: Sure.
17:47:37 <aleth_web> But I think that's some distance away.
17:48:09 <nhnt11> clokep_work: It was like a 2 line change. Bubbles "work" except that the bubble headers aren't displayed properly for grouped ones.
17:48:45 <nhnt11> I've been trying out tiny changes, haven't written much code. Trying to figure out the best approach
17:48:59 <sawrubh> clokep_work: http://pastebin.instantbird.com/728598 is the patch that I'm trying, is there something obviously wrong that I'm doing because it doesn't seem to work
17:49:25 <nhnt11> I've currently decided to leave the message adding code the way it is for incoming messages, and make it use the reverse thing for context.
17:49:27 <sawrubh> I've tried adding the script tag outside the binding too and that didn't work as weell
17:49:35 <clokep_work> sawrubh: Why are you adding everything to messenger.properties?
17:50:09 <clokep_work> Hmm....I forgot this was a binding.
17:50:18 <clokep_work> I'm not sure, let me check.
17:50:21 <sawrubh> because that's a properties file I have already created for storing strings required in cloudfile
17:50:34 <aleth_web> It should be called something else.
17:50:43 <aleth_web> cloudfile.properties maybe ;)
17:52:19 <clokep_work> Exactly.
17:52:28 <clokep_work> sawrubh: So you might have to use a susbcript loader.
17:52:29 <sawrubh> so I need passwordPrompt from that file in adding the account dialog part (which already used to refer to a properties called messenger.properties before I moved it from mail)
17:52:36 <sawrubh> so I didn't wanna change it
17:52:43 <clokep_work> aleth_web: Do you know if you can add a script element to XBL?
17:53:02 <clokep_work> ...
17:53:12 <clokep_work> sawrubh: OK It will have to get changed eventually.
17:53:26 <sawrubh> ok, then I'll rename it :)
17:53:54 <clokep_work> The other thing to do, of course, is that you can add the script tag onto the conversation window.
17:54:00 <aleth_web> clokep_work: I don't know.
17:54:08 <clokep_work> Or not put it in a separate js file. :(
17:55:01 <sawrubh> clokep_work: putting it in a separate file (because of the size of the method) was why I started :/
17:55:05 <aleth_web> Why not Cu.import a module?
17:55:24 <aleth_web> That's how I did it for the tag menu anyway.
17:55:34 <-- nhnt11-testing has quit (Client exited)
17:56:23 * sawrubh looks up how to make that file a module
17:56:26 <aleth_web> If this is really UI code for the conversation binding, I don't see why it can't remain in conversation.xml though.
17:56:57 <sawrubh> aleth_web: me and clokep_work thought it made sense to move it to a separate file for clarity
17:58:30 <aleth_web> Event handlers for the binding should definitely be in conversation.xml. Of course those can then call out to other stuff...
17:59:19 <sawrubh> ok, I'll make the uploadListener part a module, keep the rest in conversation.xml
18:00:05 <clokep_work> sawrubh: That sounds reasonable to me. :)
18:00:45 <aleth_web> Right.
18:01:04 <aleth_web> Just don't spend too much time on it if it becomes too complicated, at this stage.
18:01:20 <aleth_web> This can all be revisited in followups as file transfers get more involved.
18:02:30 <aleth_web> For your initial patches, the main goal should be that all the files are in the right places, referred to in the right way, the basic drag/drop stuff works, and nothing breaks in TB. That's already quite a lot...
18:06:56 * nhnt11 is now thinking of adding messages in batches
18:07:18 <nhnt11> Where each batch is prepended, but messages of the same batch are added to the batch in order (not reverse)
18:11:57 --> flo-retina has joined #instantbird
18:11:57 * ChanServ sets mode +qo flo-retina flo-retina 
18:18:58 <aleth_web> nhnt11: The answer to the questions you /wanted/ to ask about the context menu is probably "it's ok to make the Show Logs entry show up disabled, and enable it if there are logs, BUT only if we are over a nick, otherwise it has to be completely absent"
18:20:18 --> gerard-majax_ has joined #instantbird
18:39:02 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:39:07 --> nhnt11 has joined #instantbird
18:41:46 <-- Rym has quit (Ping timeout)
18:42:05 --> Rym has joined #instantbird
18:43:45 <mayanktg> aleth_web: Found out all the meanings of the values given in the offer :) Here's the pastebin of the xml stanza until now http://pastebin.instantbird.com/728664 and the definitions updated in the etherpad https://etherpad.mozilla.org/ib-sdp
18:44:38 <mayanktg> aleth_web: Sorry I was wrong about the v attribute :-/ . It is the version of the SDP.
18:46:53 <flo-retina> :)
18:48:37 <aleth_web> mayanktg: Looks good :)
18:48:41 <aleth_web> What XEPs is this using?
18:49:55 <mayanktg> It looks similar to 0320: Use of DTLS-SRTP in Jingle Sessions.
18:50:48 <flo-retina> note: the code doing this conversion definitely needs xpcshell tests!
18:52:52 <aleth_web> mayanktg: You mean, it's valid accordinng to that XEP? That sounds good.
18:53:01 <mayanktg> Ok.
18:53:39 <flo-retina> having an example of SDP and of its XML representation is a great start for the test ;)
18:54:58 <mayanktg> aleth_web: I was referencing it for the creation and it fit perfectly (keeping apart some of the values whose explanation I gave in the etherpad).
18:55:45 <-- sonny has quit (Ping timeout)
18:58:19 <mayanktg> flo-retina: What should be the next step now? :-o 
18:58:56 <flo-retina> what do you think should be the next step? :)
19:00:25 <mayanktg> To parse the offer and convert it to xml-stanza? 
19:06:28 <flo-retina> seems good :)
19:07:29 <aleth_web> You also need the inverse function.
19:08:52 <aleth_web> I guess that's the step after next...
19:09:29 <mayanktg> aleth_web: Yes. so that the callee could receive the offer ... and then again these two steps again for the "answer". Right?
19:09:52 <flo-retina> the answer is almost the same thing as the offer
19:10:43 <aleth_web> If you're lucky you'll have a function that maps sdp->xml that can handle both.
19:11:34 <aleth_web> As it looks from your example that the sdp data gets mapped to a set of content nodes.
19:12:36 * nhnt11 can't get bubbles grouping to work
19:16:48 <mayanktg> aleth_web: Yes. I will have to create <content/> for audio and video media and add description to it.
19:17:48 <nhnt11> Ah...
19:23:54 <-- aleth_web has left #instantbird ()
19:24:48 * nhnt11 reverts everything
19:32:03 <sawrubh> clokep_work: so regards to the ondrop not working with the conversation area (xul browser element) I just tested so the ondragenter and ondragover events are called but just the ondrop isn't
19:32:14 <sawrubh> I'm not sure why it isn't allowing the drop
19:32:29 * sawrubh wonders if flo-retina might have an idea
19:34:55 <sawrubh> http://pastebin.instantbird.com/728700 is the patch btw
19:36:13 <clokep_work> sawrubh: So the reason I asked is because you have something in your patch that obviously doesn't work then.
19:36:16 <clokep_work> That seems pretty wrong.
19:36:24 <clokep_work> Either don't put it on the browser too or fix it.
19:36:59 <sawrubh> yeah, I'm right now in that trying-to-fix part and need help with that :)
19:42:09 <clokep_work> I don't know why it wouldn't unless something is eating it before it bubbles to you.
19:42:50 <nhnt11> clokep_work: How do I get shutdown errors to appear in the error console?
19:42:54 <nhnt11> I mean, in my terminal*
19:43:06 <nhnt11> (i.e. make my terminal verbose..
19:43:07 <clokep_work> Open IB from a terminal and shut it down?
19:43:20 <nhnt11> That's what I've been doing
19:43:31 <nhnt11> Is there a way to get anything that goes to the error console to show up in my terminal as well?
19:43:47 * nhnt11 feels like he's missing an about:config flag
19:44:00 <sawrubh> clokep_work: any debugging tips that come to mind to find out this event-gobbler
19:44:19 <nhnt11> Hmm, maybe I need a debug build
19:44:19 <flo-retina> nhnt11: are you using a debug build or an optimized build?
19:44:39 <nhnt11> Optimized. I'll start a debug build then...
19:45:46 <flo-retina> sawrubh: add the event handler on the browser using addEventListener, and use a capturing listener
19:48:30 <clokep_work> sawrubh: Not really, no. Sorry.
19:49:06 <sawrubh> flo-retina: what's a capturing listener?
19:49:16 <clokep_work> sawrubh: Search MDC. ;)
19:49:48 <clokep_work> https://developer.mozilla.org/en-US/docs/Web/API/EventTarget.addEventListener has a huge paragraph on it
19:50:10 <flo-retina> wow, I'm not the only one who still thinks "MDC" rather than "MDN" :)
19:52:26 * nhnt11 is glad his debug-build-automation aliases still mostly work with c-c :)
19:53:40 <clokep_work> flo-retina: My keyword shortcut in Fx is still MDC. ;)
19:54:05 <flo-retina> heh :)
20:00:02 <nhnt11> wow, debug builds are fast!
20:00:09 <nhnt11> 11:54 :)
20:00:23 <flo-retina> yeah, they are now faster than opt builds
20:14:15 --> sonny has joined #instantbird
20:16:53 <sawrubh> flo-retina: so I've added something like 'browser.addEventListener("ondrop", this.dropHandler, true);' in a place where there are already some handlers being added, what I see is that when I try to drop a file it just bounces back (like from an area which is not droppable). Now I'm not sure if the ondrop event not bubbling and the file getting repelles are
20:16:53 <sawrubh> the same thing or one is causing the other
20:17:43 <flo-retina> what does mdn say about ondrop?
20:17:56 <flo-retina> or the other 2 event handlers you are touching
20:18:15 <sawrubh> so it said that for a target to be drop-ready it must cancel the dragenter and dragover events
20:18:22 * sawrubh searches for the article
20:18:54 <-- mconley has quit (Quit: NO CARRIER)
20:19:37 <sawrubh> "over an element that is a valid drop target, that is, one that cancelled the last dragenter or dragover event, then the drop will be successful, and a drop event will fire at the target" https://developer.mozilla.org/en-US/docs/DragDrop/Drag_Operations#drop
20:19:38 <flo-retina> sawrubh: you may want to try capturing listeners for these two too
20:20:24 <sawrubh> I'm not sure what it means when it says 'cancelled the last dragenter or dragover event'
20:20:48 --> mconley has joined #instantbird
20:20:58 <flo-retina> what's your code currently doing in these handlers?
20:21:47 <sawrubh> flo-retina: https://developer.mozilla.org/en-US/docs/DragDrop/Recommended_Drag_Types#Dragging_Files is what I followed for the ondragenter and ondragover handlers
20:21:59 --> kramolnik has joined #instantbird
20:22:12 <-- rosonline has quit (Ping timeout)
20:22:40 <flo-retina> ah, you are returning a boolean
20:22:52 --> EionRobb has joined #instantbird
20:23:21 <flo-retina> read https://developer.mozilla.org/en/docs/Web/API/event.preventDefault then :)
20:24:44 --> rosonline has joined #instantbird
20:26:14 <sawrubh> gah, event.preventDefault() fixed it
20:26:33 <EionRobb> preventDefault fixes all
20:27:15 * sawrubh remembers EionRobb said something similar about Promises too
20:27:24 <flo-retina> sawrubh: with the capturing listener, or without it?
20:27:31 <EionRobb> sawrubh: was it "Promises are made to be broken"?
20:28:41 <sawrubh> flo-retina: works both with and without the capturing listener
20:29:28 <sawrubh> EionRobb: I think so, yeah
20:29:38 <-- Rym has quit (Ping timeout)
20:30:00 <flo-retina> sawrubh: so is the MDN article wrong?
20:30:46 <sawrubh> https://developer.mozilla.org/en-US/docs/DragDrop/Recommended_Drag_Types#Dragging_Files seems to have a wrong example
20:31:01 <sawrubh> the other articles seem to be correct
20:32:11 <flo-retina> if that example was wrong, how come you were able to drag to the textbox?
20:32:34 <sawrubh> I was trying to reason that out myself
20:32:43 <sawrubh> why was it working for the textbox then :
20:33:31 --> Rym has joined #instantbird
20:39:02 <-- clokep_work has quit (Ping timeout)
20:57:16 <-- gerard-majax_ has quit (Ping timeout)
21:00:58 <-- sonny has quit (Ping timeout)
21:01:30 <mayanktg> flo-retina: I can now create the child elements of the stanza. ie. for each media device a <content/> is created and the child elements of <content/> is added to it. This is the xml stanza I've written from the offer string until now http://pastebin.instantbird.com/728773.
21:01:51 <mayanktg> I'll add attributes to it now :)
21:08:54 <flo-retina> ok
21:26:22 <-- kramolnik has quit (Ping timeout)
21:28:49 <nhnt11> flo-retina: Are you going to be online for a while?
21:29:00 <flo-retina> I'm still looking at your patches
21:29:14 <flo-retina> (I have the gloda one in front of me now)
21:29:44 <flo-retina> but I'm hoping to stop in half an hour
21:29:57 <nhnt11> flo-retina: Do you want me to respond to your comments in the bug or is IRC fine?
21:30:17 <flo-retina> answers would be better in the bug
21:30:24 <flo-retina> discussion is easier on irc
21:30:35 <nhnt11> ok
21:30:56 <-- Suiseiseki has quit (Ping timeout)
21:31:48 <nhnt11> flo-retina: Aren't == and === identical for reference types?
21:32:19 <nhnt11> BUT I'll change it to ===, it's probably clearer
21:32:30 <flo-retina> I suspect == just compares the result of .toString
21:33:00 <nhnt11> Hmm okay (I'll research that, but will change it to === either way)
21:34:14 <nhnt11> I'm going to answer stuff on IRC too, and then post the answers on BZ as well (I can type here as I read your feedback, and maybe a discussion might spawn from something I say)
21:34:19 <flo-retina> I remember debugging code years ago that worked in debug builds but not in opt build. The reason was usage of == and the debug build printing an hex representation of the pointer, and the opt build just printing the constructor name
21:34:34 <flo-retina> ok
21:34:45 <flo-retina> (btw, that was a painful bug to debug!)
21:34:48 <nhnt11> Wow, that must have been a pain
21:34:51 <nhnt11> yeah
21:35:18 <nhnt11> We do not want to return promise.then(cleanup cleanup), because this drops errors.
21:35:43 <nhnt11> cleanup wants to happen regardless of whether the operation succeeded or not. consumers don't care about the cleanup, they care about the result of the operation
21:36:14 <nhnt11> We could make cleanup propagate the error but I think the current way is simpler to understand while reading it
21:36:19 <nhnt11> er, more readable
21:38:45 <nhnt11> The reason aEntries (which is already an array) is wrapped in an array, is because the LogEnumerators accept an argument in the form [entrySet1, entrySet2, ...] where each entrySet is an array of paths of log files in a given folder
21:38:46 <flo-retina> so I was wondering if you are going to remove the map entry after each operation
21:39:17 <nhnt11> This allows LogEnumerators to be constructed from multiple log folders (for contacts and such - multiple buddies)
21:39:47 <flo-retina> wasn't using .concat before allowing the same thing?
21:39:52 <nhnt11> flo-retina: Do you want me to add a delay there?
21:40:17 --> sonny has joined #instantbird
21:40:18 <nhnt11> Not exactly.
21:40:26 <nhnt11> (1 minute)
21:41:20 <nhnt11> flo-retina: The old code was concating nsISimpleEnumerators returned by nsIFile.directoryEntries
21:41:55 <nhnt11> So we had an array of enumerators.
21:42:19 <flo-retina> "concating nsISimpleEnumerators" makes my head hurt :-D
21:42:33 <nhnt11> Now we have an array of arrays, because that's what OS.File.DirectoryIterator.nextBatch() returns.
21:42:34 <nhnt11> heh.
21:45:50 <flo-retina> where is the code flattening your array of array?
21:46:07 <nhnt11> flattening?
21:46:30 <flo-retina> _getEnumerator desperately needs a comment explaining what it takes as parameter and what it returns
21:46:56 <nhnt11> Hmm, yeah
21:47:11 <flo-retina> nhnt11: I don't see anything in _getEnumerator that deals with an array of array
21:48:00 <nhnt11> flo-retina: aLogArray is an array of arrays. That name needs to be changed.
21:48:13 <nhnt11> (Look at the DailyLogEnumerator constructor)
21:48:46 <nhnt11> There's a comment above that explaining what the parameter is..
21:48:56 --> Suiseiseki has joined #instantbird
21:49:49 <flo-retina> nhnt11: can't you simplify all of this by giving these enumerators only an array of paths, rather than an array of array?
21:49:52 <nhnt11> Maybe we actually just want to concat all these arrays
21:49:54 <nhnt11> Yeah
21:50:07 <flo-retina> please do :)
21:50:19 <nhnt11> Array of OS.File.DirectoryIterator.Entry, not paths ;)
21:50:20 * nhnt11 sighs
21:50:23 <flo-retina> this seems over complicated for no other reason than a leftover from the past
21:50:32 <flo-retina> yeah, you got what I mean :)
21:51:13 <nhnt11> Actually that constructor only uses the path, so that can likely be simplified further
21:52:49 <flo-retina> looking at that Thunderbird code also makes my head hurt ;)
21:52:49 <nhnt11> flo-retina: The logMessagePromise in LogWriter isn't redundant because it's used for initialization too.. i.e. for the first logMessage call logMessagePromise represents the initialization task, which is waited on before doing the logging.
21:53:17 <nhnt11> I do suppose we could make it an "_initialized" promise and call everything on it
21:53:22 <flo-retina> nhnt11: isn't that initialization a file operation?
21:53:55 <nhnt11> It's multiple file operations, as well as an append...
21:54:06 <-- mconley has quit (Input/output error)
21:54:07 <nhnt11> flo-retina: Init is complete when |this.path = path| is set
21:54:42 <nhnt11> (if anything throws, that's not set and I use that to prevent queuedLogMessage from doing anything)
21:55:10 <flo-retina> having 2 different promise queues per file still seems redundant
21:56:15 <nhnt11> Okay. I'll change it to _initialized, and call queuedLogMessage in its then() every time...
21:56:22 <nhnt11> (Without again setting it to the returned promise)
21:56:53 <nhnt11> That way we ensure initialization happens first but we maintain only one promise and there's no chaining
21:57:23 <nhnt11> Makes me a bit nervous though :S
21:59:11 * nhnt11 really needs to sleep
22:00:34 <nhnt11> flo-retina: Yes, I'm really saying that I'm opening and closing the file for each line. I discussed it on #perf and was assured that opens and closes are not expensive at the OS level.
22:00:38 * nhnt11 ran benchmarks as well
22:00:44 <nhnt11> I did figure you'd have an opinion on it though.
22:01:06 <flo-retina> bah, gloda :(
22:02:35 <nhnt11> flo-retina: So what that patch does is get the log conversation first, then schedule the job (if that obvious explanation makes your head hurt less by any chance :D)
22:02:52 <flo-retina> I had figured that part
22:03:03 <nhnt11> And to pass the log/conv around I set it on the job...
22:03:12 * nhnt11 figured that you figured that part but said it anyway
22:03:32 <flo-retina> nhnt11: the part that isn't clear is: are you opening every possible logged conversation and putting its content in memory before the actual indexing start
22:05:15 <nhnt11> When it's called for a given conv, the entire conversation from that log file is loaded before indexing starts, yes.
22:05:32 <nhnt11> I don't know if this happens for all convs before indexing starts
22:05:42 <flo-retina> if it happens for one conv that's OK
22:05:54 <flo-retina> if we are putting in memory _all_ conversations before indexing starts, we are in trouble
22:06:02 <nhnt11> flo-retina: Promise queues! Yay!
22:06:18 * nhnt11 sighs again
22:06:30 <flo-retina> gloda really doesn't seem to be based on async stuff (and even less promises)
22:06:49 <nhnt11> Nope, it doesn't.
22:06:56 <flo-retina> all that scheduling stuff was designed to have long actions with disk I/O happening in small chunks
22:07:41 <-- Armada has quit (Connection reset by peer)
22:07:48 <nhnt11> flo-retina: What we could do is maintain a promise queue in index_im.js, and call resolve on the current promise when indexIMConversation compeltes
22:07:52 <nhnt11> completes*
22:09:27 <flo-retina> oh btw, you are just adapting that file to use the new imILogger API, but it's still full of sync disk I/O (I probably couldn't really care less though :-])
22:10:00 <nhnt11> Expanding on that: have a variable called resolveCurrentPromise. Then, something like |currentPromise.then(new Promise((aResolve, aReject) => resolveCurrentPromise = resolve)|
22:10:12 <nhnt11> Then call resolveCurrentPromise() in indexIMConversation...
22:10:23 <nhnt11> Or have a Map of convId -> resolvePromiseForConv
22:10:29 * nhnt11 shakes his head vigorously
22:11:13 <nhnt11> The Promise constructor accepts a callback, and passes to this callback functions aResolve and aReject, which will resolve/reject it respectively
22:12:09 <flo-retina> hmm, yeah, if you don't open the second log file until the first job has been executed, we should be safe
22:12:34 * nhnt11 will try this out tomorrow
22:14:31 <flo-retina> reviews always take much longer than expected :-(
22:15:00 <nhnt11> Maybe you expected better patches :]
22:15:45 * nhnt11 was kidding, he thinks those patches are decent enough. </defensive mode>
22:16:39 <flo-retina> nhnt11: I don't think defensive mode is useful here
22:17:11 * nhnt11 was kidding again...
22:17:34 * flo-retina hopes none of his comments sounded aggressive :-]
22:20:38 <nhnt11> flo-retina: Thanks for the reviews, I'll churn out some new patches tomorrow. Good night!
22:21:25 <flo-retina> yeah, I'll spend my next evening reviewing patches for the same bug ;)
22:21:32 <flo-retina> nhnt11: good night! :)
22:23:16 --> mconley has joined #instantbird
22:37:54 <-- mconley has quit (Quit: NO CARRIER)
23:12:06 <-- flo-retina has quit (Ping timeout)
23:12:13 --> flo-retina has joined #instantbird
23:12:13 * ChanServ sets mode +qo flo-retina flo-retina 
23:13:33 --> clokep has joined #instantbird
23:13:34 * ChanServ sets mode +o clokep 
23:38:23 <-- rosonline has quit (Client exited)
23:44:10 <-- spiffytech has quit (Ping timeout)
23:44:44 --> spiffytech has joined #instantbird
23:49:04 <clokep> sawrubh: Any luck? I'd love to review a patch today or tomorrow. :)