#instantbird log on 06 02 2014

All times are UTC.

00:10:24 <-- Tonnes has quit (Ping timeout)
00:11:21 --> Tonnes has joined #instantbird
02:28:39 <-- clokep has quit (Ping timeout)
02:45:46 --> Rym has joined #instantbird
02:46:33 --> mconley has joined #instantbird
04:01:06 --> nhnt11 has joined #instantbird
04:01:14 <nhnt11> Hi
04:01:19 * nhnt11 's internet seems to have fixed itself overnight :)
04:07:04 <-- mconley has quit (Quit: NO CARRIER)
04:08:09 --> EionRobb has joined #instantbird
04:11:45 <-- nhnt11 has quit (Ping timeout)
04:12:36 --> nhnt11 has joined #instantbird
04:14:18 <-- nhnt11 has quit (Ping timeout)
04:15:25 --> nhnt11 has joined #instantbird
04:17:10 <-- nhnt11 has quit (Ping timeout)
04:18:11 --> nhnt11 has joined #instantbird
04:19:54 <-- nhnt11 has quit (Ping timeout)
04:21:02 --> nhnt11 has joined #instantbird
04:25:18 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
04:51:26 --> eson57 has joined #instantbird
04:55:23 <-- eson57 has left #instantbird ()
05:00:09 --> nhnt11 has joined #instantbird
05:00:11 <-- nhnt11 has quit (Input/output error)
05:00:17 --> nhnt11 has joined #instantbird
05:16:03 <-- nhnt11 has quit (Ping timeout)
05:16:59 --> nhnt11 has joined #instantbird
05:36:32 <-- nhnt11 has quit (Ping timeout)
05:37:18 --> nhnt11 has joined #instantbird
05:46:59 <-- nhnt11 has quit (Ping timeout)
05:49:10 --> mayanktg-ph has joined #instantbird
05:49:32 --> nhnt11 has joined #instantbird
05:56:57 <-- mayanktg-ph has quit (Client exited)
05:57:02 --> mayanktg-ph has joined #instantbird
06:05:29 --> mayanktg has joined #instantbird
06:05:55 <-- EionRobb has quit (Ping timeout)
06:06:47 <-- mayanktg-ph has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
06:08:26 --> EionRobb has joined #instantbird
06:11:55 <-- nhnt11 has quit (Ping timeout)
06:13:17 --> nhnt11 has joined #instantbird
06:15:00 <-- nhnt11 has quit (Ping timeout)
06:16:01 --> nhnt11 has joined #instantbird
06:18:40 <-- nhnt11 has quit (Ping timeout)
06:20:15 <-- mayanktg has quit (Connection reset by peer)
06:21:52 --> mayanktg has joined #instantbird
06:30:07 --> nhnt11 has joined #instantbird
06:34:25 <-- Rym has quit (Ping timeout)
06:36:51 --> mpmc has joined #instantbird
06:52:35 <-- nhnt11 has quit (Ping timeout)
06:53:12 --> nhnt11 has joined #instantbird
07:04:22 <-- nhnt11 has quit (Ping timeout)
07:05:15 --> nhnt11 has joined #instantbird
07:13:18 <-- nhnt11 has quit (Connection reset by peer)
07:14:28 --> nhnt11 has joined #instantbird
07:17:14 --> chrisccoulson has joined #instantbird
07:32:35 <-- nhnt11 has quit (Ping timeout)
07:33:14 --> nhnt11 has joined #instantbird
07:38:20 <-- nhnt11 has quit (Ping timeout)
07:39:11 --> nhnt11 has joined #instantbird
07:53:27 --> gerard-majax__ has joined #instantbird
07:56:25 <-- nhnt11 has quit (Ping timeout)
07:57:10 --> nhnt11 has joined #instantbird
08:09:10 --> jb has joined #instantbird
08:10:23 * nhnt11 has 225MB of logs
08:11:44 <EionRobb> that's a lot of wood
08:11:50 <nhnt11> :P
08:24:23 --> sonny has joined #instantbird
08:27:25 <-- nhnt11 has quit (Ping timeout)
08:28:35 --> nhnt11 has joined #instantbird
08:47:08 --> flo-retina has joined #instantbird
08:47:08 * ChanServ sets mode +qo flo-retina flo-retina 
09:17:00 <-- nhnt11 has quit (Ping timeout)
09:18:10 --> nhnt11 has joined #instantbird
09:20:47 --> BWMerlin has joined #instantbird
09:35:23 <-- nhnt11 has quit (Ping timeout)
09:36:11 --> nhnt11 has joined #instantbird
09:53:53 <-- flo-retina has quit (Ping timeout)
09:55:20 <-- nhnt11 has quit (Input/output error)
09:55:22 --> nhnt11 has joined #instantbird
09:58:49 <-- nhnt11 has quit (Ping timeout)
09:59:37 --> nhnt11 has joined #instantbird
10:05:21 <-- nhnt11 has quit (Ping timeout)
10:06:11 --> nhnt11 has joined #instantbird
10:11:22 <-- nhnt11 has quit (Ping timeout)
10:16:56 --> clokep has joined #instantbird
10:16:57 * ChanServ sets mode +o clokep 
10:17:14 --> nhnt11 has joined #instantbird
10:25:18 --> flo-retina has joined #instantbird
10:25:18 * ChanServ sets mode +qo flo-retina flo-retina 
10:32:26 <-- sonny has quit (Ping timeout)
10:44:09 --> sonny has joined #instantbird
10:45:55 <-- sonny has quit (Ping timeout)
10:53:46 --> sonny has joined #instantbird
10:56:02 <-- mayanktg has quit (Ping timeout)
10:56:05 --> mayanktg has joined #instantbird
10:58:36 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:08:07 <-- EionRobb has quit (Quit: Leaving.)
11:20:15 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:30:51 <-- nhnt11 has quit (Ping timeout)
11:31:11 --> nhnt11 has joined #instantbird
11:45:37 <-- sonny has quit (Ping timeout)
11:47:01 <-- nhnt11 has quit (Ping timeout)
11:47:46 --> nhnt11 has joined #instantbird
11:52:15 <-- nhnt11 has quit (Ping timeout)
11:53:50 --> nhnt11 has joined #instantbird
11:56:32 <-- nhnt11 has quit (Ping timeout)
11:58:02 --> nhnt11 has joined #instantbird
12:03:33 <-- nhnt11 has quit (Ping timeout)
12:04:40 --> nhnt11 has joined #instantbird
12:11:47 <-- nhnt11 has quit (Ping timeout)
12:13:04 --> nhnt11 has joined #instantbird
12:21:19 <-- nhnt11 has quit (Ping timeout)
12:23:11 --> nhnt11 has joined #instantbird
12:26:36 --> sonny has joined #instantbird
12:35:32 <-- sonny has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:35:57 --> sonny has joined #instantbird
12:39:42 <-- jb has quit (Ping timeout)
12:40:24 <-- BWMerlin has quit (Quit: BWMerlin)
12:41:45 --> jb has joined #instantbird
12:42:11 --> jb1 has joined #instantbird
12:42:16 <-- jb has quit (Connection reset by peer)
12:44:31 <-- nhnt11 has quit (Ping timeout)
12:45:25 --> nhnt11 has joined #instantbird
12:51:35 <-- nhnt11 has quit (Ping timeout)
12:52:24 --> nhnt11 has joined #instantbird
12:53:33 <-- mayanktg has quit (Ping timeout)
12:54:10 <-- nhnt11 has quit (Ping timeout)
12:54:52 --> mayanktg-ph has joined #instantbird
12:55:34 --> nhnt11 has joined #instantbird
13:06:11 <mayanktg-ph> I studied aboit XMPP standards as much as I could. I can now send cknsole message on receive of iq stanza. Will try to add notification to user and session-initiation-feedback to the caller today.
13:06:41 <mayanktg-ph> *about *console
13:15:46 <-- nhnt11 has quit (Ping timeout)
13:16:35 --> nhnt11 has joined #instantbird
13:17:20 --> aleth has joined #instantbird
13:17:20 * ChanServ sets mode +o aleth 
13:26:40 --> clokep_work has joined #instantbird
13:26:40 * ChanServ sets mode +o clokep_work 
13:27:10 <clokep_work> mayanktg-ph: Cool. You're just waiting for reviews on your other bugs, right?
13:28:18 <mayanktg-ph> clokep_work: Yes on two right now.
13:38:21 --> mayanktg has joined #instantbird
13:38:29 <-- mayanktg-ph has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
13:38:59 <clokep_work> Alright.
13:49:33 <-- mayanktg has quit (Ping timeout)
13:53:39 <flo-retina> hmm, how come I have no caret in the input box in the conv window? :-S
13:53:52 <flo-retina> ah, focusing another window and then Ib again 'fixed' it
13:54:27 <nhnt11> flo-retina: Did the window seem to be not focused, but actually was?
13:54:35 <nhnt11> i.e. greyed out title bar etc
13:54:36 <flo-retina> kinda, yes
13:54:38 <flo-retina> no
13:54:47 <flo-retina> well, the title bar is always grey on Mac ;)
13:54:49 <nhnt11> Just the input box then..
13:54:54 <nhnt11> I meant the text in the title bar
13:55:01 --> mayanktg has joined #instantbird
13:55:04 <nhnt11> (the title bar is a much lighter shade for unfocused windows)
13:55:30 <nhnt11> I saw that a couple of days ago, window was identical to an unfocused one but was receiving input
13:55:32 <flo-retina> nhnt11: I didn't play very close attention to that part of the window, but I suspect I would have noticed if something was unusual
13:55:34 <nhnt11> Couldn't reproduce it though
13:55:52 <nhnt11> I noticed it because I was typing and there was no caret ;)
14:08:09 <-- nhnt11 has quit (Ping timeout)
14:09:36 --> nhnt11 has joined #instantbird
14:13:08 <-- nhnt11 has quit (Ping timeout)
14:18:15 --> nhnt11 has joined #instantbird
14:24:15 <-- nhnt11 has quit (Ping timeout)
14:24:17 --> nhnt11 has joined #instantbird
14:26:53 <-- nhnt11 has quit (Ping timeout)
14:27:52 --> nhnt11 has joined #instantbird
14:30:30 <-- nhnt11 has quit (Ping timeout)
14:34:41 --> nhnt11 has joined #instantbird
14:36:29 <-- nhnt11 has quit (Ping timeout)
14:37:34 --> nhnt11 has joined #instantbird
14:38:06 --> Rym has joined #instantbird
14:40:12 <-- nhnt11 has quit (Ping timeout)
14:40:23 <-- mayanktg has quit (Client exited)
14:41:00 --> nhnt11 has joined #instantbird
14:45:49 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:51:18 <clokep_work> nhnt11: Are you waiting for feedback too?
14:52:29 <nhnt11> Nope, getting to work now..
14:52:35 * nhnt11 addressed aleth's comments this morning
14:58:12 <-- aleth has quit (Ping timeout)
14:59:28 --> aleth has joined #instantbird
14:59:28 * ChanServ sets mode +o aleth 
15:03:53 --> mconley has joined #instantbird
15:07:58 <-- nhnt11 has quit (Ping timeout)
15:08:51 --> nhnt11 has joined #instantbird
15:10:34 <-- nhnt11 has quit (Ping timeout)
15:11:49 --> nhnt11 has joined #instantbird
15:13:37 <-- nhnt11 has quit (Ping timeout)
15:16:04 --> nhnt11 has joined #instantbird
15:16:09 <nhnt11> aleth: ping
15:16:37 <nhnt11> Can you look at a diff for nits? There are a couple of variable renames.
15:16:51 <aleth> ok
15:17:29 <nhnt11> aleth: Btw, yes, _accountName is normalized already. It's read from the log header, which is normalized.
15:19:14 <-- nhnt11 has quit (Ping timeout)
15:20:07 --> nhnt11 has joined #instantbird
15:21:45 <nhnt11> http://pastebin.instantbird.com/726208
15:21:47 <nhnt11> aleth: ^
15:22:39 <nhnt11> I've used "this._entryPaths" instead of "this._paths" to avoid confusion "this._path" btw.
15:22:53 --> flo-retina has joined #instantbird
15:22:53 * ChanServ sets mode +qo flo-retina flo-retina 
15:22:55 <aleth> good idea
15:23:50 <nhnt11> Hmm, I've used "clearUsedPromise" as the function name but in the comment I've said "clear unused promises"
15:24:08 <nhnt11> not sure which one to change :]
15:25:24 <aleth> Just call it cleanup() ? ;)
15:25:26 <nhnt11> aleth: Btw, I wanted to ask if checking on aEntries.length is enough and Array.isArray isn't required. The answer I came up with is that the constructor isn't exposed to consumers anyway, but then why would we need the throw in the first place?
15:25:29 <nhnt11> Ah, good idea.
15:26:26 <aleth> I don't know why that throw was added there originally. Probably to detect bugs in the calling code, for which tests are preferable.
15:27:08 <nhnt11> Hmm
15:27:34 <nhnt11> If the calling code had bugs, we'd see an error anyway I guess.
15:27:37 * nhnt11 shrugs
15:28:30 <aleth> Anyway, we don't usually check callers pass the right type as an argument, so an Array.isArray check seems unnecessary,
15:28:44 <nhnt11> okay
15:28:59 <aleth> The throw kind of makes sense to me because one could asssume it's OK to call with an empty array.
15:29:08 <nhnt11> Hmm yeah.
15:29:34 <clokep_work> Array.isArray is a better check than length for checking if somethign is an array. ;)
15:29:40 <clokep_work> But I don't really have tonext here.
15:29:41 <clokep_work> have context
15:29:51 <aleth> On line 15, you can drop " being done on them"
15:30:44 <aleth> Line 59 -  "For a set of files - the time extracted, reduced to the day." I don't think this is true for the input, only for the output
15:31:12 <nhnt11> Ah, that comment was for the arguments, duh
15:31:30 <nhnt11> :[
15:31:32 <nhnt11> :]*
15:31:58 <aleth> So on line 85, change the error message in the throw as we just discussed
15:33:10 <aleth> Generally, you don't need the .bind(this) in the argument of Task.async iirc
15:33:57 <aleth> Btw, it's probably also about time now to add a TB patch, and in particular take a look and check that the gloda indexing still works.
15:36:51 <aleth> Btw have you *checked* that just calling cleanup() on promise rejection won't change the state of the promise returned by then() to resolved with value undefined?
15:37:29 <nhnt11> aleth: Why does it matter?
15:37:36 <nhnt11> We're not using the returned promise
15:37:43 <nhnt11> Promises are immutable
15:37:50 <nhnt11> So the original promise does not change
15:38:23 <aleth> OK, that makes sense.
15:39:23 <aleth> Looking good then.
15:39:30 <aleth> How are you doing with the tests?
15:39:49 <nhnt11> Not very good :(
15:40:00 <nhnt11> I'm going to get them done (or ready for feedback/review) tonight
15:40:33 <nhnt11> Btw, I have no clue how gloda works, fyi.
15:40:40 <aleth> You don't need to.
15:40:46 <nhnt11> Okay.
15:40:50 <aleth> Just make sure whatever used to be called still is called ;)
15:41:05 <aleth> (to index the logs)
15:41:16 <nhnt11> Ah. Does that use the imILogger API?
15:41:19 * nhnt11 will check
15:41:22 <nhnt11> First, tests.
15:41:35 <nhnt11> Once there's substantial progress there I will start looking at Tb
15:42:10 <aleth> You don't need a super huge number of tests, just enough to cover that things work and handle edge cases properly
15:42:49 <clokep_work> nhnt11: It'd be pretty bad if it didn't use imILogger. :( THat's what it's there for.
15:43:02 <aleth> e.g. you can log dummy convs and then read them and compare, which should already cover a lot.
15:43:05 <nhnt11> clokep_work: Then it will certainly need to be updated.
15:43:34 <nhnt11> aleth: Right, I kept getting stuck with trivialities (like my tests weren't being called, and imports, etc) and then the weekend came and I was a little demotivated
15:44:04 <clokep_work> nhnt11: Hopefully it can be updated fairly easily. :)
15:44:06 <aleth> Also if it didn't use imILogger I wouldn't have mentioned it ;)
15:44:46 <nhnt11> Shouldn't be hard to update it. Probably just change | foo(); bar; | to | foo.then(bar); |
15:44:46 <aleth> nhnt11: Tests are not fun until you're sort of halfway done with them, and then when you have the framework written they're OK.
15:46:00 <flo-retina> note: JSON logs were added _for_ gloda ;)
15:46:15 <nhnt11> aleth: I just found a bug
15:46:25 <nhnt11> If an operation is queued on a rejected promise, it will never execute
15:46:41 <nhnt11> trivial fix, thankfully
15:46:54 <aleth> Right :)
15:47:34 * nhnt11 spends quite a bit of time re-reading this async stuff
15:47:37 * aleth wasn't wrong with his feeling that the queue needed tests ;)
15:48:00 <aleth> Well, after this bug, you'll really know it.
15:51:18 <nhnt11> Hmm, I'm surprised there isn't a shortcut method for promise.then(foo, foo)
15:51:34 <-- gerard-majax__ has quit (Ping timeout)
15:51:36 <nhnt11> I've used it twice already, doesn't seem like a rare thing
15:51:42 * nhnt11 doesn't like how then(foo, foo) looks
15:51:44 <clokep_work> What's that do?
15:52:02 <nhnt11> clokep_work: Calls foo regardless of whether the promise resolved or rejected
15:52:11 <nhnt11> Kinda like a finally
15:52:13 <aleth> I think it's probably an antipattern, outside of rare cases like yours.
15:52:20 <nhnt11> Maybe.
15:52:34 <aleth> But it might just be because it's an experimental API :P
15:52:36 <nhnt11> aleth: It's an async finally, and finally isn't that rare is it?
15:52:38 <nhnt11> Maybe.
15:53:11 <nhnt11> Maybe I should add it to the implementation :D
15:53:19 <nhnt11> (if we have promise.catch()...)
15:53:25 <aleth> You could file a bug with the people involved in spec discussions and ask for it...
15:53:39 * nhnt11 will
15:53:50 <aleth> Promise.finally certainly would make sense to me.
15:54:56 <aleth> nhnt11: Probably the right place is the es-discussion mailing list, but I'm not certain
15:55:13 <aleth> sorry, es-discuss
15:55:31 <flo-retina> you can start by asking Yoric if this has been discussed before/how he feels about it :)
15:55:42 <nhnt11> :)
15:55:55 * nhnt11 should add #perf to his auto joins
15:58:59 <nhnt11> http://pastebin.instantbird.com/726241
15:59:02 <nhnt11> aleth: ^
15:59:09 * nhnt11 would rather avoid bz as much as possible on his connection
15:59:20 <nhnt11> hmm, no reconnects in a while though
16:02:42 <-- sonny has quit (Ping timeout)
16:03:18 <aleth> The comment in line 61/62 is still wrong
16:04:17 <nhnt11> Ugh wut
16:04:26 <nhnt11> (My bad)
16:05:04 <aleth> In case I wasn't clear, I asked you to expand the original comment to explain how the date is handled
16:05:09 <nhnt11> I do
16:05:11 <nhnt11> You were*
16:06:38 <nhnt11> aleth: pastebin.instantbird.com/726242
16:06:49 <nhnt11> I got distracted midway changing it and then forgot :]
16:07:05 <aleth> Thanks
16:07:39 * nhnt11 will upload the patch then
16:07:57 --> mayanktg has joined #instantbird
16:15:18 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:15:19 --> clokep_work has joined #instantbird
16:15:19 * ChanServ sets mode +o clokep_work 
16:16:34 <-- mconley has quit (Input/output error)
16:17:01 --> mconley has joined #instantbird
16:17:55 --> mpmc has joined #instantbird
16:18:45 <-- mconley has quit (Ping timeout)
16:40:15 --> rosonline has joined #instantbird
16:51:31 --> Mook_as has joined #instantbird
16:52:35 --> mconley has joined #instantbird
17:07:10 <-- aleth has quit (Ping timeout)
17:07:56 --> aleth has joined #instantbird
17:07:56 * ChanServ sets mode +o aleth 
17:08:13 <-- jb1 has quit (Ping timeout)
17:14:36 <mayanktg> aleth: How can I create a notification panel inside the conversation window? i.e. if A calls B, B should be notified in the conversation window to accept/reject the call. 
17:14:36 <mayanktg> I looked how buddy request notification is created in the buddy list but it didn't help. :(
17:15:20 <aleth> You need a notificationbox XUL element
17:16:01 <mayanktg> Ok..I got it :)
17:18:00 <flo-retina> isn't there already one?
17:18:11 <flo-retina> (in conversation.xml)
17:18:31 <aleth> Have you had  UI discussion with Mic about this?
17:20:05 <mayanktg> aleth: No. We didn't have discussion about it yet
17:20:32 <aleth> Don't postpone it for too long ;)
17:20:48 <aleth> Here's another notificationbox example http://mxr.mozilla.org/comm-central/source/im/content/newtab.xml#27
17:20:53 <mayanktg> Yes. He didn't come online today
17:21:18 <mayanktg> flo-retina: Yes there's a notificationbox  in conversationbox.xml :)
17:21:41 <aleth> So you can use that.
17:22:15 <mayanktg> Ok :)
17:23:17 <flo-retina> which part needs a UI discussion?
17:23:27 <flo-retina> (and is anything blocked?)
17:23:39 * flo-retina wonders what's the status of each of the 3 GSoC projects
17:25:04 <mayanktg> flo-retina: Discussion regarding how should a callee would be notified to accept/reject the call requested. 
17:26:24 <mayanktg> flo-retina: I have started implementing XEP-0166 and can now send session-initiate/accept/terminate from each end. 
17:26:34 --> xangua has joined #instantbird
17:27:49 <flo-retina> mayanktg: the notification bar is a good start
17:28:26 <nhnt11> flo-retina: : The logger.js asyncification patch is nearly r+
17:28:38 <mayanktg> flo-retina: We have a "/call" command to initiate video calling. It sends session-initiate iq stanza. For this we need to build a notification box so that when callee receives iq stanza he should get notified. :)
17:28:41 <nhnt11> I have some tests written but plan to complete that tonight
17:28:46 <flo-retina> "nearly r+" usually means "r-" :-P
17:29:13 <flo-retina> mayanktg: do you already have a version auto-accepting calls?
17:30:36 <mayanktg> flo-retina: no. The auto-accepting version was your code. It used plaintext signalling channel. I could make video calls in Ib using the patch you gave me.
17:30:54 <flo-retina> mayanktg: right.
17:31:17 <flo-retina> mayanktg: so what I was saying was that you can separate the XMPP stanza work from the UI work, by making a version that sends the proper stanzas but auto-accepts
17:32:53 --> arlolra has joined #instantbird
17:32:55 <mayanktg> flo-retina: Ok. I'll do that. the auto-accepts stanzas has been given in the XEP specification :)
17:33:17 <mayanktg> flo-retina: Also I was into confusion seeing XEP 0166 and 0167 
17:33:46 <aleth> mayanktg: I think it's probably time to share your xmpp WIP in a pastebin again ;)
17:34:08 <mayanktg> Wich one should we use? 
17:35:28 <mayanktg> aleth: Yes I'm sharing it, but I haven't really made some good progress as I was stuck figuring out how to add a notifiationbox :-/ 
17:37:42 <flo-retina> mayanktg: I don't know XEP numbers like clokep knows IRC RFC numbers, so it would be helpful if you could give me the title with the numbers ;)
17:39:54 <mayanktg> flo-retina: Sorry. XEP-0167: Jingle RTP Sessions http://xmpp.org/extensions/xep-0167.html
17:40:21 <mayanktg> XEP-0166: Jingle http://xmpp.org/extensions/xep-0166.html
17:40:59 <aleth> mayanktg: Does the question answer itself when you tell us what RTP is? ;)
17:41:25 <mayanktg> Real-time Transport Protocol
17:41:25 <aleth> Hint: I think so ;)
17:41:30 <flo-retina> yeah
17:41:47 <flo-retina> also, there's one more specifically targeted at WebRTC, you should look closely at that one
17:41:50 <mayanktg> It's used for transfering audio and video packets over the channel
17:43:28 <clokep_work> We should teach instantbot to link use RFCs and XEPs. :)
17:43:34 <flo-retina> is it http://xmpp.org/extensions/xep-0320.html (Use of DTLS-SRTP in Jingle Sessions)?
17:43:45 <flo-retina> clokep_work++
17:45:07 <mayanktg> Hmm..This XEP was mentioned in project-information :-|
17:50:59 <clokep_work> Auto-accepting initially is a good idea. :)
17:51:08 <nhnt11> aleth: How's this comment? http://pastebin.instantbird.com/726324
17:51:18 <mayanktg> The XEP-0320 page says that the protocol is experimental and is not approved by XMPP standards.
17:51:33 <nhnt11> Btw, I'm noticing that some pastes which I'm nearly sure were marked to last "forever" seem to be disappearing
17:53:43 <flo-retina> clokep_work: as long as it's pref'ed off by default, yeah
17:53:45 <clokep_work> mayanktg: Sure it's a draft, it could change.
17:54:06 <flo-retina> mayanktg: "the protocol is experimental and is not approved by XMPP standards." I'm pretty sure we already had this discussion months ago
17:54:13 <-- aleth has quit (Ping timeout)
17:54:18 <flo-retina> mayanktg: that means that your feedback is welcome if you find bugs in that draft-specification.
17:54:48 <nhnt11> flo-retina: A bug about adding a "finally" method to promises should be filed under Toolkit, right?
17:54:53 <mayanktg> flo-retina: Ok. I understood that.
17:55:01 <nhnt11> Ah yes, there's an Async Tooling component
17:55:13 <flo-retina> nhnt11: https://bugzilla.mozilla.org/enter_bug.cgi?product=Toolkit&component=Async%20Tooling
17:55:19 --> aleth has joined #instantbird
17:55:20 * ChanServ sets mode +o aleth 
17:55:21 <flo-retina> heh, not fast enough :-)
17:56:06 <flo-retina> "19:55:49 - Channel mode +sntrf set by concrete.mozilla.org." is any of these flags hiding the channel from LIST?
17:56:10 <nhnt11> aleth: not sure if you saw this, sorry if you did, http://log.bezut.info/instantbird/today/#m360
17:56:22 <aleth> nhnt11: Maybe make one sentence out of two?
17:56:42 <nhnt11> "Exclude convs with contacts, because for these..." ?
17:56:50 <clokep_work> nhnt11: CC me.
17:56:58 <nhnt11> clokep_work: On the promise bug?
17:57:02 <aleth> flo-retina: +s is secret?
17:57:06 <clokep_work> flo-retina: If only we actually explained those flags. :(
17:57:13 <-- rosonline has quit (Client exited)
17:57:48 <clokep_work> aleth, flo-retina: +s is secret.
17:57:53 <nhnt11> i'm going with "exclude convs with contacts, these receive.." btw
17:57:56 <clokep_work> (no ? ;))
17:57:57 <clokep_work> nhnt11: Yes
17:58:10 <aleth> nhnt11: Sounds OK
17:59:24 * nhnt11 wonders if aleth wants to be cc'd in the finally bug too
17:59:29 <aleth> Yes please
17:59:51 <aleth> I'm interested to see what the response is
18:00:10 * clokep_work pretty much likes to just be CCed on anything that is remotely related to Instantbird. ;)
18:00:33 <flo-retina> nhnt11: me too!
18:01:43 <nhnt11> The patch is a bit trivial, I'll create a diff and upload it with the bug
18:02:41 <flo-retina> it sucks that we haven't replied to that guy offering to translate to es-AR :(
18:02:57 <aleth> flo-retina: gentle review ping on bug 1014472 and bug 955000 (I'm afraid of bitrot and duplication due to gsoc patches)
18:03:06 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1014472 nor, --, ---, aleth, ASSI, Support automatic MUC reconnection for all protocols
18:03:07 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955000 enh, --, ---, aleth, ASSI, Add someone as a buddy directly from an open conversation
18:03:47 <aleth> Plus, clokep_work is writing patches that depend on those patches already ;)
18:04:16 <clokep_work> And bitrot w/ those patches. :(
18:04:39 <aleth> nhnt11's latest minipatch also bitrots one of those.
18:04:57 <aleth> And he fixed a bug elsewhere I'd already fixed...
18:06:28 <clokep_work> :(
18:07:36 * nhnt11 wonders who to ask for review/feedback/info on this promise bug
18:07:37 <nhnt11> Yoric maybe
18:08:25 <aleth> It should automatically be sent to people watching that component, but you can needinfo Yoric I guess.
18:08:37 <nhnt11> Okay.
18:09:47 <aleth> You don't really "need info" though... it's a simple enhancement request really.
18:09:57 <nhnt11> So, feedback?
18:10:20 <aleth> I'd rely on the automatic distribution list, and then maybe ask Yoric about it on IRC.
18:10:28 <nhnt11> Sure
18:10:49 --> Armada has joined #instantbird
18:23:26 --> CaptainCalliope has joined #instantbird
18:31:18 * nhnt11 just got an |Error: uncaught exception: 2147500033| in his testing profile :S
18:31:25 <nhnt11> Maybe it's not an addon after all..
18:31:27 <clokep_work> aleth: Why DOM Core for that? :-S
18:32:32 <nhnt11> clokep_work: The Promise meta-bug is filed under Core/DOM as well.
18:32:44 <aleth> DOM Promises, so...
18:32:46 <nhnt11> Promises are in DOM
18:32:48 <nhnt11> yeah
18:33:08 * nhnt11 will file a bug if he sees this 2147500033 exception again
18:34:03 <nhnt11> Aha! Happens every time I open the awesometab
18:34:13 <nhnt11> Interesting
18:34:21 --> nhnt11-testing has joined #instantbird
18:34:34 <nhnt11-testing> I'm going to lurk here in this profile and see if I discover any more async bugs :)
18:36:13 <instantbot> New Instantbird - Conversation bug 1019132 filed by nhnt11@gmail.com.
18:36:15 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1019132 nor, --, ---, nobody, NEW, "uncaught exception: 2147500033" on opening an awesometab
18:36:51 <-- nhnt11-testing has quit (Client exited)
18:37:47 --> nhnt11-testing has joined #instantbird
18:38:34 <nhnt11> Hmm, I probably need the debugger to find out where that's coming from
18:39:04 <aleth> Looks like a regression.
18:39:10 <Mook_as> might be useful to mention that it's NS_ERROR_NOT_IMPLEMENTED.
18:39:20 <nhnt11> Mook_as: Thanks! I didn't know that.
18:39:33 <aleth> nhnt11: FYI convert to hex then look it up on mdn ;)
18:39:36 <Mook_as> (via http://james-ross.co.uk/mozilla/misc/nserror?0x80004001 )
18:39:59 <Mook_as> and yeah, Silver's thing accepts decimal
18:40:00 <nhnt11> I'm a bit confused, did we ever get a debugger working on Ib or was that only the profiler?
18:40:15 <aleth> It works, if you install the addon.
18:40:16 <Mook_as> Debbuger should mostly work (it works in Komodo, so...)
18:40:30 <Mook_as> I guess I was remote-debugging from Firefox, though
18:40:52 <nhnt11> That would be fine
18:40:59 <aleth> Hmm, actually it may be broken now since a recent patch landed on m-c changing some things
18:41:04 <aleth> Try it and see ;)
18:41:19 * nhnt11 searches for the addon (maybe someone has it in their awesomebar?)
18:41:37 <aleth> Look for the debugging tools bug,
18:41:41 <nhnt11> Not on AIO?
18:41:42 <nhnt11> oksy
18:41:44 <nhnt11> okay*
18:44:08 <aleth> bug 981321
18:44:11 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=981321 enh, --, ---, nobody, NEW, Port developer tools from Thunderbird to Instantbird
18:44:45 <aleth> And the issue I was thinking of was bug 942756 and bug 972903
18:44:50 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=942756 nor, --, ---, paul, NEW, Unify the different ways we start the debugger server
18:44:51 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=972903 nor, --, ---, philipp, ASSI, Adapt Debugger Server startup code for changes in bug 942756
18:45:03 <nhnt11> Thanks!
18:47:25 <-- Tonnes has quit (Quit: ChatZilla [Firefox 29.0.1/20140506152807])
18:47:53 <nhnt11> brb
18:47:57 * clokep_work assumes Mook_as knows the error codes off the top of his head. :-D
18:48:27 <Mook_as> clokep_work: no, I just know that Silver has a site with it... which I linked to.
18:48:41 <Mook_as> though I _was_ disappointed that firebot doesn't know about it off the top of his head
18:49:12 --> gerard-majax__ has joined #instantbird
18:49:39 <-- nhnt11 has quit (Ping timeout)
18:49:52 <-- nhnt11-testing has quit (Ping timeout)
18:49:52 <-- aleth has quit (Ping timeout)
18:50:48 <-- mayanktg has quit (Ping timeout)
18:51:28 --> nhnt11 has joined #instantbird
18:51:38 --> nhnt11-testing has joined #instantbird
18:57:23 --> mayanktg-ph has joined #instantbird
18:58:00 <nhnt11> re
18:59:30 <nhnt11> Remote debugging doesn't seem to be working :(
18:59:43 <nhnt11> https://pastebin.mozilla.org/5323548
18:59:52 <nhnt11> later, then...
19:03:44 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:20:24 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
19:37:02 <-- CaptainCalliope has quit (Quit: CaptainCalliope)
19:55:23 <nhnt11> flo-retina: Is it expensive to use arrow functions where binding isn't necessary?
19:55:31 <nhnt11> i.e. just for the shorthand syntax
19:56:20 <flo-retina> I don't think so, use them :)
19:56:26 <nhnt11> Okay
20:18:45 * nhnt11 looks at the spec again to ensure he's using promise.then(foo, foo) correctly
20:20:07 * nhnt11 is using it correctly.
20:33:25 --> EionRobb has joined #instantbird
20:38:10 --> Mic has joined #instantbird
20:38:10 * ChanServ sets mode +o Mic 
20:38:10 <-- mayanktg-ph has quit (Connection reset by peer)
20:38:45 --> mayanktg-ph has joined #instantbird
20:39:27 <-- mayanktg-ph has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
20:40:27 --> mayanktg-ph has joined #instantbird
20:46:07 <Mic> nhnt11: you can attach the debugger to IB if you have Fallen's add-on installed but it'd need some work, I think. http://log.bezut.info/instantbird/today#m437
20:46:21 <Mic> You can't choose which window to attach it to afaik.
20:46:40 <Mic> -debugger +the dev tools
20:49:01 <nhnt11> Mic: What kind of "work"?
20:49:58 <Mic> I'm not sure... the add-on would need some way to list the windows and tabs of IB, sothe dev tools offer a list to choose from.
20:50:50 <nhnt11> Hmm. You said you got it working in that bug?
20:51:10 <clokep_work> flo-retina: I'm not assuming data from the network is "Correct", I'm assuming it won't really break anything if it's wrong.
20:51:39 <Mic> nhnt11: yes, it's working on my conversation window for example...
20:53:27 <nhnt11> Mic: I ran the server on Ib, but when I tried connecting from fx it timed out
20:53:38 <nhnt11> (though on the Ib side it said one connected client)
20:54:08 <-- Mic has quit (Connection reset by peer)
20:54:13 --> Mic has joined #instantbird
20:54:13 * ChanServ sets mode +o Mic 
20:55:43 <Mic> nhnt11: the "Remote Dev Tools Server" add-on has an option dialog.
20:55:52 <Mic> There's the port you need to connect to.
20:55:59 <Mic> Most likely set to 6000 already?
20:56:08 <nhnt11> 6000, yes.
20:56:26 <Mic> What does the button beneath say?
20:56:41 <Mic> "Start ..." or "Stop ..."?
20:56:59 <nhnt11> "Stop" obviously ;)
20:57:13 <Mic> OK, that's great.
20:57:16 <flo-retina> clokep_work: I don't see the difference
20:57:47 <nhnt11> Mic: Um, I think I may be doing it wrong on Fx, I'm doing Tools->Web Developer->Connect
20:58:09 <Mic> No, that sounds right.
20:58:15 <clokep_work> flo-retina: It's an JSON object, it can't like have a function in it or something.
20:58:17 <nhnt11> Hmm
20:58:21 <flo-retina> clokep_work: in "not correct" I include intentionally crafted packets by an attacker MITMing the user
20:58:23 * nhnt11 wonders if OS X's firewall is interfering
20:58:26 <Mic> It should show you a grey page saying "Connect to device via network"
20:58:28 <clokep_work> But honestly we're just wasting time, the new version of the patch adds the safety back in.
20:58:47 <clokep_work> flo-retina: OK, but I still don't think it can do any harm in the way that code is used.
20:58:55 <nhnt11> Mic: This is what I see in Fx. http://puu.sh/9cmor/ad065d7ba2.png
20:58:57 <Mic> Or whatever the exact wording is as I translated it from german...
20:58:58 <clokep_work> But it /really/ doesn't matter, I added the code back in.
20:59:02 <nhnt11> And Ib: http://puu.sh/9cmoW/ae51d180a0.png
20:59:11 <flo-retina> clokep_work: I only replied to the comment in the bug. I trust you all are doing something reasonable :)
20:59:18 <Mic> nhnt11: ah!
20:59:31 <Mic> You might have to confirm that something wants to connect to your IB server.
20:59:32 <flo-retina> (I haven't looked at the code, and don't intend to unless I'm flagged for review)
20:59:43 <Mic> Go and look for a dialog that's asking for permission?
20:59:48 <Mic> I think there was one.
21:00:15 <nhnt11> Mic: I'm getting an error in IB's console btw, did you see https://pastebin.mozilla.org/5323548?
21:00:44 <-- clokep_work has quit (Ping timeout)
21:01:09 * nhnt11 disables OS X's firewall (though it really shouldn't block localhost->localhost connections)
21:01:23 <Mic> brb
21:01:26 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
21:01:31 --> Mic has joined #instantbird
21:01:32 * ChanServ sets mode +o Mic 
21:02:21 <nhnt11> Nope, no luck.
21:02:23 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:02:31 --> nhnt11 has joined #instantbird
21:02:38 <Mic> nhnt11: no, no errors on the console here. Maybe that's a good point to start from?
21:02:41 * nhnt11 gives up for now
21:16:35 --> rosonline has joined #instantbird
21:19:08 <-- rosonline has quit (Ping timeout)
21:24:54 <-- gerard-majax__ has quit (Ping timeout)
21:38:04 --> rosonline has joined #instantbird
21:52:02 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:57:58 --> nhnt11 has joined #instantbird
22:09:08 <-- mconley has quit (Input/output error)
22:14:31 <-- mayanktg-ph has quit (Client exited)
22:23:27 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
22:41:53 --> chrisccoulson has joined #instantbird
22:49:37 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:51:34 --> mayanktg has joined #instantbird
23:00:56 <mayanktg> http://pastebin.instantbird.com/726571
23:01:11 <mayanktg> flo-retina: Here's my WIP http://pastebin.instantbird.com/726570 . I'm sending 3 negotiations (initiation, accept, acknowledgement) and then after that the media session will start.
23:01:16 <mayanktg> flo-retina:  It's as per my understanding given in the diagram in the XEP-0166 page. To know about receiveing iq Stanzas I'm using the onIqStanza() . I'm unable to get how to pass the aMsg and aConv argument to the function :( .
23:01:35 <mayanktg> flo-retina: Ignore the earlier diff
23:02:19 <flo-retina> "I'm unable to get how to pass the aMsg and aConv argument to the function" which function?
23:02:38 <mayanktg> acceptCall() and ackCall()
23:03:27 <mayanktg> I'm calling acceptCall after responder receives session-initiate iq stanza
23:04:09 <flo-retina> so you mean on the "this.acceptCall(aMsg, aConv);" line, aMsg and aConv aren't defined?
23:04:20 <mayanktg> Yes.
23:04:32 <flo-retina> what are these variables supposed to contain?
23:09:00 <mayanktg> the functions are similar to one defined in xmpp-commands.jsm . aMsg contains the message to be sent and aConv is conversation window object.
23:10:18 <mayanktg> sorry if I'm wrong, I'm not sure about the aMsg variable. :-/
23:11:41 <flo-retina> "conversation window object"?
23:11:57 <flo-retina> why would code in the xmpp folder have access to that?
23:12:35 <flo-retina> alright, think about what you actually need; and then you'll likely find a way to access it
23:12:56 <flo-retina> if you are trying to send a stanza, I suspect you just need a jid or something similar
23:14:07 <mayanktg> Ok. Yes, I needed a full JID to send the stanza
23:17:31 <mayanktg> Am I proceeding in the right direction regarding sending the negotiations? idk if I'm right.
23:22:36 <-- mayanktg has quit (Ping timeout)
23:48:31 --> clokep has joined #instantbird
23:48:31 * ChanServ sets mode +o clokep