#instantbird log on 05 30 2014

All times are UTC.

00:00:19 <nhnt11> clokep: In Komodo, in the autocomplete popup, all the other methods have a green dot, but test_logging has a red square next to it
00:00:22 <nhnt11> does that mean syntax error?
00:00:23 <nhnt11> or something
00:01:00 <clokep> It could.
00:01:09 <clokep> One second.
00:01:57 <nhnt11> Oh, I'm doing it wrong
00:02:04 <nhnt11> These tests are never called
00:02:10 <clokep> OK.
00:02:15 <nhnt11> I need to call run_next_text in run_test
00:02:20 <clokep> Glad you figured it out. ;)
00:02:22 <nhnt11> to start execution of async tests
00:02:26 <clokep> Yeah
00:02:28 <nhnt11> heh, i'll leave you to your dinner
00:02:52 * nhnt11 prepares for his tests to fail
00:03:01 <nhnt11> woo, fail
00:05:17 <clokep> :)
00:09:48 <-- Tonnes has quit (Connection reset by peer)
00:10:53 <clokep> nhnt11: https://groups.google.com/forum/#!topic/mozilla.dev.platform/X3AN2k1CFns
00:11:57 <nhnt11> clokep: Thanks!
00:16:10 <clokep> Of course.
00:16:16 <clokep> I assumed you don't read m.d.platform. ;)
00:17:03 <-- Armada_ has quit (Connection reset by peer)
00:17:39 <nhnt11> I don't :)
00:19:20 --> iamjayakumars has joined #instantbird
00:24:38 <-- iamjayakumars has quit (Ping timeout)
00:26:29 --> iamjayakumars has joined #instantbird
00:28:07 <-- iamjayakumars has quit (Quit: )
00:34:28 * nhnt11 needs to sleep
00:34:56 <nhnt11> Night!
00:42:40 <-- nhnt11 has quit (Ping timeout)
00:43:42 --> nhnt11 has joined #instantbird
00:49:55 <-- nhnt11 has quit (Ping timeout)
00:51:18 --> nhnt11 has joined #instantbird
00:52:57 <-- sonny has quit (Ping timeout)
00:55:18 * clokep waits for his build to finish. :(
01:01:29 <-- wnayes has quit (Ping timeout)
01:01:46 --> wnayes has joined #instantbird
01:03:21 <-- nhnt11 has quit (Ping timeout)
01:04:46 --> nhnt11 has joined #instantbird
01:12:07 <-- Mook_as has quit (Quit: Mook_as)
01:15:38 --> Tonnes has joined #instantbird
01:19:08 --> clokep_js has joined #instantbird
01:20:53 <-- clokep_js has left #instantbird ()
01:39:32 <instantbot> New Chat Core - General bug 1017946 filed by clokep@gmail.com.
01:39:34 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1017946 min, --, ---, clokep, ASSI, Kill usage of hasOwnProperty global
01:47:04 <-- nhnt11 has quit (Ping timeout)
01:48:28 --> nhnt11 has joined #instantbird
02:00:58 <-- nhnt11 has quit (Ping timeout)
02:02:04 --> nhnt11 has joined #instantbird
02:10:36 <-- clokep has quit (Ping timeout)
02:12:51 --> clokep has joined #instantbird
02:12:51 * ChanServ sets mode +o clokep 
02:19:11 <-- xangua has quit (Quit: Connection closed for inactivity)
02:20:00 <clokep> aleth: I also have a patch (that depends on that bug ^) to add the joining stuff to JS-XMPP.
02:20:50 <-- nhnt11 has quit (Ping timeout)
02:22:35 --> nhnt11 has joined #instantbird
02:43:22 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
02:57:14 <-- wnayes has quit (Quit: wnayes)
03:09:51 <-- mayanktg-ph has quit (Client exited)
03:09:53 --> mayanktg-ph has joined #instantbird
03:16:22 <-- Rym has quit (Ping timeout)
03:16:41 --> Rym has joined #instantbird
03:40:06 <-- mayanktg-ph has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
03:40:29 --> mayanktg has joined #instantbird
03:41:08 --> Mook has joined #instantbird
04:29:52 <-- nhnt11 has quit (Ping timeout)
04:31:22 --> nhnt11 has joined #instantbird
04:36:25 <-- nhnt11 has quit (Ping timeout)
04:37:26 --> nhnt11 has joined #instantbird
04:47:48 <-- EionRobb has quit (Quit: Leaving.)
04:53:19 <-- nhnt11 has quit (Ping timeout)
04:54:28 --> nhnt11 has joined #instantbird
05:17:05 <-- Rym has quit (Ping timeout)
05:57:35 * sawrubh had fallen asleep in front of his computer
05:57:53 <sawrubh> I'm back now, Good morning!
05:59:24 <-- mayanktg has quit (Ping timeout)
06:03:55 --> mayanktg has joined #instantbird
06:24:29 <-- jb has quit (Ping timeout)
06:33:52 --> gerard-majax_ has joined #instantbird
06:40:49 <-- gerard-majax_ has quit (Ping timeout)
06:53:49 --> jb has joined #instantbird
06:56:22 --> gerard-majax_ has joined #instantbird
07:05:15 <mayanktg> I'm filing an enhancement bug for adding voice and video call support in XMPP. I'll keep a track of the changes and my progress there.
07:07:35 <-- nhnt11 has quit (Ping timeout)
07:08:37 --> nhnt11 has joined #instantbird
07:09:23 <instantbot> New Chat Core - XMPP bug 1018060 filed by mayanktg@gmail.com.
07:09:25 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1018060 nor, --, ---, mayanktg, NEW, Voice and video call support in XMPP using WebRTC
07:13:03 <-- gerard-majax_ has quit (Ping timeout)
07:14:48 --> gerard-majax_ has joined #instantbird
07:16:47 <-- Mook has quit (Quit: Mook)
07:16:59 <-- gerard-majax_ has quit (Ping timeout)
07:19:04 <-- nhnt11 has quit (Ping timeout)
07:20:16 --> nhnt11 has joined #instantbird
07:22:50 <-- nhnt11 has quit (Ping timeout)
07:24:38 --> nhnt11 has joined #instantbird
07:30:18 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
07:36:59 --> mpmc has joined #instantbird
07:50:07 <-- nhnt11 has quit (Ping timeout)
07:51:13 --> nhnt11 has joined #instantbird
08:04:53 --> mayanktg has joined #instantbird
08:07:26 --> gerard-majax_ has joined #instantbird
08:11:26 <-- nhnt11 has quit (Ping timeout)
08:11:50 --> nhnt11 has joined #instantbird
08:14:59 <-- jb has quit (Quit: jb)
08:17:47 <-- nhnt11 has quit (Ping timeout)
08:19:17 --> nhnt11 has joined #instantbird
08:22:44 <-- nhnt11 has quit (Ping timeout)
08:24:17 --> nhnt11 has joined #instantbird
08:27:26 --> jb has joined #instantbird
08:28:23 <-- jb has quit (Quit: jb)
08:34:54 <-- mayanktg has quit (Ping timeout)
08:35:39 --> jb has joined #instantbird
08:38:55 --> mayanktg has joined #instantbird
08:57:08 --> Armada has joined #instantbird
09:19:33 --> sonny has joined #instantbird
09:32:58 <-- nhnt11 has quit (Ping timeout)
09:34:01 --> nhnt11 has joined #instantbird
09:36:38 --> BWMerlin has joined #instantbird
09:55:56 <-- jb has quit (Connection reset by peer)
09:55:58 --> jb1 has joined #instantbird
10:12:23 <-- nhnt11 has quit (Ping timeout)
10:13:49 --> nhnt11 has joined #instantbird
10:22:44 --> clokep has joined #instantbird
10:22:44 * ChanServ sets mode +o clokep 
10:29:12 <-- mayanktg has quit (Ping timeout)
10:29:22 --> mayanktg has joined #instantbird
10:34:03 <-- nhnt11 has quit (Ping timeout)
10:34:56 <clokep> mayanktg: Is that the exact patch he gave you or the one you modified slightly? Just curious. :)
10:35:44 --> nhnt11 has joined #instantbird
10:36:55 <mayanktg> clokep: Its the exact patch. The last one was for chat and this is for Ib. I'm modifying it, but presently installing Ib on other computer so that I can test the call
10:37:19 <clokep> "the last one was for chat and this is for Ib"? What?
10:37:25 <clokep> What "last one"
10:37:35 <-- nhnt11 has quit (Ping timeout)
10:38:04 <mayanktg> I mean, flo-retina build the patch for Thunderbird chat.
10:39:47 <mayanktg> But I changed it for Instantbird by moving the changes to im/content/convesation.xml and and im/locales/package-manifest.in 
10:39:48 --> nhnt11 has joined #instantbird
10:42:29 <clokep> Ah OK. :)
10:42:38 <clokep> So did you post the one for IB or his original for TB? :P
10:43:19 <clokep> Ah, I see the IB one.
10:43:19 <mayanktg> I post the one for Ib :P
10:43:36 <mayanktg> What should I have done? :-o
10:43:43 <clokep> I was just curious.
10:44:45 <mayanktg> Ok :) 
10:59:43 <-- sonny has quit (Ping timeout)
11:13:17 <-- clokep has quit (Ping timeout)
11:13:59 --> aleth_web has joined #instantbird
11:26:36 <-- nhnt11 has quit (Connection reset by peer)
11:27:59 --> nhnt11 has joined #instantbird
11:34:07 <-- jb1 has quit (Connection reset by peer)
11:34:08 --> jb has joined #instantbird
11:35:44 <sawrubh> aleth_web: http://log.bezut.info/instantbird/140529/#m943 is the discussion on that error
11:49:05 <nhnt11> aleth_web: aaaaah I missed the leak :'(
11:49:44 <aleth_web> The error handling looks pretty good though ;)
11:51:08 <nhnt11> aleth_web: The solution would be to remove a path from the Map when the Promise mapped to that path resolves.
11:51:29 <aleth_web> Not trivial though.
11:51:52 <nhnt11> The tricky bit is to ensure this doesn't happen if another operation has already been chained
11:51:55 <aleth_web> Since you want to be able to keep adding promises to the chain until it resolves...
11:53:19 --> nhnt12 has joined #instantbird
11:53:33 <-- nhnt11 has quit (Ping timeout)
11:53:33 --> clokep_work has joined #instantbird
11:53:33 * ChanServ sets mode +o clokep_work 
11:53:33 <nhnt12> ç
11:53:40 <nhnt12> oops
11:53:45 <nhnt12> aleth_web: How about just removing the path after every operation?
11:55:53 <sawrubh> clokep_work: any idea about that contract id being undefined?
11:56:10 <sawrubh> clokep_work: http://log.bezut.info/instantbird/140529/#m934 is what Mic had to say about it
11:57:07 <nhnt12> aleth_web: Write errors are propagated correctly in safelyAppendToFile
11:57:11 <aleth_web> sawrubh: I haven't had a chance to look at the logs yet, but I'm beginning to think getting rid of messenger/ in the cloudfile code and replacing it with chat/ might be helpful. It has to happen anyway before landing
11:57:22 <aleth_web> (for things that are shared)
11:57:30 <nhnt12> If there's a write error and then a close error, the close error gets dumped to the error console and the write error is propagated
11:57:40 <nhnt12> (I guess that comment isn't clear)
11:57:50 <clokep_work> aleth_web: Does it?
11:58:12 <clokep_work> sawrubh: I don't really understand what contract ID you're talking about, I need to see larger amounts of the code, etc.
11:58:14 <aleth_web> nhnt12: It's possible the comment is confusing and that's the only thing that needs to be improved ;)
11:58:52 <aleth_web> clokep_work: It would be super confusing to have messenger code referred to from IB, and it's just asking for trouble when people do things later assuming it only touches TB.
11:59:02 <sawrubh> clokep_work: http://mxr.mozilla.org/comm-central/source/mail/components/cloudfile/content/Box/management.js#6 here the contract ID mentioned in the error is being requested
11:59:19 <aleth_web> It's just a search/replace and some jar.mn changes anyway
11:59:26 <sawrubh> I get an undefined error on that contract ID (here's the errors http://pastebin.instantbird.com/722551)
11:59:45 <aleth_web> The kind of thing I did in that unforking patch.
12:01:27 <clokep_work> sawrubh: Yeah so it doesn't exist.
12:01:32 <clokep_work> I'm not sure what's confusing you. :-\
12:01:35 <aleth_web> (what I'm referring to is using chrome://messenger URIs to refer to chat/ code)
12:01:43 * nhnt12 ponders about this leak
12:01:46 * nhnt12 is now known as nhnt11
12:01:57 <clokep_work> sawrubh: Why do you think this is related to that properties file you were talking about above?
12:02:42 <sawrubh> clokep_work: this error is not related to that properties one, I was just asking aleth_web about that properties also, not that it had any relation to this
12:03:36 <sawrubh> clokep_work: so I'll go ahead with the changes aleth_web's suggested then to fix this contractID issue
12:03:36 <clokep_work> sawrubh: OK, so what do you need to know?
12:03:50 <clokep_work> sawrubh: What do you mean "fix" this issue?
12:03:56 <nhnt11> aleth_web: How about something like this (needs comments of course) http://pastebin.instantbird.com/722564
12:04:06 <aleth_web> sawrubh: What I just suggested is unrelated to your problem, just may lessen confusion.
12:04:08 <clokep_work> It's asking to instantiate an instance of http://dxr.mozilla.org/comm-central/source/mailnews/base/public/nsIMessenger.idl, we most certainyl ARE NOT moving that code to chat/.
12:04:37 <clokep_work> It only wants one method from there: http://dxr.mozilla.org/comm-central/source/mailnews/base/public/nsIMessenger.idl#138
12:04:44 --> sonny has joined #instantbird
12:05:36 <nhnt11> Hmm, I may not need the set() in line 9 of that paste
12:05:38 <clokep_work> sawrubh: I think you need to either 1. not nicely format file sizes for the moment or create a JS version of http://dxr.mozilla.org/comm-central/source/mailnews/base/util/nsMsgUtils.cpp#474 and put it in that file.
12:06:06 <nhnt11> Actually I probably do. meh. This is confusing..
12:06:08 * nhnt11 thinks of a better way
12:07:42 <clokep_work> sawrubh: Does that make sense?
12:10:33 <nhnt11> aleth_web: Is there any way to get the state of a promise? (pending/resolved/rejected)
12:10:41 * nhnt11 can't find any evidence of such an attribute or whatever
12:11:55 <nhnt11> "The instant state and value of a promise cannot be inspected synchronously from code" :(
12:16:48 <nhnt11> aleth_web: pastebin.instantbird.com/722577 :)
12:17:22 <nhnt11> sorry, missed the http: http://pastebin.instantbird.com/722577
12:17:25 <sawrubh> clokep_work: yeah, I'll not nicely format file sizes for the moment (and do the porting the function to JS in the next version), just want to get Pref Pane working for now
12:17:40 <sawrubh> (sorry, the internet had gone for some time)
12:18:44 * nhnt11 will write that blog post before writing more code today.
12:18:54 <nhnt11> This stuff with promises is pretty nifty :)
12:20:14 <aleth_web> nhnt11: Regarding tests of the encoding function, it's usually not a bad idea to test things that involve confusing regexes or such and can break if someone changes a character somewhere
12:20:21 <aleth_web> Maybe I misunderstood what that was about in the logs though
12:20:34 <nhnt11> aleth_web: Right, I'm keeping those tests.
12:20:45 <aleth_web> nhnt11: Does the == promise bit work? == on objects...
12:20:59 <nhnt11> aleth_web: Why wouldn't it?
12:21:12 <nhnt11> I'm not trying to see if the objects are "equivalent", I want complete equality
12:21:43 <nhnt11> (i.e. get() and promise should both refer to the same object)
12:21:49 <clokep_work> sawrubh: OK, put a XXX comment so we don't forget!
12:23:33 <sawrubh> ok
12:25:30 <clokep_work> Great! :)
12:25:36 * clokep_work hopes we're close to getting this to work. :)
12:25:46 * aleth_web is thinking about too many things at the same time
12:26:05 <aleth_web> nhnt11: Interesting idea. Are you sure about what happens when then() is called twice on the same promise?
12:26:35 <nhnt11> Yes.
12:27:00 <nhnt11> But I'll write a test to be sure
12:27:11 * mayanktg yay! can see his video on both the sides of chat. The video call runs :D :D
12:27:24 * nhnt11 has discovered the power of the firefox console lately
12:28:19 <clokep_work> aleth_web: So I shouldn't ask you if you looked at my patches yet? ;)
12:28:24 <aleth_web> nhnt11: My question is what happens to the promises in | let promise1 = promise.then(doOneThing); let promise2 = promise.then(doAnotherThing);| 
12:28:25 <clokep_work> mayanktg: Congrats. :)
12:28:45 <aleth_web> mayanktg: :)
12:28:50 <nhnt11> aleth_web: I understand
12:29:02 <nhnt11> From what I understand, both the then() callbacks are executed
12:29:07 <nhnt11> then() returns a new promise so..
12:29:38 <aleth_web> I'm just wondering if this is in the Promises spec or just an artifact of the implementation
12:29:56 <sawrubh> mayanktg: w00t
12:29:57 <aleth_web> Would be great to know anyway for the future!
12:30:17 <nhnt11> I just ran this snippet: http://pastebin.instantbird.com/722578
12:30:23 <nhnt11> Both the alerts got executed
12:30:52 <mayanktg> clokep_work, sawrubh: Yeah. I have to change it a bit. Its flo's code anyways ;)
12:31:15 <aleth_web> nhnt11: Yeah, but with an operation like alert the second then() possibly acts on a resolved promise.
12:31:16 <nhnt11> I'll check the spec for surity :)
12:31:29 <aleth_web> Put some timeouts in there ;)
12:31:32 <nhnt11> fine
12:31:36 <aleth_web> Thanks!
12:31:45 <aleth_web> It's cool if we can use this.
12:32:10 <aleth_web> Just don't want it to weirdly break when someone does an internal change to promise code...
12:32:13 * clokep_work thinks we might be ready for 2.0 with the work mayanktg, sawrubh and nhnt11 are doing. ;)
12:32:20 * aleth_web agrees
12:32:34 <clokep_work> (Plus if we get OTR.)
12:32:57 <aleth_web> OTR even has a bounty (for TB at least ;) )
12:33:29 <clokep_work> Yep.
12:35:12 <nhnt11> FYI, http://pastebin.instantbird.com/722589 works as expected
12:35:15 <nhnt11> (I'm still checking the spec, don't worry ;))
12:35:42 <aleth_web> clokep_work: Bah I can't believe I missed that this.left issue on review.
12:35:48 <nhnt11> aleth_web: https://promises-aplus.github.io/promises-spec/#point-36
12:35:59 <nhnt11> The spec has approved.
12:36:00 <aleth_web> clokep_work: Must be because the comment was right...
12:36:01 <nhnt11> :D
12:36:05 <aleth_web> :)
12:36:22 <aleth_web> Superb
12:36:56 <aleth_web> +1 for specs that actually answer questions ;)
12:37:02 * nhnt11 thinks the anti-leak solution is elegant
12:37:02 <nhnt11> yeah
12:38:55 <clokep_work> aleth_web: You mean the one nhnt11 fixed yesterday or the new one I just put up for review? :P
12:39:20 <sawrubh> aleth_web: bounty ?
12:39:25 <aleth_web> The original issue, not the broken fix
12:39:46 * nhnt11 was able to open that topic settable bug by typing "fix" in his awesomebar
12:39:50 <nhnt11> incredible.
12:39:59 <clokep_work> sawrubh: People can put up money saying they'll give it to whoever fixes a bug.
12:40:37 <sawrubh> how much is up for OTR ? :)
12:41:43 <nhnt11> sawrubh: Looks like $500 at the moment
12:41:45 <nhnt11> https://www.bountysource.com/issues/1012564-otr-encryption-in-thunderbird-chat
12:41:55 <sawrubh> wow
12:42:50 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:42:56 --> nhnt11 has joined #instantbird
12:43:46 <nhnt11> bbl
12:44:01 <nhnt11> (I'm able to /join channels, yay :))
12:44:11 --> qheaden has joined #instantbird
12:45:36 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:45:38 --> clokep_work has joined #instantbird
12:45:38 * ChanServ sets mode +o clokep_work 
12:45:50 <sawrubh> nhnt11: wasn't that implemented already?
12:45:58 <sawrubh> '/join' that is
12:46:02 <clokep_work> sawrubh: I broke it yesterday.
12:46:33 <clokep_work> aleth_web: As a minor optimization?
12:46:54 <clokep_work> aleth_web: We do some weird checking in a few places now where we don't have to anymore since we have a Map (i.e. we call has when we could just call get)
12:47:08 <aleth_web> clokep_work: Very minor, but yeah.
12:47:48 <aleth_web> The reason I like it is because getParticipant will actually create the participant if it's not there, and the first check is to avoid that.
12:49:05 <clokep_work> Yup yup.
12:49:06 <clokep_work> Works for me.
12:49:37 <qheaden> Hello.
12:49:39 <aleth_web> nhnt11: heh, "The test passed on the first run - something must be wrong :P" that's what I tend to think too when that happens ;)
12:51:29 --> nhnt11-phone has joined #instantbird
12:52:36 <nhnt11-phone> aleth_web: "You don't have to return a promise if there is nothing to wait for ;)" I do, otherwise queuing won't work. 
12:53:01 <nhnt11-phone> I need a promise so I can chain the next one. 
12:54:07 <aleth_web> I thought promise.then did that for you?
12:54:23 <aleth_web> But you're right, it's probably more confusing to change it.
12:54:31 <nhnt11-phone> What?
12:54:39 <nhnt11-phone> I can't call then on it unless it's a promise 
12:55:34 <clokep_work> qheaden: I left you a message yesteday.
12:55:55 <aleth_web> iirc it's filepromise.then(somefunction). If somefunction returns a promise then will pass it through, if it doesn't it will create a promise resolved to the return value.
12:56:28 <qheaden> clokep_work: Email or IRC?
12:56:31 <aleth_web> But leave it as it is, the way you have it is less confusing. Sorry.
12:56:33 <nhnt11-phone> Hmm yeah. 
12:56:41 <nhnt11-phone> Bah
12:57:00 <nhnt11-phone> I forgot we're calling the queued function from a then() already 
12:57:13 <clokep_work> qheaden: IRC.
12:57:21 <clokep_work> Check the logs.
12:57:24 * clokep_work is busy, sorry.
12:57:26 <qheaden> ok
12:57:59 <qheaden> clokep_work: Oh wow. Okay. Didn't know Yahoo! Japan was going away.
12:58:12 <-- nhnt11-phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
12:58:21 <qheaden> That makes testing easier.
13:02:12 <clokep_work> qheaden: Well...I wouldn't delete anything until we're positive about it. :)
13:02:16 <clokep_work> But thought you'd find it interesting.
13:02:33 <clokep_work> Might want to CC yourself or whatever to that bug if you're interested
13:11:16 --> Rym has joined #instantbird
13:15:04 <-- Rym has quit (Ping timeout)
13:15:34 --> Rym has joined #instantbird
13:16:36 --> Mic has joined #instantbird
13:16:36 * ChanServ sets mode +o Mic 
13:18:21 <qheaden> clokep_work: Okay. Thanks again for that.
13:19:21 <clokep_work> aleth_web: https://bugzilla.mozilla.org/attachment.cgi?id=8431556&action=edit
13:20:00 <sawrubh> Mic: yeah, I started with Servo contributions but then had to stop because of academics. My Rust knowledge is pretty 'rusty' right now (I'll brush it up once again when I start contributing to it, which I plan to do after GSoC hopefully)
13:21:23 <Mic> mayanktg: great @ http://log.bezut.info/instantbird/today#m223 :)
13:21:49 <aleth_web> clokep_work: btw good idea to get rid of all the hasownproperties :)
13:22:09 <Mic> clokep_work: can't you inline the Object.prototype- call in Twitter?
13:22:30 <clokep_work> Mic: Yes, but I don't think it's necessary, what are we protecting against there?
13:22:49 <clokep_work> We're sent a JSON object.
13:22:54 <clokep_work> It can't have functions are anything inside of it.
13:23:00 <clokep_work> We're just accessing a property.
13:23:25 <Mic> It's data coming from the network? Isn't that always considered as unsafe?
13:23:50 <clokep_work> Mic: Yes, but we're not using it in an unsafe way.
13:24:13 <Mic> Yeah, OK. I just wondered :)
13:25:00 <clokep_work> I'm not concerned about it because it's not like we're calling that propery or anything, we just access them as if they're strings or other basic types, which they /must/ be to have gone through the JSON parser.
13:26:54 <aleth_web> mayanktg: Btw I think you were looking for https://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/browser.css#497. Note this is OS-dependent CSS.
13:27:56 <Mic> aleth_web, nhnt11: what's the problem with http://log.bezut.info/instantbird/today#m226 ?
13:28:18 <nhnt11> Mic: Nothing, as we found out from the spec :)
13:28:42 <Mic> OK :)
13:28:54 <aleth_web> We just wanted to make sure the behaviour was determined :)
13:28:59 <Mic> That because I didn't see what the problem is.
13:29:31 <nhnt11> Mic: aleth wanted to make sure that it's legal to use then() multiple times on the same promise
13:29:42 <Mic> Yes, that's definitely the case.
13:29:44 <nhnt11> and that each then is called on the original promise
13:29:45 <nhnt11> etc
13:29:45 <nhnt11> yeah
13:30:18 <Mic> Once the original promise resolves, all attached ones should be called...
13:31:04 <Mic> I'm not sure about the order, though.
13:31:05 <nhnt11> certainly expected, we just wanted to make sure it's in the spec so that behavior can't change without warning
13:31:20 <nhnt11> Mic: https://promises-aplus.github.io/promises-spec/#point-36
13:31:26 <nhnt11> The spec is pretty readable :)
13:31:36 <aleth_web> Unlike some other specs I won't mention ;)
13:31:46 <Mic> Now that's concise :)
13:39:52 <clokep_work> aleth_web: I find http://pastebin.instantbird.com/722644 a nicer improvement though. ;)
13:40:28 <aleth_web> clokep_work: Is that also in my queue? I'm a bit behind...
13:40:35 <clokep_work> aleth_web: No, not yet.
13:40:40 <clokep_work> I want other stuff to land first.
13:40:47 <aleth_web> I like it.
13:40:48 <clokep_work> Don't feel like bit rotting myself. :P
13:41:08 <clokep_work> The nicest part is obviously that joining changes. . .
13:41:26 <aleth_web> Yes :)
13:41:43 <clokep_work> Mostly because it doesn't do CRAZY things w/ string checking. ;)
13:41:52 <aleth_web> Which reminds me to review ping flo when he gets back
13:42:26 <aleth_web> Otherwise we're all just bitrotting each other in multiple directions.
13:43:54 <clokep_work> Do you have an XMPP patch too? :(
13:44:10 <aleth_web> The autoreconnect patch touches some of that.
13:44:30 <aleth_web> Without attempting to fix the CRAZY so it should land first ;)
13:48:05 <sawrubh> 'life is a race, bitrot or be bitrotten' - someone great
13:48:43 <clokep_work> :)
13:48:45 <clokep_work> Right.
13:48:59 <clokep_work> My stuff won't even work without that patch! :)
13:51:03 <aleth_web> Thankfully it's r+ already apart from the unhappy libpurple bit.
13:51:22 <-- nhnt11 has quit (Ping timeout)
14:00:27 <clokep_work> :)
14:20:21 <clokep_work> aleth_web: Thanks. I fixed that comment locally btw.
14:20:48 <aleth_web> Thanks, it's not worth uploading another bugzilla patch for it.
14:21:02 <clokep_work> My thoughts too. :)
14:30:03 <-- qheaden has quit (Ping timeout)
14:31:27 --> qheaden has joined #instantbird
14:33:07 <mayanktg> aleth_web: Yes. This is where I tried to copy the CSS from :) Ok..I didn't notice that it was OS dependent.
14:38:01 <aleth_web> mayanktg: It's possible the parts you need don't differ when you look at the details, but it's worth checking.
14:39:14 <-- GeekShadow has quit (Quit: leaving)
14:39:28 --> GeekShadow has joined #instantbird
14:40:37 <clokep_work> sawrubh: Any progress then?
14:40:42 <clokep_work> AH, never mind.
14:41:25 <mayanktg> aleth_web: Yes.different theme has been given for mac-lion.  I was going through it. Thanks :)
14:43:47 <mayanktg> Ankit apoorv sir kaise hain? Monday se joining!! :D
14:44:04 <mayanktg> ooops :-/
14:47:51 <clokep_work> aleth_web: Hahaha. " Wow, this file is out of date :-/"
14:48:01 <clokep_work> I don't know how muhc is "out of date"
14:48:05 <clokep_work> And how much was intentional.
14:51:01 --> nhnt11 has joined #instantbird
14:54:35 --> jb1 has joined #instantbird
14:55:19 <-- jb has quit (Connection reset by peer)
14:55:23 --> jb has joined #instantbird
14:56:12 <-- jb1 has quit (Ping timeout)
14:58:13 <-- nhnt11 has quit (Ping timeout)
14:58:44 --> nhnt11 has joined #instantbird
15:00:51 <sawrubh> mayanktg: :)
15:02:04 <mayanktg> sawrubh: ^_^
15:09:11 <clokep_work> sawrubh: So do you think I'll have a patch waiting for review today? :)
15:09:21 <clokep_work> aleth_web: Btw I forgot how complicated all that completion code was! :)
15:12:00 --> mconley has joined #instantbird
15:12:15 <sawrubh> clokep_work: should be! (trust me no one want this done more than me :) )
15:12:43 <aleth_web> That screenshot yesterday looked promising already
15:13:01 <sawrubh> aleth_web: are you talking about me?
15:13:07 <aleth_web> yes
15:15:53 <clokep_work> :)
15:16:16 <-- mayanktg has quit (Ping timeout)
15:20:19 <-- nhnt11 has quit (Ping timeout)
15:21:13 --> nhnt11 has joined #instantbird
15:26:14 <-- mconley has quit (Input/output error)
15:26:42 --> mayanktg has joined #instantbird
15:26:42 --> mconley has joined #instantbird
15:28:27 <-- mconley has quit (Ping timeout)
15:37:03 <sawrubh> ok, so I just realized I don't have protovis-r2.6-modded.js copied which is required by the management.xhtml pages
15:37:28 <sawrubh> aleth_web: would making the change in the jar.mns you suggested allow me not to copy
15:38:08 <-- sonny has quit (Client exited)
15:38:21 --> sonny has joined #instantbird
15:38:22 <aleth_web> copy what?
15:38:33 <sawrubh> the protoviz js file
15:39:04 <sawrubh> "chrome://messenger/content/protovis-r2.6-modded.js" through which the code is trying to get it
15:39:08 <aleth_web> What I suggested was that files you have hg mv'd to chat/ should be referred to via chrome://chat... URLs
15:39:22 <aleth_web> WHat does management.xhtml do?
15:39:52 <sawrubh> that's the page which described the content of https://developer.mozilla.org/en-US/docs/Mozilla/Thunderbird/Filelink_Providers#Management_interface
15:40:02 <sawrubh> it's there for each Provider
15:40:32 <aleth_web> Protovis is a library it needs, so you have to copy/move it.
15:41:11 <sawrubh> yeah, so right now it's in mail/base/content
15:41:27 <aleth_web> Does anything other than management.xhtml refer to it?
15:41:38 <sawrubh> where do you think copying it in chat makes sense? chat/content?
15:42:17 <aleth_web> *First* find out what else uses that file.
15:42:29 <aleth_web> *Then* decide where to put it and whether you can hg mv or need to copy.
15:44:09 <aleth_web> I can't answer your question without knowing what depends on the file.
15:44:19 <sawrubh> http://mxr.mozilla.org/comm-central/ident?i=protovis-r2.6-modded&tree=comm-central&filter= returns nothing
15:44:28 <sawrubh> am I drunk or MXR :)
15:45:14 <aleth_web> http://dxr.mozilla.org/comm-central/search?q=protovis&=comm-central&redirect=true
15:46:04 <sawrubh> yeah, dxr works. I wonder what's up with MXR re this search
15:46:26 <aleth_web> probably dislikes the - or .
15:47:03 <aleth_web> anyway, so looks like gloda also uses that library. So you have to copy not move it.
15:48:38 <aleth_web> Looks like it should be in a chat/cloudfile/content subdir.
15:50:08 <sawrubh> ok
15:50:22 <-- BWMerlin has quit (Quit: BWMerlin)
15:54:59 <aleth_web> Then you have to add it to your jar.mn in chat/cloudfile so you can refer to it as chrome://chat/content/protovis-r2.6-modded.js or maybe chrome://chat/cloudfile/content/protovis-r2.6-modded.js 
15:55:21 <aleth_web> I'm assuming you already have a chat/cloudfile dir...
15:55:39 <sawrubh> yes, that's already there
15:56:19 <-- nhnt11 has quit (Ping timeout)
15:57:13 --> nhnt11 has joined #instantbird
15:57:29 <aleth_web> To be more precise the jar.mn in chat/cloudfile/content if that's where you're putting the file.
15:58:18 <sawrubh> yeah, so I've put the file in chat/cloudfile/content, the jar is in chat/cloudfile
15:58:35 <-- gerard-majax_ has quit (Ping timeout)
15:58:41 <aleth_web> Is that where your jar.mn for all the cloudfile stuff lives? ok
15:58:54 <sawrubh> yeah
16:03:09 <sawrubh> ok, so it works : http://imgur.com/45LxRCl
16:03:16 <sawrubh> I get the blue circle now
16:04:08 <aleth_web> ok
16:05:09 <sawrubh> I need to fix the css issue (I actually figured out why there was a styling issue earlier in http://i.imgur.com/gFKOTRD.png)
16:05:23 <sawrubh> I had copied the wrong preferences.css
16:05:51 <aleth_web> Is that OS-dependent?
16:09:37 <sawrubh> so this is what I understand, the preference panel is controlled by the css in im/themes/preference-*stripe but the styling in this cloudfile pane (of the preference window) is controlled by preferences.css I've copied in chat/themes/preferences
16:10:11 <-- Mic has quit (Ping timeout)
16:10:35 <aleth_web> How are you loading those css files from the xul?
16:13:12 <sawrubh> I don't know, I mean I've only done the copying, adding that to the jar.mn chat/themes like this
16:13:23 <sawrubh> 'skin/classic/messenger/preferences/preferences.css (linux/preferences/preferences.css)'
16:13:47 <sawrubh> so now they're accessible via "chrome://messenger/skin/preferences/preferences.css"
16:14:10 <aleth_web> That sounds dodgy if you still want the im/themes preferences.css to also apply
16:14:33 <sawrubh> I'm not actually very clear, they're all named preferences.css :/
16:14:55 <nhnt11> aleth_web: I just benchmarked on a USB 2.0 drive
16:15:03 <nhnt11> 1600ms versus 4800ms
16:15:23 <nhnt11> Slightly worse the second time, 2s vs. 6s
16:15:59 <aleth_web> sawrubh: So you're creating a new, aditional, cloudfile-only preferences.css, is that right?
16:16:18 <nhnt11> Average seems to be about 1.3s vs. 4.8s
16:16:18 <aleth_web> Which is not OS dependent?
16:16:47 <aleth_web> nhnt11: So about the same factor as for the SSD, interestingly?
16:16:53 <nhnt11> Yeah.
16:17:19 <nhnt11> aleth_web: Actually I should do this again
16:17:25 <nhnt11> And ensure that the two happen one after another
16:17:28 <nhnt11> and not simultaneously
16:17:32 <aleth_web> Maybe it's because its both flash :P
16:18:27 <nhnt11> aleth_web: How about I run this and compute averages for various scenarios? (usb 2, usb 3, ssd, HFS+, FAT32, NTFS...)
16:19:06 <sawrubh> aleth_web: so I've copied mail/themes/<insert os name>/mail/preferences/preferences.css to chat/themes/<insert os name>/preferences/preferences.css (so in total I've copied 3 files and added all these3 to the jar.mn's )
16:19:20 <aleth_web> nhnt11: Just do as many as you need until you're fairly confident there's no lurking nasty surprises, don't spend a huge amount of time on it
16:19:35 <nhnt11> Not more than ~10-15 minutes, I'd say
16:20:58 <sawrubh> aleth_web: I think what I could do is copy only the parts which style the cloudfile panel only (http://mxr.mozilla.org/comm-central/source/mail/themes/linux/mail/preferences/preferences.css#172)
16:20:59 <nhnt11> aleth_web: Ah, much better numbers when I run them one after another
16:21:05 <nhnt11> 600ms vs. 3.5s
16:21:23 <aleth_web> sawrubh: But these are the preferences.css for *all* of the TB preference pane, right? IB already has preferences.css for its preference pane. So what you really want I think is to figure out what's missing from the IB preferences.css and put that there.
16:22:19 <aleth_web> We don't want chat to contain code that isn't shared. That should go in im.
16:22:43 <aleth_web> You can't just apply both the IB preferences.css AND the TB preferences.css
16:22:59 <aleth_web> They'll likely conflict and/or duplicate rules.
16:24:47 <sawrubh> aleth_web: ok
16:25:29 <nhnt11> aleth_web: Interestingly, the times for open->write 1k times->close are nearly the same for the SSD and USB 2.0 drive
16:26:11 <nhnt11> (open->write->close) 1k times is 1.5s on the ssd vs >4s on the usb 2 drive
16:26:17 <aleth_web> Interesting. I guess because throughput is pretty irrelevant here
16:26:25 <aleth_web> But I don't really know.
16:27:57 * nhnt11 doesn't have access to a windows machine to benchmark ntfs
16:28:06 <nhnt11> Don't much feel like rebooting into windows right now.. :-/
16:29:12 <aleth_web> sawrubh: If the only parts missing are those cloudfile parts, and they don't depend on the OS, then I would suggest putting them in a cloudflle-preferences.css file in /chat/themes and we can share it between TB and IB.
16:30:22 <sawrubh> nhnt11: just curious, do you have a build system setup on windows or are you going to cross-compile for it?
16:30:47 <nhnt11> sawrubh: Don't need to build. I'm running the script from Fx's scratchpad
16:30:53 <sawrubh> ah
16:30:56 <nhnt11> (no, I don't have a build system, and no, I won't cross compile)
16:31:35 <aleth_web> The scratchpad is pretty useful :)
16:40:26 --> Mook_as has joined #instantbird
16:50:34 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:52:13 --> Mic has joined #instantbird
16:52:13 * ChanServ sets mode +o Mic 
16:55:11 --> iamjayakumars has joined #instantbird
16:59:04 <-- sonny has quit (Client exited)
17:01:58 <-- mayanktg has quit (Ping timeout)
17:02:09 <-- jb has quit (Ping timeout)
17:02:33 <-- Rym has quit (Ping timeout)
17:02:55 --> Rym has joined #instantbird
17:04:01 <clokep_work> sawrubh: I don't think cross compiling is supported.
17:15:39 <clokep_work> sawrubh: So how's it comign then?
17:16:32 --> mconley has joined #instantbird
17:21:24 <sawrubh> clokep_work: so I've moved the parts I think were responsible for styling the cloudfile panel (from the preferences.css in chat/themes/<insert os name>/preferences/) to the preferences.css in im/themes/preference-*strip/preferences.css but it's not getting styled
17:21:27 --> mayanktg has joined #instantbird
17:21:40 <sawrubh> it looks like http://i.imgur.com/d9tsX9m.png instead of http://i.imgur.com/45LxRCl.png
17:23:15 <-- mayanktg has quit (Ping timeout)
17:24:44 <-- mconley has quit (Input/output error)
17:25:12 --> mconley has joined #instantbird
17:25:14 <sawrubh> wait, nvm, so I've got it looking like http://i.imgur.com/45LxRCl.png again and additionally I've been able to remove the preferences.css that I had copied to chat/themes
17:26:07 <sawrubh> still can't understand what's responsible for the blue circle to go out of the right margin
17:26:41 <aleth_web> sawrubh: Open TB with DOM Inspector installed and inspect the CSS rules on the pane and its elements
17:27:21 <aleth_web> You can compare directly with the rules on the same elements in IB (using DOM Inspector there too)
17:29:09 <-- Rym has quit (Ping timeout)
17:29:32 <clokep_work> sawrubh: Did you change things like IDs and such?
17:29:36 --> mayanktg has joined #instantbird
17:29:55 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
17:30:18 <-- mayanktg has left #instantbird (AndroIRC - Android IRC Client ( http://www.androirc.com ))
17:30:40 --> mayanktg has joined #instantbird
17:31:02 --> Rym has joined #instantbird
17:31:06 <sawrubh> ah, that might be an issue. I'll revalidate my cloudfile.xul (to see if I'm not doing anything stupid which might be preventing this from getting styled)
17:31:19 <sawrubh> btw I think I had changed the ID's that needed changing
17:31:45 <sawrubh> also checking with the DOMi in TB
17:32:34 <aleth_web> Looks like the width on the panel is wrong somehow.
17:33:40 <-- Rym has quit (Ping timeout)
17:34:23 <clokep_work> Is the JS not running on that page?
17:34:55 <aleth_web> There must be some JS running to draw that circle
17:35:06 --> myk has joined #instantbird
17:35:28 <myk> back on nightly! thanks, clokep_work!
17:36:09 <-- mayanktg has quit (Ping timeout)
17:36:16 <myk> and also thanks, nhnt11!
17:36:29 --> mayanktg has joined #instantbird
17:36:57 <aleth_web> myk: Actually it's stll a bit broken (hopefully clokep_work can push the fix for tomorrow)
17:37:30 <mayanktg> Mic: The "video call" isn't specific to any protocol currently (I can even make call to users using IRC ;) ). Tonight I'll try to convert it specifically for XMPP, add a /call command for XMPP and a button for the video call.
17:37:42 <myk> aleth_web: ah, well, at least it's working well enough for me to join this channel, thank people, see myself thanking people, and see people responding to my thanks!
17:38:25 <aleth_web> mayanktg: what's your signalling channel?
17:39:06 * nhnt11 is excited about video chat
17:39:09 <nhnt11> mayanktg++ :)
17:39:29 <nhnt11> myk: you're welcome, thanks for reporting the bug!
17:41:25 <clokep_work> myk: It's only broken slightly if you join an empty channel, one of those stupid things that really only occurs during testing. :-D
17:41:29 <-- mayanktg has quit (Ping timeout)
17:41:40 <clokep_work> Bah what's the bug number w/ mayanktg's patch again?
17:41:44 --> mayanktg has joined #instantbird
17:41:44 * clokep_work is on the wrong computer. :(
17:41:47 <myk> clokep_work: hooray for testing then!
17:43:28 --> xangua has joined #instantbird
17:44:14 <mayanktg> aleth_web: idk. Currently we are using |this._conv.sendMsg()|
17:45:30 <clokep_work> myk: But yes, thanks for reporting it! :)
17:47:34 <aleth_web> mayanktg: Oh, I see, so this just hacks conversation.xml so when it receives a particular message, it starts a video chat with the sender?
17:48:20 <mayanktg> aleth_web: Yes. That's the reason I'm able to set up calls within any protocol. 
17:48:56 <aleth_web> When you've done XMPP we should definitely do it for IRC too :D
17:49:24 <aleth_web> And sawrubh can transmit files via peer connection.
17:50:27 <mayanktg> aleth_web: I have to rewrite the code for XMPP.
17:50:41 <aleth_web> Oh sure. This is for the future ;)
17:51:16 <aleth_web> Lots to do still before it all works for XMPP, with the UI and everything
17:51:55 <-- mayanktg has quit (Client exited)
17:51:57 --> mayanktg has joined #instantbird
17:54:39 --> Kynos has joined #instantbird
18:01:26 <-- mayanktg has quit (Ping timeout)
18:02:17 --> mayanktg has joined #instantbird
18:02:22 <-- mayanktg has quit (Quit: mayanktg)
18:02:25 --> mayanktg has joined #instantbird
18:03:19 --> Rym has joined #instantbird
18:04:18 <-- mayanktg has quit (Ping timeout)
18:09:04 --> mayanktg has joined #instantbird
18:09:24 <clokep_work> Gonna have to make sure it's interoperable w/ other clients too.
18:09:38 <mayanktg> aleth_web: Yes. What should I do now? Should I start writing it for XMPP or first I should go for writing in conversation.xml only?
18:10:59 <aleth_web> Make sure the bugs you have been working on have patches that can be reviewed. Then move on to the XMPP, discuss with Mic as soon as you can how to proceed with that.
18:11:32 <aleth_web> If you know what to do for XMPP, go ahead of course ;)
18:12:03 <-- Rym has quit (Ping timeout)
18:12:45 <mayanktg> aleth_web: idk at moment what to do for XMPP :-| . 
18:13:15 <clokep_work> mayanktg: What don't you know? ;) Be specific so we can answer questions intelligently.
18:13:56 <mayanktg>  aleth_web: You mean the Bug 975542 and Bug 1004930
18:14:03 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=975542 enh, --, ---, mayanktg, NEW, Set user icon from image taken with the webcam.
18:14:04 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1004930 enh, --, ---, nobody, NEW, Generic way to add buttons for actions to a conversation
18:14:07 <aleth_web> yes
18:18:20 <mayanktg> aleth_web: I have attached the patch for the user icon bug and also for the generic buttons one.
18:18:35 <aleth_web> great
18:19:56 <mayanktg> aleth_web: regarding the generic buttons bug Mix said we would proceed further when he reviews the patch once.
18:20:04 <mayanktg> *Mic
18:20:30 <aleth_web> OK, sounds like you definitely want to move on to clokep_work
18:20:34 <aleth_web> 's question then ;)
18:21:32 --> gerard-majax_ has joined #instantbird
18:24:52 <-- iamjayakumars has quit (Quit: )
18:25:27 <mayanktg> clokep_work: Sorry :-/ How to create commands for XMPP (like we have for IRC), how should I proceed with creating calls specifically for XMPP?
18:26:08 <aleth_web> Do you know what kind of XMPP stanzas to send for this?
18:26:16 <aleth_web> Does this use one of the XEPs?
18:26:29 <mayanktg> aleth_web: No.
18:27:11 <clokep_work> mayanktg: I believe you linked to a bunch of XEPs in your application.
18:27:12 <clokep_work> RIght?
18:27:14 <clokep_work> Have you read those yet?
18:29:22 <mayanktg> I have read the media discovery protocol (0030) and Jingle(0166)
18:33:26 <-- Kynos has quit (Quit: http://www.mibbit.com ajax IRC Client)
18:36:55 <mayanktg> I didn't go through it completely, just understood why do we need the media discovery and Jingle session protocol. 
18:40:41 <clokep_work> OK.
18:41:02 <clokep_work> So break down the work: what do you need to add to get this feature in there?
18:41:56 --> Rym has joined #instantbird
18:42:01 <clokep_work> sawrubh: Any luck with that styling?
18:42:40 <mayanktg> 1. session initiation 2. user at other end should be able to accept/reject call 3. stream local and remote video at both ends. 4. a command to start the session.
18:43:28 <clokep_work> Alright, so let's start at #4 since you can't do the others until you have a way to initiate. ;)
18:43:57 <mayanktg> clokep_work: Yes!
18:44:26 <clokep_work> mayanktg: So XMPP doesn't register any commands currently, so we'll need to do that, IRC defines it's commands in https://mxr.mozilla.org/comm-central/source/chat/protocols/irc/ircCommands.jsm and registers them at https://mxr.mozilla.org/comm-central/source/chat/protocols/irc/irc.js#1702
18:46:37 <clokep_work> I'd suggest making a stupid command initially (/call is fine) that just dumps or prints or something.
18:46:59 <mayanktg> clokep_work: Ok. so we should create a separate file (xmppCommands) for this?
18:47:00 <mayanktg> 	
18:47:13 <mayanktg> Ok.
18:47:55 <mayanktg> clokep_work: Ok. so we should create a separate file (xmppCommands) for this
18:48:41 <clokep_work> Umm...I don't know, probably.
18:48:49 <clokep_work> I think the XMPP code uses dashed names btw.
18:49:02 <clokep_work> So xmpp-commands.jsm.
18:49:09 <clokep_work> aleth_web: Any thoughts on it being a separate file or just inlining it?
18:49:17 <mayanktg> ok..like xmpp-xml.jsm
18:49:37 <clokep_work> Oh wait, it should definitely be a separate file  cause each protocol has to add it, yeah.
18:50:56 <mayanktg> ok..Then I should look for how other commands are implemented in IRC..
18:51:56 <mayanktg> probably like how /topic is written for XMPP MUC chat?
19:00:31 <-- mpmc has quit (Ping timeout)
19:00:45 <clokep_work> There is no /topic command.
19:00:50 --> mpmc has joined #instantbird
19:00:55 <clokep_work> mayanktg: That's what I'm saying there are NO commands.
19:01:07 <clokep_work> But you should look inside of xmpp.jsm to see what's necessary to actually send a message.
19:01:25 <clokep_work> (where "message" means "some XML that is part of XMPP")
19:02:25 <clokep_work> mayanktg: Does that make sense? Please ask if I'm not clear.
19:03:49 <-- Rym has quit (Ping timeout)
19:06:17 <mayanktg> clokep_work: Yes it does. I should look for how a message is sent. and then use the same steps to print something when user enters that command.
19:06:50 <mayanktg> I'm giving it a try. Sorry for replying late.
19:11:36 <sawrubh> clokep_work: I was comparing the two (filelink panel in TB and mine in IB) both under DOMi
19:12:00 <sawrubh> there doesn't seem to be any difference in the CSS rules applied on both of them
19:14:48 <clokep_work> sawrubh: Is there some JS function that runs that sets everything up when it first loads that we're not running?
19:16:22 <sawrubh> so what's happening is that the width of this entire tabpanel (containing the vbox listing the providers and the vbox containing the infographic (blue circle, name of provider)) their width is not being set properly
19:16:42 <sawrubh> so it's equivalent to like a horizontal scrollbar has been added
19:17:00 <sawrubh> so trying to now find the css rule which applied in the TB case which prevents this overflow
19:29:57 <clokep_work> Alright.
19:30:06 <clokep_work> Does everything work besides that?
19:30:25 <clokep_work> I'd appreciate if you could put up a patch for feedback so I can start looking over it while you try to debug this last piece.
19:30:56 --> gerard-majax__ has joined #instantbird
19:31:07 <-- gerard-majax_ has quit (No route to host)
19:32:07 <sawrubh> yes, everything else works besides that. Sure I'll put it up for feedback.
19:34:25 <clokep_work> Thanks.
19:34:27 <clokep_work> I'm going home.
19:36:07 <-- clokep_work has quit (Ping timeout)
19:38:19 <-- gerard-majax__ has quit (Quit: Ex-Chat)
19:38:24 --> gerard-majax__ has joined #instantbird
19:46:28 <sawrubh> it worked finally! I had (in one of the biggest time wasting) accidents remove the orient="vertical" on the tabpanel which was causing this
20:08:44 <-- gerard-majax__ has quit (Ping timeout)
20:14:23 <mayanktg> Do we need to do a complete build after adding a new JS module in chat/ ? 
20:15:54 <sawrubh> when you say a module you mean a .js or .jsm file right?
20:16:10 <sawrubh> ./mozilla/mach build im/ should be sufficient I guess since it builds chat/ too
20:16:31 <mayanktg> sawrubh: Yes a .jsm file. Ok
20:26:45 <-- mconley has quit (Ping timeout)
20:30:43 --> clokep has joined #instantbird
20:30:43 * ChanServ sets mode +o clokep 
20:32:58 <clokep> sawrubh: You might need to just mach build if you change moz.build files, I think it prompts you though.
20:33:04 <clokep> Oops that was for mayanktg ^
20:33:45 <mayanktg> clokep: Ok. I already set it for ./mozilla/mach build 
20:43:19 --> Mic has joined #instantbird
20:43:19 * ChanServ sets mode +o Mic 
20:43:36 <Mic> re: http://log.bezut.info/instantbird/today#m544
20:43:40 <Mic> aleth_web: the signalling channel is plain text messages afaik.
20:44:02 <Mic> mayanktg: that's why it should work with any protocol.
20:45:54 <Mic> Ah, you figured that out yourself.
20:46:05 * Mic shuts up until he's read all of the backlog ;)
20:48:55 <-- aleth_web has quit (Quit: Connection closed for inactivity)
20:55:47 --> mconley has joined #instantbird
20:57:07 <clokep> sawrubh: While you're waiting for feedback, take anothe rlook at that XMPP bug too!
20:57:42 <sawrubh> hehe, yeah I will :)
20:57:48 * clokep thinks mconley might like https://i.imgur.com/45LxRCl.png
20:59:14 <sawrubh> he might like this more http://i.imgur.com/sM4konl.png :)
20:59:48 <sawrubh> (I need to port that formatFileSize for the better numbers obviously)
21:00:44 <sawrubh> quick question : does someone know a image uploading/sharing service where I won't have to load the huge number of images on the homapage before uploading (like Imgur)
21:00:56 <sawrubh> I don't have the bandwidth nor the speed to support it :/
21:01:54 <-- mconley has quit (Ping timeout)
21:04:05 <clokep> nhnt11: ^
21:11:13 --> mayanktg-ph has joined #instantbird
21:13:37 <-- mayanktg-ph has quit (Ping timeout)
21:15:48 --> mayanktg-ph has joined #instantbird
21:15:52 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:17:55 <-- mayanktg-ph has quit (Ping timeout)
21:20:47 --> mayanktg-ph has joined #instantbird
21:23:45 <-- mayanktg-ph has quit (Ping timeout)
21:27:57 --> mayanktg-ph has joined #instantbird
21:28:41 <mayanktg-ph> sawrubh you can try postimg.org
21:31:17 <mayanktg-ph> Mic: I have added a patch for the generic buttons bug. Whenever you're free take a look over it and tell what else needs to be added/removed.
21:32:30 <-- mayanktg-ph has quit (Client exited)
21:34:38 --> mayanktg-ph has joined #instantbird
21:41:29 <Mic> sawrubh: if you feel like hacking, imgur has an API for uploading.
21:41:43 <Mic> Here's an example that is using it. http://codepo8.github.io/interaction-cam/interactioncam.js
21:46:19 --> mayank_mob has joined #instantbird
21:46:39 <-- mayanktg-ph has quit (Ping timeout)
21:48:08 <-- mayank_mob has quit (Ping timeout)
21:50:46 <clokep> Maybe once we have file transfer. :P
21:55:20 --> mayank_mob has joined #instantbird
21:58:33 <-- mayank_mob has quit (Ping timeout)
22:02:32 * sawrubh goes to take a look at the setting-the-topic bug
22:29:11 <-- xangua has quit (Quit: Connection closed for inactivity)
22:52:46 <Mic> mayanktg: I looked over your patch and it looked OK from what I've seen. I'll review it tomorrow (and the webrtc patch too).
22:52:51 <Mic> Good night!
22:52:57 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
22:58:45 <-- Tonnes has quit (Ping timeout)
23:08:04 --> wnayes has joined #instantbird
23:08:45 --> Tonnes has joined #instantbird
23:12:43 <-- mayanktg has quit (Quit: Connection closed for inactivity)
23:17:55 --> Rym has joined #instantbird
23:41:23 <-- Armada has quit (Connection reset by peer)
23:51:55 <nhnt11> sawrubh: I use puush, it's pretty good: http://puush.me
23:52:00 * nhnt11 fell asleep :]
23:54:38 <-- nhnt11 has quit (Ping timeout)
23:55:39 --> nhnt11 has joined #instantbird