#instantbird log on 05 29 2014

All times are UTC.

00:00:00 <nhnt11> I've put together something that works
00:00:25 <nhnt11> clokep: Do you think this is very ugly? https://pastebin.mozilla.org/5275178
00:00:28 <clokep> That doesn't sound confident. :)
00:00:54 <nhnt11> The promise that is finally returned by that function rejects if any of the I/O operations in the Task reject
00:00:58 <nhnt11> (tested it thoroughly)
00:01:13 <clokep> nhnt11: What is safelyDoOperation? ;)
00:02:01 <nhnt11> clokep: Should be safelyDoFileOperation, https://pastebin.mozilla.org/5275192
00:02:37 <nhnt11> Queues operations on files
00:02:39 <clokep> nhnt11: It doesn't look insane, but I really can't concentrate.
00:02:41 <clokep> I need to eat / shower.
00:02:44 <nhnt11> Okay
00:02:53 <clokep> I can look in ~42 minutes.
00:03:03 <nhnt11> Sure
00:03:55 * nhnt11 needs to blog about this, it took me a while to come up with something that works
00:07:25 <-- nhnt11 has quit (Ping timeout)
00:08:22 --> nhnt11 has joined #instantbird
00:13:58 <-- rosonline has quit (Client exited)
00:18:46 <-- arlolra has quit (Quit: arlolra)
00:20:25 <-- EionRobb has quit (Connection reset by peer)
00:23:45 <-- Armada has quit (Connection reset by peer)
00:24:02 <-- nhnt11 has quit (Ping timeout)
00:29:40 --> nhnt11 has joined #instantbird
00:29:47 * nhnt11 will be surprised if this new code works
00:31:02 <nhnt11> Wow, writing is working :D
00:33:41 <clokep> :)
00:33:53 --> EionRobb has joined #instantbird
00:33:56 <nhnt11> and the reason reading failed was because i forgot to push the UI patch
00:34:02 <nhnt11> s/push/qpush
00:34:03 * nhnt11 tests
00:34:46 <nhnt11> errors.. yay
00:40:04 <nhnt11> Ah, that was because of a bad file! :D
00:40:13 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
00:40:27 --> nhnt11 has joined #instantbird
00:40:37 <nhnt11> So it works :)
00:41:17 <nhnt11> Interesting though. The bad file caused this: https://pastebin.mozilla.org/5275448
00:42:10 <clokep> nhnt11: Here's a fun one...what happens on Windows where paths are case insensitive?
00:42:31 <nhnt11> Boo clokep... booo
00:42:33 <nhnt11> Sorry.
00:42:38 <clokep> ;)
00:42:41 <clokep> My job.
00:43:39 <nhnt11> Turns out I just needed to wrap filename in an array there.
00:49:02 * nhnt11 can't think of anything left to do for this patch except get it reviewed :)
00:49:33 <nhnt11> stuff is async, error handling is done, race conditions handled
00:49:53 <nhnt11> Case insensitive paths... hmm
00:50:32 <nhnt11> That's more of a filesystem thing than a windows thing
00:52:26 <nhnt11> clokep: Here's my answer: there's no user-inputted path coming in so there's no need to worry
00:53:03 <nhnt11> All the paths I use are created using OS.Path.join and OS.Constants.Path.profileDir
00:53:16 <nhnt11> So even if uppercase used somewhere, it's consistent
00:53:44 <clokep> nhnt11: No.
00:54:01 <clokep> nhnt11: What if somewhere I use "foo" and somewhere else I use "Foo"? When you join them it won't change the case.
00:54:26 <nhnt11> clokep: I can't see such a situation happening.
00:54:49 <nhnt11> (because if I've used "foo" somewhere, I've used "foo" everywhere)
00:55:31 <clokep> You're assuming you're the only one using the API....
00:56:41 <nhnt11> clokep: That's the thing. The API doesn't let the consumer specify paths
00:56:42 <nhnt11> Consumers request logs for accounts, buddies, etc
00:57:03 <-- wnayes has quit (Ping timeout)
00:57:32 --> wnayes has joined #instantbird
00:57:39 <clokep> Alright. Then it's probably OK.
00:59:14 <-- nhnt11 has quit (Ping timeout)
01:08:18 --> nhnt11 has joined #instantbird
01:08:25 <nhnt11> 06:28:25 - nhnt11: There is one place where a consumer can specify a path, but that path is never actually used. The directory name is extracted, and a DirectoryIterator is used to get entries. => consistency.
01:11:04 <clokep> Cool.
01:25:45 <-- nhnt11 has quit (Ping timeout)
01:26:25 --> nhnt11 has joined #instantbird
01:27:32 <-- Mook_as has quit (Quit: Mook_as)
01:37:12 <-- nhnt11 has quit (Ping timeout)
01:45:56 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
02:17:39 --> nhnt11 has joined #instantbird
02:19:26 <-- nhnt11 has quit (Ping timeout)
02:20:45 --> nhnt11 has joined #instantbird
02:25:51 <-- Rym has quit (Ping timeout)
02:31:36 --> Rym has joined #instantbird
02:42:36 <-- wnayes has quit (Quit: wnayes)
02:59:17 <-- nhnt11 has quit (Ping timeout)
03:00:20 --> nhnt11 has joined #instantbird
03:12:11 <-- nhnt11 has quit (Ping timeout)
03:12:56 --> nhnt11 has joined #instantbird
03:13:17 <-- sukhe has quit (Quit: leaving)
03:26:54 <-- nhnt11 has quit (Ping timeout)
03:27:01 --> mconley has joined #instantbird
03:27:43 --> nhnt11 has joined #instantbird
03:32:58 <-- nhnt11 has quit (Ping timeout)
03:34:16 --> nhnt11 has joined #instantbird
03:36:47 <-- nhnt11 has quit (Ping timeout)
03:38:06 --> nhnt11 has joined #instantbird
03:46:45 <-- nhnt11 has quit (Ping timeout)
03:48:04 --> nhnt11 has joined #instantbird
03:48:05 <-- mconley has quit (Connection timed out)
03:49:23 --> mconley has joined #instantbird
04:15:27 <-- mconley has quit (Input/output error)
04:15:54 --> mconley has joined #instantbird
04:17:47 <-- mconley has quit (Ping timeout)
04:31:03 <-- CaptainCalliope has quit (Quit: CaptainCalliope)
04:31:42 <-- Rym has quit (Ping timeout)
05:02:28 --> mpmc has joined #instantbird
05:04:07 --> jb has joined #instantbird
05:15:55 <-- EionRobb has quit (Quit: Leaving.)
05:29:38 <-- jb has quit (Quit: jb)
05:30:46 --> jb has joined #instantbird
05:58:59 --> mayanktg has joined #instantbird
06:11:15 <-- nhnt11 has quit (Ping timeout)
06:12:45 --> nhnt11 has joined #instantbird
06:23:56 <-- nhnt11 has quit (Ping timeout)
06:25:16 --> nhnt11 has joined #instantbird
06:44:46 <-- mayanktg has quit (Ping timeout)
06:46:13 --> mayanktg has joined #instantbird
06:51:50 <-- nhnt11 has quit (Ping timeout)
06:53:23 --> nhnt11 has joined #instantbird
07:06:26 --> Tonnes has joined #instantbird
07:08:17 <-- nhnt11 has quit (Ping timeout)
07:09:55 --> nhnt11 has joined #instantbird
07:11:52 <mayanktg> aleth: Good Morning :) Received a response from James. I don't have a Windows build of Ib and the NVDA screen reader is unable to install using Wine :-/ 
07:13:32 <-- nhnt11 has quit (Ping timeout)
07:15:21 --> nhnt11 has joined #instantbird
07:28:23 <-- nhnt11 has quit (Ping timeout)
07:29:54 --> nhnt11 has joined #instantbird
07:31:43 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
07:32:34 <-- nhnt11 has quit (Ping timeout)
07:33:25 --> BWMerlin has joined #instantbird
07:33:41 --> nhnt11 has joined #instantbird
08:02:54 --> mayanktg-ph has joined #instantbird
08:03:10 <-- mayanktg-ph has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
08:03:54 --> mayanktg-ph has joined #instantbird
08:04:44 <-- mayanktg-ph has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
08:16:25 <-- jb has quit (Connection reset by peer)
08:16:28 --> jb1 has joined #instantbird
08:21:22 <sawrubh> Afternoon folks!
08:29:15 --> EionRobb has joined #instantbird
09:05:02 <-- jb1 has quit (Ping timeout)
09:08:44 --> mpmc has joined #instantbird
09:09:09 <mayanktg> Mic: Hello!
09:11:30 --> aleth has joined #instantbird
09:11:30 * ChanServ sets mode +o aleth 
09:12:12 --> Armada has joined #instantbird
09:25:18 --> Armada651 has joined #instantbird
09:25:18 <-- Armada has quit (Connection reset by peer)
09:25:36 --> Armada_ has joined #instantbird
09:25:36 <-- Armada651 has quit (Connection reset by peer)
09:25:54 --> Mic has joined #instantbird
09:25:54 * ChanServ sets mode +o Mic 
09:27:54 <mayanktg> Mic: Are you free? I'm getting repeated menuitems in the target switcher menu :-| 
09:28:05 <mayanktg> Here's the diff http://pastebin.instantbird.com/721262
09:28:05 <Mic> Hi
09:28:46 <mayanktg> The menuitem is repeated twice for each contact 
09:30:05 <mayanktg> Mic: I had to remove the anonid as the contents were not anonymous any more and I'm now using |getElementById| to get the contents.
09:30:14 <Mic> I saw that.
09:30:19 <Mic> Might be part of the problem.
09:30:37 <mayanktg> Ok.
09:30:53 <aleth> Two elements with the same id in the same document maybe?
09:30:55 <Mic> IDs are global while get anonid only works on the subtree of an element afaik.
09:31:58 <Mic> IF you have more than one tab opened then check the menus of the other tabs if they look odd (not necessarily in the same way as the first one).
09:32:25 <Mic> Maybe they do not contain any items? (e.g. all items going into the 'first' menu?).
09:32:35 <Mic> That's just a wild guess, though.
09:32:53 <Mic> Did it work while you were still using anonid?
09:33:02 --> jb has joined #instantbird
09:33:12 <mayanktg> Mic: No it didn't work if I was using anonid
09:33:32 <mayanktg> infact anonid didn't work itself
09:33:36 <aleth> Children are not anonymous content.
09:34:35 <mayanktg> When I was using target switcher menu to switch targets. That's why I had to change it to "id"
09:37:13 <Mic> Use getElementByAttribute? That will also search only the subtree (/ the children) of an element.
09:37:25 <mayanktg> Mic: Yes. All the elements are going to the first menu. i.e. to the first tab opened :'(
09:37:33 <Mic> getElement*s*ByAttribute
09:37:42 --> sonny has joined #instantbird
09:37:56 <mayanktg> ok
09:37:58 <Mic> mayanktg: why so sad? We've identified the problem quickly :)
09:40:57 --> sonny1 has joined #instantbird
09:41:40 <-- sonny has quit (Ping timeout)
09:45:05 <mayanktg> Mic: I have changed |getElementById| to |getElementsByAttribute| http://pastebin.instantbird.com/721265 . But now I'm getting an error that "targetButton.setAttribute is not a function"
09:46:41 <aleth> Why do you think that is?
09:47:12 * sonny1 is now known as sonny
09:47:13 <aleth> What could cause setAttribute not to be a function?
09:48:08 <aleth> What is it if it's not a function?
09:48:34 <aleth> (Just trying to show you how to investigate these things)
09:48:45 <mayanktg> Because we can have multiple items with the same attribute
09:48:52 <Mic> Yay! ;)
09:49:14 <Mic> That's why I correct myself with "getElement*s*ByAttribute" earlier.
09:49:40 <aleth> You can use getElements... but if you look at mdn you will find the return value isn't a button ;)
09:49:59 <mayanktg> Ok!
09:50:39 <aleth> Generally if you add a few dump()s to investigate return values you can figure this kind of thing out for yourself pretty quickly.
09:51:40 <mayanktg> So we'd have to use |getlementById| only ?
09:51:42 <mayanktg> Ok
09:55:32 <aleth> You can use whatever you like.
09:55:50 <aleth> You could use querySelector too if you prefer.
09:56:49 <aleth> Or getElementsByTagName.
09:56:53 <aleth> Lots of options...
09:56:56 <mayanktg> Ok.
09:57:28 <aleth> Look at what's available on mdn and choose what is most appropriate.
09:58:07 <aleth> The one thing that won't work is getElementById, for the reasons Mic explained earlier ;)
09:59:55 <Mic> You need to make sure that your choice only searches the descendants / children of an element, otherwise you'll get all those other menus in the other tabs returned too.
10:00:32 <mayanktg> Yes. I'm searching for the right one 
10:04:10 <-- aleth has quit (Ping timeout)
10:10:23 --> chrisccoulson has joined #instantbird
10:18:30 <-- jb has quit (Ping timeout)
10:22:13 --> clokep has joined #instantbird
10:22:13 * ChanServ sets mode +o clokep 
10:23:19 <sawrubh> clokep: o/
10:25:55 <clokep> mayanktg: Try server is a thing run by Mozilla that allows people to push code and have the buildbots build things. That's what Jamie was asking for.
10:26:57 <mayanktg> clokep: Ok. Now I remember "try server" The one which nhnt11 has access to and filled a form for it? ;)
10:27:09 <clokep> Yes, he has commit access.
10:27:14 <sawrubh> yep, you need an L1 access
10:27:15 <clokep> As do I, aleth and maybe Mic.
10:27:23 <sawrubh> and me :)
10:28:13 <mayanktg> ahh great :D
10:28:49 <clokep> aleth: Are you positive we can't do try builds? :-S
10:30:00 <-- chrisccoulson has quit (Ping timeout)
10:31:22 --> Rym has joined #instantbird
10:31:36 --> aleth has joined #instantbird
10:31:37 * ChanServ sets mode +o aleth 
10:33:10 <aleth> clokep: If we can do try builds, I certainly don't know how.
10:33:49 <aleth> Actually for try builds you wouldn't need L1 access iirc.
10:35:30 <clokep> You do.
10:35:59 <clokep> aleth: Theoretically we should be able to push a new mozconfig along w/ the changes you want to build and it shuld work, but I've only tried a couple times and couldn't get it working.
10:36:06 <clokep> It's the same as someone building seamonkey, for instance.
10:36:11 <aleth> Ah sorry, I misremembered, L1 is the lowest not the highest access.
10:36:12 <clokep> Anyway, not important.
10:37:55 <aleth> clokep: Yeah, I've also tried, and I assume some configuration would be required somewhere.
10:38:11 <-- EionRobb has quit (Quit: Leaving.)
10:39:23 <clokep> Not important right now though. :)
10:39:43 <aleth> Nope, I didn't spend any time on it either ;)
10:42:04 <clokep> sawrubh: Did you have a question or just saying hi?
10:42:35 <sawrubh> just wanted to say hi
10:43:46 <clokep> How goes the preferences stuff? I'd like to see a new patch today.
10:47:34 <sawrubh> I got stuck at a couple of places(like was evident on irc yesterday), I'm figuring it out, a new patch should be ready today
10:48:58 <clokep> OK, feel free to ask if you're spinng your wheels for a bit when you're stuck.
10:50:58 <clokep> mayanktg: Nice blog post. :)
10:53:16 <mayanktg> clokep: thanks :)
11:00:54 <-- sonny has quit (Ping timeout)
11:04:12 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:06:57 --> sonny has joined #instantbird
11:08:40 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:11:12 <-- sonny has quit (Ping timeout)
11:19:05 <Mic> mayanktg: have you chosen a get*-method that works for you?
11:32:17 --> mayanktg has joined #instantbird
11:34:26 <sawrubh> aleth: is there a preprocessor run on js file to remove things like http://mxr.mozilla.org/comm-central/source/mail/components/preferences/applications.js#1301 ?
11:34:55 <aleth> Yes, if the file is marked for preprocessing in jar.mn
11:34:55 <mayanktg> Mic: I tried using querySelector, getElementsByTagName but I'm unable to get a suitable one. Also tried using the childNodes.
11:35:31 --> sonny has joined #instantbird
11:36:14 <sawrubh> aleth: and how do we mark that?
11:36:35 <aleth> There's an asterisk at the beginning of the line.
11:36:46 <sawrubh> ok
11:37:56 * sawrubh will blog about jar.mn's someday
11:40:57 <aleth> mayanktg: I think Mic can help you better if instead of "I tried" you show him /how/ you tried in a pastebin
11:42:00 <aleth> Because clearly any of these can be made to work ;)
11:49:52 <mayanktg> Mic: http://pastebin.instantbird.com/721366 I think I'm unable to get the children and probably repeating the mistake of getElementsByTagName .
11:51:05 <mayanktg> brb
11:51:26 <aleth> I don't think you understood what Mic was telling you earlier :-/
11:52:54 <aleth> Get rid of the id on non-unique elements.
11:57:09 <nhnt11> Hi!
11:57:37 <aleth> Hi :)
11:57:50 <aleth> Haven't had a chance to look at your new patch yet.
11:58:00 <nhnt11> Okay
11:58:33 <aleth> You're right it's annoying that Task.jsm uses Promises.jsm... I hope it gets replaced it with a built-in Task soon, but I have not been able to find out anything about that.
11:59:23 <nhnt11> aleth: The returned Promise seems to be at least "compatible" with DOM promises
11:59:30 <nhnt11> (i.e. catch works)
11:59:43 <aleth> Yes, but one always worries about edge cases...
12:00:02 <nhnt11> I was testing stuff in the firefox console (because it's shinier :]) and there, DOM promises didn't seem to be available
12:00:11 <nhnt11> or rather promises.js was already in the scope so they weren't used
12:00:53 <aleth> It's possible they're not available in content by default
12:00:53 --> chrisccoulson has joined #instantbird
12:00:58 <nhnt11> By the way, there are these weird "uncaught exception: 2147500033" errors in my error console
12:01:21 <nhnt11> Might be an addon, not totally sure
12:01:51 <aleth> If you pick chrome as the context, DOM Promises should be there (assuming your FX isn't too old)
12:02:09 <nhnt11> Maybe I'm not using the Fx console properly
12:02:23 <nhnt11> How do I choose chrome as the context?
12:02:34 <aleth> Haven't seen any of those errors in IB.
12:02:59 <nhnt11> It's likely an addon. My pastebinner addon gives me aConv is null sometimes..
12:03:05 * nhnt11 needs to update that
12:03:36 <aleth> nhnt11: devtools.chrome.enabled = true, then the scratchpad gets an Environment menu, choose Browser
12:03:42 <nhnt11> Ah, thanks
12:04:09 * nhnt11 loves the Fx console
12:04:19 <nhnt11> I recently discovered how powerful it is...
12:04:42 <aleth> Strange that they aren't there in content though given bug 918806
12:04:47 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=918806 nor, --, mozilla29, nsm.nikhil, RESO FIXED, Enable promises by default
12:05:48 <nhnt11> aleth: Okay, now I tried |Promise.reject("test").catch(alert)| in content context and it worked
12:05:55 <nhnt11> So maybe I was doing something wrong
12:06:14 <nhnt11> I wonder if it's possible that the page I was on at the time had imported promise.js and so the console had it in context?
12:06:19 <-- Rym has quit (Ping timeout)
12:08:26 <sawrubh> aleth: I'm not able to figure out why this isn't working. I have copied applications.xul/js and named them as cloudfile.xul/js, made some changes in the xul file which looks like this now http://pastebin.instantbird.com/721397, I get no errors in the error console (earlier I was getting some which I fixed by making the appropriate includes) 
12:08:35 --> Rym has joined #instantbird
12:09:05 <nhnt11> aleth: I'm curious on your opinion about the whole queue system by the way. It seems a tad bit overkill
12:09:06 <nhnt11> Maybe not ikd
12:09:08 <nhnt11> idk*
12:09:13 <-- chrisccoulson has quit (Ping timeout)
12:09:48 <aleth> nhnt11: How expensive is it to open/close the file all the time?
12:10:12 <sawrubh> all I get is a blank panel in the preference window (http://i.imgur.com/daYR6WG.png)
12:10:18 <nhnt11> aleth: "02:47:46 - Yoric: That shouldn't be too expensive."
12:11:18 <aleth> Not saying I'm disagreeing but doesn't that depend on how many messages are coming in?
12:11:29 <aleth> I'm a bit surprised if it's not an issue.
12:11:43 <nhnt11> hmm yeah.
12:12:42 <aleth> Maybe get some rough numbers from a very busy channel on the possible frequency of writes and check.
12:13:20 <nhnt11> If it's an issue, we should probably have a message "tank" and flush the whole thing when it's full..
12:13:46 <aleth> Let's first figure out how much of an issue it is. Ie if it's not an issue, we should understand why not.
12:14:08 <aleth> Also I should go look at the patch first ;)
12:14:10 <nhnt11> Yeah. I'll talk with Yoric a bit more when he's online :)
12:14:18 <-- Mic has quit (Ping timeout)
12:15:08 --> rosonline has joined #instantbird
12:16:47 <-- aleth has quit (Ping timeout)
12:17:21 --> clokep_work has joined #instantbird
12:17:21 * ChanServ sets mode +o clokep_work 
12:17:48 <-- sonny has quit (Ping timeout)
12:21:17 <sawrubh> clokep_work: I've got a doubt in the logs ^^
12:23:09 --> aleth has joined #instantbird
12:23:09 * ChanServ sets mode +o aleth 
12:24:05 <clokep_work> a doubt?
12:24:55 <sawrubh> clokep_work: http://log.bezut.info/instantbird/140529/#m277
12:25:07 <sawrubh> clokep_work: http://log.bezut.info/instantbird/140529/#m284
12:25:49 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:25:53 <clokep_work> I don't understand how that's a "doubt".
12:26:04 <clokep_work> sawrubh: Hmm...what did you change from when it was working? ;)
12:26:59 --> Mic has joined #instantbird
12:27:00 * ChanServ sets mode +o Mic 
12:27:48 <-- rosonline has quit (No route to host)
12:27:53 <sawrubh> it was never working, as in that panel was never getting populated like it's shown in https://developer.mozilla.org/en-US/docs/Mozilla/Thunderbird/Filelink_Providers#Management_interface
12:28:14 <sawrubh> I'm trying to get it to work
12:28:20 <aleth> My confusion starts with the filenames.
12:28:36 <aleth> We already have an Applications pane.
12:29:15 --> rosonline has joined #instantbird
12:29:57 <mayanktg> aleth: What should I do after removing the id's? How can I get only the children elements of the menu? :-|
12:30:28 <aleth> sawrubh: http://mxr.mozilla.org/comm-central/source/im/content/preferences/applications.xul
12:30:31 * nhnt11 found something interesting http://stackoverflow.com/a/11349501
12:30:47 <nhnt11> It's python, but still..
12:31:07 <sawrubh> aleth: so that's why I named my filed as cloudfile.xul/js and made the appropriate changes in preferences.xul (http://pastebin.instantbird.com/721411)
12:31:09 <nhnt11> I doubt our use case is that severe though :)
12:31:29 <clokep_work> sawrubh: Maybe the IDs are clashing though?
12:31:51 <sawrubh> that should have shown an error
12:31:53 <aleth> sawrubh: I really doubt the attachments pane in TB is called applications.xul.
12:32:06 <clokep_work> sawrubh: Don't depend on that, do it the right way.
12:32:12 <aleth> But maybe I don't understand what you're trying.
12:33:06 <-- BWMerlin has quit (Quit: BWMerlin)
12:33:08 <aleth> mayanktg: So what exactly are you trying to do?
12:34:05 <nhnt11> aleth: The question I just asked in #perf makes sense right?
12:34:54 <aleth> sawrubh: This looks OK http://pastebin.instantbird.com/721411 though I would call the new pane filetransfer.xul if it's not going to be just for cloudfile.
12:35:00 <aleth> (if)
12:35:35 <sawrubh> aleth: TB's attachment pane does come from applications.xul (http://mxr.mozilla.org/comm-central/source/mail/components/preferences/applications.xul#172)
12:35:49 --> jb has joined #instantbird
12:36:01 <aleth> sawrubh: Ah, so we can blame TB for being confusing :D
12:36:04 <sawrubh> some weird naming convention but I'm pretty sure about it (I've been groking around in it)
12:36:44 <mayanktg> aleth: I'm trying to bring the menupopup of the target switcher to the correct window. Currently it is displayed in the first window that appears.
12:37:32 <clokep_work> sawrubh: Btw a patch would probably be easier to look at. :-\ I'd suggest changing the IDs first though.
12:37:44 <mayanktg> aleth: For this Mic said to see that I should use getEle.. such that only the correct children elements is get. 
12:38:12 <aleth> mayanktg: Yes but try to be more specific. Look at the DOM of the window with DOM inspector and phrase it something like "I want to get all the elements of the kind X in the conversation binding" or "I want to get the first child of the element Y which is in the binding Z"...
12:39:09 <nhnt11> Hmm, the roomInfo API should use promises too :-/
12:39:15 * nhnt11 no longer approves of callbacks
12:39:54 <sawrubh> clokep_work: I'll send a patch after trying to change-the-IDs suggestion
12:40:06 * sawrubh -> debug-mode
12:40:21 <nhnt11> gtg for a while
12:41:25 <clokep_work> sawrubh: Sorry I can't give a better condition, a bit busy ATM.
12:41:53 --> sonny has joined #instantbird
12:42:55 <Mic> mayanktg: everything in a conversation window (except for the conversation content) is part of the same document.
12:43:40 <Mic> Every tab, every button on every tab, every menu attached to any button anywhere. IDs must be unique. That's why you can't set one for the menu and expect it to work.
12:43:59 <Mic> Because as soon as you open a second tab on a window, the ID no longer is unique!
12:45:09 <aleth> sawrubh: How have you added your cloudfile.xul to jar.mn
12:45:10 <Mic> The solution is here to use a method that can find a node by an attribute (or what else is appropriate) and that makes sure that it can't return a menu from another tab.
12:45:10 <Mic> .
12:45:41 <Mic> That's why you'd want to use a method that starts from a node and searches only the descendants i.e. children of it.
12:46:01 <Mic> getElementsByAttribute does that for example.
12:46:05 <sawrubh> aleth: gimme a sec, sending a beautiful diff instead
12:46:07 <mayanktg> Mic: Ok.
12:46:11 <aleth> I'd suggest using a classname and element.querySelector
12:46:29 <aleth> But really it doesn't matter, Mic is right.
12:46:31 <Mic> aleth: or that, yes.
12:47:08 <Mic> Note how aleth wrote *element* .querySelector and not document.<...>.
12:48:05 <mayanktg> Yes. I read that in MDN https://developer.mozilla.org/en-US/docs/Web/API/Element.querySelector 
12:49:05 <sawrubh> wow, this patch is getting juicy and fat
12:50:52 * clokep_work was hoping it was a separate diff for now. :(
12:50:52 <-- rosonline has quit (Connection reset by peer)
12:55:42 --> chrisccoulson has joined #instantbird
13:02:27 <sawrubh> clokep_work: aleth http://pastebin.instantbird.com/721446 is the diff (this excludes my copying the png's, applications.xul/js as cloudfile.xul/js)
13:02:44 * aleth wonders what's wrong with sawrubh's tab completion
13:03:06 <sawrubh> contents of cloudfile.xul is http://pastebin.instantbird.com/721411
13:03:14 <sawrubh> aleth: what's wrong with it?
13:03:41 <aleth> Oh, you're using irccloud. That explains it
13:03:59 <aleth> Lack of punctuation ;)
13:04:31 <nhnt11> sawrubh: s/foo: bar text/foo, bar: text/ ;)
13:04:53 * nhnt11 has to go again
13:05:10 * sawrubh reports this to the IRCCloud folks
13:05:58 <clokep_work> sawrubh: I don't understand "XXX and this should be in themes.xul. Same issue and workaround..."
13:06:42 <Mic> sawrubh: Instantbird completes like this:
13:06:42 <Mic> "abc: de"<tab> --> "abc, def:" <tab> --> "abc: def"
13:06:55 <aleth> sawrubh: Just use Instantbird ;)
13:07:03 <Mic> So you can easily adress several people OR talk to someone about someone else (last case)
13:07:31 <sawrubh> clokep_work: where do you see that? I don't see it in my diff
13:07:40 <nhnt11> Mic: What? really?
13:07:47 * sawrubh moves to IB!
13:07:49 <nhnt11> Mic: The second tab isn't working for me
13:08:11 <Mic> nhnt11: sorry, it really isn't.
13:08:26 <Mic> You press backspace to do that.
13:08:34 <Mic> Mea culpa.
13:08:36 <nhnt11> Ah, neat
13:08:54 * nhnt11 feels like he's used this before but is impressed anyway
13:09:05 <aleth> sawrubh: What does your cloudfile.xul look like?
13:09:09 <clokep_work> Yeah, aleth likes to add little features there. ;)
13:09:10 <Mic> Great when you used it but never noticed :)
13:09:26 <clokep_work> sawrubh: Not in the diff, in the other thing you posted: http://pastebin.instantbird.com/721411
13:09:26 <Mic> That means it's working perfectly :)
13:09:30 <nhnt11> Yeah :)
13:09:43 <nhnt11> It would be nice if the space didn't get deleted though
13:10:11 <nhnt11> i.e. "abc: de" <tab> "abc, def: " <backspace> "abc: def "
13:10:35 <aleth> File a bug and I'll take a look when I next get a chance to look at my WIP ;)
13:11:13 <clokep_work> Psh, you give them a nice feature and they just want MORE.
13:11:15 <clokep_work> Kids these days...
13:11:17 <sawrubh> aleth, clokep_work: http://pastebin.instantbird.com/721411 is preferences.xul (in im/content/preferences/)
13:11:18 * nhnt11 has no clue how to phrase that for a bug title
13:11:34 <sawrubh> clokep_work: aleth http://pastebin.instantbird.com/721447 is cloudfile.xul
13:11:35 <clokep_work> Mic: Would you mind taking a look at this stuff too for sawrubh?
13:11:37 <Mic> Wasn't there a no-new-features before it is a module policy? :P
13:11:43 * sawrubh kicks IRCCloud a serious kick
13:11:53 <Mic> clokep_work: the XUL stuff?
13:12:02 <clokep_work> sawrubh: L13 still has the ID as ApplicationsPaneOverlay
13:12:10 <clokep_work> I asked you to change that.
13:12:12 <nhnt11> aleth: Some discussion happening on #perf, btw
13:12:25 <clokep_work> Along with the prefPane ID on L16.
13:12:51 <-- mayanktg has quit (Ping timeout)
13:16:25 <Mic> nhnt11: maybe benchmarked opening & closing files?
13:17:24 <sawrubh> clokep_work: yeah, changing the ID fixed it e_e
13:17:24 <clokep_work> Mic: Yeah the XUL stuff, his pane isn't showing up at all...
13:17:28 <clokep_work> Ah. :)
13:17:32 <sawrubh> Mic: nvm :)
13:17:33 <nhnt11> Mic: I don't know if such a benchmark would be realistic for my use case
13:17:39 <clokep_work> clokep: 1, XUL: 0
13:17:43 <nhnt11> Mic: first I need to find the number of incoming messages / second on a busy channel
13:17:57 <clokep_work> nhnt11: Are you estimating writes / file at ~ 3 / sec?
13:17:59 <Mic> sawrubh: :)
13:18:02 <clokep_work> That seems slow.
13:18:09 <sawrubh> clokep_work++
13:18:30 <sawrubh> sawrubh: 0, XUL: 1
13:18:31 <Mic> sawrubh: everything is appearing where it should now?
13:18:32 <nhnt11> clokep_work: I would guess 3 incoming messages per second on an active channel (not overly active, just active)
13:18:43 * nhnt11 knows he hasn't run real tests
13:18:43 --> qheaden has joined #instantbird
13:18:50 <nhnt11> (and therefore my numbers are invalid)
13:18:59 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:19:10 --> mayanktg has joined #instantbird
13:20:31 <clokep_work> Not invalid, just guesses. :-D
13:20:37 --> qheaden has joined #instantbird
13:20:49 <qheaden> Hello.
13:20:50 <clokep_work> A "busy" channel is most likely #ubuntu on freenode.
13:20:55 <nhnt11> yeah
13:21:00 <clokep_work> Or follow stupid things on Twitter like "ok" or "yes"
13:21:07 <clokep_work> qheaden: What's going on!?
13:21:08 <aleth> Heh, that's *really* busy.
13:21:08 <sawrubh> Mic: it's better than before, there are still a few issues (http://i.imgur.com/KLa7tqx.png) but it should be ok
13:21:21 <sawrubh> I know how to proceed (fix *stupid* issues :P )
13:21:21 <qheaden> clokep_work: How's it going?
13:21:29 <qheaden> clokep_work: I'm still fighting with Yahoo group caht.
13:21:30 <qheaden> *chat
13:21:34 <sawrubh> qheaden: o/
13:21:39 <clokep_work> qheaden: Do you need help at all?
13:21:40 <aleth> sawrubh: I'm guessing a lot of this is just finding all the million details...
13:21:45 <qheaden> No I'm good.
13:22:02 <sawrubh> aleth: yeah, I do most of it right and just miss that one detail and BOOM
13:22:15 <qheaden> I just had to do even more packet capture the other day, and I didn't get time to compare my code against the packets.
13:22:21 <qheaden> But I should be doing that soon.
13:24:28 * qheaden has too many development projects open. :-O
13:26:52 --> rosonline has joined #instantbird
13:27:38 <clokep_work> sawrubh: That's why we're here to helpy ou. :)
13:27:57 <clokep_work> qheaden: Alright, well. It'd be pretty awesome to include that by default "soon". ;)
13:29:06 <qheaden> clokep_work: Yeah, I have to finish this group chat up.
13:29:44 <qheaden> I got a really good packet capture the other day, so it should make it easier to debug my code.
13:29:54 <aleth> qheaden: Millions of (TB) users are waiting! :D
13:30:00 <-- mayanktg has quit (Client exited)
13:30:06 * qheaden starts to sweat again
13:30:11 --> mayanktg has joined #instantbird
13:30:29 <aleth> Don't worry, they don't all want to group chat with you.
13:30:45 <qheaden> I'm not sure if this was discussed before, but is there any reason you guys don't publish 64 bit Ib nightlies for Linux?
13:31:06 <qheaden> Some distros are slowly getting rid of ia32-libs, making it harder to get the dependencies for the 32 bit applications.
13:32:05 <clokep_work> qheaden: We're not publishing Linux nightlies at all right now. :-\
13:32:36 <aleth> When we do, there will hopefully be 64b nightlies too, or so I've heard.
13:33:05 <clokep_work> That's the plan. . .
13:33:26 <qheaden> Okay cool.
13:36:25 <clokep_work> qheaden: Besides that it's just "effort".
13:38:51 <Mic> Or, are there OS' that annoy their users with things like word length? That seems so 1992...
13:38:54 <Mic> scnr ;)
13:47:09 --> mpmc has joined #instantbird
13:55:03 <-- sonny has quit (Ping timeout)
13:59:45 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:59:47 --> clokep_work has joined #instantbird
13:59:47 * ChanServ sets mode +o clokep_work 
14:02:39 --> sonny has joined #instantbird
14:08:40 <-- jb has quit (Ping timeout)
14:09:19 <-- Rym has quit (Ping timeout)
14:09:38 --> Rym has joined #instantbird
14:12:27 --> jb has joined #instantbird
14:19:11 <-- nhnt11 has quit (Ping timeout)
14:20:09 --> nhnt11 has joined #instantbird
14:22:48 --> TheOne has joined #instantbird
14:28:06 <-- chrisccoulson has quit (Ping timeout)
14:29:27 <aleth> nhnt11: I probably will only have time to look at your patch late tonight, are you blocked by anything?
14:29:38 <nhnt11> aleth: At the moment, no, I'll be writing tests today :)
14:29:58 <nhnt11> aleth: By the way, I just updated the bug with the discussion with avih on #perf, and the conclusions drawn. For future reference. :)
14:30:02 <aleth> OK great.
14:31:49 <nhnt11> gtg for a while
14:33:40 <clokep_work> :)
14:36:51 <-- nhnt11 has quit (Connection reset by peer)
14:38:28 --> nhnt11 has joined #instantbird
14:49:59 --> chrisccoulson has joined #instantbird
14:58:23 <Mic> mayanktg: nice blog posting :)
14:58:29 <-- chrisccoulson has quit (Ping timeout)
14:58:58 <Mic> Have you solved the getElement-problems?
15:02:10 --> iamjayakumars has joined #instantbird
15:02:33 <mayanktg> No :( Wait let me pastebin
15:04:54 <mayanktg> Mic: http://pastebin.instantbird.com/721539 I'm setting .conv-top-info as the node whose decendent ".alltargets-button" would have to search.
15:05:26 <mayanktg> But I'm getting that ... | toolbarElement is null | 
15:06:14 <mayanktg> It is same for all other ids and classes I ive as argument in the document.querySelector("___")
15:07:10 <Mic> Have you tried if "let targetButton = this.querySelector(".alltargets-button");" works?
15:08:11 <aleth> mayanktg: Mic did tell you explicitly why *not* to use document.querySelector ;)
15:09:25 <mayanktg> Mic: this. ... worked :)
15:09:45 <aleth> Make sure you understand why ;)
15:09:53 <aleth> For the future.
15:10:15 <Mic> Yeah, investigate "this" here.
15:10:43 <Mic> Dump Object.keys(this), this.localName, ... to find out a bit about it.
15:11:07 <mayanktg> Mic: Ok.
15:11:31 <mayanktg> Let me try this out
15:11:45 <-- gerard-majax_ has quit (Ping timeout)
15:12:19 <aleth> And read this if you haven't already https://developer.mozilla.org/en-US/docs/Web/Guide/API/DOM/Locating_DOM_elements_using_selectors
15:12:58 <-- iamjayakumars has quit (Ping timeout)
15:13:38 <mayanktg> aleth: Ok. I read separately about querySelector and querySelectorAll. Giving it a read. :)
15:16:58 <-- aleth has quit (Ping timeout)
15:17:44 <nhnt11> re
15:17:56 * nhnt11 wonders how difficult it would be to change the roomInfo api to use promises
15:18:04 <nhnt11> (and if it would be a good use of time)
15:19:38 <clokep_work> nhnt11: I don't think you should think about that right now.
15:19:44 --> chrisccoulson has joined #instantbird
15:19:58 <nhnt11> clokep_work: Well not right now, I'm curious though
15:20:47 * nhnt11 starts writing tests
15:20:58 <mayanktg> Mic: Thanks :) The property is _toolbox and name is toolbar :)
15:20:59 <clokep_work> nhnt11: Callbacks are simpler. ;)
15:21:01 <mayanktg> bbl
15:22:32 <nhnt11> I guess it would just be moving the callback from doSomething(aCallback) to doSomething().then(aCallback) anyways
15:23:03 <clokep_work> That doesn't seem useful. :(
15:23:21 <nhnt11> yeah
15:23:52 <nhnt11> It avoids passing the callback around I guess
15:23:58 <nhnt11> Anyway. Tests!
15:32:25 <Mic> mayanktg: interesting. The toolbar wasn't what I expected...
15:33:20 <Mic> localName is the name of the tag by the way, i.e. "this" was run from code attached to a "toolbar"-element in this case.
15:34:04 --> iamjayakumars has joined #instantbird
15:36:20 <clokep_work> sawrubh: Have you gotten your XUL stuff working?
15:41:34 <-- sonny has quit (Ping timeout)
15:44:49 <sawrubh> no, I'm getting 'document.getElementById(...) is null' on L881 of http://mxr.mozilla.org/comm-central/source/mail/components/preferences/applications.js#881, which I think is because of some elements missing
15:45:18 <sawrubh> removing the gelElem's but there a lot of XUL elements I've removed from
15:45:26 <sawrubh> cloudfile.xul compared to applications.xul
15:46:35 <clokep_work> sawrubh: Yeah if you remove the elements you have to remove things referencing them...are you just working through issues one by one or are you stuck?
15:47:40 <sawrubh> working through them one by one
15:47:49 <sawrubh> but it's confusing :/
15:48:02 <sawrubh> I'll ask for help in a bit if I'm not able to work out
15:48:07 <clokep_work> OK.
15:48:10 <clokep_work> I'll probably eat lunch soon.
15:48:45 * nhnt11 just tried mayanktg's user icon patch
15:49:01 --> sonny has joined #instantbird
15:49:30 <nhnt11> The panel looks nice :)
15:49:57 <sawrubh> what bums me is that on L881 there is no getElemByID but that might be just because the error is bubbling up from some other place
15:50:25 <clokep_work> sawrubh: Well didn't you modify that file?
15:50:34 <clokep_work> Are you sure you're looking at the "right" L881?
15:50:39 <Mic> sawrubh: I'll be around if you have questions.
15:52:40 <sawrubh> clokep_work: L881 of the file online (MXR), it's equivalent on my local file is where the error is being shown
15:52:53 <clokep_work> OK. . .
15:54:26 <-- iamjayakumars has quit (Client exited)
15:54:28 <nhnt11> mayanktg: I have no idea how it happened, but the panel is not displaying properly any more: http://puu.sh/96iVa/b6f8e437f1.png
15:55:14 <nhnt11> Ah. It gets messed up when I drag the window from my external screen to my laptop screen
15:55:23 <nhnt11> Maybe retina resolution issues... guess you shouldn't worry about it at this point
15:55:46 --> iamjayakumars has joined #instantbird
15:57:19 <sawrubh> http://www.diffchecker.com/yevzw9n5 is the diff (what I've removed/added from applications.xul) (for future reference)
15:59:09 <sawrubh> I see a way!
15:59:15 * sawrubh tries something real quick
16:10:26 <-- Rym has quit (Ping timeout)
16:12:25 <mayanktg> nhnt11: Ehh :-/
16:13:05 <mayanktg> That's horrible. You mean in the external screen it displayed correctly?
16:13:38 <nhnt11> mayanktg: It displayed correctly on both initially, it got borked when I moved it from the external screen to the retina display
16:14:29 <nhnt11> Well, "correct". The margins are a bit off, but that's not your fault :)
16:14:52 <mayanktg> nhnt11: Ok. I don't have a retina screen to try this on. Any idea what might have happened? 
16:15:49 <nhnt11> Nope. Haven't looked at any code.
16:16:12 --> Rym has joined #instantbird
16:16:12 <nhnt11> I don't think it's important to debug retina screen issues now? Feel free to ping me to test things though :)
16:16:17 * nhnt11 thinks clokep_work has a retina screen too
16:16:31 <mayanktg> nhnt11: ok. np :)
16:18:28 <-- iamjayakumars has quit (Ping timeout)
16:18:28 <-- clokep_work has quit (Ping timeout)
16:18:57 --> clokep_work has joined #instantbird
16:18:58 * ChanServ sets mode +o clokep_work 
16:19:34 <nhnt11> mayanktg: I'm also seeing TypeError: navigator.mozGetUserMedia is not a function btw
16:20:07 <clokep_work> nhnt11: Did you rebuild with the right flags?
16:20:38 <nhnt11> no
16:20:50 * nhnt11 doesn't know what htese flags are
16:20:52 <-- sonny has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:20:55 <Mic> clokep_work: would getUserMedia have worked otherwise?
16:21:20 <mayanktg> Mic: No
16:21:35 <Mic> hmm, OK. I'm kind of assuming that nhnt11s image was taken with the new feature.
16:21:39 <Mic> That might not be the case.
16:21:44 <nhnt11> Mic: It wasn't.
16:21:49 <nhnt11> It was already set
16:23:11 <clokep_work> nhnt11: https://bugzilla.mozilla.org/attachment.cgi?id=8429034&action=diff#a/im/confvars.sh_sec2
16:23:30 <-- nhnt11 has quit (Ping timeout)
16:23:36 <mayanktg> we have to include moz_media_naivator to include the WebRTC features. I had this problem and flo told to perform the change and rebuild :)
16:23:59 <sawrubh> yay, it works more! I understood what the error!
16:23:59 --> gerard-majax_ has joined #instantbird
16:24:14 * sawrubh -> closer to coming out debug-mode
16:24:21 <clokep_work> sawrubh: What was the issue?
16:24:30 --> nhnt11 has joined #instantbird
16:25:17 <sawrubh> I wasn't removing the getElemByID's systematically, trying to explain to you what I was having issues with just made it clear how I should go about it :)
16:25:20 * nhnt11 wonders why he didn't receive a ping for http://log.bezut.info/instantbird/today/#m586
16:25:42 <sawrubh> and the green and red thingy on diffchecker
16:26:12 <nhnt11> mayanktg, clokep_work: So isn't the flag set by the pathc already?
16:26:27 <clokep_work> nhnt11: "pathc"?
16:26:29 <nhnt11> patch*
16:26:57 <mayanktg> the flag must have been changed by applying the patch, but you have to perform complete build for it.
16:26:58 <clokep_work> nhnt11: You need to do mach configure and rebuild.
16:27:04 <nhnt11> oh okay
16:30:15 <-- chrisccoulson has quit (Ping timeout)
16:32:39 <-- nhnt11 has quit (Ping timeout)
16:34:08 --> nhnt11 has joined #instantbird
16:36:45 <mayanktg> Mic: The method "allowTargetChange" was called twice: one along with the constructor and also when we had more than one buddy for the conversation. This was causing names to appear multiple times in the menulist.
16:37:28 <Mic> This was a regression?
16:37:35 <nhnt11> Bah, "Error: App:BuildID not specified in application.ini"
16:37:40 <nhnt11> Maybe I need to clobber
16:37:49 <Mic> Well, it must be as I haven't seen it before.
16:38:17 <-- gerard-majax_ has quit (Ping timeout)
16:39:04 * nhnt11 pops mayanktg's patch for now. Need a working build to test my own stuff ;)
16:39:12 <Mic> mayanktg: how did you fix it?
16:39:39 <mayanktg> Mic: I removed the method call from the constructor 
16:40:31 <mayanktg> Mic: Because allowTargetChange() is called anyways when we start conversation with grouped contact. 
16:43:39 --> myk has joined #instantbird
16:45:20 <-- myk has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:50:57 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:56:03 --> Mook_as has joined #instantbird
16:58:41 <-- mayanktg has quit (Client exited)
16:58:59 --> mayanktg has joined #instantbird
17:01:24 <-- nhnt11 has quit (Ping timeout)
17:01:41 --> CaptainCalliope has joined #instantbird
17:04:07 --> nhnt11 has joined #instantbird
17:11:05 <-- clokep_work has left #instantbird ()
17:11:07 --> clokep_work has joined #instantbird
17:11:08 * ChanServ sets mode +o clokep_work 
17:11:39 <Mic> bbl
17:11:56 <clokep_work> :-S
17:12:03 <clokep_work> Did my topic patch break being able to set topics?
17:21:16 --> sonny has joined #instantbird
17:24:02 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
17:39:48 <mayanktg> Mic: What else should be included in the patch? I have added a class for setting up default style for the buttons. Whenever you are free take a look at the patch I'm posting in BMO. 
17:40:56 <clokep_work> mayanktg: What's in the patch now?
17:42:20 <mayanktg> clokep_work: currently the patch has, children/ element defined in the bindings, target switcher definition, a default style for the buttons which are to be included soon.
17:45:50 * qheaden goes to class
17:45:56 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:49:01 <clokep_work> mayanktg: Remember always a space to start comments, and full sentences (Start with a capital letter and end in a ., this applies for the entire full.)
17:49:32 <mayanktg> Ah sorry :-(
17:50:32 <clokep_work> Not a problem.
17:50:39 <clokep_work> If we have to keep telling you...we'll get annoyed. :P
17:51:05 <mayanktg> clokep_work: Already I was pointed out once :'(
17:52:01 <clokep_work> mayanktg: How come you couldn't just leave the XUL there below the <children/> element?
17:53:43 <-- clokep_work has quit (Ping timeout)
17:53:54 --> clokep_work has joined #instantbird
17:53:54 * ChanServ sets mode +o clokep_work 
17:53:56 <mayanktg> clokep_work: I had to include a border-bottom below the toolbarbuttons. since <description/> used a flex and then added a border-bottom, I had to include a hbox to add one.
17:56:30 <clokep_work> mayanktg: ...
17:56:34 <clokep_work> I don't understand.
17:59:24 <mayanktg> clokep_work: "displayName" has flex="1"..and in CSS displayName has border-bottom set http://mxr.mozilla.org/comm-central/source/im/themes/conversation.css#157 . 
17:59:55 <clokep_work> mayanktg: OK, but what does that have to do with hard coded in it XUL instead of JS?
18:02:35 <mayanktg> clokep_work: oh. We tried that earlier. But Mic said we have to hard code it in JS. 
18:02:43 <mayanktg> Also ...
18:02:53 <clokep_work> Hmm...I don't believe that. :)
18:06:39 <mayanktg> clokep_work: Here's the diff for what idea Mic had about http://pastebin.instantbird.com/719357 . Also children element cannot borrow anonymous element.
18:08:26 <clokep_work> mayanktg: That doesn't look related to my idea.
18:09:10 <clokep_work> mayanktg: Or I'm not understand your sentence. That's Mic's idea for what? What does "children borrowing anonymous elements" mean?
18:09:47 <Mic> re
18:09:58 <Mic> So, what's up? :)
18:10:01 <mayanktg> clokep_work: You mean to say I should just leave the XUL code there as it is? Sorry I'm not getting it
18:10:38 <clokep_work> mayanktg: I was asking why you didn't, it looks to me like it would be significantly cleaner.
18:13:10 <Mic> clokeP's suggestion makes sense.
18:13:21 <mayanktg> clokep_work: Ok. I'll add it them there. Got your point :) I thought it would be cleaner to have all the definition for the button at one place 
18:13:48 <mayanktg> Mic: Ok :) Its a better idea.
18:13:52 <Mic> Wait ...
18:13:59 <-- sonny has quit (Ping timeout)
18:14:13 <Mic> No, it doesn't.
18:14:36 <Mic> You have more than one place where you're using the children element.
18:14:55 <mayanktg> yes. conv-info-small|large
18:15:26 <Mic> I need to look it up but I'm pretty sure the place with the comment is in conv-info-*, isn#t it?
18:15:38 <Mic> Yes, it's in conv-info-large.
18:15:47 <clokep_work> Mic: I only added the comment in one place.
18:15:51 <clokep_work> The switching is in both though.
18:15:55 <clokep_work> switcher
18:16:32 <-- Rym has quit (Ping timeout)
18:17:02 --> Rym has joined #instantbird
18:17:09 <Mic> Isn't the diff missing things?
18:17:26 <Mic> Isn't there anything that needs to be removed?
18:17:34 <-- Rym has quit (Quit: WeeChat 0.4.3)
18:17:44 --> Rym has joined #instantbird
18:17:52 <Mic> (i.e. the old menu, ...)
18:18:53 <mayanktg> Mic: Old menu?
18:19:06 <Mic> The target switcher popup.
18:19:58 <mayanktg> wait..let me see.
18:24:55 <Mic> https://mxr.mozilla.org/comm-central/source/im/content/conversation.xml#1998
18:25:10 <Mic> https://mxr.mozilla.org/comm-central/source/im/content/conversation.xml#2236
18:25:32 <mayanktg> I have removed those elements from the diff. haven't I?
18:28:19 <mayanktg> Mic: I have removed the menu from these places and have defined using JS in the initConversationUI method.
18:44:55 <Mic> Yeah, there it is. Sorry for the confusion.
18:45:39 <-- mayanktg has quit (Ping timeout)
18:45:50 <clokep_work> mayanktg, Mic: Does it make sense what I'm suggesting though?
18:45:59 --> mayanktg has joined #instantbird
18:46:44 <Mic> We'd need to add the button and the menu in two places (if we don't find another place for the menu at least).
18:46:46 --> gerard-majax_ has joined #instantbird
18:46:47 <mayanktg> clokep_work: We'd have to add the XUL code at two places each
18:49:44 <mayanktg> Mic: Yes. I guess this is what we meant by 'a generic way'. A person should have a common place where he could add all the buttons.
18:51:14 <mayanktg> clokep_work: Sorry I wasn't able to clear that earlier :-/
18:53:52 <clokep_work> Mic, mayanktg: But we have to do that now anyway, right?
19:03:01 <mayanktg> clokep_work: idk much. But if we are keeping the XUL code for the target switcher, then what's the point of using the children element. We should implement target-switcher like we'd set other icons.
19:03:45 <clokep_work> mayanktg: But...it looks like you're just hard coded ita ll as JS anyway, it's simpler to hard code it as XUL, honestly.
19:04:04 <clokep_work> I don't really understand why we have a children element there instead of just having the four buttons or whatever and showing/hiding/disabling them.
19:05:46 <-- TheOne has left #instantbird ()
19:06:52 <mayanktg> clokep_work: Indeed it is. But in my opinion why should we repeat the same XUL code at two different places.
19:07:33 <clokep_work> mayanktg: Isn't that what templates is for? :P
19:07:40 <clokep_work> mayanktg: How are you not repeating the JS code anyway?
19:08:39 <mayanktg> clokep_work: Yeah! The JS code is getting repeated.
19:08:49 <clokep_work> Soooooooo how is that better? :-S
19:13:31 <mayanktg> clokep_work: The idea was that we'll have all the definition and functions related to the button in one place so that we don't have to define it at different locations in the file. I'd suggest Mic would have a better opinion than I have. :-|
19:14:53 <clokep_work> But...if the JS code is getting repeated, that's not one place?
19:15:49 <mayanktg> Yes. But we are defining the JS code only in |initConversationUI| method.
19:16:25 --> mpmc has joined #instantbird
19:16:59 <mayanktg> we'll have to _write_ the XUL code both at "conv-info-large" and "conv-info-small"
19:21:00 <Mic> We can either create a button in JS in one place (to be honest I don't understand what you mean by "being repeated") or twice if we create it in XUL/XBL.
19:21:50 <Mic> hmm, what about that?
19:22:17 --> sukhe has joined #instantbird
19:22:18 <Mic> ...
19:22:26 <clokep_work> Maybe I'm just onfused at what mayanktg means by repeated then.
19:22:47 <Mic> We could write it as default children of the toolbar... so we have it nicely written.
19:23:13 <Mic> And then only copy these nodes into the toolbar again.
19:23:24 <Mic> Might that work?
19:24:04 <Mic> Nor sure if something's going to clash then. May we'd need to find another place to host the definition of the buttons then.
19:24:31 <Mic> Anyways, I need to go again. I'll be back in about 40 minutes.
19:28:53 <clokep_work> qheaden: https://developer.pidgin.im/ticket/15906
19:35:28 --> sonny has joined #instantbird
19:42:50 <-- mayanktg has quit (Ping timeout)
19:43:10 --> mayanktg has joined #instantbird
19:50:57 <-- gerard-majax_ has quit (Ping timeout)
19:50:58 --> myk has joined #instantbird
19:52:04 <myk> hello, instantbirders! i'm experiencing a regression in today's nightly builds: when i /join #achannel, the Participants pane is missing, and the channel looks wonky in other ways (f.e. the text field is smaller); known bug?
19:56:37 <Mic> Hello myk!
19:57:16 <myk> hello, Mic!
19:57:49 <Mic> clokep_work: is our buildbot waterfall reliable?
19:57:56 <clokep_work> Mic: Yes, absolutely.
19:58:02 <clokep_work> myk: I assume you're on Mac. :)
19:58:09 <Mic> Looks like the latest nightly build was the one for MacOS, yesterday and that there haven't been any checkins in days.
19:58:10 * myk is on a Mac, yes
19:58:33 <clokep_work> Mic:  I made a check-in yesterday.
19:58:51 <Mic> There's nothing in the changes column :(
19:58:54 <clokep_work> Two days ago: https://hg.mozilla.org/comm-central/rev/a9c18429042c
19:59:23 <clokep_work> myk: I haven't seen this issue, it's possible a m-c change broke us, let me see if my client is up to date.
19:59:32 --> nhnt12 has joined #instantbird
19:59:49 <nhnt12> myk: I just updated my nightly, on Mac
19:59:54 <nhnt12> I don't see any issues
19:59:57 <-- sonny has quit (Ping timeout)
20:00:10 <-- nhnt11 has quit (Ping timeout)
20:00:14 <myk> clokep_work: in the meantime, i'll quit this 1.5 stable release and restart nightly to make sure i can reproduce
20:00:15 <-- myk has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
20:00:32 <nhnt12> myk: You're right
20:00:34 <nhnt12> missed him
20:00:41 <nhnt12> Indeed /join #channel gives me a blank tab
20:00:52 <nhnt12> http://puu.sh/96BdL/1151fa0d4e.png
20:00:56 --> myk has joined #instantbird
20:00:58 <myk> i can reproduce!
20:01:01 * nhnt12 sees tabbrowser errors
20:01:04 <nhnt12> myk: me too
20:01:46 <myk> i can reproduce! in fact i just did /join #instantbird, and now i'm in a tab that has a dotted-square border in place of the IRC icon, no title, and no Participants pane
20:01:48 <nhnt12> clokep_work: this._modes is null
20:02:05 <nhnt12> looks like a regression from the changeset you jsut linked
20:02:14 <myk> plus i see no chat messages; not my own, not other peoples'; so i don't know if y'all are getting my messages
20:02:29 <clokep_work> nhnt12: It does...hm...why are my auto-join rooms working fine then?
20:02:38 <nhnt12> My auto-joins are working too
20:02:50 --> mr_sticky has joined #instantbird
20:03:01 <myk> i do see leave/join messages, though
20:03:02 <clokep_work> nhnt12: Stack trace?
20:03:17 <mr_sticky> ooh, and i see my messages over here in this mibbit view!
20:03:29 * mr_sticky is myk, in case it isn't now obvious
20:03:46 <clokep_work> mr_sticky: Yeah, looks like I broke something.
20:04:58 <mr_sticky> clokep_work: any info you need from me (f.e. error console messages), or can you reproduce?
20:05:29 <clokep_work> mr_sticky: I can reproduce.
20:05:54 <nhnt12> clokep_work: Still need that stack trace? (since you can reproduce..)
20:06:00 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:06:05 --> clokep_work has joined #instantbird
20:06:05 * ChanServ sets mode +o clokep_work 
20:06:17 <mr_sticky> cool; i'll switch back to the stable build for now
20:06:22 <-- CaptainCalliope has quit (Quit: CaptainCalliope)
20:06:24 <clokep_work> nhnt12: If you know how to actually get a stack trace instead of just the line. ;)
20:06:37 * clokep_work wishes he had the debugger set up
20:06:43 <-- myk has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:07:35 --> myk has joined #instantbird
20:07:42 <-- mr_sticky has quit (Quit: http://www.mibbit.com ajax IRC Client)
20:08:30 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:10:13 <nhnt12> clokep_work: dump Error.stack?
20:10:22 <nhnt12> I don't have the debugger set up
20:11:26 <clokep_work> nhnt12: That's what I've done.
20:11:30 <nhnt12> clokep_work: I think this line wants to be if (this.left)? https://hg.mozilla.org/comm-central/rev/a9c18429042c#l1.71
20:11:55 <clokep_work> nhnt12: Likely. :(
20:12:03 <clokep_work> You should have been my reviewer. :P
20:12:12 <clokep_work> The comment is even right. :(
20:12:53 <nhnt12> clokep_work: I'll test it out and attach a patch
20:13:15 * nhnt12 is now known as nhnt11
20:14:00 <clokep_work> nhnt11: Testing already.
20:14:09 <nhnt11> alright
20:16:24 <clokep_work> nhnt11: So the call to _init ends up generating the UI conversation, which calls topic settable.
20:16:38 <clokep_work> But for some reason left is false already? :-S
20:18:12 <clokep_work> BAH!
20:18:13 <nhnt11> :S
20:18:16 <clokep_work> I messed up removing the one character. :-[
20:18:31 <-- Rym has quit (Ping timeout)
20:18:33 <nhnt11> uh
20:20:12 <clokep_work> nhnt11: Can you make that patch so I can r+ it? ;)
20:20:23 <clokep_work> Since I can't make the patch and then give you approval, that doesn't make sense.
20:20:28 <clokep_work> Or I guess Mic can rs it.
20:20:37 <clokep_work> Just attach it to the same bug.
20:20:38 <clokep_work> Thanks myk.
20:20:41 * nhnt11 is okay with whatever clokep_work wants to do
20:20:42 <myk> clokep_work: cheers!
20:20:47 <myk> dogfooding works!
20:20:57 * myk chows down
20:20:59 --> EionRobb has joined #instantbird
20:21:35 <clokep_work> nhnt11: Just attach a patch. :P
20:22:22 <nhnt11> clokep_work: What should the patch title be for a bustage fix?
20:22:35 <nhnt11> Bug foo - bug title - bustage-fix, r=clokep?
20:22:47 <clokep_work> nhnt11: "Bug 1012666 - Fix up checking if IRC topics are settable: fix typo causing bustage. r=clokep"
20:23:03 <nhnt11> ok
20:24:18 <instantbot> nhnt11@gmail.com changed the Resolution on bug 1012666 from FIXED to ---.
20:24:20 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1012666 nor, --, 1.6, nhnt11, REOP, Fix up checking if IRC topics are settable
20:24:33 <nhnt11> ^ not sure if I wasn't supposed to reopen it btw
20:24:35 <clokep_work> nhnt11: Yeah I'm going to reclose that in like two seconds. :P
20:24:43 <nhnt11> ok ok
20:25:14 <clokep_work> nhnt11: Btw autojoins probably work because we join BEFORE the UI is created.
20:25:35 <nhnt11> Yeah. so topicSettable is never called before _modes is set
20:26:06 <clokep_work> Exactly.
20:27:16 <-- mayanktg has quit (Ping timeout)
20:27:56 <clokep_work> Now I wonder why our build is failing. :-S
20:28:09 --> mayanktg has joined #instantbird
20:28:29 --> mconley has joined #instantbird
20:29:16 <nhnt11> What?
20:30:17 <clokep_work> Ah, RattyAway fixed it already.
20:30:18 <clokep_work> :)
20:30:47 <nhnt11> clokep_work: How do I view statuses of builds?
20:30:57 <clokep_work> buildbot.instantbird.org/waterfall
20:31:01 <nhnt11> oh that
20:33:01 <clokep_work> Yes.
20:33:04 <clokep_work> IT's fairly dismal ATM. :(
20:34:13 <nhnt11> clokep_work: Where can I read up on what "oranges" and "stars" are?
20:34:21 <instantbot> clokep@gmail.com changed the Resolution on bug 1012666 from --- to FIXED.
20:34:22 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1012666 nor, --, 1.6, nhnt11, RESO FIXED, Fix up checking if IRC topics are settable
20:34:32 <clokep_work> nhnt11: I don't really know. :-\
20:34:49 <clokep_work> nhnt11: "oranges" are things that are failing tests.
20:35:09 <clokep_work> "starring an orange" means ensuring the bug is filed and that it has knowledge of that build failure on tbpl.
20:35:26 <nhnt11> hmm okay, thanks.
20:37:24 <nhnt11> clokep_work: So how come you can push to a closed tree?
20:37:35 <clokep_work> nhnt11: Because I put CLOSED TREE in the commit message. ;)
20:37:41 <nhnt11> If you want me to google just say so, I figured asking you would be a shortcut
20:37:56 <clokep_work> nhnt11: Look at the commit message I actually used: https://hg.mozilla.org/comm-central/rev/16295350aca3
20:38:03 <nhnt11> So "closed tree" is kinda just a label and doesn't actually prevent you from pushing?
20:38:03 <clokep_work> "a=DONTBUILD chat-only regression fix on CLOSED TREE "
20:38:05 <nhnt11> I saw the commit message
20:38:12 <clokep_work> It does prevent you...unless you put CLOSED TREE.
20:38:21 <clokep_work> And if you do that and you're not supposed to...they'll revoke your commit rights.
20:38:44 <nhnt11> Basically it makes sure you know you're pushing to a closed tree?
20:39:51 <clokep_work> Yes.
20:40:25 * nhnt11 needs to create an alias for $hg qdelete $(hg qnext)
20:41:18 <clokep_work> Why?
20:41:27 <clokep_work> Oh you mean delete the next patch?
20:41:33 <nhnt11> yes
20:41:42 * clokep_work finds his qexport alias useful. ;)
20:42:01 <clokep_work> |qexport = !hg qapplied | xargs -I@ hg export @ -o @.diff|
20:42:12 <clokep_work> Exports each applied patch as a separate diff file.
20:42:26 <nhnt11> Excellent 
20:42:27 <nhnt11> thanks
20:42:28 <clokep_work> Useful when I was doing the huge sets of patches.
20:42:33 <nhnt11> I have one to export the current applied patch
20:43:05 --> sonny has joined #instantbird
20:43:17 <clokep_work> nhnt11: hg export does that, no need for an alias.
20:43:27 <nhnt11> clokep_work: `hg export qtip > ~/Desktop/$(hg qtop)`
20:43:59 <nhnt11> crude automation to get me a patch file to attach..
20:44:26 <clokep_work> Oh, OK. You mean you had one that automatically saved it to a file. :)
20:44:28 <clokep_work> Got it.
20:44:48 <nhnt11> yeah
20:44:54 <clokep_work> Makes sense.
20:45:03 <clokep_work> I should actually start using bzexport or whatever.
20:45:07 <clokep_work> I've been using qimportbz. :)
20:45:26 * nhnt11 very rarely imports patches from bugzilla
20:45:48 <clokep_work> We should make you review more. ;)
20:45:55 <nhnt11> I want to use bzexport, but I feel like I'll never be able to trust that it would work perfectly
20:45:56 <nhnt11> heh
20:48:38 <clokep_work> :)
20:54:48 <-- mconley has quit (Connection timed out)
20:55:17 --> mconley has joined #instantbird
20:55:27 <-- mconley has quit (Input/output error)
20:55:55 --> mconley has joined #instantbird
20:56:09 <-- sonny has quit (Ping timeout)
20:57:19 <nhnt11> Ah, just saw Florian's comment "Are we in trouble if the conversation is closed before we are done creating the account folder asynchronously?"
20:57:23 * nhnt11 wonders how he missed that
20:57:24 <nhnt11> interesting...
20:57:41 <-- mconley has quit (Ping timeout)
21:00:54 <clokep_work> Are we? :P
21:01:51 <nhnt11> Not sure yet
21:02:41 * nhnt11 is a bit sleepy and will think about it later.
21:04:06 <nhnt11> clokep_work: xpcshell tests are given a special temporary profile directory when they run right?
21:04:53 <clokep_work> nhnt11: No idea.
21:07:34 <-- mayanktg has quit (Ping timeout)
21:08:53 --> mayanktg has joined #instantbird
21:13:45 <nhnt11> clokep_work: Judging by "TEST-INFO | profile dir is /var/folders/qy/gcvmcl597qx06kfmn2hk6xmw0000gn/T/xpcshell/xpcshellprofile" I'd say they are.
21:16:27 <nhnt11> :S
21:16:40 <nhnt11> test_logger.js isn't getting copied to the objdir when I build
21:17:10 * nhnt11 copied it manually :]
21:17:29 <clokep_work> Did you add it to the xpcshell manifest thin?
21:17:37 <nhnt11> yes
21:17:45 <nhnt11> It was working at some point
21:18:55 <nhnt11> clokep_work: So in run_test(), I have do_print(stuff); immediately followed by do_throw("fail");
21:19:05 <nhnt11> The test fails as expected, but I can't see the stuff that's printed
21:19:24 <clokep_work> It might be way up in the stack.
21:19:29 <clokep_work> Lots of gunk.
21:19:58 <nhnt11> Nah
21:20:04 <nhnt11> https://pastebin.mozilla.org/5284973
21:22:51 <nhnt11> Hmm, it's failing even if I comment those two lines out
21:23:00 <nhnt11> maybe I should be running it "properly"
21:27:03 * clokep_work shrugs.
21:27:51 * nhnt11 wonders what's wrong
21:29:07 <nhnt11> It fails even if I comment out the whole run_test() function
21:29:43 <nhnt11> Aaah
21:29:45 <nhnt11> :]
21:29:53 * nhnt11 had a bad import
21:30:04 <nhnt11> Wow, why didn't it say something :S
21:34:12 <nhnt11> Hmm, OS.Constants.Path.profileDir is undefined for an xpcshell tests
21:34:15 <nhnt11> test*
21:42:57 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:48:59 <-- clokep_work has quit (Ping timeout)
22:01:52 --> nhnt12 has joined #instantbird
22:02:39 <-- nhnt11 has quit (Ping timeout)
22:04:56 <Mic> nhnt12: bug 810543
22:04:59 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=810543 maj, --, mozilla20, dteller, RESO FIXED, OS.Constants.Path.profileDir not available in xpcshell tests
22:08:58 --> mayanktg-ph has joined #instantbird
22:10:13 * sawrubh is stuck with hopefully these last errors : http://pastebin.instantbird.com/721889
22:10:27 <sawrubh> http://i.imgur.com/gFKOTRD.png is how the pref pane looks now
22:10:51 <sawrubh> Mic: any idea about that 'Components.classes['@mozilla.org/messenger;1'] is undefined' error?
22:13:39 --> AndroUser2 has joined #instantbird
22:13:42 <Mic> "messenger" is TB related as far as I know. I can't remember having seen that contract ID in Instantbird before.
22:13:44 --> xangua has joined #instantbird
22:13:58 <-- AndroUser2 has left #instantbird (Quit message)
22:14:07 <Mic> Oh, cool. The screenshot looks very promising already.
22:14:18 <-- mayanktg-ph has left #instantbird (Quit message)
22:14:53 --> mayanktg has joined #instantbird
22:15:11 <Mic> https://mxr.mozilla.org/comm-central/search?string=openLinkExternally&find=/
22:15:34 <mayanktg> sawrubh++ for the pref pane.
22:16:05 <Mic> I suspect we have something similar somewhere? Or you can just inline it if it's used just once?
22:16:41 <sawrubh> also I've copied applications.properties as cloudfile.properties, to where other preferences related dtd's are located (im/locale/...), added it to the jar.mn so it should be accesible by the chrome:// url
22:17:08 <sawrubh> also added it to http://mxr.mozilla.org/comm-central/source/mail/components/preferences/applications.js#525
22:17:14 <Mic> I'd try to mxr for "nsIExternalProtocolService" restricted to /im/ ...
22:17:45 <sawrubh> my clone obviously (cloudfile.js) but still I'm getting that formatString error
22:18:18 <sawrubh> it's happening because it's not able to find cloudfile.properties but I can't understand why, because of that the remove button isn't working :/
22:18:51 <Mic> Can you show me the file that it is failing in?
22:18:52 <mayanktg> Mic: Should we keep up with the JS code or go with XUL for the toolbarbutton?
22:19:27 <sawrubh> Mic: one sec
22:20:53 <Mic> mayanktg: duplicating the button feels wrong.
22:21:14 <Mic> Let me find something on today's log.
22:22:01 <Mic> clokep's objection to the JS code was apparently because you said something about things "being repeated".
22:22:03 <Mic> http://log.bezut.info/instantbird/today#m721
22:22:08 <sawrubh> Mic: so http://mxr.mozilla.org/comm-central/source/mail/locales/en-US/chrome/messenger/preferences/applications.properties#7 is where dialog_removeAccount is defined and 'dialog_removeAccount' is what is needed in the functional called when you click remove on a provider
22:22:08 <sawrubh> (http://mxr.mozilla.org/comm-central/source/mail/components/preferences/applications.js#802) and that's what's failing
22:22:08 <Mic> What did you mean by that?
22:23:02 <sawrubh> Mic: that is failing (I suppose) because it's not able to find the .properties file and hence dialog_removeAccount
22:23:10 <mayanktg> Mic: I meant that the JS code would be called as many times we have a new toolbarbutton. :-|
22:23:18 <Mic> Have you change the _string getter?
22:23:22 <Mic> *changed
22:23:33 <mayanktg> Mic: I messed things up :-/
22:23:46 <Mic> That was directed at sawrubh by the way.
22:24:32 <Mic> mayanktg: I don't see a problem here by the way.
22:24:43 <Mic> The button creation code looked good from what I remember.
22:24:46 <sawrubh> Mic: yes, http://pastebin.instantbird.com/721900 is how my _strings getter looks like
22:24:58 <sawrubh> it doesn't add up, it should work :/
22:25:11 <Mic> Can you open "chrome://instantbird/locale/preferences/cloudfile.properties" in DOMi, please?
22:25:25 <mayanktg> Mic: Ok.
22:25:32 <sawrubh> Mic: what's DOMi?
22:25:38 <Mic> DOM Inspector.
22:25:58 <sawrubh> I mean how do I use the DOM inspector, is it like the browser devtools?
22:26:18 <Mic> Do you have a debug build at the moment?
22:26:39 * sawrubh checks if he set anything in the mozconfig
22:26:50 <mayanktg> sawrubh: I installed an addon for the DOMi https://addons.instantbird.org/en-US/instantbird/addon/210
22:27:50 <sawrubh> Mic: I've turned on debug builds now. Should I install ^^ addon ?
22:28:27 <Mic> No, please run the following on the error console:
22:28:34 <Mic> openDialog(""chrome://instantbird/locale/preferences/cloudfile.properties");
22:28:57 <Mic> And remove the double quote at the beginning of the argument, please :(
22:29:05 <Mic> openDialog("chrome://instantbird/locale/preferences/cloudfile.properties");
22:30:08 <sawrubh> a window opens with the contents of cloudfile.properties
22:30:25 <Mic> OK, that's great.
22:30:34 <sawrubh> (and btw this works on non-debug builds too)
22:30:54 * sawrubh cheated and tried it on a non-debug build
22:31:19 <Mic> Sure, that's why I told you :)
22:31:31 <Mic> I wouldn't want to wait for a debug build to finish ;)
22:32:25 <sawrubh> ok, so the properties file is accesible, lemme try printing things and doing getElemenByID or something
22:32:40 <sawrubh> to probably figure out why formatString is failing
22:33:36 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:33:56 --> mayanktg-ph has joined #instantbird
22:34:29 <sawrubh> gah, I'm afraid I might not be able to turn up a patch for clokep again today 😢
22:34:33 <nhnt12> re
22:34:40 <Mic> sawrubh: wait.
22:34:43 <sawrubh> I still have to add that notificationbox thingy
22:35:06 <Mic> Before you start a new build, you might either want to set a new objdir or revert the change to do a debug build.
22:35:33 <Mic> If you've got a non-debug build and start a debug one, you'll have to do a full build afaik.
22:35:34 <nhnt12> Mic: thanks for the link. That bug has been resolved :S
22:35:45 <Mic> Have you seen comment 1 or 2?
22:36:09 <nhnt12> Just did
22:36:19 <nhnt12> Cool
22:36:28 <Mic> Did that help? I haven't read much more than that of this bug to be honest.
22:36:58 <nhnt12> Trying it. should fix the issue.
22:38:09 <nhnt12> Mic: It works. thanks.
22:38:31 <Mic> Nice!
22:40:01 * nhnt12 is now known as nhnt11
22:41:19 --> sonny has joined #instantbird
23:05:22 <nhnt11> Mic: So I'm thinking we don't actually need tests for functions like getLogFolderPathForAccount and getLogFilePathForConversation and so on
23:05:30 <nhnt11> and rather only tests for functions that are exposed for consumers
23:05:39 <-- myk has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
23:07:31 --> wnayes has joined #instantbird
23:12:53 <Mic> nhnt11: you better discuss that with clokep in my opinion.
23:12:58 <nhnt11> Okay
23:13:34 <Mic> Is there anything that could break if someone has an unexpected name for his account or the name of a contact?
23:15:01 <Mic> The names are sanitized somewhere, maybe that's test-worthy?
23:15:06 <nhnt11> Don't think so
23:15:16 <nhnt11> The names are sanitized in the stuff that handles conversations/accounts/whatever
23:15:29 <nhnt11> logger.js expects sanitized names (it uses normalizedName everywhere)
23:15:38 <Mic> OK.
23:16:26 * nhnt11 is writing a full logging test (log a few messages, use the logger api to obtain a log conversation, compare, make sure everything is ok)
23:27:26 <Mic> sawrubh: you know to write Rust? I saw you contributed to Servo?
23:28:09 <Mic> Good night!
23:28:38 <nhnt11> nn
23:31:41 --> clokep has joined #instantbird
23:31:41 * ChanServ sets mode +o clokep 
23:34:31 <clokep> sawrubh: I think it'd be good to have a WIP up without the notification box.
23:35:06 <clokep> nhnt11: Testing just external APIs is good, testing internal APIs is better. :)
23:35:26 <nhnt11> clokep: Okay.
23:35:35 <clokep> Should be trivial to test.
23:35:41 <nhnt11> I've already written the tests
23:39:51 <-- jb has quit (Connection reset by peer)
23:40:04 --> jb has joined #instantbird
23:41:48 <clokep> :)
23:41:53 <clokep> Almost done w/ tests?
23:41:57 * clokep is excited to see some code land.
23:42:40 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
23:42:44 <nhnt11> clokep: Slow progress :(
23:43:01 <nhnt11> I'm nearly done writing a test to write messages, read them, and compare them to the ones used to write
23:43:09 <nhnt11> bah, pretend that made sense
23:43:35 <nhnt11> But we want tests for each of these getLogsFor* functions (* = Account, Contact, etc)
23:43:37 --> Rym has joined #instantbird
23:43:45 <clokep> Alright.
23:43:54 <clokep> :)
23:47:17 <nhnt11> Unbelievable 
23:47:20 <nhnt11> The test passed on the first run
23:47:23 <nhnt11> something must be wrong :P
23:48:51 <nhnt11> yeah, something is wrong
23:49:09 <nhnt11> I added a do_throw in a loop and it's still passing
23:49:12 <nhnt11> => loop never executes
23:51:50 <nhnt11> ah, an error..
23:56:05 <clokep> Hahah.
23:56:07 <clokep> :)
23:57:17 <nhnt11> clokep: So I can't get my test to fail :S
23:57:31 <nhnt11> pasting
23:58:04 <nhnt11> clokep: https://pastebin.mozilla.org/5286222
23:58:22 * nhnt11 figured at least ONE of those throws would cause a fail
23:58:24 * clokep needs to start cooking.
23:58:34 <nhnt11> There's an add_task(test_logging) in the run_test function btw
23:58:52 <clokep> nhnt11: Add a throw as the first thing in the function?
23:59:22 <nhnt11> hmm
23:59:32 <nhnt11> it passed :S