#instantbird log on 05 27 2014

All times are UTC.

00:14:08 <-- wnayes has quit (Ping timeout)
00:14:29 --> wnayes has joined #instantbird
00:21:49 <-- iamjayakumars has quit (Ping timeout)
00:22:43 --> iamjayakumars has joined #instantbird
00:32:36 <-- nhnt11 has quit (Ping timeout)
00:37:50 --> nhnt11 has joined #instantbird
00:40:22 --> Armada651 has joined #instantbird
00:40:22 <-- Armada_ has quit (Connection reset by peer)
01:01:18 <-- Mook_as has quit (Quit: Mook_as)
01:02:23 <-- nhnt11 has quit (Ping timeout)
01:03:19 --> nhnt11 has joined #instantbird
01:04:46 <-- Armada651 has quit (Connection reset by peer)
01:04:53 <-- iamjayakumars has quit (Quit: )
01:11:13 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
01:21:21 <-- Tonnes has quit (Ping timeout)
01:25:38 --> Tonnes has joined #instantbird
01:33:37 --> mconley has joined #instantbird
02:14:28 <-- wnayes has quit (Ping timeout)
02:14:45 --> wnayes has joined #instantbird
02:17:42 <-- mconley has quit (Quit: NO CARRIER)
02:18:06 --> mconley has joined #instantbird
02:18:48 <-- mconley has quit (Quit: NO CARRIER)
02:38:11 <-- nhnt11 has quit (Ping timeout)
02:39:36 --> nhnt11 has joined #instantbird
02:51:02 --> CaptainCalliope has joined #instantbird
02:55:25 <-- wnayes has quit (Quit: wnayes)
03:13:58 <-- nhnt11 has quit (Ping timeout)
03:15:24 --> nhnt11 has joined #instantbird
03:31:57 <-- nhnt11 has quit (Ping timeout)
03:33:48 --> nhnt11 has joined #instantbird
03:35:35 <-- nhnt11 has quit (Ping timeout)
03:37:04 --> nhnt11 has joined #instantbird
03:47:49 <-- nhnt11 has quit (Ping timeout)
03:49:12 --> nhnt11 has joined #instantbird
03:54:26 <-- nhnt11 has quit (Ping timeout)
03:55:57 --> nhnt11 has joined #instantbird
03:56:44 --> mpmc has joined #instantbird
04:03:12 <-- nhnt11 has quit (Ping timeout)
04:15:49 --> nhnt11 has joined #instantbird
04:25:35 <-- nhnt11 has quit (Ping timeout)
04:30:07 --> nhnt11 has joined #instantbird
04:41:46 <-- nhnt11 has quit (Ping timeout)
04:45:07 --> nhnt11 has joined #instantbird
04:45:30 <-- CaptainCalliope has quit (Ping timeout)
04:46:45 --> CaptainCalliope has joined #instantbird
04:55:23 --> gerard-majax_ has joined #instantbird
05:01:19 <-- gerard-majax_ has quit (Ping timeout)
05:10:51 <-- nhnt11 has quit (Ping timeout)
05:11:55 --> nhnt11 has joined #instantbird
05:14:09 --> gerard-majax_ has joined #instantbird
05:17:22 <-- nhnt11 has quit (Ping timeout)
05:17:47 <-- gerard-majax_ has quit (Ping timeout)
05:18:42 --> nhnt11 has joined #instantbird
05:24:07 --> jb has joined #instantbird
05:25:28 <-- nhnt11 has quit (Connection reset by peer)
05:26:52 --> nhnt11 has joined #instantbird
05:32:37 <-- Rym has quit (Ping timeout)
05:33:13 --> mayanktg has joined #instantbird
05:33:14 <-- EionRobb has quit (Quit: Leaving.)
05:55:35 --> gerard-majax_ has joined #instantbird
05:57:19 <-- gerard-majax_ has quit (Ping timeout)
06:04:51 <-- nhnt11 has quit (Ping timeout)
06:06:13 --> nhnt11 has joined #instantbird
06:13:50 --> EionRobb has joined #instantbird
06:14:11 <-- nhnt11 has quit (Ping timeout)
06:15:35 --> nhnt11 has joined #instantbird
06:16:58 --> gerard-majax_ has joined #instantbird
06:19:12 <-- nhnt11 has quit (Ping timeout)
06:20:41 --> nhnt11 has joined #instantbird
06:23:07 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
06:23:12 <-- jb has quit (Ping timeout)
06:23:23 <-- gerard-majax_ has quit (Ping timeout)
06:24:14 <-- nhnt11 has quit (Ping timeout)
06:25:16 --> nhnt11 has joined #instantbird
06:26:42 --> jb has joined #instantbird
06:38:53 --> gerard-majax_ has joined #instantbird
06:39:33 <-- jb has quit (Ping timeout)
06:42:24 <-- gerard-majax_ has quit (Ping timeout)
06:44:21 * Fallen|away is now known as Fallen
06:52:46 <-- nhnt11 has quit (Ping timeout)
06:54:00 --> nhnt11 has joined #instantbird
07:26:11 <-- nhnt11 has quit (Ping timeout)
07:27:42 --> nhnt11 has joined #instantbird
07:35:42 <-- nhnt11 has quit (Ping timeout)
07:36:07 --> nhnt11 has joined #instantbird
07:39:41 <-- nhnt11 has quit (Ping timeout)
07:42:00 --> nhnt11 has joined #instantbird
07:44:52 <-- nhnt11 has quit (Ping timeout)
07:47:06 --> nhnt11 has joined #instantbird
07:49:16 --> jb has joined #instantbird
07:51:27 --> gerard-majax_ has joined #instantbird
07:53:11 <-- nhnt11 has quit (Ping timeout)
07:54:56 --> nhnt11 has joined #instantbird
08:35:28 * nhnt11 is debugging
08:41:14 <nhnt11> Seems to be working, except that the promise returned by logger.js isn't getting recognized as a promise in the consumer
08:41:23 <nhnt11> (foobar().then is not a function)
09:08:00 --> BWMerlin has joined #instantbird
09:11:33 --> mayanktg has joined #instantbird
09:24:06 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:39:28 --> sonny has joined #instantbird
09:48:44 <mayanktg> Hello. I'm trying to add toolbarbuttons for the Bug 1004930 . I have used a <children/> but unable to get the icons :-/ . here's the pastebin http://pastebin.instantbird.com/718867 . I have looked at the example http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/tree.xml#996
09:48:47 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1004930 enh, --, ---, nobody, NEW, Generic way to add buttons for actions to a conversation
09:49:46 <mayanktg> Also http://mb.eschew.org/15#sub_15.2.5.2
09:55:57 <nhnt11> mayanktg: Are you using <children> so that you don't have to write separate code for the different sizes of conv-top-inf?
10:00:12 --> flo-retina has joined #instantbird
10:00:12 * ChanServ sets mode +qo flo-retina flo-retina 
10:00:22 <nhnt11> mayanktg: So from what I understand, if you have a binding "foo" (in this case, "conv-info-*") and want to add a binding to it "bar" (in this case "toolbarbutton-test") as a child, what <children> allows you to do is merge the stuff in foo's <content> with the stuff in bar's <content>
10:00:35 --> chrisccoulson has joined #instantbird
10:00:52 <mayanktg> nhnt11: No. to add toolbarbuttons (like the target switcher). 
10:01:30 <-- EionRobb has quit (Quit: Leaving.)
10:01:30 <mayanktg> nhnt11: Yes. Exactly.
10:01:31 <nhnt11> so if you have <children includes="toolbarbutton"/> in "conv-info-large", and add a "toolbarbutton-test" to it, then the toolbar buttons from the toolbarbuton-test element will get added wherever the children tag was
10:02:50 <nhnt11> flo-retina: I've been unable to get the interface to return a Promise :(
10:03:04 * nhnt11 asked on #developers, no response..
10:03:12 * flo-retina doesn't understand anything in http://pastebin.instantbird.com/718867 :(
10:03:31 <nhnt11> Oh, looks like Yoric is active, I can ask him :D
10:03:56 <flo-retina> #developers isn't very active in the (European) morning
10:04:00 <flo-retina> Yoric is in France
10:04:15 <nhnt11> His whois said active 3 mins ago :)
10:04:19 * nhnt11 has been stalking him ;)
10:04:46 --> Armada has joined #instantbird
10:05:25 <nhnt11> mayanktg: I'm pretty sure that in order for your code to work you need to create a "toolbarbutton-test' element from JS and explicitly add it as a child of the conv-info-large element
10:06:17 <flo-retina> "<children includes="toolbarbutton-test"/>" -> that should be 'toolbarbutton', not toolbarbutton-test
10:06:22 <nhnt11> mayanktg: If you remove the includes attribute from your children tag, and do what I said from code, the content of the toolbarbutton-test binding should get added where the children tag is (which is your hbox)
10:06:39 <mayanktg> Ok.
10:07:43 <nhnt11> flo-retina: Apart from returning the promise, my Cu.reportErrors that the promise should be returned is good to go
10:07:55 <nhnt11> it resolves to the enumerator, which works as expected
10:08:04 <flo-retina> are you discussing this in #perf?
10:08:09 <nhnt11> No
10:08:40 <nhnt11> I asked once on #developers ~20 minutes ago, that's it.
10:08:55 <nhnt11> I pinged Yoric on #developers a few minutes ago..
10:09:43 <flo-retina> https://groups.google.com/forum/#!topic/mozilla.dev.platform/NcIsG6_TKV0
10:09:47 <flo-retina> nhnt11: ^
10:10:25 <nhnt11> flo-retina: I've seen that already. I have everything set to jsval in my idl file, but the returned value gives me |TypeError: Services.logs.getLogsForConversation(...).then is not a function|
10:10:52 <nhnt11> Let me pastebin some code for you...
10:10:55 <flo-retina> if you dump the return of Services.logs.getLogsForConversation(...) what do you get?
10:13:30 <nhnt11> flo-retina: Ah, should've done that ages ago, |[xpconnect wrapped nsISimpleEnumerator]|
10:13:37 <nhnt11> That's odd :S
10:14:12 * nhnt11 wonders if that means that the promise has already resolved
10:14:36 <nhnt11> And even if it has, shouldn't then() still work?
10:14:42 * nhnt11 investigates 
10:17:17 * Fallen is now known as Fallen|away
10:17:42 <nhnt11> flo-retina: Uh, do I need to do anything to get my idl changes to take effect?
10:18:50 <flo-retina> rebuild?
10:19:05 <nhnt11> I did?
10:19:23 <nhnt11> $mach build im is enough right?
10:19:38 <flo-retina> maybe
10:19:47 <flo-retina> aren't these idl files in chat/ ?
10:19:56 <nhnt11> Yes
10:20:07 <nhnt11> $mach build im builds im/, chat/, and im/app/
10:20:23 <flo-retina> so you are sure the .xpt file has been rebuilt?
10:20:55 * nhnt11 isn't sure
10:20:58 * nhnt11 will do a full build
10:21:11 <flo-retina> and -purgecaches ?
10:23:32 <-- sonny has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:23:35 --> sonny has joined #instantbird
10:25:02 --> clokep has joined #instantbird
10:25:02 * ChanServ sets mode +o clokep 
10:25:46 <nhnt11> It's working now :]
10:25:57 <nhnt11> full build did the trick
10:28:37 <flo-retina> :)
10:30:10 <-- chrisccoulson has quit (Ping timeout)
10:35:30 <nhnt11> \o/
10:35:44 <nhnt11> The log viewer is showing my logs :)
10:37:04 <nhnt11> No errors anywhere either :)
10:38:21 <flo-retina> :)
10:41:45 <clokep> sawrubh: Ping
10:45:52 <clokep> flo-retina: Do we have any idea about windows nightlies yet?
10:46:30 <flo-retina> not really
10:46:37 <flo-retina> I want to convince Even to look into it
10:46:53 <clokep> Alright.
10:46:58 <-- sonny has quit (Ping timeout)
10:48:23 --> sonny has joined #instantbird
10:51:00 <nhnt11> flo-retina: Are there any logger consumers other than the log viewer?
10:51:46 <flo-retina> nhnt11: gloda
10:52:39 * nhnt11 will have to figure that out
10:54:05 --> nhnt11-testing has joined #instantbird
10:55:36 --> aleth has joined #instantbird
10:55:36 * ChanServ sets mode +o aleth 
10:56:44 <sawrubh> clokep: quick pong
10:56:57 <sawrubh> I'll be back in 45 min
10:57:10 <sawrubh> Outside on the road right now
10:57:18 <clokep> OK.
10:57:27 <clokep> sawrubh: OK, I'll be at work then. Talk to me then.
10:57:53 <sawrubh> Ok
10:58:13 <-- nhnt11-testing has quit (Input/output error)
11:00:12 <clokep> flo-retina: Did you see Philip Chee's post in m.d.a.thunderbird?
11:02:46 * nhnt11 is doing a self-review
11:04:48 <clokep> (About browserRequest.(xul|js))
11:04:54 <clokep> I'll reply to him at some point btw.
11:06:32 <flo-retina> clokep: I don't think I'm subscribed to that group, so no
11:07:26 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:08:05 * Fallen|away is now known as Fallen
11:10:32 <-- aleth has quit (Ping timeout)
11:12:32 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:13:52 <nhnt11> aleth, flo-retina: I've uploaded a new patch for feedback. Stuff I'm aware of: I think a couple of functions are now unused and need to be removed (getLogFolderForAccount is one, and the logDir getter). Error handling needs to be added. Comments are needed. Promise.jsm is an unused import. File needs to be closed after a period of inactivity.
11:14:03 <nhnt11> brb
11:14:08 <-- jb has quit (Ping timeout)
11:15:56 --> jb has joined #instantbird
11:16:20 <flo-retina> nhnt11: "There is a slight delay when viewing the log for a conversation with a large amount of log files"  was this delay already there before?
11:16:23 --> jb1 has joined #instantbird
11:16:27 <-- jb has quit (Connection reset by peer)
11:18:05 <nhnt11> flo-retina: I can't imagine why it wouldn't have. It would've been a UI-blocking delay before, but now you get to see a blank log viewer till everything is loaded
11:18:20 <flo-retina> smells like a bug
11:18:24 <nhnt11> I'll test though
11:18:36 <nhnt11> flo-retina: If hundreds of files had to be read, why would there not be a delay?
11:18:37 <flo-retina> is this while getting the list of log files, or while getting the messages of a specific (large) file?
11:19:30 <Fallen> what is the nickname autocompletion service called? I can't find anything related with the search terms I am using.
11:19:31 <nhnt11> I haven't tested it that far yet
11:19:41 <nhnt11> Just noted that there was a slight delay
11:20:06 <flo-retina> Fallen: It's named "aleth needs to separate that out into a module or service" :-/
11:20:13 <flo-retina> Fallen: the code is in conversation.xml
11:22:03 <Fallen> flo-retina: ah thanks :-)
11:25:09 --> aleth has joined #instantbird
11:25:09 * ChanServ sets mode +o aleth 
11:28:42 --> chrisccoulson has joined #instantbird
11:32:16 --> Rym has joined #instantbird
11:37:06 <aleth> nhnt11: I haven't had time to look at your patch yet, but "There is a slight delay when viewing the log for a conversation with a large amount of log files, maybe we want a throbber"... that sounds like the consumer is still doing things synchronously (i.e. waiting for all the logs to be provided at once), is that right?
11:37:31 <nhnt11> aleth: While I/O is now asynchronous, messages are returned all at once, yes
11:37:36 <aleth> How hard would it be to change this?
11:37:53 <nhnt11> The API would need to change quite a bit
11:38:04 <nhnt11> The current setup with the enumerators would need to be changed
11:38:15 <nhnt11> We would need to start returning messages in batches
11:38:17 <aleth> I'm thinking also of instances in context menus etc where we need to know if logs exist at all, and don't want to wait for the whole list to be assembled
11:38:58 <aleth> What's the bottleneck? Actually creating the enumerator?
11:39:57 <nhnt11> The bottleneck is likely reading the files...
11:40:49 <aleth> Why do we read the files just to get the list?
11:40:54 <nhnt11> aleth: The slight delay is in the order of a couple hundred milliseconds on my machine, with 436 log files in the folder
11:40:56 * Fallen is now known as Fallen|away
11:41:12 <nhnt11> aleth: What's the "list" you're talking about here
11:41:19 <aleth> You have a very fast machine, so it's a concern for people with slower ones..
11:42:00 <aleth> nhnt11: Aren't you talking about the log tree creation where we ask for the list of logs?
11:43:05 <nhnt11> aleth: The bottleneck is when we get the log conversation for a given log
11:43:38 <nhnt11> one second, let me add some dumps and get some numbers...
11:43:46 <aleth> nhnt11: Oh, then I misunderstood. So you say this happens when clicking on a different log in the tree?
11:44:17 <nhnt11> aleth: yes
11:44:40 <nhnt11> Uh, in the sense, if that log conversation hasn't been created already
11:44:48 <nhnt11> let me run a few more tests..
11:45:21 <aleth> I'm intrigued because with the current sync code, I don't notice any lag (well sometimes there's a progress bar while adding the messages of course).
11:45:38 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
11:45:48 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:46:10 --> mayanktg has joined #instantbird
11:46:49 <aleth> Which is the same issue as opening a conv from hold that you will get to later in the project ;)
11:46:57 <nhnt11> yeah
11:47:35 <aleth> Maybe you can use the profiler to check that the lag you see is actually coming from that and not from anything logger.js-related
11:48:10 <nhnt11> aleth: It doesn't seem to be
11:48:31 <aleth> Should be useful info to find out where all the time is spent.
11:48:42 <nhnt11> The delay I'm seeing is on a blank log viewer, then I can see messages getting appended
11:48:49 <nhnt11> (progress bar)
11:49:49 <nhnt11> aleth: I'm surprised you wouldn't see this delay with sync log reading.
11:50:01 <nhnt11> Either implementation has to read the files so...
11:50:22 <aleth> That's why I'm a bit confused and would like to know the cause.
11:51:20 <aleth> What I currently experience is that it may take time to add all the messages in a log (progress bar) but because the first messages get displayed immediately, it's not really terrible.
11:52:02 <aleth> Hmm, do you have a SSD? Maybe my disk I/O is faster.
11:52:11 <nhnt11> aleth: Yes, I have an SSD
11:52:16 <aleth> So that's not it.
11:52:36 <nhnt11> aleth: I'm testing the same log folder on the sync implementation, wait
11:54:10 <nhnt11> Heh, here it's not opening at all
11:54:13 <nhnt11> ugh
11:54:24 <nhnt11> Error: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIFileInputStream.init]
11:54:42 <aleth> ouch.
11:54:48 <aleth> --purgecaches?
11:55:31 * sawrubh is back
11:55:42 <nhnt11> aleth: FYI the log folder has ~850 JSON files of 17kb each
11:55:47 <nhnt11> Brb
11:55:51 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:55:59 --> nhnt11 has joined #instantbird
11:56:25 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:56:34 --> nhnt11 has joined #instantbird
11:58:08 --> nhnt12 has joined #instantbird
11:58:18 <-- nhnt11 has quit (Connection reset by peer)
11:58:56 <nhnt12> aleth: I just tried to open a log with 500 files, 44kB each
11:59:00 <nhnt12> The same lag is present
11:59:11 <nhnt12> just that it happens /before/ the log viewer is opened in this case
11:59:22 <nhnt12> Rather, before the window is displayed
11:59:35 <nhnt12> I'll find out where the lag is coming from
12:00:01 <aleth> Yeah, this is why I assumed you were talking about the log tree creation, rather than individual log tree entries
12:00:04 <nhnt12> (In the async implementation, UI isn't blocked while IO happens, so though I see an empty viewer, I can still move windows around and stuff in the split second)
12:00:42 <aleth> Probably a sign of partial success :D
12:00:49 <nhnt12> Definitely
12:02:08 <nhnt12> aleth: So I think I should focus on cleaning up this patch, adding error handling and tests, and getting it landed before worrying about returning messages in batches and such
12:02:16 <aleth> Definitely
12:03:02 <aleth> As long as you are sure that't what's causing the delay here.
12:03:42 <aleth> I'm not completely convinced (in the sync version, we don't add messages before creating the window ;) )
12:04:27 <nhnt12> aleth: Adding messages isn't the problem
12:04:35 <aleth> (Well, I guess it depends on whether we are talking about adding messages to the conv or to the DOM)
12:04:41 <nhnt12> Ah
12:04:47 * nhnt12 is doing some testing
12:05:03 <-- mayanktg has quit (Ping timeout)
12:05:04 <nhnt12> aleth: The lag is definitely in getConversation()
12:05:09 <nhnt12> i.e. during the reading of the files
12:05:10 --> clokep_work has joined #instantbird
12:05:10 * ChanServ sets mode +o clokep_work 
12:05:59 <aleth> In the sync version, that happens onselect.
12:06:07 --> chrisccoulson has joined #instantbird
12:06:27 <nhnt12> Yeah. same case here.
12:07:14 <nhnt12> aleth: In the sync version, openWindow is called with the list of logs, but the window isn't shown until getConversation is completed
12:07:18 <nhnt12> Because... it's sync ;)
12:07:35 <nhnt12> (that's why there's a delay before i see the window0
12:07:37 <nhnt12> ) *
12:07:47 <aleth> OK
12:07:56 <nhnt12> s/openWindow/openDialog/
12:08:42 * nhnt12 wonders about the throbber
12:08:50 <nhnt12> Possibly a follow up
12:08:51 <aleth> I think we should revisit this later.
12:08:52 * nhnt12 is now known as nhnt11
12:08:57 <nhnt11> Okay!
12:09:04 <nhnt11> I'll start on error handling.
12:09:58 <aleth> Great :) Make sure you handle OS.File errors, and that no code errors can go unnoticed.
12:10:54 <flo-retina> nhnt11: "The current setup with the enumerators would need to be changed" we are using enumerators specifically because they don't have a .length property, so that we don't have to be done reading to start returning results
12:12:00 <nhnt11> Oh
12:12:02 <nhnt11> Ah
12:12:28 <aleth> I thought you remembered this from last year ;)
12:12:56 <nhnt11> flo-retina: What if the consumer consumes all of the enumerators elements before it's been refilled?
12:13:30 <nhnt11> aleth: Last year I returned multiple enumerators right? And there were callbacks... -_-'
12:14:40 * nhnt11 thought flo-retina was suggesting we use the enumerator like a buffer
12:15:07 * nhnt11 goes to get some food, bbl
12:17:41 <flo-retina> nhnt11: Then one getNext() call may be blocking
12:18:12 <-- BWMerlin has quit (Quit: BWMerlin)
12:23:45 --> mpmc has joined #instantbird
12:26:37 <aleth> nhnt11: Btw, when you change interfaces, an incremental build (mach build im) is not enough 
12:27:23 <aleth> You don't have to import Promise.jsm because you can use DOM Promises now :)
12:29:05 <-- aleth has quit (Ping timeout)
12:31:33 <clokep_work> What are DOM promises? :-S
12:31:58 <clokep_work> nhnt11: Shouldn't the enumerator returned allow you to be async by quering for more data each time a result is needed?
12:32:25 <clokep_work> sawrubh: You still here?
12:32:53 <sawrubh> hey
12:33:36 <sawrubh> yeah, so I've nearly completed the drag and drop, I was looking at defining the methods for ondrop and other handlers in an external file and referring that via script
12:33:48 <clokep_work> Is that necessary?
12:33:59 <clokep_work> Does anything else in that file do that?
12:34:29 --> mayanktg has joined #instantbird
12:34:32 <sawrubh> no, it doesn't. But I've seen other xul files do that (however they do it on menu* things and not handlers)
12:34:54 <clokep_work> I don't think we should do it then.
12:35:01 <clokep_work> Unless there's a real good reason to do it.
12:40:17 <clokep_work> nhnt11: Those changes are too large for me to review right now. :( Maybe I can take a look tonight if aleth doesn't give you feedback.
12:40:39 --> aleth has joined #instantbird
12:40:39 * ChanServ sets mode +o aleth 
12:42:45 <aleth> clokep_work: DOM Promises are just the builtin ES6 promises.
12:43:19 <aleth> Promises defined in the DOM spec.
12:51:40 <nhnt11> re
12:52:25 <clokep_work> aleth: Are they any different?
12:52:25 <nhnt11> aleth: I know I don't need Promises.jsm, http://log.bezut.info/instantbird/today/#m195 :)
12:52:46 <nhnt11> I imported it because I tried using Promise.defer() when my interface changes didn't work
12:53:10 <nhnt11> (with the thought that maybe a Promise.jsm Promise would work as expected)
12:53:11 <aleth> Oh, I thought you meant "I don't know why I don't need Promises.jsm" with that ;)
12:53:41 <nhnt11> Oh
12:53:43 <aleth> Yeah, there's a lot of really confusing stuff out there regarding differing Promise implementations...
12:55:56 <aleth> clokep_work: yes
12:56:25 <aleth> around the edges...
13:01:01 <nhnt11> clokep_work: I just noticed this post doesn't link to our blogs, maybe you want to update it? http://blog.instantbird.org/2014/04/google-summer-of-code-2014-has-commenced/
13:01:04 <nhnt11> Just a thought :)
13:01:55 * aleth wonders if mayanktg would like to put a blogpost about the webcam user icon on the IB blog when it lands
13:02:28 <mayanktg> aleth: Sure :)
13:02:49 <-- Rym has quit (Ping timeout)
13:03:51 * nhnt11 wonders if we want a log-viewer-tab
13:04:24 <flo-retina> nhnt11: as a temporary thing maybe
13:04:32 <flo-retina> nhnt11: but that doesn't replace infinite scroll
13:04:37 <aleth> We can think about that later when you do infinite scroll
13:04:48 <aleth> It should become unnecessary
13:05:00 <nhnt11> flo-retina: I didn't intend it to replace infinite scroll
13:05:08 <aleth> Heh, IRC lag sometimes...
13:05:41 <nhnt11> aleth: It's not necessarily unnecessary, what if you want to see a conversation from a specific date?
13:05:50 <nhnt11> (by "it" I mean a separate log viewer)
13:05:55 <clokep_work> nhnt11: I wrote that post before YOU knew you were accepted, I certainly couldn't ask you for your blog. ;0
13:05:55 <aleth> How about a sidebar with the log tree in it?
13:06:12 <nhnt11> Yeah
13:06:25 <nhnt11> So I guess log-viewer-tab is just a conversation tab with the sidebar :)
13:06:37 <aleth> Yup! :)
13:06:42 <nhnt11> clokep_work: Fair enough :)
13:07:02 <clokep_work> nhnt11: I can update it though, maybe. Remind me later. I'm quite busy this morning.
13:07:06 <nhnt11> Okay
13:07:22 * nhnt11 figured if he's writing blog posts, it would be nice if a few people are reading them ;)
13:09:43 <-- Armada has quit (Quit: Leaving)
13:09:48 --> Armada has joined #instantbird
13:18:29 --> Rym has joined #instantbird
13:19:44 <-- CaptainCalliope has quit (Ping timeout)
13:21:18 --> CaptainCalliope has joined #instantbird
13:25:29 <clokep_work> sawrubh: So what is left to do on your initial patch?
13:25:45 <clokep_work> I'd like to see a patch up for feedback.
13:26:12 --> rosonline has joined #instantbird
13:26:30 * aleth wonders what happened to the topic bug
13:28:42 <clokep_work> I think I wanted to test the patch and see the messages being exchanged before replying again.
13:29:36 <sawrubh> clokep_work: there seems to be a callback issue on the upload function, debugging that, will send for feedback as soon as I work it out (max 1 hour I guess)
13:29:43 <clokep_work> (Althouhg it's apparently unread, so I might just not have really thought about it yet).
13:30:05 <clokep_work> sawrubh: OK. What's the issue? Is there an error being thrown?
13:30:54 <sawrubh> uploading the diff in a sec
13:40:37 <clokep_work> Alright.
13:47:48 <sawrubh> clokep_work: http://pastebin.instantbird.com/719111 is the relevant part (don't mind the indentation for now) http://pastebin.instantbird.com/719112 is the error
13:51:11 * Fallen|away is now known as Fallen
13:52:22 <sawrubh> clokep_work: I think I got it
13:53:22 <clokep_work> sawrubh: listener is commented out in that code.
13:53:28 <clokep_work> sawrubh: Line 121.
13:53:38 <clokep_work> sawrubh: Where is taht listener, etc. coming from btw? Is there similar TB code you got this from?
13:54:46 <sawrubh> I've commented it because listener is defined on line 68
13:55:22 --> mconley has joined #instantbird
13:56:00 <sawrubh> clokep_work: http://mxr.mozilla.org/comm-central/source/mail/components/compose/content/MsgComposeCommands.js#1363
13:59:40 <clokep_work> sawrubh: It looks like you're defining an object, but no instance to it. I think you'd want to (on L123) new listener()
14:01:04 <clokep_work> sawrubh: The listener you're passing only has one property: prototype, but once you create an instance (via. new listener()), then it should have the other properties that are expected.
14:01:35 <clokep_work> sawrubh: Btw I had no idea this required so much code, so I agree with you now that it might make sense to move some of it to a separate file.
14:07:33 <clokep_work> Does that make sense?
14:07:45 <sawrubh> yes, on it already
14:15:45 <nhnt11> aleth: Do we want user-friendly errors, or just make sure we get everything safely to the error console without dropping anything?
14:16:12 <mayanktg> The toolbarbutton is added to the <children/> but the xbl:inherits="...." didn't seem to inherit the image and tooltiptext. 
14:17:00 <mayanktg> Moreover if I add image="<icon-url>" to one of the toolbarbutton, both of them inherits it 
14:17:14 <aleth> nhnt11: Error console is enough for now I think for writing. For reading we already tell the user, you can improve that a bit if you like.
14:17:23 <mayanktg> here's the Pastebin of diff http://pastebin.instantbird.com/71911
14:17:50 <nhnt11> aleth: We do? What about that error I posted a while ago?
14:17:53 <aleth> nhnt11: Of course the error console errors should be comprehensible for file i/o errors.
14:17:57 <aleth> Which error?
14:18:27 <nhnt11> http://log.bezut.info/instantbird/today/#m259
14:18:38 <nhnt11> aleth: It was my fault, I copied log files from a different profile into this one
14:19:04 <aleth> That seems to suggest the current code doesn't do it well enough ;)
14:19:07 <nhnt11> Still, it was only in the error console..
14:19:10 <nhnt11> Yeah
14:19:14 * nhnt11 will figure it out
14:20:38 <aleth> What we do at the moment is http://mxr.mozilla.org/comm-central/source/chat/components/src/logger.js#351 and http://mxr.mozilla.org/comm-central/source/im/content/viewlog.js#79
14:21:37 <nhnt11> Hmm, so we just "ignore" bad log files
14:21:55 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:21:58 * Fallen is now known as Fallen|away
14:22:12 <aleth> We only ignore them if there are others on the same day. And there is an error message in the log viewer.
14:22:30 <nhnt11> Okay.
14:22:51 <nhnt11> Task.spawn should make errors easy to handle :)
14:22:52 <aleth> The error message isn't very specific though.
14:23:11 <aleth> And what you pastebinned above shouldn't happen of course ;)
14:23:15 <flo-retina> mayanktg: broken pastebin link
14:24:34 <clokep_work> sawrubh: Make sure you're not wasting time spinning your wheels. If you can't quickly find the solutions via Googling please ask us! (We should at least be able to point you to things to look at. :))
14:25:03 <sawrubh> ok, it's working now btw :)
14:25:32 <sawrubh> I'm working on getting the url for the file uploaded (it's coming as undefined in case of Hightail, seeing why that is so)
14:25:46 <nhnt11> flo-retina: I think he meant http://pastebin.instantbird.com/719118
14:26:54 <flo-retina> I have no clue of what that patch is trying to do with the new binding :-/
14:26:58 <nhnt11> There's a lot of spam on pastebin.i.c... :(
14:27:20 <flo-retina> nhnt11: I don't think it matters
14:27:42 <flo-retina> last time I looked into it, spammers don't set the "forever" option, so their junk clears itself automatically
14:27:45 <aleth> We could hide the sidebar ;)
14:28:19 <clokep_work> sawrubh: Alright.
14:28:36 <nhnt11> aleth: The sidebar is useful sometimes (that's how I got the correct link just now) :)
14:28:37 <clokep_work> Please ask questions!
14:28:49 <clokep_work> Psh people look at the sidebar?!
14:28:54 <clokep_work> I need to stop using that for private things.
14:29:31 <flo-retina> clokep_work: heh, keeping the spammers means the sidebar never displays anything useful ;)
14:29:37 <flo-retina> so your private stuff is safe
14:29:42 <flo-retina> well, "safe" :)
14:29:52 <aleth> people will just assume it's spam ;)
14:30:47 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
14:35:15 <clokep_work> :)
14:38:25 <sawrubh> clokep_work: so it's working perfectly on Box :)
14:38:54 <aleth> :)
14:39:09 <clokep_work> sawrubh: Cool. :) Sounds like I'll have a patch to give feedback on soon? :P
14:45:55 --> iamjayakumars has joined #instantbird
14:46:24 <-- aleth has quit (Ping timeout)
14:57:44 --> aleth has joined #instantbird
14:57:44 * ChanServ sets mode +o aleth 
15:17:37 <-- Rym has quit (Ping timeout)
15:28:44 * nhnt11 finds bugs
15:33:20 <nhnt11> aleth: Thanks for the feedback :)
15:33:24 <nhnt11> Those comments weren't dropped on purpose :]
15:33:41 <nhnt11> I was moving stuff around and they got.. lost :]
15:34:22 <aleth> Yeah, this file is very messy and you are moving lots of things into hopefully better places ;)
15:34:38 <nhnt11> aleth: The reason createLogConversationFromFiles is a separate function is because I didn't know if it's okay to do async stuff in a constructor (I'm assuming it's /not/ okay)
15:35:06 <-- sonny has quit (Ping timeout)
15:35:33 <aleth> The problem is you can't return a promise from a constructor afaik, as you can't return a value
15:35:40 <nhnt11> Yeah
15:36:05 <aleth> But you're calling that function from getConversation, so I don't see why that applies
15:36:34 <nhnt11> Ah yeah
15:36:51 <nhnt11> The contents of that function should just be in getConversation I guess.
15:37:05 <nhnt11> I see why  you said merging Log and LogCluster would help
15:37:22 <aleth> I may be missing something, but they seem almost identical
15:37:55 --> Rym has joined #instantbird
15:39:44 <clokep_work> nhnt11: Or maybe have one inherit from the other?
15:40:41 <nhnt11> So we're currently using Log for txt logs and LogCluster for JSON logs
15:40:44 --> sonny has joined #instantbird
15:41:00 <clokep_work> (o_O)
15:41:20 --> mayanktg has joined #instantbird
15:42:25 --> Vigilante has joined #instantbird
15:42:45 <-- Vigilante has left #instantbird ()
15:43:10 <aleth> Are you sure?
15:43:23 <aleth> I think that's incidental.
15:43:30 <mayanktg> flo-retina: http://pastebin.instantbird.com/719118
15:43:38 <aleth> It's only because we don't bundle text logs.
15:43:50 <-- iamjayakumars has quit (Client exited)
15:44:30 <nhnt11> aleth: https://mxr.mozilla.org/comm-central/source/chat/components/src/logger.js#559
15:44:55 --> iamjayakumars has joined #instantbird
15:45:01 <aleth> yes, like I said.
15:45:30 <nhnt11> I'll try to combine them for the next patch
15:46:08 * nhnt11 missed this line while converting stuff to OS.File https://mxr.mozilla.org/comm-central/source/chat/components/src/logger.js#562
15:47:45 <aleth> In case that wasn't clear: JSON logs get a single entry per day in the tree. Text logs get one for each file.
15:48:07 * nhnt11 gets it
15:48:20 <aleth> Because nobody could be bothered to implement clustering for text logs ;)
15:48:30 <aleth> (That's my guess anyway)
15:53:37 <-- sonny has quit (Ping timeout)
15:53:46 <aleth> Oh, there was also the issue that there'll be one day where you have text logs and your first json log...
15:54:10 * aleth hopes wnayes will have time to land log importing soon so we can get rid of this text log mess
15:54:23 <-- gerard-majax_ has quit (Ping timeout)
15:56:32 <clokep_work> If things can be split into follow ups that might be good too.
15:56:58 * nhnt11 likes the sound of that
16:00:59 <-- aleth has quit (Ping timeout)
16:02:30 --> aleth has joined #instantbird
16:02:30 * ChanServ sets mode +o aleth 
16:04:38 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:15:03 <-- chrisccoulson has quit (Ping timeout)
16:18:10 <clokep_work> sawrubh: Any chance of putting up that patch?
16:18:13 * clokep_work is on his lunch hour.
16:18:28 <sawrubh> uploading
16:19:12 --> sonny has joined #instantbird
16:19:53 <clokep_work> Alright.
16:20:48 <-- aleth has quit (Ping timeout)
16:21:03 --> aleth has joined #instantbird
16:21:03 * ChanServ sets mode +o aleth 
16:26:03 --> arlolra has joined #instantbird
16:29:21 <-- Tonnes has quit (Connection reset by peer)
16:34:13 <sawrubh> clokep_work: 2 minutes more
16:34:31 --> Mic|web has joined #instantbird
16:35:15 <Mic|web> Sorry that I'm short on time but has someone said something about http://log.bezut.info/instantbird/140527/#m121 later in the logs?
16:36:33 <aleth> Mic|web: mayanktg posted a pastebin earlier, I don't think anyone responded yet
16:36:36 <Mic|web> You don't want to do that. You want to add the children here (so that you don't have to care which binding is applied): http://mxr.mozilla.org/comm-central/source/im/content/conversation.xml#23
16:36:55 <Mic|web> Use the children element in all applicable bindings then.
16:38:40 <Mic|web> Ah, OK. The pastebin looks like mayanktg's doing that already.
16:38:57 <Mic|web> You won't need new bindings for your buttons.
16:39:31 <Mic|web> Document.create toolbarbuttons and set all necessary properties like you need them.
16:39:37 --> Mook_as has joined #instantbird
16:39:48 <Mic|web> You might need to make sure that you're using the right namespace?
16:40:29 <mayanktg> Mic|web: Ok. So I have to create documnet.create... for every new property I want to add in the buttons. 
16:40:30 <mayanktg> :)
16:41:03 <Mic|web> No, you want that once for each button and change the properties of them using "setAttribute" and the liek.
16:41:11 <mayanktg> Mic|web: How can I check about using the right namespace?
16:41:41 <Mic|web> Try if it works. If it does, things are fine.
16:41:55 <Mic|web> If not then ask again.
16:41:57 <mayanktg> Ok.
16:42:05 <Mic|web> I need to go but I'm going to check the logs from time to time.
16:42:28 <Mic|web> Bye!
16:42:30 <mayanktg> I will try to add the properties we had discussions on.
16:42:32 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
16:42:34 <mayanktg> Ok Bye :)
16:42:36 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:44:04 <sawrubh> clokep_work: now working on the improvements I've suggested (sorry for the really dirty patch btw), I'll clean it up a lot in the next iteration
16:44:52 <clokep_work> sawrubh: WIPs are OK.
16:44:59 <clokep_work> We want to be able to comment on the methodology and such earlier.
16:45:06 <clokep_work> I'm not concerned yet about debug statements or formatting.
16:45:10 <clokep_work> But we'll get to that, don't worry. ;)
16:45:51 <aleth> sawrubh: It's better you get feedback before you spend a lot of time polishing something to make sure the basic structure is right...
16:46:30 <sawrubh> btw I haven't cc'ed you on the bug
16:46:46 <sawrubh> ...not that it matters, seems you're already subscribed to that component
16:46:54 <clokep_work> sawrubh: Yes, I get it for the component. :P
16:59:29 <-- iamjayakumars has quit (Client exited)
17:00:49 <-- jb1 has quit (Ping timeout)
17:08:42 <-- aleth has quit (Ping timeout)
17:09:02 --> aleth has joined #instantbird
17:09:02 * ChanServ sets mode +o aleth 
17:10:59 <sawrubh> clokep_work: so all those improvements sound reasonable? are you going to be commenting on it?
17:12:48 <sawrubh> aleth: clokep_work also do you guys want to test this patch on Windows, Mac and Linux (because it didn't seem to be working for you) or do you wanna do it on later versions
17:12:56 <clokep_work> sawrubh: Im about to comment, one second.
17:15:30 <clokep_work> sawrubh: I couldn't get it to work on Mac/Windows, do you ahve access to one of those?
17:16:26 <sawrubh> I have a Windows although that's like completely non-setup for building, can I cross-compile?
17:16:54 <sawrubh> I don't have a Mac though
17:17:10 * sawrubh eyes nhnt11 :P
17:17:37 <nhnt11> sawrubh: What's up
17:17:51 <nhnt11> I'm on/off afk at the moment fyi
17:18:05 <sawrubh> I might request you to test something sometime down the line :)
17:18:12 <nhnt11> Sure
17:19:34 <-- mayanktg has quit (Ping timeout)
17:21:26 <sawrubh> clokep_work: is there some way to move stuff between mq's or will I need to create new mq's (shouldn't take much time but) just wondering
17:22:43 --> gerard-majax_ has joined #instantbird
17:26:01 <aleth> sawrubh: You could export both and copy-paste between the resulting patches
17:26:36 <aleth> (assuming you don't mean whole queues, but individual patches in a queue)
17:26:51 <sawrubh> ah, in the .hg directory!
17:27:07 <sawrubh> yeah, I was planning on moving the 'moving related' changes from one to another
17:27:26 <aleth> I would avoid messing directly with stuff inside .hg
17:27:55 <sawrubh> so you're suggesting I do this copy paste before I upload these patches on BZ?
17:28:12 <aleth> I'm suggesting hg export -> edit the patches -> hg qimport
17:28:18 <sawrubh> ah
17:29:00 <aleth> There's also possibly hg extensions that help with this kind of thing, idk
17:29:41 --> mayanktg has joined #instantbird
17:29:47 <Mook_as> It's also a good idea to put your mq in its own repo (i.e. hg init --mq) if you're going to play with it
17:30:00 <aleth> That's always a good idea!
17:30:41 <aleth> mqext can take care of that for you.
17:36:58 <-- Rym has quit (Ping timeout)
17:37:21 --> Rym has joined #instantbird
17:37:27 <-- gerard-majax_ has quit (Ping timeout)
17:59:21 <clokep_work> sawrubh: |hg help qref| should tell you what you need.
17:59:38 <clokep_work> sawrubh: https://developer.mozilla.org/en-US/docs/Mercurial_Queues#Splitting_a_patch.2C_the_easy_case.3A_per-file_splitting
18:01:48 <clokep_work> Sorry for the delayed response, wasn't here.
18:02:14 <clokep_work> sawrubh: I don't think you can cross compile, theoretically if it works on linux that should be fine. I'll try it again at some point and if it still doesn't work I'll ask you to fix it.
18:02:34 <sawrubh> heh
18:03:27 <sawrubh> I still haven't gotten it to work when I drop the file on the conversation window (instead of the textbox part)
18:04:29 <sawrubh> aleth: do you think it's possible (you ruled out adding handlers on vbox would work because of events (drop etc) not bubbling) is there some such constraint on the conversation window which I'm not aware of
18:04:47 <sawrubh> aleth: btw how did you know that events won't bubble on the vbox? documentation?
18:06:17 <sawrubh> clokep_work: so flo-retina said that he was going to be on leave from Wed, so what should we do about the questions you've asked from him in your feedback?
18:07:57 <clokep_work> sawrubh: Hopefully he'll answer today. ;)
18:08:11 <clokep_work> If not then I'm going to make my best guess at a solution or we'll leave it for now and not check anythign in until he's back.
18:08:20 <aleth> sawrubh: It's not that they don't bubble per se iirc
18:10:19 <aleth> I misremembered that, I think we discovered what mattered is that the drag events have to be cancelled on the same element as the drop handler
18:10:21 <aleth> My concern was that the vbox covered too many elements you didn't want to have as drop targets
18:11:12 <sawrubh> so I'll give a shot again trying to make the conversation window
18:11:21 <sawrubh> a drop target that is
18:12:47 <clokep_work> sawrubh: Do all my comments make sense to you?
18:13:40 <sawrubh> yes, I have a few things
18:13:48 * sawrubh will just comment on the bug
18:14:29 <nhnt11> aleth: dummySystemLog is used if purple.logging.log_system isn't set
18:14:45 <clokep_work> sawrubh: If it's just clarification feel free to ask here.
18:14:45 <nhnt11> And also if non-existing system log is requested with aCreate set to false
18:14:50 <clokep_work> If you don't agree, please ask on the bug.
18:15:14 <nhnt11> aleth: Why do you say it's not compatible with the new code?
18:15:59 <aleth> nhnt11: Thanks. If your new code returns a promise for a certain method, then so should the dummy version of that method.
18:16:15 <aleth> Just return a resolved promise.
18:16:23 <nhnt11> close() doesn't need to return a promise, I've removed the return value
18:16:50 <aleth> Then there's no conflict anymore I guess ;)
18:21:49 --> Mic has joined #instantbird
18:21:49 * ChanServ sets mode +o Mic 
18:24:07 <sawrubh> clokep_work: so that [if(!this._accountType)] was required because in some cases this._accountType was coming up as null (because accountTypeSelected being called on L36 of addAccountDialog.xul, was called before onInit)
18:24:28 <sawrubh> both onInit and accountTypeSelected are defined in addAccountDialog.js btw
18:25:14 <sawrubh> I remember I had tried to debug but couldn't come up with a justification about why this was happening
18:25:25 <clokep_work> sawrubh: Right, so my question is "Is this STILL necessary or is it fixed?"
18:27:47 <aleth> sawrubh: Regarding the drag/drop, have you checked which of the various event handlers get called over the browser?
18:34:01 <sawrubh> and re that dropFile.js I had added that file and plan to use the handlers defined in that instead of the one defined in conversation.xml
18:34:06 <-- sonny has quit (Ping timeout)
18:34:29 <sawrubh> aleth: any easier way to find out all the event handlers registered for a node besides listening for all of them
18:34:40 <sawrubh> online I find solutions which use jQuery
18:35:04 <aleth> Why would you need that? Just put dumps in the handlers you added.
18:35:32 <clokep_work> sawrubh: Yes, I kind of figured that but realized it halfway through the review. :)
18:35:54 <sawrubh> I thought you needed information on the various other handlers...anyhoo
18:37:33 <sawrubh> clokep_work: better name for onDrop? onDrop sounds good me (something which happens on dropping :) )
18:38:07 --> rosonline has joined #instantbird
18:38:28 <Mic> mayanktg: hello!
18:38:50 <clokep_work> sawrubh: I disagree.
18:38:59 <Mic> Do you know already if the children thing is working?
18:39:06 <Mic> I haven't read the logs yet.
18:39:10 <aleth> sawrubh: What I was getting at is that it's possible the handler is being called but your code is buggy ;)
18:39:11 <mayanktg> Mic: Hi. I'm adding effects to the button now :) 
18:39:21 <Mic> What sort of effects?
18:39:35 <aleth> sawrubh: One typical issue is that "this" might not be what you think it is...
18:39:36 <sawrubh> aleth: e_e
18:39:52 <Mic> Do you have a WIP at hand, maybe?
18:39:55 <mayanktg> Mic: AS we discussed.. adding glow effect on hover, tooltiptext
18:40:22 <mayanktg> Mic: yes wait ...
18:40:30 <Mic> hmm, sounds like polishing... does it work already then?
18:41:09 <sawrubh> ok, all comments looked at! time to address them :)
18:41:16 * sawrubh comes up with a better name
18:41:34 <mayanktg> Mic: No. A lot of work needs to be done. btw you said _not_ to create separate bindings and add the <children/> here http://mxr.mozilla.org/comm-central/source/im/content/conversation.xml#23
18:42:03 <sawrubh> clokep_work: aleth should I address these comments first and then we could think of a UX for feedback to the user about the upload progress ?
18:42:33 <mayanktg> Mic: But I have added it in the conv-info-large because this is where the toolbarbutton was defined earlier.
18:42:55 <aleth> sawrubh: Have you got the complete inherited UI working already? (Preference pane, account setup etc)
18:43:38 <sawrubh> I forgot the Pref Pane!
18:43:40 <aleth> Also, before you add something for upload progress, add a notification bar where the user confirms the upload and possibly can change the provider
18:43:41 <sawrubh> I've got the account setup working though
18:44:40 <sawrubh> clokep_work: so I'll try and see if we actually require preferences.css (I think we do but I'll investigate)
18:45:02 * sawrubh gets back to actual work
18:45:41 <clokep_work> sawrubh: We need to scope what that initial patchset is trying to do.
18:46:26 <sawrubh> I didn't catch you (you're talking about Patch1 right?)
18:47:22 <-- aleth has quit (Ping timeout)
18:48:16 <-- CaptainCalliope has quit (Quit: CaptainCalliope)
18:48:21 <sawrubh> tasks for now btw https://etherpad.mozilla.org/ib-filelink-week2
18:49:02 <mayanktg> Mic: Here's the diff. Don't go by the nits :-| http://pastebin.instantbird.com/719333 The toolbarbuttons would be added  to the hbox when we define it in the binding.
18:50:15 <clokep_work> sawrubh: I guess what I'm saying is that we don't have to do the entire uploading, progress, etc. in the final state we want it. If there's a good intermediate state than that's reasonable.
18:50:56 <mayanktg> and then ..we can add the properties we wanted to include namely:
18:50:56 <mayanktg> * enable/disable button
18:50:56 <mayanktg> * image for the button (icon)
18:50:56 <mayanktg> * tooltiptext
18:50:56 <mayanktg> * hover effect
18:50:56 <mayanktg> * fix position for target switcher(in the right). 
18:51:12 <mayanktg> Mic: ^
18:52:52 <sawrubh> clokep_work: ok, so I'll not think about feedback to user right now, just do what's been said till now
18:53:51 <Mic> mayanktg: thanks, let me whip something up ...
18:55:43 <clokep_work> sawrubh: We'll want it done before landing this, but I think there's enough other stuff to clean up first. Does that sound reasonable?
18:55:50 <mayanktg> Mic: Tell me what I have to change there. Also upon changing the binding , I'm unable to get the location of target-switcher icon . (Line 83) :(
18:56:02 <sawrubh> clokep_work: aye
18:59:07 <Mic> mayanktg: I imagined it like this: http://pastebin.instantbird.com/719357
18:59:53 <Mic> That's all initialized from the conversation binding itself. conv-info-(large|small|...) only get a <children/> tag added each.
19:00:16 <mayanktg> Ok
19:02:00 <mayanktg> I've understood it. Let me modify it.
19:02:21 <Mic> Oops, the # is wrong there by the way.
19:02:33 * clokep_work is now known as clokep-meets
19:02:42 <Mic> and classList.add() doesn't need the class names to start with a dot either.
19:03:54 <Mic> The conversation binding is creating the buttons and adding it to its toolbar when loading. The toolbar binding only contain the small "children" change that you already did on conv-info-large.
19:04:10 <Mic> Did that help?
19:04:11 <mayanktg> Ok.
19:04:41 <mayanktg> Yes. I'm working on it now.
19:04:43 <mayanktg> :)
19:10:33 <nhnt11> Mic: Free to test something for a minute?
19:12:06 <nhnt11> Hmm, actually never mind
19:12:10 --> sonny has joined #instantbird
19:12:25 --> CaptainCalliope has joined #instantbird
19:17:19 <clokep-meets> nhnt11: http://blog.instantbird.org/2014/04/google-summer-of-code-2014-has-commenced/
19:17:42 <nhnt11> clokep-meets: :)
19:18:13 <-- mayanktg has quit (Ping timeout)
19:42:31 <Mic> clokep-meets: thanks for the blog posting!
19:42:39 <Mic> I'll link to it from Facebook! :)
19:43:14 <Mic> Oh, wait...
19:43:20 <Mic> I thought it was a new one...
19:45:57 <clokep-meets> Mic: I just added links.
19:48:14 <instantbot> clokep@gmail.com changed the Resolution on bug 1012666 from --- to FIXED.
19:48:17 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1012666 nor, --, 1.6, clokep, RESO FIXED, Fix up checking if IRC topics are settable
19:50:03 --> mayanktg has joined #instantbird
19:50:20 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:50:52 --> mayanktg has joined #instantbird
19:51:43 --> gerard-majax_ has joined #instantbird
19:58:08 <mayanktg> Mic: works :)
20:02:55 <Mic> Cool! I can haz code? ;)
20:05:53 <mayanktg> Mic: http://pastebin.instantbird.com/719402
20:12:24 <Mic> OK.
20:13:20 <Mic> You'll need to make sure that this code is only run once and not on every 'update'.
20:13:23 <-- nhnt11 has quit (Ping timeout)
20:13:36 <Mic> The method you put it in is called from here, e.g.: https://mxr.mozilla.org/comm-central/source/im/content/conversation.xml#1834
20:14:05 <Mic> i.e. I suspect that as soon as you receive a notification like that, you'll get extra buttons.
20:14:29 <Mic> initConversationUI sounds better imo.
20:15:15 --> EionRobb has joined #instantbird
20:15:38 <mayanktg> Ok!
20:16:03 <Mic> You'll need to add the menu to the target switcher by the way...
20:16:03 <mayanktg> Mic: btw regarding the user icon bug. Did the camera work? I changed my camera resolutions (both using "cheese" and "gucview" ) but there was no error as you mentioned :(
20:16:32 <Mic> OK, I'll try again and if it's working I'm going to blame it on Ubuntu :P 
20:17:05 <Mic> -it on
20:17:26 <mayanktg> Mic: How would you test the patch then :P No test no r+ :D 
20:18:03 <Mic> If it's not working, I'll investigate more ;)
20:18:45 --> nhnt11 has joined #instantbird
20:19:12 <Mic> mayanktg: there's stuff that can be removed in the patch, by the way.
20:19:33 <mayanktg> Mic: sure. Where/what?
20:19:48 <Mic> <!-- ... --> , "toolbarbutton-test" stuff
20:20:39 <mayanktg> Ok :)
20:30:19 --> flo-retina has joined #instantbird
20:30:19 * ChanServ sets mode +qo flo-retina flo-retina 
20:37:04 <Mic> mayanktg: make sure to set the attributes on these buttons like they were before. If in doubt what an attribute does, then better copy it and we'll sort that out during review.
20:38:05 <mayanktg> Mic: ok
20:38:09 <-- nhnt11 has quit (Ping timeout)
20:39:53 --> nhnt11 has joined #instantbird
20:40:40 * nhnt11 finds more bugs
20:40:42 <flo-retina> I feel bad for the "new localization" email that got no answer :(
20:43:26 <nhnt11> Aaaah
20:43:36 <nhnt11> [undefined].length is 1 :(
20:44:03 <EionRobb> neat
20:44:47 <EionRobb> why would it be anything else?
20:46:34 <nhnt11> EionRobb: I have a function foo that returns an array, and another function bar that wraps many such arrays in another array and returns it. In the case that bar is wrapping just one array returned by foo, and foo happens to not return anything, the length of the array returned by bar is 1 :(
20:46:39 <nhnt11> If that makes any sense :]
20:46:52 <nhnt11> (I need the length in that case to be 0)
20:47:30 <EionRobb> it returns undefined :)
20:47:51 <nhnt11> Yeah.
20:48:07 <nhnt11> Hence my annoyance that [undefined].length == 0 :)
20:48:11 <nhnt11> 1 *
20:48:31 <EionRobb> you just need to set 1 = 0, then 1==0, solving the problem everywhere
20:48:47 <nhnt11> \o/
20:51:25 <-- nhnt11 has quit (Ping timeout)
20:52:14 --> nhnt11 has joined #instantbird
20:53:35 <-- CaptainCalliope has quit (Quit: CaptainCalliope)
20:53:59 <flo-retina> Is any of you waiting for something from me before I disappear for the rest of the week?
20:54:54 <nhnt11> flo-retina: Maybe you could have a look at the latest patch on bug 955292?
20:54:57 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955292 enh, --, ---, nhnt11, ASSI, Read/write chat logs asynchronously
20:55:23 <nhnt11> flo-retina: How long are you online for? I've added error handling, and am working on a couple of pesky bugs. Should have a new patch soon.
20:57:36 <EionRobb> I want a cookie before you disappear, flo-retina
21:00:04 <sawrubh> flo-retina: clokep-meets asked you some questions on bug 1014644, could you provide your feedback please?
21:00:07 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1014644 nor, --, ---, saurabhanandiit, NEW, Make FileLink work in Instantbird
21:00:34 <nhnt11> Aha!
21:00:40 <flo-retina> EionRobb: http://upload.wikimedia.org/wikipedia/commons/1/16/Choc-Chip-Cookie.jpg
21:00:49 <nhnt11> The bug I'm hunting down exists in the current nightlies
21:00:55 <nhnt11> I thought it was related to my changes :(
21:01:04 <flo-retina> doesn't mean you can't fix it :)
21:01:06 <nhnt11> The show logs menu item is never disabled if a conversation doesn't have logs
21:01:15 <nhnt11> Yeah, this is a good opportunity I guess
21:03:04 <-- nhnt11 has quit (Ping timeout)
21:03:51 --> nhnt11 has joined #instantbird
21:05:03 <nhnt11> This should be using setAttribute :( https://mxr.mozilla.org/comm-central/source/im/content/conversation.xml#1572
21:05:33 <EionRobb> flo-retina: perfect. thanks!
21:06:33 <flo-retina> nhnt11: is the disabled attribute not defined on the menuitem binding? Or is the binding not attached yet?
21:06:50 <-- nhnt11 has quit (Ping timeout)
21:07:49 <Mic> flo-retina: isn't setAttribute setting a DOM attribute while .disabled is setting a JS property?
21:08:11 <flo-retina> Mic: usually the xbl bindings have attribute setters that set the DOM attribute
21:08:19 --> nhnt11 has joined #instantbird
21:08:34 <Mic> OK, good to know.
21:08:43 <flo-retina> and sometimes that doesn't work well
21:08:50 <flo-retina> either because the setter just doesn't exist
21:08:56 <flo-retina> or because the xbl binding isn't attached yet
21:10:24 <Mic> mayanktg: things are goign fine so far?
21:10:46 <nhnt11> flo-retina: The item hasn't been added yet (so the binding isn't attached yet)
21:12:37 <mayanktg> Mic: I have added the menupopup as you told. But the toolbarbuttons are aligned between the status-bar and DisplayName. Wait let me take the screenshot
21:13:17 <-- nhnt11 has quit (Ping timeout)
21:14:08 --> nhnt11 has joined #instantbird
21:14:17 <-- mayanktg has quit (Ping timeout)
21:14:21 <nhnt11> new patch coming up
21:14:34 --> mayanktg has joined #instantbird
21:15:20 <mayanktg> Mic: http://i.imgur.com/5FihkxT.png
21:17:03 <Mic> Did look like that with the code in the latest pastebin?
21:17:20 <mayanktg> Yes
21:18:05 <mayanktg> Even before when I showed you my version of the diff.
21:20:57 <Mic> The code looks like it should display the buttons in the top row.
21:21:35 <mayanktg> Mic: Even on using just the "target switcher" button. The result is the same. :-/
21:22:16 <Mic> (You won't need the enclosing hbox on "children" by the way. The description and the buttons (currently hbox) are already in an hbox...)
21:22:33 <mayanktg> Mic: Yes. I've removed that 
21:22:58 <Mic> Do you use DOMi to inspect stuff by the way?
21:23:14 <Mic> I can be useful to see the generated tree...
21:28:04 <mayanktg> Mic: The generated XML seems to be correct. 
21:28:34 <nhnt11> flo-retina: New patch is up, fyi. I still haven't added more tests, or implemented the auto-closing of the OS.File instance (which shouldn't take too long tbh)
21:28:59 <mayanktg> <hbox>
21:28:59 <mayanktg>   <xul:description>
21:28:59 <mayanktg>   <toolbarbutton>
21:28:59 <mayanktg>   <toolarbutton>
21:29:46 <-- clokep-meets has quit (Ping timeout)
21:30:23 <-- nhnt11 has quit (Ping timeout)
21:31:01 <Mic> Let's see. The grey line belongs to the description...
21:31:25 --> nhnt11 has joined #instantbird
21:31:58 <Mic> Ah!
21:33:14 <Mic> hmm, not quite.
21:35:51 <Mic> The icon is moved over the description.
21:36:34 <Mic> mayanktg: https://mxr.mozilla.org/comm-central/source/im/themes/conversation.css#164
21:36:45 <mayanktg> Mic: Yes. there's a border-bottom for displayName.
21:36:58 <Mic> That's something different.
21:37:20 <-- nhnt11 has quit (Ping timeout)
21:37:28 --> nhnt11 has joined #instantbird
21:37:48 <nhnt11> Good night
21:38:06 <Mic> nn
21:38:43 <-- Rym has quit (Ping timeout)
21:38:59 --> jb has joined #instantbird
21:39:34 <mayanktg> Mic: ehh..Don't try hard ..I'll fix that up. 
21:40:04 <Mic> d'oh.
21:40:24 --> jb1 has joined #instantbird
21:40:28 <-- jb has quit (Connection reset by peer)
21:40:33 <Mic> One must not change "*" CSS rules on something like an hbox :D
21:40:41 --> Rym has joined #instantbird
21:42:37 <Mic> Maybe we need to wrap the descriptions and the buttons in an extra hbox and style the bottom border.
21:42:59 <Mic> I'll need to think about this a bit more (as I currently don't undestand why it's done the way it is).
21:43:43 <Mic> That won't block you from working on the buttons by the way.
21:44:23 <Mic> You can still make sure the menu works on the target switcher and that it is updated properly when the target changes.
21:44:50 <mayanktg> Mic: Yes. The problem seems to be here https://mxr.mozilla.org/comm-central/source/im/themes/conversation.css#160 We should not touch it. rather wrap it as you have mentioned 
21:45:05 <mayanktg> Ok
21:46:10 <Mic> Well need to touch that if we wrap it with another element... to remove the border on the desciption and the then-unnecessary margin.
21:46:15 <Mic> *We'll
21:47:19 --> CaptainCalliope has joined #instantbird
21:47:42 <Mic> Good night!
21:47:58 <mayanktg> Mic: Good night :)
21:48:12 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
21:51:04 <-- nhnt11 has quit (Ping timeout)
21:52:15 --> nhnt11 has joined #instantbird
22:05:00 <-- gerard-majax_ has quit (Ping timeout)
22:12:52 <-- jb1 has quit (Ping timeout)
22:18:56 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:20:14 <-- nhnt11 has quit (Ping timeout)
22:21:30 --> nhnt11 has joined #instantbird
22:22:49 <-- sonny has quit (Ping timeout)
22:28:27 --> sonny has joined #instantbird
22:42:28 <-- nhnt11 has quit (Ping timeout)
22:43:26 --> nhnt11 has joined #instantbird
22:45:10 <-- nhnt11 has quit (Ping timeout)
22:46:49 --> nhnt11 has joined #instantbird
22:48:51 <-- CaptainCalliope has quit (Quit: CaptainCalliope)
22:54:02 <-- nhnt11 has quit (Ping timeout)
22:57:02 --> wnayes has joined #instantbird
23:01:37 --> nhnt11 has joined #instantbird
23:03:14 --> mpmc has joined #instantbird
23:14:04 --> clokep has joined #instantbird
23:14:04 * ChanServ sets mode +o clokep 
23:17:12 <-- nhnt11 has quit (Ping timeout)
23:20:26 --> nhnt11 has joined #instantbird
23:22:54 <clokep> flo-retina: How do we expect file link to show upload progress?
23:23:00 <-- nhnt11 has quit (Ping timeout)
23:23:16 <flo-retina> I don't think that's fully decided yet
23:23:30 <flo-retina> but one idea is to use the download panel for uploads too
23:23:35 <flo-retina> I think that button contains a progress bar
23:24:32 --> nhnt11 has joined #instantbird
23:25:07 <clokep> Hm...OK. Would it be reasonable to land something w/o that feature first?
23:25:11 <clokep> I'm afriad of the patch getting HUGE!
23:25:20 <clokep> (Land it, but disabled behind a pref.)
23:25:28 <flo-retina> heh, you read my mind
23:25:38 <flo-retina> I was going to type "as long as it's pref'ed off, sure"
23:25:52 <clokep> :) OK.
23:26:04 <clokep> I'm trying to scope the work that sawrubh needs to do a bit and would prefer to land earlier, rather than later.
23:26:15 <flo-retina> I'm not sure it's reasonable to land the whole thing in chat/ as a copy of the current mail/ stuff though
23:26:29 <flo-retina> what was your plan for that?
23:30:30 <clokep> What do you mean? :-S
23:30:34 <clokep> It's not a copy.
23:30:58 <-- sonny has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
23:31:16 <flo-retina> so are you thinking of getting r+ (from m conley?) on a patch moving all these files to chat, before we even use them?
23:31:48 <clokep> Well, we would be using them, but it'd be preffed off?
23:32:04 <clokep> My plan is to move the files, ensure it still works in TB, land very basic UI preffed off.
23:35:36 <clokep> (And yes, I'd get an r+ from mconley.)
23:36:40 <-- nhnt11 has quit (Ping timeout)
23:38:28 --> nhnt11 has joined #instantbird