#instantbird log on 05 26 2014

All times are UTC.

00:43:46 --> wnayes has joined #instantbird
01:11:22 <-- nhnt11 has quit (Ping timeout)
01:12:33 --> nhnt11 has joined #instantbird
01:31:41 --> mconley has joined #instantbird
01:38:34 <-- nhnt11 has quit (Ping timeout)
01:40:21 --> nhnt11 has joined #instantbird
01:40:41 <-- mconley has quit (Ping timeout)
01:49:06 <-- nhnt11 has quit (Ping timeout)
01:50:16 --> nhnt11 has joined #instantbird
01:53:58 --> mconley has joined #instantbird
02:04:00 <-- mconley has quit (Ping timeout)
02:34:08 --> mconley has joined #instantbird
02:43:52 <-- wnayes has quit (Ping timeout)
02:44:10 --> wnayes has joined #instantbird
03:05:20 <-- nhnt11 has quit (Ping timeout)
03:06:43 --> nhnt11 has joined #instantbird
03:20:32 <-- mconley has quit (Quit: NO CARRIER)
04:35:24 <-- Rym has quit (Ping timeout)
04:43:41 <-- wnayes has quit (Ping timeout)
04:43:59 --> wnayes has joined #instantbird
04:48:52 <-- nhnt11 has quit (Ping timeout)
04:49:18 --> nhnt11 has joined #instantbird
05:04:50 --> jb has joined #instantbird
05:26:18 <-- EionRobb has quit (Quit: Leaving.)
05:30:16 <-- wnayes has quit (Quit: wnayes)
05:31:33 --> Armada has joined #instantbird
05:38:25 <-- jb has quit (Ping timeout)
05:38:41 --> jb has joined #instantbird
05:48:16 --> Even has joined #instantbird
05:48:16 * ChanServ sets mode +o Even 
05:57:12 <-- jb has quit (Ping timeout)
06:14:15 --> CaptainCalliope has joined #instantbird
06:18:49 --> EionRobb has joined #instantbird
06:18:50 <-- CaptainCalliope has quit (Quit: CaptainCalliope)
07:00:40 --> mayanktg has joined #instantbird
07:02:17 <-- nhnt11 has quit (Ping timeout)
07:03:54 --> nhnt11 has joined #instantbird
07:11:29 <-- gerard-majax_ has quit (Ping timeout)
07:25:32 <-- nhnt11 has quit (Ping timeout)
07:26:37 --> mpmc has joined #instantbird
07:26:58 --> nhnt11 has joined #instantbird
07:29:09 --> Mic has joined #instantbird
07:29:09 * ChanServ sets mode +o Mic 
07:29:37 <-- nhnt11 has quit (Ping timeout)
07:48:50 <mayanktg> Mic: Hello. sorry I was asleep yesterday. I'm able to add buttons near the target switcher for that generic Icon bug. Now going to start using <children/> :)
07:49:43 <Mic> OK, aleth description did help to understand what the children tag is for?
07:49:48 <Mic> *is there for?
07:50:29 <mayanktg> yes it did :) I also went through http://www.w3.org/TR/2001/NOTE-xbl-20010223/#anonymous-children-tags 
07:51:03 <mayanktg> Mic: Are you sure the Ubuntu has all additional graphic drivers installed? The best trick I use for my Ubuntu is to install /root and /home on two separate drives.
07:51:50 <mayanktg> *drive partition I mean.
07:52:57 <Mic> The graphic on the w3 page is summing it up nicely :)
07:53:24 <mayanktg> nhnt11 referred me this link
07:54:34 --> sonny has joined #instantbird
08:07:59 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
08:24:53 --> jb has joined #instantbird
08:25:04 --> chrisccoulson has joined #instantbird
08:35:16 <-- sonny has quit (Ping timeout)
08:50:10 --> Mic|web has joined #instantbird
08:58:32 --> sonny has joined #instantbird
09:11:33 --> BWMerlin has joined #instantbird
09:15:48 --> nhnt11 has joined #instantbird
09:21:18 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:44:16 <-- nhnt11 has quit (Ping timeout)
09:45:09 --> nhnt11 has joined #instantbird
09:51:44 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
09:56:27 --> gerard-majax_ has joined #instantbird
09:59:26 --> flo-retina has joined #instantbird
09:59:26 * ChanServ sets mode +qo flo-retina flo-retina 
10:00:05 <flo-retina> Hello :)
10:01:14 <-- Even has quit (Ping timeout)
10:01:32 --> Even has joined #instantbird
10:01:32 * ChanServ sets mode +o Even 
10:01:57 <-- Armada has quit (Connection reset by peer)
10:07:49 <nhnt11> Hi
10:14:16 <-- flo-retina has quit (Input/output error)
10:14:23 --> flo-retina has joined #instantbird
10:14:23 * ChanServ sets mode +qo flo-retina flo-retina 
10:14:45 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:14:51 --> nhnt11 has joined #instantbird
10:33:34 <-- chrisccoulson has quit (Ping timeout)
10:35:29 <-- EionRobb has quit (Quit: Leaving.)
10:53:37 --> Mic|mobile has joined #instantbird
10:54:14 <Mic|mobile> Mayanktg: have you tried wirh differently sized video streams?
10:55:44 <Mic|mobile> I got an error when trying to take an image and the line number was that of the drawImage call
10:55:57 <Mic|mobile> Blist:642, iirc?
10:56:57 <-- Mic|mobile has quit (Connection reset by peer)
10:57:05 --> Mic|mobile has joined #instantbird
10:58:52 <-- Mic|mobile has quit (Ping timeout)
11:03:40 --> mayanktg has joined #instantbird
11:04:47 <-- jb has quit (Ping timeout)
11:05:42 <mayanktg> Mic: What was the error?
11:06:38 <mayanktg> Mic: The camera used 640X480 video stream and we fixed the height and width of video stream to 213X160
11:08:08 <mayanktg> Mic: I never got an error for incorrectly using drawImage() . was the video stream in panel-2 streaming properly?
11:10:42 <flo-retina> mayanktg: are you still waiting for an answer on "The webcamSuccesscallback isn't called until we click on "Take Picture..." button. Why do we need to check then?" or has someone else answered for me?
11:11:41 <mayanktg> flo-retina: aleth told mein how to check for the "state" of the panel and I implemented it in the patch. 
11:11:58 <mayanktg> But I would like to know why we should check for the panel?
11:13:08 <flo-retina> mayanktg: I see you filed bug 1015678 as UNCONFIRMED. I think this should have been NEW, so I just gave you the additional bugzilla permissions to be able to do it; use these new powers wisely :).
11:13:13 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1015678 nor, --, ---, nobody, UNCO, Make  user icon handling in chat/ be asynchronous with OS.File
11:13:37 <mayanktg> doesn't onpopuphiding() already closes the stream?
11:14:52 <-- sonny has quit (Ping timeout)
11:15:25 <flo-retina> mayanktg: the case I was concerned about is: 1. gUM is requested. 2. Several seconds later the video still isn't there (some webcams can take several seconds to start) and the user, loosing patience, clicks elsewhere which cause the panel to close. 3. gUM finally succeeds, but the panel is already closed.
11:15:31 <flo-retina> mayanktg: was this case already covered?
11:17:13 <mayanktg> flo-retina: There would have been two poosilibilities. 1. User Clicks the "back" button...stream closes 2. Uses closes the panel by clicking somewhere else in the rest of the screen...onpopuphiding is activated...stream closes 
11:17:43 <flo-retina> mayanktg: The stream doesn't exist yet when onpopuphiding is called
11:18:03 <mayanktg> flo-retina++ 
11:18:12 <mayanktg> Wait...
11:18:49 <mayanktg> We check for stream availability in stopWebcamStream()
11:19:18 <mayanktg> flo-retina: But we'll have to add the same in case of capturebackButton too
11:20:50 <flo-retina> ah, do you mean checking that the panel is open isn't enough; we should also check that the deck is still showing the video element?
11:22:26 --> aleth has joined #instantbird
11:22:26 * ChanServ sets mode +o aleth 
11:23:42 <mayanktg> flo-retina: No checking the panel should be enough. Is the method I used in the updated patch correct ?
11:24:08 <flo-retina> I haven't reviewed the new patch yet
11:24:24 <flo-retina> so what did you mean by "we'll have to add the same in case of capturebackButton too"?
11:25:58 <mayanktg> when a user clicks "back" button..the state of the panel is still open..but we would be supposed to close the video stream right?
11:26:19 * Fallen|away is now known as Fallen
11:27:11 <flo-retina> Yes
11:27:46 <flo-retina> and when gUM succeeds _after_ a user has clicked the "back" button, we should cancel the stream too, like if the panel is closed, right?
11:27:52 --> jb has joined #instantbird
11:29:16 <mayanktg> exactly. So we should add a check just like we did in onpopuphiding method "stopWebcamStream()" which would stop the stream and initialize it to null
11:29:44 <aleth> nhnt11: This http://log.bezut.info/instantbird/140525/#m144 is why I asked that http://log.bezut.info/instantbird/140525/#m101 ;)
11:30:32 <nhnt11> aleth, flo-retina: So my current plan is to have a map of conversations to their logMessagePromises in logger.js
11:30:56 <nhnt11> That way the reading and writing code can communicate
11:31:03 <flo-retina> Isn't there already a map of conversations to their current log object?
11:31:05 <aleth> You mean, to the object whose property logmessagepromise is?
11:31:20 <nhnt11> flo-retina: There is? /me checks
11:31:25 <flo-retina> I'm not sure
11:31:32 * nhnt11 keeps getting lost in this code :(
11:31:33 <flo-retina> but if not, feel free to add one :)
11:31:38 <flo-retina> it's messy!
11:31:45 --> chrisccoulson has joined #instantbird
11:31:46 <flo-retina> that's why we asked you to clean it up
11:31:48 <aleth> I don't see what mapping to the Promise would help.
11:32:09 <aleth> +1 for cleaning it up ;)
11:32:11 <nhnt11> aleth: When trying to read a conversation's log, look up its promise and read it in then()
11:32:17 <nhnt11> Then the next write will happen after the read
11:32:35 <aleth> nhnt11: What about having an object per log that can read and write?
11:32:39 <nhnt11> (logMessagePromise = logMessagePromise.then(read))
11:32:50 --> sonny has joined #instantbird
11:32:58 <aleth> It seems asking for trouble to have two objects which use the same promise chain.
11:33:09 <nhnt11> aleth: Why?
11:33:16 * nhnt11 thinks it's clever and would work well
11:34:13 <aleth> Why spread out the code like that? You then have a private property that is actually not private.
11:35:01 <nhnt11> aleth: So stop keeping it private?
11:35:17 <aleth> Maybe I'm not understanding completely what you envisage.
11:35:19 <nhnt11> Bah, this will involve a lot more rewriting though
11:35:56 <aleth> It seems to me that if you are keeping a map conv -> promises you can just as well keep a map conv -> object that deals with a particular file.
11:36:25 <nhnt11> aleth: In that case, a single object would do the reading and the writing
11:36:35 <nhnt11> (that works, just different from what I was thinking)
11:36:48 <aleth> Right. I'm asking /why/ you didn't want to do it that way
11:37:53 * nhnt11 isn't against it
11:38:07 <nhnt11> Just that doing what I said involves less rewriting.. :]
11:38:57 <aleth> I'm not against your idea necessarily if it makes for cleaner code.
11:39:06 <aleth> Before you add code for reading, it's probably good to make sure the writing code has tests, the file gets closed on inactivity, and the error handling works.
11:39:31 <aleth> I'd also like you to be certain the async shutdown stuff is taken care of automatically (you can ping Yoric and ask)
11:40:20 <nhnt11> aleth: I already started with the async reading :-/
11:40:27 * Fallen is now known as Fallen|away
11:40:33 <aleth> nhnt11: ok then :)
11:40:53 <nhnt11> Bah :(
11:40:55 <aleth> The order doesn't matter as much as getting it done
11:42:19 <aleth> For async reading, what's your API going to look like? Just return promises where currently we return logs?
11:42:33 --> Mic|mobile has joined #instantbird
11:42:44 <nhnt11> aleth: Yeah.
11:42:53 <nhnt11> Consumers wait for them to resolve and then consume.
11:43:22 <Mic|mobile> Mayanktg, the error was somerhing saying about "too large or negative value".
11:43:59 <Mic|mobile> Can you set the video of your webcam to other values abd see if ut works?
11:44:06 <aleth> One reason I thought you might bring up for having two different objects is that it's possible the API consumers act differently for reading than for writing. Ie reading is a discrete thing (request logs and get it) whereas the writing object will exist as long as the prplconv does
11:44:34 <Mic|mobile> E.g. 320x240 or an HD video stream just to name some?
11:44:42 <mayanktg> Mic|mobile: Yes Let me try to set webcam to resolution other than 630X480
11:44:47 <mayanktg> Yes.
11:44:50 <flo-retina> mayanktg: I sent you more comments on the new patch, but I didn't do a full review. I have only read the code in the new patch; not tried to think about what could go wrong.
11:45:21 <Mic|mobile> Thanks!
11:45:33 <Mic|mobile> Gtg again
11:45:40 <-- Mic|mobile has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
11:47:22 <nhnt11> aleth: Good point :]
11:48:09 <nhnt11> flo-retina: So there is indeed a gConversationLogs object that could be used.
11:48:18 <flo-retina> nhnt11: "doing what I said involves less rewriting.." that doesn't really matter, especially at the beginning of the project. Please optimize for future readability at this point :)
11:48:40 <nhnt11> Okay!
11:49:18 <-- aleth has quit (Ping timeout)
11:49:41 * flo-retina wonders if we would want to tweak the imILog interface, and add another imIWritableLog interface that inherits from imILog
11:49:45 <flo-retina> (just a thought)
11:50:01 <nhnt11> flo-retina: So one improvement for readability that I think we should do is move some functions like convIsRealMUC and getDateFromFilename to a loggerUtils.jsm file or something
11:50:33 <flo-retina> are they used elsewhere?
11:51:28 <nhnt11> No. Do we only use *Utils files for stuff that is used in multiple places?
11:51:59 <nhnt11> Er, s/No./No afaik./
11:52:11 <flo-retina> yes
11:52:55 <flo-retina> creating more .jsm files means more compartments (ie. wasted memory) and more cross compartment wrappers (wasted memory + slightly slower)
11:53:11 <-- sonny has quit (Ping timeout)
11:53:16 <nhnt11> Hmm okay.
12:01:30 --> aleth has joined #instantbird
12:01:30 * ChanServ sets mode +o aleth 
12:05:07 --> sonny has joined #instantbird
12:07:19 <aleth> nhnt11: You'll definitely want to reorder/rename stuff in logger.js to make it less messy, at the very least
12:10:47 <-- aleth has quit (Ping timeout)
12:11:26 <-- nhnt11 has quit (Ping timeout)
12:12:19 --> nhnt11 has joined #instantbird
12:12:51 --> aleth has joined #instantbird
12:12:51 * ChanServ sets mode +o aleth 
12:13:53 <-- jb has quit (Quit: jb)
12:15:01 --> jb has joined #instantbird
12:15:35 --> clokep has joined #instantbird
12:15:36 * ChanServ sets mode +o clokep 
12:15:48 <-- clokep has quit (Input/output error)
12:15:53 --> clokep has joined #instantbird
12:15:54 * ChanServ sets mode +o clokep 
12:16:50 <-- nhnt11 has quit (Ping timeout)
12:17:43 --> nhnt11 has joined #instantbird
12:20:35 <-- nhnt11 has quit (Ping timeout)
12:20:39 --> nhnt11 has joined #instantbird
12:22:50 <-- sonny has quit (Ping timeout)
12:24:12 <-- nhnt11 has quit (Ping timeout)
12:25:01 --> nhnt11 has joined #instantbird
12:26:50 <-- nhnt11 has quit (Ping timeout)
12:36:35 --> sonny has joined #instantbird
12:38:21 <-- BWMerlin has quit (Quit: BWMerlin)
12:49:33 <-- sonny has quit (Ping timeout)
12:50:34 <-- clokep has quit (Ping timeout)
12:51:25 <-- flo-retina has quit (Ping timeout)
12:52:09 --> flo-retina has joined #instantbird
12:52:09 * ChanServ sets mode +qo flo-retina flo-retina 
12:52:45 --> nhnt11 has joined #instantbird
12:53:14 <nhnt11> My broadband died on me :-/
12:53:27 <nhnt11> I'm on 3g, not sure how stable it is.
12:56:45 --> sonny has joined #instantbird
12:58:17 <-- nhnt11 has quit (Ping timeout)
12:59:11 --> nhnt11 has joined #instantbird
13:01:53 <-- nhnt11 has quit (Ping timeout)
13:06:32 --> nhnt11 has joined #instantbird
13:06:46 <-- flo-retina has quit (Ping timeout)
13:12:21 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
13:16:09 <-- nhnt11 has quit (Ping timeout)
13:18:37 --> nhnt11 has joined #instantbird
13:20:17 <-- aleth has quit (Ping timeout)
13:21:45 <mayanktg> Mic: Hi. I tried changing the webcam resolution to 320X240 and other. But there was no error thrown as you mentioned :(
13:22:11 --> aleth has joined #instantbird
13:22:11 * ChanServ sets mode +o aleth 
13:22:24 <mayanktg> Just to be sure ...the changes in contrast, brightness etc for the webcam did get reflected in the video stream at the panel.
13:23:24 --> flo-retina has joined #instantbird
13:23:24 * ChanServ sets mode +qo flo-retina flo-retina 
13:33:44 <nhnt11> flo-retina: In this function -  https://mxr.mozilla.org/comm-central/source/chat/components/src/logger.js#292 - do we have to wait for close() to finish before replacing gSystemLogs[id] with a new SystemLog?
13:34:32 * nhnt11 thinks not.. the object will be gc'd after close() comletes, no?
13:37:51 <flo-retina> if you called the file's close method, I think you can let OS.File deal with it without worrying about gc
13:39:32 <nhnt11> Alright
13:39:37 <nhnt11> I'm worried about the SystemLog instance, not the OS.File instance..
13:41:01 --> mconley has joined #instantbird
13:49:06 <aleth> Worried about what in particular?
13:52:21 <nhnt11> aleth: about leaking it
13:52:37 <-- sonny has quit (Ping timeout)
13:53:09 <aleth> I don't think there is anything that will retain a reference to it
13:53:29 <nhnt11> yeah alright
13:53:35 <nhnt11> brb
13:54:46 <-- nhnt11 has quit (Connection reset by peer)
13:55:07 --> nhnt11 has joined #instantbird
14:01:53 --> iamjayakumars has joined #instantbird
14:16:53 <-- nhnt11 has quit (Ping timeout)
14:23:17 --> nhnt11 has joined #instantbird
14:23:56 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:24:08 --> nhnt11 has joined #instantbird
14:27:11 <-- nhnt11 has quit (Ping timeout)
14:29:17 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:31:15 --> sonny has joined #instantbird
14:32:03 --> nhnt11-phone has joined #instantbird
14:32:10 --> nhnt11 has joined #instantbird
14:46:34 --> wnayes has joined #instantbird
14:54:58 <nhnt11> flo-retina: Are you following the conversation on #perf by any chance?
14:55:06 <flo-retina> no
14:55:23 <flo-retina> but I can get the awesome tab to open it for me ;)
14:55:33 <nhnt11> flo-retina: Interesting question there: "when the app crashes, how many milliseconds of message history are you willing to lose"
14:58:21 <-- aleth has quit (Ping timeout)
14:58:53 --> aleth has joined #instantbird
14:58:53 * ChanServ sets mode +o aleth 
15:01:16 --> mayanktg has joined #instantbird
15:02:44 <-- sonny has quit (Ping timeout)
15:06:50 --> rosonline has joined #instantbird
15:06:55 <-- nhnt11 has quit (Ping timeout)
15:07:22 --> nhnt11 has joined #instantbird
15:09:52 --> sonny has joined #instantbird
15:11:16 <flo-retina> nhnt11: are you satisfied with the answer I gave to that question?
15:11:24 <nhnt11> flo-retina: Yes
15:12:09 <nhnt11> I think that "the current appending mechanism is acceptable within our limits of tolerance" is a good conclusion from the discussion
15:13:22 <-- sonny has quit (Ping timeout)
15:14:32 --> sonny has joined #instantbird
15:33:54 <-- aleth has quit (Ping timeout)
15:34:39 <-- nhnt11 has quit (Ping timeout)
15:35:19 --> nhnt11 has joined #instantbird
15:44:15 <-- nhnt11-phone has quit (Ping timeout)
15:49:27 --> clokep has joined #instantbird
15:49:27 * ChanServ sets mode +o clokep 
15:51:11 <-- clokep has quit (Ping timeout)
15:55:36 <-- nhnt11 has quit (Ping timeout)
15:56:35 --> nhnt11 has joined #instantbird
16:00:06 <-- gerard-majax_ has quit (Ping timeout)
16:02:24 <-- iamjayakumars has quit (Client exited)
16:12:43 <-- nhnt11 has quit (Ping timeout)
16:13:30 --> nhnt11 has joined #instantbird
16:14:37 <-- wnayes has quit (Ping timeout)
16:14:58 --> wnayes has joined #instantbird
16:16:56 <-- nhnt11 has quit (Ping timeout)
16:18:20 --> nhnt11 has joined #instantbird
16:20:05 <-- nhnt11 has quit (Ping timeout)
16:21:07 --> nhnt11 has joined #instantbird
16:22:47 <-- nhnt11 has quit (Ping timeout)
16:25:40 --> nhnt11 has joined #instantbird
16:41:34 <-- nhnt11 has quit (Ping timeout)
16:43:22 --> nhnt11 has joined #instantbird
16:45:02 <-- nhnt11 has quit (Ping timeout)
16:51:46 --> nhnt11 has joined #instantbird
16:54:22 <-- nhnt11 has quit (Ping timeout)
16:55:11 --> nhnt11 has joined #instantbird
17:05:46 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:20:12 <-- mayanktg has quit (Ping timeout)
17:22:37 --> mayanktg has joined #instantbird
17:22:43 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:33:28 <-- jb has quit (Ping timeout)
17:35:38 --> gerard-majax_ has joined #instantbird
17:44:17 <-- gerard-majax_ has quit (Ping timeout)
17:47:45 * mconley is now known as mconley|food
17:49:32 <-- sonny has quit (Ping timeout)
17:54:52 --> iamjayakumars has joined #instantbird
17:54:55 <-- iamjayakumars has quit (Client exited)
17:58:23 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
18:04:23 <-- nhnt11 has quit (Ping timeout)
18:05:14 --> nhnt11 has joined #instantbird
18:10:28 <-- nhnt11 has quit (Ping timeout)
18:11:26 --> nhnt11 has joined #instantbird
18:14:09 <-- wnayes has quit (Ping timeout)
18:14:27 --> wnayes has joined #instantbird
18:20:02 --> Rym has joined #instantbird
18:23:24 <-- nhnt11 has quit (Ping timeout)
18:23:56 --> Armada has joined #instantbird
18:24:23 --> nhnt11 has joined #instantbird
18:29:34 <-- Armada has quit (Ping timeout)
18:34:11 --> flo-retina has joined #instantbird
18:34:11 * ChanServ sets mode +qo flo-retina flo-retina 
18:35:03 <flo-retina> mayanktg: have you updated the patch?
18:36:19 <mayanktg> Mic: I was waiting cos Mic had some error running the patch ..
18:36:27 <mayanktg> I'm done with the changes you mentioned
18:37:47 <mayanktg> *flo-retina ^
18:38:01 <mayanktg> I'm updating it with the latest patch.
18:44:40 <flo-retina> ok, thanks
18:44:45 <flo-retina> will try to have a look later today
18:47:00 <flo-retina> mayanktg: have you made progress about the icons in the conversations?
18:48:45 --> gerard-majax_ has joined #instantbird
18:50:40 <mayanktg> flo-retina: Updated with the changes. :)
18:51:34 <flo-retina> what do you mean by "I tried using this way. I guess we have to "return OS"."?
18:52:35 <mayanktg> sorry. I meant the way I have used in the patch seems correct.
18:52:55 <mayanktg> XPCOMUtils.defineLazyGetter(this, "OS", function() {
18:52:55 <mayanktg>   Cu.import("resource://gre/modules/osfile.jsm");
18:52:55 <mayanktg>   return OS;
18:52:55 <mayanktg> });
18:53:04 <flo-retina> that's longer than what I suggested, right?
18:53:25 <flo-retina> I showed a way to do the same thing with a single line
18:53:38 <mayanktg> Yes. But when I tried your method. There was an error in the console. Let me reproduce that.
18:56:02 <nhnt11> flo-retina: Update on what I'm doing: currently working on these LogEnumerators, replacing directoryEntries and stuff with OS.File equivalents.
18:56:14 <flo-retina> mayanktg: I still see plenty of lines containing "inkscape" or "sodipodi" in the svg file
18:56:28 <flo-retina> nhnt11: ok :)
18:56:43 * flo-retina wonders what sawrubh is doing today
18:56:50 <mayanktg> flo-retina: sorry :( Its working fine. I'll update that. 
18:57:17 <nhnt11> flo-retina: Sorry this has been slow work, btw... everything is interconnected and I keep having to reread stuff. I don't think I can get you a review-ready patch tonight..
18:57:40 <mayanktg> flo-retina: upon removing the lines containing sodipodi and inksscape the svg file didn't display 
18:58:15 <flo-retina> mayanktg: that's surprising
18:59:06 <-- nhnt11 has quit (No route to host)
18:59:11 <mayanktg> Yes. Upon removing any of the xmlsns lines containing sodipodi and inkscape,
18:59:23 <mayanktg> *xmlns
19:00:42 <mayanktg> flo-retina: Though we can still clip off many of the useless contents still present there. 
19:00:51 --> nhnt11 has joined #instantbird
19:00:52 <mayanktg> I'll update the patch again.
19:01:03 <flo-retina> I'm trying to reduce that file right now
19:02:33 <mayanktg> flo-retina: http://pastebin.instantbird.com/718090
19:02:46 <mayanktg> I've reduced it until this point.
19:03:05 <flo-retina> I'm down to http://pastebin.instantbird.com/718091 already
19:05:50 <flo-retina> mayanktg: http://pastebin.instantbird.com/718092
19:05:55 * mconley|food is now known as mconley
19:08:06 --> Armada has joined #instantbird
19:11:16 <-- nhnt11 has quit (Ping timeout)
19:14:04 --> nhnt11 has joined #instantbird
19:17:46 <mayanktg> flo-retina: thanks.
19:19:58 <-- nhnt11 has quit (Ping timeout)
19:21:36 --> nhnt11 has joined #instantbird
19:23:26 <-- nhnt11 has quit (Ping timeout)
19:24:44 --> nhnt11 has joined #instantbird
19:26:26 <-- nhnt11 has quit (Ping timeout)
19:27:10 <-- Rym has quit (Ping timeout)
19:27:25 --> nhnt11 has joined #instantbird
19:28:34 --> Rym has joined #instantbird
19:30:51 <nhnt11> Ahhh
19:32:41 <-- nhnt11 has quit (Ping timeout)
19:34:59 --> nhnt11 has joined #instantbird
19:35:05 * nhnt11 just typed out some stuff that didn't get sent, but now I understand so I guess it's no longer relevant
19:37:16 * nhnt11 was basically super confused because each element in an array of directoryEntries was being referred to as an "entry"
19:38:07 <nhnt11> And each "entry" was treated as an enumerator, and so I was trying to figure out if recursive directory traversal was going on
19:38:15 <-- Rym has quit (Ping timeout)
19:39:45 --> Armada651 has joined #instantbird
19:39:45 <-- Armada has quit (Connection reset by peer)
19:39:49 <-- Armada651 has quit (Quit: Armada651)
19:39:53 --> Armada has joined #instantbird
19:48:38 <-- nhnt11 has quit (Ping timeout)
19:59:15 --> nhnt11 has joined #instantbird
20:00:10 <-- mayanktg has quit (Ping timeout)
20:07:19 * nhnt11 may be done with the logger.js changes... :D
20:07:38 <nhnt11> (minus testing, since I need to adapt consumers for promises..)
20:09:47 <-- Mook_as has quit (Input/output error)
20:10:17 <nhnt11> flo-retina: thunderbird has its own log viewer right?
20:10:31 <nhnt11> I'm trying to find it in mail/base/content
20:11:08 <nhnt11> meh, i'll start with Ib for now..
20:11:56 --> jb has joined #instantbird
20:14:22 <-- wnayes has quit (Ping timeout)
20:14:36 --> wnayes has joined #instantbird
20:17:24 <flo-retina> nhnt11: look in mail/components/im/
20:17:41 <nhnt11> flo-retina: thanks
20:18:30 --> sonny has joined #instantbird
20:18:46 --> Mook_as has joined #instantbird
20:18:52 <nhnt11> flo-retina: I don't see anything related to logging there?
20:19:42 * nhnt11 does an mx
20:19:43 <nhnt11> mxr
20:21:36 <nhnt11> Ah, it's in the chat-messenger-overlay code 
20:23:18 --> EionRobb has joined #instantbird
20:31:44 --> igorko has joined #instantbird
20:36:00 <-- sonny has quit (Ping timeout)
20:38:31 <nhnt11> flo-retina: I'll upload what I've got right now on the bug. It's untested and probably requires some clean up but maybe you could give me some general feedback
20:38:45 <nhnt11> It's not the easiest patch to review though..
20:39:51 --> Armada651 has joined #instantbird
20:39:52 <-- Armada has quit (Connection reset by peer)
20:52:40 <flo-retina> ok, I'll try and have a look either tonight or tomorrow morning (more likely)
20:55:42 --> sonny has joined #instantbird
20:59:52 <nhnt11> That patch probably needs cleaning up for consistency (among other things), fyi. For e.g. I may have used Task.spawn in some places and not in some other places.
21:01:19 <-- sonny has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:06:52 <-- igorko has quit (Ping timeout)
21:07:13 --> igorko has joined #instantbird
21:13:13 <-- igorko has quit (Ping timeout)
21:13:44 --> igorko has joined #instantbird
21:14:11 <-- igorko has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
21:18:57 <-- nhnt11 has quit (Ping timeout)
21:25:52 --> nhnt11 has joined #instantbird
21:28:05 <-- gerard-majax_ has quit (Ping timeout)
21:28:32 <-- nhnt11 has quit (Ping timeout)
21:29:44 --> Rym has joined #instantbird
21:29:48 --> nhnt11 has joined #instantbird
21:31:31 <-- nhnt11 has quit (Ping timeout)
21:38:51 --> nhnt11 has joined #instantbird
21:40:02 --> Armada_ has joined #instantbird
21:40:03 <-- Armada651 has quit (Connection reset by peer)
21:54:54 <-- jb has quit (Ping timeout)
22:14:17 <-- wnayes has quit (Ping timeout)
22:14:30 --> wnayes has joined #instantbird
22:40:08 --> Armada651 has joined #instantbird
22:40:08 <-- Armada_ has quit (Connection reset by peer)
22:46:58 <-- mconley has quit (Input/output error)
22:49:23 --> rosonline has joined #instantbird
23:17:22 --> mconley has joined #instantbird
23:23:33 <-- mconley has quit (Ping timeout)
23:24:57 --> iamjayakumars has joined #instantbird
23:40:17 --> Armada_ has joined #instantbird
23:40:18 <-- Armada651 has quit (Connection reset by peer)