#instantbird log on 05 25 2014

All times are UTC.

00:06:56 <-- Suiseiseki has quit (Quit: Leaving)
00:07:30 <-- jb has quit (Ping timeout)
00:08:51 --> Suiseiseki has joined #instantbird
00:28:58 <mayanktg> flo-retina: Here's the complete diff until now http://pastebin.instantbird.com/716026 
00:46:51 --> Rym has joined #instantbird
01:06:23 <-- EionRobb has quit (Quit: Leaving.)
01:06:53 --> EionRobb has joined #instantbird
01:14:10 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
02:14:16 <-- nhnt11 has quit (Connection reset by peer)
02:17:02 --> nhnt11 has joined #instantbird
02:32:20 <-- Rym has quit (Ping timeout)
02:36:15 --> Rym has joined #instantbird
02:43:52 --> iamjayakumars has joined #instantbird
02:50:16 <-- iamjayakumars has quit (Client exited)
02:58:32 --> iamjayakumars has joined #instantbird
03:07:24 <-- wnayes has quit (Quit: wnayes)
03:09:28 <-- iamjayakumars has quit (Client exited)
03:56:32 --> iamjayakumars has joined #instantbird
03:59:12 <-- iamjayakumars has quit (Client exited)
04:04:02 --> mpmc has joined #instantbird
04:06:23 --> iamjayakumars has joined #instantbird
04:07:47 <-- iamjayakumars has quit (Client exited)
04:19:41 --> iamjayakumars has joined #instantbird
04:37:50 <-- iamjayakumars has quit (Client exited)
04:40:48 --> iamjayakumars has joined #instantbird
04:54:41 <-- iamjayakumars has quit (Client exited)
05:06:00 <-- Rym has quit (Ping timeout)
05:51:45 --> iamjayakumars has joined #instantbird
06:15:57 <-- iamjayakumars has quit (Client exited)
06:30:58 --> iamjayakumars has joined #instantbird
06:51:51 <-- iamjayakumars has quit (Quit: )
07:03:01 --> mayanktg has joined #instantbird
07:39:15 --> igorko has joined #instantbird
07:51:56 <-- igorko has quit (Client exited)
08:14:23 --> Even has joined #instantbird
08:14:23 * ChanServ sets mode +o Even 
08:31:11 --> iamjayakumars has joined #instantbird
08:51:27 <-- Even has quit (Input/output error)
08:59:01 <-- mayanktg has quit (Ping timeout)
09:13:10 --> Mic|mobile has joined #instantbird
09:17:57 --> mayanktg has joined #instantbird
09:27:46 <-- iamjayakumars has quit (Client exited)
09:30:40 <-- Mic|mobile has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
09:31:36 --> iamjayakumars has joined #instantbird
09:46:38 --> Mic|web has joined #instantbird
09:51:50 <-- iamjayakumars has quit (Client exited)
09:59:52 <Mic|web> :)
10:00:19 <Mic|web> mayanktg: I got my camera to work on Linux using getUserMedia, so I can actually test things now :)
10:04:21 --> Armada has joined #instantbird
10:05:00 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
10:24:03 <-- mayanktg has quit (Ping timeout)
10:27:59 --> mayanktg has joined #instantbird
11:41:07 <-- EionRobb has quit (Quit: Leaving.)
12:10:57 --> iamjayakumars has joined #instantbird
12:21:50 <-- BWMerlin has quit (Quit: BWMerlin)
12:26:50 <mayanktg> Mic: Treat! ;) What was stopping gUM to run camera? :-o 
12:51:10 <-- iamjayakumars has quit (Quit: )
13:31:59 --> clokep has joined #instantbird
13:31:59 * ChanServ sets mode +o clokep 
13:32:28 <-- mayanktg has quit (Ping timeout)
13:36:04 --> mayanktg has joined #instantbird
13:52:30 --> chrisccoulson has joined #instantbird
14:00:06 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:16:54 <-- clokep has quit (Ping timeout)
14:35:18 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:53:20 <-- chrisccoulson has quit (Ping timeout)
14:53:23 --> chrisccoulson_ has joined #instantbird
14:53:38 --> gerard-majax_ has joined #instantbird
14:55:26 <-- chrisccoulson_ has quit (Ping timeout)
15:12:17 --> iamjayakumars has joined #instantbird
15:16:49 --> aleth has joined #instantbird
15:16:49 * ChanServ sets mode +o aleth 
15:27:49 <nhnt11> aleth: Can we discuss http://log.bezut.info/instantbird/140520/#m173?
15:29:20 <aleth> Sure
15:29:31 <nhnt11> I've been reading code and figuring out how log reading works with the goal of making a decision for that
15:29:35 <nhnt11> (whether to leave it for later or not)
15:29:35 <aleth> (I've not caught up with the logs though)
15:29:52 <nhnt11> aleth: Today's log is pretty empty I think :)
15:29:57 * nhnt11 hasn't said anything...
15:30:19 <aleth> Heh, true.
15:30:52 * nhnt11 wonders what flo-retina thinks about async log reading at this point.
15:31:02 <aleth> What do *you* think?
15:31:29 --> CaptainCalliope has joined #instantbird
15:31:49 <nhnt11> aleth: I think I could do it, but I want to read more code before deciding
15:32:07 <aleth> It's a good idea to look at the consumers of the interface too.
15:32:13 <nhnt11> (i.e. I want to make sure it won't require changes later, that would make anything I do now redundant)
15:32:19 <nhnt11> Yeah.
15:32:22 <aleth> I think you'll want to do it, the question is only timing.
15:32:45 <nhnt11> Right. The question i'm trying to answer is "now or later?"
15:32:55 <aleth> ie before or after indexing ;)
15:33:00 <nhnt11> Yeah
15:33:19 <aleth> I guess just keep it in mind as you finish the writing code. Still a few things to do there iirc
15:33:27 <-- Armada has quit (Connection reset by peer)
15:33:46 <nhnt11> Bah, I still haven't uploaded a patch in response to your review comments, guess I should do that first
15:34:00 <nhnt11> Regardless of async reading, async writing can probably land soon :)
15:34:22 <aleth> Btw if all your tests pass, try adding some syntax error inside Promise code to see if they still pass ;)
15:34:24 * nhnt11 already addressed most of the comments yesterday
15:34:27 <aleth> Cool.
15:34:36 <nhnt11> Yeah.
15:36:50 <aleth> Btw, (looking at the logs) When writing a test, I often add an intentional fail at the end so I can see the logging.
15:37:05 <nhnt11> That would work, thanks
15:38:35 <aleth> Re reading logs as well, is the same log object going to be used for reading and writing, or not?
15:52:33 --> mayanktg has joined #instantbird
16:00:54 <mayanktg> aleth: Thanks :) 
16:04:40 <mayanktg> aleth: Do you know how to check if a panel is closed? 
16:05:26 <aleth> I'm guessing... onpopuphiding? Look at the available events.
16:05:42 <aleth> Or attributes if you need the state.
16:06:32 <aleth> https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/panel#p-state
16:06:36 <aleth> mdn is your friend ;)
16:07:05 <mayanktg> ahaa!
16:09:56 <-- aleth has quit (Ping timeout)
16:10:45 --> aleth has joined #instantbird
16:10:45 * ChanServ sets mode +o aleth 
17:12:01 <aleth> mayanktg: Are you using OS.File only inside a single function in blist.js?
17:14:29 <mayanktg> aleth: I added osfile.jsm file before writing that function. I just cross checked. There's no other function using OS.File in blist.js 
17:14:44 <aleth> Then you can move the Cu.import("resource://gre/modules/osfile.jsm"); inside that function.
17:15:25 <aleth> That way it only gets included lazily when that function is called.
17:15:52 <mayanktg> Ok. I thought by lazy getter flo meant to use defineLazyGetter. Ok I'll do that :)
17:16:24 <aleth> Oh, you added a lazyGetter? I guess my tab contains an old version of your patch.
17:16:32 <aleth> But yeah, in this case inlining is easier.
17:16:48 <mayanktg> I just updated the Bug with new patch
17:17:27 <mayanktg> using lazyGetter too OS.File would be called only when function is used I guess.
17:17:50 <aleth> Yes, it would work, but as it's only used in one place you can do the simple thing ;)
17:20:20 <mayanktg> hehe..Take a look at the patch if you are free. I think its pretty much ready now ;)
17:20:49 <aleth> Generally to do something "lazily" just means to do it only at the last minute, when it's needed.
17:21:32 <aleth> mayanktg: Mic should give it another review, but it looks like it will land soon to me ;)
17:22:23 <mayanktg> Yeah I know..we use lazy getters in almost every prog languages. Yeah he fixed his Ubuntu :)
17:24:43 <mayanktg> Well I did search hard for understanding how to use defineLazyGetter :P
17:25:31 <aleth> Well done :) I am sure you will find other uses for it...
17:25:56 <aleth> All I meant was lazyGetters are not the only way to implement something lazily ;)
17:47:24 <-- aleth has quit (Ping timeout)
17:48:05 --> aleth has joined #instantbird
17:48:05 * ChanServ sets mode +o aleth 
18:07:56 <-- aleth has quit (Ping timeout)
18:08:14 --> aleth has joined #instantbird
18:08:15 * ChanServ sets mode +o aleth 
18:10:11 --> clokep_wp8 has joined #instantbird
18:10:42 <clokep_wp8> I'd prefer defineLazyGetter btw. Including code at the top is a lot easier.
18:10:59 <clokep_wp8> Just my 2¢. ;-)
18:11:01 <-- clokep_wp8 has quit (Connection reset by peer)
18:22:18 <-- aleth has quit (Ping timeout)
18:23:31 <-- iamjayakumars has quit (Quit: )
18:54:10 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:31:04 <-- Suiseiseki has quit (Ping timeout)
19:37:38 <flo-retina> "17:30:52 * nhnt11 wonders what flo-retina thinks about async log reading at this point." The reasons I mentioned it in my review comment is that I'm wondering what will happen if you attempt to read synchronously a file that you are currently writing asynchronously
19:38:00 <flo-retina> I was thinking that you probably need to convert the read to be async, and wait on the writing promise (if any)
19:38:46 <nhnt11> flo-retina: Hmm so you're worried we may drop a message or two?
19:38:51 --> Suiseiseki has joined #instantbird
19:39:00 <flo-retina> nhnt11: I'm worried about race conditions, yes
19:39:32 * nhnt11 gets it now
19:40:15 <nhnt11> At the very least we'll need to wait until _logMessagePromise resolves...
19:41:07 <flo-retina> btw, nhnt11, mayanktg and more generally anybody who may need review(s) from me: I'll be offline camping from Wednesday to Sunday. If you want a review from me next week, please ensure it reaches my queue on Monday.
19:41:32 <nhnt11> Okay!
19:42:10 <flo-retina> nhnt11: yeah, so if you wait for a promise to resolve before doing the read, you can as well do the read async with OS.File, as you have already broken the current sync API :)
19:42:42 <nhnt11> flo-retina: Do you think these race conditions could be dealt with in a follow-up? I don't think at this point that the solution would be very trivial... (i.e. I won't be able to do it tonight most likely)
19:42:44 * flo-retina wonders how much gloda pain will be cause by these changes
19:42:59 <nhnt11> Yeah, if we're doing one thing async, might as well do the whole thing async
19:42:59 <flo-retina> you can do it tomorrow
19:43:13 <nhnt11> Okay
19:43:15 <flo-retina> I think it will take you ~half a day to figure this out
19:43:52 <nhnt11> Sure. I'll start looking at it now.
19:43:56 <flo-retina> I also don't really see how you can write meaningful logging tests if you don't have reading code to check the content of the file you stored
19:44:21 <flo-retina> nhnt11: yeah, look around to see what the problem actually is, then sleep on it, and implement a solution tomorrow :)
20:16:14 --> EionRobb has joined #instantbird
20:26:59 <nhnt11> Hmm, interface changes
20:28:05 <nhnt11> Should be a simple change from |foo bar(in foo bar)| to |promise<foo> bar(in foo bar);| (I hope)
20:34:28 <nhnt11> Hmm, looks like what I want is jsval, not promise<foo> :S
20:40:03 <-- nhnt11 has quit (Input/output error)
20:40:31 --> nhnt11 has joined #instantbird
20:41:11 <flo-retina> I don't really know how one returns a promise through xpidl
20:41:37 <flo-retina> I remember this has been discussed on #maildev relatively recently, but I don't remember the conclusion of the discussion
20:41:47 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:45:24 <nhnt11> flo-retina: Searching on mxr, as well as the last post here - http://codeverge.com/mozilla.dev.platform/xpidl-promises/1144252 - suggest that I should just use "jsval" as the return type
20:51:35 <nhnt11> Good night
20:56:22 --> mconley has joined #instantbird
21:03:30 --> Armada has joined #instantbird
21:33:44 --> Mic has joined #instantbird
21:33:44 * ChanServ sets mode +o Mic 
21:40:44 <Mic> mayanktg: you'll get your review tomorrow morning (UTC).
21:41:41 <Mic> And technically speaking I haven't fixed my Ubuntu. It's hanging while booting and I can't figure out why. It boots fine when I start into recovery mode and proceed booting from there. So it's more a workaround than a fix :(
21:44:52 --> jb has joined #instantbird
21:48:18 <-- jb has quit (Ping timeout)
21:49:12 --> jb has joined #instantbird
22:04:08 <-- jb has quit (Ping timeout)
22:16:55 <-- CaptainCalliope has quit (Quit: CaptainCalliope)
22:37:10 --> Rym has joined #instantbird
22:47:51 <-- mconley has quit (Input/output error)
22:48:58 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
23:14:03 <-- Armada has quit (Connection reset by peer)