#instantbird log on 05 24 2014

All times are UTC.

00:00:05 --> Rym has joined #instantbird
00:32:01 --> mpmc has joined #instantbird
00:33:29 <-- CaptainCalliope has quit (Quit: CaptainCalliope)
01:44:39 <-- mconley has quit (Quit: NO CARRIER)
01:45:48 <-- clokep has quit (Ping timeout)
01:58:31 <-- Armada has quit (Connection reset by peer)
02:14:52 <-- nhnt11 has quit (Ping timeout)
02:16:05 --> nhnt11 has joined #instantbird
02:49:00 <-- wnayes has quit (Quit: wnayes)
03:35:16 --> CaptainCalliope has joined #instantbird
03:59:27 <-- Rym has quit (Ping timeout)
03:59:47 --> Rym has joined #instantbird
04:08:01 <-- Suiseiseki has quit (Ping timeout)
04:25:53 --> Suiseiseki has joined #instantbird
04:41:02 --> gerard-majax_ has joined #instantbird
04:42:50 <-- Rym has quit (Ping timeout)
05:22:56 <-- gerard-majax_ has quit (Ping timeout)
06:32:05 --> mayanktg has joined #instantbird
07:49:46 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
08:13:38 --> mikk_s has joined #instantbird
08:13:52 <-- mikk_s has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
08:19:50 <-- nhnt11 has left #instantbird ()
08:19:51 --> nhnt11 has joined #instantbird
08:20:42 --> Mic has joined #instantbird
08:20:42 * ChanServ sets mode +o Mic 
08:31:27 <-- mayanktg has quit (Ping timeout)
08:34:10 --> mayanktg has joined #instantbird
08:34:52 --> gerard-majax_ has joined #instantbird
08:35:11 <mayanktg> Mic: Did you see the patch for the ser icon bug? I updated it last night
08:39:57 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
08:48:36 <-- gerard-majax_ has quit (Ping timeout)
09:04:46 --> gerard-majax_ has joined #instantbird
09:29:55 <-- gerard-majax_ has quit (Ping timeout)
09:48:54 --> sonny has joined #instantbird
10:01:13 <-- sonny has quit (Ping timeout)
10:32:46 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
10:58:05 --> sonny has joined #instantbird
11:20:38 <-- EionRobb has quit (Quit: Leaving.)
11:21:03 <-- sonny has quit (Ping timeout)
11:33:57 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:07:07 <-- CaptainCalliope has quit (Ping timeout)
12:09:26 --> CaptainCalliope has joined #instantbird
13:20:27 <sawrubh> Even: ping
13:28:34 --> aleth has joined #instantbird
13:28:34 * ChanServ sets mode +o aleth 
13:28:47 --> clokep has joined #instantbird
13:28:47 * ChanServ sets mode +o clokep 
13:31:05 <sawrubh> wow, that's some coincidence (joining simultaneously) ;)
13:31:41 <sawrubh> clokep: o/
13:32:39 <-- clokep has quit (Ping timeout)
13:32:56 --> Rym has joined #instantbird
13:33:50 --> clokep has joined #instantbird
13:33:51 * ChanServ sets mode +o clokep 
13:35:21 <aleth> sawrubh: re XMPP testing, why don't you simply join rooms you have made yourself?
13:36:00 <sawrubh> aleth: I have done that, but those rooms send subject stanzas without body element
13:36:36 <sawrubh> I wanted to test in a room where the server sends a body element too ( I can't modify the server config of my room to ask it to add a body element to test)
13:36:48 <aleth> So you'll either have to find a server that behaves like pidgin.im or write an xpcshell test which simulates one.
13:37:14 <aleth> Regarding your participans/muc.incomingMessage errors, I have already suggested to you in your bug how you can debug those.
13:37:43 <aleth> I sort of suspect clokep is going to ask you to add tests anyway ;)
13:37:45 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:37:50 --> clokep has joined #instantbird
13:37:50 * ChanServ sets mode +o clokep 
13:38:16 <clokep> sawrubh: You could write an xpcshell test.
13:38:28 <clokep> I was not going to , actually.
13:38:36 <clokep> sawrubh: Any luck getting the filelink stuff working?
13:41:19 <sawrubh> clokep: yeah, so I've fixed most of it, just one final thing remains
13:41:37 <clokep> :)
13:42:25 <sawrubh> so in cloudFileAccount.js, when it tries to do 'Cu.import("resource:///modules/iteratorUtils.jsm");' it can't find it
13:42:39 <clokep> Cause we don't have iteratorUtils.
13:42:43 <sawrubh> currently trying to figure out what decides which modules are visibe to who
13:42:45 <clokep> It's part of TB.
13:43:08 <clokep> We only have access to cod einside of im and chat.
13:43:15 <clokep> So it's pretty straightforward
13:43:21 <sawrubh> so we are able to access XPCOMUtils.jsm (mozilla stuff) but not TB stuff?
13:43:48 <sawrubh> some config file must be deciding the scope of these modules or is it something else?
13:44:26 <clokep> We can of course access anythign in toolkit.
13:44:34 <clokep> No, they're just not built.
13:46:05 <sawrubh> so should I copy it (and not move it) somewhere?
13:46:19 <-- clokep has quit (Ping timeout)
13:47:42 <aleth> Put a try/catch around the import and if it fails, include whatever contains getIter?
13:49:30 <aleth> Likely not the way to ultimately fix it, but...
13:49:43 <sawrubh> so I get this : NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]
13:50:16 <aleth> Oh, I see, it's global code.
13:51:18 * sawrubh wonders what straightforward solution clokep had in mind
13:54:12 <aleth> Comment out the iteratorUtils inclusion, and see what that file actually uses from it.
13:54:26 <aleth> Then you can decide how to fix the problem.
13:55:05 <sawrubh> It used 'fixIterator'
13:58:37 <aleth> So, for now, try inlining the relevant parts of fixIterator.
14:01:31 <aleth> If there's lots of other cloudfile parts that require it we can think about importing iteratorUtils
14:03:58 <sawrubh> no there aren't
14:06:09 <aleth> So yeah, find out which if clause in fixIterator applies in this case, and use that.
14:11:48 --> mconley has joined #instantbird
14:16:36 --> jb has joined #instantbird
14:22:58 <sawrubh> aleth: will I need to update the uuid in the .manifest file or is that auto-generated?
14:23:20 <aleth> You shouldn't have to touch manifest files, they are generated from jar.mn
14:26:08 <sawrubh> gah, now the same thing with log4moz.js
14:26:12 * sawrubh goes to fix that
14:29:44 <aleth> Wait, log4moz.js? Do you really need that?
14:29:48 <aleth> iirc it's part of gloda
14:31:36 <sawrubh> well http://pastebin.instantbird.com/715350 is what I'm getting now (after inlining the entire fixIterator (for now))
14:32:00 <sawrubh> and the nsBox.js error is about not being able to find log4moz.js so yeah, I guess we need it
14:33:13 <aleth> What does it do?
14:33:26 <aleth> Box is one of the storage providers iirc.
14:34:24 <sawrubh> yeah, so throughout nsBox.js (the implementation required to add a FileLink provider to mozilla code) it uses log4moz to log the various things
14:34:45 <aleth> Yeah, I'm not sure what we're going to do about that. flo-retina would be the person to ask.
14:35:04 <aleth> I guess just include log4moz for now.
14:35:20 <sawrubh> you mean copy it
14:37:40 <aleth> You could make a copy for now. Don't move this file.
14:38:40 <sawrubh> btw thanks for getting 'mach build im/' building, it has really speeded up things :)
14:39:46 <aleth> No problem :)
14:43:03 <aleth> Maybe I should explain a bit better what you'll have to do with Filelink, ultimately. At the moment, it's TB-only. IB and TB share code in /chat, everything else is separate. So the problem is to disentangle the Filelink code so it can be shared and placed in /chat, forking only if we really have to.
14:43:39 <aleth> So a dependency like log4moz, which lives in /gloda (which is the content database for TB which we really don't want or need in IB) is a problem...
14:44:36 <sawrubh> ok
14:44:52 --> Armada has joined #instantbird
14:45:30 <sawrubh> so with me moving the cloudfile to chat/ shouldn't we have to make some changes to ensure things work in TB?
14:46:42 <aleth> Ultimately yes, you'll have to do that. (Like changing the messenger/ URIs to chat/ URIs as discussed previously)
14:47:29 <aleth> For now the goal is I think just to get it building so you can work with it. As you get to understand the Filelink code better it should become more obvious what you need to modify and what not.
14:48:38 <aleth> E.g. for log4moz, we'll need to figure out exactly what it does for cloudfile, and how much it depends on gloda. Thankfully flo-retina probably already knows the answer ;)
14:50:46 <sawrubh> this makes things clearer
14:51:02 --> wnayes has joined #instantbird
14:51:04 <sawrubh> otherwise today's been mostly grappling with weird chrome urls for me
14:51:44 <aleth> Not fun... but I guess you're learning how they work and what all these files are for ;)
14:53:16 <sawrubh> it's not completely clear to me yet but yeah I'm figuring it out (mostly having Eureka moments)
14:53:39 <-- Even has quit (Input/output error)
14:55:05 <aleth> This may help a bit http://dxr.mozilla.org/mozilla-central/source/build/docs/jar-manifests.rst 
14:55:28 <-- mconley has quit (Quit: NO CARRIER)
14:56:08 <sawrubh> yeah, I had found it during my googling sessions today
14:56:29 * sawrubh goes back to fixing stuff
14:57:26 <-- Rym has quit (Connection reset by peer)
14:57:55 --> Rym has joined #instantbird
15:00:19 <-- BWMerlin has quit (Quit: BWMerlin)
15:00:37 <-- Rym has quit (Connection reset by peer)
15:00:55 --> iamjayakumars has joined #instantbird
15:01:13 --> Rym has joined #instantbird
15:05:26 <nhnt11> Hi
15:05:42 <nhnt11> aleth: So I've been unable to run my tests :-/
15:06:02 <aleth> What goes wrong?
15:06:50 <aleth> Heh, I see you discovered how easy it is to drop errors on the floor with promises... iirc that used to be a real problem.
15:08:58 <aleth> Can you get the other tests in the same folder to run?
15:09:22 <nhnt11> Nope
15:09:26 <nhnt11> Can't get any tests to run
15:09:29 <nhnt11> I pastebin'd the error..
15:09:37 <nhnt11> Something about being unable to load sqlite3
15:09:39 <aleth> I didn't see that pastebin
15:09:44 <nhnt11> 1 sec
15:10:09 <nhnt11> aleth: http://pastebin.instantbird.com/714733
15:10:53 <aleth> Try "make xpcshell-tests"
15:11:07 <nhnt11> aleth: That's what gave me that ouput
15:11:09 <aleth> (from the objdir)
15:11:13 <nhnt11> (see line 1)
15:11:14 <aleth> Uh, sorry
15:11:27 <nhnt11> brb
15:11:32 <aleth> That's weird
15:11:57 <aleth> Have you tried clobbering?
15:12:01 <nhnt11> Yes
15:12:19 <aleth> If you've recently pulled, I wonder if something broke.
15:12:26 <aleth> Let me update my repo...
15:14:29 <aleth> Tests just ran fine for me. Now I've updated and started a build, so we'll see.
15:15:28 <nhnt11> :S
15:15:29 <aleth> nhnt11: if you remove your test from xpcshell.ini, I'm guessing that makes no difference?
15:16:06 * nhnt11 tries
15:16:10 <nhnt11> aleth: No difference
15:16:30 <aleth> So at least you know it's not your test that's the problem ;)
15:18:16 <aleth> Huh, now you make me read up on this newfangled Assert stuff :D
15:19:38 <nhnt11> :P
15:19:42 <aleth> Btw I personally like to add the occasional do_print to make the test output more readable.
15:19:52 <nhnt11> Alright
15:20:08 <aleth> But you'll see for yourself once we get them running...
15:20:26 <aleth> e.g. turn the comments into do_prints
15:20:46 <nhnt11> Yeah
15:21:19 --> mayanktg has joined #instantbird
15:28:19 <-- Rym has quit (Ping timeout)
15:33:03 <-- jb has quit (Ping timeout)
15:34:43 --> Rym has joined #instantbird
15:36:10 <aleth> nhnt11: So a fresh build with the current tree has no problems running the tests for me
15:36:22 <aleth> What's your mozconfig?
15:37:26 <nhnt11> aleth: 1 sec. What exactly are you doing to run tests? $make xpcshell-tests from the objdir?
15:37:32 <aleth> Yes
15:37:56 <nhnt11> aleth: http://pastebin.instantbird.com/715429
15:37:59 <nhnt11> My mozconfig
15:38:11 <nhnt11> I don't get why it's annoyed about sqlite3
15:38:22 <aleth> Weird
15:38:32 <aleth> Maybe (long shot) try a brew update/upgrade?
15:38:48 <aleth> I doubt it has anything to do with it though
15:39:09 <nhnt11> Tried that already too :(
15:39:36 <aleth> So you're now also building with a clean tree, and still see the error?
15:39:52 <mayanktg> aleth: http://i.imgur.com/TTMgsmG.png
15:39:59 <mayanktg> Looks much better now
15:40:37 <nhnt11> aleth: Yes.
15:40:59 <aleth> mayanktg: Looks like you've added your first new feature ;)
15:41:19 <mayanktg> aleth: yeppie :D
15:41:35 <mayanktg> Lets go for next!
15:41:47 <aleth> So what's that bug you're asking about?
15:42:06 <mayanktg> Bug 1004930
15:42:12 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1004930 enh, --, ---, nobody, NEW, Generic way to add buttons for actions to a conversation
15:42:46 <-- Rym has quit (Connection reset by peer)
15:42:49 <aleth> nhnt11: I don't have any ideas what's causing that "image not found" :-S
15:43:02 <nhnt11> aleth: I asked on #maildev yesterday night, didn't get a response
15:43:18 --> Rym has joined #instantbird
15:43:19 <nhnt11> Guess I can try again...
15:43:27 <aleth> Maybe also try #developers
15:43:30 <nhnt11> Hmm
15:45:33 <aleth> mayanktg: "how to add elements in the children element so that it can be updated.." parentelement.appendChild() ?
15:45:51 --> jb has joined #instantbird
15:45:52 <mayanktg> No.. Using <children /> 
15:46:04 <mayanktg> https://developer.mozilla.org/en-US/docs/XBL/XBL_1.0_Reference/Elements#children
15:46:13 <aleth> <children> just specifies in the XBL where children will be added.
15:46:23 <mayanktg> Ok.
15:46:28 <aleth> You still have to add them!
15:47:08 <aleth> Maybe I don't understand your question, in which case share a pastebin and be more specific ;)
15:47:56 <aleth> Do you understand what <children> is for?
15:48:00 <mayanktg> I don't have a patch for it :-|
15:49:16 <mayanktg> aleth: Yes..pretty much. It species where the child element should be added 
15:49:29 <aleth> mayanktg: What are you trying to do?
15:50:07 <mayanktg> We generate content (toolbar in this case) ...and try to place it near the target switcher
15:50:18 <mayanktg> ** target switcher is itself such button
15:50:38 <aleth> So you want to replace the target switcher with a container that can contain multiple buttons
15:50:46 <mayanktg> Yes
15:51:45 <aleth> Before you get all confused about <children>, how would you do this?
15:52:50 <aleth> What code are you looking at?
15:53:01 <mayanktg> Define the toolbarbutton in desired place .... 
15:53:59 <aleth> Where is the desired place? (in the code)
15:54:18 <mayanktg> add <children> to the hbox containing displayName and toolbarbutton (targetPrplIcon)
15:54:22 <mayanktg> Wait..
15:55:03 <mayanktg> http://mxr.mozilla.org/comm-central/source/im/content/conversation.xml#1995
15:55:44 <aleth> Have you seen http://mxr.mozilla.org/comm-central/source/im/content/conversation.xml#2233 ?
15:56:10 <mayanktg> Yes I have seen that too
15:56:56 <aleth> Looks like your task is to find a way to add and remove buttons, dynamically, in both places.
15:57:33 <aleth> The reason <children> came up is because the existing buttons are inside the <content> of a binding.
15:57:51 <mayanktg> ok
15:57:52 <aleth> This content is "anonymous content" (look it up)
15:59:35 <mayanktg> The annonid element is being fetched by the targetButton here http://mxr.mozilla.org/comm-central/source/im/content/conversation.xml#2145
15:59:40 <aleth> <children> is a tag you can put inside <content> that determines where in the content elements added on the binding with appendChild() get inserted.
16:00:20 <mayanktg> Ok.
16:01:53 <aleth> I think if you start coding and try to add some buttons with appendChild() without <children> you will quickly learn if and why you need it ;)
16:02:47 <mayanktg> Yeah. I guess I was putting the children element right... I will try to add a button using appendChild() :)
16:03:45 <aleth> XBLs can be a bit tricky... trying things out is a good way to get some experience with them
16:04:26 --> Mic has joined #instantbird
16:04:27 * ChanServ sets mode +o Mic 
16:05:09 <-- Armada has quit (Connection reset by peer)
16:05:20 <aleth> mayanktg: Don't forget to update the patch in the webcam bug (and the screenshot there) before Mic reviews it ;)
16:05:24 * mayanktg goes to update the review patch in Bugzilla with new screenshot :D
16:05:32 <mayanktg> aleth: read my mind :D
16:05:36 <aleth> :)
16:05:40 <aleth> Just to avoid confusion.
16:10:23 * Mic somehow I can't get getUserMedia to work in Fx.
16:10:25 <mayanktg> updated :)
16:10:45 <Mic> Skype is showing the video feed from the webcam fine though.
16:11:29 <Mic> Fx is even asking which device it should use but video isn't working then.
16:13:58 <sawrubh> aleth: where would it make sense to redefine http://mxr.mozilla.org/comm-central/source/mail/app/profile/all-thunderbird.js#845
16:14:39 <sawrubh> im/app/profile?
16:15:01 <aleth> For now, add the missing prefs to all-instantbird.js
16:15:06 <-- iamjayakumars has quit (Client exited)
16:16:12 --> iamjayakumars has joined #instantbird
16:17:05 <aleth> Mic: Does this work for you? http://jsfiddle.net/codepo8/agaRe/4/ 
16:17:15 <aleth> (It's a bit broken for me but it does access the webcam)
16:18:51 <mayanktg> aleth: Yeah..this jsFiddle doesn't work in ff though :P .https://bugzilla.mozilla.org/show_bug.cgi?id=998964
16:18:54 <instantbot> Bug 998964 nor, --, ---, nobody, UNCO, 'Taking webcam photos' example given in JSFiddle site doesn't capture image in Firefox.
16:19:55 <-- aleth has quit (Ping timeout)
16:23:18 --> aleth has joined #instantbird
16:23:19 * ChanServ sets mode +o aleth 
16:39:56 <Mic> aleth: I'll check that when I come back.
16:40:00 <Mic> Have a nice evening! :)
16:40:17 <-- Rym has quit (Ping timeout)
16:40:34 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
16:40:35 <-- jb has quit (Ping timeout)
16:48:12 --> clokep has joined #instantbird
16:48:13 * ChanServ sets mode +o clokep 
16:52:42 <clokep> aleth: We'll most likely just make a copy of log4moz.
16:53:22 <aleth> clokep: I'm just kind of worried it may store stuff in gloda, but I haven't looked at it.
16:53:58 <clokep> aleth: No...it doesn't.
16:54:01 <clokep> It just does logging.
16:54:04 <clokep> It's not originally from gloda.
16:54:07 <clokep> They just use it.
16:55:07 <aleth> OK :) Nothing else does.
16:55:35 <aleth> So I was suspicious ;)
16:59:47 <clokep> I think lightning uses it too.
17:00:04 <clokep> http://log.bezut.info/instantbird/today/#m216 doesn't sound right to me. :-S
17:00:17 <clokep> aleth: Are you clear what mayanktg's task is? :) I don't want everyone to get confused.
17:00:30 <aleth> I was asking what had been agreed.
17:00:53 <aleth> For now, he's hopefully experimenting with just simple adding of buttons.
17:03:10 * nhnt11 needs to get those tests working asap :-/
17:03:13 <nhnt11> #developers!
17:03:49 <clokep> aleth: Yeah, it's pretty make "Make the target switched a real button" and "add a way to add more buttons dynamically".
17:06:42 <nhnt11> aleth: Is there a way to copy messages without magic? i.e. without timestamps
17:06:59 <nhnt11> (like, by holding some key, etc)
17:07:16 <aleth> Not that I know of
17:07:22 <nhnt11> ok
17:07:42 <aleth> The magic does more than just timestamps though
17:07:53 * nhnt11 knows
17:08:06 <aleth> I guess you could add a hidden pref or something...
17:08:47 <nhnt11> I don't think that's necessary, I was just wondering if something already exists.
17:11:56 <nhnt11> I wonder if this is some weird python problem
17:13:05 * nhnt11 tries https://stackoverflow.com/questions/15595473/python-import-sqlite-error
17:21:54 --> flo-retina has joined #instantbird
17:21:54 * ChanServ sets mode +qo flo-retina flo-retina 
17:22:23 <flo-retina> hello :)
17:22:28 * flo-retina assumed nhnt11 wouldn't mind more feedback after aleth had already looked at the patch :)
17:22:39 * nhnt11 doesn't mind.
17:23:01 <aleth> flo-retina: I didn't finish looking at the patch actually, as getting tests to work seemed more urgent. So thanks!
17:23:12 <aleth> Unfortunately tests are working for me but not for nhnt11...
17:23:30 <flo-retina> hasn't log4moz been moved to toolkit and renamed to Log.jsm or Logs.jsm?
17:23:51 <-- iamjayakumars has quit (Quit: )
17:23:57 <flo-retina> aleth: I haven't looked at the whole patch actually, I kinda skipped the system logs part
17:24:04 * nhnt11 is reinstalling python/sqlite3, and it's taking forever on his connection...
17:25:10 <flo-retina> clokep: what's wrong with "replace the target switcher with a container that can contain multiple buttons"?
17:31:34 <flo-retina> mayanktg: on http://i.imgur.com/TTMgsmG.png why are the horizontal margins larger than the vertical margins around the placeholder?
17:32:40 * nhnt11 clobbers
17:33:40 <aleth> flo-retina, mayanktg: I don't think the left/right margins should be smaller. But maybe the top/bottom ones around the placeholder should match that.
17:35:22 <mayanktg> flo-retina: I tried keeping the margins eual on all the sides along the placeholder. Though it appeared good on panel-1 but the buttons in panel-2 looked ugly cos the panel appeared to be rectangle-vertically.
17:37:05 <mayanktg> aleth: Yes I can try with increasing the margins of top and bottom
17:37:07 <flo-retina> good/ugly seems like it wants screenshots ;)
17:37:24 <flo-retina> aleth: either way, I just think all the margins should be the same around a square :)
17:38:03 <aleth> Sounds like a good idea actually.
17:38:07 <mayanktg> flo-retina: yupp ..wait a min :)
17:41:40 <mayanktg> flo-retina: http://i.imgur.com/Cew3XMt.png
17:41:47 <mayanktg> Looks good to me :)
17:42:00 <aleth> :)
17:49:35 <mayanktg> flo-retina: Anything else that we would like to modify in the patch?
17:52:47 <nhnt11> Yay, my tests work
17:52:59 <aleth> nhnt11: excellent!
17:53:12 <aleth> I wonder how your install got messed up.
17:53:19 * nhnt11 too
17:54:59 <nhnt11> Um. I'd removed the logger tests from xpcshell.ini. After adding it back, mach build im doesn't seem to be enough to let me run it?
17:55:47 <-- aleth has quit (Ping timeout)
17:57:06 <nhnt11> The tests seem to pass on the first try :S
17:57:12 * nhnt11 expected bugs
17:58:31 <nhnt11> Maybe the fact that they pass is a bug ;)
17:58:55 * nhnt11 adds do_prints
18:05:15 <nhnt11> clokep: How do I view a test's log file? (where is it?)
18:06:56 <flo-retina> isn't it visible on your terminal?
18:07:35 <nhnt11> flo-retina: I don't see the output of my do_prints on my terminal
18:14:46 <flo-retina> mayanktg: looking at your patch now
18:19:58 --> Rym has joined #instantbird
18:24:59 <-- CaptainCalliope has quit (Quit: CaptainCalliope)
18:45:46 <-- Rym has quit (Ping timeout)
18:45:58 <mayanktg> flo-retina: seems too long :-(
18:46:07 <flo-retina> what?
18:46:40 <mayanktg> You were reviewing the patch..I though it isn't complete yet
18:46:56 <flo-retina> I'm still reviewing
18:47:05 <flo-retina> reviews frequently take 1+ hour
18:47:12 <flo-retina> I'm almost done though :)
18:48:04 <mayanktg> Ohh :-| Is it ok now?  
18:48:17 <flo-retina> You'll get feedback ;)
18:52:18 <sawrubh> clokep: current status (http://pastebin.instantbird.com/715614) is that when I drop a file in the text area, add account dialog opens up properly, providers set correctly, selecting opens up their login pages but after signing in, it doesn't return. In the case of Box, it gives an alert popup and in the case of Hightail, it gives an error. The errors are
18:52:18 <sawrubh> http://pastebin.instantbird.com/715630
18:52:29 <flo-retina> mayanktg: published
18:52:43 <sawrubh> clokep: working on fixing those errors
18:53:17 <mayanktg> flo-retina: received..going through it...
18:57:31 <flo-retina> mayanktg: btw, don't be surprised/disappointed if your first patches need plenty of review iterations, it's normal :). nhnt11 can tell you he's gone through plenty too at the beginning when he started hacking tabs :).
18:57:51 <nhnt11> flo-retina++
18:59:10 * mayanktg wishes to contribute in version 1.6!
18:59:29 <nhnt11> mayanktg: I think you already have with the user icon context menu
18:59:30 <nhnt11> ?
19:00:36 <mayanktg> nhnt11: Yeah ..but it would be removed if this one lands. Plus this would be something new :)
19:01:21 <sawrubh> when does 1.6 get uplifted?
19:02:42 <sawrubh> and what kind of release schedule and workflow do we follow? 6-weekly and aurora->beta->stable?
19:04:06 <nhnt11> sawrubh: So far we've had nightlies and stable builds, which are built when "the time is right" (the goal is to have a stable release every ~3 months)
19:05:08 <nhnt11> After the c-c we want automated betas and so forth, but I'm not really sure on the status of this
19:05:20 <nhnt11> I suppose flo-retina or clokep could clarify/correct me :)
19:05:41 <nhnt11> er, s/c-c/c-c merge
19:23:06 <clokep> flo-retina: It sounded to me like "add more things in the target switcher's drop down"
19:23:50 <clokep> nhnt11: do_print is only visible for failed tests.
19:24:22 <nhnt11> clokep: Alright, I'll just be happy that my tests are working and stop trying to find something wrong then :)
19:25:42 <clokep> nhnt11: It is useful to know they pass, yes. That's usually why you make tests before the feature...when the tests fail. :P
19:25:49 <clokep> nhnt11: And that's vaguely right about our release strategy.
19:25:54 <clokep> sawrubh: Did you still have issues?
19:26:02 <clokep> Meh, pretend that sentence made sense.
19:30:12 <nhnt11> flo-retina: I'm not quite sure why the stuff in _initNewLog is not done in the constructor, that's the way it was before I touched it so I left it like that for the time being.
19:30:37 <nhnt11> It's done in the constructor for system logs, so I guess I should change it (I can't see a reason not to, but maybe one will become clear if I test stuff out?)
19:31:17 <clokep> FWIW I'd still like to be able to read txt logs...but writing them does seem kind of silly at this point.
19:31:21 <sawrubh> clokep: http://mxr.mozilla.org/comm-central/source/mail/components/cloudfile/content/addAccountDialog.js#57 is where _accountType is set and http://mxr.mozilla.org/comm-central/source/mail/components/cloudfile/content/addAccountDialog.xul#36 is where it's set in the dialog window so I don't see a reason why it should be null
19:32:30 <clokep> sawrubh: Is onInit() being called?
19:33:42 <clokep> (Throw a debug statement in there to ensure it is.)
19:33:56 <clokep> Maybe even print _accountType from in there.
19:34:28 * nhnt11 finds arrow functions hard to read
19:34:37 <nhnt11> Especially when they're nested...
19:34:59 <nhnt11> Um, I'm doing it wrong.
19:40:41 * nhnt11 discovers Promise.all and notes it for future use.
19:43:32 <clokep> nhnt11: What're you doing wrong?
19:43:41 <clokep> Promise.all waits for a list of promises to resolve?
19:43:55 <sawrubh> hrm, so dump doesn't work in there
19:44:04 * sawrubh tries some other debugging technique
19:44:53 <nhnt11> clokep: I was doing something like promise.then(() => anotherPromise.then(() => { ... })); which got confusing fast
19:45:24 <nhnt11> (changed it to promise.then(() => {return anotherPromise}).then(() => {...});)
19:45:41 <nhnt11> Basically chain the promises instead of nesting stuff
19:46:00 <nhnt11> clokep: It returns a Promise that resolves when a list of promises all resolve
19:47:11 <nhnt11> Hmm, there isn't any real documentation of it on MDN..
19:47:49 <clokep> Isn't that what I just said? :P
19:47:57 <clokep> Cool. :)
19:48:07 <nhnt11> clokep: It doesn't wait, it gives you a Promise ;)
19:48:08 <clokep> Looks like Florian and aleth agree w/ the review comments I gave you yesterday too. :)
19:48:18 <clokep> nhnt11: Same thing.
19:48:19 <nhnt11> Yeah :)
19:51:07 --> Armada has joined #instantbird
20:21:41 <-- clokep has quit (Ping timeout)
20:29:40 * flo-retina isn't sure what clokep's review comments were, but usually clokep's comment make sense (even without pretending), so I'm not surprised
21:36:27 --> igorko has joined #instantbird
21:56:38 <-- igorko has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
22:18:14 --> EionRobb has joined #instantbird
22:18:50 <-- Armada has quit (Quit: Leaving)
22:20:24 <mayanktg> http://pastebin.instantbird.com/715863
22:21:03 <mayanktg> flo-retina: I'm almost done with the changes. I tried using | image.style.background = "url('chrome://instantbird/skin/userIcon.svg')"; |
22:21:10 <mayanktg> to set the image as background. The image didn't fix properly to the div :-/ Should I add another line to fix this up? or leave the code with setting the "src" attr for the same?
23:04:33 --> Rym has joined #instantbird
23:08:08 <-- Rym has quit (Ping timeout)
23:22:33 --> BWMerlin has joined #instantbird
23:26:21 --> jb has joined #instantbird
23:46:51 <-- EionRobb has quit (Ping timeout)
23:50:27 --> EionRobb has joined #instantbird
23:50:31 <instantbot> New Instantbird - Contacts window bug 1015678 filed by mayanktg@gmail.com.
23:50:33 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1015678 nor, --, ---, nobody, UNCO, Make  user icon handling in chat/ be asynchronous with OS.File