#instantbird log on 05 23 2014

All times are UTC.

00:00:55 <sawrubh> clokep: didn't work :/
00:01:22 <clokep> sawrubh: You gotta give me more than that. ;) Was there an error?
00:01:43 <sawrubh> I haven't registered the interfac though, I should give that a try
00:01:58 --> nhnt11 has joined #instantbird
00:02:11 <sawrubh> I get a green entry in the error console saying there is no such interface
00:03:03 <sawrubh> clokep: 'No chrome package registered for chrome://instantbird/cloudfile/addAccountDialog.xul' is the exact error
00:03:55 <clokep> sawrubh: Did you try w/ messenger instead of instantbird?
00:04:13 <clokep> (I might have misunderstood what you were asking before. . .)
00:04:25 <clokep> It's very possible it's being registered under messenger, but we /don't want it to be/.
00:04:29 <clokep> But don't worry about that yet.
00:04:36 <sawrubh> trying with messenger
00:05:38 <sawrubh> I've used messenger/content/cloudfile (exactly in cloudFileAccounts.js)
00:05:47 <sawrubh> ...compiling...
00:06:49 <sawrubh> 'No chrome package registered for chrome://messenger/content/cloudfile/addAccountDialog.xul' :/
00:07:03 <-- clokep has quit (Ping timeout)
00:08:17 <-- flo-retina has quit (Ping timeout)
00:08:19 --> clokep has joined #instantbird
00:08:20 * ChanServ sets mode +o clokep 
00:08:47 <clokep> sawrubh: How are you compiling btw? Just want to make sure you're not compiling stuff you don't need to be.
00:08:48 <clokep> Hm.m..OK
00:09:20 <sawrubh> I do ./mozilla/mach build in comm-central :)
00:09:45 <clokep> sawrubh: Do ./mozilla/mach build im/
00:10:06 <clokep> Should take < 10s.
00:10:40 <clokep> OK....I'm almost done w/ dinner, I can concenrate more once I am.
00:11:01 <sawrubh> woah, that build was fast
00:11:06 <sawrubh> 3s or so
00:11:30 <clokep> ;)
00:11:34 <clokep> I'm glad I asked.
00:11:50 <sawrubh> btw it didn't package any jars, shouldn't that be an issue ( when I do ./mozilla/mach build I see it packaging and defalting things)
00:12:07 <clokep> Umm....I don't remember.
00:12:12 <clokep> You're not building the installer, so...
00:12:32 <clokep> sawrubh: Are those pastebins still fairly up to date?
00:12:38 <sawrubh> as long as it's fast and the correct things are getting built
00:13:01 <sawrubh> those two pastebins are up to date (till me trying these different chrome urls)
00:13:34 <clokep> OK. :)
00:13:55 * sawrubh wonders what to try next
00:14:21 <sawrubh> can I somehow call something using @mozilla.org contract ID's or something?
00:14:32 <clokep> sawrubh: Check that the files are in objdir/mozilla/dist/bin!
00:14:39 <clokep> Yes, you can do that.
00:14:47 <clokep> Via... Component.classes, IIRC.
00:15:03 * clokep needs to do mach build.
00:15:06 <clokep> So it'll be like ~5 minutes.
00:17:21 <sawrubh> so I can see a symlink in the objdir to the conversation.xml that I'm editing, is that what you wanted me to check?
00:17:37 <clokep> I want to know if the file you expect actually exists.
00:17:42 <clokep> I.e. the account xul file.
00:17:49 <-- nhnt11 has quit (Ping timeout)
00:18:00 --> nhnt11 has joined #instantbird
00:19:02 <sawrubh> cool
00:19:02 <clokep> I.e. do you see cloudfile stuff in objdir/mozilla/dist/bin/components
00:19:18 <sawrubh> so I see /home/sawrubh/Mozilla/comm-central/obj-x86_64-unknown-linux-gnu/mozilla/dist/bin/chrome/messenger/content/messenger/cloudfile as the location of addAccountDialog.xul
00:19:25 <sawrubh> (the one inside the objdir)
00:19:34 <sawrubh> so we know the chrome url now
00:19:36 <clokep> OK, that's good.
00:19:42 <clokep> Hmmm....maybe.
00:20:22 * sawrubh tries this recursive-messenger chrome url
00:21:26 * clokep is still waiting fo rhis ubild to finish...
00:22:30 <sawrubh> gah
00:22:34 <sawrubh> 'No chrome package registered for chrome://messenger/content/messenger/cloudfile/addAccountDialog.xul'
00:23:33 <clokep> OK.
00:30:36 * clokep tries to find this link again...
00:34:10 <-- wnayes has quit (Ping timeout)
00:34:50 --> clokep_work has joined #instantbird
00:34:50 * ChanServ sets mode +o clokep_work 
00:35:09 <clokep_work> sawrubh: So I can't get the drag n drop to work.
00:35:10 <clokep_work> Where do I need to drop it?
00:35:27 <sawrubh> drop it where we type in the text
00:35:43 <sawrubh> anywhere else and it doesn't work
00:36:11 <sawrubh> you can change the last line (window.openDialog) to some alert or this._conv.sendMsg() and it should work
00:36:25 <clokep> :-S
00:36:28 <clokep> No feedback at all...
00:37:03 <sawrubh> it doesn't work or you're saying we should tell the user somehow where to drop (that sort of feedback(?
00:37:39 <clokep> It doesn't work.
00:37:57 * sawrubh tries again
00:38:28 <clokep> Does it work w/ both MUCs and private conversations?
00:38:40 <clokep> Does hte icon or anything change while I'm dragging?
00:38:53 <clokep> You're on Linux, right?
00:39:04 <sawrubh> it's working on my personal room on muc.ch3kr.de
00:39:10 <sawrubh> I'm on Linux, yeah
00:39:26 <sawrubh> the icon doesn't change, nothing happens, it's very elementary right now
00:39:57 <clokep> OK.
00:40:00 <sawrubh> I was wanting to get it working (filelink dialog opening) then would work on polish
00:40:12 <clokep> I'm building on Windows now...
00:40:38 <sawrubh> gimme a sec, checking if it works for me
00:40:45 <clokep> Thanks. :)
00:40:48 <clokep> I know this is frustrating hah.
00:43:53 <sawrubh> ok, so it works for me
00:44:01 <sawrubh> http://pastebin.instantbird.com/714305 is the exact patch that I've applied
00:44:19 <sawrubh> besides the other copying-filelink one
00:44:39 <sawrubh> which channel/room are you trying this on?
00:45:02 <sawrubh> btw this is in the instance of IB where I've got js-xmpp enabled (fwiw)
00:45:32 <clokep> I've been trying w/ IRC.
00:45:37 <sawrubh> can you do one thing? join sawrubh@muc.ch3kr.de and I'll test again
00:46:03 <sawrubh> I don't see why this should be protocol specific, the changes are to conversation.xml
00:47:27 <sawrubh> clokep: sorry I'll have to leave for an hour or so, can we do this later?
00:47:40 <clokep> sawrubh: Sure thing.
00:47:45 <sawrubh> thanks
00:47:57 <clokep> sawrubh: Just joined your room.
00:50:16 <-- nhnt11 has quit (Ping timeout)
00:52:38 --> nhnt11 has joined #instantbird
00:52:46 <clokep> Doesn't work on Windows either. :-S
00:54:25 <-- clokep_work has quit (Ping timeout)
00:59:40 <-- nhnt11 has quit (Ping timeout)
01:00:55 --> nhnt11 has joined #instantbird
01:09:06 <-- Mook_as has quit (Quit: Mook_as)
01:12:16 <-- nhnt11 has quit (Ping timeout)
01:13:24 --> nhnt11 has joined #instantbird
01:13:26 --> wnayes has joined #instantbird
01:16:03 <-- nhnt11 has quit (Ping timeout)
01:17:41 --> nhnt11 has joined #instantbird
01:18:04 <-- rosonline has quit (Client exited)
01:23:10 --> jb has joined #instantbird
01:25:34 <-- Armada has quit (Connection reset by peer)
01:25:37 <-- jb has quit (Ping timeout)
01:36:51 --> jb has joined #instantbird
01:39:43 <-- jb has quit (Ping timeout)
01:41:59 --> jb has joined #instantbird
01:43:39 <-- jb has quit (Ping timeout)
01:50:32 <-- wnayes has quit (Connection reset by peer)
01:52:52 --> jb has joined #instantbird
01:58:25 <-- jb has quit (Ping timeout)
02:06:50 <-- stux has quit (Ping timeout)
02:07:36 --> stux has joined #instantbird
02:12:04 <-- dew has quit (Ping timeout)
02:13:04 --> dew has joined #instantbird
02:24:18 <-- clokep has quit (Ping timeout)
02:24:50 --> mconley has joined #instantbird
02:31:11 <-- mconley has quit (Input/output error)
03:18:32 --> mconley has joined #instantbird
03:29:28 <-- mconley has quit (Input/output error)
03:32:45 --> mconley has joined #instantbird
03:33:15 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
03:54:08 <-- mconley has quit (Input/output error)
03:55:56 --> mconley has joined #instantbird
04:29:56 <-- mconley has quit (Input/output error)
04:35:44 <-- Rym has quit (Ping timeout)
04:37:26 --> mayanktg has joined #instantbird
05:33:48 <-- EionRobb has quit (Quit: Leaving.)
06:18:28 --> EionRobb has joined #instantbird
06:25:22 --> gerard-majax_ has joined #instantbird
06:34:02 <-- gerard-majax_ has quit (Ping timeout)
07:14:21 * Fallen|away is now known as Fallen
07:21:05 --> Mic has joined #instantbird
07:21:05 * ChanServ sets mode +o Mic 
07:35:03 <Mic> Hello
07:40:02 <EionRobb> hi
07:47:50 * Fallen is now known as Fallen|away
07:50:48 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
07:52:18 * Fallen|away is now known as Fallen
08:06:58 <-- dew has quit (Connection reset by peer)
08:07:04 --> dew has joined #instantbird
08:08:03 <mayanktg> Mic: Thanks for the review..
08:10:23 --> flo-retina has joined #instantbird
08:10:23 * ChanServ sets mode +qo flo-retina flo-retina 
08:34:37 <mayanktg> Mic: I'm working on the generic icon patch. will ping you if I'm stuck. I've added a <children/> element in the <xul:hbox> and I'm trying to define binding for it. I'll share WIP soon.
08:42:22 --> Mic|mobile has joined #instantbird
08:44:29 <-- flo-retina has quit (Ping timeout)
08:46:27 --> flo-retina has joined #instantbird
08:46:28 * ChanServ sets mode +qo flo-retina flo-retina 
08:46:29 <Mic|mobile> You don't need to create a binding for children yoursekf...
08:47:33 <mayanktg> Ok
08:48:10 <mayanktg> Then ? How would the toolbarbuttons get dynamically added inside the children element?
08:48:39 <Mic|mobile> That's haopening automatically
08:48:56 <Mic|mobile> That's the whole point of using it.
08:49:18 <flo-retina> mayanktg: have you read the documentation for XBL's <children> tag?
08:49:52 <mayanktg> flo-retina: https://developer.mozilla.org/en-US/docs/XBL/XBL_1.0_Reference/Elements#children ?
08:50:39 <flo-retina> yes
08:50:42 <flo-retina> did you understand it?
08:52:07 <flo-retina> ooh, that's a nice reading even for me :). I didn't know one can put default content in there.
08:52:42 <mayanktg> Not completely.  I looked at code for <children> too in mxr http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWidgets.xml#404 . 
08:57:14 <flo-retina> mayanktg: btw, I asked you yesterday to fix the indent in your patch for an easier review of the code, and I see that Mic had plenty of comments about the indent being wrong :(
08:58:29 <Mic|mobile> flo-retina: I read that and only included it lest it gets forgotten.
08:58:45 <mayanktg> flo-retina: I didn't upload the latest patch. I thought Mic would be reviewing that.. I have fixed it now
09:01:10 <mayanktg> Also I have added the svg icon... Should I use 64X64 userIcon file for user icon area in the buddy list or at both places (in panel and buddy list) we should have the same placeholder icon?
09:01:11 <flo-retina> mayanktg: I told you to update the patch before Mic reviews, didn't I?
09:03:17 <mayanktg> flo-retina: Yes you said it. :(
09:05:59 <Mic|mobile> Bbl
09:07:45 <-- Mic|mobile has quit (Ping timeout)
09:07:49 --> sonny has joined #instantbird
09:07:50 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:14:19 --> Armada has joined #instantbird
09:28:59 <-- sonny has quit (Ping timeout)
09:29:18 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:29:25 --> nhnt11 has joined #instantbird
09:29:31 --> aleth has joined #instantbird
09:29:31 * ChanServ sets mode +o aleth 
09:31:48 --> sonny has joined #instantbird
09:31:54 <nhnt11> Hi
09:31:59 <nhnt11> Sorry I never reappeared yesterday..
09:32:40 <aleth> I left some feedback in your bug.
09:33:19 * nhnt11 saw
09:35:10 --> flo-retina has joined #instantbird
09:35:10 * ChanServ sets mode +qo flo-retina flo-retina 
09:41:34 * Fallen is now known as Fallen|away
09:44:12 --> gerard-majax_ has joined #instantbird
09:46:40 * flo-retina wonders if nhnt11 fell asleep and slept the whole day yesterday :-P
09:47:33 <aleth> or maybe some exhausting post-finals celebrations ;)
09:51:56 --> clokep has joined #instantbird
09:51:56 * ChanServ sets mode +o clokep 
09:58:57 <aleth> flo-retina: http://log.bezut.info/instantbird/140523/#m167 we do that in the tooltips actually.
10:00:13 <aleth> sawrubh: ping
10:00:44 <mayanktg> Mic: I have added the changes you mentioned in the reviews. Hope no poor indents this time...
10:01:53 <-- aleth has quit (Ping timeout)
10:01:56 <mayanktg> You said yesterday that there's no need to add accesskey to "Remove" button as there's no place to show shortcut for that. I have added it as a button though..we can add later if needed be.
10:02:10 <-- sonny has quit (Ping timeout)
10:04:57 <flo-retina> aleth: Indeed! I must not have paid attention when we introduced that :-]
10:05:01 <flo-retina> we also use it at http://lxr.instantbird.org/instantbird/source/instantbird/content/preferences/handlers.xml#74
10:05:04 --> sonny has joined #instantbird
10:06:25 <-- EionRobb has quit (Quit: Leaving.)
10:06:47 --> BWMerlin has joined #instantbird
10:06:48 <flo-retina> mayanktg: "694 	    document.getElementById("userIconPanel")."
10:06:52 <flo-retina> dot on the next line
10:07:43 <-- sonny has quit (Ping timeout)
10:08:16 --> sonny has joined #instantbird
10:08:46 <mayanktg> Done :'(
10:08:52 <flo-retina> I'm adding more comments
10:09:14 <clokep> aleth, flo-retina: Did you guys look over those pastebins sawrubh posted? I'm unsure what needs to be changed in jar.mn or what to get the content/components in the right spots...
10:09:22 <flo-retina> I didn't
10:11:11 <clokep> flo-retina: http://log.bezut.info/instantbird/yesterday/#m631
10:11:33 <clokep> I tried those patches and the ondrop handler isn't working for me on Mac or Windows.
10:11:48 <clokep> And he's getting 'No chrome package registered for chrome://instantbird/cloudfile/addAccountDialog.xul' is the exact error
10:15:27 <clokep> mayanktg: Mic: Btw using "icon" actually fits with other nomenclature we use around that.
10:16:56 <-- sonny has quit (Ping timeout)
10:17:50 --> sonny has joined #instantbird
10:18:58 <flo-retina> mayanktg: I just gave you more coding style comments
10:19:52 <flo-retina> clokep: chrome://instantbird/cloudfile/addAccountDialog.xul is certainly not a valid chrome URL
10:20:23 <flo-retina> urls are chrome://<packagename>/{content,skin,locale}/[<path>/]<filename>
10:23:48 --> aleth has joined #instantbird
10:23:48 * ChanServ sets mode +o aleth 
10:24:55 <clokep> flo-retina: OK, that's not really the issue though. Did you read the logs or look at the patches? He can't figure out what to change https://mxr.mozilla.org/comm-central/source/mail/components/cloudfile/cloudFileAccounts.js#193 to
10:24:57 <clokep> I think.
10:25:05 <clokep> Or maybe it's the line in the patch where he opens the dialog.
10:25:22 <clokep> I'd love to know why it didn't work for me, but that's another issue. :(
10:25:41 <flo-retina> clokep: has he edited http://mxr.mozilla.org/comm-central/source/mail/components/cloudfile/jar.mn ?
10:26:01 <clokep> I don't think so. I played with that a bit, but had no idea what to modify things to.
10:26:06 <mayanktg> flo-retina: Yes I was reading that. :)  What MDN says about using if else statement is: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/if...else#Example:_Using_if...else  . That's why I didn't use a line break after "if" statement :(
10:26:11 <aleth> chat/content/cloudfile? ;)
10:26:14 <flo-retina> clokep: ""chrome://instantbird/cloudfile/content/addAccountDialog.xul"" in that diff isn't a correct chrome url
10:26:50 <flo-retina> clokep: so do we want to change the urls to chat/content/cloudfile everywhere (including in TB), or use messenger/content/cloudfile urls in Instantbird?
10:27:04 <clokep> flo-retina: I don't know, what do you think?
10:27:13 <flo-retina> I think the latter is saner as a way to start
10:27:21 <clokep> I do too.
10:27:22 <flo-retina> don't want to start messing with Tb code now :)
10:27:33 <aleth> We should move it eventually though to make it clear it is shared code.
10:27:46 <aleth> Not now of course (enough distractions...)
10:28:44 <flo-retina> clokep: we likely need one of our jar.mn file to contain:
10:28:44 <flo-retina> messenger.jar:
10:28:45 <flo-retina> % content messenger %content/messenger/
10:29:12 <clokep> flo-retina: I saw some lines like that in the chat jar.mns, what does that line do?
10:29:46 <flo-retina> that line causes a "content" line to be added to the .manifest files while building
10:30:04 <flo-retina> and these "content" lines are required for things to exist within chrome URLs
10:30:16 <flo-retina> currently chrome://messenger/content/ doesn't exist in Instantbird
10:30:53 <clokep> Alright.
10:30:56 <flo-retina> are your questions answered?
10:30:57 <clokep> Thanks. :)
10:31:01 <clokep> Yep!
10:31:03 <flo-retina> :)
10:35:32 <clokep> Unless you magically know why ondrop wasn't working? :P
10:35:57 <aleth> I think I have a guess ;)
10:36:04 <clokep> Woot! :)
10:36:15 <clokep> Want me to test something?
10:36:15 <aleth> Pastebin looks wrong to me anyway.
10:36:23 <clokep> Which part?
10:36:29 <aleth> Shouldn't sawrubh be testing? :P
10:36:54 <flo-retina> he should!
10:36:56 <flo-retina> where is he?
10:38:00 * flo-retina wonders if now is time to send a reminder to all mentors that students should have been coding the whole week as a full time job, and that some code/patches should have appeared by now
10:38:19 <clokep> aleth: He was, it was working fine for him.
10:38:55 <aleth> clokep: I missed that. So it's working for him and not for you?
10:39:12 <clokep> aleth: Yes,
10:39:22 <clokep> It's possible he has other differences, other stuff applied.
10:39:56 <aleth> Regardless, those ondrag handlers should not be on the vbox.
10:40:17 <-- sonny has quit (Ping timeout)
10:40:42 <aleth> At least I'd be surprised if that worked.
10:40:47 <clokep> aleth: So the ondrag handlers work for me, but on*drop* handler doesn't.
10:41:06 <aleth> The same goes for ondrop of course.
10:41:48 <aleth> I think they should be on the browser and/or the textbox elements
10:43:48 --> sonny has joined #instantbird
10:44:02 <aleth> I haven't looked at the code inside the handler, but it should be called if you do that.
10:44:59 <aleth> Btw why are the ondrag handlers needed anyway?
10:45:23 * aleth doesn't remember
10:45:25 <clokep> Testing, I think. There's also some weird paragraph about them on the drag n drop handler.
10:45:27 <clokep> page
10:45:29 <clokep> on MDC.
10:47:37 <clokep> nhnt11: So tests today? :)
10:47:52 <nhnt11> clokep: Yup
10:52:16 <clokep> :)
10:52:31 <clokep> I guess those aren't really exciting changes to land, but hopefully we can land them soon! :)
10:53:11 <nhnt11> brb
10:53:43 <aleth> I don't know, from a technical point of view going async is quite exciting. So much less likely to have random freezes and janks...
10:54:17 <aleth> No need for manually adding executeSoon queues...
11:15:53 <-- clokep has quit (Ping timeout)
11:21:05 --> Mic|mobile has joined #instantbird
11:25:02 <-- Mic|mobile has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
11:36:37 --> Mic|mobile has joined #instantbird
11:42:53 <-- sonny has quit (Ping timeout)
11:58:53 --> clokep_work has joined #instantbird
11:58:53 * ChanServ sets mode +o clokep_work 
12:08:25 --> Rym has joined #instantbird
12:16:09 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:16:32 --> Mic has joined #instantbird
12:16:32 * ChanServ sets mode +o Mic 
12:22:04 <clokep_work> flo-retina: Did you have any ideas about whether we could get the conversation from libpurple to add the chatRoomFields at all?
12:22:15 * clokep_work thinks we need libpurple to start using promises. ;)
12:27:12 <flo-retina> clokep_work: I think i need to review aleth's patch carefully to understand what's going on, and then see if something is possible
12:27:46 <aleth> libpurple is just... old in it's design.
12:30:09 <clokep_work> I should finish the libpurple update. :-[
12:31:36 <nhnt11> aleth: Re. your suggestion create a getLogFile/PathForConv function: if we do that, what's left for init() to do?
12:32:22 <aleth> nhnt11: Create and write the header of the file?
12:32:45 <nhnt11> Hmm. Alright. Just that that code isn't really used elsewhere...
12:32:50 <nhnt11> Good for readability I guess
12:33:00 <nhnt11> (The alternative is to add a comment maybe)
12:33:02 <aleth> Readable now, possibly reused later...
12:33:09 <nhnt11> Alright
12:34:03 <aleth> There are lots of getLogsFor variants, some exposed, some not. I expect in the progress of asyncification it will become clear how to best organise them...
12:38:33 --> qheaden has joined #instantbird
12:38:43 <-- Mic|mobile has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
12:44:28 * Mic was hoping that eventually there'd be an API to find out when there were messages in a conversation and a way to get them in a range of time (e.g. "now - 24h" to "now").
12:46:12 <aleth> I'm guessing the API will change a lot during this gsoc, one way or another...
12:46:37 <clokep_work> Most likely.
12:46:54 <aleth> We'll see what's needed as indexing gets added etc
12:46:55 <Mic> Hopefully a lot of this session/log file oriented stuff will just die :P
12:47:53 <aleth> If you're expecting the One Big Database To Hold Absolutely Everything, I think you'll be disappointed though ;)
12:48:42 <aleth> But yeah, the user shouldn't have to know about log files.
12:49:42 --> sonny has joined #instantbird
12:49:52 <flo-retina> I've just sent more comments in mayanktg's direction. Glad to see my previous comments have all been correctly addressed, including the handling of the retina icon :)
12:51:34 <Mic> aleth: I don't care how it would be implemented :P
12:51:35 <flo-retina> Mic: I think we will still have plenty of log files
12:51:52 <aleth> We just have to make sure we start a new log file at least once a day.
12:52:00 <flo-retina> I would like if we could automatically compress/archive old logs to waste less disk space though
12:52:00 <aleth> To avoid them getting too big....
12:52:06 <flo-retina> probably outside the scope of gsoc though
12:52:13 <Mic> flo-retina: sure, no problem with lots of log files as long as API consumers don't have to bother with that.
12:52:32 <flo-retina> Mic: oh, yeah, agreed on the API needing to be sane :)
12:52:36 <aleth> Yup!
12:53:43 * clokep_work never pushed his IRC stats extension. :(
12:53:43 --> mpmc has joined #instantbird
12:53:45 <clokep_work> I was going to run it...
12:54:07 <aleth> Have you tried it on a large channel yet?
12:54:16 <flo-retina> clokep_work: are you going to make stats by channel?
12:54:51 <clokep_work> flo-retina: It doesn't right now, but I could add that.
12:54:55 <clokep_work> aleth: No, why?
12:55:05 <Mic> clokep_work: you're going to collect "version" information, aren't you?
12:55:14 <clokep_work> Mic: That's all it collects, yes.
12:55:18 <Mic> OK
12:55:40 <aleth> clokep_work: all I know is you tried it on #chatdev ;)
12:55:55 <clokep_work> aleth: I'm not sure why you think a larger channel would matter. ;)
12:56:06 <aleth> More variety than #chatdev?
12:56:51 <clokep_work> aleth: Ah, I thought you were concerned about it not working or flooding stuff.
12:56:52 <Mic> Whois everyone! ;) Then try to convert the people who are idling in the most channels to maximize the advertisement effect of our default quit  message ;)
12:57:36 <clokep_work> Hmmm....I guess it wouldn't be too hard to add a list of channels people were seen in.
12:58:02 <clokep_work> Do people think it's reasonable to assume someone's client doesn't change? Pretty much if I've seen a nick before, I ignore it.
13:00:37 <flo-retina> I think it makes sense to assume someone's client doesn't change several times a day (that's probably not true if people switch back and forth between mobile/laptop/web; but shouldn't change too much the statistical results)
13:01:52 <Mic> Anyone knows why we a're importing "resource:///modules/..." with three but ""resource://gre/modules/" with only two slashes after "resource:"?
13:04:04 --> mconley has joined #instantbird
13:04:17 <sawrubh> aleth: clokep_work flo-retina hey, sorry I overslept, getting back to work in a bit
13:04:34 <flo-retina> Mic: yes
13:04:39 <-- Rym has quit (Ping timeout)
13:04:47 <flo-retina> resource:/// is a shortcut for resource://app/
13:04:56 <Mic> Ah, thanks!
13:05:19 <Mic> I was wondering if that was a typo that didn't cause an error and was just copied and pasted everywhere ;)
13:05:22 <flo-retina> do you know the difference between //app/ and //gre/ or should I explain that too?
13:06:57 <Mic> No, but you don't need to explain it either.
13:07:10 <flo-retina> if you don't know, I should explain it
13:07:18 <sawrubh> I'll try what's been suggested in the scrollback
13:07:21 <Mic> OK, go ahead then :)
13:07:39 <flo-retina> if we are building with a xul-sdk (ie. xulrunner), app/ points to Instantbird's folder, and gre/ points to xulrunner's folder
13:08:21 <flo-retina> so in most cases both point to the same thing, but getting it wrong means people building on linux with --with-xul-sdk will have bad surprises.
13:09:09 <Mic> OK
13:09:49 --> rosonline has joined #instantbird
13:10:30 <clokep_work> sawrubh: OK. You saw Florian's suggestion?
13:10:53 <sawrubh> Yes
13:24:08 <clokep_work> flo-retina: Is it cool to set width/height like that in JS? Shouldn't that be down as percentages or something? :-S
13:28:52 <flo-retina> like what?
13:29:19 <aleth> Isn't the answer "it depends"?
13:32:11 --> mayanktg has joined #instantbird
13:32:48 <clokep_work> flo-retina: https://bugzilla.mozilla.org/show_bug.cgi?id=975542#c26
13:32:50 <instantbot> Bug 975542 enh, --, ---, mayanktg, NEW, Set user icon from image taken with the webcam.
13:33:13 <clokep_work> width of 213 looks pretty weird to me.
13:33:41 <Mic> height is 160px, 213 is 4/3 of that.
13:33:55 <mayanktg> clokep_work: Yes..as Mic said
13:34:02 <aleth> I do think a comment would be nice in cases like that.
13:34:15 <Mic> That seems to assume a certain aspect ration of the video btw...
13:34:33 <flo-retina> clokep_work: if these are constants, it could probably just go in the xul file
13:34:49 <aleth> mayanktg, Mic: How about using CSS calc() ?
13:35:04 <Mic> aleth: the canvas need to have it's size set like this.
13:35:13 <flo-retina> also canvas.setAttribute("width", "160px");
13:35:27 <Mic> CSS just doesn't cut it here.
13:35:44 <Mic> Check the canvas docs if interested.
13:35:47 <aleth> Mic: thanks. Comments it is then ;)
13:35:48 <Mic> *curious
13:36:13 <aleth> Or just explicit 160 * (4/3) ...
13:36:35 <Mic> Or a comment containing that, yes.
13:37:29 <Mic> Meh, I wrote some of the same comments as flo did...
13:38:16 <flo-retina> Mic: if these are constants and can't go in the CSS, I think they should go in the xul file
13:38:30 <mayanktg> aleth: Ok. I will add that. I tried very hard..but getting the correct stream inside the panel gave weird results.. Sometimes the video frame wasn't right and other the menu :-|
13:38:34 <flo-retina> Mic: ah, I didn't know you were already reviewing the new patch, sorry :-/
13:38:58 <aleth> mayanktg: Don't add it, Mic explained why it wouldn't work ;)
13:39:32 <Mic> Yeah, I try to improve on the quality and speed of my reviews and responses this year ;)
13:42:54 * flo-retina also needs to improve his review speed
13:43:02 <flo-retina> (sorry arlora :-/)
13:43:32 <mayanktg> flo-retina: I guess "stream: is destructed only if we explicitly define stream.stop() or if we close the window/tab. I'm not sure though 
13:44:30 <Mic> Ah, yes!
13:44:45 <Mic> I wanted to ask if we need to "delete stream" after it has been stopped...
13:45:54 <Mic> I need to go again but I managed to leave some comments on the bug.
13:45:57 <aleth> Why are you storing it as an attribute of the window?
13:46:09 <aleth> Is that standard?
13:46:26 <aleth> s/attribute/property
13:46:41 <Mic> aleth: isn't that how global variables and stuff are always stored?
13:46:58 <aleth> But why is it global?
13:47:15 <aleth> Why not buddylist.stream ?
13:47:21 <Mic> Ah! Sure :S
13:47:29 <Mic> Sorry that I missed that.
13:47:57 <Mic> I noticed that it's defined in one function and used in another, so I jumped to the conclusion that it needed to be global...
13:47:59 <Mic> :(
13:48:11 <aleth> global scares me... ;)
13:48:36 <flo-retina> I'm not scared of globals. I r- them ;)
13:49:07 <aleth> It's the only way to be sure.
13:55:49 <clokep_work> flo-retina slays the globals w/ his holy sword of r- mightiness!
13:56:02 <-- aleth has quit (Ping timeout)
13:57:05 <flo-retina> :-]
13:57:15 --> aleth has joined #instantbird
13:57:15 * ChanServ sets mode +o aleth 
14:01:42 <clokep_work> We'll get you a suit of armor first. ;)
14:05:15 --> Rym has joined #instantbird
14:08:53 <-- Rym has quit (Ping timeout)
14:10:07 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
14:14:39 <-- flo-retina has quit (Ping timeout)
14:15:49 --> flo-retina has joined #instantbird
14:15:49 * ChanServ sets mode +qo flo-retina flo-retina 
14:15:58 <-- aleth has quit (Ping timeout)
14:18:36 <-- Suiseiseki has quit (Ping timeout)
14:19:57 --> wnayes has joined #instantbird
14:21:12 --> Suiseiseki has joined #instantbird
14:21:33 <-- BWMerlin has quit (Quit: BWMerlin)
14:24:56 --> aleth has joined #instantbird
14:24:56 * ChanServ sets mode +o aleth 
14:25:47 --> jb has joined #instantbird
14:26:25 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:29:57 --> iamjayakumars has joined #instantbird
14:32:11 <-- flo-retina has quit (Ping timeout)
14:35:36 --> flo-retina has joined #instantbird
14:35:36 * ChanServ sets mode +qo flo-retina flo-retina 
14:36:33 <-- jb has quit (Ping timeout)
14:49:29 <mayanktg> Mic, flo-retina: does it look ok now?
14:50:30 <mayanktg> I mean https://bugzilla.mozilla.org/show_bug.cgi?id=975542#c31
14:50:34 <instantbot> Bug 975542 enh, --, ---, mayanktg, NEW, Set user icon from image taken with the webcam.
14:54:47 <aleth> mayanktg: Can I see a current screenshot? ;)
14:55:13 <mayanktg> yeah sure
14:56:15 <clokep_work> mayanktg: Looks a lot better. :)
14:56:36 <clokep_work> (I only looked at an interdiff btw)
14:57:02 <aleth> I think this is getting really close to landing :)
14:57:14 <-- Even has quit (Ping timeout)
14:59:27 <mayanktg> aleth: http://i.imgur.com/QHv48Fr.png
14:59:56 <aleth> Thanks :)
15:00:07 <clokep_work> mayanktg: Didn't someone ask for the "Select file" and "Take picture" text to not be centered to make it fit w/ the icon better?
15:00:21 <clokep_work> It looks nice though. :)
15:01:41 <aleth> I wonder if there's a nice file icon in the same folder that the webcam icon came from?
15:01:58 <mayanktg> clokep_work: It would look nice for "Take Picute..." but I think "select File..." won't look nice left aligned.
15:02:17 <mayanktg> aleth: Yeah ..I search for it in m-c ..could find a suitable one :-/
15:02:23 <mayanktg> *searched
15:03:03 <clokep_work> mayanktg: OK, but can you at least try it and show us a screenshot?
15:03:18 <mayanktg> yeah :)
15:03:46 <aleth> If you want, you could make your own (take the same colour as the webcam icon, and make something standard like a rectangle with a "folded corner" in Gimp)
15:05:45 --> Mic has joined #instantbird
15:05:45 * ChanServ sets mode +o Mic 
15:06:08 <Mic> aleth, mayanktg: the "Save page" icon from the hamburger menu looks like that.
15:06:20 <Mic> It's large, though.
15:06:22 <aleth> Mic: Right :)
15:06:29 <aleth> Shrinking things is easy.
15:06:41 <Mic> No necessarily :S
15:06:54 <aleth> Well, if it's an integer multiple.
15:06:57 <aleth> We can hope.
15:07:16 <Mic> I can have a look at the icons.
15:07:30 <Mic> I can create a retina version of the "New Conversation" icon too :)
15:08:21 * Mic wants to create a new MUC-icon too. The SVG user icon file will help with that :)
15:08:21 <flo-retina> the current misalignment between "Select" and "Take" isn't really nice
15:08:27 <flo-retina> so I think we should stop centering on these buttons
15:08:46 <aleth> Mic: :)
15:10:04 <aleth> Heh, there's also a camera with mic https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/drawable-hdpi/alert_mic_camera.png?force=1
15:11:27 * flo-retina wonders why you all are picking stuff from the android folder
15:11:39 <mayanktg> flo-retina: Ok. I'm trying to change the alignment..but tex-align: left doesn't seem to work for the toolbarbutton :-|
15:11:42 <aleth> That's where the webcam icon came from.
15:11:57 <flo-retina> aleth: we have some icons for Firefox too ;)
15:12:06 <aleth> flo-retina: where?
15:12:18 <flo-retina> aleth: http://mxr.mozilla.org/mozilla-central/find?string=webrtc&tree=mozilla-central&hint=browser%2Fthemes
15:12:51 * flo-retina knows, be cause he added _at least_ half of these
15:12:52 <aleth> mayanktg ^^
15:13:16 <flo-retina> and pestered Boriss for weeks to get all these files in the correct colors and resolutions.
15:13:18 <aleth> Let's use those then.
15:14:06 <aleth> Also for the video chat later ;)
15:15:05 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
15:15:32 <Mic> http://mxr.mozilla.org/mozilla-central/source/browser/themes/linux/menuPanel.png
15:15:36 --> CaptainCalliope has joined #instantbird
15:15:48 <mayanktg> Bookmarked ;) 
15:15:54 <mayanktg> Mic: Thanks :) :) :)
15:16:22 <aleth> Are those really OS-specific?
15:16:27 <-- CaptainCalliope has quit (Quit: CaptainCalliope)
15:17:16 <Mic> Yes, even when the Linux ones don't look like Linux ones :P
15:17:20 <aleth> mayanktg: Easy way to preview: http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/
15:18:01 <aleth> Mic: I guess my question is "should mayanktg add the various icons for all the OS" ;)
15:19:02 <aleth> Probably a good idea if the files differ (mayanktg: Take a look at my recent throbber patch to see how that is done)
15:19:58 <aleth> mayanktg: https://hg.mozilla.org/comm-central/rev/396fbef06517
15:20:00 <mayanktg> aleth: as the lords say :) Ok I'm looking a the patch
15:20:20 <aleth> mayanktg: hey, it's faster than having to make your own icon ;)
15:20:56 <mayanktg> aleth: that too using GIMP :P
15:22:16 <aleth> mayanktg: Basically, make subdirs for the various OS if they don't exist yet, and then add the files to jar.mn like in that patch.
15:22:30 <mayanktg> I added the "webcam" icon for retina display btw. 
15:22:54 <aleth> Well, I guess I made the folders in that patch already ;)
15:23:11 <aleth> Great.
15:23:52 <mayanktg> aleth: ohh that's great :)
15:25:12 <aleth> mayanktg: https://hg.mozilla.org/comm-central/diff/396fbef06517/chat/themes/jar.mn This is how the different OS get the right icon assigned to them at build-time.
15:26:19 <mayanktg> aleth: OK! understood that :D
15:26:19 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
15:26:39 <aleth> mayanktg: Oh OK, great if you already knew :)
15:27:28 <mayanktg> So we would be using http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/webRTC-shareDevice-16.png for webcam image (its 64X64 variance too)
15:27:29 <aleth> Anyway, adding those WebRTC icons now will be useful later too.
15:27:50 <aleth> mayanktg: Use that one for OSX, and the Linux one for Linux, etc...
15:28:11 <mayanktg> So I should add all of them? I mean for each video, audio call etc ?
15:28:19 <mayanktg> In this patch only?
15:28:39 <aleth> For now I'd just add the ones you need
15:28:54 <aleth> But keeping the filenames so it is clear where they came from.
15:29:16 <mayanktg> http://mxr.mozilla.org/mozilla-central/source/browser/themes/linux/menuPanel.png (folder icon) . I should crop and use or use as is and use -moz-image-region for that?
15:29:52 <aleth> Probably easier to do the latter. Ask Mic when he returns though.
15:30:06 <mayanktg> Ok
15:31:28 <aleth> If you use moz-image-region you'll need a transform as well to rescale, so I don't know what he will decide ;)
15:32:30 <mayanktg> Hmm..Rescale might cause blurry icon :-o
15:32:45 <aleth> Whats' the size of those icons?
15:33:06 <aleth> Hopefully it's an integer multiple of the size you need...
15:33:39 <aleth> Otherwise you'll have to crop and polish by hand I suppose.
15:34:35 <clokep_work> mayanktg: use -moz-image-region.
15:35:38 <mayanktg> aleth: The size of wach icon is 32X32
15:35:43 <mayanktg> *each
15:35:43 <aleth> mayanktg: :)
15:35:59 <mayanktg> ok
15:35:59 <aleth> So you are in luck.
15:49:27 <-- sonny has quit (Ping timeout)
15:50:17 <-- clokep_work has quit (Ping timeout)
15:54:25 <-- gerard-majax_ has quit (Ping timeout)
15:57:58 <sawrubh> aleth: so I need to change 'content/messenger/cloudfile' in the jar.mn (in the copied cloudfile directory) to 'messenger/content/cloudfile' and then use this chrome url 'chrome://messenger/content/cloudfile/addAccountDialog.xul' ?
15:58:32 <sawrubh> also I have it on the vbox and it's working for, why do you think it shouldn't work when I have it on vbox?
15:58:54 <aleth> Yes, that sounds right.
15:59:23 <sawrubh> and regarding clokep's 'It's possible he has other differences, other stuff applied.' I don't have anything applied besides the patch to copy cloudfile to chat (and get it building and then this patch to add handlers to conversation.xml
15:59:42 <aleth> sawrubh: You don't want it on the vbox because I don't think you want to allow dropping on to the participant list for example (that would be ambiguous)
16:00:41 <sawrubh> aleth: but suppose I did (for testing purposes) it should technically work, but it isn't
16:00:45 <aleth> I didn't think it would work on the vbox because I didn't expect those events to bubble, that seems to be wrong.
16:00:49 <sawrubh> it only works when I drop it in the textbox
16:01:33 <sawrubh> ok, then I'll keep it to browser and textbox that way, dropping it on conversation area and textbox should work
16:01:52 <sawrubh> aleth: 'Pastebin looks wrong to me anyway.' is this vbox thing the only thing that looks wrong or you meant something else?
16:02:06 <aleth> sawrubh: I don't know exactly why it only works on the textbox, but my guess is we shouldn't rely on bubbling
16:02:13 <aleth> Yes, that's all.
16:02:34 <aleth> I didn't actually look at the code inside the event handlers...
16:06:36 <aleth> sawrubh: Ah, this is what I vaguely remembered: "A listener for the dragenter and dragover events are used to indicate valid drop targets, that is, places where dragged items may be dropped. Most areas of a web page or application are not valid places to drop data. Thus, the default handling for these events is to not allow a drop."
16:06:42 <aleth> Not precisely to do with bubbling.
16:08:29 <flo-retina> "I need to change 'content/messenger/cloudfile' in the jar.mn (in the copied cloudfile directory) to 'messenger/content/cloudfile'" no
16:08:46 <sawrubh> btw this is what I had read (https://developer.mozilla.org/en-US/docs/DragDrop/Drag_Operations#drop) and what clokep was talking about
16:09:01 <aleth> sawrubh: In that case sorry for the confusion!
16:09:11 <sawrubh> this says valid ondrop targets are where 'that is, one that cancelled the last dragenter or dragover event,'
16:09:26 <flo-retina> you don't need to change anything to that jar.mn file
16:09:29 <aleth> sawrubh: http://log.bezut.info/instantbird/140523/#m246
16:09:43 <flo-retina> you'll just need to add some lines I mentioned before to either that manifest, or another Ib one
16:11:18 <sawrubh> flo-retina: ok, I'll try to add this to cloudFileComponents.manifest (the one in the copied cloudfile directory and see if this works)
16:11:26 <sawrubh> otherwise will try some other manifest
16:13:54 <sawrubh> sorry I again confused, you say in http://log.bezut.info/instantbird/140523/#m246 that one of our jar.mn should contain it and not the .manifest file
16:14:57 <-- mayanktg has quit (Ping timeout)
16:15:34 <flo-retina> yes, jar.mn
16:15:44 <flo-retina> and that's used to generate the .manifest
16:22:45 --> mayanktg has joined #instantbird
16:30:16 <mayanktg> aleth: "chrome://browser/skin/menuPanel.png" this url for the ff menu panel should work in the CSS right?
16:32:28 <aleth> mayanktg: No, you have to copy the files to an /im/themes OS subfolder, add them to jar.mn, and then chrome://instantbird/skin/menuPanel.png should work.
16:32:45 <aleth> "browser" would work if you were building firefox ;)
16:34:11 <mayanktg> yeah ....Then I should probably crop the icon too :P
16:34:42 <mayanktg> Would save some space
16:34:45 <aleth> Don't for now. It will take time.
16:34:59 <mayanktg> ok
16:35:00 <aleth> Do it if Mic says you should later ;)
16:38:29 <flo-retina> yeah, you should crop the image if you are using only one icon from that large set
16:40:18 --> jb has joined #instantbird
16:44:56 --> Mook_as has joined #instantbird
16:45:18 <nhnt11> re
16:56:26 <-- qheaden has quit (Input/output error)
17:04:04 <aleth> mayanktg: If you want to style the text and/or icon inside a toolbarbutton, try #toolbarbuttonid > .toolbarbutton-icon {} and ...-text {}
17:05:03 <-- jb has quit (Quit: jb)
17:05:15 <mayanktg> Ok! I guess I have to use this for aligning the text left
17:06:02 <mayanktg> aleth: btw the buttons look this way now .. http://i.imgur.com/emMPZHB.png
17:07:50 <aleth> Definitely better with two icons, but unfortunately it looks like the file icon may need tweaking
17:07:59 <aleth> Looks like it has a different colour - what do you think?
17:08:00 <flo-retina> or the other one
17:08:12 <flo-retina> the do look different
17:08:13 <aleth> I think we should keep the webrtc icons standard
17:08:15 <flo-retina> *they
17:08:21 <aleth> Because they'll also be used elsewhere.
17:08:40 <mayanktg> flo-retina: Yes they have slightly different color variance
17:08:42 <aleth> Modifying an icon that's already been cropped out of a png is OK.
17:09:42 <aleth> mayanktg: Gimp has a colour picker which might help to grab the webcam colours and apply them to the file icon
17:10:20 <mayanktg> aleth: Yeah :) I'd adjust that.. sorry bbl 
17:10:53 <flo-retina> can't you find 2 icons coming from the same place?
17:10:59 <flo-retina> so that they already have correct colors?
17:11:34 <aleth> I suggested looking here http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/ but apparently there wasn't anything suitable?
17:13:27 <aleth> flo-retina: How about using one of these instead of that file icon? http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/menuPanel-customize.png
17:13:29 <sawrubh> aleth: I'm getting these errors (now the chrome url is working) the urls which that addAccountDialog.xul needs is what's missing
17:13:34 <sawrubh> 'No chrome package registered for chrome://messenger/locale/cloudfile/addAccountDialog.dtd'
17:14:04 <sawrubh> 'No chrome package registered for chrome://messenger/skin/preferences/preferences.css'
17:14:58 <sawrubh> I haven't copied those (these css reside in the themes directory)
17:15:41 <aleth> You haven't copied any files at this point afaik, you are just including them in jar.mn?
17:16:00 <sawrubh> I have copied the cloudfile folder to chat, that's all
17:16:18 <sawrubh> I haven't copied these .dtd and .css files (the ones references in the error messages)
17:16:22 <aleth> :-/
17:16:36 <sawrubh> should I do that?
17:16:47 <aleth> Why did you copy them to chat if you are including them via messenger/... ?
17:16:59 <aleth> Maybe I'm confused about what you decided with clokep
17:17:36 --> Vigilante has joined #instantbird
17:17:38 <sawrubh> so I can use the cloudfile component inside mail/components by just making changed to the jar.mn and without actually copying it
17:17:50 <sawrubh> ?
17:17:54 <aleth> I think you should be able to delete all your copied files for now. 
17:18:20 <aleth> You're including them directly by adding them to jar.mn
17:19:35 * sawrubh tries
17:19:37 <aleth> Preferences.css is more complicated because of course we already have a preferences in IB.
17:20:18 <aleth> So you'll have to look at the existing preferences.css (im/themes/preferences*)
17:21:01 <aleth> And figure out what the best thing to do is.
17:21:03 <sawrubh> btw I've made the changes to the jar.mn in the cloudfile folder that I copied
17:21:36 <sawrubh> so if I delete this folder....
17:21:55 <aleth> I think I'm confused about the way you are doing this, and I have to go in a minute.
17:22:24 <aleth> Maybe catch clokep when he reappears and fix the topic bug while you wait?
17:22:31 <sawrubh> sounds good
17:24:00 <aleth> (My confusion is: if the files are in /chat (and ultimately they should indeed be there, but via hg mv not as a copy) you should be referring to them via chrome://chat/... )
17:24:35 <sawrubh> just to be clear, right now too, I'm using hg mv
17:24:46 * sawrubh wonders how that's different from copying
17:25:04 <aleth> It's a *move*
17:25:06 <sawrubh> both of them copy the actual file
17:25:20 <aleth> When you move, you remove the original ;)
17:25:47 <sawrubh> ah!
17:25:57 <aleth> If you've hg mv'd them, then in the jar.mn in your cloudfile folder, you can replace /messenger/ with /chat/ everywhere.
17:27:01 --> clokep_work has joined #instantbird
17:27:01 * ChanServ sets mode +o clokep_work 
17:27:36 <sawrubh> woot, clokep_work's here!
17:28:13 <aleth> Now you've already done this via moving, maybe it's best to continue down that road.
17:29:16 * sawrubh just wants to check with clokep_work
17:29:38 <flo-retina> aleth: we decided to keep messenger/ for now in the paths
17:29:40 <aleth> Good idea :)
17:29:44 <mayanktg> re
17:29:45 <flo-retina> to avoid having to change everything in Tb too
17:30:26 <aleth> flo-retina: That's what I thought the plan was. But if his patch hg mv's the files, he can't get around changing Tb too, right? ;)
17:30:28 <-- clokep_work has quit (Ping timeout)
17:30:39 --> clokep_work has joined #instantbird
17:30:39 * ChanServ sets mode +o clokep_work 
17:31:31 <aleth> Well maybe he can, but it seems confusing to me.
17:31:48 <aleth> Easier to change Tb, it's just a search/replace after all.
17:34:54 <-- iamjayakumars has quit (Quit: )
17:37:00 <clokep_work> aleth: We decided to NOT change any of the chrome URIs for now.
17:37:22 --> Rym has joined #instantbird
17:37:35 <clokep_work> aleth: He shouldn't have to change anything in TB right now.
17:37:38 <aleth> All I can say is moving the files but not the URLs confused /me/ ;)
17:37:47 <clokep_work> aleth: It's a WIP.
17:37:51 <clokep_work> sawrubh: What's your question?
17:37:55 <aleth> Sure.
17:37:56 --> jb has joined #instantbird
17:38:11 <aleth> I'm just explaining why I wasn't much help ;)
17:39:13 <sawrubh> clokep_work: http://pastebin.instantbird.com/714650 is the error I get
17:39:49 <sawrubh> when I use 'chrome://messenger/content/cloudfile/addAccountDialog.xul'
17:39:55 <clokep_work> sawrubh: You have to copy/move the properties files.
17:40:01 <clokep_work> The localizations.
17:40:05 <clokep_work> So properties/dtd files.
17:40:28 <sawrubh> what about the css files in the themes directory?
17:41:11 <sawrubh> btw I think I should copy and not move (remove from original location) right?
17:41:12 <-- dew has quit (Ping timeout)
17:41:23 <sawrubh> because in the case of cloudfile, I've hg mv'ed
17:42:09 --> dew has joined #instantbird
17:43:10 <clokep_work> sawrubh: It depends what you're talking about.
17:43:33 <clokep_work> I can't give you a blanket answer there.
17:44:00 <mayanktg> aleth: What should we do about the icons? wait for Mic to decide what's better? here's the screenshot (text left aligned) http://i.imgur.com/dTvSA8U.png
17:44:50 <sawrubh> clokep_work: I'll try copying and if it doesn't work, I'll ask specifically
17:44:53 <aleth> mayanktg: I think you want more margin between the icon and the text
17:45:22 <clokep_work> sawrubh: Why are you starting with copying? :-\
17:45:30 <mayanktg> aleth: ok
17:45:36 <clokep_work> We need to decide what assets are shared (and should be MOVED and which are unique and should be COPIED).
17:46:08 <aleth> mayanktg: Just play around with the icon margins until it looks good.
17:46:17 --> jb1 has joined #instantbird
17:46:19 * Fallen|away is now known as Fallen
17:46:37 <-- jb has quit (Connection reset by peer)
17:47:59 <sawrubh> clokep_work: I have a doubt, if we *move* the shared things, how will the other component we are sharing the resource with work (it won't find the thing where it expects it to be)
17:48:17 <sawrubh> shouldn't we instead move the unique things and copy the shared ones
17:48:22 <aleth> mayanktg: Then tweak the file icon colours to match the webrtc icon. It also looks a bit blurry, or am I imagining things?
17:48:24 <clokep_work> (o_O)
17:48:37 <clokep_work> sawrubh: No. We don't want two copies of the identical code in the tree.
17:48:48 <clokep_work> sawrubh: If we need to make changes from the TB code, then we want our own copy.
17:49:39 <-- wnayes has quit (Ping timeout)
17:49:45 <mayanktg> aleth: No you're not ..The icon was compressed to 16X16 from 32X32 ..that's why.. 
17:50:12 --> wnayes has joined #instantbird
17:51:49 <aleth> sawrubh, clokep_work: As I said above, the right thing to do with the preferences.css file isn't obvious. You'll have to compare the IB and TB versions of the file.
17:59:53 <clokep_work> sawrubh: So is it clear what you need to do or are you stuck?
18:01:39 <sawrubh> it's not very clear, but the next steps are comparing the preferences.css files (?)
18:01:49 <sawrubh> what's clear is that I need to move the dtd file atleast
18:06:45 <clokep_work> sawrubh: Yes, you have to cp or mv the dtd/properties files.
18:07:46 <clokep_work> Did you find the dtd it wants at least?
18:07:58 <sawrubh> yes, it's in locales
18:08:14 <clokep_work> . . .
18:08:16 <clokep_work> Where in locales.
18:08:28 <-- Rym has quit (Ping timeout)
18:08:36 <sawrubh> '/home/sawrubh/Mozilla/comm-central/mail/locales/en-US/chrome/messenger'
18:09:05 <clokep_work> Hmmm...OK.
18:09:25 <clokep_work> So those will need to be put under chat/locales.
18:10:06 <clokep_work> It doesn't look like we have a separate chrome folder right now, I don't have a strong feeling or whether it should go right in that folder or in a cloudfile folder.
18:10:23 <aleth> http://mxr.mozilla.org/comm-central/find?text=&string=addaccountdialog
18:11:16 <clokep_work> sawrubh: So it looks like you want to hg mv mail/locales....messenger/cloudfile to chat/locales.../cloudfile
18:11:45 <aleth> & there's a bunch of CSS there too
18:12:01 <clokep_work> I know.
18:12:12 <clokep_work> I'm not sure where to put that. :(
18:12:33 <aleth> If you want a real headache, consider what to do with all the tests...
18:12:37 <clokep_work> I guess copy it into a chat/themes folder.
18:12:39 <aleth> http://mxr.mozilla.org/comm-central/find?string=cloudfile&tree=comm-central&hint=
18:12:42 <clokep_work> Why is that a headache? :-S
18:13:01 <clokep_work> Those should just stay where they are.
18:13:04 <aleth> Hopefully.
18:13:05 <clokep_work> They're TB UI tests.
18:13:26 <aleth> Oh right, it's just mozmill.
18:13:47 <clokep_work> We can certainly ignore them for now. ;)
18:14:22 <clokep_work> sawrubh: Does this make sense or no?
18:14:25 <clokep_work> I Have to go in a few minutes.
18:14:46 <aleth> But there's a whole bunch of CSS and png files in mail/themes subfolders that should probably be moved
18:14:59 <sawrubh> yes, that I need to move the css to chat/themes
18:15:35 <aleth> Right.
18:28:51 <sawrubh> ok, done with the moving
18:28:55 <sawrubh> let's see if this builds
18:31:11 <sawrubh> and it does, but I still get the same error
18:31:19 <sawrubh> btw http://pastebin.instantbird.com/714651 is how I moved things
18:31:51 <aleth> What's the error?
18:33:05 <clokep_work> Did you add a jar.mn inside of the themes directory that sets up all the paths?
18:33:07 <aleth> You shouldn't have moved the preferences files I think
18:33:20 <aleth> But let's get it building first.
18:33:29 <sawrubh> aleth: it's building all right
18:33:59 <sawrubh> I'm getting the error when I drop the file (the error associated with missing resources (dtds, css's))
18:34:01 <sawrubh> http://pastebin.instantbird.com/714650 to be exact
18:34:16 <sawrubh> clokep_work: no, I didn't
18:34:20 <aleth> A lot of those preferences files don't even look cloudfile-related -- did you look to see what they were?
18:34:21 <sawrubh> lemme do that!
18:34:44 <clokep_work> sawrubh: And a moz.build and a Makefile?
18:34:51 <clokep_work> Makefile.in.
18:35:01 <clokep_work> I don't know exactly what to put in them, but take a look at the ones in im/themes.
18:35:10 <clokep_work> I need to get going.
18:36:47 <sawrubh> aleth: no I didn't
18:37:54 <sawrubh> but they are referenced in the xul file (that's why the error) so I thought it might be required and that css internally might need all those pngs
18:38:24 <aleth> IIRC cloudfile adds a pane to the Preferences window?
18:38:39 <sawrubh> I'll first try adding the moz.build, Makefile.in and jar.mn in the themes directory (and probably the cloudfile directory inside locales which I copied)
18:39:02 <aleth> But IB already has a Preferences window, so you'll have to take a closer look to find out what needs adding where
18:39:27 <clokep_work> I'm also not entirely sure why you're trying to bring up the accounts window when dropping the file. ;)
18:40:56 <aleth> I'd recommend taking a look around all those cloudfile files to get a rough idea of what the moving parts are ;)
18:41:05 --> sonny has joined #instantbird
18:41:11 <sawrubh> clokep_work: so when the person first drops the file, I need to check if he's signed into some FileLink provider and if not, will ask him to add his account
18:41:28 <clokep_work> sawrubh: OK.
18:41:56 * clokep_work goes.
18:42:02 <sawrubh> aleth: ok, I'll do that
18:43:38 <-- clokep_work has quit (Ping timeout)
18:44:02 <Mook_as> does cloudfile make sense in chat/ ? (trying to remember what seamonkey uses)
18:44:10 <aleth> Mook_as: Yes
18:44:17 <aleth> Seamonkey doesn't use it.
18:44:50 <Mook_as> alright, you've obviously put thought into it :D
18:45:08 <nhnt11> aleth: status update: I've gone through logger.js and addressed your comments, and fixed a couple of other things (missing bind()s and parentheses). I've gone through the xpcshell documentation and looked at an example (https://mxr.mozilla.org/comm-central/source/mozilla/browser/base/content/test/chat/head.js#70). I'm currently writing tests for the getLog(Folder/File) functions, then I'll move on to logMessage().
18:45:11 <nhnt11> Phew :)
18:45:22 <aleth> Mook_as: we asked mconley, I think that's the extent of it ;)
18:45:51 <aleth> nhnt11: sounds good!
18:45:59 <aleth> Did those simplifications I suggested work?
18:46:00 <Mook_as> That's some sort of thought, close enough! :p
18:46:53 --> Rym has joined #instantbird
18:47:53 <nhnt11> aleth: You mean for the queuing thing? They should I think. Haven't tested anything, I thought that's what the tests were for.
18:47:59 <aleth> nhnt11: Here's an example for how to load the file into the scope of a test, and how to add fake accounts and such
18:48:01 <nhnt11> Maybe I should create a new profile and run this stuff though
18:48:25 <aleth> nhnt11: No worries, I somehow assumed you were testing this on a live IB.
18:48:25 <nhnt11> aleth: I've done Services.scriptLoader.loadSubScript
18:48:30 <aleth> gtg though
18:48:32 <aleth> http://mxr.mozilla.org/comm-central/source/chat/components/src/test/test_commands.js
18:48:46 <aleth> was what I wanted to link, but yes, thay's the right thing to use
18:48:46 <nhnt11> Yup, that's the example I saw.
18:48:54 <nhnt11> Alright.
18:49:08 <nhnt11> Bye!
18:50:26 <-- aleth has quit (Ping timeout)
18:51:17 --> gerard-majax_ has joined #instantbird
18:53:41 --> aleth has joined #instantbird
18:53:41 * ChanServ sets mode +o aleth 
18:57:29 <nhnt11> aleth: So I tested it on a live Ib. Stuff is broken :]
18:57:51 <aleth> I guess that's not surprising...
18:57:56 <nhnt11> Yeah
18:58:03 <aleth> What kind of broken?
18:58:34 <nhnt11> Some mistakes (renamed a variable wrong at one place)
18:58:48 <aleth> Continuing writing the tests first is probably as good a way to debug as any.
18:58:53 <nhnt11> 1 sec, let me eliminate these..
19:01:06 <-- jb1 has quit (Ping timeout)
19:03:47 <-- aleth has quit (Ping timeout)
19:04:23 <nhnt11> Hmm. It's saying the aAccount passed to getLogFolderForAccount is undefined
19:07:59 * nhnt11 finds mistakes
19:11:53 <-- Rym has quit (Ping timeout)
19:22:22 --> CaptainCalliope has joined #instantbird
19:26:16 <-- mayanktg has quit (Ping timeout)
19:27:42 --> mayanktg has joined #instantbird
19:30:35 <nhnt11> Aaah!
19:30:53 <nhnt11> Errors from Promise chains are hard to debug :(
19:31:17 <nhnt11> Turns out this.encoder didn't exist, but the error callback in then() didn't print anything :-/
19:31:48 * nhnt11 got lucky and realized he hadn't defined encoder in SystemLog.prototype
19:32:13 <nhnt11> Anyway, the system log for my account is being written properly :)
19:37:42 <nhnt11> And now conversation logs are being written too :)
19:44:43 <nhnt11> flo-retina: For conversation/account instances in tests, I can just create Objects with the relevant properties hardcoded, can't I?
19:44:57 <nhnt11> Or should I actually create a dummy imIAccount instance
19:45:25 <nhnt11> I think I can get away with a hardcoded object, because I'm really only using the account's name and so on.
19:46:07 <nhnt11> (the thing I'm testing is that these properties are being used properly, not really bothered about the actual values)
19:50:39 <-- dew has quit (Ping timeout)
20:04:21 --> Rym has joined #instantbird
20:04:56 <-- mayanktg has quit (Ping timeout)
20:11:09 --> mayanktg has joined #instantbird
20:16:22 <-- Vigilante has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
20:20:01 --> rosonline has joined #instantbird
20:22:37 * nhnt11 is a bit unsure what we're testing these getLogFolder/PathForBlabla functions for
20:22:53 <nhnt11> (that the correct path is returned? or that the folder is being created properly? or both?)
20:28:57 --> Even has joined #instantbird
20:28:57 * ChanServ sets mode +o Even 
20:29:11 --> clokep has joined #instantbird
20:29:11 * ChanServ sets mode +o clokep 
20:33:08 <clokep> nhnt11: Hard coded isfine.
20:33:29 <clokep> Mook_as: We gave it some thought, yes. SeaMonkey does not use it and chat/ is the only shared code so...yeah that was pretty mcuh it. :)
20:33:53 <Mook_as> yep, that sounds fine to me
20:34:31 <Mook_as> at least when I was at songbird, people surprisingly keep thinking I give good reviews just by asking random questions like that :p
20:34:36 <Mook_as> (komodo doesn't do reviews, sigh)
20:35:19 <nhnt11> clokep: So here, the comment says we want to append an underscore if the filename ends with a period or a space. But the regex appends an underscore if the filename already ends with an underscore too. https://mxr.mozilla.org/comm-central/source/chat/components/src/logger.js#43
20:35:56 <clokep> nhnt11: Well if you're using an _ as an escape character of some sort you'd definitely have to do that.
20:36:00 <nhnt11> Er, the regex doesn't append it, but the regex matches it, causing us to append..
20:36:08 <-- spiffytech has quit (Ping timeout)
20:36:21 --> spiffytech has joined #instantbird
20:36:25 <nhnt11> Underscore as an escape character in filenames?
20:36:25 <-- rosonline has quit (Ping timeout)
20:36:36 <Mook_as> right, how would you undo that underscore transform if you get a "foo _" file? did it originally have an underscore, or was it added?
20:36:53 <clokep> Exactly.
20:36:57 <clokep> Think of the reverse situation.
20:36:57 <nhnt11> Oh
20:36:59 <nhnt11> alright
20:37:00 <nhnt11> Thanks
20:37:04 <clokep> It'd be like no escaping a backslash in a string.
20:41:42 <nhnt11> This is slow work :-/
20:44:34 <-- Suiseiseki has quit (Connection reset by peer)
20:45:26 --> Suiseiseki has joined #instantbird
20:46:00 <clokep> nhnt11: And yes, debugging stuff like that kind of blows. :-\
20:46:22 * clokep wonders what progress sawrubh has made.
20:49:02 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:56:51 * Fallen is now known as Fallen|away
21:02:26 <clokep> nhnt11: Is there an easy way to write a JSON blob to a file?
21:03:34 <nhnt11> clokep: OS.File.writeAtomic(new TextEncoder().encode(<stringified json>))
21:03:50 <nhnt11> Assuming that by "blob" you mean a stringified object (idk what a blob is otherwise)
21:06:59 <clokep> Cool.
21:07:00 <clokep> Thanks. :)
21:08:03 <-- Rym has quit (Ping timeout)
21:08:09 <nhnt11> np
21:09:11 <mayanktg> clokep: Seems CSS guys are away ..could you tell if this is ok? http://i.imgur.com/K1tAjYZ.png
21:09:31 --> Rym has joined #instantbird
21:09:48 --> clokep_js has joined #instantbird
21:10:13 <clokep> mayanktg: It looks reasonable to me, yes.
21:10:17 <clokep> I'd request review again.
21:10:41 <mayanktg> Ok.
21:10:43 * nhnt11 wonders if we can have the panel to the left, so that it doesn't block the blist
21:10:52 <nhnt11> (just a thought, not trying to start a bikeshedding session :))
21:11:15 <-- clokep_js has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:11:29 <clokep> nhnt11: What if I put my buddy list on the left? ;)
21:11:36 <nhnt11> To the right then?
21:11:58 * nhnt11 shrugs
21:12:05 <nhnt11> Tests!
21:12:19 <clokep> ;)
21:15:31 --> rosonline has joined #instantbird
21:22:17 <-- rosonline has quit (Client exited)
21:24:35 <-- gerard-majax_ has quit (Ping timeout)
21:25:13 * clokep has no idea what to work on.
21:30:19 <nhnt11> clokep: Do you know offhand how to run a single test?
21:30:27 <nhnt11> s/single/standalone
21:31:11 <nhnt11> Ah.. got it
21:31:54 <clokep> :))
21:32:18 <nhnt11> Erm, I tried using mach and it said I need a Firefox, android, or b2g build
21:33:10 <clokep> Yeah, you have to use make.
21:33:33 <clokep> nhnt11: https://developer.mozilla.org/en-US/docs/MailNews_xpcshell-tests
21:33:40 <nhnt11> I'm there already :)
21:33:43 * nhnt11 trie
21:33:44 <nhnt11> s
21:33:56 <clokep> I should just go home, jeez.
21:35:43 <nhnt11> "Build configuration changed. Regenerating backend."
21:35:45 <nhnt11> :(
21:35:50 <nhnt11> Looks like I need to run a build..
21:35:58 <clokep> If it runs don't worry about it.
21:36:10 <nhnt11> It didn't run my tests
21:36:20 <clokep> Then, yes....mach build im/
21:36:40 * nhnt11 just did a mach build
21:36:57 <nhnt11> Hopefully it won't take too long... maybe I'll go fix myself a coffee ;)
21:37:06 <nhnt11> cup of*
21:37:50 <clokep> mayanktg: I answer one question and I get a review request?! :P
21:38:22 <nhnt11> My build failed :S
21:38:50 <mayanktg> clokep: :D
21:39:04 <nhnt11> ah, mach build im worked
21:39:40 <clokep> nhnt11: You can thank aleth for that.
21:39:53 <nhnt11> yeah :)
21:40:17 <nhnt11> Bah, still errors :(
21:40:45 <nhnt11> http://pastebin.instantbird.com/714720
21:40:52 <nhnt11> Maybe I should just clobber
21:41:21 <clokep> Yes.
21:41:37 <nhnt11> :(
21:41:43 * nhnt11 doesn't want to wait for a build at 3am
21:42:06 <nhnt11> bbl after my build
21:43:03 <clokep> nhnt11: Get up earlier? :P
21:43:26 <nhnt11> clokep: I got up at 7.30 today, that's /very/ early imo ;)
21:44:13 <clokep> I get up at 6. :P
21:44:18 <clokep> Seems late to me!
21:44:23 <-- Rym has quit (Ping timeout)
21:48:03 --> EionRobb has joined #instantbird
21:49:05 <nhnt11> clokep: http://pastebin.instantbird.com/714721
21:50:16 <clokep> nhnt11: So firrst of all...I don't think we need a lazy getter around L14-16 anymore
21:50:54 <nhnt11> Hmm I guess a variable would work yeah
21:51:26 <clokep> nhnt11: My second comment, declare each "task" as a separate function and then in run_test just do add_task(foo); add_task(bar);
21:51:33 <clokep> Just helps w/ the indentation.
21:51:45 <nhnt11> Alrighty
21:52:02 <clokep> nhnt11: Where is this "Assert.equal" thing? :-S
21:52:10 <clokep> I've never seen that before.
21:52:11 <nhnt11> clokep: Assert.jsm
21:52:20 <nhnt11> https://developer.mozilla.org/en/docs/Mozilla/JavaScript_code_modules/Assert.jsm
21:53:00 <clokep> nhnt11: OK maybe I shuld have said "Why?"
21:53:01 <nhnt11> The article on xpcshell tests "highly recommends" using it rather than do_check_eq, etc
21:53:22 <nhnt11> https://developer.mozilla.org/en-US/docs/Mozilla/QA/Writing_xpcshell-based_unit_tests#Assertions_and_logging
21:53:32 <clokep> Why? It seems like more of a PITA.
21:53:50 <clokep> Does it give a reason?
21:54:01 <nhnt11> "It implements the CommonJS Unit Testing specification version 1.1, which provides a basic, standardized interface for performing in-code logical assertions with optional, customizable error reporting."
21:54:18 <clokep> That doesn't seem like a good reason to me.
21:54:55 <clokep> There's no reason to change it, I just find it more difficult to read.
21:55:13 <nhnt11> Alright... It's used elsewhere in c-c too btw. https://mxr.mozilla.org/comm-central/search?string=assert.equal&find=chat&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
21:55:51 <clokep> Not in Instantbird.
21:56:01 <clokep> nhnt11: Those usages are all m-c, not c-c.
21:56:01 <nhnt11> Okay
21:56:07 <nhnt11> oh yeah.
21:56:09 <nhnt11> okay
21:56:48 <clokep> nhnt11: So why do you have a try-catch and then just throw the exception?
21:56:51 <clokep> Can't you just not catch it?
21:57:49 <nhnt11> That works? I figured if there's a "do_throw", I was supposed to use it :P
21:57:55 <nhnt11> Okay, I'll not catch it then.
21:58:47 <nhnt11> Ah, my build is done
21:59:32 <clokep> Hmm..
22:00:26 <clokep> I think that's if you want to throw an exception, not cathing an exception shuld also cause a failure.
22:01:13 <nhnt11> Right. According to MDN, do_throw causes the test to fail even if the throw is caught
22:01:34 <clokep> That's not how I read it.
22:01:50 <-- mconley has quit (Input/output error)
22:01:56 <clokep> Ah, well it says it can be CAUGHT, but will still cause it to FAIL.
22:01:59 <clokep> So...I don't know.
22:02:06 <clokep> I don't see any reason to not just let the error throw.
22:02:29 <nhnt11> Yeah, if we're not catching anything at all we're safe (in that the test will fail)
22:05:12 <nhnt11> v2: http://pastebin.instantbird.com/714732
22:07:11 <nhnt11> clokep: So I still can't run tests :-/
22:07:28 <nhnt11> I'm runing $make xpcshell-tests from my objdir, is that wrong?
22:08:21 <nhnt11> output: http://pastebin.instantbird.com/714733
22:11:52 <clokep> I usually do something like make -C objdir/chat/protocols/irc xpcshell-tests
22:12:55 <nhnt11> $make -C chat/components/src/ xpcshell-tests
22:12:55 <nhnt11> make: Nothing to be done for `xpcshell-tests'.
22:12:58 <nhnt11> :-/
22:13:45 <clokep> Hmm....
22:13:47 <clokep> Is it xpcshell-test?
22:13:50 <clokep> I always forget.
22:13:54 <nhnt11> no
22:14:01 <nhnt11> then it would say "no rule to make target.."
22:14:03 <clokep> You're in your objdir, right?
22:14:07 <nhnt11> Yes
22:14:41 <clokep> :-S same for me.
22:17:05 * nhnt11 asks in #maildev
22:24:13 <nhnt11> Bah
22:24:25 <nhnt11> I'm going to upload whatever I've got at the moment on the bug and go to bed I think
22:34:55 --> mconley has joined #instantbird
22:35:00 <nhnt11> Good night.
22:35:19 --> BWMerlin has joined #instantbird
22:37:59 --> jb has joined #instantbird
22:53:53 <-- jb has quit (Ping timeout)
22:57:39 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
23:36:02 --> Rym has joined #instantbird
23:49:48 <-- sonny has quit (Ping timeout)
23:51:53 <-- Rym has quit (Ping timeout)