#instantbird log on 05 20 2014

All times are UTC.

00:00:02 --> mconley|food has joined #instantbird
00:01:57 <-- mconley|food has quit (Input/output error)
00:09:23 --> raro has joined #instantbird
00:15:30 --> iamjayakumars has joined #instantbird
00:15:36 <-- iamjayakumars has quit (Client exited)
00:16:21 <-- raro has quit (Quit: http://www.kiwiirc.com/ - A hand crafted IRC client)
00:43:51 --> rosonline has joined #instantbird
01:08:25 <-- CaptainCalliope has quit (Quit: CaptainCalliope)
01:09:42 <-- nhnt11 has quit (Ping timeout)
01:11:41 --> nhnt11 has joined #instantbird
01:26:00 <clokep> nhnt11: ping
01:36:02 <clokep> nhnt11: Does your tabtest add-on actually work?
01:40:20 <-- rosonline has quit (Client exited)
01:43:59 <-- Rym has quit (Ping timeout)
01:44:15 --> Rym has joined #instantbird
02:08:48 --> CaptainCalliope has joined #instantbird
02:14:59 <-- flo-retina has quit (Ping timeout)
02:16:35 --> flo-retina has joined #instantbird
02:16:35 * ChanServ sets mode +qo flo-retina flo-retina 
02:17:51 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
02:47:14 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
02:48:45 --> mconley|food has joined #instantbird
03:11:49 <instantbot> New Chat Core - Yahoo! Messenger bug 1013034 filed by qheaden@phaseshiftsoftware.com.
03:11:51 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1013034 nor, --, ---, nobody, NEW, Conference messages aren't broadcast
03:20:47 <-- CaptainCalliope has quit (Quit: CaptainCalliope)
03:26:30 <-- mconley|food has quit (Input/output error)
03:43:24 <nhnt11> clokep: I used that addon to test out the tabbrowser changes from last year's community bonding period
03:43:29 <nhnt11> It's no longer relevant I think :)
04:18:33 --> mayanktg has joined #instantbird
04:27:06 <-- mayanktg has left #instantbird ()
04:28:28 --> mayanktg1 has joined #instantbird
04:29:12 <-- mayanktg1 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
04:29:38 --> mayanktg has joined #instantbird
04:36:16 <-- nhnt11 has left #instantbird ()
04:36:18 --> nhnt11 has joined #instantbird
04:40:58 <-- mayanktg has quit (Client exited)
04:42:20 --> mayanktg has joined #instantbird
05:09:36 <-- nhnt11 has quit (Ping timeout)
05:09:53 --> nhnt11 has joined #instantbird
05:14:56 <-- mayanktg has quit (Ping timeout)
05:16:36 --> mayanktg has joined #instantbird
05:20:26 <mayanktg> flo-retina: Hey! I tried the WebRTC patch yesterday. It works in Ib :) Though I wasn't able to make someone accept the calls. But /call did work.
05:35:28 <-- nhnt11 has quit (Ping timeout)
05:36:00 --> nhnt11 has joined #instantbird
05:37:45 <-- EionRobb has quit (Quit: Leaving.)
05:45:17 <-- Rym has quit (Ping timeout)
05:46:56 --> Rym has joined #instantbird
05:47:40 <-- mayanktg has quit (Ping timeout)
05:51:34 --> mayanktg has joined #instantbird
06:07:32 * Fallen|away is now known as Fallen
06:20:40 --> mpmc has joined #instantbird
06:22:24 <-- mayanktg has quit (Ping timeout)
06:22:44 --> mayanktg has joined #instantbird
06:53:58 --> chrisccoulson has joined #instantbird
06:55:34 <-- mayanktg has quit (Ping timeout)
06:56:01 --> mayanktg has joined #instantbird
06:56:48 --> EionRobb has joined #instantbird
07:07:16 --> Mic has joined #instantbird
07:07:17 * ChanServ sets mode +o Mic 
07:10:12 <mayanktg> can someone please help in adding left getter support in XMPP MUC?
07:10:50 <EionRobb> what's a left getter?
07:12:34 <mayanktg> EionRobb: Hello http://mxr.mozilla.org/comm-central/source/chat/components/public/prplIConversation.idl#116 Its to notify if a person closes the conversation.
07:13:10 <EionRobb> oic that kind of "left"
07:13:41 <mayanktg> I have to add the support in XMPP MUC.  Yeah 
07:15:16 <EionRobb> that's an interesting 'fixme' on line 143.  the answer there if anyone cares is that yes you can have an alias with no buddy
07:20:11 <-- mayanktg has quit (Ping timeout)
07:20:28 --> mayanktg has joined #instantbird
07:26:51 <Mic> mayanktg: what kind of help do you need?
07:29:06 <mayanktg> Mic: I have gone throuch XMPPMUCConversationPrototype. I need to know where should I use left getter? We have to send a stanza stating that user has left the conversation ...right?
07:29:55 <mayanktg> correct me if I'm wrong or missing soething...
07:30:00 <Mic> Which bug number is that?
07:30:24 <mayanktg> Bug 1000477
07:30:26 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1000477 nor, --, ---, saurabhanandiit, NEW, Implement the left getter for XMPP MUCs
07:30:28 <Mic> Thanks
07:30:48 <Mic> Umm...
07:31:58 <Mic> ... very detailed.
07:32:29 <flo-retina> are we automatically rejoining MUCs after an account is disconnected?
07:32:50 <flo-retina> If not a good way to reproduce is: 1. connect account 2. join MUC 3. Disconnect account. 4. reconnect, and check that the MUC has the "left" icon
07:33:04 <mayanktg> flo-retina: ok.
07:36:44 <Mic> Meh @ https://mxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm#1192
07:37:05 <Mic> Because "no icon" is better than the old icon? :S
07:37:28 <Mic> I never liked that we don't have icons for offline contacts...
07:37:56 <nhnt11> offline accounts* but yeah!
07:38:07 <Mic> nhnt11: right
07:38:08 <-- mayanktg has quit (Ping timeout)
07:38:35 <nhnt11> Hmm can't reproduce that
07:38:52 <nhnt11> I disconnected my gtalk/fb accounts and the contacts still have icons
07:39:06 <nhnt11> Do they do something different from the js-xmpp base?
07:39:43 --> mayanktg has joined #instantbird
07:41:29 <Mic> Did you connect the account before or was it disconnected since you started?
07:42:00 <mayanktg> flo-retina: I can automatically re-join the channel if I have added it to the list of "auto-joined channels". where's the "left" icon? I can find no change in Channel conversation window if I disconnect y account. accept for a notidfication "Your account is disconnected."
07:42:34 <flo-retina> "I can find no change in Channel conversation window if I disconnect y account." that's the bug you are trying to fix, right?
07:42:51 <flo-retina> compare with the behavior of IRC channels
07:42:58 <Mic> mayanktg: /part an IRC channel and check the icon on the tab.
07:43:01 <flo-retina> you'll see a grey dot in the bottom right corner of the icon in the tab
07:44:14 <nhnt11> Mic: It was connected before. Is this something that happens at startup?
07:45:02 <mayanktg> Mic: Yes the XMPP MUC has a change in icon if I disconnect the account
07:47:46 <-- Rym has quit (Ping timeout)
07:51:19 <mayanktg> Mic: I'm able to automatically join MUC after I have reconnected my account..
07:54:22 <Mic> nhnt11: I think it might make a difference if you connect the account. I'd try starting with the account disconnected and see if there are icons.
07:54:48 <Mic> If not, then you're seeing the problem that's annoying me.
07:55:20 <Mic> https://mxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm#1186
07:55:31 <Mic> mayanktg, flo-retina: ^
07:56:06 <Mic> bye
07:56:06 <flo-retina> ah!
07:56:10 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
08:02:49 <mayanktg> flo-retina: I couldn't understand it. muc.left has been set true here. But it should have been true if we have left the conversation but kept the tab open? I'm confused :-/
08:03:34 <mayanktg> Whats wrong here?
08:07:21 <flo-retina> I don't understand your question
08:09:40 <-- mayanktg has quit (Ping timeout)
08:10:21 --> Mic|mobile has joined #instantbird
08:11:16 --> mayanktg has joined #instantbird
08:11:38 <mayanktg> flo-retina: Can you tell what left getter does?
08:12:34 <mayanktg> I'm unable to have an idea of what I have to do in the Bug 1000477
08:12:37 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1000477 nor, --, ---, saurabhanandiit, NEW, Implement the left getter for XMPP MUCs
08:16:28 <-- Mic|mobile has quit (Connection reset by peer)
08:16:33 --> Mic|mobile has joined #instantbird
08:20:47 <-- Mic|mobile has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
08:35:34 --> aleth has joined #instantbird
08:35:35 * ChanServ sets mode +o aleth 
08:36:19 <-- aleth has quit (Quit: exit stage left)
08:36:31 --> aleth has joined #instantbird
08:36:31 * ChanServ sets mode +o aleth 
08:40:13 <-- aleth has quit (Quit: exit stage left)
08:40:15 --> aleth has joined #instantbird
08:40:16 * ChanServ sets mode +o aleth 
08:51:01 <nhnt11> mayanktg: Here's my guess: all MUCs have a flag, "left" which indicates that you've left that chat. In javascript, this flag is implemented as a getter, and you need to do this for XMPP
08:51:27 <nhnt11> Ah, maybe aleth can confirm that? ^
08:51:50 <aleth> Yes, that's right.
08:52:25 <aleth> It's a boolean, usually implemented with a getter, because it's marked as read-only in the interface (so from the outside you can't set it).
08:52:40 <mayanktg> nhnt11: Yes. I have understood it now  After reconnecting the "icon" is still displayed offline. We have implement this getter.. 
08:53:01 <aleth> Reconnecting isn't implemented for XMPP MUCs.
08:53:13 <mayanktg> ok
08:53:15 <aleth> The point is, when you leave the room, the UI should show you have left it.
08:53:40 <aleth> Try "/part" in an IRC channel and see what happens to the icon on the tab for example.
08:53:53 <nhnt11> mayanktg: See this: https://mxr.mozilla.org/comm-central/source/chat/modules/jsProtoHelper.jsm#578
08:54:19 <nhnt11> You basically need to set this._left on the XMPP ConvChat instance when the user leaves it
08:54:23 <mayanktg> aleth: Yes. i have tried "/part"
08:54:34 <aleth> mayanktg: So you know what the expected behaviour is now?
08:54:42 <mayanktg> nhnt11: Ok. 
08:55:16 <aleth> Notice you are inheriting the code nhnt11 just pointed at already.
08:55:56 <mayanktg> aleth: Yes. When a user leaves the chat the icon should be marked as we have in IRC...
08:56:27 <aleth> mayanktg: And all you need to do for that to happen is make sure this.left = true when the user leaves the room.
08:57:12 <mayanktg> aleth: ok.. :)
08:57:37 <aleth> Because the setter in jsProtoHelper already informs the UI for you (take a look at that code!)
08:59:28 <aleth> mayanktg: "I can find no change in Channel conversation window if I disconnect y account" is exactly what you are supposed to fix ;)
09:00:00 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:00:09 <mayanktg> aleth: Yeah I understood it now :) Thats what flo said :-|
09:00:20 <aleth> ahaha ok :D
09:00:50 <aleth> "I'm able to automatically join MUC after I have reconnected my account.." this is *only* true if the MUC is in the autojoin list.
09:01:26 * sawrubh gets deja vu seeing mayanktg
09:01:39 --> BWMerlin has joined #instantbird
09:01:47 <aleth> I guess I should read the logs ;)
09:02:06 * nhnt11 is having starting trouble on logger.js
09:02:35 <aleth> What kind of trouble? "This file is ugly" kind of trouble?
09:02:44 <nhnt11> Er... yeah :]
09:02:50 <aleth> :D
09:03:12 <nhnt11> I considered creating a new file and writing it from scratch at one point
09:03:31 <nhnt11> (to keep track of what I had and hadn't made async at any point)
09:03:35 <aleth> Feel free to tidy it up in the process.
09:05:43 <aleth> It may even help to write the tests first?
09:06:08 <nhnt11> "the tests" makes me think you've got specific tests in mind already?
09:07:04 <aleth> Just the usual (use the methods in the interface and check they do the right thing)
09:07:30 <nhnt11> Okay
09:08:07 <aleth> The drawback is that tests are slightly different for async code.
09:09:00 <aleth> So I'm not sure it's worth doing first unless you find it helpful.
09:09:02 <aleth> https://developer.mozilla.org/en-US/docs/Mozilla/QA/Writing_xpcshell-based_unit_tests
09:09:37 <nhnt11> Hmm
09:09:44 <nhnt11> I think I'll do the tests after the asyncification
09:10:54 <-- mayanktg has quit (Ping timeout)
09:11:07 --> mayanktg has joined #instantbird
09:11:16 <aleth> Are you starting with async writing of logs?
09:11:36 <nhnt11> Yeah
09:11:51 <aleth> The reading part is harder and possibly should be left till later because it will require interface changes.
09:11:52 <nhnt11> Reading is more tricky, I'd presume
09:11:56 <nhnt11> Yeah
09:12:21 <nhnt11> aleth: I was thinking of async-ifying the reading part for the API
09:12:23 <aleth> "Harder" mainly because logger.js is shared with TB of course.
09:12:31 <nhnt11> (if you want to go by the terminology i've used in my proposal)
09:12:44 <aleth> You'd have to, yes.
09:13:00 <nhnt11> No I meant
09:13:10 <nhnt11> I was thinking of doing it then rather than now
09:13:15 <aleth> OK.
09:13:47 * nhnt11 grabs some coffee
09:20:40 <-- mayanktg has quit (Ping timeout)
09:21:24 --> mayanktg has joined #instantbird
09:25:31 --> flo-retina has joined #instantbird
09:25:31 * ChanServ sets mode +qo flo-retina flo-retina 
09:31:04 <-- mayanktg has quit (Ping timeout)
09:32:30 --> mayanktg has joined #instantbird
09:35:13 <-- mayanktg has quit (Ping timeout)
09:35:45 --> mayanktg has joined #instantbird
09:37:25 <-- mayanktg has quit (Ping timeout)
10:03:25 --> clokep has joined #instantbird
10:03:26 * ChanServ sets mode +o clokep 
10:06:28 <-- aleth has quit (Ping timeout)
10:21:36 <clokep> nhnt11: Why is it no longer relevant? Isn't it an example? :-S
10:23:44 --> mayanktg has joined #instantbird
10:25:55 <clokep> nhnt11: I guess my second question then is "Do you have an example of an extension that adds tabs?"
10:27:37 <-- flo-retina has quit (Ping timeout)
10:27:56 --> sonny has joined #instantbird
10:29:05 --> flo-retina has joined #instantbird
10:29:05 * ChanServ sets mode +qo flo-retina flo-retina 
10:36:59 --> aleth has joined #instantbird
10:36:59 * ChanServ sets mode +o aleth 
10:37:31 <-- flo-retina has quit (Ping timeout)
10:39:11 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:42:00 <-- sonny has quit (Ping timeout)
10:47:01 --> flo-retina has joined #instantbird
10:47:01 * ChanServ sets mode +qo flo-retina flo-retina 
10:50:46 --> sonny has joined #instantbird
10:56:41 --> Mic|mobile has joined #instantbird
10:57:42 <Mic|mobile> Mayanktg, aleth: have you found out if there *is* a bug?
10:58:01 <aleth> What bug?
10:58:24 <Mic|mobile> The left getter bug.
10:59:19 <Mic|mobile> Mayanktg said that he saw a change of icon when disconnecting...
10:59:28 <-- mayanktg has quit (Ping timeout)
10:59:43 <Mic|mobile> ... that's speaking against it.
11:00:26 <aleth> Well, if there's no bug, that's great :)
11:00:37 <aleth> I wonder who/what fixed it though.
11:01:07 <flo-retina> it seems we set .left = true when the account is disconnected
11:01:17 <flo-retina> that doesn't mean it's set when we part a MUC
11:01:23 <flo-retina> (is /part supported BTW?)
11:01:30 <Mic|mobile> I wonder why that bug report wass filed tbh
11:01:30 --> mayanktg has joined #instantbird
11:01:42 <aleth> No, the /part command is missing.
11:02:00 <flo-retina> because we thought something wasn't finished there
11:02:06 <Mic|mobile> The bug should say these things.
11:02:55 <flo-retina> Mic|mobile: it seems to be originally from https://bugzilla.mozilla.org/show_bug.cgi?id=954959#c0
11:02:57 <instantbot> Bug 954959 nor, --, ---, nobody, NEW, Finish the implementation of basic MUC support in JS-XMPP
11:06:08 * aleth wonders if adding a /part command would be a useful task for mayanktg or not
11:06:27 <flo-retina> what's the status with the WebRTC bug?
11:07:00 <aleth> Mic|mobile: I'm sorry, when I suggested that bug I assumed it would be obvious what was missing ;)
11:08:28 <mayanktg> flo-retina: I have added the crop feature in it. Now the image doesn't get squeezed  (gets converted from 4:3 to 1:1). Also I added the "remove icon" with hover effect to it 
11:08:41 <flo-retina> mayanktg: I meant the gUMD bug
11:09:09 <mayanktg> oh. The patch didn't work. Its still dependednt on gUM
11:09:23 <Mic|mobile> Can someone copy the information from thw other bug to the new one or  post a link to thw old one ("Spun off from bug...")
11:09:45 <mayanktg> I applied the patch, did a complete Ib build. But still it seemed to be dependent on gUM. 
11:10:02 <Mic|mobile> I gtg...
11:10:07 <-- Mic|mobile has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
11:10:08 <flo-retina> there's not much more info there unfortunately. That original bug was basically a dump of what remained of my JS-XMPP todo list when I stopped working on it
11:10:23 <flo-retina> mayanktg: can you reproduce the issue on Firefox?
11:10:28 <flo-retina> mayanktg: in the scratchpad?
11:10:40 <flo-retina> mayanktg: if we want jiib to fix the bug, we need to give him a way to reproduce.
11:11:00 <aleth> mayanktg: If someone requests feedback from you in a bug, you should set the feedback flag to f+ or f- when you reply.
11:11:14 <mayanktg> flo-retina: Ok. I will try that in Firefox. 
11:12:05 <mayanktg> aleth: ok :-|
11:12:26 <aleth> mayanktg: Click on "details" next to the attachment and you will see a dropdown
11:13:21 <mayanktg> flo-retina: I will apply the patch in Firefox and build ff to see if that's running in scrathpad or not. 
11:13:40 <flo-retina> mayanktg: try to reproduce without the patch first!
11:14:49 <aleth> flo-retina: Won't that fail due to the lack of chrome privileges anyway?
11:15:44 <flo-retina> aleth: Tools -> Web Developer -> Scratchpad. Then in the new window that opens, Environment -> Browser
11:17:17 <aleth> I don't see any Environment menu.
11:17:28 <-- sonny has quit (Ping timeout)
11:18:12 <flo-retina> aleth: you may need to set devtools.chrome.enabled to true in about:config for it to appear
11:18:33 <aleth> Ah, that's possible. Thanks!
11:18:40 <flo-retina> indeed
11:18:41 <aleth> mayanktg ^^
11:18:49 <flo-retina> setting that to false makes the environment menu disappear
11:19:39 <mayanktg> aleth: Yeah. I'm trying to reproduce it in ff :)
11:22:57 <-- EionRobb has quit (Quit: Leaving.)
11:25:49 <-- flo-retina has quit (Ping timeout)
11:26:17 --> flo-retina has joined #instantbird
11:26:17 * ChanServ sets mode +qo flo-retina flo-retina 
11:26:44 <flo-retina> do we have plans for a release "soon"?
11:26:51 * flo-retina is wondering if we should start making a list of 'blocker" bugs
11:27:09 <aleth> do we know how to release with trains yet?
11:27:18 <flo-retina> no
11:27:26 <aleth> Linux seems the biggest blocker atm.
11:27:28 <flo-retina> but we will never know if we don't even attempt to figure it out ;)
11:27:39 <flo-retina> Linux just needs motivation
11:28:02 <flo-retina> we either need to go ahead and ask for the help we need; or decide that we don't care about old versions, and install an ubuntu lts that we know how to handle
11:29:33 --> jb has joined #instantbird
11:29:41 <aleth> Whether the first option will work probably depends on whether you know of a friendly person to ask ;)
11:30:21 <aleth> iirc I asked on #it a long time ago and didn't get very far.
11:30:30 <flo-retina> aleth: I do
11:30:39 <flo-retina> what's not clear is _what_ we want to ask :-S
11:31:02 <aleth> I guess that depends on Even's preferences? ;)
11:32:45 <-- mayanktg has quit (Ping timeout)
11:35:04 --> mayanktg has joined #instantbird
11:35:17 <mayanktg> flo-retina: mGUMD runs and displays the number of devices in the browser console..but it doesn't even after adding gUM. I am using the browser environment.
11:35:40 <flo-retina> "it doesn't even after adding gUM." what does this mean?
11:36:22 <aleth> i.e. pastebin your scratchpad code ;)
11:36:48 <aleth> Btw nhnt11 wrote an add-on to make pastebinning easier ;)
11:39:04 <mayanktg> flo-retina: http://pastebin.instantbird.com/713143
11:43:39 <mayanktg> aleth: Thanks...installed :) nhnt11 Thanks!
11:45:23 <-- mayanktg has quit (Ping timeout)
11:45:49 --> mayanktg has joined #instantbird
11:47:17 <-- aleth has quit (Ping timeout)
11:49:32 --> unghost has joined #instantbird
11:52:07 --> clokep_work has joined #instantbird
11:52:07 * ChanServ sets mode +o clokep_work 
11:53:03 --> aleth has joined #instantbird
11:53:03 * ChanServ sets mode +o aleth 
12:05:46 <clokep_work> flo-retina: I think we should try to release "soon", so a list of blockers is a good place to start.
12:06:36 * aleth pings qheaden!
12:11:48 <clokep_work> What for?
12:12:16 <clokep_work> aleth: Thanks for the reviews btw. :)
12:12:21 <clokep_work> (And flo-retina!)
12:12:39 <aleth> clokep_work: I'm thinking he might like to have JS-Yahoo in 1.6 ;)
12:15:05 <-- BWMerlin has quit (Quit: BWMerlin)
12:15:33 <clokep_work> Ah.
12:15:46 <clokep_work> aleth: Are you making a blocker list then?
12:16:41 <instantbot> New Instantbird - Conversation bug 1013236 filed by aleth@instantbird.org.
12:16:43 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1013236 nor, --, ---, aleth, ASSI, [regression] Status indicator stretched in tooltips with user icon
12:18:17 <aleth> clokep_work: well, I filed a blocker ;)
12:18:25 <aleth> Good place to start.
12:23:36 <nhnt11> mayanktg: Let me know how you like the addon
12:23:57 <nhnt11> I've been procrastinating on adding a few improvements that it needs for a while now..
12:25:56 * Fallen is now known as Fallen|away
12:28:03 <clokep_work> Oh bleh, we should check in that Prototype bug.
12:28:09 <clokep_work> nhnt11: I asked you some questions earlier in the log. :)
12:31:17 <nhnt11> clokep_work: I used that example as a way to test out the tabbrowser changes as I made them
12:31:31 <nhnt11> Without having to clean up debugging code later
12:31:42 <nhnt11> I think it actually uses a tabbrowser method that's no longer there?
12:32:01 <nhnt11> clokep_work: If you'd like me to write an example of an addon that adds tabs for reference purposes, I wouldn't mind :)
12:34:58 <clokep_work> nhnt11: Nah it's OK. I might just have question. ;) I'll have to read the documentation you had written. You have more important things to do, like rewrite logger.js.
12:35:15 <clokep_work> (Or I could always just dump to the error console. :P)
12:35:29 <clokep_work> aleth, flo-retina: My IRC version stats add-on works from a backend POV. :)
12:35:33 <clokep_work> Ran it last night on #chatdev.
12:36:03 <aleth> heh, neat.
12:36:10 <aleth> Probably not an interesting channel to run it in though ;)
12:43:00 <clokep_work> No, but I figured people wouldn't get angry if I spammed them. ;)
12:47:44 <flo-retina> aleth: the broken throbber on retina screen is also a blocker
12:48:07 <aleth> Right.
12:48:07 <nhnt11> Ah, that broken throbber is only on retina?
12:48:19 <aleth> Yes, and someone on retina has to fix it ;)
12:48:23 <nhnt11> :P
12:48:40 <flo-retina> ah, it seems nhnt11 is volunteering to fix it ;)
12:48:48 <nhnt11> aleth, flo-retina: The huge status indicator dot on buddy tooltip icons is a blocker too
12:49:00 <aleth> nhnt11: See above
12:49:01 <flo-retina> nhnt11: aleth has already marked it so
12:49:18 <nhnt11> Okay okay
12:49:31 <aleth> Thanks anyway
12:49:37 <nhnt11> It seems saying something in Instantbird when bugs are being discussed automatically makes you a volunteer ;)
12:49:42 <nhnt11> #instantbird*
12:50:26 <flo-retina> nhnt11: no, just when you look like you've got nothing to do :-P
12:50:32 <aleth> You can also volunteer to ignore that kind of poking ;)
12:53:25 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:53:30 <nhnt11> In this case I actually don't mind looking at it though :)
12:53:43 <nhnt11> I'm going out for dinner and have enough time for a small bug before I do
12:53:53 <aleth> Probably just a matter of DOM Inspectoring the tab...
12:54:08 <nhnt11> (my impromptu nap means I'll be staying up late)
12:54:09 <flo-retina> yeah
12:54:30 <flo-retina> just use DOMi on a tab that keeps the throbber forever (eg. a password protected channel)
12:54:45 <clokep_work> aleth: Any opinions on my comment in bug 1012660?
12:54:48 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1012660 nor, --, ---, clokep, ASSI, Remove _chatRoomFieldsList from IRC code
12:55:09 <nhnt11> flo-retina: Example existing password-protected channel please?
12:55:23 <nhnt11> Ah, #moco works
12:55:25 <aleth> clokep_work: I'm happy with those comments.
12:56:58 <clokep_work> Oh, boo. I need to mark these as joining = false...
13:07:37 --> rosonline has joined #instantbird
13:16:14 <nhnt11> aleth, flo-retina: I fixed it with -moz-image-region, that's acceptable right?
13:17:05 <flo-retina> nhnt11: I don't know that code, would need to look at a diff and the surrounding code to have an opinion
13:17:14 <nhnt11> Alright. I'll attach a patch
13:17:32 <aleth> I was wondering why the retina CSS I copied that style from doesn't fail similarly.
13:17:56 <nhnt11> aleth: Have you specified a moz-image-region anywhere else for non-retina icons/
13:18:10 <nhnt11> i didn't see that but maybe I missed it?
13:18:34 <nhnt11> Is there a bug filed for this already?
13:19:08 <clokep_work> nhnt11: Yes. It was filed above in the log.
13:19:10 <nhnt11> Found it
13:19:13 <flo-retina> nhnt11: bug 1009284
13:19:15 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1009284 min, --, ---, nobody, NEW, Joining throbber sometimes only shows top left corner
13:19:18 <nhnt11> Thanks
13:20:40 <nhnt11> Why is bugzilla submitting my patches without me clicking submit these days? :S
13:20:48 <nhnt11> Second time this is happening...
13:21:29 <clokep_work> Did ou click enter? I've never heard of that happening.
13:21:35 <nhnt11> No, I didn't
13:21:40 <nhnt11> I was scrolling down when it happened
13:22:06 <nhnt11> I'll be alert next time and try and figure out if I'm doing something wrong before filing a bug or whatever
13:23:03 <aleth> This is ugly http://puu.sh/8TOK4.png
13:24:21 <-- mayanktg has quit (Ping timeout)
13:24:22 <flo-retina> nhnt11: it happened to me once when I typed enter in an auto-complete popup
13:24:39 <nhnt11> Hmm. I don't remember exactly what I was doing so..
13:24:40 <aleth> It's happened to me too.
13:24:48 --> mayanktg has joined #instantbird
13:27:34 <clokep_work> aleth: Yes! It is!
13:28:36 <flo-retina> nhnt11: have you found what's used for the other tab icons?
13:28:42 <nhnt11> flo-retina: Setting min/max-width/height isn't working
13:28:42 * Fallen|away is now known as Fallen
13:28:45 * clokep_work has no idea what moz-image-region does. . .
13:28:55 <flo-retina> clokep_work: it uses a subset of an image
13:29:01 <nhnt11> One sec
13:29:11 <clokep_work> flo-retina: That would be a really weird fix here, no? :-S
13:29:21 <flo-retina> clokep_work: right
13:29:28 <flo-retina> clokep_work: that's why I'm asking questions ;)
13:31:05 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
13:31:16 --> flo-thinkpad has joined #instantbird
13:31:34 <nhnt11> flo-retina: Using min/max-width/height causes this ugliness in the tabstrip: http://puu.sh/8TPeY.png
13:32:09 <flo-retina> it also doesn't seem to fix the issue ;)
13:32:15 <nhnt11> yeah
13:32:43 <flo-retina> nhnt11: but you are applying that on ".tabbrowser-tab[chat][status="joining"]" ? :-S
13:33:10 <nhnt11> :]
13:33:11 <nhnt11> oops
13:33:31 <flo-retina> nhnt11: there's http://mxr.mozilla.org/comm-central/source/im/themes/tabbrowser-pinstripe/tabbrowser.css#33
13:33:39 <flo-retina> what's causing it to have no effect in this case?
13:34:17 <-- mayanktg has quit (Ping timeout)
13:34:23 <nhnt11> flo-retina: The icon /is/ the correct size, just that the image source isn't being scaled
13:34:26 <flo-retina> how are we setting the other icons?
13:34:36 <nhnt11> I guess width/height are supposed to take care ofthat..
13:34:44 <nhnt11> flo-retina: We don't have retina icons for other ones
13:34:57 <instantbot> New Instantbird - Contacts window bug 1013277 filed by aleth@instantbird.org.
13:34:58 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1013277 nor, --, ---, nobody, NEW, Contact request CSS is not pretty
13:35:07 <flo-retina> aaah!
13:35:15 <nhnt11> Hmm, the new conversation icon has a retina version iirc
13:35:28 <-- flo-thinkpad has quit (Ping timeout)
13:35:29 <flo-retina> nhnt11: yes http://mxr.mozilla.org/comm-central/source/im/themes/tabbrowser-pinstripe/tabbrowser.css#489
13:35:47 <nhnt11> Ah, we're using -moz-image-region there!
13:35:57 * flo-retina wonders what Firefox is doing
13:36:01 --> flo-thinkpad has joined #instantbird
13:36:03 <aleth> So that's a sneaky way to set the size?
13:36:36 <aleth> nhnt11: Hmm no,  in that case the icon actually contains multiple images.
13:36:41 <flo-retina> http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/browser.css#2738 hmm
13:36:43 <aleth> Look at the hover/active states
13:36:49 <clokep_work> aleth: Hope oyu don't mind, I renamed that. I think the issue is that the result is not pretty, not that the CSS isn't. :-D
13:37:01 <nhnt11> aleth: Ah!
13:37:07 <nhnt11> That's not the icon i was thinking of
13:37:14 <aleth> clokep_work: That's fine, I was being euphemistic anyway ;)
13:37:15 <nhnt11> flo-retina, aleth: I was thinking of the favicon for the awesometab
13:37:45 <nhnt11> We don't have a @2x version of that btw
13:37:49 <nhnt11> So I guess this is the first case :)
13:37:51 <flo-retina> nhnt11: http://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/tabs.inc.css#69
13:39:22 <nhnt11> Here's the @2x code for that: https://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/browser.css#2734
13:39:26 <-- flo-thinkpad has quit (Ping timeout)
13:39:27 <nhnt11> I don't see any changes :-/
13:39:32 --> flo-thinkpad has joined #instantbird
13:40:01 * flo-retina wonders what image-rendering: -moz-crisp-edges; does
13:40:26 <nhnt11> Sorry, but I've really got to go
13:40:31 <flo-retina> so I guess one wayto fix this sizing issue isto port Australis ;)
13:40:33 <nhnt11> Bbl!
13:41:37 * aleth wonders if moz-crisp-edges should be applied to everything for a really crisp UI ;)
13:42:50 <-- flo-thinkpad has quit (Ping timeout)
13:54:00 --> iamjayakumars has joined #instantbird
13:56:31 --> mayanktg has joined #instantbird
13:58:21 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
14:00:07 --> chrisccoulson has joined #instantbird
14:06:30 --> flo-thinkpad has joined #instantbird
14:06:44 <clokep_work> aleth: Thanks.
14:13:26 --> mconley|food has joined #instantbird
14:13:54 <-- flo-thinkpad has quit (Ping timeout)
14:14:19 --> flo-thinkpad has joined #instantbird
14:15:54 <-- aleth has quit (Ping timeout)
14:38:23 <-- flo-thinkpad has quit (Ping timeout)
14:38:57 <clokep_work> Anyone looked at that new localization email?
14:39:40 <flo-retina> I opened this morning, and then marked it as unread
14:40:57 <-- mayanktg has quit (Ping timeout)
14:42:10 <clokep_work> Same thing I did. :-[
14:42:24 --> aleth has joined #instantbird
14:42:25 * ChanServ sets mode +o aleth 
14:45:10 --> flo-thinkpad has joined #instantbird
14:50:16 --> wnayes has joined #instantbird
14:52:22 --> rosonline has joined #instantbird
14:55:04 <clokep_work> aleth: "jcranmer: You've been looking into this I think - how do you specify a Promise return value in an XPCOM IDL?" Hmmm????
14:56:14 * Fallen is now known as Fallen|away
14:56:26 <-- flo-thinkpad has quit (Ping timeout)
14:56:43 --> flo-thinkpad has joined #instantbird
14:57:08 <aleth> clokep_work: hmm?
14:58:51 --> sonny has joined #instantbird
15:01:29 <-- sonny has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:02:05 <instantbot> New Instantbird - Other bug 1013307 filed by aleth@instantbird.org.
15:02:08 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1013307 nor, --, ---, nobody, NEW, Shutdown error: illegal operation
15:03:54 <-- jb has quit (Ping timeout)
15:04:23 <clokep_work> aleth: Wondering why you're asking that. :)
15:04:57 <aleth> clokep_work: Thinking a bit about nhnt11's async stuff earlier, I realized I didn't know.
15:04:57 <clokep_work> Bah aleth is finding all the errors. . .
15:05:17 <aleth> It's a new one.
15:05:33 --> mayanktg has joined #instantbird
15:06:17 <-- flo-thinkpad has quit (Ping timeout)
15:06:47 --> flo-thinkpad has joined #instantbird
15:08:38 <aleth> The puzzling question is "what are we doing in Core::init()" during shutdown ;)
15:10:32 <clokep_work> Any add-ons?
15:11:18 <aleth> Not in my dev profile.
15:14:02 <-- flo-thinkpad has quit (Ping timeout)
15:14:42 --> flo-thinkpad has joined #instantbird
15:16:52 * mconley|food is now known as mconley
15:17:29 <-- flo-thinkpad has quit (Ping timeout)
15:18:18 --> flo-thinkpad has joined #instantbird
15:20:20 --> Rym has joined #instantbird
15:20:55 <-- flo-thinkpad has quit (Ping timeout)
15:24:29 <sawrubh> clokep_work: yo
15:24:41 <sawrubh> sorry I had dozed of yesterday when you pinged me
15:25:15 <sawrubh> I was busy with something during the day but am working now on that setting the topic thing and we can have a chat about the UI when you want
15:25:28 <sawrubh> also I figured out the problem with that setting the topic bug
15:26:24 <sawrubh> so right now, in the onMessageStanza body, we check if body is undefined and do nothing if that's the case (which is wrong)
15:26:47 --> flo-thinkpad has joined #instantbird
15:27:53 <sawrubh> since the message I receive from the server doesn't have the body element in it, so the check here (http://mxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm#874) isn't satisfied
15:28:48 <sawrubh> replace 'in the onMessageStanza body' with 'in the onMessageStanza logic'
15:33:07 <sawrubh> ..which made me think how did the patch in bug 998609 work (because I had tested it myself that time and it had been working)
15:33:10 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=998609 enh, --, 1.6, saurabhanandiit, RESO FIXED, Support topics in XMPP MUCs
15:36:41 <aleth> That function looks like it could do with some polishing.
15:37:12 <-- iamjayakumars has quit (Client exited)
15:37:56 <clokep_work> sawrubh: The one I was getting had a body too, so that's how it worked for me. :)
15:38:28 <clokep_work> sawrubh: Alright so looks like you k now what needs to be worked on then! :) Let me know if you have any questions.
15:38:33 <clokep_work> And yes, we should discuss UI at some point.
15:38:40 <clokep_work> aleth and flo-retina probably want to discuss it too.
15:38:45 <clokep_work> (Probably more so than me. :P)
15:39:10 <sawrubh> I'm ready whenever they are
15:39:41 <aleth> To start out with, is any UI required for Filelink that is not inherited (eg the Preferences pane)? You just drag and drop and then use a notification bar...
15:40:59 <sawrubh> by the notif bar you meant the progress bar?
15:41:52 <sawrubh> yeah, so before you (or someone) suggested I had the plans to add a 'paper clip' or 'attach' icon in the conversation window, clicking on which would do the dance
15:41:57 <sawrubh> now the dance is
15:42:07 <aleth> No, one of these https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/notificationbox
15:42:15 <sawrubh> v1) selecting the file and only using FileLinks
15:42:35 <flo-retina> aleth: bug 1013307 isn't new.
15:42:38 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1013307 nor, --, ---, nobody, NEW, Shutdown error: illegal operation
15:42:44 <flo-retina> aleth: I've seen that shutdown error in debug builds for years
15:42:57 <aleth> flo-retina: It's new to me, and not with a debug build.
15:43:09 <sawrubh> v2) selecting the file and automatically using protocol implementation for file transfer ( we need to detect the support for the implementation in this)
15:43:10 <flo-retina> how do you see shutdown errors with non debug builds?
15:43:13 <aleth> Do you know what's causing it?
15:43:19 <aleth> flo-retina: In the console.
15:43:30 <aleth> (i.e. terminal, to be unambiguous)
15:43:38 <flo-retina> aleth: dumping errors in the terminal on non debug builds is new!
15:43:43 <flo-retina> how do you do that? :)
15:44:25 <aleth> It's been around for a long time, but maybe it works better these days? browser.dom.window.dump.enabled = true.
15:44:48 <flo-retina> where is the dump call?
15:45:13 <aleth> I have no idea if shutdown errors actually use dump, but if a pref is involved, that'll be the one.
15:46:46 <aleth> Uh, what I mean is "I don't know if this error message is written by JS code"
15:47:00 <flo-retina> aleth: "Do you know what's causing it?" my current guess (which is different from what I thought last time I looked at this) is that we are attempting to open the account manager window during shutdown, because we observe "account-disconnected" notifications, and all accounts get disconnected during shutdown
15:47:17 <aleth> Hmm, that's a good guess.
15:49:05 <-- wnayes has quit (Ping timeout)
15:49:59 --> wnayes has joined #instantbird
15:50:11 <clokep_work> sawrubh: I think we need to discuss iterations of it: What's the minimum UI we can add to start working on the project? What's the "final" UI we'd like to add?
15:50:16 <aleth> flo-retina: Oh, I forgot, it's also important to start IB using instantbird-bin rather than open Instantbird.app
15:50:18 <clokep_work> I think we should have these discussions w/ mockups.
15:51:23 <aleth> sawrubh, clokep_work: I think Filelink can easily land (and even ship) on its own with a simple drag-and-drop interface, no need for a file picker.
15:51:35 <aleth> The UI for file transfer as a whole will be a more complicated discussion.
15:51:56 <aleth> But if the plan is to work on Filelink first, it's not a fallback at that point, so... no complications.
15:52:00 <flo-retina> aleth: you may still need some UI for the upload progress
15:52:38 <aleth> flo-retina: Maybe if we were to actually ship it, but I would land that later.
15:52:54 <aleth> In the interest of more discrete patches ;)
15:53:08 <flo-retina> what about we start the whole file transfer UI discussion early, but start the file link coding now; so that once we are ready for file transfer stuff in general, the UI discussion has already happened?
15:53:16 <aleth> +1 :)
15:53:50 --> iamjayakumars has joined #instantbird
15:54:08 <aleth> The minimal UI I described is purely to enable the immediate coding  ;)
15:56:15 <aleth> For the full UI, I think sawrubh will have to investigate the download panel in FX first, to see if it can be repurposed for this (e.g. to also show uploads). If it can be used, then that's your button ;)
15:56:58 <sawrubh> clokep_work: do you want wireframe mockups or actual mockups made by altering the xul files?
15:57:09 <clokep_work> sawrubh: Altering XUL files isn't mock ups.
15:57:15 <clokep_work> Wireframes.
15:57:16 <sawrubh> I normally use https://gomockingbird.com/ for the former
15:57:38 <clokep_work> sawrubh: But what aleth said is pretty much what I was trying to eventually get the conversation to.
15:57:53 <clokep_work> sawrubh: We should have some super simple (like drag & drop) so that the initial integration of FileLink can happen.
15:58:01 <clokep_work> And add features to that once we need them.
15:59:25 <sawrubh> (one quick off topic thing, making mockups like this would be so awesome http://readyformozilla.com/panorama/ :) )
16:00:13 <flo-retina> sawrubh: we hired that guy ;)
16:00:23 <aleth> lol, that's quite the cv :D
16:00:44 <clokep_work> Hmm...I don't get it...although I have so much JS disabled...
16:01:32 <sawrubh> clokep_work: so the initial drag and drop seems to unanimous
16:04:00 <clokep_work> sawrubh: I agree! :)
16:04:24 <sawrubh> ok so http://i.imgur.com/U09C6g9.png is what I had proposed
16:04:33 * aleth uses pencil and paper for mockups ;)
16:04:38 <sawrubh> let me try and refine that
16:06:38 <clokep_work> Would that menu be shared across all conversations?
16:07:04 <clokep_work> I would think we'd want uploads and downloads to be . . . kind of in the same UI?
16:07:05 <aleth> or per-account?
16:07:11 <-- flo-thinkpad has quit (Ping timeout)
16:07:18 --> flo-thinkpad has joined #instantbird
16:08:08 <sawrubh> yeah, so that is what I guess aleth had suggested some time earlier (using the Fx download panel for showing the uploads too)
16:08:44 <clokep_work> aleth: No. We don't separate things by account ever.
16:09:13 <aleth> Just wondering.
16:09:39 <sawrubh> not doing it per account would be simpler but per-account could also make sense in the scenario....
16:10:02 --> CaptainCalliope has joined #instantbird
16:10:18 --> Armada has joined #instantbird
16:10:48 <flo-retina> per-contact would make more sense than per-account
16:10:52 <aleth> I guess the realistic choice is per-conversation or per-IB
16:13:41 <aleth> The download panel in FX is per-instance so I think investigating that code soon would be useful for the discussion.
16:13:59 <aleth> It may not be easy to have N copies of it around.
16:14:47 * Fallen|away is now known as Fallen
16:15:03 <-- CaptainCalliope has quit (Ping timeout)
16:15:14 --> CaptainCalliope has joined #instantbird
16:17:44 --> Vigilante has joined #instantbird
16:18:50 <-- CaptainCalliope has quit (Quit: CaptainCalliope)
16:25:00 <-- mayanktg has quit (Ping timeout)
16:25:47 * sawrubh is not sure what to contribute to this right now
16:26:23 --> mayanktg has joined #instantbird
16:26:37 <sawrubh> clokep_work: are we waiting on something or can I go work on that setting the topic bug, I'll check the FX download panel, refine my mockup after that
16:26:55 <clokep_work> sawrubh: It sounded like we were in agreement?
16:27:06 <clokep_work> Was there something else you think we needed to discuss?
16:27:18 <sawrubh> no
16:27:22 <clokep_work> sawrubh: My suggestion for you would be to try to finish the topic stuff today or tomorrow and then start looking at FileLink stuff. :)
16:27:34 <sawrubh> ok
16:30:58 --> arlolra has joined #instantbird
16:32:08 <mayanktg> sawrubh: Please share the mockup with me too when you have made one so that we can see that the design for Video calling and FileLinks don't conflict..
16:33:21 --> Mook_as has joined #instantbird
16:38:06 <clokep_work> aleth: What's that IRC client that does crazy things w/ colors and such?
16:38:23 <aleth> mIRC?
16:38:58 <clokep_work> Yes, thanks. :)
16:39:19 <flo-retina> mayanktg: I'm expecting all the mockups to be shared publicly here ;)
16:46:53 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:47:00 --> nhnt11 has joined #instantbird
16:48:13 <-- iamjayakumars has quit (Quit: )
16:48:33 <-- aleth has quit (Ping timeout)
16:55:17 <arlolra> is chat.prpls.forcePurple trying to force using libpurple?
16:56:51 <sawrubh> arlolra: I'm not sure about 'forcing' but yeah, it basically allows you to either use js implementation or libpurple's
16:57:25 <sawrubh> I wouldn't recommend using js version (of xmpp atleast) since it's still being developed
16:57:55 <arlolra> doesn't gtalk and facebook depend on xmpp though?
16:58:19 <sawrubh> yes and we use libpurple's implementation of xmpp
16:58:36 <sawrubh> facebook doesn't btw (it uses something called mqqt or whatever)
16:58:52 <clokep_work> arlolra: GTalk and Facebook always use JS-XMPP, never libpurple.
16:58:57 <clokep_work> sawrubh: ^
16:59:06 <sawrubh> whoops
16:59:21 <sawrubh> ..and this is why I shouldn't answer ;)
16:59:31 <clokep_work> arlolra: forcePurple says "use libpurple instead of the JS implementations", personally I run with it cleared out and use all our own implementations.
17:00:01 <clokep_work> I'm not positve what you mean by "trying to force".
17:00:07 <clokep_work> It doesn't "try" it does or it doesn't.
17:00:11 <clokep_work> YOu have to restart after modifying it.
17:00:36 <arlolra> shouldn't that be cleared out by default if I'm building without libpurple?
17:00:47 <arlolra> maybe try was a bad word there. you got my gist
17:03:31 <flo-retina> hmm, I'm not sure it has any effect when building without libpurple, but that's worth checking
17:04:01 <arlolra> it causes an error and xmpp/yahoo don't show up in the accounts list
17:04:31 <arlolra> failed to create an instance of @instantbird.org/purple/protocol;1 (http://instantbird.org/purple/protocol;1);
17:04:32 <arlolra> TypeError; Cc[cid] is undefined
17:04:40 <flo-retina> if we have an ifdef for when buildbing with/without libpurple, we should ifdef out http://lxr.instantbird.org/instantbird/source/instantbird/modules/ibCore.jsm#64
17:06:04 <flo-retina> if we don't, we could add a runtime check |if (Ci.purpleICoreService)| before that line
17:09:27 <-- flo-thinkpad has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:11:17 <arlolra> hmm, it's possible I build with extension=purple enabled in mozconfig but I just didn't check it out
17:11:26 <arlolra> s/build/built/
17:12:37 <flo-retina> I think if you did you would have a working libpurple
17:12:54 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:15:06 <arlolra> I thought that required a separate step https://developer.mozilla.org/en-US/docs/Simple_Instantbird_build#Building_purplexpcom_and_libpurple
17:15:21 <arlolra> and he's gone
17:22:42 <Mook_as> Hmm, doesn't looks like it would be trivial to check to see if each protocol provided is actually supported by the running libpurple.  Because that seems smarter than just a service (or better, contractid) check.
17:27:23 <arlolra> maybe just fail is extensions=purple is enabled but mozilla/extensions/purple isn't present
17:41:19 * nhnt11 wonders if we're okay with the -moz-image-region fix
17:41:30 * nhnt11 shrugs and pops it out of his mq for now
17:45:03 <sawrubh> clokep_work: ok, so fixed it, now one thing remaining
17:45:36 <clokep_work> arlolra: It does.
17:46:09 <sawrubh> libpurple actually tells who set the topic by saying something like '%s set the topic to %s' but we simply write 'The topic for <channel name> is %s'
17:46:13 <clokep_work> I agree we should be checking if it exists ahead of time.
17:46:22 <clokep_work> sawrubh: OK.
17:47:28 <clokep_work> sawrubh: I'd have to see the patch to give more info. ;)
17:51:26 <clokep_work> sawrubh: I think that's kind of expected, unfortunately. :(
17:52:04 <sawrubh> why, I'm trying to extract the nick from the 'from' attribute and show a mesage like libpurple
17:52:54 <sawrubh> I'll need to first find out who generates this message btw 'The topic for <channel> is %s' and stop it from doing so and instead show my custom message (similar to libpurple)
17:52:55 <clokep_work> sawrubh: If that works then great! :)
17:53:14 <clokep_work> Isn't that just printing out the body? You probably just need to do an early return.
17:53:40 <sawrubh> I'll try that and get back to you
17:55:32 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:55:38 --> nhnt11 has joined #instantbird
17:57:25 * Fallen is now known as Fallen|away
17:58:42 <clokep_work> OK. :)
18:07:49 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
18:18:47 --> gerard-majax_ has joined #instantbird
18:27:55 --> flo-retina has joined #instantbird
18:27:55 * ChanServ sets mode +qo flo-retina flo-retina 
18:30:24 <clokep_work> sawrubh: Any luck? I have a few minutes before a meeting if you want to bounce ideas aroudn.
18:34:39 <mayanktg> clokep_work: http://i.imgur.com/Vb66ZFt.png http://i.imgur.com/qL3m0Md.png Here are two mockups for different screen sizes (one for a smaller and other for wider windows). Does changing the chat area for wider screens would be good? I could imagine where else should I put the video pane.
18:35:01 <mayanktg> *couldn't
18:39:57 <clokep_work> mayanktg: I don't know. I'd ask flo-retina.
18:40:09 <clokep_work> And I'm unsure why you care about the %age of the screen?
18:40:25 <mayanktg> clokep_work: ok. :)
18:40:29 <clokep_work> What if I have a 30" monitor with an insanely high resolution?
18:43:23 <flo-retina> I think you care about the aspect ratio of the window, rather than the screen
18:43:53 <nhnt11> Hmm, asyncification has stuff to think about :/
18:44:15 <mayanktg> We can change the design as per percentage of the screen width / height...
18:44:18 <nhnt11> For example the "getLogFolderForAccount" method has an option to create the folder if it doesn't exist
18:44:25 <flo-retina> mayanktg: I think you should ask with something roughly like http://i.imgur.com/Vb66ZFt.png but you can simplify it
18:44:41 <nhnt11> But I wouldn't include that in the OS.File version, because we don't have a guarantee on when the folder will start to exist
18:44:54 <flo-retina> mayanktg: the area with "call buttons Buttons here" seems a pure waste
18:45:17 <mayanktg> flo-retina: Yes. aspect ratio is to be taken care of.. I wouldn't want my video stream to change their aspect ratio.
18:46:04 <flo-retina> "you should ask" was supposed to be "you should start"
18:46:34 <mayanktg> flo-retina: ok .. Then how should we disconnect/mute/hold video? we should have options for that?
18:46:50 <clokep_work> nhnt11: Why not?
18:47:10 <clokep_work> Can't you just prepend an extra chain onto the callbacks starting with "Ok, now create the directory!!!!!!!"
18:48:04 <flo-retina> mayanktg: what are these nice buttons you have near the target switcher? ;)
18:48:26 <nhnt11> clokep_work: the function that I'm trying to "convert" returns an nsIFile instance. Instead of that, I'm returning a path string. Getting this string isn't async, and requires no callbacks.
18:49:09 <nhnt11> So there isn't any callback chain to begin with
18:49:26 <nhnt11> Hmm, maybe there should be though?
18:49:27 <clokep_work> nhnt11: Well then see if we actually use that anywhere.
18:49:30 <nhnt11> Yeah
18:49:45 <nhnt11> I haven't followed the flow enough to know whether we need it or not
18:49:53 * nhnt11 shrugs and continues his quest
18:49:59 <mayanktg> flo-retina: I couldn't find one suitable in the mockup :P ....L-->R : SendFile..Video Call..Audio call..Protocol button .... (The order would change when we have discussion over the Generic ways to add the buttons) :)
18:50:01 <clokep_work> nhnt11: You might need to make async version in parallel with sync versions and move stuff over. Additionally...things might not need to be done EXACTLY the same.
18:50:38 <flo-retina> mayanktg: I meant these buttons can be used to control the call
18:50:50 <flo-retina> if you click the "video" icon it starts a call, if you click it again you can stop the call
18:51:00 <flo-retina> (or it can open a panel with more options)
18:51:13 <mayanktg> flo-retina: OK! better :D
18:51:24 <nhnt11> clokep_work: That's kinda what I'm doing. I'm making async versions of the sync functions, but not removing the sync ones.
18:51:35 <mayanktg> Having a panel would be a great idea.. would save some space..
18:51:40 <nhnt11> I can remove sync functions that will no longer be used later
18:51:51 <nhnt11> There will likely be some sync functions that will still be used that can stay
18:51:59 <nhnt11> Since I'm not implementing async reading right now
18:53:19 <flo-retina> mayanktg: you could also have a tiny button in a corner above the video, and hovering it would show more
18:54:00 <mayanktg> flo-retina: ok..and a fullscreen hover (bottom right) ?
18:55:54 <flo-retina> top right
18:56:07 <flo-retina> bottom right I think you should have the user's video preview
18:56:59 <mayanktg> flo-retina: ok..
18:58:22 <mayanktg> So we should start up with this mockup? 
18:58:45 <-- Vigilante has left #instantbird ()
18:58:46 <flo-retina> can you update it with what we have just discussed?
18:59:35 <mayanktg> flo-retina: Also I have a question.. Do we need to perform a complete build of Ib on changing files in installer/package-manifest.in ?
18:59:40 <mayanktg> flo-retina: Yeah sure..
18:59:50 <clokep_work> nhnt11, sawrubh, mayanktg: Btw you should all be writing on your blogs at some point this week. :) (Personally I'd suggest frequent shorter posts than rare long posts)
19:00:07 <nhnt11> clokep_work: Planning a post either today or tomorrow, based on progress :)
19:00:20 <-- chrisccoulson has quit (Ping timeout)
19:00:50 <mayanktg> clokep_work: Yes I will upload one today :) 
19:02:10 <sawrubh> 'upload' a post :)
19:04:47 --> qheaden has joined #instantbird
19:04:53 <qheaden> Hello everyone
19:05:05 <sawrubh> o/
19:06:01 <qheaden> clokep_work: I took a lot of time looking at the group chat code last night to no avail. I'm going to have to really flowchart the packets of a group chat with only Yahoo clients.
19:06:29 * Fallen|away is now known as Fallen
19:08:11 <clokep_work> qheaden: That sounds fun! :)
19:08:16 <qheaden> :P
19:08:34 <clokep_work> qheaden: The unfortunate thing is...I don't care as much about group chats. :-[
19:08:36 <qheaden> Some packet in my code is either malformed, or I'm not sending a certain packet.
19:08:46 <qheaden> clokep_work: Yeah, me either. But we want to be complete.
19:09:15 <clokep_work> qheaden: Ah! OK. :) Malformed packet would be "easy".
19:09:22 <qheaden> clokep_work: Yeah.
19:09:38 <qheaden> I probably didn't use the correct key/values or something.
19:09:59 <clokep_work> Or the wrong order. :(
19:10:18 <qheaden> clokep_work: Oh, and it took me some time to realize that your changing _participants to a Map broke the group chat code. :P
19:10:42 <qheaden> My getParticipantNames function wasn't using a for of loop over the map values.
19:11:31 <clokep_work> qheaden: Oops. :( Sorry.
19:11:36 <clokep_work> Do you have a patch for that?
19:11:43 <qheaden> clokep_work: Yeah, it is really simple.
19:11:59 <qheaden> clokep_work: I will just include it in my group chat fix patch, whenever that is working.
19:12:36 <clokep_work> qheaden: Alternately you could put it on the Maps/Sets code.
19:13:26 <clokep_work> qheaden: s/code/bug/
19:14:20 <nhnt11> Hmm. New approach: leave all the synchronous code for creating folders and log files intact, and only rewrite the code that actually writes stuff to be async
19:14:42 <-- mayanktg has quit (Ping timeout)
19:15:17 <flo-retina> nhnt11: why is that easier?
19:15:24 <flo-retina> have you tried using task.js?
19:15:29 --> mayanktg has joined #instantbird
19:15:33 <-- Tonnes has quit (Connection reset by peer)
19:15:53 <nhnt11> flo-retina: I'm worried about edge cases where something tries to write to a log file that hasn't been created yet
19:15:56 <nhnt11> No I haven't.
19:16:43 --> Tonnes has joined #instantbird
19:18:27 <sawrubh> clokep_work: what should I use for writing the message to the conversation?
19:18:53 <sawrubh> writeMessage() or instead get incomingMessage to write it by creating a fake packet
19:19:23 <clokep_work> nhnt11: Doesn't OS.File handle all that for you?
19:19:26 <clokep_work> sawrubh: What?
19:19:49 <clokep_work> sawrubh: I do not understand what the second part of that means, which most likely means "no".
19:19:59 <mayanktg> flo-retina: Here's the new one. Panel, removed button area, fullscreen hover at top right, caller's video at bottom right.. http://i.imgur.com/cPujyeS.png 
19:19:59 <clokep_work> sawrubh: There's a method for printing stuff to conversations, I think writeMessage is it, yes.
19:20:25 <clokep_work> sawrubh: But I think the message is done in abstract code? :-S
19:20:36 <sawrubh> sending a diff
19:20:45 <sawrubh> I'm not able to write the message properly
19:20:48 <clokep_work> OK.
19:21:29 <nhnt11> clokep_work: Why would it? If init() calls OS.File.create(), but before this finishes, another bit of code tried to log a message, that would fail afaik.
19:21:44 <nhnt11> (we should wait for the create() promise to resolve before allowing writing to the file)
19:21:52 <nhnt11> Um, give me a few minutes
19:21:53 <flo-retina> mayanktg: why do you have borders around the video area?
19:22:02 <flo-retina> the stuff with rounded corners
19:23:01 <flo-retina> I don't expect the user's video to be square
19:23:18 <nhnt11> Ah, I think the yield keyword might helkp me
19:23:30 <flo-retina> nhnt11: it certainly will :)
19:23:36 <nhnt11> flo-retina: Is that why you were asking about Task.js?
19:23:37 <nhnt11> Ah
19:23:38 <flo-retina> nhnt11: that's why I said use task.js
19:23:38 <mayanktg> flo-retina: It was to keep up with the theme... :-/ I'll remove it then..
19:23:56 <mayanktg> flo-retina: oops 
19:23:57 <nhnt11> Excellent
19:24:18 <nhnt11> Wow, Promises are great!
19:24:20 <nhnt11> ;)
19:24:21 <nhnt11> :) *
19:24:59 <sawrubh> clokep_work: http://pastebin.instantbird.com/713285
19:25:00 <flo-retina> mayanktg: also, remove the volume selector you have on the left side of the video (I don't know any way to implement that; and it's certainly not something you need in the beginning)
19:26:32 <clokep_work> sawrubh: Why are you calling setTopic?
19:26:40 <clokep_work> Oh wait, never mind.
19:26:53 <sawrubh> :)
19:27:30 <clokep_work> sawrubh: https://mxr.mozilla.org/comm-central/source/chat/modules/jsProtoHelper.jsm#539 setTopic takes a second parameter.
19:28:24 <mayanktg> flo-retina: done :) Anything else I should modify/add in that?
19:29:14 * nhnt11 seems to have arrived back where he started after trying different things
19:29:23 <clokep_work> sawrubh: (Which doesn't answer your real question of how to write to the conversation...)
19:29:46 <sawrubh> clokep_work: passing a second param wouldn't really fix anything but I'll do that
19:30:01 <clokep_work> sawrubh: Why not? :-S
19:30:05 <sawrubh> that second param is the nick of the person who set it right?
19:30:08 <clokep_work> Yes.
19:30:14 * sawrubh tries
19:30:32 <mayanktg> flo-retina: http://i.imgur.com/smHwSi2.png
19:31:08 <clokep_work> sawrubh: Doesn't https://mxr.mozilla.org/comm-central/source/chat/modules/jsProtoHelper.jsm#553 do what you want?
19:32:01 <sawrubh> ..compiling.... :)
19:32:07 <sawrubh> yeah, it should do that!
19:32:30 <clokep_work> sawrubh: Stop trying to make it harder than it is! :P
19:33:23 <sawrubh> it fixed it! :'( and :)
19:33:44 <nhnt11> brb
19:34:47 <clokep_work> sawrubh: Good. :)
19:35:42 <sawrubh> one last thing, so in the case of libpurple, the message with the nick get's 'bold'-ed out (darker black) while in the case of js-xmpp it doesn;t
19:35:45 <sawrubh> is that a bug?
19:36:14 <sawrubh> uploading screenshots (in case what I just said ^^ isn't clear)
19:42:10 <clokep_work> sawrubh: It's part of the stuff you're not supposed to worry about as someone implementing protocols, so no.
19:42:20 <clokep_work> But I'd like to see a screenshot.
19:43:21 --> mpmc has joined #instantbird
19:48:38 <sawrubh> clokep_work: http://i.imgur.com/aSuE7xf.png (libpurple one) has the message in bold while http://i.imgur.com/QEWrTqM.png (js-xmpp) one doesn't
19:49:37 <clokep_work> sawrubh: That's because it's YOU who set the topic.
19:49:40 <clokep_work> It's pinging you essentially.
19:50:24 <sawrubh> exactly, so that in the second screenshot, the 3rd topic change should be highlighted
19:50:49 <sawrubh> because there I'm signed in as sawrubh
19:51:34 <clokep_work> sawrubh: It's fine. It matches IRC.
19:58:42 <sawrubh> clokep_work: testing, commenting and then sending for review
19:59:56 <clokep_work> sawrubh: Cool. :)
20:14:34 <-- qheaden has quit (Ping timeout)
20:16:40 --> EionRobb has joined #instantbird
20:19:29 <sawrubh> clokep_work: one question, I'm not able to figure out how to get the halfOf property ( the _participants is empty, here is the value of 'this' inside the topicSettable method http://pastebin.instantbird.com/713310)
20:19:38 <sawrubh> *halfOp
20:20:49 <clokep_work> sawrubh: Can I see code?
20:22:03 <sawrubh> clokep_work: http://pastebin.instantbird.com/713311
20:22:19 --> Even has joined #instantbird
20:22:19 * ChanServ sets mode +o Even 
20:24:52 <clokep_work> sawrubh: _participants is a Map, not an object.
20:25:01 <clokep_work> _participants.get(foo)
20:25:12 <-- mayanktg has quit (Ping timeout)
20:25:17 <clokep_work> this._participants.get(this._nick).halfOp;
20:25:31 <clokep_work> sawrubh: Also, don't youw ant to check if it's a halfOp or higher?
20:26:25 <clokep_work> sawrubh: E.g. https://mxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm#77 looks like you should be checking halfOp || op || founder!
20:31:10 <flo-retina> sawrubh: http://i.imgur.com/aSuE7xf.png looks like a libpurple bug to me
20:32:04 <flo-retina> mayanktg: so you removed one border (the rounded one) but you still have margins around the video element. I don't think you need that (it's wasted space)
20:34:42 <instantbot> New Instantbird - Other bug 1013563 filed by clokep@gmail.com.
20:34:45 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1013563 nor, --, ---, nobody, NEW, about:licenses not updated with GPL information after merge into c-c
20:36:00 <-- Armada has quit (Connection reset by peer)
20:37:10 --> mayanktg has joined #instantbird
20:38:16 <mayanktg> flo-retina: ahh..okay.. I'll remove that.
20:38:20 <mayanktg> :)
20:40:27 <mayanktg> Done :)
20:40:51 <clokep_work> sawrubh: Did that work?
20:41:35 <-- Rym has quit (Ping timeout)
20:41:52 <mayanktg> http://i.imgur.com/sTgNOsz.png
20:43:55 <sawrubh> clokep_work: yes
20:45:13 <flo-retina> mayanktg: much better!
20:45:25 <flo-retina> mayanktg: at some point we will want to discuss the content of the panel
20:45:36 <flo-retina> but we can discuss that later
20:45:54 <sawrubh> clokep_work: r? http://pastebin.instantbird.com/713314
20:45:58 <mayanktg> flo-retina: ok. :) 
20:49:41 <clokep_work> sawrubh: Overall it looks reasonable. I probably have some nits.
20:49:46 <clokep_work> Can you upload it to BZ somewhere?
20:49:57 <EionRobb> there's a special shampoo for that
20:51:43 <sawrubh> clokep_work: doing that in a while
20:56:36 <clokep_work> sawrubh: Why in a while?
20:57:30 <clokep_work> I'm only here for a bit longer.
20:57:32 <sawrubh> because getting an issue when connecting to a server which sends a body in the topic-changing message stanza :P
20:58:58 <flo-retina> I don't think ":P" is appropriate in an answer to someone helping you.
21:01:38 <clokep_work> Alright.
21:01:48 <clokep_work> It'll have to wait till later then. I'm going home. Goodnight!
21:01:50 <-- sawrubh has quit (Ping timeout)
21:02:40 <EionRobb> flo-retina: does your locale not treat ":P" the same as ";)"?
21:02:54 <clokep_work> Mine doesn't.
21:03:06 --> sawrubh has joined #instantbird
21:04:03 <flo-retina> EionRobb: my locale treats ":P" as a punctuation symbol indicating that the author of the sentence doesn't deserve an answer.
21:04:37 <EionRobb> lol
21:05:24 <-- clokep_work has quit (Ping timeout)
21:08:19 <-- gerard-majax_ has quit (Ping timeout)
21:13:55 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:34:14 <-- unghost has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
21:35:27 * Fallen is now known as Fallen|away
21:46:01 <flo-retina> http://blog.queze.net/post/2014/05/20/Summer-of-Code-2014-projects
21:54:03 --> Rym has joined #instantbird
21:58:09 <flo-retina> I restarted the mac mini on the wifi (the time capsule's wifi)
22:51:27 --> clokep has joined #instantbird
22:51:27 * ChanServ sets mode +o clokep 
23:04:47 <instantbot> clokep@gmail.com changed the Resolution on bug 955328 from --- to FIXED.
23:04:49 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955328 enh, --, 1.6, clokep, RESO FIXED, Use Javascript default parameters where applicable
23:04:58 <instantbot> clokep@gmail.com changed the Resolution on bug 1012660 from --- to FIXED.
23:04:59 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1012660 nor, --, 1.6, clokep, RESO FIXED, Remove _chatRoomFieldsList from IRC code
23:05:00 * clokep is happy to be cleaning out his mq. :)
23:05:28 <clokep> It almost fits on one terminal window now. :P
23:05:42 --> clokep_work has joined #instantbird
23:05:42 * ChanServ sets mode +o clokep_work 
23:06:56 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
23:09:09 * flo-retina gives up on fixing the Windows VM
23:09:14 <flo-retina> I'll need to bug Even tomorrow
23:14:47 <clokep> :(
23:18:34 <flo-retina> clokep: when started automatically at startup, the init scripts sets variables pointing for the win7 SDK
23:18:45 <flo-retina> when I run it, the variables are correctly set to the Windows8 SDK
23:19:08 <flo-retina> I don't understand what's causing that strange behavior...
23:27:12 <clokep> flo-retina: Alright, well hopefully Even has an idea.
23:39:57 * clokep wonders if sawrubh ever figured out that last part. :)
23:41:36 --> clokep_tb has joined #instantbird
23:43:14 <-- clokep_tb has quit (Quit: clokep_tb)
23:48:04 <-- EionRobb has quit (Ping timeout)
23:48:31 --> EionRobb has joined #instantbird
23:48:32 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
23:48:34 --> clokep has joined #instantbird
23:48:35 * ChanServ sets mode +o clokep