#instantbird log on 05 19 2014

All times are UTC.

00:02:40 <-- mayanktg has quit (Quit: Connection closed for inactivity)
00:09:40 --> mconley has joined #instantbird
00:29:12 <-- quartzjer has quit (Quit: Leaving.)
00:48:36 <-- mconley has quit (Input/output error)
01:09:41 <-- nhnt11 has quit (Ping timeout)
01:10:32 --> nhnt11 has joined #instantbird
01:19:35 --> mconley has joined #instantbird
01:25:26 <-- mconley has quit (Ping timeout)
01:52:57 <-- Rym has quit (Ping timeout)
01:56:08 --> mconley has joined #instantbird
02:11:01 <instant-buildbot> build #1376 of win32-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1376
02:21:21 <-- mconley has quit (Input/output error)
02:44:09 --> mayanktg has joined #instantbird
02:51:52 --> mconley has joined #instantbird
02:54:36 --> qheaden has joined #instantbird
02:55:16 <-- mconley has quit (Input/output error)
03:05:12 --> mconley has joined #instantbird
03:11:39 <-- wnayes has quit (Quit: wnayes)
03:29:05 <instant-buildbot> build #2150 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2150
04:21:12 <-- mconley has quit (Input/output error)
04:43:39 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
04:52:53 --> nhnt11 has joined #instantbird
05:12:11 <-- nhnt11 has quit (Ping timeout)
05:13:08 --> nhnt11 has joined #instantbird
05:13:17 --> mayank_mob has joined #instantbird
05:18:24 <-- mayank_mob has quit (Ping timeout)
05:25:08 <-- EionRobb has quit (Quit: Leaving.)
05:26:05 <-- qheaden has quit (Ping timeout)
05:26:24 <-- nhnt11 has quit (Ping timeout)
05:27:10 --> nhnt11 has joined #instantbird
05:32:13 --> mayank_mob has joined #instantbird
05:34:17 <mayank_mob> Mic: bug 1011878…comment from jib says mozGUMD is to b3 used with getUserMedia. :)
05:35:16 <mayank_mob> ^ Bug 1011878
05:35:20 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1011878 nor, --, ---, nobody, NEW, mozGetUserMediaDevices doesn't work until getUserMedia is called
05:42:54 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
05:47:38 <-- mayank_mob has quit (Ping timeout)
05:48:08 --> mayank_mob has joined #instantbird
05:50:06 <-- mayank_mob has quit (Client exited)
05:52:43 <-- nhnt11 has quit (Ping timeout)
05:53:10 --> nhnt11 has joined #instantbird
06:07:02 <-- nhnt11 has quit (Ping timeout)
06:07:45 --> nhnt11 has joined #instantbird
06:09:03 <nhnt11> Hi
06:09:13 <nhnt11> I'll be online this evening to start off with some logger.js stuff
06:09:20 <nhnt11> aleth^
06:09:22 <nhnt11> Bye for now! :)
06:23:08 <-- nhnt11 has quit (Ping timeout)
06:23:31 --> nhnt11 has joined #instantbird
06:29:35 <-- nhnt11 has quit (Ping timeout)
06:30:49 --> nhnt11 has joined #instantbird
06:37:49 <-- nhnt11 has quit (Ping timeout)
06:38:06 --> nhnt11 has joined #instantbird
06:42:33 <-- nhnt11 has quit (Ping timeout)
06:42:54 --> nhnt11 has joined #instantbird
06:52:54 --> chrisccoulson has joined #instantbird
07:12:21 <-- nhnt11 has quit (Ping timeout)
07:12:32 --> EionRobb has joined #instantbird
07:23:02 --> Mic has joined #instantbird
07:23:02 * ChanServ sets mode +o Mic 
07:41:40 <mayanktg> Mic; Hello. I tried implementing the buttons the way you suggested but reverted back to the original design as they occupied much space and seemed bigger than the image :-| . I think the buttons whould better like one's in the mockup.
07:41:57 <Mic> Do you have a screenshot of that?
07:42:54 <mayanktg> I have to take one. The code is on my laptop. I'm currently building Ib on that and its not responding. 
07:43:05 <mayanktg> I will share it with you.
07:43:40 <mayanktg> Also. Shall I start with the enhancement 1004930 ?
07:44:21 <mayanktg> ^ Bug 1004930
07:44:24 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1004930 enh, --, ---, nobody, NEW, Generic way to add buttons for actions to a conversation
07:52:42 --> gerard-majax_ has joined #instantbird
08:02:03 --> sonny has joined #instantbird
08:02:46 <Mic> mayanktg: I'll have to check something for that...
08:02:48 <Mic> brb
08:03:31 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
08:07:10 <-- sonny has quit (Ping timeout)
08:07:34 --> sonny has joined #instantbird
08:31:53 --> Mic has joined #instantbird
08:31:53 * ChanServ sets mode +o Mic 
08:37:03 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
08:41:56 --> Mic has joined #instantbird
08:41:56 * ChanServ sets mode +o Mic 
08:44:40 <Mic> mayanktg: I can't try at the moment as Linux refuses to boot :/
08:48:16 * Fallen|away is now known as Fallen
08:51:00 <mayanktg> Here's the link: http://i.imgur.com/O7Tqxhc.png
08:51:42 <mayanktg> Also the one before I changed the menu: http://i.imgur.com/GLXB7BL.png
08:52:55 <mayanktg> Mic: np :) I'll be bbl 
09:19:44 --> BWMerlin has joined #instantbird
09:25:35 <-- sonny has quit (Ping timeout)
09:29:26 --> aleth has joined #instantbird
09:29:26 * ChanServ sets mode +o aleth 
09:32:29 --> sonny has joined #instantbird
09:36:24 <mayanktg> Mic: back! 
09:44:51 <Mic> wb
09:49:33 * Fallen is now known as Fallen|away
09:50:17 <mayanktg> Mic: Linux fixed? I was asking how should I start with my project. The bug is included in my work too. Should I take it first or start by adding "make and accept video/audio call" feature for XMPP?
09:56:27 <Mic> No, I've not fixed it yet. I'm busy atm. Once I get it working again (not before tonight) I'll check the idea that flo had for the toolbarbuttons (let's hope it works because it'd be only a small change) and take a shot at styling the panel and the buttons...
09:59:21 <mayanktg> Mic: ok :) 
09:59:57 <Mic> flo had code that added WebRTC support to Thunderbird.
10:00:10 <mayanktg> http://queze.net/goinfre/webrtc-demo/thunderbird-webrtc/931706bc0ce9
10:00:11 <Mic> Have you seen it?
10:00:19 <Mic> Yes, exactly.
10:00:30 <mayanktg> Yes. he shared that me over mail.
10:01:06 <aleth> I wonder if it might be useful for mayanktg to fix a simple XMPP bug, to get a look at how the backend works?
10:01:40 <mayanktg> aleth: can you suggest one suitable to take on? 
10:01:42 <aleth> For example, in bug 954959 the left getter might not be too complicated
10:01:42 --> flo-retina has joined #instantbird
10:01:42 * ChanServ sets mode +qo flo-retina flo-retina 
10:01:44 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=954959 nor, --, ---, nobody, NEW, Finish the implementation of basic MUC support in JS-XMPP
10:01:58 <mayanktg> ok :)
10:01:59 <-- flo-retina has quit (Input/output error)
10:02:02 --> flo-retina has joined #instantbird
10:02:02 * ChanServ sets mode +qo flo-retina flo-retina 
10:02:04 <Mic> aleth: thanks
10:04:17 <-- aleth has quit (Ping timeout)
10:07:06 <-- Even has quit (Input/output error)
10:07:08 --> Even has joined #instantbird
10:07:09 * ChanServ sets mode +o Even 
10:07:21 <-- Even has quit (Input/output error)
10:07:23 --> Even has joined #instantbird
10:07:24 * ChanServ sets mode +o Even 
10:19:17 --> clokep has joined #instantbird
10:19:18 * ChanServ sets mode +o clokep 
10:27:57 <-- EionRobb has quit (Quit: Leaving.)
10:32:20 --> aleth has joined #instantbird
10:32:20 * ChanServ sets mode +o aleth 
10:34:20 <aleth> Mic, mayanktg: there's a separate bug filed for it actually, bug 1000477
10:34:22 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1000477 nor, --, ---, saurabhanandiit, NEW, Implement the left getter for XMPP MUCs
10:34:42 <mayanktg> aleth: Yes I have seen that. Thanks :)
10:43:09 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
10:43:45 * clokep is going to try to make everyone rwite more comments this summer. :P
10:52:08 <mayanktg> aleth: is this the place for left getter code? http://mxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm#281
10:52:09 <clokep> sawrubh: Are you still stuck?
10:52:32 <clokep> mayanktg: No, not really. But that should be done too. :P
10:53:09 <clokep> mayanktg: Actually, I lied...that might be one of the places.
10:53:10 <aleth> mayanktg: You can only leave a private conversation by closing it. This bug is about MUCs
10:53:26 <clokep> I don't know whether XMPP responds that we've left or not. (Whcih is how we handle that in IRC.)
10:53:33 <aleth> You have to look at XMPPMUCConversationPrototype
10:54:06 <aleth> Right, the first thing to do is to investigate how one can part a MUC in XMPP ;)
10:54:21 <aleth> Disconnection is one way.
10:54:28 <mayanktg> ok
10:55:47 <aleth> Make sure you understand what the left flag is for ;)
10:56:29 <clokep> And ask if you don't!
10:56:50 <mayanktg> i asked sawrubh http://mxr.mozilla.org/comm-central/source/chat/components/public/prplIConversation.idl#117 :D
10:59:34 <mayanktg> aleth: By " how one can part a MUC in XMPP" you mean joining MUC in XMPP ?
10:59:53 --> rosonline has joined #instantbird
10:59:53 <aleth> umm, no. Parting is the opposite of joining.
11:00:00 <aleth> Try /part and /join in IRC...
11:00:24 <mayanktg> aleth: oh ..ok :)
11:00:45 <aleth> Have you looked at the interface spec at all?
11:01:03 <aleth> prplIConversation.idl
11:01:20 <sawrubh> clokep: on call, be back in 5 minutes
11:01:34 <mayanktg> aleth: Not yet. 
11:01:48 <aleth> Good place to start ;)
11:02:03 <mayanktg> ok :)
11:02:29 <clokep> aleth, mayanktg: It also happens if you sign out of the account...
11:02:47 <aleth> I guess if you're using ircccloud it's not so easy to try it on IRC :P
11:03:01 <flo-retina> "clokep is going to try to make everyone rwite more comments this summer. :P"
11:03:10 * flo-retina is going to try to make everyone write more tests this summer. :-P
11:07:33 <clokep> :)
11:07:36 <clokep> Good goals IMO.
11:08:40 * aleth thinks making everyone write more code would also be useful at this point ;)
11:08:59 <flo-retina> aleth: I leave that part to GSoC mentors :-P
11:09:07 * mayanktg gets the reason GSoC's paying 10% more :D
11:09:38 <flo-retina> mayanktg: are you planning to write 10% more code than the students we had last year? :-P
11:09:57 * flo-retina should have said "good code".
11:09:57 <aleth> Tests and comments are code too.
11:10:13 <flo-retina> I'm not interested in people dumping large pieces of junk to our review queues :-]
11:11:34 --> sshagarwal has joined #instantbird
11:11:38 <-- sshagarwal has left #instantbird ()
11:11:57 <mayanktg> flo-retina: hope I write good maintainable ones. :P
11:12:35 <-- clokep has quit (Ping timeout)
11:18:45 <-- rosonline has quit (Client exited)
11:30:55 <-- aleth has quit (Ping timeout)
11:36:31 --> aleth has joined #instantbird
11:36:31 * ChanServ sets mode +o aleth 
11:58:02 --> clokep_work has joined #instantbird
11:58:02 * ChanServ sets mode +o clokep_work 
12:02:00 --> rosonline has joined #instantbird
12:03:21 <-- Even has quit (Connection reset by peer)
12:03:24 --> Even has joined #instantbird
12:03:24 * ChanServ sets mode +o Even 
12:04:44 <clokep_work> Happy coding period everyone!
12:04:46 <clokep_work> Now get to work. ;)
12:05:08 <clokep_work> sawrubh: OK, ping me when you get a chance. Just want to catch up again since we haven't talked in a few days.
12:07:34 <sawrubh> clokep_work: pong
12:13:56 <clokep_work> sawrubh: So what's your status? What have you eben working on?
12:14:32 <-- BWMerlin has quit (Quit: BWMerlin)
12:18:20 <sawrubh> clokep_work: I primarily tried my hands on that setting the topic bug, besides that not much
12:18:37 <sawrubh> (I had my n5 come in so was playing with that :P)
12:20:34 <sawrubh> clokep_work: https://pastebin.mozilla.org/5199728 is what I my diff is
12:20:43 <sawrubh> for the setting the topic bug
12:23:46 * aleth doubts the topic is a property of the account ;)
12:24:04 <clokep_work> sawrubh: OK! Do you have questions? I'd love to finish that up very soon so we can start working on the "real" project. :)
12:24:11 <sawrubh> yeah, sorry that is this._topic
12:24:16 <sawrubh> I uploaded the wrong diff
12:24:42 <aleth> Have you looked at the code in jsProtoHelper you are overriding?
12:24:56 <-- aleth has quit (Quit: exit stage left)
12:25:13 <sawrubh> aleth: GenericConvChatPrototype
12:25:49 <sawrubh> yeah, that's why I added this getter to XMPPMUCConversationPrototype
12:27:05 <sawrubh> clokep_work: so according to me I've implemented the topic getter and topicSettable() getter which should be enough for
12:27:10 <sawrubh> me to click and change it
12:27:59 <clokep_work> sawrubh: OK. So do you have questions or just need to test or is it ready to upload? :)
12:28:01 <sawrubh> I've used the setTopic() method instead of creating an XMPP message (like I guess you suggested was the motive of this bug : to learn how to craft xmpp messages). so setTopic() should work right?
12:28:17 <sawrubh> clokep_work: I've tested this patch and it doesn't work
12:29:22 <clokep_work> sawrubh: Above you said you uploaded the wrong diff, can you upload the right one and we can work through it?
12:29:28 <-- ivan has quit (Quit: ERC Version 5.3 (IRC client for Emacs))
12:29:53 <clokep_work> "used the setTopic() method instead of creating an XMPP message", I don't understand what this means, you have to send the message to the server.
12:31:16 <clokep_work> sawrubh: Or did I misunderstand and you just meant that's your current diff but you know it doesn't work? :)
12:32:55 <sawrubh> clokep_work: https://pastebin.mozilla.org/5199877 is the current diff. It doesn't work
12:33:57 <clokep_work> sawrubh: Can you please expand on "doesn't work"? (Is there an error you're getting, does nothing happen, etc.)
12:34:05 <sawrubh> now I understand, using setTopic is incorrect (because that'll just set the topic of the local instance and not update it on the other users)
12:34:20 <clokep_work> Yup! :) That's the protocol specific part.
12:34:53 <sawrubh> clokep_work: with this diff, when I click on the topic nothing happens, while in the libpurple instance I run, there comes a text box where I can enter the topic
12:35:04 <sawrubh> I don't see any errors in the error console though
12:35:16 <clokep_work> sawrubh: Does the cursor even change to the edit text cursor?
12:35:20 <sawrubh> no
12:35:30 <sawrubh> it acts as if I'm doing nothing :P
12:35:37 <clokep_work> sawrubh: Your topicSettable only returns true if you're a halfOp.
12:35:48 <clokep_work> sawrubh: But you're checking that on the account, whcih doesn't make sense.
12:35:56 --> ivan has joined #instantbird
12:36:11 <clokep_work> (Btw: COding style thing, you can just do |return foo| instead of |if (foo) return true;| :)
12:37:21 <sawrubh> ah, because halfOp already retursn a bool
12:38:05 <sawrubh> clokep_work: why doesn't it makes sense?
12:38:12 <sawrubh> should I check it on the participant?
12:38:45 <clokep_work> sawrubh: https://mxr.mozilla.org/comm-central/source/chat/components/public/imIAccount.idl#71 has no halfOp field on it.
12:39:20 <clokep_work> sawrubh: You can have different levels in different MUCs, so it's certainly not account centric!
12:39:44 <clokep_work> sawrubh: Yes, it's on the participant that represents you: https://mxr.mozilla.org/comm-central/source/chat/components/public/prplIConversation.idl#136
12:41:56 <clokep_work> sawrubh: https://mxr.mozilla.org/comm-central/source/chat/protocols/irc/irc.js#540 is the IRC implementation, we check if we're in the room, (That coudl probably just be a check against this.left btw), then we get the prplIConvChatParticipant instance that represents us, then do some checks on it.
12:42:31 <clokep_work> And...that check doesn't look right in that code. :-\
12:43:00 * sawrubh goes over this again
12:43:48 <clokep_work> sawrubh: Please ask questions if oyu have them, I know it's a lot of interacting pieces.
12:43:52 <sawrubh> btw in irc.js the topicSettable is called when setMode is called, in xmpp, should we call this on connect()
12:44:34 <sawrubh> (or equivalent of connect)
12:48:08 <clokep_work> sawrubh: The proper place to call it would be when the participant representing us has it's mode changed.
12:48:30 <clokep_work> sawrubh: Well...you don't have to CALL topicSettable ever.
12:48:43 <clokep_work> The conversation service calls it.
12:48:48 <clokep_work> Where do you see it being called
12:48:48 <clokep_work> ?
12:50:01 <sawrubh> line 584 of irc.js
12:51:08 <sawrubh> afk for 15 minutes (sorry )
12:52:51 <clokep_work> sawrubh: That's implementation details for IRC, please don't get too wrapped up in it. It's pretty much asks "If we are now able to set the topic and didn't used to be (or vice versa), then notify the UI that this has changed"
12:58:58 --> mpmc has joined #instantbird
13:04:37 <sawrubh> back
13:07:06 <clokep_work> OK.
13:10:48 <clokep_work> sawrubh: Ingest some of that and let me know when you have more questions.
13:15:45 <mayanktg> clokep_work: I checked on how to part from Conversation. As aleth disconnection of account works but when I tried "closing conversation " it didn't opt out the user from the list.
13:23:13 --> flo-thinkpad has joined #instantbird
13:23:52 <clokep_work> mayanktg: "closing conversation"? What do you mean? Can you be specific about exactly what you did?
13:26:54 <mayanktg> clokep_work: sorry...I right clicked on the tab menu and selected "close conversation". It should have disconnected the user from the groupchat. right?
13:28:38 <-- flo-thinkpad has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
13:28:49 --> flo-thinkpad has joined #instantbird
13:28:52 <mayanktg> But the username was still on the Participant list. (I used two separate XMPP accounts for this)
13:31:50 <clokep_work> mayanktg: Yes, it should have.
13:31:54 <instantbot> New Chat Core - IRC bug 1012660 filed by clokep@gmail.com.
13:31:55 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1012660 nor, --, ---, clokep, ASSI, Remove _chatRoomFieldsList from IRC code
13:32:05 <clokep_work> mayanktg: We're most likely not sending the message to disconnect, didn't someone point to a TODO about that earlier? :)
13:32:10 <clokep_work> (I forget if it was you or sawrubh.)
13:32:55 <mayanktg> The one I sent was in XMPPConversationPrototype 
13:33:24 <mayanktg> :)
13:38:03 <clokep_work> OK.
13:38:16 <clokep_work> The comment is wrong though it needs to be done only for MUCs, IIRC.
13:38:29 <clokep_work> sawrubh: So the checkTopicSettable thing seems wrong to me, please ignore that. I'm fixing it now.
13:39:13 <instantbot> New Chat Core - IRC bug 1012666 filed by clokep@gmail.com.
13:39:14 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1012666 nor, --, ---, nobody, NEW, Fix up checking if IRC topics are settable
13:52:57 * clokep_work wonders why mayanktg is interested in me removing the _chatRoomsFieldList. ;)
13:56:54 <mayanktg> mayanktg: I wasn't interested in that. I was finding ways to part MUC chatroom :-|
13:58:06 <clokep_work> mayanktg: You CCed yourself to it, that's why I asked.
13:59:48 <mayanktg> clokep_work: Ok. 
14:00:02 --> nhnt11 has joined #instantbird
14:00:46 <-- flo-retina has quit (Ping timeout)
14:01:08 <nhnt11> Hi
14:01:18 <mayanktg> The bug looked simple. I thought I should see how its done. :-|
14:03:09 --> flo-retina has joined #instantbird
14:03:10 * ChanServ sets mode +qo flo-retina flo-retina 
14:03:17 * nhnt11 writes a comment for clokep_work :P
14:05:32 <-- flo-thinkpad has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:09:24 <nhnt11> clokep_work: Can I carry forward the r+? The interdiff is http://pastebin.instantbird.com/712570
14:09:46 <nhnt11> Um, line 12 shouldn't be there
14:10:09 <nhnt11> (correct interdiff: http://pastebin.instantbird.com/712571
14:10:41 <flo-retina> nhnt11: doesn't seem like a correct diff ;)
14:11:24 <nhnt11> What? :S
14:11:34 <nhnt11> Do you mean the metadata in line 3?
14:11:35 <flo-retina> I don't think it would apply :-P
14:11:50 --> qheaden has joined #instantbird
14:11:53 <flo-retina> yeah
14:11:56 <nhnt11> Yeah yeah. It was just so someone could r+ it on IRC
14:12:00 <-- qheaden has left #instantbird ()
14:12:14 --> qheaden has joined #instantbird
14:12:42 <qheaden> Hello everyone.
14:12:43 <flo-retina> but I think the comment is fine, yes :)
14:12:55 * qheaden finally has a working build after the NSIS patch.
14:13:52 <flo-retina> has it landed? :)
14:14:28 * nhnt11 is going to push that patch
14:14:35 <nhnt11> My second push :D
14:15:43 --> flo-thinkpad has joined #instantbird
14:17:25 <nhnt11> flo-retina: Just to be sure, steps to push are a) checkout, b) qfinish, c) push, correct? (assuming the tree is open)
14:18:25 <nhnt11> flo-thinkpad: ^
14:19:10 <flo-retina> for me it's usually hg pull, hg up, hg st, hg ci, hg out, hg st, hg push
14:19:27 <flo-retina> sometimes with "import" instead of "ci" if I'm doing a check-in of a patch rather than of something I have locally.
14:19:41 <flo-retina> (I don't use mq)
14:20:02 <nhnt11> flo-retina: How do you manage patches if not mq?
14:20:09 <flo-retina> bugzilla :-P
14:21:01 <nhnt11> Too many patches? :P
14:21:23 <nhnt11> flo-retina: How do you export patches though?
14:21:28 * nhnt11 wonders if you can export uncommitted changes
14:21:31 <flo-retina> hg diff
14:21:50 <flo-retina> ah yeah, if you want to use hg export to have the correct metadata in the patches, that's annoying
14:22:05 <nhnt11> Yeah I was thinking about metadata
14:22:22 <flo-retina> people rarely complain about missing metadata if you are doing the checkins yourself
14:22:28 <flo-retina> I'll likely use mq someday :-)
14:22:42 <nhnt11> Hmm
14:27:02 <instantbot> nhnt11@gmail.com changed the Resolution on bug 1007422 from --- to FIXED.
14:27:06 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1007422 min, --, ---, nhnt11, RESO FIXED, IRC channels prefixed with "##" are difficult to filter in the awesometab.
14:28:52 --> aleth has joined #instantbird
14:28:52 * ChanServ sets mode +o aleth 
14:29:17 <clokep_work> nhnt11: Acutally I'm gonna straight up r- That bug.
14:29:20 <clokep_work> Which bug is that from?
14:29:32 * nhnt11 starts to sweat
14:29:51 <nhnt11> I just pushed it... -_-'
14:30:07 <clokep_work> You didn't wait to hear back from me about the comment? :(
14:30:10 * nhnt11 is never going to push stuff without double confirmation again
14:30:24 * nhnt11 figured since flo said ok...
14:30:40 <nhnt11> Sorry
14:31:15 <clokep_work> nhnt11: OK so what I was thinking of having you do won't work.
14:31:23 <clokep_work> But I think that'd be clearer as a regex personally.
14:31:31 <clokep_work> So that's OK, I guess.
14:31:33 <nhnt11> clokep_work: I think we avoided a regex due to performance reasons?
14:31:44 <nhnt11> Hmm the second part could've been a regex I guess
14:31:46 <flo-retina> clokep_work: isn't changing the logic outside the scope of that bug?
14:32:02 <clokep_work> flo-retina: I wasn't asking to change logic.
14:32:12 --> iamjayakumars has joined #instantbird
14:32:19 <clokep_work> flo-retina: I was going to ask him to use startsWith, but then realized it wouldn't work.
14:32:32 <aleth> I did r+ the actual code ;)
14:32:37 <flo-retina> we already had that discussion months ago to come up with such confusing code
14:32:49 <nhnt11> clokep_work: Aren't we already using startsWith?
14:32:52 <flo-retina> you asked "Can we add some comments in there before committing?", nhnt11 did add a comment
14:32:57 <clokep_work> nhnt11: I see an indexOf in there. ;)
14:33:16 <nhnt11> Um, so that was a clever way of checking startsWith for multiple chars that aleth came up with
14:33:28 <flo-retina> clokep_work: there's a trick, we use indexOf on a string of length 1 ;)
14:33:29 <clokep_work> nhnt11: I know! I just said I understand now why it isn't used.
14:33:35 <nhnt11> ok ok
14:33:35 * clokep_work isn't sure why everyone is teaming up on him.
14:33:41 <clokep_work> Please STOP!
14:33:43 <clokep_work> And re-read what I said.
14:33:54 <clokep_work> I already said I'm ok w/ it after re-reading.
14:33:56 * nhnt11 wasn't attacking clokep
14:33:58 <flo-retina> clokep_work: we reacted to "nhnt11: Acutally I'm gonna straight up r- That bug."
14:34:00 <nhnt11> (sorry)
14:34:12 <clokep_work> flo-retina: But not any of the comments after that apparently. ;)
14:34:55 <clokep_work> nhnt11: Also, be careful when adding links to the logs! Try not to link to things that have "today" in them. :)
14:35:04 <clokep_work> Since if I click on it tomorrow it'll be the wrong thing!
14:35:07 <nhnt11> Uh, did I do that? :(
14:35:13 <aleth> Didn't Mic fix that problem for us?
14:35:40 <clokep_work> In the bug, yeah about flo's approval.
14:35:52 <clokep_work> aleth: I don't remember if it works in Instantbird, but he certainly didn't fix it for Fx!
14:35:57 <nhnt11> clokep_work: I realized where, didn't realize I forgot about today :)
14:35:59 <nhnt11> Anyway
14:36:09 <aleth> clokep_work: That's unfortunate ;)
14:36:14 --> nhnt12 has joined #instantbird
14:37:38 <-- nhnt11 has quit (Ping timeout)
14:37:38 <clokep_work> nhnt11: Just for the future!
14:38:16 --> mconley has joined #instantbird
14:38:41 * clokep_work was really hoping for comments throughout that function btw. ;)
14:38:46 <clokep_work> But that's probably outside the scope of that bug.
14:40:07 <aleth> clokep_work: That's nice that we can now remove the ugly chatroomfieldslist :)
14:40:23 <aleth> Well spotted.
14:40:25 <clokep_work> aleth: I figured you'd enjoy it! Please be careful looking over that logic.
14:40:38 <clokep_work> I looked over it a lot of times, but it really needs a careful review.
14:40:50 <aleth> Yes, I remember that being tricky when I wrote it.
14:40:57 <aleth> I'll have to remember why ;)
14:43:12 <clokep_work> Woo, someone cared about bug 1011878. ;)
14:43:14 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1011878 nor, --, ---, nobody, NEW, mozGetUserMediaDevices doesn't work until getUserMedia is called
14:43:15 <clokep_work> aleth: Thanks. :)
14:43:21 <clokep_work> I gave you a lot of reviews, sorry!
14:43:30 <clokep_work> I had time while on a ferry this weekend. . .but no Internet.
14:45:56 <aleth> clokep_work: Is there a bug about moving the whole chatroomfields/reconnection logic into jsprotohelper?
14:46:17 <clokep_work> aleth: Not really, no.
14:46:21 <flo-retina> mayanktg: can you try the webrtc patch soon?
14:46:36 <aleth> Maybe there should be
14:46:41 * aleth muses
14:47:40 <flo-retina> clokep_work: yes, the WebRTC team is quite reactive! :)
14:48:23 <-- aleth has quit (Ping timeout)
14:49:30 * nhnt12 is now known as nhnt11
14:49:46 --> aleth has joined #instantbird
14:49:46 * ChanServ sets mode +o aleth 
14:49:56 <clokep_work> aleth: Maybe! :) My guess is that chatRoomFields should be on the interface and the rejoining should be done by conversations.js.
14:50:22 <aleth> That's where it would go if we could make it work for libpurple too...
14:50:29 <aleth> maybe we can.
14:51:53 <mayanktg> flo-retina: Yes I was just qush the patch 
14:52:38 <mayanktg> I should qpush it into the mozilla/  hg directory right?
14:52:58 <aleth> You can use qimport.
14:53:05 <aleth> But yes.
14:53:18 <mayanktg> Yes. I did a qimport and then qpush
14:53:34 <mayanktg> I was in mozilla/ subdirectory
14:53:43 <aleth> Yes, that's correct.
14:53:49 <nhnt11> bbl after dinner
14:53:52 <mayanktg> But it gave an error: abort: local changes found
14:54:12 <aleth> So try hg diff to look at the local changes you have ;)
14:58:08 <-- mconley has quit (Input/output error)
14:59:08 <clokep_work> sawrubh: Any progress? :)
15:17:26 <-- nhnt11 has quit (Ping timeout)
15:17:46 --> nhnt11 has joined #instantbird
15:26:47 <-- sonny has quit (Ping timeout)
15:30:27 <-- nhnt11 has quit (Ping timeout)
15:31:00 --> nhnt11 has joined #instantbird
15:32:51 <clokep_work> aleth: So Komodo highlighted "class" as if it were a keyword.
15:32:55 <clokep_work> Which is why I used cls.
15:33:03 <clokep_work> And you're right, I should s/_conversations/conversations/.
15:33:51 <aleth> clokep_work: Maybe convClass if that is less confusing then.
15:34:23 --> Vigilante has joined #instantbird
15:34:36 <clokep_work> aleth: Sure. I'll check if class is actually reserved or not, I gess.
15:34:40 <clokep_work> Thanks for the reviews. :)
15:35:43 <aleth> Sublime Text also seems to think it's a keyword, though I have no idea what it does if so.
15:36:19 <aleth> May just be people copypasting the same syntax highlighting files...
15:37:33 <aleth> mayanktg: Does that patch fix the problem?
15:37:49 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:37:51 <clokep_work> aleth: Ah, it is a keyword...
15:37:53 <-- nhnt11 has quit (Ping timeout)
15:38:02 <-- flo-thinkpad has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:38:09 <clokep_work> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Reserved_Words
15:38:12 --> nhnt11 has joined #instantbird
15:38:18 <-- aleth has quit (Quit: exit stage left)
15:38:21 --> aleth has joined #instantbird
15:38:21 * ChanServ sets mode +o aleth 
15:42:02 <aleth> clokep_work: "future use"? :P
15:42:52 <clokep_work> aleth: Yup! :) So what name do you want?
15:43:45 --> flo-retina has joined #instantbird
15:43:45 * ChanServ sets mode +qo flo-retina flo-retina 
15:44:08 <mayanktg> aleth: I applied the patch successfully then did a "make -C obj../mozilla/dom/media/" . 
15:44:31 <aleth> mayanktg: Safer to do a mozilla/mach build from c-c.
15:44:42 <aleth> But if that worked for you...
15:45:19 <-- nhnt11 has quit (Ping timeout)
15:45:21 <mayanktg> Upon removing the gUM() the menu button still remains disabled :-/ I tried using Cu.reportError too.
15:45:30 <mayanktg> ok...
15:46:14 --> nhnt11 has joined #instantbird
15:46:18 <aleth> If you make -C you only build that subfolder, you don't build the dependencies.
15:47:10 <mayanktg> OK. so I have to do that on dom/ ? 
15:47:15 <nhnt11> re
15:47:35 <aleth> mayanktg: No, you go to your root c-c folder and mozilla/mach build as per usual.
15:48:06 <nhnt11> aleth: Anything you want me to do before getting started? I think the timeline in my proposal is good to go?
15:48:13 <mayanktg> ohh. Okay. Let me try it then.
15:48:18 <mayanktg> Thanks :)
15:48:53 <aleth> mayanktg: If you only change IM code and no interfaces you can "mozilla/mach build im". But you want to pick up the m-c changes here.
15:49:15 <aleth> nhnt11: The logger.js upgrade still seems the best place to start.
15:49:28 <nhnt11> aleth: That's what I intend to start with right now
15:49:32 <aleth> Cool :)
15:49:49 <mayanktg> Yeah. Understood it :)
15:52:02 <-- nhnt11 has quit (Ping timeout)
15:52:24 <aleth> Try to ping flo-retina for some of the pain points he encountered with logger.js when he tried to index logs when you/he get a chance.
15:52:24 --> nhnt11 has joined #instantbird
15:52:30 <aleth> nhnt11 ^^
15:52:39 <sawrubh> aleth: yo, https://pastebin.mozilla.org/5200733 is the current diff
15:53:00 <sawrubh> I'm getting an error on that participants line
15:53:10 <nhnt11> aleth: Alright.
15:54:22 <-- gerard-majax_ has quit (Ping timeout)
15:55:10 <aleth> sawrubh: What's the error?
15:55:14 --> arlolra has joined #instantbird
15:55:36 <-- nhnt11 has quit (Ping timeout)
15:56:09 --> nhnt11 has joined #instantbird
15:56:52 <clokep_work> sawrubh: Wait.. why are you re-requesting the conversation from the account? (Sorry I just realized this, I know you showed me this earlier)
15:57:00 <clokep_work> sawrubh: this._account._mucs[this._account._connection._jid] == this, doesn't it?
15:57:09 <aleth> I'm puzzled by that line too.
15:58:08 <aleth> And have you tried simple things like dump(this._account._connection._jid) and dumping the participant nicks to see if it really gives you what you want here?
15:58:33 <aleth> Looks suspicious to me.
15:58:36 --> quartzjer has joined #instantbird
15:58:55 <sawrubh> so the error I was getting was 'this._participants.get(...) is undefined'
15:59:22 <aleth> Yeah, so the key is wrong.
15:59:23 <clokep_work> sawrubh: So...how new is your code? The thing that made _participants a Map is fairly new...
15:59:54 <aleth> Try what I suggested to *see* what the problem is.
16:00:07 <sawrubh> clokep_work: I'm re-requesting it because 'this' while in XMPPMUCConversationPrototype is MUC while '_conv' is a property of XMPPAccountPrototype
16:00:12 <clokep_work> Check that line in jsProtoHelper I gave you in that IM locally vs. what's on MXR.
16:00:46 * sawrubh -> serializing all the parallel stuff that was just said :P
16:00:54 <clokep_work> sawrubh: I don't understand your response.
16:01:13 <-- nhnt11 has quit (Ping timeout)
16:01:58 --> nhnt11 has joined #instantbird
16:02:13 <aleth> sawrubh: What happens when you do this.setTopic(...) ?
16:03:54 <-- iamjayakumars has quit (Quit: )
16:04:31 * sawrubh wonders if there's a better way than to dump things and inspect
16:04:37 <sawrubh> probably somekind of debugger
16:04:48 <aleth> sawrubh: You can use the debugger if you like.
16:05:10 <aleth> But it takes a while to set up. Usually dump is faster if it's a simple thing.
16:07:10 <-- nhnt11 has quit (Ping timeout)
16:07:35 --> nhnt11 has joined #instantbird
16:08:06 <aleth> sawrubh: In case it wasn't clear: what you need to look at is this._participants.keys()
16:08:21 <sawrubh> yeah, dumping it
16:08:41 <aleth> Because get returns undefined if the key doesn't exist ;)
16:13:13 <nhnt11> brb
16:15:22 <-- nhnt11 has quit (Input/output error)
16:15:25 --> nhnt11 has joined #instantbird
16:16:27 <sawrubh> aleth: so after doing this.setTopic() it works
16:16:58 <aleth> Do you understand now /why/ this.setTopic works?
16:17:42 <sawrubh> no :P
16:17:51 <sawrubh> lemme think for a moment
16:18:14 <aleth> http://mxr.mozilla.org/comm-central/source/chat/modules/jsProtoHelper.jsm#539 is inherited
16:20:17 <mayanktg> aleth: I did a "./mozilla/mach build" on c-c. But the patch doesn't work for me :-/ . its still dependent on gUM.
16:20:29 <mayanktg> bbl
16:20:44 <aleth> mayanktg: Then you should give that feedback in the bug ;) 
16:23:33 <aleth> sawrubh: Have you checked whether you actually need to call setTopic in the setter? i.e. look at the debug log and see if you get a server response to the topic-setting stanza you send out. (And of course run a second instance joined to the same room and see if the topic change happens correctly there too)
16:35:20 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
16:39:32 <-- nhnt11 has quit (Ping timeout)
16:39:56 --> nhnt11 has joined #instantbird
16:40:25 <sawrubh> aleth: I get a resource conflict when I try to connect to the same room from a different instance of IB, using the same jabber id but with a different nick
16:40:43 <sawrubh> is this not allowed, being online in 2 instances with the same jabber id
16:40:47 <clokep_work> Change your resource? :)
16:41:11 <aleth> Make a new account with a different nick?
16:41:13 --> wnayes has joined #instantbird
16:45:00 <-- quartzjer has left #instantbird ()
16:45:32 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:47:18 <clokep_work> aleth: Thanks for the reviews. :)
16:47:30 <aleth> Those were the easy ones :0
16:47:43 <clokep_work> sawrubh: Do you know what a resource is? It's not your nickname, although I don't know exactly how this relates to names in MUCs, flo-retina should know (but is in a meeting).
16:50:05 <aleth> sawrubh: Did you figure out the key issue? ;)
16:51:42 <sawrubh> aleth: yeah, currently I'm not stuck anywhere
16:51:51 <sawrubh> eating a melon, looking at the debug log
16:51:51 <clokep_work> Cool. :)
16:52:21 <mayanktg> back!
16:52:21 <clokep_work> The backend protocols are a bit of a beast, but hopefully you're learning where to look things up and such! :)
16:55:46 --> jb has joined #instantbird
16:57:50 <clokep_work> aleth: Do you want to resee that conversations patch?
16:58:01 <aleth> Not really.
16:58:10 <aleth> I trust your search and replace skillz ;)
16:59:34 <clokep_work> Haha, well then just r+ it. :P
17:04:23 <aleth> Huh, splinter really put useful context in that comment :-/
17:05:39 <aleth> clokep_work: I think you attached the wrong patch
17:06:33 <clokep_work> aleth: You're right osrry.
17:06:40 <clokep_work> Crap I forgot to request review on it. Can oyu just take a look?
17:08:02 <aleth> clokep_work: Don't forget to check that normalizeNick line before landing
17:09:14 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:11:43 <clokep_work> aleth: I commented, I'll wait for a response before pushing anything
17:12:55 <aleth> clokep_work: That's good, I commented because I didn't understand why it was there in the first place.
17:13:13 <clokep_work> Yeah, I should have mentioned it when uploading the patch. :)
17:13:20 <clokep_work> I didn't have internet when writing them. :(
17:14:18 * Fallen|away is now known as Fallen
17:15:33 <clokep_work> aleth: We comfortable w/ me pushing those four patches then? :)0
17:16:26 <-- aleth has quit (Ping timeout)
17:19:46 * clokep_work takes that as a yes. ;)
17:21:46 <instantbot> clokep@gmail.com changed the Resolution on bug 955366 from --- to FIXED.
17:21:50 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955366 min, --, 1.6, clokep, RESO FIXED, Use Maps and Sets in IRC code
17:23:36 <sawrubh> hmm..so the stanza isn't being sent correctly, let's fix this!
17:26:52 <sawrubh> clokep_work: any idea where would the idl or spec for Stanza be?
17:29:39 <sawrubh> got it, xmpp-xml.jsm
17:36:17 --> sonny has joined #instantbird
17:37:09 <-- sonny has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:37:33 <clokep_work> sawrubh: That interface is a bit confusing, but yeah it should be in there.
17:38:44 <sawrubh> I wanted to see how libpurple crafts it's message (since that's working) but debug log doesn't work for it :/
17:41:41 <clokep_work> It does not.
17:41:57 <clokep_work> sawrubh: Did you look at the XEP to see what to send?
17:42:08 <clokep_work> You can use Wireshark most likely to see what libpurple is sending.
17:42:10 <clokep_work> Or read the code.
17:42:28 <sawrubh> or just follow the XEP, which is simpler :)
17:43:11 --> flo-retina has joined #instantbird
17:43:11 * ChanServ sets mode +qo flo-retina flo-retina 
17:43:44 <clokep_work> I'd suggest following the XEP, yes.
17:45:12 <flo-retina> let's not reverse engineer what's documented ;)
17:57:27 --> CaptainCalliope has joined #instantbird
18:11:55 <-- wnayes has quit (Quit: wnayes)
18:12:51 <-- jb has quit (Ping timeout)
18:24:32 <clokep_work> flo-retina++
18:24:40 <clokep_work> Oops, I mean ++flo-retina.
18:24:42 <clokep_work> ;)
18:25:24 <sawrubh> for?
18:28:41 * nhnt11 needs to sleep.
18:28:59 <nhnt11> I'll be online tomorrow, something came up and I was out all day today.
18:29:14 <clokep_work> sawrubh: Not reverse engineering documented things.
18:32:38 <-- Vigilante has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
18:45:15 <-- nhnt11 has quit (Ping timeout)
18:45:56 --> nhnt11 has joined #instantbird
18:48:10 <clokep_work> qheaden: I meant to r? you on https://hg.mozilla.org/comm-central/rev/ffcaadc29781
18:49:37 --> mconley has joined #instantbird
18:49:55 <qheaden> clokep_work: Looks good.
18:50:54 <-- CaptainCalliope has quit (Ping timeout)
18:51:37 --> CaptainCalliope has joined #instantbird
18:54:18 <clokep_work> :) Thanks.
18:57:55 <qheaden> clokep_work: NormalizedMap is pretty cool.
18:58:01 <qheaden> I'm looking at your IRC diffs
19:02:29 --> gerard-majax_ has joined #instantbird
19:03:10 <-- CaptainCalliope has quit (Quit: CaptainCalliope)
19:05:19 <clokep_work> qheaden: Thanks. It's OK. It'll be better once @@create is supported. (I had written a blog post on NormalizedMap btw.)
19:06:09 --> mpmc has joined #instantbird
19:23:01 * mconley is now known as mconley|food
19:41:07 --> Mic has joined #instantbird
19:41:08 * ChanServ sets mode +o Mic 
19:41:41 <-- mconley|food has quit (Input/output error)
19:42:11 --> Vigilante has joined #instantbird
19:48:55 --> Armada has joined #instantbird
19:51:27 <-- Fallen has quit (Ping timeout)
19:51:27 <-- stux has quit (Ping timeout)
19:51:38 <-- Mic has quit (Ping timeout)
19:52:28 <-- instant-buildbot has quit (Ping timeout)
20:01:49 <clokep_work> sawrubh: Any luck with sending the proepr stanza?
20:02:35 --> CaptainCalliope has joined #instantbird
20:04:34 <sawrubh> pretty close (I had gone off somewhere for a while in between)
20:08:19 --> Fallen has joined #instantbird
20:12:37 --> mconley|food has joined #instantbird
20:12:55 <-- mconley|food has quit (Input/output error)
20:13:03 --> mconley|food has joined #instantbird
20:17:44 <sawrubh> clokep_work: current diff https://pastebin.mozilla.org/5201843
20:19:55 <sawrubh> I see [object Object] in the dump, any idea how can I see the exact representation
20:19:58 <clokep_work> sawrubh: I thought the stanza for a topic was just a subject element?
20:20:12 <clokep_work> sawrubh: JSON.stringify(foo) is generally what I do.
20:20:16 <clokep_work> Maybe foo.toSource().
20:20:23 <sawrubh> it's a subject element inside message
20:20:41 <sawrubh> http://xmpp.org/extensions/xep-0045.html#enter-subject ?
20:20:42 --> EionRobb has joined #instantbird
20:20:53 <clokep_work> Ah, so I read that backwards.
20:21:25 <clokep_work> Generally I'd suggest using longer variable names than s and n and such, but that kind of fits into the style of the file. :-S
20:22:01 * sawrubh wonders why he isn't seeing any sent object in the debug log
20:22:23 <sawrubh> this bug again is teaching me quite a lot of things :)
20:22:24 <clokep_work> sawrubh: You also probably don't need all those trailing nulls btw.
20:24:25 <clokep_work> sawrubh: I'm not sure, looks like it should be there...
20:24:31 <-- mconley|food has quit (Input/output error)
20:24:32 <clokep_work> Are there any errors that pop up?
20:25:01 <sawrubh> le me take ze look
20:25:39 <clokep_work> (I.e. is sendStanza throwing for some reason)
20:26:47 <sawrubh> there are so many things to take a look at, error console, debug log copied in editor and then these two instances of IB :)
20:27:04 <sawrubh> and the terminal too
20:27:38 <sawrubh> not that I'm complaining though
20:28:46 <clokep_work> I usually just use the error console unless I want a full dumb of the debug log.
20:29:01 <clokep_work> (And I usually test with my real instance of Instantbird + a dev one)
20:29:13 <flo-retina> unless you are on Windows (where the terminal is really awful), a terminal is usually easier to use than the error console
20:29:28 --> mconley|food has joined #instantbird
20:30:04 <sawrubh> flo-retina: I suppose there must be a pref then to make the errors be thrown to the terminal itself
20:31:31 <flo-retina> the debug logs go to the terminal (http://lxr.instantbird.org/instantbird/source/chat/modules/imXPCOMUtils.jsm#83)
20:32:20 <flo-retina> the other errors/warnings don't in normal builds (but most do in debug builds)
20:33:01 <-- mconley|food has quit (Input/output error)
20:33:52 <sawrubh> hmm, so https://pastebin.mozilla.org/5201896 is the dump of the 3 things, and no error on the error console nor anything in the debug log
20:34:09 <flo-retina> I can't connect to pastebin :-S
20:37:13 <sawrubh> hrm, the id and from field aren't set in the stanza (although the 'subject' is as a child which is what I wanted)
20:38:23 <clokep_work> sawrubh: So I'm a little confused. Do you even see it leaving in the socket logging code or no?
20:38:25 <flo-retina> if you want me to look, pastebin on pastebin.instantbird.org
20:39:20 <sawrubh> flo-retina: http://pastebin.instantbird.com/712738
20:39:43 <flo-retina> what is this from?
20:41:11 <sawrubh> flo-retina: this diff http://pastebin.instantbird.com/712739
20:41:21 <sawrubh> gah, my bad
20:42:07 <sawrubh> I was searching for the topic I had entered, in the debug log, however the subject node I'm creating has an empty body
20:42:13 <sawrubh> hence I wasn't able to find it
20:42:20 <sawrubh> found it now in the debug log
20:43:00 <flo-retina> the n variable should have a better/longer name
20:43:41 <flo-retina> s is ok, it's the typical name in the xmpp code for the 'top level' stanza that will be passed to sendStanza
20:43:41 <sawrubh> clokep_work already pointed that out, but I was basically trying to follow the norm in the file (I'll change it once this works)
20:44:02 <sawrubh> got it, so the server is saying bad-request
20:44:07 <sawrubh> cool!
20:44:21 <flo-retina> are you a moderator in that room? :)
20:45:08 <sawrubh> http://pastebin.instantbird.com/712740
20:46:08 <sawrubh> flo-retina: so using libpurple I'm able to edit the topic so I'm assuming, I'm whatever it takes to edit the topic
20:46:20 <flo-retina> seems a good assumption :)
20:46:42 <clokep_work> sawrubh: Well looks like the subject is empty. :P
20:46:47 <flo-retina> indeed!
20:48:46 <sawrubh> example 43 in http://xmpp.org/extensions/xep-0045.html#enter-subject says that shouldn't be an issue
20:48:57 <sawrubh> so I see 3 possible things
20:49:26 <sawrubh> a) subject element is '<subject/>' instead of '<subject><subject/>'
20:49:43 <flo-retina> sawrubh: where is the XEP for setting the subject?
20:50:04 <sawrubh> b) subject element is empty (assuming a ^^ is not an issue)
20:50:18 <flo-retina> sawrubh: these are the stanzas sent from the server to you
20:50:21 <sawrubh> c) from attribute is not set in message, nor is the id attribute set
20:50:52 <sawrubh> flo-retina: I'm talking about line 3 of http://pastebin.instantbird.com/712740, that's my message right
20:51:16 <sawrubh> flo-retina: http://xmpp.org/extensions/xep-0045.html#enter-subject is the XEP for setting the room subject
20:51:27 <flo-retina> sawrubh: what are you trying to do?
20:51:59 <sawrubh> I'm trying to fix bug 1011226
20:52:01 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1011226 nor, --, ---, saurabhanandiit, NEW, Support setting the topic in XMPP MUCs
20:52:13 <sawrubh> I click on topic/subject, enter something and set it
20:52:14 <flo-retina> sawrubh: what about you start reading around http://xmpp.org/extensions/xep-0045.html#subject-mod ?
20:53:19 <sawrubh> yes, that section is what I read for implementing the 'topicSettable()' part of the idl/spec
20:53:28 --> stux has joined #instantbird
20:53:53 <sawrubh> (right now I'm returning true but eventually I plan to check if the user editing is the mod in the room)
20:54:48 --> Mic has joined #instantbird
20:54:48 * ChanServ sets mode +o Mic 
20:55:39 <flo-retina> sawrubh: fix the "to" attribute in the message you are sending
20:56:34 <flo-retina> sawrubh: remove  |+ "/" + this._nick| in your code
20:57:55 <sawrubh> yeah!
21:02:12 <clokep_work> Does that mean it's working? ;)
21:03:16 <clokep_work> (Read as https://www.youtube.com/watch?v=AXwGVXD7qEQ . . .)
21:03:25 <sawrubh> http://pastebin.instantbird.com/712761, I'm getting the correct server response now
21:04:01 <sawrubh> now just need to do a few things and we should we on our way to a r+ :P
21:04:30 <clokep_work> Excellent! :)
21:04:32 <flo-retina> on our way to clokep asking for comments and me for tests :-P
21:04:42 <sawrubh> e_e
21:15:26 <clokep_work> sawrubh: So we should probably discuss some UI stuff once this is over and get you started on your "real" project.
21:15:34 <clokep_work> As much as I like you improving the XMPP code. :)
21:16:31 <sawrubh> gimme 15 min, lemme just figure out why this notifyObserver ain't observing
21:16:45 <clokep_work> sawrubh: I didn't mean now. :) I'm going home soon.
21:24:05 <sawrubh> flo-retina: so what I'm doing right now is sending a message to the server, shouldn't IB automatically handle the response from the server (by calling onMessageStanza)
21:24:22 <flo-retina> isn't this what happens?
21:27:29 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:28:54 <sawrubh> hrm, no
21:29:35 <sawrubh> no one is handling the reply sent by the server, btw the topic is being set correctly (and is visible to the other members on that channel too)
21:29:43 * sawrubh takes a look
21:30:19 <flo-retina> have you fixed that other bug about displaying the subject?
21:31:14 <sawrubh> yes and it has already landed (the code I'm building off has that patch applied)
21:31:27 * sawrubh updates the code again, just to be sure
21:31:54 <-- gerard-majax_ has quit (Ping timeout)
21:42:39 --> mconley|food has joined #instantbird
21:42:40 <-- mconley|food has quit (Input/output error)
21:52:40 <-- mayanktg has quit (Quit: Connection closed for inactivity)
22:04:24 * Fallen is now known as Fallen|away
22:04:44 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
22:06:43 <-- Even has quit (Ping timeout)
22:38:38 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:51:03 --> Rym has joined #instantbird
23:07:45 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
23:13:45 --> clokep has joined #instantbird
23:13:45 * ChanServ sets mode +o clokep 
23:14:15 <clokep> sawrubh: Were you able to figure it out?
23:42:55 <-- Rym has quit (Ping timeout)
23:43:12 --> Rym has joined #instantbird
23:45:51 <-- Vigilante has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
23:47:49 <-- Armada has quit (Connection reset by peer)
23:50:13 <-- arlolra has quit (Quit: arlolra)