#instantbird log on 05 04 2014

All times are UTC.

00:14:03 <-- Armada has quit (Connection reset by peer)
01:24:06 --> qheaden has joined #instantbird
02:00:42 <-- clokep has quit (Ping timeout)
02:01:01 --> clokep has joined #instantbird
02:01:01 * ChanServ sets mode +o clokep 
02:31:29 <-- Rym has quit (Ping timeout)
02:31:59 --> Rym has joined #instantbird
02:55:03 <-- clokep has quit (Ping timeout)
02:56:25 --> clokep has joined #instantbird
02:56:25 * ChanServ sets mode +o clokep 
02:58:39 <-- clokep has quit (Ping timeout)
03:02:38 --> clokep has joined #instantbird
03:02:38 * ChanServ sets mode +o clokep 
03:14:32 <-- nhnt11 has quit (Ping timeout)
03:15:56 --> nhnt11 has joined #instantbird
03:28:20 <instant-buildbot> build #2132 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2132
03:43:35 <instant-buildbot> build #1352 of win32-nightly-default is complete: Failure [4failed shell_5]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1352
03:59:54 <-- Rym has quit (Ping timeout)
04:11:31 <-- nhnt11 has quit (Ping timeout)
04:15:04 --> nhnt11 has joined #instantbird
04:26:43 <-- qheaden has quit (Ping timeout)
04:34:55 <-- wnayes has quit (Quit: wnayes)
04:55:54 <-- nhnt11 has quit (Ping timeout)
04:59:05 --> nhnt11 has joined #instantbird
05:38:59 --> kramolnik has joined #instantbird
05:53:36 <-- EionRobb has quit (Quit: Leaving.)
06:34:30 --> mpmc has joined #instantbird
07:51:31 <-- flo-retina has quit (Ping timeout)
08:25:14 <-- deltafalcon has quit (Ping timeout)
08:28:04 --> jb has joined #instantbird
08:29:10 --> gerard-majax_ has joined #instantbird
08:29:59 <-- clokep has quit (Ping timeout)
08:30:22 <-- kramolnik has quit (Connection reset by peer)
08:31:22 --> kramolnik has joined #instantbird
08:31:47 --> clokep has joined #instantbird
08:31:48 * ChanServ sets mode +o clokep 
08:33:34 <-- clokep has quit (Ping timeout)
08:42:21 --> clokep has joined #instantbird
08:42:22 * ChanServ sets mode +o clokep 
08:52:01 --> Armada has joined #instantbird
09:41:29 <-- jb has quit (Ping timeout)
09:57:08 <-- clokep has quit (Ping timeout)
09:59:42 --> Rym has joined #instantbird
10:00:45 --> clokep has joined #instantbird
10:00:45 * ChanServ sets mode +o clokep 
10:26:03 <-- mpmc has quit (Ping timeout)
10:26:38 --> mpmc has joined #instantbird
10:30:12 <-- mpmc has quit (Ping timeout)
10:30:53 --> mpmc has joined #instantbird
10:49:17 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:42:19 <-- Tonnes has quit (Quit: ChatZilla [Firefox 29.0/20140421221237])
11:46:15 <-- gerard-majax_ has quit (Ping timeout)
12:06:04 <-- BWMerlin has quit (Quit: BWMerlin)
12:09:38 --> quartzjer has joined #instantbird
12:57:28 <clokep> Anyone look at that faliure yet?
12:57:54 <clokep> Ah, just during distribution...
13:01:59 --> mayanktg has joined #instantbird
13:10:35 --> gerard-majax has joined #instantbird
13:12:23 <mayanktg> aleth: Hello!
13:12:41 <mayanktg> aleth: I'm able to change the user icon now :D
13:17:43 <mayanktg> aleth: Here's the pastebin http://pastebin.instantbird.com/695670 
13:44:56 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:45:04 --> clokep has joined #instantbird
13:45:04 * ChanServ sets mode +o clokep 
13:50:58 --> Tonnes has joined #instantbird
13:52:45 <mayanktg> The user icon is not the present image I clicked but the one before that :'(
13:58:01 <clokep> mayanktg: Does your code properly work if the image file already exists? I.e. does it overwrite properly?
13:58:54 <mayanktg> earlier it didn't. Then on using Services.core.globalUserStatus.setUserIcon(null); it is now able to change the icon and replace it with new one
14:00:57 <-- Rym has quit (Ping timeout)
14:04:06 --> nhnt11-phone has joined #instantbird
14:09:02 <-- nhnt11-phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
14:16:36 --> Rym has joined #instantbird
14:26:02 --> mpmc has joined #instantbird
14:51:53 <-- quartzjer has quit (Quit: Leaving.)
15:01:30 --> iamjayakumars has joined #instantbird
15:06:23 --> aleth has joined #instantbird
15:06:23 * ChanServ sets mode +o aleth 
15:09:29 <aleth> mayanktg: Hi :)
15:17:08 <mayanktg> aleth: Hi! :)
15:17:25 <aleth> Looks like you made some progress :)
15:17:30 <mayanktg> Could you tell whats the problem? http://pastebin.instantbird.com/695733
15:17:36 <aleth> Sure.
15:17:54 <mayanktg> the image set as user Icon is the previous image which I clicked :-/
15:17:55 <aleth> Do you know what a promise is?
15:18:09 <mayanktg> No.
15:18:21 <aleth> Then you should have asked ;)
15:18:34 <mayanktg> Its related to making asynchronous code easier?
15:18:47 * mayanktg not sure though
15:18:48 <aleth> OS.File is asynchronous. So when writeAtomic returns the file has not been written.
15:19:14 <mayanktg> ok!
15:19:26 <aleth> Instead it returns a promise, which allows you to specify what will happen when the file is written.
15:19:49 <aleth> So your code can't work, because it just continues assuming the file exists when it's not there yet.
15:20:22 <mayanktg> Yes. I got it now.
15:20:26 <aleth> You have to put the code following writeAtomic into the function that is called when the promise resolves successfully.
15:20:59 <aleth> With a promise, two things can happen: 1) it resolves successfully or 2) there was an error
15:21:07 <aleth> You should provide functions to handle both cases
15:21:25 <aleth> Take a look at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise
15:21:47 <mayanktg> ok
15:22:09 <aleth> Essentially, what you need is promise.then(function onSuccess, function onError)
15:23:17 <aleth> Promises are a bit complicated when you first encounter them...
15:23:28 <mayanktg> Ok. I understood what needs to be done. I'll try again now!
15:23:55 <mayanktg> are Promises and promise same thing?
15:24:20 <aleth> Promise is the name of an interface, promise is just the variable name in your code.
15:25:14 <aleth> You can think of Promise as a type like string or integer or...
15:25:50 <aleth> So your promise is an instance of Promise.
15:26:25 <mayanktg> Yes. thanks :)
15:27:30 <aleth> A promise has methods just like a string has methods (string.toLowercase() for example)
15:28:35 <mayanktg> Ok. I'll try reading from the docs and implementing the same. I kind of understood why its called a Promise! :)
15:39:30 <-- Rym has quit (Ping timeout)
15:46:33 <-- iamjayakumars has quit (Client exited)
15:48:44 <aleth> nhnt11: Did you get a response from Yoric yet?
15:51:13 --> iamjayakumars has joined #instantbird
15:53:07 <aleth> So I was thinking one solution would be to keep appending to the log file, but ensure that we start a new log file every day. This both limits the file size and makes the log tree entries more sensible for people who rarely close IB.
15:54:12 <aleth> For extra security one could periodically (say every hour) make a backup copy of the log file currently written to, which is automatically deleted after the session is closed.
16:03:05 <aleth> The log reader could then notice if a log file has length zero or is missing, and then check to see if a backup is present, and if it is, use that.
16:03:21 <aleth> s/missing/corrupt
16:04:13 <aleth> (This check is already there, we show an error message in the log reader at the moment if it happens)
16:11:59 <-- mayanktg has quit (Ping timeout)
16:13:38 <clokep> That sounds overly complicated. :-S
16:13:44 <clokep> I'd guess Florian has given some thought to this btw.
16:14:19 <aleth> Well, the "extra security" bit is optional.
16:14:54 --> mayanktg has joined #instantbird
16:14:55 <aleth> It's just an equivalent of what writeAtomic does if you use its security features.
16:16:45 <aleth> If you have any suggestions for simpler ways to provide the same effect... ;)
16:21:45 <aleth> It's certainly something that could be added later after going async. 
16:49:27 --> Mic has joined #instantbird
16:49:27 * ChanServ sets mode +o Mic 
16:50:49 --> Rym has joined #instantbird
16:58:57 <Mic> aleth: thanks for explaining promises :)
17:01:04 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:01:57 <-- Armada has quit (Connection reset by peer)
17:02:06 --> Armada has joined #instantbird
17:03:55 <Mic> mayanktg: if it's working, you can polish the code (i.e. make sure it's following the coding style guidelines, has sensible variable names, ...) and put it up for review.
17:04:24 <Mic> I'll review it as soon as possible then.
17:04:28 <Mic> https://wiki.instantbird.org/Instantbird:Coding_Guidelines
17:04:38 <aleth> Or show it to Mic in a pastebin now for quick feedback ;)
17:04:49 <-- clokep has quit (Ping timeout)
17:04:51 <Mic> Or that :)
17:05:42 <aleth> Just so that the general structure is right before the polish happens...
17:06:13 <Mic> Maybe a review on Bugzilla wouldn't be too bad, to show you Splinter and stuff...
17:06:15 <mayanktg> Mic: i was out for lunch :P I'm writing the code with promise :( . Also please tell me how can I stop the webcam from getting automatically turned on at startup of Ib?
17:07:44 <Mic> I'll check the pastebin. I've got an idea what the problem could be...
17:07:53 <aleth> mayanktg: Don't spend /too/ much time reading the Promises documentation, just the then method I told you about.
17:08:11 <aleth> You don't need the other stuff for this.
17:08:38 <mayanktg> aleth: Ok.
17:09:36 * Mic think mayanktg won't need more than "then()" at the moment...
17:10:29 <Mic> Line 352 is the problem as far as I can tell.
17:10:47 <mayanktg> Mic: the problem is that I'm using takePicture.js file. so navigator.mozGetUserMedia; gets automatically intialized during startup :-/
17:11:22 <mayanktg> ok
17:14:14 * aleth wonders what that file is for
17:14:17 <aleth> Can't all that be inlined?
17:14:35 <aleth> Or alternatively Cu.imported when needed?
17:14:36 <Mic> Most likely.
17:14:50 <mayanktg> It can be. Ok. :)
17:14:58 <aleth> But lets not worry about that until you have it working ;)
17:15:07 <Mic> mayanktg: just get it working, and that's stuff that will come up in a review.
17:15:43 <mayanktg> yes. I'm writing the function now.
17:25:51 <mayanktg> Done :D I current image is displayed now :) . Thanks aleth :D
17:25:59 <aleth> :)
17:26:26 <mayanktg> performing nits now
17:36:19 --> wnayes has joined #instantbird
17:43:11 <-- mayanktg has quit (Ping timeout)
17:49:30 --> mayanktg has joined #instantbird
17:51:33 --> qheaden has joined #instantbird
17:52:10 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:54:07 <-- aleth has quit (Ping timeout)
17:55:59 <-- iamjayakumars has quit (Quit: )
18:04:17 --> qheaden has joined #instantbird
18:47:20 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:53:35 <-- kramolnik has quit (Connection reset by peer)
19:19:35 --> Mic1 has joined #instantbird
19:20:47 <Mic1> mayanktg: could you upload it to BMO and request review? Would be great!
19:20:48 <Mic1> bbl
19:20:55 <-- Mic1 has quit (Quit: Instantbird -- http://www.instantbird.com)
19:21:03 <-- Mic has quit (Ping timeout)
21:22:14 --> EionRobb has joined #instantbird
21:51:41 --> jb has joined #instantbird
21:55:24 <-- jb has quit (Ping timeout)
21:58:01 --> dew has joined #instantbird
22:03:46 --> clokep has joined #instantbird
22:03:46 * ChanServ sets mode +o clokep 
22:22:10 <-- clokep has quit (Ping timeout)
22:22:54 --> Mic has joined #instantbird
22:22:55 * ChanServ sets mode +o Mic 
22:27:37 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
23:42:38 <-- gerard-majax has quit (Ping timeout)