#instantbird log on 03 04 2014

All times are UTC.

00:12:08 <-- Rym has quit (Ping timeout)
00:17:03 --> Rym has joined #instantbird
01:08:13 --> arlolra has joined #instantbird
01:12:14 <-- GeKo has quit (Z:lined (dronebot))
01:22:09 --> clokep has joined #instantbird
01:22:10 * ChanServ sets mode +o clokep 
01:22:27 --> GeKo has joined #instantbird
01:35:54 <-- GeKo has quit (Z:lined (dronebot))
01:45:23 <-- arlolra has quit (Quit: arlolra)
01:55:59 <-- mconley has quit (Input/output error)
02:01:18 --> GeKo has joined #instantbird
02:04:37 <-- GeKo has quit (Z:lined (dronebot))
02:16:25 --> GeKo has joined #instantbird
02:22:06 <-- GeekShadow has quit (Ping timeout)
02:22:09 --> GeekShadow has joined #instantbird
02:43:23 <clokep> I just switched my patch queues over to the c-c stuff...that was painful. :-\
02:44:22 --> mconley has joined #instantbird
02:45:21 --> shashika has joined #instantbird
03:06:06 <-- shashika has quit (Quit: http://www.mibbit.com ajax IRC Client)
03:13:56 <instantbot> clokep@gmail.com changed the Resolution on bug 978778 from --- to DUPLICATE.
03:13:58 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=978778 maj, --, ---, nobody, RESO DUPLICATE, MOZ_PURPLE check needed in the about menu
03:31:07 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
03:31:26 --> clokep has joined #instantbird
03:31:26 * ChanServ sets mode +o clokep 
03:43:42 --> Mook has joined #instantbird
03:46:05 <-- GeKo has quit (Z:lined (dronebot))
03:46:15 --> GeKo has joined #instantbird
04:17:31 <-- EionRobb has quit (Quit: Leaving.)
04:18:37 <-- Rym has quit (Ping timeout)
04:19:02 --> Rym has joined #instantbird
04:32:27 <-- mconley has quit (Input/output error)
05:40:09 --> shrihari1 has joined #instantbird
05:40:17 <-- shrihari1 has quit (Quit: shrihari1)
05:40:38 --> shrihari1 has joined #instantbird
05:40:59 <-- shrihari1 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
05:41:19 --> shrihari1 has joined #instantbird
05:42:03 <-- shrihari1 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
05:42:26 --> shrihari1 has joined #instantbird
06:00:43 <-- shrihari1 has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
06:00:47 --> shrihari has joined #instantbird
06:12:03 <-- shrihari has quit (Ping timeout)
06:13:24 <-- Mook has quit (Quit: Mook)
06:29:47 --> shrihari has joined #instantbird
06:30:51 <-- wnayes has quit (Quit: wnayes)
06:42:10 <-- shrihari has quit (Ping timeout)
06:56:49 --> shrihari has joined #instantbird
07:03:31 <-- shrihari has quit (Ping timeout)
08:16:51 --> Mic has joined #instantbird
08:16:51 * ChanServ sets mode +h Mic 
08:19:53 <-- Rym has quit (Ping timeout)
08:31:03 --> shrihari has joined #instantbird
08:45:10 <-- shrihari has quit (Ping timeout)
08:46:25 <-- gerard-majax__ has quit (Quit: Ex-Chat)
08:46:36 * nhnt12 is now known as nhnt11
08:46:37 --> gerard-majax__ has joined #instantbird
08:47:04 * nhnt11 will likely not be around today after his last test :)
08:56:56 --> shrihari has joined #instantbird
09:05:18 <-- shrihari has quit (Ping timeout)
09:08:56 <-- Mic has quit (Input/output error)
09:20:54 --> Mic has joined #instantbird
09:24:53 <Mic> clokep, flo-retina: what the procedure when adding the reviewer info after r+? Obsoleting the old patch, r+ed patch? Or keeping the old patch and setting the "checkin" flag on the new patch?
09:25:14 <Mic> *the old, r+ed patch
09:26:46 --> pirosb3 has joined #instantbird
09:29:21 <pirosb3> hello @flo-retina. I am having some issues installing Instantbird. In this guide https://wiki.instantbird.org/Instantbird:Compiling it says to add ac_add_options --enable-application=im. My .mozconfig is this, is it correct? https://gist.github.com/PirosB3/9343136 thanks
09:31:05 <-- clokep has quit (Ping timeout)
09:31:27 --> clokep has joined #instantbird
09:31:27 * ChanServ sets mode +o clokep 
09:32:02 <flo-retina> Mic: mark the old patch obsolete. Attach the new one with "(for checkin)" at the end of the description, and carry forward the r+
09:32:20 <flo-retina> and checkin-needed as a keyword
09:32:28 <Mic> OK
09:32:49 <flo-retina> Mic: or if your commit message is already correct and you only miss the reviewer, don't bother, just mark "checkin-needed" and the sheriff will add the r= annotation for you
09:33:15 <Mic> It's only missing the reviewer information.
09:33:31 <flo-retina> it's up to you how nice you want to be with the sheriff then :)
09:33:50 --> shrihari has joined #instantbird
09:34:08 <flo-retina> pirosb3: remove "ac_add_options --enable-calendar"
09:34:41 <flo-retina> pirosb3: well, what are you _actually_ trying to do.
09:34:52 <flo-retina> pirosb3: that mozconfig is a mix of a Firefox and Thunderbird mozconfig :-S
09:35:08 <pirosb3> oh no!
09:35:28 <pirosb3> Mission: build instantbird
09:35:52 <pirosb3> in the compile guide, it says  The only change is that you must create a mozconfig file containing the line ac_add_options --enable-application=im
09:36:21 <pirosb3> would you suggest me a .mozfile for instantbird?
09:37:11 <Mic> Apparantly this was my first patch on BMO. I thought I had contributed something before already :S
09:38:09 <flo-retina> Mic: surprising! :)
09:38:18 <flo-retina> Mic: but I guess... 'congrats! :)' then ;)
09:38:33 <Mic> haha, thanks.
09:38:51 <Mic> There should be more now that we're in c-c
09:38:57 <flo-retina> pirosb3: so in the mozconfig you showed, remove lines 4 to 7
09:39:11 <flo-retina> and you may want to not call your objdir "ff" (line 11)
09:39:36 <flo-retina> Mic: looks like you'll soon get Gerv to add you to about:credits ;)
09:40:36 <flo-retina> bah, tooltips in my contact list are so screwed up :(
09:41:34 <flo-retina> I've got 4 instances of "Patrick Cloke" in the list :-S
09:41:51 <flo-retina> 3 that aren't part of any group.
09:41:54 <pirosb3> flo-retina: will try that thx 
09:41:55 <flo-retina> One that is sorted like "clokep"
09:42:07 --> BWMerlin has joined #instantbird
09:42:20 <flo-retina> and one at the correct alphabetical position, but 'offline' so shouldn't be visible at all.
09:42:22 <flo-retina> so broken :(
09:43:20 --> shashika has joined #instantbird
09:43:24 <flo-retina> Mic: you missed a '>' character on the user line: https://bug684457.bugzilla.mozilla.org/attachment.cgi?id=8385187
09:43:27 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=684457 min, --, ---, benediktp, ASSI, Need keyboard access to 'Tools for all add-ons' button in Addons Manager: Extensions list
09:44:14 <Mic> :o
09:44:57 <Mic> I had fixed that in my hgrc :S
09:45:03 <flo-retina> Linux nightlies are broken again :'(
09:45:08 <pirosb3> Ok flo-retina: This is my updated .mozconf https://gist.github.com/PirosB3/9343136/3b55d3c227683e38c1a848885b3949fe80ccd47c and it is failing saying configure: error: --enable-application value not recognized how is that possible? if I grep for "enable-application" stuff comes out. Could it be I have a wrong version? I am on branch default
09:45:08 <flo-retina> "configure: error: Library requirements (pango >= 1.22.0) not met; consider adjusting the PKG_CONFIG_PATH environment variable if your libraries are in a nonstandard prefix so pkg-config can find them."
09:45:55 <flo-retina> pirosb3: you still have that ac_add_options --enable-calendar line
09:46:22 <flo-retina> also, which version of which repository are you using?
09:47:34 <pirosb3> mozilla-central
09:47:50 <flo-retina> have you cloned comm-central?
09:48:45 <pirosb3> Oh okay sorry. Do I need both? or only comm-central?
09:49:25 <flo-retina> isn't this all explained on the wiki page?
09:52:06 <shashika> wiki page clearly mentioned it
09:53:16 <pirosb3> Yes it does, I followed too much the guide on setting up firefox
09:53:18 <flo-retina> I've got to go, but I'm sure others here will be happy to help you.
09:53:28 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:53:45 <pirosb3> ok thanks flo-retina
10:05:17 <Mic> pirosb3: it should all be on the wiki but here's a summary anyways:
10:06:05 <Mic> Clone c-c, then clone m-c into the folder /mozilla/ directly in your c-c repository.
10:06:48 <Mic> Make the mozconfig changes.
10:08:36 <Mic> Run the following in the root of c-c:
10:08:37 <Mic> python client.py checkout
10:08:37 <Mic> ./mozilla/mach build
10:09:59 <Mic> You can find the binary in objdir/mozilla/dist/bin/ at the end.
10:14:57 <shashika> I did some changes in the code and build it again with ./mozilla/mach build
10:15:20 <shashika> I forget the path where instantbird can run 
10:16:12 <shashika> as I remember it is in comm-central/obj-pc-linux-gnu/...........
10:16:59 --> flo-retina has joined #instantbird
10:16:59 * ChanServ sets mode +qo flo-retina flo-retina 
10:18:16 <pirosb3> oh thanks Mic
10:18:46 <pirosb3> I am progressing finally ahah
10:19:08 <Mic> shashika: objdir/mozilla/dist/bin
10:21:18 <shashika> Mic : Got it :)
10:22:01 <-- shrihari has quit (Ping timeout)
10:23:21 <-- GeKo has quit (Ping timeout)
10:29:11 <shashika> I'm using intellij idea
10:29:36 <shashika> upto now I separately open files in /im directory
10:29:55 <shashika> are there a way to open whole project at one
10:30:00 <shashika> *once
10:32:18 <-- pirosb3 has quit (Quit: CGI:IRC (Ping timeout))
10:35:21 --> shrihari has joined #instantbird
10:38:48 <-- BWMerlin has quit (Ping timeout)
10:42:22 <Mic> shashika: no idea, I'm not familiar with this IDE.
10:43:16 <-- gerard-majax__ has quit (Ping timeout)
10:44:23 <-- Mic has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:58:43 --> GeKo has joined #instantbird
11:04:12 --> pirosb3 has joined #instantbird
11:04:51 <pirosb3> hey guys
11:05:05 <pirosb3> I am getting other build errors again
11:05:24 <pirosb3> OSError: [Errno 2] No such file or directory: '/Users/danielpiros/Documents/Projects/comm-central/mozilla/obj-ff-dbg'
11:05:36 <pirosb3> I know obj- is the prefix for built files
11:05:41 --> rosonline has joined #instantbird
11:06:11 <pirosb3> Is there something I need to build before that?
11:06:15 <-- pirosb3 has quit (Quit: CGI:IRC (EOF))
11:07:13 --> pirosb3 has joined #instantbird
11:08:21 <flo-retina> pirosb3: use an absolute path of the OBJDIR in the mozconfig
11:09:42 <pirosb3> ok
11:11:42 --> Mic has joined #instantbird
11:11:42 * ChanServ sets mode +h Mic 
11:20:26 --> gerard-majax__ has joined #instantbird
11:22:29 --> danielpiros has joined #instantbird
11:24:24 <-- pirosb3 has quit (Quit: CGI:IRC)
11:35:02 <clokep> Mic: Obsolete the old patch and r+ the new one is what I like.
11:35:53 <Mic> clokep: thanks, that's the same advice that flo gave me too :)
11:37:15 <Mic> Looks like we might get a new peak: http://ftp.instantbird.com/instantbird/stats/
11:37:59 <flo-retina> thanks to the recent press?
11:38:36 <clokep> flo-retina: I have some people which are super duplicated too. :-\
11:38:54 <flo-retina> clokep: is people duplication worse than code duplication? :)
11:39:33 <clokep> Mic: I find http://ftp.instantbird.com/instantbird/stats/last2years.php easier to look at btw. :)
11:39:42 <clokep> flo-retina: Some of the people I don't like very much. ;)
11:40:30 <Mic> clokep: that's the link I was looking for. It's not on the wiki yet.
11:41:06 <clokep> awesomebar to the rescue!
11:42:38 * flo-retina was looking for the same thing, and the awesomebar didn't help. I _typed_ the last part :-]
11:43:13 <Mic> It's on the wiki now.
11:44:19 <clokep> :)
11:44:20 <flo-retina> great, I'll just need to type the wiki URL instead :-D
11:44:48 <flo-retina> errr, the reason why it wasn't on my awesomebar was that I was trying on the wrong Firefox profile :-]
11:44:50 <flo-retina> (makes more sense)
11:53:25 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
11:55:03 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:59:14 --> BWMerlin has joined #instantbird
12:10:09 <-- shashika has quit (Quit: http://www.mibbit.com ajax IRC Client)
12:27:36 --> hadi has joined #instantbird
12:32:44 --> aleth has joined #instantbird
12:32:45 * ChanServ sets mode +h aleth 
12:41:11 <aleth> Mic: The participant context menu can easily be extended with protocol-specific stuff.
12:44:33 * aleth lols at "not working" as a bug description
12:46:16 --> Mic has joined #instantbird
12:46:16 * ChanServ sets mode +h Mic 
12:47:53 <aleth> Mic: Are you working on showing twitter timelines from other users?
12:48:28 <Mic> aleth: no
12:48:54 <Mic> I still have that WIP for showing tweets containing keywords in their own tabs
12:49:10 <aleth> Oh yeah! That was a good idea.
12:49:11 <Mic> I wanted to lookat that after fixing bio 1511
12:49:35 <-- BWMerlin has quit (Quit: BWMerlin)
12:49:49 * aleth has forgotten bio numbers and can't remember bmo numbers ;)
12:49:52 --> clokep_work has joined #instantbird
12:49:52 * ChanServ sets mode +o clokep_work 
12:50:51 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:50:53 --> clokep_work has joined #instantbird
12:50:53 * ChanServ sets mode +o clokep_work 
12:51:32 <clokep_work> flo-retina: Yes, you're right. But I meant for things like the about window, that could totally be an overlay.
12:51:34 <aleth> Mic: You also had that duplicate account check bug that was almost finished
12:51:44 <Mic> That's bio 1511 ;)
12:51:48 <aleth> :D
12:53:19 <aleth> Something very broken is going on around imContacts :-/
12:56:28 <danielpiros> Hey guys
12:56:36 <danielpiros> progress on the build! it finished
12:56:44 <danielpiros> We know it took a while, but your build finally finished successfully!
12:56:44 <danielpiros> To view resource usage of the build, run |mach resource-usage|.
12:56:45 <danielpiros> Error running mach:
12:56:46 <danielpiros>     ['build']
12:56:57 <aleth> danielpiros: Great :)
12:57:28 <danielpiros> I read the documentation, and it says that if the build does not find the executable, it is because the files reside in objdir/mozilla/dist
12:57:28 --> deOmega has joined #instantbird
12:57:35 <danielpiros> unfortunately, that dir does not exist
12:57:56 <aleth> For objdir, you have to substitute your actual object directory name ;)
12:58:11 <aleth> If you haven't set it by hand, its name starts with obj...
12:59:41 <danielpiros> oh ok
12:59:44 <danielpiros> I'll have a look
12:59:48 <danielpiros> thanks aleth
12:59:57 <danielpiros> I'll be back soon guys, thanks for your help
13:00:20 <-- danielpiros has quit (Quit: danielpiros)
13:04:18 <aleth> Any news on when ccrework is going to land?
13:11:26 <clokep_work> aleth: Watch m.d.planning for an announcement.
13:13:02 <aleth> Thx
13:22:00 <Mic> aleth: a lot of our bugs start with 954...
13:26:22 * aleth doesn't understand why his patch isn't working :-/
13:29:28 <aleth> If in doubt, rebuild...
13:32:15 <aleth> I'm beginning to think something is broken around localeCompare, and that seems really strange.
13:41:07 <-- Even has quit (Ping timeout)
13:43:52 <flo-retina> clokep_work: has the announcement been sent yet?
14:18:19 <clokep_work> flo-retina: No.
14:18:22 <clokep_work> Not that I know of.
14:18:25 <clokep_work> jcranmer was talking about it yesterday.
14:18:42 <-- hadi has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
14:19:41 <flo-retina> ok
14:19:47 <flo-retina> was just wondering if I missed something
14:28:21 <aleth> Sometimes mach build doesn't seem to pick up all the changes :-S
14:29:05 --> mconley has joined #instantbird
14:46:55 --> danielpiros has joined #instantbird
14:51:38 --> chrisccoulson_ has joined #instantbird
14:52:37 <-- chrisccoulson has quit (Ping timeout)
14:55:04 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
14:55:17 --> mayanktg has joined #instantbird
14:55:57 <mayanktg> Hi! sorry my mid-term exams are going on 
14:57:28 <mayanktg> I need a help .. how can I create a second frame inside the panel ("take image" panel-2 should appear when I click on the take image button in panel-1)??
14:58:59 <aleth> mayanktg: Try a deck
14:59:20 <aleth> https://developer.mozilla.org/en-US/docs/XUL/deck
14:59:31 <aleth> (if I understand correctly what you are trying to do)
15:00:09 <mayanktg> aleth: thanks. I guess it is what I need :)
15:00:50 <aleth> Either that or use JS to construct what's inside the panel at runtime.
15:01:40 <danielpiros> @aleth unfortunately I still cannot find the executable
15:01:49 --> shashika has joined #instantbird
15:01:57 <danielpiros> I set my MOZ_OBJDIR
15:02:04 <mayanktg> I'm trying by using deck, if that doesn't help I will use JS
15:02:17 <danielpiros> but under that folder, I cannot find anything relevant to build
15:02:33 <danielpiros> there is an empty dist folder, although the build says it was completed successfully
15:03:24 <aleth> danielpiros: Did you set your OBJDIR to an absolute path?
15:03:34 <danielpiros> yep
15:03:36 <danielpiros> :(
15:03:50 <aleth> Can you pastebin a listing of what it contains?
15:04:04 <aleth> And pastebin your mozconfig
15:05:26 <danielpiros> Oh wow, I found the folder now
15:05:33 <danielpiros> it was nested in /mozilla
15:05:40 <danielpiros> sorry about that aleth 
15:06:12 <aleth> Yes, that's where it is expected to be :)
15:06:29 <danielpiros> :)
15:08:02 <clokep_work> Mook_as: Thanks for the comment. I don't think it made ccrework harder...at least not for us.
15:08:06 <clokep_work> ;)
15:11:41 --> iamjayakumars has joined #instantbird
15:13:39 <danielpiros> aleth: is it possible to run all tests at once?
15:13:54 <clokep_work> Yes...how, I don't remember. :)
15:17:02 <instantbot> ryanvm@gmail.com changed the Resolution on bug 954871 from --- to FIXED.
15:17:04 <instantbot> ryanvm@gmail.com changed the Resolution on bug 954324 from --- to FIXED.
15:17:05 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=954871 min, --, ---, nobody, RESO FIXED, Remove Welcome screen from Account wizard
15:17:06 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=954324 tri, --, ---, gfxindia, ASSI, Add-ons window doesn't close on Cmd+W
15:17:13 <instantbot> ryanvm@gmail.com changed the Resolution on bug 954216 from --- to FIXED.
15:17:14 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=954216 nor, --, ---, nobody, NEW, Add a context menu to the user icon to set and remove it
15:18:12 <flo-retina> aleth, clokep_work: you may want to have a look at the log of #maildev ;)
15:18:39 <flo-retina> we'll need to clarify our module ownership story for the im/ folder now that sheriffs are doing checkins for us.
15:19:39 <clokep_work> flo-retina: OK! Sounds reasonable. I'd also like to clarify target milestone for "Chat Core".
15:19:50 <clokep_work> (I'm willing to change any milestones of bugs if need be...)
15:20:14 <flo-retina> clokep_work: so basically, the question we need to answer is: who's allowed to r+ in im/ ?
15:20:19 <flo-retina> (or sub parts of im/)
15:27:15 <clokep_work> flo-retina: I agree. You and I can r+ in it. ;)
15:27:29 <flo-retina> that's what the wiki page says
15:27:37 <flo-retina> but I think aleth and Mic have r+'ed plenty of pathces
15:27:42 <flo-retina> and nhnt11 just r+'ed one ;)
15:28:19 <clokep_work> flo-retina: Are you adding a separate IM module?
15:28:41 <flo-retina> clokep_work: is it useful?
15:28:47 <flo-retina> clokep_work: I think we only need it if the peers are different
15:28:48 <clokep_work> I doubt it. :)
15:28:53 <-- shrihari has quit (Ping timeout)
15:31:19 <-- chrisccoulson_ has quit (Client exited)
15:33:55 <danielpiros> Hey guys, I see this bug has not been assigned to anyone. Do you think I can take it? https://bugzilla.mozilla.org/show_bug.cgi?id=953873
15:33:57 <instantbot> Bug 953873 enh, --, ---, nobody, NEW, XMPP: detect if user-id contains domain
15:36:49 <flo-retina> I'm not sure that bug still applies to JS-XMPP
15:38:29 <-- flo-retina has quit (Ping timeout)
15:40:58 <danielpiros> ok
15:41:10 <danielpiros> do you have any starter bug you would suggest me?
15:41:41 <danielpiros> also, what are the best practices for debugging/developing on instantbird? I could not find anything on this
15:45:54 --> zen_monkey has joined #instantbird
15:47:42 <clokep_work> danielpiros: I can look through a few in a second...
15:47:55 <danielpiros> cheers
15:49:07 <-- aleth has quit (Quit: exit stage left)
15:50:00 <clokep_work> danielpiros: What kind of stuff are you interested in? UI? Backend type things?
15:50:20 <clokep_work> danielpiros: Are you the one who said they like tests? :P
15:50:26 <danielpiros> ahah
15:50:30 <danielpiros> yes I am that guy
15:50:41 <danielpiros> clokep_work: I am mainly backend type of guy
15:50:58 <danielpiros> I would like to be working on the WebRTC file transfer task
15:51:00 <danielpiros> for SoC
15:51:13 <danielpiros> so anything that could be relevant for that could give me a head start :)
15:51:14 <clokep_work> danielpiros: So bug 817596 has a couple of patches on it but DESPERATELY calls for tests.
15:51:16 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=817596 nor, --, ---, clokep, ASSI, Unable to parse nonce values from "jabber.ubuntu-fr.org"
15:51:21 --> chrisccoulson has joined #instantbird
15:51:27 <clokep_work> Maybe writing the tests and ensuring one of those patches works could be a good place to start?
15:51:32 <clokep_work> ( / fixing the patches if they don't :-D)
15:51:33 <danielpiros> great, let me see
15:51:47 <danielpiros> clokep_work: you said there is no docs on tests right? :)
15:52:02 <clokep_work> danielpiros: What about tests? Running them? Writing them?
15:52:08 <danielpiros> both
15:52:11 <clokep_work> GEnerally its just the documentation on wiki.mozilla.org.
15:52:18 <-- mayanktg has quit (Quit: http://www.mibbit.com ajax IRC Client)
15:52:19 <danielpiros> running them: for now I am just running them from the bin folder
15:52:33 <danielpiros> ok
15:52:44 <danielpiros> also, a instantbird-specific question
15:52:53 <danielpiros> how do you develop/debug?
15:53:08 <danielpiros> how do I avoid recompiling everything? does the tool only recompile what I have changed?
15:53:20 <clokep_work> mach is supposed to only recompile what has changed, yes.
15:53:32 <clokep_work> I generally recompile im/ or chat/ when I change things (Directly, using make)
15:53:39 <clokep_work> flo might know of a "better" way to do that.
15:53:55 <clokep_work> Debugging...I tend to use print statements and such, but we should be able to use the remote debugger now that we're in c-c.
15:54:00 <clokep_work> I don't know if that's hooked up or what.
15:54:48 --> aleth has joined #instantbird
15:54:49 * ChanServ sets mode +h aleth 
15:55:52 <danielpiros> ok thanks!
15:56:39 <clokep_work> Idk if that actually answered your question or not. ;)
15:58:15 <-- iamjayakumars has quit (Client exited)
15:59:19 <aleth> The remote debugger "should" work just like it does for TB, but if anyone actually tries and succeeds, putting instructions on our wiki would be a helpful thing to do ;)
16:00:34 --> flo-retina has joined #instantbird
16:00:35 * ChanServ sets mode +qo flo-retina flo-retina 
16:02:14 --> shrihari has joined #instantbird
16:14:08 --> iamjayakumars has joined #instantbird
16:14:29 <shrihari> Who are "sheriffs"?
16:16:32 <aleth> shrihari: https://wiki.mozilla.org/Sheriff_Duty
16:18:04 <aleth> actually, this is probably better https://wiki.mozilla.org/Sheriffing
16:19:14 <shrihari> That's interesting :) Didn't know about this.
16:19:37 <clokep_work> aleth: Why do you manually call getChatRoomDefaultFieldValues?
16:21:00 <aleth> clokep_work: I did not change that aspect of the existing code
16:21:51 <clokep_work> Ah, you just didn't inline it.
16:21:53 <clokep_work> Sorry.
16:22:18 <aleth> Line length ;)
16:30:55 <clokep_work> Yeah yaeh
16:31:18 <aleth> Haha, comments...
16:31:26 <clokep_work> ;)
16:31:37 <clokep_work> I'm concerned about joinChat not matching the interface btw.
16:31:44 <clokep_work> Idk what flo-retina's thought on that is...
16:32:14 <aleth> clokep_work: It's not a problem in this case. I wouldn't mind adding it to the interface though I'm not sure it would be trivial for libpurple.
16:32:33 <clokep_work> aleth: What did we recently update that for? createConversation?
16:32:40 <aleth> "that"=?
16:33:09 <clokep_work> aleth: Returning a conversation...
16:33:13 <clokep_work> We did that SOMEWHERE
16:33:14 <clokep_work> REcently...
16:33:34 <aleth> iirc I proposed it and we decided against
16:33:57 <clokep_work> Maybe that's what I'm thinking of.
16:33:58 <aleth> clokep_work: Ah: https://bugzilla.mozilla.org/show_bug.cgi?id=955680#c4
16:34:00 <instantbot> Bug 955680 nor, --, 1.5, aleth, RESO FIXED, Only remember on-hold state for autojoined conversations
16:34:43 <aleth> clokep_work: For this bug, as I'm only using the return value within irc, it's OK as is.
16:35:04 <clokep_work> aleth: If we returned it...couldn't we focus it outside the join conversation call?
16:35:04 <aleth> ymmv of course.
16:35:26 <aleth> I don't understand.
16:35:34 <aleth> Commands return true or false.
16:37:45 <aleth> Returning it (in the interface) would simplify the code around the /other/ methods we have to call joinChat.
16:38:50 <clokep_work> Maybe you misunderstood...
16:39:02 <clokep_work> Oh, no. I see what you're esaying.
16:39:10 <clokep_work> We're calling joinChat inside of our command.
16:39:21 <clokep_work> So unless there was some other API we called which called joinChat...
16:39:25 <clokep_work> Yeah, OK. got it.
16:39:25 <aleth> It would help for the awesometab and that awful join chatdialog.
16:39:51 <clokep_work> Yeah...did Mic find some crayz bug too where if you try to join a bunch of stuff at once weird things happen?
16:40:03 <aleth> I dont remember that one?
16:40:33 <clokep_work> aleth: Using the Join Chat Dialogue, join #foo,#bar.
16:41:00 <aleth> That sounds like something I am surprised works at all :D
16:41:30 <aleth> Do we even have code that parses that?
16:42:26 <aleth> Doesn't look like it.
16:42:58 <aleth> So I guess that happens is that IRC sends "JOIN #foo,#bar" and strangeness results ;)
16:47:53 <clokep_work> Yes, that's exactly what happens.
16:53:54 <-- aleth has quit (Ping timeout)
16:54:14 --> aleth has joined #instantbird
16:54:14 * ChanServ sets mode +h aleth 
16:56:32 <-- iamjayakumars has quit (Quit: )
16:59:11 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
17:02:28 --> wnayes has joined #instantbird
17:03:11 <clokep_work> Can someone make the arrows glow when I have a message in a tab that's off screen that's unread? :(
17:04:57 <aleth> Yes please :)
17:05:03 <aleth> Didn't Mic have a patch for that?
17:05:31 <clokep_work> I don't know...
17:05:41 <clokep_work> I still think we can do better things than making the title change color btw...
17:09:37 <-- shrihari has quit (Ping timeout)
17:14:55 * aleth had a WIP that coloured the background instead
17:15:11 <aleth> Maybe I should dig it out, but I dread the colour bikeshedding that will result.
17:33:41 <clokep_work> Yeah, I was playing w/ that too.
17:40:00 --> shrihari has joined #instantbird
17:40:06 <-- gerard-majax__ has quit (Ping timeout)
17:40:35 <-- Mook_as has quit (Quit: Mook_as)
17:41:04 --> Mook_as has joined #instantbird
17:52:22 <shrihari> Would it be the right time to start working on my GSoC proposal?
17:56:22 <clokep_work> shrihari: That's up to you and how much time and effort you expect it to take. ;) I don't think that's really a question we can answer.
17:57:51 <shrihari> clokep_work: Right :-)
17:58:40 <shrihari> But, who would be my mentor? The project being "Single Window UI".
17:58:50 <Mook_as> <3
17:58:52 <aleth> flo-retina: I agree about the Interruption manager, but what's so terrible about a notification? The UI can decide to ignore it.
17:59:05 <flo-retina> apparently Mook is volunteering to mentor
17:59:14 <flo-retina> aleth: no, the UI can't decide
17:59:32 <flo-retina> aleth: it has no way to know if that's a genuine notification or a crazy prpl sending broken notifications
17:59:36 <Mook_as> haha, no, not if you want the poor student to actually get any help
18:00:16 <flo-retina> aleth: that's similar to the libpurple prpl throwing modal dialog at the user. There's no problem because the people writing prpls are responsible, right? Except bugs happen.
18:00:54 <shrihari> Haha :D
18:01:44 <clokep_work> aleth: Can you name your patches differently? Makes it easier to diff across them in BZ.
18:01:47 <aleth> flo-retina: It's a little bit different, but OK, I take your point. A return value can't be repeated.
18:01:49 <clokep_work> (I.e. put a version on each.)
18:02:00 <aleth> clokep_work: There is a version? (in the description)
18:02:27 <clokep_work> Not on the first three patches. ;)
18:02:28 <flo-retina> aleth: and I'm really sorry for that r- (I see you asked a question that could have received this answer a long time ago in the comments :()
18:04:23 <aleth> np (the original patch there really was just stuck because of async issues that no longer exist, so not very motivating to look at...)
18:19:56 <aleth> flo-retina: Do you know what Jeff Walden's IRC nick is?
18:20:03 <flo-retina> waldo?
18:20:07 <flo-retina> why? :)
18:20:36 <flo-retina> Waldo actually (my guess was right except for the case)
18:20:57 <aleth> I think some of the strange errors we've been seeing may be caused by calling localeCompare during startup.
18:21:25 <aleth> So I was looking for someone to ask about recent changes in that area...
18:22:02 --> Rym has joined #instantbird
18:22:37 <-- shashika has quit (Quit: http://www.mibbit.com ajax IRC Client)
18:24:01 <aleth> At least I don't see anything else that could cause "Exception... "Failure"  nsresult: "0x80004005 (NS_ERROR_FAILURE)" in, eg., http://mxr.mozilla.org/comm-central/source/im/components/ibConvStatsService.js#362 :-S
18:25:22 <aleth> Weird.
18:25:49 <flo-retina> aleth: do you have the stack for that exception
18:25:51 <flo-retina> ?
18:25:55 <aleth> No
18:26:05 <flo-retina> are you able to reliably reproduce it?
18:26:20 <aleth> No
18:26:25 <flo-retina> :-/
18:26:33 <aleth> None of these strange issues we've been seeing seem to be reliable.
18:26:44 <Mook_as> sounds like you want to talk to the ICU people?
18:26:45 <aleth> Hence my suspicion there is a race condition involved
18:26:56 <Mook_as> (I have no idea if that's Waldo)
18:26:58 <-- shrihari has quit (Ping timeout)
18:27:39 <aleth> But sometimes we get NS_ERROR_FAILURE in Tags.sort, and there too localeCompare is involved.
18:29:20 <flo-retina> aleth: would be nice to see if a debug build logs anything interesting to the terminal (any new assertions, etc...)
18:35:21 --> gerard-majax__ has joined #instantbird
18:36:16 <aleth> Hmm maybe this needs porting https://hg.mozilla.org/mozilla-central/rev/b6dc96f18391
18:37:08 <aleth> flo-retina ^^
18:38:25 <flo-retina> what is it doing?
18:38:36 <flo-retina> (not obvious to me with a quick look at the diff
18:38:38 <flo-retina> )
18:41:10 <aleth> It's not entirely clear to me what was and wasn't built at which stage, and to what extent localeCompare in m-c now relies on the Internationalization API
18:41:40 <aleth> (which was pref'd on for fx29)
18:53:05 <-- deOmega has quit (Quit: So easy...but yet complicated.)
18:53:14 --> deOmega has joined #instantbird
18:53:22 <-- deOmega has quit (Connection reset by peer)
18:54:00 --> deOmega has joined #instantbird
18:56:48 --> shrihari has joined #instantbird
18:58:31 <danielpiros> hey guys. I am currently developing on instantbird. If I do a change to the JS, do I need to recompile? does the JS get compiled in the build? if not, what is the best way to build without having to recompile everything?  
18:59:36 <danielpiros> clokep_work: with regards to the MD5 nonce issue: do you have an example of some of the nonces that were failing? thanks 
19:00:25 <clokep_work> danielpiros: Isn't there some in the bug?
19:00:45 <clokep_work> danielpiros: If not...then...no, not right now. :)
19:01:04 <danielpiros> there are only 3
19:01:10 <aleth> danielpiros: You need to recompile if the js file in the objdir isn't a symlink.
19:01:11 <danielpiros> I just want to assert more cases
19:01:23 <danielpiros> ok thanks
19:01:27 <clokep_work> danielpiros: Start with those three. ;)
19:01:35 <danielpiros> sure
19:01:35 <aleth> danielpiros: Usually it's symlinked if there is no preprocessing required.
19:01:43 <clokep_work> danielpiros: And make up more based on what the RFC says is allowed / not allowed?
19:01:50 <danielpiros> ok
19:04:05 --> shrihari_ has joined #instantbird
19:04:50 <-- shrihari_ has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:08:36 --> shrihari_ has joined #instantbird
19:09:39 --> Mic has joined #instantbird
19:09:39 * ChanServ sets mode +h Mic 
19:12:57 <nhnt11> flo-retina, clokep_work: So now that I have commit access, could I have (for example) checked in shrihar i's patch after it was r+?
19:13:14 <flo-retina> yes
19:14:03 <nhnt11> cool. should I be following any kind of protocol when I check stuff in? (informing you guys, blabla)
19:14:21 <flo-retina> nhnt11: you can generally checkin your own patches, the patches you reviewed (if you have reasonable reasons to assume the person doesn't have commit access), and the patches where the author asked you to do it
19:14:58 <nhnt11> Alright!
19:15:04 <flo-retina> (or sometimes some patch you really care about that has the relevant r+ and is just waiting for someone to check it in. Happens rarely, but if the assignee of a bug has moved on, and the review arrives months later...)
19:16:10 <flo-retina> nhnt11: the first time you'll likely want clokep or me to be around "just in case" (as voucher we signed up to fix the mess if you break the tree and run away ;)), but generally, no, you can just check it in and paste the changeset url in the bug
19:16:35 <nhnt11> Cool.
19:18:41 <-- shrihari_ has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:19:17 --> shrihari_ has joined #instantbird
19:21:33 <-- shrihari_ has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:21:34 * flo-retina doesn't feel motivated to look at the Linux build failure :(
19:22:06 * nhnt11 wishes he had the competence to debug buildbot issues
19:22:34 <clokep_work> nhnt11: Generally if it's something you're totally 100% about it's OK.
19:22:47 <clokep_work> But if you want someone else to look over it first...obviously you'd have to wait. :)
19:22:56 <nhnt11> right
19:23:17 <flo-retina> nhnt11: well, nobody knows how to fix the buildbot crap... until one knows that nobody else will do it ;).
19:23:42 <danielpiros> hey guys, does anyone know how to run the JS tests?
19:24:04 <danielpiros> I tried looking but found no information. I can run the compiled tests fine, but not the JS tests
19:24:22 <flo-retina> which test are you trying to run?
19:24:24 --> shrihari_ has joined #instantbird
19:24:29 <clokep_work> xpcshell tests?
19:24:34 <-- shrihari_ has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:24:56 <danielpiros> yes
19:25:05 <danielpiros> a unit test I made just now
19:26:51 <clokep_work> DId you add it to the manifest?
19:27:07 <danielpiros> yes
19:27:20 <danielpiros> I can find documentation on how to run firefox tests
19:27:30 <danielpiros> but not generic to c-c
19:27:47 <danielpiros> how do you do it?
19:27:58 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
19:28:13 <danielpiros> I also tried "make xpcshell-tests"
19:28:16 <clokep_work> danielpiros: https://developer.mozilla.org/en-US/docs/MailNews_xpcshell-tests#Workaround_for_mach_problems
19:28:29 <clokep_work> That page is insanely hidden...
19:28:57 <clokep_work> make -C objdir xpcshell-tests TEST_PATH=path/to/test
19:29:53 <danielpiros> amazing
19:30:09 <danielpiros> thanks guys, sorry for the lame questions
19:30:10 <flo-retina> clokep_work:  doesnt |make -C objdir xpcshell-tests| just work?
19:30:27 <flo-retina> ah, you wanted a specific test
19:30:29 <flo-retina> ignore me :)
19:30:29 <clokep_work> flo-retina: I don't know.
19:30:35 <clokep_work> I assume he wasn't doing -C objdir. :)
19:31:31 <danielpiros> i wasn't
19:31:51 --> chrisccoulson has joined #instantbird
19:31:58 <danielpiros> I was looking for the makefile elsewhere
19:33:17 <danielpiros> Ok, dinner time. Hear you later :)
19:34:04 <shrihari> Where do I find "chrome://global/content/bindings/toolbar.xml#toolbar" ?
19:34:46 <aleth> shrihari: It's https://developer.mozilla.org/en-US/docs/XUL/toolbar
19:35:02 <-- danielpiros has quit (Quit: danielpiros)
19:35:08 <Mook_as> shrihari: http://mxr.mozilla.org/comm-central/find?string=toolbar.xml&tree=comm-central&hint= is a good way to find it in the future
19:35:42 <aleth> shrihari: Oh, if you were looking for the actual code, http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/widgets/toolbar.xml
19:36:44 <shrihari> Thanks you. That's what I was looking for. The file associated with the URL
19:39:43 <shrihari> http://mxr.mozilla.org/comm-central/source/im/content/conversation.xml#1969
19:40:01 <shrihari> Can someone explain how this is being rendered the way it is?
19:40:19 <aleth> This defines a new XBL binding that extends the toolbar binding.
19:40:40 <shrihari> Yes.
19:41:09 <aleth> So if you understand how that works, what's your question>
19:41:15 <shrihari> Why are `statusImageStack` and `displayNameAndstatusMessageStack` not children of a hbox?
19:41:45 <aleth> Why would that be needed?
19:42:17 <Mook_as> shrihari: they're children of the <content>, which means basically "whatever element that was replaced by this XBL binding"
19:43:18 <shrihari> Mook_as: Yes, I got that.
19:43:21 <aleth> The content gets inserted into the DOM when a conv-info-large element is added.
19:43:36 <shrihari> Yes. Understood that.
19:44:11 <Mic> shrihari: do you wonder why they're automatically layed out horizontally without a hbox needed?
19:44:27 <shrihari> Mic: Yes
19:44:35 <Mic> I don't know.
19:45:31 --> shrihari_ has joined #instantbird
19:47:14 <shrihari> Could it be because it extends `toolbar`?
19:47:38 <-- shrihari_ has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:48:22 <-- aleth has quit (Ping timeout)
19:48:46 <shrihari> That leads to my next question - Why does it extend `toolbar`?
19:49:06 <Mic> https://developer.mozilla.org/en-US/docs/Web/CSS/box-orient
19:49:19 --> shrihari_ has joined #instantbird
19:49:27 <-- shrihari_ has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:49:56 <Mic> horizontal seems to be the default value for that. I suspect that's part of the answer.
19:50:56 <shrihari> Hmm yes. Could be..
19:51:33 --> shrihari_ has joined #instantbird
19:54:00 <Mic> Not to myself: setting "-moz-box-orient: vertical" on the toolbar isn't the best idea :D
19:54:05 <Mic> *Note
19:54:36 <shrihari> Haha :D
19:56:40 <-- shrihari_ has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:58:16 --> shrihari_ has joined #instantbird
19:58:45 <-- shrihari_ has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:02:44 --> shrihari_ has joined #instantbird
20:05:43 <-- shrihari_ has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:08:00 <-- Mic has quit (Ping timeout)
20:08:16 --> EionRobb has joined #instantbird
20:17:42 <-- Rym has quit (Ping timeout)
20:19:17 --> Rym has joined #instantbird
20:30:03 <shrihari> Expanding status message on hover seems more complicated than I thought.
20:38:14 <-- zen_monkey has quit (Ping timeout)
21:03:16 <-- deOmega has quit (Quit: So easy...but yet complicated.)
21:05:58 <clokep_work> shrihari: Those are the best types of fies.
21:06:46 <shrihari> What are fies?
21:06:59 <clokep_work> shrihari: bugs
21:07:03 <clokep_work> No idea how i typed that...
21:08:08 <shrihari> :D
21:09:34 <-- GeekShadow has quit (Client exited)
21:13:13 --> GeekShadow has joined #instantbird
21:13:18 --> Mic has joined #instantbird
21:13:18 * ChanServ sets mode +h Mic 
21:20:29 <clokep_work> What!? No new checkins today? Come on...
21:20:47 <flo-retina> clokep_work: tree's busted!
21:20:52 <flo-retina> (linux)
21:21:01 <clokep_work> People use that toy OS still? ;)
21:21:17 <flo-retina> don't get me started about CentOS5
21:21:19 <flo-retina> ;)
21:23:27 <clokep_work> :P Does that match what they use at Moz btw?
21:23:35 <clokep_work> Fix 64-bit builds too? :P
21:24:22 <flo-retina> that matches what SeaMonkey still uses
21:24:28 <flo-retina> MoCo has moved on to CentOS6
21:24:36 <flo-retina> which is significantly less outdated
21:24:47 <clokep_work> But still outdated? ;)
21:24:54 <flo-retina> yes, purposefully so.
21:25:22 <flo-retina> on Linux we are always trying to build on as old a system as we can, because builds are forward compatible, but not backward compatible.
21:26:28 <flo-retina> and yes, that's a PITA. But the alternative is to provide a build for each version of distribution...
21:26:54 <clokep_work> Yeah, I understand.
21:30:31 <clokep_work> Someone should check this out w/ Instantbird: https://developer.mozilla.org/en-US/docs/Tools/Remote_Debugging/Thunderbird
21:30:39 <clokep_work> (Obviously we'd have to add that to the Tools menu...)
21:38:19 <-- shrihari has quit (Ping timeout)
22:13:54 <-- Mic has quit (Ping timeout)
22:15:16 --> Mic has joined #instantbird
22:15:16 * ChanServ sets mode +h Mic 
22:19:42 <-- Rym has quit (Ping timeout)
22:20:32 <-- clokep_work has quit (Ping timeout)
22:21:14 --> Rym has joined #instantbird
22:25:52 --> clokep_work has joined #instantbird
22:25:52 * ChanServ sets mode +o clokep_work 
22:37:13 <flo-retina> ah, bug 975639 has finally reached its MemShrink:P2 final destination :-D
22:37:17 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=975639 nor, --, ---, nobody, NEW, compartments for JS components stay around forever
22:47:55 <-- GeKo has quit (Ping timeout)
22:52:22 --> He_Dom has joined #instantbird
23:07:33 <-- Suiseiseki has quit (Ping timeout)
23:09:05 --> Suiseiseki has joined #instantbird
23:13:31 <-- He_Dom has quit (Quit: Occupato)
23:16:19 --> GeKo has joined #instantbird
23:23:37 <clokep_work> flo-retina: That's bad, right? ;)
23:39:54 <-- nathanr has quit (Ping timeout)
23:45:09 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
23:45:21 --> deOmega has joined #instantbird
23:47:10 <-- mconley has quit (Input/output error)
23:51:33 --> nathanr has joined #instantbird
23:52:13 <-- deOmega has quit (Quit: So easy...but yet complicated.)