All times are UTC.
00:16:28 <-- Mook_as has quit (Ping timeout) 00:16:54 --> Mook_as has joined #instantbird 00:24:33 --> mconley has joined #instantbird 00:28:51 --> Mic has joined #instantbird 00:29:17 <Mic> Thanks for fixing the build problem on Linux, flo! :) 00:29:24 <Mic> It worked fine now :) 00:30:06 <-- Mic has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 02:15:29 --> mayanktg has joined #instantbird 02:20:21 <-- Mook_as has quit (Quit: Mook_as) 02:40:58 --> clokep has joined #instantbird 02:40:58 * ChanServ sets mode +o clokep 02:43:55 <clokep> flo-retina: You know I made that extension for IRC, right? 02:44:08 <clokep> https://addons.instantbird.org/en-US/instantbird/addon/357/ 02:44:25 <clokep> I assume you want it for other protocols, but just figured I'd share. ;) 02:55:46 <-- dewtwo has quit (Ping timeout) 03:00:00 --> dewtwo has joined #instantbird 03:01:55 <-- mconley has quit (Input/output error) 03:04:02 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 03:14:20 <-- mayanktg has quit (Quit: http://www.mibbit.com ajax IRC Client) 03:29:03 --> Mook has joined #instantbird 03:32:19 --> mconley has joined #instantbird 03:38:24 <-- mconley has quit (Ping timeout) 03:38:59 <-- EionRobb has quit (Quit: Leaving.) 04:01:16 --> mconley has joined #instantbird 04:52:14 <-- mconley has quit (Input/output error) 05:27:23 <-- wnayes has quit (Quit: wnayes) 06:13:40 <-- Mook has quit (Quit: Mook) 07:23:44 --> mconley has joined #instantbird 07:28:59 <-- mconley has quit (Ping timeout) 07:44:40 <instant-buildbot> build #1269 of win32-nightly-default is complete: Failure [4failed shell_3] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1269 07:45:08 --> GeKo has joined #instantbird 07:47:14 --> EionRobb has joined #instantbird 07:55:39 <instant-buildbot> build #2024 of macosx-nightly-default is complete: Failure [4failed shell_3] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2024 08:09:46 --> mayanktg has joined #instantbird 08:25:06 --> jb has joined #instantbird 08:25:18 <-- nhnt11 has quit (Ping timeout) 08:27:12 --> nhnt11 has joined #instantbird 08:40:28 --> nhnt11-phone has joined #instantbird 08:41:52 <-- nhnt11-phone has quit (Input/output error) 08:41:58 --> nhnt11-phone has joined #instantbird 08:42:05 <-- nhnt11-phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com )) 08:54:06 <-- nhnt11 has quit (Ping timeout) 08:56:53 --> Mic has joined #instantbird 09:00:18 <Mic> mayanktg: I've got a solution for your onclick problem. 09:00:54 <Mic> I've posted it in the bug. 09:01:52 <Mic> At least I think it is. I haven't actually tried it. 09:02:37 <Mic> flo-retina, clokep: I've lost my half-op rights when my nickname expired. Would you mind adding that back? 09:07:03 <-- jb has quit (Ping timeout) 09:07:16 --> nhnt11 has joined #instantbird 09:07:32 <mayanktg> mic: Ok. checking it 09:07:58 <Mic> Are you familiar with MXR already? That's a code search tool... 09:08:24 --> nhnt11-phone has joined #instantbird 09:08:37 <Mic> e.g. if you're interested what other onclick handlers do, you could query https://mxr.mozilla.org/comm-central/search?string=onclick&find=/im/ 09:08:52 <Mic> That will search the im directory for "onclick". 09:09:36 <mayanktg> mic: yes 09:09:58 <Mic> Great! :) 09:10:08 <mayanktg> I have been using it for searching :D 09:10:12 <nhnt11-phone> mayanktg: You're on mibbit? 09:10:37 <-- nhnt11 has quit (Ping timeout) 09:10:47 <nhnt11-phone> Why are you not using Instantbird, rather :P 09:11:10 <mayanktg> nhnt11-phone: Yaa..I'm having trouble with proxy settings :-/ 09:11:28 <nhnt11-phone> Ahh :( 09:12:02 <mayanktg> That's why!! The connection is never established :( 09:12:49 <nhnt11-phone> mayanktg: If you have that issue with a lot of programs, you could try setting up a transparent proxy (in which you would set parent proxy settings) 09:13:09 * nhnt11-phone used to do that... 09:14:23 <mayanktg> nhnt11-phone: Let me try that. Earlier it used to work. I'm able to connect to freenode but irc.mozilla.org is giving troubles 09:14:42 <mayanktg> Mic: it worked :) 09:14:45 <nhnt11-phone> If one network works, they all should. 09:14:54 <mayanktg> Mic: You are awesome! 09:15:42 <nhnt11-phone> Try connecting directly to concrete.mozilla.org 09:15:42 <nhnt11-phone> Haha, did Mic pull off some CSS magic? 09:17:08 <mayanktg> nhnt11-phone: No not css..but it was one :P 09:18:01 <mayanktg> nhnt11-phone: So you'd be getting a try-server!! Lucky you :) 09:18:31 <nhnt11-phone> Ny t 09:18:35 <nhnt11-phone> Typo sorry 09:19:00 <Mic> mayanktg: cool :) 09:19:55 <-- EionRobb has quit (Quit: Leaving.) 09:20:19 <Mic> Our coding style might require brackets around the body of the if block in such a case. Please compare it with other cases like that before putting it in a patch. It might save you a round of review... 09:22:11 <mayanktg> Mic: :) Ok I'll check that 09:40:44 <-- nhnt11-phone has quit (Ping timeout) 09:43:44 <mayanktg> mic: I applied the changes. 09:46:20 --> BWMerlin has joined #instantbird 10:10:01 --> jb has joined #instantbird 10:35:06 <-- Mic has quit (Ping timeout) 10:42:47 --> nhnt11 has joined #instantbird 10:43:35 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 10:43:41 --> nhnt11 has joined #instantbird 10:45:37 <nhnt11> flo-retina: Okay, so I'll be filing a bug for commit access 10:50:48 --> Mic has joined #instantbird 10:58:59 --> gerard-majax__ has joined #instantbird 11:01:08 <nhnt11> flo-retina, clokep: I've cc'd you both on the bug, but here it is anyway: https://bugzilla.mozilla.org/show_bug.cgi?id=974848 11:01:12 <instantbot> Bug 974848 nor, --, ---, mozillamarcia.knous, NEW, Commit Access (Level 3) for Nihanth Subramanya 11:06:29 <-- mayanktg has quit (Quit: http://www.mibbit.com ajax IRC Client) 11:15:49 <-- BWMerlin has quit (Ping timeout) 11:15:57 <-- dew has quit (Ping timeout) 11:17:11 --> dew has joined #instantbird 11:18:55 --> BWMerlin has joined #instantbird 11:31:56 <-- BWMerlin has quit (Ping timeout) 11:31:59 --> BWMerlin has joined #instantbird 11:33:22 --> aleth has joined #instantbird 11:33:22 * ChanServ sets mode +h aleth 11:33:35 --> clokep has joined #instantbird 11:33:35 * ChanServ sets mode +o clokep 12:00:20 <flo-retina> clokep: no I didn't know/remember. 12:00:29 <flo-retina> alexis: https://addons.instantbird.org/en-US/instantbird/addon/357/ 12:05:35 <flo-retina> Mic: done, but I think it will only be visible after you part and rejoin. 12:07:04 <aleth> Mic: I fixed the addon you reviewed ;) 12:07:29 <clokep> flo-retina: Well, there it is! :P Did I miss some conversation between you and alexis about this? :-S 12:07:57 * clokep sets mode +h Mic 12:08:56 <clokep> I didn't set it in chanserv, I'll do it later. 12:13:35 <flo-retina> clokep: was private/in French. 12:14:08 <flo-retina> clokep: I did set it in chanserv, and told me "will only be visible after you part and rejoin" :-P 12:14:17 <aleth> clokep: You might want to get that addon out of the sandbox so it is discoverable ;) 12:15:22 <clokep> aleth: Except I don't want to support it. :P 12:15:52 <aleth> Yep, keeping addons up to date is surprisingly time consuming 12:17:01 <-- clokep has quit (Ping timeout) 12:30:18 <Mic> aleth: true :( 12:31:29 --> Armada has joined #instantbird 12:33:21 <-- BWMerlin has quit (Connection reset by peer) 12:39:50 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 12:44:04 <alexis> oh wow, thanks ! 12:48:18 --> deOmega has joined #instantbird 13:01:21 <-- aleth has quit (Ping timeout) 13:01:22 --> clokep_work has joined #instantbird 13:04:35 --> aleth has joined #instantbird 13:04:35 * ChanServ sets mode +h aleth 13:05:49 <-- panther7 has quit (Quit: bye) 13:28:59 <nhnt11> clokep_work, flo-retina: Thanks for vouching! 13:29:20 <instantbot> ryanvm@gmail.com changed the Resolution on bug 974610 from --- to FIXED. 13:29:22 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=974610 nor, --, ---, nhnt11, RESO FIXED, make package doesn't work - Missing files TelemetryPing.js and dom_camera.xpt 13:32:24 --> hadi has joined #instantbird 13:35:37 <clokep_work> Thanks for porting that nhnt11. 14:15:55 <-- Tonnes has quit (Ping timeout) 14:18:25 --> Tonnes has joined #instantbird 14:22:10 <clokep_work> flo-retina: OK, so...what's the deal w/ this configure stuff? What did you do to run autoconf? 14:22:46 <flo-retina> we are not going to run autoconf 14:24:21 <flo-retina> clokep_work: the plan was to directly run m4 on the purple configure, if we find one. Much like http://mxr.mozilla.org/mozilla-central/source/configure.in#4068 does. 14:25:29 <flo-retina> so copying lines 4058-4073 of that configure.in file inside im/configure.in and fixing the path "should" work. 14:25:35 <flo-retina> Except I had bad luck with it 14:26:08 <flo-retina> and the line I had trouble with was just "if test -f ".../configure.in" ; then" ... that never worked the way I wanted (silly, isn't it? ;) 14:27:24 <aleth> What if you put the test... in square brackets [] ? 14:27:53 <aleth> (a bit of a long shot considering it doesn't appear to be needed) 14:28:54 <clokep_work> flo-retina: Interesting, OK. 14:30:41 <flo-retina> aleth: the stuff I actually had in my file is http://pastebin.instantbird.com/600787 14:31:41 <clokep_work> flo-retina: Isn't that missing a mozilla/ in those paths? 14:31:48 <flo-retina> clokep_work: actually, AC_OUTPUT_SUBDIRS is a macro that does the m4 magic for us 14:31:58 <clokep_work> if [ -d $topsrcdir/***mozilla/***extensions/purple ]; then 14:32:10 <clokep_work> Or is topsrcdir the mozilla directory? 14:32:13 <flo-retina> clokep_work: I don't think so, bit you can try 14:32:26 <flo-retina> clokep_work: I think topsrcdir is the dir with the main configure script that is being run 14:32:47 <flo-retina> and the c-c configure no longer does any real thing, it just starts the m-c configure and then parses the results 14:33:13 <aleth> I think that's why relative objdir paths go wrong. 14:33:17 <flo-retina> clokep_work: the reason for echo $topsrcdir/extensions/purple > /tmp/foopath was likely that I wanted to see what $topsrcdir was ;) 14:34:51 --> mayanktg has joined #instantbird 14:34:58 <clokep_work> flo-retina: Likely. :) Maybe I'll play with it later. 14:37:13 <aleth> The magic is finding something like AC_OUTPUT_SUBDIRS ;) 14:45:58 <flo-retina> aleth: what do you mean? 14:46:28 <aleth> I mean it's not on MDN and so you have to look through lots of other similar files until you see it 14:46:53 <flo-retina> aleth: I read http://mxr.mozilla.org/mozilla-central/source/build/autoconf/subconfigure.m4 14:47:06 <flo-retina> which is the list of stuff defined for use in subconfigures 14:47:15 <flo-retina> (ie. the list of stuff we can use in im/configure.in) 14:47:27 <flo-retina> I had to fight with this a while ago already ;) 14:47:38 <aleth> Thanks, good to know where this stuff is ;) 14:48:17 <flo-retina> basically it's just a macro calling the do_output_subdirs function 14:48:27 <flo-retina> implemented at http://mxr.mozilla.org/comm-central/source/mozilla/configure.in#4060 14:48:42 <flo-retina> the reason for using the macro is that AC_OUTPUT_SUBDIRS exists for autoconf 14:48:57 <flo-retina> do_output_subdirs is just the custom implementation that Mozilla has for subconfigures 14:57:51 --> mconley has joined #instantbird 15:02:56 <-- jb has quit (Quit: jb) 15:03:50 --> jb has joined #instantbird 15:10:04 <aleth> flo-retina: This seems to work http://pastebin.instantbird.com/600808 15:25:48 <aleth> mayanktg: Thanks for the new patch! Could you add that the "Remove" menu item gets disabled (appears greyed out) when no icon is set? 15:25:55 <aleth> Ask me if you don't know how that's done. 15:28:47 <mayanktg> aleth: I can try that 15:29:55 <aleth> You have to set/unset the disabled attribute 15:30:01 <aleth> https://developer.mozilla.org/en-US/docs/XUL/menuitem 15:30:23 <mayanktg> aleth: ok :) 15:31:45 <-- Armada has quit (Quit: Leaving) 15:32:05 <aleth> There are also a bunch of coding style nits, but we can look at those later. 15:34:52 <clokep_work> aleth: Cool! So...combine that w/ the other code that we started to write and you should get configure to run!? 15:35:50 <clokep_work> Ah the funding just went through for Tor's IM bundle. 15:41:24 <-- hadi has quit (Ping timeout) 15:41:28 --> hadi has joined #instantbird 15:43:55 <aleth> clokep_work: Hopefully (though I'm a bit short of time now) 15:44:01 <aleth> clokep_work: How are they funded? 15:44:15 --> wnayes has joined #instantbird 15:44:19 <clokep_work> aleth: I don't know. 15:49:41 <-- mconley has quit (Connection reset by peer) 15:50:03 --> mconley has joined #instantbird 16:01:52 <aleth> clokep_work: This indeed gets configure to run http://pastebin.instantbird.com/600859 16:03:29 <clokep_work> aleth: Cool. :) Did you check config.status to see if it has the expected output variables? 16:03:44 <aleth> No, I was testing with a dummy configure.in so far. 16:04:34 <clokep_work> Boo. :P 16:04:41 <clokep_work> The patch that adds configure.in is on the bug. 16:05:54 <flo-retina> clokep_work: "Ah the funding just went through for Tor's IM bundle." where did you see that? 16:06:02 <clokep_work> (You can check if STATIC_PRPL is defined.) 16:06:07 <clokep_work> flo-retina: In an email I got from someone. ;) 16:06:32 <clokep_work> "Sorry for the long delay. As a result of our winter dev meeting, Iâve *finally* got a contract to work on this project, with funding, deadlines and all. We aim to have an initial build by March 31st. Progress is forthcoming." 16:06:49 <flo-retina> aleth: why do you have both AC_OUTPUT_SUBDIRS, and the m4 call? 16:07:33 <aleth> flo-retina: That's why I haven't moved on to adding the real configure.in, because I don't understand why it's needed. 16:08:38 <aleth> I can either use the commented out code or AC_OUTPUT_SUBDIRS, but leaving out the m4 call makes it not work. 16:09:50 <flo-retina> strange 16:10:49 <aleth> I wonder if it's simply srcdir vs topsrcdir. 16:11:26 <aleth> (not sure about the difference) 16:15:58 <-- jb has quit (Quit: jb) 16:16:51 <aleth> No, they are identical. 16:18:59 <-- mconley has quit (Connection reset by peer) 16:19:15 --> mconley has joined #instantbird 16:20:29 <aleth> flo-retina: The reason it doesn't work is because MOZ_BUILD_APP isn't set to extensions/purple. 16:22:14 <flo-retina> ah, the "${srcdir}/${MOZ_BUILD_APP}/configure.in" > $tmpscript line 16:22:23 <aleth> yes 16:22:41 <aleth> Not sure if putting extensions/purple there by hand was the right thing to do though. 16:25:11 <flo-retina> aleth: http://mxr.mozilla.org/comm-central/source/mozilla/configure.in#8909 16:44:00 <clokep_work> flo-retina: https://productforums.google.com/forum/#!topic/chat/XqQKYLbTeZ8 is the issue I'm having btw. 16:44:05 <clokep_work> And there seems to be no way to fix it. 16:49:21 <flo-retina> there's a way: let's buy Google and then tell them to fix it! :-D 16:50:30 <mayanktg> aleth: is it to be implemented the same way as it has been done for "File menu" items? http://mxr.mozilla.org/comm-central/source/im/content/menus.js#124 http://mxr.mozilla.org/comm-central/source/im/content/menus.xul#48 16:51:41 <mayanktg> or we can create a function which returns true if no icon is set 16:52:49 <nhnt11> \o/ 16:53:06 <nhnt11> I just updated Komodo, and was pleasantly surprised to see that semicolons are automatically pushed to the end of the line 16:53:07 <nhnt11> :D 16:53:41 * clokep_work has no idea what that means. ;) 16:53:42 <aleth> mayanktg: You aren't using a commandset, so you can just use the attribute. 16:53:51 <aleth> mayanktg: https://developer.mozilla.org/en-US/docs/XUL/commandset 16:54:33 <nhnt11> clokep_work: Try typing Components.utils.reportError("blabla");, but type the semicolon with the caret right before the closing parenthesis. 16:54:56 <nhnt11> I have no idea when this feature kicked in, I noticed it just now though 16:55:09 <nhnt11> It was something I badly missed from Netbeans 16:55:12 <aleth> mayanktg: https://developer.mozilla.org/en-US/docs/XUL/Tutorial/Updating_Commands 17:02:35 * nhnt11 finds himself duplicating this code for the debug log tab: https://mxr.mozilla.org/comm-central/source/im/modules/imWindows.jsm#210 17:05:15 <aleth> so you are saying it should be moved? 17:05:25 * clokep_work has no idea what that code does. :-D 17:05:43 <nhnt11> aleth: I'm not suggesting anything at the moment 17:06:26 <nhnt11> Hmm, fun. It's been a while since I played with XBL bindings :D 17:08:59 <nhnt11> Ugh, I forgot jar.mn again -_-' 17:09:13 <aleth> jarring! :P 17:09:35 <nhnt11> :D 17:10:44 * nhnt11 wonders what the best way is to show the debug log in a browser 17:10:52 <nhnt11> aleth: Do you think I need to worry about making it async and all that? 17:11:00 <nhnt11> Logs could possibly be quite big.. 17:11:27 <aleth> The advantage of making it async is that you could make it live-update at the same time 17:11:35 <nhnt11> Aha. 17:11:44 <nhnt11> That's a good enough reason IMO 17:12:02 <nhnt11> Hmm but is that needed 17:12:04 <aleth> Other than that I suspect it doesn't matter if it's mainly devs that are going to be using it 17:12:37 <flo-retina> clokep_work: it confuses you! :) 17:12:46 <nhnt11> aleth: Was the original point of the copy debug log feature not that users could share them with devs? 17:12:55 <nhnt11> That makes me rethink the point of a debug log tab at all 17:13:16 <aleth> nhnt11: Sure! 17:14:15 <flo-retina> nhnt11: developers also like to share their debug logs with other debug logs, but they want to have a look at what they are sharing first ;) 17:14:32 <flo-retina> nhnt11: when I send someone a debug log, I typically paste it in a new emacs buffer, then look at it, then pastebin 17:14:35 <flo-retina> that's inefficient 17:14:41 <nhnt11> Right 17:15:14 <flo-retina> share ... with other s/debug logs/developers/ ! (sorry) 17:16:07 <aleth> Or you may only want to pastebin some relevant bit 17:16:38 <aleth> The other use case is while developing of course. 17:18:48 <-- hadi has quit (Connection reset by peer) 17:21:57 <flo-retina> yes, it's useful to have a look at what's going on 17:22:04 <nhnt11> flo-retina, aleth: Should I be looking at how conversations are populated? 17:22:15 <flo-retina> my original plans for the debug logs included having a live view, with syntax highlighting for the various protocols 17:22:34 <flo-retina> then I settled on "copy debug logs" as the minimal useful thing and moved on 17:22:46 * nhnt11 wonders if there's an easy way to do the equivalent of document.write(debugLogText) for now 17:22:52 * nhnt11 realizes that document.write would probably work 17:22:54 <flo-retina> nhnt11: if you don't attempt to use message styles (which seem overkill for this case), don't bother 17:23:24 <aleth> nhnt11: No, it will just confuse things 17:23:25 <flo-retina> nhnt11: for a first prototype, document.write would likely work, yes 17:23:34 <nhnt11> I meant for a first prototype, yes. 17:23:47 <flo-retina> be careful about HTML escaping though 17:24:07 <nhnt11> Okay. Is this related to security? 17:24:14 <flo-retina> creating <p> nodes (or <li>) and using .textContent and then appendChild may be good 17:24:34 * nhnt11 recalls a conversation he saw ages ago with someone from Tor.. 17:24:42 <nhnt11> Okay 17:25:13 <flo-retina> nhnt11: you don't want plain text messages (eg. from IRC) that contain HTML code to have that code rendered. 17:25:25 <flo-retina> (I think that's what you would get if you just used document.write(message) 17:26:01 <aleth> nhnt11: Also we straightforwardly want debug logs to be verbatim of course... 17:26:08 <flo-retina> aleth: are you still poking at the configure stuff, or should someone else try and take it over? 17:26:46 <aleth> flo-retina: I don't have time to look at it right now, so feel free to take over :) 17:26:59 <flo-retina> I probably shouldn't look at that right now 17:27:09 <flo-retina> I just don't want everybody to wait on each other for that :) 17:27:40 <nhnt11> "Error: SecurityError: The operation is insecure." for the document.write method :( 17:27:47 <flo-retina> cool :) 17:27:49 * nhnt11 isn't too surprised, honestly 17:28:54 <aleth> How about using the pre tag? 17:30:24 <aleth> Ah, no. 17:33:14 <-- gerard-majax__ has quit (Ping timeout) 17:35:08 <flo-retina> aleth: Let's not bikeshed about the tags right now. We will want something better later to make it more readable, and have clickable location info 17:35:21 <flo-retina> aleth: but for now let's let nhnt11 focus first on getting something that works 17:37:04 <aleth> flo-retina: Yeah, I misremembered what pre did exactly (I thought he could maybe just put the entire log inside a pre tag for now) 17:37:36 <nhnt11> How do I add an element directly to a document? 17:37:45 <nhnt11> doc.appendChild isn't working (didn't expect it to though) 17:37:56 <flo-retina> nhnt11: you want to add the element to the body, not to the document 17:38:06 <nhnt11> d'oh 17:38:07 <nhnt11> cool 17:39:23 <nhnt11> Hmm. So I've got no errors, but nothing is showing up 17:39:28 * nhnt11 readies a pastebin 17:41:05 <nhnt11> http://pastebin.instantbird.com/600960 17:41:18 <nhnt11> (line 50 is where the element creation/addition is) 17:42:31 <aleth> document.createElement("p") is simpler 17:42:45 <nhnt11> aleth: I just made that change 17:43:39 <aleth> I don't see where you are getting the body from 17:44:02 <flo-retina> aleth: doc.body at line 52 17:44:18 <aleth> Ah, OK 17:44:19 <flo-retina> (and I just checked in the error console that it seems to work) 17:44:42 <flo-retina> nhnt11: add a dump() call at line 51 printing formattedMsg? 17:44:54 <nhnt11> flo-retina: Already did. 17:44:57 <nhnt11> It's fine. 17:45:03 <flo-retina> it's printed several times? 17:45:16 <nhnt11> Er, yes? Once for each message 17:45:22 <flo-retina> cool 17:45:33 <flo-retina> nhnt11: then go look at the content of your browser with dom inspector 17:46:10 <flo-retina> nhnt11: I'm a bit surprised that you don't load any URL in the browser 17:46:11 <nhnt11> Interesting 17:46:14 <nhnt11> Yeah 17:46:16 <flo-retina> do you need to load about:blank or something? 17:46:18 <nhnt11> The URL is set to about:blank 17:46:21 <flo-retina> or data:text/html ? 17:46:43 <flo-retina> nhnt11: look at the DOM :) 17:47:04 <nhnt11> I'm looking at it. BODY doesn't have any children 17:47:36 <nhnt11> I'll try data:text/html.. 17:49:31 --> jb has joined #instantbird 17:49:40 <nhnt11> That didn't work 17:50:15 <flo-retina> which URL have you used? 17:50:34 <nhnt11> I set the browser's src attribute to data:text/html 17:51:12 <aleth> Try browser.loadURI("about:blank") 17:51:15 <flo-retina> apparently for conversations we use "chrome://chat/content/conv.html" 17:51:34 <nhnt11> Which is blank 17:51:42 <flo-retina> nhnt11: oh, I think I know your problem: you may be poking at the document before the it's done loading 17:51:51 <flo-retina> so about:blank is loaded _after_ all your DOM changes 17:51:57 <nhnt11> Hmm 17:52:15 <flo-retina> see http://mxr.mozilla.org/comm-central/source/chat/content/convbrowser.xml#65 17:52:53 <flo-retina> we start poking with the actual document only at http://mxr.mozilla.org/comm-central/source/chat/content/convbrowser.xml#825 17:53:24 <flo-retina> You probably don't need to implement nsIWebProgressListener though 17:53:35 <flo-retina> there may be an event that's good enough (domcontentloaded?) 17:53:43 <nhnt11> Interesting 17:53:49 <flo-retina> nhnt11: see http://lxr.instantbird.org/instantbird/source/instantbird/content/viewlog.js#37 17:54:54 <nhnt11> I shall try that. 17:56:40 <nhnt11> What's text-browser there? 17:57:10 * nhnt11 is searching 17:57:27 <nhnt11> okay so it's just a browser 17:58:00 * nhnt11 isn't sure why there's text-browser and conv-browser but doesn't think it's too important anyway 17:59:12 <nhnt11> It works \o/ 17:59:16 <nhnt11> flo-retina: Thanks!! 17:59:24 <aleth> text-browser is legacy stuff that displays plain text logfiles. 17:59:34 <nhnt11> Ah 18:01:09 <aleth> You might want to copy this line too http://mxr.mozilla.org/comm-central/source/chat/content/convbrowser.xml#65 18:01:20 <aleth> (or some equivalent) 18:02:08 <nhnt11> Okay 18:03:19 * clokep_work wants to see a screenshot. :P 18:03:34 <nhnt11> clokep_work: It's pretty ugly 18:03:42 <nhnt11> But here you go: http://puu.sh/73yWT.png 18:04:07 <flo-retina> cool :) 18:04:10 <aleth> The rest is details :) 18:04:45 <flo-retina> the screenshot would be more convincing if you had at least another tab in the window 18:05:06 <flo-retina> also, putting some text in the tab title would make it feel more 'real' :) 18:05:27 <clokep_work> nhnt11: I'm still excited! :-D 18:05:33 * clokep_work has no idea how we'd do syntax highlighting. :-S 18:05:44 <flo-retina> clokep_work: we would do it by filing a bug ;) 18:05:53 --> Mook_as has joined #instantbird 18:06:02 <flo-retina> clokep_work: also, some of the dev tools stuff may have existing solutions for some of it 18:06:06 * nhnt11 is going to get something to eat 18:06:30 <clokep_work> flo-retina: Sure...:) 18:06:34 <clokep_work> filing a bug is easy. ;) 18:06:46 <nhnt11> There's already a bug for debug log in a tab, btw 18:07:06 <nhnt11> bug 955641 18:07:08 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955641 nor, --, ---, nobody, NEW, Open debug logs in a tab 18:07:34 * clokep_work is excited. 18:07:49 <aleth> It's going to be really useful. 18:09:07 * flo-retina wonders how nhnt11 manages to do more exciting Ib work than everybody else in the team during that same time 18:09:57 * nhnt11 was a bit disappointed in himself for not finishing the WIP earlier, but is flattered anyway 18:10:04 <aleth> Backend work is less visible in the app ;) 18:11:01 <flo-retina> aleth: yeah, I'm tired of spending all my Ib time fixing crap that no longer wants to build ;) 18:11:19 <clokep_work> aleth: Is one of those pastebins your "newest" things that works. 18:11:25 <clokep_work> I have a few minutes while VMs are coming up.. 18:11:52 <aleth> clokep_work: The last pastebin works but I'm not sure it's the right way to do it. 18:12:16 <aleth> You can drop the AC_OPTIONS line. 18:12:58 <aleth> Bear in mind "works" == "extensions/purple/configure.im is processed", I didn't test more than that 18:13:16 <clokep_work> aleth: http://pastebin.instantbird.com/600859 18:13:20 <clokep_work> Yes? 18:13:24 <aleth> Yes 18:13:50 <aleth> s/AC_OPTIONS/AC_OUTPUT/SUBDIRS 18:14:08 <clokep_work> What? 18:14:21 <clokep_work> Error: too many parameters in s// statement. :P 18:14:26 <aleth> Not my day for typing :-S 18:15:22 --> gerard-majax__ has joined #instantbird 18:16:35 <aleth> clokep_work: With that pastebin? 18:17:52 <clokep_work> aleth: No, with your statement. 18:17:56 <clokep_work> What are you saying to switch? 18:18:57 <flo-retina> clokep_work: aleth means that he typed "You can drop the AC_OPTIONS line." instead of "You can drop the AC_OUTPUT_SUBDIRS line." 18:20:24 <aleth> clokep_work: Sorry, yes, what flo said. I typoed in the correction. 18:52:47 <clokep_work> flo-retina, aleth: http://pastebin.instantbird.com/601031 gives interesting results. 18:53:58 <clokep_work> It eventually gives http://pastebin.instantbird.com/601032 18:54:54 <aleth> Interesting approach. That doesn't look like a terrible error. 18:56:01 <aleth> clokep_work: I'm confused line 37 & 38 don't need to be commented out 18:56:27 <aleth> (that's kind of a trivial comment of course) 18:56:30 <clokep_work> Hmm...maybe they do and I totally messed things up. :) 18:56:46 <clokep_work> If I uncomment that stuff and comment out AC_OUTPUT_SUBDIRS...I get an error about MOZ_BUILD_APP not existing. 18:56:50 <clokep_work> How'd you get past that? :-S 18:57:57 <aleth> I just meant you have line 36 commented out and I would have thought not commenting out 37 and 38 as well would give some kind of syntax error 18:58:36 <clokep_work> aleth: Yes, I understand that. 18:58:41 <clokep_work> I'm asking an entirely unrelated question. 18:59:06 <aleth> You are saying the original pastebin didn't work for you? 18:59:28 <flo-retina> clokep_work: so what was the problem with http://pastebin.instantbird.com/600859 (without lines 11-18) ? 18:59:56 <clokep_work> I don't understand what you guys are asking. :-S 19:00:23 <aleth> and vice versa :-/ 19:00:38 <flo-retina> right 19:01:05 <-- jb has quit (Quit: jb) 19:01:10 <flo-retina> clokep_work: I don't understand what you are trying to do 19:01:34 <clokep_work> flo-retina: I'm trying to get configure to run... 19:01:40 --> jb has joined #instantbird 19:01:42 <flo-retina> that part, we understood ;) 19:01:52 <clokep_work> Then you need to ask a more specific question. :P 19:02:02 <flo-retina> why didn't you use what aleth pastebined? 19:02:29 <aleth> I got around the MOZ_BUILD_APP issue by putting extensions/purple there by hand. Is that what you were asking? 19:03:00 <-- Tonnes has quit (Quit: ChatZilla 0.9.90.1 [Firefox 27.0.1/20140212131424]) 19:03:05 <clokep_work> flo-retina: Because it doesn't work. 19:03:08 <clokep_work> I get: 0:02.75 Configuring purplexpcom 19:03:08 <clokep_work> 0:02.76 /var/folders/1n/j8t7_vv168q01tqsrfnk960m0000gn/T/subscript.bs_uCN: line 71: MOZ_BUILD_APP: command not found 19:03:08 <clokep_work> 0:02.76 /var/folders/1n/j8t7_vv168q01tqsrfnk960m0000gn/T/subscript.bs_uCN: line 76: /Users/pcloke/mozilla/comm-central/mozilla/build/autoconf/altoptions.m4: Permission denied 19:03:17 <clokep_work> (I added an echo "Configuring purplexpcom" line.) 19:03:32 <clokep_work> aleth: "by putting extensions/purple there by hand", I don't understand. 19:03:32 <flo-retina> clokep_work: that error is from the ' AC_OUTPUT_SUBDIRS($topsrcdir/extensions/purple)' line that aleth told you to remove 19:03:39 <clokep_work> I did remove it 19:03:55 <flo-retina> so what's using MOZ_BUILD_APP ? 19:04:09 <clokep_work> flo-retina, aleth: http://pastebin.instantbird.com/601043 is exactly what I'm running now. 19:04:17 <flo-retina> aleth: so I just put the code in your pastebin in my filed and it looks like the only thing that was broken in my code was using [] instead of test? 19:04:21 <flo-retina> aleth: is this correct? 19:04:23 <clokep_work> Which is the pastebin + some lines removed (I think I got the right ones) + an echo line 19:04:40 <flo-retina> aleth: if so, that's really silly of me, I should have remembered that [] are treated like quotes in autoconf :( 19:04:56 <aleth> flo-retina: Yes 19:05:01 <flo-retina> :( 19:05:02 <flo-retina> aleth: thanks! 19:05:46 <flo-retina> clokep_work: so have you tried http://pastebin.instantbird.com/601044 ? 19:06:17 <clokep_work> flo-retina: That's identical to what I pastebinned except I have spaces, not tabs and I added an echo. 19:07:12 <flo-retina> clokep_work: ok. So what's the result of that? 19:07:16 <flo-retina> (I now have spaces too :)) 19:07:36 --> Tonnes has joined #instantbird 19:07:40 <aleth> clokep_work: Which OS are you on atm? 19:07:48 <clokep_work> aleth: Mac OS X. 19:07:49 <aleth> (you never know...) 19:08:17 <clokep_work> Actually I think the terminal find was just screwing me over, one second. 19:08:27 <flo-retina> aleth: "/Users/" at the beginning of a path strongly pointed toward OSX ;) 19:08:36 <aleth> clokep_work: Do you have a configure.in in extensions/purple that might be broken? 19:08:44 <aleth> flo-retina: Right :) 19:13:22 <clokep_work> aleth: http://pastebin.instantbird.com/601055 19:14:25 <aleth> So you're saying that inserting a non-dummy configure.in runs into trouble because MOZ_BUILD_APP is pointing at im? 19:15:40 <clokep_work> I haven't tried a "dummy" configure.in. 19:15:45 <clokep_work> Did you just use a blank file? 19:15:53 <aleth> I just put an echo there. 19:17:57 <aleth> With your configure.in mach configure runs fine, I'm trying mach build now. 19:20:43 <-- douglaswth has quit (Quit: OMGWTFBBQ!) 19:21:21 --> douglaswth has joined #instantbird 19:21:57 <clokep_work> aleth, flo-retina: Progress, 0:02.69 /var/folders/1n/j8t7_vv168q01tqsrfnk960m0000gn/T/subscript.WszTez: line 45: syntax error near unexpected token `2.12' 19:21:58 <clokep_work> 0:02.69 /var/folders/1n/j8t7_vv168q01tqsrfnk960m0000gn/T/subscript.WszTez: line 45: `AC_PREREQ(2.12)' 19:24:16 <-- jb has quit (Ping timeout) 19:26:16 <clokep_work> (Any ideas would be good. :)) 19:27:29 <aleth> This happens for you during mach configure? That's what's confusing me. (My build is still running) 19:28:00 <clokep_work> aleth: Yes. 19:28:37 <aleth> I can't reproduce then. :-S 19:29:11 <flo-retina> clokep_work: where is AC_PREREQ(2.12)? 19:30:18 <flo-retina> what's the content of your mozilla/extensions/purple/configure.in file? 19:32:50 <aleth> It's the one in his WIP patch in the bug, 19:32:59 --> EionRobb has joined #instantbird 19:37:36 <aleth> clokep_work: Where is the config.status you asked me to check ealier (iirc)? 19:38:21 <flo-retina> aleth: link to the attachment? 19:38:29 <flo-retina> I still don't know which configure.in file is used 19:38:55 <flo-retina> ah https://bugzilla.mozilla.org/attachment.cgi?id=8369240&action=diff 19:40:10 <flo-retina> clokep_work: so the configure file you are using isn't correct 19:40:39 <flo-retina> you should basically use http://lxr.instantbird.org/instantbird/source/instantbird/configure.in with lines 7-9 removed. 19:40:58 <flo-retina> and you likely need a slightly different code for lines 11-15 to get a good value for the commdir variable 19:43:25 <aleth> clokep_work: OK, I can reproduce it now. 19:43:58 <aleth> (The 2.12 syntax error line.) 19:46:17 <clokep_work> flo-retina: I could ahve sworn that's what I was using. :( 19:47:29 * clokep_work is on the phone. 19:47:30 <clokep_work> Sorry. :) 19:49:29 <aleth> flo-retina: That seems to work, with commdir=$topsrcdir/extensions 19:50:12 <aleth> It then fails with mozbuild.frontend.reader.SandboxValidationError: Reference to a file that doesn't exist in SOURCES (static_proto_init.c) in extensions/purple/libpurple 19:56:38 <aleth> I suppose that's where the MOZ_BUILD_APP issue reappears in another guise :-/ 19:56:57 <clokep_work> aleth: That's on a build, not a configure, right? 19:57:09 <aleth> No, that's at the end when config.status is processed 19:57:26 <clokep_work> aleth: Mine completed successfully. ;) 19:57:41 <aleth> Haha :D 19:57:44 <clokep_work> But I see now configure file. 19:57:52 <clokep_work> I think we should ensure we're all working w/ the same thing... :-\ 19:58:00 <aleth> Probably... 19:59:53 <clokep_work> I'll put up new patches soon, I guess. 20:00:10 <aleth> Yeah, if you have it working that would be nice :) 20:00:39 <clokep_work> aleth: Did you have issues with https://bugzilla.mozilla.org/show_bug.cgi?id=955009#c39 also? 20:00:42 <instantbot> Bug 955009 enh, --, ---, clokep, ASSI, Ship libpurple as an add-on / allow it to be disabled in configure 20:00:51 <clokep_work> I did, wasn't sure how to fix it though. 20:01:11 <aleth> Yes, I used patch and commited by hand. 20:01:32 <clokep_work> OK. 20:07:24 * nhnt11 is working on formatting the debug messages 20:07:41 <nhnt11> Here's what it looks like right now: http://puu.sh/73Hn9.png 20:08:00 <nhnt11> I can't get the table to wrap :/ 20:09:26 * nhnt11 should probably figure out if it's possible/how to attach a style sheet to the browser first 20:12:05 <aleth> nhnt11: look at document.styleSheets 20:13:19 <nhnt11> aleth: Can that be used to attach a stylesheet though? 20:13:29 <nhnt11> (i.e. isn't it readonly? 20:13:53 <aleth> You'll have to check on mdn, you can certainly add rules if there is a stylesheet so I would be surprised if not 20:14:10 <clokep_work> Add a <style> element somewhere? :-D 20:14:46 <aleth> I think he's looking for the JS equivalent ;) 20:16:57 <nhnt11> aleth, clokep_work: Well I could add a <style> to document.head 20:17:20 <nhnt11> But then I would be defining the styles from javascript 20:17:29 <aleth> clokep_work: Did you make any changes to the libpurple configure.in apart from at the very top? 20:17:31 <nhnt11> I'm looking for a way to have a .css file, and attach that to the browser's document 20:17:39 <nhnt11> flo-retina: ^ 20:17:53 <clokep_work> aleth: I don't understand the question. :-\ 20:18:30 * nhnt11 wonders if a css file included in the xml file will apply to the browser as well 20:18:33 --> Mic has joined #instantbird 20:18:33 * ChanServ sets mode +h Mic 20:18:39 <aleth> clokep_work: What's new here https://bugzilla.mozilla.org/attachment.cgi?id=8379191&action=diff compared to the hg.instantbird.org one? 20:19:46 <clokep_work> aleth: It has the lines removed that flo-retina suggested and the paths changed. :) 20:20:10 <deOmega> hello. I know this may be quite late, but is it possible to have a send button? Or is there a workaround.? 20:21:39 <aleth> Mic: Thanks! 20:22:19 <deOmega> the scenario is there are times someone may want me to give them the word to do something... so I would have teh words typed already waiting to send 20:22:52 <deOmega> but without a send button, i have to go over to the box, select it then look for enter on teh keyboard 20:23:08 <deOmega> any ideas? thanks and sorry about the flooding 20:26:34 * nhnt11 doesn't get why the table is overflowing the window 20:26:35 <aleth> clokep_work: I still end up with mozbuild.frontend.reader.SandboxValidationError after the traceback after Reticulating splines... 20:27:08 <aleth> deOmega: That's an intriguing scenario. 20:27:28 <clokep_work> aleth: Let me try a clean objdir 20:27:30 <aleth> deOmega: I don't think there's a workaround other than writing an add-on 20:28:07 <clokep_work> aleth: OK, now I'm getting that. 20:28:22 <aleth> OK, so at least we are in sync :) 20:29:04 <aleth> (I had a similar issue earlier when I thought mach configure was working fine...) 20:31:35 <mayanktg> aleth: no help with that..will try more :-/ 20:31:47 <aleth> mayanktg: Help with what? 20:32:27 <mayanktg> aleth: adding disabled feature to remove Icon 20:32:27 <clokep_work> aleth: Yes, but disappointing. :( 20:32:47 <aleth> mayanktg: You just need to get the menuitem and then use setAttribute 20:33:24 <mayanktg> Ok 20:34:37 <deOmega> aleth: OK, thank you very much 20:34:59 <deOmega> Just wanted to bring it up at least :) 20:34:59 <aleth> clokep_work: http://lxr.instantbird.org/instantbird/source/purple/libpurple/Makefile.in#169 20:35:37 <clokep_work> aleth: ...Is that the line causing issues? 20:36:32 <aleth> It's the only file I can find references to the "missing" file in. 20:40:27 <clokep_work> aleth: My guess is that needs to be added to moz.build. 20:42:59 <aleth> But it doesn't exist 20:43:17 <clokep_work> aleth: First of all that's not in that file anymore. 20:44:07 <aleth> So, if I add ac_add_options --enable-purple-plugins to my mozconfig, it configures OK :) 20:44:24 <clokep_work> aleth: See https://bugzilla.mozilla.org/attachment.cgi?id=8370402&action=diff#a/libpurple/Makefile.in_sec3 20:44:42 <clokep_work> Changing that to GENERATED_SOURCES makes my configure complete. 20:45:59 <aleth> Ah, so either way we have it working :) 20:46:12 <aleth> That explains it then. 20:47:52 <clokep_work> aleth: so objdir/mozilla/config.status shows the results of configure. 20:47:58 <aleth> Yes 20:47:58 <clokep_work> I see STATIC_PRPLS defined in mine! 20:48:09 <aleth> Indeed :) 20:48:54 <flo-retina> clokep_work: "This seems to run, but I don't see any output configure file." why do you expect to see a 'configure' file? 20:49:06 <flo-retina> you generate it in a temporary location and then rm it after running it... 20:49:16 <clokep_work> flo-retina: Oh, I didn't know it was rm'd. 20:49:27 <clokep_work> flo-retina: Please stop assuming I have any idea how configure works. :-\ 20:50:04 <flo-retina> clokep_work: I just assumed you had read http://pastebin.instantbird.com/601044 ;) 20:50:07 <flo-retina> (line 16) 20:50:27 <clokep_work> flo-retina: I thought that was removing the script to create the configure file, not the configure file itself. 20:50:48 <flo-retina> ok :) 20:51:19 * clokep_work is doing a build now. 20:51:47 <flo-retina> I wanted to mention GENERATED_SOURCES when I saw you were having issues with static_proto_init.c, but you all figured it out before I was done reading the scrollback :) 20:51:58 * aleth is also building 20:52:11 <clokep_work> I figured it out pretty quickly...I just was confused at it wasn't in that file already. ;) 20:52:21 * clokep_work finds it difficult to discuss large changes to code like this w/o lxr to link to. :( 20:57:05 <nhnt11> flo-retina: Do you have any ideas about attaching a stylesheet to an XUL browser? 20:57:08 * nhnt11 is kinda stuck 20:57:19 --> Mnyromyr has joined #instantbird 20:57:42 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105]) 21:02:14 <clokep_work> 10:29.29 Exception: File not found: protocols/jabber/libjabber.a :( 21:02:47 <aleth> ditto 21:03:17 * clokep_work guesses he needs to look back at the rules stuff... 21:03:20 * aleth wonders what a .a file is 21:04:37 <flo-retina> clokep_work: cool 21:04:51 <flo-retina> clokep_work: that means we are now ready to fix the static prpl thingy :) 21:05:15 <clokep_work> flo-retina: Exactly my thoughts! :) Any ideas? :P 21:05:22 <flo-retina> clokep_work: I'll need to look at the code 21:05:28 <-- deOmega has quit (Quit: So easy...but yet complicated.) 21:05:31 <flo-retina> what do I need to apply exactly to start poking? :) 21:05:43 <clokep_work> Let me upload the newest patch. 21:06:09 <flo-retina> nhnt11: I would just load an HTML file in the browser, and include the css from the html file 21:06:47 * nhnt11 was hesitant to create a dummy HTML file 21:06:49 <nhnt11> But okay, I guess 21:07:26 <clokep_work> flo-retina: Everything should be on https://bugzilla.mozilla.org/show_bug.cgi?id=955009 now. 21:07:29 <instantbot> Bug 955009 enh, --, ---, clokep, ASSI, Ship libpurple as an add-on / allow it to be disabled in configure 21:08:46 <aleth> There doesn't seem to be a rule generating the static library files yet? 21:08:55 --> nhnt12 has joined #instantbird 21:09:19 <-- nhnt11 has quit (Ping timeout) 21:11:46 <clokep_work> aleth: prpl.py should have someo f that stuff. 21:12:27 <aleth> Yes, looking at that file 21:17:06 <-- GeKo has quit (Ping timeout) 21:18:37 <flo-retina> aleth: adding that rule shouldn't be too difficult 21:19:01 <aleth> I'm wondering why the FINAL_LIBRARY isn't enough 21:19:44 <clokep_work> aleth, flo-retina: Locally I changed line 7 to if protocol in CONFIG['STATIC_PRPLS'] 21:19:47 <flo-retina> we probably aren't looking at the exact sime code 21:19:50 <clokep_work> |if protocol in CONFIG['STATIC_PRPLS']| 21:19:54 <clokep_work> Bah, BenB.... 21:19:57 <aleth> clokep_work: me too 21:20:10 <flo-retina> remember I tinkered with the code to make dynamic prpls work ;) 21:20:15 <clokep_work> (I removed the TODO comment too, but that doesn't seem useful. ;)) 21:20:29 <clokep_work> flo-retina: Oh< I have that patch applied at home, but not here. :( 21:20:48 <flo-retina> clokep_work: line 7 of what? 21:20:54 <clokep_work> flo-retina: prpl.py 21:21:37 <flo-retina> so you removed the | CONFIG['STATIC_PRPLS'] and | part? 21:22:04 * flo-retina wonders what BenB is doing to that poor file 21:22:07 <clokep_work> flo-retina: Yes, it was just to make it stop crashing since that wasn't in configure before. 21:22:16 <clokep_work> flo-retina: BenB makes it so |if protocol in CONFIG['STATIC_PRPLS']| doesn't show up as code. ;) 21:22:37 <flo-retina> aaah! 21:22:55 <flo-retina> that change doesn't make any behavior difference, right? 21:23:02 <clokep_work> No. 21:23:11 <flo-retina> ok, I'll focus on getting stuff to build before cleaning it up 21:23:17 <aleth> No 21:23:18 <aleth> Looking at rules.mk now 21:23:36 <clokep_work> I cleaned up the patch you had given previously...and I don't think I uploaded it anywhere. :( 21:23:37 <aleth> prpl-rules.mk 21:24:07 <flo-retina> aleth: I think you are right that FINAL_LIBRARY should be enough :) 21:26:33 --> GeKo has joined #instantbird 21:26:34 <flo-retina> aleth: which means that to fix your "File not found: protocols/jabber/libjabber.a" error, you need to go edit around http://lxr.instantbird.org/instantbird/source/purple/libpurple/Makefile.in#32 21:26:56 <aleth> ah! 21:26:57 <flo-retina> remove (or comment out :)) lines 34 37 38 21:28:02 <clokep_work> flo-retina: Is that the same change your changes had made? I can't find that pastebin again. :( 21:28:08 <aleth> 37 & 38 ? 21:28:47 <flo-retina> aleth: look at the lines in lxr, not in the current file 21:29:02 <aleth> aah :D 21:29:10 <aleth> That makes much more sense. 21:29:47 <flo-retina> line 25 should also be removed, but that's unrelated 21:30:13 <flo-retina> and I think we should get rid of the PURPLE_PLUGINS case that never really worked 21:30:29 <aleth> That's not just in that file 21:31:59 <flo-retina> the PURPLE_PLUGINS stuff is scattered across several files, yes. 21:32:06 <flo-retina> and we could remove that later in a follow up 21:33:59 <aleth> Now clang is looking for those .a files when making libpurplexpcom.dylib 21:35:29 <flo-retina> that's correct 21:38:43 * clokep_work expects a diff at some point. ;) 21:40:40 <-- Mic has quit (Ping timeout) 21:43:34 <aleth> clokep_work: http://pastebin.instantbird.com/601196 21:43:35 * nhnt12 wonders what font/font-size the messages in the error console use 21:43:39 * nhnt12 is now known as nhnt11 21:44:03 <flo-retina> nhnt11: DOM Inspector is your friend ;) 21:44:15 <nhnt11> Oh yeah 21:44:37 <flo-retina> aleth: why the space before the "DEFINES += -DSTATIC_PROTO_INIT..." line? 21:45:14 <aleth> clokep_work: http://pastebin.instantbird.com/601197 21:45:28 <flo-retina> aleth: I get a "ld: can't link with bundle (MH_BUNDLE) only dylibs (MH_DYLIB) for architecture x86_64" insult 21:46:07 <aleth> flo-retina: not sure where that came from 21:46:15 <aleth> I've removed it. 21:47:08 <flo-retina> bah, the command line arguments given to the linker are wrong, it includes all the dynamically linked prpls :-S 21:47:36 <clokep_work> aleth: How are those diffs separated? They confuse me a lot. :-S 21:47:37 <-- mayanktg has quit (Quit: http://www.mibbit.com ajax IRC Client) 21:48:04 <aleth> clokep_work: One is flo's patch at least as I have it, one is my changes 21:48:11 <flo-retina> the diff I have looks like http://pastebin.instantbird.com/601199 21:48:22 <aleth> flo-retina: I get this http://pastebin.instantbird.com/601198 21:48:54 <flo-retina> aleth: you are lucky then! 21:49:20 <flo-retina> aleth: that error means you need to fix the commented out stuff at the top of libpurple/moz.build 21:51:50 <aleth> Why would we need to add those dirs twice? 21:52:19 <aleth> (you are talking about the PARALLEL_DIRS lines, right?) 21:53:25 <flo-retina> you need to add each of them once 21:53:51 <flo-retina> the static prpls need to be added from libpurple/moz.build, and the dynamic prpls need to be added from purplexpcom/src/moz.build 21:54:12 <aleth> OK 21:54:29 <clokep_work> If there's a full list of prpls somewhere you should be able to get the intersection of PRPLS and STATIC_PRPLS, etc. 21:54:30 <flo-retina> ah, after rm -r objdir/mozilla/extensions/purple, and rebuilding, I now have the same error as you :) 21:54:51 <flo-retina> clokep_work: well, in one case we only care about the static prpls, so we can use that list directly 21:55:02 <aleth> clokep_work: I was just wondering how to do that... 21:55:59 <clokep_work> flo-retina: Sure. :) 21:56:07 <clokep_work> aleth: Well first "get it working" even if it involves hard coding? 21:57:13 --> rosonline has joined #instantbird 21:57:17 <flo-retina> anything obviously wrong in: PARALLEL_DIRS += ['protocols/' + proto for proto in CONFIG['STATIC_PRPLS']] 21:57:17 <flo-retina> ? 21:57:29 <flo-retina> that gives me: Directory (protocols/b) registered multiple times in PARALLEL_DIRS 21:57:33 <-- chrisccoulson has quit (Ping timeout) 21:58:34 --> chrisccoulson has joined #instantbird 21:59:37 <flo-retina> is CONFIG['STATIC_PRPLS'] a string or an array? 22:01:13 <aleth> I'm struggling with the same error 22:01:17 <flo-retina> likely a string 22:01:30 * nhnt11 stops for the night with this: http://puu.sh/73PAE.png 22:01:32 <aleth> prpl.py uses it like an array 22:01:33 <clokep_work> flo-retina: It's a string, we should probably put a .split(" ") on it. 22:01:39 <flo-retina> ok 22:01:45 <flo-retina> so all the other existing code touching it is likely wrong 22:01:48 <clokep_work> (Although I think python in works anyway) 22:01:58 <flo-retina> clokep_work: well, a string is an array 22:01:59 <aleth> nhnt11: That's quite an improvement :) 22:02:06 <flo-retina> but each character is an item 22:02:11 <clokep_work> True. :) 22:02:24 <clokep_work> nhnt11: Nice progress! :) 22:02:29 <flo-retina> nhnt11: attach a patch before stopping ;) 22:02:37 <nhnt11> Okay. 22:02:37 <aleth> That would explain where the b comes from ;) 22:02:40 <flo-retina> nhnt11: but great progress indeed! 22:02:55 <aleth> clokep_work: your idea works :) 22:03:26 <flo-retina> 0:05.78 File already read. Skipping: /Users/florian/buildhg/comm-central/mozilla/extensions/purple/libpurple/protocols/jabber/moz.build 22:03:27 <flo-retina> :-S 22:05:37 <nhnt11> aleth: What email address do you use on BMO? aleth@instantbird.org? 22:05:42 <aleth> Yes 22:05:53 <flo-retina> heh, sounds like I can get away with including all the prpls in parallel_dirs in purplexpcom/src/moz.build and moz.build will automatically ignore the ones that were already built by libpurple/moz.build :-D 22:06:01 <flo-retina> I don't think we want to rely on that though :) 22:06:12 <flo-retina> aleth: has your build finished well? (mine worked) 22:10:14 <flo-retina> aleth: (assuming yes,) next step is to add http://lxr.instantbird.org/instantbird/source/instantbird/installer/package-manifest.in#223 back in http://mxr.mozilla.org/comm-central/source/im/installer/package-manifest.in with an ifdef 22:11:07 * clokep_work still wonders if it's better to use one of the other methods (i.e. making a full XPI or something) 22:11:56 <flo-retina> clokep_work: I don't think we want an xpi (the binaries files would have to be unpacked anyway) 22:12:07 <flo-retina> clokep_work: the other packaging method is to put everything in an extensions/ folder 22:12:22 <nhnt11> clokep_work: I haven't f?'d you on that WIP patch but feel free to drop a comment on your opinion :) 22:12:23 <nhnt11> Good night 22:12:30 <flo-retina> clokep_work: that's more work 22:12:32 <clokep_work> flo-retina: I don't remember exactly what they are, aleth found a nice link. 22:12:45 <flo-retina> clokep_work: I think we should just do whatever is the fastest to get us nightlies again 22:12:49 <clokep_work> flo-retina: A benefit of an XPI I see is being able to directly use it for TB too. 22:12:53 <clokep_work> flo-retina: Fair enough. :) 22:12:58 <flo-retina> clokep_work: I know that 22:13:08 <flo-retina> clokep_work: and I would be all for adding the makefile magic to generate the xpi for Tb 22:13:19 <flo-retina> clokep_work: but that's really a separate problem 22:13:42 <flo-retina> clokep_work: the problem I'm trying to address now is "get nightlies out of c-c that are from a user point of view identical to what we had before going to c-c" 22:14:22 <clokep_work> flo-retina: I agree. Sorry for confusing the situation. 22:16:32 * aleth still ends up with make[8]: *** [protocols/qq_libs] Error 2 22:16:57 <EionRobb> do you use a libpurple prpl for qq? 22:17:58 <aleth> Yes, not that it works. 22:18:24 <EionRobb> right 22:19:14 <aleth> Maybe I should clobber, but I think I have to go. 22:19:46 <EionRobb> yeah, we were talking about this in #pidgin earlier on in the week, that libqq doesn't work, but there's another one that does 22:20:35 <flo-retina> aleth: so is there anything I should take from your work? 22:20:41 <flo-retina> or just make patches based on what I have? 22:21:46 <nhnt11> flo-retina: Can you think of any reason I'm not receiving bugmail? (e.g. for your f+ just now) :( 22:22:04 <aleth> flo-retina: I think the only difference is likely http://pastebin.instantbird.com/601240 22:22:08 <nhnt11> My email settings seem fine.. 22:22:32 <flo-retina> aleth: does that work? 22:22:37 <flo-retina> nhnt11: check your spam folder? 22:22:43 <nhnt11> Nothing there.. 22:23:13 <aleth> I'd have to clobber and rebuild, I'm getting make[8]: *** [protocols/qq_libs] Error 2 22:23:27 <aleth> Which doesn't seem related. 22:23:29 <flo-retina> aleth: there's likely an error before that 22:23:42 <flo-retina> and I don't think you have to fully clobber 22:24:03 <aleth> make[9]: *** [buddy_opt.o] Error 1 22:24:03 <flo-retina> |rm -r objdir/mozilla/extensions/purple && ./mozilla/mach build| worked well for me earlier :) 22:24:08 <nhnt11> Hmm. I'm seeing it in the "All Mail" view 22:24:17 <flo-retina> aleth: you likely have a compiler error before that ;) 22:24:21 <nhnt11> Why would it skip my inbox :/ 22:24:34 <flo-retina> you keep bugmail in your inbox? :-O 22:24:47 <nhnt11> Er, I meant it's getting archived 22:24:51 <aleth> flo-retina: Yes, it's a helpfule "The following command failed to execute properly: clang..." 22:24:53 <nhnt11> I just realized why though 22:25:04 <nhnt11> I'd created a filter to archive all bugmail during the bio->bmo merge 22:25:09 <flo-retina> pastebin something larger around that? :) 22:25:18 <flo-retina> like at least 50 lines before/after :) 22:25:21 <aleth> Sorry, gtg :-( 22:25:31 <flo-retina> aleth: ok, no worries 22:25:34 * flo-retina was just trying to help 22:25:42 <aleth> Thanks! 22:25:53 <aleth> I /think/ that generator should work though my python is not strong... 22:27:33 <-- aleth has quit (Ping timeout) 22:38:40 <-- mconley has quit (Input/output error) 22:42:59 --> Mic has joined #instantbird 22:42:59 * ChanServ sets mode +h Mic 23:00:55 <-- rosonline has quit (Ping timeout) 23:01:34 --> rosonline has joined #instantbird 23:07:27 --> jb has joined #instantbird 23:09:06 <-- clokep_work has quit (Ping timeout) 23:20:18 <-- jb has quit (Connection reset by peer) 23:20:40 --> jb has joined #instantbird 23:35:52 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 23:37:06 <-- jb has quit (Ping timeout) 23:52:42 <flo-retina> any idea of why this wouldn't work? 23:53:15 <flo-retina> http://pastebin.instantbird.com/601331 23:58:37 --> clokep has joined #instantbird 23:58:37 * ChanServ sets mode +o clokep 23:59:00 --> clokep_work has joined #instantbird 23:59:28 <clokep_work> flo-retina: Not off the top of my head. 23:59:33 <flo-retina> bah, I'm an idiot 23:59:47 <clokep_work> I guess you know then. ;) 23:59:55 <flo-retina> dynamic prpls "don't work" because... all the prpls are statically linked for the kind of build I'm attempting to do