#instantbird log on 02 18 2014

All times are UTC.

00:03:35 --> clokep has joined #instantbird
00:03:35 * ChanServ sets mode +o clokep 
00:19:56 --> mconley has joined #instantbird
00:38:05 <instant-buildbot> build #1990 of macosx-nightly-default is complete: Failure [4failed shell_3]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/1990
00:44:16 <-- dew has quit (Ping timeout)
00:44:40 --> dew has joined #instantbird
00:57:29 <-- dewtwo has quit (Ping timeout)
01:09:06 <-- qheaden has quit (Ping timeout)
01:16:55 --> qheaden has joined #instantbird
01:20:16 <-- clokep has quit (Ping timeout)
01:22:21 --> dewtwo has joined #instantbird
01:58:19 <-- Mook_as has quit (Quit: Mook_as)
02:25:01 <-- mconley has quit (Input/output error)
02:25:42 --> mconley has joined #instantbird
02:29:12 <-- mconley has quit (Input/output error)
02:51:44 <-- Morian has quit (Ping timeout)
02:54:01 --> Morian has joined #instantbird
02:54:02 * ChanServ sets mode +h Morian 
03:12:07 --> Mook has joined #instantbird
04:02:50 --> mconley has joined #instantbird
04:29:36 <-- mconley has quit (Input/output error)
04:32:00 <-- dewtwo has quit (Ping timeout)
04:41:28 <-- SCIF has quit (Ping timeout)
04:45:19 --> SCIF has joined #instantbird
05:02:28 <-- Mook has quit (Quit: Mook)
05:08:00 --> gerard-majax__ has joined #instantbird
05:12:26 <-- gerard-majax__ has quit (Ping timeout)
05:13:02 <-- EionRobb has quit (Quit: Leaving.)
05:16:23 --> dewtwo has joined #instantbird
05:21:59 --> mayanktg has joined #instantbird
05:26:20 <mayanktg> aleth: What am I supposed to change in the code here: http://mxr.mozilla.org/comm-central/source/chat/protocols/yahoo/yahoo-session.jsm#312
06:07:29 --> mconley has joined #instantbird
06:13:51 <-- wnayes has quit (Quit: wnayes)
06:14:06 <-- dewtwo has quit (Ping timeout)
06:23:11 --> dewtwo has joined #instantbird
06:32:49 <-- mayanktg has quit (Quit: http://www.mibbit.com ajax IRC Client)
06:38:36 <instant-buildbot> build #2000 of macosx-nightly-default is complete: Failure [4failed shell_3]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2000
06:40:44 --> mayanktg has joined #instantbird
06:46:34 <-- SCIF has left #instantbird ()
07:34:27 --> EionRobb has joined #instantbird
07:34:51 <-- mayanktg has quit (Quit: http://www.mibbit.com ajax IRC Client)
07:48:49 --> jb has joined #instantbird
07:53:59 --> stig has joined #instantbird
07:59:14 <-- mconley has quit (Input/output error)
08:11:49 <-- flo-retina has quit (Ping timeout)
08:12:19 --> flo-retina has joined #instantbird
08:12:19 * ChanServ sets mode +qo flo-retina flo-retina 
08:14:07 --> gerard-majax__ has joined #instantbird
08:14:32 <-- gerard-majax__ has quit (Client exited)
08:14:39 --> gerard-majax_ has joined #instantbird
08:22:50 --> mayanktg has joined #instantbird
08:23:24 --> nhnt11 has joined #instantbird
09:06:13 <-- jb has quit (Ping timeout)
09:35:04 --> Armada has joined #instantbird
09:47:57 --> panther7 has joined #instantbird
09:48:20 <panther7> .
09:48:29 <panther7> hi
09:48:49 <panther7> i have question, how i can change "resource" in jabber account?
09:50:40 --> aleth has joined #instantbird
09:50:40 * ChanServ sets mode +h aleth 
09:50:56 <nhnt11> panther7: In the Account manager, right click the account -> Properties -> Advanced Options
09:51:52 <panther7> i dont see any input like "resource" in account options
09:52:56 <nhnt11> Hmm. I see a field for Resource in the Advanced Options tab.
09:53:04 <nhnt11> What OS are you running?
09:53:12 <aleth> Is this a screen reader issue?
09:54:44 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:54:52 <panther7> Win 7 x64;
09:55:01 --> nhnt11 has joined #instantbird
09:55:12 <panther7> nhnt11: win7 +x64
09:55:14 <aleth> mayanktg: You are supposed to read the code and make sure it works as it should when no new user icon is passed as an argument ;)
10:00:19 <-- EionRobb has quit (Quit: Leaving.)
10:01:37 <panther7> nhnt11: look http://luna.mosner.net/public/jabber.png
10:02:53 <nhnt11> panther7: Here's what it looks like for me: http://puu.sh/70M8N.png
10:02:58 <nhnt11> panther7: What version of Instantbird are you using?
10:03:11 <panther7> latest
10:03:13 <panther7> 1.5
10:03:33 <nhnt11> aleth: Any idea about this? ^
10:04:25 <aleth> nhnt11: Maybe you are using JS-XMPP and he is not?
10:04:44 <panther7> aleth, nhnt11: how i can define it?
10:04:49 <nhnt11> Ahh
10:05:03 <aleth> nhnt11: Check first before we decide that's the reason
10:05:42 <nhnt11> aleth: I did. My chats.prpls.forcePurple is an empty string
10:06:02 <nhnt11> That's the only thing I need to check right?
10:06:45 <aleth> Yes. I guess the next thing to try is starting IB with a fresh profile to see what it looks like with libpurple
10:06:58 <nhnt11> I'm on it..
10:09:08 <nhnt11> panther7, aleth: So I don't see any resource setting in account options. However, there was a field for it while creating the account
10:09:28 <aleth> That's unfortunate - it probably means it's about.config only?
10:09:34 * nhnt11 wonders if there's some about:config twiddling to do it...
10:09:57 <aleth> Either that or panther7 gets to beta-test JS-XMPP ;)
10:10:12 <nhnt11> panther7: Are you willing to try out a little hack in about:config?
10:11:09 <nhnt11> If so, type "/about config" (without quotes obviously) in any conversation window. Then search for "account" and find your xmpp account. You'll see something like messenger.account.account4.name, set to blabla@jabber.org/Instantbird
10:11:14 <panther7> If it is not dangerous for my security  :)
10:11:23 <nhnt11> Change Instantbird to whatever you want
10:11:30 <nhnt11> That should do the trick I think
10:11:43 <nhnt11> aleth: Is it okay to modify the account name like that?
10:11:55 <aleth> nhnt11: Hmm, I'm not sure that's as safe as it looks
10:12:01 <nhnt11> Yeah I'm a bit weary
10:12:30 <nhnt11> panther7: So you might want to wait before doing that ;)
10:12:38 <aleth> It may lead to trouble with logs etc.
10:13:06 <aleth> panther7: How about creating a new XMPP account? 
10:13:13 <nhnt11> I was about to suggest that ^
10:13:25 <panther7> if i change "/Instantbird" to anything, etc "/Instantbird-test", then my account list is empty
10:13:44 <aleth> panther7: Don't change it, instead delete the account and make a new one,'
10:13:59 <nhnt11> panther7: That didn't happen to me, but yeah change it back to what it was for now
10:14:10 <nhnt11> Well if you're deleting the account it doesn't matter I guess..
10:14:38 <aleth> nhnt11: You can't delete it unless it shows up in the account manager ;)
10:14:49 <nhnt11> Uh
10:14:50 <nhnt11> oops
10:14:55 <aleth> nhnt11: btw, bug 953870
10:14:58 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=953870 enh, --, ---, nobody, NEW, Rename accounts (i.e. change the username)
10:15:38 <aleth> panther7: During the account creation process you should be able to specify the resource.
10:15:39 <panther7> aleth, nhnt11: new accoutn have same settings (noresource)
10:16:06 <nhnt11> panther7: There was a field in the wizard while creating it for me
10:16:29 <panther7> no in XMPP but Google talk have resource input
10:17:07 <nhnt11> That's because GTalk uses a JavaScript implementation of the protocol (which has different settings exposed)
10:17:43 <aleth> panther7: Do you use XMPP MUCs?
10:18:25 <panther7> I don't know, what is it
10:18:34 <aleth> multi-user chatroooms
10:18:54 <panther7> i never use it
10:19:05 <aleth> nhnt11: Do you have a screenshot of the libpurple account creation dialog?
10:19:41 --> EionRobb has joined #instantbird
10:19:46 <nhnt11> Here's the relevant screen: http://puu.sh/70MGp.png
10:20:11 <aleth> panther7: Does that help?
10:20:27 <aleth> I'm wondering if the l10n of "Resource" might be confusing.
10:21:24 <panther7> ohhhh, yeah, resource, i see... but in config i cant change... is shit create new accoutn for cahnge resource
10:22:13 <aleth> panther7: As you could see on the earlier screenshot, That problem will be gone when our new js-xmpp implementation becomes the default.
10:22:32 <aleth> panther7: If you really need to change the resource often you could turn it on and help beta-test it ;)
10:23:02 <panther7> no often, only once :)
10:23:07 <panther7> probalby
10:23:26 <-- panther7 has quit (Connection reset by peer)
10:23:47 --> panther7 has joined #instantbird
10:24:24 <panther7> lol... i did remove XMPP account and instantbird crashed
10:27:57 <aleth> Looks like changing that about:config setting wasn't a good idea ;)
10:28:35 <aleth> panther7: Does the new account work though?
10:30:39 --> BWMerlin has joined #instantbird
10:38:25 <-- stig has quit (Ping timeout)
10:38:30 --> stig has joined #instantbird
10:40:00 --> jb has joined #instantbird
10:46:08 <panther7> aleth: yeah, now works
10:48:01 <-- EionRobb has quit (Quit: Leaving.)
10:48:09 <instant-buildbot> build #1267 of win32-nightly-default is complete: Failure [4failed shell_3]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1267
11:02:03 <-- BWMerlin has quit (Ping timeout)
11:04:09 <-- aleth has quit (Ping timeout)
11:33:00 --> aleth has joined #instantbird
11:33:00 * ChanServ sets mode +h aleth 
11:34:37 --> BWMerlin has joined #instantbird
11:36:45 <-- Suiseiseki has quit (Connection reset by peer)
11:41:15 <-- GeekShadow has quit (Ping timeout)
11:41:28 --> GeekShadow has joined #instantbird
11:43:08 --> Suiseiseki has joined #instantbird
11:45:03 <-- nhnt11 has quit (Ping timeout)
11:48:24 <-- stig has quit (Ping timeout)
12:15:50 <-- BWMerlin has quit (Quit: BWMerlin)
12:33:24 --> clokep_work has joined #instantbird
12:41:30 <aleth> What's new in gecko 29 includes CSS variables
12:44:12 <clokep_work> flo-retina: Mic: Thunderbird should have the "Add exception" link in the account manager, I ported that.
12:55:58 <-- jb has quit (Ping timeout)
13:04:43 <flo-retina> clokep_work: ok
13:07:28 --> deOmega has joined #instantbird
13:08:46 <clokep_work> nhnt11, aleth: I wouldn't really suggest to random people to try JS-XMPP. :-\
13:09:01 <clokep_work> Changing the resource requires a new accoutn as you guys figured out...
13:09:17 <aleth> That's why I didn't suggest it other than with major caveats ;)
13:10:49 --> jb has joined #instantbird
13:11:33 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:14:34 <clokep_work> flo-retina: Looks like you made some progress with libpurple? :)
13:14:39 <clokep_work> I should probably catch up on bugmail...
13:32:45 --> aleth1 has joined #instantbird
13:32:56 <-- aleth1 has quit (Input/output error)
14:07:58 <-- aleth has quit (Ping timeout)
14:10:09 --> aleth has joined #instantbird
14:10:09 * ChanServ sets mode +h aleth 
14:16:26 <aleth> clokep_work: With your libpurple patches applied and enable-extensions=purple set, did MOZ_EXTENSIONS get set properly for you? For me, moz.build in mozilla/extensions/purple only gets parsed if I explicitly add_tier it
14:20:40 <clokep_work> aleth: Did you try mach configure?
14:21:41 <aleth> No. Doesn't mach build notice the mozconfig has changed? It seemed to
14:22:00 <clokep_work> I don't know.
14:26:27 <aleth> Aha! You're right. That did the trick.
14:27:18 <aleth> Thanks :) I wasted a fair bit of time trying to figure out why it wasn't working...
14:28:04 --> mconley has joined #instantbird
14:30:49 <clokep_work> Sorry. :-\
14:31:34 <aleth> No need for /you/ to apologize ;) I'm just surprised mach build picks up on some changes in mozconfig but not others.
14:31:58 <clokep_work> I just always run configure manually when messing with this stuff.
14:32:10 <aleth> Clearly a wise habit :D
14:38:40 <clokep_work> That remove buddy icon patch is pretty simple, actually.
14:38:54 <aleth> Yes, good first bug! ;)
14:39:38 <aleth> Touches various parts of the codebase without being difficult.
14:43:57 <mayanktg> aleth: Yes, it started with blist and 'm looking into yahoo-session :P
14:44:51 <mayanktg> off the tpoic: we had TEDx today! http://tedxjecollege.com/
14:46:25 <aleth> Did you hear anything interesting?
14:46:26 --> stig has joined #instantbird
14:47:11 <mayanktg> We were in the organizing team :)
14:48:39 <mayanktg> Yes indeed. Madhu Yadav was the captain of Indian Women Hockey team (Hockey being the National sport of India). She explained how it is being neglected.
14:49:15 <mayanktg> Then Mame Khan ..Sufi singer was amazing!!
14:49:43 <mayanktg> http://tedxjecollege.com/speakers
14:49:57 <clokep_work> "Hockey" being field hockey, right?
14:50:13 <mayanktg> yes.
14:50:13 <clokep_work> mayanktg: Yeah, we'll probably want to put a patch that fixes Yahoo in the same bug.
14:50:50 <aleth> mayanktg: Sounds like a good day :)
14:51:06 <mayanktg> clokep_work: I'm going through the code, but unable to understand how it should be implemented
14:51:39 <aleth> qheaden is the person to ask :)
14:51:42 <mayanktg> clokep_work: I built the site :D
14:52:01 <clokep_work> mayanktg: What code is this? (Link me? :P)
14:52:10 <mayanktg> ok :)
14:52:23 <mayanktg> http://mxr.mozilla.org/comm-central/source/chat/protocols/yahoo/yahoo-session.jsm#312
14:53:11 <aleth> Nice site.
14:54:05 <aleth> mayanktg, clokep_work: The question is whether Yahoo has a way to remove the previously uploaded icon without uploading a new one.
14:54:17 <mayanktg> we wanted it to be plain and simple :) Thanks.
14:55:25 <mayanktg> aleth: then we have to verify that using yahoo messenger?
14:55:51 <aleth> mayanktg: First you have to find out what the protocol expects/allows you to do.
14:56:41 <aleth> A first step (which you've probably already done) is to look at http://mxr.mozilla.org/comm-central/source/chat/protocols/yahoo/yahoo-session.jsm#1071 to see if it mentions icon removal in any way
14:57:04 <aleth> qheaden wrote this code, which is why I mentioned him.
14:57:05 <mayanktg> aleth: ok.
14:58:25 <clokep_work> Haha... http://lxr.instantbird.org/instantbird/source/purple/libpurple/protocols/yahoo/yahoo_picture.c#542
14:58:57 <aleth> :D
15:06:05 --> flo-retina has joined #instantbird
15:06:05 * ChanServ sets mode +qo flo-retina flo-retina 
15:28:56 <-- panther7 has quit (Ping timeout)
15:31:08 <-- flo-retina has quit (Ping timeout)
15:33:45 <-- jb has quit (Quit: jb)
15:34:18 --> jb has joined #instantbird
15:34:24 --> flo-retina has joined #instantbird
15:34:24 * ChanServ sets mode +qo flo-retina flo-retina 
15:37:41 <clokep_work> http://tools.ietf.org/html/draft-hartmann-default-port-for-irc-via-tls-ssl-09 updated a few weeks ago. ;)
15:40:16 <flo-retina> clokep_work: "<clokep_work> flo-retina: Looks like you made some progress with libpurple? :)" I have figured out the part about building dynamic prpls.
15:40:34 <flo-retina> We still need to figure out the static prpls, which needs to happen after we figure out the configure stuff.
15:40:46 <clokep_work> flo-retina: Awesome! :) How bad was it? Did I miss a patch going up?
15:40:57 <flo-retina> I expect the packaging part to be trivial once the configure stuff is handled (we'll basically just need to add an ifdef in the package-manifest)
15:41:06 <flo-retina> clokep_work: I didn't upload any patch
15:41:17 <flo-retina> clokep_work: I guess I can pastebin to show you what I tinkered with
15:41:43 <clokep_work> I agree it shouldn't be that bad.
15:42:31 <flo-retina> clokep_work: http://pastebin.instantbird.com/598100
15:43:27 <flo-retina> so the trick is mostly to remove the dynamic prpls from PARALLEL_DIRS of libpurple/moz.build, and add them to the parallel dir of purplexpcom/src/moz.build
15:43:43 <flo-retina> then remove all the previous workaround we had before (the stuff involving the PURPLEXPCOM environment variable)
15:44:49 <flo-retina> it actually looks very simple once it's in the pastebin ;)
15:45:44 <flo-retina> it wasn't easy as long as I kept trying to fix the stuff we had before, and the aha moment was when instead of fixing the existing stuff, I started wondering which behavior I wanted, and what was the simplest way to get it.
15:46:13 <flo-retina> also, when I read that PARALLEL_DIRS could take relative paths, including .. :)
15:47:38 <clokep_work> flo-retina: Ah, that doesn't sound bad at all, you're right. :)
15:49:12 <aleth> It's actually simpler from what it was before :)
15:49:18 <flo-retina> aleth: it is!
15:50:05 --> panther7 has joined #instantbird
15:51:25 <aleth> What's the difference between DIRS and PARALLEL_DIRS ?
15:52:45 <-- Armada has quit (Quit: Leaving)
15:53:05 <flo-retina> aleth: PARALLEL_DIRS are compiled in parallel. With DIRS, each folder is built only when the previous one in the list is finished.
15:53:39 <aleth> Ah, so just a perfomance difference.
15:53:42 <aleth> Thanks.
15:54:11 <flo-retina> aleth: also order difference. DIRS is deterministic.
15:54:33 <flo-retina> it may also be that DIRS is built before the source files in the current folder, and PARALLEL_DIRS after. I'm not sure.
16:06:21 <flo-retina> is the patch in bug 817596 looking good?
16:06:24 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=817596 nor, --, ---, clokep, ASSI, Unable to parse nonce values from "jabber.ubuntu-fr.org"
16:06:28 <flo-retina> I don't really remember :-/
16:14:44 <clokep_work> flo-retina: Which is the "current"? :P
16:15:06 <clokep_work> I don't remember what that other guy's patch changes.
16:15:20 <flo-retina> I see scary regexps in that patch
16:15:42 <flo-retina> it looks like I would need to concentrate on them for a while to guess what the do/claim they are wrong ;)
16:16:27 <-- stig has quit (Ping timeout)
16:18:15 --> stig has joined #instantbird
16:25:25 <-- aleth has quit (Ping timeout)
16:30:27 --> aleth has joined #instantbird
16:30:27 * ChanServ sets mode +h aleth 
16:36:21 <-- gerard-majax_ has quit (Ping timeout)
16:40:23 <-- aleth has quit (Ping timeout)
16:42:15 --> aleth has joined #instantbird
16:42:15 * ChanServ sets mode +h aleth 
16:58:01 <clokep_work> Aren't all regexps scary? ;)
17:08:19 <-- jb has quit (Ping timeout)
17:44:56 <-- mayanktg has quit (Quit: http://www.mibbit.com ajax IRC Client)
17:48:35 <flo-retina> merging {mail,im}/app/Makefile.in is more difficult than it seemed
17:48:55 --> mayanktg has joined #instantbird
18:03:40 <-- aleth has quit (Ping timeout)
18:04:20 --> unghost has joined #instantbird
18:23:36 <clokep_work> :-\
18:23:42 <clokep_work> Not fully surprising.
18:26:27 --> Mook_as has joined #instantbird
18:34:09 <-- stig has quit (Ping timeout)
19:02:54 <-- mayanktg has quit (Quit: http://www.mibbit.com ajax IRC Client)
19:04:36 --> nhnt11 has joined #instantbird
19:05:27 <-- nhnt11 has quit (Connection reset by peer)
19:13:07 --> nhnt11 has joined #instantbird
19:14:49 <-- nhnt11 has quit (Connection reset by peer)
19:15:45 --> EionRobb has joined #instantbird
19:18:48 --> nhnt11 has joined #instantbird
19:19:38 <-- nhnt11 has quit (Connection reset by peer)
19:21:23 --> nhnt11 has joined #instantbird
19:24:02 <-- deOmega has quit (Ping timeout)
19:24:02 <-- nhnt11 has quit (Connection reset by peer)
19:24:57 --> nhnt11 has joined #instantbird
19:47:10 <flo-retina> clokep_work: I'll r? you soon on the patch in bug 973385
19:47:12 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=973385 blo, --, ---, nobody, NEW, Instantbird doesn't build on Linux
19:47:45 <flo-retina> clokep_work: I want to do a little more testing of it; and check again a diff between {mail,im}/app/Makefile.in after applying the patch, to see if I can get these 2 even closer 'easily' :)
19:47:59 <flo-retina> the changes in Makefile.in have been applied by hand
19:48:20 <flo-retina> but now that the order of things mostly match, using a merge tool may give satisfying results (it didn't when I tried 2 hours ago).
19:50:35 --> deOmega has joined #instantbird
19:55:54 <-- Tonnes has quit (Connection reset by peer)
19:59:14 <-- mconley has quit (Connection reset by peer)
19:59:39 --> mconley has joined #instantbird
20:03:30 * clokep_work hopes he's not expected to review that one. ;)
20:08:38 <-- jamesw has quit (Client exited)
20:13:50 --> Tonnes has joined #instantbird
20:15:45 <-- micahg has quit (Ping timeout)
20:41:11 <-- nhnt11 has quit (Ping timeout)
20:52:37 <-- deOmega has quit (Quit: So easy...but yet complicated.)
21:31:55 <-- unghost has quit (Input/output error)
21:37:14 --> micahg has joined #instantbird
21:49:43 <flo-retina> clokep_work: you are!
21:51:44 * clokep_work cries. :'(
21:51:52 <clokep_work> flo-retina: I'll try it on WIndows when I'm home.
21:52:13 <flo-retina> well, you can just rs, it's an almost straight port
21:52:23 <flo-retina> the .cpp file is just a cp of the Tb file
21:52:34 <flo-retina> and the Makefile is a mostly manual port, but I'll diff with the mail/ file
21:52:39 <flo-retina> so we should see what the differences are
21:53:19 <clokep_work> OK. :)
21:53:24 <clokep_work> Just set r? on it whenever you're ready.
21:53:42 <flo-retina> I want to test on Mac
21:53:45 <flo-retina> and look at the diff
21:53:59 <flo-retina> I think I haven't handled the cases for using a xul sdk correctly (or at all)
21:57:35 <clokep_work> :-\
21:57:37 <flo-retina> clokep_work: ok, the all the build system logic related to icons is a bit messed up
21:57:41 <clokep_work> I don't think that's a case I'll be able to check.
21:57:42 <flo-retina> I purposefully didn't touch it
21:57:59 <clokep_work> What's that mean?
22:00:10 <clokep_work> (How are they "messed up"?)
22:01:05 <flo-retina> well, the Makefile rules are very far from what Tb does
22:01:14 <flo-retina> and I'm pretty sure what Tb does is better
22:01:30 <flo-retina> but I don't think attempting to fix that in the same changeset is a good idea
22:03:11 <clokep_work> OK. But it "works"?
22:04:18 <flo-retina> it's not more broken than the stuff in hg.ib.org :)
22:08:27 --> hadi has joined #instantbird
22:17:28 <clokep_work> OK, well. In that case r+! :P
22:19:09 <flo-retina> clokep_work: for your reviewing pleasure: http://pastebin.instantbird.com/598486 (this is |diff -U 8 {mail,im}/app/Makefile.in|)
22:20:11 <clokep_work> flo-retina: Do you have some line ending differences? :-S
22:20:43 <flo-retina> the icon mess I was talking about is the stuff between line 145 and 225 in the pastebin
22:20:53 <flo-retina> clokep_work: no, but there are 2 lines in the Tb file that have trailing whitespace
22:21:09 <flo-retina> (12 and 128 in the pastebin)
22:21:52 <-- mconley has quit (Input/output error)
22:22:03 <flo-retina> I think we'll want to file another bug to get rid of splash.bmp (it's a remnant of WinCE that we forgot to remove)
22:22:15 <flo-retina> and another bug to take care of cleaning up the situation with icons
22:22:24 <clokep_work> flo-retina: OK. Those changes all look not insane.
22:37:36 <flo-retina> alright, it's on the bug for your reviewing pleasure ;)
22:41:53 <clokep_work> flo-retina: So that ran on Mac?
22:41:58 <flo-retina> yes
22:42:44 <flo-retina> and I've just checked that the new version of the patch produces a version that "works" (minus libpurple of course) on Linux
22:47:33 <flo-retina> clokep_work: are you going to push it on my behalf after testing on Windows? :)
22:47:55 <clokep_work> flo-retina: I can do that or just mark it checkin-needed?
22:48:07 <clokep_work> Does the patch have your name in the right encoding? :P
22:48:15 <clokep_work> (I.e. does it have header information.)
22:49:21 * clokep_work goes home.
22:54:23 <-- clokep_work has quit (Ping timeout)
23:07:42 --> mconley has joined #instantbird
23:11:59 --> jb has joined #instantbird
23:18:01 <flo-retina> clokep_work: the patch is just an hg diff, it doesn't have changeset info
23:37:56 --> wnayes has joined #instantbird
23:50:31 --> clokep has joined #instantbird
23:50:31 * ChanServ sets mode +o clokep 
23:56:22 <-- jb has quit (Ping timeout)