#instantbird log on 02 17 2014

All times are UTC.

00:01:56 --> SCIF has joined #instantbird
00:05:48 <instantbot> New Instantbird - Other bug 973385 filed by benediktp@ymail.com.
00:05:50 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=973385 blo, --, ---, nobody, NEW, Instantbird doesn't build on Linux
00:05:53 --> mayanktg has joined #instantbird
00:06:14 <-- Tonnes has quit (Quit: ChatZilla [Firefox 12.0/20120420145725])
00:06:34 --> Tonnes_ has joined #instantbird
00:06:52 * Tonnes_ is now known as Tonnes
01:02:39 <-- kramolnik has quit (Ping timeout)
01:09:57 <-- mayanktg has quit (Quit: http://www.mibbit.com ajax IRC Client)
02:20:18 --> mconley has joined #instantbird
02:34:00 <-- mconley has quit (Quit: Leaving...)
02:44:01 --> mconley has joined #instantbird
03:00:12 <-- mconley has quit (Input/output error)
03:01:11 <-- SCIF has quit (Ping timeout)
03:05:02 --> SCIF has joined #instantbird
03:25:09 --> mconley has joined #instantbird
04:01:48 --> stig has joined #instantbird
04:42:18 <-- EionRobb has quit (Quit: Leaving.)
04:55:37 <-- stig has quit (Ping timeout)
05:20:56 --> mayanktg has joined #instantbird
05:27:55 <-- mayanktg has quit (Quit: http://www.mibbit.com ajax IRC Client)
05:33:09 <-- mconley has quit (Input/output error)
05:40:36 --> mayanktg has joined #instantbird
05:41:01 <-- mayanktg has quit (Quit: http://www.mibbit.com ajax IRC Client)
05:41:19 --> mayanktg has joined #instantbird
05:46:40 <-- mayanktg has quit (Quit: http://www.mibbit.com ajax IRC Client)
05:54:00 --> EionRobb has joined #instantbird
05:54:37 <-- wnayes has quit (Quit: wnayes)
05:55:33 --> mayanktg has joined #instantbird
06:33:41 --> mconley has joined #instantbird
06:38:54 <-- mconley has quit (Ping timeout)
06:40:59 --> kramolnik has joined #instantbird
07:16:20 <-- mayanktg has quit (Quit: http://www.mibbit.com ajax IRC Client)
07:44:23 --> mayanktg has joined #instantbird
07:45:55 <instant-buildbot> build #1265 of win32-nightly-default is complete: Failure [4failed shell_3]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1265
07:54:52 <-- mayanktg has quit (Quit: http://www.mibbit.com ajax IRC Client)
07:56:34 --> stig has joined #instantbird
08:04:33 <-- SCIF has quit (Quit: Good bye)
08:19:07 --> gerard-majax_ has joined #instantbird
08:57:46 --> nhnt11 has joined #instantbird
09:03:38 <-- nhnt11 has quit (Ping timeout)
09:07:37 <-- kramolnik has quit (Ping timeout)
09:39:41 <-- EionRobb has quit (Quit: Leaving.)
09:58:24 --> BWMerlin has joined #instantbird
10:21:51 --> chrisccoulson has joined #instantbird
10:29:50 --> FireFly_TB has joined #instantbird
10:53:48 --> jb has joined #instantbird
11:03:37 <-- FireFly_TB has quit (Ping timeout)
11:04:29 --> FireFly_TB has joined #instantbird
11:12:18 --> Armada has joined #instantbird
11:32:31 --> aleth has joined #instantbird
11:32:31 * ChanServ sets mode +h aleth 
11:57:13 <-- aleth has quit (Quit: exit stage left)
11:57:16 --> aleth has joined #instantbird
11:57:16 * ChanServ sets mode +h aleth 
11:59:15 <-- FireFly_TB has quit (Input/output error)
12:08:13 --> Galebourn has joined #instantbird
12:08:43 --> mayanktg has joined #instantbird
12:09:01 <mayanktg> aleth: there?
12:09:09 <aleth> Yes
12:10:05 <mayanktg> aleth: I'm having problems solving that bug.. how to get the filename of the file of the buddyicon currently used?
12:10:23 <aleth> How does setUserIcon get it?
12:10:46 <mayanktg> yes...
12:12:02 <mayanktg> there's a getUserIcon too
12:12:06 <aleth> This seems to contain all the pieces you need https://mxr.mozilla.org/comm-central/source/chat/components/src/imCore.js#168
12:12:33 <mayanktg> Yes, I did find it
12:12:58 <aleth> There's code in that function that removes the old file.
12:13:24 <mayanktg> This explains how the filename is to named and then remove the old one.
12:14:43 <mayanktg> shall i create a seperate function "removeUserIcon" to complete the rest of the task or edit the same one?
12:15:56 <flo-retina> mayanktg: which part of the task isn't completed by the current function?
12:16:26 <aleth> mayanktg: I am confused by "rest of"
12:16:46 <aleth> Either you add a new function to the API or you change the definition of setUserIcon to include removal
12:17:07 <mayanktg> aleth: by rest of I mean .. getting the current file name and then removing it 
12:17:21 <mayanktg> aleth: ok
12:17:37 <aleth> Adding a new function is probably cleaner.
12:19:24 <mayanktg> flo-retina: the setUserIcon replaces the old buddy icon with the new one. when adding a remove icon feature I was asking whter I should create a separate function of modify setuserIcon 
12:19:44 <mayanktg> aleth: yes..
12:20:51 <mayanktg> *or
12:20:52 <aleth> mayanktg: You will have to add the function to the idl file and then change the uuid in that file (because the interface was changed)
12:21:41 <flo-retina> mayanktg, aleth: it looks to me like setUserIcon(null) removes the existing icon. Doesn't it?
12:23:16 <aleth> flo-retina: It may do so "by accident", but if we intend that to be supported we should change the description in the idl. That's what I meant above (the alternative to a new function is to declare the setUserIcon parameter optional)
12:23:46 <flo-retina> aleth: I don't think it's an accident
12:23:54 <flo-retina> maybe the doc isn't good enough
12:23:55 <mayanktg> flo-retina: I have to check that.
12:24:29 <aleth> flo-retina: If it's not an accident, then these should all be able to handle icon removal: https://mxr.mozilla.org/comm-central/search?string=user-icon-changed
12:24:31 <flo-retina> the only reason for the if at https://mxr.mozilla.org/comm-central/source/chat/components/src/imCore.js#172 is to support removing the icon
12:24:37 <-- jb has quit (Ping timeout)
12:24:52 <aleth> But you should know since you wrote it ;)
12:25:14 <-- BWMerlin has quit (Quit: BWMerlin)
12:26:10 <flo-retina> aleth: we could make aIconFile optional indeed. I was expecting the value to be _null_ when unsetting the icon
12:26:12 <aleth> And indeed it looks like it's supported here https://mxr.mozilla.org/comm-central/source/im/content/blist.js#360
12:26:35 <aleth> Not sure about the prpls though.
12:27:07 <mayanktg> aleth: i guess the idl file is used only to fire notification that the icon has been chaneged , But to make it link with the xul we have to do it in blist.js
12:27:11 <flo-retina> aleth: all the code in your mxr query seems to handle icon removal just fine
12:27:24 <mayanktg> aleth: yes yes yes 
12:28:24 <flo-retina> I take that back. http://mxr.mozilla.org/comm-central/source/chat/protocols/yahoo/yahoo-session.jsm#312 needs a null check.
12:28:33 <flo-retina> xmpp handles it fine.
12:28:39 <aleth> mayanktg: The idl file defines the interface of the xpcom component. I.e. it determines how and if setUserIcon can be called.
12:29:12 <aleth> OK, so I think adding an "optional" and improving the comment is the way to go.
12:30:08 <mayanktg> aleth: okk
12:30:12 <flo-retina> "nsIFileURL getUserIcon();" also desperately needs a comment about what it returns
12:30:16 <aleth> flo-retina: The mxr query is also missing prplxpcom (obviously)
12:30:29 <flo-retina> ah
12:31:15 <flo-retina> aleth: I'm not so sure about the 'optional' actually. Which of "setUserIcon(null)" and "setUserIcon()" makes you think the most of a removal?
12:32:13 <flo-retina> aleth: I think these {g,s}etUserIcon methods were supposed to act like getters/setters, and I was frustrated by having 2 different types, and had to write 2 real methods instead of an attribute
12:32:44 <aleth> Ah, thinking of it as a setter, the optional makes no sense.
12:33:49 <flo-retina> aleth: "flo-retina: The mxr query is also missing prplxpcom (obviously)" hmm?
12:33:53 <aleth> I'd be OK with requiring the "null" argument, as long as the comments get improved :)
12:34:23 <flo-retina> http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleAccount.cpp#895
12:34:24 <aleth> flo-retina: http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleAccount.cpp#895
12:34:36 <flo-retina> aleth: sure, the comment needs improvements
12:35:02 <aleth> I'm pretty sure qheaden would have implemented icon removal if he had known it was required ;)
12:37:08 <aleth> mayanktg: So it seems you don't have much to do there :)
12:37:24 <mayanktg> flo-retina, aleth: yupp
12:37:45 <mayanktg> So i simply have to use setuserIcon(null) ? 
12:38:02 <mayanktg> or something else :-o
12:38:05 <aleth> Yes, and make sure that that works for all prpls (e.g. yahoo as above).
12:38:23 <mayanktg> Ok!
12:38:26 <aleth> prpl = protocol plugin
12:39:30 <mayanktg> aleth: ok. Let me try it then :)
12:41:37 <flo-retina> that comment is outdated: http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleAccount.cpp#966
12:41:52 <flo-retina> but removing an icon is indeed supported: http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleAccount.cpp#1005
12:41:59 <-- Gizmokid2005 has quit (Quit: ZNC - http://znc.sourceforge.net)
12:42:41 <-- stig has quit (Ping timeout)
12:43:37 --> Gizmokid2005 has joined #instantbird
12:46:39 <mayanktg> aleth, flo-retina: its working!!!
12:47:12 <mayanktg> aleth: let me check it also for the prpls
12:47:13 <mayanktg> :)
12:51:38 <mayanktg> http://pastebin.instantbird.com/596515
12:52:16 --> jb has joined #instantbird
12:52:45 <mayanktg> http://pastebin.instantbird.com/596516
12:53:32 <aleth> mayanktg: If you think it is ready, you can attach it as a patch to the bug and request review or feedback
12:54:41 <aleth> Please don't add another popupset to blist.xul - it already has one. Move your menupopup there.
12:54:42 <mayanktg> aleth: I'm checking for the prpls and then I will attach it as a patch
12:55:15 <mayanktg> aleth: ok
12:56:10 <mayanktg> to the statusTypeIcon onlu\y?
12:57:28 <flo-retina> I would prefer if the pastebins were colored as diffs ;)
13:00:11 --> stig has joined #instantbird
13:12:07 <aleth> mayanktg: The patch should also include the comment improvements we discussed earlier
13:12:20 <mayanktg> :)
13:13:26 <mayanktg> and one more thing...where should I place the menuitem now? 
13:14:09 <aleth> What menuitem?
13:15:54 <mayanktg> aleth: you said to remove the popupset
13:16:14 <aleth> If you mean the children of the menupopup, those should stay in the menupopup of course.
13:19:59 <mayanktg> and what about popupset .. am not getting it what you are trying to say :-/
13:20:13 <mayanktg> sorry :(
13:24:18 <aleth> There is already a popupset XUL element in blist.xul
13:24:46 <aleth> Move your menupopup element there. When I say move the menupopup element, I mean move the entire menupopup block including the menuitem children.
13:25:16 <mayanktg> ok :)
13:25:54 <aleth> Here is the popupset https://mxr.mozilla.org/comm-central/source/im/content/blist.xul#47
13:26:35 <aleth> I think I already linked for you the mdn article on how this stuff works.
13:26:54 <mayanktg> got it
13:26:56 <mayanktg> done :)
13:27:33 <mayanktg> I got confused with popupset.. I didn't notice the one already present there. 
13:28:11 <mayanktg> yes i read that :)
13:30:11 <-- Galebourn has quit (Quit: Leaving)
13:43:11 <flo-retina> aleth: bug 930517 bug 930520
13:43:14 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=930517 enh, --, ---, nobody, NEW, Add a scriptable way to know how much time was spent outside of the event loop
13:43:15 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=930520 enh, --, ---, nobody, NEW, Offer a promise helping execute tasks on the main thread without causing UI jank
13:43:52 <aleth> Thanks!
13:44:21 <flo-retina> aleth: bug 928893
13:44:23 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=928893 nor, --, ---, nobody, NEW, Provide an API for processing DOM trees without blocking the main thread
13:44:30 <flo-retina> that's all we discussed during the Summit
13:47:13 <-- aleth has quit (Ping timeout)
13:47:22 --> aleth has joined #instantbird
13:47:22 * ChanServ sets mode +h aleth 
13:58:44 <mayanktg> flo-retina: was the build problem solved? I'm still having the same problem :(
13:59:02 <flo-retina> sounds like the answer is in your question
13:59:36 <flo-retina> I didn't have time to look at it. I'm not feeling very well today, and I'm spending more time than I would reall
13:59:40 <flo-retina> y like in bed.
13:59:41 <aleth> jcranmer may have a fix for it, but I'm not sure where.
13:59:53 <flo-retina> aleth: it's a couple bugs we need to port
14:03:05 <mayanktg> flo-retina: ohh..
14:03:15 <mayanktg> have rest then
14:03:34 <flo-retina> aleth: bug 668869
14:03:36 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=668869 nor, --, Thunderbird 13.0, mbanner, RESO FIXED, port ffox work to lazily load libxul to speed up start-up perf and remove wrapper startup script
14:04:15 <aleth> Cool, maybe Mic will do that.
14:04:41 <flo-retina> aleth: maybe :)
14:04:59 <flo-retina> aleth: given how old the patches are, I don't think any of them will apply, so it will likely require understanding the changes to reproduce them
14:07:04 <flo-retina> aleth: it may actually be easier to compare the current mail/app/Makefile.in and mail/app/nsMailApp.cpp files with the equivalents in im/
14:07:08 <flo-retina> and just merge/sync them.
14:09:50 <aleth> That may be the better way to go anyway
14:17:12 * aleth tried to get configure.in in mozilla/extensions/purple to be noticed
14:18:14 <aleth> flo-retina: I'm confused that if I put junk in moz.build in that directory (that should cause a syntax error) it doesn't cause an error when building. That suggests to me that directory is never processed on mach build, but I don't see why that would be the case.
14:19:23 <aleth> Not that I expect to be able to fix the configure issue myself, but I did expect to learn something...
14:23:06 <flo-retina> do you have --enable-extensions=purple in your mozconfig?
14:24:28 <aleth> Yes
14:25:42 <flo-retina> I'm never completely sure about what happens to the moz.build files
14:26:04 <flo-retina> I wouldn't be fully surprised if parse errors there were just going to /dev/null
14:29:44 <aleth> No, mozbuild.frontend.reader throws (python syntax) errors.
14:34:13 <aleth> i.e. the same junk inserted in im/moz.build causes the build to fail early.
14:40:15 --> deOmega has joined #instantbird
15:00:54 <-- mayanktg has quit (Quit: http://www.mibbit.com ajax IRC Client)
15:07:20 <-- aleth has quit (Ping timeout)
15:10:55 --> aleth has joined #instantbird
15:10:55 * ChanServ sets mode +h aleth 
15:11:04 <-- aleth has quit (Input/output error)
15:11:44 --> aleth has joined #instantbird
15:11:44 * ChanServ sets mode +h aleth 
15:19:42 --> mayanktg has joined #instantbird
15:27:56 <aleth> Is it the expected behaviour that in a XMPP conversation where I am participating with two different resources, messages sent from the other resource are not displayed? (I wonder if we even receive them)
15:28:34 --> wnayes has joined #instantbird
15:28:50 <aleth> They certainly don't show up in the debug log...
15:31:39 <mayanktg> aleth: yes, like if you are having conversation using google hangouts, you won't receive notification in IB.
15:31:46 <mayanktg> correct?
15:32:47 <aleth> I wasn't talking about gtalk specifically (which may be a special case), but that's probably correct.
15:34:35 <mayanktg> I was just giving an example. I didn't try others. 
15:34:52 <mayanktg> Though presently I have no idea how to fix that up :-/
15:35:18 <aleth> It may be the way XMPP is /meant/ to work, hence my question ;)
15:45:13 <-- Armada has quit (Quit: Leaving)
16:11:42 <aleth> mayanktg: Thanks for tackling the user icon bug!
16:14:28 <mayanktg> aleth: hahaha..my first bug <3
16:14:49 <mayanktg> going for another one! :-)
16:16:43 <mayanktg> a lot is to be done in prev bug :( thanks for the comment :)
16:19:07 <-- jb has quit (Ping timeout)
16:33:09 --> jb has joined #instantbird
16:39:56 --> iamjayakumars has joined #instantbird
16:41:34 <-- gerard-majax_ has quit (Ping timeout)
16:43:28 --> aleth1 has joined #instantbird
16:44:25 <-- aleth1 has quit (Quit: Ciao)
16:47:07 <-- deOmega has quit (Quit: So easy...but yet complicated.)
16:49:20 <flo-retina> aleth: it's normal that by default you don't receive the messages you sent from other resources
16:49:59 <-- stig has quit (Ping timeout)
16:50:07 <flo-retina> I think there's a XEP to provide that feature, so some servers may implement it.
16:51:13 --> stig has joined #instantbird
16:51:15 <flo-retina> aleth: and I wonder if facebook chat doesn't have something custom they send to support that.
17:17:29 --> gerard-majax__ has joined #instantbird
17:21:12 <-- gerard-majax__ has quit (Ping timeout)
17:24:15 <aleth> flo-retina: Re the earlier issue, for some reason MOZ_EXTENSIONS is not set when app.mozbuild is read.
17:26:04 <aleth> Maybe because that happens in mozilla/configure.in (not sure about the sequencing)
17:32:08 <flo-retina> aleth: that's strange
17:32:21 <flo-retina> libpurple gets built for me
17:34:26 <aleth> If I remove the if CONFIG... clause and add extensions/purple to add_tier_dir, it actually looks at the moz.build in that folder.
17:35:43 <-- jb has quit (Ping timeout)
17:42:17 <-- iamjayakumars has quit (Quit: )
17:57:58 --> Mook_as has joined #instantbird
17:59:15 --> gerard-majax__ has joined #instantbird
18:01:49 --> nhnt11 has joined #instantbird
18:03:29 <-- nhnt11 has quit (Ping timeout)
18:04:05 --> nhnt11 has joined #instantbird
18:09:58 <nhnt11> Good evening
18:16:42 <-- gerard-majax__ has quit (Ping timeout)
18:17:06 <-- aleth has quit (Ping timeout)
18:23:24 --> mconley has joined #instantbird
18:29:41 <-- mconley has quit (Ping timeout)
18:30:24 --> aleth has joined #instantbird
18:30:24 * ChanServ sets mode +h aleth 
18:33:37 <-- mayanktg has quit (Quit: http://www.mibbit.com ajax IRC Client)
18:49:00 <Mook_as> Hm, why is dbus disabled in the official builds? (Not that I particularly care about it; it was just non-obvious and caused my build to fail packaging, since it's listed in removed-files.in)
18:59:05 <flo-retina> Mook_as: I think because dbus isn't installed on our build slave
19:05:57 <-- nhnt11 has quit (Ping timeout)
19:08:28 --> nhnt11 has joined #instantbird
19:16:43 <-- aleth has quit (Ping timeout)
19:20:37 <-- stig has quit (Ping timeout)
19:21:05 <-- nhnt11 has quit (Ping timeout)
19:32:41 --> EionRobb has joined #instantbird
19:35:54 --> gerard-majax__ has joined #instantbird
20:01:13 --> Mic has joined #instantbird
20:01:35 <Mic> Hola
20:07:05 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
20:08:19 --> chrisccoulson has joined #instantbird
20:49:17 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
21:27:54 --> nhnt11 has joined #instantbird
21:28:05 <-- gerard-majax__ has quit (Ping timeout)
21:30:31 --> gerard-majax__ has joined #instantbird
21:34:52 <-- gerard-majax__ has quit (Ping timeout)
21:43:59 --> jb has joined #instantbird
22:23:31 --> Mic has joined #instantbird
22:50:08 <-- nhnt11 has quit (Ping timeout)
23:05:59 <-- Even has quit (Ping timeout)
23:06:07 <-- jb has quit (Ping timeout)
23:18:20 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
23:58:00 --> SCIF has joined #instantbird