#instantbird log on 01 23 2014

All times are UTC.

00:14:32 <-- FireFly_TB has quit (Ping timeout)
00:33:35 <clokep> flo-retina: Yeah good catch, I missed the renames. :-\
02:00:01 <-- Mook_as has quit (Quit: Mook_as)
02:33:23 <-- GeekShadow has quit (Ping timeout)
02:33:25 --> GeekShadow has joined #instantbird
02:59:17 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
03:01:27 <-- deOmega has quit (Quit: So easy...but yet complicated.)
03:01:34 --> deOmega has joined #instantbird
03:05:22 --> Mook has joined #instantbird
03:16:09 <-- deOmega has quit (Quit: So easy...but yet complicated.)
03:39:25 --> FireFly_TB has joined #instantbird
04:16:04 --> mconley has joined #instantbird
04:28:09 <-- mconley has quit (Input/output error)
04:32:54 <-- EionRobb has quit (Quit: Leaving.)
04:44:03 <-- wnayes has quit (Quit: wnayes)
05:00:54 <-- FireFly_TB has quit (Ping timeout)
05:14:21 --> mconley has joined #instantbird
05:19:35 --> gerard-majax has joined #instantbird
05:21:04 <-- mconley has quit (Input/output error)
05:45:36 <-- Mook has quit (Quit: Mook)
05:50:06 <-- gerard-majax has quit (Ping timeout)
06:03:44 --> EionRobb has joined #instantbird
06:28:08 <-- GeKo has quit (Ping timeout)
06:32:38 --> GeKo has joined #instantbird
06:55:36 --> gerard-majax has joined #instantbird
07:05:21 <-- gerard-majax has quit (Ping timeout)
07:09:36 --> hadi has joined #instantbird
07:11:03 <hadi> Hey, i'm about to go on a short trip... i'm taking my laptop with me, is there a way that i could export my instantbird settings and channels from my pc to my laptop?
07:21:01 --> gerard-majax has joined #instantbird
07:24:50 <-- hadi has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
07:25:55 <-- gerard-majax has quit (Ping timeout)
07:35:28 <instant-buildbot> build #1739 of macosx-nightly-default is complete: Failure [4failed shell_3]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/1739
07:42:00 <instant-buildbot> build #1240 of win32-nightly-default is complete: Failure [4failed shell_3]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1240
08:13:57 --> gerard-majax has joined #instantbird
08:25:35 <-- EionRobb has quit (Quit: Leaving.)
10:18:39 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:20:49 --> aleth has joined #instantbird
10:20:49 * ChanServ sets mode +h aleth 
10:29:15 --> BWMerlin has joined #instantbird
10:43:45 --> flo-retina has joined #instantbird
10:43:46 * ChanServ sets mode +qo flo-retina flo-retina 
11:00:52 <-- aleth has quit (Ping timeout)
11:27:30 --> clokep has joined #instantbird
11:27:30 * ChanServ sets mode +o clokep 
11:30:37 <flo-retina> looks like our script left some flags on https://bugzilla.mozilla.org/show_bug.cgi?id=955515 that don't exist on https://bugzilla.instantbird.org/show_bug.cgi?id=2078
11:30:41 <instantbot> Bug 955515 nor, --, 1.5, nhnt11, RESO FIXED, Home/End in newtab filterbox don't work as expected
11:31:06 <flo-retina> apparently aleth touched 3 flags at once. I guess our script didn't like that
11:31:28 --> aleth has joined #instantbird
11:31:28 * ChanServ sets mode +h aleth 
11:35:46 <-- flo-retina has quit (Ping timeout)
11:36:55 --> flo-retina has joined #instantbird
11:36:56 * ChanServ sets mode +qo flo-retina flo-retina 
11:37:49 <aleth> hadi: yes
11:38:03 <aleth> ah, he's gone
11:38:14 <flo-retina> aleth: what's the status of https://bugzilla.mozilla.org/show_bug.cgi?id=954979 ?
11:38:17 <instantbot> Bug 954979 nor, --, ---, nobody, NEW, Check for open conversations when adding a buddy
11:38:32 <flo-retina> or more specifically, are you still waiting for feedback from me there?
11:38:47 <aleth> No, it probably needs a new patch from me before it's worth looking at
11:39:05 <flo-retina> ok :)
11:39:09 <aleth> It's possible some of the stumbling blocks have been removed since I last looked at it
11:39:10 <flo-retina> are you removing the flag, or should I?
11:39:32 <aleth> done
11:41:37 <flo-retina> thanks!
11:43:19 <aleth> Do you know who owns the BMO account corresponding to the email that instantbot watches?
11:43:31 <-- Tonnes has quit (Connection reset by peer)
11:43:31 --> Tonnes_ has joined #instantbird
11:43:49 * Tonnes_ is now known as Tonnes
11:44:25 <flo-retina> does it even exist?
11:44:59 <aleth> Idk, but I thought "instantbot" filed some stuff during the BMO merge?
11:45:12 <flo-retina> that was a completely different account IIRC
11:46:06 <flo-retina> the migration was done with an account "Instantbot <bugzilla@instantbird.org>"
11:48:03 <clokep> aleth: So _lastAliveTime being null means there was never activity, right?
11:48:09 <flo-retina> on BIO the global watchers list contains bugs@instantbird.org (that's for the bug mailing list; it's a google group) and instantbot@bugzilla.bezut.info (instantbot's incoming stream of data)
11:48:12 <aleth> clokep: Right
11:49:13 <aleth> flo-retina: So it looks like we need a BMO account for instantbot@bugzilla.bezut.info?
11:49:30 <flo-retina> aleth: looks like we need BMO accounts for these 2 addresses
11:49:36 <flo-retina> and make both watch our 3 products
11:50:07 <clokep> aleth: I'm a litle confused at what "elapsedTime > this.kTimeBeforePing + this.kTimeAfterPingBeforeDisconnect" is checked that the one directly above it doesn't cehck.
11:50:44 <aleth> clokep: I don't want to assume that all protocols using sockets.jsm use the ping functionality
11:51:38 <clokep> aleth: OK, so you're pretty much saying "Or if we've been disconnected for a while, just assume the socket is dead and disconnect"?
11:52:15 <aleth> Yes, this last one is simply "after this time we can assume the connection is dead"
11:52:20 <clokep> OK.
11:53:05 <clokep> aleth: So |else if (this._pingTimer && !this._disconnectTimer) {| is not what I expected, why when do we have the pingTimer running and not the disconnectTimer?
11:53:28 <aleth> There are two timers, the first one runs before we send a ping, the second one after
11:53:29 <clokep> (I expected a check against kTimeBeforePing in that statement somewhere...)
11:53:59 <clokep> So this one is "If we've sent a ping but haven't received a response yet"?
11:54:25 <aleth> No this one is "we were going to send a ping, lets do it right now"
11:55:01 <clokep> I don't remember how those timers interact. :-\
11:55:23 <clokep> When we send a ping, do we immediately restart the ping timer? It seems not...
11:55:36 <aleth> No, when we send a ping we start the disconnect timer
11:55:51 <clokep> OK, so my question is when we restart the ping timer.
11:55:52 <aleth> When we get a pong we stop that one and start the ping timer again
11:55:55 <clokep> That's the part I'm misunderstanding.
11:56:14 <aleth> The ping timer is started whenever a message is received
11:57:34 <clokep> Is the !this._disconnectTimer necessary? I would hope we clear the pingTimer when we start the pingTimer
11:57:59 <clokep> (That's my last question. :-D)
11:58:08 <aleth> I was being careful. We may be in an odd state.
11:59:29 <aleth> Well, actually I guess you are right and that could be removed.
11:59:59 <clokep> I think that might make that statement simpler in my mind.
12:00:05 <clokep> But if you'd like to leave it, that's OK.
12:00:10 <clokep> If you remove it you can carry forward the r+.
12:01:18 <aleth> I think I'll remove it (makes things simpler)
12:01:33 <aleth> Thanks for the quick review on that confusing code
12:02:14 <clokep> Thanks for making socket.jsm not suck. ;)
12:08:24 * flo-retina is a bit annoyed that we are checking in a bunch of stuff without nightlies
12:08:53 * clokep was thinking that too...
12:10:15 <clokep> I was wondering yesterday whether we should set up nightlies and just not build libpurple yet.
12:10:38 <aleth> We probably have too many nightly users for that.
12:11:25 * clokep figured it's worth a discussion. ;)
12:11:31 <aleth> Or did you mean reusing the last libpurple build results?
12:12:19 <aleth> flo-retina: On the other hand checking in a bunch of stuff without nightlies is motivation to get nightlies to be able to use the fixes ;)
12:13:51 <clokep> I'd appreciate some help finishing off the purple extension then. :-\
12:14:10 <flo-retina> clokep: which help do you need?
12:14:22 <flo-retina> I may have time to look into it Saturday evening.
12:15:00 <-- aleth has quit (Quit: exit stage left)
12:15:03 --> aleth has joined #instantbird
12:15:04 * ChanServ sets mode +h aleth 
12:15:13 <-- aleth has quit (Quit: exit stage left)
12:15:15 --> aleth has joined #instantbird
12:15:15 * ChanServ sets mode +h aleth 
12:15:32 <-- clokep has quit (Ping timeout)
12:16:01 <-- aleth has quit (Quit: exit stage left)
12:16:05 --> aleth has joined #instantbird
12:16:05 * ChanServ sets mode +h aleth 
12:30:01 <-- BWMerlin has quit (Quit: BWMerlin)
12:31:34 <-- aleth has quit (Ping timeout)
12:38:12 --> aleth has joined #instantbird
12:38:12 * ChanServ sets mode +h aleth 
12:52:22 <flo-retina> heh, looks like aleth is fixing all the IRC bugs I filed (relatively) recently :-D
12:52:36 <flo-retina> maybe "checking in a bunch of stuff without nightlies is motivation to get nightlies to be able to use the fixes" was serious after all :-)
12:57:13 --> deOmega has joined #instantbird
13:03:29 --> clokep_work has joined #instantbird
13:05:46 --> jb has joined #instantbird
13:06:47 <clokep_work> aleth: The sentence "The issue is that the commandname search should ignore commands that won't apply in the given conversation." means nothing to me, can you explain that in more detail.
13:06:51 <clokep_work> What does "won't apply" mean?
13:13:38 <aleth> Commands that belong to a different protocol, or only work in a MUC, or whatever.
13:15:23 <aleth> In the existing code, this is checked for only in a second step.
13:15:54 <aleth> So there are circumstances where the function returns early (too many matches) when it shouldn't.
13:16:31 <clokep_work> OK.
13:18:37 <clokep_work> I need to read this patch now. :P
13:20:38 <aleth> It required more of a rewrite than I was expecting for that simple diagnosis ;)
13:26:46 <clokep_work> It's mostly moving code around though.
13:26:52 <clokep_work> So it isn't really THAT bad.
13:26:58 <aleth> Yup.
13:27:05 <aleth> Just a messy diff.
13:27:19 --> mconley has joined #instantbird
13:29:05 <-- mconley has quit (Ping timeout)
13:29:34 * clokep_work needs to get used to pressing review not diff.
13:30:11 <aleth> flo-retina: So from a quick test it appears changing wifi networks does not send any network:status-changed notifications
13:35:58 * clokep_work wonders if aleth could reply to the newest person on the mailing list.
13:36:04 <clokep_work> I think they sent the same email a second time? :-S
13:38:08 <aleth> I don't understand why he can't edit his password
13:39:04 <aleth> Also I suspect there is some http proxy issue there but I can't remember exactly what the story was for that
13:42:17 <clokep_work> aleth: Or the port is being blocked?
13:42:36 <clokep_work> aleth: My guess is he doesn't know how to?
13:43:24 <clokep_work> Now if only someone can help me get shortened commands in git... :-\
13:45:10 <aleth> There's that autocomplete config flag, but it doesn't quite do what hg does
13:49:51 <clokep_work> aleth: I don't understand why you're checking cmdArray.length in the middle of that loop.
13:49:55 <clokep_work> Why is it not done outside the loop?
13:50:15 <aleth> Because as soon as more than one command name matches, we want to return the empty array.
13:50:18 <clokep_work> (I.e. responding "see the previous comment" probably means I don't understand how it relates. ;))
13:50:30 <clokep_work> OK, you keep saying that, but WHY?
13:50:58 <aleth> The reason I wasn't more explicit is because you wrote that code so I thought you remembered why it did that ;)
13:51:22 <aleth> Because when there is an ambiguity about which command was meant we don't want to run the command.
13:51:31 <clokep_work> That's a silly assumption. :P
13:51:42 <clokep_work> OK, so empty means "don't run a command"?
13:51:58 <aleth> It returns no commands in that case, so yes.
13:52:08 <clokep_work> I still disagree with the location of that...
13:52:30 <aleth> Yes, it's a bit of a silly assumption (it's amazing how little sometimes the comments one has oneself put into the code help later)
13:52:40 <aleth> Can you think of a better location?
13:54:13 <clokep_work> aleth: https://bugzilla.mozilla.org/show_bug.cgi?id=955360#c4
13:54:15 <instantbot> Bug 955360 nor, --, ---, aleth, ASSI, /ba doesn't work as a command, even though it is unambiguous for /back
13:54:18 <clokep_work> That's the issue I see, which maybe can't happen.
13:58:03 <aleth> Ah, now I see what you mean.
13:58:15 <aleth> You're right, that's yet another edge case :-/
13:59:09 <clokep_work> Sorry I wasn't being clear, that was obvious to me it wouldn't work. I thought I was confused. :)
14:09:28 <aleth> Yeah, it's obvious once it's obvious ;)
14:11:59 <-- aleth has quit (Ping timeout)
14:12:50 <flo-retina> can we get tests for this commands service?
14:12:56 <flo-retina> that can be tested with only xpcshell, right?
14:14:38 <flo-retina> aleth: I also dislike "review not granted"
14:16:29 <flo-retina> and I'm also not really happy about https://groups.google.com/forum/#!topic/mozilla.dev.platform/1clMLuuhtWQ (I totally agree with Zack's reply)
14:16:55 --> mconley has joined #instantbird
14:18:01 --> aleth has joined #instantbird
14:18:01 * ChanServ sets mode +h aleth 
14:19:04 <-- GeKo has quit (Quit: leaving)
14:19:19 --> GeKo has joined #instantbird
14:23:15 * clokep_work doesn't love the cmdArray = cmdArray.concat(matches) construct.
14:24:25 <flo-retina> in 2014 we want tests, don't we? ;)
14:24:56 <clokep_work> Yes. :)
14:25:04 <clokep_work> Do you want me to request tests on that patch? :P
14:25:16 <flo-retina> I've already added a comment on the bug
14:25:57 * flo-retina has just spent a lot of time recently writing tests for the WebRTC UI in bug 804611
14:26:00 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=804611 nor, P2, ---, florian, ASSI, Add a "Remember this decision" option to getUserMedia permission dialog
14:29:18 <clokep_work> aleth: Actually that code doesn't look awful to test...so it might be a good way to learn how to write an xpcshell test. :)
14:34:20 <flo-retina> clokep_work: that's why I asked! I think it's one of the easiest parts of our current stuff to test.
14:42:21 <clokep_work> :)
14:45:46 * clokep_work wishes he had a wa y of telling someone on IM that he wants their attention without IMing them.
14:50:17 <flo-retina> so you mean the wizz thing?
14:50:43 * aleth expects an IRC extension shortly ;)
14:50:43 <clokep_work> Idk what that is.
14:51:24 <clokep_work> I wantsomething that'll show up in their buddy list with a little ! next to their name or something.
14:51:28 <clokep_work> Not pop up a window on their screen.
14:52:29 <flo-retina> ah
14:52:50 <flo-retina> you want them to know that you've got something to tell them, but nothing urgent so you don't want to interrupt?
14:54:24 <flo-retina> aleth: it's the proxy's password that changes everymonth, not the gtalk password
14:54:26 <clokep_work> Yes. :)
14:56:57 <-- GeKo has quit (Ping timeout)
14:57:10 --> GeKo has joined #instantbird
15:00:21 <-- flo-retina has quit (Ping timeout)
15:03:09 <-- clokep_work has quit (Ping timeout)
15:04:07 <aleth> flo-retina: Someone else had better answer his question then because I don't know how to change the non-libpurple proxy password setting either
15:08:04 --> clokep_work has joined #instantbird
15:10:14 --> flo-retina has joined #instantbird
15:10:14 * ChanServ sets mode +qo flo-retina flo-retina 
15:11:28 * clokep_work sighs.
15:11:31 <clokep_work> libpurple...
15:19:11 --> jb1 has joined #instantbird
15:19:20 <-- jb has quit (Connection reset by peer)
15:30:06 --> iamjayakumars has joined #instantbird
15:35:40 <-- jb1 has quit (Ping timeout)
15:42:03 --> jb has joined #instantbird
16:03:49 <flo-retina> clokep_work: libpurple?
16:04:19 <-- aleth has quit (Ping timeout)
16:12:34 --> wnayes has joined #instantbird
16:18:39 <instantbot> clokep_work wanted you to know: I have heard that libpurple is meh...don't talk about that
16:18:52 <clokep_work> Bleh, messed up the syntax.
16:39:54 <-- dew has quit (Ping timeout)
16:43:09 <-- gerard-majax has quit (Ping timeout)
16:45:03 <-- clokep_work has quit (Ping timeout)
16:52:37 <-- GeKo has quit (Ping timeout)
16:56:00 --> GeKo has joined #instantbird
17:38:07 <-- iamjayakumars has quit (Quit: )
17:43:56 --> Mook_as has joined #instantbird
17:52:47 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:59:59 --> clokep_work has joined #instantbird
18:00:38 <clokep_work> aleth: Ask questions about tests if you want btw. :)
18:07:56 <-- Mook_as has quit (Quit: Mook_as)
18:11:43 --> Mook_as has joined #instantbird
18:21:05 <clokep_work> Git doesn't have a cp command?!
18:26:30 --> flo-retina has joined #instantbird
18:26:31 * ChanServ sets mode +qo flo-retina flo-retina 
18:57:35 <-- mconley has quit (Connection reset by peer)
18:57:53 --> mconley has joined #instantbird
19:22:33 <-- clokep_work has quit (Ping timeout)
19:26:56 --> clokep_work has joined #instantbird
19:27:05 * clokep_work wants aleth's patch already.
19:28:50 <flo-retina> which one?
19:29:59 <clokep_work> The one that'll make my connection come back without me sending messages.
19:30:42 --> EionRobb has joined #instantbird
19:32:53 <flo-retina> ah :)
19:45:07 --> gerard-majax has joined #instantbird
20:11:14 --> nhnt11 has joined #instantbird
20:24:29 <-- nhnt11 has quit (Ping timeout)
20:46:14 --> Mic has joined #instantbird
20:50:08 <-- gerard-majax has quit (Ping timeout)
21:00:36 <-- clokep_work has quit (Ping timeout)
21:02:19 <-- jb has quit (Ping timeout)
21:10:11 <-- deOmega has quit (Quit: So easy...but yet complicated.)
21:48:38 --> clokep has joined #instantbird
21:48:39 * ChanServ sets mode +o clokep 
22:20:12 <-- mconley has quit (Input/output error)
22:31:57 --> FireFly_TB has joined #instantbird
22:45:20 <-- FireFly_TB has quit (Ping timeout)
22:49:51 --> FireFly_TB has joined #instantbird
22:53:11 <-- FireFly_TB has quit (Quit: FireFly_TB)
23:00:27 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
23:00:32 --> clokep has joined #instantbird
23:00:32 * ChanServ sets mode +o clokep 
23:25:00 <GeekShadow> yop
23:25:20 <GeekShadow> flo-retina, how do you generate the dsstore file for the dmg ? http://lxr.instantbird.org/instantbird/source/instantbird/branding/release/dsstore
23:27:06 <flo-retina> GeekShadow: you mark the dmg file as read/write from the disk utils, then do the changes you want with Finder, then copy the resulting .DS_Store file
23:27:46 <GeekShadow> oh thanks :)
23:28:39 <GeekShadow> flo-retina, I thought there was a better way, so every developer do like this for dmg...
23:28:56 <flo-retina> you only have to do it once
23:29:30 <GeekShadow> yep
23:30:17 <GeekShadow> flo-retina, in the past one of our developer just renamed the dsstore file thought it would work, but since the dsstore still contains songbird references ;)
23:36:28 * qheaden is now known as qheaden_away