#instantbird log on 01 03 2014

All times are UTC.

00:02:36 <-- Mic2 has quit (Quit: Mic2)
00:07:30 <-- EionRobb has quit (Ping timeout)
00:07:34 <-- skeledrew has quit (Connection reset by peer)
00:10:41 --> EionRobb has joined #instantbird
00:11:54 --> skeledrew has joined #instantbird
00:18:21 <-- mconley has quit (Input/output error)
00:41:05 --> aleth has joined #instantbird
00:41:05 * ChanServ sets mode +h aleth 
00:57:23 --> BWMerlin has joined #instantbird
01:03:19 <-- aleth has quit (Quit: exit stage left)
01:16:12 <-- EionRobb has quit (Quit: Leaving.)
03:17:36 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
03:17:42 --> clokep has joined #instantbird
03:17:43 * ChanServ sets mode +o clokep 
03:17:43 <-- clokep has quit (Input/output error)
03:21:12 --> mconley has joined #instantbird
03:23:38 <-- mconley has quit (Quit: Leaving...)
03:36:51 --> ivan has joined #instantbird
03:42:57 <-- wnayes has quit (Quit: wnayes)
04:08:10 <instant-buildbot> build #1069 of linux-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1069
05:00:24 <-- skeledrew has quit (Connection reset by peer)
05:17:13 --> mconley has joined #instantbird
05:28:59 --> EionRobb has joined #instantbird
05:57:35 <-- mconley has quit (Input/output error)
07:49:24 <instant-buildbot> build #1219 of win32-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1219
07:58:52 --> hadi has joined #instantbird
08:07:27 <-- hadi has quit (Ping timeout)
09:43:14 --> jb has joined #instantbird
10:00:11 <-- GeekShadow has quit (Ping timeout)
10:00:13 --> GeekShadow has joined #instantbird
10:12:03 <-- Even has quit (Ping timeout)
10:13:02 --> Even has joined #instantbird
10:13:02 * ChanServ sets mode +o Even 
10:16:58 --> gerard-majax__ has joined #instantbird
10:38:24 <instant-buildbot> build #1569 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/1569
10:45:00 <-- EionRobb has quit (Quit: Leaving.)
10:45:45 --> nhnt11 has joined #instantbird
11:10:45 <-- GeKo has quit (Quit: leaving)
11:15:07 --> hadi has joined #instantbird
11:15:54 --> GeKo has joined #instantbird
11:44:21 <-- GeekShadow has quit (Ping timeout)
11:44:27 --> GeekShadow has joined #instantbird
11:50:25 <-- hadi has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
11:56:05 --> Mic has joined #instantbird
11:56:20 * Mic is now known as Mic2
12:26:38 <-- jb has quit (Ping timeout)
12:46:40 --> clokep has joined #instantbird
12:46:40 * ChanServ sets mode +o clokep 
12:50:03 --> jb has joined #instantbird
12:53:00 <-- clokep has quit (Ping timeout)
12:58:12 <-- Mic2 has quit (Ping timeout)
12:58:52 --> deOmega has joined #instantbird
13:06:34 --> clokep has joined #instantbird
13:06:35 * ChanServ sets mode +o clokep 
13:36:21 --> Mic2 has joined #instantbird
13:47:03 <-- jb has quit (Quit: jb)
13:47:09 --> jb has joined #instantbird
14:02:06 <clokep> Apparently Miranda forked: http://miranda-ng.org/en/
14:08:33 <flo-retina> uh
14:08:39 <flo-retina> do they explain why?
14:09:22 <clokep> Not really. :-\
14:10:06 <clokep> http://en.wikipedia.org/wiki/Miranda_IM#Miranda_NG says "The reasons were differences in the development team and slow-moving development of original Miranda. The main differences between the original client and the fork are: moving to Visual Studio 2010's compiler thus deprecating the ANSI version, core and plugins development is combined and share a unified repository."
14:10:46 <flo-retina> ah, I was about to paste the same quote
14:11:17 <flo-retina> "deprecating the ANSI version" they are dropping Windows 98?!? That's crazy! :-P
14:42:20 --> jb1 has joined #instantbird
14:42:35 <-- jb has quit (Ping timeout)
15:01:24 <flo-retina> nhnt11: from what I remember, there's a problem around http://lxr.instantbird.org/instantbird/source/instantbird/content/macgestures.js#166
15:02:52 <nhnt11> flo-retina: I can't get these swipe gestures to work anywhere
15:03:10 <flo-retina> especially because of http://lxr.instantbird.org/instantbird/source/instantbird/content/macgestures.js#55
15:03:23 <flo-retina> that's too bad :(
15:03:31 * flo-retina can't really use Ib without these gestures any more
15:03:54 <nhnt11> let me disable better touch tool and try...
15:04:01 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:04:09 --> nhnt11 has joined #instantbird
15:05:00 <nhnt11> Weird, now three finger swiping is behaving identical to two fingers (i.e. it scrolls)
15:06:49 <flo-retina> nhnt11: I think there's one thing to uncheck
15:07:42 <flo-retina> "Three finger drag" is unchecked for me
15:07:49 <nhnt11> I unchecked it already
15:07:50 <-- GeekShadow has quit (Ping timeout)
15:07:52 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:07:57 --> flo-retina has joined #instantbird
15:07:58 * ChanServ sets mode +qo flo-retina flo-retina 
15:08:13 <nhnt11> Aha
15:08:15 <nhnt11> I got it to work
15:08:35 <nhnt11> I needed to change the "Swipe between pages" setting to "Swipe with three fingers" in "More Gestures"
15:08:37 * flo-retina wonders how much effort it would take to replace the "offline" icon with a throber on IRC channel tabs that we have already opened, but not actually joined yet
15:08:51 <flo-retina> I always go "why is this channel 'left'?!?" :-S
15:08:54 <nhnt11> "Swipe with two or three fingers" also works
15:09:25 <flo-retina> cool :)
15:10:14 <flo-retina> nhnt11: so from what I remember, the problem is: richlistboxes already support the swipe gesture by default (you can test this in the account manager), but the code in macgestures.js calls "stopPropagation" because it thinks it's handling all the gestures itself
15:10:44 <flo-retina> so I guess some of that code needs to change to return a boolean indicating if the gesture has been handled, and stop the propagation only in that case
15:10:54 <nhnt11> Hmm
15:11:17 --> GeekShadow has joined #instantbird
15:11:48 <flo-retina> or duplicate the stopPropagation call in a few places, and return early when we don't want it
15:11:51 <flo-retina> or something :)
15:12:30 * nhnt11 will be back after dinner
15:20:17 --> wnayes has joined #instantbird
15:25:10 <-- BWMerlin has quit (Quit: BWMerlin)
16:11:53 <Mic2> 17:09:14 - Mic2: Are there other plans for *-in-a-tab?
16:11:53 <Mic2> 17:09:26 - nhnt11: Right now, nope
16:11:53 <Mic2> 17:09:39 - nhnt11: Do you have ideas?
16:11:53 <Mic2> 17:10:29 - Mic2: My conversation window is usually to big to host the e.g. account manager. I think that would look awkward... 
16:11:53 <Mic2> 17:10:54 - nhnt11: I think the account manager is comfortable in its window ;)
16:12:04 <flo-retina> Mic2: the next window I would like to get rid of is the update dialog :)
16:12:19 <flo-retina> I would like to include most of it in the About dialog, like Fx/Tb did
16:12:32 <flo-retina> and add an /update command to force an update check easily from the conv window
16:12:38 <clokep> Mic2: Unfortunately for me the conversation window is the perfect size for the account manager. ;)
16:12:57 * clokep would like to get rid of join chat also! :)
16:12:58 <flo-retina> clokep: I don't think the account manager should go in the conv window
16:13:05 <clokep> I don't think so either.
16:13:10 <flo-retina> clokep: sure. Feels like more work though.
16:13:11 <clokep> Just saying size is a tricky subject.
16:13:27 <flo-retina> clokep: I purposefully avoided commenting on the size part ;)
16:13:32 <Mic2> Maybe media-queries could help...
16:15:07 * clokep stops commenting on UI.
16:15:23 <flo-retina> clokep: heh
16:18:56 <flo-retina> so who is working on the c-c merge?
16:19:22 * nhnt11 just realized his | $python client.py checkout| failed :/
16:19:23 <flo-retina> I think we should do our best to make it happen next week
16:20:35 <clokep> flo-retina: So....I've been unable to get a c-c build to work. :-/
16:20:50 <clokep> I wanted to check that latest merge and then push those changes.
16:20:56 <clokep> That was step 1 for me.
16:21:00 <clokep> (And convince you to r+ them. :))
16:21:57 <flo-retina> clokep: that's step unrelated for me
16:22:12 <flo-retina> it needs to happen before the final merge, but doesn't block the parts that need a lot of work
16:22:21 <clokep> flo-retina: Well the step that's "related" form my opinion is that I still can't build c-c!
16:22:32 <flo-retina> how come?
16:22:51 <clokep> I'm unsure of what my last error is, I'm gonna build again.
16:22:53 <clokep> (This is on Linux btw)
16:23:15 * nhnt11 wonders why his checkout is saying "abort: crosses branches"
16:23:29 <flo-retina> nhnt11: add --clean
16:23:34 <nhnt11> I'm tempted to do a --clean but I'm a bit weary since I haven't done this in a while
16:23:35 <nhnt11> Ah
16:23:35 <nhnt11> cool
16:23:38 <flo-retina> and --skip-instantbird if you have local changes you care about
16:23:57 <nhnt11> No, I popped my queue before this
16:24:13 <nhnt11> Why would it cross branches though?
16:24:28 <flo-retina> nhnt11: because we use release branches for mozilla-release
16:24:54 <flo-retina> so whenever we update to a new mozilla version, we use a new branch of the mozilla-release repo
16:25:03 <clokep> :)
16:25:23 <nhnt11> So there was a moz update while I wasn't looking? :)
16:25:29 <nhnt11> That would explain it
16:25:30 <flo-retina> nhnt11: or two
16:25:49 <flo-retina> if you hg parent -R mozilla/ it will tell you which changeset/branch it currently has checked out
16:25:49 <nhnt11> I think I saw the moz 24 update happening...
16:25:58 <nhnt11> Okay
16:26:06 <flo-retina> nhnt11: we are on 25
16:26:13 <nhnt11> I saw :)
16:26:25 --> GeKo_ has joined #instantbird
16:26:33 <-- GeKo_ has quit (Quit: leaving)
16:26:48 --> GeKo_ has joined #instantbird
16:26:48 <-- GeKo has quit (Ping timeout)
16:27:55 <clokep> flo-retina: OK, I lied.
16:27:56 <clokep> It worked.
16:27:58 <clokep> mach is just stupid.
16:28:43 * flo-retina didn't know clokep was a liar, and rephrases that to "mach lied"
16:30:24 <-- jb1 has quit (Ping timeout)
16:30:51 <clokep> I'd prefer to do this work on Windows though...
16:31:02 <clokep> Easier than working in a RDP session all the time.
16:31:25 <flo-retina> was there a problem on Windows?
16:32:35 <clokep> My computer over heated. :-D
17:14:22 --> nathanr has joined #instantbird
17:19:43 <-- nathanr has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
17:20:07 --> nathanr has joined #instantbird
17:20:57 <-- nathanr has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
17:29:30 --> nathanr has joined #instantbird
17:30:36 <-- nathanr has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
17:34:12 <-- nhnt11 has quit (Ping timeout)
17:35:29 --> nhnt11 has joined #instantbird
17:36:03 --> nathanr has joined #instantbird
17:36:27 <nathanr> has anyone gotten stylish to work for Instantbird?
17:37:39 <-- Mic2 has quit (Ping timeout)
17:39:31 <nathanr> ah I got it
17:39:49 <nathanr> you have to create styles using - window.openDialog("chrome://stylish/content/manage-standalone.xul");
17:40:03 <nathanr> cause the button for creating styles doesnt appear in the addon manager dialog
17:41:00 <-- nhnt11 has quit (Ping timeout)
17:42:12 <clokep> :)
17:42:16 <clokep> What're you using stylish for?
17:42:22 <clokep> Is it just to customize or is something broken?
17:42:41 <nathanr> just to quickly change some things around without having to get down and dirty
17:42:47 --> nhnt11 has joined #instantbird
17:43:06 <nathanr> I use it in Komodo too, to prototype some changes for a while before I integrate them
17:44:35 <-- nhnt11 has quit (Ping timeout)
17:45:52 --> nhnt11 has joined #instantbird
17:48:26 <clokep> Oh boo.
17:48:26 <-- nhnt11 has quit (Ping timeout)
17:48:29 <clokep> I left a debug statement in. :(
17:50:04 --> nhnt11 has joined #instantbird
17:52:45 <-- nhnt11 has quit (Ping timeout)
17:54:12 --> nhnt11 has joined #instantbird
17:57:44 <-- nhnt11 has quit (Ping timeout)
17:58:39 --> nhnt11 has joined #instantbird
17:58:48 <clokep> flo-retina: OK, I commented on all the port chat/ changes bugs.
18:00:12 <flo-retina> thanks!
18:02:06 <clokep> I only messed up the first one bad. :(
18:02:19 <-- nhnt11 has quit (Ping timeout)
18:02:47 <clokep> flo-retina: So if my c-c build finishes I'll start trying to build IB in c-c.
18:02:59 <flo-retina> cool
18:03:10 <flo-retina> so I guess I should start looking at the hg convert thingy then
18:03:42 --> nhnt11 has joined #instantbird
18:04:44 <-- gerard-majax__ has quit (Ping timeout)
18:05:06 <clokep> I added my script to the repo btw in case someone else needs to do something similar.
18:05:14 <clokep> Unless Mic or aleth are bored.
18:05:16 <clokep> Or nhnt11.
18:06:08 <flo-retina> well, the hg convert commit message map may be very similar ;)
18:07:03 <nathanr> there, nice and minimalistic - http://d.pr/i/3Iin/3bgQaeC4
18:07:06 <clokep> We could map those SVN revisions that are done by you but not really done by you at the same time. :P
18:07:22 <clokep> (We actually might want to do some of the ones that aren't in the form of "Bug xxxx - fooo"
18:07:46 <clokep> nathanr: Nice. :) Does that touch the content also or just the UI?
18:07:53 <clokep> (I.e. what message theme is that.)
18:08:01 <nathanr> clokep: thats just css
18:08:10 <clokep> That didn't answer my quesiton. ;)
18:08:15 <nathanr> its the minimal theme with some tweaks
18:08:25 <clokep> OK.
18:08:43 <nathanr> if by content you meant the chat theme then yeah it does
18:08:48 <nathanr> this is all quick and dirty
18:09:00 <clokep> Yes, that's what I meant.
18:09:02 <nathanr> to let me test things out
18:09:15 * clokep goes to find what minimal normally looks like.
18:09:40 <clokep> Nice. :) Looks like aleth is maintaining that now.
18:11:02 <nathanr> mm, I pretty much just added a slight gradient as the background and tweaker the sender usernames to stand out a bit more
18:11:58 <clokep> flo-retina: What were the goofy emails you had found? :-S
18:12:40 <clokep> (How do you know nay of them might be the same person w/o a name?)
18:14:30 <-- nhnt11 has quit (Ping timeout)
18:16:31 --> nhnt11 has joined #instantbird
18:20:12 <-- nhnt11 has quit (Ping timeout)
18:21:05 --> nhnt11 has joined #instantbird
18:21:14 <flo-retina> that's a lot of foo in bug 753807 ;)
18:21:25 <clokep> :-[
18:22:43 <flo-retina> https://bugzilla.mozilla.org/show_bug.cgi?id=920801 needs new attachments with the new BMO numbers in commit messages, doesn't it?
18:24:34 <clokep> flo-retina: Um, sure...we could do that.
18:25:40 <clokep> I don't know how easily. ;)
18:25:42 <clokep> But we could.
18:25:52 --> Mic2 has joined #instantbird
18:26:47 --> igorko has joined #instantbird
18:28:05 <igorko> Hi guys, this thing with sound is annoying
18:30:50 <Mic2> Hi
18:31:08 <clokep> That was sufficiently vague. ;)
18:33:09 <Mic2> nathanr: I used the userContent.css and userChrome.css files for stuff like that.
18:33:34 <nathanr> Mic2: yeah but you have to restart with those
18:33:50 <nathanr> Stylish is instant, and lets your organize it across different files
18:34:03 <Mic2> hmm, usually I try the changes with DOMi and then write them down in a css file.
18:35:12 <nathanr> right, its just a bit easier with stylish imo
18:35:30 <nathanr> I still use DOMi but not to make changes, just to identify nodes
18:35:37 <Mic2> Where's that button normally? @ http://log.bezut.info/instantbird/today#m174
18:35:46 <flo-retina> the shorter the feedback loop, the more pleasing it is to hack stuff :)
18:36:04 <nathanr> Mic2: http://d.pr/i/hhJU/5FWWmdLe
18:36:17 <nathanr> flo-retina: exactly
18:36:48 <nathanr> Mic2: this is what it looks like in Instantbird: http://d.pr/i/Cyl0/mBgTWJcV
18:36:48 <Mic2> The User Style add-on categories on the left exist, though?
18:36:52 <nathanr> yeah
18:37:26 <Mic2> Does anything appear on the error console when you open the add-on manager?
18:37:34 <nathanr> leme check
18:38:02 <nathanr> nope
18:38:23 <Mic2> I'm not sure if I want to debug that then ;)
18:38:26 <nathanr> I checked with DOMi and couldnt find the button anywhere, it's probably missmatching something in the overlay
18:41:38 <-- nhnt11 has quit (Ping timeout)
18:42:34 --> nhnt11 has joined #instantbird
18:48:06 --> gerard-majax__ has joined #instantbird
18:48:11 * clokep wonders if anyone on team@ can tell me if they just received an email?
18:49:48 <clokep> I'm not convinced it sent. :)
18:50:32 <-- nhnt11 has quit (Ping timeout)
18:51:23 --> nhnt11 has joined #instantbird
18:52:54 <nhnt11> clokep: I got two emails
18:53:14 <nhnt11> Both identical
18:53:27 <clokep> Oops. :(
18:53:40 <clokep> Is one from me @ib.org and the other form me @ gmail?
18:53:57 <clokep> Odd, it told me the first time it didn't send.
18:53:58 --> gerard-majax_ has joined #instantbird
18:53:59 <clokep> Whatever.
18:53:59 <nhnt11> Yes.
18:54:02 <-- gerard-majax__ has quit (No route to host)
18:54:04 <nhnt11> One from @ib.org, one from gmail
18:54:22 <clokep> Bah.
18:54:24 <clokep> I didn't change my account.
18:55:00 <nhnt11> bah, I have to go
18:55:03 <nhnt11> Good night
18:55:09 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:56:27 <-- gerard-majax_ has quit (Connection reset by peer)
18:56:33 --> gerard-majax_ has joined #instantbird
18:58:22 <flo-retina> clokep: bug 1677 wasn't by goofy
18:58:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1677 nor, --, 1.3, lorenzo.ghetti, RESO FIXED, [Italian] Grammatical error
18:58:42 <flo-retina> https://bugzilla.mozilla.org/show_bug.cgi?id=955106 on BMO
18:59:03 --> gerard-majax__ has joined #instantbird
18:59:07 <clokep> flo-retina: Good catch.
18:59:08 <-- gerard-majax_ has quit (Quit: Ex-Chat)
18:59:34 <clokep> I must have ticked too many boxes. :)
19:01:47 --> jb has joined #instantbird
19:03:19 <flo-retina> likely :)
19:03:43 <clokep> OK, so I emailed all the people who are still instantbot for assigned bugs.
19:03:46 <clokep> If they respond, great.
19:03:49 <clokep> If not...oh well. :)
19:04:28 <-- gerard-majax__ has quit (Connection reset by peer)
19:04:32 --> gerard-majax_ has joined #instantbird
19:05:24 <clokep> flo-retina: My c-c build finished. :)
19:06:26 <flo-retina> :)
19:09:52 <-- jb has quit (Ping timeout)
19:10:04 <igorko> clokep: I mean sound notification. It lags
19:10:41 <igorko> and sizzles
19:11:13 <igorko> looks like it happneds when instantbird tries to play few sounds in the same time
19:11:19 <igorko> happens*
19:12:18 <clokep> igorko: OK, on Linux, I assume? I think there's a bug on file about that.
19:12:35 <igorko> on windows 7
19:17:06 --> aleth has joined #instantbird
19:17:07 * ChanServ sets mode +h aleth 
19:18:11 <aleth> igorko: you can cc yourself to the bug... or fix it if you are in a hurry ;)
19:18:59 <igorko> I'm not familiar with Instantbird code, and don't have time, so I'll just wait. ;)
19:34:54 * aleth is surprised there are not more sound theme addons
19:37:51 <clokep> aleth: I don't think it's really obvious how to make them. And most people expect to be able to just choose files, it seems.
19:38:30 <flo-retina> I'm in the category of people who expect the application to have decent sounds by default
19:38:38 <flo-retina> (and I'm not really pleased by the sounds we currently have ;))
19:38:45 <Mic2> Easy way to test the sounds thing might be to install the Chat Sound Notification add-on and then track "fail" or a word like "the" on Twitter ;)
19:38:50 <aleth> The Venn diagram of developers and sound users seems to be empty
19:46:12 <clokep> I use sounds.
19:46:18 <clokep> So the Venn diagram is clokep.
19:46:40 <clokep> flo-retina: So for https://bugzilla.mozilla.org/show_bug.cgi?id=920801, you want me to change the commit messages from being bio ### to the real bug number?
19:47:06 <flo-retina> clokep: I use sounds too
19:47:16 <flo-retina> I understand that sentence as sound developers/code developers
19:47:34 <flo-retina> clokep: wouldn't that make more sense?
19:47:44 <flo-retina> hmm
19:47:47 <flo-retina> I'm not sure actually
19:47:50 <flo-retina> maybe I just don't care :)
19:48:01 <clokep> flo-retina: I don't particularly care personally.
19:48:16 <flo-retina> alright, never mind then
19:50:09 <clokep> flo-retina: So I just built and tested all of that though? Any chance I can put up a new patch for the full changes and get an r+?
19:50:37 <deOmega> Mic2: that keyword alert on twitter is really very powerful.  Very useful!  It could be easier to navigate to modify the keyword, but  it is GREAT.
19:51:11 <clokep> Oh, actually I only asked on it for the other changes. :)
19:51:55 <Mic2> Don't we have other preferences that would be better a list of separate items instead of a comm-aseparated string?
19:52:07 <Mic2> Auto-join list, alternate nicks, ...
19:52:08 <clokep> Most likely.
19:52:35 <Mic2> Some of those hopefully go away one day (I'm looking at you, auto-joins;)
19:54:44 * clokep would mostly like an r+ on https://bugzilla.mozilla.org/attachment.cgi?id=815330&action=edit
19:54:52 <clokep> But https://bugzilla.mozilla.org/attachment.cgi?id=819524&action=edit would be nice too.
19:55:05 <clokep> I guess aleth or Mic2 can steal those if they'd like? I don't know if they need to be by a peer or not.
19:55:14 <clokep> Also did you guys see Florian's comment about an hg convert script?
19:56:25 <aleth> clokep: iirc I already reviewed that
19:56:39 <aleth> Or have you changed it?
19:56:42 --> rosonline has joined #instantbird
19:56:44 <clokep> No
19:59:59 <Mic2> clokep: can't you, as chat peer, request review from anyone and that's just fine?
20:00:11 * clokep doesn't remember.
20:03:50 <clokep> aleth: So those are actually ports and have the original commit information on them, if you'd r+ those I'd feel OK pushing them.
20:04:08 <clokep> (I.e. I was just changing paths and context in those patches.)
20:05:25 <aleth> clokep: OK, I'll do that later
20:06:50 <clokep> OK. :-(
20:11:52 --> hadi has joined #instantbird
20:11:52 * aleth didn't realize you weren't referring to https://bugzilla.mozilla.org/attachment.cgi?id=8355622&action=diff
20:12:06 <Mic2> Module owners and peer need reviews from someone else of the module team (either owner or another peer).
20:12:11 <Mic2> No self-reviews allowed.
20:12:42 <-- igorko has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
20:12:44 <-- hadi has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
20:13:05 <aleth> clokep: The patch I just linked to has no r? at all
20:14:25 <clokep> aleth: That doesn't need an r+ it's direct ports.
20:14:29 <clokep> They were already reviewed.
20:15:31 <aleth> OK then (I just saw the reference to moz.build changes in your comment)
20:16:04 <clokep> Oh, yeah...well....shh...
20:16:12 <clokep> It's direct ports except for Yahoo build files. :)
20:16:46 <clokep> aleth: I added the two lines at the bottom of https://bugzilla.mozilla.org/attachment.cgi?id=8355622&action=diff#a/chat/protocols/yahoo/moz.build_sec2
20:18:15 <clokep> (One of which is blank. ;))
20:18:15 * aleth hopes instantbot wakes up to BMO soon ;)
20:19:01 <clokep> :)
20:20:13 * clokep would like to push this code before it bitrots again. :-D
20:34:52 <-- gerard-majax_ has quit (Ping timeout)
20:35:54 --> gerard-majax_ has joined #instantbird
20:40:06 <-- gerard-majax_ has quit (Quit: Ex-Chat)
20:40:12 --> gerard-majax__ has joined #instantbird
20:45:21 <-- gerard-majax__ has quit (No route to host)
20:45:22 --> gerard-majax_ has joined #instantbird
20:50:48 <aleth> clokep: Did you forget to push the two manual ports?
20:50:56 <clokep> aleth: I don't think so.
20:50:58 <clokep> Why?
20:51:24 <clokep> It's possible I did though. :)
20:51:47 <aleth> Didn't see them in the shortlog, but I might have missed them if they were hiding somewher in the middle.
20:51:56 <clokep> No, they're there.
20:52:01 <clokep> They're the 7 newest changesets IIRC>
20:52:30 <aleth> Oh, I see, you disaggregated them again
20:52:50 <aleth> Sorry.
20:54:11 <clokep> I had them all applied in my mq and did qfin -a && hg push.
20:54:26 <clokep> And then realized I had a bunch of stuff set up wrong in my hgrc, fixed it and pushed again hah.
20:54:50 <aleth> Right, it's just that some metadata is not visible on BMO diff
20:57:29 <clokep> Oh, I understand.
20:57:30 <clokep> Yes.
21:03:19 <-- deOmega has quit (Quit: So easy.. but it is complicated.)
21:35:41 <clokep> flo-retina: ping
21:35:51 <clokep> Any idea what's up with these test failures? :( https://tbpl.mozilla.org/php/getParsedLog.php?id=32529669&tree=Thunderbird-Trunk
21:48:14 --> jb has joined #instantbird
21:55:11 <-- aleth has quit (Ping timeout)
22:13:14 <-- jb has quit (Ping timeout)
22:13:19 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
22:16:28 <clokep> qheaden: ping
22:17:28 <-- GeKo_ has quit (Quit: leaving)
22:25:07 <flo-retina> clokep: pong
22:25:41 <clokep> flo-retina: So the Yahoo xpcshell tests are failing on c-c from JS-Yahoo.
22:25:47 <clokep> The tests run OK on Windows for me, but fail on Linux.
22:26:33 <clokep> WIth a really unhelpful error message.
22:26:51 <clokep> Would it be reasonable to disable those tests for now (as we consider JS-Yahoo "experimental" still) or...what should I do? :)
22:27:40 <flo-retina> clokep: guess, yahoo.js isn't packaged for Thunderbird, and that file is missing when running the xpcshell tests in a Tb context (because builders package builds, and then the test slaves download the builds)
22:27:58 <clokep> Oh, I did not know that...hmm....
22:28:19 <flo-retina> it's just a guess ;)
22:28:22 <clokep> Package.manifest change?
22:28:59 <flo-retina> but you've got [3926] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file ../../../../../mozilla/js/xpconnect/loader/mozJSComponentLoader.cpp, line 928 a few times in your log, and that warning in debug builds usually means "missing JS component"
22:29:42 <flo-retina> clokep: yes, http://mxr.mozilla.org/comm-central/source/mail/installer/package-manifest.in#299 would need another 2 lines
22:30:23 <clokep> flo-retina: OK.
22:31:42 <flo-retina> follow-up question: do we have a way to pref-off JS-Yahoo if libpurple isn't here?
22:32:16 <clokep> I don't think we actually do. :-\
22:32:24 <flo-retina> clokep: I think we should either get JS-Yahoo on by default in Tb (is this a reasonable thing to do?) or ifdef out the yahoo test when in a tb context
22:32:54 <clokep> flo-retina: http://pastebin.instantbird.com/516397
22:32:59 <clokep> I think it's reasonable to do.
22:33:03 <clokep> And might get more users on it actually.
22:33:09 <flo-retina> r-
22:33:14 <clokep> Oops.
22:33:15 <flo-retina> and I think you haven't read the diff you pastebinned
22:33:40 <flo-retina> clokep: I'm wondering if it wouldn't be a distraction
22:33:54 <flo-retina> I think I would prefer us to do that once we are actually developping JS-Yahoo on c-c
22:34:04 <clokep> Sure, that's fine.
22:34:24 <flo-retina> (although arguably landing on both the ib and c-c repo is less painful now that it doesn't require filing a second bug)
22:34:25 <clokep> flo-retina: Is there an ifdef I should use or just comment it out?
22:34:46 <flo-retina> http://lxr.instantbird.org/instantbird/source/chat/modules/imTextboxUtils.jsm#125
22:35:08 <flo-retina> I would put that in the file, and check locally that the yahoo tests are no longer running in your c-c build
22:35:21 <clokep> flo-retina: Put that in what file?
22:35:26 <clokep> The moz.build file?
22:36:20 <flo-retina> I guess moz.build files won't tolerate ifdef
22:36:37 <flo-retina> http://mxr.mozilla.org/comm-central/search?string=MOZ_THUNDERBIRD&find=moz.build&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central gives no result :(
22:37:52 <clokep> :-\
22:38:07 <flo-retina> I guess if CONFIG['MOZ_THUNDERBIRD']:
22:38:09 <flo-retina> but test it :)
22:38:35 <clokep> If not that, right?
22:38:42 <flo-retina> yeah
22:40:51 <clokep> flo-retina: That worked.
22:41:24 <flo-retina> great :)
22:41:45 <flo-retina> clokep: so busting the Tb tree is your new way to force me to look into something quickly? ;)
22:41:55 <clokep> flo-retina: It worked. ;)
22:41:56 <clokep> Sorry.
22:42:06 <flo-retina> no problem
22:42:27 <clokep> flo-retina: https://bugzilla.mozilla.org/attachment.cgi?id=8355672&action=edit
22:42:41 <clokep> flo-retina: I'm going to change that commit message before pushing.
22:42:42 <flo-retina> I'm glad you are moving this forward, and that you found others who are willing to take the blame for the brokenness :-P
22:43:00 <clokep> To "Bug 920801 - Port chat/ changes from Instantbird to comm-central - 6 - Disable JS-Yahoo tests, r=fqueze."
22:43:39 <clokep> Do I need any sort of special approval flags in my  commit message?
22:43:47 <clokep> (Like TEST-BUSTAGE or something?)
22:44:22 <flo-retina> if the tree isn't closed (yet), you don't need approval
22:44:35 <clokep> It's closed.
22:44:42 <flo-retina> "Disable JS-Yahoo tests" could be clearer. Maybe add " until JS-Yahoo is packaged for Thunderbird" ?
22:44:45 <clokep> "CLOSED. xpcshell orange." on Tinderbox.
22:44:52 <flo-retina> if it's closed, a=bustage-fix will do
22:45:09 <clokep> That goes at the end?
22:45:24 <clokep> Cool. Thanks. :)
22:45:45 <flo-retina> clokep: can you push my name with the correct encoding next time? "Florian Quèze" isn't nice :-P
22:46:16 <clokep> flo-retina: I'm unsure how that got messed up. I didn't do anything different than I normally do?
22:46:51 <flo-retina> you likely only use ascii characters when you check-in patches usually.
22:49:55 <clokep> Likely.
22:50:03 <clokep> I'll check before pushing next time.
22:50:04 <clokep> Sorry. :)
22:50:44 <flo-retina> that's ok (if you fix it next time!) :)
22:52:49 <clokep> Just be ready for me to ask questions next time.
22:54:19 <flo-retina> I'll just ask you to push it to try next time ;)
22:54:40 <clokep> I have no idea how to Push to try. :-[
22:54:53 <flo-retina> lmgtfy? ;)
22:55:06 <clokep> :)
22:55:07 <flo-retina> keywords would be: thunderbird try
22:55:29 <clokep> http://lmgtfy.com/?q=thunderbird+try&l=1 maybe? :P
22:57:00 <flo-retina> it even works! :-D
23:03:07 <flo-retina> oh, you all ported the "copy debug logs" feature to Tb? That's exciting! :)
23:06:17 <clokep> "you all" means "clokep", right?
23:06:30 <clokep> But yes, I got tired of people reporting crappy bugs so I made it part of that port. ;)
23:06:37 --> aleth has joined #instantbird
23:06:37 * ChanServ sets mode +h aleth 
23:11:05 <clokep> flo-retina: So for the im/ build stuff, you think grabbing mail/'s and copying to start w/ makes the most sense or should I go from instantbird/?
23:11:24 <flo-retina> go from instantbird/
23:18:27 <clokep> k
23:20:55 <clokep> flo-retina: Is it reasonable to initially pretend purple/ doesn't exist?
23:21:03 <flo-retina> looks like hg convert doesn't have an option to change commit messages
23:21:10 <flo-retina> clokep: it doesn't exist!
23:21:18 <clokep> :)
23:21:35 <flo-retina> hmm, well, not really
23:22:00 <flo-retina> so what I mean is: don't include the purple/ folder in the c-c repo
23:22:18 <flo-retina> but the file in instantbird/ that mention purple should keep mentioning purple/ in your first commit
23:22:30 <flo-retina> so that I can review the fixes you will make to drop all references to purple
23:23:03 <flo-retina> clokep: looks like hg convert won't do what I want
23:23:31 <clokep> flo-retina: OK, so that was my question. :)
23:24:23 <flo-retina> clokep: so my next plan is to hg export everything in our repo (or from an hg converted repo that is closer to what I want to end up with), use sed to do all the changes I want to the commit messages, and then hg import everything into a branch of c-c, and finally merge
23:24:27 <clokep> flo-retina: Currently I cp instantbird/ to im/ and instantbird's chat/ over c-c's chat/, but then reverted all of chat's moz.build files. Is that what you want as a first commit?
23:24:41 <clokep> flo-retina: That was going to be my next suggestion.
23:25:00 <flo-retina> cool
23:25:33 <flo-retina> "reverted all of chat's moz.build files" shouldn't this be done in your second commit?
23:25:46 <clokep> It can be. :)
23:25:51 <clokep> I'll do it in smalle rchunks.
23:26:15 <flo-retina> the state of your repo after your first commit should match what I'm expected to obtain with my hg tinkering
23:26:41 <flo-retina> and then we will hg export all your other commits, and push that above my branch
23:27:05 <clokep> OK.
23:27:58 <flo-retina> the detail I really care about for this merge is: after the merge, when doing an hg annotate, I want the history of the chat files to come from Instantbird's history; not the current mostly broken Tb history that is full of 'merge chat/' changesets.
23:28:05 <aleth> flo-retina: This extension might allow modifying commit messages? http://mercurial.selenic.com/wiki/HisteditExtension
23:28:47 <flo-retina> aleth: seems to be an interactive tool
23:28:56 <flo-retina> I want something I'll script :)
23:29:12 <flo-retina> btw, bug numbers aren't the only thing I want to fix in commit messages
23:29:30 <aleth> That's unfortunate that it's not scriptable :-/
23:29:35 <aleth> Who writes such a thing ;)
23:29:39 <flo-retina> I think I'll also s/r=fqueze/r=florian/ (because that's what was used in c-c)
23:29:52 <flo-retina> possibly also cleanup the email used for aleth's changesets
23:29:55 <flo-retina> and for Mic
23:30:22 <clokep> flo-retina: So...this is super specific but there's a changeset I actually put the wrong bug number in. :-D
23:30:44 <flo-retina> clokep: this week will be the right time to remind me about such details
23:30:54 <flo-retina> clokep: there's also a very old changeset I care about cleaning up ;)
23:33:06 <flo-retina> hmm, I have a hard time believing http://hg.instantbird.org/instantbird/rev/6ccd4f960e09 is the first changeset
23:33:19 <flo-retina> it's quite possible we got rid of the early history when we converted from svn to hg
23:34:14 <flo-retina> hmm, looking at these folder names, I have no idea of where these files could go in c-c
23:34:25 <flo-retina> so maybe we need to drop some more of the hold history when merging into c-c
23:35:01 <flo-retina> and keep the existing repo readonly just in case anybody cares in the future about obscure archeology :)
23:36:17 <clokep> Yeah I was wondering that today.
23:36:25 <clokep> Unless you do crazy hg convert magic. ;)
23:36:35 <clokep> (First)
23:37:49 <flo-retina> I will likely do some crazy magic
23:37:55 <flo-retina> but some files just won't make any sense
23:38:11 <flo-retina> I think I'll do my best to keep the history of the existing files as far as I can go back for them
23:38:17 <flo-retina> and just ignore the files that don't go anywhere
23:38:36 --> Mook has joined #instantbird
23:39:11 * clokep can't find the bug w/ the wrong commit message.
23:44:12 <flo-retina> clokep: I think I also need to hg convert-out the tools/ top level directory we currently have
23:44:33 <clokep> flo-retina: Maybe hg convert it to im/tools?
23:46:17 <flo-retina> clokep: I think buildbot-configs should go in im/config/mozconfigs/ to match http://mxr.mozilla.org/comm-central/source/mail/config/mozconfigs/
23:46:47 <flo-retina> "l10n" and create-header.sh seem purple related, so probably going in that other repo
23:47:07 <clokep> OK. :)
23:47:10 <flo-retina> and the other two folders could likely go elsewhere (in hg.instantbird.org/tools ?)
23:47:13 <clokep> What abou tall the patching stuff?
23:47:31 <-- Mic2 has quit (Ping timeout)
23:47:37 <flo-retina> that's not acceptable for c-c, right?
23:47:55 <flo-retina> so I would say: let's pretend it doesn't exist for now.
23:48:14 <flo-retina> And then we will hg convert c-c + other stuff we have into a repo that we actually hand to our buildbot slaves
23:48:38 <flo-retina> or we could have a separate patch repo
23:51:20 --> Mic2 has joined #instantbird
23:52:43 <clokep> I'd imagine so.
23:59:07 <flo-retina> wasn't there a bug where I had a WIP of making purple/ an extension?
23:59:50 <flo-retina> IIRC that was challenging, but I think the most annoying issue I had at the time no longer exists, thanks to a c-c-rework change from jcranmer