#instantbird log on 12 25 2013

All times are UTC.

00:04:42 <-- qlum has quit (Client exited)
00:22:37 <-- skeledrew1 has quit (Connection reset by peer)
00:46:49 <-- gerard-majax__ has quit (Connection reset by peer)
00:46:54 --> gerard-majax_ has joined #instantbird
01:24:02 --> Suiseiseki has joined #instantbird
04:05:46 <instant-buildbot> build #1060 of linux-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1060
06:23:44 --> hadi has joined #instantbird
06:55:30 --> BWMerlin has joined #instantbird
07:13:28 <instant-buildbot> build #1467 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/1467
08:00:41 <instant-buildbot> build #1210 of win32-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1210
08:46:21 --> Mic has joined #instantbird
08:46:40 * Mic is now known as Mic2
09:00:54 --> GeKo has joined #instantbird
09:21:59 <-- GeKo has quit (Quit: leaving)
09:23:53 --> Tonnes has joined #instantbird
10:59:25 <-- Mic2 has quit (Quit: Mic2)
11:02:29 --> qlum has joined #instantbird
11:06:31 <-- Suiseiseki has quit (Client exited)
11:08:42 --> GeKo has joined #instantbird
11:08:53 <-- GeKo has quit (Quit: leaving)
11:10:50 --> Suiseiseki has joined #instantbird
11:13:27 --> flo-linux has joined #instantbird
11:14:03 --> GeKo has joined #instantbird
11:17:19 <flo-retina> https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=12016 is better (the summary is OK)
11:17:30 <flo-retina> not sure why comment 1 is still broken :(
11:17:49 <flo-retina> less broken than in https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=12015 though
11:20:42 <flo-retina> on https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=12017 the • are correct, except when creating attachments :-S
11:27:58 <flo-retina> looks a lot like https://bugzilla.mozilla.org/show_bug.cgi?id=731528
11:48:28 <-- Suiseiseki has quit (Ping timeout)
11:49:24 <flo-retina> I pushed the changes to produce https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=12019
12:06:13 --> Suiseiseki has joined #instantbird
12:50:07 <-- flo-linux has quit (Client exited)
14:42:34 <-- qlum has quit (Quit: Getting the <censored> out.)
14:42:37 --> qlum has joined #instantbird
15:05:58 <qlum> does anyone here have experience with bouncers as I can't seem to get znc to work with instantbird.
15:46:11 <-- GeKo has quit (Ping timeout)
15:54:20 --> GeKo has joined #instantbird
15:58:27 --> mconley has joined #instantbird
15:59:00 <qlum> update: I went to the znc irc channel and asked about it and someone else who tested it confirmed it not working
15:59:07 <qlum> by testing it himself
15:59:38 <qlum> here is a log of my attempt: http://pastebin.mozilla.org/3860133
16:00:51 <qlum> ah never mid seems it was already reported
16:02:38 <-- mconley has quit (Input/output error)
16:09:36 <-- gerard-majax_ has quit (Quit: Ex-Chat)
16:09:43 --> gerard-majax__ has joined #instantbird
16:16:47 <flo-retina> qlum: instantbird and ZNC are known to work (relatively) well together
16:17:18 <flo-retina> qlum: you likely need to set your server password from about:config
16:17:25 <qlum> I had to use that yea
16:18:12 <flo-retina> clokep may be interested in looking at your debug log anyway, to see if there's anything we can easily improve
16:24:29 <qlum> made a post on the thread
16:26:11 <flo-retina> great, thanks :)
16:48:02 <-- BWMerlin has quit (Quit: BWMerlin)
17:14:28 --> wnayes has joined #instantbird
17:27:17 --> mconley has joined #instantbird
17:28:48 <-- mconley has quit (Input/output error)
18:06:05 <-- qlum has quit (Ping timeout)
18:06:49 --> qlum has joined #instantbird
18:15:00 --> clokep has joined #instantbird
18:15:00 * ChanServ sets mode +o clokep 
19:21:19 --> qheaden has joined #instantbird
19:30:07 <flo-retina> we've got 31 bugs that we fail to 'transform'
19:30:18 --> flo-linux has joined #instantbird
19:30:24 <flo-linux> http://pastebin.instantbird.com/499974
19:31:38 <qheaden> Hello.
19:34:19 <flo-linux> ERROR: Unknown product: purplexpcom
19:34:24 <flo-linux> that shouldn't be too difficult to fix :)
19:38:58 <flo-retina> ok, that single renamed "purplexpcom" product was the cause of all 31 errors! :)
19:39:26 <clokep> :)
19:39:32 <clokep> Did I misname something?
19:39:36 <flo-retina> no
19:39:46 <flo-retina> My guess is we renamed "purplexpcom" into "core" at some point
19:40:52 <clokep> Ah, that sounds likely.
19:40:59 <clokep> That Unicode bug looks annoying. :-/
19:41:02 <clokep> I'm glad you fixed it.
19:41:10 <flo-linux> clokep: http://pastebin.instantbird.com/499975 is all I had to do to fix it
19:41:32 <flo-retina> clokep: the part that annoys me is: https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=12017#c1
19:41:57 <clokep> flo-retina: Whoa, what's going on there.
19:42:31 <flo-retina> clokep: My guess is "BzAPI" has an encoding bug on "POST /attachment" :(
19:42:40 <clokep> :(
19:42:46 <flo-retina> not sure though
19:42:55 <flo-retina> it was filed as https://bugzilla.mozilla.org/show_bug.cgi?id=731528
19:43:12 <flo-retina> and then the guy says the patch that's already in the BzAPI repo fixed it
19:43:26 <flo-retina> I don't see how that patch would apply only to attachments though :-S
19:45:45 <clokep> Is it possible the BzAPI plug-in on landfill is out of date?
19:46:07 <flo-linux> clokep: the result of the Makefile I just pushed: http://pastebin.instantbird.com/499976
19:46:20 <flo-linux> We've got 21k events to replay
19:46:30 <instantbot> clokep@gmail.com set the Resolution field on bug 1807 to WONTFIX.
19:46:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1807 tri, --, ---, nobody, RESO WONTFIX, An option of VKontakte (ВКонтакте) icon
19:46:55 <flo-retina> heh, messing with my test cases? :)
19:47:08 <clokep> flo-retina: I've closed 2 or 3 bugs already from this. ;)
19:47:13 <flo-retina> :)
19:47:34 <clokep> flo-retina: Does the merge.js script take too much memory or...?
19:48:14 <flo-retina> I think if everything go right, assuming BMO takes 1-2s per request, we will need to 6-10hours to run the import
19:48:22 <flo-retina> clokep: I haven't tried merge.js yet
19:48:36 <clokep> that's long but not insane. :)
19:48:54 <flo-retina> but I don't think merge.js should deal with file I/O
19:49:04 <flo-retina> my current Makefile just does a cat on all the transformed files
19:49:15 <flo-retina> (and slices/transforms using all cores :))
19:49:43 <clokep> True.
19:49:54 <clokep> Nice. :)
19:49:59 <clokep> What's the file? Is it checked in?
19:50:08 <flo-retina> the Makefile? I just pushde it
19:50:19 --> mikk_s has joined #instantbird
19:50:29 <flo-retina> it runs in 26s on my modern desktop hardware
19:50:43 <-- mikk_s has left #instantbird ()
19:50:49 <flo-linux> $ time ./js merge.js < events.json events-merged.json 
19:50:49 <flo-linux> merge.js:51:6 TypeError: events[(intermediate value)].data.comments is undefined
19:50:49 <flo-linux> real	0m1.307s
19:52:22 <flo-retina> if I comment out the part of merge.js dealing with combining comments / finding duplicate events, it runs in 1.46s :)
19:52:31 <flo-retina> so I guess memory usage is irrelevant
19:52:42 <flo-retina> the input file weights 121MB. I've got 32GB of ram ;)
19:52:52 <clokep> I understand like a 1/3rd of that. :P
19:53:03 <flo-retina> "that"?
19:53:04 <clokep> I think we'll be OK!
19:53:08 <clokep> The makefile.
19:53:19 <flo-retina> is there some dark gmake magic there?
19:53:28 <clokep> Nope.
19:53:35 <flo-retina> at this point what really worries me is the UTF8 issue
19:53:36 <clokep> Just lots of giggling going on around me.
19:53:50 <clokep> Is that something we can ask someone about (probably not today)?
19:54:12 <flo-retina> I almost wonder if we should think about using an ascii character instead of •
19:54:28 <flo-retina> and then, detect if some comments made while attaching contain non-ascii characters, and in that case post the comment separately
19:54:29 <clokep> I'm not sure I love the • actually. :-/
19:54:40 <clokep> We could do that, yes.
19:54:41 <flo-retina> well, it uncovered interesting issues :)
19:54:59 <flo-retina> that's a backup plan in we can't figure out the real issue
19:55:05 <flo-retina> s/issue/fix/
19:55:51 <flo-retina> there hasn't been much visible progress yet today because I spent an awful lot of time trying to setup https://wiki.mozilla.org/BMO/DeveloperBox, and then BzAPI on it
19:55:59 <flo-retina> (and I still fail to import the BMO database dump)
19:56:09 <flo-retina> (so I think my testing will happen on a BMO install without existing bugs)
19:56:28 <flo-retina> (assuming I manage to get BzAPI running; which isn't sure yet at this point)
19:56:50 <clokep> :-/
19:56:54 <clokep> Once you run it once it'll have bugs in it. :P
19:56:58 <flo-retina> (and I already hate CPAN)
19:57:42 <clokep> Have you tried replaying multiple bugs at once?
19:57:49 <clokep> We still need to do the replacing of bug #s. ::-/
19:58:08 <flo-retina> clokep: not yet!
19:58:20 <flo-retina> clokep: I wanted to start working on merge.js
19:58:36 <flo-retina> so I started a makefile that can handle touching multiple bugs at once
19:59:05 <flo-retina> anyway, it's been nice to verify that our existing scripts (didn't) work on all bugs :)
19:59:45 <clokep> But easily fixed!
20:00:17 <flo-retina> yeah :)
20:00:21 <flo-retina> I also want to work on replay.js
20:00:40 <flo-retina> I want to change it so that it can restart wherever it stopped during the previous run
20:00:49 <flo-retina> so output the bug/attachment maps
20:00:51 <flo-retina> and progress info
20:00:52 <clokep> :)
20:01:00 <clokep> Take a line number input?
20:01:47 <flo-retina> I was thinking of making the print()'ed output valid JS code
20:02:05 <flo-retina> with ++i; // <description of what happened> each time we finish an action successfully
20:04:28 <-- clokep has quit (Ping timeout)
20:37:21 --> Mic has joined #instantbird
20:37:36 * Mic is now known as MIc2
20:37:39 * MIc2 is now known as Mic2
20:38:47 <-- wnayes has quit (Ping timeout)
20:42:29 --> wnayes has joined #instantbird
20:48:25 <Mic2> Bug 2294 looks bad :(
20:48:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2294 maj, --, ---, nobody, NEW, When leaving the stable version in Russian disappears twitter!
20:51:22 <Mic2> I'm currently checking if this is only a problem of the russian locale or if e.g. the german one is also missing Twitter.
20:51:22 <flo-retina> prpl-B28BB5 ?!? :-S
20:53:02 <Mic2> Works on the german locale.
20:55:12 <flo-retina> Mic2: if you download the ru file and look into the omni.ja, does the twitter.js file look OK?
20:55:33 <Mic2> I'm at it already :)
20:56:36 <Mic2> Yes, it looks like it's OK.
20:56:55 <Mic2> Maybe we messed up with localized protocol names and are creating the prpl id from the localized name or something?
20:57:08 <Mic2> I'll see that I figure it out.
20:58:50 <Mic2> http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#757
20:58:50 <Mic2> http://lxr.instantbird.org/instantbird/source/chat/protocols/twitter/twitter.js#1085
20:58:55 <Mic2> Looks like it imo.
21:10:05 <Mic2> Yes, adding 'get id() "prpl-twitter"' to the TwitterProtocol prototype fixed it.
21:10:08 <Mic2> :(
21:11:38 <flo-retina> that sucks :(
21:11:41 <flo-retina> thanks for debugging it!
21:12:05 <Mic2> np
21:15:54 <flo-retina> Mic2: so I guess we need to add a normalizedName getter
21:16:40 <Mic2> I just suggested to hardcode the id...
21:34:28 <flo-retina> Mic2: I'm saying the normalized name will be broken too if this.name has an unexpected value.
21:34:37 <Mic2> Ah!
21:34:44 <flo-retina> http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#758
21:34:55 <Mic2> "ru" seems to be the only affected locale for Twitter.
21:35:06 <flo-retina> and if we fix the normalized name, then "id" will magically work
21:35:30 <Mic2> I checked twitter.properties for all locales and ru was the only one in which it was translated.
21:36:12 <flo-retina> Twitter isn't the only localized protocol name
21:36:46 <Mic2> Yes, but I haven't seen other problems yet. I didn't have a closer look yet what xmpp and the derived protocols do.
21:36:49 <flo-retina> but it looks like we have fixed normalizedName getters for all the others
21:37:38 <flo-retina> Mic2: So we will fix it for 1.6. I wonder if we should offer an add-on fixing it for 1.5-ru users
21:42:52 <-- GeKo has quit (Quit: leaving)
22:08:18 <flo-retina> clokep: I don't really understand the logic in the current merge.js file.
22:11:31 --> GeKo has joined #instantbird
22:12:39 <-- GeKo has quit (Quit: leaving)
22:12:50 --> GeKo has joined #instantbird
22:34:26 <-- Mic2 has quit (Quit: Mic2)
22:37:59 <flo-retina> pff, the history event for "marked as duplicate" doesn't contain the bug number :(
22:54:26 <flo-retina> clokep's merging of update's with comment's works for almost all DUPLICATE bugs
22:54:31 <flo-retina> "almost" is the problem
22:54:41 <flo-retina> it merges the wrong comment in the case of bug 1383 :(
22:54:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1383 nor, --, ---, nobody, RESO DUPLICATE, Contacts being cut a bit from the lower side
22:55:36 <flo-retina> uh, actually it _eats_ comment 1 :-/
23:08:24 <flo-retina> ok, the bug was trivial
23:08:55 * flo-retina added a comment explaining the issue next to the line of code he moved, so that clokep can see what was going on if he reads the patch I'll commit.
23:22:03 --> dew has joined #instantbird
23:22:42 <-- dew1 has quit (Ping timeout)
23:37:16 <flo-retina> resolving bugs as duplicates is now supported