#instantbird log on 12 24 2013

All times are UTC.

00:00:45 <flo-retina> hmm, we should also merge "flag" with "attach", if the attachment number is the same
00:19:39 <-- mconley has quit (Input/output error)
00:25:27 <-- hadi has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
00:31:22 <clokep> flo-retina: No, that fell victim to my latest change.
00:32:09 <clokep> I just added it back though.
00:32:29 <flo-linux> {"attachment_id":"2704","flags":[{"name":"review","status":"?","requestee":"florian@instantbird.org","type_id":1}],"comments":[{"text":"Originally posted on bio 2104 as attmnt undefined by nhnt11@gmail.com at 2013-08-13 00:38:24 UTC."}],"update_token":"1387845063-45dcbfcd2ada0675db6978f70e722681"}
00:32:29 <flo-linux> ERROR: 500 - Internal Server Error
00:32:31 <flo-linux> hmm
00:32:35 <clokep> Yeah, the objects I have have flags already. soo....
00:32:40 <clokep> I couldn't test thta. :)
00:32:47 <flo-linux> clokep: I removed that
00:32:55 <clokep> :) OK.
00:32:57 <clokep> I'll pull again soon.
00:33:04 <clokep> Tryingto arrange some tables in the dining room to fit 20 people...
00:33:05 <flo-linux> not pushed yet
00:33:08 <clokep> (Well 19 + 1)
00:33:12 <flo-linux> I would like to not have "error 500" ;)
00:34:23 <flo-linux> anything obviously wrong in that request?
00:34:36 <flo-linux> (the comment is obviously wrong, but I don't see why that would cause an error 500)
00:35:11 <flo-retina> aaah, the attachment number isn't mapped!
00:39:00 <flo-retina> and I'm using POST instead of PUT :-S
00:40:01 <flo-retina> hmm, no, it was my debug logging that was broken
00:40:06 <flo-retina> I'm actually using PUT
00:51:58 <flo-retina> I wonder how many silly mistakes I can make on the same request
00:59:40 <flo-retina> aaaah "     Due to limitations in Bugzilla, when updating attachments (including their flags), you must post back the entire object, otherwise Bugzilla will complain about missing fields. This limitation may be removed in future. "
01:01:02 <clokep> Eek.
01:02:58 <flo-retina> I marked an attachment as obsolete! https://landfill.bugzilla.org/bzapi_sandbox/show_activity.cgi?id=11962 :)
01:03:19 <clokep> flo-linux: Congrats. :)
01:03:36 <flo-retina> clokep: it's actually less painful than it seems, because I'm already doing a request to get the update token... so I can just "forget to filter everything else out".
01:03:48 <flo-retina> I would like to remove the attachment data though...
01:04:26 <clokep> Hmmm.... att.flags is undefined, slice:143:2
01:04:31 <flo-retina> ah, looks like I don't get the attachment data without explicitly asking for it
01:04:44 <flo-retina> not sure what that is
01:04:49 <flo-retina> I haven't pushed anything yet
01:04:55 <flo-retina> and I'm changing much of the flags stuff ;)
01:05:08 <clokep> I figured that. :)
01:05:14 <clokep> I'm not sure what to work on next.
01:06:12 <flo-retina> I still get "500 - internal server error" when setting flags :'(
01:06:43 <flo-retina> if that helps I guess I can push my stuff, with the sending of attachment flags commented out
01:06:54 <flo-retina> (it will still mark patches as obsolete, change attachment descriptions, etc...)
01:07:20 <clokep> Sure.
01:10:39 <flo-retina> done
01:10:49 <flo-retina> now you can tell me if what I've done is crazy ;)
01:11:48 <flo-retina> I don't want this line: http://hg.instantbird.org/bio-merge/rev/7bab8ebecbe5#l1.32 But there was a broken comment added there automatically. Any idea of the cause?
01:12:14 <flo-retina> what really bothers me is the error 500 when setting flags though :-/
01:12:49 <clokep> Hmm....no, I'm not sure.
01:13:01 <flo-retina> not sure if it's crazy? :)
01:14:07 <clokep> I don't see anything crazy.
01:14:17 <clokep> It's annoying thta we have to request the attachment again though. :-\
01:15:28 <flo-retina> we don't get the attachment data
01:15:36 <flo-retina> it's just the metadata that gets downloaded
01:15:37 <flo-retina> so it's not too bad
01:16:09 <flo-retina> https://landfill.bugzilla.org/bzapi_sandbox/show_activity.cgi?id=11964 :)
01:16:11 <clokep> That's annoying in terms of async-ness.
01:16:19 <flo-retina> so the good news is: it's only setting review requests that is broken.
01:16:23 <flo-retina> setting r+ works.
01:17:16 <clokep> Wow, bu g 507 is 150 events.
01:17:37 <flo-linux> so "flags":[{"name":"review","status":"+","type_id":1}] is OK
01:17:52 --> BWMerlin has joined #instantbird
01:18:09 <flo-linux> but "flags":[{"name":"review","status":"?","requestee":"florian@mailinator.com","type_id":1}] is not
01:18:44 <clokep> flo-retina: Should it be requestee: {"name": "florian@mailinator.com"}?
01:18:56 <flo-retina> great idea!
01:19:08 <flo-retina> I was about to say "I'm tempted to set a review request by hand, and then download the attachment"
01:19:31 <clokep> So line 85, just remove the .name
01:19:35 <clokep> of transform.js.
01:19:51 <flo-retina> btw, it's really super super painful that the format of attachment related stuff is completely different in the history and in the attachment requests
01:20:15 <clokep> :-\
01:20:59 <flo-retina> https://landfill.bugzilla.org/bzapi_sandbox/show_activity.cgi?id=11965 !!! \o/
01:21:03 <flo-retina> clokep: Thanks!
01:21:18 * clokep feels useful. :)
01:21:50 <flo-retina> s/feels/is/ !
01:21:53 <clokep> Woot! :)
01:21:57 <flo-retina> pushed the update
01:22:07 <flo-retina> setting flags mostly works now
01:22:26 <flo-retina> next I'll work on the corner cases (removing a flag, setting multiple flags, etc...)
01:24:24 <flo-retina> would be great if you could comment out that FIXME line about the comment in the "flag" request, and see why we get this broken comment: https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11967#c2
01:25:58 <clokep> flo-retina: So settings flags is supposed to work now or no?
01:26:09 <flo-retina> the general case works
01:26:14 <flo-retina> edge cases aren't handled
01:26:25 <clokep> Oh...hmmm...can comments be added with flags?
01:26:26 <flo-retina> have you seen a case you expected to see working that didn't?
01:26:36 <flo-retina> sure, why not?
01:27:02 <clokep> https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11966 doesn't include my comment giving the r+, but https://landfill.bugzilla.org/bzapi_sandbox/show_activity.cgi?id=11966 shows I did r+ it.
01:27:18 <-- skeledrew has quit (Ping timeout)
01:27:29 --> skeledrew has joined #instantbird
01:27:35 <clokep> (I.e. https://bugzilla.instantbird.org/show_bug.cgi?id=990#c10)
01:27:37 <instantbot> Bug 990 nor, --, 1.1, florian, RESO FIXED, Closing a conversation window with unread messages shouldn't warn if the "hidden conversations" feat
01:27:38 <flo-retina> are all these "Originally posted on bio 2104 as attmnt undefined by nhnt11@gmail.com at
01:27:38 <flo-retina> 2013-08-23 23:19:34 UTC." comments we really want (then we need to fix the 'undefined' in there), or comments that we should get rid of?
01:28:14 <flo-retina> that's because of: http://hg.instantbird.org/bio-merge/rev/7bab8ebecbe5#l1.32
01:28:26 <clokep> Oh! OK. :)
01:28:35 <clokep> I'll look at that next then.
01:28:39 <flo-retina> you can comment it to get a behavior like https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11967#c2
01:28:43 <clokep> Umm...Idk if they're necessary ornot.
01:29:01 <flo-retina> hmm, they may be, I guess requesting from instantbot isn't nice
01:29:26 <flo-retina> maybe we could shorten the wording?
01:29:38 <clokep> Go for it.
01:29:50 <flo-retina> "Originally change on bio 2104 attmnt NNN by nhnt11@gmail.com at
01:29:50 <flo-retina> 2013-08-23 23:19:34 UTC." seems better
01:30:00 <-- skeledrew has quit (Connection reset by peer)
01:30:04 --> skeledrew has joined #instantbird
01:30:10 <flo-retina> (I replaced "Originally posted" by "Original change" and removed the "as ")
01:30:32 <flo-retina> are you doing it, or should I?
01:30:40 <clokep> Doing what?
01:30:49 <clokep> Changing the wording? I am not doing that.
01:31:33 <flo-retina> ok, I'm doing it, and fixing the "undefined" while I'm at it
01:31:37 <clokep> Cool https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11968#c10 :)
01:31:49 <flo-retina> the next thing you could look at is: https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11967#c0
01:31:53 <clokep> OK, so that worked by commenting out that delete comments line.
01:31:59 <clokep> What bug did that break on? 2104?
01:32:12 <flo-retina> the line "Created attachment 2704" is wrong
01:32:23 <flo-retina> did what break on?
01:32:34 <-- skeledrew has quit (Client exited)
01:32:44 <clokep> flo-retina: http://hg.instantbird.org/bio-merge/rev/7bab8ebecbe5#l1.32
01:35:39 <flo-retina> I mostly removed it while trying to reduce the possible causes of the error 500
01:35:52 --> skeledrew has joined #instantbird
01:36:14 <clokep> OK.
01:36:31 <flo-retina> clokep: I think I got it working: https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11969#c2
01:37:06 <clokep> flo-retina: Nice. :) Can we file an attachment while filing a bug or no?
01:37:21 <flo-retina> on BIO yes. On BzAPI, no.
01:37:38 <flo-retina> (at least the third time I say this ;))
01:37:46 <flo-retina> pushed
01:39:10 <flo-retina> so, what are you working on now?
01:39:53 <flo-retina> oops, there's something wrong on: https://landfill.bugzilla.org/bzapi_sandbox/show_activity.cgi?id=11969
01:40:16 <flo-retina> setting a flag to r+ doesn't remove the request
01:40:34 <-- skeledrew has quit (Ping timeout)
01:40:34 <clokep> flo-retina: Looking at the comment being funky when you file a bug and add an attachment.
01:40:44 <flo-retina> great, thanks
01:40:44 --> skeledrew has joined #instantbird
01:41:54 <flo-retina> clokep: In that annoying case we can't help ending up with 2 comments instead of one.
01:42:23 <flo-retina> so I guess we just need to decide which of the 2 gets the real text
01:42:34 <flo-retina> and fill the other one with an insult for BzAPI ;)
01:43:32 <clokep> flo-retina: Yeah, I assume you HAVE to have a comment when you file a bug?
01:43:51 <flo-retina> not on BMO
01:44:01 <flo-retina> (but that creates an empty one)
01:44:14 <flo-retina> on BIO I think a bug description is mandatory
01:44:47 <clokep> OK.
01:44:56 <flo-retina> should we start making an etherpad with what's left to do?
01:45:11 <flo-retina> and the test cases we want to try again after fixing stuff?
01:47:29 <flo-retina> (I'm working now on handling multiple flags)
01:48:21 <flo-retina> I think after finishing the stuff we are both working on, we will be very close to looking at filing more than one bug at once, and setting dependencies between them.
01:48:42 <flo-retina> and fixing bug/attachment numbers inside comments
01:51:23 <flo-retina> handling the blocking flags (see https://bugzilla.instantbird.org/show_activity.cgi?id=151 for an example) may be painful. I think we said we wanted to convert them to status whiteboard annotations
01:51:32 <clokep> flo-retina: Possibly. I was thinking we shld start striking things out on the etherpad we made already.
01:51:49 <clokep> I didn't know we ever even had those.
01:51:50 <flo-retina> I don't think the existing etherpad is good as a todo list
01:51:54 <flo-retina> it's more an overall plan
01:53:05 <flo-retina> see https://bugzilla.instantbird.org/buglist.cgi?quicksearch=ALL%20flag%3Ablock&list_id=6195 for a list of bugs with flags
01:53:26 <flo-retina> if we get out of time and don't handle them, I think I won't be too disappointed though ;)
01:53:33 <flo-retina> they are all resolved anyway
01:53:36 <clokep> OK.
01:53:43 <flo-retina> and some already have whiteboard annotations
01:53:59 <flo-retina> another thing we could do is just set the whiteboard by hand on BIO before the final import
01:54:33 <clokep> Which ever is easier we should do.
01:54:37 <flo-retina> if we are 4 and take 7 bugs each, it should be quick
01:55:26 <clokep> OK. :)
01:55:53 <flo-retina> we will need to check that our scripts don't break on these bugs (even if they drop some data on the floor)à
01:56:33 <clokep> flo-retina: https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11970 so this adds the attachment comment appropriately to when the attachment is added.
01:57:06 <clokep> But it breaks on https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11971
01:57:33 <flo-retina> is it difficult to add a comment in the description, saying that due to BzAPI limitations, the original description is shifted to comment 1?
01:59:12 <clokep> Um, probably not.
01:59:49 <-- skeledrew has quit (Ping timeout)
02:06:11 <clokep> flo-retina: https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11974#c0
02:07:42 <flo-retina> would the comment fit on 1 line if we replaced "Because of limitations in BzAPI" by "Because BzAPI limitations"?
02:08:13 <flo-retina> I'm also wondering if we shouldn't prefix all the automatically-added comments
02:08:21 <flo-retina> maybe "# "?
02:08:44 <flo-retina> or put in ()?
02:09:13 <clokep> Possibly.
02:09:38 --> skeledrew has joined #instantbird
02:13:09 <clokep> OK I've pushed my latest change.
02:14:32 <clokep> flo-retina: Did you want to list out what's left?
02:14:45 <flo-retina> I think it can be useful, yes
02:15:57 <flo-linux> what's the   // XXX Sort by author name here?
02:16:14 <clokep> Oh, I was concerned if two people had the same exact time funny things would happen.
02:16:30 <clokep> But they will hopefully just remain in the same order we pulled them.
02:16:50 <flo-linux> I don't know if the sort we have is a stable sort or not
02:17:55 <clokep> :-/ I'm not sure either.
02:21:18 <flo-retina> I'm surprised by how few lines I need to touch to change significantly the logic of what the code does
02:21:32 <clokep> :-\
02:21:47 <flo-retina> I think I'm done with the parsing of multiple flags in slice.js
02:21:51 <clokep> :)
02:22:05 <flo-retina> now I need to see if I can apply it in replay.js :)
02:22:09 <flo-retina> and then test until it works :-|
02:22:25 <flo-retina> want me to pause and write with you the list of stuff left to do?
02:22:42 <clokep> If you're in a good spot, I think that'd be helpful.
02:22:59 <flo-linux> ok, where is the pad? :)
02:23:22 <clokep> flo-retina: https://etherpad.mozilla.org/bugzilla-instantbird-todo
02:28:53 <clokep> Hmm....I guess the first part of multiple bugs at once is taking all the events and sorting them?
02:29:30 <flo-linux> clokep: what am I missing?
02:29:39 <flo-linux> (except food in my stomach :-S)
02:30:32 <flo-linux> clokep: sorting them is trivial. We just need to "cat *.transformed" and sort all the events of the resulting stream by date.
02:30:39 <flo-linux> I guess that sorting is the role of merge.js
02:30:52 <flo-linux> that script should also get rid of duplicate events for dependencies
02:31:38 <clokep> Is that the only other deduplication that is needed?
02:31:50 <flo-linux> it's the only one I have in mind
02:32:04 <flo-linux> doesn't mean there aren't others
02:32:09 <clokep> OK.
02:32:26 <flo-linux> btw, I think we are surprisingly close to being done :)
02:32:45 <flo-linux> "surprisingly" because we haven't tested on many bugs yet.
02:32:57 <flo-linux> but I don't see many things that we haven't touched yet.
02:34:02 <clokep> :)
02:34:22 <flo-linux> the multiple flags thing is the last area that feels "unknown" for me
02:34:23 <clokep> flo-linux: I think everything I can think of is on there...
02:34:39 <clokep> I think the bug / attachment #s stuff will be painful.
02:34:43 <clokep> More so than we think.
02:34:44 <flo-linux> the dependency dedup is a bit unknown too, but I can't think of any reason why that would be difficult
02:34:47 <clokep> But not that /hard/, just annoying.
02:35:29 <flo-linux> are we completely done with the merging of events inside a single bug?
02:35:59 <flo-linux> just added another idea: resolving bugs as duplications. That puts stuff in both bugs!
02:36:23 <clokep> Ah true! :)
02:36:24 <flo-linux> we will likely have some comments/events to get rid of
02:36:31 <clokep> Umm....I want to say "yes", but I'm not positive. :-/
02:37:21 <flo-linux> I think I'm a bit lost on which cases are handled and which cases aren't :-/
02:37:40 <clokep> Which cases need to be handled?
02:37:50 <flo-linux> likely because I haven't fully read your code :)
02:38:21 <clokep> It works for: merging a comment into an attach, merging a comment into flag, merging a comment into file.
02:38:42 <flo-linux> what about update?
02:39:24 <clokep> Umm....I believe it will work too.
02:39:56 <clokep> Do you happen to know a test case?
02:40:03 <flo-linux> hmm
02:40:38 <flo-linux> resolving a bug as fixed and posting a checkin url?
02:41:00 <clokep> flo-linux: Doesn't work for update right now at least...
02:41:08 <clokep> One second, might just need to tweak one thing.
02:42:37 <clokep> flo-linux: OK, fixed that. :)
02:42:46 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
02:43:08 <flo-linux> cool :)
02:43:17 <clokep> Just had to change the sort order of them.
02:43:46 <flo-linux> I like that our code is often easy to fix :)
02:44:29 <clokep> I'm going to take a look at doing the other fields, That should be easy to map.
02:44:44 <flo-retina> ok
02:45:40 <clokep> Do we care about votes?
02:45:45 <flo-retina> (btw, in case you are wondering if there's a rationale between me talking from flo-linux or flo-retina: both keyboards are 20cm from each other, so I talk from the machine where having the Ib conv window shown is the least disturbing)
02:45:56 <flo-retina> clokep: BzAPI doesn't support votes, so it's a problem solved ;)
02:46:03 <clokep> :)
02:48:00 <clokep> :-S
02:48:09 <clokep> flo-retina: $ ./run.sh 999
02:48:09 <clokep> slice.js:151:0 TypeError: obj.attachments is undefined
02:50:54 <clokep> Looks like anything w/o attachments get that bug.
02:54:21 <clokep> flo-retina: Are you stripping the platform/op_sys somewhere right now?
02:54:41 <clokep> (I can't find anywhere we're doing it, but I'm surprised it works on landfill then.)
02:55:12 <flo-retina> I think for most cases they are compatible
02:55:20 <flo-retina> the only problematic case is likely WinCE
02:55:36 <flo-retina> and Mac OS X versions
02:56:33 <clokep> It's all summarized in https://bmo.etherpad.mozilla.org/bugzilla-instantbird-merge
02:56:39 <clokep> But that didn't answer my question at all. :-D
03:01:33 <dew> the merge is coming!
03:04:31 <flo-retina> clokep: so what was the question?
03:04:42 <flo-retina> dew: it's coming one line of code at a time ;)
03:04:44 <clokep> flo-retina: I figured it out. :)
03:04:53 <clokep> flo-retina: I was wondering how all our bugs were working w/o mapping OS and platform!
03:05:01 <clokep> Turns out that landfill has like everything possible listed. ;)
03:05:07 <clokep> But I found some bugs that didn't work. :)
03:05:09 <flo-retina> my multiple attachment stuff doesn't work at all (which isn't really a surprise on the first attempt that doesn't fail with a JS error :-D)
03:06:54 <clokep> That was easy. :)
03:08:29 <flo-retina> are we merging attach+flag?
03:09:01 <clokep> No.
03:09:08 <clokep> Maybe?
03:09:12 <clokep> No.
03:09:13 <clokep> We're not.
03:09:29 --> deomega has joined #instantbird
03:09:45 <clokep> Maybe I misunderstood, but I thought we weren't supposed to?
03:11:51 <flo-retina> why not?
03:12:56 <instantbot> clokep@gmail.com set the Resolution field on bug 1200 to WORKSFORME.
03:12:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1200 nor, --, ---, nobody, RESO WORKSFORME, "Error: account is null" at startup
03:12:59 <clokep> Idk, this whole merging thing has confused me.
03:13:11 <flo-retina> I wonder how many testing bugs we have filed today :)
03:14:03 <clokep> A couple hundred, I think?
03:14:12 <clokep> OK, I just fixed for bugs that don't have any attachments.
03:14:26 <flo-retina> :)
03:14:38 <clokep> Quick null check. ;)
03:15:20 <clokep> flo-retina: Lines 198 - 200 of slice.js...no we don't merge them. ;)
03:15:36 <clokep> Do you have a test case for this?
03:16:41 <flo-retina> clokep: requesting review on a patch one attaches ;)
03:16:54 <clokep> I meant a bug #. :P
03:17:05 <clokep> 2104 probably has that.
03:17:08 <flo-retina> I would be surprised if 2091 didn't do it
03:17:20 <flo-retina> (it's the one I'm debugging my stuff on)
03:17:33 <clokep> It does.
03:20:35 <flo-retina> https://landfill.bugzilla.org/bzapi_sandbox/show_activity.cgi?id=11987 looks correct, doesn't it? :)
03:21:38 <flo-retina> ah, no, the review request on aleth is missing :(
03:21:55 <flo-retina> well, at least I'm correctly cancelling the pending request when r-'ing! :)
03:22:15 <clokep> :)
03:23:27 <flo-retina> crap, " You can't set the same (multi-settable) flag twice on a single attachment submission " :(
03:24:47 * flo-retina is disappointed and needs to rethink his approach (find a new workaround!)
03:25:56 <flo-retina> let's see what I get on https://bugzilla.instantbird.org/show_activity.cgi?id=1827
03:30:22 * clokep mumbles.
03:30:29 <clokep> I broke a bunch of stuff and have no idea how...
03:31:43 <flo-retina> https://landfill.bugzilla.org/bzapi_sandbox/show_activity.cgi?id=11988 is not what I expected
03:32:32 <flo-retina> it looks like marking an attachment obsolete confuses the script
03:32:59 <flo-retina> hmm, I guess the feedback -> super-review also confuses things (or needs some mapping)
03:33:53 <flo-retina> I'm tempted to just add the feedback flag on landfill
03:35:34 <flo-retina> done
03:35:55 <flo-retina> let's try again and see if the results are less confusing
03:37:56 * clokep is confused. :(
03:39:09 <-- wnayes has quit (Quit: wnayes)
03:39:24 <flo-retina> https://landfill.bugzilla.org/bzapi_sandbox/show_activity.cgi?id=11989 is better
03:39:28 <flo-retina> clokep: confused by what?
03:39:40 <clokep> About what I broke. :-D
03:39:44 <flo-retina> ah
03:40:01 <flo-retina> I'm still confused by the differences between https://bugzilla.instantbird.org/show_activity.cgi?id=1827 and https://landfill.bugzilla.org/bzapi_sandbox/show_activity.cgi?id=11989
03:40:59 <flo-retina> the "Attachment is patch " and " Attachment mime type " changes are missing
03:41:03 <flo-retina> I don't know why
03:41:21 <flo-retina> then the script breaks at some point, and stops doing requests
03:41:35 <clokep> :-/
03:42:11 <flo-retina> ah, that's when removing flags that don't exist :)
03:44:34 <flo-retina> when I see the time it takes to import such a bug, I'm worried that our scripts may run for several days to do the real import :(
03:44:52 <flo-retina> ahah, now it ends in "500 - Internal Server Error" awesome -_-'
03:45:03 <clokep> AH! I fiured it out.
03:45:06 <clokep> I'm dumb. :-D
03:45:47 <flo-retina> ok, the error 500 is when trying to update the depends_on field
03:45:55 <flo-retina> we currently drop "blocks" but not "depends_on"
03:46:02 <flo-retina> so when a bug has dependencies, we do crazy stuff
03:46:15 <clokep> :)
03:48:23 <flo-retina> hmm, maybe I should commit my stuff before going into a hack to workaround the "You can't set the same (multi-settable) flag twice on a single attachment submission" limitation
03:48:44 <clokep> I've been trying to keep my commits as small as possible.
03:51:17 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
03:52:30 <flo-retina> ok, https://landfill.bugzilla.org/bzapi_sandbox/show_activity.cgi?id=11994 isn't so bad, time to push it :)
03:54:56 <flo-retina> clokep: here is my stuff: http://hg.instantbird.org/bio-merge/rev/bf6fb604544f
03:55:58 <clokep> This makes my head hurt.
03:56:36 <flo-retina> my code?
03:56:55 <clokep> Just the flags in general. :-D
03:57:06 <clokep> Doesn't look totally insane.
03:57:11 <flo-retina> that's also the case for me
03:57:24 <flo-retina> well, the next step will be insane :)
03:57:32 <flo-retina> with "flag" calling itself recursively :-S
03:58:07 <clokep> (o_O)
03:58:14 <clokep> Inception flags?
04:03:33 <instant-buildbot> build #1059 of linux-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1059
04:04:12 <clokep> flo-retina: https://landfill.bugzilla.org/bzapi_sandbox/show_activity.cgi?id=11995
04:04:17 <clokep> Looks correct to me. :)
04:04:25 <clokep> (Minus the target milestone)
04:04:39 <clokep> And the attachment isn't set obsolete, is that supposed to work yet?
04:06:18 <clokep> (I pulled in your latest before running btw)
04:07:23 <flo-retina> setting attachment to obsolete works, yes
04:07:29 <clokep> http://hg.instantbird.org/bio-merge/rev/1d82e40765db will merge flag and attach together.
04:07:33 <clokep> Uh-oh...did I break that then.
04:07:40 <flo-retina> it happened on https://landfill.bugzilla.org/bzapi_sandbox/show_activity.cgi?id=11994
04:08:10 <flo-retina> but I'm surprised that neither Attachment is patch  nor Attachment mime type  or  Attachment description does...
04:08:14 <flo-retina> so I need to debug something there
04:09:40 <flo-retina> https://landfill.bugzilla.org/bzapi_sandbox/show_activity.cgi?id=11996 now with a recursive call to add the second feedback? flag !
04:10:02 <flo-retina> I guess I should now try https://bugzilla.instantbird.org/show_activity.cgi?id=2091 again
04:11:44 <flo-retina> gives https://landfill.bugzilla.org/bzapi_sandbox/show_activity.cgi?id=11998
04:11:47 <flo-retina> that seems good to me!
04:12:53 <flo-retina> pushed that
04:13:43 <flo-retina> clokep: BMO doesn't have Macintosh and PC?
04:14:13 <clokep> flo-retina: According to the etherpad, no.
04:14:43 <flo-retina> WinCE really exists on both landfill and BMO?
04:15:53 <flo-retina> I guess the next step for me is to figure out why Attachment {is patch, mime type, description} doesn't work.
04:15:59 <clokep> Umm...I don't know if I checked landfill or not.
04:16:54 <flo-retina> aaaah, I know!
04:16:57 <flo-retina> it's not that it's broken
04:17:06 <flo-retina> it's that we set them to the final value when creating the attachment
04:17:22 <flo-retina> ok, that needs some undo'ing :-S
04:18:26 <flo-retina> clokep: what's your next step?
04:20:18 <clokep> flo-retina: So I apparently broke obslete, and I have no idea how.
04:20:32 <flo-retina> with local changes?
04:21:49 <clokep> No, with pushed changes. :-/
04:21:59 <clokep> It seemed to break when I merged flags into attachments.
04:22:00 <flo-retina> it still works for me
04:22:07 <flo-retina> maybe there's a specific troublesome test case?
04:22:07 <clokep> Maybe it needed the recursive flags thing?
04:22:15 <flo-retina> it doesn't
04:22:32 <flo-retina> want me to try on the same bug as you did?
04:22:36 <flo-retina> (which one is it?)
04:22:38 <clokep> I'm trying 2104
04:22:59 <flo-retina> trying now
04:23:37 <clokep> Thanks. :)
04:23:44 <flo-retina> same results as you
04:24:24 <flo-retina> it's indeed possible that there's some unfortunate merging happening
04:24:40 <flo-retina> you can't merge flags for different attachments
04:25:38 <clokep> Yeah, I'm wondering if that's what's happening.
04:26:50 <flo-retina> is it possible to create multiple flags of the same type when creating an attachment?
04:26:54 <flo-retina> (I think it isn't on BIO)
04:27:47 <clokep> Comma separated list of emails?
04:29:07 <flo-retina> did that ever work?
04:29:34 <flo-retina> that missing is_obsolete really looks like an unfortunate merging/disappearing
04:29:35 <clokep> I'm 99% sure I've done it.
04:29:43 <clokep> flo-retina: I think I fixed it already.
04:29:50 <flo-retina> clokep: would be nice to find a test case
04:30:01 <clokep> Was 2104 not good enough? :-S
04:30:02 <flo-retina> clokep: if it actually happened, we will need recursive flag setting there too
04:30:14 <clokep> Oh, we're crossing streams.
04:30:38 <flo-retina> O_o
04:30:58 <clokep> (Never seen Ghost Busters?)
04:31:04 <flo-retina> no
04:31:22 * flo-retina wonders if anybody will dare reading the log tomorrow :-D
04:31:46 --> mconley has joined #instantbird
04:32:13 <clokep> http://www.youtube.com/watch?v=jyaLZHiJJnE ;)
04:32:19 <clokep> (It's where the name Venkman comes from btw)
04:32:46 <clokep> (I meant we were both using pronouns to describe two different things though. :-D)
04:34:04 <clokep> OK, that's fixed.
04:40:20 <flo-retina> clokep: can you start merge.js?
04:40:51 <flo-retina> for now I would say the goal there should be pick to bugs that are either duplicate or depend on each other, and get the 2 imported reasonably.
04:41:02 <flo-retina> *two bugs
04:41:04 <clokep> flo-retina: Sure...OK.
04:46:09 <clokep> You have any good examples of that?
04:46:14 <clokep> I can't find any that don't have a huge tree.
04:46:28 <flo-retina> haven't you marked a bunch of bugs as duplicates this morning?
04:46:52 <flo-retina> 15:01:52 - instantbot: clokep@gmail.com set the Resolution field on bug 2291 to DUPLICATE of bug 1195.
04:46:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2291 nor, --, ---, nobody, RESO DUPLICATE, I would like to smile button
04:46:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1195 nor, --, ---, nobody, NEW, Add UI to insert emoticons
04:47:05 <clokep> flo-retina: Yeah those aren't downloaded. :-D
04:47:12 <clokep> I can do that though.
04:47:16 <flo-retina> ah, good point
04:47:17 * clokep was just feeling lazy.
04:47:23 <flo-retina> let's find something else then
04:48:24 <flo-retina> bug 1194 bug 1283?
04:48:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1194 nor, --, ---, nobody, RESO DUPLICATE, Twitter: Add "block" and "report spam" actions
04:48:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1283 enh, --, ---, nobody, NEW, Ability to block / report as spam for Twitter messages
04:48:49 <clokep> That'll work.
04:55:32 <instant-buildbot> build #1460 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/1460
04:57:04 <-- skeledrew has quit (Connection reset by peer)
05:00:38 --> skeledrew has joined #instantbird
05:10:25 * clokep isn't sure if this needs to be done before or after transform.js. :-/
05:10:37 <flo-retina> merge?
05:10:54 <clokep> Yes.
05:11:09 <flo-retina> for the end result it doesn't seem important. But for transform.js's debuggability, doing the merge after seems better
05:11:30 <clokep> I have a feeling we might not want to deal w/ the "Originally..." messages though.
05:12:24 <clokep> Ah, maybe it'll be OK. :)
05:12:36 <flo-retina> what's the problem with them?
05:13:31 <flo-retina> ah, with my changes + your recent patch, https://landfill.bugzilla.org/bzapi_sandbox/show_activity.cgi?id=12006 seems reasonable (compare with https://bugzilla.instantbird.org/show_activity.cgi?id=1827)
05:15:56 <flo-retina> hmm, except we lost the first feedback?(clokep@gmail.com) flag :(
05:16:37 <clokep> :-/
05:18:30 <flo-retina> is that flag request merged with the attach request?
05:21:10 <clokep> Possibly.
05:21:36 <flo-retina> looks like it is (and that it's the reasonable thing to do there)
05:21:49 <flo-retina> so I guess I need to handle setting flags recursively for "attach" requests too.
05:21:53 <flo-retina> fun... :-D
05:22:21 <flo-retina> btw, how did you feel about adding a prefix or something to make auto-generated comment lines easy to distinguish?
05:22:33 <clokep> I think that's very reasonable.
05:22:41 <clokep> Do we also want to add some text to easily query for all these bugs later on?
05:23:00 <flo-retina> and filter out the bugmail?
05:23:01 <clokep> flo-retina: I just pushed the initial merge script, it just sorts and then deduplicates RESOLVED DUPLICATE events.
05:23:11 <flo-retina> :)
05:23:56 <clokep> Oh, and another one that handles bugs w/ no cc list.
05:24:04 <flo-retina> I wonder how much memory merge.js will take :-S
05:24:16 <clokep> Probably a lot. :-(
05:24:26 <clokep> I need to go to bed though, I have an awful headache.
05:24:29 <flo-retina> I have only 32GB
05:25:08 <clokep> :-\
05:25:17 <clokep> flo-retina: Goodnight. I'll talk to you tomorrow at some point.
05:25:36 <flo-retina> any expectation of when/how much you'll be online during the next few hours/days?
05:25:50 <flo-retina> take care, and enjoy being with your family :)
05:25:58 <clokep> Umm...tomorrow morning I'll be online a bit.
05:26:10 <clokep> (Meaning in like 8 hours)
05:26:18 <flo-retina> ok
05:26:21 <clokep> For probably a few hours.
05:26:37 <clokep> Christmas I'll be online a bit during the day, likely. But might not be able to sit down and program.
05:26:46 <clokep> I have no idea about Thursday and Friday, sorry. :-/
05:27:03 <clokep> I'll check the logs and answer questions when I can though!
05:27:51 <flo-retina> ok, good night
05:28:06 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
05:28:07 * flo-retina would like to at least finish that flag thing before getting some rest/food
05:47:36 <-- mconley has quit (Input/output error)
05:54:48 <flo-retina> some prefix tests "#": https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=12010, or "//": https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=12011
05:54:51 <flo-retina> any preference?
05:56:27 <flo-retina> •
06:17:26 <flo-retina> flo-linux: https://bugzilla.mozilla.org/attachment.cgi?id=8349566&action=diff
06:55:11 --> rosonline has joined #instantbird
07:03:46 --> jb has joined #instantbird
07:09:50 <-- jb has quit (Ping timeout)
07:19:21 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
07:33:23 <-- flo-linux has quit (Ping timeout)
07:58:42 <instant-buildbot> build #1209 of win32-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1209
10:33:17 --> jb has joined #instantbird
10:36:32 --> hadi has joined #instantbird
10:43:25 --> hadi1 has joined #instantbird
10:44:18 <-- hadi has quit (Ping timeout)
11:05:21 <-- jb has quit (Ping timeout)
11:31:43 --> deomega has joined #instantbird
11:36:55 <deomega> Good day.  So I was able to resolve the statusbar tweak.  the code is  #convWindow-statusbar {
11:36:55 <deomega>   display: none;
11:36:55 <deomega> }
11:38:38 <deomega> and regarding the antivirus false positive..  Good news:   http://pastebin.instantbird.com/497435
11:40:58 <-- hadi1 has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
12:37:26 --> hadi has joined #instantbird
12:59:09 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
12:59:21 --> deomega has joined #instantbird
13:06:08 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
13:06:15 --> deomega has joined #instantbird
13:07:01 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
13:07:10 --> deomega has joined #instantbird
13:07:40 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
13:07:49 --> deomega has joined #instantbird
13:09:33 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
13:09:41 --> deomega has joined #instantbird
13:12:40 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
13:12:47 --> deomega has joined #instantbird
13:35:50 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
13:35:56 --> deomega has joined #instantbird
13:38:13 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
13:38:22 --> deomega has joined #instantbird
14:27:03 --> nhnt11 has joined #instantbird
14:36:59 <-- nhnt11 has quit (Input/output error)
14:37:06 --> nhnt11 has joined #instantbird
14:37:36 --> clokep has joined #instantbird
14:37:36 * ChanServ sets mode +o clokep 
14:39:04 <clokep> flo-retina: I like the // better than #.
14:39:13 <clokep> But ( ) might be more readable as an aside.
14:39:15 <nhnt11> Hi!
14:39:22 <nhnt11> Is the BIO->BMO stuff complete?
14:39:30 * nhnt11 reads the logs
14:39:35 <clokep> nhnt11: We're working on it.
14:39:40 <clokep> I'd be impressed if you read the logs. ;)
14:39:53 <clokep> deomega: Thanks! :)
14:40:01 <nhnt11> Yeah, looks like a bit much
14:40:45 <clokep> nhnt11: https://etherpad.mozilla.org/bugzilla-instantbird-todo
14:41:11 <nhnt11> flo-retina: Er, by the way, I think I emailed you the wrong password to my BMO account...
14:41:28 <clokep> nhnt11: Can you reply to the email I sent out to both Florian and I? :)
14:41:56 <deomega> clokep: you are welcome
14:42:22 <nhnt11> clokep: The one about sharing my credentials? Ok. Doing it now.
14:42:33 <clokep> :P
14:44:57 <clokep> (Thanks.)
14:57:22 --> Mic has joined #instantbird
14:57:42 * Mic is now known as Mic2
15:02:03 <flo-retina> clokep, Mic2, nhnt11: hello :)
15:02:21 <flo-retina> clokep: I think of the various things I tried, my preferred prefix character is •
15:02:42 <flo-retina> clokep: unfortunately, that caused me to discover that the character encoding is completely broken on xpcshell :(
15:03:01 <flo-retina> clokep: bug 1807 is a good test case for that
15:03:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1807 tri, --, ---, nobody, UNCO, An option of VKontakte (ВКонтакте) icon
15:03:12 <flo-retina> that's the next thing I'm going to fix (nowish)
15:04:15 * flo-retina would also be impressed if nhnt11 (or anybody, really) read the full log :-D
15:06:32 --> flo-linux has joined #instantbird
15:12:46 <Mic2> Hi flo!
15:13:21 <Mic2> I've read yesterday's log, does that count? ;)
15:13:31 <flo-retina> what about today's? ;)
15:14:30 <Mic2> I stopped somewhere in the middle. I thought "oh cool, it's not that much judging from the scrollbar" but it turned out to be more than I expected ;)
15:15:08 <clokep> flo-retina: I'm OK w/ that.
15:15:10 <flo-linux> I think the amount of work is also a bit more than we expected
15:15:24 <flo-linux> clokep: with me fixing UTF8 stuff? ;)
15:15:27 <clokep> The amount of corner cases, yes.
15:15:29 <clokep> flo-linux: With *. :)
15:15:50 <flo-retina> it was •, no * :)
15:15:58 <clokep> Whatever!
15:16:04 <flo-retina> * wouldn't break :)
15:16:07 <Mic2> It seems to be quite some work covering edge-cases ...
15:17:46 <-- clokep has quit (Ping timeout)
15:18:25 <flo-linux> yeah, there's still a significant amount of work to do
15:18:29 <flo-linux> as shown in the todo list
15:18:56 <flo-linux> if but you've clicked our latest landfill links, you can see that we already get a pretty good import when looking at an individual bug
15:19:03 <Mic2> I must have missed that one.
15:19:28 <Mic2> Yes, I saw that the names were right and the history seemed to look good
15:20:49 <flo-retina> the flags were such an headache
15:21:04 <flo-retina> I spent almost the whole night on them
15:21:53 <flo-retina> while clokep was doing awesome work, merging the requests that had no reason to be separate; adding comments where we needed them, and possibly a few other things I don't remember
15:22:00 <flo-retina> (slept only 4hours this night :-])
15:30:10 <-- BWMerlin has quit (Quit: BWMerlin)
15:45:35 --> jb has joined #instantbird
15:49:25 <-- jb has quit (Ping timeout)
16:12:41 --> qlum has joined #instantbird
16:13:14 <-- nhnt11 has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
16:18:44 <-- Tonnes has quit (Connection reset by peer)
16:20:15 <-- skeledrew has quit (Connection reset by peer)
16:21:20 --> skeledrew has joined #instantbird
16:31:06 --> clokep has joined #instantbird
16:31:06 * ChanServ sets mode +o clokep 
16:32:13 <clokep> flo-retina: Honestly I don't even remember what I did either...
16:32:25 <clokep> The merging was kind of painfu. :-/ I'm afraid to look at that code again.
17:11:32 --> jb has joined #instantbird
17:14:15 <Mic2> Merry Christmas to all of you! :)
17:17:15 --> mconley has joined #instantbird
17:17:18 <-- Mic2 has quit (Quit: Mic2)
17:18:58 <-- mconley has quit (Ping timeout)
17:22:09 <-- clokep has quit (Ping timeout)
17:22:34 --> clokep has joined #instantbird
17:22:34 * ChanServ sets mode +o clokep 
17:25:55 <-- clokep has quit (Ping timeout)
17:34:04 <-- jb has quit (Ping timeout)
17:34:15 --> jb has joined #instantbird
17:43:57 --> wnayes has joined #instantbird
18:03:31 --> unghost has joined #instantbird
18:07:09 <-- jb has quit (Ping timeout)
18:35:14 --> mconley has joined #instantbird
18:44:20 <-- micahg has quit (Input/output error)
18:46:09 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
19:03:10 --> jb has joined #instantbird
19:11:36 --> skeledrew1 has joined #instantbird
19:11:37 <-- skeledrew has quit (Connection reset by peer)
19:13:57 <-- jb has quit (Ping timeout)
19:14:00 --> jb1 has joined #instantbird
19:18:35 <-- jb1 has quit (Ping timeout)
19:37:10 <-- flo-linux has quit (Ping timeout)
19:48:39 --> jb has joined #instantbird
19:59:09 --> jb1 has joined #instantbird
19:59:11 <-- jb has quit (Connection reset by peer)
20:00:46 <-- jb1 has quit (Ping timeout)
20:19:52 <-- mconley has quit (Input/output error)
21:04:04 <-- unghost has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
21:16:25 <-- wnayes has quit (Quit: wnayes)
22:32:11 <-- hadi has quit (Connection reset by peer)
23:13:35 --> micahg has joined #instantbird
23:21:59 --> dew1 has joined #instantbird
23:22:54 <-- dew has quit (Ping timeout)
23:32:50 <-- Suiseiseki has quit (Quit: Leaving)