#instantbird log on 12 23 2013

All times are UTC.

00:10:34 <-- qlum has quit (Client exited)
00:17:45 * flo-retina is finally able to make an http request, and wait for the result!
00:18:25 <flo-retina> that took longer than I thought it would
00:18:43 <flo-retina> but I've learned some stuff! (first time I touch an event loop in JS :))
00:23:59 <flo-retina> now I get "500 - Internal Server Error" :-/
00:34:05 <flo-retina> first bug filed through the API: https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11897 \o/
00:38:21 <-- hadi has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
00:44:17 <-- rosonline has quit (Client exited)
01:14:34 <flo-retina> and now with more than one comment: https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11901 :)
01:29:13 <flo-retina> https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11903 -> editing the summary, setting the whiteboard, resolving as FIXED. => enough for tonight :)
01:30:07 <flo-retina> it feels a lot more "real" now :)
01:34:35 --> BWMerlin has joined #instantbird
01:47:50 <flo-retina> so when the API returns "Error 400 - Bad Request", the bug is filed anyway :-S
02:02:44 <flo-retina> https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11909 is the bug filed with the code I just pushed: http://hg.instantbird.org/bio-merge/rev/8837b6825877
02:02:59 <flo-retina> only the credentials have been edited after that test run
02:03:05 <flo-retina> for now I've tested only with bug 990
02:03:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=990 nor, --, 1.1, florian, RESO FIXED, Closing a conversation window with unread messages shouldn't warn if the "hidden conversations" feat
02:06:01 <-- GeekShadow has quit (Ping timeout)
02:06:04 --> GeekShadow has joined #instantbird
02:10:38 <flo-retina> I think I've pushed this enough that now all the changes we make to these scripts will be visible, so development should be more motivating now :)
03:31:53 <-- skeledrew has quit (Ping timeout)
03:46:28 --> clokep has joined #instantbird
03:46:28 * ChanServ sets mode +o clokep 
04:07:11 <instant-buildbot> build #1058 of linux-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1058
04:07:24 <clokep> flo-retina: Great progress. :)
04:14:49 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
04:44:10 --> mconley has joined #instantbird
04:50:41 <-- mconley has quit (Input/output error)
04:55:33 <instantbot> New Instantbird (UI) bug 2291 filed by kantsuris@gmail.com.
04:55:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2291 nor, --, ---, nobody, UNCO, I would like to smile button
04:56:55 <instantbot> New Instantbird (UI) bug 2292 filed by kantsuris@gmail.com.
04:56:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2292 nor, --, ---, nobody, UNCO, I would like to send button
04:57:35 <instantbot> New Instantbird (UI) bug 2293 filed by kantsuris@gmail.com.
04:57:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2293 nor, --, ---, nobody, UNCO, хотелось бы редактировать горячие кнопки
05:08:56 <instantbot> New Instantbird (UI) bug 2294 filed by kantsuris@gmail.com.
05:08:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2294 nor, --, ---, nobody, UNCO, When leaving the stable version in Russian disappears twitter!
05:20:19 <-- wnayes has quit (Quit: wnayes)
05:27:35 <instant-buildbot> build #1458 of macosx-nightly-default is complete: Failure [4failed shell_3]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/1458
06:37:41 --> skeledrew has joined #instantbird
07:54:33 --> mikk_s has joined #instantbird
08:27:41 --> GeKo has joined #instantbird
08:28:09 <-- GeKo has quit (Quit: leaving)
08:28:19 --> GeKo has joined #instantbird
09:06:22 <-- GeKo has quit (Quit: leaving)
09:13:26 --> GeKo has joined #instantbird
10:03:10 <instant-buildbot> build #1208 of win32-nightly-default is complete: Failure [4failed shell_3]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1208
10:24:20 <-- mikk_s has left #instantbird ()
12:20:38 <-- gerard-majax_ has quit (Ping timeout)
12:51:29 --> gerard-majax_ has joined #instantbird
12:52:31 <-- qheaden_away has quit (Quit: ZNC - http://znc.in)
13:11:06 --> deomega has joined #instantbird
13:19:14 <-- gerard-majax_ has quit (Connection reset by peer)
13:19:18 --> gerard-majax_ has joined #instantbird
13:28:42 <-- gerard-majax_ has quit (Quit: Ex-Chat)
13:28:59 --> gerard-majax_ has joined #instantbird
13:29:13 <-- skeledrew has quit (Ping timeout)
13:29:22 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
13:29:34 --> deomega has joined #instantbird
13:31:57 --> skeledrew has joined #instantbird
13:32:03 <-- sabret00the has quit (Quit: Leaving)
13:39:10 <deomega> I  had a new installation on my pc and in haste,  forgot to save some of my custom IB settings
13:39:26 <-- gerard-majax_ has quit (Ping timeout)
13:39:34 <deomega> I was sure i saved these under a cloud file I have called IB but   just cannot find them
13:40:10 <deomega> Mic had given me some strngs to have the tabs on the bottom that I placer in userChrome.css
13:40:21 <deomega> anyone have any idea what those may be?
13:41:22 <deomega> And the option to change the color of the name in the active tab
13:42:01 --> gerard-majax_ has joined #instantbird
13:44:16 --> clokep has joined #instantbird
13:44:16 * ChanServ sets mode +o clokep 
13:45:26 <-- gerard-majax_ has quit (Ping timeout)
13:47:22 --> Mic has joined #instantbird
13:47:25 <Mic> Hi
13:47:35 <Mic> Hello deomega
13:47:38 * Mic is now known as Mic2
13:48:18 <clokep> Hello flo-retina.
13:48:29 <flo-retina> clokep: good morning :)
13:48:49 <Mic2> Could you check your emails? I might have emailed you the tabs-on-bottom code.
13:49:04 <Mic2> Should have been after 2013/03/10?
13:49:19 <Mic2> That's why I think that: http://log.bezut.info/instantbird/130310/#m42
13:52:27 <deomega> Mic2: gm, HA.. that would explain why I did not save it, I figured it was in my email.     Thank you
13:52:44 <Mic2> I found the email (really sent on 10th or March) but it only links to a pastebin snippet that has expired :(
13:53:21 <deomega> oh.  :(
13:53:31 <instantbot> clokep@gmail.com set the Resolution field on bug 2292 to DUPLICATE of bug 1264.
13:53:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2292 nor, --, ---, nobody, RESO DUPLICATE, I would like to send button
13:53:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1264 nor, --, ---, nobody, NEW, Add a discoverable way to send messages
13:53:58 * clokep has no idea what bug 2294 or bug 2293 mean.
13:53:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2294 nor, --, ---, nobody, UNCO, When leaving the stable version in Russian disappears twitter!
13:54:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2293 nor, --, ---, nobody, UNCO, хотелось бы редактировать горячие кнопки
13:54:24 <deomega> there is a way to search IB log over a period of time?  I was trying to go through it  day by day  hoping to find something but gave up
13:54:24 <Mic2> deOmega: can you try this in the userChrome file?
13:54:25 <Mic2> http://log.bezut.info/instantbird/130310/#m43
13:54:50 <Mic2> I googled for:
13:54:50 <Mic2> site:log.bezut.info deOmega userChrome 2013
13:55:28 <Mic2> If you do that, there'll be only two results and it was the first one for me ("#instantbird log on 03 10 2013").
13:55:37 <deomega> Mic2:oh... thank you on   all accounts.  will try
14:01:51 <instantbot> clokep@gmail.com set the Resolution field on bug 2291 to DUPLICATE of bug 1195.
14:01:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2291 nor, --, ---, nobody, RESO DUPLICATE, I would like to smile button
14:01:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1195 nor, --, ---, nobody, NEW, Add UI to insert emoticons
14:05:24 <clokep> flo-retina: I looked over your replayed bug, looks awesome so far. :)
14:06:01 <flo-retina> thanks :)
14:06:13 <flo-retina> gerv gave me admin access to the sandbox an hour or two ago
14:06:31 <flo-retina> we can now create 4 mailinator accounts, and grant them editbugs
14:07:22 <clokep> Sweet! :)
14:07:28 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
14:07:28 <clokep> Is there anything I should look at?
14:07:35 --> deomega has joined #instantbird
14:10:03 <deomega> hmm, userChrome should be created in chrome located in.. Drive:\Users\username\AppData\Roaming\Instantbird\Profiles\chrome   right?
14:10:21 <clokep> deomega: No, it goes under an individual profile.
14:12:06 <deomega> hmm, i created it at the end of this
14:12:07 <deomega> %appdata%\Instantbird\Profiles\
14:12:35 <flo-retina> clokep: I think bug 2294 is "Twitter isn't a top protocol in the Russian locale"
14:12:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2294 nor, --, ---, nobody, UNCO, When leaving the stable version in Russian disappears twitter!
14:12:55 <clokep> flo-retina: Ah, maybe.
14:13:03 <deomega> no wonder none of my experiments have been working out in userchrome
14:13:13 <Mic2> deomega: there's got to be a profile name in the path.
14:13:23 <Mic2> Most likely something with ".default" in it.
14:13:48 <deomega> where i have username, it is  'my name'
14:14:06 <deomega> ok
14:14:40 <deomega> gotcha
14:16:23 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
14:16:31 --> deomega has joined #instantbird
14:16:48 <deomega> I am such an idiot
14:17:09 <deomega> this is why nothing was working that i was experimenting with  :)
14:17:29 <deomega> gonna take an image of that  so i do not have tor ely on y reasoning.
14:19:25 <Mic2> Maybe write a note and put it in a Dropbox (/Skydrive/... if you use one of these), so you won't lose it when you need to reinstall your pc?
14:20:54 <deomega> i use google drive and will put that up there.  just  did an image with instructions
14:20:56 <deomega> thanks
14:21:19 <flo-retina> clokep: I'm not sure how we can parallelize the work on the BIO stuff
14:22:07 <flo-retina> maybe if I write a quick script for the transformation required for the sandbox (instead of hardcoding that in the replay.js script), you could then start working on the real bmo transformations?
14:23:28 <deomega> I help a lot of people with other matters and it gets frustrating when i have to help them with the same thing over and over, so..this is not easy for me to be asking.. so thanks.
14:23:33 <clokep> flo-retina: OK.
14:25:32 <deomega> By the way, I should verify that it worked.
14:26:03 <deomega> *confirm
14:26:28 <clokep> flo-retina: So you've worked on 1, 2 & 4 right now?
14:26:53 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
14:26:55 --> deomega has joined #instantbird
14:27:09 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
14:27:17 --> deomega has joined #instantbird
14:27:19 <flo-retina> clokep: yes. 1 is done. 2 and 4 are WIP.
14:27:31 <flo-retina> 3, I hacked around it.
14:27:48 <clokep> Lines 20 - 29 in replay.js?
14:28:40 <clokep> (And 19 - 22 of slice.js :-S)
14:34:53 * clokep tries to figure out how to run this thing.
14:35:28 <flo-retina> what about these lines?
14:37:48 <flo-retina> clokep: 20-29 and 95-103 in replay.js are the lines that should be handled by transform.js
14:38:50 <Mic2> deOmega: don't worry, I'm pretty patient ;)
14:40:31 <Mic2> I need to go for today, have a nice day.
14:40:48 <Mic2> Good luck with the export/import script :)
14:41:47 <deomega> Mic2: thank you  :)
14:42:52 <clokep> flo-retina: I can't get this to run. :-/
14:43:14 <-- Mic2 has quit (Quit: Mic2)
14:45:30 <clokep> Ah, finally got it. :)
14:55:18 <flo-retina> filed some bugs yet? ;)
14:55:47 <flo-retina> you have seen that you need to patch xpcshell.cpp and recompile it, right?
14:56:45 <clokep> flo-retina: Only if I'm going to try to upload. :0
14:56:54 * clokep needs to find his charger.
14:58:50 --> jb has joined #instantbird
14:59:21 <flo-retina> clokep: ah, yes, if you don't want to see the results, you don't need that
15:02:15 <flo-retina> clokep: btw, the lines 19-22 in slice.js are there to stay.
15:02:43 <clokep> Any reason that's done there instead of in transform?
15:02:45 <flo-retina> they are not to transform stuff from BIO into stuff for BMO, but they are there to make the script not fail despite stuff having been renamed in the past on BIO.
15:03:00 <clokep> Oh! OK. :0
15:03:40 <flo-retina> should I start a transform.js script and move there the currently hardcoded stuff, so that you have a "stable" place to patch?
15:03:42 <flo-retina> or are you already doing it?
15:04:29 <flo-retina> btw, I could do with some help creating {florian,aleth,benediktp,clokep}@mailinator.com accounts on https://landfill.bugzilla.org/bzapi_sandbox/
15:05:11 <flo-retina> yesterday I was using flo@instantbird.org there, but now that account is admin, so I'll only use it to grant editbugs to the other accounts we will use.
15:06:41 <flo-retina> hmm, creating accounts goes faster than I expected :)
15:06:44 <clokep> flo-retina: I already started one.
15:07:06 * clokep tries to figure out how to throw errors properly.
15:07:07 <flo-retina> would if nice if we could avoid bitrotting each other :)
15:07:35 <flo-retina> my next steps are: 1. Handle uploading on behalf of multiple users in replay.js. 2. Handle attachments and attachment flags in replay.js
15:11:29 --> gerard-majax__ has joined #instantbird
15:13:03 <flo-retina> bah, 291 @mailinator users on the sandbox :-/
15:13:34 <clokep> flo-retina: Reasonable. I'll show you what I have so far in a few minutes.
15:13:39 <clokep> Just trying to get it to work. ;)
15:14:28 * flo-retina has 4 sandbox accounts with editbugs!
15:15:02 <flo-retina> I think you are allowed to push on the repository (I started it as a copy of the experiments repository for the configuration parameters ;))
15:15:16 <flo-retina> but it may be nice to pastebin your changes before pushing :)
15:15:22 <flo-retina> for quick feedback
15:16:41 <flo-retina> I also want to refactor replay.js to reduce the duplication around the way I'm doing HTTP requests
15:18:23 <flo-retina> hmm, I may need an instantbot account too :)
15:18:45 <clokep> OK
15:20:49 <clokep> flo-retina: http://pastebin.instantbird.com/495862
15:21:29 <flo-retina> you may need your own version of run.sh
15:21:50 <flo-retina> replay.js needs the transformed version as input
15:21:50 <clokep> I wasn't going to check those changes in. ;)
15:22:19 <flo-retina> cool
15:22:24 <clokep> Looks reasonable?
15:22:33 <clokep> Unfortuntaely that script is going to be a whole lot of special cases.
15:22:38 <clokep> But I don't think there's a way around that.
15:22:39 <flo-retina> ok, so if you are only touching the new file, we won't conflict
15:22:53 <flo-retina> and I'll just be able to remove the obsolete lines in replay.js once your script is usable
15:23:18 <clokep> I think you could do that right now. ;)
15:23:29 <clokep> (flip the landfill flag to false and change run.sh to use it)
15:24:14 <flo-retina> clokep: transform.js has mostly 2 things to do (we could even make that 2 separate scripts if we think it would help) : 1. Handle the component/product name changes. 2. Merge several (eventually "all") sliced bugs into _one_ stream of events. And remove duplicates (we will have duplicate events for blocks/depends_on changes)
15:25:23 <flo-retina> clokep: btw, some of these things are no longer necessary. Eg now that my accounts have editbugs on landfill, I don't need to force bugs into the "UNCONFIRMED" status
15:26:08 <clokep> flo-retina: OK. I think merging everything / deduplicating should be a separate merge.js script personally.
15:26:41 <clokep> flo-retina: HTTP Error 500 when pushing. :-/
15:26:44 <flo-retina> ok
15:26:52 <flo-retina> that happens :-P
15:26:58 <flo-retina> which account have you used?
15:27:06 <clokep> Wait, I think I'm stupid.
15:27:30 <clokep> flo-retina: I tried both clokep and my email.
15:29:44 --> mconley has joined #instantbird
15:30:09 <flo-retina> clokep: your transform script should detect which kind of data it is getting, before transforming it
15:30:28 <flo-retina> eg. you don't want to set the product in each "update" request.
15:30:50 <clokep> flo-retina: They don't have that data in it.
15:30:58 <flo-retina> ?
15:31:03 <flo-retina> they = ?
15:31:05 <clokep> updates
15:31:14 <clokep> They don't have a product (unless you're changing the product, I assume)
15:31:44 <flo-retina> clokep: your script is setting the product unconditionally
15:31:54 <clokep> flo-retina: And I'm arguing that that's the right thing to do
15:31:57 <flo-retina> in the transformLandfile part
15:32:00 <clokep> Oh.
15:32:07 <clokep> You weren't specific. ;)
15:32:17 <flo-retina> I looked at what was going to break me ;)
15:32:43 <flo-retina> I would suggest using a JS object as a map for the product name mapping
15:32:56 <flo-retina> for BMO we may need to explicitly set the classification too
15:32:58 <flo-retina> (not sure)
15:33:51 <clokep> flo-retina: It isn't just a mapping though, we have to set the components too in the one situation.
15:33:58 <clokep> Although I guess I cold just further down check for that.
15:34:19 <flo-retina> have you successfully filed bugs now?
15:35:54 <clokep> No.
15:38:10 <clokep> I haven't tried either though. :)
15:40:03 <clokep> Oh I need to recompile. :-/
15:40:09 <clokep> flo-retina: Is there a particular incantation to recompile just js.exe?
15:40:31 <-- GeKo has quit (Input/output error)
15:41:03 <flo-retina> it's xpcshell.exe that you want to recompile
15:41:07 <flo-retina> recompile just the xpcshell folder
15:41:28 * flo-retina was very frustrated yesterday to discover xpcshell's readline was broken
15:41:34 <clokep> OK.
15:41:48 <clokep> (Any hints on where that is? :-D)
15:42:04 <clokep> Got it :)
15:42:24 * flo-retina assumes nobody will blame him for another global variable or two
15:42:49 <clokep> I assume we're not caring TOO much about style.
15:42:52 <clokep> As long as it's readable. :-D
15:42:59 * clokep starts to code like an animal.
15:43:43 <flo-retina> we just need to be able to understand what's going on
15:43:43 <clokep> flo-retina: Is this "end of data after property value in object" mean I still have that error after compiling mozilla/testing/xpcshell?
15:43:51 <flo-retina> no problem if we can't remember 2 weeks from now (hopefully)
15:44:28 <flo-retina> no idea why you would compile that
15:44:31 <flo-retina> the folder you want is /js/xpconnect/shell
15:45:00 <clokep> 10:41:04 AM - flo-retina: it's xpcshell.exe that you want to recompile
15:45:01 <clokep> 10:41:07 AM - flo-retina: recompile just the xpcshell folder
15:45:05 <clokep> ;)
15:45:06 <clokep> That's why.
15:45:22 <flo-retina> yeah, not explicit enough and you took it litteraly ;)
15:45:29 <clokep> Pretty much. :)
15:46:04 <flo-retina> btw: very useful command: ./js -c replay.js
15:46:10 <flo-retina> "-c" means" only check the syntax
15:46:13 <clokep> flo-retina: https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11911
15:46:18 <clokep> Oooo, that is useful! :)
15:47:30 --> GeKo has joined #instantbird
15:47:59 <flo-retina> Cool
15:48:12 <flo-retina> I'll reply with: https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11912 :)
15:49:07 <clokep> I just saw that! :)
15:49:16 <flo-retina> you are spying my bugs now? :-D
15:49:38 <flo-retina> do you think it's ok to have the list of usernames and passwords inside replay.js?
15:49:47 <flo-retina> or should I store that in a JSON file outside?
15:50:03 <flo-retina> I think the later would make it easier to not commit the real credentials
15:50:08 <clokep> Probably should do it outside...
15:50:44 <clokep> flo-retina: http://pastebin.instantbird.com/495894
15:50:45 <clokep> That works.
15:50:49 <clokep> And probably bit rots you. :)
15:50:49 <-- gerard-majax__ has quit (Ping timeout)
15:51:36 <flo-retina> now that we can actually play, it seems fun ;)
15:52:17 <flo-retina> drop that "aData.status = "UNCONFIRMED";" line? :)
15:52:51 <clokep> Right, sorry. you said that already!
15:53:05 <flo-retina> clokep: actually, some of the stuff I just wrote would be better in transform.js actually
15:53:09 <clokep> Are you OK w/ the changes to run.sh in there?
15:53:18 <flo-retina> (transforming the BIO authors into landfill/BMO authors)
15:53:26 <flo-retina> yes
15:54:17 <flo-retina> clokep: I don't see where you have the equivalent of "if (aData.status == "ASSIGNED") {" ...
15:54:27 <-- jb has quit (Ping timeout)
15:54:30 <flo-retina> missing editbugs was one of the problem there
15:54:42 <clokep> Ah, the comment implied to me that the only issue with that was editbugs.
15:54:42 <flo-retina> the other problem was that it requires mapping the value of assigned_to
15:55:11 <clokep> That's not yet handled.
15:57:29 <flo-retina> if it's not handled, we should continue dropping that change for now
15:57:46 <clokep> OK.
15:58:33 <clokep> flo-retina: line 15 of transform.js drops assigned_to?
15:59:10 <flo-retina> link?
15:59:22 <flo-retina> ah, ok
15:59:28 <clokep> I pushed, sorry. :)
15:59:51 <flo-retina> "// Use "priority" to mean we're creating a new bug." can you stop using hacks like this, when the type of each request is _explicit_?
15:59:55 --> gerard-majax__ has joined #instantbird
16:00:20 <clokep> flo-retina: Sure, but I wasn't going to pass that in since there's no reason to.
16:00:24 <flo-retina> so if I hg up it should still just work?
16:01:17 <flo-retina> not sure what you mean, but I'm pretty sure I can't agree
16:01:32 <flo-retina> there's no reason to not map the components in updates that don't change the priority
16:01:50 <-- gerard-majax__ has quit (Ping timeout)
16:01:51 <clokep> OK.
16:02:22 <flo-retina> I would suggest taking the 990.sliced file, and throwing it at a jsonbeautifier
16:02:30 <flo-retina> if should make lots of things more understandable in what I've done
16:02:44 <flo-retina> hmm, maybe you would need to do it line by line :-/
16:02:46 <clokep> I think I understand it pretty well.
16:03:05 <clokep> The beatutifier I use in Komodo works on those files.
16:03:11 <flo-retina> there's a short comment in slice.js explaining the different type of lines in the output
16:03:14 <flo-retina> cool
16:03:36 <clokep> Yes, I know that already.
16:03:51 <clokep> I was using priority to mean "this is being created", but yes. That isn't really far.
16:04:28 --> hadi has joined #instantbird
16:04:44 <flo-retina> right. So what I'm saying is: 1. Looking at the priority value to decide we are filing a bug is broken. 2. Not mapping products (and other fields) during bug updates is broken.
16:05:16 <hadi> evening
16:05:24 <clokep> flo-retina: Yes. I didn't do #2 yet! All i did was take the code from replay.js and put it into transform.js.
16:05:31 <clokep> I haven't added other "features" yet.
16:05:54 <clokep> (Also, I think that's unfortunately only broken for the transformLandfill and not for the transform function :()
16:06:04 <flo-retina> these are regressions IMHO ;)
16:06:20 <clokep> They can't be regressions if they were never supported.
16:06:41 <flo-retina> and also, I would be a bit concerned that the code paths are different for landfill and BMO. The BMO path doesn't benefit at all from the testing we do on landfill
16:07:28 <clokep> Yes, I was just trying to look at the file at first.
16:07:33 <clokep> I just started making them the same.
16:07:41 <clokep> (I'm going to override the map for landfill, is that reasonable?)
16:07:57 <flo-retina> yes
16:11:55 <flo-retina> clokep: I pushed the change to use the various accounts.
16:12:08 <flo-retina> I think mapping the authors should do in transform.js
16:12:14 <flo-retina> s/do/go/
16:12:37 <flo-retina> and when using the fallback author (instantbot) a comment should be added
16:12:48 <clokep> Yes, that probably makes the most sense.
16:12:54 <clokep> Where is it done now?
16:12:56 <flo-retina> replay.js would still load the usermap file, but only to get the passwords
16:13:11 <flo-retina> http://hg.instantbird.org/bio-merge/rev/08f99e7cccb5
16:15:46 <-- BWMerlin has quit (Quit: BWMerlin)
16:19:47 --> gerard-majax__ has joined #instantbird
16:37:20 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
16:37:27 --> deomega has joined #instantbird
16:38:30 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
16:38:38 --> deomega has joined #instantbird
16:38:45 --> wnayes has joined #instantbird
16:39:47 * clokep thinks florian will like this version better...
16:40:30 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
16:40:37 --> deomega has joined #instantbird
16:45:13 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
16:45:21 --> deomega has joined #instantbird
16:46:50 <clokep> flo-retina: http://hg.instantbird.org/bio-merge/rev/e6e578e18df3 I think this makes it better.
16:47:09 <flo-retina> how did you guess that was the url of my selected Fx tab? ;)
16:47:15 <clokep> I believe priority, version and target_milestone don't need to be mapped between BIO -> BMO?
16:47:31 <clokep> :)
16:47:36 * clokep has to go find a stocking in the attic...
16:48:34 <flo-retina> clokep: unless some mistake happened while creating our products, they indeed don't need to be mapped :)
16:48:50 <flo-retina> as a possible next step, I would suggest mapping user names, especially the assigned_to field :)
16:49:02 <clokep> That was my plan, yes.
16:49:11 <clokep> Should be easy with the map you already made. :P
16:50:46 <flo-retina> :)
16:50:52 <flo-retina> maybe after that the CC list?
16:51:13 <clokep> OK. They should both be simple, I think!
16:51:27 <flo-retina> I think we agreed to do it at the end though, so maybe we if the cc list isn't empty, we should push an update at the end in slice.js
16:51:48 <clokep> flo-retina: And the "author" field you added too or no?
16:52:20 <flo-retina> it should be BIO->BMO mapped, yes. But should stay just an email address
16:52:30 <flo-retina> the other fields I was talking about need to become User objects
16:52:48 <flo-retina> (which is basically just {name: "name@domain.tld"}
16:52:48 <flo-retina> )
16:53:29 <clokep> Right.
16:53:50 <clokep> Ah, looks like you're doing that mapping in replay.js currently, I'll remove that.
16:53:54 <clokep> (I think you said that earlier.)
16:54:02 * clokep copies that line of code. ;)
16:54:59 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
16:55:06 --> deomega has joined #instantbird
16:55:10 <flo-retina> IIRC I'm killing that assigned_to line to avoid doing that mapping
16:55:56 <flo-retina> I've done the mapping the other way in slice.js so that assignee emails could be compared (comparing JS objects would have been awkward)
16:57:44 <clokep> flo-retina: I assume nobody@instantbird.org should become nobody@mozilla.org?
16:57:52 <flo-retina> yes
16:58:07 <flo-retina> but I'm not sure we should see that value anywhere
16:58:51 <clokep> Hmm....so I see it in the assigned_to field when we have the file type.
16:58:55 <clokep> file event.
16:59:40 <clokep> That should likely be deleted.
17:03:28 <flo-retina> hmm, yes I think we can delete it
17:03:53 <flo-retina> or make it nobody@moz, it shouldn't really matter I guess
17:06:54 <clokep> Deleting is easier.
17:07:03 <flo-retina> indeed :)
17:09:03 <clokep> flo-retina: assigned_to and CC list https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11917 ;)
17:10:07 <flo-retina> now you can move the cc list update to the end? ;)
17:10:41 <clokep> Sure. Would you want to do that in slice.js, transform.js or merge.js? :P
17:10:56 <flo-retina> slice
17:11:08 <flo-retina> hmm
17:11:17 <flo-retina> you may need to make up a timestamp :-/
17:13:12 --> mikk_s has joined #instantbird
17:13:41 <-- mikk_s has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com)
17:14:15 <clokep> Hmmm... :-\
17:14:19 --> mikk_s has joined #instantbird
17:14:33 <-- mikk_s has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
17:14:36 <clokep> How does "the last timestamp + 1" sound? :P
17:14:46 <clokep> Were we going to disable email anyway?
17:17:06 <clokep> http://hg.instantbird.org/bio-merge/rev/f857ade765cb does the mapping.
17:18:03 <clokep> flo-retina: slice.js is meant to be run individually on each bug, right?
17:18:34 <flo-retina> yes
17:18:50 <flo-retina> clokep: "Were we going to disable email anyway?" I think I'm going to be lazy on that part
17:19:09 <flo-retina> btw, the timestamp isn't really relevant
17:19:23 <clokep> It is for sorting stuff.
17:19:28 <flo-retina> we need it only if we want to show "Initially posted at ..."
17:19:31 <flo-retina> but we don't need it for cc lists
17:19:34 <flo-retina> ah, indeed!
17:25:45 <clokep> flo-retina: Is this even worth it then though? Won't most people automatically get added to the CC list when posting a comment and then...they're going to get the emails anyway?
17:26:19 <flo-retina> we would need to check, but I think people adding comments aren't automatically cc'ed
17:26:38 <flo-retina> it's a checkbox in the web UI, but I don't think it happens automatically for API requests
17:27:01 <flo-retina> however, a relatively recent BMO change adds automatically to the cc list all requestees.
17:27:28 <clokep> Interesting.
17:29:03 <-- mrphs has quit (Ping timeout)
17:35:45 <clokep> Bleh I need to rebuild the date string by hand. :-/
17:36:33 <flo-retina> really?
17:37:53 --> mrphs has joined #instantbird
17:43:24 <flo-retina> removing the duplication around HTTP requests saves 30 lines, and makes the code way more readable :)
17:45:19 <clokep> flo-retina: Do you know how to get a 2011-09-27T22:43:02Z-esque string easily from  a JS Object?
17:45:26 <clokep> I know Lightning has code to do it, it was my first patch. :p
17:45:40 <flo-retina> no, but I thought it was a "standard" format
17:45:52 <flo-retina> Date() can parse it, so it would make sense if it could output it
17:46:30 <clokep> It's RFC 3339 dates.
17:46:52 <flo-retina> I wouldn't have guessed you could find RFC numbers during a bugzilla migration :)
17:47:14 <clokep> http://mxr.mozilla.org/comm-central/source/calendar/base/modules/calProviderUtils.jsm#413
17:47:22 <clokep> I looked in my bugzilla history to find it. :)
17:48:58 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
17:49:05 --> deomega has joined #instantbird
17:50:03 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
17:50:10 --> deomega has joined #instantbird
17:53:18 <-- hadi has quit (Ping timeout)
17:53:39 --> hadi has joined #instantbird
17:54:06 <deomega> i was able to get  everything else to work except  hiding the status bar.  This is what I have but it is not working
17:54:20 <deomega> statusbar-display {
17:54:20 <deomega> display: none !important;
17:54:20 <deomega> }
17:54:44 <deomega> anything i need to  add there?
17:56:22 <flo-retina> deomega: it's #statusbar-display not statusbar-display
18:00:46 <deomega> i had that before but it  still did not give teh result.  let me try again
18:01:24 * clokep finds http://pastebin.instantbird.com/496055 super ugly.
18:01:35 <clokep> flo-retina: ^ Any ideas of how to make that more readable or is it reasonable?
18:01:54 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
18:02:04 --> deomega has joined #instantbird
18:03:02 <deomega> yeah still  now working with this:
18:03:15 <deomega> #statusbar-display {
18:03:15 <deomega> display: none !important;
18:03:15 <deomega> }
18:03:43 <flo-retina> clokep: which part?
18:04:02 <clokep> flo-retina: Mostly how I build the ccList.
18:04:08 <flo-retina> clokep: I don't really understand that code; it seems broken.
18:04:09 <clokep> And then filter out events.
18:04:17 <clokep> It seems to give the results I expect.
18:04:20 <clokep> What part do you not understand?
18:04:30 <flo-retina> because you don't have aleth's renamed account in your way
18:05:00 <clokep> I'm not sure I understand.
18:05:08 <flo-retina> clokep: you should just get the CC list that's in obj.cc
18:05:20 <flo-retina> and then delete all the cc list changes from all the update events
18:05:26 <clokep> :( I didn' tknow that existed.
18:05:48 <flo-retina> clokep: http://pastebin.instantbird.com/496076
18:05:59 <flo-retina> line 134
18:06:10 <clokep> Yes, I see it.
18:06:12 --> qlum has joined #instantbird
18:07:29 <flo-retina> clokep: the reason why that code was broken is that in the history you have cc list changes for email addresses that are old account addresses.
18:08:17 <flo-retina> got an attachment now! https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11924
18:08:47 <flo-retina> landfill doesn't have the "feedback" flag :(
18:09:06 <clokep> Aren't you an admin? ;)
18:09:12 <flo-retina> ah!
18:09:18 <clokep> flo-retina: yes, makes sense now.
18:09:23 <clokep> That makes the code a lot cleaner.
18:09:24 <clokep> Sorry about that
18:09:28 <flo-retina> the flag my request was trying to set was "review" anyway :-S
18:09:36 <flo-retina> no idea of why that flag isn't set on the attachment
18:11:18 <clokep> flo-retina: http://pastebin.instantbird.com/496087 more reasonable? :)
18:12:14 <flo-retina> is if ("cc" in obj) { needed?
18:12:25 <clokep> Is it guaranteed to be there?
18:12:37 <flo-retina> I dislike the part at Remove the cc list from each event and totally remove any events that were...
18:13:00 <flo-retina> can't we just delete this cc field at the time the update events are created, and skip pushing the event to the list if the event is empty?
18:13:34 <clokep> Yes.
18:13:36 <flo-retina> you need to remove the line that is currently 49 for me in slice.js
18:13:42 <flo-retina> (bug.cc = obj.cc.map...)
18:14:03 <flo-retina> clokep: we _already_ do it
18:14:10 <flo-retina> see the "XXX ignore cc list changes for now" comment
18:14:20 <flo-retina> you may want to rephrase / remove the XXX now that it's handled :)
18:14:52 <clokep> Ah, I see. You return early there.
18:24:07 * flo-retina wonders how many times we will file the exact same bug on landfill :)
18:25:53 <-- gerard-majax__ has quit (Ping timeout)
18:26:49 --> flo1 has joined #instantbird
18:27:04 <flo1> when while attaching my request looks like:
18:27:19 <flo1> POST https://api-dev.bugzilla.mozilla.org/test/latest/bug/11927/attachment?username=florian@mailinator.com&password=topsecret
18:27:19 <flo1> {"file_name":"bug990.patch","encoding":"base64","flags":[{"name":"review","status":"+"}],"data":"ZGlmZiAtLWdpdCBhL2luc3RhbnRiaXJkL2NvbnRlbnQvY29udmVyc2F0aW9uLnhtbCBiL2luc3RhbnRiaXJkL2NvbnRlbnQvY29udmVyc2F0aW9uLnhtbAotLS0gYS9pbnN0YW50YmlyZC9jb250ZW5
18:27:27 <flo1> any obvious reason for the flags not to be set?
18:27:33 <flo-retina> the doc is https://wiki.mozilla.org/Bugzilla:REST_API:Objects#Flag
18:27:33 --> gerard-majax__ has joined #instantbird
18:29:08 <clokep> Hmm...
18:29:49 <clokep> flo-retina: Do you need the id?
18:30:03 <clokep> Or type_id?
18:31:11 <clokep> :-/ the SSL cert on that doesn't work: https://landfill.bugzilla.org/bzapi_sandbox/attachment.cgi?id=2792&action=edit
18:31:13 <clokep> That's annoying
18:32:08 <flo-retina> yeah...
18:32:18 <flo-retina> I don't think that's my problem though :)
18:32:50 <flo-retina> so yes, maybe type_id would be required
18:33:12 <flo-retina> but then I wonder how I'm expected to find that value :-S
18:33:50 <clokep> Is it returned to you somewhere else? :-D
18:33:59 <flo-retina> "     Due to limitations in Bugzilla, when updating attachments (including their flags), you must post back the entire object, otherwise Bugzilla will complain about missing fields. This limitation may be removed in future. " hmm
18:34:03 * clokep just pushed http://hg.instantbird.org/bio-merge/rev/582a348ed48f
18:34:27 <flo-retina> cool
18:34:55 <flo-retina> I wonder if that really means we need to push the whole object, including the attachment data. I hope not!
18:35:18 <clokep> That seems...excessive!
18:35:40 <flo-retina> I would assume not, because the attachment data isn't returned by default in bugs unless we ask for it
18:35:44 <clokep> Our plan is (I assume) to get this bug "perfect" and then move on to others, right?
18:36:00 <flo-retina> not necessarily perfect
18:36:09 <flo-retina> but as good as we can while touching a single bug
18:36:25 <flo-retina> there's still a log to do ^^
18:36:28 <flo-retina> *lot
18:36:38 <flo-retina> if only I could understand how flags work ;)
18:36:40 <clokep> I know! Just asking.
18:36:45 <clokep> Maybe #bugzilla would know?
18:38:25 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
18:38:33 --> deomega has joined #instantbird
18:40:16 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
18:40:23 --> deomega has joined #instantbird
18:41:02 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
18:41:11 --> deomega has joined #instantbird
18:43:44 <-- deomega has quit (Client exited)
18:43:55 --> deomega has joined #instantbird
18:45:14 <clokep> flo-retina: What sort of information do we want to add to comments? "This comment was originally made by so-and-so on some-date.\n\n"?
18:46:19 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
18:46:29 --> deomega has joined #instantbird
18:50:10 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
18:50:18 --> deomega has joined #instantbird
18:53:45 --> rosonline has joined #instantbird
19:00:37 <flo-retina> clokep: I think we want to keep them short, one liners if possible
19:01:07 <flo-retina> something like "Originally posted on bio NNN [by name] at [time]\n\n"
19:01:25 <flo-retina> the [by name] part would be only if we are posting as instantbot
19:02:31 <clokep> OK.
19:02:55 <clokep> And we want to add comments if actions take place without a comment, right?
19:03:18 <-- qlum has quit (Connection reset by peer)
19:03:40 <flo-retina> clokep: I'm not sure
19:03:55 <flo-retina> clokep: I originally thought we wanted to do that.
19:04:01 --> qlum has joined #instantbird
19:04:09 <clokep> I flip flop in my head. :(
19:04:12 <flo-retina> But that creates an offset for all other comment numbers
19:04:46 <flo-retina> and I think for most actions, it should be relatively easy to figure out rougthly when they happened, because they will be between comments that have dates
19:05:10 <clokep> I agree.
19:05:13 <flo-retina> most important actions have comments already (it's not possible to add an attachment without a comment being added)
19:05:25 <flo-retina> it's only when r+'ing, etc... that it could be ambiguous
19:05:41 <flo-retina> so I think we should do our best to add the original time info to all existing comments
19:05:42 <clokep> Or just modifying the CC list, but we're doing that at the end anyway.
19:06:12 <flo-retina> so the only _relevant_ modification I can think of that doesn't require a comment is touching the whiteboard
19:06:21 <flo-retina> but I think we have the habit of always commenting when doing that
19:06:31 <flo-retina> I don't think the timestamp is terribly valuable for that anyway
19:06:39 <clokep> aleth frequently adds "checkin-needed" without commenting.
19:06:48 <clokep> And it happens < 30s after someone else gives him an r+.
19:06:58 <clokep> I don't find the timestamp of that to be important AT ALL.
19:07:00 <flo-retina> if the change is made by instantbot, we will definitely need to add a comment though
19:07:05 <flo-retina> clokep: I agree
19:07:29 <flo-retina> unless we want to do stats of how long there is between checkin-needed and actually checkin, that timestamp has no value
19:07:52 <clokep> Even so it'd be hrad to get that info from the comments, be much easier from the original bug database.
19:07:55 <flo-retina> (I won't do such stats; will give aleth checkin access instead if he's tired of waiting for people to check in his patches ;))
19:08:18 <flo-retina> clokep: I was planning on turning off BIO though
19:08:31 <clokep> I understand. :)
19:08:45 <clokep> I don't think we shold be concerned about that.
19:09:05 <flo-retina> some other work related to comments that remains is grouping updates with their comment
19:09:06 <clokep> I hope there aren't many people we have for instantbot needing to make changes w/o comments, but in that case I think we should just add it and not worry about it.
19:09:43 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
19:09:47 --> deomega has joined #instantbird
19:11:30 <-- skeledrew has quit (Connection reset by peer)
19:12:22 <flo-retina> so I guess for the flags I need to query https://api-dev.bugzilla.mozilla.org/latest/configuration
19:13:00 --> skeledrew has joined #instantbird
19:14:20 <flo-retina> I wonder if I can just hardcode the values for the flag type_id
19:14:25 <flo-retina> I think yes. We have only 2 flags
19:15:01 <flo-retina> for BMO the "review" flag is type_id 4
19:15:17 <flo-retina> feedback is 607
19:15:50 <flo-retina> for landfile, review is 1
19:15:56 <flo-retina> feedback doesn't exist
19:16:15 <clokep> That's not too bad.
19:16:20 <flo-retina> I suggest mapping it to "super review" for testing purpose (id 2)
19:16:39 <flo-retina> more transform.js material I guess ;)
19:19:52 <clokep> It looks like we have to merge the initial comment and the bug creation too?
19:20:00 <flo-retina> yes
19:20:02 <clokep> You're doing that, right?
19:20:07 <clokep> (The flag stuff.)
19:20:08 <flo-retina> you are :-P
19:20:09 <flo-retina> ah
19:20:10 <flo-retina> I can
19:20:15 <flo-retina> if you aren't touching transform.js right now
19:20:26 <clokep> I'm touching the very bottom of it.
19:20:34 <flo-retina> lines 57-66 give me a "code duplication" flag ;)
19:21:12 <flo-retina> why the do/while loop?
19:27:17 <clokep> flo-retina: As opposed to a while loop? Ummm...I'm actually not even positive the do-while is doing what I want. :-D
19:27:21 <flo-retina> that worked! :)
19:27:31 <clokep> flo-retina: I don't see how that code is duplicated. :-/
19:27:54 <flo-retina> you read "obj.data.product" 4 times
19:28:20 <flo-retina> and in the whole content of the loop, you touch obj.data lots and lots of times
19:28:28 <flo-retina> also, most of these "in" check aren't needed
19:29:24 <flo-retina> I pushed the change to map the type_id values
19:29:33 <flo-retina> and I now have a flag on my attachment https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11930 \o/
19:30:19 <clokep> flo-retina: Any reason you rebuild that map everytime instead of once at the top?
19:30:35 <flo-retina> no _good_ reason :)
19:30:43 <clokep> http://hg.instantbird.org/bio-merge/rev/7577c4331a1b#l1.14 has a tab. ;)
19:30:51 <flo-retina> the not-really-good is I wanted to touch only one place of the file, to reduce bitrot risk :-]
19:31:15 <flo-retina> want me to do the cleanups I suggested? (will bitrot any other change you may have in the file right now)
19:31:24 * flo-retina needs to reconfigure his emacs :(
19:31:51 <clokep> Sure thing.
19:31:56 <clokep> And the ones I just suggested? :P
19:32:04 <clokep> I don't think you'll bit rot me, those changes were far from what I'm doing...
19:32:04 <flo-retina> sure
19:33:15 <clokep> https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11931 has some dates in it, lemme know what you think of the format
19:33:28 <clokep> The attachment one doesn't though..hmm...
19:34:19 <flo-retina> clokep: we need to detect the comment starting with "Created attachment 847" and get rid of that line + make the comment a comment made while attaching.
19:34:39 <clokep> I thought you couldn't add comments when attaching things.
19:34:47 <flo-retina> do you really like UTC times?
19:34:49 <clokep> But OK, as long as it's something "TODO" still. I won't be worried about it.
19:35:10 <clokep> flo-retina: Would you prefer a different timezone? ;)
19:35:12 <flo-retina> clokep: it's part of the deduplicating :)
19:35:22 <flo-retina> I think I would prefer if we could display what was displayed by BIO
19:35:38 <flo-retina> I wouldn't capitalize BIO
19:35:59 <clokep> "2011-05-20 09:15:11 EDT"?
19:36:03 <clokep> But in UTC, not EDT.
19:36:06 <flo-retina> I tend to use "BIO" to refer to the bugzilla.instantbird.org install, and bio to refer to a bug number on BIO
19:36:21 <flo-retina> clokep: I think we are currently on CEST or something like that
19:36:33 <clokep> flo-retina: It's configurable for each user...
19:36:36 <flo-retina> but UTC may make sense for more people I guess
19:36:45 <clokep> UTC seems the most likely thing for everyone to easily be able to convert from.
19:36:51 <flo-retina> yeah
19:36:54 <clokep> But if you dislike the date format, I can certainly change it.
19:37:03 <flo-retina> nah, that's fine
19:37:36 <clokep> (It was much easier to just say obj.time than to parse it. :-D)
19:38:14 <clokep> flo-retina: You didn't change the loop from do-while -> while, did you?
19:38:16 * clokep just did that.
19:39:29 * clokep wonders if flo-retina finds the "cc" if statement on line 76 hacky: http://pastebin.instantbird.com/496179
19:40:03 <flo-retina> I'm doing it
19:40:42 <flo-retina> clokep: it looks strange, yes
19:41:17 <clokep> I can not special case that, but I thought it was odd to add the comment in that situation.
19:46:01 <flo-retina> pushed the cleanup
19:46:05 <flo-retina> and going to eat dinner
19:48:01 <clokep> Cool. :)
19:58:35 <-- flo-retina has quit (Ping timeout)
20:00:39 <clokep> http://hg.instantbird.org/bio-merge/rev/96e4119ab97f with the originally posted on stuff.
20:06:01 <clokep> mconley: Are you stuck under snow?
20:06:26 <mconley> clokep: yes, but replace the snow with the NSS code
20:06:58 <mconley> clokep: actually, where I am has been mostly freezing rain. So the trees are encased with ice, and the ground is all slippery, but not mounds of snow.
20:07:42 <clokep> :-/
20:07:46 <clokep> mconley: Aren't you off today?
20:08:22 <mconley> clokep: I am! But between shopping trips, I thought I'd take the opportunity to see if I could figure out why JosiahOne and I can't run mozmill tests locally on OS X.
20:08:26 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
20:08:30 --> deomega has joined #instantbird
20:08:31 <mconley> clokep: and I've traced it to NSS not initializing properly
20:08:36 <mconley> and that's where I'm stuck
20:08:46 <clokep> Ahh-ha. :)
20:08:51 <clokep> Sounds like a fun experience.
20:10:13 <mconley> it's been...interesting
20:10:18 <mconley> I don't normally ever go this low in the framework
20:10:28 <mconley> feels weird being down here
20:11:00 <clokep> You're probably safer facing the ice.
20:30:20 <mconley> it's true
20:40:16 --> jb has joined #instantbird
20:43:33 <-- mconley has quit (Input/output error)
20:44:31 <clokep> flo1: OK I've merged attachment comments into the attachment event: https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11940 http://hg.instantbird.org/bio-merge/rev/2ffc59d20906
20:46:03 <clokep> Although now I'm wondering if I should have done that in slice.js instead of merge.js. :-/
20:49:26 --> flo-retina has joined #instantbird
20:49:26 * ChanServ sets mode +qo flo-retina flo-retina 
20:49:59 <flo-retina> clokep: yes, seems like something for slice.js
20:50:19 <clokep> Yeah I just realized "slice.js" deals with stuff for a single bug...
20:50:22 <clokep> Oops. :)
20:50:33 <flo-retina> clokep: "Originally posted on bio 990 as 847 at 2011-09-27T10:14:00Z." missed the "attachment" word here, right?
20:50:46 <clokep> flo-retina: So I didn't want to put it in cause BZ will auto-linkify it.
20:50:51 <clokep> I thought of doing bio_attachment ?
20:51:43 <flo-retina> would attacht NNN be "readable"?
20:51:53 <flo-retina> I don't want to add too many characters in there :-/
20:51:59 <clokep> attmnt ?
20:52:09 <clokep> bikeshedding.
20:52:14 <flo-retina> yes :)
20:53:01 <flo-retina> https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11940#c11 needs some fixing too
20:53:12 <flo-retina> it should be an update of the attachment
20:53:22 <flo-retina> I guess it needs to be merged with the "flag" event
20:53:41 <clokep> OK.
20:53:50 <clokep> that's an update, I assume?
20:54:01 <flo-retina> it's a "flag" + "comment" now
20:54:03 <clokep> Oh, there's a flag one.
20:54:04 <clokep> Sorry.
20:54:29 <flo-retina> "flag" isn't handled yet
20:55:56 <clokep> I see.
20:55:56 <flo-retina> didn't you have a way to post the times as UTC?
20:56:04 <clokep> Are those not UTC?
20:56:13 <clokep> I'm confused by what you mean. :-/ I thought we decided we'd just leave them.
20:56:40 <flo-retina> the T and Z there aren't human friendly
20:56:59 <clokep> Oh, I agree. I can remove them, I just thought we had decided we wouldn't.
20:57:03 <clokep> OK, I'll do thta after the flag thing.
20:57:35 * Gizmokid2005 hi-fives everyone.
20:57:43 <Gizmokid2005> just read the blog on the new release :)
20:57:47 <Gizmokid2005> g'rats all!
20:58:04 <clokep> flo-retina: Do you know if attachment comments always come after the attach event and if there's ay order to a flag and the comment associated with it?
20:58:08 <clokep> Gizmokid2005: Thanks. :)
20:58:13 <Gizmokid2005> You're welcome! :)
20:58:19 <Gizmokid2005> making it harder to stick with pidgin
20:58:33 <flo-retina> clokep: we agreed on:
20:58:33 <flo-retina> 20:36:00 - clokep: "2011-05-20 09:15:11 EDT"?
20:58:33 <flo-retina> 20:36:04 - clokep: But in UTC, not EDT.
20:58:48 <clokep> I didn't realize there was any agreement to that! OK. :)
20:58:52 <clokep> easy peasy.
20:59:01 <Gizmokid2005> I think at this point the only thing that keeps me with pidgin is I don't want to "lose" my logs
20:59:38 <flo-retina> clokep: not sure if there was a clear agreement (it seems not), but that's what I understood
21:00:11 <clokep> I'm changing it now.
21:00:16 <clokep> Let's move on!
21:01:30 <flo-retina> Gizmokid2005: can you remind us to think about this more in a few weeks?
21:01:50 <Gizmokid2005> I can probably do that flo-retina :)
21:02:04 <flo-retina> (we are quite busy these days with infrastructure things)
21:02:24 <Gizmokid2005> my wish would be to be able to write into pidgin's structure with an option/setting/etc to save into a specific location (ie - that one).
21:02:32 <Gizmokid2005> I can definitely understand that :)
21:02:42 <clokep> + Christmas. :p
21:03:12 <flo-retina> Gizmokid2005: you can do that with symbolic links
21:03:18 <Gizmokid2005> haha. I just got back from a week long work trip on Friday night, had an office christmas party Saturday. Lost power from 10am Sunday to 12pm today. I'm off this week (but Christmas) and then fly out for another work trip on the 30th to return the 4th...
21:03:23 <flo-retina> Gizmokid2005: but really, you don't want the Pidgin log format (it sucks)
21:03:46 <Gizmokid2005> flo-retina: I know, but the fewer symlinks I have to remember/worry about the better. They're not really entirely friendly in windows anyways (I guess I should've specified that)
21:04:05 <Gizmokid2005> I can also agree there. I just would like a way to make it so no matter if I use pidgin or Instantbird, the logs would be consistent across both.
21:04:10 <Gizmokid2005> that's my end-game with that.
21:04:21 <Gizmokid2005> IANAP but... :D
21:04:48 <flo-retina> Gizmokid2005: why would you still use Pidgin?
21:05:29 <Gizmokid2005> *shrugs* Who knows. I will admit once I switched IRC clients, I've not gone back to anything else. Maybe some feature that I"m looking for that Instantbird doesn't have? I'm not entirely sure if/what would trigger me to come back.
21:05:33 <Gizmokid2005> or rather, GO back.
21:05:57 <Gizmokid2005> I'll admit, I haven't used instantbird in any length since just prior to the 1.0 release.
21:06:31 <flo-retina> try it now, and forget Pidgin ;)
21:06:38 <Gizmokid2005> but...my logs! :(
21:06:39 <Gizmokid2005> :D
21:06:54 <flo-retina> just copy your pidgin log folder into Ib's log folder
21:06:56 <Gizmokid2005> Hmm, I wonder if John's managed to package up the new instantbird yet...my guess is now.
21:06:59 <Gizmokid2005> *not*
21:07:06 <flo-retina> if you logged in txt format, that will just work
21:07:12 <deomega> lol.  My brother actually just decided to give up Pidgin for IB.
21:07:12 <Gizmokid2005> (RE: John - Portableapps)
21:07:25 <-- jb has quit (Ping timeout)
21:07:27 <clokep> flo-retina: Are you working adding flags next then?
21:07:30 <Gizmokid2005> he just came out of surgery last week so he's been on the recover right now.
21:07:40 <flo-retina> deomega: :)
21:08:10 <flo-retina> clokep: I'll likely start working on that in 10-15 minutes, unless you start before I do.
21:08:12 <Gizmokid2005> flo-retina: clokep - are either of you responsible for maintaining the PortableApps version of IB?
21:08:18 <flo-retina> Gizmokid2005: no
21:08:28 <clokep> Gizmokid2005: We have no relation with them at all.
21:08:29 <flo-retina> Gizmokid2005: from what I remember they don't disable auto updates
21:08:37 <flo-retina> so you could just install an old version and let it update itself
21:08:46 <Gizmokid2005> Theoretically
21:08:53 <clokep> flo-retina: I am not trying to, I don't see a way to add a comment w/ it though. :(
21:08:54 <Gizmokid2005> I'm an PA packager myself
21:09:13 <clokep> flo-retina: Or is it another attachment message and not a flag message? :)
21:09:14 <Gizmokid2005> I just missed who was doing it. Looks like the guy who is hasn't really been all that active on the site lately (though neither have I).
21:09:26 <flo-retina> clokep: it's an attachment update
21:09:28 <Gizmokid2005> is there any simple way to copy my accounts into IB?
21:09:31 <clokep> OK! :)
21:09:31 <Gizmokid2005> from Pidgin?
21:09:52 <flo-retina> clokep: the problem is we need to first tweak slice.js to undo all the attachment changes (right now we add them with all the flags like they are at the end)
21:10:09 <clokep> OK.
21:11:17 --> jb has joined #instantbird
21:14:22 --> mconley has joined #instantbird
21:17:21 <flo-retina> ok, I'm back in front of the computer
21:19:39 <-- mconley has quit (Ping timeout)
21:20:29 <flo-retina> Gizmokid2005: "any simple way to copy my accounts into IB?" not yet.
21:20:35 <Gizmokid2005> oke doke.
21:20:40 <flo-retina> We have a student who wrote code for that, but we haven't finished reviewing it
21:20:44 <Gizmokid2005> Not too worried, just didn't want to manually do it if it would.
21:20:49 <Gizmokid2005> also, just FYI
21:20:51 <flo-retina> but unless you have 150 accounts, I guess you can just recreate them ;)
21:20:57 <Gizmokid2005> I just used the built-in updater and got a crash when it finished?
21:21:07 <flo-retina> doesn't seem nice
21:21:20 <Gizmokid2005> http://pb.gizmokid2005.com/rov
21:21:55 <Gizmokid2005> and I always get "there was a problem submitting your report"
21:21:59 <Gizmokid2005> so I can't ever seem to send them.
21:22:57 <Gizmokid2005> it did successfully update though, so I don't know if it's something in the updater that doesn't handle the portable paths/execution well or what.
21:23:57 <flo-retina> clokep: http://hg.instantbird.org/bio-merge/rev/96e4119ab97f#l1.21 looks like it won't work for the initial comment when someone reports a bug
21:24:55 <clokep> flo-retina: How is that done? I guess, what format is the data in that it'll be different?
21:25:15 <clokep> flo-retina: I just pushed a couple more change.s
21:25:36 <flo-retina> really, that code works only if the "data" there was a Comment.
21:25:51 <flo-retina> Not if it was a bug. So it doesn't work for file, update, attach, flag...
21:26:25 <Gizmokid2005> As a note, I did actually add a comment and email address to that report.
21:26:45 <clokep> flo-retina: Look at it now and let me know what you think of it.
21:26:57 <flo-retina> looks like you just fixed it (still reading)
21:27:17 <clokep> \o/
21:27:17 <flo-retina> Gizmokid2005: if it failed to upload, we will get neither the stack nor the comment :(
21:27:24 <Gizmokid2005> I know :(
21:27:30 <Gizmokid2005> but there's no feedback as to why it fails
21:27:36 <Gizmokid2005> I've noticed that in both FF and Tbird too
21:27:49 <clokep> Gizmokid2005: Do you use a proxy?
21:27:52 <Gizmokid2005> nope.
21:28:03 <flo-retina> clokep: the code around http://hg.instantbird.org/bio-merge/rev/2ffc59d20906#l3.36 is likely broken
21:28:26 <clokep> flo-retina: What's the concern?
21:28:31 <flo-retina> maybe that "else {" really was else if (obj.type == "comment") { and you wanted another else?
21:28:56 <flo-retina> clokep: if I'm changing the status whiteboard and adding a comment at the same time, this code won't work.
21:29:38 <clokep> flo-retina: Hmm...maybe... what type of event would that be?
21:29:42 <flo-retina> "str += " as " + obj.attachment_id;" I think we agreed to add "attchmt" there?
21:29:50 <flo-retina> clokep: that's an "update" event
21:29:59 <clokep> flo-retina: Look at the next commit. ;)
21:30:24 <clokep> OK. And an update cannot have a .text inside the data I assume? I'll have to look at this case.
21:31:41 <flo-retina> clokep: well, it likely "can" (in that the request wouldn't fail) but it would be ignored
21:32:02 <clokep> OK. I'll have to look at that again.
21:32:20 <clokep> Would that just be like the data.comments array above it?
21:32:29 <flo-retina> clokep: basically, in all cases where type != "comment", you need to look in data.comments
21:32:35 <clokep> OK!
21:32:53 <clokep> So likely I want to reverse that to be if obj.type == comment { do stuff } else { do things to data.comments }
21:33:51 <flo-retina> I think so
21:34:49 <flo-retina> "flo-retina: Do you know if attachment comments always come after the attach event and if there's ay order to a flag and the comment associated with it?" I don't know.
21:36:29 <clokep> It looks like the attachment and the comment have different timestamps actually.
21:36:46 <flo-retina> yeah
21:37:21 <clokep> flo-retina: AHHHHH You adding the attachment and set a flag AND added a comment all at once.
21:37:26 <clokep> That's three events!
21:37:30 <flo-retina> So one case that really sucks is: merging the initial comment (when creating the bug) IF an attachment was added while creating the bug.
21:37:31 * clokep goes insane.
21:37:49 <flo-retina> clokep: what's the problem there?
21:38:01 <clokep> Just that I didn't take it into consideration. :)
21:38:10 <flo-retina> clokep: you'll go insane when discovering that we can't mark the old attachment as obsolete in the same request ;)
21:38:26 <clokep> :-\
21:38:41 * clokep wonders if this should be a separate thing from the slice script so he can see the output of that one...
21:39:01 <flo-retina> once we get that bug working, we will need to "play" with a bug where there are actually review requests, and several iterations of the same patch
21:39:12 <flo-retina> (marking old patches as obsolete and cancelling pending review requests at the same time)
21:39:21 <flo-retina> also, multiple review requests on the same patch will be "interesting"
21:39:43 <flo-retina> clokep: too many "this" and "that" in your last sentence
21:39:56 <clokep> flo-retina: bug 507?
21:39:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=507 enh, --, 1.2, clokep, RESO FIXED, Implement IRC in JavaScript
21:40:16 <clokep> (That might take too long to play with though since it's a HUGE bug.)
21:40:33 <clokep> flo-retina: I was wondering if the "merging" should be done in a different script inside of the slice.js.
21:40:49 <flo-retina> +or?
21:41:35 <flo-retina> my goal with "slice.js" was that it would output one JSON line for each action that a user actually made on BIO.
21:43:08 <flo-retina> (for a specific bug)
21:43:47 <clokep> OK.
21:46:57 <flo-retina> the "Comment on attachment 1181" line at https://bugzilla.instantbird.org/show_bug.cgi?id=507#c36 is also interesting
21:46:59 <instantbot> Bug 507 enh, --, 1.2, clokep, RESO FIXED, Implement IRC in JavaScript
21:47:22 <-- jb has quit (Ping timeout)
21:47:24 <clokep> (Which part of it?)
21:47:46 <flo-retina> it's a line added automatically by bugzilla when the comment is posted as part of a "flag" event
21:48:38 <flo-retina> so we need to remove it, but it also lets us know how to group that specific comment
21:50:32 <flo-retina> I'm wondering if another way to write http://hg.instantbird.org/bio-merge/rev/53d93d5906fe#l3.7 couldn't be to look for "comment" events, and then see if there's a way to group that merge that comment into whatever the previous event was
21:50:40 <flo-retina> all the other events can accept comments
21:51:43 <clokep> Possibly.
21:51:47 <clokep> That's kind of what I'm doing now...
21:51:52 <flo-retina> cool :)
21:51:56 <flo-retina> so should I look at the flags now?
21:52:00 <flo-retina> that touches slice.js too
21:52:07 <clokep> I think so.
21:52:26 <clokep> I'm scared I'm going to eat comments that aren't meant to be...but I think it'll be OK-ish. :-/
21:52:39 <flo-retina> what's the worst that can happen?
21:53:09 <clokep> So I'm debating whether I should even attempt to compare the event times or not.
21:53:15 <clokep> (They're different for attachments, at least.)
21:53:21 <flo-retina> as long as you check the author, check that both timestamps are within a few seconds, and check that there wasn't already a comment there... what can go wrong?
21:53:55 <flo-retina> I think we should check the timestamps, but be generous
21:54:03 <clokep> The ones I'm looking at in bug 990 is 19 seconds off!
21:54:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=990 nor, --, 1.1, florian, RESO FIXED, Closing a conversation window with unread messages shouldn't warn if the "hidden conversations" feat
21:54:09 <flo-retina> I don't think there can be more than 60s of difference between the two
21:54:21 <clokep> I was thinking of using 30 or 60 seconds, yes.
21:54:30 <clokep> We might want to ensure that works with a really large attachment at some point.
21:55:02 <flo1> the code near "  if (h.changes[0].attachment_id) { //FIXME handle more than the first flag change" looks like a minefield :-S
21:55:36 <flo1> so many things there that are obviously half baked :-/
21:56:08 <flo1> clokep: well, if it doesn't work, the worst that can happen is "comment numbers are off by one"
21:56:14 <clokep> :) True.
21:56:28 <flo1> clokep: so I think it's OK to have false negatives here (as long as we don't have plenty of them)
21:56:41 <flo1> false positive (especially if not attributing to the right person) would be way more annoying.
21:57:52 <clokep> True.
21:57:57 <clokep> Checking the author heps a lot, I think.
21:59:40 <flo-retina> yes, that's a nice safety check :)
21:59:59 <flo-retina> and I'm glad in slice.js we don't have to wonder about whether the author has already been mapped to the BMO name :)
22:00:53 <flo-retina> I think I need a new testcase
22:01:10 <flo-retina> where we have a patch with flags changing value a few times
22:01:17 <flo-retina> possibly patches becoming obsolete
22:01:29 <clokep> Find any of aleth's bugs. ;)
22:01:34 <clokep> He always submits two patches. :-D
22:02:01 <flo-retina> bug 2104 seems nice
22:02:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2104 nor, --, 1.5, nhnt11, RESO FIXED, Filenames for buddy icons are not null-checked in the new conversation tab.
22:02:13 <flo-retina> clokep: aleth submits 3 patches per review cycle ;)
22:02:34 <flo-retina> will also force handling the "Attachment is obsolete" thing
22:02:45 <clokep> :) Cool.
22:02:54 <flo-retina> ok, 2104 is my new playing field
22:03:03 <clokep> flo-retina: Maybe DON'T add nhnt11 to the list so we can force that code path?
22:03:15 <flo-retina> well, he isn't in the list, right?
22:03:16 <flo-retina> ;)
22:03:19 <clokep> Exactly!
22:03:22 <clokep> :)
22:03:26 <flo-retina> I think I'll tweak run.sh to take a bug number as parameter
22:04:20 <flo-retina> ah, you added BUG_ID, but didn't use it everywhere
22:05:27 <flo1> transform.js:77:4 TypeError: data.cc.map is not a function
22:06:03 <clokep> Yeah I missed one spot for the BUG_ID.
22:06:08 <clokep> I fixed it locally but haven't committed ye.t
22:06:12 <flo-retina> ok
22:06:21 <-- GeKo has quit (Quit: leaving)
22:06:28 <flo-retina> I don't understand that error
22:06:42 <flo-retina> data.cc is null checked
22:06:46 <flo-retina> can it be anything but an array?
22:07:29 <clokep> I don't know...
22:08:11 <flo-retina> the code path seems to work: https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11943#c1
22:08:47 <flo-retina> clokep: oooh, that bug also has the interesting case of "attachment created at bug filing time"! :)
22:09:21 <clokep> Did it work? ;)
22:09:40 <flo-retina> the part attributing the comment to nhnt11 instead of instantbot worked
22:09:54 <clokep> :)
22:10:03 <clokep> (Should we hide emails in any way?)
22:10:08 <flo-retina> for the history, there's room for improvement (compare https://bugzilla.instantbird.org/show_activity.cgi?id=2104 and https://landfill.bugzilla.org/bzapi_sandbox/show_activity.cgi?id=11943)
22:10:19 <flo-retina> not sure
22:10:33 <flo-retina> I think BMO hides them for non-logged-in users
22:10:36 <flo-retina> so maybe we should, yes
22:10:43 <flo-retina> would be nice to have the real name
22:11:01 <clokep> OK https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11944 has comment merging working for MOST cases, but I actually broke it on the attach case now. :(
22:11:18 <clokep> Can we do an API query and get all the names?
22:11:34 <flo-retina> we don't have them?
22:11:45 <clokep> Hmm...maybe we do.
22:11:57 <flo-retina> or did you mean an SQL query, and hardcode them?
22:11:59 <clokep> Not in an easy to use map of author -> name. :)
22:12:09 <-- rosonline has quit (Ping timeout)
22:12:13 <clokep> But maybe it's in the data and I didn't look.
22:15:12 <flo-retina> looks like something is going wrong with the CC list
22:15:31 <flo1> transform.js is receiving an object looking like this: {"id":"2104","status":"RESOLVED","cc":"clokep@gmail.com","resolution":"FIXED","assigned_to":{"name":"instantbot@mailinator.com"},"target_milestone":"1.5"}
22:18:41 <clokep> flo1: :-/ OK. Are you looking at it, or would you like me to?
22:18:53 <clokep> I don't see how that's possible if the obj.cc.map call is working. :-S
22:18:53 <flo-retina> if you can guess what's going wrong, do it
22:18:59 <flo-retina> if it needs investigating, I'm not it
22:19:42 <flo1> it's rather the code after "// Ignore cc list changes since they are imported at the end." that is expected to prevent this IMHO
22:20:01 <flo1> ohh
22:20:03 <flo1> trivial bug
22:20:12 <clokep> OK. :)
22:20:15 <clokep> What was it?
22:21:05 <flo1> clokep: http://pastebin.instantbird.com/496360
22:21:17 <clokep> Nice. :)
22:21:29 <flo-retina> I guess I can commit that separately
22:22:15 <flo1> I should really setup that ssh key :-/
22:24:32 <flo1> done :)
22:24:45 <flo1> (enough mis-typed passwords)
22:24:52 <flo1> (the password I set on the new server is long :))
22:26:04 <-- wnayes has quit (Ping timeout)
22:28:57 <flo-retina> clokep: why did you want more API calls for the real names?
22:29:01 <flo-retina> it's in the JSON we have
22:29:09 <flo-retina> "real_name" next to "name"
22:29:44 <clokep> flo-retina: OK, I guess it isn't in the actual events being created then.
22:30:02 <flo-retina> I have a function in slice.js to clean up the User objects and keep only the name
22:30:05 --> wnayes has joined #instantbird
22:30:06 <clokep> Add an author_name?
22:30:10 <flo-retina> as we don't need to send anything else to the server
22:30:23 <flo-retina> I see nothing wrong with that :)
22:30:50 --> rosonline has joined #instantbird
22:31:04 <deomega> hey guys..  quick thing.. maybe quick on my end
22:31:32 <deomega> someone just updated to instantbird and they were not able to get it to restart.  they are running Norton antivirus
22:31:42 <deomega> I connected to them remotely and was able tor esolve it
22:32:15 <deomega> but norton was putting a file into quarantine.  
22:32:58 <clokep> Yes, someone needs to report a false positive w/ them.
22:33:05 <deomega> i will put it in  pastebin
22:33:06 <clokep> This happened to one of my friends too.
22:33:11 <rosonline> Hello! I still can not update the website strings
22:33:12 <deomega> ah ok
22:33:18 <rosonline> Please help me
22:33:28 <clokep> rosonline: You need to be more specific.
22:33:35 <clokep> (Unless I missed context. :))
22:33:42 <clokep> Can you not find them? Not get them to show up on the website?
22:33:59 <rosonline> I have cloned the 1.5 properties from the en-US repositury
22:34:15 <rosonline> I made the translations and update the file
22:34:32 <rosonline> but the weebsite doesn't show the translated file
22:34:46 <rosonline> it shows a english strings
22:36:20 <deomega> clokep: if this could be of any use to you guys:  http://pastebin.instantbird.com/496391
22:36:53 <flo-retina> flo1: .slice("review".length + "?(".length, - ")".length)
22:38:12 <clokep> deomega: https://submit.symantec.com/false_positive/
22:41:09 <deomega> clokep: ok, I am gonna have to reconnect to this person to get the required information to file that.
22:41:13 <flo-retina> rosonline: I'm looking into it
22:41:24 <clokep> deomega: Thanks. :) I'm busy right now sorry I can't do it.
22:41:39 <rosonline> ok
22:41:49 <rosonline> I wait for
22:41:56 <rosonline> waiting
22:41:57 <deomega> clokep: sure
22:42:15 <clokep> This happened for 1.3 too IIRC.
22:43:32 <flo-retina> rosonline: fixed http://instantbird.com/pt-BR/release-notes.html :)
22:44:13 <clokep> flo-retina: Can we not do ANY flags in an attachment event? :-S
22:44:16 <flo1> too bad people can't just be convinced that Norton is a piece of malware
22:44:29 <flo1> clokep: what do you mean?
22:44:40 * flo1 is now known as flo-linux
22:44:55 <rosonline> clokep: It's fine now! Thanks! But what's happened?
22:45:03 <clokep> flo-linux: With my current changes it looks like I have good JSON objects, but now I don't see all the flag changes...
22:45:10 <clokep> https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11946 is the bug I just created.
22:45:21 <clokep> http://pastebin.instantbird.com/496402 is the JSON.
22:45:28 <flo-linux> clokep: we aren't pushing to the server any "flag" event
22:45:41 <clokep> flo-linux: Even if it's part of the "attacH" event?
22:45:56 <clokep> Oh wait.
22:45:58 <clokep> What...?
22:46:03 <flo-linux> clokep: we set flags as part of adding an attachment
22:46:09 <flo-linux> but we currently set the final state of the attachment
22:46:13 <clokep> OH!
22:46:14 <clokep> You said that.
22:46:16 <clokep> Sorry. :(
22:46:19 <flo-linux> so trying to replay the "flag" events would break
22:46:22 <flo-linux> that's what I'm trying to fix
22:46:27 <flo-linux> but I still have plenty of work to do
22:46:33 <clokep> OK.
22:46:40 <clokep> I think I have collapsing of related events working though.
22:46:53 <flo-linux> I'm working now on parsing the flag changes we have in the history events... and trying to make them look like Flag objects
22:47:02 <flo-linux> sounds great :
22:47:03 <flo-linux> )
22:47:51 <flo-linux> clokep: what's https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11946#c2 ?
22:48:40 <clokep> flo-linux: It's what I'm looking at now. ;)
22:48:45 <flo-linux> :)
22:48:49 <-- qlum has quit (Quit: Getting the <censored> out.)
22:49:03 <clokep> Ah, It was from reversing the logic in transform.js...
22:50:12 <deomega> clokep: ok.  issue submitted and confirmed.  have a nice evening.
22:50:17 <clokep> Thanks. :)
22:50:39 <-- deomega has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
22:52:57 <clokep> flo-retina, flo-linux: Any opinion on http://pastebin.instantbird.com/496413 ?
22:54:32 <flo-retina> why "else if (obj.type == "attach" || obj.type == "flag")"?
22:54:39 <flo-retina> more specifically, why not for types "update" or "file"?
22:55:10 <clokep> flo-retina: Didn't we decide earlier that we don't want to add comments to updates?
22:55:15 <clokep> It should probably have file in there though.
22:55:33 <flo-retina> we did!
22:55:42 <clokep> Well that's why it isn't there. :)
22:55:44 <flo-retina> may be worth a code comment :)
22:56:13 <clokep> Yup, and I made it != "update'.
22:56:17 <clokep> That'll be more explicit.
22:56:20 <-- EionRobb has quit (Quit: Leaving.)
22:56:23 <flo-retina> great, thanks
22:56:59 <flo-linux> 2013-08-13T00:38:00Z nhnt11	attach {"file_name":"2104.diff","encoding":"base64","flags":[{"name":"review","status":"+"}],"data":"IyBIRyBjaGFuZ2VzZXQg...","description":"Add null-check","content_type":"text/plain","is_patch":"1","comments":[{"text":""}]}
22:57:06 <flo-linux> do you know why I'm getting an empty comment here?
22:57:28 <flo-linux> (it probably doesn't hurt; just confuses me a little bit :))
22:58:03 <clokep> I don't know off the top of my head...
22:58:17 <clokep> The code that merges comments to attachments has been entirely rewritten from what you're on.
22:58:24 <clokep> Trying to convince myself there's no dataloss right now. :)
22:58:24 <flo-retina> now I know why I left these flags as TODO
22:58:33 <flo-retina> it's more work than it looks like
22:58:46 <flo-retina> ok
23:05:36 <flo-retina> clokep: do you know of a bug where the same person changed 2 flags at once?
23:05:44 <clokep> flo-retina: Does the "ERROR" function actually do anything?
23:05:46 <flo-retina> (eg replaced a review? by a feeback+ or something like that)
23:05:56 <flo-retina> it prints an error message
23:05:56 <clokep> Hmm...I did this recently.
23:06:00 <flo-retina> we may want to make it quit()
23:06:02 <clokep> I canceled a review and gave an r+.
23:06:09 <clokep> Give me two seconds to find it.
23:06:11 <flo-retina> uh?
23:06:35 * flo-retina is looking for a better/more complicated test case
23:07:12 <clokep> Oh. :(
23:07:14 <flo-retina> I want to see the annoying edge cases right from the beginning :)
23:07:33 <clokep> Cancelling aleth's review and r+ing my review isn't enough? :P
23:08:06 <flo-retina> I've done it on bug 1221 comment 16
23:08:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1221 enh, --, 1.5, wnayes, RESO FIXED, Redesign buddy tooltips
23:08:11 <flo-retina> but I'm afraid that bug is huge
23:08:20 <clokep> :-/
23:08:28 <flo-retina> clokep: you mean you have 2 different review? flags?
23:08:40 <flo-retina> that's another complication
23:08:41 <clokep> It was two different review flags.
23:08:51 <flo-retina> I don't know how to deal with flags set multiple times
23:09:00 <flo-retina> but that's not really the problem I'm looking at now
23:09:14 <flo-retina> I'm trying to find a way to group the changes into events.
23:09:43 <flo-retina> because it's possible to do at the same time changes on different attachment (when marking one obsolete for example)
23:09:47 <flo-retina> hmm
23:10:02 <clokep> flo-retina: Ah it is bug 2091
23:10:03 <flo-retina> maybe I should look for a bug from aleth where he marks as obsolete an attachment that had pending review requests
23:10:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2091 nor, --, ---, qheaden, ASSI, /join chatroom does not do anything.
23:10:26 <clokep> (That bug does what I just said also)
23:10:30 <clokep> Bah.
23:10:39 <clokep> That bug also marks something obsolete while adding a new attachment.
23:10:49 <flo-retina> cool
23:10:55 <flo-retina> I'll need to test on that one at some point
23:12:08 <flo-retina> bug 1472 comment 4
23:12:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1472 enh, --, 1.2, clokep, RESO FIXED, Handle a ChanServ entry message
23:12:49 <flo-retina> https://bugzilla.instantbird.org/show_activity.cgi?id=1472 :-D
23:13:11 <clokep> I don't see ERROR printing anything out. :-/
23:13:34 <clokep> Also has aleth's old email. :P
23:15:00 <flo-retina> clokep: doesn't matter, we drop the cc changes
23:15:09 <flo-retina> but for review requests, we will need to map old emails...
23:16:38 <flo-linux> what I get is:
23:16:38 <flo-linux>  "removed": "review?(florian@instantbird.org)",
23:16:38 <flo-linux>             "added": "review-, feedback+",
23:18:05 <flo-linux> now the last thing I would like to see is: what happens in the JSON when someone changes the status of the bug (eg. sets it to ASSIGNED) from the "add attachment" page
23:19:03 <flo-linux> bug 2280 will be another interesting test case
23:19:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2280 nor, --, 1.5, aleth, RESO FIXED, URL context menu broken in private conversations
23:20:01 <clokep> flo-retina: Setting it to assigned while adding an attachment happens in bug 990.
23:20:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=990 nor, --, 1.1, florian, RESO FIXED, Closing a conversation window with unread messages shouldn't warn if the "hidden conversations" feat
23:20:09 <clokep> I merge that already, I think.
23:20:35 <flo-retina> clokep: no, it's separate in https://bugzilla.instantbird.org/show_activity.cgi?id=990
23:21:02 <flo-retina> in https://bugzilla.instantbird.org/show_activity.cgi?id=2280 it's the same event
23:21:12 <clokep> I see.
23:21:29 <flo-retina> more mess for me to tidy up ;)
23:21:49 <clokep> My checks right now merge that all into one event. :-/
23:21:54 --> dew has joined #instantbird
23:22:00 <flo-retina> it's not possible
23:22:09 <clokep> Why not?
23:22:16 <flo-retina> unless I missed something, BzAPI can't change the bug's status while updating an attachment
23:22:24 <-- dew1 has quit (Ping timeout)
23:22:38 <clokep> Bah.
23:22:58 <flo-retina> clokep: I thought you were only trying to merge "comment" events?
23:23:08 <clokep> No.
23:24:03 <clokep> But now I'm all confused. :-/
23:24:21 <flo-retina> that's the state I was in a few minutes ago
23:24:26 <flo-retina> now I know where to start typing code :-D
23:24:54 <flo-linux> well, really, all I've figured out is how to replace "  if (h.changes[0].attachment_id) { //FIXME handle more than the first flag change
23:24:54 <flo-linux> " which was very obviously broken
23:25:52 <clokep> flo-retina: OK, so here's the issue I'm running into. I have an attach event at 10:14:00, an update and a comment at 10:14:19.
23:26:13 <clokep> The comment says "created attachment" so it goes with the attachment...
23:26:21 <clokep> But right now I'm merging ALL of that together into one thing...
23:26:24 <flo-retina> I think I mentioned that before (yesterday?) as a sucky edge case
23:26:33 <clokep> Yeah. :-/
23:26:42 <flo-retina> clokep: in that specific case, the "update" should stay separate
23:27:02 <flo-retina> attach/flag can't be mixed with "update"
23:27:18 <clokep> But update and comment can be mixed.
23:27:33 <-- flo-linux has quit (Ping timeout)
23:27:35 <flo-retina> yes
23:27:48 <clokep> So I have to be able to "skip" an event and look at theone past it? That's...annoying.
23:28:10 <clokep> flo-retina: Are you OK w/ me doing a merge instead of rebasing?
23:28:14 <flo-retina> and "attach" takes priority in getting merged, as it already causes a comment
23:28:20 --> flo-linux has joined #instantbird
23:28:44 <flo-retina> is the rebase painful?
23:28:53 <flo-retina> I don't care much about the history of this repo tbh :)
23:28:53 <clokep> I actually have no idea how to rebase in hg.
23:28:58 <flo-retina> "hg rebase"
23:29:02 <flo-retina> and it usually just works
23:29:22 <flo-retina> unless it doesn't (if there are conflicts I don't think it can just work)
23:29:49 <clokep> Is there a way to do hg st but ignore uncommited files? :-/
23:31:38 <clokep> flo-retina: OK I have to go do a couple of things. I have code which kind of merges stuff, but apparently does too much. Do you want me to not push it yet?
23:32:20 <flo-retina> I don't know (haven't seen it). Do whatever seems the most reasonable thing to do :)
23:32:31 <flo-retina> how long do you expect to be gone?
23:32:44 <clokep> I'm eating dinner in a few minutes.
23:35:28 <clokep> I'll wait until after.
23:35:32 <clokep> I don't think you're waiting for this change at all.
23:35:51 <flo-retina> ok
23:36:14 <flo-retina> yeah, I expect it will take me a significant amount of time to finish dealing with flags
23:37:52 <clokep> flo-retina: So the only thing we should try to merge is a comment then?
23:39:41 <clokep> OK, that might have been easier than I thought it'd be. :)
23:42:09 <clokep> flo-retina: OK. https://landfill.bugzilla.org/bzapi_sandbox/show_bug.cgi?id=11949 is my current results, I just pushed.
23:42:28 <clokep> It actually looks "worse" in a way because the r+ comment from me is now missing...because it's now IN the flag event, which then doesn't go to the server.
23:42:28 --> mconley has joined #instantbird
23:42:46 <clokep> I hope that code will work for most cases. :)
23:42:56 <clokep> I have to go for a bit.
23:44:57 <flo-retina> for lots of these things, understanding what the expected behavior is seems to be more than half the work toward having it implemented
23:46:18 --> FireFly_TB has joined #instantbird
23:48:36 <flo-retina> I haven't done a detailed review of your recent push, just looked briefly: are you checking that you aren't merging a comment into an update that already had a comment?
23:50:26 <-- FireFly_TB has quit (Quit: FireFly_TB)