#instantbird log on 11 28 2013

All times are UTC.

00:04:59 <-- wnayes has quit (Ping timeout)
00:05:34 <-- qlum has quit (Client exited)
00:08:38 --> wnayes has joined #instantbird
00:12:56 <-- mrphs has quit (Ping timeout)
00:14:09 --> mrphs has joined #instantbird
00:14:24 --> dionisos has joined #instantbird
00:22:03 <-- mconley has quit (Input/output error)
00:22:31 --> mconley has joined #instantbird
00:24:20 <-- mconley has quit (Ping timeout)
00:34:42 <-- jb has quit (Ping timeout)
00:42:43 --> clokep has joined #instantbird
00:42:43 * ChanServ sets mode +o clokep 
00:58:03 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
00:59:34 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
00:59:39 --> clokep has joined #instantbird
00:59:40 * ChanServ sets mode +o clokep 
01:14:13 <-- dionisos has quit (Ping timeout)
01:38:28 <-- wnayes has quit (Connection reset by peer)
01:38:33 --> wnayes has joined #instantbird
03:58:18 --> mconley has joined #instantbird
04:13:35 <instant-buildbot> build #1034 of linux-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1034
04:15:39 <-- mconley has quit (Input/output error)
04:25:25 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
04:26:34 <instant-buildbot> build #1234 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/1234
04:32:24 <-- wnayes has quit (Quit: wnayes)
04:47:43 --> skeledrew has joined #instantbird
05:07:09 --> mconley has joined #instantbird
05:14:25 <-- mconley has quit (Input/output error)
05:29:49 <-- EionRobb has quit (Quit: Leaving.)
06:14:36 --> gerard-majax__ has joined #instantbird
06:27:00 --> GeKo has joined #instantbird
07:24:06 <-- dew has quit (Connection reset by peer)
07:24:10 --> dew has joined #instantbird
07:25:50 <-- dew has quit (Ping timeout)
07:52:41 <instant-buildbot> build #1172 of win32-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1172
07:56:07 --> BWMerlin has joined #instantbird
07:58:49 <-- flo-retina has quit (Ping timeout)
07:59:58 <-- gerard-majax__ has quit (Ping timeout)
08:32:41 --> jb has joined #instantbird
08:52:19 --> gerard-majax__ has joined #instantbird
08:52:42 --> gerard-majax_ has joined #instantbird
08:54:01 <-- gerard-majax__ has quit (Ping timeout)
09:04:28 <-- gerard-majax_ has quit (Ping timeout)
09:07:42 --> dionisos has joined #instantbird
09:50:32 <-- alexis has quit (Max SendQ exceeded)
09:50:55 --> alexis has joined #instantbird
10:05:28 --> dew has joined #instantbird
10:37:18 --> gerard-majax_ has joined #instantbird
10:42:18 --> aleth has joined #instantbird
10:42:18 * ChanServ sets mode +h aleth 
10:45:04 <aleth> flo-retina: "I suspect you want conv.getNormalizedChatBuddyName in these 2 places" is why I cancelled that review ;)
10:46:22 <-- aleth has quit (Quit: Ciao)
10:46:26 --> aleth has joined #instantbird
10:46:26 * ChanServ sets mode +h aleth 
10:46:48 --> flo-retina has joined #instantbird
10:46:48 * ChanServ sets mode +qo flo-retina flo-retina 
11:04:48 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
11:04:51 --> flo-retina has joined #instantbird
11:04:51 * ChanServ sets mode +qo flo-retina flo-retina 
11:12:17 <-- dionisos has quit (Ping timeout)
11:37:22 <flo-retina> aleth: do you have a way to test if bug 2140 is fixed?
11:37:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2140 nor, --, ---, nobody, NEW, Nightlies depend on gcc >= 4.5 via libstdc++
11:37:31 <flo-retina> (I mean, if I try to change something for it)
11:38:40 <aleth> No... the way to test it is to try to run IB on an old distro.
11:39:08 <aleth> Hmm, maybe there is a way to list all the required dependencies?
11:40:17 <aleth> We should have got the bug reporter to cc to the bug :(
11:40:59 <flo-retina> maybe we just need to list the imported symbols with nm?
11:41:14 <flo-retina> I'm tempted to just revert https://hg.instantbird.org/instantbird/rev/80a19e04e244 to see if it fixes stuff.
11:41:15 <aleth> "ldd instantbird-bin" maybe
11:41:32 <aleth> Doesn't seem to give version numbers
11:42:12 <aleth> ldd -v does
11:43:48 <flo-retina> hmm, I can't type a | character on that VNC window :(
11:45:11 <aleth> Doesn't seem to list the dependencies for libxul.so
11:46:33 <aleth> Duh, ldd -v libxul.so does ;)
11:46:37 <flo-retina> yeah
11:46:40 <flo-retina> that's what I already had
11:46:59 <flo-retina> and actually ldd -> libxul.so > /dev/null
11:47:25 <flo-retina> gives errors about GLIBCXX_3.4.14 and GLIBCXX_3.4.9 :)
11:47:35 <flo-retina> + some errors about NSS
11:47:44 <aleth> Right :)
12:01:32 <flo-retina> aleth: looks like the interesting stuff is (not) happening in http://mxr.mozilla.org/comm-release/source/mozilla/build/unix/stdc++compat/stdc++compat.cpp
12:04:38 * aleth wonders why that file is c-c only
12:05:10 <aleth> Oh, it's not. Just mxr behaving badly.
12:09:43 <flo-retina> so my guess is we need to add ac_add_options --enable-stdcxx-compat to the linux mozconfigs
12:10:09 <aleth> That sounds plausible :)
12:10:55 <aleth> I'm surprised clokep didn't automatically add that when he synchronised with the c-c config (but maybe that's a work in progress, I don't know the status of that)
12:11:24 <flo-retina> he didn't sync the mozconfigs
12:12:40 <flo-retina> aleth: r? https://bugzilla.instantbird.org/attachment.cgi?id=3089&action=edit
12:12:41 <aleth> https://mxr.mozilla.org/comm-central/source/build/unix/mozconfig.linux#9
12:13:05 <aleth> What's elf-hack?
12:13:22 <instantbot> aleth@instantbird.org granted review for attachment 3089 on bug 2140.
12:13:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2140 nor, --, ---, nobody, NEW, Nightlies depend on gcc >= 4.5 via libstdc++
12:13:36 <flo-retina> it's https://bugzilla.mozilla.org/show_bug.cgi?id=606145
12:13:43 <flo-retina> that was my first guess, but it was wrong
12:14:01 <flo-retina> it's just a startup and binary size optimization; at the cost of breaking the profiler.
12:14:09 <aleth> ah ok.
12:14:14 <aleth> Thanks.
12:17:09 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/4e714a9b18a6 - Florian Qu├Ęze - Bug 2140 - Nightlies depend on gcc >= 4.5 via libstdc++ - add --enable-stdcxx-compat to linux mozconfigs, r=aleth.
12:17:38 <flo-retina> I started a linux onCommit
12:18:18 <flo-retina> if it finishes successfully, I'll go look at ldd -v libxul.so again
12:18:35 <flo-retina> and then we can decided if we want a new nightly to start testing immediately, or if it can wait until tomorrow
12:19:05 <aleth> Great! Thanks for looking into that.
12:19:51 <aleth> Have you/Even decided whether we are going to offer 64b builds or whether we need to assemble a list of libraries to install for the FAQ?
12:22:31 --> mpmc has joined #instantbird
12:35:55 --> clokep has joined #instantbird
12:35:55 * ChanServ sets mode +o clokep 
12:36:21 <clokep> We haven't had a Windows nightly ina long time. :(
12:38:11 <instant-buildbot> build #497 of linux-onCommit is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/497
12:38:51 <flo-retina> clokep: really?
12:39:14 <aleth> Looks like there was one tonight
12:39:33 <flo-retina> clokep: we've had 4 this week already
12:39:38 <clokep> flo-retina: I'm on 20131125042602
12:39:41 <clokep> No updates are available.
12:39:50 <flo-retina> that's not about "no nightly"
12:39:54 <flo-retina> it's the update cache that sucks
12:40:36 <flo-retina> clokep: try again
12:41:20 <clokep> flo-retina: I woke up literally like 90 seconds again, cut me a break. ;)
12:41:54 <flo-retina> you mean you are frustrated if you don't get a new nightly within 90s of waking up? :-D
12:42:53 <clokep> Yes. :)
12:42:55 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
12:43:07 --> clokep has joined #instantbird
12:43:07 * ChanServ sets mode +o clokep 
12:43:09 <aleth> Nightly before coffee... now that's priorities...
12:45:13 <clokep> I don't believe in coffee. ;)
12:45:46 <flo-retina> stronger than coffer, a new nightly! :-D
12:46:08 <aleth> Freshly brewed.
12:48:16 <clokep> I did have a mountain dew at 9:15 last week though..
12:48:55 <aleth> What's that?
12:50:06 <-- mpmc has quit (Connection reset by peer)
12:51:37 --> mpmc has joined #instantbird
12:54:22 <flo-retina> bah, that linux oncommit build sucks
12:54:59 <flo-retina> it didn't run configure (I don't know why), so...
12:55:07 <flo-retina> the change didn't have any effect
12:55:23 <instantbot> clokep@gmail.com set the Resolution field on bug 2140 to FIXED.
12:55:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2140 nor, --, 1.5, florian, RESO FIXED, Nightlies depend on gcc >= 4.5 via libstdc++
12:55:34 * flo-retina isn't sure if he wants to trigger a new nightly or not
12:56:31 <flo-retina> any opinion?
12:56:38 <clokep> Go fo rit.
12:56:53 <aleth> Then we can see if it really is fixed ;)
12:59:55 <-- BWMerlin has quit (Quit: BWMerlin)
13:03:00 <clokep> flo-retina: So is there something special to do to rebuild makefiles from omz.build?
13:03:11 --> dionisos has joined #instantbird
13:06:16 <clokep> Anyone seen this error? http://pastebin.instantbird.com/458978
13:06:26 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 3090 on bug 2148.
13:06:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2148 nor, --, ---, clokep, ASSI, Remove VKontakte protocol
13:07:02 <-- aleth has quit (Quit: Ciao)
13:07:13 --> aleth has joined #instantbird
13:07:13 * ChanServ sets mode +h aleth 
13:07:43 <flo-retina> clokep: I saw it 2 or 3 times, but don't have the steps to reproduce
13:08:59 <instantbot> New Core - Yahoo! Messenger bug 2259 filed by aleth@instantbird.org.
13:09:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2259 nor, --, ---, nobody, NEW, Shutdown error: this._keepAliveTimer is undefined
13:09:31 <flo-retina> clokep: when I saw it, it seemed vaguely related to the "Other Contacts" not cleaning up correctly when all accounts got disconnected.
13:09:48 <flo-retina> I remember seeing one contact in the "Other Contacts" group with the "unknown" status
13:09:53 <flo-retina> (I don't display offline contacts)
13:17:05 <aleth> clokep: Do we have to land website changes before string freeze?
13:17:28 <flo-retina> no
13:22:57 <flo-retina> but it's nicer if we give translators a few days to update the website's locale if they care about it
13:27:49 <flo-retina> clokep: "I'm pretty sure this is just me not understanding what the deal is with rebuilding now that we have moz.build"  it's not "just you". I've been annoyed several times by similar stuff :(
13:28:06 <flo-retina> either there's something handling dependencies better that we need to port, or moz.build is a PITA (or both!)
13:29:22 <clokep> flo-retina: OK. :(
13:29:31 <clokep> According to rkent it's just a PITA. :p
13:31:18 <aleth> jcranmer may have encountered the same problem a bit earlier if you are lucky ;)
13:31:26 <clokep> I already asked him.
13:31:30 <clokep> I suspect he's asleep / eating turkey.
13:31:46 <aleth> oh right, thanksgiving!
13:42:05 <aleth> 'JavaScript component does not have a method named: "normalize"' when calling method: [imIAccount::normalize]
13:42:26 <aleth> Does the uuid on imIAccount need to be changed so that it notices the interface it inherits from has changed?
13:43:39 <clokep> aleth: Get the prplAccount.
13:44:03 <clokep> foo.prplAccount
13:44:11 <aleth> clokep: But why doesn't it inherit?
13:44:23 <aleth> interface imIAccount: prplIAccount
13:44:32 <clokep> aleth: Because the implementation doesn't, most likely.
13:45:06 <aleth> Oh, so it would have to forward explicitly?
13:46:21 <flo-retina> uh, my review sucked :(
13:47:05 <flo-retina> aleth: see http://lxr.instantbird.org/instantbird/source/chat/components/src/imAccounts.js#449
13:47:42 <aleth> OK
13:47:43 * aleth is confused by that inheritance model
13:48:06 <clokep> aleth: http://pastebin.instantbird.com/459019
13:48:55 <clokep> Probably actually http://pastebin.instantbird.com/459020 btw.
13:49:38 <aleth> Right.
13:49:51 * aleth wonders under what circumstances the protocol plugin is missing
13:51:04 * aleth no longer confused by the inheritance model :)
13:52:12 <aleth> Are we expecting cases where an imIAccount still exists after the corresponding prplAccount has been removed?
13:58:06 <-- dionisos has left #instantbird ()
13:59:44 <flo-retina> aleth: that's when the user has configured an account using a prpl installed as an add-on, or built-in in a previous Ib version, and the prpl no longer exists (add-on disabled, newer Ib, ...)
14:00:07 <aleth> VKontakte...
14:00:11 <aleth> OK, thanks.
14:00:15 <flo-retina> oh really? :-D
14:11:41 <clokep> aleth: Do I need to put that patch up somewhere or will you inc lude it in your bug?
14:12:11 <aleth> clokep: It's probably clearer if you attach it to bug 2115
14:12:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2115 nor, --, 1.5, aleth, RESO FIXED, Provide a way to obtain the normalizedName of a nick
14:12:20 * clokep mumbles.
14:12:36 <aleth> r+ from me...
14:13:01 <clokep> Does it work? :P
14:13:03 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 3091 on bug 2115.
14:13:06 <clokep> You can steal Florian's review then.
14:13:18 <aleth> Thanks
14:13:44 <instantbot> aleth@instantbird.org granted review for attachment 3091 on bug 2115.
14:16:08 <clokep> aleth: Did you test this? :P
14:16:25 <instantbot> aleth@instantbird.org denied review for attachment 3091 on bug 2115.
14:16:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2115 nor, --, 1.5, aleth, RESO FIXED, Provide a way to obtain the normalizedName of a nick
14:17:04 <clokep> aleth: Oops, you're right.
14:17:56 <aleth> clokep: Tested it just now.
14:17:59 <instantbot> clokep@gmail.com requested review from aleth@instantbird.o rg for attachment 3092 on bug 2115.
14:18:19 <instantbot> aleth@instantbird.org granted review for attachment 3092 on bug 2115.
14:22:55 <clokep> aleth: Should be in the next nightly.
14:27:17 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/c8ff45f03f66 - Patrick Cloke - Bug 2115 - Provide a way to obtain the normalizedName of a nick, add imAccount implementation, r=aleth.
14:28:41 --> aleth_dev has joined #instantbird
14:29:50 <-- aleth_dev has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
14:36:03 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 3088 on bug 451.
14:36:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=451 enh, --, 1.5, aleth, RESO FIXED, Participants Need Context Menu
14:36:21 <clokep> I dislike the number of reviews we're requesting on fixed bugs.
14:37:12 <aleth> Gah, attached the wrong patch
14:38:26 <instantbot> aleth@instantbird.org cancelled review?(florian@instantbird .org) for attachment 3088 on bug 451.
14:38:27 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 3093 on bug 451.
14:38:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=451 enh, --, 1.5, aleth, RESO FIXED, Participants Need Context Menu
14:39:19 <clokep> aleth: What is getNormalizedChatBuddyName?
14:39:36 <clokep> Is that something we just added?
14:39:43 <aleth> No, it's always been there.
14:39:51 <clokep> Oh that's the XMPP thing.
14:39:53 <aleth> It's what you use e.g. to requestBuddyInfo
14:40:39 <instantbot> clokep@gmail.com granted review for attachment 3093 on bug 451.
14:40:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=451 enh, --, 1.5, aleth, RESO FIXED, Participants Need Context Menu
14:40:50 * flo-retina isn't sure if he wants to laugh or cry when reading "What is getNormalizedChatBuddyName?"
14:41:15 <clokep> We just had so many different v ersions of the getNormalizedFooStuff.
14:41:17 <clokep> I couldn't remember.
14:41:21 <clokep> I still haven't had coffee. ;)
14:41:35 <aleth> Maybe you should switch back to mountain dew ;)
14:42:12 * aleth wonders what flo thinks about https://bugzilla.instantbird.org/show_bug.cgi?id=451#c24
14:44:21 <flo-retina> bleah :(
14:44:38 <flo-retina> I think you want to normalize the normalized chat buddy name :-P
14:45:12 <flo-retina> and btw, I agree with clokep: this should be a separate bug!
14:45:56 <flo-retina> clokep: my comment wasn't against you. It's just so unfortunate that even after so many explanations the meaning of these methods is still not obvious.
14:48:49 <clokep> :)
14:49:02 <aleth> It seemed a trivial followup... (I guess I should have known better than to expect trivial from anything to do with normalize)
14:49:20 <flo-retina> a trivial normalized follow-up? -P
14:49:39 * clokep sighs.
14:52:34 <instantbot> New Instantbird (UI) bug 2260 filed by aleth@instantbird.org.
14:52:35 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 3094 on bug 2260.
14:52:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2260 nor, --, ---, aleth, ASSI, Fix the getNormalizedName stub in nsContextMenu
14:56:39 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
14:56:50 <flo-retina> aleth: I think that patch is fine.
14:57:03 <flo-retina> The line "getBuddyByNameAndProtocol(account.normalize(nick)" seems wrong; but I don't see any non crazy way to improve it
14:57:20 <aleth> I'm not sure if you aren't right that it should be normalize(getNormalizedChatBuddyName)
14:57:41 <flo-retina> it should.
14:57:42 <aleth> flo-retina: Yes, there should really be a getBuddyByNameAndAccount
14:57:51 <flo-retina> But in the only case where that would matter in the future, that would be broken anyway
14:58:14 <aleth> Heh. Or at least it's likely to be broken...
14:58:25 <aleth> Let's use it anyway and add a comment.
14:58:42 <flo-retina> aleth: or isn't the problem that you want the normalize method available on the prpl even if we don't have an account?
14:59:53 <flo-retina> or maybe we should just disable the "add contact" item if the normalized chat buddy name is different from the normalized nick?
14:59:58 <flo-retina> hmm, no, that's not correct either :(
15:00:22 <flo-retina> ah, I know!
15:01:32 <flo-retina> var normalizedNick = conv.getNormalizedChatBuddyName(nick); We should disable the add contacts item if account.normalize(normalizedNick) != normalizedNick
15:01:50 <flo-retina> (except that would be broken with the current IRC implementation, where I think getNormalizedChatBuddyName does nothing)
15:02:17 <flo-retina> (and does nothing for a good reason (to preserve capitalization of the nick when opening a private conversation))
15:02:43 <aleth> That's not right.
15:02:54 <flo-retina> which part? :-D
15:03:09 <aleth> The IRC getNormalizedChatBuddyName normalizes.
15:03:30 <aleth> Precisely so as to not have to worry about capitalization ;)
15:03:33 <flo-retina> aleth: ah right.
15:03:43 <flo-retina> so my idea would work then?
15:04:26 <aleth> I think it makes sense, as we can't add XMPP MUC chatbuddies as contacts for example.
15:04:27 <-- dew has quit (Ping timeout)
15:04:55 --> dew has joined #instantbird
15:06:16 <flo-retina> I'm not sure adding them as contact is strictly impossible, but it would cause so many edge cases that I don't think we would want to do it
15:16:28 --> mconley has joined #instantbird
15:20:24 <instantbot> aleth@instantbird.org cancelled review?(florian@instantbird .org) for attachment 3094 on bug 2260.
15:20:25 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 3095 on bug 2260.
15:20:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2260 nor, --, ---, aleth, ASSI, Fix the getNormalizedName stub in nsContextMenu
15:29:43 --> clokep has joined #instantbird
15:29:43 * ChanServ sets mode +o clokep 
15:35:25 <instantbot> aleth@instantbird.org cancelled review?(florian@instantbird .org) for attachment 3095 on bug 2260.
15:35:26 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 3096 on bug 2260.
15:35:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2260 nor, --, ---, aleth, ASSI, Fix the getNormalizedName stub in nsContextMenu
15:41:31 <-- clokep has quit (Ping timeout)
15:47:45 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
16:05:57 --> clokep has joined #instantbird
16:05:57 * ChanServ sets mode +o clokep 
16:17:00 <instantbot> aleth@instantbird.org cancelled review?(florian@instantbird .org) for attachment 3087 on bug 2258.
16:17:01 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 3097 on bug 2258.
16:17:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2258 nor, --, ---, aleth, ASSI, Log sweeping code should close its iterators and handle errors better
16:37:07 <-- gerard-majax_ has quit (Ping timeout)
17:01:51 --> dionisos has joined #instantbird
17:18:20 <flo-retina> aah, plenty of patches in my review queue ;)
17:21:47 <flo-retina> aleth: I'm confused by the patch in bug 2260
17:21:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2260 nor, --, ---, aleth, ASSI, Fix the getNormalizedName stub in nsContextMenu
17:22:52 --> gerard-majax_ has joined #instantbird
17:23:44 <-- jb has quit (Ping timeout)
17:24:39 <-- gerard-majax_ has quit (Ping timeout)
17:27:08 <aleth> flo-retina: That patch looks broken.
17:27:20 <aleth> I wonder if I forgot to save something...
17:28:51 * flo-retina put review comments in the bug anyway
17:29:18 --> gerard-majax_ has joined #instantbird
17:30:53 <flo-retina> I guess I don't have any excuse to not do a real review of bug 2258 anymore now ;)
17:30:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2258 nor, --, ---, aleth, ASSI, Log sweeping code should close its iterators and handle errors better
17:32:38 --> wnayes has joined #instantbird
17:38:22 <instantbot> aleth@instantbird.org cancelled review?(florian@instantbird .org) for attachment 3096 on bug 2260.
17:38:23 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 3098 on bug 2260.
17:38:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2260 nor, --, ---, aleth, ASSI, Fix the getNormalizedName stub in nsContextMenu
17:38:52 <-- gerard-majax_ has quit (Ping timeout)
17:47:29 <flo-retina> "The idea is to check that the normalizedName of the nick would match that generated from the normalizedChatBuddyName." is just a translation in words of the code; it doesn't explain anything
17:47:41 <flo-retina> so I guess I'll need to explain my suggestion then :-S
17:48:54 <qheaden> Hello everyone.
17:49:44 <flo-retina> qheaden: hello :) Happy turkey!
17:49:50 <qheaden> :)
17:50:12 <qheaden> FYI, I'm almost finished my semester so I can get back to development again. I miss it.
17:52:14 <aleth> Happy thanksgiving!
18:00:13 --> gerard-majax_ has joined #instantbird
18:02:03 <-- gerard-majax_ has quit (Ping timeout)
18:02:44 --> qlum has joined #instantbird
18:34:56 <instantbot> florian@instantbird.org granted review for attachment 3090 on bug 2148.
18:34:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2148 nor, --, ---, clokep, ASSI, Remove VKontakte protocol
18:35:51 --> Mnyromyr has joined #instantbird
18:58:32 <flo-retina> clokep, aleth: do you guys have a release date in mind?
19:03:24 <aleth> String freeze, then when we're ready?
19:07:50 <flo-retina> I suspect if we don't give people deadlines to work against, we won't be ready any week soon ;).
19:09:04 <flo-retina> the last thing touching strings is bug 2148, right?
19:09:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2148 nor, --, ---, clokep, ASSI, Remove VKontakte protocol
19:09:20 <flo-retina> if so we could announce string freeze tonight, right?
19:09:30 <aleth> I think so.
19:09:36 * flo-retina was hoping Even would find time to fix the buildbot-l10n feedback emails :(
19:12:34 <-- wnayes has quit (Connection reset by peer)
19:12:40 --> wnayes has joined #instantbird
19:27:14 --> EionRobb has joined #instantbird
19:28:40 <clokep> flo-retina: Umm...some time well before Christmas. :)
19:47:26 <-- aleth has quit (Quit: Ciao)
19:48:42 <-- GeKo has quit (Quit: leaving)
20:03:08 --> gerard-majax_ has joined #instantbird
20:28:50 <-- gerard-majax_ has quit (Ping timeout)
20:33:06 <flo-retina> clokep: I was more hoping for someday next week ;)
20:37:32 <flo-retina> bug 2260 has already got 7 comments. It was definitely worth splitting it off :)
20:37:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2260 nor, --, ---, aleth, ASSI, Fix the getNormalizedName stub in nsContextMenu
20:48:34 <-- skeledrew has quit (Ping timeout)
20:49:00 --> skeledrew has joined #instantbird
22:08:54 --> jb has joined #instantbird
22:15:03 <-- mconley has quit (Input/output error)
22:46:54 <-- dionisos has quit (Ping timeout)
22:58:07 <-- qlum has quit (Client exited)
23:00:18 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
23:01:10 <-- jb has quit (Ping timeout)
23:13:01 --> jb has joined #instantbird
23:15:01 <-- jamesw has quit (Ping timeout)
23:15:33 <-- jb has quit (Ping timeout)