#instantbird log on 11 11 2013

All times are UTC.

00:08:44 <-- FireFly_TB has quit (Ping timeout)
00:10:37 <-- qlum has quit (Quit: Getting the <censored> out.)
01:05:32 --> mconley has joined #instantbird
01:20:21 <-- skeledrew has quit (Connection reset by peer)
01:20:23 --> skeledrew has joined #instantbird
01:34:43 <-- sabret00the has quit (Ping timeout)
01:37:22 --> FireFly_TB has joined #instantbird
01:39:59 <-- FireFly_TB has quit (Ping timeout)
01:53:32 --> sabret00the has joined #instantbird
02:19:42 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
02:54:39 --> clokep has joined #instantbird
02:54:39 * ChanServ sets mode +o clokep 
03:39:14 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
03:58:53 <-- wnayes has quit (Quit: wnayes)
04:06:24 <instant-buildbot> build #1029 of linux-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1029
05:13:14 <-- dew has quit (Ping timeout)
05:13:44 --> dew has joined #instantbird
05:21:01 <-- EionRobb has quit (Quit: Leaving.)
05:27:53 <-- dew has quit (Ping timeout)
05:27:58 --> dew has joined #instantbird
05:58:38 <-- mconley has quit (Input/output error)
06:27:46 --> FireFly_TB has joined #instantbird
07:46:12 --> GeKo has joined #instantbird
08:02:14 <instant-buildbot> build #1155 of win32-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1155
08:18:55 --> dionisos has joined #instantbird
08:31:29 --> Mic has joined #instantbird
08:31:29 * ChanServ sets mode +h Mic 
09:00:05 --> chrisccoulson has joined #instantbird
09:16:49 --> BWMerlin has joined #instantbird
09:51:41 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
09:52:14 --> Mic has joined #instantbird
09:52:14 * ChanServ sets mode +h Mic 
09:57:38 --> aleth has joined #instantbird
09:57:38 * ChanServ sets mode +h aleth 
10:02:37 --> mpmc has joined #instantbird
10:03:49 <-- dionisos has quit (Ping timeout)
10:15:56 <-- FireFly_TB has quit (Ping timeout)
10:24:26 --> jb has joined #instantbird
10:31:02 --> dionisos has joined #instantbird
10:53:34 <-- dionisos has quit (Ping timeout)
10:55:48 <-- jb has quit (Ping timeout)
11:43:26 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
11:55:46 <aleth> "Warning: XUL box for tooltip element contained an inline deck child, forcing all its children to be wrapped in a block."
11:56:01 <aleth> So if I unify the tooltips, we have to live with that stupid warning? :(
11:58:03 <flo-retina> before we decide to live with a stupid warning, maybe you can attach a WIP somewhere so that others see if they have ideas?
11:59:02 <aleth> Oh, this is still at the pre-WIP stage.
12:00:50 <aleth> More along the lines of an experiment http://pastebin.instantbird.com/434197
12:02:01 <aleth> I'd still prefer to find a way to tell certain DOM elements in the browser to use a different tooltip, but I can't figure out a way to do that.
12:03:57 <flo-retina> this line seems strange/wrong: http://lxr.instantbird.org/instantbird/source/chat/content/convbrowser.xml#748
12:06:52 <aleth> I want to drop that function and use http://dxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/popup.xml#l498
12:08:05 <aleth> (unless that can't be done for some reason I am not seeing at the moment)
12:11:21 <flo-retina> would be nice :)
12:11:44 <flo-retina> I tried to do that a while ago but couldn't get it to work for some reason I didn't understand
12:13:22 <aleth> Of course I'm not sure it can be used if we have to introduce a messy hack with decks etc.
12:14:16 * aleth is disappointed element.setAttribute("tooltip", ...) doesn't work for children of the browser.
12:20:46 <-- BWMerlin has quit (Quit: BWMerlin)
12:26:44 <aleth> Looks like that warning is there for a reason - decks don't seem to work inside tooltips.
12:43:42 --> clokep has joined #instantbird
12:43:42 * ChanServ sets mode +o clokep 
13:02:25 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
13:02:36 --> clokep has joined #instantbird
13:02:36 * ChanServ sets mode +o clokep 
13:28:49 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 3030 on bug 2189.
13:28:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2189 maj, --, ---, clokep, ASSI, package-manifest:35: Missing file(s): bin/uninstall/helper.exe
13:33:37 --> jb has joined #instantbird
13:35:54 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 3026 on bug 1587.
13:35:55 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 3031 on bug 1587.
13:35:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1587 min, --, 1.5, clokep, REOP, Re-sync installer with comm-central
13:36:23 <clokep> Bug 2189 is bad. :(
13:36:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2189 maj, --, ---, clokep, ASSI, package-manifest:35: Missing file(s): bin/uninstall/helper.exe
13:39:48 <aleth> Looks like nobody ever tries to uninstall IB? :P
13:43:02 <clokep> That's good, right? ;)
13:43:34 <-- dew has quit (Ping timeout)
13:43:39 --> dew has joined #instantbird
13:44:28 <-- jb has quit (Ping timeout)
13:46:54 --> jb has joined #instantbird
13:54:21 <-- jb has quit (Ping timeout)
13:55:01 <qheaden> Hello all. :)
13:55:19 <clokep> Hello qheaden.
13:55:45 <qheaden> If any of you bet on me not showing up again, sorry I messed it up. :P
14:32:15 --> jb has joined #instantbird
14:40:18 <-- jb has quit (Ping timeout)
14:41:51 <flo-retina> qheaden: I'm not sure why we would bet that.
14:49:01 <qheaden> :P
14:57:04 --> mconley has joined #instantbird
14:57:46 <aleth> Does anyone else see that when a tooltip expands in size (e.g. due to whois info) the dropshadow doesn't immediately extend to the new size of the tooltip?
14:58:08 <aleth> I'm not sure if that's one of those 32-bit-build things
14:58:52 <clokep> My whois comes back too fast to see that.
15:03:08 <clokep> Also, I don't think there's a drop shadow at all on Windows?
15:03:27 <flo-retina> aleth: I suspect the drop shadow is drawn by your window manager, not by gecko
15:04:38 <instantbot> florian@instantbird.org granted review for attachment 3030 on bug 2189.
15:04:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2189 maj, --, ---, clokep, ASSI, package-manifest:35: Missing file(s): bin/uninstall/helper.exe
15:05:18 <flo-retina> clokep: "This takes into account the changes from bug 2189." means it applies after it, right?
15:06:44 <flo-retina> clokep: looking at https://bugzilla.instantbird.org/attachment.cgi?id=3032&action=diff#instantbird/installer/package-manifest.in_sec3 why is components.manifest in ifndef XP_WIN?
15:06:54 <clokep> flo-retina: Yes, it means I added back in the packaging of uninstall/helper.exe and applies after it.
15:07:01 <clokep> If you applie it beforehand package will fail.
15:08:30 <clokep> Umm...let me see...
15:08:57 <clokep> flo-retina: Looks like it shouldn't be done that way.
15:10:21 <clokep> It works on Windows. :-D
15:10:44 <clokep> I'll try that patch on Linux.
15:11:36 <flo-retina> why is the ifdef NECKO_WIFI gone?
15:11:51 <flo-retina> clokep: what's the content of that components.manifest file?
15:12:03 <clokep> flo-retina: The ifdef where?
15:12:21 <clokep> binpath/components/components.manifest?
15:12:23 <flo-retina> clokep: https://bugzilla.instantbird.org/attachment.cgi?id=3031&action=diff#a/instantbird/installer/Makefile.in_sec1
15:12:29 <flo-retina> clokep: yes
15:12:57 <clokep> flo-retina: http://pastebin.instantbird.com/434462
15:14:54 * flo-retina felt like his review comments had been ignored again
15:14:59 <clokep> flo-retina: https://bugzilla.instantbird.org/show_bug.cgi?id=1587#c15
15:15:01 <instantbot> Bug 1587 min, --, 1.5, clokep, REOP, Re-sync installer with comm-central
15:15:03 <flo-retina> but to be fair, you asked a question about it that I didn't answer
15:15:08 <clokep> Yes.
15:15:19 <flo-retina> I thought we discussed it on IRC
15:15:35 <flo-retina> but I'm too lazy to look in the logs to check, so I'll pretend it didn't happen :-)
15:15:36 <clokep> Well, not really a question. But I stated my confusion.
15:15:45 <clokep> I think we did, but no solution never came out of it.
15:15:54 <clokep> It was just "we added that at some point", but no one knew why.
15:16:02 <flo-retina> what?
15:16:13 * flo-retina has never been confused about why these were added
15:16:24 <flo-retina> you didn't ask though :(
15:16:36 <clokep> Yeah it was added i nhttp://hg.instantbird.org/instantbird/rev/86599b6abbeb
15:16:41 <clokep> Oops, http://hg.instantbird.org/instantbird/rev/86599b6abbeb
15:17:02 <flo-retina> the NECKO_WIFI is so that we can build on our Linux slave, where installing the required libraries to support wifi are approximately of the same complexity as resinstalling the OS.
15:17:05 <clokep> It was never clear to me from our previous conversations whether they were necessary or not.
15:17:21 <flo-retina> the garbage thing is so that |make clean| works
15:17:41 <flo-retina> which was useful when testing that code
15:17:59 <clokep> Why are those not in c-c then?
15:18:08 <flo-retina> because nobody cares about make clean?
15:18:26 <flo-retina> it's likely broken in a dozen other ways :)
15:18:33 <flo-retina> but back at the time I had it working in Ib
15:18:36 <clokep> What about the NECKO_WIFI one?
15:18:39 <flo-retina> and I don't see a good reason to intentionaly break it
15:18:48 <flo-retina> 16:17:02 - flo-retina: the NECKO_WIFI is so that we can build on our Linux slave, where installing the required libraries to support wifi are approximately of the same complexity as resinstalling the OS.
15:19:01 <clokep> Yes, but why is that not in c-c?
15:19:22 <flo-retina> because they have correct slaves that don't require http://lxr.instantbird.org/instantbird/source/tools/buildbot-configs/linux/mozconfig#25 ?
15:19:24 <clokep> (I also don't really understand what necko has to know about WiFi specifically...)
15:19:50 <flo-retina> clokep: they added at the time some XPCOM interface (which is part of Necko) that lets XUL apps list the available wifi networks
15:19:55 <flo-retina> this is used for geolocation
15:20:00 <flo-retina> (which we don't really care about)
15:20:02 <clokep> I see.
15:20:05 <clokep> OK.
15:20:18 <flo-retina> at some point I had a cool add-on idea to use it :)
15:20:37 <flo-retina> detecting your usual locations, and restoring the status you had last time you were there
15:20:53 <flo-retina> ie connecting your work accounts at work, and your home accounts at home. Automatically.
15:21:50 <clokep> That's neat. :)
15:22:27 <flo-retina> "include $(MOZILLA_SRCDIR)/toolkit/mozapps/installer/signing.mk" I wonder if this will give us a large part of the work to get signed builds
15:22:34 <flo-retina> we need to investigate that at some point :(
15:22:55 <clokep> Yeah. :-/
15:23:44 <clokep> flo-retina: OK I've added both those back in.
15:23:46 <flo-retina> I wouldn't be really surprised if the APP_SOURCE_REPO thing in your patch didn't work on our slaves
15:23:50 <clokep> And I'll fix the components ifdef.
15:23:59 <flo-retina> although if it's only looking at the ib repo, it's relatively likely to work
15:24:07 <flo-retina> it's for the mozilla/ one that we do some magic on the slaves
15:24:26 <flo-retina> clokep: have you looked at the content of that components.manifest file?
15:24:30 <flo-retina> what is it?
15:24:38 <clokep> Did I not pastebin that? Hmm...
15:24:41 <flo-retina> I'm surprised that Tb has an ifdef around it
15:24:49 <clokep> 10:12:57 AM - clokep: flo-retina: http://pastebin.instantbird.com/434462
15:24:58 <flo-retina> you did!
15:25:14 <flo-retina> ah, if we've got purplexpcom in there, it needs to be packaged on all OSes :)
15:25:29 <clokep> Yup!
15:25:30 <flo-retina> I was kindof assuming that we would only have the tray thing
15:26:01 <clokep> flo-retina: Should I add that same ifdef as c-c or just not ifdef it?
15:26:10 <flo-retina> no ifdef
15:26:24 <flo-retina> what would that "same ifdef" look line anyway?
15:26:51 <clokep> #if defined(MOZ_ENABLE_DBUS) || defined(MOZ_ENABLE_GNOME_COMPONENT) || defined(MOZ_ENABLE_GNOMEVFS)
15:27:05 <clokep> That sounds fairly unrelated though. :-D
15:27:07 <clokep> Just making sure!
15:27:45 <flo-retina> looks like after your changes @BINPATH@/@MOZ_APP_NAME@ will be packaged on mac
15:27:48 <flo-retina> any reason for that?
15:29:14 <flo-retina> heh, @BINPATH@/splash.bmp :)
15:29:23 <flo-retina> I thought we had removed all the WinCE junk already :)
15:29:52 <flo-retina> starting on WinCE was so slow that we had a slash screen to show that _something_ was going on.
15:30:05 <clokep> Hah. I guess we missed that.
15:30:32 <flo-retina> I'm not convinced the [OS/2] section is of any use, but if that makes us closer to Tb... :)
15:31:08 <clokep> flo-retina: I don't reall yknow what @BINPATH@/@MOZ_APP_NAME@ is, but It looks like it's packaged in c-c?
15:31:30 <flo-retina> I suspect there's a long story there
15:32:09 <clokep> Btw I also think that the changes to use MOZ_MSVC_REDIST instead of _MSC_VER could be very bad if we don't include those...
15:32:58 <flo-retina> I wonder what autoconfig.xpt is
15:35:26 <flo-retina> clokep: I don't understand what you mean with "the changes to use MOZ_MSVC_REDIST instead of _MSC_VER could be very bad if we don't include those..."
15:35:43 <clokep> I feel like it could cause us to not include the proper redistributable libraries on Windows.
15:36:03 <clokep> I.e. people would get the errros saying they don't have the right versions of libraries when running IB.
15:36:15 <flo-retina> I don't really see how that would happen
15:36:33 <clokep> OK
15:36:44 <flo-retina> Looks to me that the worst that could happen there without the patch is packaging failing on Windows for people who haven't set the WIN32_REDIST_DIR var in their mozconfig
15:37:04 <clokep> OK.
15:37:20 <flo-retina> and now it will instead package builds without the required DLLs
15:37:38 <flo-retina> I'm not convinced that's an improvement, but if that makes us match Tb... :)
15:37:55 <flo-retina> maybe it helps packaging of debug builds?
15:38:21 <flo-retina> clokep: I've looked at the rest of the patch and don't have any additional comment
15:38:47 <flo-retina> clokep: would probably be good to try it on Mac before pushing; especially as our onCommit builds are broken, so we won't know quickly if it fails
15:41:20 <clokep> flo-retina: Seems reasonable.
15:41:41 <clokep> flo-retina: Current interdifff: http://pastebin.instantbird.com/434504
15:45:35 <flo-retina> clokep: seems ok :)
15:47:02 <clokep> Sweet.
15:47:14 <clokep> Should I upload a new patch? Do you want me to try to build on Linux first?
15:47:22 <clokep> (Although I think my build is busted there w/ bonjour errors...)
15:47:30 <flo-retina> if you can do quickly that would be nice
15:47:34 <flo-retina> if it would take hours, don't bother
15:47:50 <clokep> It will take me a while, most likely.
15:47:55 <clokep> (And I need to do a few real life things.)
15:50:35 <flo-retina> the sw:1.5 list seems to finally start shrinking :)
15:51:16 <instantbot> clokep@gmail.com set the Resolution field on bug 2189 to FIXED.
15:51:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2189 maj, --, 1.5, clokep, RESO FIXED, package-manifest:35: Missing file(s): bin/uninstall/helper.exe
15:51:26 <instantbot> clokep@gmail.com set the Resolution field on bug 2069 to FIXED.
15:51:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2069 nor, --, 1.5, aleth, RESO FIXED, Update theming for '+' button on Linux
15:51:45 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/0762f55e4717 - Patrick Cloke - Bug 2189 - package-manifest:35: Missing file(s): bin/uninstall/helper.exe, r=fqueze.
15:51:46 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/707d51c8f267 - aleth - Bug 2069 - Update theming for '+' button on Linux, r=clokep.
15:52:40 <clokep> Still pretty long though. :(
15:52:51 <clokep> flo-retina: Any chance you can look at bug 2194?
15:52:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2194 nor, --, ---, nobody, NEW, Blinking scrollbar whenever timebubbles adds a pixel at the bottom of the conversation
15:53:03 <clokep> I'm unsure what the fix is for that though, but I think we need someone on a Mac to do it. :)
15:53:25 * flo-retina doesn't feel like the only one having a mac
15:55:26 <clokep> nhnt11?
15:56:09 <clokep> Does Not Today! work? http://log.bezut.info/instantbird/today/#m92
15:56:52 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 3031 on bug 1587.
15:56:53 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 3034 on bug 1587.
15:56:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1587 min, --, 1.5, clokep, REOP, Re-sync installer with comm-central
15:58:38 <flo-retina> aleth: where is fillInPageTooltip implemented?
15:58:48 --> aleth_dev has joined #instantbird
15:59:00 <-- aleth_dev has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
15:59:13 <flo-retina> hmm, do you inherit it from popup.xml#tooltip?
15:59:35 <flo-retina> looks like it :)
15:59:49 <clokep> flo-retina: Thanks for looking at those ptaches btw. :) I know they're not fun.
15:59:51 <aleth> flo-retina: yes
15:59:56 <instantbot> aleth@instantbird.org cancelled review?(florian@instantbird .org) for attachment 3033 on bug 1693.
15:59:57 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 3036 on bug 1693.
15:59:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1693 enh, --, ---, aleth, ASSI, Show participant tooltip when hovering nick in conversation
16:00:37 <flo-retina> clokep: you are welcome. They are more fun (to me) than server migration stuff
16:01:22 <clokep> Haha! :)
16:01:25 <flo-retina> aleth: I hope we werent using FillInHTMLTooltip in Tb
16:01:30 <clokep> More fun for me than BIO->BMO. :P
16:01:38 <aleth> clokep: they don't look like fun to write either ;)
16:01:47 <flo-retina> looks lke we weren't :)
16:01:56 <flo-retina> clokep: ahah
16:02:09 <flo-retina> aleth: indeed, they look boring enough that we shouldn't let them bitrott
16:02:39 <aleth> Yes, there is nothing less motivating than having to look at a boring patch /again/ when one has forgotten what one did in it
16:02:40 <flo-retina> aleth: is the next step to make the tooltips work on awesometab items? ;)
16:02:52 <aleth> flo-retina: not for 1.5 I think ;)
16:03:01 <flo-retina> aleth: I'm afraid that will happen to me
16:03:29 <flo-retina> my patch in https://bugzilla.mozilla.org/show_bug.cgi?id=723951 looked awfully bitrotted last time I looked
16:04:21 <aleth> looks like that's been sitting there for a while :-/
16:05:23 <flo-retina> aleth: would it be difficult to make the tooltips work on logs too?
16:05:38 <flo-retina> I know we don't highlight nicks, but the sender have their tags, right?
16:06:46 <aleth> flo-retina: Wouldn't it be a bit broken as it would only work for people who happened to be online while you were reading the log?
16:07:56 <flo-retina> is it really a problem?
16:08:16 <flo-retina> btw, do the tooltip look OK for nicks that have left the room/are offline?
16:09:04 <flo-retina> hmm, do we have the context menus on nicks in the logs?
16:09:10 <flo-retina> if not I guess it's consistent to skip the tooltips too
16:09:22 <flo-retina> We don't. ok.
16:09:58 <aleth> The other problem is you'd have to associate the log reader with a conversation, and the user can close that conversation tab before closing the log reader.
16:10:05 <aleth> I forsee edge cases...
16:10:10 <flo-retina> aleth: the patch looks great. I'll want to try it, and look at a diff -w of buddytooltip.xml  before r+'ing though.
16:10:28 <aleth> There's a lot of indentation change at one point.
16:10:39 <-- aleth has quit (Quit: Ciao)
16:10:51 --> aleth has joined #instantbird
16:10:52 * ChanServ sets mode +h aleth 
16:10:53 <flo-retina> that's why I want to look at the diff -w :)
16:11:19 <aleth> Parted/offline nicks are no problem btw.
16:11:23 <flo-retina> cool :)
16:11:50 <aleth> Hmm, a disconnected account though...
16:12:12 <flo-retina> aleth: I suspect we have a conversation object for a log, so I don't see that as been a huge problem.
16:12:34 <flo-retina> but I agree showing tooltips on logs seems to add more edge cases than it fixes
16:12:36 <aleth> Doesn't seem to be a problem\
16:13:43 <aleth> flo-retina: A r+ on bug 1454 would be nice too, just to get that done with ;)
16:13:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1454 tri, --, ---, aleth, ASSI, Add explanatory comments to document normalizedNames
16:13:56 <flo-retina> looks like I won't code today :(
16:14:04 <aleth> That patch is trivial...
16:14:31 <aleth> It's just there to help future coders new to the code
16:14:58 <flo-retina> aleth: I think the comment style in prplIConversation.idl is not what we typically use
16:15:03 <flo-retina> I don't really care though
16:15:39 <flo-retina> aleth: the typical style is http://lxr.instantbird.org/instantbird/source/chat/components/public/prplIConversation.idl#84
16:16:09 <flo-retina> there's one exception at http://lxr.instantbird.org/instantbird/source/chat/components/public/prplIConversation.idl#40 but I suspect it's because it's 2 comments (or sentences) that are next to each other
16:16:20 <aleth> Something tabby must have happened here http://lxr.instantbird.org/instantbird/source/chat/components/public/prplIConversation.idl#104 ;)
16:16:58 <aleth> flo-retina: Right, I should probably remove those excess */
16:17:16 <instantbot> florian@instantbird.org granted review for attachment 3017 on bug 1454.
16:17:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1454 tri, --, ---, aleth, ASSI, Add explanatory comments to document normalizedNames
16:17:31 <flo-retina> aleth: that's on purpose.
16:17:54 <flo-retina> aleth: "attribute" is aligned with the other "attribute", so the 'indent' is the space of the 'readonly' keyword you don't have on that line
16:18:29 <instantbot> aleth@instantbird.org granted review for attachment 3037 on bug 1454.
16:19:05 <aleth> flo-retina: Ah OK.
16:20:44 <aleth> Thanks!
16:21:13 <flo-retina> :)
16:27:12 * aleth wonders if he should add documentation for the page attribute on tooltips to MDN or whether that is intentionally undocumented
16:31:46 * flo-retina has updated the end of http://ftp.instantbird.com/instantbird/stats/ by hand
16:32:11 <flo-retina> aleth: is there the dev-doc-needed tag on the BMO bug that implemented it?
16:32:48 <flo-retina> but I think you can feel free to add doc on MDN if you manage to login :)
16:33:11 <aleth> Ah, I forgot about the Persona wall ;)
16:36:32 <aleth> flo-retina: There's no doc-needed.
16:36:56 <flo-retina> you can add it if you don't feel like fighting Persona
16:51:44 <flo-retina> aleth: what is the <children> for?
16:52:38 <aleth> It specifies where non-anonymous child nodes get added iirc. It's carried across from the content of the standard tooltip.
16:52:55 <flo-retina> aleth: this is the diff -w I'm looking at: http://pastebin.instantbird.com/434609
16:53:49 <aleth> http://dxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/popup.xml#l472
16:54:49 <flo-retina> aleth: ok, if it matches the other implementation I guess it's safer this way, but I don't see it being used anywhere
16:55:01 <flo-retina> I don't see any appendChild or insertBefore call in popup.xml
16:55:12 <aleth> I don't see it being used, but I don't want it to break if they change fillInPageTooltip
16:56:47 --> florian has joined #instantbird
16:57:08 * florian is now known as IRCMonkey27799
16:58:09 --> jb has joined #instantbird
16:59:30 <-- jb has quit (Quit: jb)
17:00:05 <IRCMonkey27799> I wonder if we can revert the tooltip sizing hack we added after the moz24 update
17:01:39 --> jb has joined #instantbird
17:05:48 <flo-retina> aleth: http://i2.minus.com/iLT1HrDA8QNXW.png
17:06:11 <aleth> flo-retina: That's strange, I don't get that.
17:06:29 <aleth> Must be the Mac-only tooltip sizing hack ;)
17:06:50 <flo-retina> aleth: http://hg.instantbird.org/instantbird/rev/ea3cbcee9243
17:07:51 <-- IRCMonkey27799 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:09:00 --> florian has joined #instantbird
17:09:19 * florian is now known as IRCMonkey60414
17:09:43 <aleth> Hmm, no idea what's causing that then. I can't reproduce.
17:10:06 <IRCMonkey60414> The bug still exists :(
17:11:17 <flo-retina> If I remove the hack it looks like this: http://i6.minus.com/ibrBxOH4gd0TeX.png
17:11:43 <aleth> Maybe you have to change the hack to sizeTo(0,0(
17:12:07 <flo-retina> we tried that before, it didn't work
17:12:21 <aleth> sizeTo(1,0)? ;)
17:12:23 <flo-retina> it forces the tooltip to a stupidly small width (as small as it can get away with)
17:12:44 <flo-retina> random idea: would it work if we removed the node from the DOM and reinserted it?
17:12:51 <flo-retina> would that get rid of the cached size?
17:13:11 <aleth> Try it?
17:13:24 <flo-retina> I will
17:13:32 <flo-retina> I was already annoyed by these poorly sized tooltips
17:13:42 <-- sary has quit (Ping timeout)
17:13:46 <flo-retina> now that it's the only thing blocking me from having nick-tooltips, I'm even more motivated ;)
17:14:09 <aleth> Otherwise put a mac-only sizeto(0,0) in popupshowing before fillinPageToolTip is called?
17:14:25 <clokep> Thanks for finishing these normalization bugs aleth. :)
17:16:42 <aleth> flo-retina: Or maybe calling getComputedStyle would do the trick?
17:17:11 <flo-retina> getComputedStyle after hiding it? That's nasty! :)
17:17:21 <aleth> very :)
17:17:48 --> sary has joined #instantbird
17:20:25 --> dionisos has joined #instantbird
17:21:00 <-- IRCMonkey60414 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:21:26 <flo-retina> I'm annoyed enough by all the shutdown noise that I may fix it soon
17:21:27 --> florian has joined #instantbird
17:21:53 * florian is now known as IRCMonkey47795
17:22:06 <-- IRCMonkey47795 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:22:32 --> florian1 has joined #instantbird
17:26:54 <-- florian1 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:27:20 --> florian has joined #instantbird
17:27:42 * florian is now known as IRCMonkey12613
17:30:14 <IRCMonkey12613> aleth: this seems unfriendly: JavaScript error: chrome://instantbird/content/buddytooltip.xml, line 360: aConv.target.getNormalizedChatBuddyName is not a function
17:30:32 <aleth> That's not good :(
17:30:36 <aleth> How did you get that?
17:30:46 <aleth> In a PM I suppose :-S
17:31:01 <aleth> I should check isChat.
17:31:09 <aleth> Good catch!
17:31:28 <flo-retina> aleth: yes, the sender of a PM (nickserv)
17:31:55 <flo-retina> right, if you are not in a chat you don't need the getNormalizedChatBuddyName call
17:31:58 <aleth> The tooltips won't work outside MUCs.
17:32:02 <flo-retina> why?
17:32:16 <aleth> getNormalizedChatBuddyName doesn't exist...
17:33:09 <flo-retina> you don't need it outside of a chat
17:35:16 <flo-retina> aleth: I've done http://pastebin.instantbird.com/434680
17:35:25 <flo-retina> it works perfectly in the conversation window!
17:35:31 <flo-retina> and doesn't work at all in the blist
17:35:43 <flo-retina> (in the blist tooltips behave as if I had fully removed the hack)
17:39:11 <aleth> Mysterious.
17:39:20 --> wnayes has joined #instantbird
17:39:57 <-- IRCMonkey12613 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:40:25 --> florian has joined #instantbird
17:40:49 * florian is now known as IRCMonkey50109
17:42:12 <flo-retina> hmm, so whois likely actually works
17:42:24 <flo-retina> it's just that its result is only displayed the first time in each window
17:42:27 <instantbot> aleth@instantbird.org cancelled review?(florian@instantbird .org) for attachment 3036 on bug 1693.
17:42:28 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 3038 on bug 1693.
17:42:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1693 enh, --, ---, aleth, ASSI, Show participant tooltip when hovering nick in conversation
17:43:20 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:43:29 <flo-retina> aleth: so no tooltip in private conversations?
17:43:38 <aleth> No, I added one.
17:44:09 <aleth> (Just no tooltip for yourself ;))
17:44:57 <flo-retina> and no whois results if the nick you are talking too isn't in your contact list?
17:45:24 <aleth> Well, that's a different can of worms.\
17:45:58 <flo-retina> yeah, you can reasonably pretend it's another instance of an existing bug :)
17:46:06 * flo-retina is annoyed by these tooltips
17:46:32 <aleth> We should have the correct whois in the conversation tooltip for those too...
17:47:14 <flo-retina> your patch doesn't touch http://lxr.instantbird.org/instantbird/source/instantbird/content/blist.xul#48 at all?
17:47:49 <aleth> No (I'm not sure what that does, but it WFM)
17:48:28 <aleth> Ah, it prevents a tooltip over the drop target, duh.
17:49:35 <clokep> Tooltips for private conversations don't work unless a buddy exists IIRC.
17:49:54 <aleth> A lot of things break for private conversations with non-buddies :-S
17:50:05 <aleth> We should really put our heads together some day and try and solve that.
17:50:08 <clokep> I'm just really unsure what the bug is there...
17:50:10 <clokep> I know.
17:50:17 * clokep has a feeling flo-retina might know the real issue. :-D
17:50:30 <flo-retina> aleth: I was trying to find an explanation for having a different sizing behavior in the blist and the conv window
17:50:40 <flo-retina> clokep: what's the real issue?
17:51:02 <aleth> The problem is we need a 'fake' temporary buddy.
17:51:32 <flo-retina> so would prplIConvIM have to implement prplIAccountBuddy?
17:51:45 <flo-retina> anyway, I don't know what the problem is, and don't care too much
17:54:11 <aleth> "put a mac-only sizeto(0,0) in popupshowing before fillinPageToolTip is called" didn't work?
17:54:39 <flo-retina> I can try.
17:54:56 <flo-retina> but I'm afraid it would have side effects for the regular popup the next time it's shown
17:55:12 <aleth> Yeah... these are ugly hacks anyway.
17:55:20 <-- IRCMonkey50109 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:55:20 <aleth> Is there some BMO bug about this?
17:55:28 <flo-retina> I don't know
17:55:41 <flo-retina> would be great if we could push to get that fixed :-/
17:55:42 <aleth> You'd think someone would have run into that in another context by now...
17:55:58 <flo-retina> maybe nobody cares about xul tooltips?
17:56:11 --> florian has joined #instantbird
17:56:24 <-- jb has quit (Ping timeout)
17:56:32 <aleth> m conley might know
17:56:33 * florian is now known as IRCMonkey45586
17:58:24 <-- IRCMonkey45586 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:58:50 --> florian has joined #instantbird
17:59:10 * florian is now known as IRCMonkey40500
18:01:27 <-- IRCMonkey40500 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
18:01:46 --> Mnyromyr has joined #instantbird
18:01:56 --> florian has joined #instantbird
18:02:17 * florian is now known as IRCMonkey47275
18:05:43 --> qlum has joined #instantbird
18:10:48 <-- IRCMonkey47275 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
18:11:15 --> florian has joined #instantbird
18:11:38 * florian is now known as IRCMonkey11345
18:13:35 <flo-retina> aleth: interestingly, in the conv window, just adding a        this.reset(); call in the popuphiding handler fixes the issue and I can remove the hack.
18:13:41 <flo-retina> aleth: doesn't work at all in the blist though :(
18:14:20 * clokep can't wait until aleth's patches have commit messages in them.
18:14:28 <flo-retina> :)
18:15:09 <flo-retina> any idea of what could be different on the blist?
18:15:52 <-- IRCMonkey11345 has quit (Input/output error)
18:16:16 --> florian has joined #instantbird
18:16:37 * florian is now known as IRCMonkey15186
18:17:01 <instant-buildbot> build #1182 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/1182
18:17:30 <instantbot> clokep@gmail.com set the Resolution field on bug 1454 to FIXED.
18:17:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1454 tri, --, 1.5, aleth, RESO FIXED, Add explanatory comments to document normalizedNames
18:17:53 <-- IRCMonkey15186 has quit (Input/output error)
18:18:17 --> florian has joined #instantbird
18:18:38 * florian is now known as IRCMonkey45974
18:19:35 <flo-retina> never seen "JavaScript error: chrome://instantbird/content/buddytooltip.xml, line 299: buddyElt.build is not a function" before
18:19:35 <clokep> https://twitter.com/gazoombo/status/399963720493043714
18:20:10 <aleth> I'm confused about the blist, because really the changes I made shouldn't affect it at all.
18:20:31 <flo-retina> clokep: he doesn't want search, he wants the awesometab
18:20:42 <aleth> clokep: Tell him to try again with 1.5 or a nightly! ;)
18:20:54 <flo-retina> and the target selector won't help him to change his account :(
18:21:05 <clokep> :-/
18:21:11 <clokep> (We should add a chevron next to that btw...)
18:21:14 <aleth> That's a bit broken, yes
18:21:57 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/29a88d2a25ed - aleth - Bug 1454 - Add explanatory comments to document normalizedNames, r=fqueze,clokep.
18:22:15 <flo-retina> clokep: I think we'll cleanup that part of the UI when adding a video chat, or file transfer icon (whichever comes first)
18:22:23 * clokep figured he'd take a third of the responsibility for that check-in. ;)
18:23:06 <flo-retina> clokep: only a fourth! Reviewers all together have only half :)
18:23:14 <flo-retina> doesn't seem risky though ;)
18:23:52 * clokep hates doing feedback over Tiwtter.
18:24:00 <clokep> Twitter is such a garbage medium. :-/
18:24:53 <-- sary has quit (Ping timeout)
18:25:34 <clokep> We need blinking arrows when you have an off screen message that was received...
18:25:53 <flo-retina> s/blinking/highlighted/
18:26:38 <flo-retina> clokep: some of the logic to trigger that when a tab is opened off screen exists. We just need to also trigger it when a message is received in an offscreen tab
18:26:42 <flo-retina> it may not be very difficult
18:27:46 <flo-retina> aleth: "I'm confused about the blist, because really the changes I made shouldn't affect it at all." it's not your changes that affect the blist. It's what I'm trying to do instead of the existing workaround that affects the blist.
18:27:54 <-- IRCMonkey45974 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
18:28:24 --> florian has joined #instantbird
18:28:43 * florian is now known as IRCMonkey1472
18:29:35 <flo-retina> actually, that this.reset() didn't help at all
18:29:52 <flo-retina> I've just verified that just commenting out the workaround works perfectly on the conv window
18:29:59 <flo-retina> on the blist on the other hand... :(
18:32:04 <flo-retina> so I guess I'm now looking for something that's different in updatefromcontact/buddy than it is for update from conv / participant
18:41:24 <clokep> Sounds likely.
18:41:35 <clokep> And you thought you wouldn't write any code today! :P
18:43:00 <flo-retina> clokep: I wanted to write the log indexing code
18:44:33 <flo-retina> given http://lxr.instantbird.org/instantbird/source/instantbird/content/buddytooltip.xml#310, it will be difficult to find something actually different :-S
18:47:26 <-- IRCMonkey1472 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
18:48:21 --> florian has joined #instantbird
18:48:42 * florian is now known as IRCMonkey16248
18:51:29 <aleth> Random thought - The size of the blist window?
18:51:54 <clokep> flo-retina: And I wanted to write a blog post, but I've been cleaning all day.
18:53:03 <flo-retina> I don't understand http://mxr.mozilla.org/mozilla-central/source/layout/xul/base/src/nsPopupBoxObject.cpp#152
18:54:23 <-- IRCMonkey16248 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
18:54:49 --> florian has joined #instantbird
18:55:10 * florian is now known as IRCMonkey51045
18:55:25 --> rosonline has joined #instantbird
18:57:07 <flo-retina> Looking at the sizeTo implementation gave me a better workaround :)
18:57:49 <-- IRCMonkey51045 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
18:58:15 --> florian has joined #instantbird
18:58:40 * florian is now known as IRCMonkey39166
19:00:55 <-- IRCMonkey39166 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
19:01:21 --> florian has joined #instantbird
19:01:42 * florian is now known as IRCMonkey51137
19:06:52 --> JosiahOne has joined #instantbird
19:07:20 <clokep> How'd the exam go? :P
19:07:30 <JosiahOne> Very well. :)
19:08:13 <JosiahOne> If it didn't go well I'd be shocked. :)
19:08:34 <JosiahOne> But about the spam problems...
19:09:26 <JosiahOne> clokep: Have any suggestions about what to do with them?
19:09:52 <flo-retina> aleth: http://pastebin.instantbird.com/434801
19:09:54 <-- IRCMonkey51137 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
19:10:16 <flo-retina> JosiahOne: is it possible to have a summary of the problem?
19:11:12 --> florian has joined #instantbird
19:11:15 <aleth> flo-retina: nice! I'm surprised that works, seeing as we don't set height by hand
19:11:17 <JosiahOne> flo-retina: I suppose so. :) Sorry, my original problems were mentioned on #maildev.
19:11:33 * florian is now known as IRCMonkey62242
19:12:00 <JosiahOne> Basically I've been getting a lot of spam PMs from users on #ux and #fx-team, but I can find no way to ignore/block/etc these people on instantbird.
19:12:35 <clokep> http://pastebin.instantbird.com/434812 was the conversation last night flo-retina
19:12:57 <flo-retina> maybe I should also remove the width
19:13:04 <clokep> (That's one of the few times I've wanted a "copy conversation" function btw. :))
19:13:07 <flo-retina> aleth: that works much better than the workaround we already had.
19:13:22 <flo-retina> aleth: the sizeTo method sets the width and height attributes
19:13:26 <aleth> flo-retina: Do you know enough now to file the underlying bug?
19:13:46 <flo-retina> aleth: no
19:14:01 <flo-retina> the part that's still totally unclear is: why do we need this in the blist, and not the conv window?
19:14:03 <JosiahOne> clokep: BTW, I only have a couple minutes before I have to run home, but I'll get back on after that.
19:15:05 <JosiahOne> Seems like I really can't do anything about it right now until the bug is fixed that allows ignoring users.
19:15:48 * JosiahOne is now known as JosiahOne|Away
19:16:03 <aleth> JosiahOne: It would be fairly easy to add something hackish for IRC only, but solving it properly across all protocols, with a nice UI, is not trivial.
19:17:05 <aleth> E.g. an add-on could add a suitable IRC command.
19:17:32 <-- JosiahOne|Away has quit (Ping timeout)
19:19:08 <clokep> aleth: Tab complete should handle someone changing a nick while you're typing a message. ;)
19:19:32 <aleth> :D
19:20:36 <-- rosonline has quit (Ping timeout)
19:35:19 <-- dionisos has quit (Ping timeout)
19:40:19 --> JosiahOne has joined #instantbird
19:44:54 <-- qlum has quit (Quit: Getting the <censored> out.)
19:45:30 --> qlum has joined #instantbird
19:48:11 --> EionRobb has joined #instantbird
19:55:18 * clokep just tried to right click on an IRC message to get a link to it on log.bezut.info....
19:55:28 <clokep> JosiahOne: http://log.bezut.info/instantbird/today/#m503
20:03:12 <-- chrisccoulson has quit (Connection reset by peer)
20:03:28 --> chrisccoulson has joined #instantbird
20:04:50 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
20:05:48 * clokep wonders how the hell oyu register a command again...
20:08:32 <JosiahOne> clokep: Thanks.
20:09:26 <JosiahOne> clokep/aleth: How would one accomplish this hack if one wanted it? What the basic idea of adding it as an add-on or the like?
20:09:44 <clokep> JosiahOne: I'm like 85% of the way done w/ it. ;)
20:10:12 <JosiahOne> clokep: Well hey, that works too! :)
20:11:00 <aleth> clokep: You can steal command registration from nhnt11's pastebinner
20:20:20 <-- JosiahOne has quit (Ping timeout)
20:20:41 <clokep> aleth: Somewhere for IRC we do some crazy map() to trim things and then filter to strip things out? Where was that...?
20:20:54 <clokep> Ah, I Found it. :)
20:20:57 <clokep> http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#1169
20:22:23 <clokep> What's the opposite of "ignore"?
20:22:44 <clokep> unignore? :P
20:23:00 <aleth> nore? :P
20:24:09 <aleth> maybe /notice or /show... or just /ignore twice
20:24:35 --> JosiahOne has joined #instantbird
20:47:57 <flo-retina> so... I would like us to finish that tooltip patch before I go drive the AMI :)
20:48:18 <aleth> I have 5 minutes ;)
20:48:31 <flo-retina> hmm
20:48:44 <aleth> Was there anything left to do?
20:48:49 <flo-retina> I'm wondering if the workaround change should go in your patch, or in a new bug, or reopen the previous bug
20:49:01 <aleth> Sounds more related to the previous bug, as a followup or reopened
20:49:04 <flo-retina> decide how we are working around the work around, and who r+s it
20:49:10 <flo-retina> yeah, I think I'll reopen
20:49:43 <-- IRCMonkey62242 has quit (Input/output error)
20:49:46 <aleth> I couldn't think of a good hypothesis for why the blist has that issue either (other than a vague guess that it is usually a narrower window)
20:50:08 --> florian has joined #instantbird
20:50:09 <-- JosiahOne has quit (Ping timeout)
20:50:28 * florian is now known as IRCMonkey61145
20:50:42 <flo-retina> aleth: I was wondering if it's worth investigating
20:51:01 <flo-retina> if it is, I think I would add mutation observers, and try to see if they are fired in the same way in the conv and blist window
20:51:12 <flo-retina> and if not, break there with a debugger, and see what's going on
20:51:20 <flo-retina> I'm not convinced that's really worth the effort
20:51:51 <aleth> If the workaround works...
20:52:16 <aleth> It would be enough to find a testcase actually.
20:52:34 <flo-retina> well, what we want to know is what's different
20:52:37 <aleth> If you care about getting it fixed in the core, that is.
20:52:55 <flo-retina> I care. But I care more about fixing plenty of other bugs we have
20:53:02 <aleth> Yeah...
20:53:09 <flo-retina> so which bug was that
20:53:27 <flo-retina> bug 2113
20:53:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2113 nor, --, 1.5, florian, REOP, Buddy tooltips have incorrect sizes
20:53:39 <aleth> Not that long ago.
20:53:50 <flo-retina> which is it already "reop"?
20:54:18 <-- GeKo has quit (Quit: leaving)
20:54:47 <aleth> flo-retina: https://bugzilla.mozilla.org/show_bug.cgi?id=802335 ?
20:55:32 <aleth> Sorry, I meant https://bugzilla.mozilla.org/show_bug.cgi?id=464440
20:55:56 <flo-retina> we are looking for a moz22 regression
20:56:43 <aleth> Gah, sorry, I was looking at the last modified date by accident.
20:56:48 <instantbot> florian@instantbird.org requested review from the wind for attachment 3039 on bug 2113.
20:56:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2113 nor, --, 1.5, florian, REOP, Buddy tooltips have incorrect sizes
20:57:39 <instantbot> aleth@instantbird.org granted review for attachment 3039 on bug 2113.
20:58:09 <-- aleth has quit (Quit: Ciao)
20:58:28 <clokep> OK so in a bootstrap extension...why is my command not registered if I restart Instantbird? http://pastebin.instantbird.com/434958
20:58:30 <flo-retina> alright, time for checkins I guess
20:59:01 <flo-retina> clokep: does it work if you disable/enabled your add-on?
20:59:30 <clokep> flo-retina: Yes.
21:00:21 <flo-retina> clokep: calling registerCommand before http://lxr.instantbird.org/instantbird/source/chat/components/src/imCommands.js#16 seems a unhappy thing
21:00:36 <clokep> flo-retina: Yes, I just saw that. :) Good catch.
21:00:51 <flo-retina> clokep: so you'll need to check Services.core.initialized
21:00:55 <clokep> Yup!
21:01:00 <flo-retina> and if false, observe prpl-init
21:02:21 <-- IRCMonkey61145 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
21:02:29 <clokep> Can I remove an observer in itself?
21:02:33 <clokep> Or does that leak?
21:02:39 <flo-retina> why not?
21:02:57 --> florian has joined #instantbird
21:03:00 <flo-retina> that will leak if you never remove it
21:03:17 * florian is now known as IRCMonkey61951
21:03:58 <clokep> OK.
21:04:43 <flo-retina> crap. I've reverted aleth's tooltip patch (basically reverted everything) and reapplied only my patch
21:04:57 <clokep> Did you push? :P
21:05:03 <flo-retina> now the tooltips are fine in the blist (because of my patch) and broken in the conv window.
21:05:24 <flo-retina> so it looks like what makes the tooltips not-broken in the conv window is related to aleth's patch.
21:06:10 * IRCMonkey61951 isn't sure what to do now
21:06:19 <IRCMonkey61951> oops, wrong window
21:10:04 <-- IRCMonkey61951 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
21:10:29 --> florian has joined #instantbird
21:10:53 * florian is now known as IRCMonkey14019
21:11:14 * clokep finishes his extension.
21:13:18 <flo-retina> clokep: it's a UI patch, but it's trivial! ;)
21:13:21 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 3040 on bug 2113.
21:13:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2113 nor, --, 1.5, florian, REOP, Buddy tooltips have incorrect sizes
21:13:38 <clokep> https://addons.instantbird.org/en-US/instantbird/addon/357/
21:13:42 --> jb has joined #instantbird
21:14:01 <clokep> flo-retina: r=me
21:14:05 <flo-retina> cool :)
21:14:25 <instantbot> clokep@gmail.com granted review for attachment 3040 on bug 2113.
21:15:22 <flo-retina> alright, this time I hope I can actually do the check-ins!
21:16:53 <flo-retina> raw interdiffs: https://bugzilla.instantbird.org/attachment.cgi?oldid=3036&newid=3038&action=interdiff&format=raw :)
21:18:41 <-- IRCMonkey14019 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
21:19:07 --> florian has joined #instantbird
21:19:26 * florian is now known as IRCMonkey37830
21:21:23 <flo-retina> clokep: doesn't the "unknown" sound wrong here: http://i5.minus.com/itDBYQ5AvtSAz.png ?
21:22:49 <IRCMonkey37830> hmm, interestingly the context menu offers to add Even to the contacts
21:23:02 <IRCMonkey37830> but not flo-retina or clokep. (all these 3 nicks are in the contact list of this account)
21:23:34 <flo-retina> I suspect that's because Even has an uppercase letter, and there's yet another normalization issue for aleth to play with ;).
21:25:26 --> Mic has joined #instantbird
21:25:27 * ChanServ sets mode +h Mic 
21:26:57 <clokep> flo-retina: Sounds likely. :-/
21:27:14 <flo-retina> The "Unknown" still seems wrong to me
21:27:46 <flo-retina> for "clokep" or "flo-retina" the status is obviously not unknown, and the context menu know we have a buddy in the list for it
21:28:09 <instantbot> florian@instantbird.org granted review for attachment 3038 on bug 1693.
21:28:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1693 enh, --, ---, aleth, ASSI, Show participant tooltip when hovering nick in conversation
21:28:35 <flo-retina> time to try bug 1587
21:28:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1587 min, --, 1.5, clokep, REOP, Re-sync installer with comm-central
21:29:58 <clokep> flo-retina: It's because the participants aren't linked back to the account buddy objects.
21:30:05 <clokep> It's also why buddy icons don't work.
21:30:17 <flo-retina> buddy icons for IRC buddies?
21:30:38 <Mic> Yes, please! ;)
21:31:00 <flo-retina> Mic: :-D
21:31:19 <clokep> Mic: Is that not on AIO?
21:31:41 <Mic> clokep: I think I attached it to a bug?
21:31:57 <EionRobb> irc supports buddy icons?
21:31:58 <flo-retina> clokep: do I have to do a full rebuild to test that installer patch?
21:32:09 <flo-retina> clokep: or is make package good enough?
21:32:09 <clokep> flo-retina: No.
21:32:16 <clokep> flo-retina: I'd build instantbird and the package.
21:32:20 <flo-retina> (obviously touching rules.mk will make a large part of the tree be rebuilt
21:32:25 <flo-retina> hmm, maybe not mozilla/ though
21:32:30 <flo-retina> so should still be < 5 minutes
21:32:55 <-- IRCMonkey37830 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
21:33:11 <Mic> EionRobb: "yes", via CTCP.
21:35:04 <flo-retina> clokep: http://pastebin.instantbird.com/434969
21:35:36 <flo-retina> should be a 2 minutes fix ;)
21:35:40 <clokep> flo-retina: :)
21:35:43 <flo-retina> are you on it?
21:36:09 <clokep> No.
21:36:14 * clokep is on the phone.
21:36:29 <flo-retina> errr, that was actually my other review comments you ignored :(
21:36:33 <flo-retina> comment 13
21:36:55 <flo-retina> You wrote in comment 15 "I've removed these since I can't check this since I don't have a Mac."
21:37:00 <flo-retina> but that's not what the patch says
21:37:14 <clokep> Hmm....maybe I messed up a qref or something.
21:38:04 <flo-retina> should I just fix this locally and push pretending it's still your patch?
21:38:44 <clokep> flo-retina: That works for me.
21:39:05 <clokep> flo-retina: Sorry for messing up all your review comments there. :-/
21:40:44 <flo-retina> clokep: the changes I'm making are http://pastebin.instantbird.com/434990
21:41:15 --> JosiahOne has joined #instantbird
21:41:21 <clokep> OK. :)
21:42:26 <flo-retina> with these changes |make package| works, and Ib can start out of the packaged build
21:42:33 --> florian has joined #instantbird
21:42:35 <clokep> :)
21:42:42 <florian> hello from the packaged build
21:42:50 <-- florian has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
21:42:58 <clokep> :)
21:44:04 <JosiahOne> clokep: Thanks!
21:45:28 <clokep> JosiahOne: Should be pretty easy to use, let me know when it breaks. :P
21:45:33 <clokep> It doesn't save anything over sessions btw.
21:45:54 <JosiahOne> Okay, that's fine.
21:47:43 <instantbot> florian@instantbird.org granted review for attachment 3034 on bug 1587.
21:47:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1587 min, --, 1.5, clokep, REOP, Re-sync installer with comm-central
21:47:49 <clokep> JosiahOne: The code is at https://bitbucket.org/clokep/irc-extras/src/tip/ignore/bootstrap.js if you're curious.
21:47:55 <clokep> It wasn't super trivial, but was pretty easy. :)
21:48:05 <clokep> (At least for me...since I wrote the IRC code. :P)
21:49:05 <JosiahOne> :) Thanks. I was curious.
21:49:45 <clokep> No problem, it's pretty hacky...you'll still see their join/parts/kicks, etc. btw.
21:51:52 <clokep> Bah I just got a TON of mail from BIO all at once.
21:51:55 <clokep> From the past ~12 hours.
21:52:10 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/302b929f1de4 - aleth - Bug 1693 - Show participant tooltip when hovering nick in conversation, r=fqueze.
21:52:11 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/cd4a67ecb4af - Patrick Cloke - Bug 1587 - Re-sync build scripts with comm-central, r=fqueze.
21:52:12 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/74704f87a57d - Florian Qu├Ęze - Bug 2113 - Buddy tooltips have incorrect sizes - better workaround, r=clokep.
21:52:58 <instantbot> clokep@gmail.com set the Resolution field on bug 1693 to FIXED.
21:52:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1693 enh, --, 1.5, aleth, RESO FIXED, Show participant tooltip when hovering nick in conversation
21:53:07 <-- jb has quit (Ping timeout)
21:53:59 <instantbot> clokep@gmail.com set the Resolution field on bug 2113 to FIXED.
21:54:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2113 nor, --, 1.5, florian, RESO FIXED, Buddy tooltips have incorrect sizes
21:55:42 <clokep> flo-retina: Should I close bug 1587 and file a follow up for the removed-files stuff or leave it open?
21:55:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1587 min, --, 1.5, clokep, REOP, Re-sync installer with comm-central
21:56:09 <flo-retina> so I can't say I made a great job of reducing my BIO queue this week-end. At least I succeeded in not making it increase, despite all your incoming great patches! :)
21:56:26 <flo-retina> clokep: I replied to that in the bug before you asked on IRC;
21:56:38 <flo-retina> clokep: new bug. I think the target milestone won't be 1.5 for that ;).
21:57:31 <clokep> Ah. :)
21:57:33 <clokep> You're fast.
22:01:45 <instantbot> New Instantbird (UI) bug 2248 filed by clokep@gmail.com.
22:01:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2248 min, --, ---, nobody, NEW, Updated removed-files.in
22:02:16 <instantbot> clokep@gmail.com set the Resolution field on bug 1587 to FIXED.
22:02:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1587 min, --, 1.5, clokep, RESO FIXED, Re-sync installer with comm-central
22:03:31 <clokep> Down to 13 blockers. ;)
22:07:54 <flo-retina> down to 19 unread (= todo) bugmail.
22:08:00 <instantbot> clokep@gmail.com requested review from aleth@instantbird.o rg for attachment 3042 on bug 2122.
22:08:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2122 nor, --, ---, clokep, ASSI, Update Linux system requirements page
22:08:05 <flo-retina> only 9 of which are from BIO related
22:08:24 <flo-retina> Good evening!
22:08:25 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
22:09:17 <clokep> Bye!
22:13:26 <clokep> I think that's about all the blockers I'm equipped to handle. :-/
22:13:43 <clokep> Oh and bug 2148...
22:13:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2148 nor, --, ---, clokep, ASSI, Remove VKontakte protocol
22:14:14 * JosiahOne is now known as JosiahOne|Away
22:16:01 <-- JosiahOne|Away has quit (Ping timeout)
22:20:00 <instantbot> New Core - General bug 2249 filed by clokep@gmail.com.
22:20:01 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 3043 on bug 2249.
22:20:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2249 nor, --, ---, clokep, ASSI, Move more stuff to moz.build
22:22:03 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 3044 on bug 2249.
22:22:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2249 nor, --, ---, clokep, ASSI, Move more stuff to moz.build
22:22:54 --> igorko has joined #instantbird
22:24:25 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 3045 on bug 2249.
22:24:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2249 nor, --, ---, clokep, ASSI, Move more stuff to moz.build
22:25:50 <clokep> Uh oh, that last one might not work. :-/
22:25:53 <Mic> Nice, interdiffs are working now on BIO :)
22:26:03 <clokep> Mic: Yup, Florian got it working. :-D
22:26:05 <Mic> I guess we need to thank Even for this? :)
22:26:14 <Mic> Then Flo ;)
22:27:59 <clokep> I think he pretty much just had to |apt-get install diffutils|
22:58:19 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
22:59:49 --> dew1 has joined #instantbird
23:01:03 <-- dew has quit (Ping timeout)
23:23:34 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
23:43:13 <-- qlum has quit (Quit: Getting the <censored> out.)
23:48:31 <-- igorko has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com)
23:50:26 --> flo-retina has joined #instantbird
23:50:27 * ChanServ sets mode +qo flo-retina flo-retina 
23:51:03 <flo-retina> clokep: how have you been doing bug 2249?
23:51:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2249 nor, --, ---, clokep, ASSI, Move more stuff to moz.build
23:51:25 <flo-retina> I thought you just exported the c-c changesets for their chat/ subset
23:51:51 <flo-retina> but that doesn't explain how https://bugzilla.mozilla.org/attachment.cgi?id=746627&action=diff#a/chat/modules/Makefile.in_sec3 becomes https://bugzilla.instantbird.org/attachment.cgi?id=3043&action=diff#a/chat/modules/Makefile.in_sec2
23:52:26 <flo-retina> oh wait, Tb doesn't have test/appInfoUtils.jsm yet
23:52:55 <instantbot> florian@instantbird.org denied review for attachment 3043 on bug 2249.