All times are UTC.
00:05:09 <flo-retina> clokep: real 23m49.245s 00:05:45 --> florian has joined #instantbird 00:06:07 * florian is now known as IRCMonkey26698 00:06:22 <flo-retina> clokep: look at the tooltip of #testib 00:06:50 <clokep> flo-retina: There is no topic? 00:07:09 <flo-retina> doesn't this look broken? 00:07:26 <clokep> It doesn't look too bad... 00:08:06 <clokep> http://i.imgur.com/Kbf3fXc.png 00:08:37 <flo-retina> wouldn't you expect the /No topic message for this room./ ? 00:08:56 * flo-retina wonders why we have the word "message" in that string 00:09:19 <clokep> Hmm....yes, I guess I would. :) 00:09:21 <-- clokep_js has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:09:50 <flo-retina> clokep: the MUC icon also seems missing from the tooltip btw 00:10:30 <-- IRCMonkey26698 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:10:49 <clokep> This is why I don't review UI patches btw. ;) 00:11:21 <flo-retina> what's "This" in this sentence? 00:11:27 <-- sabret00the has quit (Ping timeout) 00:11:38 <clokep> My lack of attention to detail. :) 00:11:53 --> florian has joined #instantbird 00:12:16 * florian is now known as IRCMonkey33240 00:19:21 <flo-retina> wnayes: do you know why "<xul:stack class="displayNameMessageBox" flex="1">" is a stack? 00:22:00 <-- IRCMonkey33240 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:22:41 --> florian has joined #instantbird 00:23:04 * florian is now known as IRCMonkey36461 00:24:05 <-- IRCMonkey36461 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:25:05 --> florian has joined #instantbird 00:25:29 * florian is now known as IRCMonkey22261 00:27:25 <-- IRCMonkey22261 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:27:46 <clokep> flo-retina: https://bugzilla.instantbird.org/show_bug.cgi?id=1587#c16 Any thoughts? 00:27:48 <instantbot> Bug 1587 min, --, 1.5, clokep, REOP, Re-sync installer with comm-central 00:28:59 * flo-retina is getting plenty of shutdown warnings/errors on his debug build because of the issues discussed in bug 1928 that are still pending 00:29:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1928 maj, --, ---, florian, NEW, Crash [@ purpleAccountBuddy::Get* ] during shutdown 00:29:04 * flo-retina dislikes shutdown noise 00:29:36 <flo-retina> clokep: is your question about icon.png? 00:30:06 <clokep> Yes. :) 00:30:30 <flo-retina> so what's your suggested answer? 00:31:18 --> florian has joined #instantbird 00:31:37 * florian is now known as IRCMonkey5150 00:32:05 <clokep> Well apparently we're supposed to have an icon.png somewhere. 00:33:20 <clokep> I guess I'm unsure if I should ust find an IB icon somewhere to use? 00:33:23 <clokep> (It's for the default theme.) 00:33:29 <clokep> s/ust/just/ 00:34:43 <flo-retina> bah, I just saw what the new tooltips look like on contacts with a status and a buddy icon. I think I'll now hate our current tooltips even more! :-[ 00:35:19 <flo-retina> clokep: what is that icon for? 00:35:48 <-- IRCMonkey5150 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:36:40 <clokep> flo-retina: ...That I hvae no idea. :-/ 00:37:21 <flo-retina> wnayes: how does http://pastebin.instantbird.com/431316 sound? 00:39:08 <flo-retina> clokep: I think Firefox uses http://mxr.mozilla.org/comm-central/source/mozilla/browser/themes/linux/icon.png 00:39:28 <flo-retina> and it's the same icon on all 3 OSes 00:40:06 <flo-retina> clokep: you'll need some Makefile rules: http://mxr.mozilla.org/comm-central/source/mozilla/browser/themes/windows/Makefile.in#5 00:40:11 --> BWMerlin has joined #instantbird 00:40:22 <flo-retina> s/rules/lines/ 00:40:29 <clokep> Ah! Thank you. :) 00:40:41 <flo-retina> clokep: if you still have the tooltip patch applied, can you test what I pastebined? 00:41:19 <clokep> I don't, but I can reapply it. 00:41:26 * clokep needs ~5 minutes. 00:46:21 --> sabret00the has joined #instantbird 00:48:04 --> florian has joined #instantbird 00:48:24 * florian is now known as IRCMonkey35020 00:48:51 <wnayes> flo-retina: I was away eating, but back now. I used a stack based on how conv-info-large is set up. With the stack it allows the tooltipMessage to be placed exactly far enough down so that it aligns with the status icon. 00:49:29 <clokep> You shouldn't need a stack for that. 00:49:34 <wnayes> There might be a way to achieve the same thing with vbox, but then the height of the display name hbox has to be the same across platforms. 00:49:56 <flo-retina> wnayes: is the problem that you can't predict the height of <xul:description class="tooltipDisplayName" ? 00:50:33 <clokep> flo-retina: Rebuilding. 00:50:50 <clokep> What screenshots do you want to see? 00:50:56 * clokep wishes he could just share his screen... 00:51:14 <wnayes> flo-retina: Yeah, if the height was the same I don't think we would have had the issue lining up the status text in the earlier patches. 00:51:15 <flo-retina> clokep: well, look if this seems reasonable for the tooltips of #instantbird 00:51:39 <flo-retina> wnayes: so you think I should revert that and find another solution? 00:51:48 --> clokep_js has joined #instantbird 00:52:06 <flo-retina> wnayes: what's the point of .tooltipSeparator { 00:52:06 <flo-retina> margin-left: 3px; 00:52:06 <flo-retina> ? 00:52:44 <flo-retina> isn't that separator an horizontal element where a margin-left won't make a difference? 00:53:26 <flo-retina> ah, is it to cancel margin-left: -3px; from .tooltipBuddies? 00:53:48 <-- IRCMonkey35020 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:54:05 <wnayes> flo-retina: I think it was related to aligning the right side of the separator with the underline on the display name. 00:54:15 <-- clokep_js has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:55:01 <flo-retina> ah, I think it's not the separator I had in mind 00:55:11 --> florian has joined #instantbird 00:55:23 <clokep> flo-retina: Two images: http://imgur.com/btika5U,t2CxHGB 00:55:35 * florian is now known as IRCMonkey19412 00:56:03 <flo-retina> clokep: ok, that looks bad :( 00:56:21 <flo-retina> is your clokep_js account configured with a non utf8 encoding? 00:56:46 <clokep> Umm...possibly. 00:56:55 <clokep> That account is a mess. ;) 00:57:07 <clokep> flo-retina: Ah-ha, it's set to ISO-8859-4 00:57:31 <-- IRCMonkey19412 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:57:41 <flo-retina> that's expected for a debug profile ;) 00:57:54 <flo-retina> you don't even want to see the mess I have on at least a dozen debug profiles ;) 00:58:11 --> florian has joined #instantbird 00:58:31 * florian is now known as IRCMonkey41554 00:59:19 <flo-retina> wnayes: another proposal that keeps the stack: http://pastebin.instantbird.com/431347 00:59:33 <flo-retina> (assume the indent wouldn't be crazy of course :)) 01:02:23 <wnayes> flo-retina: Would that fix the description wrapping? 01:02:45 <flo-retina> is there anything else it's expected to fix? 01:03:53 <flo-retina> I mean, yes, that's what I was fixing 01:03:56 <wnayes> Oh ok, looked at it wrong :) 01:06:49 <wnayes> I'm building with it now, it looked at first like a way to align the status message with the icon at first. 01:08:31 <flo-retina> wnayes: it's just a way to allow the stack to expand vertically if the description is taller than the hbox 01:08:46 <wnayes> flo-retina: Yeah, looks like it works :D 01:08:53 <flo-retina> wnayes: perfect 01:09:01 <flo-retina> wnayes: do you have time now for tweaks? 01:09:10 <clokep> bleh, the moz 25 stuff seems to have added more files I need. :-/ 01:09:10 <flo-retina> especially fixing the chat case? 01:09:25 <wnayes> flo-retina: I should, yes. 01:09:32 <flo-retina> that would be awesoe 01:09:36 <flo-retina> *awesome 01:10:13 <flo-retina> see http://lxr.instantbird.org/instantbird/source/instantbird/themes/instantbird.css#95 01:10:40 <flo-retina> for chats, the tooltips should have either the chat or chat-left icon 01:11:14 <flo-retina> and if there's no topic, there should be http://lxr.instantbird.org/instantbird/source/instantbird/locales/en-US/chrome/instantbird/instantbird.properties#89 in italic, rather than "" 01:11:41 <flo-retina> your patch currently does this.setMessage(aConv.topic || ""); 01:11:56 <wnayes> OK, I hadn't heard of the chat icon issue yet. But I was aware of the empty topic one. 01:12:24 <flo-retina> wnayes: I discovered it when trying the patch today. 01:13:11 <flo-retina> wnayes: I mentioned it a few minutes ago, but without pinging you: http://log.bezut.info/instantbird/today#m12 01:13:40 <flo-retina> err, that's already an hour ago :-S 01:14:25 <wnayes> flo-retina: What would you suggest for adding the instantbird.properties bundle. Making another getter just for that one use case (and then probably renaming the current one named only "bundle")? 01:15:44 <-- mpmc has quit (Connection reset by peer) 01:16:12 <flo-retina> I would just Services.strings.createBundle("chrome://instantbird/locale/instantbird.properties").GetStringFromName("noTopic"); :) 01:17:46 --> dew1 has joined #instantbird 01:18:22 <-- dew has quit (Ping timeout) 01:18:49 <wnayes> OK, that's a monster to fit in 80 chars :) 01:20:17 <flo-retina> wnayes: I think you can take advantage not me not being fully awake, and being excited at the idea of landing the new tooltips to go a bit over 80 chars ;) 01:20:26 <flo-retina> s/not me/of me/ 01:21:56 --> FireFly_TB has joined #instantbird 01:22:16 <clokep> r- ;) 01:23:27 <flo-retina> wnayes: it actually fits! 01:23:41 <flo-retina> wnayes: http://pastebin.instantbird.com/431399 01:23:50 <flo-retina> clokep: I thought you didn't want to review UI patches :-P 01:24:28 <clokep> flo-retina: I take it back. :P 01:24:35 <flo-retina> :-D 01:24:41 <wnayes> flo-retina: OK great, I was trying different things but none were quite there :) 01:24:47 <-- FireFly_TB has quit (Quit: FireFly_TB) 01:25:37 <flo-retina> note that the bundle getter has 99 columns ;) 01:26:25 <flo-retina> I think I would put |const kBundleName = "chrome://instantbird/locale/instantbird.properties";| on a single line (86 chars) 01:26:38 <flo-retina> XBL sucks for respecting 80 char lines anyway 01:27:37 <flo-retina> there's 11 characters of indent... 01:27:55 * clokep hates how it's *11* 01:30:04 <flo-retina> clokep: I almost commented on that too! 01:31:06 * clokep wonders if we're supposed to have update-settings.ini and blocklist.xml... 01:31:18 * wnayes is looking into the chat icon issue now. 01:31:22 <flo-retina> :) 01:31:31 <flo-retina> clokep: blocklist we likely should 01:32:34 <flo-retina> clokep: but that sounds more like a separate bug 01:32:59 <flo-retina> update-settings.ini, no 01:36:11 <-- qlum has quit (Quit: Getting the <censored> out.) 01:41:48 --> gerard-majax__ has joined #instantbird 01:42:20 <-- IRCMonkey41554 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 01:42:51 <flo-retina> I think I have a fix for the findbar 01:43:39 <-- gerard-majax__ has quit (Ping timeout) 01:43:55 <clokep> :) 01:45:25 --> florian has joined #instantbird 01:45:47 * florian is now known as IRCMonkey48564 01:49:51 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 3025 on bug 2241. 01:49:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2241 nor, --, ---, florian, NEW, [regression] Findbar chevrons swapped since moz25 01:52:22 <instantbot> clokep@gmail.com granted review for attachment 3025 on bug 2241. 01:52:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2241 nor, --, ---, florian, NEW, [regression] Findbar chevrons swapped since moz25 01:55:05 <clokep> I like things that reduce our mozilla patches. :) 01:56:57 <-- IRCMonkey48564 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 01:57:12 * flo-retina got clokep to review a UI patch! \o/ 01:57:21 <clokep> Bah, I can't get this icon.png thing to work. 01:57:31 <flo-retina> clokep: I lke things that reduce our blocker list ;) 01:57:40 <clokep> Yeah. 01:57:45 <flo-retina> clokep: pastebin what you've got and your errors? 01:57:57 * flo-retina is waiting for wnayes' new patch, so he can have a look 01:58:18 <clokep> OK, one second. 01:58:28 <wnayes> I'm testing the new fixes out, seems to be working :) 01:58:31 --> gerard-majax__ has joined #instantbird 02:00:03 <clokep> flo-retina: Log: http://pastebin.instantbird.com/431440, changes: http://pastebin.instantbird.com/431441 02:00:24 <flo-retina> logs from windows terminals are so hard to read :( 02:00:30 <clokep> Sorry. :-/ 02:00:35 <wnayes> ... since the chat icon was added, the multiline clipping is back :( 02:00:39 <clokep> I've never found a good way to automatically fix them. 02:01:08 <flo-retina> clokep: "Error: c:\Users\clokep\instantbird\instantbird\installer\removed-files.in:172: Removal of packaged file(s): dependentlibs.list" should be easy 02:01:24 <flo-retina> clokep: maybe execute the stuff with a redirection to a file? 02:01:36 <clokep> How do I redirect stderr again? 02:01:44 <flo-retina> 2>file 02:01:57 <flo-retina> or likely 2>&1 >file 02:02:03 <clokep> Yes, that was my real question. ;) 02:02:42 <clokep> Yeah that doesn't work. 02:02:51 <clokep> Errors are still in my terminal. 02:05:12 <clokep> flo-retina: So I didn't add dependentlibs to removed-files.in or anything, why would that be erroring now? Do I just need to remove it? 02:05:47 <flo-retina> clokep: I suspect your problem for icon.png is http://hg.mozilla.org/comm-central/rev/3c8b64fa8547 02:06:08 <clokep> Possibly. :) 02:06:15 * clokep doesn't know how you find this stuff still. :( 02:06:52 <clokep> Does change config/rules.mk require a clobber? 02:07:08 <flo-retina> you mean how I find such crap at 3am? :-D 02:07:29 <flo-retina> clokep: btw, the comm-central makefiles don't use these recent rules, so you may want to copy http://mxr.mozilla.org/comm-central/source/mail/themes/linux/Makefile.in#17 instead 02:08:00 * clokep was hoping I could just update to what m-r had though. :) 02:08:12 <flo-retina> well, patching comm-central is nice too ;) 02:08:14 <clokep> (I noticed that earlier btw.) 02:08:26 <clokep> Maybe once we're in it. :P 02:09:02 <flo-retina> if you want to update update to the m-r stuff, you may need to port both patches from https://bugzilla.mozilla.org/show_bug.cgi?id=881368 02:09:03 <flo-retina> not sure 02:09:20 <clokep> Woot! It's working. :) 02:09:23 <flo-retina> clokep: http://lxr.instantbird.org/instantbird/source/instantbird/installer/removed-files.in#172 02:09:39 <flo-retina> get rid of that line :) 02:10:01 <flo-retina> wnayes: want to upload a new patch so that I can help you debug it? 02:10:49 <flo-retina> clokep: have you looked at the warnings of each OS? 02:10:59 <clokep> flo-retina: Of course not. :) 02:11:05 <clokep> Well besides the ones you put int he bug. 02:11:06 <flo-retina> clokep: r-! :-P 02:11:26 <flo-retina> look at the logs of the distribute steps of nightlies on the waterfall 02:11:42 <clokep> Will do. 02:11:47 <clokep> Btw this bug is entirely boring. :P 02:12:06 <flo-retina> oh really? 02:12:40 <flo-retina> maybe you'll be able to work on a new tooltip follow-up soon to un-bore you? :-D 02:13:21 <clokep> flo-retina: We haven't had a Linux nightly in a while. :-/ 02:13:36 <clokep> Or windows, apparently. 02:13:45 <wnayes> flo-retina: Here's the patch, http://pastebin.instantbird.com/431462 02:13:47 <clokep> Oh, no. Lied. Just Linux. 02:13:59 <flo-retina> clokep: ping Even about it soon :) 02:14:04 <flo-retina> he doesn't seem awake now ;) 02:14:11 * clokep sighs. 02:14:18 <clokep> Why not?! :P 02:14:59 <wnayes> I just tested again to confirm that the spacer vbox fix was working without the chat icon visible. 02:18:13 <clokep> flo-retina: I'm "fairly" confident I got them on all OSes. 02:20:07 <flo-retina> wnayes: chat-left isn't handled yet, right? 02:21:15 <wnayes> flo-retina: No, wasn't totally sure about how to handle that. The conv-info-large binding also doesn't handle it so I thought maybe it would be OK for now :) 02:22:02 <flo-retina> is it that difficult to put the left attribute there when needed, and to remove it at the same time as the noTopic one? 02:23:26 --> florian has joined #instantbird 02:23:48 * florian is now known as IRCMonkey49218 02:24:43 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 3026 on bug 1587. 02:24:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1587 min, --, 1.5, clokep, REOP, Re-sync installer with comm-central 02:25:11 * clokep feels accomplished. 02:26:31 * IRCMonkey49218 wonders how to fix the tooltip stuff 02:27:23 <-- IRCMonkey49218 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 02:27:52 --> florian has joined #instantbird 02:28:17 * florian is now known as IRCMonkey26556 02:30:44 <-- IRCMonkey26556 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 02:31:37 --> florian has joined #instantbird 02:32:00 * florian is now known as IRCMonkey38817 02:34:49 <-- IRCMonkey38817 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 02:35:20 --> florian has joined #instantbird 02:35:42 * florian is now known as IRCMonkey1260 02:37:15 <-- IRCMonkey1260 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 02:37:43 --> florian has joined #instantbird 02:38:05 * florian is now known as IRCMonkey15515 02:38:40 <-- IRCMonkey15515 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 02:39:05 --> florian1 has joined #instantbird 02:39:33 <flo-retina> wnayes: ahah, it works! 02:41:54 <-- florian1 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 02:42:24 --> florian has joined #instantbird 02:42:31 <wnayes> flo-retina: :D What was the fix? I almost have the chat-left working. 02:42:34 <flo-retina> we've got only a few minutes left to get stuff included in nightlies 02:42:45 * florian is now known as IRCMonkey26283 02:43:54 <flo-retina> wnayes: http://pastebin.instantbird.com/431503 02:45:04 <clokep> r-, whitespace 02:45:53 <flo-retina> clokep: common 02:45:56 <flo-retina> err 02:45:58 <flo-retina> come on 02:46:27 <clokep> :-D 02:46:38 <clokep> I can review UI patches. :p 02:46:57 <flo-retina> clokep: @BINPATH@/uninstall/helper.exe 02:47:04 <flo-retina> why is that packaged for Tb and not Ib? 02:47:12 <flo-retina> looking at https://bugzilla.instantbird.org/attachment.cgi?id=3027&action=diff#instantbird/installer/package-manifest.in_sec2 02:47:27 <clokep> flo-retina: Because it doesn't exist for us. 02:47:46 <flo-retina> are you... sure? 02:48:17 <clokep> flo-retina: I dn't have a bin/uninstall path at all. 02:49:34 <flo-retina> what's @BINPATH@/components/xpautocomplete.xpt ? 02:50:26 <flo-retina> clokep: looks like bug 2189 may be blocking you then ;) 02:50:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2189 nor, --, ---, nobody, NEW, package-manifest:35: Missing file(s): bin/uninstall/helper.exe 02:50:50 <clokep> flo-retina: The old auto-complete code still used by LDAP, I think. 02:50:56 <flo-retina> ok 02:51:14 <clokep> flo-retina: Sure, it's a dup. ;) 02:51:28 <flo-retina> no, it's a blocker ;) 02:51:38 <instantbot> wnayes@gmail.com cancelled feedback?(florian@instantbi rd.org) for attachment 3008 on bug 1221. 02:51:39 <flo-retina> if that file is really missing, uninstalling Ib on Windows isn't possible :-P 02:51:39 <instantbot> wnayes@gmail.com requested review from florian@instantbird .org for attachment 3028 on bug 1221. 02:51:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1221 enh, --, ---, wnayes, ASSI, Redesign buddy tooltips 02:52:35 <flo-retina> clokep: want to look too? 02:53:27 <clokep> Nope. :) 02:53:42 <clokep> I don't want to be responsible. 02:54:29 <flo-retina> lol 02:55:02 <flo-retina> how come you already know we will need follow-ups? ;) 02:57:07 <clokep> I just have a suspicion. :) 02:58:05 <-- IRCMonkey26283 has quit (Input/output error) 02:58:31 --> florian has joined #instantbird 02:58:52 * florian is now known as IRCMonkey62406 02:59:25 <-- IRCMonkey62406 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 03:00:18 <flo-retina> The l10n hook actually works! http://hg.instantbird.org/l10n/en-US/rev/66d48bda9c4a :) 03:00:46 <flo-retina> "next in ~ 9 mins" we still had a few minutes to tinker :-D 03:01:29 <clokep> :P 03:01:34 <clokep> Did you clear check-in needed? 03:01:58 <instantbot> florian@instantbird.org granted review for attachment 3028 on bug 1221. 03:01:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1221 enh, --, ---, wnayes, ASSI, Redesign buddy tooltips 03:02:07 <flo-retina> not at all 03:02:21 <flo-retina> clokep: nothing interesting in there :- 03:02:21 <flo-retina> P 03:02:27 <clokep> :P 03:02:30 <flo-retina> (to me at least) 03:02:46 <clokep> Well...we can stll check it in. ;) 03:02:59 <wnayes> Yay :D 03:03:04 <flo-retina> wnayes: thanks :) 03:03:18 <flo-retina> wnayes: I think I've wanted this change for years ;) 03:03:27 <-- gerard-majax__ has quit (Ping timeout) 03:04:24 <flo-retina> I think the first follow-up I'll be interested in working on is moving the "Tags" line to the first line after the status, with the tag icon used in the awesometab aligned with the status icon; instead of the "Tags" label. 03:04:42 <flo-retina> (doesn't have to be in 1.5 though) 03:05:34 <flo-retina> clokep: why is the label "Using a secure connection" rather than just "Secure connection"? 03:06:18 <clokep> flo-retina: My string reviewer must have been sleeping on the job. ;) 03:06:39 <clokep> I don't remember, but I remember having a large debate about one off those things... 03:06:41 <flo-retina> you mean the review may have happened at 4am? :-o 03:07:54 <flo-retina> clokep: why aren't we using the "Name" field as the display name, and displaying the nick as "username" in the tooltip? 03:08:27 <clokep> flo-retina: I don't know. 03:08:38 <clokep> That probably makes more sense, yes. 03:08:49 <clokep> Can you do that w/o creating a buddy object? 03:09:30 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/499b80eaa20f - Will Nayes - Bug 1221 - Redesign buddy tooltips, r=fqueze. 03:09:31 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/2773b8e9bccb - Florian Quèze - Bug 2241 - Conversation findbar chevrons swapped since moz25, r=clokep. 03:09:33 <flo-retina> clokep: I was thinking about the buddies I have in my list 03:09:43 <flo-retina> clokep: hmm, maybe that requires doing a whois on all of them to get the names? 03:10:00 <flo-retina> that means we would /whois gavin whenever we reconnect :-P 03:10:59 <clokep> flo-retina: I'm confused. Are you talking about the buddy list or tooltips? :P 03:11:14 <flo-retina> clokep: the 2 are expected to match 03:11:17 <clokep> If there are issues, file bugs and we can see about fixing them. :) 03:11:29 <instantbot> clokep@gmail.com set the Resolution field on bug 2241 to FIXED. 03:11:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2241 nor, --, 1.5, florian, RESO FIXED, [regression] Findbar chevrons swapped since moz25 03:11:35 <flo-retina> clokep: those are more random thoughts than issues at this point ;) 03:12:10 <instantbot> clokep@gmail.com set the Resolution field on bug 1221 to FIXED. 03:12:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1221 enh, --, 1.5, wnayes, RESO FIXED, Redesign buddy tooltips 03:12:11 <clokep> Don't mince my words! 03:13:17 --> florian has joined #instantbird 03:13:39 * florian is now known as IRCMonkey57467 03:14:28 <flo-retina> wnayes: so what surprised me about the tooltip patch when I tried it on a contact with a status icon and a buddy icon is that the layout felt so familiar (because we already have it both in the conv binding and at the top of the blist) that it felt like it had been part of Instantbird forever. 03:15:33 <flo-retina> uh, we are ready for the first follow-up :-S 03:16:24 <flo-retina> wnayes: http://i2.minus.com/ieLpoqPSYFhSr.png My status message isn't displayed :( 03:18:01 <flo-retina> looks like we miss some of the logic around http://lxr.instantbird.org/instantbird/source/instantbird/content/conversation.xml#1711 03:18:47 <flo-retina> I almost mentioned this an hour ago, then wanted to test it and forgot :-S 03:19:27 <instantbot> clokep@gmail.com set the Resolution field on bug 1600 to FIXED. 03:19:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1600 nor, --, 1.5, aleth, RESO FIXED, RTL messages on the receiver side 03:19:31 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/e3fb5a5b56d1 - Benedikt Pfeifer - Bug 2053 - Add data to 'conversation-loaded' notification to let observers know that the conversation was moved, r=aleth. 03:19:32 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/a69666e461e9 - aleth - Bug 1983 - Default normalizedName normalization is too aggressive, r=clokep. 03:19:33 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/4ec0345f49a6 - aleth - Bug 1600 - RTL messages on the receiver side, r=fqueze. 03:19:36 <wnayes> flo-retina: Back in the initial patches there was uncertainty about how to remove the status from the lower table rows part of the tooltip, and since it wasn't clear how to reliably do so, I think we agreed (at least at that time) to keep the status out of the upper part because it would exist twice in the tooltip. 03:19:57 <instantbot> clokep@gmail.com set the Resolution field on bug 1983 to FIXED. 03:19:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1983 tri, --, 1.5, aleth, RESO FIXED, Default normalizedName normalization is too aggressive 03:20:05 <wnayes> Which would have been very apparent with a long status. 03:20:07 <flo-retina> wnayes: we may have agreed to do it in a follow-up 03:20:24 <flo-retina> but it will need to happen at some point 03:20:38 <instantbot> clokep@gmail.com set the Resolution field on bug 2053 to FIXED. 03:20:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2053 enh, --, 1.5, benediktp, RESO FIXED, Add data to 'conversation-loaded' notification to let observers know that the conversation was moved 03:20:53 <wnayes> Yeah, now that the line wrapping issue is fixed half the battle should be won :) 03:21:07 <flo-retina> wnayes: and I do remember that earlier iterations of the patch had unsatisfying ways to remove duplicated status messages 03:21:28 <clokep> Looks like I missed this nightly. ;) 03:21:42 <flo-retina> but I think we can happily remove the lines displaying these in the prpl specific code 03:22:15 <flo-retina> There's still plenty of clean-up we can do :) 03:22:34 <flo-retina> we are just starting. But that's not really a layout problem 03:23:48 <wnayes> The check I had was mentioned in Comment 5 on the bug (it was a check whether we were adding a row titled "Status"). 03:23:52 <clokep> wnayes: Thanks for working on that! I know it was a long process. 03:24:03 <flo-retina> wnayes: yeah, that didn't work because of localization 03:24:25 <flo-retina> wnayes: and it's not done exactly the same on all prpls 03:24:36 <flo-retina> wnayes: IRC has a row with a label "Away" :-S 03:25:21 <wnayes> flo-retina: Yeah I used the bundle to get the status string, but the prpl differences weren't addressed. 03:25:36 <flo-retina> we should just cleanup the prpls 03:25:41 <flo-retina> we do have that power :) 03:25:44 <wnayes> clokep, flo-retina: Thanks for testing the patch throughout and helping with the last tricky bit! 03:26:46 * clokep didn't do anything. 03:26:50 <clokep> :) 03:26:52 <flo-retina> you are welcome. 03:26:56 <flo-retina> XUL isn't always easy. 03:27:07 <clokep> s/isn't always/is never/ ;) 03:27:11 <clokep> But yes, anytime! :) 03:27:21 <flo-retina> clokep: I thought you claimed something different to bwinton a few months ago :-P 03:27:53 <clokep> flo-retina: I was right in that case, it took me <5 minutes to figure out what he wanted to do. 03:28:00 <clokep> (After building for like 3 hours :P) 03:28:01 <flo-retina> :) 03:29:25 <flo-retina> clokep: given that the mac nightly restarted 17 times last night, it's not completely clear if you missed it or not for this night 03:29:40 <flo-retina> but you likely missed the windows one :-P 03:29:51 <clokep> That's fine. :) None were super exciting to me. 03:30:03 <clokep> I just think it's nice for people to have their patches checked in quickly after they're approved. :) 03:30:05 <flo-retina> I'm glad I didn't :) 03:30:14 <flo-retina> clokep: I agree! 03:30:22 <flo-retina> "people" should get commit access ;) 03:33:27 <flo-retina> now that we are going to have awesome tooltips, we should really find a way to display them on nicks inside conversations. 03:33:53 <wnayes> flo-retina: In this case, was XUL neither easy or correct? I still can't believe the description tag was exhibiting proper behavior... 03:34:24 <flo-retina> I don't remember what the problem was :( 03:34:45 <clokep> It should be easier to fix things now that the base has landed, however. 03:35:18 <flo-retina> wnayes: not sure if the problem was with the description tag or the stack. I'm inclined to blame the latter. 03:35:45 <flo-retina> clokep: well, aleth was struggling with that. The problem was having 2 different tooltips for the same content area. 03:36:09 <flo-retina> I haven't really looked, but that seemed non trivial 03:37:44 <wnayes> flo-retina: I definitely had issues with the text wrapping into the tooltip content on the some of the older patches, and I hadn't started using stacks until the last couple patches. 03:38:03 <flo-retina> ok 03:38:18 <flo-retina> I honestly don't remember any code of the previous patches :-] 03:39:49 <wnayes> Well, the user/status icon has always been a stack, so maybe it could be a stack issue. I always assumed it was the immediate parent elements of the description, but that didn't seem to be the case when the chat icon was just introduced today... 03:40:10 <wnayes> *immediate parent element structure causing the issue. 03:42:52 <flo-retina> Good night 03:43:06 <flo-retina> (I suspect it's almost time for bed for you :-S) 03:43:32 <wnayes> Yeah, good night! :) 03:49:54 <clokep> Goodnight! 04:06:42 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 04:20:26 --> mconley has joined #instantbird 04:20:53 <-- mconley has quit (Input/output error) 04:27:50 --> mconley has joined #instantbird 05:20:29 <-- wnayes has quit (Quit: wnayes) 05:59:46 <-- mconley has quit (Input/output error) 06:02:06 --> gerard-majax__ has joined #instantbird 06:38:36 --> mconley has joined #instantbird 07:25:29 <-- gerard-majax__ has quit (Ping timeout) 07:54:14 <instant-buildbot> build #1154 of win32-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1154 07:56:54 --> dionisos has joined #instantbird 08:38:30 <-- mconley has quit (Input/output error) 08:45:30 <flo-retina> alreaady 17 failed mac nightlies :-S 08:55:34 --> Guido has joined #instantbird 09:36:52 --> jb has joined #instantbird 09:39:09 <-- Guido has quit (Connection reset by peer) 09:43:02 --> Guido has joined #instantbird 09:54:35 <-- jb has quit (Quit: jb) 09:54:41 --> jb has joined #instantbird 10:09:08 --> Mic has joined #instantbird 10:09:08 * ChanServ sets mode +h Mic 10:22:06 <-- EionRobb has quit (Quit: Leaving.) 10:41:49 <instant-buildbot> build #1028 of linux-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1028 10:43:39 <-- jb has quit (Quit: jb) 11:08:30 --> mpmc has joined #instantbird 11:13:36 --> jb has joined #instantbird 11:19:47 <-- jb has quit (Ping timeout) 11:27:31 <-- Guido has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 11:30:12 --> Guido has joined #instantbird 11:32:06 <-- Guido has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 11:41:15 --> qlum has joined #instantbird 11:58:33 <-- BWMerlin has quit (Quit: BWMerlin) 12:44:31 * flo-retina is very disappointed that *28* mac nightlies failed today :'( 13:18:53 <-- dionisos has quit (Ping timeout) 13:32:15 --> clokep has joined #instantbird 13:32:15 * ChanServ sets mode +o clokep 13:46:38 <clokep> flo-retina: What's with the mac nightlies failing? 13:47:19 * clokep doesn't have an update available. :( 13:58:44 --> dionisos has joined #instantbird 14:01:33 <clokep> Did we port the chat part of https://hg.mozilla.org/comm-central/rev/d3fcee9dc98d? (nhnt11, maybe?) 14:11:38 <-- dionisos has quit (Ping timeout) 14:17:12 --> aleth has joined #instantbird 14:17:12 * ChanServ sets mode +h aleth 14:17:27 <flo-retina> clokep: For the Mac nightly, I would blame my ISP 14:18:24 <flo-retina> clokep: uh, how come something was commited to chat/ without either of us having a look at it? 14:18:39 <clokep> flo-retina: Because people seem to totally ignore the module system? 14:19:09 <flo-retina> that should have been backed out immediately by either of us 14:19:28 <clokep> I just saw it now. :( Apparently some of my RSS feeds weren't working. 14:20:32 <aleth> Wow, interesting checkins :) 14:20:54 <clokep> flo-retina: Any idea why the Windows update isn't available to me? 14:20:54 <flo-retina> clokep: it's not _your_ fault! 14:21:27 <aleth> The Linux update isn't available to me either, but the fix for that is known. Maybe permissions are wrong for Windows too now? 14:22:42 * flo-retina is trying to cool off a little bit before sending an angry comment in there. 14:23:10 <aleth> Hopefully that is the only thing that landed in /chat without anyone noticing :-S 14:23:20 <aleth> If there is one, there may be others... 14:23:22 <clokep> aleth: I've been looking through them right now. 14:23:29 <-- alexis has quit (Ping timeout) 14:23:37 <clokep> I'm pretty sure Joshua's changes for the moz.build stuff don't have our approval. 14:23:50 --> alexis has joined #instantbird 14:24:25 <flo-retina> isn't that icon blurry? http://mxr.mozilla.org/comm-central/source/chat/themes/chat-32.png 14:24:59 <aleth> Looks OK to me (the diagonal could be better) 14:25:03 <flo-retina> clokep: I'm more ok with these, as they were: 1. Mechanical changes (a script applied on the whole tree) 2. Urgent bustage fixes. 14:25:15 <flo-retina> aleth: the 3 bubbles don't even have the same size 14:25:36 <aleth> flo-retina: It's definitely ugly, but not blurry ;) 14:25:44 <flo-retina> it's crap! 14:25:55 * flo-retina hasn't very successfully cooled off :-D 14:25:57 <aleth> I'll agree with that :) 14:27:37 <flo-retina> I don't understand why they named it "chat-32.png" when all the other retina icons have an @2x.png suffix 14:28:54 <flo-retina> nor why they packaged it unconditionally to use it only on mac. 14:29:17 <clokep> Be angry, write a comment. 14:29:20 <clokep> Just be polite. :) 14:29:21 <flo-retina> clokep: I'm actually still wondering if I want to just back it out 14:29:55 <clokep> flo-retina: well it's on comm-aurora too. :-/ 14:30:01 <flo-retina> not my problem 14:30:23 <flo-retina> nothing is going to be released out of the current comm-aurora, right? 14:30:30 <aleth> flo-retina: You can't really r- if you don't back it out first ;) 14:30:51 <flo-retina> it was for Tb25, so likely in comm-beta too, and even comm-release 14:31:07 <aleth> Ah. 14:31:09 <clokep> flo-retina: It was Tb25, so c-a was Tb24 == the current release. 14:31:30 <flo-retina> oh, you mean it also got approved 14:31:33 <clokep> Yes. 14:31:35 <flo-retina> yeah, I'll definitely blame Mark too! 14:31:39 <clokep> It's been released is what I mean. 14:34:16 --> Guido has joined #instantbird 14:35:38 <flo-retina> clokep: that's not really a fact I care strongly about. 14:35:50 <flo-retina> it's not been released on the instantbird side 14:36:11 <clokep> OK. :) 14:36:26 <clokep> flo-retina: Btw Paenglab has done this...4 or 5 times now, probably. 14:36:34 <flo-retina> "this"? 14:36:44 <flo-retina> you mean there are more bugs touching chat/ without our approval? 14:37:04 <clokep> flo-retina: It has happened in the past before, yes. 14:37:07 <flo-retina> The only problem I have with this is... I don't want to be mean with Paenglab :-( 14:37:17 <flo-retina> :( 14:38:15 <clokep> Yeah. :-/ 14:38:39 <aleth> Isn't it the reviewer's responsibility rather than his? 14:38:40 <clokep> Write a comment saying you find the current patch unacceptable and point out why and say that it really needs to have approval of you or me before being committed. 14:40:14 <flo-retina> aleth: totally! 14:40:36 <flo-retina> clokep: if they thought it was trivial enough that it didn't need our review, they should at the very least have cc'ed us. 14:40:51 <clokep> I agree! 14:42:04 <clokep> flo-retina: I'll bring itup at the status meeting, maybe knock some heads around. ;) 14:44:48 <flo-retina> I'll try to attend 14:52:14 <flo-retina> I wonder how come https://bugzilla.mozilla.org/show_bug.cgi?id=861454 is fixed, yet unknown prpl accounts are awfully broken in Tb24 :-S 14:53:38 * clokep wonders if he can convince aleth to look at bug 2069 when he gets a chance. :) 14:53:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2069 nor, --, ---, nobody, NEW, Update theming for '+' button on Linux 14:54:33 <flo-retina> clokep: I've looked at the hg log of chat/ in comm-central. There's no other patch that would have needed our review. 14:55:06 <flo-retina> all the other changes we haven't reviewed are build system changes, and most of them are straight forward bustage fixes in the chat/ subtree caused by tree-wide changes. 14:55:09 <clokep> flo-retina: I think there was a couple that we caught right before check in a long time ago. 14:55:44 <clokep> flo-retina: FYI I follow http://hgchanges.fractalbrew.com/comm-central/feed/chat but it apparently wasn't working... 15:09:21 * clokep supposes he can delete his skypekit directory now... 15:19:42 <aleth> Why do we have two buddytooltip.css files now? 15:37:16 <flo-retina> aleth: one is in content, the other in themes 15:40:32 <clokep> flo-retina: Any ideas of how to track down bug 2189? 15:40:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2189 nor, --, ---, nobody, NEW, package-manifest:35: Missing file(s): bin/uninstall/helper.exe 15:41:06 <flo-retina> clokep: look at the code generating that file, and see why it's not called any more? 15:41:36 <aleth> flo-retina: Let me rephrase that: I don't understand why that display:none should be in content 15:45:25 <clokep> flo-retina: Our code seems to match what's in m-r, but I'll keep looking. :) 15:45:54 <flo-retina> aleth: our usually rule is that CSS code defining what's displayed (that's usually -moz-binding and display: none rules) are in content/, and CSS code defining how it appears is in themes. 15:47:07 <aleth> OK 15:47:19 <aleth> Thanks! 15:47:41 <aleth> If you bump the permissions, I can test the new tooltips ;) 15:48:00 <flo-retina> I'm trying to convince Even to fix the real problem ;) 15:48:25 <clokep> Hm...I was supposed to poke Even too... 15:48:39 <flo-retina> clokep: apparently he started the linux slave without your help though ;) 15:48:49 <clokep> Ah-ha! :) 15:53:09 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 16:07:54 <flo-retina> aleth, clokep: I think you two should now have updates 16:08:04 * flo-retina wants his new tooltips! 16:08:23 <aleth> Indeed :) 16:08:38 <-- aleth has quit (Quit: Ciao) 16:08:42 --> aleth has joined #instantbird 16:08:42 * ChanServ sets mode +h aleth 16:08:59 <clokep> Full update. :( 16:09:12 <aleth> Partial updates haven't worked since the server move. 16:09:19 <flo-retina> aleth: not fully true. 16:09:21 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 16:09:31 --> clokep has joined #instantbird 16:09:32 * ChanServ sets mode +o clokep 16:09:32 <flo-retina> aleth: I saw 2 successful partial updates on Mac. 16:09:34 <aleth> Those tooltips look so much nicer :) 16:09:39 <aleth> Thanks wnayes! 16:09:45 <flo-retina> aleth: and I don't have any explanation for why these 2 worked, and none of the others did :( 16:09:54 <flo-retina> aleth: I'm jealous now! 16:10:09 <clokep> flo-retina: Becaues aleth thanked wnayes? ;) 16:10:11 * flo-retina wants his new nightly with new tooltips! 16:10:16 <clokep> Ohhh, haha. 16:10:18 <clokep> They look nice. :) 16:10:42 <flo-retina> I would like to kick that ISP 16:11:05 <aleth> Hmm, I wonder if for contacts without avatars the line above the status should go all the way to the left (and the display name with it) 16:11:52 <aleth> Right now there is an indent without a real reason 16:12:08 <flo-retina> but it's very very cheap for what I get, so I guess what I get is reasonable for my money :-S 16:12:46 <flo-retina> 8euros/month for a 100Mbps "fiber" connection (I actually only get 25Mbps, but that's ok) 16:12:47 <aleth> You need an uninterrupted connection during the whole build? 16:12:58 <flo-retina> aleth: yes, because buildbot sucks :( 16:13:12 <flo-retina> aleth: my plan is to make that go through an SSH tunnel as soon as I access that machine again! 16:13:15 <clokep> aleth: I think we've discussed that on conversation sbefore too. 16:14:40 <flo-retina> aleth: I like having both lines of texts vertically aligned. 16:14:51 <flo-retina> err, horizontally 16:14:55 <flo-retina> well, you know what I mean 16:15:38 <flo-retina> clokep: does http://lxr.instantbird.org/instantbird/source/instantbird/installer/windows/Makefile.in#54 work? 16:17:09 <clokep> I'm not sure... 16:20:01 <flo-retina> so that's where I would start looking ;) 16:20:37 <clokep> Thanks. :) 16:22:27 <flo-retina> I'm trying to fix http://ftp.instantbird.com/instantbird/stats/ 16:22:31 <flo-retina> the figures I get are strange 16:22:46 <flo-retina> 4792 04/Nov/2013 16:22:46 <flo-retina> 5004 05/Nov/2013 16:22:46 <flo-retina> 5128 06/Nov/2013 16:22:47 <flo-retina> 5088 07/Nov/2013 16:22:47 <flo-retina> 4918 08/Nov/2013 16:22:50 <flo-retina> Not sure I really believe it :-S 16:23:11 <flo-retina> why would have jumped up by 2000 without reason? 16:23:15 <aleth> Counting pings differently? 16:24:40 <flo-retina> I do'nt think so 16:24:56 <flo-retina> but maybe we failed to update often enough that builds ping more frequently 16:25:45 <aleth> I can't remember if nightlies were counted in the stats at all 16:26:48 <flo-retina> they were 16:26:59 <flo-retina> we just count the number of requests on update.xml in the apache log 16:27:16 <flo-retina> and we exclude the requests that contain "force" (ie. where the user clicked "check for updates" in the UI 16:30:58 <clokep> Sounds complicated. :P 16:31:04 <flo-retina> ? 16:35:06 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 3029 on bug 2069. 16:35:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2069 nor, --, ---, aleth, ASSI, Update theming for '+' button on Linux 16:35:47 <clokep> aleth: Can I get screenshots? 16:36:38 <clokep> Either that or I can blindly r+ it. :P 16:38:23 --> mconley has joined #instantbird 16:38:35 <aleth> https://i.minus.com/jo6AFTsnpB5Rz.png https://i.minus.com/jbfPo5zx72IBcD.png 16:39:51 <instantbot> clokep@gmail.com granted review for attachment 3029 on bug 2069. 16:39:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2069 nor, --, ---, aleth, ASSI, Update theming for '+' button on Linux 16:40:02 <aleth> flo-retina: Those stats are suspiciously close to 2x the previous ones 16:41:02 <aleth> clokep: Do you want to steal the review on bug 1454? It's a patch with just comments after all. 16:41:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1454 tri, --, ---, aleth, ASSI, Add explanatory comments to document normalizedNames 16:41:44 <clokep> aleth: Didn't I write those originally? 16:42:08 <aleth> clokep: Ah yes. So maybe you shouldn't steal it... 16:42:19 <clokep> :) 16:42:23 * aleth was just looking at this review queue 16:42:30 <clokep> Just keep poking Florian with a sharpened stick. ;) 16:43:10 <aleth> I know it's boring, but I don't want it bitrotting 2115 ;) 16:43:30 <clokep> bug 2115 16:43:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2115 nor, --, ---, nobody, NEW, Provide a way to obtain the normalizedName of a nick 16:43:38 <clokep> Ahhh... 16:43:56 * clokep isn't sure. 16:44:02 <clokep> I can request review of oyu and oyu can review it? :P 16:44:13 <aleth> also known as the last of the normalize bugs ;) 16:44:25 <clokep> :-D I can't wait! 17:07:05 <flo-retina> aleth: does Firefox really look like https://i.minus.com/jbfPo5zx72IBcD.png ? 17:08:24 <aleth> flo-retina: Yes 17:08:51 <flo-retina> it's really strange that the + is twice as bold as the > and the down arrow. 17:08:57 <aleth> (well, apart from the incorrect background, that's due to the lack of 64 bit builds) 17:09:30 <aleth> That's because mozilla does this strange thing where it pulls half (but only half) the icons from the system icon theme 17:09:50 <flo-retina> are the other two icons really from the system? 17:09:50 <aleth> Causing ugliness in various places. 17:10:08 <aleth> The + is from the system 17:12:53 --> gerard-majax__ has joined #instantbird 17:14:43 <-- gerard-majax__ has quit (Ping timeout) 17:18:28 <-- IRCMonkey57467 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 17:20:56 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 17:21:37 --> Mic has joined #instantbird 17:21:37 * ChanServ sets mode +h Mic 17:23:09 <Mic> Tooltips ftw! :) 17:23:34 <Mic> Very nice, great that they finally landed! 17:25:35 <Mic> It looks like almost all margin/padding was lost though. 17:26:04 <clokep> Mic: Your avatar doesn't seem to work in it. :( 17:26:05 <Mic> The text almost starts at the border of the tooltip and that makes it look a bit packed. 17:26:18 <clokep> Oh, it only works from the buddy list, not from the participants window. 17:27:59 <Mic> The protocol icon has the same problem as in the conv top header, i.e. it touches the separator from top. 17:28:52 <flo-retina> aleth, clokep: the data I get when looking at both servers are: http://pastebin.instantbird.com/432705 17:29:11 <flo-retina> I really don't understand how we can have some many requests still reaching the old server :-S 17:29:21 <flo-retina> *so many 17:29:38 --> gerard-majax__ has joined #instantbird 17:29:57 <flo-retina> Mic: can you show a screenshot of what you see? 17:30:13 <Mic> Sure, give me a few minutes. 17:30:26 <flo-retina> it's difficult to meaningfully comment about what should be changed if we aren't sure we see the same thing :) 17:30:35 <aleth> Mic: On Linux it's mainly the horizontal margin that seems tighter 17:30:36 <Mic> That's true ;) 17:31:01 <Mic> aleth: yes, it seems to be ..3px here? 17:32:07 <flo-retina> when I looked yesterday there was some padding I would likely have wanted to add, but that really felt like follow-ups :) 17:32:13 <aleth> For comparison https://i.minus.com/jnvb2v326SuAB.png 17:32:26 <flo-retina> blue? :-S 17:32:54 <flo-retina> where has the MUC icon disappeared? 17:33:05 <aleth> No idea why they are blue, FX has that too. 17:33:15 <flo-retina> likely your GTK theme then 17:33:40 <aleth> yeah 17:35:30 <Guido> hello, wil it be possible to get an invisible mode? 17:37:20 <flo-retina> ah, the mac slave has failed another 2 nightlies 17:38:35 <flo-retina> aleth: you were right, it seems that all lines in the apache log are duplicated :-S 17:39:00 <clokep> That blue is gross. 17:39:53 <clokep> Guido: I suggest you read bug 510. 17:39:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=510 enh, --, ---, nobody, NEW, Invisible mode / appear offline 17:40:07 <clokep> (And possible http://clokep.blogspot.com/2012/10/on-status.html, but that's a fairly poorly written blog post I'm not very happy w/.) 17:40:14 <aleth> KDE usually has white on black, that must be a bug in their gtk theme. 17:40:41 <flo-retina> clokep: wow, I tried to find that post several times 17:40:49 <flo-retina> I was sure it was on the ib blog, and with "invisible" in its title :( 17:41:00 <clokep> flo-retina: Nope, on my blog w/o invisible in the title. 17:41:18 <clokep> Awesomebar found it for me. :) I did try "clokep.blog invis" before going to "clokep.blog stat" though ; 17:41:26 <clokep> Several times for what? 17:41:36 <Mic> http://i.imgur.com/L30uYJU.png 17:41:41 <-- sary has quit (Ping timeout) 17:41:47 <Mic> Excuse the ugly XP tooltip style. 17:41:51 <flo-retina> clokep: tried to convince Boriss that invisible was a bad idea. 17:41:57 <clokep> Ohhhh. 17:41:58 --> sary has joined #instantbird 17:42:01 <clokep> flo-retina: Did you win? 17:42:29 <flo-retina> no 17:42:37 <clokep> :( 17:42:56 <clokep> I think not having invisible w/o being able to block people is a bit odd... 17:45:37 <flo-retina> wow, if I keep "o" pressed for several seconds, instead of repeating the o, it opens a panel showing all the possible accents on "o" I could want to type 17:45:51 <flo-retina> I wonder if it's a moz25 feature or some strange option I toggled by accident in the system preferences 17:46:05 <Mic> WFM :P 17:46:15 <aleth> Not a moz25 feature I think. 17:46:28 <aleth> Actually sounds kind of useful to me. 17:46:56 <Guido> clokep: so it is in work, but not solved jet (not included and no addon) 17:47:14 <flo-retina> the panel doesn't move with the window 17:47:19 <flo-retina> so possible an OS thingy 17:47:23 <aleth> Guido: Nobody is working on it, because it can't work for all protocols. 17:47:51 <aleth> Guido: If you would like to implement it for specific protocols that support it, you could do that. 17:48:13 <flo-retina> Mic: so appart from the prpl icon touching the horizontal line, it looks good :) 17:48:33 <flo-retina> Mic: I agree some paddings could be increased 17:49:20 <clokep> Guido: No. 17:49:37 <clokep> The backend supports it, and some protocols. 17:49:40 <clokep> We will not show it in the UI. 17:49:50 <Mic> flo-retina: yes, beside the paddings and the icon position things look fine. 17:50:53 <Mic> I was expecting a separator between the header and the section with the fields + values by the way. 17:51:51 <Mic> Or at least a tiny bit of extra space to separate these parts a bit from another. 17:52:09 <Guido> clokep: i don't know how to program (this). As fare as I know the away status combined with FB works as invisible. I would like to be invisible on gmail 17:53:23 <flo-retina> Mic: yeah, it would make sense to separate them 17:53:40 <flo-retina> and I think we need some text to replace/in addition to the horizontal line with the list of buddies 17:53:51 <flo-retina> as it is right now, that doesn't really make sense 17:54:21 <flo-retina> Mic: I'm also not really sure of why that list is animated 17:54:27 <Mic> We could use the tag icon for the tags. 17:54:28 <flo-retina> that seems to just make everything jump around 17:54:30 <aleth> More space is probably better than yet another line. 17:54:32 <-- GeekShadow has quit (Client exited) 17:54:38 <flo-retina> I suspect I/we were just playing with the shiny new CSS transitions 17:54:57 <Mic> Maybe it's a side effect and not intentionally used there? 17:55:00 <flo-retina> Mic: I definitely want us to use the tag icon for the tags, align it with the status icon, and make that the line immediately after the status. 17:55:18 <flo-retina> Mic: if we reuse the <buddy> binding it's quite possible it wasn't really intentional 17:55:26 --> dionisos has joined #instantbird 17:57:29 <aleth> Guido: An add-on could do this, but we are not going to implement it as a standard feature. 17:57:37 <Mic> http://lxr.instantbird.org/instantbird/source/instantbird/content/buddytooltip.xml#293 17:57:49 <Mic> We're creating a "buddy"-element here... 17:58:07 <flo-retina> Mic: I think there's a lot we can improve in the middle and bottom parts of the tooltips. 17:58:14 <flo-retina> We were really focusing on the top part. 17:58:18 <aleth> Guido: Why do you want to be invisible? DOn't people respect your Unavailable status? 17:58:36 <flo-retina> Mic: and I suspect we made that part look good enough that now everything else in the tooltip looks like it wants to be redone ;) 17:58:44 <Mic> True ;) 17:59:52 * aleth wonders if Mic has any ideas for the MUC icon in the awesometab 18:00:07 * flo-retina wonders if anybody is going to add tooltips to the awesometab soon 18:00:08 <Guido> aleth: I want to be "available" for some persons. if they have something important a can react soon, but i don't want them to know when I'm behind the computer 18:00:38 <flo-retina> Guido: so why can't you just set your status to "do not disturb"? 18:00:57 <aleth> Guido: How do they know you are available if you are set to invisible? 18:01:28 --> GeekShadow has joined #instantbird 18:02:48 <Guido> aleth: they do not know, but i can answer imideatly. 18:03:25 <Guido> flo-retina: they would see that I'm behind a computer and have the chat switched on 18:04:24 <Guido> aleth: as long as i'm invisible it's up to me to answer or not and i can also say that i wasn't there 18:04:28 <flo-retina> Guido: what's the problem with that? 18:04:55 <flo-retina> if you are "unavailable" all they know is that a computer you own has access to the internet. Not that you are near it. 18:06:06 <Guido> flo-retina: hm, okee, but I'm an environmentalyst and i swich the computer compleatly off, if I'm not there and they know that 18:06:27 <flo-retina> that's interesting :-D. 18:06:36 <aleth> Guido: Thanks. 18:06:58 <flo-retina> Guido: do you also switch your phone off when you are not calling someone? 18:07:26 <flo-retina> Guido: most people I know appear constantly on because they are connected to their IM services from their phone too. 18:07:45 <Guido> flo-retina: i don't have a smatphone, i tend to vorget to charge my mobile and to forget it on my room 18:08:06 <flo-retina> ok :) 18:09:04 <flo-retina> So what's the problem if they know you are at your computer, that your chat software is running (because it starts automatically with the computer), and that you don't reply to them when they send you messages while you are "unavailable"? 18:10:08 <flo-retina> The way I see the "do not disturb/unavailable" status is "don't talk to me now, unless you don't care about how soon I'll answer, or what you have to say is urgent enough that you would disturb me even more for it by calling me on my phone if I wasn't online now." 18:10:40 <flo-retina> and it seems to me that this definition of "unavailable" matches your described use of the invisible status. 18:11:09 <Guido> flo-retina: I don't even want that some know that the computer is running, i'm at home 18:12:57 <flo-retina> do you use the same account to talk to work-people and to friends? 18:13:21 <flo-retina> (ie. are you saying you don't want people to talk to you about work related stuff when you are at home?) 18:15:21 <Guido> not exactly, but quite the same 18:16:03 <flo-retina> Guido: I have some people annoyingly asking me stuff about work at 9pm. I usually just don't reply. 18:16:31 <-- Guido has quit (Client exited) 18:16:48 --> Guido has joined #instantbird 18:17:04 <-- gerard-majax__ has quit (Ping timeout) 18:17:15 <Guido> what did you sayed? instundbird crashed before i could read it 18:17:29 <flo-retina> Guido: I have some people annoyingly asking me stuff about work at 9pm. I usually just don't reply. 18:17:43 <aleth> It crashed? Now that is bad... 18:17:45 <flo-retina> aleth: http://pastebin.instantbird.com/432777 any idea about how I could find a reasonable figure for 31/Oct? 18:18:39 <Guido> aleth: it happens sometimes and somtimes not al messages from or to FB are shown in the program 18:18:56 <aleth> flo-retina: That value seems between 30/10 and 1/11, so is it unreasonable? 18:19:21 <Guido> flo-retina: yea, but i also don't want them to know that I'm home and i can't make 2 accounts 18:19:27 <aleth> Guido: Did you submit a crash report? 18:19:31 <-- Guido has quit (Connection reset by peer) 18:19:36 <flo-retina> aleth: I guess my problem is really that I have no idea of where the pings in lines 5-14 come from in http://pastebin.instantbird.com/432705 18:19:45 --> Guido has joined #instantbird 18:20:07 <aleth> Do some people on really old versions have a different hardwired address? 18:20:08 <Guido> oh, that was a soon next crash 18:20:18 <aleth> Guido: Did you submit a crash report? 18:20:21 <flo-retina> aleth: Even is still trying to make crash-stats work on the new server 18:20:35 <Guido> aleth: no, how can i? 18:20:41 <aleth> ok, so that won't work for now. 18:21:09 <aleth> Guido: Usually it should ask you when it crashes. 18:21:50 <Guido> okee, think then i send it 18:22:11 * aleth hasn't seen a crash in ages. 18:22:37 <Guido> flo-retina: but i still don't want that they know i'm home 18:22:50 <flo-retina> aleth: the pings we get on the old servers (even today!) are from 1.4 and a few from 1.5a1pre 18:22:57 <flo-retina> aleth: so no, not from old versions :-S 18:24:00 <flo-retina> aleth: I don't think DNS servers could be caching the old IP for 10+ days :-S 18:24:19 <flo-retina> that really makes no sense for me :-S 18:24:28 <aleth> Weird. 18:24:53 <Guido> my version: 1,4 18:25:15 --> chrisccoulson has joined #instantbird 18:30:06 <aleth> Guido: I'm not sure how reliable "invisible" is. After all, the server has to know you are connected... But if you want to write an add-on that supports it for gtalk we could probably give you some pointers. 18:30:53 <Guido> aleth: i have no idea about how to write ab app or something 18:31:36 <aleth> Guido: It's just Javascript, I'm sure you could learn ;) 18:32:09 <Guido> i have no idea how to program java ... 18:32:49 <Guido> if i'm on gmail and then log in with instantbird i get the message that i'm no longer invisible as the program does not support invissible 18:34:33 --> mpmc has joined #instantbird 18:42:10 <aleth> That's right. 18:51:28 <flo-retina> were we considering full text indexing for the LIST results? 18:51:50 <aleth> Yes, because of the topics 18:52:09 <flo-retina> would we keep that index around, or need to recreate it whenever we LIST? 18:52:10 <instantbot> New Instantbird (UI) bug 2243 filed by benediktp@ymail.com. 18:52:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2243 min, --, ---, nobody, NEW, Time since last message in Bubbles theme only showing after switching tabs 18:52:53 <aleth> We would probably need to recreate it (we only LIST once a day iirc btw) 18:53:41 <flo-retina> this sounds wasteful, but I don't have any better idea :-S 18:55:50 <flo-retina> I'm also wondering if the database I'll create for indexed logs obsoletes the JSON cache of the stats service 18:56:12 <flo-retina> (ie. is there any data in that cache that we can't trivially regenerate from the database?) 18:56:48 <aleth> No idea. Worry about it later? 18:57:59 <aleth> Depends also on what your database looks like. Are you thinking of using a tree?\ 18:58:30 <flo-retina> a tree for what? 18:59:29 <aleth> i.e. instead of looking up whole words, build a directed graph with the nodes being the letters and the endpoints representing the words. 19:00:02 <flo-retina> I'm not sure of what you are talking about :-S 19:00:18 <flo-retina> I won't do the full text index by hand, SQLite knows how to do it likely better than I do 19:01:02 <aleth> OK, if you are not implementing that yourself ignore my comment ;) 19:02:23 <flo-retina> bah, I didn't remember how complicated the gloda stuff was :-S 19:02:40 <flo-retina> I was naïvely hoping I could find something to copy/paste there :-D 19:11:54 <-- Guido has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 19:18:25 --> FireFly_TB has joined #instantbird 19:23:30 --> EionRobb has joined #instantbird 19:37:59 <-- FireFly_TB has quit (Quit: FireFly_TB) 19:38:46 <-- mpmc has quit (Ping timeout) 19:38:52 --> FireFly_TB has joined #instantbird 19:38:56 --> mpmc has joined #instantbird 19:47:40 --> wnayes has joined #instantbird 19:58:41 <Mic> wnayes: thanks for the new tooltips, they're great! :) 19:59:17 <wnayes> Mic, aleth: You're welcome :) 19:59:38 <wnayes> I'm not sure how why the protocol icon is out of line on XP :( 20:00:31 <Mic> Did you copy CSS rules from the header of conversations? 20:00:53 <Mic> There's the protocol selector at the right end of the conv top header and it's got the same problem here. 20:01:00 <wnayes> More or less. It's the same way there too? 20:02:32 <-- aleth has quit (Quit: Ciao) 20:04:17 <wnayes> The tricky part with the padding is that it varies based on the OS theme I think. 20:05:28 <wnayes> The padding that exists currently, that is (which I couldn't find a way to set explictly) 20:06:48 <Mic> That means we'd need more or less padding on different OS'? 20:07:21 <Mic> We could use %IFDEFs if needed? 20:07:44 <EionRobb> or put the ostheme in as a css class? 20:08:17 <Mic> We've got ifdef's in CSS files anyways already. 20:09:23 <wnayes> Yeah. Also it seems the issue with the protocol icon on XP is because the text beside it is not nearly as tall. 20:09:25 <-- FireFly_TB has quit (Input/output error) 20:10:13 --> FireFly_TB has joined #instantbird 20:11:04 <wnayes> Text height also influences how tightly packed the lower rows are I'm guessing. 20:12:20 <Mic> Do you know how does it look on Windows 7 for example? 20:16:08 <wnayes> Mic: http://i.imgur.com/HooiqOC.png 20:17:13 <Mic> :) 20:17:13 <Mic> The horizontal paddings are a lot better and the text isn't packed as it is on XP. 20:17:34 <wnayes> Moving from |font-size: large| to some fixed value on display name might improve compatibility. 20:25:50 <instant-buildbot> build #1154 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/1154 20:35:59 <flo-retina> oh! 20:38:00 <flo-retina> wnayes: you'll still have problems if people change the dpi settings 20:38:30 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 20:38:33 --> flo-retina has joined #instantbird 20:38:34 * ChanServ sets mode +qo flo-retina flo-retina 20:39:15 <flo-retina> I'm getting a full update :-/ 20:42:25 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 20:42:28 --> flo-retina has joined #instantbird 20:42:29 * ChanServ sets mode +qo flo-retina flo-retina 20:45:58 <flo-retina> :-) 21:02:02 <flo-retina> when showing the tooltip of a contact, if the preferred buddy doesn't have a buddy icon, shouldn't we try a bit harder and see if other buddies of the contact have one? 21:05:14 <Mic> flo-retina: is that really something that the tooltip should do itself? 21:05:25 <flo-retina> Mic: not really no 21:05:41 <Mic> :) 21:05:43 <flo-retina> Mic: it's really the buddy icon getter of the contact 21:05:51 <flo-retina> Mic: there's the same thing at the top of conversations 21:05:53 <Mic> That's what I was about to say. 21:07:57 <Mic> I'm also annoyed a lot that there are no icons for offline contacts (on some protocols?). It's a lot more visible with the awesome-tab now. 21:12:13 <-- skeledrew has quit (Ping timeout) 21:12:41 --> skeledrew has joined #instantbird 21:49:06 <flo-retina> Here's the draft SQL schema I have for indexed logs: http://pastebin.instantbird.com/433064 21:55:54 <-- Suiseiseki has quit (Ping timeout) 22:00:50 <-- dionisos has quit (Ping timeout) 22:05:42 <flo-retina> Sqlite.jsm seems nice :) 22:10:27 <-- mconley has quit (Input/output error) 22:16:28 --> Suiseiseki has joined #instantbird 22:18:04 <-- clokep has quit (Ping timeout) 22:26:17 <instantbot> New Instantbird (UI) bug 2244 filed by benediktp@ymail.com. 22:26:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2244 nor, --, ---, nobody, NEW, Use tag icon on tooltips 22:33:11 <instantbot> New Instantbird (UI) bug 2245 filed by benediktp@ymail.com. 22:33:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2245 min, --, ---, nobody, NEW, Separate tooltip header from section with the list of details 22:33:53 --> mconley has joined #instantbird 22:36:24 <instantbot> New Instantbird (UI) bug 2246 filed by benediktp@ymail.com. 22:36:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2246 min, --, ---, nobody, NEW, List of buddies on the tooltips could use a descriptive headline 22:50:34 <instantbot> New Instantbird (UI) bug 2247 filed by benediktp@ymail.com. 22:50:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2247 min, --, ---, nobody, NEW, Make the "Account" information on tooltips more meaningful 22:59:50 <-- dew1 has quit (Ping timeout) 23:03:45 --> dew has joined #instantbird 23:11:35 <-- mconley has quit (Ping timeout) 23:14:44 --> mconley has joined #instantbird 23:20:53 <-- mconley has quit (Input/output error) 23:42:59 <-- chrisccoulson has quit (Ping timeout) 23:49:57 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)