#instantbird log on 10 11 2013

All times are UTC.

00:01:04 <flo-retina> bah, it looks like my first idea for configure.in won't fly :(
00:01:12 <clokep_work> Why did that build fail? :-S
00:01:20 <flo-retina> the top level c-c configure.in doesn't do anything
00:01:55 <flo-retina> and the only changes it makes to the result of the mozilla/ configure are made in python, so just putting autoconf macros inside the configure.in script wouldn't produce any useful result :(
00:02:22 <flo-retina> back to square 1 :(
00:02:32 <clokep_work> :-\ That's silly.
00:03:05 <flo-retina> clokep_work: looks like someone broke Yahoo ;)
00:03:17 <clokep_work> flo-retina: I tested those patches though...
00:03:27 <flo-retina> is Http.jsm packaged?
00:03:33 <flo-retina> does it need to be?
00:03:39 <clokep_work> Ummm....I don't know. :)
00:03:51 <flo-retina> hmm, http://mxr.mozilla.org/comm-central/source/mail/installer/package-manifest.in#108 should do I guess :-S
00:04:25 <clokep_work> Shouldn't the libpurple yahoo be being used anyway? ;)
00:05:11 <flo-retina> by the xpcshell testes?
00:05:13 <flo-retina> *tests
00:05:35 <clokep_work> Ah, sorry. I'm specifically looking at test_purplexpcom.
00:05:45 * clokep_work blames qheaden.
00:05:48 <clokep_work> He gave me an r+. :P
00:06:04 <flo-retina> :-D
00:06:31 <flo-retina> clokep_work: I think I would try to fix "failed to create an instance of @mozilla.org/chat/yahoo;1: [Exception... "Component returned failure code: 0x80570015 (NS_ERROR_XPC_CI_RETURNED_FAILURE) [nsIJSCID.createInstance]"" first
00:06:35 <qheaden> What broke?
00:06:44 <flo-retina> clokep_work: I told him he should give you a few r-
00:06:48 <flo-retina> qheaden: tests
00:06:53 <flo-retina> qheaden: http://buildbot.instantbird.org/builders/linux-onCommit/builds/483/steps/shell_1/logs/stdio
00:06:57 <clokep_work> Ah.
00:06:58 <clokep_work> I know what it is.
00:07:12 * qheaden scolds clokep_work. :P
00:07:17 <clokep_work> I didn't change the path to http.jsm in yahoo-session.
00:07:22 <clokep_work> qheaden: It's ahlf your fault. ;)
00:07:26 <flo-retina> clokep_work: are tests even running on a packaged version of the build?
00:07:27 <clokep_work> Can I push a fix w/o testing it?
00:07:32 <qheaden> :P
00:07:58 <flo-retina> "I tested those patches" he said :-P.
00:09:38 <clokep_work> flo-retina: I did.
00:09:40 <clokep_work> I seriously did.
00:09:50 <clokep_work> I made sure I could connect to Yahoo.
00:09:53 * flo-retina would remove "seriously" from that sentence :-P
00:10:12 <flo-retina> more /seriously/ any idea of why your testing didn't catch it?
00:10:43 <clokep_work> qheaden: http://pastebin.instantbird.com/381680
00:10:56 <clokep_work> Windows is case insensitive?
00:10:58 <clokep_work> Maybe?
00:11:35 <qheaden> clokep_work: The file wasn't found before?
00:12:25 <clokep_work> I don't really understand the question.
00:12:35 <clokep_work> The component can't be created, see http://buildbot.instantbird.org/builders/linux-onCommit/builds/483/steps/shell_1/logs/stdio
00:12:48 <qheaden> clokep_work: Oh nevermind. I see you added gre in front.
00:13:01 <qheaden> That patch looks fine. I assume it works?
00:13:05 <clokep_work> I haven't tested it.
00:13:12 <clokep_work> I have no capability to do it. :(
00:13:14 <clokep_work> Not until my build finishes.
00:13:16 <clokep_work> But we're going.
00:13:18 <clokep_work> I'll be back later.
00:13:28 <qheaden> clokep_work: Unfortunately, I need to build my tree too.
00:13:40 <qheaden> Did a clobber yesterday, and I was trying to get distcc working. Never finished the build.
00:14:42 <nhnt11> ]\\
00:14:59 <nhnt11> ^ignore that :(
00:18:20 <-- Rym has quit (Ping timeout)
00:18:20 <flo-retina> clokep_work, qheaden: the pastebined patch fixes the xpcshell tests.
00:18:35 <qheaden> Great.
00:18:44 <qheaden> Hey nhnt11.
00:18:50 <flo-retina> I tested on my local broken debug build (I messed it up with my configure.in hacks... but managed to get the relevant parts to rebuild without touching the rest)
00:19:04 * qheaden goes to rebuild his tree.
00:20:15 * flo-retina pushed the fix
00:20:28 <nhnt11> Hey qheaden
00:21:46 --> Rym has joined #instantbird
00:22:02 <flo-retina> Good night
00:22:10 <qheaden> Good night flo-retina.
00:26:20 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/03c7937d8f17 - Patrick Cloke - Bug 2159 - Bustage fix for Yahoo tests, r=fqueze.
00:36:20 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/59e18294a19d - Nihanth Subramanya - Bug 2200 - Use a conversation's statusType for ranking, r=aleth, Mic.
00:48:40 <-- Mook_as has quit (Quit: Mook_as)
00:49:03 <instant-buildbot> build #484 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/484
00:53:43 <instant-buildbot> build #486 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/486
01:14:56 <-- Rym has quit (Ping timeout)
01:16:20 <instant-buildbot> build #485 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/485
01:18:16 --> Rym has joined #instantbird
01:22:49 <-- Rym has quit (Ping timeout)
01:24:01 <instant-buildbot> build #487 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/487
01:26:14 --> Rym has joined #instantbird
01:33:26 <-- Rym has quit (Ping timeout)
01:36:52 --> Rym has joined #instantbird
01:38:03 <instantbot> clokep@gmail.com set the Resolution field on bug 2200 to FIXED.
01:38:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2200 nor, --, 1.5, nhnt11, RESO FIXED, Use a conversation's statusType for ranking
01:40:36 <clokep_work> qheaden: flo-retina Thanks. :)
01:42:25 <-- Rym has quit (Ping timeout)
01:45:48 --> Rym has joined #instantbird
01:56:40 <-- Rym has quit (Ping timeout)
03:12:05 <instant-buildbot> build #998 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/998
03:16:21 --> dew has joined #instantbird
03:25:14 --> mconley has joined #instantbird
03:33:33 <-- mconley has quit (Input/output error)
03:34:56 <instant-buildbot> build #1030 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/1030
04:21:14 --> mconley has joined #instantbird
04:24:43 <-- EionRobb has quit (Quit: Leaving.)
04:28:28 <-- mconley has quit (Input/output error)
05:06:27 --> jb has joined #instantbird
05:19:31 <-- jb has quit (Ping timeout)
06:01:40 --> Rym has joined #instantbird
06:02:43 <Rym> Anyone alive?
06:30:08 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
06:30:32 --> chrisccoulson_ has joined #instantbird
06:31:27 <-- chrisccoulson_ has quit (Client exited)
06:31:31 --> chrisccoulson has joined #instantbird
06:53:03 <-- spiffytech has quit (Ping timeout)
06:56:18 --> spiffytech has joined #instantbird
07:00:58 <-- Mook has quit (Ping timeout)
07:04:37 --> Mook has joined #instantbird
07:15:36 --> Mic has joined #instantbird
07:15:36 * ChanServ sets mode +h Mic 
07:18:28 --> BWMerlin has joined #instantbird
07:27:26 --> lepalmtree has joined #instantbird
07:27:30 <lepalmtree> bonjour
07:28:10 <lepalmtree> est-ce qu'il est possible d'avoir  les notifications de nouveaux messages dans la zone de notifications d'ubuntu ? 
07:31:15 <Mic> Hi
07:31:23 <Mic> Hello Rym, hello lepalmtree
07:31:43 <Rym> hi
07:32:08 <Rym> I think lepalmtree is wanting new message notifications to be in the ubuntu zone thing, I think an addon provides that?
07:32:35 <Rym> Mic: My question, a recent changelist says it's easier to fix cert errors with irc 
07:32:51 <Mic> Thanks, I understood (the few years of french in school paid off apprantely).
07:33:15 <lepalmtree> oh sorry, i thought this was a french channel
07:33:23 <lepalmtree> and yes Rym that's what i was asking :) thank you
07:33:47 <Rym> I'm getting cert errors for oftc.net and it's saying Cert marked unsafe by user, but gives no additional help to either see the Cert, or any ability to fix it (I haven't changed any of the cert options in preferences)
07:33:49 <Mic> Rym: if you're running a nightly build you should get an error and a link to open a dialog to add exception if I'm right.
07:33:52 <lepalmtree> sorry guys, i'll go in english from now on
07:34:03 <Rym> ah i'm not, I'm on latest stable I think
07:34:21 <Rym> It has the add exception link
07:34:39 <Mic> Oh, really? I don't remember when that was added.
07:34:48 <Rym> But I'd prefer not to click that without knowing what the cert is?
07:36:01 <Mic> lepalmtree: I'm not a Linux user so I don't know what we support there and what we don't. Have you searched on addons.instantbird.org for an extension that might help?
07:36:52 <Mic> Rym: can I try myself somehow? irc.oftc.net:6697 or something?
07:36:53 <lepalmtree> Mic: yes i did, and unfortunately, there is no extension that does the job
07:37:13 <Rym> yeah that's it for ssl (i was able to connect without ssl fine)
07:37:29 <Mic> Is there something on AMO (addons.mozilla.org) for Thunderbird? COuld be changed to work with IB most likely.
07:38:24 <Mic> Rym: the link will only open a dialog by the way.
07:38:45 <lepalmtree> i'll check, but thunderbird has that notification system built-in for ubuntu, so i don'think there is an addon for that
07:38:48 <lepalmtree> i'll let you know
07:39:35 <Rym> ok, I was wary of it taking immediate action, sec, i'll retry on my end to see dialog
07:41:11 <Rym> ah ok, Mic, that behavior is actually nice, perhaps rewording the 'Add Exception' as 'Review Certificate' might be clearer
07:41:33 <Mic> The dots indicate that there's a dialog coming before anything happens.
07:42:16 <Mic> You can observe the same pattern in menus and context menus by the way.
07:42:43 <Mic> (e.g. check your Firefox File menu)
07:43:53 <Rym> Even so, I'd still propose it on something as delicate as ssl certs, but ok thanks :)
07:45:08 <Mic> Rym if you think there's room for improvement, please file a bug on bugzilla.instantbird.org :)
07:45:23 <Mic> lepalmtree: you've found anything?
07:45:31 <lepalmtree> Mic: still searching
07:47:35 <lepalmtree> maybe this https://addons.mozilla.org/fr/thunderbird/addon/firetray/?src=search
07:47:44 <lepalmtree> or this https://addons.mozilla.org/fr/thunderbird/addon/enhanced-desktop-notifications/?src=search
07:49:43 <Mic> Like that, maybe? https://addons.mozilla.org/de/thunderbird/addon/unity-unread-count/?src=search
07:50:48 <Mic> Do you only want to get a notification that there is a new message, or do you actually want to read the message in the notification.
07:51:08 <Rym> Mic: will do, going to get comfortable with the software first before logging potential timewasters :)
07:51:25 <lepalmtree> Mic this is actually not the notification system. i would like notifications to appear here http://img5.imageshack.us/img5/8193/w4d1.jpg
07:51:52 <lepalmtree> and i just want to know that there is a new message
07:52:07 <Rym> that unity unread count one, I think someone ported that to instantbird already https://addons.instantbird.org/en-US/instantbird/addon/310
07:53:15 <lepalmtree> Rym: yes this one exists for instantbird, but it is not doing what i want :(
07:53:44 <Rym> yeah, I understand, could probably be adapted though :)
07:54:06 <lepalmtree> Rym:  i hope so
07:54:22 <lepalmtree> i'm not good enough to do it though
07:55:20 <Rym> Could try and ask when/if you fail! :P
07:56:03 <lepalmtree> Rym: i have no idea how to do it. i don't even know how to start
07:56:24 <Mic> lepalmtree: you can wait for someone more proficient with Linux/Ubuntu than me.
07:56:51 <lepalmtree> Mic: yeah thanks, hopefully someone will be able/willing to do it
07:56:58 <Mic> aleth: ^
08:00:03 --> jb has joined #instantbird
08:16:04 <-- dew has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com)
08:41:56 <-- lepalmtree has quit (Ping timeout)
08:41:58 --> lepalmtree has joined #instantbird
08:42:55 <-- jb has quit (Ping timeout)
08:52:21 <-- gerard-majax_ has quit (Ping timeout)
08:59:43 --> jb has joined #instantbird
09:00:11 --> jb1 has joined #instantbird
09:01:27 <-- jb has quit (Ping timeout)
09:10:53 <-- Rym has quit (Ping timeout)
09:11:29 <-- jb1 has quit (Ping timeout)
09:14:24 --> Rym has joined #instantbird
09:29:41 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
09:33:59 <-- Rym has quit (Ping timeout)
09:37:13 --> Rym has joined #instantbird
09:43:25 --> gerard-majax_ has joined #instantbird
09:44:37 --> jb has joined #instantbird
09:53:46 --> flo-retina has joined #instantbird
09:53:46 * ChanServ sets mode +qo flo-retina flo-retina 
09:57:53 <-- jb has quit (Ping timeout)
10:01:00 <-- Rym has quit (Ping timeout)
10:01:01 --> Rym has joined #instantbird
10:01:08 --> jb has joined #instantbird
10:04:40 * flo-retina liked these "Mozilla is my dinosaur" story :-]
10:09:00 <-- Rym has quit (Ping timeout)
10:11:46 --> nhnt12 has joined #instantbird
10:12:25 --> Rym has joined #instantbird
10:13:09 <-- nhnt12 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
10:13:14 <-- nhnt11 has quit (Ping timeout)
10:13:18 --> nhnt11 has joined #instantbird
10:13:31 <-- jb has quit (Ping timeout)
10:22:45 <flo-retina> http://people.mozilla.org/~bgirard/cleopatra/#report=d09c3036616b93ee4150ff8a0abdaf628596dcf0 is a profile of the jank I get when opening the awesometab for the first time.
10:37:06 <nhnt11> flo-retina: This is on a profile that has never been log-swept?
10:37:22 <flo-retina> nhnt11: no, it's my everyday profile
10:37:32 * nhnt11 doesn't get it
10:37:49 <nhnt11> I somehow still think this is due to list results
10:37:53 <nhnt11> Or is that what you're saying too
10:39:32 <flo-retina> nhnt11: I suspect it's LIST, yes
10:39:55 * nhnt11 never sees jank, but he doesn't have a freenode account at the moment
10:40:00 --> jb has joined #instantbird
10:40:08 * nhnt11 doesn't know the best way to counter this
10:40:20 <nhnt11> we could delay stuff more I guess
10:41:10 <flo-retina> yeah, I don't know what the real problem is :-/
10:41:49 <flo-retina> nhnt11: maybe just change 40 -> 15 at http://lxr.instantbird.org/instantbird/source/instantbird/components/ibConvStatsService.js#242
10:42:28 <nhnt11> Hmm
10:42:34 <flo-retina> Yoric said the main thread shouldn't be blocked for more than 15ms (there's other stuff that needs to happen, like layout/painting, ...), and the user starts noticing at 100ms.
10:42:48 <Yoric> I actually said that the user starts noticing at 50ms.
10:42:51 --> aleth has joined #instantbird
10:42:51 * ChanServ sets mode +h aleth 
10:43:31 <Yoric> (I got that number from avih, who's working on making things smooth, I don't know where he got it)
10:43:37 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
10:44:11 <flo-retina> Yoric: :)
10:45:32 <flo-retina> nhnt11: another thing to do could be to suspend this background work when the user is actively interacting. I only notice this jank when scrolling in the awesometab or when typing something (typically when typing /profiler ;))
10:45:47 <flo-retina> that may be more difficult to implement though.
10:55:31 <-- jb has quit (Ping timeout)
11:01:42 <-- aleth has quit (Quit: Ciao)
11:01:49 --> aleth has joined #instantbird
11:01:49 * ChanServ sets mode +h aleth 
11:30:27 <-- Rym has quit (Ping timeout)
11:35:33 --> Rym has joined #instantbird
11:39:13 <-- Rym has quit (Ping timeout)
11:43:55 --> Rym has joined #instantbird
12:01:56 <-- Rym has quit (Ping timeout)
12:02:18 --> Rym has joined #instantbird
12:06:17 --> jb has joined #instantbird
12:15:41 <-- aleth has quit (Quit: Ciao)
12:15:52 --> aleth has joined #instantbird
12:15:52 * ChanServ sets mode +h aleth 
12:16:51 * aleth wonders what the anonymous functions are in profiles of the awesometab
12:18:18 <aleth> They have names! Why not display them ;)
12:23:57 * aleth is a little surprised this line is 20% of the time spent in getFilteredConv http://lxr.instantbird.org/instantbird/source/instantbird/components/ibConvStatsService.js#332
12:26:46 <flo-retina> aleth: they don't have names
12:27:01 <aleth> flo-retina: Some of them do (looking up the line number)
12:27:40 <aleth> That's how I identified getFilteredConv in the first place...
12:27:55 <flo-retina> aleth: http://pastebin.instantbird.com/382573
12:28:14 <aleth> flo-retina: aha! Thanks!
12:28:32 <aleth> Now I understand the point of that syntax in blist.js :D
12:29:37 <flo-retina> aleth: the part I don't understand is... I'm pretty sure the profiler used to be able to show the name of the field that contains the anonymous function
12:30:05 <flo-retina> I wonder if it's a bug only when the profiler is used on a packaged build
12:30:42 <flo-retina> I'm pretty sure I wasn't annoyed by these anonymous functions in the profiles before
12:33:26 <aleth> Maybe the names are set automatically for methods in XML files
12:35:03 <aleth> (considering you were possibly profiling conversation.xml and convbrowser.xml mainly)
12:35:11 <clokep_work> Rym: "Add exception..." is a standard string inside of Mozilla stuff.
12:45:23 <flo-retina> aleth: I was definitely profiling this LIST stuff
12:45:32 <flo-retina> I think I would have noticed if I couldn't make sense of the names
12:46:52 <clokep_work> I think it's supposed to be fixed? https://bugzilla.mozilla.org/show_bug.cgi?id=433529
12:48:56 * flo-retina got another 2 emails about the TB add-on
12:52:38 <aleth> Hmm, maybe there is still some file missing from the packaging?
12:55:22 <flo-retina> yeah, that's possible
12:58:35 --> jb1 has joined #instantbird
12:59:57 <-- jb has quit (Ping timeout)
13:08:40 <Rym> clokep_work: ok, noted :)
13:30:04 --> jb has joined #instantbird
13:30:35 <-- jb1 has quit (Ping timeout)
13:42:42 <flo-retina> nhnt11: should we just try changing the 40ms to 15 and see if that fixes stuff magically? If not, what's our plan to get the responsiveness issue fixed "soon"?
13:43:35 <flo-retina> nhnt11: btw, the ranking today after yesterday's checkin seems pretty reasonable here. Congrats! :)
13:47:42 <flo-retina> hmm, there are 2 strange things:
13:47:42 <flo-retina> 1. The 9th item is an auto-joined channel where nobody has talked in months.
13:47:43 <flo-retina> 2. The 18th item is a private IRC conversation with someone not in my buddy list. Not a problem that he's 18th, but it's strange that the item is grayed out (probably because status = unknown) even though the conversation is active.
13:50:10 <flo-retina> most recent message exchange inside the channel ranked #9 was on June 25th.
13:50:44 <aleth> Sounds like you've identified the cause of (2) and it's another case of the IRC presence problem.
13:53:05 <aleth> It might be helpful if there was a way for nightly users to dump the sorted ranking results in the way the add-on did... then you could figure out where (1) is coming from.
13:53:51 --> mconley has joined #instantbird
13:54:36 <aleth> Maybe we should add a workaround for (2) though considering that bug isn't going to be fixed soon :-/
13:55:21 <flo-retina> yeah. At this point I'm just explaining what surprises me as a user ;).
13:55:55 <flo-retina> the first thing I saw though is that overall the order seems pretty realistic :)
13:56:26 <aleth> Ranking is much better for me too, apart from the ones explained by the XMPP/IRC issue :)
13:58:38 <flo-retina> Standard8 would possibly be higher if that issue was fixed :)
14:02:00 <flo-retina> Error: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: '[JavaScript Error: "this._observers is undefined" {file: "resource://gre/components/imContacts.js" line: 841}]' when calling method: [imIContact::addObserver]
14:02:00 <flo-retina> Source File: chrome://instantbird/content/buddytooltip.xml
14:02:00 <flo-retina> Line: 83
14:02:19 <flo-retina> This was when I merged c lokep_work into the existing contact I had for Patrick.
14:08:41 <aleth> Another regression? 
14:09:03 <flo-retina> I'm not sure what caused it exactly
14:09:42 <flo-retina> I remember blaming a similar error message (when merging contacts) to the stats service recently, but here it's in buddytooltip.xml... maybe both have the same cause.
14:14:52 <flo-retina> aleth: with the participant list hidden, I need the tooltips on nicks even more ;)
14:15:10 <aleth> flo-retina: Do you have an idea to work around the issue I mentioned?
14:15:20 <flo-retina> I haven't understood that issue.
14:15:59 <flo-retina> I think seeing a WIP would help me better than an explanation though
14:16:19 <flo-retina> even if it contains a "//FIXME, not sure what to write here" in the middle at the point where you are stuck
14:16:43 <aleth> My WIP was just a test, because I expected the problem
14:17:25 <flo-retina> hmm, I should dig into wnayes' tooltip patch to see if I can finish it
14:17:29 <flo-retina> would be cool to have it for 1.5
14:17:41 <aleth> That would be nice.
14:18:16 <aleth> Btw I think I can probably work around the tooltip issue, but I suspect it won't be very elegant...
14:29:32 <flo-retina> http://google-opensource.blogspot.se/2013/05/a-change-to-google-code-download-service.html
14:34:14 <-- jb has quit (Connection reset by peer)
14:34:18 --> jb1 has joined #instantbird
14:35:28 <-- mconley has quit (Input/output error)
14:35:50 --> jb has joined #instantbird
14:36:32 <-- jb1 has quit (Ping timeout)
14:47:44 <instantbot> New Instantbird (UI) bug 2214 filed by aleth@instantbird.org.
14:47:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2214 nor, --, ---, nobody, NEW, LIST results not added to awesometab
14:53:58 <instantbot> aleth@instantbird.org requested review from nhnt11@gmail.com for attachment 2938 on bug 2213.
14:54:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2213 enh, --, ---, aleth, ASSI, Allow searching for IRC channels without typing the prefix
14:58:19 <aleth> I've now also experienced the awesomejank. STR: Connect to freenode and use the awesometab (scroll or filter) while LIST is happening.
15:11:14 <-- lepalmtree has quit (Client exited)
15:11:46 --> mconley has joined #instantbird
15:16:20 <flo-retina> aleth: unless I missed something while reading, r- from me for the new patch in bug 2213.
15:16:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2213 enh, --, ---, aleth, ASSI, Allow searching for IRC channels without typing the prefix
15:16:48 <flo-retina> aleth: mostly because I don't understand why the "c.lowerCaseName.startsWith(aFilterStr) ||" at the beginning of the test is gone
15:17:01 <flo-retina> I don't see either why /\s+/ is replaced by " "
15:18:20 <aleth> I removed it because it only does any good when it is a match, and that is the unlikely outcome, not the likely outcome. So most of the time it actually doesn't do any good.
15:18:44 <flo-retina> aleth: that test is to match my name if you type "Florian Q"
15:19:00 <flo-retina> or really, if the search string contains a space that the .split will remove.
15:19:17 <flo-retina> it looks like this could do with a comment
15:19:55 <aleth> Oh, OK. So it's a workaround for something else...
15:20:09 <aleth> I dropped the \s because I don't expect tabs, newlines, etc in user and channel names ;)
15:20:49 <flo-retina> aleth: it's just an optimization to avoid having empty items in the array if you have someone named "foo  bar" (2 spaces in the middle)
15:21:08 <aleth> Is that really an optimization?
15:21:27 <flo-retina> that's debatable. But changing that (without any metrics about it) in a bug that's completely unrelated feels r- ;)
15:22:20 <aleth> It feels like a matter of taste to me ;)
15:22:45 <aleth> I doubt there is any real performance difference.
15:23:48 <flo-retina> aleth: you are still changing a behavior here. ;)
15:24:17 <flo-retina> I don't expect any tab either. But an unbreakable space, that's conceivable.
15:29:03 <-- jb has quit (Ping timeout)
15:30:40 --> jb has joined #instantbird
15:43:29 <-- jb has quit (Ping timeout)
15:46:35 <-- Rym has quit (Ping timeout)
15:47:34 <clokep_work> flo-retina: Well...we're probably abusing it. ;)
15:47:44 <flo-retina> it ?
15:47:55 <instantbot> aleth@instantbird.org cancelled review?(nhnt11@gmail.com) for attachment 2938 on bug 2213.
15:47:57 <instantbot> aleth@instantbird.org requested review from nhnt11@gmail.com for attachment 2939 on bug 2213.
15:47:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2213 enh, --, ---, aleth, ASSI, Allow searching for IRC channels without typing the prefix
15:50:40 <clokep_work> flo-retina: The Google Code Download stuff. :-D
15:51:39 <flo-retina> ah
15:51:43 <flo-retina> well, maybe :)
15:52:44 <flo-retina> aleth: heh, looks like you really couldn't keep the existing behavior ;).
15:53:17 <-- BWMerlin has quit (Quit: BWMerlin)
15:53:27 <flo-retina> aleth: the AND feature really feels like it was for another bug, but I won't object to it as it's really nice to have it, and doing 2 patches for these 2 changes would obviously bitrot each other.
15:53:34 <flo-retina> maybe edit the summary a bit? :)
15:54:02 <aleth> Yeah, I wasn't intending to add it, but that duplicate startsWith check is just Wrong so I kind of had to... ;)
15:54:36 <flo-retina> well, not really, you could have just added a comment explaining what it was doing
15:54:55 <aleth> I did consider filing a separate bug.
15:54:59 <flo-retina> wasn't there a whole bug to add it in the first place, where we said it was "good enough for now" ? :)
15:55:11 <flo-retina> anyway, thanks for improving this :)
15:55:19 <flo-retina> having to type # really got me a few times :)
15:55:24 <aleth> There's a bug about improving search iirc but that also includes matching topics etc and is a much bigger affair...
15:55:50 --> Rym has joined #instantbird
15:59:59 <instantbot> aleth@instantbird.org cancelled review?(nhnt11@gmail.com) for attachment 2939 on bug 2213.
16:00:00 <instantbot> aleth@instantbird.org requested review from nhnt11@gmail.com for attachment 2940 on bug 2213.
16:00:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2213 enh, --, ---, aleth, ASSI, Match channels without insisting on the prefix and treat whitespace as AND in the awesometab
16:00:20 <-- Rym has quit (Ping timeout)
16:04:28 --> Rym has joined #instantbird
16:10:18 <clokep_work> flo-retina: So do we know what's next since your first try at configure didn't work?
16:10:42 <flo-retina> looking at your moz.build patch maybe?
16:10:48 <flo-retina> or that stupid Tb add-on
16:11:01 <flo-retina> I wish we could just tell them all to install Ib instead ;)
16:11:02 <clokep_work> Which of those sounds most fun. :)
16:11:20 <flo-retina> clokep_work: looking at wnayes' tooltips sounds more fun
16:14:46 <aleth> Maybe qheaden will erode the TB addon userbase in the near future...
16:15:05 <flo-retina> how so?
16:15:21 <aleth> Depending on how many people install it just to get yahoo.
16:18:50 <flo-retina> ah!
16:19:07 <flo-retina> I just understood that you mean it will reduce the need for the add-on, not the usage of Tb instead of Ib :-D
16:20:18 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
16:22:10 <clokep_work> I doubt most of them do it for Yahoo, but it would be nice. :)
16:26:43 <-- Rym has quit (Ping timeout)
16:31:26 --> Rym has joined #instantbird
17:06:33 <-- gerard-majax_ has quit (Ping timeout)
17:15:31 * clokep_work wonders if Florian knows what dependlibs.list is.
17:30:34 --> dionisos has joined #instantbird
17:31:09 <instantbot> clokep@gmail.com denied review for attachment 2901 on bug 2180.
17:31:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2180 min, --, ---, aleth, ASSI, this._account socket error on disconnect [regression]
17:31:26 --> Mook_mb has joined #instantbird
17:32:31 <instantbot> clokep@gmail.com requested review from benediktp@ymail.com  for attachment 2277 on bug 1893.
17:32:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1893 enh, --, ---, clokep, ASSI, Use Javascript default parameters where applicable
17:33:02 <instantbot> clokep@gmail.com requested review from aleth@instantbird.o rg for attachment 2887 on bug 2172.
17:33:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2172 nor, --, ---, nobody, NEW, Bubbles: use splitter of the same color as the bubble's borders to separate messages
17:33:57 <clokep_work> I have a feeling some reviews got dropped on the floor there. :)
17:37:33 <Mook_mb> hrm, I don't suppose you guys have anything about a crash on connecting on IRC on thunderbird nightly builds?
17:39:29 <clokep_work> Mook_mb: Not that I know of no, that code hasn't changed in a while.
17:40:30 <instantbot> aleth@instantbird.org denied review for attachment 2887 on bug 2172.
17:40:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2172 nor, --, ---, nobody, NEW, Bubbles: use splitter of the same color as the bubble's borders to separate messages
17:40:36 --> sabret00the has joined #instantbird
17:41:22 <Mook_mb> yeah, didn't think so; plus, you're all JS, so you're not supposed to be able to *crash* anyway :p
17:43:52 <Mook_mb> okay, nevermind; gdb is showing the crash to be somewhere in pulseaudio... and there *was* an update earlier this morning. so I probably just need a reboot.
17:45:16 <clokep_work> :P
17:47:48 <Mook_mb> it does feel a bit silly that I needed to go to gdb to find this out, though... :p
17:54:47 <clokep_work> Yeah, well...
17:54:49 <clokep_work> Poo on you.
17:56:05 <Mook_mb> no, that's tuesdays
17:59:12 --> Mook_as has joined #instantbird
18:00:33 <-- Rym has quit (Ping timeout)
18:03:27 --> Rym has joined #instantbird
18:05:57 <-- Mook_mb has quit (Quit: http://www.mibbit.com ajax IRC Client)
18:05:58 <-- Rym has quit (Ping timeout)
18:06:11 --> Rym has joined #instantbird
18:11:33 <-- Rym has quit (Ping timeout)
18:15:46 --> Rym has joined #instantbird
18:26:06 <-- Rym has quit (Ping timeout)
18:30:13 --> Rym has joined #instantbird
18:31:17 <-- aleth has quit (Quit: Ciao)
18:33:55 <-- Rym has quit (Ping timeout)
18:36:33 --> aleth has joined #instantbird
18:36:33 * ChanServ sets mode +h aleth 
18:37:47 <aleth> clokep_work: If you have any alternative ideas for bug 2180...
18:37:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2180 min, --, ---, aleth, ASSI, this._account socket error on disconnect [regression]
18:37:52 --> Rym has joined #instantbird
18:38:19 <clokep_work> aleth: I don't really...
18:39:01 <clokep_work> aleth: But I'll think on it more.
18:40:37 <aleth> We could throw in the ERROR handler despite there being no error and then move the this._account check to the catch I suppose
18:41:34 <clokep_work> Bleh...
18:41:39 <aleth> Bleh indeed.
18:42:13 <clokep_work> Mook_as: How do I print things out in xpcshell tests again? dump? print? printf? foobarbaz? Components.utils.reportError?
18:43:14 <-- Rym has quit (Ping timeout)
18:44:03 <Mook_as> I think dump should do something, though the xpcshell test driver might hide it from you
18:45:39 <clokep_work> Hm, OK.
18:47:14 <-- aleth has quit (Quit: Ciao)
18:48:12 --> Rym has joined #instantbird
18:53:34 <-- Rym has quit (Ping timeout)
18:57:46 --> Rym has joined #instantbird
18:58:25 <nhnt11> Good evening
19:02:15 <clokep_work> Hello. :)
19:08:09 <instantbot> nhnt11@gmail.com granted review for attachment 2940 on bug 2213.
19:08:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2213 enh, --, ---, aleth, ASSI, Match channels without insisting on the prefix and treat whitespace as AND in the awesometab
19:08:39 <nhnt11> Sorry for the duplicate comment there^ :(
19:11:02 <instantbot> clokep@gmail.com requested review from aleth@instantbird.o rg for attachment 2941 on bug 653.
19:11:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=653 enh, --, ---, clokep, ASSI, Configurable alternate IRC nicks
19:14:29 <clokep_work> Can someone connect to moznet and give me the ISUPPORT strings that are sent?
19:14:35 <clokep_work> nhnt11: Mayb.e...
19:14:49 <nhnt11> Give me a minute
19:15:16 <clokep_work> k
19:16:20 <nhnt11> clokep_work: http://pastebin.instantbird.com/383036
19:16:59 <clokep_work> Thanks. :)
19:21:39 --> qlum has joined #instantbird
19:26:41 * clokep_work figured he'd like at your ISUPPORT bug.
19:28:27 <-- Rym has quit (Ping timeout)
19:32:41 --> Rym has joined #instantbird
19:46:00 --> kkirill has joined #instantbird
19:51:43 <nhnt11> Thanks~!
19:51:43 --> Mic has joined #instantbird
19:51:44 * ChanServ sets mode +h Mic 
19:53:05 * nhnt11 needs to sleep
19:53:08 <nhnt11> Good night
19:53:13 <Mic> Good evening!
19:54:12 --> unghost has joined #instantbird
19:54:25 <clokep_work> Hello Mic. :)
19:57:48 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
20:00:17 <-- Rym has quit (Ping timeout)
20:04:21 --> Rym has joined #instantbird
20:17:22 <-- Rym has quit (Ping timeout)
20:22:47 --> jb has joined #instantbird
20:38:15 <-- jb has quit (Ping timeout)
20:41:23 <-- qheaden has quit (Quit: ZNC - http://znc.in)
20:41:48 <-- kkirill has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
20:41:54 --> kkirill has joined #instantbird
20:43:37 <-- kkirill has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
20:43:44 --> kkirill has joined #instantbird
20:46:03 <-- kkirill has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
20:46:08 --> kkirill has joined #instantbird
20:47:11 <-- kkirill has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
20:47:18 --> kkirill has joined #instantbird
21:05:22 --> flo-retina has joined #instantbird
21:05:22 * ChanServ sets mode +qo flo-retina flo-retina 
21:05:47 <flo-retina> Good evening :)
21:07:41 <clokep_work> Howdy.
21:09:18 <flo-retina> clokep_work: would it be reasonable to allow the alternate nick list to contain the account-name-nick and in that case not add the accountNickname automatically at the beginning of the list?
21:09:51 <flo-retina> (that's obviously a workaround for the lack of ability to rename accounts; so maybe we should fix that instead...)
21:09:58 * flo-retina would like to use flo and drop -retina
21:10:31 <clokep_work> flo-retina: Yeah we should probably check that...and ensure they're all unique...
21:10:32 <flo-retina> thanks for updating that patch btw :)
21:10:36 <clokep_work> Times that I wish I had MATLAB!
21:11:21 <clokep_work> I'm unsure how this would avoid the renaming issue?
21:11:43 <flo-retina> if I list "flo, flo-retina" as alternate nicks, I would get connected as "flo" by default
21:13:27 <clokep_work> Oh, I see what you're saying.
21:13:35 <clokep_work> Hm...we could possibly do that.
21:13:39 <clokep_work> Could it maybe be a follow up?
21:14:01 <flo-retina> if you also want to avoid duplicates, you can do both at the same time
21:14:23 <clokep_work> How so?
21:15:14 <flo-retina> you'll need to have a way to check if the accountNickname is already in the list
21:15:26 <flo-retina> well, you may not get it completely for free, but it will be similar code
21:16:05 <flo-retina> tbh, I'm not completely sure that's a reasonable behavior. But I don't really see how it could hurt anybody, so it may be acceptable (the only obvious downside is that it will kill most of the motivation for implementing account renaming ;))
21:16:17 <flo-retina> but I'm not sure anybody was motivated to fix that bug anyway
21:17:02 <clokep_work> Mook_as: might be. ;)
21:19:01 <Mook_as> nah, just automatically /nick myself these days
21:19:06 <Mook_as> err, I just ...
21:19:44 <flo-retina> clokep_work: so he could be interested in what I'm suggesting too ;)
21:20:04 <clokep_work> I think I taught him to make an extension. :P
21:20:11 <clokep_work> I'd rather we could rename accounts. :-/
21:20:32 <clokep_work> I wonder how much work that would really be though.
21:20:44 <clokep_work> flo-retina: Well it's an interesting idea, I'd really prefer it to be a followup though.
21:21:04 <flo-retina> ok ok
21:24:10 <-- Even has quit (Ping timeout)
21:24:13 --> Even has joined #instantbird
21:24:13 * ChanServ sets mode +o Even 
21:27:21 <clokep_work> :P
21:27:38 <clokep_work> And you're welcome for looking at the patch. ;)
21:27:47 <clokep_work> I had to do something while waiting for you to look at the moz.build stuff. :P
21:29:14 <flo-retina> ah, then I should maybe delay looking at the moz.build stuff until you fix the IRC error I've had in my console for months? ;)
21:31:09 <clokep_work> What error is that?
21:31:35 * clokep_work checks bio
21:32:00 <clokep_work> bug 2134?
21:32:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2134 nor, --, ---, nobody, NEW, Exception... "'TypeError: this._account is undefined' when calling method: [nsIStreamListener::onSto
21:32:10 <flo-retina> no, the SASL one
21:32:37 <clokep_work> The one about trying to identify with flo-retina instead of flo?
21:32:40 <clokep_work> I have no idea how to fix that one.
21:32:52 <flo-retina> Warning: The server does not support SASL PLAIN authentication.
21:32:53 <flo-retina> Source File: resource://gre/modules/ircSASL.jsm Line: 59
21:32:53 <flo-retina> Error: Registration completed before SASL authentication completed.
21:32:53 <flo-retina> Source File: resource://gre/modules/ircSASL.jsm Line: 72
21:33:19 <clokep_work> Ah, is it filed?
21:33:25 <flo-retina> clokep_work: well, making the stuff in the console less misleading would be a good start ;)
21:33:38 <clokep_work> I don't think it's misleading, I think it's a bug.
21:33:52 <flo-retina> but yeah, it's about my account being fqueze, and fqueze being a grouped nick of the fqueze_ group that NickServ knows about
21:34:10 <clokep_work> So bug 1788?
21:34:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1788 nor, --, ---, nobody, NEW, SASL auth fails when using a grouped nick (but not the first of the group)
21:34:19 <flo-retina> so it's quite possible that Ib has no way to guess that NickServ expects fqueze_ for the SASL auth.
21:34:28 <flo-retina> yes, that's the one! :)
21:34:53 <clokep_work> Hm, OK.
21:35:08 <clokep_work> So there's a bug in the erro messages...but I don't think there's any way to identify you then.
21:35:34 <flo-retina> clokep_work: well, the auth succeeds. Just not the SASL one.
21:35:45 <clokep_work> OK. :)
21:42:33 <flo-retina> btw, I've got more stuff than usual in the console today: http://pastebin.instantbird.com/383196 Apparently oftc's got some messages we don't handle.
21:44:25 <clokep_work> That probably just needs a "return true;"
21:46:07 <flo-retina> yeah, these lines don't seem very interesting
21:46:14 <flo-retina> or maybe they should go to the server tab?
21:46:33 <clokep_work> I doubt it, but maybe.
21:46:43 * flo-retina isn't very interested about them
21:47:45 <clokep_work> File a bug and I'll fix it tonight.
21:49:45 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
21:52:09 <flo-retina> done
21:52:24 <instantbot> New Core - IRC bug 2215 filed by florian@instantbird.org.
21:52:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2215 tri, --, ---, nobody, NEW, Warning: Unhandled IRC message 042 and 338 when connecting to oftc.net
22:09:25 <-- kkirill has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
22:16:53 <-- qlum has quit (Quit: Getting the <censored> out.)
22:34:50 <-- mconley has quit (Input/output error)
22:37:47 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/fa948dbd76bf - aleth - Bug 2213 - Match channels without insisting on the prefix and treat whitespace as AND in the awesometab, r=nhnt11.
22:54:27 <instantbot> clokep@gmail.com set the Resolution field on bug 2213 to FIXED.
22:54:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2213 enh, --, 1.5, aleth, RESO FIXED, Match channels without insisting on the prefix and treat whitespace as AND in the awesometab
23:07:35 <instantbot> clokep@gmail.com requested review from aleth@instantbird.o rg for attachment 2942 on bug 2215.
23:07:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2215 tri, --, ---, clokep, ASSI, Warning: Unhandled IRC message 042 and 338 when connecting to oftc.net
23:08:07 <instant-buildbot> build #488 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/488
23:16:53 --> mconley has joined #instantbird
23:52:51 --> EionRobb has joined #instantbird
23:56:40 <-- sabret00the has quit (Ping timeout)
23:57:37 <-- mconley has quit (Input/output error)
23:57:55 <instant-buildbot> build #486 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/486