All times are UTC.
00:24:43 --> luser0 has joined #instantbird 00:24:48 <-- rosonline has quit (Client exited) 00:31:12 <-- luser0 has left #instantbird () 00:44:58 <-- GeekShadow has quit (Ping timeout) 00:45:02 --> GeekShadow has joined #instantbird 00:50:14 <-- Mook_as has quit (Quit: Mook_as) 01:50:20 <-- mconley has quit (Input/output error) 03:14:35 <instant-buildbot> build #997 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/997 03:17:48 <-- wnayes has quit (Quit: wnayes) 03:27:08 --> Mook has joined #instantbird 03:33:12 <instant-buildbot> build #1029 of macosx-nightly-default is complete: Failure [failed shell_3] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/1029 04:43:51 <-- EionRobb has quit (Quit: Leaving.) 04:48:02 --> mconley has joined #instantbird 05:29:42 <-- mconley has quit (Input/output error) 05:52:18 --> mconley has joined #instantbird 05:56:01 --> jb has joined #instantbird 05:57:08 --> jb1 has joined #instantbird 05:57:11 <-- jb has quit (Connection reset by peer) 06:17:40 <-- jb1 has quit (Ping timeout) 06:43:19 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2934 on bug 2131. 06:43:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2131 nor, --, ---, qheaden, ASSI, "Would you like to be my chat buddy" sent on accepting buddy auth request 06:48:41 <-- qheaden has quit (Ping timeout) 06:52:07 --> qheaden has joined #instantbird 07:01:46 <-- Mook has quit (Ping timeout) 07:05:14 --> Mook has joined #instantbird 07:19:11 --> jb has joined #instantbird 07:19:37 <-- jb has quit (Input/output error) 07:20:05 --> jb has joined #instantbird 07:23:32 --> Huvik has joined #instantbird 07:38:34 <-- qheaden has quit (Ping timeout) 07:41:36 <-- jb has quit (Ping timeout) 07:50:35 --> jb has joined #instantbird 07:57:22 <-- mconley has quit (Input/output error) 08:03:39 <instantbot> New Instantbird (UI) bug 2211 filed by benediktp@ymail.com. 08:03:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2211 nor, --, ---, nobody, NEW, Change icon of MUCs in the Awesometab 08:39:26 <-- dew has quit (Connection reset by peer) 09:12:52 <-- jb has quit (Ping timeout) 09:15:29 --> BWMerlin has joined #instantbird 09:16:19 --> jb has joined #instantbird 09:28:04 --> mconley has joined #instantbird 09:33:31 <-- mconley has quit (Ping timeout) 09:40:07 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 10:04:40 --> gerard-majax_ has joined #instantbird 10:07:10 --> flo-retina has joined #instantbird 10:07:10 * ChanServ sets mode +qo flo-retina flo-retina 10:08:39 --> nhnt11 has joined #instantbird 10:15:22 <-- Huvik has quit (Ping timeout) 10:15:51 <-- nhnt11 has quit (Ping timeout) 10:16:41 --> nhnt11 has joined #instantbird 10:20:07 <-- nhnt11 has quit (Ping timeout) 10:20:58 --> nhnt11 has joined #instantbird 10:21:48 <-- jb has quit (Ping timeout) 10:44:43 <flo-retina> aleth: http://log.bezut.info/instantbird/yesterday#m487 that JSON string starting with start:... is from the profiler. 10:45:22 <flo-retina> it would be interesting to know what keeps SymbolicateWorker.js alive after the profiler window is closed. 10:46:35 <flo-retina> bah, if I /stop the profiler, most of that memory is released :) 10:46:49 <-- nhnt11 has quit (Ping timeout) 10:50:49 --> jb has joined #instantbird 10:57:06 <-- jb has quit (Ping timeout) 11:57:55 --> mconley has joined #instantbird 12:00:28 <-- mconley has quit (Ping timeout) 12:30:42 <instantbot> clokep@gmail.com denied review for attachment 2934 on bug 2131. 12:30:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2131 nor, --, ---, qheaden, ASSI, "Would you like to be my chat buddy" sent on accepting buddy auth request 12:34:42 * clokep_work was bored on the plane. ;) (Re https://bugzilla.mozilla.org/show_bug.cgi?id=920801 ) 12:51:23 --> jb has joined #instantbird 12:51:30 <-- BWMerlin has quit (Quit: BWMerlin) 12:53:12 <-- jb has quit (Ping timeout) 13:01:46 * clokep_work wonders if he really needs review on bug 2159 from flo-retina ... 13:01:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2159 nor, --, ---, clokep, ASSI, Port |Bug 884319 - Add http.jsm to toolkit for usage by Thunderbird FileLink, Lightning and Instantb 13:21:07 <flo-retina> clokep_work: rs=me ;) 13:24:29 --> jb has joined #instantbird 13:35:55 <flo-retina> Components.utils.import("resource://gre/libnss3.so"); wow, that would be cool if it generated jsctype bindings for the functions automatically ;) 13:43:59 <flo-retina> "no log viewer in TB" uh :-S 13:44:22 <flo-retina> there's a list of previous conversations at the bottom of the right sidebar 13:58:59 --> Huvik has joined #instantbird 14:22:56 --> mconley has joined #instantbird 14:30:21 <-- mconley has quit (Input/output error) 14:31:38 <-- Huvik has quit (Ping timeout) 14:34:22 --> mconley has joined #instantbird 14:36:12 * mconley is now known as mconley|brb 14:56:06 * mconley|brb is now known as mconley 15:12:34 <-- mconley has quit (Input/output error) 15:29:26 <-- jb has quit (Quit: jb) 15:56:37 --> mconley has joined #instantbird 16:04:03 <clokep_work> flo-retina: But I couldn't find viewlog.js...I don't know what replaced it...and I was on a plane. ;) 16:10:13 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 2913 on bug 2159. 16:10:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2159 nor, --, ---, clokep, ASSI, Port |Bug 884319 - Add http.jsm to toolkit for usage by Thunderbird FileLink, Lightning and Instantb 16:14:45 * clokep_work is happy to get those three patches out of his mq. :) 16:14:46 <instantbot> clokep@gmail.com set the Resolution field on bug 2159 to FIXED. 16:14:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2159 nor, --, 1.5, clokep, RESO FIXED, Port |Bug 884319 - Add http.jsm to toolkit for usage by Thunderbird FileLink, Lightning and Instantb 16:15:26 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/c19d3fe1319c - Patrick Cloke - Bug 898760 - Twitter says connected but shows nothing, r=fqueze. 16:15:27 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/53c58fccae41 - Patrick Cloke - Bug 2159 - Port |Bug 884319 - Add http.jsm to toolkit for usage by Thunderbird FileLink, Lightning and Instantbird|, update YMSG to use new API, r=qheaden. 16:15:28 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/92a186172d7f - Patrick Cloke - Bug 884319 - Add http.jsm to toolkit for usage by Thunderbird FileLink, Lightning and Instantbird, r=fqueze,mconley,philipp. 16:16:53 <flo-retina> would you have some times tonight to discuss what approach we are taking for the configure bug? 16:17:09 <flo-retina> and maybe give me an update about where we are re moz.build stuff, and if I need to help there/how? 16:17:24 <flo-retina> s/times/time/ 16:18:24 <clokep_work> I should be able to have time at some point. 16:18:31 <clokep_work> Soonish might owrk better than tonight. 16:18:51 * flo-retina was hoping to go to the swimming pool. 16:19:20 <clokep_work> I'll be here for another like 7 hours. ;) 16:20:48 <flo-retina> I should be at home and online in 4 hours (or maybe even before) 16:21:17 <clokep_work> Cool. :) 16:21:46 <clokep_work> Down to 39 patches in my queue! :P 16:22:07 <flo-retina> I would be happy to get rid of the configure one on my side ;) 16:26:36 --> aleth has joined #instantbird 16:26:36 * ChanServ sets mode +h aleth 16:26:56 <clokep_work> I'd be happy to get rid of the installer synchronization. :( 16:27:03 <clokep_work> I have no idea how close that is to being finished though. 16:37:00 --> jb has joined #instantbird 16:41:55 <clokep_work> Btw I agree that http://log.bezut.info/instantbird/today/#m70 would be awesome if it just worked 16:46:17 --> Mook_as has joined #instantbird 16:46:24 <instant-buildbot> build #485 of macosx-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/485 16:46:56 <-- aleth has quit (Quit: Ciao) 16:47:03 --> aleth has joined #instantbird 16:47:03 * ChanServ sets mode +h aleth 16:48:00 <clokep_work> DId we recently change the package-manifest? :-S 16:48:24 <clokep_work> Bah.... http://hg.instantbird.org/instantbird/rev/c83097010a4a severely bitrotted one of my patches 16:52:30 <flo-retina> :-P 16:53:51 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 17:03:33 --> qlum has joined #instantbird 17:23:47 <-- gerard-majax_ has quit (Ping timeout) 17:52:34 --> flo-retina has joined #instantbird 17:52:34 * ChanServ sets mode +qo flo-retina flo-retina 18:00:09 <clokep_work> flo-retina: So I just unbitrotted my moz.build patch. 18:05:58 <-- flo-retina has quit (Ping timeout) 18:06:20 --> flo-retina has joined #instantbird 18:06:20 * ChanServ sets mode +qo flo-retina flo-retina 18:06:28 --> gerard-majax_ has joined #instantbird 18:06:46 <flo-retina> the swimming pool was on strike from 7pm to 9pm, stupid them :-/ 18:07:49 <clokep_work> :( 18:07:59 <clokep_work> The lifeguards? I assume the pool itself doesn't go on strike? 18:11:07 <flo-retina> clokep_work: possibly. It was still open for clubs :-S. 18:11:41 <flo-retina> doesn't make much sense to me to close it only for individuals only for 2 hours. 18:12:13 <clokep_work> Oh, that's weird. 18:12:33 <flo-retina> if they wanted to just annoy people, they wouldn't do it any differently ;) 18:12:49 <flo-retina> close just at the time when people with a job can go... 18:13:01 <clokep_work> Haha. 18:13:34 <Mook_as> they probably just wanted people like you to complain (to the management) so they have more bargaining power :p 18:15:05 * flo-retina would happily offer the management more firing power ;) 18:15:24 <clokep_work> flo-retina: So let me know when you want to discuss, I'm going to go eat lunch soon-ish. 18:15:55 <flo-retina> last time there was 30 people waiting in line (even some out of the building!) and the cashier was just wandering around, taking all his time... 18:17:43 <flo-retina> clokep_work: so what's the next step for the moz.build stuff? 18:17:54 <flo-retina> IIRC it was messed up around linking libpurple. Do I need to look. 18:18:09 <flo-retina> For the configure stuff, maybe I should just write a long comment in the bug explaining the possible options 18:19:53 <clokep_work> flo-retina: Yes, I have no idea what to work on. 18:20:16 <clokep_work> The moz.build stuff was having issues where we need the prpls to build before libpurple but linked afterward or something? 18:20:17 <flo-retina> BIO->BMO ? Moz25? 18:20:19 * flo-retina hides 18:20:49 <flo-retina> out of curiosity, have you played with the profiler? :) 18:21:12 <clokep_work> No, I haven't. 18:21:22 <clokep_work> By "I have no idea what to work on" I mean to get moz.build to work. 18:21:28 <clokep_work> Where should I put my updated patch? 18:23:31 <clokep_work> Do we have a moz.build bug? 18:23:32 <flo-retina> isn't there a bug where you had the previous version? 18:23:44 <flo-retina> or have we closed it after deciding it wasn't required for the moz update? 18:23:55 <flo-retina> anyway, nobody will be upset if you file a new one 18:27:27 <clokep_work> K. 18:30:07 <instantbot> New Instantbird (UI) bug 2212 filed by clokep@gmail.com. 18:30:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2212 nor, --, ---, nobody, NEW, Switch to using moz.build 18:31:19 <clokep_work> flo-retina: ^ There you go. ;) 18:31:21 <clokep_work> Have fun. 18:31:26 <flo-retina> thx :) 18:31:28 <flo-retina> bon appétit 18:31:44 <flo-retina> do you know what the next steps are for the BIO->BMO merge? 18:32:25 <clokep_work> Finish writing the script I started. :-/ 18:32:33 <clokep_work> I half lost interest, unfortunately. :( 18:35:05 <clokep_work> I don't know if the script online for that is up to date at all though... 18:35:18 <clokep_work> Most likely we'd want someone with better Python foo or something to look at that instead of me. 18:35:28 <clokep_work> It shouldn't be THAT hard...but I don't write scripts like that that often... 18:39:59 <flo-retina> I expect the hard part to be the motivation 18:40:03 <flo-retina> it looks like tedious work 18:40:27 <flo-retina> did you have ways to test it? 18:41:48 <clokep_work> I was testing it manually and dumping to JSON. 18:42:01 <instantbot> florian@instantbird.org requested feedback from florian@instantbi rd.org for attachment 2935 on bug 2212. 18:42:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2212 nor, --, ---, nobody, NEW, Switch to using moz.build 18:42:14 <flo-retina> any idea of how we could divide that work/make it more fun? 18:44:12 <clokep_work> Make it a game? 18:44:16 <clokep_work> :P 18:45:15 * aleth awards a Manic Merger Badge :P 18:45:28 <clokep_work> I'll be off Monday (apparently...) maybe I can take a look at it again then. 18:45:38 <clokep_work> It'd be more fun to me if we could work on it collaboratively, I think. 18:45:45 <-- jb has quit (Ping timeout) 18:46:31 <aleth> clokep_work: Can you test it by running it with a clean bugzilla instance and seeing if it correctly clones BIO there? 18:46:53 <clokep_work> I don't know. 18:47:02 <clokep_work> I was just going to test it using BIO and the bugzilla test install. 18:47:59 <Mook_as> anything I can help with, especially python-wise? 18:48:08 * Mook_as is also off on monday, thanksgiving 18:48:45 <flo-retina> clokep_work: do you mean we should pair program on it? 18:49:12 <clokep_work> Mook_as: You mean Columbus Day, right? ;) 18:49:20 <clokep_work> Mook_as: It's currently in node.js. 18:49:31 <clokep_work> flo-retina: Or just people submit patches to the partial work that's done now. 18:50:12 <flo-retina> so you need to have something that is at least good enough for it to do "something" 18:50:26 <flo-retina> and then throw it in a repo on bitbucket or somewhere 18:50:33 <clokep_work> Done and done. ;) 18:50:36 <flo-retina> and then we can each add a tiny little thing and send a patch 18:50:37 <clokep_work> ALthough I don't think it's up to date yet. 18:51:05 <flo-retina> and we need a trivial way to test the result 18:51:11 <clokep_work> Yeah. :-/ 18:51:14 <Mook_as> oh. well, I've written some non-node js, if that helps... :p 18:51:22 <clokep_work> Would dumping to an HTML file or something work? 18:51:32 <clokep_work> I always don't know how to handle attachments at all yet, I think that's when I "gave up" 18:53:20 <flo-retina> the part that seems non trivial to me is rewriting automatically all the comment numbers 18:53:53 <flo-retina> what's the problem with attachments? 18:53:56 <clokep_work> I don't think that's bad... 18:54:00 <clokep_work> I can't ifigure out how to get them. 18:54:34 --> wnayes has joined #instantbird 18:58:17 --> Rym has joined #instantbird 19:03:19 <clokep_work> https://bitbucket.org/clokep/bio-bmo-merge is what I have, that doesn't look up to date though. 19:06:01 --> jb has joined #instantbird 19:07:34 --> Rym1 has joined #instantbird 19:08:49 <-- Rym has left #instantbird () 19:09:05 * Rym1 is now known as Rym 19:15:01 <flo-retina> I profiled the jank I have when opening the new conversation tab 19:15:22 <instantbot> aleth@instantbird.org denied review for attachment 2933 on bug 2200. 19:15:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2200 nor, --, ---, nhnt11, ASSI, Use a conversation's statusType for ranking 19:15:39 <aleth> That took longer than expected :-S 19:16:00 <flo-retina> most of the functions are <Anonymou>, and the line numbers don't point to things that make sense 19:18:35 --> nhnt11 has joined #instantbird 19:18:44 --> rosonline has joined #instantbird 19:18:50 <nhnt11> aleth: Thanks for the review 19:19:47 <nhnt11> aleth: I used the canSendMessage at one point while experimenting, but forgot to incorporate it later because I moved some stuff around :( 19:20:03 <aleth> nhnt11: Did you follow the discussion about release dates yesterday? If we decide to release on moz24, we'll have to decide in the next 4-5 days whether to include the awesometab 19:20:34 <nhnt11> Yeah I did see that 19:20:35 <aleth> More importantly, if there are any blocking bugs that would require string changes, they would have to land before then 19:20:45 <aleth> (so the localizers have time to translate) 19:21:15 <aleth> So if you think it is feasible to ship the newtab, make the triage list soon ;) 19:22:35 <nhnt11> Right 19:25:13 <aleth> nhnt11: If you get a new version of bug 2200 up in the next 20 minutes or so, I can probably r+ and we can try it in nightlies 19:25:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2200 nor, --, ---, nhnt11, ASSI, Use a conversation's statusType for ranking 19:26:00 <nhnt11> aleth: Cool :) 19:26:55 <-- jb has quit (Ping timeout) 19:27:44 <nhnt11> aleth: Would you say bug 2208 is important enough to be in the triage list? 19:27:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2208 nor, --, ---, nobody, NEW, Show a notification bar in the awesometab while log sweeping. 19:28:25 <aleth> I'd just dump all the open awesomebugs into an etherpad, then people can add comments/rank them 19:28:46 --> Mic has joined #instantbird 19:28:46 * ChanServ sets mode +h Mic 19:28:52 <nhnt11> Ok 19:29:09 <aleth> I think that bug would be a good thing to have when the awesometab is introduced, as when it is introduced log sweeping will happen for _every_ updating user, but ymmv 19:31:03 <Mic> nhnt11: wait a moment before you upload something new. I'll just put a comment on that bug. 19:31:33 <nhnt11> sure, I haven't started addressing a leth's comments yet. 19:37:32 <nhnt11> I've updated https://etherpad.mozilla.org/instantbird-gsoc-2013-awesometab 19:37:47 <nhnt11> The bugs aren't links unfortunately but I've copied the bug descriptions 19:37:56 <nhnt11> I'm adding "+"s to bugs I think are important for a release 19:38:01 <aleth> Cool, thanks, that's all that's needed :) 19:38:57 <Mic> nhnt11: does the new score calculation intentionally reduce the score for some statuses? 19:38:57 <nhnt11> Also adding "+"s to those that can be fixed easily/have WIPs 19:39:30 <nhnt11> Mic: Yes 19:39:47 <-- wnayes has quit (Quit: wnayes) 19:39:52 <Mic> With the threshold being between idle and mobile? 19:42:16 <nhnt11> Yeah.. 19:42:28 <Mic> OK, then. 19:50:11 <nhnt11> Mic: With that patch, I saw more offline contacts near the top than I'd have liked. Likely a personal preference but perhaps it needs to be a little less lenient with them. 19:50:58 --> EionRobb has joined #instantbird 19:51:02 <instantbot> benediktp@ymail.com denied review for attachment 2933 on bug 2200. 19:51:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2200 nor, --, ---, nhnt11, ASSI, Use a conversation's statusType for ranking 19:51:20 <aleth> I suspect it may look weird if offline contacts are ranked above available or away ones. 19:51:48 <aleth> But we'll see. As long as it doesn't happen for ones I can't actually send messages to, it may make sense. 19:52:13 <Mic> I'd rather have my favourite contacts listed offline at the top than having a bunch of online contacts that I rarely talk to there. 19:52:31 <aleth> ^^ interesting! 19:52:51 <aleth> So in your contact list you have "show offline contacts" activated? 19:52:53 <Mic> Not really. I'm frequently leaving messages for them that need no immediate response. 19:53:16 * nhnt11 rarely uses the buddy list anymore 19:53:25 <aleth> Mic: But that only works for protocols that support it, which was what I meant 19:53:59 <Mic> Yes, I had suggested filtering the ones out that can't be messaged anyways. 19:54:34 <aleth> nhnt11: mission accomplished? ;) 19:55:41 <nhnt11> aleth: On the etherpad? I suppose so :) 19:56:06 <aleth> nhnt11: No, I meant that making the buddy list much less necessary was one of the goals of the project ;) 19:56:09 <Mic> I think he meant that the awesometab seems to work well enough to make you ignore the contact list. 19:56:17 <nhnt11> Ah! 19:56:20 <nhnt11> Definitely yes 19:56:27 <nhnt11> (IMO) 19:57:30 * nhnt11 wants to get a couple smaller bugs out of the way tonight 20:00:20 <nhnt11> aleth: "it's very hard for any contact to compete with a channel as channels are much noisier" - This was one of the reasons for using outgoing to incoming count ratio as a multiplier - it brings channels down a bit, but not if you've participated a lot. 20:00:51 <aleth> OK :) Looking at the output, does the multiplier seem to work for you? 20:01:48 <nhnt11> Yes. With the patch, contacts certainly seem to get more priority, but #instantbird is still first on the list (and is quite often the one I want to open) 20:01:54 <aleth> Cool. 20:02:03 <nhnt11> #chatdev has moved down though 20:02:06 <nhnt11> (which makes sense) 20:02:55 <aleth> That also explains why #maildev is way down for me (I hardly ever say anything there) :) 20:04:18 <nhnt11> I suppose if we boost auto-joined channels, it will likely make it more sensible 20:04:26 <aleth> nhnt11: We don't want to do that 20:04:44 <Mic> I think flo wanted that? 20:04:46 <aleth> (Autojoin is going away, I hope ;) ) 20:04:56 <Mic> aleth++ 20:05:07 <Mic> Restore all the things! ;) 20:05:12 <aleth> nhnt11: The problem with the ratio is that I see channels I join much less often ranked above #maildev simply because when I do join, I am likely to say something, 20:06:00 <nhnt11> Right. But I'm not sure what to do here, because there are likely people who keep conversations on hold for the sake of having context, but rarely want to open them. 20:06:39 <nhnt11> Maybe we need to monitor how many times a conversation is simply opened and factor that in as well 20:08:16 <aleth> It's not the most pressing issue for now anyway. 20:08:37 <aleth> But the answer has to be smarter than just giving autojoined channels a boost ;) 20:08:55 <nhnt11> Right 20:09:01 <Mic> I don't think the message count is a good indicator (for ranking contacts, not chats). 20:10:00 <aleth> I think we should focus on fixing the actual bugs first so that we all see the actual ranking produced by the algorithm rather than bug artifacts before making too many further tweaks. 20:10:00 <clokep_work> nhnt11: Are these weightings tweakable? 20:10:01 <Mic> I think I'd try to look at the first message in every session (the session that starts/ends when opening/closing a chat). 20:10:08 <nhnt11> Why not? It seemed to make sense to me. If the other party does more of the talking, it's more likely he's the usual initiator of the conversation. 20:10:16 <nhnt11> Ah 20:10:25 <Mic> It's either sent by me or by the remote contact. 20:10:25 <nhnt11> Mic: I remember you'd suggested this before :/ 20:10:34 <aleth> Mic: clever :) 20:10:48 <Mic> It might not work for people who close their conversation after every message though :( 20:11:05 <nhnt11> Still though, it doesn't work if you keep the conversation open all the time 20:11:10 <nhnt11> And what Mic just said :P 20:11:11 <aleth> Yeah... 20:11:30 <nhnt11> clokep_work: as of now, these values aren't tweakable 20:12:34 <nhnt11> The only magic constants which we may want to be able to tweak are here: http://lxr.instantbird.org/instantbird/source/instantbird/components/ibConvStatsService.js#551 20:12:43 <nhnt11> These seem to be fine though (as far as I've seen) 20:12:45 <clokep_work> We should make those tweakable. 20:12:59 <aleth> Lets fix the bugs first ;) 20:13:04 <nhnt11> aleth++ 20:13:30 <clokep_work> I'm just saying that if youw ant to get feedback about what people don't like...you'll probably need ot make it so they can modify them. 20:14:15 <aleth> More easily said than done though, it's not just a matter of constants. 20:15:12 <nhnt11> Mic, aleth: I'm not sure if you noticed, but I haven't applied the status biasing to existing convs 20:15:14 <nhnt11> (for contacts) 20:15:22 <nhnt11> (in that patch) 20:15:27 <aleth> Yeah, I saw that. 20:15:51 <Mic> bbl 20:17:04 <nhnt11> The reason: Existing conversations are not as likely to be reopened as an available contact, but are more likely to be reopened than an offline contact 20:17:13 <nhnt11> If we average that out, it results in no status biasing 20:17:24 <aleth> Seems sensible 20:17:32 <nhnt11> I'll add comments 20:18:04 <clokep_work> Mook_as: flo-retina Any ideas? http://pastebin.instantbird.com/381436 20:23:53 <flo-retina> clokep_work: my first idea is to convince you to buy a mac, so that you don't have crazy line wrappings in your build logs :-/ 20:24:20 <flo-retina> clokep_work: isn't it that bug again where we needed to delete .pyc files? 20:24:38 <flo-retina> or even just delete mozilla/xpcom/ and hg up it after that? 20:25:21 <nhnt11> aleth: Should we just filter out contacts who can't receive messages? 20:25:58 <nhnt11> That and filtering convs for offline accounts would likely get rid of bug 2184 too ;) 20:26:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2184 nor, --, ---, nobody, NEW, The list of PossibleConversations shouldn't be duplicated while filtering. 20:26:28 <nhnt11> Seems expensive to do in getFilteredConvs though. 20:27:03 <aleth> Probably too extreme. If I'm searching for a particular person, I'll be surprised if I can't find them at all. 20:27:22 <nhnt11> Yeah 20:27:50 <nhnt11> I kinda want to WONTFIX bug 2116 :-/ 20:27:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2116 nor, --, ---, nhnt11, NEW, Newtab shows contacts for disconnected accounts 20:27:59 <nhnt11> (for the same reason) 20:28:44 <aleth> I'd be OK with that as long as there are no errors when they are selected ;) 20:28:54 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 20:29:01 --> nhnt11 has joined #instantbird 20:29:15 <nhnt11> There aren't. 20:30:50 <instantbot> nhnt11@gmail.com set the Resolution field on bug 2116 to WONTFIX. 20:30:51 <aleth> These are status = unknown, I hope those are right at the bottom then though ;) 20:30:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2116 nor, --, ---, nhnt11, RESO WONTFIX, Newtab shows contacts for disconnected accounts 20:31:00 <nhnt11> Yeah, way at the bottom. 20:31:13 <nhnt11> Er, but not if they're ranked.... 20:31:23 <flo-retina> aleth: unknown + !canSendMessage 20:31:24 <nhnt11> I'd still say WONTFIX though. there's enough negative bias imo 20:31:51 <aleth> flo-retina: Right, exactly the same issue as the offline contacts. 20:32:19 <clokep_work> flo-retina: Trying that now, yes. 20:32:29 <nhnt11> I'm adding a 0.8 multiplier if (!canSendMessage), but I have no way to see how well this works 20:32:40 <nhnt11> I don't have any accounts that don't support offline messaging 20:32:43 <nhnt11> Oh wait IRC 20:32:50 <aleth> IRC doesn't. 20:33:03 <aleth> XMPP supports it. 20:33:17 * nhnt11 has no IRC contacts 20:33:38 <clokep_work> Add one of us. ;) 20:33:39 <Mic> Why would we want contacts in there that you can't start conversations with? 20:34:06 <nhnt11> The only person I PM on IRC is instantbot, really (I ping him to see if I'm pinged out) 20:34:12 <flo-retina> https://etherpad.mozilla.org/instantbird-gsoc-2013-awesometab isn't really readable :-/ 20:34:30 <nhnt11> Mic: http://log.bezut.info/instantbird/131010/#m328 20:34:32 <aleth> nhnt11: The reason to have IRC contacts is to see their presence info ;) 20:35:19 <Mic> Can we rank them really, really low then? 20:35:51 <flo-retina> not sure who's adding empty lines, but that's a good idea :) 20:35:54 <nhnt11> Mic: It's a ~0.4 multiplier, that's pretty low imo 20:35:57 <nhnt11> flo-retina: Me ;) 20:36:41 * flo-retina is confused by this ranking discussion 20:37:13 <Mic> bbl again 20:37:13 <nhnt11> flo-retina: The discussion will only make sense if you've seen/understood the patch on bug 2200 20:37:16 <flo-retina> at this poin, I have no theoretical opinion about how it should work; I think we should just fix bugs, and see what feels wrong 20:37:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2200 nor, --, ---, nhnt11, ASSI, Use a conversation's statusType for ranking 20:37:22 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 20:37:33 * aleth thinks we should let nhnt11 get on with fixing bug 2210 and others ;) 20:37:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2210 nor, --, ---, nobody, NEW, XMPP buddies with changing resource don't get their stats counted correctly 20:37:52 <nhnt11> aleth: I currently don't use IRC that much - if I don't see people in #instantbird, I don't really care about their presence elsewhere :P 20:38:08 <nhnt11> offtopic though 20:38:10 <aleth> By presence I meant available/away 20:38:13 <nhnt11> Oh 20:38:18 <nhnt11> Anyway 20:38:31 <nhnt11> Even if I created IRC contacts now to test this, it likely won't help because I'd have no stats 20:38:52 <nhnt11> so I'll add a 0.8 multiplier, and you guys will have to decide if it's good enough :S 20:39:32 <aleth> nhnt11: As flo suggested, just make offline AND cantSendMessage == unknown 20:39:45 <nhnt11> cool 20:40:00 <nhnt11> Waith what 20:40:01 <nhnt11> wait* 20:40:05 <aleth> or maybe a little bigger... 20:40:10 <nhnt11> Ah 20:40:31 <nhnt11> ==unknown is likely fine 20:40:48 <aleth> I guess unknown really should be right at the bottom 20:41:14 <aleth> Offline at least carries some info ;) 20:42:07 <nhnt11> aleth: So you want to assign a score of 0 if unknown? 20:42:23 <nhnt11> (I guess that makes sense) 20:43:12 <aleth> idk... go with what you think best 20:43:38 <nhnt11> I don't want to just push them to the bottom, because an unknown indicator will at least serve as a reminder that the account is disconnected 20:43:43 <nhnt11> but that may be more of a personal opinion 20:43:49 <flo-retina> aleth: it may be possible to contact a "buddy" with status == unknown. 20:43:50 <aleth> No, sounds reasonable 20:44:00 <flo-retina> for IRC for example, for nicks not in the buddy list yet 20:44:02 <aleth> Not to completely zero out the ranking. 20:44:46 <aleth> flo-retina: Right, good point. 20:45:00 <nhnt11> flo-retina, aleth: So right now, I'm leaning towards just trying out the patch as it is now (with the 0.8 multiplier), and deciding if it needs further tweaking after a day or two of nightlies 20:45:03 <aleth> Not that anyone will notice until bug 2185 ;) 20:45:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2185 nor, --, ---, nobody, NEW, New conversation tabs should display items for buddies that aren't contacts. 20:45:16 <aleth> nhnt11: OK 20:45:16 <flo-retina> aleth: yeah yeah 20:46:46 <nhnt11> aleth: Btw, the first comment you asked me to update doesn't really need updating imo 20:47:21 <aleth> Does it need expanding then? 20:47:24 <nhnt11> (It doesn't talk about ordering based on status) 20:47:27 <nhnt11> That, maybe. 20:47:48 <nhnt11> Actually, I don't think so 20:48:05 <nhnt11> The status related stuff is done in PossibleConversation.computedScore, and I've added comments there 20:48:11 <aleth> OK. 20:48:38 <flo-retina> do you need me to look, or are you guys happy with the progress you are making? 20:49:19 * nhnt11 shrugs (I'm happy with it) 20:49:40 <aleth> Really the only way to tell is to try it out ;) 20:50:01 <aleth> Looks like an improvement. 20:50:03 <flo-retina> if you don't need me I'll poke at bug 2188 again 20:50:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2188 nor, --, ---, nobody, NEW, Port 'Bug 846540 - Emasculate comm-central/configure.in' 20:50:32 * aleth tried the whois nick tooltips, got frustrated 20:52:07 <flo-retina> what was blocking you? 20:52:32 <clokep_work> Hopefully we can get rid of configure.in. :) 20:52:46 <aleth> flo-retina: When a tooltip is triggered, you can by hand openPopup on a different tooltip, but you'd also have to forward all subsequent events, because otherwise the popup never gets closed. 20:53:04 <flo-retina> clokep_work: I think I'm going to propose that we don't for now 20:53:08 <clokep_work> :( 20:53:29 <flo-retina> and just instead do most of the cleanup, but keep the libpurple stuff in configure.in for now 20:53:38 <clokep_work> That's fair enough. 20:54:21 <instantbot> nhnt11@gmail.com cancelled review?(florian@instantbird .org) for attachment 2933 on bug 2200. 20:54:22 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2936 on bug 2200. 20:54:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2200 nor, --, ---, nhnt11, ASSI, Use a conversation's statusType for ranking 20:55:05 <flo-retina> clokep_work: I think the top reason for wanting to do that is that we can do it soon, and that will make the following patches easier to review. 20:55:05 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 20:55:11 --> nhnt11 has joined #instantbird 20:56:14 * nhnt11 wants to merge several of his contacts but... can't. 20:56:20 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 20:56:24 --> nhnt11 has joined #instantbird 20:56:26 <flo-retina> why? 20:56:53 <nhnt11> Contact list doesn't scroll when I'm dragging :/ 20:57:39 <clokep_work> flo-retina: Right. How would the patches be easier then though? What "cleanup" are you talking about? 20:58:03 <aleth> I think Mic filed a bug for that ;) 20:58:24 <flo-retina> clokep_work: I mean that the current patch is 200+kB, and any change included in it is painful to review 20:58:35 <instantbot> aleth@instantbird.org granted review for attachment 2936 on bug 2200. 20:58:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2200 nor, --, ---, nhnt11, ASSI, Use a conversation's statusType for ranking 20:58:49 <flo-retina> so I would prefer it the changes where we produce _new_ code could be in smaller patches 20:58:58 <flo-retina> (the current large patches just moves/ports stuff around) 20:59:13 <clokep_work> OK. 21:00:23 <nhnt11> That's all the time I have tonight, I'm afraid 21:00:34 <nhnt11> Good night. 21:00:43 <nhnt11> XMPP resources will likely be my priority tomorrow. 21:03:38 <clokep_work> :) 21:03:42 <clokep_work> Thanks for the hard work nhnt11 . 21:07:14 <nhnt11> clokep_work: :) 21:10:16 <flo-retina> clokep_work: I just posted a comment in bug 2188 with what I have in mind 21:10:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2188 nor, --, ---, nobody, NEW, Port 'Bug 846540 - Emasculate comm-central/configure.in' 21:10:31 <flo-retina> if we are in agreement, I can try and produce a patch for option 1. tonight 21:10:46 <flo-retina> (assuming there's no unexpected issues with it...) 21:11:56 <clokep_work> flo-retina: I agree that that seems reasonalble. 21:13:02 <aleth> nhnt11: If the user starts IB and log sweeping starts, and then quits IB before it finishes, will it sweep again on the next restart? 21:13:22 <nhnt11> aleth: Yes (the json file won't have been created) 21:13:51 <aleth> Great :) 21:20:00 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died) 21:20:01 --> jb has joined #instantbird 21:20:11 --> chrisccoulson has joined #instantbird 21:21:43 <flo-retina> clokep_work: do add-ons have a configure script? 21:23:33 <-- rosonline has quit (Connection reset by peer) 21:24:47 <-- qlum has quit (Client exited) 21:29:29 <clokep_work> flo-retina: They might be able to...I have no idea. 21:29:52 --> rosonline has joined #instantbird 21:36:26 <-- mconley has quit (Input/output error) 21:37:52 <clokep_work> flo-retina: rkent might now or Mike Kaply. 21:38:33 <clokep_work> We can send out some feelers probably... 21:40:51 <Mook_as> do you mean, add on build systems? 21:42:18 <clokep_work> Yes 21:42:53 <Mook_as> I've heard that at some point pyxpcom was packaged as an addon. 21:42:59 <Mook_as> that does have a configure. 21:58:11 <instantbot> New Instantbird (UI) bug 2213 filed by aleth@instantbird.org. 21:58:12 <instantbot> aleth@instantbird.org requested review from nhnt11@gmail.com for attachment 2937 on bug 2213. 21:58:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2213 enh, --, ---, nobody, NEW, Allow searching for IRC channels without typing the prefix 22:00:07 <nhnt11> aleth: What about IRC channels with two #'s? 22:00:37 <aleth> They are being weird on purpose ;) 22:00:39 <nhnt11> (read: Is name.substring(1) really the best way to do this?) 22:00:54 <aleth> That's what I was asking in the comment ;) 22:01:29 <nhnt11> Er, I saw the bug before that comment got added. 22:01:42 <nhnt11> Other than that, the patch seems fine, thanks! 22:01:45 <aleth> What I want to avoid is getting the full channel prefix list from IRC, as the protocol has no API for that. So the alternative is hardcoding a # 22:02:12 <aleth> Hmm, that's probably the best thing to do actually. 22:02:15 <nhnt11> aleth: What about trimming off all special characters from the beginning of the name? 22:02:36 <aleth> nhnt11: Good idea, but I'd like to get rid of the regex ;) 22:03:10 <aleth> I think I'll do something like that though. 22:03:40 <nhnt11> That would help with the odd case that a contact name starts with a special char too ;) 22:03:55 <Mook_as> it's probably useful to look around chatzilla's source and see what they do :p 22:04:03 <Mook_as> (I think Silver spent a bit of time on it) 22:04:25 <clokep_work> On what? 22:04:30 <aleth> Mook_as: This isn't at the protocol level, where we handle it correctly. 22:04:39 <Mook_as> ah, okay 22:04:43 <nhnt11> Mook_as: Seeing as chatzilla is specifically an IRC client, they probably don't have thsi problem 22:05:08 <Mook_as> yeah, but I thought only IRC had strange prefixes 22:05:16 <Mook_as> (twitter... sort of does something?) 22:05:19 <aleth> This is strictly a workaround until better search is implemented (which won't happen for 1.5) ;) 22:05:44 <aleth> Mook_as: Technically the @ in twitter isn't part of the username. 22:05:45 <nhnt11> Yeah, but considering that they only care about IRC, it would be OK to hardcode it (or something) ;) 22:06:18 <aleth> nhnt11: There are other possible channel prefixes than #, it depends on the server 22:06:35 <nhnt11> aleth: They're all defined in the RFC though IIRC? 22:06:55 <Mook_as> for IRC, RFCs are more advisory :p 22:07:03 <aleth> lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#821 22:07:17 <clokep_work> aleth: That can be overridden via ISUPPORT. 22:07:31 <aleth> clokep_work: I was about to paste http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/ircISUPPORT.jsm#141 ;) 22:07:44 <nhnt11> Bah 22:08:41 <clokep_work> Ignoring starting special characters seems reasonable. 22:09:03 <aleth> flo-retina: I didn't do word boundaries as I wanted to get rid of the regex altogether 22:09:56 <flo-retina> aleth: I misread the patch 22:10:11 <instantbot> benediktp@ymail.com granted review for attachment 2936 on bug 2200. 22:10:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2200 nor, --, ---, nhnt11, ASSI, Use a conversation's statusType for ranking 22:10:24 <flo-retina> aleth: what's the point of getting rid of the regexp? 22:10:32 <instantbot> aleth@instantbird.org denied review for attachment 2937 on bug 2213. 22:10:32 <aleth> flo-retina: speed 22:10:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2213 enh, --, ---, nobody, NEW, Allow searching for IRC channels without typing the prefix 22:10:54 <flo-retina> real or fantasized speed? 22:12:15 <aleth> heh. I guess I can profile that now :) 22:14:17 <-- jb has quit (Quit: jb) 22:15:04 <flo-retina> I wouldn't be surprised if the regexp was faster than the .som call 22:15:07 <flo-retina> *.some 22:15:41 <nhnt11> flo-retina: Well the .some call was already there so... 22:16:58 * nhnt11 wonders if we should just use indexOf 22:17:00 <aleth> I mainly removed the regex because I didn't think it was likely for user names to contain tabs or line breaks ;) 22:17:56 <nhnt11> Uh, name.contains(aFilterStr) rather 22:18:10 <flo-retina> wouldn't that be slower? 22:18:24 <-- aleth has quit (Quit: Ciao) 22:18:53 <nhnt11> I don't know. Depends on if split() is faster. 22:18:53 <flo-retina> indexof/contains is likely more expensive than just startsWith 22:19:08 <clokep_work> It is almost definitely. 22:19:11 <nhnt11> Er, we check startsWith first, and then contains? 22:19:22 <clokep_work> That's probably even more expensive. 22:19:33 <clokep_work> Since contains probably essentially first calls startsWith. ;) 22:19:33 <nhnt11> How come split() is fast? 22:19:45 <nhnt11> I would think avoiding a split() is good. 22:19:50 <flo-retina> to ensure we pay the cost of both? :-P 22:20:30 * flo-retina thinks this pseudo-performance discussion doesn't make any sense 22:20:39 <nhnt11> flo-retina: ++ 22:21:03 * clokep_work thinks someone should profile things. ;) 22:21:13 <EionRobb> worst idea ever 22:21:20 <flo-retina> clokep_work: if it takes less than 1% of the profile, it's irrelevant 22:21:24 <EionRobb> talk about code until its fast 22:21:35 <flo-retina> EionRobb: transfer files until the code is fast ;) 22:21:51 <EionRobb> \o/ 22:22:07 <flo-retina> clokep_work: we should just decide which behavior we want, then implement it, and then fix the perf issues; which almost definitely are somewhere else 22:25:14 <clokep_work> flo-retina: I agree! 22:25:32 <EionRobb> code now, fix later 22:46:58 <clokep_work> Code now, eat later? 22:47:21 <EionRobb> coffee now 22:47:27 <EionRobb> coffee later 22:50:37 <-- Rym has quit (Ping timeout) 22:52:31 <clokep_work> COFFEE 22:54:01 --> Rym has joined #instantbird 23:06:04 <-- rosonline has quit (Client exited) 23:21:54 --> mconley has joined #instantbird 23:24:25 <-- mconley has quit (Input/output error) 23:32:04 <clokep_work> flo-retina: Btw that seems to ahve fixed my build, thanks. :) 23:32:49 <flo-retina> cool :) 23:39:45 <clokep_work> I'm building media now, so...that's most of the way done, I think. 23:49:08 --> qheaden has joined #instantbird 23:49:39 <qheaden> Hello. 23:50:30 <clokep_work> Hello qheaden . 23:53:50 <qheaden> clokep_work: So for bug 2131, you want me to just add a comment explaining why it is empty? 23:53:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2131 nor, --, ---, qheaden, ASSI, "Would you like to be my chat buddy" sent on accepting buddy auth request 23:58:41 <instant-buildbot> build #483 of linux-onCommit is complete: Failure [failed shell_1] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/483 blamelist: Patrick Cloke <clokep@gmail.com> 23:59:46 <clokep_work> qheaden: Yes. :P