#instantbird log on 09 25 2013

All times are UTC.

00:20:31 <flo-retina> clokep: can you handle the checkin-needed queue?
00:21:40 <clokep> flo-retina: Sure can.
00:22:45 <flo-retina> thanks! :)
00:26:32 <clokep> flo-retina: In bug 2147, aleth's alternative patch is the one to check in?
00:26:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2147 nor, --, ---, nobody, NEW, Bubbles' last message sometimes doesn't auto-scroll
00:33:59 <instantbot> clokep@gmail.com set the Resolution field on bug 2102 to FIXED.
00:34:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2102 nor, --, 1.5, qheaden, RESO FIXED, Support Server Pings
00:34:19 <instantbot> clokep@gmail.com set the Resolution field on bug 2182 to FIXED.
00:34:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2182 nor, --, 1.5, nhnt11, RESO FIXED, Include LIST results in awesome-tab by default
00:35:01 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/e6e6695dd686 - aleth - Bug 2147 - Bubbles' last message sometimes doesn't auto-scroll, r=fqueze.
00:35:02 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/36fb242a9db3 - Nihanth Subramanya - Bug 2182 - Include LIST results in awesome-tab by default, r=Mic.
00:35:03 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/6b1fa55e89a3 - Quentin Headen - Bug 2102 - JS-Yahoo: Support Server Pings, r=clokep.
00:37:12 <instant-buildbot> build #460 of win32-onCommit is complete: Failure [failed compile]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/460  blamelist: Quentin Headen <qheaden@phaseshiftsoftware.com>, Nihanth Subramanya <nhnt11@gmail.com>, aleth <aleth@instantbird.org>
00:37:55 <clokep> Yay!
00:40:08 <-- mconley has quit (Input/output error)
00:52:03 <qheaden> Hey clokep.
00:52:18 <clokep> Hello qheaden.
00:52:59 <qheaden> clokep: I sent out an email (you were on the CC list) of my wrap up blog.
00:53:11 <clokep> qheaden: I replied to your email. ;
00:53:12 <clokep> ;)
00:53:18 * qheaden goes to check
00:54:40 <qheaden> Thanks again for all of the experience I gained this summer. :)
00:59:47 <clokep> Of course! Thanks for all the hard work you've put in! :)
00:59:48 <instant-buildbot> build #470 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/470
01:02:28 --> rosonline has joined #instantbird
01:03:07 <qheaden> It's been a long day. I'm going to head in and start fresh tomorrow. I want to get some more stuff fixed.
01:04:25 <clokep> :) Goodnight.
01:05:19 <qheaden> Goodnight.
01:07:48 <instant-buildbot> build #469 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/469
01:10:14 --> mconley has joined #instantbird
01:19:21 <-- Mook_as has quit (Quit: Mook_as)
01:38:25 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
02:23:59 --> Mook has joined #instantbird
02:30:12 <-- rosonline has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com)
03:10:34 --> skeledrew has joined #instantbird
03:14:25 <-- mconley has quit (Input/output error)
03:19:11 <instant-buildbot> build #981 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/981
03:31:42 --> dionisos has joined #instantbird
03:36:21 <instant-buildbot> build #1004 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/1004
04:06:02 <-- wnayes has quit (Quit: wnayes)
04:19:39 <-- dionisos has quit (Ping timeout)
05:22:58 --> FireFly_TB has joined #instantbird
05:43:36 <-- Mook has quit (Quit: Mook)
05:51:00 <-- FireFly_TB has quit (Ping timeout)
05:53:05 --> BWMerlin has joined #instantbird
06:06:13 <-- EionRobb has quit (Quit: Leaving.)
06:24:36 --> FireFly_TB has joined #instantbird
06:55:09 <instant-buildbot> build #1100 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1100
06:59:42 --> EionRobb has joined #instantbird
08:14:38 --> Mic has joined #instantbird
08:14:38 * ChanServ sets mode +h Mic 
08:22:22 <-- sabret00the has quit (Ping timeout)
08:22:48 <Mic> Hello!
08:25:06 <-- gerard-majax has quit (Ping timeout)
08:34:55 --> nhnt11 has joined #instantbird
08:35:25 <nhnt11> Hi
08:37:18 <Mic> Hello!
08:38:48 --> sabret00the has joined #instantbird
08:49:43 <nhnt11> Mic: http://log.bezut.info/instantbird/yesterday/#m129 - is that ok with you?
08:55:17 --> gerard-majax has joined #instantbird
08:55:35 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
08:55:39 --> nhnt11 has joined #instantbird
09:10:29 --> dionisos has joined #instantbird
09:25:13 <-- nhnt11 has quit (Ping timeout)
09:34:40 --> nhnt11 has joined #instantbird
09:34:51 * nhnt11 is now known as nhnt11_class
09:48:26 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
10:10:55 <Mic> nhnt11_class: yes, that's fine with me. You don't need to wait until then to write it of course, you can just delay publishing it...
10:11:09 <nhnt11_class> Right
10:11:45 <Mic> Most likely you're going to include screenhots of the result as you have a nice UI to show off? ;)
10:12:14 <Mic> Screenshots are tedious because you think you're done and need to start over again because a minor detail is wrong ;)
10:14:12 <nhnt11_class> :P
10:14:59 <nhnt11_class> The problem with screenshots for ranking is that they won't really convey that frecent contacts are shown first
10:15:19 <nhnt11_class> Just by looking at it (with no caption) it may appear to be a random order to a 3rd person..
10:15:49 <Mic> You'll need to label the figure then ;)
10:16:29 * nhnt11_class just thought about it and realized how "long" the summer really was
10:20:00 --> flo-retina has joined #instantbird
10:20:00 * ChanServ sets mode +qo flo-retina flo-retina 
10:24:20 <-- nhnt11_class has quit (Ping timeout)
10:24:31 --> jb has joined #instantbird
10:40:19 <-- EionRobb has quit (Connection reset by peer)
10:40:38 <Mic> bye!
10:40:53 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
10:44:15 <flo-retina> was the summer really that long?
10:49:58 <-- sabret00the has quit (Quit: Leaving)
10:51:10 --> nhnt11_phone has joined #instantbird
10:51:31 <nhnt11_phone> flo-retina: considering all the code I got to tinker with...
10:51:46 <nhnt11_phone> For example the tabbrowser patch seems ages ago
10:53:26 <-- nhnt11_phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
11:03:09 <-- dew has quit (Ping timeout)
11:03:42 --> dew has joined #instantbird
11:03:56 --> nhnt11_class has joined #instantbird
11:16:44 --> clokep has joined #instantbird
11:16:44 * ChanServ sets mode +o clokep 
11:17:30 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
11:17:48 --> clokep has joined #instantbird
11:17:48 * ChanServ sets mode +o clokep 
11:20:22 <-- jb has quit (Ping timeout)
11:20:24 <-- nhnt11_class has quit (Ping timeout)
11:20:47 --> novabyte has joined #instantbird
11:24:20 --> jb has joined #instantbird
11:25:48 <flo-retina> nhnt11_phone: a patch checked in 2 days ago seems ages ago too if we have already played with it in yesterday's nightly (ie the feature is no longer new) and we don't have any regression to fix. ;)
11:27:20 --> nhnt11_class has joined #instantbird
11:34:41 <-- novabyte has quit (Quit: bye bye)
11:39:43 <-- nhnt11_class has quit (Ping timeout)
11:42:51 --> nhnt11_class has joined #instantbird
11:46:25 <-- nhnt11_class has quit (Ping timeout)
11:49:05 <clokep> flo-retina: http://pastebin.instantbird.com/360498 is the error I'm getting.
11:51:45 * clokep actually has no idea what could be causing that. :(
11:52:48 --> nhnt11 has joined #instantbird
12:11:20 <-- BWMerlin has quit (Quit: BWMerlin)
12:35:51 <flo-retina> "Missing files: c:/Users/clokep/instantbird/instantbird/test/xpcshell.ini\xpcshell.ini" ?
12:36:44 <clokep> Yeah, that seems weird.
12:37:17 <-- FireFly_TB has quit (Quit: FireFly_TB)
12:37:31 --> FireFly_TB has joined #instantbird
12:37:47 <flo-retina> clokep: is that when building or when doing make checks?
12:37:57 <clokep> flo-retina: Building, I believe.
12:40:10 <flo-retina> if you --disable-tests, does the build pass? ;)
12:41:28 <clokep> That would mean I'd have to reconfigure / build from scratch to change that?
12:42:18 --> mconley has joined #instantbird
12:42:24 --> philz has joined #instantbird
12:45:24 <philz> salut tt le monde, certains d'entre vous utilisent-ils instantbird uniquement en réseau local ? (pas d'accès extérieur)
12:46:07 <clokep> philz: Do you speak English?
12:46:38 <clokep> Ah, flo-retina speaks French.
12:47:05 <philz> ce serait plus simple en french si tu speak aussi !
12:47:34 <flo-retina> philz: C'est plus simple en anglais car tout le monde comprends. Mais s'il y a des choses que tu as vraiment du mal à exprimer en anglais, je peux aider à traduire.
12:47:58 <philz> ok je comprends
12:48:48 <flo-retina> clokep: philz's question was "Are any of you using Instantbird in a local network without internet access?"
12:48:57 <philz> Donc : did some of you try tu use instantbird only in lan mode ? (no external communications)
12:49:27 <philz> sorry, i have to leave office now... i'll come here later, sorry
12:49:39 <flo-retina> philz: I don't think any of us have tried; but I see no reason why it wouldn't work.
12:49:57 * clokep wonders if philz means Bonjour?
13:05:11 <-- nhnt11 has quit (Ping timeout)
13:29:18 --> nhnt11 has joined #instantbird
13:30:45 <-- mconley has quit (Input/output error)
13:31:51 <philz> hello, i'm back
13:33:34 <clokep> Hello.
13:33:41 <philz> i have some questions about this lan configuration for example : do users have to own an account on an external server (msn, google, facebook, ...)
13:34:41 <clokep> If you can't hit the external server you can't use that network, but you could set up a server (XMPP or IRC, most likely) and use that on a LAN.
13:34:55 <clokep> There's also Bonjour which automatically finds other users on the LAN, etc.
13:36:26 <philz> I heard about bonjour, but i don't know much about apple tools. Have to learn...
13:36:58 <clokep> The protocol isn't from Apple, but on Mac and Windows you have to install the Bonjour toolkit.
13:37:34 <clokep> nhnt11, flo-retina: If you get a message on a tab that is overflown from the currently viewable tabs...are the arrows supposed to flash or something.
13:38:28 <nhnt11> Hmm
13:39:06 <philz> thanks clokep, i'll try this. bye
13:39:23 <nhnt11> clokep: Was that previous behavior (that isn't working anymore), or are you suggesting that it would be nice to have?
13:39:47 <clokep> I don't ever remember if we had that.
13:39:56 <nhnt11> ok
13:40:19 <clokep> I used to always use Vertical Tabs and never had this issue...
14:03:41 <-- philz has quit (Quit: http://www.mibbit.com ajax IRC Client)
14:09:45 --> mconley has joined #instantbird
14:19:09 --> philz has joined #instantbird
14:26:15 <flo-retina> clokep: the arrow flashes when a new tab opens.
14:26:54 <flo-retina> I think we should make it flash whenever a new message arrives instead (or maybe even keep the blue-ish outline on the icon until the message is read)
14:27:02 <flo-retina> (there's a bug on file for that)
14:27:04 <clokep> flo-retina: +1
14:31:56 <flo-retina> clokep: wasn't our assumption about that email that there's something specific to HipChat?
14:34:41 <-- philz has quit (Quit: http://www.mibbit.com ajax IRC Client)
14:34:55 --> philz has joined #instantbird
14:36:27 <clokep> flo-retina: I don't think so.
14:37:30 * clokep thinks we'd need debug stuff anyway. ;)
14:39:31 <-- philz has left #instantbird ()
14:41:41 <flo-retina> clokep: definitely! :)
14:41:59 <flo-retina> clokep: if you need help with that moz24 update, feel free to put in a bug what you already have :)
14:42:02 <clokep> flo-retina: So any ideas on the Moz24 upgrade? I'm not even sure where to start?
14:42:05 <clokep> Hahah.
14:42:39 <flo-retina> do you know where to start now? :)
14:43:36 <clokep> Attached to bug 2033.
14:43:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2033 nor, --, ---, clokep, ASSI, Update to Mozilla 24
14:45:58 * nhnt11 is running into some normalizedName stuff
14:46:20 <nhnt11> When using the name of a prplIConvChat, I should be using the normalizedName right?
14:46:38 * nhnt11 has been thinking hard about how this will match up against what prplIRoomInfo is using
14:47:12 <flo-retina> normalizedName discussion? Time to hide!
14:47:21 * clokep hides.
14:48:27 <-- dionisos has quit (Ping timeout)
14:49:11 <nhnt11> >:(
14:49:35 * nhnt11 finds clokep and flo-retina and pokes them with a stick
14:49:53 <nhnt11> flo-retina: Should I add a normalizedName attribute to prplIRoomInfo?
14:50:14 <nhnt11> clokep: Should I be doing this.normalize on the name of the irc channel when creating an ircRoomInfo?
14:50:33 <clokep> No.
14:50:33 <nhnt11> Hmm, or should I just be using prplIConversation.name
14:50:39 <nhnt11> and not worry about the normalizing stuff
14:50:41 <clokep> That shuld be handled at the prpl level, I think.
14:51:02 <nhnt11> clokep: I just asked if I should be doing it at the prpl level (in ircBase)
14:51:19 <clokep> Why do you need to pre-normalize it?
14:51:25 <clokep> I'm really confused at what you're trying to do.
14:51:30 <nhnt11> Er, ok
14:51:30 <nhnt11> context.
14:51:34 <flo-retina> clokep: I'll try and look into this tonight
14:51:40 <clokep> flo-retina: Thanks. :)
14:51:48 <nhnt11> The stats service stores chats by account id and name
14:51:50 <clokep> I won't be able to do any more moz24 stuff until I'm back home (i.e. at the Summit).
14:51:53 <flo-retina> if it looks like I'm starting to hack on something else, feel free to remind me :).
14:52:01 <nhnt11> the name is currently unnormalized.
14:52:14 <clokep> nhnt11: OK, why would it need to be normalized? That's what I'm not understanding.
14:52:15 <nhnt11> I need to obtain the PossibleChat corresponding to a prplIConversation
14:52:28 <flo-retina> (I would also really want to finish that CSS patch I started Monday and continued yesterday; but I can hack CSS while the macbook is compiling :))
14:52:48 <clokep> :)
14:52:50 <flo-retina> nhnt11: ">:(" I didn't know we had that emoticon :)
14:53:04 <nhnt11> clokep: er, that's why I asked if I should just use prplIConversation.name and forget about normalization
14:53:32 <clokep> nhnt11: I don't see why you'd have to normalize it.
14:53:36 <nhnt11> alright
14:53:43 <clokep> I don't see what that would gain you (besides probably showing the wrong capitalization in the awesometab)
14:53:57 <nhnt11> clokep: The awesometab wouldn't use the normalized name in UI
14:54:22 <nhnt11> I was wondering if, when mapping stuff by name, I should be using normalizedName for any particular reason
14:54:33 <flo-retina> clokep: "I'm really confused at what you're trying to do." exactly what I was going to say after reading the scrollback :-S.
14:54:37 <nhnt11> (so I guess not)
14:55:21 <flo-retina> clokep: "I won't be able to do any more moz24 stuff" do you mean won't be able to work on it/test stuff, or won't be able to look at all (like to discuss some of it/review patches)?
14:55:34 <nhnt11> I guess I"m just worrying about a non-existent issue
14:56:14 <flo-retina> nhnt11: so what are you _actually_ trying to do?
14:56:50 <nhnt11> flo-retina: When there's a new text, add the PossibleConversation corresponding to the prplIConversation to a list of convs to be repositioned
14:56:56 <nhnt11> (when a new observer is added)
14:57:49 <nhnt11> Since I have all the chats mapped out by account id and name, I was wondering about whether the name of a RoomInfo object and prplIConversation.name would match up.
14:58:05 <nhnt11> bah
14:58:10 <nhnt11> like I said, non existent issue
14:58:28 <nhnt11> (sorry for confusing you :P)
14:59:41 <clokep> flo-retina: Test stuff.
15:01:28 * nhnt11 got an email reminding him to fill out his evaluation form
15:01:32 <nhnt11> I better do that now..
15:01:56 <flo-retina> nhnt11: so you are trying to find the existing RoomInfo object for an active conversation?
15:02:07 <nhnt11> flo-retina: I'm trying to find the existing PossibleChat
15:09:06 --> Mic has joined #instantbird
15:09:06 * ChanServ sets mode +h Mic 
15:20:15 <nhnt11> flo-retina, Mic: To avoid caching the total stats of a contact before logs have been fully swept/JSON cache has been read, I'm keeping the gStatsByContactId cache uninitialized, and initializing it right after gStatsByConvId is ready (and doing a null check on gStatsbyContactId wherever it's used). Does this seem reasonable?
15:20:25 * nhnt11 has been delaying this patch because he isn't quite happy with it
15:20:34 <nhnt11> I'm going to upload what I have now and get some feedback
15:20:52 --> dionisos has joined #instantbird
15:21:04 <flo-retina> nhnt11: does that mean there's no stats at all if the user opens the awesometab before the log sweep is finished?
15:21:22 <nhnt11> flo-retina: No, it just means that the cumulative stats for a contact aren't cached.
15:21:35 <nhnt11> i.e. the sum of the buddies' stats is computed every time
15:27:58 <flo-retina> ok
15:28:08 <flo-retina> I guess it will make sense when reading the patch :)
15:28:20 <nhnt11> ok
15:40:19 --> wnayes has joined #instantbird
15:45:22 <-- FireFly_TB has quit (Ping timeout)
16:26:59 <nhnt11> Bah!
16:27:20 <nhnt11> I was trying to code up aleth's suggestion of having a "switch" in PossibleConveresation that would turn it into an existing conv
16:27:24 <nhnt11> Conversation*
16:27:49 <nhnt11> Now I realize this doesn't work when the new UI conversation isn't already in the list of convs
16:28:22 <nhnt11> I could just create a new ExistingConversation for these and insert it
16:28:47 <nhnt11> But then removing them later isn't straightforward
16:28:52 <nhnt11> complication after complication...
16:33:24 <nhnt11> I'm discarding this idea for now.. nothing I can think of seems like a good solution
16:33:54 <-- gerard-majax has quit (Ping timeout)
16:34:10 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
16:42:23 <-- dionisos has quit (Ping timeout)
16:44:30 --> Mook_as has joined #instantbird
16:52:14 --> aleth has joined #instantbird
16:52:14 * ChanServ sets mode +h aleth 
16:59:58 <aleth> "<nhnt11> Now I realize this doesn't work when the new UI conversation isn't already in the list of convs" When the conversation is opened, isn't a stats object generated for it?
17:00:14 <nhnt11> aleth: A stats object, yes, but not a PossibleConversation
17:00:27 <aleth> Ah yeah.
17:00:47 <aleth> Good point.
17:02:42 <aleth> Hmm, how we can have an object with stats that isn't also a possible conversation?
17:02:55 <aleth> If we have talked to someone in the past, they should be in the awesometab
17:03:12 --> qlum has joined #instantbird
17:03:22 <nhnt11> aleth: right, but that hasn't been implemented yet :-/
17:04:20 <aleth> So you're saying "this would work if we implemented what we planned to implement anyway"? ;)
17:04:42 <aleth> Maybe it's followup territory, idk how you intend to split the patches
17:05:03 <nhnt11> I would say a followup
17:05:23 <nhnt11> I'd rather have bug 2143 land, it'll give me some sense of completion :P
17:05:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2143 enh, --, ---, nhnt11, NEW, Stats service should maintain statistical data for conversations and use it for sorting.
17:06:00 <aleth> It'd be good to land that soon, yes :)
17:06:07 <aleth> As long as you file the followups so you don't forget them ;)
17:06:11 <-- qlum has quit (Quit: Getting the <censored> out.)
17:06:18 --> qlum has joined #instantbird
17:13:53 <-- jb has quit (Ping timeout)
17:16:33 <-- aleth has quit (Quit: Ciao)
17:16:38 --> aleth has joined #instantbird
17:16:38 * ChanServ sets mode +h aleth 
17:19:17 <-- Tonnes has quit (Connection reset by peer)
17:30:14 --> flo-retina has joined #instantbird
17:30:14 * ChanServ sets mode +qo flo-retina flo-retina 
17:30:41 <flo-retina> has anybody who hadn't pref'ed on auto list yet noticed anything interesting in today's nightly? :)
17:35:02 --> rosonline has joined #instantbird
17:39:14 <clokep> My new conversation tab doesn't work. :( Does that conut?
17:39:20 <nhnt11> :O
17:39:22 <nhnt11> why not
17:39:24 <clokep> I'm also out of date though.
17:39:39 <clokep> nhnt11: http://pastebin.instantbird.com/360909
17:41:17 * nhnt11 scratches his head
17:47:52 <Mic> clokep: do you have any steps to reproduce?
17:49:28 --> nhnt11-testing has joined #instantbird
17:50:25 <-- nhnt11-testing has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:50:48 --> nhnt11-testing has joined #instantbird
17:51:38 <clokep> Mic: No.
17:51:54 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:52:08 --> clokep has joined #instantbird
17:52:08 * ChanServ sets mode +o clokep 
17:52:22 <-- nhnt11-testing has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:52:37 <clokep> Worked after a restart & update.
17:56:19 <nhnt11> aleth: Btw - "This should be just a message or a warning, as everyone will get to see it at least once, and it's not an error ;)" That's why there's a !aError.becauseNoSuchFile check ;)
17:56:51 <aleth> nhnt11: Aha, I missed the ! :D
17:57:09 * nhnt11 meant to reply to that a long time ago
17:59:26 <nhnt11> aleth: So I guess the convs.slice(0) can't really be gotten rid of
17:59:28 <nhnt11> (easily)
18:03:32 <aleth> Do you have a roadmap to a point where you can get rid of it (maybe after some followups)?
18:03:45 <instantbot> nhnt11@gmail.com cancelled review?(florian@instantbird .org) for attachment 2894 on bug 2143.
18:03:46 <instantbot> nhnt11@gmail.com requested review from florian@instantbird .org for attachment 2904 on bug 2143.
18:03:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2143 enh, --, ---, nhnt11, NEW, Stats service should maintain statistical data for conversations and use it for sorting.
18:04:06 <aleth> Making a copy of the _entire_ data just to be able fo filter entries is just wrong.
18:06:03 <nhnt11> aleth: The alternative I can think of (that would work at this point) would be to replace PossibleConversations with ExistingConversations as they are opened, and keep a map of ExistingConversation->PossibleConversation which will be used to replace the existingConv with the PossibleConv again when the conversation is closed.
18:07:05 <nhnt11> That would cause problems when contacts are removed while a conv was opened with them for example
18:07:29 <nhnt11> (Because _removeContact would then need to filter the map as well)
18:07:32 <Mic> Would that also fix bug 2181 by the way?
18:07:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2181 nor, --, ---, nobody, NEW, Error when choosing a non longer existing conversation in the awesome-tab
18:08:22 <aleth> nhnt11: it's not worth doing if you intend to do something along the lines of the followup we discussed earlier anyway?
18:08:25 <nhnt11> Mic: I don't think so.
18:08:33 <nhnt11> aleth: Possibly, yeah.
18:08:43 <aleth> If you disliked that idea for other reasons, then maybe
18:09:01 <aleth> It sounds a bit hackish to me too.
18:09:47 <nhnt11> Mic: That bug likely just needs the stats service to send an "update" notification when a conv is closed
18:10:11 <nhnt11> Seems a bit wasteful though just for one conversation to switch... there's no other "trivial" fix though.
18:11:20 <nhnt11> I have to go
18:11:24 <nhnt11> Good night.
18:16:36 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
18:16:47 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
18:16:55 <flo-retina> clokep: I wonder if the error message you pastebined could be a variation of bug 2181
18:16:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2181 nor, --, ---, nobody, NEW, Error when choosing a non longer existing conversation in the awesome-tab
18:17:13 <clokep> Maybe.
18:56:17 --> Hayfever76 has joined #instantbird
18:57:06 <-- wnayes has quit (Quit: wnayes)
18:57:31 <Hayfever76> Patrick, are you about?
18:58:53 <aleth> clokep ^^
18:59:04 <Hayfever76> thanks very!
18:59:18 <clokep> Hayfever76: Hello.
19:00:01 <clokep> Hayfever76: Any chance we can talk in here?
19:00:08 <clokep> Unless it's actually private. :)
19:00:24 --> dionisos has joined #instantbird
19:01:08 <Hayfever76> Sure thing. I'm the IT guy from Opscode here in Seattle. 
19:01:26 <clokep> Yeah, I saw you were having a few issues using HipChat.
19:01:45 <Hayfever76> That's it
19:02:20 <Hayfever76> Error Console shows one error but I'm not sure if it's relevant or not
19:02:23 <clokep> So...we've had people come in here before about some issues with HipChat, so it's possible that it: 1. Does something "wrong" and isn't really XMPP compliant, or that 2. We do something wrong and don't handle some properly or 3. Idk...I'm sure there's something else. :)
19:02:34 <clokep> Does it point to anything inside of an XMPP file?
19:02:35 <Hayfever76> Ha
19:02:39 <Hayfever76> yup
19:02:40 <clokep> (or socket.jsm, perhaps)
19:02:50 <clokep> It could be relevant then, maybe you can pastebin it for us?
19:03:43 <Hayfever76> bear with me... recovering windows user here... 
19:03:57 * clokep uses Windows. ;)
19:04:05 <Hayfever76> Oh, ok then!
19:04:27 <clokep> You're on Mac OS, right?
19:04:42 <Hayfever76> Where i work there's a lot of anti-Redmond talk... Yes, 10.8 OSX
19:06:06 <Hayfever76> Error: TypeError aPhotoNode.getElement(...) is null
19:06:07 <Hayfever76> Source File: resource:///modules/xmpp-xml.jsm
19:06:17 <Hayfever76> getting a ton of those
19:06:42 <flo-retina> there's a bug on file for that
19:06:46 <clokep> I think that happens when downloading the contact list.
19:06:48 * clokep filled it.
19:07:08 <flo-retina> https://bugzilla.mozilla.org/show_bug.cgi?id=905094
19:07:26 <flo-retina> clokep: no you didn't :-P.
19:07:30 * clokep was thinking of bug 1900.
19:07:34 <flo-retina> ah
19:07:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1900 min, --, ---, nobody, NEW, aPhotoNode.getElement(...) is null when connecting to LiveJournal
19:07:35 <flo-retina> sorry
19:07:38 <flo-retina> I just clicked that
19:07:44 <clokep> :P
19:08:31 <clokep> Hayfever76: The second comment on that bug says "FYI, I get this error too, and the effect *seems* to be that I cannot join a channel (I have it set to auto-join, but trying manually also seems to fail)."
19:08:51 <clokep> My guess is that we just need to add a null check.
19:08:56 <Hayfever76> Confirmed
19:09:08 <Hayfever76> I cannot connect to a channel
19:09:25 <Hayfever76> people I can chat with directly all day long and all the users in teh org show up fine
19:09:37 <Hayfever76> it's just 'rooms/channels/'
19:10:07 <clokep> Got it.
19:10:15 <clokep> Any chance you'd be willing to take a look at fixing this? :-D
19:10:32 <Hayfever76> sure... my code sucks but i'm happy to help. What do you need me to do?
19:11:15 <clokep> Would probably be hard unless you have a development environment. :(
19:11:15 <flo-retina> clokep: so the problem is that we receive a vcard that contains a <PHOTO> element but no TYPE?
19:11:22 <clokep> flo-retina: I think so.
19:11:32 <Hayfever76> THAT I can get you... got Visual Studio 2012 handy..
19:11:35 <flo-retina> so we should just drop it?
19:11:50 <flo-retina> Hayfever76: seems surprising on OS X ;)
19:12:02 <Hayfever76> I run bootcamp
19:12:15 <Hayfever76> and run Win7/Server 2012 in VM's
19:12:20 <Hayfever76> under Virtualbo
19:12:22 <Hayfever76> x
19:12:48 <Hayfever76> running VS under a mac is a bit challenging otherwise
19:12:51 <Hayfever76> :-)
19:13:20 <flo-retina> running VS under Windows is challenging too.
19:13:49 <Hayfever76> there is that...
19:14:13 <aleth> Hayfever76: Are you using TB?
19:14:25 <Hayfever76> Thunderchicken, yes!
19:14:26 * aleth wonders why Hayfever76 is seeing JS-XMPP errors at all
19:14:32 <aleth> OK.
19:14:49 <Hayfever76> saw the errors from the error console
19:15:10 <clokep> Yeah, TB is JS-XMPP only. :)
19:15:16 <aleth> Hayfever76: Sure, I only asked because on Instantbird the default XMPP is still provided by libpurple.
19:16:02 <Hayfever76> I am confused with that piece a bit. Can you differentiate Libpurple from pidgin? Pidgin is the client and libpurple is the core lib?
19:17:10 <Hayfever76> and for my build environment I'm configuring C, GLib and GTK+ libraries, yes?
19:17:11 <flo-retina> exactly!
19:17:23 <flo-retina> errr, not sure what the last question is asking
19:17:40 <clokep> I think something like http://pastebin.instantbird.com/361020 woudl work btw.
19:17:52 <Hayfever76> you guys asked if I had access to development tools - I assumed you'll want me to tweak, compile and test soemthing, yes?
19:18:25 <flo-retina> clokep: r=me
19:18:44 <Mook_as> so, if you need to hack on this js, for local testing you don't need a toolchain - should get you results faster
19:18:45 <flo-retina> Hayfever76: I think you'll be able to start at the "test something" part
19:19:09 <flo-retina> (assuming we check-in the patch soon, there will be a nightly tomorrow with it that you can try)
19:20:05 * clokep twiddles his thumbs.
19:20:17 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 2905 on bug 1900.
19:20:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1900 min, --, ---, clokep, ASSI, aPhotoNode.getElement(...) is null when connecting to LiveJournal
19:21:05 <Hayfever76> OK, cool, thanks, yeah hook me up..
19:21:29 <instantbot> florian@instantbird.org granted review for attachment 2905 on bug 1900.
19:22:22 <clokep> flo-retina: How hard is it to do a ib, c-c sync?
19:23:18 <flo-retina> clokep: with your moz24 patch: http://pastebin.instantbird.com/361031
19:23:31 <flo-retina> clokep: not hard. Just boring.
19:23:45 <clokep> flo-retina: Well I'm bored. ;)
19:23:54 <flo-retina> ah, good to know
19:26:50 <clokep> flo-retina: --disable-gamepad?
19:26:57 <flo-retina> is this something you did?
19:27:53 <clokep> I seem to have that in my mozconfig, yes.
19:28:03 <clokep> But that's because I don't have the DirectX SDK installed.
19:30:18 <instantbot> clokep@gmail.com set the Resolution field on bug 1900 to FIXED.
19:30:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1900 min, --, 1.5, clokep, RESO FIXED, aPhotoNode.getElement(...) is null when connecting to LiveJournal
19:30:42 <flo-retina> aaaaah, I guess we may be building with the wrong SDK
19:30:51 <flo-retina> we are still building with the OS X 10.6 SDK
19:30:57 <flo-retina> maybe Mozilla moved to something newer
19:31:28 <Hayfever76> what's my next step, gang? Connect at this same time tomorrow and see about getting the new file(s) ?
19:31:28 <flo-retina> there's no 'official' way to get the 10.6 SDK on OS X 10.8, I remember struggling with that, and finally rsync'ing it from an older build machine.
19:32:06 <flo-retina> Hayfever76: yeah, ensure clokep doesn't forget to do the checkin for that patch, and then see tomorrow if it works
19:32:20 <clokep> It's checked into Instantbird. :P
19:32:37 <instant-buildbot> build #461 of win32-onCommit is complete: Failure [failed compile]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/461  blamelist: Patrick Cloke <clokep@gmail.com>
19:32:37 <clokep> flo-retina: So can you describe the steps to me to do an ib, c-c sync again? I know I've asked you this but I seem to never write them down. :(
19:34:18 <flo-retina> clokep: I'd like to have diner first
19:34:27 <-- Suiseiseki has quit (Quit: Leaving)
19:34:34 <aleth> Hayfever76: Well, if you try it in Instantbird, you'll have to enable JS-XMPP first for the test to make sense.
19:34:54 <clokep> flo-retina: Sure, sure. I'm in no rush. :)
19:35:17 <flo-retina> aleth: I think he'll try in the next Daily
19:35:18 <aleth> Hayfever76: To check the fix works in TB, just open omni.ja and hand-edit xmpp.jsm :D
19:35:40 <flo-retina> aleth: it's not clear if clokep wants to sync chat/ before checking in the patch in c-c
19:35:42 <aleth> flo-retina: Oh, are you getting it checked in for TB immediately? OK then
19:35:50 <clokep> flo-retina: That was my plan, yes.
19:35:55 <Hayfever76> ok... trying now then
19:35:59 <flo-retina> c-c is closed :(
19:36:15 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/4ccdab9c316f - Patrick Cloke - Bug 1900 - aPhotoNode.getElement(...) is null when connecting to LiveJournal, r=fqueze.
19:36:15 <clokep> c-c is closed like 90% of the time. :(
19:36:22 <clokep> Thanks instantbot. :P
19:36:23 <flo-retina> clokep: that's a risky plan (as there will be plenty of other changes...)
19:36:40 <flo-retina> clokep: yeah, that makes me wonder if we _really_ want Ib to be developed off c-c :(
19:37:02 <clokep> flo-retina: Yeah...me too...
19:37:20 <clokep> If we can both do syncs it sholdn't be too bad. :)
19:37:36 <flo-retina> we could mostly automate it
19:37:50 <flo-retina> 'mostly' because some patches may require changes in mail/
19:38:39 <Hayfever76> omni.ja is a directory, yes?
19:38:59 <Mook_as> it's a zip file
19:39:09 <Hayfever76> Ahh, thanks
19:39:32 <Hayfever76> looking for the one under /Thunderbird.app?
19:39:41 <Mook_as> it used to be omni.jar, and then it started pretending to be the japanese localization so it gets saved by windows system restore :p
19:40:07 <Hayfever76> oh wow.. I'm on a mac... 
19:40:11 <Hayfever76> though
19:40:18 <clokep> It's the same file on all systems though.
19:40:22 <Mook_as> it was easier to keep the same name across platforms :)
19:40:30 <Hayfever76> yup
19:40:57 <clokep> Hayfever76: Was your plan to roll out TB + TB Chat to your entire set of people?
19:42:08 <Hayfever76> Maybe... was going to see if I could make it work and then sell it as an option. I work with a bunch of Linux guys so "rolling out" becomes more of a huge cat-herding operation - they wanna do their own thing.
19:42:20 <Hayfever76> :-)
19:42:40 <Hayfever76> but yeah, would love to get 50 - 100 users on this and save us a bunch of money
19:43:17 <Mook_as> cats should find birds tasty :D
19:43:17 <aleth> Offer Instantbird as an alternative? :P
19:44:00 <Hayfever76> why not... if I can get email, calendar and chat connected in one spiffy UI, then that cleans up the desktops
19:45:01 <clokep> :)
19:45:40 <Hayfever76> ok, so to recap, find the zip/tz file called omni.ja, open it, get the xmpp.jsm, make the changes you sent me in pastebin.... then what?
19:45:58 <Hayfever76> that zip may or may not be in the Thunderbird folder structure
19:46:03 <clokep> rezip it and start TB with --purge-caches or something.
19:46:06 <flo-retina> Thunderbird.app/Contents/MacOS/omni.ja
19:46:11 <flo-retina> -purgecaches
19:46:14 <Hayfever76> there we go, thanks
19:46:21 <Hayfever76> brb
19:52:55 <clokep> :)
19:53:10 --> FireFly_TB has joined #instantbird
19:53:19 <Hayfever76> btw, what do I need to use to zip/unzip that file with?
19:55:08 <aleth> Hayfever76: Some ZIP tools require you to change the extension to ZIP for some reason
19:55:43 <Hayfever76> found GUItar
19:56:04 <Hayfever76> the compression type is BZ2, yes?
19:56:34 <flo-retina> Hayfever76: I would just use 'zip' on the command line
19:56:36 <aleth> No, it's ZIP
19:59:29 <Mook_as> (pk)zip normally uses deflate
20:01:10 <flo-retina> pfff, still failing in Navigator.o :(
20:03:04 <flo-retina> clokep: alright, let's document this sync process
20:03:11 <flo-retina> a pad would be easier, right?
20:03:17 <instant-buildbot> build #470 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/470
20:03:24 <flo-retina> and then once you've successfully done it once, it can move to a wiki page
20:03:38 <clokep> flo-retina: Sounds like a good plan. :)
20:03:47 <flo-retina> clokep: https://etherpad.mozilla.org/c-c-chat-sync
20:05:08 <clokep> Thanks.
20:05:53 <clokep> flo-retina: I'm glad you named your folders identically to mine. :)
20:06:11 <flo-retina> my Instantbird folder is named hg.instantbird.org
20:06:18 <flo-retina> in ~/buildhg
20:06:29 <flo-retina> but I just tried to use something 'generic' for the documentation
20:07:26 <clokep> :)
20:08:26 <flo-retina> http://pastebin.instantbird.com/361076 :(
20:09:54 * clokep sighs. :(
20:09:57 <clokep> Clearly we have to port something.
20:10:04 <clokep> I didn't think there wer eany configure changes though...
20:13:11 <Hayfever76> hey, I have 2 versions of that xmpp file. Which one do I want? There's one in the /jsloader and one in the /modules folder?
20:14:47 <flo-retina> Mook_as: do you know what jsloader is? Is it a cache of pre-parsed files?
20:15:04 <flo-retina> clokep: I'll try again after removing the obj-dir from the previous attempts
20:15:06 <clokep> flo-retina: Step 6: Manually fix all the changesets that don't port properly? :P
20:17:16 <flo-retina> clokep: kindof :-P
20:22:17 <flo-retina> clokep: I think I'm done for the brain dump
20:22:29 <flo-retina> I haven't done this in a while, so it's very possible that I forgot a thing or two
20:23:10 <clokep> flo-retina: Thanks. :)
20:23:53 <clokep> Looks like c-c- might open soon.
20:25:55 <Hayfever76> OK, if I go into the /modules/xmpp.jsm file, it seems that there are 2 constants named XMPPAccountBuddyPrototype. which one do I fix? both of them?
20:27:22 <Hayfever76> ignore me
20:27:25 <Hayfever76> I can't read
20:27:43 <aleth> Hayfever76: http://hg.instantbird.org/instantbird/rev/4ccdab9c316f
20:28:39 <Hayfever76> Someone sent me this earlier.. http://pastebin.instantbird.com/361020
20:29:37 <Hayfever76> hey, I'm learning stuff today... and once again, I can't read... moving forward
20:29:50 <Hayfever76> now understanding the code to change
20:30:16 <flo-retina> do you have the patch command installed?
20:33:17 <Hayfever76> no
20:33:29 <Hayfever76> stock Mac install
20:34:59 <Hayfever76> quick question on the fix too. It reads like you're assigning 'type' a value twice once from .innertext element and once without it. Won't the second iteration overwrite the first?
20:35:10 <Hayfever76> -    let type = aPhotoNode.getElement(["TYPE"]).innerText;
20:35:10 <Hayfever76> +    // Some servers seem to send a photo node without a type declared.
20:35:10 <Hayfever76> +    let type = aPhotoNode.getElement(["TYPE"]);
20:35:10 <Hayfever76> +    if (!type)
20:35:10 <Hayfever76> +      return;
20:35:10 <Hayfever76> +    type = type.innerText;
20:38:48 <aleth> Hayfever76: If you look at the line that was removed, the reason that caused a problem is that sometimes aPhotoNode.getElement(["TYPE"]) does not return any element. So getting its innertext causes an error
20:39:23 <aleth> The new code ultimately puts the innertext in type, as you say the temporary value of type gets overwritten.
20:40:31 --> EionRobb has joined #instantbird
20:43:32 <Hayfever76> or is thanks!
20:44:00 <Hayfever76> red = removed.... 
20:44:08 <Hayfever76> I feel like a toddler today.
20:44:10 <Hayfever76>  holy crap
20:44:25 <Hayfever76> every noob mistake possible. Thanks for your patience
20:44:33 <aleth> The - and + should help too ;)
20:45:23 <aleth> You're looking at a diff between two versions of the same file. Diff files can be automatically applied (using patch for example), that's one of the benefits...
20:46:03 <aleth> It's a way to track the changes made.
20:47:59 <aleth> The point of this line '@@ -437,17 +437,21 @@ const XMPPAccountBuddyPrototype = {' is to tell you that the following snippet of code starts at line 437, and contains 17 lines before the change and 21 after
20:50:14 <flo-retina> clokep: after clobbering, I get the same error message that you had :)
20:50:22 <clokep> :(
20:50:27 <clokep> Wel maybe :)
20:50:30 <flo-retina> why ":("?
20:50:37 <flo-retina> it's nice that it's not Windows specific :)
20:51:40 <flo-retina> so now we just need to hmm... fix it :-|
20:51:48 <Mook_as> flo-retina: yeah, I think that's preparsed stuff
20:54:56 <flo-retina> clokep: this feels like we need at least the first change of http://hg.mozilla.org/releases/comm-release/rev/f3d345164ea8
20:56:17 * aleth wishes nhnt11 would add a bugzilla comment when uploading a new patch
20:56:58 <aleth> Or at least an interdiff...
20:57:52 <flo-retina> oh wait, I read this patch the wrong way
21:00:00 * flo-retina is confused. The code at http://hg.mozilla.org/releases/comm-release/annotate/tip/config/rules.mk#l131 is not what we have at http://lxr.instantbird.org/instantbird/source/config/rules.mk#88
21:00:23 <flo-retina> but the changeset that last changed it looks reversed: http://hg.mozilla.org/releases/comm-release/diff/f3d345164ea8/config/rules.mk
21:00:59 <clokep> :-S
21:01:13 <flo-retina> well, no, it's not reversed
21:01:18 <flo-retina> it's just "different"
21:01:24 <flo-retina> what's that game hg annotate is playing on me? :(
21:02:26 <-- Hayfever76 has quit (Quit: Hayfever76)
21:02:27 <flo-retina> ah
21:02:30 <flo-retina> I'm just tired
21:02:45 <flo-retina> the relevant change doesn't show up in annotate because it just *removed* a line
21:02:52 <flo-retina> clokep: http://hg.mozilla.org/releases/comm-release/rev/47d08a243bde#l2.1
21:03:15 --> Hayfever76 has joined #instantbird
21:03:24 <clokep> flo-retina: Ah, that's definitely it. :)
21:04:51 <flo-retina> just removing that line fixes your error
21:05:08 <clokep> :)
21:05:09 <clokep> Nice.
21:07:20 <flo-retina> clokep: http://pastebin.instantbird.com/361121 is all we need
21:07:26 <flo-retina> the build finishes successfully :)
21:07:36 <clokep> flo-retina: Cool. :)
21:07:41 <clokep> r=me for those changes?
21:07:50 <flo-retina> ok
21:08:00 <flo-retina> what's the next step?
21:08:11 <flo-retina> do we need to test mac universal builds, or are we feeling lucky?
21:08:25 <flo-retina> maybe I/we should check that make package works
21:08:31 <clokep> Hmm...that seems reasonable.
21:08:35 <clokep> I'm OK w/ feeling lucky. :P
21:09:00 <flo-retina> Warning: /Users/florian/buildhg/obj-instantbird-dbg/instantbird/installer/package-manifest:47: Missing file(s): /InstantbirdDebug.app/Contents/MacOS/.app/
21:09:40 <flo-retina> that's already in http://buildbot.instantbird.org/builders/macosx-onCommit/builds/470/steps/shell_1/logs/stdio so probably not a moz24 regression
21:09:46 <flo-retina> but it still seems scary
21:10:27 <flo-retina> ah no it's ok, it's just that we don't have e10s
21:12:24 <flo-retina> System JS : ERROR resource://gre/modules/ActivitiesService.jsm:41
21:12:24 <flo-retina>                      NS_ERROR_XPC_GS_RETURNED_FAILURE: Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]
21:14:24 --> flo-dbg has joined #instantbird
21:14:30 <flo-dbg> hello from moz24 :)
21:15:35 <flo-retina> "Failed to load native module at path '/Volumes/Instantbird/InstantbirdDebug.app/Contents/MacOS/components/libnull.dylib': (80004005) <unknown; can't get error from NSPR>"
21:15:50 <flo-retina> could just be that we don't package that file
21:15:52 <-- flo-dbg has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
21:16:33 --> florian has joined #instantbird
21:16:53 <florian> this is from the same build, but without packaging it
21:17:23 <-- florian has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
21:17:42 <flo-retina> I don't see any new warning in the console. No shutdown leak.
21:17:45 <flo-retina> I'm feeling lucky.
21:19:51 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 2906 on bug 2033.
21:19:53 <flo-retina> oh wait, should we also --disable-gamepad ?
21:19:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2033 nor, --, ---, clokep, ASSI, Update to Mozilla 24
21:20:57 <clokep> flo-retina: It should work on Windows, I think?
21:21:23 <instantbot> clokep@gmail.com granted review for attachment 2906 on bug 2033.
21:21:27 <flo-retina> well, it worked on Mac before that update
21:22:31 <flo-retina> hmm, my point about us using the 10.6 SDK doesn't even make sense, we use it only for univeral builds: http://lxr.instantbird.org/instantbird/source/build/macosx/universal/mozconfig.common#15 :-S
21:27:33 <-- FireFly_TB has quit (Ping timeout)
21:27:42 <-- Hayfever76 has quit (Ping timeout)
21:35:10 * flo-retina isn't sure what to do about it.
21:35:22 <clokep> Push and hope for the best and fix it while I'm gone? :P
21:35:32 <flo-retina> is it worth attempting to debug it? Or should we just --disable it in the mac mozconfigs?
21:35:42 <flo-retina> how long do you plan on being gone?
21:35:50 <flo-retina> (I guess it's "until it's fixed", but... :-P)
21:36:10 <clokep> :-D
21:39:31 <instantbot> aleth@instantbird.org denied review for attachment 2904 on bug 2143.
21:39:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2143 enh, --, ---, nhnt11, NEW, Stats service should maintain statistical data for conversations and use it for sorting.
21:39:52 <clokep> flo-retina: Is there any trick to figure out where the file failed?
21:40:00 <flo-retina> which file?
21:40:01 <clokep> I.e. patching twitter.js failed, but that's in the diff multiple times.
21:40:55 <flo-retina> what's the output?
21:41:03 <flo-retina> is there a .rej file lying around?
21:41:25 <clokep> Ah, I purged it.
21:41:27 <clokep> That would help. :)
21:41:50 --> Hayfever76 has joined #instantbird
21:46:30 <aleth> Hayfever76: did it work?
21:47:59 <flo-retina> my build error looks like some includes were messed up in Mozilla files
21:48:04 <flo-retina> *looked
21:48:28 <clokep> flo-retina: hg rollback keeps rolling back the pull I just did. :-S
21:48:55 <flo-retina> should we push the moz24 update without --disable-gamepad to see if the same error happens on the buildbot slave?
21:49:13 <flo-retina> clokep: why are you doing rollback if you haven't imported anything?
21:49:28 <clokep> flo-retina: It was after I attempted to import. :p
21:49:37 <clokep> flo-retina: That could make sense.
21:49:57 <flo-retina> is it the first changeset that failed to import?
21:50:01 <clokep> Yes.
21:50:04 <flo-retina> bah...
21:51:30 <EionRobb> gamepad control for an im client could be interesting
21:53:18 <-- qlum has quit (Connection reset by peer)
21:54:49 * clokep has a feeling that twitter is going to be very frustrating in this case.
21:55:30 <aleth> Maybe merge the Http.jsm changes to IB first and check nothing breaks?
21:56:29 <-- Hayfever76 has quit (Quit: Hayfever76)
21:57:37 <Mook_as> flo-retina: what's the error?
21:57:50 <flo-retina> Mook_as: http://pastebin.instantbird.com/361031
21:58:08 <Mook_as> yeah, I recall something like that... one minute please
21:59:29 <Mook_as> bug 885819?
22:03:31 <clokep> aleth: That won't help the changesets.
22:05:07 <flo-retina> Mook_as: oh great!
22:05:55 <flo-retina> what's --disable-media-navigator? Is it the same as disabling webrtc?
22:06:09 <Mook_as> I think it's, umm, getUserMedia or something?
22:06:13 <Mook_as> it's definitely related
22:06:51 * Mook_as is mildly amused that you're disabling webrtc, given your involvement... :D
22:07:11 <flo-retina> Mook_as: I don't think we are. That's why I'm asking!
22:09:24 <flo-retina> any idea of how we could unintentionaly disable that?
22:09:39 <flo-retina> I don't see anything obvious in http://lxr.instantbird.org/instantbird/source/instantbird/confvars.sh
22:09:53 <flo-retina> nor in http://lxr.instantbird.org/instantbird/source/mozconfig
22:10:15 <Mook_as> you don't have http://mxr.mozilla.org/mozilla-central/source/browser/confvars.sh#56
22:10:42 --> Suiseiseki has joined #instantbird
22:10:50 <Mook_as> yes, the *lack* of a random line...
22:10:58 <clokep> flo-retina, Mook_as: Do you know what "failed to synchronize metadata for <foo>" means when importing a patch?
22:11:29 <Mook_as> I would _guess_ it's failing to get author, date, or something along those lines, but I don't actually know
22:12:19 <flo-retina> clokep: likely means that you are butchering my last name :-P
22:12:34 <clokep> It happens when I tried to replace a whole hunk of a diff. :-/
22:13:01 <flo-retina> if your editor isn't correctly set to UTF8, saving the file could have changed unrelated stuff
22:13:06 <Mook_as> ah. your starting line numbers are busted?
22:13:14 <flo-retina> clokep: so any opinion on whether we should turn on webrtc or include Mook's patch?
22:13:39 <clokep> Mook_as: Does my editor support UTF8? :P
22:13:50 <flo-retina> ahah
22:13:52 <clokep> flo-retina: Which patch was this, sorry? :-(
22:13:56 <Mook_as> clokep: it internally works in utf8 :p
22:14:04 <Mook_as> (it converts back to whatever format on the way out)
22:14:08 <flo-retina> clokep: https://bugzilla.mozilla.org/show_bug.cgi?id=885819
22:14:20 <flo-retina> (it's the real fix for my compile error)
22:14:34 <flo-retina> but that error happens because we have unintentional not enabled webrtc
22:14:43 <flo-retina> *unintentionally
22:16:11 <clokep> Mook_as: Setting it to UTF-8 seems to have worked, yes.
22:16:21 <clokep> flo-retina: OK, let's enable it.
22:16:52 <clokep> If you're concerned that's changing too much at once....
22:16:56 <clokep> Then we can enable it next time. :)
22:17:02 <-- aleth has quit (Quit: Ciao)
22:18:59 <flo-retina> clokep: I'm a bit concerned that it's a significant change, yeah
22:19:16 <clokep> OK, then we'll take Mook_as' patch.
22:19:37 * flo-retina was going to add "but let's not take a patch we intend to backout a day later" :-D
22:20:02 <Mook_as> just drop the patch when you update beyond 24 :)
22:22:13 * clokep thinks Mook_as' plan sounds good.
22:23:07 <-- mconley has quit (Input/output error)
22:23:28 <flo-retina> so we take Mook's patch?
22:23:33 * flo-retina wants to do the checkin and go to bed
22:26:49 <flo-retina> clokep: I should have hg rm'ed instantbird/test/xpcshell.ini in the patch I attached on the bug
22:26:57 <flo-retina> can I keep your r+ with that change? :)
22:26:59 --> mconley has joined #instantbird
22:27:00 <clokep> flo-retina: yes. :)
22:27:03 <clokep> Yes.
22:27:05 <clokep> To both.
22:27:29 <flo-retina> sorry for being slow tonight :-/
22:30:53 <clokep> No problem.
22:30:56 <clokep> Sorry for being distracted. :)
22:31:15 <flo-retina> pushed!
22:33:42 <clokep> :)
22:33:44 <clokep> I'll close the bugs.
22:34:00 <flo-retina> alright, assuming the waterfall is green tomorrow, it looks like that was a relatively easy update :)
22:34:30 <flo-retina> although the moz23 update was the easiest update ever (wasn't it), and it ended up busting our builds for weeks :-P.
22:34:30 <clokep> :)
22:34:40 <clokep> And they're still semi-bustd. :-/
22:35:31 <-- mconley has quit (Input/output error)
22:36:24 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/cd83ea0d02c0 - Patrick Cloke - Bug 2033 - Update to Mozilla 24, r=fqueze.
22:36:25 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/14a2daa89438 - Florian Quèze - Bug 2033 - Update to Mozilla 24 - include the patch from 'Bug 885819 - Navigator.cpp build failure with --disable-media-navigator --enable-gamepad'.
22:36:26 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/ea513e7129a4 - Florian Quèze - Bug 2033 - Update to Mozilla 24 - port 'Bug 869635 - Eliminate the master xpcshell manifest', r=clokep.
22:37:53 <instant-buildbot> build #471 of macosx-onCommit is complete: Failure [failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/471  blamelist: Florian Qu?ze <florian@instantbird.org>, Patrick Cloke <clokep@gmail.com>
22:38:02 <instantbot> clokep@gmail.com set the Resolution field on bug 2033 to FIXED.
22:38:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2033 nor, --, 1.5, clokep, RESO FIXED, Update to Mozilla 24
22:50:51 <-- EionRobb has quit (Connection reset by peer)
22:50:58 --> EionRobb has joined #instantbird
22:56:59 --> FireFly_TB has joined #instantbird
22:59:33 <-- FireFly_TB has quit (Ping timeout)
23:01:56 <instant-buildbot> build #462 of win32-onCommit is complete: Failure [failed compile]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/462  blamelist: Florian Qu?ze <florian@instantbird.org>, Patrick Cloke <clokep@gmail.com>
23:03:20 <clokep> Anyone alive in here? :)
23:04:52 <flo-retina> Mook_as: is "d:/bb-slave/win32/build/mozilla/config/baseconfig.mk:20: *** Windows-style srcdir being used with GNU make. Did you mean to run d:/bb-slave/win32/build/mozilla/build/pymake/make.py instead? [see-also:     https://developer.mozilla.org/en/Gmake_vs._Pymake].  Stop." familiar?
23:05:06 <Mook_as> yes. why is it not running pymake?
23:05:19 <Mook_as> gnu make basically doesn't work anymore :(
23:05:27 <clokep> flo-retina: At some point they FORCED the switch to pymake.
23:06:01 <flo-retina> the mac error looks like we just need a clobber
23:06:09 <flo-retina> Mook_as: so what broke it?
23:06:35 <flo-retina> Mook_as: last time we tried pymake, it didn't work on some of our makefiles
23:06:49 <Mook_as> no idea. would have expected it to die in a previous attempt.
23:07:04 <Mook_as> these days it's basically "mach and hope it works" :|
23:07:15 <flo-retina> clokep: 110?!? :-D
23:07:27 <clokep> flo-retina: Yes...any tricks on finding which might need UI changes.
23:07:50 <flo-retina> clokep: human review :(
23:08:05 <clokep> Yeah. I'm doing that now...
23:08:13 <flo-retina> last time I put the list in a pad, and we went through the list with aleth and you IIRC.
23:08:39 <flo-retina> it's easy to exclude the changes related to IRC/Yahoo
23:09:19 <flo-retina> and then when in doubt, we just need to go look at the original bug
23:10:38 <clokep> Yes. :)
23:10:42 <clokep> That's my hope!
23:11:07 <flo-retina> so it looks like we are going to not have Windows nightlies again for a while :(
23:11:08 <clokep> https://etherpad.mozilla.org/ib-c-c-merge-6
23:11:14 <flo-retina> if we need to get pymake fixed
23:12:11 <flo-retina> https://bugzilla.mozilla.org/show_bug.cgi?id=716235 is one of the blockers for using pymake
23:13:47 <flo-retina> well, or we can just throw Even's patch in our tools/patches/ folder :-P
23:14:21 <Mook_as> or cheat and dos2unix client.mk and see what breaks :p
23:15:42 --> mconley has joined #instantbird
23:16:04 <flo-retina> Mook_as: why would that help?
23:16:59 <Mook_as> oh, right, it's the path, not the line endings (any more)
23:17:06 <Mook_as> I was thinking of a different check, sorry
23:34:04 <instant-buildbot> build #471 of linux-onCommit is complete: Failure [failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/471  blamelist: Florian Qu?ze <florian@instantbird.org>, Patrick Cloke <clokep@gmail.com>
23:43:58 --> Tonnes has joined #instantbird
23:51:11 <-- mconley has quit (Input/output error)
23:52:21 <flo-retina> cool, a different error on Linux, that seems real too :-/.
23:52:37 <clokep> Aren't you supposed to sleep?
23:53:08 <flo-retina> I think so.